Timeline



Mar 23, 2006:

11:17 PM Changeset in webkit [13469] by darin
  • 2 edits in trunk/WebKitSite

Reviewed by Darin.

  • coding/coding-style.html: Changed &emdash; to —.
11:15 PM Changeset in webkit [13468] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • bindings/jni_jsobject.cpp: (JavaJSObject::convertJObjectToValue): Was trying to retrieve the native pointer from the wrong base class, and the GetFieldID was using the wrong signature.
11:07 PM Changeset in webkit [13467] by darin
  • 10 edits in trunk/WebCore

Reviewed by Adele.

  • fix <rdar://problem/4484787> KWQAccObject dangles under GC
  • kwq/AccessibilityObjectCache.h: Moved AccessibilityObjectCache into the WebCore namespace. Renamed accObject to get, removed setAccObject, renamed removeAccObject to remove, removed getAccObjectID, renamed removeAXObjectID to removeAXID, change from CF dictionaries to HashMap and HashSet.
  • kwq/AccessibilityObjectCache.mm: (WebCore::AccessibilityObjectCache::~AccessibilityObjectCache): Detach all objects and call CFRelease on all of them. (WebCore::AccessibilityObjectCache::get): Call CFRetain on objects before putting them in the HashMap, rather than assuming that retain == CFRetain. This is what fixes the GC issue. (WebCore::AccessibilityObjectCache::remove): Detach and call CFRelease when removing. (WebCore::AccessibilityObjectCache::getAXID): Change to use a single global variable for the AXIDs, which makes it so we won't reuse the same AXID as much as we did before. (WebCore::AccessibilityObjectCache::removeAXID): Updated to use HashSet. (WebCore::AccessibilityObjectCache::textMarkerForVisiblePosition): Updated for other changes. (WebCore::AccessibilityObjectCache::visiblePositionForTextMarker): Ditto. (WebCore::AccessibilityObjectCache::childrenChanged): Ditto. (WebCore::AccessibilityObjectCache::postNotificationToTopWebArea): Ditto. (WebCore::AccessibilityObjectCache::postNotification): Ditto.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge accessibilityTree]): Change to use functions by new names.
  • dom/Document.h: AccessibilityObjectCache is now in the WebCore namespace. getAccObjectCache and ownerElement are const member functions, and m_accCache is a mutable data member.
  • dom/Document.cpp: (WebCore::Document::getAccObjectCache): Make const. (WebCore::Document::ownerElement): Make const.
  • kwq/WebCoreAXObject.h: Changed WebCoreAXID to WebCore::AXID.
  • kwq/WebCoreAXObject.mm: (-[WebCoreAXObject anchorElement]): Update for function name change. (-[WebCoreAXObject firstChild]): Ditto. (-[WebCoreAXObject lastChild]): Ditto. (-[WebCoreAXObject previousSibling]): Ditto. (-[WebCoreAXObject nextSibling]): Ditto. (-[WebCoreAXObject parentObject]): Ditto. (-[WebCoreAXObject accessibilityAttributeValue:]): Ditto. (-[WebCoreAXObject doAXUIElementForTextMarker:]): Ditto. (AXLinkElementForNode): Ditto. (AXAttributedStringAppendReplaced): Ditto. (-[WebCoreAXObject accessibilityHitTest:]): Ditto. (-[WebCoreAXObject _accessibilityParentForSubview:]): Ditto. (-[WebCoreAXObject accessibilityFocusedUIElement]): Ditto. (-[WebCoreAXObject axObjectID]): Change field name to m_id. (-[WebCoreAXObject setAXObjectID:]): Ditto. (-[WebCoreAXObject removeAXObjectID]): Ditto.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): Remove ifdefs. (WebCore::RenderContainer::appendChildNode): Ditto. (WebCore::RenderContainer::insertChildNode): Ditto.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::remove): Ditto.
11:05 PM Changeset in webkit [13466] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • fix buildbot
10:28 PM Changeset in webkit [13465] by darin
  • 23 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

  • kjs/object.h: Take function name, as well as source URL and line number, when using the special overloaded construct for making functions.
  • kjs/object.cpp: (KJS::JSObject::construct): Ditto.
  • kjs/function_object.h: Ditto.
  • kjs/function_object.cpp: (FunctionObjectImp::construct): Pass a name when constructing the function rather than null. Use "anonymous" when making a function using the default function constructor.
  • kjs/nodes2string.cpp: (FuncDeclNode::streamTo): Put a line break just before a function declaration.
  • unrelated fix
  • kxmlcore/HashMapPtrSpec.h: Add missing needed friend declaration.

LayoutTests:

  • fast/js/resources/function-names.js: Added.
  • fast/js/function-names.html: Generated.
  • fast/js/function-names-expected.txt: Generated.

WebCore:

Reviewed by Maciej.

Test: fast/js/function-names.html

  • dom/Document.h: Add function name parameter to createHTMLEventListener.
  • dom/Document.cpp: (WebCore::Document::createHTMLEventListener): Pass function name when calling createHTMLEventHandler. (WebCore::Document::setHTMLWindowEventListener): Pass attribute name as function name when calling createHTMLEventListener.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::setHTMLEventListener): Pass attribute name as function name when calling createHTMLEventListener.
  • khtml/ecma/kjs_events.h: Add a function name parameter to JSLazyEventListener.
  • khtml/ecma/kjs_events.cpp: (KJS::JSLazyEventListener::JSLazyEventListener): Take and store a function name. (KJS::JSLazyEventListener::parseCode): Pass function name when constructing the function.
  • khtml/ecma/kjs_proxy.h: Add a function name parameter to createHTMLEventHandler and createSVGEventHandler.
  • khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxy::createHTMLEventHandler): Pass function name when creating a JSLazyEventListener. (WebCore::KJSProxy::createSVGEventHandler): Ditto.
  • ksvg2/events/JSSVGLazyEventListener.h: Add a function name parameter to JSSVGLazyEventListener.
  • ksvg2/events/JSSVGLazyEventListener.cpp: (WebCore::JSSVGLazyEventListener::JSSVGLazyEventListener): Pass the function name on to the base class constructor.
  • ksvg2/misc/SVGDocumentExtensions.h: Add function name parameter to createSVGEventListener.
  • ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::createSVGEventListener): Pass function name when calling createSVGEventHandler.
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::addSVGEventListener):
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::addSVGWindowEventListner): Pass attribute name as function name when calling createSVGEventListener.
  • WebCore.xcodeproj/project.pbxproj: Moved generation script to the top.
5:51 PM Changeset in webkit [13464] by tomernic
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Layout test for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7691>

  • fast/forms/button-default-title-expected.checksum: Added.
  • fast/forms/button-default-title-expected.png: Added.
  • fast/forms/button-default-title-expected.txt: Added.
  • fast/forms/button-default-title.html: Added.

WebCore:

Reviewed by Darin.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7691>
REGRESSION: imdb.com search button looks wrong because "Submit" is drawn

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueWithDefault): Only use the default button title if no title was specified; previously we'd use the default button title if the specified title was empty, which is not what Firefox does.
5:20 PM Changeset in webkit [13463] by darin
  • 14 edits in trunk/LayoutTests
  • removed merge artifacts from .checksum files
  • fast/block/float/vertical-move-relayout-expected.checksum:
  • fast/css/first-letter-detach-expected.checksum:
  • fast/css/hover-subselector-expected.checksum:
  • fast/dom/Element/class-attribute-whitespace-expected.checksum:
  • fast/events/event-sender-mouse-moved-expected.checksum:
  • fast/forms/form-hides-table-expected.checksum:
  • fast/invalid/missing-address-end-tag-expected.checksum:
  • fast/invalid/missing-dl-end-tag-expected.checksum:
  • fast/invalid/missing-dt-end-tag-expected.checksum:
  • fast/invalid/missing-font-end-tag-expected.checksum:
  • fast/text/in-rendered-text-rtl-expected.checksum:
  • fast/tokenizer/missing-title-end-tag-1-expected.checksum:
  • fast/tokenizer/missing-title-end-tag-2-expected.checksum:
5:08 PM Changeset in webkit [13462] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Beth.

  • test for <rdar://problem/4335038> REGRESSION: when max-height is none, height value is ignored
  • fast/css/max-height-none-expected.checksum: Added.
  • fast/css/max-height-none-expected.txt: Added.
  • fast/css/max-height-none.html: Added.
  • fast/css/max-height-none-expected.png: Added.

WebCore:

Reviewed by Beth.

  • fix <rdar://problem/4335038> REGRESSION: when max-height is none, height value is ignored
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): For max-height of none, set it to Length(undefinedLength, Fixed), which is the correct value (same as the default). Also did some formatting fixes to the height section.
2:44 PM Changeset in webkit [13461] by bdakin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed, tweaked, and landed by Beth.

Test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6431

2:27 PM Changeset in webkit [13460] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Darin

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6431
REGRESSION: style change where :hover changes only an :after style
doesn't work

  • dom/Node.cpp: (WebCore::Node::diff): Need to call diff() on the before and after styles if we have them.
2:07 PM Changeset in webkit [13459] by tomernic
  • 4 edits in trunk/WebKit

Reviewed by John Sullivan.

At John's suggestion, renamed a private WebFrame method and tightened up some of the redirect logic I recently touched.

  • WebView/WebFramePrivate.h: Renamed -_clientRedirectCancelled: to -_clientRedirectCancelledOrFinished:, since we call this both when a redirect is cancelled and when a redirect is successfully committed.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge reportClientRedirectCancelled:]): Call renamed WebFrame method.
  • WebView/WebFrame.m: Added sentRedirectNotification flag to WebFramePrivate. This flag is set when we notify the frame load delegate that a redirect will occur. We check this flag when committing a provisional load to ensure that the frame load delegate is notified that the redirect finished. (-[WebFrame _commitProvisionalLoad:]): After committing a provisional load, make sure that the frame load delegate is notified that there is no longer a pending redirect. (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): Set the new sentRedirectNotification flag. (-[WebFrame _clientRedirectCancelledOrFinished:]): Renamed method. Clear the sentRedirectNotification flag. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Call renamed method.
1:58 PM Changeset in webkit [13458] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Added:

  • fast/forms/button-table-styles.txt: Added.
  • fast/forms/button-table-styles.png: Added.
  • fast/forms/button-table-styles.checksum: Added.
  • fast/forms/button-table-styles.html: Added.

WebCore:

Reviewed by Hyatt.

Test:
fast/forms/button-table-styles.html

  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): The theme should disallow table display styles form elements.
1:28 PM Changeset in webkit [13457] by tomernic
  • 1 edit in trunk/WebKit/ChangeLog

Corrected the date on my previous ChangeLog entry for 4439752.
Also moved to the top of the file (merge problem).

1:17 PM Changeset in webkit [13456] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Eric.

  • fix <rdar://problem/4380465> repro crash when unsuccessfully attempting to import image from Services menu
  • WebView/WebDataSource.m: (-[WebDataSource _imageElementWithImageResource:]): Quietly do nothing if passed nil. (-[WebDataSource _documentFragmentWithImageResource:]): Ditto.
8:31 AM Changeset in webkit [13455] by darin
  • 12 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • bindings/c/c_utility.h: Remove NPN_UTF16FromString declaration (not implemented).
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant): Use DOUBLE_TO_NPVARIANT, BOOLEAN_TO_NPVARIANT, VOID_TO_NPVARIANT, NULL_TO_NPVARIANT, and OBJECT_TO_NPVARIANT. In the case of OBJECT, call _NPN_RetainObject in one case and remove a _NPN_ReleaseObject in another because this should return a retained value. (KJS::Bindings::convertNPVariantToValue): Use NPVARIANT_TO_BOOLEAN, NPVARIANT_TO_INT32, and NPVARIANT_TO_DOUBLE.
  • bindings/c/c_runtime.h: Removed implementations of CMethod::name and CField::name that called _NPN_UTF8FromIdentifier and hence leaked.
  • bindings/c/c_runtime.cpp: (KJS::Bindings::CMethod::name): Added. Returns the string from inside the method object. (KJS::Bindings::CField::name): Added. Returns the string from inside the field object. (KJS::Bindings::CField::valueFromInstance): Added call to _NPN_ReleaseVariantValue on the result of getProperty after using it to fix a storage leak. (KJS::Bindings::CField::setValueToInstance): Added call to _NPN_ReleaseVariantValue after pasing a value to setProperty now that the conversion function does a retain.
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::invokeMethod): Changed to use Vector for a local stack buffer. Removed special case for NPVARIANT_IS_VOID because the convertNPVariantToValue function handles that properly. (KJS::Bindings::CInstance::invokeDefaultMethod): Ditto.
  • bindings/NP_jsobject.h: Formatting changes only.
  • bindings/NP_jsobject.cpp: (jsDeallocate): Changed parameter type so we don't need a function cast. (_NPN_InvokeDefault): Use VOID_TO_NPVARIANT. (_NPN_Invoke): Use NULL_TO_NPVARIANT and VOID_TO_NPVARIANT. (_NPN_Evaluate): Use VOID_TO_NPVARIANT. (_NPN_GetProperty): Use NULL_TO_NPVARIANT and VOID_TO_NPVARIANT.
  • bindings/c/c_class.cpp: Formatting changes only.
  • bindings/c/c_class.h: Formatting changes only.
  • bindings/npruntime_priv.h: Removed obsolete and now-unused functions: NPN_VariantIsVoid, NPN_VariantIsNull, NPN_VariantIsUndefined, NPN_VariantIsBool, NPN_VariantIsInt32, NPN_VariantIsDouble, NPN_VariantIsString, NPN_VariantIsObject, NPN_VariantToBool, NPN_VariantToInt32, NPN_VariantToDouble, NPN_VariantToString, NPN_VariantToStringCopy, NPN_VariantToObject, NPN_InitializeVariantAsVoid, NPN_InitializeVariantAsNull, NPN_InitializeVariantAsUndefined, NPN_InitializeVariantWithBool, NPN_InitializeVariantWithInt32, NPN_InitializeVariantWithDouble, NPN_InitializeVariantWithString, NPN_InitializeVariantWithObject, and NPN_InitializeVariantWithVariant.
  • bindings/npruntime.cpp: (getIntIdentifierDictionary): Don't bother creating custom callbacks for the integer dictionary since the default behavior is fine for integers.
8:08 AM Changeset in webkit [13454] by darin
  • 2 edits in trunk/WebCore
  • generate-derived-sources: Tweaked formatting a tiny bit and removed a stray touch that was left in here.
7:36 AM Changeset in webkit [13453] by darin
  • 2 edits in trunk/WebKit

Reviewed by Eric.

  • fix <rdar://problem/4380465> repro crash when unsuccessfully attempting to import image from Services menu
  • WebView/WebDataSource.m: (-[WebDataSource _imageElementWithImageResource:]): Quietly do nothing if passed nil. (-[WebDataSource _documentFragmentWithImageResource:]): Ditto.
12:21 AM Changeset in webkit [13452] by eseidel
  • 3 edits in trunk/WebCore

2006-03-23 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

REGRESSION: Dashed borders paint with the wrong phase
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7879

Test: Already covered by css1/box_properties/border_style.html

  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLine):
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLine):

Mar 22, 2006:

10:30 PM Changeset in webkit [13451] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.


  • generate-derived-sources: Suppress warning.
10:13 PM Changeset in webkit [13450] by mjs
  • 2 edits in trunk/WebCore
  • generate-derived-sources: Added.
10:03 PM Changeset in webkit [13449] by mjs
  • 9 edits
    1 add
    4 deletes in trunk/WebCore

Reviewed by Eric.


Handle dependencies for derived sources properly.

  • Made a new generate-derived-sources script that does all the depedency checking and source generation.
  • Put this script in a subtarget instead of a phase.
  • Made derived sources go in the build root, not a source root.
  • Added derived sources to the project.
  • Removed files whose sole purpose was to include and compile derived sources, just compile those directly for now.
  • Tweaked the IDL code generator so it can handle one IDL at a time, to make it easier to get the dependencies right.


  • generate-derived-sources: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMCore.cpp: Removed.
  • bindings/js/JSDOMEvents.cpp: Removed.
  • bindings/js/JSDOMHTML.cpp: Removed.
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/generate-bindings.pl:
  • css/UserAgentStyleSheets.cpp: Removed.
  • dom/Range.cpp: (WebCore::Range::~Range):
  • dom/Range.h:
  • khtml/ecma/kjs_css.cpp: (KJS::DOMStyleSheet::DOMStyleSheet): (KJS::DOMStyleSheetList::DOMStyleSheetList): (KJS::DOMCSSRuleList::DOMCSSRuleList): (KJS::DOMCSSRule::DOMCSSRule):
  • khtml/ecma/kjs_css.h:
9:46 PM Changeset in webkit [13448] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed and landed by Maciej.

  • generate-derived-sources: Handle generated header named either grammar.cpp.h or grammar.hpp.
5:37 PM Changeset in webkit [13447] by justing
  • 4 edits
    5 adds
    1 delete in trunk

LayoutTests:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7904>
Avoid a layout after test insertion and remove isProbablyBlock


Added:

  • editing/pasteboard/display-block-on-spans-expected.txt: Added.
  • editing/pasteboard/display-block-on-spans-expected.png: Added.
  • editing/pasteboard/display-block-on-spans-expected.checksum: Added.
  • editing/pasteboard/display-block-on-spans.html: Added.


I'm disabling this layout test because of 7899:

  • editing/pasteboard/paste-empty-startcontainer.html

WebCore:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7904>
Avoid a layout after test insertion and remove isProbablyBlock

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplacementFragment::~ReplacementFragment): (WebCore::ReplacementFragment::firstChild): (WebCore::ReplacementFragment::lastChild): (WebCore::ReplacementFragment::mergeStartNode): (WebCore::ReplacementFragment::enclosingBlock): (WebCore::ReplacementFragment::insertFragmentForTestRendering): (WebCore::ReplacementFragment::computeAndStoreNodeStyles): (WebCore::ReplacementFragment::removeUnrenderedNodes): (WebCore::ReplacementFragment::renderedBlocks): (WebCore::ReplacementFragment::removeStyleNodes): (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.h: (WebCore::ReplacementFragment::root):
5:31 PM Changeset in webkit [13446] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker.

Even better fix for <rdar://problem/4432562>. We need to notify the frame delegate of a finished redirect for both
"fast" and "slow" redirects, after committing the load. My previous change only notified for "fast", history-locking
redirects. Now we notify the frame delegate after committing any kind of provisional load, not just in the case of
a fast redirect.

  • WebView/WebFrame.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _commitProvisionalLoad:]):
5:21 PM Changeset in webkit [13445] by eseidel
  • 3 edits
    2 adds in trunk

2006-03-22 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix attribute mutation events to not fire for "style" attributes.
We lazily update style attributes, so sending mutation events for them makes no sense anymore.
<rdar://problem/4474910> repro assertion failure @ apple.com/store: !eventDispatchForbidden()

Test: fast/events/delayed-style-mutation-event-crash.html

  • dom/dom_elementimpl.cpp: (WebCore::Element::dispatchAttrRemovalEvent): add assert (WebCore::Element::dispatchAttrAdditionEvent): add assert (WebCore::NamedAttrMap::addAttribute):
3:37 PM Changeset in webkit [13444] by eseidel
  • 18 edits in trunk/WebCore

2006-03-22 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Remove more DeprecatedString usage.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7882

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString): (WebCore::FrameMac::fontForSelection): (WebCore::FrameMac::tokenizerProcessedData): (WebCore::FrameMac::registerCommandForUndoOrRedo): (WebCore::FrameMac::markMisspellings): (WebCore::FrameMac::respondToChangedSelection): (WebCore::FrameMac::dashboardRegionsDictionary): (WebCore::FrameMac::dragSourceMovedTo):
  • css/CSSGrammar.y:
  • css/css_valueimpl.h:
  • css/cssparser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::validUnit): (WebCore::CSSParser::parseShorthand): (WebCore::CSSParser::parseContent): (WebCore::skipCommaInDashboardRegion): (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseShape): (WebCore::CSSParser::parseFont): (WebCore::CSSParser::parseFontFamily): (WebCore::CSSParser::parseColorFromValue): (WebCore::yyerror): (WebCore::CSSParser::lex): (WebCore::CSSParser::text):
  • css/cssparser.h: (WebCore::deprecatedString):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMDocument::getValueProperty):
  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
  • ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::parseMappedAttribute):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutPositionedObjects): (WebCore::RenderBlock::positionNewFloats): (WebCore::RenderBlock::newLine):
  • rendering/RenderCanvas.cpp: (WebCore::RenderCanvas::absolutePosition): (WebCore::RenderCanvas::paint):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
  • rendering/RenderObject.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderLine): (WebCore::RenderBlock::layoutInlineChildren):
  • rendering/render_form.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
  • rendering/render_style.h: (WebCore::RenderStyle::setDashboardRegion):
  • rendering/table_layout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::insertSpanCell): (WebCore::AutoTableLayout::layout): (WebCore::AutoTableLayout::calcPercentages):
3:33 PM Changeset in webkit [13443] by bdakin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Hyatt

Layout text for <rdar://problem/4471984> repro crash CSS position
for html/table=relative causes crash when hiding table

2:42 PM Changeset in webkit [13442] by mjs
  • 2 edits in trunk/JavaScriptCore
  • fix the build
2:30 PM Changeset in webkit [13441] by tomernic
  • 5 edits
    4 adds in trunk

WebCore:

Reviewed by Kevin Decker.

Part of <rdar://problem/4351664> REGRESSION (420+): extra URL in b/f list - navigating back to previous page fails at apple.com/retail/)
This also fixes <rdar://problem/4477821> REGRESSION (10.4.5-TOT): meta tag specifying refresh is being added to history.

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: Removed redirectionTimerFired(). This was added as attempt to fix <​http://bugzilla.opendarwin.org/show_bug.cgi?id=7058>. The aim was to cause Safari and WebKit to update their loading status after a redirect. Unfortunately, the fix had a bad side effect. Calling -reportClientRedirectCancelled: on a successful redirect causes WebKit to forget that the redirect was supposed to lock history (i.e. reuse the current back/forward entry for the new page). The end result was that intermediate "quick" redirects were creating back/forward entries when they should not have been. See 4351664. That fix was almost correct, in that we do need to notify the frame load delegate when a redirect ends, either because it succeeded or because it was cancelled. However, this is the wrong place to do it. WebCore's redirect notification logic did not need to change to fix 7058. The never-ending spinning indicators problem was actually caused by a bug at the WebKit level.
  • manual-tests/redirectHistory: Added.
  • manual-tests/redirectHistory/redir-1.html: Added.
  • manual-tests/redirectHistory/redir-2.html: Added.
  • manual-tests/redirectHistory/redir-3.html: Added. Manual test case. I couldn't figure out how to create a layout test for this, because it involves navigation through history and it was unclear how/when to tell DumpRenderTree to dump its output.

WebKit:

Reviewed by Kevin Decker.

Better fix for <rdar://problem/4432562> REGRESSION (TOT): Safari's "stop loading" active, "view source" inactive after page load [7058]

  • WebView/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Cancel the client redirect when we commit the provisional load, if we were waiting for a redirect. This is a better fix for 7058 (<rdar://problem/4432562>). The original fix for 7058 changed the timing of the redirect cancel in such a way that WebKit was precluded from ever reusing back/forward list entries for redirects. Clearing the redirect state here actually makes logical sense, as the redirect's target page is being committed at this point.
2:27 PM Changeset in webkit [13440] by eseidel
  • 57 edits in trunk/WebCore

2006-03-22 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Replace more DeprecatedString with String.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7907

  • WebCore+SVG/kdom.h:
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
  • bridge/BrowserExtension.h:
  • bridge/mac/BrowserExtensionMac.h:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::setTypedIconURL):
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::searchForLabelsBeforeElement): (WebCore::nsArray): (WebCore::FrameMac::createPlugin): (WebCore::FrameMac::bindingRootObject): (WebCore::FrameMac::windowScriptObject): (WebCore::FrameMac::windowScriptNPObject): (WebCore::FrameMac::partClearedInBegin): (WebCore::FrameMac::openURLFromPageCache):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): (-[WebCoreFrameBridge scrollToAnchor:]): (-[WebCoreFrameBridge URLWithAttributeString:]): (-[WebCoreFrameBridge highlightAllMatchesForString:caseSensitive:]):
  • bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]):
  • bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings _updateAllViews]): (-[WebCoreSettings setStandardFontFamily:]): (-[WebCoreSettings setMinimumFontSize:]): (-[WebCoreSettings setMinimumLogicalFontSize:]): (-[WebCoreSettings setDefaultFontSize:]): (-[WebCoreSettings setDefaultFixedFontSize:]): (-[WebCoreSettings setUserStyleSheetLocation:]):
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSGrammar.y:
  • css/css_stylesheetimpl.cpp: (WebCore::MediaList::setMediaText):
  • css/css_valueimpl.cpp: (WebCore::quoteStringIfNeeded):
  • css/cssparser.cpp: (WebCore::CSSParser::parseColor):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector):
  • css/cssstyleselector.h:
  • dom/Document.cpp: (WebCore::Document::resetActiveLinkColor): (WebCore::Document::nextState): (WebCore::Document::setUserStyleSheet): (WebCore::Document::processHttpEquiv): (WebCore::Document::recalcStyleSelector):
  • dom/Document.h: (WebCore::Document::userStyleSheet): (WebCore::Document::setPrintStyleSheet): (WebCore::Document::printStyleSheet):
  • editing/markup.cpp: (WebCore::createMarkup): (WebCore::createFragmentFromMarkup): (WebCore::createFragmentFromText):
  • editing/markup.h:
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler):
  • html/html_baseimpl.cpp: (WebCore::HTMLFrameElement::openURL): (WebCore::HTMLFrameElement::attach):
  • html/html_headimpl.cpp: (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::setStyleSheet):
  • html/html_headimpl.h:
  • html/html_imageimpl.cpp: (WebCore::HTMLImageElement::parseMappedAttribute):
  • html/html_imageimpl.h: (WebCore::HTMLImageElement::compositeOperator):
  • html/html_objectimpl.cpp: (WebCore::HTMLAppletElement::createRenderer):
  • ksvg2/svg/SVGStringList.cpp: (SVGStringList::reset):
  • kwq/AccessibilityObjectCache.h:
  • kwq/AccessibilityObjectCache.mm: (AccessibilityObjectCache::textMarkerForVisiblePosition): (AccessibilityObjectCache::postNotificationToTopWebArea): (AccessibilityObjectCache::postNotification):
  • kwq/ClipboardMac.mm: (WebCore::cocoaTypeFromMIMEType):
  • kwq/KWQKHTMLSettings.h: (KHTMLSettings::userStyleSheetLocation): (KHTMLSettings::setUserStyleSheetLocation):
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (QLineEdit::selectedText):
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::ref):
  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::setStyleSheet): (WebCore::Frame::jScriptEnabled): (WebCore::Frame::javaEnabled): (WebCore::Frame::pluginsEnabled): (WebCore::Frame::receivedFirstData): (WebCore::Frame::begin): (WebCore::Frame::setUserStyleSheet): (WebCore::Frame::requestObject): (WebCore::Frame::loadPlugin): (WebCore::Frame::referrer): (WebCore::Frame::lastModified): (WebCore::Frame::reparseConfiguration): (WebCore::Frame::handleMousePressEventSingleClick): (WebCore::Frame::appliedEditing): (WebCore::Frame::unappliedEditing): (WebCore::Frame::reappliedEditing):
  • page/Frame.h:
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
  • platform/AtomicString.h: (WebCore::AtomicString::AtomicString):
  • platform/DeprecatedString.cpp: (DeprecatedString::replace):
  • platform/GraphicsContext.h:
  • platform/Image.h:
  • platform/KURL.cpp:
  • platform/KURL.h:
  • platform/PlatformString.h: (WebCore::String::String): (WebCore::String::replace):
  • platform/String.cpp: (WebCore::operator+):
  • platform/StringImpl.cpp: (WebCore::StringImpl::remove): (WebCore::parseLength): (WebCore::StringImpl::replace):
  • platform/StringImpl.h:
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::setCompositeOperation):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paint):
  • rendering/render_form.cpp: (WebCore::RenderSelect::updateFromElement):
  • rendering/render_frames.cpp: (WebCore::isURLAllowed): (WebCore::mapClassIdToServiceType): (WebCore::RenderPartObject::updateWidget):
  • rendering/render_style.h: (WebCore::RenderStyle::setDashboardRegion):
  • xml/xmlhttprequest.cpp: (WebCore::getCharset): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::overrideMIMEType):
2:21 PM Changeset in webkit [13439] by bdakin
  • 3 edits in trunk/WebCore

Reviewed by Hyatt

Fix for <rdar://problem/4471984> repro crash CSS position for html/
table=relative causes crash when hiding table

2:10 PM Changeset in webkit [13438] by mjs
  • 2 edits in trunk/JavaScriptCore
  • kjs/generate-derived-sources: Set executable property.
2:10 PM Changeset in webkit [13437] by hyatt
  • 5 edits in trunk/WebCore

Fix for residual style problem where form elements lose their connection
to a degenerate table form because of a residual style fixup. This is
Radar bug #4330765.

Reviewed by eric

  • khtml/html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement):
  • khtml/html/HTMLFormElement.h: (WebCore::HTMLFormElement::setPreserveFormConnectionAcrossRemove): (WebCore::HTMLFormElement::preserveFormConnectionAcrossRemove):
  • khtml/html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::removedFromTree):
  • khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
2:09 PM Changeset in webkit [13436] by adele
  • 2 edits
    4 adds in trunk/WebCore

Reviewed by Adele.

  • manual-tests/named-window-blank-target.html: Added.
  • manual-tests/resources/named-window-blank-target-step2.html: Added.
  • manual-tests/resources/named-window-blank-target-step3.html: Added.
  • manual-tests/resources/named-window-blank-target-step4.html: Added.
  • page/FrameTree.cpp: (WebCore::FrameTree::find): If the given name is empty, just return our frame, even if it has a name.
1:31 PM Changeset in webkit [13435] by mjs
  • 2 edits
    1 add in trunk/JavaScriptCore

Reviewed by Darin.


Ensure that generated source dependencies are handled properly, as follows:


  • Made an external script that generates the sources into a DerivedSources dir in the build products directory.
  • Added a new build target that builds all the generated sources if needed. Sadly it has to be a target, not a phase for Xcode to notice changes.
  • Added the DerivedSources dir in question to the include path.
  • Added the new DerivedSources dir and its contents to the project as build-relative.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/generate-derived-sources: Added. Based on the windows version - maybe someday they can share more.
12:18 PM Changeset in webkit [13434] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Added Bugzilla bug number.

12:16 PM Changeset in webkit [13433] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.

  • test for <rdar://problem/4483856> REGRESSION (417.8-TOT): onclick handler cannot call a function named OnClick (7143)
  • fast/dom/Element/onclick-case-expected.txt: Added.
  • fast/dom/Element/onclick-case.html: Added.

WebCore:

Reviewed by Adele.

  • fix <rdar://problem/4483856> REGRESSION (417.8-TOT): onclick handler cannot call a function named OnClick (7143)

Test: fast/dom/Element/onclick-case.html

We discussed this with Maciej. In the long run we may need to remove the "all attributes
show up as properties in JavaScript" feature entirely. Gecko does not do it, and it's
not really the same thing IE does either.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMElement::attributeGetter): Use getAttributeNS so we're case sensitive. (KJS::DOMElement::getOwnPropertySlot): Ditto.
12:02 PM Changeset in webkit [13432] by eseidel
  • 2 edits in trunk/WebCore

2006-03-22 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

<rdar://problem/4486417> REGRESSION: Mail linked against TOT WebKit crashes when composing a message

No test possible.

  • bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings init]): call AtomicString::init()

Mar 21, 2006:

8:59 PM Changeset in webkit [13431] by darin
  • 2 edits in trunk/WebKit
  • WebView/WebHTMLView.m: (-[WebHTMLView _updateFocusState]): Treat window as having focus if its sheet is key. (-[WebHTMLView addWindowObservers]): Observe all focus notifications, not just the ones involving this window. (-[WebHTMLView removeWindowObservers]): Ditto. (-[WebHTMLView windowDidBecomeKey:]): Add checks so that we call the methods only when appropriate, since this will now be called for all windows. (-[WebHTMLView windowDidResignKey:]): Ditto.
8:44 PM Changeset in webkit [13430] by darin
  • 4 edits in trunk/WebCore
  • fix buildbot (and everyone else)
  • bindings/js/JSDOMCore.cpp: Touch, because Adele's change adds a virtual function, and Xcode doesn't know this needs recompiling.
  • bindings/js/JSDOMEvents.cpp: Ditto.
  • bindings/js/JSDOMHTML.cpp: Ditto.
8:38 PM Changeset in webkit [13429] by darin
  • 7 edits in trunk/WebCore

Reviewed by Eric and Darin.

  • get Windows building again
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::userAgent):
  • bridge/win/FrameWin.h:
  • platform/GraphicsContext.h:
  • platform/cairo/ImageCairo.cpp: (WebCore::Image::supportsType):
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::mimeTypeForFileName): (FrameWin::objectContentType): (FrameWin::createPlugin): (FrameWin::overrideMediaType): (FrameWin::passSubframeEventToSubframe): (FrameWin::createFrame): (FrameWin::incomingReferrer):
7:42 PM Changeset in webkit [13428] by darin
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::setStyleSheet): This was calling the function that sets the stylesheet URL, passing it the actual stylesheet. (WebCore::Frame::begin): (WebCore::Frame::setUserStyleSheetLocation): Renamed the version of setUserStyleSheet() that takes a URL to this. (WebCore::Frame::reparseConfiguration):
  • page/Frame.h:
5:08 PM Changeset in webkit [13427] by adele
  • 19 edits
    10 adds in trunk

LayoutTests:

Tests for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6813
elementAtPoint needs to return input element when clicking on new text field
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7799
New text fields don't respect the disabled attribute

  • fast/forms/input-appearance-disabled-expected.checksum: Added.
  • fast/forms/input-appearance-disabled-expected.png: Added.
  • fast/forms/input-appearance-disabled-expected.txt: Added.
  • fast/forms/input-appearance-disabled.html: Added.
  • fast/forms/input-appearance-elementFromPoint-expected.txt: Added.
  • fast/forms/input-appearance-elementFromPoint.html: Added.
  • fast/forms/input-appearance-preventDefault-expected.checksum: Added.
  • fast/forms/input-appearance-preventDefault-expected.png: Added.
  • fast/forms/input-appearance-preventDefault-expected.txt: Added.
  • fast/forms/input-appearance-preventDefault.html: Added.

WebCore:

Reviewed by Darin.

  • Tests: fast/forms/input-appearance-disabled.html fast/forms/input-appearance-elementFromPoint.html fast/forms/input-appearance-preventDefault.html
  • bridge/mac/WebCoreFrameBridge.h: Added allowShadowContent parameter to getInnerNonSharedNode so new elementAtPoint method in WebKit can call this.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getInnerNonSharedNode:innerNode:URLElement:atPoint:allowShadowContent:]): Passes allowShadowContent parameter to nodeInfoAtPoint. (-[WebCoreFrameBridge _visiblePositionForPoint:]): Updated to call nodeInfoAtPoint allowing shadow content. (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:allowShadowContent:]): Added allowShadowContent parameter.
  • dom/Node.h: (WebCore::Node::isShadowNode): Added. (WebCore::Node::shadowParentNode): Added.
  • dom/Node.cpp: (WebCore::Node::shadowAncestorNode): Added. If an ancestor is a shadow node, return its shadow parent node.
  • html/HTMLTextFieldInnerElement.h: (WebCore::HTMLTextFieldInnerElement::isShadowNode): Added.
  • dom/Document.cpp: (WebCore::Document::elementFromPoint): Gets the shadowAncestorNode (so we get the input element, and not the inner div).
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isKeyboardFocusable): If text fields are focusable, then they should be keyboard focusable. This works for the old text fields because HTMLGenericFormElement::isKeyboardFocusable does the right thing for RenderWidgets. That's not needed for the new form elements. (WebCore::HTMLInputElement::defaultEventHandler): let the renderer forward drag, mouse, and wheel events.
  • page/FrameView.cpp: (WebCore::FrameView::updateDragAndDrop): Send drag events to the shadowAncestorNode. (WebCore::FrameView::dispatchMouseEvent): Send mouse events to the shadowAncestorNode. (WebCore::FrameView::handleWheelEvent): Send wheel events to the shadowAncestorNode.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::forwardEvent): forwards events to the inner div element.
  • rendering/RenderTextField.h: Added forwardEvent method.
  • kwq/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityHitTest:]): Gets the shadowAncestorNode (so we get the input element, and not the inner div). (-[WebCoreAXObject role]): Gets the right role for text fields, since we no longer get that from AppKit. (-[WebCoreAXObject roleDescription]): Gets the right description for text fields.

WebKit:

Reviewed by Darin.

  • WebView/WebDocumentInternal.h: Added elementAtPoint:allowShadowContent:
  • WebView/WebHTMLView.m: (-[NSArray elementAtPoint:]): Does not allow shadow content. This way, by default, callers would get the input element instead of the inner div. (-[NSArray elementAtPoint:allowShadowContent:]): Allows callers to specify whether or not the element can be a shadow node. (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Allows shadow content when getting element. (-[WebHTMLView _mayStartDragAtEventLocation:]): ditto. (-[NSArray _isSelectionEvent:]): ditto. (-[NSArray _canProcessDragWithDraggingInfo:]): ditto.
  • WebView/WebFrame.m: (-[WebFrame _actionInformationForNavigationType:event:originalURL:]): Does not allow shadow content when getting element.
  • WebView/WebImageView.m: (-[WebImageView elementAtPoint:allowShadowContent:]): Added to conform to the WebDocumentElement protocol.
  • WebView/WebPDFView.m: (-[WebPDFView elementAtPoint:allowShadowContent:]): ditto.
  • WebView/WebTextView.m: (-[WebTextView elementAtPoint:allowShadowContent:]): ditto.
3:52 PM Changeset in webkit [13426] by darin
  • 14 edits
    5 adds in trunk

LayoutTests:

  • test for <rdar://problem/4251515> REGRESSION: listing tag broken in TOT
  • fast/html: Added.
  • fast/html/listing-expected.checksum: Added.
  • fast/html/listing-expected.png: Added.
  • fast/html/listing-expected.txt: Added.
  • fast/html/listing.html: Added.

WebCore:

Reviewed by Tim O.

  • fixed <rdar://problem/4251515> REGRESSION: listing tag broken in TOT

Test: fast/html/listing.html

  • html/HTMLNames.h: Add listing tag.
  • bindings/objc/DOM.mm: (+[DOMNode _nodeWith:]):
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString):
  • css/html4.css:
  • editing/ReplaceSelectionCommand.cpp: (WebCore::isProbablyBlock):
  • editing/TextIterator.cpp: (WebCore::TextIterator::handleNonTextNode): (WebCore::TextIterator::exitNode): (WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode):
  • editing/markup.cpp: (WebCore::startMarkup): (WebCore::createMarkup):
  • html/HTMLElement.cpp: (WebCore::blockTagList):
  • html/HTMLElementFactory.cpp: (WebCore::addTag): (WebCore::createFunctionMap): (WebCore::HTMLElementFactory::createHTMLElement):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::isAffectedByResidualStyle):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
  • khtml/ecma/kjs_html.cpp: (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): Add listing tags everywhere pre tags are listed.
3:41 PM Changeset in webkit [13425] by thatcher
  • 12 edits in trunk/WebCore/dom

Touching the idl files to force a build after Maciej's change.

3:36 PM Changeset in webkit [13424] by mjs
  • 6 edits in trunk/WebCore

Reviewed by Darin.


  • fix horrible build fallout from my attr fix
  • bindings/js/JSCanvasRenderingContext2DBase.cpp:
  • bindings/js/JSDOMCore.cpp:
  • bindings/js/JSDOMEvents.cpp:
  • bindings/js/JSDOMHTML.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
2:49 PM Changeset in webkit [13423] by tomernic
  • 4 edits
    2 adds in trunk/WebKit

Reviewed by Tim Hatcher and Darin.

<rdar://problem/4427068> LMGetCurApRefNum, CloseConnection and GetDiskFragment deprecated, used in Netscape
plugin code

  • Plugins/WebNetscapeDeprecatedFunctions.h: Added.
  • Plugins/WebNetscapeDeprecatedFunctions.c: Added. Added wrappers for deprecated CFM and LowMem functions. These exist in a separate file so that we can set -Wno-deprecated-declarations on this one file without ignoring other deprecated function usage elsewhere. (WebGetDiskFragment): (WebCloseConnection): (WebLMGetCurApRefNum): (WebLMSetCurApRefNum):
  • Plugins/WebNetscapePluginPackage.h: Don't include connID ivar in 64-bit, since CFM is not supported in 64-bit.
  • Plugins/WebNetscapePluginPackage.m: (+[WebNetscapePluginPackage initialize]): Don't bother setting the resource refNum in 64-bit, because the API to get and set it does not exist. A theoretical 64-bit plugin couldn't possibly rely this, since there is no API. (-[WebNetscapePluginPackage unloadWithoutShutdown]): No need to close the connID in 64-bit. (-[WebNetscapePluginPackage load]): Don't load CFM bundles in 64-bit, because CFM is not supported.
  • WebKit.xcodeproj/project.pbxproj: Added WebNetscapeDeprecatedFunctions.[hm].
11:36 AM Changeset in webkit [13422] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Kevin Decker.


  • fixed <rdar://problem/4485637> Implementors of searchFor:direction:caseSensitive:wrap: should bail out early if search string is empty


This doesn't change any existing behavior, but avoids unnecessary work.

  • Misc/WebSearchableTextView.m: (-[WebSearchableTextView searchFor:direction:caseSensitive:wrap:]): bail out immediately (returning NO) if search string is empty


  • WebView/WebHTMLView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): ditto


  • WebView/WebPDFView.m: (-[WebPDFView searchFor:direction:caseSensitive:wrap:]): ditto


  • WebView/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): ditto
10:12 AM Changeset in webkit [13421] by bdakin
  • 2 edits in trunk/LayoutTests

Reducing the amount of time this test waits for the frame to fully
load per Justin's request.

9:36 AM Changeset in webkit [13420] by bdakin
  • 6 edits
    5 adds in trunk

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7223
Reproducible crash when tabbing to a frame that has not been loaded
Also adds support for keyDown() to DumpRenderTree.

2:53 AM Changeset in webkit [13419] by eseidel
  • 3 edits
    3 adds in trunk

2006-03-20 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix a unsafe static cast causing intermittent crashes.
<rdar://problem/4411663> crash at KXMLCore::RefPtr<WebCore::DOMStringImpl>::get() const + 20 (RefPtr.h:45)

Test: fast/dom/NodeList/item-by-id-with-no-document.html

  • dom/NodeList.cpp: (WebCore::NodeList::itemById): fix unsafe static cast.

Mar 20, 2006:

11:57 PM Changeset in webkit [13418] by justing
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by vicki


Testcase for fix for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7363>
REGRESSION (r12872): Repro crash when clicking the Quick Reply box in Gmail


  • fast/forms/textfield-focus-out-expected.txt: Added.
  • fast/forms/textfield-focus-out.html: Added.
11:56 PM Changeset in webkit [13417] by mjs
  • 2 edits in trunk/WebCore
  • touch this file in hopes of fixing build
  • bindings/js/JSDOMCore.cpp:
11:12 PM Changeset in webkit [13416] by mjs
  • 1 edit in trunk/LayoutTests/ChangeLog

fix accidentally reversed changelog entries

11:08 PM Changeset in webkit [13415] by mjs
  • 7 edits
    5 adds in trunk

LayoutTests:

Reviewed by mjs.

Test for: <rdar://problem/4483882> REGRESSION (417.8-TOT): crash at yourmovies.com.au in WebCore::HTMLTokenizer::reset() + 92 (7818)

  • fast/tokenizer/external-script-document-open-expected.txt: Added.
  • fast/tokenizer/external-script-document-open.html: Added.
  • fast/tokenizer/resources/external-script-document-open.js: Added.
  • fast/tokenizer/resources/write-external-script-open.js: Added.
  • fast/tokenizer/write-external-script-open-expected.txt: Added.
  • fast/tokenizer/write-external-script-open.html: Added.
  • fast/tokenizer/write-inline-script-open-expected.txt: Added.
  • fast/tokenizer/write-inline-script-open.html: Added.

WebCore:

Reviewed by Anders.


  • fixed <rdar://problem/4446749> 10.4.4: safari crash in DOM::NamedAttrMapImpl::setNamedItem
  • bindings/scripts/CodeGeneratorJS.pm: Add a framework for typechecking method arguments. For now only use it for parameters of type Attr.
  • dom/Element.idl: Arbitrary change to make it regenerate.
  • dom/dom_elementimpl.cpp: (WebCore::Element::setAttributeNode): ASSERT that attr is not null
  • khtml/ecma/kjs_dom.cpp: (KJS::toAttr): add bool ok parameter
  • khtml/ecma/kjs_dom.h:
11:02 PM Changeset in webkit [13414] by eseidel
  • 1 edit
    1 delete in trunk/WebCore

2006-03-20 Eric Seidel <​eseidel@apple.com>

  • ksvg2/css/SVGCSSParser.h: Removed unused file.
10:46 PM Changeset in webkit [13413] by eseidel
  • 7 edits
    8 adds in trunk

2006-03-20 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix tokenizer crash when document.open() is called from an external script:
<rdar://problem/4483882> REGRESSION (417.8-TOT): crash at yourmovies.com.au in WebCore::HTMLTokenizer::reset() + 92 (7818)

  • dom/Document.cpp: (WebCore::Document::open): Check to make sure the current tokenizer isn't executing a script
  • dom/xml_tokenizer.h: (WebCore::Tokenizer::executingScript): Add a way for others to know if scripts are executing.
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution): Wire into existing m_executingScript member var.
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::executingScript):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::prepareFilter): Unrelated code cleanup.
10:22 PM Changeset in webkit [13412] by justing
  • 4 edits in trunk/WebCore

Reviewed by darin


<rdar://problem/3997958>
REGRESSION (Mail): Mail takes half of forever to paste >1500 lines - replaceSelectionWithNode

  • dom/Position.cpp: (WebCore::Position::upstream): Avoid calling previous() when we know that it will 1) end the search and 2) be expensive to compute. (WebCore::Position::downstream): Removed some dead code. (WebCore::Position::inRenderedText): Return false for offsets inside composed characters.
  • dom/Position.h:
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::init): If there are two visually equivalent candidates, we choose the one that occurs first in document order. Using upstream() to find the one that occurs first is much faster than the old code.
9:52 PM Changeset in webkit [13411] by mjs
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.


  • test case for <rdar://problem/4362396> REGRESSION: (417-420) stopPropagation is not working for click event listener (onclick works fine)

Make sure that capturing event listeners trigger on the target and that if they
stopPropagation, then bubbling listeners on ancestors do not trigger.


  • fast/events/capture-on-target-expected.txt: Added.
  • fast/events/capture-on-target.html: Added.

WebCore:

Reviewed by adele & ggaren.

Added new cachePluginDataIfNecessary function to update
plugins and mimes arrays. Made sure to call this in
constructor as well as refresh. The crash was caused by
a refresh rendering a "plugins" object invalid.
Changed existing test case to depend on this new correct behavior.


<rdar://problem/4480571> Safari crashed at exit at KXMLCore::deleteAllValues + 24

  • khtml/ecma/kjs_navigator.cpp: (KJS::PluginBase::cachePluginDataIfNecessary): (KJS::PluginBase::PluginBase): (KJS::PluginBase::~PluginBase): (KJS::PluginBase::refresh):
8:23 PM Changeset in webkit [13410] by eseidel
  • 4 edits in trunk

2006-03-20 Eric Seidel <​eseidel@apple.com>

Reviewed by adele & ggaren.

Added new cachePluginDataIfNecessary function to update
plugins and mimes arrays. Made sure to call this in
constructor as well as refresh. The crash was caused by
a refresh rendering a "plugins" object invalid.
Changed existing test case to depend on this new correct behavior.


<rdar://problem/4480571> Safari crashed at exit at KXMLCore::deleteAllValues + 24

  • khtml/ecma/kjs_navigator.cpp: (KJS::PluginBase::cachePluginDataIfNecessary): (KJS::PluginBase::PluginBase): (KJS::PluginBase::~PluginBase): (KJS::PluginBase::refresh):
7:52 PM Changeset in webkit [13409] by adele
  • 2 edits in trunk/WebCore

Reviewed by Justin.

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::visiblePositionForIndex): When calculating the VisiblePosition for the first position in the text field, it makes more sense for the position to have a downstream affinity.
5:54 PM Changeset in webkit [13408] by eseidel
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

2006-03-20 Eric Seidel <​eseidel@apple.com>

Reviewed by justing.

Re-enable previously failing test.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6560

  • dom/xhtml/level2/html/HTMLIFrameElement11.xhtml: Added.
  • dom/xhtml/level2/html/HTMLIFrameElement11.xhtml-disabled: Removed.
5:46 PM Changeset in webkit [13407] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.


<rdar://problem/4458568> WebCore should not disclose https referrers

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canLoadURL:fromReferrer:hideReferrer:]): Don't send https URLs as referrers to non-secure http sites.
5:29 PM Changeset in webkit [13406] by tomernic
  • 4 edits in trunk/WebKit

Reviewed by John Sullivan.

Moved -_contentView from WebFrameViewInternal to WebFrameViewPrivate. Safari
needs this.

  • WebView/WebFrameView.m: (-[WebFrameView _contentView]):
  • WebView/WebFrameViewInternal.h:
  • WebView/WebFrameViewPrivate.h:
5:15 PM Changeset in webkit [13405] by darin
  • 84 edits
    1 move
    1 add in trunk/WebCore

Reviewed by Geoff.

  • config.h: Remove the defines for DOM, KDOM, KSVG, khtml, DOMString, QString, and qstring().
  • WebCore.xcodeproj/project.pbxproj: Pass in WebCore instead of KSVG as the namespace for SVG names.
  • ksvg2/scripts/make_names.pl: Made a couple changes to trick the SVG names into recompiling, since they are in a different namespace now.
  • ForwardingHeaders/kjs/identifier.h: Added.
  • dom/PlatformWheelEvent.idl: Removed.
  • dom/WheelEvent.idl: Added. This file was renamed by accident.
  • bindings/js/JSDOMCore.cpp:
  • bindings/js/JSDOMEvents.cpp:
  • bindings/js/JSDOMHTML.cpp:
  • dom/Attr.idl:
  • dom/CharacterData.idl:
  • dom/DOMImplementation.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/Entity.idl:
  • dom/MutationEvent.idl:
  • dom/Notation.idl:
  • dom/ProcessingInstruction.idl:
  • dom/Text.idl:
  • html/CanvasGradient.idl:
  • html/CanvasPattern.idl:
  • html/CanvasRenderingContext2D.idl: Touched, to get CodeGeneratorJS.pm changes to take effect.


  • css/CSSGrammar.y:
  • css/css_valueimpl.cpp: (WebCore::propertyID):
Changed calls to get CSS property values to use an explicit SVG
namespace, to match what the script writes out.
  • khtml/ecma/kjs_binding.h: Added forward declaration of WebCore::String.
  • ksvg2/scripts/cssmakeget rid of macro hacks for DOM, KDOM, KSVG, khtml, DOMString, QString props: Made this compile with warnings and strict turned on. Really just a trick to get properties to recompile, which turned out to be unneeded.
  • ksvg2/scripts/cssmakevalues: Ditto.
  • ksvg2/svg/SVGAElement.cpp: (SVGAElement::parseMappedAttribute): (SVGAElement::defaultEventHandler):
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (SVGAnimateTransformElement::parseMappedAttribute):
  • ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::parseMappedAttribute):
  • ksvg2/svg/SVGClipPathElement.cpp: (SVGClipPathElement::parseMappedAttribute):
  • ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (SVGComponentTransferFunctionElement::parseMappedAttribute):
  • ksvg2/svg/SVGExternalResourcesRequired.cpp: (SVGExternalResourcesRequired::parseMappedAttribute):
  • ksvg2/svg/SVGFEBlendElement.cpp: (SVGFEBlendElement::parseMappedAttribute):
  • ksvg2/svg/SVGFEColorMatrixElement.cpp: (SVGFEColorMatrixElement::parseMappedAttribute):
  • ksvg2/svg/SVGFEComponentTransferElement.cpp: (SVGFEComponentTransferElement::parseMappedAttribute):
  • ksvg2/svg/SVGFECompositeElement.cpp: (SVGFECompositeElement::parseMappedAttribute):
  • ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
  • ksvg2/svg/SVGFEDisplacementMapElement.cpp: (SVGFEDisplacementMapElement::SVGFEDisplacementMapElement): (SVGFEDisplacementMapElement::stringToChannel): (SVGFEDisplacementMapElement::parseMappedAttribute): (SVGFEDisplacementMapElement::filterEffect):
  • ksvg2/svg/SVGFEDisplacementMapElement.h:
  • ksvg2/svg/SVGFEFloodElement.cpp: (SVGFEFloodElement::parseMappedAttribute):
  • ksvg2/svg/SVGFEGaussianBlurElement.cpp: (SVGFEGaussianBlurElement::parseMappedAttribute):
  • ksvg2/svg/SVGFEImageElement.cpp: (SVGFEImageElement::parseMappedAttribute):
  • ksvg2/svg/SVGFELightElement.cpp: (SVGFELightElement::parseMappedAttribute):
  • ksvg2/svg/SVGFEMergeNodeElement.cpp: (SVGFEMergeNodeElement::parseMappedAttribute):
  • ksvg2/svg/SVGFEOffsetElement.cpp: (SVGFEOffsetElement::parseMappedAttribute):
  • ksvg2/svg/SVGFESpecularLightingElement.cpp: (SVGFESpecularLightingElement::parseMappedAttribute):
  • ksvg2/svg/SVGFETileElement.cpp: (SVGFETileElement::parseMappedAttribute):
  • ksvg2/svg/SVGFETurbulenceElement.cpp: (SVGFETurbulenceElement::parseMappedAttribute):
  • ksvg2/svg/SVGFilterElement.cpp: (SVGFilterElement::parseMappedAttribute):
  • ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::parseMappedAttribute):
  • ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::parseMappedAttribute):
  • ksvg2/svg/SVGPolyElement.cpp: (SVGPolyElement::parseMappedAttribute):
  • ksvg2/svg/SVGStopElement.cpp: (SVGStopElement::parseMappedAttribute):
  • ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::parseMappedAttribute):
  • ksvg2/svg/SVGTests.cpp: (WebCore::SVGTests::parseMappedAttribute):
  • ksvg2/svg/SVGTextContentElement.cpp: (SVGTextContentElement::parseMappedAttribute):
  • ksvg2/svg/SVGTextPositioningElement.cpp: (SVGTextPositioningElement::parseMappedAttribute):
  • ksvg2/svg/SVGViewElement.cpp: (SVGViewElement::parseMappedAttribute):
  • ksvg2/svg/SVGZoomAndPan.cpp: (SVGZoomAndPan::parseMappedAttribute): Changed code that converts an AtomicString to a String to do it in a more-efficient fashion that works even with all the new conversions.
  • page/Frame.cpp: (WebCore::getString): Removed unneeded .deprecatedString(). (WebCore::Frame::begin): Removed the only use of QSTRING_NULL.
  • platform/AtomicString.h: Added conversion to and from KJS::Identifier and KJS::UString.
  • platform/AtomicString.cpp: (WebCore::AtomicString::add): Added overloads for Identifier and UString. (WebCore::AtomicString::operator Identifier): Added. (WebCore::AtomicString::operator UString): Added.
  • platform/DeprecatedString.h: Added conversion to and from KJS::Identifier and KJS::UString.
  • platform/DeprecatedString.cpp: (DeprecatedString::DeprecatedString): Added overloads for Identifier and UString. (DeprecatedString::operator Identifier): Added. (DeprecatedString::operator UString): Added.
  • platform/PlatformString.h: Added conversion to and from KJS::Identifier and KJS::UString.
  • platform/String.cpp: (WebCore::String::String): Added overloads for Identifier and UString. (WebCore::String::operator Identifier): Added. (WebCore::String::operator UString): Added.
  • platform/StringImpl.h: Added constructors that take KJS::Identifier and KJS::UString
  • platform/StringImpl.cpp: (WebCore::getWordBreakIterator): Changed a use of UChar to say ::UChar instead because of ambiguity with KJS::UChar. (WebCore::StringImpl::StringImpl): Added overloads for Identifier and String.
  • bindings/js/JSCanvasRenderingContext2DBase.cpp: (WebCore::JSCanvasRenderingContext2DBaseProtoFunc::callAsFunction): (WebCore::toHTMLCanvasStyle):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
  • dom/QualifiedName.cpp: (WebCore::QualifiedName::toString):
  • khtml/ecma/JSDOMParser.cpp: (KJS::DOMParserProtoFunc::callAsFunction):
  • khtml/ecma/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
  • khtml/ecma/JSXSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
  • khtml/ecma/kjs_binding.cpp: (KJS::valueToStringWithNullCheck):
  • khtml/ecma/kjs_css.cpp: (KJS::cssPropertyName): (KJS::DOMCSSStyleDeclaration::put): (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction): (KJS::DOMStyleSheetList::nameGetter): (KJS::DOMStyleSheetList::getOwnPropertySlot): (KJS::DOMMediaList::put): (KJS::KJS::DOMMediaListProtoFunc::callAsFunction): (KJS::DOMCSSStyleSheetProtoFunc::callAsFunction): (KJS::DOMCSSRule::putValueProperty): (KJS::DOMCSSRuleFunc::callAsFunction): (KJS::DOMCSSValue::put): (KJS::DOMCSSPrimitiveValueProtoFunc::callAsFunction):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::putValueProperty): (KJS::DOMNode::toString): (KJS::DOMNodeProtoFunc::callAsFunction): (KJS::DOMEventTargetNodeProtoFunc::callAsFunction): (KJS::DOMNodeList::nameGetter): (KJS::DOMNodeList::getOwnPropertySlot): (KJS::DOMDocument::putValueProperty): (KJS::DOMDocumentProtoFunc::callAsFunction): (KJS::DOMElement::attributeGetter): (KJS::DOMElement::getOwnPropertySlot): (KJS::DOMNamedNodeMap::nameGetter): (KJS::DOMNamedNodeMap::getOwnPropertySlot): (KJS::DOMNamedNodeMapProtoFunc::callAsFunction): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): (KJS::DOMEvent::getValueProperty): (KJS::DOMEventProtoFunc::callAsFunction): (KJS::DOMUIEventProtoFunc::callAsFunction): (KJS::DOMMouseEventProtoFunc::callAsFunction): (KJS::DOMKeyboardEventProtoFunc::callAsFunction): (KJS::Clipboard::putValueProperty): (KJS::ClipboardProtoFunc::callAsFunction):
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::callAsFunction): (KJS::JSHTMLDocument::namedItemGetter): (KJS::JSHTMLDocument::getOwnPropertySlot): (KJS::JSHTMLDocument::putValueProperty): (KJS::JSHTMLElement::framesetNameGetter): (KJS::JSHTMLElement::getOwnPropertySlot): (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::putValueProperty): (KJS::JSHTMLCollection::callAsFunction): (KJS::JSHTMLCollection::getNamedItems): (KJS::HTMLCollectionProtoFunc::callAsFunction): (KJS::OptionConstructorImp::construct):
  • khtml/ecma/kjs_navigator.cpp: (KJS::Plugins::nameGetter): (KJS::Plugins::getOwnPropertySlot): (KJS::MimeTypes::nameGetter): (KJS::MimeTypes::getOwnPropertySlot): (KJS::Plugin::nameGetter): (KJS::Plugin::getOwnPropertySlot):
  • khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate):
  • khtml/ecma/kjs_range.cpp: (KJS::DOMRangeProtoFunc::callAsFunction):
  • khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractViewProtoFunc::callAsFunction):
  • khtml/ecma/kjs_window.cpp: (KJS::parseModalDialogFeatures): (KJS::showModalDialog): (KJS::Window::childFrameGetter): (KJS::Window::namedFrameGetter): (KJS::Window::namedItemGetter): (KJS::Window::getOwnPropertySlot): (KJS::Window::put): (KJS::WindowFunc::callAsFunction): (KJS::ScheduledAction::execute): (KJS::Window::installTimeout): (KJS::FrameArray::nameGetter): (KJS::FrameArray::getOwnPropertySlot): (KJS::Location::put): (KJS::LocationFunc::callAsFunction): (KJS::SelectionFunc::callAsFunction): Removed explicit calls to domString(), sometimes replacing with explicit calls to the String() constructor. Other similar changes for AtomicString and DeprecatedString use.
3:25 PM Changeset in webkit [13404] by eseidel
  • 78 edits in trunk/WebCore

2006-03-20 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Remove many, many uses of DeprecatedString.
Fix various style issues throughout the touched code.

  • bindings/objc/DOM.mm: (-[DOMRange _text]):
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/FrameMac.h: (WebCore::FrameMac::bridge): (WebCore::FrameMac::markedTextRange): (WebCore::Mac):
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::searchForLabelsAboveCell): (WebCore::FrameMac::searchForLabelsBeforeElement): (WebCore::FrameMac::matchLabelsAgainstElement): (WebCore::FrameMac::findString): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::urlSelected): (WebCore::FrameMac::objectContentType): (WebCore::FrameMac::createPlugin): (WebCore::FrameMac::createFrame): (WebCore::FrameMac::setTitle): (WebCore::FrameMac::setStatusBarText): (WebCore::FrameMac::advanceToNextMisspelling): (WebCore::FrameMac::userAgent): (WebCore::FrameMac::mimeTypeForFileName): (WebCore::FrameMac::openURLFromPageCache): (WebCore::FrameMac::incomingReferrer): (WebCore::FrameMac::attributedString): (WebCore::FrameMac::overrideMediaType): (WebCore::FrameMac::shouldClose):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge _documentTypeString]): (-[WebCoreFrameBridge selectedString]): (-[WebCoreFrameBridge stringForRange:]): (-[WebCoreFrameBridge advanceToNextMisspelling]): (-[WebCoreFrameBridge advanceToNextMisspellingStartingJustBeforeSelection]): (-[WebCoreFrameBridge domain]):
  • bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings setStandardFontFamily:]): (-[WebCoreSettings setFixedFontFamily:]): (-[WebCoreSettings setSerifFontFamily:]): (-[WebCoreSettings setSansSerifFontFamily:]): (-[WebCoreSettings setCursiveFontFamily:]): (-[WebCoreSettings setFantasyFontFamily:]): (-[WebCoreSettings setUserStyleSheetLocation:]): (-[WebCoreSettings setDefaultTextEncoding:]):
  • css/css_valueimpl.cpp: (WebCore::quoteStringIfNeeded):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::setEncodedURL): (WebCore::cleanpath): (WebCore::checkPseudoState): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::convertToLength): (WebCore::colorForCSSValue): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
  • css/cssstyleselector.h:
  • dom/CDATASection.cpp: (WebCore::CDATASection::toString):
  • dom/Document.cpp: (WebCore::Document::recalcStyle):
  • dom/Document.h: (WebCore::Document::baseTarget): (WebCore::Document::setBaseTarget):
  • dom/dom_elementimpl.cpp: (WebCore::Element::openTagStartToString):
  • dom/xml_tokenizer.cpp: (WebCore::handleElementAttributes): (WebCore::XMLTokenizer::startElementNs):
  • editing/SelectionController.cpp: (WebCore::SelectionController::type):
  • editing/TextIterator.cpp: (WebCore::TextIterator::advance): (WebCore::TextIterator::handleTextBox): (WebCore::TextIterator::handleNonTextNode): (WebCore::TextIterator::exitNode): (WebCore::SimplifiedBackwardsTextIterator::advance): (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): (WebCore::CharacterIterator::advance): (WebCore::WordAwareIterator::advance): (WebCore::WordAwareIterator::length): (WebCore::WordAwareIterator::characters): (WebCore::CircularSearchBuffer::CircularSearchBuffer): (WebCore::CircularSearchBuffer::append): (WebCore::TextIterator::rangeFromLocationAndLength): (WebCore::findPlainText):
  • editing/TextIterator.h:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
  • khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
  • khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxy::initScriptIfNeeded):
  • khtml/ecma/kjs_window.cpp: (KJS::Location::getValueProperty):
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::fillPaintServer): (WebCore::KSVGPainterFactory::strokePaintServer):
  • ksvg2/svg/SVGAngle.cpp: (SVGAngle::calculate): (SVGAngle::setValueAsString): (SVGAngle::valueAsString): (SVGAngle::convertToSpecifiedUnits): (SVGAngle::shortestArcBisector):
  • ksvg2/svg/SVGAngle.h:
  • ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::targetElement): (SVGAnimationElement::parseMappedAttribute): (SVGAnimationElement::parseClockValue): (SVGAnimationElement::targetAttribute): (SVGAnimationElement::setTargetAttribute): (SVGAnimationElement::detectAnimationMode): (SVGAnimationElement::calculateCurrentValueItem): (SVGAnimationElement::calculateRelativeTimePercentage):
  • ksvg2/svg/SVGColor.cpp: (SVGColor::setRGBColor):
  • ksvg2/svg/SVGDOMImplementation.cpp: (svgFeatureSet): (SVGDOMImplementation::self): (SVGDOMImplementation::hasFeature): (SVGDOMImplementation::createDocumentType): (SVGDOMImplementation::createDocument):
  • ksvg2/svg/SVGDOMImplementation.h:
  • ksvg2/svg/SVGPaint.cpp: (SVGPaint::cssText):
  • ksvg2/svg/SVGPathSegClosePath.h: (WebCore::SVGPathSegClosePath::toString):
  • ksvg2/svg/SVGPreserveAspectRatio.cpp: (SVGPreserveAspectRatio::parsePreserveAspectRatio): (SVGPreserveAspectRatio::getCTM):
  • ksvg2/svg/SVGStopElement.cpp: (SVGStopElement::parseMappedAttribute):
  • ksvg2/svg/SVGStyleElement.cpp: (SVGStyleElement::childrenChanged):
  • ksvg2/svg/SVGURIReference.cpp: (SVGURIReference::getTarget):
  • kwq/ClipboardMac.mm: (WebCore::ClipboardMac::setData): (WebCore::ClipboardMac::types): (WebCore::ClipboardMac::setEffectAllowed): (WebCore::cocoaOpFromIEOp): (WebCore::IEOpFromCocoaOp): (WebCore::ClipboardMac::sourceOperation): (WebCore::ClipboardMac::destinationOperation):
  • kwq/KWQCString.cpp: (DeprecatedCString::append):
  • kwq/KWQKHTMLSettings.h: (KHTMLSettings::stdFontName): (KHTMLSettings::fixedFontName): (KHTMLSettings::serifFontName): (KHTMLSettings::sansSerifFontName): (KHTMLSettings::cursiveFontName): (KHTMLSettings::fantasyFontName): (KHTMLSettings::minFontSize): (KHTMLSettings::minLogicalFontSize): (KHTMLSettings::mediumFontSize): (KHTMLSettings::mediumFixedFontSize): (KHTMLSettings::autoLoadImages): (KHTMLSettings::isJavaScriptEnabled): (KHTMLSettings::JavaScriptCanOpenWindowsAutomatically): (KHTMLSettings::isJavaEnabled): (KHTMLSettings::isPluginsEnabled): (KHTMLSettings::encoding): (KHTMLSettings::userStyleSheet): (KHTMLSettings::shouldPrintBackgrounds): (KHTMLSettings::textAreasAreResizable): (KHTMLSettings::setStdFontName): (KHTMLSettings::setFixedFontName): (KHTMLSettings::setSerifFontName): (KHTMLSettings::setSansSerifFontName): (KHTMLSettings::setCursiveFontName): (KHTMLSettings::setFantasyFontName): (KHTMLSettings::setMinFontSize): (KHTMLSettings::setMinLogicalFontSize): (KHTMLSettings::setMediumFontSize): (KHTMLSettings::setMediumFixedFontSize): (KHTMLSettings::setAutoLoadImages): (KHTMLSettings::setIsJavaScriptEnabled): (KHTMLSettings::setIsJavaEnabled): (KHTMLSettings::setArePluginsEnabled): (KHTMLSettings::setJavaScriptCanOpenWindowsAutomatically): (KHTMLSettings::setEncoding): (KHTMLSettings::setUserStyleSheet): (KHTMLSettings::setShouldPrintBackgrounds): (KHTMLSettings::setTextAreasAreResizable):
  • kwq/KWQLoader.mm: (KWQServeSynchronousRequest):
  • kwq/KWQTextStream.cpp: (QTextStream::QTextStream): (QTextStream::operator<<): (QTextStream::precision):
  • kwq/KWQTextStream.h:
  • kwq/RenderTreeAsText.cpp: (operator<<): (quoteAndEscapeNonPrintables): (writeTextRun): (write): (writeSelection):
  • loader/Cache.cpp: (WebCore::Cache::init): (WebCore::Cache::requestImage): (WebCore::Cache::requestStyleSheet): (WebCore::Cache::preloadStyleSheet): (WebCore::Cache::requestScript): (WebCore::Cache::preloadScript): (WebCore::Cache::requestXSLStyleSheet): (WebCore::Cache::requestXBLDocument): (WebCore::Cache::remove):
  • loader/Cache.h:
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::error):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::error):
  • loader/CachedImage.h:
  • loader/CachedObject.h:
  • loader/CachedScript.cpp: (WebCore::CachedScript::checkNotify): (WebCore::CachedScript::error):
  • loader/CachedScript.h:
  • loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::error):
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::error):
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader): (WebCore::DocLoader::~DocLoader): (WebCore::DocLoader::needReload): (WebCore::DocLoader::requestImage): (WebCore::DocLoader::requestStyleSheet): (WebCore::DocLoader::requestScript): (WebCore::DocLoader::requestXSLStyleSheet): (WebCore::DocLoader::requestXBLDocument): (WebCore::DocLoader::setAutoloadImages): (WebCore::DocLoader::setShowAnimations): (WebCore::DocLoader::removeCachedObject):
  • loader/loader.cpp: (WebCore::Loader::receivedAllData): (WebCore::Loader::receivedResponse):
  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::setStyleSheet): (WebCore::Frame::didOpenURL): (WebCore::Frame::setMetaRefreshEnabled): (WebCore::Frame::setAutoloadImages): (WebCore::Frame::autoloadImages): (WebCore::Frame::clear): (WebCore::Frame::receivedFirstData): (WebCore::Frame::begin): (WebCore::Frame::write): (WebCore::Frame::baseTarget): (WebCore::Frame::completeURL): (WebCore::Frame::scheduleRedirection): (WebCore::Frame::scheduleLocationChange): (WebCore::Frame::scheduleHistoryNavigation): (WebCore::Frame::changeLocation): (WebCore::Frame::redirectionTimerFired): (WebCore::Frame::encoding): (WebCore::Frame::gotoAnchor): (WebCore::Frame::setStandardFont): (WebCore::Frame::setFixedFont): (WebCore::Frame::selectedText): (WebCore::Frame::selection): (WebCore::Frame::dragCaret): (WebCore::Frame::setSelection): (WebCore::Frame::setDragCaret): (WebCore::Frame::paintCaret): (WebCore::Frame::paintDragCaret): (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::requestObject): (WebCore::Frame::shouldUsePlugin): (WebCore::Frame::loadPlugin): (WebCore::Frame::loadSubframe): (WebCore::Frame::submitForm): (WebCore::Frame::lastModified): (WebCore::Frame::reparseConfiguration): (WebCore::Frame::shouldChangeSelection): (WebCore::Frame::appliedEditing): (WebCore::Frame::unappliedEditing): (WebCore::Frame::reappliedEditing): (WebCore::Frame::executeScript): (WebCore::updateState): (WebCore::Frame::isCharacterSmartReplaceExempt): (WebCore::Frame::openURL): (WebCore::Frame::didNotOpenURL): (WebCore::Frame::setEncoding): (WebCore::Frame::saveInterpreterBuiltins): (WebCore::Frame::restoreInterpreterBuiltins): (WebCore::Frame::mutableInstances): (WebCore::Frame::setPolicyBaseURL): (WebCore::Frame::addMetaData): (WebCore::Frame::scrollToAnchor): (WebCore::Frame::setMediaType): (WebCore::Frame::highlightAllMatchesForString): (WebCore::Frame::tree):
  • page/Frame.h: (WebCore::Frame::instances):
  • page/FramePrivate.h:
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::FrameView): (WebCore::FrameView::~FrameView): (WebCore::FrameView::init): (WebCore::FrameView::setMarginWidth): (WebCore::FrameView::setMarginHeight): (WebCore::FrameView::adjustViewSize): (WebCore::FrameView::layout): (WebCore::FrameView::dispatchDragEvent): (WebCore::FrameView::scrollTo): (WebCore::FrameView::setMediaType): (WebCore::FrameView::mediaType): (WebCore::FrameView::setResizingFrameSet): (WebCore::FrameView::setIgnoreWheelEvents):
  • page/FrameView.h: (WebCore::FrameView::frameWidth): (WebCore::FrameView::marginWidth): (WebCore::FrameView::marginHeight): (WebCore::FrameView::ref): (WebCore::FrameView::deref):
  • page/ResourceRequest.h: (WebCore::ResourceRequest::contentType): (WebCore::ResourceRequest::setContentType):
  • platform/FontFamily.h:
  • platform/Image.h:
  • platform/KURL.cpp: (KURL::KURL): (KURL::parse): (urlcmp): (KURL::encode_string): (encodeHostname):
  • platform/KURL.h:
  • platform/PlatformString.h: (WebCore::String::left): (WebCore::String::right):
  • platform/String.cpp: (WebCore::String::toInt):
  • platform/StringImpl.cpp: (WebCore::StringImpl::toInt):
  • platform/TransferJob.cpp: (WebCore::TransferJob::queryMetaData): (WebCore::TransferJob::addMetaData):
  • platform/TransferJob.h:
  • platform/mac/ImageMac.mm: (WebCore::Image::supportsType):
  • platform/mac/TransferJobMac.mm: (WebCore::TransferJob::start):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::information):
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::updateFromElement):
  • xml/xmlhttprequest.cpp: (WebCore::getMIMEType): (WebCore::getCharset): (WebCore::XMLHttpRequest::getReadyState): (WebCore::XMLHttpRequest::getResponseText): (WebCore::XMLHttpRequest::getResponseXML): (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::~XMLHttpRequest): (WebCore::XMLHttpRequest::changeState): (WebCore::XMLHttpRequest::callReadyStateChangeListener): (WebCore::XMLHttpRequest::urlMatchesDocumentDomain): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::overrideMIMEType): (WebCore::XMLHttpRequest::setRequestHeader): (WebCore::XMLHttpRequest::getRequestHeader): (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): (WebCore::XMLHttpRequest::responseIsXML): (WebCore::XMLHttpRequest::getStatus): (WebCore::XMLHttpRequest::getStatusText): (WebCore::XMLHttpRequest::processSyncLoadResults): (WebCore::XMLHttpRequest::receivedAllData): (WebCore::XMLHttpRequest::receivedRedirect): (WebCore::XMLHttpRequest::receivedData): (WebCore::XMLHttpRequest::cancelRequests): (WebCore::XMLHttpRequest::detachRequests):
  • xml/xmlhttprequest.h:
1:27 PM Changeset in webkit [13403] by bdakin
  • 5 edits in trunk/LayoutTests

Reviewed by Adele

I added a close comment tag to this layout test so that the layout
would not longer be affected by the unclosed <style> tag bug since
that is not the original aim of this test anyway.

12:46 PM Changeset in webkit [13402] by ap
  • 7 edits
    4 adds in trunk

Reviewed by Darin.


Implemented saving the previous node under the mouse, so that we don't need to
recalculate it, which is slow and even not really possible. This has fixed a number
of issues with mouse event dispatching when the content changes.
The code still needs refactoring and cleanup, see bug 3439 for comments.

Tests (both files perform multiple checks):

  • fast/events/mouseover-mouseout.html
  • fast/events/mouseover-mouseout2.html
  • page/Frame.h: Added a Frame parameter to passSubframeEventToSubframe(), used for mouseMoved events.
  • bridge/mac/FrameMac.h: Ditto.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::passSubframeEventToSubframe): Use the passed subframe to target NSMouseMoved events.
  • page/FrameView.h: Added a prepareMouseEvent() helper that does viewportToContents translation.
  • page/FrameView.cpp: Added data members for storing the previous node and subframe under the mouse to FrameViewPrivate. Removed the now unused prevMouseX/prevMouseY. (WebCore::FrameViewPrivate::reset): Reset the new data members. (WebCore::subframeForEvent): A temporary place for the code that extracts a subframe pointer from MouseEventWithHitTestResults, moved from FrameMac::passSubframeEventToSubframe(). (WebCore::FrameView::prepareMouseEvent): The new helper. (WebCore::FrameView::handleMousePressEvent): Use the new helper. (WebCore::FrameView::handleMouseDoubleClickEvent): Ditto. (WebCore::FrameView::handleMouseReleaseEvent): Ditto. (WebCore::FrameView::updateDragAndDrop): Ditto. (WebCore::FrameView::hoverTimerFired): Ditto. (WebCore::FrameView::dispatchMouseEvent): Store and use the oldUnder node, don't store or use prevMouseX/Y. (WebCore::FrameView::handleMouseMoveEvent): Rewrote dispatching events to subframes using a stored oldSubframe reference. Protect "this" from being removed while in this function.
11:58 AM Changeset in webkit [13401] by bdakin
  • 5 edits
    8 moves in trunk/LayoutTests

Reviewed by Adele

Updating pixel results for a few tables tests that have changed
with Hyatt's recent table work. Moving two of said tests into the
expected successes folder because they now completely pass. Yay!

9:04 AM Changeset in webkit [13400] by darin
  • 25 edits
    1 add
    2 deletes in trunk/WebCore

Reviewed by Anders.

  • dom/Range.idl: Added.
  • khtml/ecma/kjs_range.cpp: Removed.
  • khtml/ecma/kjs_range.h: Removed.
  • WebCore.vcproj/WebCore/build-generated-files.sh: Removed code to generate kjs_range.lut.h.
  • WebCore.xcodeproj/project.pbxproj: Added Range.idl source file. Removed kjs_range.h and kjs_range.cpp source files. Sorted the "dom" group. Removed rule to generate kjs_range.lut.h.
  • bindings/js/JSDOMCore.cpp: Added include of JSRange.cpp.
  • bindings/scripts/CodeGeneratorJS.pm: Added DocumentFragment, Range, CompareHow, and short to the types this script can handle. Added code to generate toRange functions and the like. Added separate code to handle exceptions for getters vs. setters for attributes. Changed return values for the "bad ID" case to 0 -- there's no need to generate the extra code to return jsUndefined() in such cases, which should be unreachable. Changed exception handling to use setDOMException directly instead of DOMExceptionTranslator; DOMExceptionTranslator was a trick to make it easier to convert existing bindings and shouldn't be used going forward. Fixed names of constructors to use the JavaScript class name (the interface name), not the name of the C++ implementation class. Fixed generation of code for functions that have no parameters but do raise exceptions.
  • bindings/scripts/IDLParser.pm: Added parsing for separate getter and setter exceptions in attributes. The syntax is not real IDL, but real IDL doesn't support declaring exceptions on attributes at all. We'll probably want to revisit our syntax for this some day.
  • bindings/scripts/IDLStructure.pm: Removed unused exceptionName field from domAttribute, and replaced raisesExceptions field with getterExceptions and setterExceptions. Added regular expressions for parsing getter/setter syntax. We'll probably have to redo this whole thing parse in a better way at some point -- the regular expressions allow any invalid syntax in between them.
  • dom/Attr.idl: Change exception declaration for setting the value attribute to use setter-specific exception syntax.
  • dom/CharacterData.idl: Change exception declaration for setting the data attribute to use setter-specific exception syntax.
  • dom/ProcessingInstruction.idl: Change exception declaration for setting the data attribute to use setter-specific exception syntax.
  • khtml/ecma/kjs_dom.cpp: Include JSRange.h instead of kjs_range.h.
  • khtml/ecma/kjs_window.cpp: Include JSRange.h instead of kjs_range.h. (KJS::Window::getValueProperty): Use JSRange::getConstructor instead of getRangeConstructor.
1:00 AM Changeset in webkit [13399] by eseidel
  • 4 edits in trunk/WebKitTools

2006-03-20 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix win32 build.

  • Spinneret/Spinneret/Spinneret.vcproj:
  • Spinneret/Spinneret/WebFrame.h:
  • Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebView::keyPress): (WebKit::WebViewWndProc):
1:00 AM Changeset in webkit [13398] by eseidel
  • 5 edits in trunk/WebCore

2006-03-20 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix win32 compile.

  • Viewer/ImageView.cpp:
  • platform/GraphicsContext.cpp: (WebCore::WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::WebCore::GraphicsContext::destroyGraphicsContextPrivate):
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::fillRectSourceOver): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawFocusRing):
  • platform/win/FontWin.cpp: (WebCore::Font::drawHighlightForText):
12:03 AM Changeset in webkit [13397] by darin
  • 62 edits
    72 copies
    1 delete in trunk/WebCore

Rubber stamped by Eric.

  • moved khtml/html files all into html directory
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for new paths.
  • WebCore.vcproj/WebCore/build-generated-files.sh: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • khtml/html: Removed.
  • html/DocTypeStrings.gperf: Moved.
  • html/FormDataList.cpp: Ditto.
  • html/FormDataList.h: Ditto.
  • html/HTMLBaseFontElement.cpp: Ditto.
  • html/HTMLBaseFontElement.h: Ditto.
  • html/HTMLButtonElement.cpp: Ditto.
  • html/HTMLButtonElement.h: Ditto.
  • html/HTMLCanvasElement.cpp: Ditto.
  • html/HTMLCanvasElement.h: Ditto.
  • html/HTMLCollection.cpp: Ditto.
  • html/HTMLCollection.h: Ditto.
  • html/HTMLDocument.cpp: Ditto.
  • html/HTMLDocument.h: Ditto.
  • html/HTMLElement.cpp: Ditto.
  • html/HTMLElement.h: Ditto.
  • html/HTMLElementFactory.cpp: Ditto.
  • html/HTMLElementFactory.h: Ditto.
  • html/HTMLEntityNames.gperf: Ditto.
  • html/HTMLFieldSetElement.cpp: Ditto.
  • html/HTMLFieldSetElement.h: Ditto.
  • html/HTMLFormCollection.cpp: Ditto.
  • html/HTMLFormCollection.h: Ditto.
  • html/HTMLFormElement.cpp: Ditto.
  • html/HTMLFormElement.h: Ditto.
  • html/HTMLGenericFormElement.cpp: Ditto.
  • html/HTMLGenericFormElement.h: Ditto.
  • html/HTMLInputElement.cpp: Ditto.
  • html/HTMLInputElement.h: Ditto.
  • html/HTMLIsIndexElement.cpp: Ditto.
  • html/HTMLIsIndexElement.h: Ditto.
  • html/HTMLKeygenElement.cpp: Ditto.
  • html/HTMLKeygenElement.h: Ditto.
  • html/HTMLLabelElement.cpp: Ditto.
  • html/HTMLLabelElement.h: Ditto.
  • html/HTMLLegendElement.cpp: Ditto.
  • html/HTMLLegendElement.h: Ditto.
  • html/HTMLNameCollection.cpp: Ditto.
  • html/HTMLNameCollection.h: Ditto.
  • html/HTMLNames.cpp: Ditto.
  • html/HTMLNames.h: Ditto.
  • html/HTMLOptGroupElement.cpp: Ditto.
  • html/HTMLOptGroupElement.h: Ditto.
  • html/HTMLOptionElement.cpp: Ditto.
  • html/HTMLOptionElement.h: Ditto.
  • html/HTMLOptionsCollection.cpp: Ditto.
  • html/HTMLOptionsCollection.h: Ditto.
  • html/HTMLParser.cpp: Ditto.
  • html/HTMLParser.h: Ditto.
  • html/HTMLSelectElement.cpp: Ditto.
  • html/HTMLSelectElement.h: Ditto.
  • html/HTMLTextAreaElement.cpp: Ditto.
  • html/HTMLTextAreaElement.h: Ditto.
  • html/HTMLTextFieldInnerElement.cpp: Ditto.
  • html/HTMLTextFieldInnerElement.h: Ditto.
  • html/HTMLTokenizer.cpp: Ditto.
  • html/HTMLTokenizer.h: Ditto.
  • html/html_baseimpl.cpp: Ditto.
  • html/html_baseimpl.h: Ditto.
  • html/html_blockimpl.cpp: Ditto.
  • html/html_blockimpl.h: Ditto.
  • html/html_headimpl.cpp: Ditto.
  • html/html_headimpl.h: Ditto.
  • html/html_imageimpl.cpp: Ditto.
  • html/html_imageimpl.h: Ditto.
  • html/html_inlineimpl.cpp: Ditto.
  • html/html_inlineimpl.h: Ditto.
  • html/html_listimpl.cpp: Ditto.
  • html/html_listimpl.h: Ditto.
  • html/html_objectimpl.cpp: Ditto.
  • html/html_objectimpl.h: Ditto.
  • html/html_tableimpl.cpp: Ditto.
  • html/html_tableimpl.h: Ditto.
  • bindings/objc/DOM.mm:
  • bridge/mac/WebCoreEncodings.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • css/CSSGrammar.y:
  • css/cssstyleselector.cpp:
  • dom/Document.cpp:
  • dom/EventTargetNode.cpp:
  • dom/NameNodeList.cpp:
  • dom/Node.cpp:
  • dom/Position.cpp:
  • dom/dom_elementimpl.cpp:
  • dom/xml_tokenizer.cpp:
  • editing/ApplyStyleCommand.cpp:
  • editing/BreakBlockquoteCommand.cpp:
  • editing/CompositeEditCommand.cpp:
  • editing/DeleteSelectionCommand.cpp:
  • editing/InsertLineBreakCommand.cpp:
  • editing/InsertParagraphSeparatorCommand.cpp:
  • editing/JSEditor.cpp:
  • editing/ReplaceSelectionCommand.cpp:
  • editing/TextIterator.cpp:
  • editing/VisiblePosition.cpp:
  • editing/htmlediting.cpp:
  • editing/markup.cpp:
  • editing/visible_units.cpp:
  • html/CanvasRenderingContext2D.cpp:
  • kcanvas/KCanvasTreeDebug.cpp:
  • khtml/ecma/JSDOMParser.cpp:
  • khtml/ecma/kjs_css.cpp:
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_events.cpp:
  • khtml/misc/decoder.cpp:
  • khtml/xsl/XSLStyleSheet.cpp:
  • khtml/xsl/XSLTProcessor.cpp:
  • ksvg2/misc/SVGImageLoader.h:
  • ksvg2/svg/SVGElement.cpp:
  • ksvg2/svg/SVGSVGElement.cpp:
  • kwq/WebCoreAXObject.mm:
  • page/Frame.cpp:
  • page/FrameView.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBox.cpp:
  • rendering/RenderFlow.cpp:
  • rendering/RenderHTMLCanvas.cpp:
  • rendering/RenderImage.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderTable.cpp:
  • rendering/RenderTableCell.cpp:
  • rendering/RenderTableCol.cpp:
  • rendering/RenderTableRow.cpp:
  • rendering/RenderTableSection.cpp:
  • rendering/RenderTextField.cpp:
  • rendering/RenderTheme.cpp:
  • rendering/render_applet.cpp:
  • rendering/render_button.cpp:
  • rendering/render_frames.cpp:
  • rendering/render_list.cpp: Updated includes.

Mar 19, 2006:

11:30 PM Changeset in webkit [13396] by eseidel
  • 18 edits in trunk/WebCore

2006-03-17 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Move Form code from MacFrame to Frame.
Move GraphicsContext code from GraphicsContextMac to GraphicsContext.
Use IntRect, FloatRect in more places throughout the code.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7824

  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::MacFrame): (WebCore::MacFrame::searchForLabelsAboveCell): (WebCore::MacFrame::searchForLabelsBeforeElement): (WebCore::dictionaryFromHashMap): (WebCore::MacFrame::submitForm): (WebCore::MacFrame::setView): (WebCore::MacFrame::currentEventIsMouseDownInWidget): (WebCore::MacFrame::currentEventIsKeyboardOptionTab): (WebCore::MacFrame::handleKeyboardOptionTabInView): (WebCore::MacFrame::tabsToAllControls): (WebCore::MacFrame::shouldDragAutoNode): (WebCore::MacFrame::selectionImage): (WebCore::MacFrame::snapshotDragImage):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge nextKeyView]): (-[WebCoreFrameBridge previousKeyView]): (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]):
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::clearRecordedFormValues): (WebCore::Frame::recordFormValue): (WebCore::Frame::didNotOpenURL): (WebCore::scanForForm): (WebCore::Frame::paint): (WebCore::Frame::prepareForUserAction):
  • page/Frame.h:
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContextPrivate::~GraphicsContextPrivate): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setBrush): (WebCore::GraphicsContext::brush): (WebCore::GraphicsContext::setUsesInactiveTextBackgroundColor): (WebCore::GraphicsContext::usesInactiveTextBackgroundColor): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::printing): (WebCore::GraphicsContext::drawImageAtPoint): (WebCore::GraphicsContext::drawImageInRect): (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::initFocusRing): (WebCore::GraphicsContext::clearFocusRing): (WebCore::GraphicsContext::addFocusRingRect): (WebCore::GraphicsContext::focusRingWidth): (WebCore::GraphicsContext::focusRingOffset): (WebCore::GraphicsContext::focusRingRects):
  • platform/GraphicsContext.h:
  • platform/mac/GraphicsContextMac.mm: (WebCore::fillRectSourceOver): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::setColorFromBrush): (WebCore::GraphicsContext::setColorFromPen): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawFloatImage): (WebCore::GraphicsContext::drawTiledImage): (WebCore::GraphicsContext::drawScaledAndTiledImage): (WebCore::GraphicsContext::selectedTextBackgroundColor): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::addClip): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::drawFocusRing):
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended): (WebCore::RenderBox::outlineBox):
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize):
  • rendering/render_image.cpp: (WebCore::RenderImage::paint):
  • rendering/render_list.cpp: (WebCore::RenderListMarker::paint):
  • rendering/render_object.cpp: (WebCore::RenderObject::drawBorder): (WebCore::RenderObject::paintBorderImage):
11:25 PM Changeset in webkit [13395] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • html/CanvasGradient.cpp: (WebCore::CanvasGradient::platformShading): Don't make the CG shading object keep a reference to the DOM gradient object. I got confused because in the case of a CanvasPattern, the pattern does need to keep a reference to the DOM pattern object, but the object lifetime is handled differently here. The CG shading object is used right away, not set in a graphics context.
11:20 PM Changeset in webkit [13394] by darin
  • 4 edits
    2 adds in trunk/WebCore

Reviewed by Eric.

  • attempt to fix the buildbot by handling DOMImplementation another way
  • WebCore.xcodeproj/project.pbxproj: Added DOMImplementationFront.h/cpp.
  • bindings/objc/DOMImplementationFront.cpp: Added.
  • bindings/objc/DOMImplementationFront.h: Added.
  • bindings/objc/DOMInternal.h: Use DOMImplementationFront, not DOMImplementation.
  • bindings/objc/DOM.mm: (-[DOMImplementation dealloc]): Ditto. (-[DOMImplementation finalize]): Ditto. (-[DOMImplementation _initWithDOMImplementation:]): Ditto. (+[DOMImplementation _DOMImplementationWith:]): Ditto. (-[DOMImplementation _DOMImplementation]): Ditto. (-[DOMDocument implementation]): Call implementationFront from the DOMImplementationFront header instead of using the real implementation function on the Document.
6:57 PM Changeset in webkit [13393] by darin
  • 453 edits
    446 moves in trunk/WebCore
  • global rename, done by script
  • <lots of files>: Renamed XXXImpl to XXX, and a number of other renames. See WebKitTools/Scripts/do-webcore-rename version 13392 for details.
5:01 PM Changeset in webkit [13392] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Another round of refinement. Ready to go now, but looks like I'm going to have to wait and do this next week.

10:55 AM Changeset in webkit [13391] by darin
  • 3 edits in trunk/WebKitTools

Reviewed by Anders.

  • DumpRenderTree/DumpRenderTree.m: (main): Turn on pop-up blocking so that we can test it in layout tests. We don't really need tests that run with pop-up blocking off at the moment. If we do some day, we can add some API for turning it off in the layout test controller.
  • Scripts/run-webkit-tests: Since we don't use NSLanguage at all any more, don't ignore the leak; it should no longer show up.
10:40 AM Changeset in webkit [13390] by darin
  • 11 edits
    8 adds in trunk

LayoutTests:

  • fast/js/exception-linenums-in-html-3-expected.txt:
  • fast/js/exception-linenums-in-html-3-expected.png: Added.
  • fast/js/exception-linenums-in-html-3-expected.checksum: Added.
  • fast/js/missing-style-end-tag-js-expected.txt:
  • fast/js/missing-style-end-tag-js-expected.png: Added.
  • fast/js/missing-style-end-tag-js-expected.checksum: Added.
  • fast/tokenizer/missing-style-end-tag-1-expected.checksum:
  • fast/tokenizer/missing-style-end-tag-1-expected.png:
  • fast/tokenizer/missing-style-end-tag-1-expected.txt:
  • fast/tokenizer/missing-style-end-tag-2-expected.checksum:
  • fast/tokenizer/missing-style-end-tag-2-expected.png:
  • fast/tokenizer/missing-style-end-tag-2-expected.txt:
  • added some missing pixel-test results
  • tables/mozilla/marvin/backgr_layers-opacity-expected.checksum: Added.
  • tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
  • fast/dom/Element/class-attribute-whitespace-expected.png: Added.
  • fast/canvas/patternfill-repeat-expected.png: Added.

WebCore:

This fix was breaking major sites -- details in the bug report.

  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Removed the bug fix, added a FIXME about the <title> code that has the same problem.
10:13 AM Changeset in webkit [13389] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Another round, believe it or not. About ready to go.

8:56 AM Changeset in webkit [13388] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Another round of tweaks after another dry run.

Note: See TracTimeline for information about the timeline view.