Context Navigation

← Previous Period
Next Period →

Timeline

Apr 12, 2006:

11:32 PM Changeset in webkit [13858] by darin

97 edits
18 deletes in trunk/WebCore

Rubber-stamped by Anders.

get ready for some more de-KWQ-ing done by the renaming script in two ways

1) stop using forwarding headers for things within WebCore
2) remove a bit of unused stuff

loader/CachedImage.h:
loader/CachedImage.cpp:
loader/DocLoader.cpp:
loader/DocLoader.h:
page/Frame.cpp:
xml/XSLTProcessor.cpp: Removed unused showAnimations functions and data. We can add back later if we need it. And if we do, we won't use a typedef from KHTMLSettings.

ForwardingHeaders/java: Removed.
ForwardingHeaders/java/kjavaappletwidget.h: Removed.
ForwardingHeaders/khtml_settings.h: Removed.
ForwardingHeaders/kio: Removed.
ForwardingHeaders/kio/global.h: Removed.
ForwardingHeaders/ksslkeygen.h: Removed.
ForwardingHeaders/q3ptrlist.h: Removed.
ForwardingHeaders/q3valuelist.h: Removed.
ForwardingHeaders/qcombobox.h: Removed.
ForwardingHeaders/qfontmetrics.h: Removed.
ForwardingHeaders/qlineedit.h: Removed.
ForwardingHeaders/qmatrix.h: Removed.
ForwardingHeaders/qptrlist.h: Removed.
ForwardingHeaders/qptrqueue.h: Removed.
ForwardingHeaders/qregexp.h: Removed.
ForwardingHeaders/qscrollbar.h: Removed.
ForwardingHeaders/qtextedit.h: Removed.
ForwardingHeaders/qtextstream.h: Removed.
ForwardingHeaders/qvaluelist.h: Removed.
ForwardingHeaders/qwmatrix.h: Removed.

WebCore+SVG/DOMList.h:
bindings/js/kjs_dom.cpp:
bindings/js/kjs_dom.h:
bindings/js/kjs_window.cpp:
css/css_stylesheetimpl.h:
css/css_valueimpl.cpp:
css/css_valueimpl.h:
css/cssstyleselector.cpp:
dom/CharacterData.cpp:
dom/Document.cpp:
dom/Document.h:
dom/EventTargetNode.cpp:
dom/Node.cpp:
editing/BreakBlockquoteCommand.h:
editing/htmlediting.cpp:
html/FormDataList.h:
html/HTMLKeygenElement.cpp:
html/HTMLTokenizer.h:
html/html_objectimpl.cpp:
kcanvas/KCanvasFilters.cpp:
kcanvas/KCanvasMatrix.cpp:
kcanvas/KCanvasMatrix.h:
kcanvas/KCanvasPath.cpp:
kcanvas/KCanvasPath.h:
kcanvas/KCanvasResources.cpp:
kcanvas/KCanvasTreeDebug.h:
kcanvas/RenderForeignObject.h:
kcanvas/RenderPath.h:
kcanvas/RenderSVGImage.h:
kcanvas/RenderSVGText.h:
kcanvas/device/KRenderingPaintServerGradient.cpp:
kcanvas/device/KRenderingPaintServerPattern.cpp:
kcanvas/device/KRenderingPaintServerSolid.cpp:
kcanvas/device/quartz/KCanvasItemQuartz.h:
kcanvas/device/quartz/KCanvasResourcesQuartz.h:
ksvg2/svg/SVGColor.cpp:
ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
ksvg2/svg/SVGDocument.h:
ksvg2/svg/SVGFEBlendElement.cpp:
ksvg2/svg/SVGFEColorMatrixElement.cpp:
ksvg2/svg/SVGFEComponentTransferElement.cpp:
ksvg2/svg/SVGFECompositeElement.cpp:
ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
ksvg2/svg/SVGFEDisplacementMapElement.cpp:
ksvg2/svg/SVGFEGaussianBlurElement.cpp:
ksvg2/svg/SVGFELightElement.cpp:
ksvg2/svg/SVGFEMergeElement.cpp:
ksvg2/svg/SVGFEOffsetElement.cpp:
ksvg2/svg/SVGFESpecularLightingElement.cpp:
ksvg2/svg/SVGFETileElement.cpp:
ksvg2/svg/SVGFETurbulenceElement.cpp:
ksvg2/svg/SVGFitToViewBox.cpp:
ksvg2/svg/SVGLengthList.cpp:
ksvg2/svg/SVGMatrix.h:
ksvg2/svg/SVGNumberList.cpp:
ksvg2/svg/SVGPreserveAspectRatio.cpp:
ksvg2/svg/SVGSVGElement.cpp:
ksvg2/svg/SVGStringList.cpp:
ksvg2/svg/SVGStyledElement.h:
ksvg2/svg/SVGStyledTransformableElement.cpp:
ksvg2/svg/SVGTransformable.cpp:
ksvg2/svg/SVGURIReference.h:
ksvg2/svg/svgpathparser.cpp:
kwq/KWQKHTMLSettings.h:
loader/Cache.h:
loader/CachedObject.h:
loader/Decoder.cpp:
loader/FormData.h:
loader/loader.h:
page/Frame.h:
page/FramePrivate.h:
platform/Font.cpp:
platform/SegmentedString.h:
platform/mac/FontMac.mm:
platform/mac/WebCoreTextField.mm:
rendering/RenderBlock.cpp:
rendering/RenderObject.cpp:
rendering/RenderTable.cpp:
rendering/RenderTableCell.cpp:
rendering/RenderTableCol.cpp:
rendering/RenderTableSection.cpp:
rendering/bidi.h:
rendering/break_lines.cpp:
rendering/render_applet.cpp:
rendering/render_form.cpp:
rendering/render_form.h:
rendering/render_frames.cpp:
rendering/render_style.h:
xml/xmlhttprequest.cpp: Updated includes.

WebCore.xcodeproj/project.pbxproj: Resorted a couple things.

10:43 PM Changeset in webkit [13857] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Plans for another round of renaming (eliminating KWQ).

8:19 PM Changeset in webkit [13856] by thatcher

1 edit in trunk/WebCore/bridge/mac/FrameMac.mm

Fixes the build.

7:00 PM Changeset in webkit [13855] by justing

1 edit
4 adds in trunk/LayoutTests

Reviewed by harrison

Layout test for the changes made to VisiblePosition::init in r13825.

editing/selection/unrendered-space.html
editing/selection/unrendered-space-expected.png
editing/selection/unrendered-space-expected.checksum
editing/selection/unrendered-space-expected.txt

6:50 PM Changeset in webkit [13854] by adele

24 edits
2 adds in trunk

LayoutTests:

Test for setSelectionRange bug in text fields.

fast/forms/input-delete-expected.txt: Added.
fast/forms/input-delete.html: Added.

WebCore:

Reviewed by Darin and Tim O.

WebCore part of fix for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=8061
REGRESSION: New text fields need to send callbacks used by autocomplete

Fix for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=8156
FrameMac::submitForm is busted after Vector changes

bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _rectOnScreen]): Use boundingBox method so this no longer relies on an NSTextField. The old code is no longer needed because this method was used by autocomplete, and that was not enabled for password or search fields. (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]): New implementation that uses setValue and setSelectionRange instead of NSTextField specific code. (-[DOMHTMLInputElement _selectedRange]): Creates range by calling selectionStart and selectionEnd on the input element. (-[DOMHTMLInputElement _setAutofilled:]): Provides a way for the autofill code to set a flag on the input element so it knows when its value is set by autofill. This is how we change the background color.
bindings/objc/DOMPrivate.h: Removed _displayedValue, _setDisplayedValue, _setBackgroundColor since these are no longer needed for the new text field implementation, and aren't used for remaining NSView-style password and search fields. Added _setAutofilled method.
bridge/mac/FrameMac.h: Added virtual clearRecordedFormValues and recordFormValue. These were moved into Frame.cpp recently, which broke how Safari asked to add form values to the keychain.

bridge/mac/FrameMac.mm: (WebCore::createNSDictionary): Added. Converts a hashmap to an NSDictionary for m_formValuesAboutToBeSubmitted. This is needed to fix the submit form bug. (WebCore::selectorForKeyEvent): Added. This helper function converts key events into selectors that the autocomplete code needs to know about. (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::submitForm): Convert saved form and formValues into DOMElement and NSMutableDictionary. (WebCore::FrameMac::textFieldDidBeginEditing): Added so the input element can send this notification over the bridge. (WebCore::FrameMac::textFieldDidEndEditing): ditto. (WebCore::FrameMac::textDidChangeInTextField): ditto. (WebCore::FrameMac::doTextFieldCommandFromEvent): ditto. Also calls selectorForKeyEvent. (WebCore::FrameMac::textWillBeDeletedInTextField): ditto.
page/Frame.cpp: (WebCore::Frame::textFieldDidBeginEditing): ditto. (WebCore::Frame::textFieldDidEndEditing): ditto. (WebCore::Frame::textDidChangeInTextField): ditto. (WebCore::Frame::doTextFieldCommandFromEvent): ditto. (WebCore::Frame::textWillBeDeletedInTextField): ditto.
page/Frame.h: ditto.
platform/PlatformString.h: (WebCore::String::replace): Added to use an existing version of StringImpl::replace.

rendering/RenderTextField.cpp: (WebCore::RenderTextField::setSelectionRange): Setting the selection here should close the typing command. (WebCore::RenderTextField::subtreeHasChanged): Calls textDidChangeInTextField.

dom/Document.cpp: (WebCore::Document::setFocusNode): Calls dispatchFocusEvent and dispatchBlurEvent instead of directly dispatching the events. This gives the node a chance to do other work before dispatching the event.

dom/EventTargetNode.cpp:

(WebCore

EventTargetNode::dispatchFocusEvent): Added.

(WebCore

EventTargetNode::dispatchBlurEvent): Added.

dom/EventTargetNode.h:

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::init): initializes m_autofilled. (WebCore::HTMLInputElement::dispatchFocusEvent): Calls textFieldDidBeginEditing and then calls up to the base class (WebCore::HTMLInputElement::dispatchBlurEvent): Calls textFieldDidEndEditing and then calls up to the base class (WebCore::HTMLInputElement::defaultEventHandler): For keypress events, calls doTextFieldCommandFromEvent so the form delegate will have a chance to say whether or not it is going to handle the event.

(WebCore::HTMLInputElement::isKeyboardFocusable): Uses isNonWidgetTextField instead of checking the inputType.

(WebCore::HTMLInputElement::isMouseFocusable): ditto.
(WebCore::HTMLInputElement::focus): ditto.
(WebCore::HTMLInputElement::constrainValue): Uses isTextField instead of checking inputType.

html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): ditto.
html/HTMLInputElement.h: (WebCore::HTMLInputElement::isTextField): Added. Checks for TEXT, PASSWORD, and SEARCH (WebCore::HTMLInputElement::isNonWidgetTextField): Added. Checks for all converted controls. (WebCore::HTMLInputElement::autofilled): Added. (WebCore::HTMLInputElement::setAutofilled): Added.
html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerElement::defaultEventHandler): Uses isNonWidgetTextField instead of checking the inputType.

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): If the deletion is occuring in a text field, call textWillBeDeletedInTextField so the frame can call across the bridge to notify the form delegate.

css/css_base.cpp: (WebCore::CSSSelector::extractPseudoType): Added autofill string for "-khtml-autofill".
css/css_base.h: (WebCore::CSSSelector::): Added PseudoAutofill to enum.
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Added case for PseudoAutofill that checks the input element's autofilled flag. (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): Changed -webkit-focus-ring-color to -khtml-focus-ring-color for consistency.
css/html4.css: Added background-color and background-image for input:-khtml-autofill style. Changed -webkit-focus-ring-color to -khtml-focus-ring-color for consistency.
css/CSSValueKeywords.in: ditto.
css/cssparser.cpp: (WebCore::CSSParser::parseValue): ditto. (WebCore::CSSParser::parseShadow): ditto.

6:31 PM Changeset in webkit [13853] by justing

110 edits in trunk

LayoutTests:

Reviewed by hyatt

updated test results for http://bugzilla.opendarwin.org/show_bug.cgi?id=4855 List item's bullets fail to redraw correctly after their style is set with JavaScript

css1/basic/class_as_selector-expected.txt:
css1/basic/containment-expected.txt:
css1/basic/contextual_selectors-expected.txt:
css1/basic/id_as_selector-expected.txt:
css1/box_properties/border_bottom-expected.txt:
css1/box_properties/border_left-expected.txt:
css1/box_properties/border_right_inline-expected.txt:
css1/box_properties/border_top-expected.txt:
css1/box_properties/clear_float-expected.txt:
css1/box_properties/margin-expected.txt:
css1/box_properties/margin_bottom-expected.txt:
css1/box_properties/margin_left-expected.txt:
css1/box_properties/margin_right-expected.txt:
css1/box_properties/margin_top-expected.txt:
css1/box_properties/padding_left-expected.txt:
css1/box_properties/padding_right-expected.txt:
css1/cascade/cascade_order-expected.txt:
css1/classification/display-expected.txt:
css1/classification/list_style-expected.txt:
css1/classification/list_style_image-expected.txt:
css1/classification/list_style_position-expected.txt:
css1/classification/list_style_type-expected.txt:
css1/conformance/forward_compatible_parsing-expected.txt:
css1/pseudo/anchor-expected.txt:
css2.1/t0402-c71-fwd-parsing-02-f-expected.txt:
css2.1/t0505-c16-descendant-01-e-expected.txt:
css2.1/t050803-c14-classes-00-e-expected.txt:
css2.1/t0509-c15-ids-01-e-expected.txt:
css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
css2.1/t1205-c561-list-displ-00-b-expected.txt:
css2.1/t1205-c563-list-type-00-b-expected.txt:
css2.1/t1205-c563-list-type-01-b-expected.txt:
css2.1/t1205-c564-list-img-00-b-g-expected.txt:
css2.1/t1205-c565-list-pos-00-b-expected.txt:
css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
css2.1/t1205-c566-list-stl-01-c-g-expected.txt:
editing/deleting/delete-listitem-002-expected.txt:
editing/execCommand/insertHTML-expected.txt:
editing/pasteboard/paste-4039777-fix-expected.txt:
editing/pasteboard/paste-list-001-expected.txt:
editing/selection/extend-by-word-002-expected.txt:
editing/selection/move-by-line-002-expected.txt:
editing/selection/select-all-iframe-expected.txt:
editing/selection/selectNode-expected.txt:
editing/selection/selectNodeContents-expected.txt:
editing/unsupported-content/list-type-after-expected.txt:
editing/unsupported-content/list-type-before-expected.txt:
fast/block/float/014-expected.txt:
fast/css-generated-content/009-expected.txt:
fast/css/001-expected.txt:
fast/css/001-expected.png:
fast/css/001-expected.checksum:
fast/css/continuationCrash-expected.txt:
fast/css/list-outline-expected.txt:
fast/doctypes/001-expected.txt:
fast/doctypes/002-expected.txt:
fast/doctypes/003-expected.txt:
fast/doctypes/004-expected.txt:
fast/dom/window-onFocus-expected.txt:
fast/forms/form-hides-table-expected.txt:
fast/forms/plaintext-mode-2-expected.txt:
fast/lists/001-expected.checksum:
fast/lists/001-expected.png:
fast/lists/001-expected.txt:
fast/lists/002-expected.txt:
fast/lists/003-expected.txt:
fast/lists/004-expected.txt:
fast/lists/005-expected.txt:
fast/lists/006-expected.txt:
fast/lists/007-expected.txt:
fast/lists/008-expected.txt:
fast/lists/009-expected.txt:
fast/lists/drag-into-marker-expected.txt:
fast/lists/li-br-expected.txt:
fast/lists/ol-display-types-expected.txt:
fast/lists/olstart-expected.txt:
fast/lists/scrolled-marker-paint-expected.txt:
fast/overflow/overflow-rtl-expected.txt:
fast/parser/entities-in-xhtml-expected.txt:
fast/selectors/001-expected.txt:
fast/selectors/013-expected.txt:
fast/selectors/015-expected.txt:
fast/selectors/166-expected.txt:
fast/table/018-expected.txt:
fast/table/form-with-table-style-expected.txt:
fast/text/whitespace/tab-character-basics-expected.txt:
fast/tokenizer/004-expected.txt:
tables/mozilla/bugs/bug23235-expected.txt:
tables/mozilla/bugs/bug30692-expected.txt:
tables/mozilla/bugs/bug3191-expected.txt:
tables/mozilla/bugs/bug32205-2-expected.txt:
tables/mozilla/marvin/backgr_index-expected.txt:
tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
tables/mozilla/marvin/x_table-expected.txt:
tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
tables/mozilla/other/wa_table_tr_align-expected.txt:
tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:

WebCore:

Reviewed by hyatt

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4855 List item's bullets fail to redraw correctly after their style is set with JavaScript

manual-tests/list-marker-repaint.html: Added.
rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Call positionListMarker() after laying out the children. (WebCore::RenderBlock::calcInlineMinMaxWidth): Call calcWidth() on the child if we are going to use its marginLeft() or marginRight(), which is if they are given as a percentage or if the child is a list marker.
rendering/RenderBlock.h: (WebCore::RenderBlock::positionListMarker): Added this virtual function which RenderListItem implements and which is called from layoutBlock().
rendering/RenderFlow.cpp: (WebCore::RenderFlow::addFocusRingRects): Avoid adding focus rings around outside list markers. Previously it did not matter since the markers had zero width.
rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Outside list markers should not contribute to the line width, even now that they have width.
rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Skip outside list markers.
rendering/render_list.cpp: (WebCore::RenderListItem::positionListMarker): Added. (WebCore::RenderListMarker::paint): Removed code that was used to right-align outside text markers, since that is achieved by margins now. (WebCore::RenderListMarker::calcMinMaxWidth): Changed the marker height to be the font height. Made the width of outside list markers non-zero and equal to the width of inside markers. Changed the width to include only the marker and not any padding. Increased the width of bullets by 2 to contain spillage due to antialiasing. (WebCore::RenderListMarker::calcWidth): Calculate horizontal margins. Padding that was previously included in the width is now part of the margins. (WebCore::RenderListMarker::getRelativeMarkerRect): Adjusted for the changes to width and margins.
rendering/render_list.h:

5:36 PM Changeset in webkit [13852] by darin

3 edits
14 moves in trunk/WebCore

Rubber-stamped by Hyatt.

moved some more files out of KWQ to more-permanent homes

WebCore.vcproj/WebCore/WebCore.vcproj: Updated for new locations.
WebCore.xcodeproj/project.pbxproj: Ditto.

kwq/BlockExceptions.h: Removed.
kwq/BlockExceptions.mm: Removed.
kwq/ClipboardMac.h: Removed.
kwq/ClipboardMac.mm: Removed.
kwq/DeprecatedPtrList.h: Removed.
kwq/DeprecatedPtrListImpl.cpp: Removed.
kwq/DeprecatedPtrListImpl.h: Removed.
kwq/DeprecatedValueList.h: Removed.
kwq/DeprecatedValueListImpl.cpp: Removed.
kwq/DeprecatedValueListImpl.h: Removed.
kwq/WebCoreTextArea.h: Removed.
kwq/WebCoreTextArea.mm: Removed.
kwq/WebCoreTextField.h: Removed.
kwq/WebCoreTextField.mm: Removed.
platform/DeprecatedPtrList.h: Added.
platform/DeprecatedPtrListImpl.cpp: Added.
platform/DeprecatedPtrListImpl.h: Added.
platform/DeprecatedValueList.h: Added.
platform/DeprecatedValueListImpl.cpp: Added.
platform/DeprecatedValueListImpl.h: Added.
platform/mac/BlockExceptions.h: Added.
platform/mac/BlockExceptions.mm: Added.
platform/mac/ClipboardMac.h: Added.
platform/mac/ClipboardMac.mm: Added.
platform/mac/WebCoreTextArea.h: Added.
platform/mac/WebCoreTextArea.mm: Added.
platform/mac/WebCoreTextField.h: Added.
platform/mac/WebCoreTextField.mm: Added.

5:21 PM Changeset in webkit [13851] by harrison

10 edits
4 adds in trunk/LayoutTests

<rdar://problem/4386640> AX: AXPreviousSentenceStartTextMarkerForTextMarker does not respect paragraph boundary
<rdar://problem/4414575> AX: Dictionary popup cannot find some words on Dictionary.app

editing/editing.js: Add sentence navigation/selection.

editing/selection/extend-by-sentence-001-expected.txt: Added.
editing/selection/extend-by-sentence-001.html: Added. Test for both <rdar://problem/4386640> and <rdar://problem/4414575>.

fast/dom/inner-text-001-expected.txt: Added.
fast/dom/inner-text-001.html: Added. Tests innerText on a variety of elements.

fast/dom/HTMLObjectElement/form/test1-expected.txt:
fast/events/mouseclick-target-and-positioning-expected.txt:
fast/forms/button-in-forms-collection-expected.txt:
fast/forms/focus-control-to-page-expected.txt:
fast/forms/focus-expected.txt:
fast/forms/textarea-hard-linewrap-expected.txt:
fast/forms/textarea-setvalue-submit-expected.txt:
fast/loader/loadInProgress-expected.txt: Updated for innerText changes that emit newlines for more kinds of blocks.

5:18 PM Changeset in webkit [13850] by harrison

4 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4386640> AX: AXPreviousSentenceStartTextMarkerForTextMarker does not respect paragraph boundary
<rdar://problem/4414575> AX: Dictionary popup cannot find some words on Dictionary.app

(see related changes in WebCore)

Tests added:

editing/selection/extend-by-sentence-001.html: Added.
fast/dom/inner-text-001.html: Added.

WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): (-[NSArray moveToBeginningOfSentence:]): (-[NSArray moveToBeginningOfSentenceAndModifySelection:]): (-[NSArray moveToEndOfSentence:]): (-[NSArray moveToEndOfSentenceAndModifySelection:]): (-[NSArray selectSentence:]):
WebView/WebView.m:
WebView/WebViewPrivate.h: Add sentence navigation and selection.

5:14 PM Changeset in webkit [13849] by harrison

10 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4386640> AX: AXPreviousSentenceStartTextMarkerForTextMarker does not respect paragraph boundary
<rdar://problem/4414575> AX: Dictionary popup cannot find some words on Dictionary.app

AXPreviousSentenceStartTextMarkerForTextMarker failed to stop at the beginning a block because
SimplifiedBackwardsTextIterator::handleNonTextNode() emitted a space when exiting the block.
Fixed by emitting a newline instead.

Word boundary failed to stop at the beginning of a block because no character at all was emitted
when leaving the block, because the exitNode was checking specific html tags to decide whether the
node is block, but the node was xml. Fixed by using the node's renderer, if present.

(see related changes in WebKit)

Tests added:

editing/selection/extend-by-sentence-001.html: Added.
fast/dom/inner-text-001.html: Added.

bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]): Add sentence navigation/selection.

editing/Selection.cpp: (WebCore::Selection::validate): Add sentence navigation/selection.

editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): (WebCore::SelectionController::modifyMovingRightForward): (WebCore::SelectionController::modifyExtendingLeftBackward): (WebCore::SelectionController::modifyMovingLeftBackward): (WebCore::SelectionController::modify): Add sentence navigation/selection.

editing/TextGranularity.h: (WebCore::): Add SentenceGranularity and SentenceBoundary.

editing/TextIterator.cpp: (WebCore::isTableCell): (WebCore::shouldEmitTabBeforeNode): (WebCore::shouldEmitNewlineForNode): (WebCore::shouldEmitNewlinesBeforeAndAfterNode): (WebCore::shouldEmitExtraNewlineForNode): New utility functions that prefer renderers over html tag names.

(WebCore::TextIterator::handleNonTextNode):
(WebCore::TextIterator::exitNode):
(WebCore::SimplifiedBackwardsTextIterator::advance):
Use new utility functions.

(WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode):
Use new utility functions. Also emit linefeed instead of space,
so sentence parsing works across block boundaries.

(WebCore::SimplifiedBackwardsTextIterator::exitNode):
Use new utility functions.

(WebCore::SimplifiedBackwardsTextIterator::emitNewline):
Renamed from emitNewlineForBROrText because it is not always for BR or text.

editing/TextIterator.h: Renamed emitNewlineForBROrText to emitNewline.

editing/visible_units.cpp:
editing/visible_units.h: (WebCore::previousBoundary): (WebCore::nextBoundary): (WebCore::previousSentencePosition): (WebCore::nextSentencePosition): Add sentence navigation/selection.

4:54 PM Changeset in webkit [13848] by darin

11 edits
4 copies
1 move
1 delete in trunk/WebCore

Rubber-stamped by Hyatt.

moved Decoder and FormData classes into loader directory (Decoder, because it's part of the loading process.

FormData, because it's used as a parameter when specifying
what to load. Arguably either could be in page instead.)

moved Length.h from css to renderer, cause that's where Hyatt says it belongs

WebCore.vcproj/WebCore/WebCore.vcproj: Updated for new locations.
WebCore.xcodeproj/project.pbxproj: Ditto.

khtml: Removed.
loader/Decoder.cpp: Added.
loader/Decoder.h: Added.
loader/FormData.cpp: Added.
loader/FormData.h: Added.

css/Length.h: Removed.
rendering/Length.h: Added.

bridge/mac/WebCoreEncodings.mm:
dom/Document.h:
kwq/KWQFormData.mm:
loader/CachedXBLDocument.cpp:
loader/CachedXSLStyleSheet.cpp:
page/ResourceRequest.h:
platform/TransferJobInternal.h:
xml/xmlhttprequest.cpp: Updated includes.

4:49 PM Changeset in webkit [13847] by darin

2 edits in trunk/WebKitTools

Rubber-stamped by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8348 upload-disk-image stage on buildslaves fail with "No space left on device"

BuildSlaveSupport/build-launcher-dmg: Use the -srcfolder option to 'hdiutil create'. This creates the initial disk image based on the size of the source folder, and copies the contents to the new disk image. The file extension on the temporary uncompressed disk image has also been altered from ".uncompressed" to ".uncompressed.dmg" as hdiutil on 10.4.6 Intel fails when the extension is not ".dmg".

4:13 PM Changeset in webkit [13846] by justing

2 edits
1 add in trunk/WebCore

Reviewed by darin

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8337 Incomplete repaint of inlines' outline during editing

manual-tests/inline-outline-repaint.html: Added.
rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Add the maximal outline width to the inlines' repaint rect.

4:01 PM Changeset in webkit [13845] by hyatt

2 edits in trunk/LayoutTests/http/tests/misc

Fix broken test results.

2:54 PM Changeset in webkit [13844] by justing

1 edit in trunk/WebCore/editing/JSEditor.cpp

Removed unnecessary check for an empty string.

2:51 PM Changeset in webkit [13843] by justing

3 edits
4 adds in trunk

LayoutTests:

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=8335>
Implement execCommand(InsertHorizontalRule)

editing/deleting/merge-unrendered-space.html:
editing/execCommand/insertHorizontalRule-expected.checksum: Added.
editing/execCommand/insertHorizontalRule-expected.png: Added.
editing/execCommand/insertHorizontalRule-expected.txt: Added.
editing/execCommand/insertHorizontalRule.html: Added.

WebCore:

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=8335>
Implement execCommand(InsertHorizontalRule)

editing/JSEditor.cpp:

2:50 PM Changeset in webkit [13842] by eseidel

1 copy in branches/treecode-stable

Make a "stable" copy of treecode, which ggaren and I can drive towards TOT, independent of mjs' re-working.

2:43 PM Changeset in webkit [13841] by tomernic

2 edits in trunk/WebKit

Reviewed by Darin.

Part of <rdar://problem/4482530>

WebView/WebView.m: (-[WebView _focusedFrame]): Fixed up the logic here to take into account immediate subviews of WebView, which are not actually in a WebFrameView (they are peers to the main frame's WebFrameView).

1:21 PM Changeset in webkit [13840] by hyatt

7 edits in trunk/LayoutTests/fast

Land updated results for overflow changes.

1:02 PM Changeset in webkit [13839] by darin

3 edits
4 copies
2 deletes in trunk/WebCore

Rubber-stamped by Hyatt.

moved xsl files into xml directory, removed xbl files (for now)

WebCore.vcproj/WebCore/WebCore.vcproj: Updated for new locations.
WebCore.xcodeproj/project.pbxproj: Ditto.
khtml/xbl: Removed.
khtml/xsl: Removed.
xml/XSLStyleSheet.cpp: Added.
xml/XSLStyleSheet.h: Added.
xml/XSLTProcessor.cpp: Added.
xml/XSLTProcessor.h: Added.

12:52 PM Changeset in webkit [13838] by hyatt

4 edits in trunk/WebCore

Fix for 5283, make sure overflow doesn't paint on top of positioned elements.

Reviewed by beth

kwq/RenderTreeAsText.cpp: (writeLayers):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::addChild): (WebCore::RenderLayer::removeChild): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::dirtyOverflowList): (WebCore::RenderLayer::updateOverflowList): (WebCore::RenderLayer::collectLayers): (WebCore::RenderLayer::shouldBeOverflowOnly): (WebCore::RenderLayer::styleChanged):
rendering/RenderLayer.h: (WebCore::RenderLayer::isOverflowOnly): (WebCore::RenderLayer::overflowList):

11:31 AM Changeset in webkit [13837] by eseidel

2 edits in trunk/WebKitTools

2006-04-12 Eric Seidel <eseidel@apple.com>

Reviewed by Tim H.

Scripts/update-webkit: Make this return non-zero when svn fails.

9:32 AM Changeset in webkit [13836] by darin

2 edits in trunk/WebCore

WebCore.xcodeproj/project.pbxproj: Turn SVG support back on. I accidentally checked in this file with SVG off last night.

9:22 AM Changeset in webkit [13835] by darin

4 edits in trunk/WebCore

try to fix Windows build

platform/TransferJobInternal.h: Declare HANDLE.
platform/image-decoders/gif/GIFImageReader.h: Include GIFImageDecoder.h.
rendering/RenderThemeWin.h: Declare HANDLE and HMODULE.

9:08 AM Changeset in webkit [13834] by darin

3 edits in trunk/WebCore

another attempt to get things building

bindings/js/kjs_proxy.cpp: Add "kjs_events.h" include, needed when not building SVG (so for Windows too).
editing/TextIterator.h: Add back include of Vector.h.

Apr 11, 2006:

10:31 PM Changeset in webkit [13833] by ggaren

2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Minor code cleanup -- passes all the JS tests.

kjs/object_object.cpp: (ObjectObjectImp::construct): (ObjectObjectImp::callAsFunction):

9:46 PM Changeset in webkit [13832] by darin

9 edits in trunk

JavaScriptCore:

another attempt to fix Windows build -- Vector in Forward.h was not working

kxmlcore/Forward.h: Remove Vector.
kxmlcore/Vector.h: Add back default arguments, remove include of Forward.h.

WebCore:

try to fix Windows build

html/HTMLCollection.h: Add back include of Vector.h.
page/Frame.h: Ditto.
platform/Timer.h: Ditto.

more changes for no-SVG (not working yet though)

editing/CompositeEditCommand.h: Added css_valueimpl.h include.

9:15 PM Changeset in webkit [13831] by darin

3 edits in trunk/WebCore

try to fix no-SVG build

kwq/RenderTreeAsText.cpp: Added back an include only needed for non-SVG.
rendering/RenderObject.h: Ditto.

9:07 PM Changeset in webkit [13830] by darin

12 edits
3 deletes in trunk

JavaScriptCore:

try to fix Windows build -- HashForward.h was not working

kxmlcore/HashForward.h: Removed.

JavaScriptCore.xcodeproj/project.pbxproj: Remove HashForward.h.
kjs/collector.h: Remove use of HashForward.h.
kxmlcore/HashCountedSet.h: Remove include of HashForward.h, restore default arguments.
kxmlcore/HashMap.h: Ditto.
kxmlcore/HashSet.h: Ditto.

JavaScriptGlue:

try to fix Windows build

kxmlcore/HashForward.h: Removed.

WebCore:

try to fix Windows build

ForwardingHeaders/kxmlcore/HashForward.h: Removed.
dom/xml_tokenizer.h: Include another header instead of HashForward.h.
loader/Cache.h: Ditto.
page/Page.h: Ditto.
platform/TransferJob.h: Ditto.

8:14 PM Changeset in webkit [13829] by justing

2 edits in trunk

7:07 PM Changeset in webkit [13828] by justing

7 edits
8 adds in trunk

LayoutTests:

Reviewed by harrison

Added to test changes:

editing/pasteboard/merge-end-1-expected.checksum: Added.
editing/pasteboard/merge-end-1-expected.png: Added.
editing/pasteboard/merge-end-1-expected.txt: Added.
editing/pasteboard/merge-end-1.html: Added.
editing/pasteboard/merge-end-2-expected.checksum: Added.
editing/pasteboard/merge-end-2-expected.png: Added.
editing/pasteboard/merge-end-2-expected.txt: Added.
editing/pasteboard/merge-end-2.html: Added.

Use the editing library so the test can be run in slow motion.

editing/deleting/merge-unrendered-space.html:

Merges after pasted content no longer happen unnecessary. These
tests used to do unnecessary merges that happened to move nodes
that served as selection endpoints, which cleared the selection.
So, you'll see changes to the selection change delegate calls.

editing/pasteboard/8145-2-expected.txt:
editing/pasteboard/paste-line-endings-010-expected.txt:
editing/pasteboard/paste-text-008-expected.txt:
editing/pasteboard/paste-text-009-expected.txt:

WebCore:

Reviewed by harrison

Fixes more instances of:
<rdar://problem/3950559>
CrashTracer: 2116 crashes in Mail at com.apple.WebCore: khtml::CompositeEditCommand::insertNodeAfter + 32

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Do paragraph merging using moveParagraphs.

6:18 PM Changeset in webkit [13827] by eseidel

63 edits
3 copies
1 delete in branches/treecode/JavaScriptCore

Merged with HEAD (13826), rs=timo.

6:08 PM Changeset in webkit [13826] by eseidel

1 edit in branches/treecode/JavaScriptCore/kjs/TreeCode.cpp

.5% speedup on ibench by using Completion&. r=darin

5:57 PM Changeset in webkit [13825] by justing

7 edits
4 adds in trunk

LayoutTests:

Reviewed by harrison

editing/deleting/merge-unrendered-space-expected.checksum: Added.
editing/deleting/merge-unrendered-space-expected.png: Added.
editing/deleting/merge-unrendered-space-expected.txt: Added.
editing/deleting/merge-unrendered-space.html: Added.

WebCore:

Reviewed by harrison

Some setup for work on paste performance.

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraph): Moved code from mergeParagraphs so that it can be used in ReplaceSelectionCommand.
editing/CompositeEditCommand.h:
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): (WebCore::DeleteSelectionCommand::doApply):
editing/VisiblePosition.cpp: (WebCore::VisiblePosition::init): Put the code that chooses m_deepPosition into initDeepPosition. (WebCore::VisiblePosition::initDeepPosition): Fixed a bug: don't fall through to the code that's only for positions inside unrendered space between blocks when there's a candidate downstream() is a candidate. Added a comment about why the fall through code is necessary.
editing/VisiblePosition.h:

1:02 PM Changeset in webkit [13824] by harrison

3 edits in trunk/JavaScriptCore

Reviewed by Darin.

fixed clean build, broken by Darin's check-in

kjs/date_object.cpp: Add needed include of lookup.h.
kjs/regexp_object.cpp: Move include of .lut.h file below other includes.

12:45 PM Changeset in webkit [13823] by eseidel

2 edits in trunk/WebKitSite

2006-04-11 Eric Seidel <eseidel@apple.com>

Reviewed by andersca.

quality/testing.html: fix run-mozilla-tests to run-javascriptcore-tests

10:51 AM Changeset in webkit [13822] by sullivan

2 edits in trunk/WebCore

Reviewed by Darin Adler.

fixed <rdar://problem/4509328> highlight all matches hangs when searching for tab character on www.google.com (and others)

For reasons not yet completely understood, searching for a tab character on some pages (Google, Amazon) finds a match
with a non-collapsed range but then claims that the end visible position of the match is the original start visible
position of the search range. This was causing the highlightAllMatches code to loop forever. Fixed the loop by
checking for the non-advancing search range explicitly. I'm going to track down a reduction of the bogus
search-for-tab issue, and write that up as a separate bug (that bug is not a regression; you can "find" a tab on
google in Tiger also).

page/Frame.cpp: (WebCore::Frame::highlightAllMatchesForString): break the loop if the search range hasn't advanced

9:30 AM Changeset in webkit [13821] by darin

352 edits
7 adds
1 delete in trunk

JavaScriptCore:

Rubber-stamped by John Sullivan.

switched from a shell script to a makefile for generated files
removed lots of unneeded includes
added new Forward.h and HashForward.h headers that allow compiling with fewer unneeded templates

DerivedSources.make: Added.
generate-derived-sources: Removed.
JavaScriptCore.xcodeproj/project.pbxproj: Added new files, changed to use DerivedSources.make.

kxmlcore/Forward.h: Added.
kxmlcore/HashForward.h: Added.

kxmlcore/HashCountedSet.h: Include HashForward for default args.
kxmlcore/HashMap.h: Ditto.
kxmlcore/HashSet.h: Ditto.

kjs/object.h:
kjs/object.cpp: Moved KJS_MAX_STACK into the .cpp file.

bindings/NP_jsobject.cpp:
bindings/c/c_instance.h:
bindings/jni/jni_class.h:
bindings/jni/jni_runtime.h:
bindings/jni/jni_utility.h:
bindings/objc/WebScriptObject.mm:
bindings/objc/WebScriptObjectPrivate.h:
bindings/objc/objc_class.h:
bindings/objc/objc_class.mm:
bindings/objc/objc_instance.h:
bindings/objc/objc_instance.mm:
bindings/objc/objc_runtime.mm:
bindings/objc/objc_utility.mm:
bindings/runtime.h:
bindings/runtime_array.cpp:
bindings/runtime_array.h:
bindings/runtime_method.cpp:
bindings/runtime_method.h:
bindings/runtime_object.cpp:
bindings/runtime_root.h:
kjs/JSImmediate.cpp:
kjs/Parser.h:
kjs/array_object.cpp:
kjs/array_object.h:
kjs/bool_object.cpp:
kjs/bool_object.h:
kjs/collector.h:
kjs/context.h:
kjs/debugger.cpp:
kjs/error_object.h:
kjs/function_object.h:
kjs/internal.h:
kjs/lexer.cpp:
kjs/math_object.cpp:
kjs/math_object.h:
kjs/nodes.cpp:
kjs/nodes.h:
kjs/number_object.cpp:
kjs/number_object.h:
kjs/object_object.cpp:
kjs/operations.cpp:
kjs/protected_reference.h:
kjs/reference.h:
kjs/reference_list.h:
kjs/regexp_object.h:
kjs/string_object.cpp:
kjs/string_object.h:
kjs/testkjs.cpp:
kjs/value.cpp:
kjs/value.h:
kxmlcore/HashTable.h:
kxmlcore/ListRefPtr.h:
kxmlcore/TCPageMap.h:
kxmlcore/Vector.h: Removed unneeded header includes.

JavaScriptGlue:

Rubber-stamped by John Sullivan.

added forwarding headers for the new Forward.h and HashForward.h files

kxmlcore/Forward.h: Added.
kxmlcore/HashForward.h: Added.

WebCore:

Rubber-stamped by John Sullivan (except for pbxproj change).

updated to use the new Forward.h and HashForward.h headers
moved the showTree debugging functions out of the WebCore namespace so they are easier to call from gdb, and renamed the showTree member functions so they don't get in the way; now you can do "call showTree(x)" in gdb and it just works
removed a lot of unneeded includes

WebCore.xcodeproj/project.pbxproj: Fixed a lot of paths that were not relative to the enclosing group.

ForwardingHeaders/kxmlcore/Forward.h: Added.
ForwardingHeaders/kxmlcore/HashForward.h: Added.
bindings/js/JSCanvasRenderingContext2DBase.cpp:
bindings/js/JSXMLHttpRequest.cpp:
bindings/js/JSXMLHttpRequest.h:
bindings/js/JSXSLTProcessor.h:
bindings/js/kjs_binding.h:
bindings/js/kjs_dom.cpp:
bindings/js/kjs_dom.h:
bindings/js/kjs_events.cpp:
bindings/js/kjs_events.h:
bindings/js/kjs_html.cpp:
bindings/js/kjs_navigator.cpp:
bindings/js/kjs_navigator.h:
bindings/js/kjs_proxy.cpp:
bindings/js/kjs_traversal.h:
bindings/js/kjs_window.cpp:
bindings/js/kjs_window.h:
bindings/objc/DOM.mm:
bindings/objc/DOMCSS.mm:
bindings/objc/DOMCore.h:
bindings/objc/DOMEvents.mm:
bindings/objc/DOMHTML.mm:
bindings/objc/DOMImplementationFront.h:
bindings/objc/DOMInternal.mm:
bindings/objc/DOMUtility.mm:
bindings/objc/DOMViews.mm:
bridge/BrowserExtension.h:
bridge/mac/BrowserExtensionMac.mm:
bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm:
bridge/mac/WebCoreFrameBridge.mm:
bridge/mac/WebCoreFrameNamespaces.mm:
bridge/mac/WebCoreJavaScript.mm:
bridge/win/PageWin.cpp:
css/CSSComputedStyleDeclaration.cpp:
css/css_base.h:
css/css_ruleimpl.h:
css/css_valueimpl.cpp:
css/cssparser.cpp:
css/cssparser.h:
css/cssstyleselector.cpp:
css/cssstyleselector.h:
dom/AbstractView.h:
dom/AtomicStringList.h:
dom/Attribute.cpp:
dom/Attribute.h:
dom/Comment.cpp:
dom/ContainerNode.cpp:
dom/DOMImplementation.cpp:
dom/DOMImplementation.h:
dom/Document.cpp:
dom/Document.h:
dom/Element.h:
dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dump): (WebCore::forbidEventDispatch): (WebCore::allowEventDispatch): (WebCore::eventDispatchForbidden):
dom/EventTargetNode.h: (WebCore::EventTargetNode::postDispatchEventHandler):
dom/NamedAttrMap.h:
dom/Node.cpp: (WebCore::Node::showNode): (WebCore::Node::showTree): (WebCore::Node::showTreeAndMark): (showTree):
dom/Node.h:
dom/NodeList.cpp:
dom/NodeList.h:
dom/Position.cpp: (showTree):
dom/Position.h:
dom/Range.cpp:
dom/Range.h:
dom/StyledElement.cpp:
dom/StyledElement.h:
dom/dom2_eventsimpl.cpp:
dom/dom2_eventsimpl.h:
dom/dom2_traversalimpl.h:
dom/dom_xmlimpl.cpp:
dom/xml_tokenizer.cpp:
dom/xml_tokenizer.h:
editing/AppendNodeCommand.cpp:
editing/ApplyStyleCommand.cpp:
editing/ApplyStyleCommand.h:
editing/BreakBlockquoteCommand.cpp:
editing/CompositeEditCommand.cpp:
editing/CreateLinkCommand.cpp:
editing/DeleteFromTextNodeCommand.cpp:
editing/DeleteFromTextNodeCommand.h:
editing/DeleteSelectionCommand.cpp:
editing/EditCommand.cpp:
editing/EditCommand.h:
editing/HTMLInterchange.cpp:
editing/InsertIntoTextNodeCommand.cpp:
editing/InsertIntoTextNodeCommand.h:
editing/InsertLineBreakCommand.cpp:
editing/InsertNodeBeforeCommand.cpp:
editing/InsertParagraphSeparatorCommand.cpp:
editing/InsertTextCommand.cpp:
editing/JSEditor.cpp:
editing/JoinTextNodesCommand.cpp:
editing/MergeIdenticalElementsCommand.cpp:
editing/ModifySelectionListLevelCommand.cpp:
editing/MoveSelectionCommand.cpp:
editing/RebalanceWhitespaceCommand.h:
editing/RemoveCSSPropertyCommand.h:
editing/ReplaceSelectionCommand.cpp:
editing/ReplaceSelectionCommand.h:
editing/Selection.cpp: (WebCore::Selection::formatForDebugger): (WebCore::Selection::showTree): (showTree):
editing/Selection.h:
editing/SelectionController.cpp: (WebCore::SelectionController::formatForDebugger): (WebCore::SelectionController::showTree): (showTree):
editing/SelectionController.h:
editing/TextIterator.cpp:
editing/TextIterator.h:
editing/TypingCommand.cpp:
editing/TypingCommand.h:
editing/UnlinkCommand.cpp:
editing/VisiblePosition.cpp: (WebCore::isEqualIgnoringAffinity): (WebCore::VisiblePosition::formatForDebugger): (WebCore::VisiblePosition::showTree): (showTree):
editing/VisiblePosition.h: (WebCore::VisiblePosition::VisiblePosition): (WebCore::operator==):
editing/WrapContentsInDummySpanCommand.cpp:
editing/htmlediting.h:
editing/markup.cpp:
editing/markup.h: (WebCore::):
editing/visible_units.cpp:
html/CanvasGradient.cpp:
html/CanvasRenderingContext2D.h:
html/CanvasStyle.cpp:
html/CanvasStyle.h:
html/FormDataList.cpp:
html/FormDataList.h:
html/HTMLCollection.cpp:
html/HTMLCollection.h:
html/HTMLDocument.cpp:
html/HTMLDocument.h:
html/HTMLElement.cpp:
html/HTMLElementFactory.cpp:
html/HTMLElementFactory.h:
html/HTMLFormCollection.cpp:
html/HTMLFormElement.cpp:
html/HTMLFormElement.h:
html/HTMLInputElement.cpp:
html/HTMLParser.cpp:
html/HTMLSelectElement.cpp:
html/HTMLSelectElement.h:
html/HTMLTokenizer.cpp:
html/HTMLTokenizer.h:
html/html_baseimpl.cpp:
html/html_headimpl.h:
kcanvas/KCanvasCreator.cpp:
kcanvas/KCanvasFilters.h:
kcanvas/KCanvasPath.h:
kcanvas/KCanvasResources.h:
kcanvas/KCanvasTreeDebug.cpp:
kcanvas/RenderPath.cpp:
kcanvas/RenderPath.h:
kcanvas/device/KRenderingDevice.h:
kcanvas/device/KRenderingPaintServerGradient.h:
kcanvas/device/KRenderingPaintServerPattern.h:
kcanvas/device/KRenderingPaintServerSolid.h:
kcanvas/device/quartz/KCanvasFilterQuartz.mm:
kcanvas/device/quartz/KCanvasMaskerQuartz.h:
kcanvas/device/quartz/KCanvasResourcesQuartz.h:
kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
khtml/misc/decoder.cpp:
khtml/misc/decoder.h:
khtml/xsl/XSLStyleSheet.cpp:
khtml/xsl/XSLTProcessor.cpp:
khtml/xsl/XSLTProcessor.h:
ksvg2/css/SVGRenderStyle.h:
ksvg2/ecma/GlobalObject.cpp:
ksvg2/misc/KCanvasRenderingStyle.h:
ksvg2/misc/SVGDocumentExtensions.h:
ksvg2/svg/SVGAngle.h:
ksvg2/svg/SVGAnimateColorElement.h:
ksvg2/svg/SVGAnimatedColor.h:
ksvg2/svg/SVGAnimatedLengthList.h:
ksvg2/svg/SVGAnimatedNumberList.h:
ksvg2/svg/SVGAnimatedString.h:
ksvg2/svg/SVGAnimatedTransformList.h:
ksvg2/svg/SVGAnimationElement.h:
ksvg2/svg/SVGColor.h:
ksvg2/svg/SVGCursorElement.h:
ksvg2/svg/SVGHelper.h:
ksvg2/svg/SVGLength.h:
ksvg2/svg/SVGList.h:
ksvg2/svg/SVGPaint.h:
ksvg2/svg/SVGPathSeg.h:
ksvg2/svg/SVGPatternElement.h:
ksvg2/svg/SVGSVGElement.cpp:
ksvg2/svg/SVGSVGElement.h:
ksvg2/svg/SVGStringList.h:
ksvg2/svg/SVGTransform.h:
kwq/AccessibilityObjectCache.mm:
kwq/ClipboardMac.mm:
kwq/JavaAppletWidget.mm:
kwq/KWQComboBox.mm:
kwq/KWQEditCommand.mm:
kwq/KWQFileButton.mm:
kwq/KWQKHTMLSettings.h:
kwq/KWQKSSLKeyGen.mm:
kwq/KWQLoader.mm:
kwq/KWQPageState.mm:
kwq/KWQTextEdit.mm:
kwq/RegularExpression.h:
kwq/RenderTreeAsText.cpp:
kwq/RenderTreeAsText.h:
kwq/WebCoreAXObject.mm:
loader/Cache.cpp:
loader/Cache.h:
loader/CachedCSSStyleSheet.cpp:
loader/CachedObject.h:
loader/CachedScript.cpp:
loader/CachedXBLDocument.cpp:
loader/CachedXBLDocument.h:
loader/CachedXSLStyleSheet.cpp:
loader/CachedXSLStyleSheet.h:
loader/DocLoader.cpp:
page/Frame.cpp:
page/Frame.h:
page/FramePrivate.h:
page/FrameTree.cpp:
page/FrameTree.h:
page/FrameView.cpp:
page/FrameView.h:
page/Page.cpp:
page/Page.h:
page/Plugin.h: (WebCore::Plugin::Plugin): (WebCore::Plugin::view):
platform/Color.cpp:
platform/FloatRect.h:
platform/Font.cpp:
platform/Font.h:
platform/FontFamily.cpp:
platform/GraphicsContext.cpp:
platform/Image.cpp:
platform/Image.h:
platform/IntRect.h:
platform/KURL.cpp:
platform/KURL.h:
platform/SegmentedString.h:
platform/Shared.h:
platform/StreamingTextDecoder.cpp:
platform/StringImpl.cpp:
platform/StringImpl.h:
platform/TextEncoding.h:
platform/Timer.cpp:
platform/Timer.h:
platform/TransferJob.cpp:
platform/TransferJob.h:
platform/TransferJobInternal.h:
platform/cairo/GraphicsContextCairo.cpp:
platform/cairo/ImageCairo.cpp:
platform/cairo/ImageSourceCairo.cpp:
platform/image-decoders/gif/GIFImageReader.cpp:
platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
platform/mac/FontFamilyMac.mm:
platform/mac/FontMac.mm:
platform/mac/ImageMac.mm:
platform/mac/TextEncodingMac.cpp:
platform/mac/TransferJobMac.mm:
platform/win/FontPlatformDataWin.cpp:
platform/win/TransferJobWin.cpp:
rendering/RenderBlock.cpp:
rendering/RenderBlock.h:
rendering/RenderBox.cpp:
rendering/RenderBox.h:
rendering/RenderCanvas.cpp:
rendering/RenderCanvas.h:
rendering/RenderContainer.cpp:
rendering/RenderFlexibleBox.h:
rendering/RenderFlow.cpp:
rendering/RenderFlow.h:
rendering/RenderImage.cpp:
rendering/RenderImage.h:
rendering/RenderLayer.cpp:
rendering/RenderLayer.h:
rendering/RenderObject.cpp: (showTree):
rendering/RenderObject.h:
rendering/RenderTableCell.h:
rendering/RenderTableSection.h:
rendering/RenderText.cpp:
rendering/RenderText.h:
rendering/RenderTextField.cpp:
rendering/RenderTextFragment.h:
rendering/RenderTheme.h:
rendering/RenderThemeMac.mm:
rendering/RenderThemeWin.cpp:
rendering/bidi.cpp:
rendering/render_form.h:
rendering/render_line.cpp: (showTree):
rendering/render_line.h:
rendering/render_list.cpp:
rendering/render_replaced.cpp:
rendering/render_replaced.h:
rendering/render_style.cpp:
rendering/render_style.h:
xml/xmlhttprequest.h:

4:17 AM Changeset in webkit [13820] by eseidel

2 edits in branches/treecode/JavaScriptCore

misc small speedups to bring 2% more on the js ibench. r=mjs

2:03 AM Changeset in webkit [13819] by eseidel

9 edits in branches/treecode/JavaScriptCore/kjs

Roll DeclaredFunctionImp::call() down into the interpreter loop for a 5% speed gain on ibench. r=mjs

Apr 10, 2006:

9:40 PM Changeset in webkit [13818] by ap

2 edits
2 moves
1 delete in trunk

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8157 Make HTTP tests using Perl use .pl extension

WebKitTools:

Scripts/run-webkit-tests: Added support for running .pl and .php tests, removed support for .text. Reduced the number of places that explicitly list supported extensions. Some of the changes come from bug 8121, the patch for which got landed only partially.

LayoutTests:

http/tests/incremental/slow-utf8-text.pl: Added (renamed from .text).
http/tests/incremental/slow-utf8-text.text: Removed.
http/tests/incremental/split-hex-entities.pl: Added (renamed from .html).
http/tests/incremental/split-hex-entities.html: Removed.
http/tests/incremental/.htaccess: Removed.

9:17 PM Changeset in webkit [13817] by sullivan

4 edits in trunk/WebKit

Reviewed by Tim Omernick.

fixed <rdar://problem/4139799> Seed: Safari: Private Browsing leaves traces in Icon Cache

Misc/WebIconDatabasePrivate.h: new ivars: pageURLsBoundDuringPrivateBrowsing, iconURLsBoundDuringPrivateBrowsing, and privateBrowsingEnabled

Misc/WebIconDatabase.m: (-[NSMutableDictionary init]): initialize new ivars, and listen for notifications that WebPreferences changed so we can react to changes to private browsing. (-[NSMutableDictionary iconForURL:withSize:cache:]): Don't remove icon URL from extraRetain dictionary; that's now done in _forgetIconForIconURLString. (I left a comment here earlier about why I was worried about this change, but I convinced myself that it's fine.) (-[WebIconDatabase removeAllIcons]): Removed no-longer-true (and never very clear) comment, and braces. Also remove all objects from the two private-browsing-related dictionaries. (-[WebIconDatabase _setIcon:forIconURL:]): remember icon URL if private browsing is enabled (-[WebIconDatabase _setHaveNoIconForIconURL:]): remember icon URL if private browsing is enabled (-[WebIconDatabase _setIconURL:forURL:]): added an assert that helped me out at one point (-[WebIconDatabase _clearDictionaries]): clear the two new dictionaries too (-[WebIconDatabase _loadIconDictionaries]): made an existing ERROR not fire in the expected case where there are no icons at all on disk (-[WebIconDatabase _updateFileDatabase]): when saving the pageURLToIconURL dictionary to disk, first remove any values that were created during private browsing (-[WebIconDatabase _retainIconForIconURLString:]): skip the code that deals with saving changes to disk if private browsing is enabled (-[WebIconDatabase _forgetIconForIconURLString:]): Remove the icon URL from extraRetain dictionary here. We're forgetting everything about this icon URL so we should forget its former extraRetain count too. (-[WebIconDatabase _resetCachedWebPreferences:]): Cache the new value of private browsing. If it has now been turned off, forget everything we learned while it was on. This causes (e.g.) icons for bookmarks or pre-existing history items to be forgotten if the icon was only learned during private browsing.

History/WebHistoryItem.m: removed an unnecessary #import I happened to notice

4:36 PM Changeset in webkit [13816] by darin

2 edits in trunk/LayoutTests

fast/dom/gc-4-expected.txt: Add one blank line (test result was failing).

4:30 PM Changeset in webkit [13815] by darin

2 edits in trunk/WebCore

try to fix the Windows build

WebCore.vcproj/WebCore/WebCore.vcproj: Fix mistaken bad editing of AdditionalIncludeDirectories.

3:30 PM Changeset in webkit [13814] by hyatt

6 edits in trunk/WebCore

Make focus ring painting respect clips set by WebCore (e.g., overflow).

Reviewed by darin

platform/GraphicsContext.h:
platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::setFocusRingClip): (WebCore::GraphicsContext::clearFocusRingClip): (WebCore::GraphicsContext::drawFocusRing):
platform/mac/WebCoreGraphicsBridge.h:
platform/mac/WebCoreGraphicsBridge.m: (-[WebCoreGraphicsBridge drawFocusRingWithPath:radius:color:clipRect:]):
rendering/RenderLayer.cpp: (WebCore::setClip): (WebCore::restoreClip):

3:29 PM Changeset in webkit [13813] by hyatt

2 edits in trunk/WebKit

Make the broken CG focus ring painting work when WebCore sets a clip
(in addition to respecting the dirty rect clip).

Reviewed by darin

WebCoreSupport/WebGraphicsBridge.m: (-[WebGraphicsBridge drawFocusRingWithPath:radius:color:clipRect:]):

3:12 PM Changeset in webkit [13812] by darin

4 edits
28 copies
1 delete in trunk/WebCore

Reviewed by Geoff.

death to khtml/ecma, long live bindings/js

khtml/ecma: Removed. Moved all files to bindings/js.

bindings/js/JSDOMParser.cpp: Added.
bindings/js/JSDOMParser.h: Added.
bindings/js/JSXMLHttpRequest.cpp: Added.
bindings/js/JSXMLHttpRequest.h: Added.
bindings/js/JSXMLSerializer.cpp: Added.
bindings/js/JSXMLSerializer.h: Added.
bindings/js/JSXSLTProcessor.cpp: Added.
bindings/js/JSXSLTProcessor.h: Added.
bindings/js/kjs_binding.cpp: Added.
bindings/js/kjs_binding.h: Added.
bindings/js/kjs_css.cpp: Added.
bindings/js/kjs_css.h: Added.
bindings/js/kjs_dom.cpp: Added.
bindings/js/kjs_dom.h: Added.
bindings/js/kjs_events.cpp: Added.
bindings/js/kjs_events.h: Added.
bindings/js/kjs_html.cpp: Added.
bindings/js/kjs_html.h: Added.
bindings/js/kjs_navigator.cpp: Added.
bindings/js/kjs_navigator.h: Added.
bindings/js/kjs_proxy.cpp: Added.
bindings/js/kjs_proxy.h: Added.
bindings/js/kjs_traversal.cpp: Added.
bindings/js/kjs_traversal.h: Added.
bindings/js/kjs_views.cpp: Added.
bindings/js/kjs_views.h: Added.
bindings/js/kjs_window.cpp: Added.
bindings/js/kjs_window.h: Added.

DerivedSources.make: Removed khtml/ecma from directory list.
WebCore.vcproj/WebCore/WebCore.vcproj: Moved files from khtml/ecma to bindings/js.
WebCore.xcodeproj/project.pbxproj: Ditto.

3:09 PM Changeset in webkit [13811] by eseidel

21 edits
4 copies
1 delete in branches/treecode/JavaScriptCore

Re-base the treecode branch to latest HEAD.

I used the following command:
svn merge -r 13663:13752 svn+ssh://eseidel@svn.opensource.apple.com/svn/webkit/trunk/JavaScriptCore

The merge was rubber-stamped by Tim Hatcher.

2:40 PM Changeset in webkit [13810] by darin

2 edits in trunk/LayoutTests

one more test change for http://bugzilla.opendarwin.org/show_bug.cgi?id=4884 Canvas element breaks when RenderObject creation is deferred by external CSS

fast/dom/gc-4.html: Test had a bug where it used <canvas> without a </canvas> tag. Changed test to include a </canvas> tag.

2:38 PM Changeset in webkit [13809] by darin

3 edits in trunk/WebCore

Reviewed by Geoff.

try to fix the Windows build

html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::reset): Put code to release m_drawingContext into an APPLE ifdef.

platform/win/TemporaryLinkStubs.cpp:

2:10 PM Changeset in webkit [13808] by ggaren

2 edits in trunk/WebKitSite

Reviewed by Beth.

projects/compat/hitlist.html: updated dates

2:04 PM Changeset in webkit [13807] by eseidel

1 delete in branches/temp-tree-code

Remove the temporary import branch for treecode.

2:02 PM Changeset in webkit [13806] by eseidel

1 move in branches/treecode

Move the treecode branch to its proper place.

1:34 PM Changeset in webkit [13755] by thatcher

1 add in branches/temp-tree-code

New branch folder for an upcoming import.

10:02 AM Changeset in webkit [13754] by ap

2 edits
1 add in trunk/WebCore

Fix by Mitz Pettel, reviewed by Eric.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8295 Dictionary pop-up panel targets the wrong word in a scrolled IFRAME

kwq/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerForPosition:]): Removed the addition of scroll offsets, which is redundant for scrolled views, then changed the first view to be the document's scrolled view instead of its scroll view (all subsequent views were already scrolled views).
manual-tests/dictionary-scrolled-iframe.html: Added.

9:49 AM Changeset in webkit [13753] by darin

92 edits in trunk

LayoutTests:

regenerated pixel results because many may be affected by the fix for bug 8100

WebKit:

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8100 REGRESSION (NativeTextField): Right-aligned and RTL text jitters in new text fields

WebCoreSupport/WebTextRenderer.m: (overrideLayoutOperation): For RTL runs, apply the word-rounding on the left. (CG_floatWidthForRun): For RTL runs, apply the last character's rounding on the left by adjusting the start position. (initializeWidthIterator): Added finalRoundingWidth field to WidthIterator. (advanceWidthIterator): For RTL runs, apply rounding on the left of the character, by increasing the width of the next character (which is the character to the left). For the last character, keep the rounding width in the iterator's finalRoundingWidth, to be used by CG_floatWidthForRun().

Apr 9, 2006:

10:40 PM Changeset in webkit [13805] by ggaren

4 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

5% speedup by pushing all sourceelements nodes on the stack in one go

10:06 PM Changeset in webkit [13752] by ggaren

3 edits in trunk/JavaScriptCore

Reviewed by eric.

Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=8284 prevent unnecessary entries in the "nodes with extra refs" hash table

This patch switches manual RefPtr exchange with use of
RefPtr::release to ensure that a node's ref count never tops 1
(in the normal case).

kjs/nodes.cpp: (BlockNode::BlockNode): (CaseBlockNode::CaseBlockNode):
kjs/nodes.h: (KJS::ArrayNode::ArrayNode): (KJS::ObjectLiteralNode::ObjectLiteralNode): (KJS::ArgumentsNode::ArgumentsNode): (KJS::VarStatementNode::VarStatementNode): (KJS::ForNode::ForNode): (KJS::CaseClauseNode::CaseClauseNode): (KJS::FuncExprNode::FuncExprNode): (KJS::FuncDeclNode::FuncDeclNode):

9:53 PM Changeset in webkit [13804] by ggaren

2 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

prevent unnecessary entries in the extra ref count on nodes table

9:40 PM Changeset in webkit [13751] by ap

3 edits
3 adds in trunk

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7877 XMLHttpRequest ignores username/password passed to open()

Test: http/tests/xmlhttprequest/basic-auth.html

platform/KURL.cpp: (KURL::setUser): Enable a code path that handles non-empty user name - it was already present, but commented out and protected with an assertion. (KURL::setPass): Ditto.

7:45 PM Changeset in webkit [13750] by darin

1 edit in trunk/LayoutTests/fast/canvas/canvas-before-css-expected.checksum

Removed bogus suffix I checked in by accident.

5:55 PM Changeset in webkit [13803] by eseidel

1 edit in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs/TreeCode.cpp

Prevent int->double conversion in hot code path

5:31 PM Changeset in webkit [13802] by ggaren

5 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

fixed up unwinding some more -- all the mozilla js tests now pass

4:48 PM Changeset in webkit [13749] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

First early steps towards a next, much smaller, round of renames
in WebCore.

4:38 PM Changeset in webkit [13748] by darin

14 edits
4 adds in trunk

LayoutTests:

Reviewed by Anders.

test changes for http://bugzilla.opendarwin.org/show_bug.cgi?id=4884 Canvas element breaks when RenderObject creation is deferred by external CSS

fast/canvas/canvas-before-css-expected.checksum: Added.
fast/canvas/canvas-before-css-expected.png: Added.
fast/canvas/canvas-before-css-expected.txt: Added.
fast/canvas/canvas-before-css.html: Added.

fast/canvas/image-object-in-canvas.html: Test had a bug where it used <canvas> without a </canvas> tag. Changed test to include a </canvas> tag.

fast/canvas/patternfill-repeat-expected.txt: Updated for name change from RenderCanvasImage to RenderHTMLCanvas.
fast/canvas/image-object-in-canvas-expected.txt: Ditto.
fast/canvas/fillrect_gradient-expected.txt: Ditto.
fast/canvas/quadraticCurveTo-expected.txt: Ditto.

WebCore:

Reviewed by Anders.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4884 Canvas element breaks when RenderObject creation is deferred by external CSS

Test: fast/canvas/canvas-before-css.html

This patch makes us match the canvas documentation in Hixie's Web Applications
draft as far as when the canvas is created and recreated and how it's sized.
It also gets rid of the compositeOperation attribute of the canvas element.
We can add that back if we need it. Anders points out that this specifically
changes behavior for canvas elements where the size is set in CSS and not with
width and height attributes. The CSS size now determines how big a box the canvas
is rendered into, but has no effect on the size of the canvas's buffer.

html/CanvasRenderingContext2D.h: Added overloads of drawImage that take HTMLCanvasElement, which is no longer derived from HTMLImageElement.
html/CanvasRenderingContext2D.cpp: (WebCore::imageSize): Renamed from imageOrCanvasSize. Now used for images only, because canvas is no longer derived from image. (WebCore::CanvasRenderingContext2D::drawImage): Split the implementation of this for image sources from the implementation for canvas sources. (WebCore::CanvasRenderingContext2D::willDraw): Changed to call a new willDraw function on the canvas element. (WebCore::CanvasRenderingContext2D::drawingContext): Changed to call drawingContext on the canvas element rather than the renderer.

html/HTMLCanvasElement.h: Changed HTMLCanvasElement to derive from HTMLElement instead of HTMLImageElement. Added width, height, setWidth, setHeight, willDraw, paint, drawingContext, createDrawingContext, and reset functions. Added m_size, m_createdDrawingContext, m_data, and m_drawingContext data members. Removed mapToEntry, attach, detach, and isURLAttribute functins.

html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement): Added initializers for new m_size, m_createdDrawingContext, m_data, and m_drawingContext data members. (WebCore::HTMLCanvasElement::~HTMLCanvasElement): Free m_data and m_drawingContext. (WebCore::HTMLCanvasElement::parseMappedAttribute): Got rid of special case for srcAttr, which is no longer needed since we aren't deriving from HTMLImageElement. Added code that triggers a reset when either width or height is set. (WebCore::HTMLCanvasElement::createRenderer): Added code to set the intrinsic width and height of the renderer to the size of the element. (WebCore::HTMLCanvasElement::setHeight): Added. Sets the height attribute. (WebCore::HTMLCanvasElement::setWidth): Added. Sets the width attribute. (WebCore::HTMLCanvasElement::willDraw): Added. Tells the renderer to repaint. Also has FIXME mentioning we could dirty only the part that has changed in the future. (WebCore::HTMLCanvasElement::reset): Added. Sets the size of the canvas and discards the old buffer, which is an indirect way of resetting the buffer to transparent black. (WebCore::HTMLCanvasElement::paint): Added. Draws the canvas image into the graphics context that's passed in. (WebCore::HTMLCanvasElement::createDrawingContext): Added. Allocates a buffer for the bits, then creates a bitmap context for drawing into the buffer. (WebCore::HTMLCanvasElement::drawingContext): Added. Calls createDrawingContext if needed, then returns the current drawing context. (WebCore::HTMLCanvasElement::createPlatformImage): Changed to always call CGContextFlush and to create the image from the context in this class.

rendering/RenderHTMLCanvas.h: Remove almost all of the contents of this file. Removed ~RenderHTMLCanvas, setNeedsImageUpdate, element, updateDrawnImage, drawingContext, createDrawingContext, and drawnImage functions and _drawingContext, _drawingContextData, _drawnImage, and _needsImageUpdate booleans. Changed RenderHTMLCanvas to derive from RenderReplaced instead of RenderImage.

rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::RenderHTMLCanvas): Changed to only initialize RenderReplaced. (WebCore::RenderHTMLCanvas::renderName): Moved this in here, since there's no good reason to have this virtual function inlined. (WebCore::RenderHTMLCanvas::paint): Changed implementation to use HTMLCanvasElement::paint instead ofcalling CGContextDrawImage directly. (WebCore::RenderHTMLCanvas::layout): Removed the code that detects changes in width and causes the drawing context to be recreated; instead, if the width and height changes we scale when we paint the canvas.

bindings/js/JSCanvasRenderingContext2DBase.cpp: (WebCore::JSCanvasRenderingContext2DBaseProtoFunc::callAsFunction): Separated out handling for <canvas> vs. <img> elements in drawRect, since HTMLCanvasElement is no longer derived from HTMLImageElement.

3:00 PM Changeset in webkit [13747] by eseidel

2 edits in trunk/WebCore

2006-04-09 Rob Buis <buis@kde.org>

Reviewed by eseidel. Landed by eseidel.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6027:
Dirty rect invalidation issues in mozilla sample

Make sure the paths calculate the new bounding box and not
use the cached bbox.

No automated test case possible.

kcanvas/RenderPath.cpp: (WebCore::RenderPath::setPath):

2:55 PM Changeset in webkit [13746] by eseidel

3 edits
4 adds in trunk

2006-04-09 Rob Buis <buis@kde.org>

Reviewed by darin. Landed by eseidel.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6930:
% width/height on nested <svg> tags do not work

Set the context correctly for inner <svg>, so calculation of
width/height for inner <svg> elements is done against the
viewport element.

Test: svg/custom/inner-percent.svg

ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::width): (WebCore::SVGSVGElement::height):

1:12 PM Changeset in webkit [13745] by eseidel

2 edits in trunk/WebCore

2006-04-08 Rob Buis <buis@kde.org>

Reviewed by eseidel.

No automated test case possible.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7531:
hang in SVGPolygonElementImpl::toPathData in polygon test case

Make sure the points list is cleared, just like the path
list is cleared first before (re)parsing.

ksvg2/svg/SVGPolyElement.cpp: (SVGPolyElement::parseMappedAttribute):

1:03 AM Changeset in webkit [13744] by ap

1 edit in trunk/LayoutTests/ChangeLog

Forgot to commit ChangeLog for JSC string capitalization fixes.

Apr 8, 2006:

10:08 PM Changeset in webkit [13743] by darin

17 edits
8 adds in trunk

LayoutTests:

Reviewed by Beth.

tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=7622 REGRESSION: New text fields should compute maxlength considering composed character sequences

fast/forms/input-text-maxlength-expected.checksum: Added.
fast/forms/input-text-maxlength-expected.png: Added.
fast/forms/input-text-maxlength-expected.txt: Added.
fast/forms/input-text-maxlength.html: Added.
fast/forms/input-text-paste-maxlength-expected.checksum: Added.
fast/forms/input-text-paste-maxlength-expected.png: Added.
fast/forms/input-text-paste-maxlength-expected.txt: Added.
fast/forms/input-text-paste-maxlength.html: Added.

WebCore:

Reviewed by Beth.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7622 REGRESSION: New text fields should compute maxlength considering composed character sequences

Test: fast/forms/input-text-maxlength.html
Test: fast/forms/input-text-paste-maxlength.html

html/HTMLInputElement.h: Removed all friend classes (not needed any more). Renamed typeEnum to InputType. Made init() function private. Tweaked parameter names and formatting in many function declarations. Made canHaveSelection, selectionStart, and selectionEnd const. Made data members except for m_name private instead of protected. Added private functions constrainValue and recheckValue. Removed unused isEditable function.

html/HTMLInputElement.cpp: (WebCore::numGraphemeClusters): Added. (WebCore::numCharactersInGraphemeClusters): Added. (WebCore::HTMLInputElement::isKeyboardFocusable): Use inputType() instead of using m_type directly. (WebCore::HTMLInputElement::isMouseFocusable): Ditto. (WebCore::HTMLInputElement::focus): Ditto. (WebCore::HTMLInputElement::setInputType): Added code to call constrainValue or recheckValue so we will enforce maxLen if changing from a type that doesn't have maxLen to one that does. (WebCore::HTMLInputElement::type): More-standard formatting for switch statement. Put cases into alphabetical order. (WebCore::HTMLInputElement::state): Changed switch statement to include all case values and not include a default case to take advantage of gcc's missing case warning. (WebCore::HTMLInputElement::restoreState): Ditto. (WebCore::HTMLInputElement::canHaveSelection): Ditto. (WebCore::HTMLInputElement::selectionStart): Ditto. (WebCore::HTMLInputElement::selectionEnd): Ditto. (WebCore::HTMLInputElement::setSelectionStart): Ditto. (WebCore::HTMLInputElement::setSelectionEnd): Ditto. (WebCore::HTMLInputElement::select): Ditto. (WebCore::HTMLInputElement::setSelectionRange): Ditto. (WebCore::HTMLInputElement::click): Ditto. (WebCore::HTMLInputElement::accessKeyAction): Ditto. (WebCore::HTMLInputElement::parseMappedAttribute): Use inputType() instead of using m_type directly. Added call to recheckValue when parsing a new value for the maxlength attribute. (WebCore::HTMLInputElement::rendererIsNeeded): Changed switch statement to include all case values and not include a default case to take advantage of gcc's missing case warning. (WebCore::HTMLInputElement::createRenderer): Ditto. (WebCore::HTMLInputElement::attach): Remove code to condition the value attribute when done parsing. This is now all handled by constrainValue and recheckValue as needed. (WebCore::HTMLInputElement::isSuccessfulSubmitButton): Use inputType() instead of using m_type directly. (WebCore::HTMLInputElement::appendFormData): Ditto. Rearranged code a little. (WebCore::HTMLInputElement::setChecked): Ditto. (WebCore::HTMLInputElement::setIndeterminate): Ditto. (WebCore::HTMLInputElement::value): Ditto. Call constrainValue when reading the value out of the value attribute. (WebCore::HTMLInputElement::valueWithDefault): Use inputType() instead of using m_type directly. Changed switch statement to include all case values and not include a default case to take advantage of gcc's missing case warning. (WebCore::HTMLInputElement::setValue): Ditto. Call constrainValue when storing a value. (WebCore::HTMLInputElement::setValueFromRenderer): Added an assertion. (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): Use inputType() instead of using m_type directly. (WebCore::HTMLInputElement::preDispatchEventHandler): Ditto. (WebCore::HTMLInputElement::postDispatchEventHandler): Ditto. (WebCore::HTMLInputElement::defaultEventHandler): Ditto. Changed code to truncate inserted text in a BeforeTextInsertedEvent to use the new constrainValue function and also the numGraphemeClusters function, so it's based on grapheme clusters instead of characters and shares code. (WebCore::HTMLInputElement::constrainValue): Added. (WebCore::HTMLInputElement::recheckValue): Added.

html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::HTMLIsIndexElement): Removed unneeded code to set m_type to TEXT, which is already what it gets set to by the base class's constructor.

html/HTMLGenericFormElement.h: Removed unused isEditable function.
html/HTMLGenericFormElement.cpp: Ditto.
html/HTMLTextAreaElement.h: Ditto.
html/HTMLTextAreaElement.cpp: Ditto.

platform/StringImpl.cpp: (WebCore::StringImpl::truncate): Changed > to >= so that truncating to the size of the string does nothing, efficiently.

rendering/RenderText.h: Added declaration of characterBreakIterator.
rendering/RenderText.cpp: (WebCore::characterBreakIterator): Made this public so it can be used in other files. Maybe we should also move it to another source file later. Also renamed to remove the "get" from the title. (WebCore::RenderText::previousOffset): Updated for name change. (WebCore::RenderText::nextOffset): Updated for name change.

rendering/RenderTextField.cpp: (WebCore::RenderTextField::updateFromElement): Removed code to implement maxlength checking. That's handled entirely in the DOM now. Also moved down the code to get the value into a string so that it's done only in the case where the string is used.

rendering/render_form.cpp: (WebCore::RenderFileButton::valueChanged): Use setValueFromRenderer instead of setting the value directly in the input element. We changed this for all the other types a while ago, and it works just as well for the input element.

dom/BeforeTextInsertedEvent.h: Added setText function. Previously, clients changed the text by modifying the text object in place, but going forward we'd like to avoid that sort of thing.

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Changed code to assume clients will change the text in the event rather than mutating the text object itself. This is compatible with possible future changes to String to be copy on write.
editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): Ditto.

1:51 PM Changeset in webkit [13801] by ggaren

1 edit in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs/TreeCode.cpp

added missing fall through to case code

1:50 PM Changeset in webkit [13800] by ggaren

2 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

refined rules for what the current completion state is

1:40 PM Changeset in webkit [13799] by eseidel

2 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore

added shrinkTo and growTo to vector for speed gain

12:08 PM Changeset in webkit [13798] by eseidel

2 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

fix try and switch

12:04 PM Changeset in webkit [13742] by ap

2 edits in trunk/JavaScriptCore

Reviewed by Darin.

One more attempt - use reinterpret_cast, rather than static_cast.

11:54 AM Changeset in webkit [13741] by ap

2 edits in trunk/JavaScriptCore

Reviewed by Darin.

An attempt to fix Win32 build - ICU uses wchar_t on Windows, so we need a type cast.

kxmlcore/unicode/icu/UnicodeIcu.h: (KXMLCore::Unicode::toLower): (KXMLCore::Unicode::toUpper):

10:21 AM Changeset in webkit [13740] by ap

11 edits
3 copies
3 adds in trunk

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8264 toLowerCase and toUpperCase don't honor special mappings

Test: fast/js/string-capitalization.html

JavaScriptCore.xcodeproj/project.pbxproj: Added KXMLCore::Unicode headers to the project.
icu/unicode/putil.h: Added (copied from WebCore).
icu/unicode/uiter.h: Ditto.
icu/unicode/ustring.h: Ditto.
kjs/string_object.cpp: (StringProtoFunc::callAsFunction): Use the new KXMLCore::Unicode::toUpper() and toLower().
kjs/ustring.cpp: Removed unused (and evil) UChar::toLower() and toUpper().
kjs/ustring.h: Ditto.

kxmlcore/unicode/Unicode.h: Corrected capitalization of the word Unicode.
kxmlcore/unicode/UnicodeCategory.h: Renamed include guard macro to match file name.

kxmlcore/unicode/icu/UnicodeIcu.h: (KXMLCore::Unicode::toLower): Work on strings, not individual characters. Use ICU root locale. (KXMLCore::Unicode::toUpper): Ditto. (KXMLCore::Unicode::isFormatChar): Use int32_t, which can hold a complete code point. (KXMLCore::Unicode::isSeparatorSpace): Ditto. (KXMLCore::Unicode::category): Ditto.
kxmlcore/unicode/qt4/UnicodeQt4.h: (KXMLCore::Unicode::toLower): Work on strings, not individual characters. (KXMLCore::Unicode::toUpper): Ditto. (KXMLCore::Unicode::isFormatChar): Use int32_t, which can hold a complete code point. (KXMLCore::Unicode::isSeparatorSpace): Ditto. (KXMLCore::Unicode::category): Ditto.

tests/mozilla/ecma/String/15.5.4.12-1.js: Corrected expected results.
tests/mozilla/ecma/String/15.5.4.12-5.js: Corrected expected results.

9:49 AM Changeset in webkit [13739] by sullivan

2 edits in trunk/WebKit

Reviewed by Adele Peterson.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=8260 REGRESSION: Assertion failure: ![_private->iconsToSaveWithURLs containsObject:iconURLString] in WebIconDatabase.m:695-[WebIconDatabase(WebInternal) _retainIconForIconURLString:]

Misc/WebIconDatabase.m: (-[WebIconDatabase _retainIconForIconURLString:]): This new assertion was one block too high; moved it in.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed