Timeline



Apr 27, 2006:

8:49 PM Changeset in webkit [14095] by eseidel
  • 2 edits in trunk/WebCore

2006-04-27 Eric Seidel <​eseidel@apple.com>

  • WebCore.vcproj/WebCore/WebCore.vcproj: Fix break from last checkin.
6:00 PM Changeset in webkit [14094] by ggaren
  • 26 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Maciej

  • Minor fixups I discovered while working on the autogenerator.


  • kjs/lookup.cpp: (findEntry): ASSERT that size is not 0, because otherwise we'll % by 0, compute a garbage address, and possibly crash.
  • kjs/lookup.h: (cacheGlobalObject): Don't enumerate cached objects -- ideally, they would be hidden entirely.

LayoutTests:

  • Updated to remove diff shmutz:
  • fast/dom/Window/window-special-properties-expected.txt:
  • fast/dom/Window/window-special-properties.html:
  • Test for global window properties like window.HTMLDocument:


  • fast/dom/global-constructors-expected.txt: Added.
  • fast/dom/global-constructors.html: Added.

WebCore:

Reviewed by Maciej.

  • Added global constructor autogeneration for the following, many of which are required by *.live.com: Node, Element, Range, CSSRule, CSSValue, CSSPrimitiveValue, CSSStyleDeclaration, Event, MutationEvent, NodeFilter

It works like so:


  • The autogenerator knows about the "Constructor" data type, which gets special treatment because it exists purely in the bindings. It also knows about the "GenerateConstructor" interface attribute, which does just that.
  • The window interface has many Constructor attributes
  • The hash table generator swizzles empty tables to tables with one empty bucket, to prevent crashes in Lookup::findEntry. (The old generator used to work this way, too.)
  • Window object property lookup gets special treatment to allow shadowing of its built-in global constructor properties. We'll need to expand this mechanism in the future and make it more flexible, but it works for now.


  • DerivedSources.make:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_css.cpp: (KJS::toJS):
  • bindings/js/kjs_css.h:
  • bindings/js/kjs_window.cpp: Removed 'namedFrameGetter' and its use because they were bogus; added FIXME describing what they were attempting to do. (KJS::Window::getValueProperty): (KJS::Window::getOverridePropertySlot): (KJS::Window::getOwnPropertySlot):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSPrimitiveValue.idl:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl: Added.
  • css/CSSValue.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/MutationEvent.idl:
  • dom/Node.idl:
  • dom/NodeFilter.idl:
  • dom/Range.idl:
  • page/DOMWindow.idl:
5:39 PM Changeset in webkit [14093] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

2006-04-27 Timothy Hatcher <​timothy@apple.com>

Merged fix from TOT to Safari-2-0-branch

2006-02-27 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by Darin.

  • fast/dom/css-selectorText-expected.checksum: Updated.
  • fast/dom/css-selectorText-expected.png: Updated.
  • fast/dom/css-selectorText-expected.txt: Updated.
  • fast/dom/css-selectorText.html: Added a case with multiple subselectors.

2006-04-27 Timothy Hatcher <​timothy@apple.com>

Merged fix from TOT to Safari-2-0-branch

2005-12-12 Timothy Hatcher <​timothy@apple.com>

Reviewed by Dave Hyatt.

Test: fast/dom/css-selectorText.html

Fixes selecotrText serialization to only print "*"
when it is stand alone. Fixes the attribute set selector,
along with general cleanup. Also print chained selectors.

  • khtml/css/css_base.cpp: (CSSSelector::extractPseudoType): (CSSSelector::selectorText):
  • khtml/css/css_ruleimpl.cpp: (DOM::CSSStyleRuleImpl::selectorText):
4:44 PM Changeset in webkit [14092] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-11-29 Tim Omernick <​timo@apple.com>

Reviewed by John Sullivan, Eric Seidel

<rdar://problem/4340787> Safari creates 2 instances of the some plug-ins


  • WebView.subproj/WebFrameView.m: (-[WebFrameView _makeDocumentViewForDataSource:]): Instead of creating a new WebDocumentView, use the WebDataSource's representation if it is a WebDocumentView of the appropriate class. Right now, this can only happen when the loading document is a standalone WebKit plugin, because WebPluginDocumentView is both the WebDocumentView and the WebDocumentRepresentation for that kind of page load.


I have verified that this does not affect other kinds of page loads; in all other cases, the representation
class is distinct from the document view class.

I talked with Chris Blumenberg about this change (he knows this code), and he agreed that this is the right
approach.

4:39 PM Changeset in webkit [14091] by thatcher
  • 4 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-04-25 Tim Omernick <​timo@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4472035> SPI that checks for URL policy fails in plugin documents

  • Plugins/WebPluginController.h:
  • Plugins/WebPluginController.m: (-[WebPluginController URLPolicyCheckReferrer]): New method. Get the referrer from the frame's data source's NSURLResponse. Note that for document types loaded by WebCore, this URL is the same as -[WebCorePageBridge referrer], since the response URL is what we pass to -[WebCorePageBridge openURL:].
  • Plugins/WebPluginContainerCheck.m: (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use the WebPluginController's -URLPolicyCheckReferrer instead of assuming that the bridge's -referrer is valid. -[WebCorePageBridge referrer] is only set during the normal WebCore page load process, which has nothing to do with loading standalone plugin documents.
4:24 PM Changeset in webkit [14090] by justing
  • 1 edit in trunk/LayoutTests/ChangeLog

Give credit where credit is due.

4:00 PM Changeset in webkit [14089] by justing
  • 2 edits
    51 adds
    12 deletes in trunk

LayoutTests:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8607>
Automate repaint tests

  • fast/repaint/backgroundSizeRepaint-expected.checksum: Added.
  • fast/repaint/backgroundSizeRepaint-expected.png: Added.
  • fast/repaint/backgroundSizeRepaint-expected.txt: Added.
  • fast/repaint/backgroundSizeRepaint.html: Added.
  • fast/repaint/border-repaint-glitch-expected.checksum: Added.
  • fast/repaint/border-repaint-glitch-expected.png: Added.
  • fast/repaint/border-repaint-glitch-expected.txt: Added.
  • fast/repaint/border-repaint-glitch.html: Added.
  • fast/repaint/bugzilla-3509-expected.checksum: Added.
  • fast/repaint/bugzilla-3509-expected.png: Added.
  • fast/repaint/bugzilla-3509-expected.txt: Added.
  • fast/repaint/bugzilla-3509.html: Added.
  • fast/repaint/bugzilla-5699-expected.checksum: Added.
  • fast/repaint/bugzilla-5699-expected.png: Added.
  • fast/repaint/bugzilla-5699-expected.txt: Added.
  • fast/repaint/bugzilla-5699.html: Added.
  • fast/repaint/bugzilla-6278-expected.checksum: Added.
  • fast/repaint/bugzilla-6278-expected.png: Added.
  • fast/repaint/bugzilla-6278-expected.txt: Added.
  • fast/repaint/bugzilla-6278.html: Added.
  • fast/repaint/bugzilla-6388-expected.checksum: Added.
  • fast/repaint/bugzilla-6388-expected.png: Added.
  • fast/repaint/bugzilla-6388-expected.txt: Added.
  • fast/repaint/bugzilla-6388.html: Added.
  • fast/repaint/bugzilla-6473-expected.checksum: Added.
  • fast/repaint/bugzilla-6473-expected.png: Added.
  • fast/repaint/bugzilla-6473-expected.txt: Added.
  • fast/repaint/bugzilla-6473.html: Added.
  • fast/repaint/bugzilla-7235-expected.checksum: Added.
  • fast/repaint/bugzilla-7235-expected.png: Added.
  • fast/repaint/bugzilla-7235-expected.txt: Added.
  • fast/repaint/bugzilla-7235.html: Added.
  • fast/repaint/inline-outline-repaint-expected.checksum: Added.
  • fast/repaint/inline-outline-repaint-expected.png: Added.
  • fast/repaint/inline-outline-repaint-expected.txt: Added.
  • fast/repaint/inline-outline-repaint.html: Added.
  • fast/repaint/outline-repaint-glitch-expected.checksum: Added.
  • fast/repaint/outline-repaint-glitch-expected.png: Added.
  • fast/repaint/outline-repaint-glitch-expected.txt: Added.
  • fast/repaint/outline-repaint-glitch.html: Added.
  • fast/repaint/repaint-resized-overflow-expected.checksum: Added.
  • fast/repaint/repaint-resized-overflow-expected.png: Added.
  • fast/repaint/repaint-resized-overflow-expected.txt: Added.
  • fast/repaint/repaint-resized-overflow.html: Added.
  • fast/repaint/repaint.js: Added.
  • fast/repaint/resources: Added.
  • fast/repaint/resources/apple.jpg: Added.
  • fast/repaint/table-cell-move-expected.checksum: Added.
  • fast/repaint/table-cell-move-expected.png: Added.
  • fast/repaint/table-cell-move-expected.txt: Added.
  • fast/repaint/table-cell-move.html: Added.

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8607>
Automate repaint tests

  • manual-tests/backgroundSizeRepaint.html: Removed.
  • manual-tests/border-repaint-glitch.html: Removed.
  • manual-tests/bugzilla-3509.html: Removed.
  • manual-tests/bugzilla-5699.html: Removed.
  • manual-tests/bugzilla-6278.html: Removed.
  • manual-tests/bugzilla-6388.html: Removed.
  • manual-tests/bugzilla-6473.html: Removed.
  • manual-tests/bugzilla-7235.html: Removed.
  • manual-tests/inline-outline-repaint.html: Removed.
  • manual-tests/outline-repaint-glitch.html: Removed.
  • manual-tests/repaint-resized-overflow.html: Removed.
  • manual-tests/table-cell-move.html: Removed.
3:11 PM Changeset in webkit [14088] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-04-25 Beth Dakin <Beth Dakin>

Reviewed by Maciej.

Fix for <rdar://problem/4518632> getComputedStyle returns 'auto'
for dimensions like 'margin-left'

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): For margin and padding, to match Firefox we now go to the renderer to get the property value instead of calling valueForLength() on the style attribute. valueForLength() will return the string 'auto' if that was what was specified in the CSS, or a percentage if it was specified as a percent. But to match Firefox, we always want to return a pixel value for margin and padding.
3:04 PM Changeset in webkit [14087] by thatcher
  • 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-02-10 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Adding support for external entity declarations in XSLT.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7184
<rdar://problem/4271696> support external DTD references in XSLT

  • dom/xml_tokenizer.cpp: (WebCore::OffsetBuffer::OffsetBuffer): new support class (WebCore::OffsetBuffer::readOutBytes): read method (WebCore::shouldAllowExternalLoad): for preventing common urls (WebCore::openFunc): now does a synchronous data load (WebCore::readFunc): returns data from the offset buffer (WebCore::closeFunc): deletes offset buffer (WebCore::setLoaderForLibXMLCallbacks): helper function (WebCore::createQStringParser): cleanup (WebCore::XMLTokenizer::finish):
  • dom/xml_tokenizer.h:
  • khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::parseString):
  • khtml/xsl/xsl_stylesheetimpl.h:
1:11 PM Changeset in webkit [14086] by justing
  • 13 edits
    24 adds in trunk

LayoutTests:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8624>
Placeholders aren't always removed during paste
<rdar://problem/4059807>
Seed: Mail: pasting quoted content sometimes adds a phantom newline


If a webkit-block-placeholder has been introduced by a bug in deletion,
we shouldn't remove it during paste if it is now acting as a linebreak.

  • editing/pasteboard/bad-placeholder-expected.checksum: Added.
  • editing/pasteboard/bad-placeholder-expected.png: Added.
  • editing/pasteboard/bad-placeholder-expected.txt: Added.
  • editing/pasteboard/bad-placeholder.html: Added. Generic placeholder brs should be removed if they are displaced by pasted content.
  • editing/pasteboard/displaced-generic-placeholder-expected.checksum: Added.
  • editing/pasteboard/displaced-generic-placeholder-expected.png: Added.
  • editing/pasteboard/displaced-generic-placeholder-expected.txt: Added.
  • editing/pasteboard/displaced-generic-placeholder.html: Added. So should placeholder brs with our special class on them.
  • editing/pasteboard/displaced-placeholder-expected.checksum: Added.
  • editing/pasteboard/displaced-placeholder-expected.png: Added.
  • editing/pasteboard/displaced-placeholder-expected.txt: Added.
  • editing/pasteboard/displaced-placeholder.html: Added. Removed an unnecessary collapsed br.
  • editing/pasteboard/paste-text-010-expected.txt: Two fixes, an extra line was present after pasting with an interchange newline.
  • editing/pasteboard/paste-text-016-expected.checksum: Added.
  • editing/pasteboard/paste-text-016-expected.png: Added.
  • editing/pasteboard/paste-text-016-expected.txt: Added.
  • editing/pasteboard/paste-text-017-expected.checksum: Added.
  • editing/pasteboard/paste-text-017-expected.png: Added.
  • editing/pasteboard/paste-text-017-expected.txt: Added. The code that interprets the incoming br as a br in strict mode had a bug.
  • editing/pasteboard/quirks-mode-br-1-expected.checksum: Added.
  • editing/pasteboard/quirks-mode-br-1-expected.png: Added.
  • editing/pasteboard/quirks-mode-br-1-expected.txt: Added.
  • editing/pasteboard/quirks-mode-br-1.html: Added. The linePlaceholder removal was negating the work to interpret the last incoming br as a br in strict mode.
  • editing/pasteboard/quirks-mode-br-2-expected.checksum: Added.
  • editing/pasteboard/quirks-mode-br-2-expected.png: Added.
  • editing/pasteboard/quirks-mode-br-2-expected.txt: Added.
  • editing/pasteboard/quirks-mode-br-2.html: Added. Don't let collapsed brs become rendered as a result of the paste operation.
  • editing/pasteboard/unrendered-br-expected.checksum: Added.
  • editing/pasteboard/unrendered-br-expected.png: Added.
  • editing/pasteboard/unrendered-br-expected.txt: Added.
  • editing/pasteboard/unrendered-br.html: Added.

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8624>
Placeholders aren't always removed during paste
<rdar://problem/4059807>
Seed: Mail: pasting quoted content sometimes adds a phantom newline

  • editing/CompositeEditCommand.cpp: Added a FIXME.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Removed two no-op setEndingSelection calls. Store away a br at the position where we'll start inserting content in case the br a) is made unnecessary by the insertion (it's collapsed away) b) was acting as a placeholder and should therefore be displaced by inserted content or c) was acting as a line break and, as a result of the insertion, is now acting as a placeholder. Don't only store away brs that have the webkit-block-placeholder class on them. Any br that does any of the three things just mentioned should be removed. The linePlaceholder removal was run after the code that makes sure to interpret incoming brs strictly, and was negating that work in certain cases.


(WebCore::ReplaceSelectionCommand::removeEndBRIfNeeded): Described above.

  • editing/ReplaceSelectionCommand.h:
  • editing/VisiblePosition.cpp: (WebCore::isEqualIgnoringAffinity): Added a workaround for 8622. We want this function to return true even if one of the two visible positions has been incorrectly canonicalized.
11:39 AM Changeset in webkit [14085] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Reviewed by darin.

<rdar://problem/4449442> GMAIL: XMLHttpRequest does not correctly report "Interactive" state on receipt of load data
Also cleaned up spacing a little.

No layout test possible (local loads are non incremental).

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::changeState): (WebCore::XMLHttpRequest::slotData):
11:34 AM Changeset in webkit [14084] by adele
  • 13 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Beth.

Fix for <rdar://problem/4073701> click event not sent with dispatchEvent

Removed KHTML_CLICK_EVENT and KHTML_DBLCLICK_EVENT. Just use CLICK_EVENT and DBLCLICK_EVENT.

  • khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::wasRunByUserGesture):
  • khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): (DOMNode::putValue):
  • khtml/ecma/kjs_window.cpp: (Window::get): (Window::put):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseHTMLAttribute): (HTMLElementImpl::click):
  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::defaultEventHandler):
  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::defaultEventHandler):
  • khtml/html/html_objectimpl.h:
  • khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent):
  • khtml/rendering/render_form.cpp: (RenderFormElement::slotClicked):
  • khtml/xml/dom2_eventsimpl.cpp: (EventImpl::idToType):
  • khtml/xml/dom2_eventsimpl.h: (DOM::EventImpl::):
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchMouseEvent):
  • kwq/KWQAccObject.mm: (-[KWQAccObject mouseButtonListener]):
9:57 AM Changeset in webkit [14083] by ggaren
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

speculative fix for windows build

Apr 26, 2006:

5:57 PM Changeset in webkit [14082] by tomernic
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.


Test case for <rdar://problem/4068375> Flash inserted via innerHTML Fails to Show when
CSS Display Style is Toggled via Javascript

  • plugins/inner-html-display-none.html: Added.
  • plugins/inner-html-display-none-expected.txt: Added.

WebCore:

Reviewed by Hyatt.

<rdar://problem/4068375> Flash inserted via innerHTML Fails to Show when CSS Display
Style is Toggled via Javascript

  • html/html_objectimpl.cpp: (WebCore::HTMLObjectElement::setComplete): Set needWidgetUpdate when finished parsing, even if the object element is not in a document. That way, when the element attaches to a document, it will update its widget (creating the plug-in view if necessary). This is important when the object is being inserted via setInnerHTML, since the parsed nodes are not added to the document until the whole HTML string is parsed.
3:31 PM Changeset in webkit [14081] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.


  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Rolling out grandparent NULL check because it caused this regression and there's no test case justifying it.
2:35 PM Changeset in webkit [14080] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-02-23 Vicki Murley <​vicki@apple.com>

Reviewed by Tim Omernick.


  • fix <rdar://problem/4394910> calling Javascript window.close() does not trigger onbeforeunload event

Check shouldClose() before actually scheduling a close.

shouldClose() checks for the onbeforeunload handler, displays the onbeforeunload dialog, and returns a
result based on whether the user clicks "OK" or "Cancel". In cases where the window is closed with cmd-w
or by clicking the red globe, shouldClose() is checked in the windowShouldClose delegate method. Since
windowShouldClose isn't invoked when a window is closed with Javascript, it makes sense to add a check
for shouldClose() in scheduleClose(), returning early when appropriate before the chain of events that
closes a window even gets started.

  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::scheduleClose): add a check for shouldClose()
2:10 PM Changeset in webkit [14079] by justing
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by hyatt


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8459>
REGRESSION: Content lost during a delete/merge of whitespace:pre text

Updated to mention the bug that this testcase still demonstrates.
Leaving it disabled until the bug (8592) is fixed:

  • editing/deleting/merge-whitespace-pre.html-disabled:


Illustrates why prune should ascend using the render tree:

  • editing/deleting/pruning-after-merge-1-expected.checksum: Added.
  • editing/deleting/pruning-after-merge-1-expected.png: Added.
  • editing/deleting/pruning-after-merge-1-expected.txt: Added.
  • editing/deleting/pruning-after-merge-1.html: Added.

WebCore:

Reviewed by hyatt


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8459>
REGRESSION: Content lost during a delete/merge of whitespace:pre text

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::prune): The function would prune a rendered leaf because it assumed that the first node passed to it would be a container. The old code ascended using the DOM tree, and would remove the <b> when pruning the <div> in <b><div></div>foo</b>. Now ascends using the render tree.
1:57 PM Changeset in webkit [14078] by thatcher
  • 21 edits in branches/Safari-2-0-branch

JavaScriptCore:

Merged fix from TOT to Safari-2-0-branch

2006-02-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej, Eric.

  • WebCore half of fix for <rdar://problem/4176077> CrashTracer: 6569 crashes in DashboardClient at com.apple.JavaScriptCore: KJS::Bindings::ObjcFallbackObjectImp::type()

WebCore and JavaScriptCore weren't sharing Instance objects very
nicely. I made them use SharedPtrs, and sent them to bed without dessert.

  • bindings/jni/jni_instance.cpp: Made _instance a SharedPtr (JavaInstance::~JavaInstance): (JObjectWrapper::JObjectWrapper):
  • bindings/jni/jni_instance.h: (KJS::Bindings::JObjectWrapper::ref): (KJS::Bindings::JObjectWrapper::deref):
  • bindings/jni/jni_runtime.cpp: Made _array a SharedPtr (JavaArray::~JavaArray): (JavaArray::JavaArray):
  • bindings/jni/jni_runtime.h: (KJS::Bindings::JavaArray::operator=):
  • bindings/objc/objc_runtime.h:
  • Prohibited copying because that would muss the ref count.
  • Prohibited construction without instance because an instance wrapper without an instance is almost certainly a bug.
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::ObjcFallbackObjectImp):
  • bindings/runtime.cpp: (KJS::Bindings::Instance::Instance): (KJS::Bindings::Instance::createBindingForLanguageInstance): (KJS::Bindings::Instance::createRuntimeObject):
  • bindings/runtime.h: (KJS::Bindings::Instance::ref): (KJS::Bindings::Instance::deref):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter): (RuntimeObjectImp::getOwnPropertySlot): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut):
  • bindings/runtime_object.h:
  • Removed ownsInstance data member because SharedPtr takes care of instance lifetime now.
  • Prohibited copying because that would muss the ref count.
  • Prohibited construction without instance because an instance wrapper without an instance is almost certainly a bug. (KJS::RuntimeObjectImp::getInternalInstance):

WebCore:

Merged fix from TOT to Safari-2-0-branch

2006-02-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej, Eric.

  • WebCore half of fix for <rdar://problem/4176077> CrashTracer: 6569 crashes in DashboardClient at com.apple.JavaScriptCore: KJS::Bindings::ObjcFallbackObjectImp::type()

WebCore and JavaScriptCore weren't sharing Instance objects very
nicely. I made them use SharedPtrs, and sent them to bed without dessert.

  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLAppletElementImpl::HTMLAppletElementImpl): Made appletInstance a SharedPtr (WebCore::HTMLAppletElementImpl::getAppletInstance): (WebCore::HTMLAppletElementImpl::detach): (WebCore::HTMLEmbedElementImpl::HTMLEmbedElementImpl): Made embedInstance a SharedPtr (WebCore::HTMLEmbedElementImpl::getEmbedInstance): (WebCore::HTMLEmbedElementImpl::detach): (WebCore::HTMLObjectElementImpl::HTMLObjectElementImpl): Made m_objectInstance a SharedPtr (WebCore::HTMLObjectElementImpl::getObjectInstance): (WebCore::HTMLObjectElementImpl::detach):
  • bindings/js/JSDOMCore.cpp:
  • khtml/ecma/kjs_dom.cpp: (KJS::getRuntimeObject):
  • khtml/html/html_objectimpl.h:
1:42 PM Changeset in webkit [14077] by ggaren
  • 3 edits in trunk/WebCore

This time for sure. Fixed Windows build too.


  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
1:29 PM Changeset in webkit [14076] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by TimO.

Build fix.

  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_domnode.h:
1:18 PM Changeset in webkit [14075] by tomernic
  • 6 edits in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/4525105> Repro TOT crash in [WebBaseNetscapePluginView dealloc] at coachella.com
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8564> crashed when closing a tab

  • WebView/WebFrame.m: (-[WebFramePrivate dealloc]): Assert that plugInViews has been released. (-[WebFrame _addPlugInView:]): New method. Adds the plug-in view to the plugInViews set and calls -setWebFrame: on it. (-[WebFrame _removeAllPlugInViews]): New method. Calls -setWebFrame:nil on all plug-in views and releases the plugInViews set. (-[WebFrame _willCloseURL]): New method. Dispose of plug-in views when leaving a page (or closing the WebView).
  • WebView/WebFrameInternal.h: Declared -_addPlugInView:, -_removeAllPlugInViews, -_willCloseURL
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): Call -[WebFrame _addPlugInView:] instead of directly setting plug-in views' frames. This allows us to keep track of them so that we can explicitly dispose of them when leaving the page. (-[WebFrameBridge closeURL]): Override -[WebCoreFrameBridge closeURL] so that we can perform our own teardown when leaving a page or closing the WebView.
  • Plugins/WebBaseNetscapePluginView.h: Declared -stop so that subclass WebNetscapePluginEmbeddedView can call it.
  • Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView setWebFrame:]): Stop the plug-in when it is removed from its WebFrame.
1:02 PM Changeset in webkit [14074] by ggaren
  • 13 edits
    2 adds in trunk

LayoutTests:

Reviewed by OMG DETHBAKIN.

  • fast/dom/prototype-chain-expected.txt: Fix up prototype chain now that Node is autogenerated.

WebCore:

Reviewed by OMG DETHBAKIN.

  • Start autogenerating Node. This fixes many missing attributes in our DOM by making prototypes hold their relevant constants as properties.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_dom.cpp: (KJS::DOMEventTargetNode::DOMEventTargetNode): (KJS::toJS):
  • bindings/js/kjs_dom.h: (KJS::DOMEventTargetNode::):
  • bindings/js/kjs_domnode.h: Had to break DOMNode into a separate header to avoid circular dependency in header includes. Gave it an old-school file name to keep distinguishing beteween old school and news school files easy. (KJS::DOMNode::impl): (KJS::DOMNode::classInfo): (KJS::DOMNode::):
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/DocumentType.idl:
  • dom/Entity.idl:
  • dom/Node.idl: Added.
  • dom/Notation.idl:
  • dom/ProcessingInstruction.idl:
12:52 PM Changeset in webkit [14073] by tomernic
  • 4 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4472035> SPI that checks for URL policy fails in plugin documents

  • Plugins/WebPluginController.h:
  • Plugins/WebPluginController.m: (-[WebPluginController URLPolicyCheckReferrer]): New method. Get the referrer from the frame's data source's NSURLResponse. Note that for document types loaded by WebCore, this URL is the same as -[WebCorePageBridge referrer], since the response URL is what we pass to -[WebCorePageBridge openURL:].
  • Plugins/WebPluginContainerCheck.m: (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use the WebPluginController's -URLPolicyCheckReferrer instead of assuming that the bridge's -referrer is valid. -[WebCorePageBridge referrer] is only set during the normal WebCore page load process, which has nothing to do with loading standalone plugin documents.
12:09 PM Changeset in webkit [14072] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Committing the project file change jhaygood suggesed in
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8044
WebKit Visual Studio 2005 project shouldn't use the SolutionDir


Instead of his patch, I used the following commands:

sed -e 's/$(SolutionDir)/$(ProjectDir)
../g' Image\ Viewer/Image\
Viewer.vcproj > Image\ Viewer/Image\ Viewer.vcproj_ && mv Image\
Viewer/Image\ Viewer.vcproj_ Image\ Viewer/Image\ Viewer.vcproj

sed -e 's/$(SolutionDir)/$(ProjectDir)
../g'
WebCore/WebCore.vcproj > WebCore/WebCore.vcproj_ && mv
WebCore/WebCore.vcproj_ WebCore/WebCore.vcproj

  • Viewer.vcproj:
  • WebCore.vcproj/WebCore/WebCore.vcproj:

Apr 25, 2006:

9:33 PM Changeset in webkit [14071] by justing
  • 15 edits
    13 adds
    1 delete in trunk

LayoutTests:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8583>
Moving paste code around and some small fixes

Disabling until the bug it illustrates is fixed (8459):

  • editing/deleting/merge-whitespace-pre.html: Removed.
  • editing/deleting/merge-whitespace-pre.html-disabled: Added.


This illustrates the need to do mergeEnd in the opposite direction:

  • editing/pasteboard/merge-end-borders-expected.checksum: Added.
  • editing/pasteboard/merge-end-borders-expected.png: Added.
  • editing/pasteboard/merge-end-borders-expected.txt: Added.
  • editing/pasteboard/merge-end-borders.html: Added.


These illustrate the need to do the special case checks for list content and Mail
blockquote content at the top of shouldMergeStart:

  • editing/pasteboard/merge-start-blockquote-expected.checksum: Added.
  • editing/pasteboard/merge-start-blockquote-expected.png: Added.
  • editing/pasteboard/merge-start-blockquote-expected.txt: Added.
  • editing/pasteboard/merge-start-blockquote.html: Added.
  • editing/pasteboard/merge-start-list-expected.checksum: Added.
  • editing/pasteboard/merge-start-list-expected.png: Added.
  • editing/pasteboard/merge-start-list-expected.txt: Added.
  • editing/pasteboard/merge-start-list.html: Added.


In these tests, the caret was blown away because it was in content that
participated in the end merge. Now the end merge happens in the opposite
direction (incoming content is what is moved when merging paragraphs), so
the caret is no longer blown away:

  • editing/pasteboard/paste-line-endings-007-expected.txt:
  • editing/pasteboard/paste-line-endings-008-expected.txt:
  • editing/pasteboard/paste-line-endings-009-expected.txt:
  • editing/pasteboard/paste-text-002-expected.txt:


Acceptable change to a complicated paste-a-selection-over-itself:

  • editing/pasteboard/paste-text-003-expected.checksum:
  • editing/pasteboard/paste-text-003-expected.png:
  • editing/pasteboard/paste-text-003-expected.txt:

WebCore:

Reviewed by harrison

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8583>
Moving paste code around and some small fixes


Moved code to make it easier to do the start merge after the fact,
with moveParagraph, instead of in the middle of the paste operation.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraph):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::shouldMergeStart): Moved code to make this decision to its own function. Moved special case checks to the top. Added m_forceMergeStart to override the special cases because moveParagraph uses ReplaceSelectionCommand and expects a merge.


(WebCore::ReplaceSelectionCommand::shouldMergeEnd):
No functional changes, just moved code here.
(WebCore::ReplaceSelectionCommand::doApply):
Do the end merge in the opposite direction. Merging two paragraphs destroys
the moved one's block level styles, and we prefer to use the styles of the
one that was in the document, not the one that's being pasted.


  • editing/ReplaceSelectionCommand.h:
  • editing/Selection.h: (WebCore::Selection::visibleStart): Added. (WebCore::Selection::visibleEnd): Added.
  • editing/htmlediting.cpp: (WebCore::enclosingList): Added. (WebCore::isMailBlockquote): Don't require a renderer so that this can be used on nodes in fragments.


  • editing/htmlediting.h:
4:12 PM Changeset in webkit [14070] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Eric.

<rdar://problem/4526052> intermittent assertion failure in -[WebBasePluginPackage dealloc]
running layout tests

  • Plugins/WebPluginPackage.m: (-[WebPluginPackage unload]): Clear isLoaded here. It turns out that only WebNetscapePluginPackage cleared its isLoaded flag in -unload. We need to also do it here, because the superclass (WebBasePluginPackage) asserts in -dealloc that -unload has been called.
3:58 PM Changeset in webkit [14069] by ggaren
  • 9 edits
    6 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for the DOM properties supported by object, embed, attribute:

  • fast/dom/plugin-attributes-enumeration-expected.txt: Added.
  • fast/dom/plugin-attributes-enumeration.html: Added.


Test for setting attributes through DOM properties:

  • plugins/embed-attributes-setting-expected.txt: Added.
  • plugins/embed-attributes-setting.html: Added.


Test for the special attribute-to-style mappings on embed.

  • plugins/embed-attributes-style-expected.txt: Added.
  • plugins/embed-attributes-style.html: Added.

WebCore:

Reviewed by Maciej.

  • Removed special handling of attributes in the DOM. To match WinIE, we used to make all attributes available as properties of their elements in the DOM, but that has caused us more compatibility woes than it has solved, so, after talking with Darin and Maciej, I'm taking it out. (Firefox does not support it.)

A layout test regression caused by this change led me to do the
following as well:


  • Implemented DOM properties missing on EMBED elements: align, height, name, width, src, type. Since align, height, name, and width are common to all plugin elements, I factored them and some other common functionality out into a new abstract base class, HTMLPlugInElement.
  • Removed extraneous attribute-to-style mappings on EMBED elements: valign, border. Why they were there in the first place is a question for the ages. Neither FF nor IE supports them.
  • bindings/js/kjs_dom.cpp: (KJS::getRuntimeObject):
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLElement::embedGetter): (KJS::JSHTMLElement::embedSetter):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Element.idl:
  • html/html_objectimpl.cpp: (WebCore::HTMLPlugInElement::HTMLPlugInElement): (WebCore::HTMLPlugInElement::align): (WebCore::HTMLPlugInElement::setAlign): (WebCore::HTMLPlugInElement::height): (WebCore::HTMLPlugInElement::setHeight): (WebCore::HTMLPlugInElement::name): (WebCore::HTMLPlugInElement::setName): (WebCore::HTMLPlugInElement::width): (WebCore::HTMLPlugInElement::setWidth): (WebCore::HTMLPlugInElement::mapToEntry): (WebCore::HTMLPlugInElement::parseMappedAttribute): (WebCore::HTMLPlugInElement::checkDTD): (WebCore::HTMLAppletElement::HTMLAppletElement): (WebCore::HTMLAppletElement::~HTMLAppletElement): (WebCore::HTMLAppletElement::parseMappedAttribute): (WebCore::HTMLAppletElement::insertedIntoDocument): (WebCore::HTMLAppletElement::removedFromDocument): (WebCore::HTMLAppletElement::getInstance): (WebCore::HTMLAppletElement::closeRenderer): (WebCore::HTMLAppletElement::detach): (WebCore::HTMLEmbedElement::HTMLEmbedElement): (WebCore::HTMLEmbedElement::~HTMLEmbedElement): (WebCore::HTMLEmbedElement::getInstance): (WebCore::HTMLEmbedElement::mapToEntry): (WebCore::HTMLEmbedElement::parseMappedAttribute): (WebCore::HTMLEmbedElement::attach): (WebCore::HTMLEmbedElement::detach): (WebCore::HTMLEmbedElement::insertedIntoDocument): (WebCore::HTMLEmbedElement::removedFromDocument): (WebCore::HTMLEmbedElement::src): (WebCore::HTMLEmbedElement::setSrc): (WebCore::HTMLEmbedElement::type): (WebCore::HTMLEmbedElement::setType): (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::~HTMLObjectElement): (WebCore::HTMLObjectElement::getInstance): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::rendererIsNeeded): (WebCore::HTMLObjectElement::attach): (WebCore::HTMLObjectElement::closeRenderer): (WebCore::HTMLObjectElement::detach): (WebCore::HTMLObjectElement::insertedIntoDocument): (WebCore::HTMLObjectElement::removedFromDocument): (WebCore::HTMLObjectElement::recalcStyle):
  • html/html_objectimpl.h: (WebCore::HTMLPlugInElement::endTagRequirement): (WebCore::HTMLAppletElement::tagPriority): (WebCore::HTMLEmbedElement::tagPriority): (WebCore::HTMLObjectElement::tagPriority):
3:42 PM Changeset in webkit [14068] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Eric.

<rdar://problem/4526120> -[WebBasePluginPackage finalize] leaks the CFBundle (under GC only)

  • Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage finalize]): Release the CFBundle here.
3:35 PM Changeset in webkit [14067] by bdakin
  • 3 edits
    4 adds in trunk

Reviewed by Maciej.

Fix for <rdar://problem/4518632> getComputedStyle returns 'auto'
for dimensions like 'margin-left'

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): For margin and padding, to match Firefox we now go to the renderer to get the property value instead of calling valueForLength() on the style attribute. valueForLength() will return the string 'auto' if that was what was specified in the CSS, or a percentage if it was specified as a percent. But to match Firefox, we always want to return a pixel value for margin and padding.
3:02 PM Changeset in webkit [14066] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-03-31 John Sullivan <​sullivan@apple.com>

Reviewed by Tim Hatcher.


  • fixed <rdar://problem/4372842> 10.4.4 Regression: control-clicking on a misspelled word doesn't select it or offer corrections (first click only)
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent): Rolled in this one-line change that Hyatt wrote ages ago.
2:51 PM Changeset in webkit [14065] by thatcher
  • 8 edits
    1 add in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-04-25 Tim Omernick <​timo@apple.com>

Reviewed by Geoff.

<rdar://problem/4472037>


Private extensions to the WebPlugin interface. A plugin may implement these methods to receive loading callbacks
for its main resource. Plug-ins that implement this SPI show better loading progress in the browser, can be saved
to disk, and are more efficient by avoiding making duplicate GET or POST requests for the plug-in's main resource.

I want to provide a solid API for plug-in networking, but time constraints require that I first provide this simple
SPI for internal clients.

  • Plugins/WebPluginViewFactoryPrivate.h: Added a new plugin argument, WebPlugInShouldLoadMainResourceKey. If YES, the plugin is responsible for loading its own content. If NO, the plugin should wait for WebKit to send it the data via the new request-sharing SPI.
  • Plugins/WebPluginPrivate.h: Added. Request-sharing SPI. See comments in code.
  • Plugins/WebPluginDocumentView.h: Hang onto the plugin view as an ivar so we can call the new resource loading methods on it.
  • Plugins/WebPluginDocumentView.m: (-[WebPluginDocumentView dealloc]): Release pluginView ivar. (-[WebPluginDocumentView setDataSource:]): Pass NO for WebPlugInShouldLoadMainResourceKey to indicate to the plugin that it should not load its own main resource -- the data will come from WebKit. This is only necessary for plugin documents. By the time we create the view for a plugin document, we already have fetched some of its main resource's data. Embedded plugins do not have this issue because WebKit is not involved in loading their content. Call -webPlugInMainResourceDidReceivResponse: on the plugin if necessary. This lets the plugin know how much and what kind of data is going to be received. (-[WebPluginDocumentView dataSourceUpdated:]): If the plugin implements the new request-sharing SPI, don't cancel the in-progress request. (-[WebPluginDocumentView receivedData:withDataSource:]): Forward to the plugin via the new request-sharing SPI. (-[WebPluginDocumentView receivedError:withDataSource:]): ditto (-[WebPluginDocumentView finishedLoadingWithDataSource:]): ditto
  • Plugins/WebPluginPackage.m: Added WebPlugInShouldLoadMainResourceKey, tweaked some style a bit.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:]): Pass YES for WebPlugInShouldLoadMainResourceKey. Embedded plugins must load their own data. (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): ditto


  • WebKit.xcodeproj/project.pbxproj: Added WebPluginPrivate.h
2:47 PM Changeset in webkit [14064] by brmorris
  • 1 copy in S60/tags/s60-051212

S60: Tagging initial migration at S60/tags/s60-051212

2:44 PM Changeset in webkit [14063] by brmorris
  • 1 delete in S60/trunks

S60: Removed svn/webkit/s60/trunkS

2:34 PM Changeset in webkit [14062] by brmorris
  • 574 edits
    235 adds
    205 deletes in S60/trunk

S60: populated s60/trunk with s60-051212 release.

2:26 PM Changeset in webkit [14061] by eseidel
  • 2 edits in trunk/WebKitTools

2006-04-26 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by hyatt. Landed by eseidel.

  • DumpRenderTree/DumpRenderTree.m: (-[LayoutTestController display]):
2:24 PM Changeset in webkit [14060] by tomernic
  • 8 edits
    1 add in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/4472037>


Private extensions to the WebPlugin interface. A plugin may implement these methods to receive loading callbacks
for its main resource. Plug-ins that implement this SPI show better loading progress in the browser, can be saved
to disk, and are more efficient by avoiding making duplicate GET or POST requests for the plug-in's main resource.

I want to provide a solid API for plug-in networking, but time constraints require that I first provide this simple
SPI for internal clients.

  • Plugins/WebPluginViewFactoryPrivate.h: Added a new plugin argument, WebPlugInShouldLoadMainResourceKey. If YES, the plugin is responsible for loading its own content. If NO, the plugin should wait for WebKit to send it the data via the new request-sharing SPI.
  • Plugins/WebPluginPrivate.h: Added. Request-sharing SPI. See comments in code.
  • Plugins/WebPluginDocumentView.h: Hang onto the plugin view as an ivar so we can call the new resource loading methods on it.
  • Plugins/WebPluginDocumentView.m: (-[WebPluginDocumentView dealloc]): Release pluginView ivar. (-[WebPluginDocumentView setDataSource:]): Pass NO for WebPlugInShouldLoadMainResourceKey to indicate to the plugin that it should not load its own main resource -- the data will come from WebKit. This is only necessary for plugin documents. By the time we create the view for a plugin document, we already have fetched some of its main resource's data. Embedded plugins do not have this issue because WebKit is not involved in loading their content. Call -webPlugInMainResourceDidReceivResponse: on the plugin if necessary. This lets the plugin know how much and what kind of data is going to be received. (-[WebPluginDocumentView dataSourceUpdated:]): If the plugin implements the new request-sharing SPI, don't cancel the in-progress request. (-[WebPluginDocumentView receivedData:withDataSource:]): Forward to the plugin via the new request-sharing SPI. (-[WebPluginDocumentView receivedError:withDataSource:]): ditto (-[WebPluginDocumentView finishedLoadingWithDataSource:]): ditto
  • Plugins/WebPluginPackage.m: Added WebPlugInShouldLoadMainResourceKey, tweaked some style a bit.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:]): Pass YES for WebPlugInShouldLoadMainResourceKey. Embedded plugins must load their own data. (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): ditto


  • WebKit.xcodeproj/project.pbxproj: Added WebPluginPrivate.h
2:23 PM Changeset in webkit [14059] by eseidel
  • 2 edits
    3 adds in trunk

2006-04-26 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by darin. Landed by eseidel.

Test: fast/frames/empty-cols-attribute.html

  • platform/StringImpl.cpp: (WebCore::StringImpl::toLengthArray): If the string is empty, return 0 but set len to 1. This gives the same behavior you get if you don't specify the attribute at all, matching WinIE and Firefox. Previously, the empty string resulted in len being set to 0 (and a memory smasher in RenderFrameSet::layout()).
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::layout): Added an assert.
2:22 PM Changeset in webkit [14058] by eseidel
  • 12 edits
    50 adds in trunk

2006-04-26 Oliver Hunt <​ojh16@student.canterbury.ac.nz>

Reviewed by eseidel. Landed by eseidel.

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasFilters.cpp: (WebCore::operator<<):
  • kcanvas/KCanvasFilters.h: (WebCore::KCComponentTransferFunction::KCComponentTransferFunction):
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::getVectorForChannel): (WebCore::genImageFromTable): (WebCore::filterForComponentFunc): (WebCore::setParametersForComponentFunc): (WebCore::getFilterForFunc): (WebCore::KCanvasFEComponentTransferQuartz::getFunctionFilter): (WebCore::KCanvasFEComponentTransferQuartz::getCIFilter):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::createFilterEffect):
  • kcanvas/device/quartz/filters/WKComponentMergeFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKComponentMergeFilter.h: Added.
  • kcanvas/device/quartz/filters/WKComponentMergeFilter.m: Added. (+[WKComponentMergeFilter initialize]): (+[WKComponentMergeFilter filterWithName:]): (-[WKComponentMergeFilter init]): (-[WKComponentMergeFilter outputImage]):
  • kcanvas/device/quartz/filters/WKDiscreteTransferFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKDiscreteTransferFilter.h: Added.
  • kcanvas/device/quartz/filters/WKDiscreteTransferFilter.m: Added. (+[WKDiscreteTransferFilter initialize]): (+[WKDiscreteTransferFilter filterWithName:]): (-[WKDiscreteTransferFilter init]): (-[WKDiscreteTransferFilter outputImage]):
  • kcanvas/device/quartz/filters/WKGammaTransferFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKGammaTransferFilter.h: Added.
  • kcanvas/device/quartz/filters/WKGammaTransferFilter.m: Added. (+[WKGammaTransferFilter initialize]): (+[WKGammaTransferFilter filterWithName:]): (-[WKGammaTransferFilter init]): (-[WKGammaTransferFilter outputImage]):
  • kcanvas/device/quartz/filters/WKIdentityTransferFilter.h: Added.
  • kcanvas/device/quartz/filters/WKIdentityTransferFilter.m: Added. (+[WKIdentityTransferFilter initialize]): (+[WKIdentityTransferFilter filterWithName:]): (-[WKIdentityTransferFilter init]): (-[WKIdentityTransferFilter outputImage]):
  • kcanvas/device/quartz/filters/WKLinearTransferFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKLinearTransferFilter.h: Added.
  • kcanvas/device/quartz/filters/WKLinearTransferFilter.m: Added. (+[WKLinearTransferFilter initialize]): (+[WKLinearTransferFilter filterWithName:]): (-[WKLinearTransferFilter init]): (-[WKLinearTransferFilter outputImage]):
  • kcanvas/device/quartz/filters/WKTableTransferFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKTableTransferFilter.h: Added.
  • kcanvas/device/quartz/filters/WKTableTransferFilter.m: Added. (+[WKTableTransferFilter initialize]): (+[WKTableTransferFilter filterWithName:]): (-[WKTableTransferFilter init]): (-[WKTableTransferFilter outputImage]):
  • ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (SVGComponentTransferFunctionElement::parseMappedAttribute): (SVGComponentTransferFunctionElement::transferFunction):
2:21 PM Changeset in webkit [14057] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore

New export symbols for a change in JavaScriptGlue.

2:20 PM Changeset in webkit [14056] by thatcher
  • 4 edits in branches/Safari-2-0-branch/JavaScriptGlue

Merged fix from TOT to Safari-2-0-branch

2006-03-31 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin.

  • Fixed <rdar://problem/4430836> JavaScript patch crashing Quartz Composer

JSValueWrappers used to hold on to the ExecState that pertained at
the time of their creation. Since ExecStates are transient, that
design was totally bogus, and it would crash once the ExecState had
been deallocated.

Unfortunately, there's no clean solution to this problem, since
the JSGlue API has no notion of state. The solution here is to use
a shared, global ExecState for the purpose of JSGlue calls. Given
the pre-existing limitations in the JSGlue API, this design
shouldn't actually introduce any new limitations (see comments in
JSValueWrapper.cpp).

I tested with Quartz Composer and PAC files, neither of which are
layout-testable.


  • JSUtils.cpp: (KJSValueToJSObject):
  • JSValueWrapper.cpp: (JSValueWrapper::JSValueWrapper): (JSValueWrapper::GetValue): (getProcessGlobalExecState): (JSValueWrapper::JSObjectCopyPropertyNames): (JSValueWrapper::JSObjectCopyProperty): (JSValueWrapper::JSObjectSetProperty): (JSValueWrapper::JSObjectCallFunction): (JSValueWrapper::JSObjectCopyCFValue):
  • JSValueWrapper.h:

Also added a test harness file. It was helpful while I was testing,
and may come in handy in the future:


  • JavaScriptGlue.xcodeproj/project.pbxproj: testjsglue.cpp: Added.
12:33 PM Changeset in webkit [14055] by eseidel
  • 4 edits in branches/Safari-2-0-branch/WebCore

2006-04-25 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Fixes for our 3rd and 5th most common crashtracers:
<rdar://problem/4233435> CrashTracer: 2698 crashes in Safari at com.apple.WebCore: khtml::RenderBlock::addChildToFlow + 156
<rdar://problem/4129744> [REGRESSION]CrashTracer: ..400 crashes at com.apple.WebCore: DOM::NodeImpl::createRendererIfNeeded + 44

Test case landed on trunk but not on branch.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): use m_inDetach bool copied from trunk
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::NodeImpl): (NodeImpl::detach): set m_inDetach (NodeImpl::createRendererIfNeeded): (NodeBaseImpl::removeChildren): remove node from tree before calling detach.
  • khtml/xml/dom_nodeimpl.h:
12:32 PM Changeset in webkit [14054] by eseidel
  • 2 edits in trunk/WebCore

2006-04-25 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Fixes for our 3rd and 5th most common crashtracers:
<rdar://problem/4233435> CrashTracer: 2698 crashes in Safari at com.apple.WebCore: khtml::RenderBlock::addChildToFlow + 156
<rdar://problem/4129744> [REGRESSION]CrashTracer: ..400 crashes at com.apple.WebCore: DOM::NodeImpl::createRendererIfNeeded + 44

Test case landed on trunk but not on branch.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): use m_inDetach bool copied from trunk
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::NodeImpl): (NodeImpl::detach): set m_inDetach (NodeImpl::createRendererIfNeeded): (NodeBaseImpl::removeChildren): remove node from tree before calling detach.
  • khtml/xml/dom_nodeimpl.h:
12:16 PM Changeset in webkit [14053] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-03-13 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren & TimH.

<rdar://problem/4473288> XSL file containing <xsl:include href="../Styles/EscapeString.xsl" /> fails to load file
XML_DTD_NODE objects in the tree were causing loadChildSheets to
fail to preload child stylesheets, this patch causes us to
correctly ignore all nodes besides the first XML_ELEMENT_NODE at
the root level when searching the tree for xsl:include statements
to pre-load.

Test: fast/xsl/xslt-second-level-import.xml

  • khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::loadChildSheets):
11:53 AM Changeset in webkit [14052] by ggaren
  • 1 edit in trunk/JavaScriptCore/ChangeLog

changelog fixup

11:38 AM Changeset in webkit [14051] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • don't have a fini method, since trying to call it will actually call the subclass method and mess up the bridge count.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dealloc]): (-[WebCoreFrameBridge finalize]):
11:05 AM Changeset in webkit [14050] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-03-20 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.


<rdar://problem/4458568> WebCore should not disclose https referrers

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canLoadURL:fromReferrer:hideReferrer:]): Don't send https URLs as referrers to non-secure http sites.
10:59 AM Changeset in webkit [14049] by sfalken
  • 3 edits in trunk/WebCore

2006-04-25 Steve Falkenburg <​sfalkenburg@apple.com>

Reviewed by eseidel.

No test case needed

  • platform/win/TemporaryLinkStubs.cpp: (KWQFileButton::setFrameGeometry):
1:51 AM Changeset in webkit [14048] by eseidel
  • 3 edits
    2 adds in trunk

2006-04-25 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix reproducible crash in html parser code.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7137

Test: fast/parser/remove-current-node-parent.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
1:11 AM Changeset in webkit [14047] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): Add a missing release
12:18 AM Changeset in webkit [14046] by hyatt
  • 2 edits in trunk/WebCore

Fix for 8336, focus ring redrawing on top of itself. Make sure
not to include empty rects when doing the focus ring drawing, since
that results in a draw with no clip set.

Reviewed by adele

  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawFocusRing):

Apr 24, 2006:

10:24 PM Changeset in webkit [14045] by eseidel
  • 3 edits
    2 adds in trunk

2006-04-24 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Fix for 5th worst unresolved crasher:
<rdar://problem/4129744> [REGRESSION]CrashTracer: ..400 crashes at com.apple.WebCore: DOM::NodeImpl::createRendererIfNeeded + 44

Test: fast/dom/remove-style-element.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):
10:01 PM Changeset in webkit [14044] by mjs
  • 5 edits in trunk/WebKit

Reviewed by Geoff.


<rdar://problem/4525364> REGRESSION (yesterday?): LOG() mechanism is broken


  • initialize WebKit's log channels
  • Misc/WebKitLogging.h:
  • Misc/WebKitLogging.m: (initializeLogChannel): (WebKitInitializeLoggingChannelsIfNecessary):
  • WebView/WebPreferences.m: (+[WebPreferences initialize]):
  • WebView/WebView.m: (-[WebView _commonInitializationWithFrameName:groupName:]):
10:00 PM Changeset in webkit [14043] by eseidel
  • 4 edits in trunk/WebCore

2006-04-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Speculative fix for our 7th worst crasher.
Also added ASSERTs to help us better understand the issue.
<rdar://problem/4153404> CrashTracer: 2412 crashes in Safari at com.apple.WebCore: khtml::RenderStyle::RenderStyle[unified] + 44

  • dom/Document.cpp: (WebCore::Document::recalcStyle): (WebCore::Document::setInPageCache):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::recalcStyle):
5:30 PM Changeset in webkit [14042] by adele
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4503438> REGRESSION (NativeTextField): Can't insert caret when
selection is active in field (Business/Unit)

  • css/html4.css: Added -webkit-user-select:text for input elements.
5:22 PM Changeset in webkit [14041] by mjs
  • 6 edits in trunk

WebCore:

Build fix:


  • move some prematurely code back
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge fini]):

WebKit:

Build fix:


  • move some prematurely code back
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge fini]): (-[WebFrameBridge _preferences]): (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): (-[WebFrameBridge keyboardUIMode]):
4:54 PM Changeset in webkit [14040] by brmorris
  • 1 copy in S60/trunk

Creating trunk in S60 branch from r9049

4:33 PM Changeset in webkit [14039] by brmorris
  • 1 delete in S60/tags/s60-051212

Reversed s60-051212 import ('svn copy' is better)

3:56 PM Changeset in webkit [14038] by mjs
  • 6 edits in trunk

WebCore:

Reviewed by Darin.

  • move more code from WebFrameBridge to WebCoreFrameBridge
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge domain]): (-[WebCoreFrameBridge canTargetLoadInFrame:]): (-[WebCoreFrameBridge fini]): (-[WebCoreFrameBridge dealloc]): (-[WebCoreFrameBridge finalize]): (_getPreSmartSet): (_getPostSmartSet): (-[WebCoreFrameBridge isCharacterSmartReplaceExempt:isPreviousCharacter:]): (-[WebCoreFrameBridge _retrieveKeyboardUIModeFromPreferences:]): (-[WebCoreFrameBridge keyboardUIMode]):

WebKit:

Reviewed by Darin.

  • move more code from WebFrameBridge to WebCoreFrameBridge
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge fini]): (-[WebFrameBridge expiresTimeForResponse:]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameBridge valueForKey:keys:values:]): (-[WebFrameBridge _preferences]):
3:33 PM Changeset in webkit [14037] by brmorris
  • 1174 adds in S60/tags/s60-051212

Populated S60/tags/s60-051212

2:59 PM Changeset in webkit [14036] by adele
  • 3 edits in trunk/WebCore

Reviewed by Tim O.

Fix to send textFieldDidBeginEditing on the first editing change instead of on focus.
This matches our old behavior.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::dispatchFocusEvent):
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::subtreeHasChanged):
2:10 PM Changeset in webkit [14035] by ggaren
  • 5 edits in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/dom/prototype-chain-expected.txt: Updated now that 'JS' is no longer used as a prefix when serializing DOM elements to string.
  • fast/events/event-view-toString.html: ditto

WebCore:

Reviewed by Eric.

Fix for <rdar://problem/4513383> REGRESSION: Crash in
WebCore::shouldEmitTabBeforeNode() when iterating through document
text

  • editing/TextIterator.cpp: (WebCore::shouldEmitTabBeforeNode): Need to nil-check the renderer.
2:05 PM Changeset in webkit [14034] by brmorris
  • 4 adds in S60

S60: Added toplevel repository layout

11:50 AM Changeset in webkit [14033] by bdakin
  • 3 edits
    4 adds in trunk

Reviewed by Eric.

Fix for <rdar://problem/4513383> REGRESSION: Crash in
WebCore::shouldEmitTabBeforeNode() when iterating through document
text

  • editing/TextIterator.cpp: (WebCore::shouldEmitTabBeforeNode): Need to nil-check the renderer.
2:30 AM Changeset in webkit [14032] by mjs
  • 27 edits in trunk/WebKit

Reviewed by Anders.



I removed all use of these, now objects get at each other via
actual pointers, not using the view hierarchy. However, I left two
of the calls in because other clients rely on them as SPI (ugh).

  • History/WebHistoryItem.m:
  • Misc/WebNSViewExtras.h:
  • Misc/WebNSViewExtras.m: (-[NSView _web_superviewOfClass:]): (-[NSView _web_parentWebFrameView]):
  • Plugins/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView layout]):
  • Plugins/WebNetscapePluginEmbeddedView.h:
  • Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView setWebFrame:]): (-[WebNetscapePluginEmbeddedView dataSource]):
  • Plugins/WebNullPluginView.h:
  • Plugins/WebNullPluginView.m: (-[WebNullPluginView setWebFrame:]): (-[WebNullPluginView viewDidMoveToWindow]):
  • Plugins/WebPluginController.h:
  • Plugins/WebPluginController.m: (-[WebPluginController setDataSource:]): (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): (-[WebPluginController webPlugInContainerShowStatus:]): (-[WebPluginController webPlugInContainerSelectionColor]): (-[WebPluginController webFrame]):
  • Plugins/WebPluginDocumentView.h:
  • Plugins/WebPluginDocumentView.m: (-[WebPluginDocumentView setDataSource:]): (-[WebPluginDocumentView layout]): (-[WebPluginDocumentView currentWindow]): (-[WebPluginDocumentView viewWillMoveToWindow:]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge formControlIsBecomingFirstResponder:]): (-[WebFrameBridge formControlIsResigningFirstResponder:]): (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]):
  • WebCoreSupport/WebViewFactory.m: (-[WebViewFactory bridgeForView:]):
  • WebView/WebClipView.m: (-[NSView initWithFrame:]):
  • WebView/WebFrameView.m: (-[WebFrameView _shouldDrawBorder]): (-[WebFrameView webCoreBridge]):
  • WebView/WebHTMLView.m: (-[WebTextCompleteController dealloc]): (-[WebHTMLView _dataSource]): (-[WebHTMLView _bridge]): (-[WebHTMLView _webView]): (-[WebHTMLView _frameView]): (-[WebHTMLView _web_firstResponderCausesFocusDisplay]): (-[NSArray becomeFirstResponder]): (-[NSArray setDataSource:]): (-[NSArray pageUp:]): (-[NSArray pageDown:]): (-[NSArray pageUpAndModifySelection:]): (-[NSArray pageDownAndModifySelection:]): (-[WebHTMLView _frame]):
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebImageView.h:
  • WebView/WebImageView.m: (-[WebImageView drawRect:]): (-[WebImageView adjustFrameSize]): (-[WebImageView setDataSource:]): (-[WebImageView webView]): (-[WebImageView writeImageToPasteboard:types:]): (-[WebImageView copy:]): (-[WebImageView elementAtPoint:]): (-[WebImageView mouseDragged:]):
  • WebView/WebPDFView.h:
  • WebView/WebPDFView.m: (-[WebPDFView _applyPDFDefaults]): (-[WebPDFView _trackFirstResponder]): (-[PDFPrefUpdatingProxy forwardInvocation:]):
  • WebView/WebRenderNode.m: (-[WebRenderNode initWithWebFrameView:]):
  • WebView/WebTextView.h:
  • WebView/WebTextView.m: (-[WebTextView _textSizeMultiplierFromWebView]): (-[WebTextView _preferences]): (-[WebTextView setDataSource:]): (-[WebTextView _webFrame]): (-[WebTextView dragSelectionWithEvent:offset:slideBack:]): (-[WebTextView menuForEvent:]): (-[WebTextView resignFirstResponder]): (-[WebTextView drawPageBorderWithSize:]): (-[WebTextView knowsPageRange:]):
  • WebView/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): (containingFrameView): (-[WebView _focusedFrame]): (-[WebView _frameViewAtWindowPoint:]):

Apr 23, 2006:

9:58 PM Changeset in webkit [14031] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • Took the larger snippets of C++ in the code generator and broke them into HERE documents in the hopes of improving readability.


  • bindings/scripts/CodeGeneratorJS.pm: I indented variable names level with their corresponding HERE documents to clearly "sandwich" the HERE documents between opening and closing EOF statements.
8:47 PM Changeset in webkit [14030] by mjs
  • 13 edits
    2 copies
    2 deletes in trunk

WebCore:

Reviewed by Darin.


  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreStringTruncator.h: Added.
  • bridge/mac/WebCoreStringTruncator.mm: Added. (stringWidth): (truncateString): (+[WebCoreStringTruncator widthOfString:font:]):
  • bridge/mac/WebCoreViewFactory.h:
  • kwq/KWQFileButton.h:
  • kwq/KWQFileButton.mm: (-[WebFileChooserButton initWithWidget::]): (-[WebCoreFileButton positionButton]): (-[WebCoreFileButton initWithWidget:]): (-[WebCoreFileButton initWithFrame:]): (-[WebCoreFileButton dealloc]): (-[WebCoreFileButton isFlipped]): (-[WebCoreFileButton drawRect:]): (-[WebCoreFileButton updateLabel]): (-[WebCoreFileButton setFilename:]): (-[WebCoreFileButton filename]): (-[WebCoreFileButton setFrameSize:]): (-[WebCoreFileButton bestVisualFrameSizeForCharacterCount:]): (-[WebCoreFileButton visualFrame]): (-[WebCoreFileButton setVisualFrame:]): (-[WebCoreFileButton baseline]): (-[WebCoreFileButton beginSheet]): (-[WebCoreFileButton chooseFilename:]): (-[WebCoreFileButton cancel]): (-[WebCoreFileButton chooseButtonPressed:]): (-[WebCoreFileButton mouseDown:]): (-[WebCoreFileButton acceptsFirstResponder]): (-[WebCoreFileButton becomeFirstResponder]): (-[WebCoreFileButton nextKeyView]): (-[WebCoreFileButton previousKeyView]): (-[WebCoreFileButton nextValidKeyView]): (-[WebCoreFileButton previousValidKeyView]): (-[WebCoreFileButton performClick]): (-[WebFileChooserButton initWithWidget:]): (-[WebFileChooserButton nextValidKeyView]): (-[WebFileChooserButton previousValidKeyView]): (-[WebFileChooserButton resignFirstResponder]): (KWQFileButton::KWQFileButton): (KWQFileButton::setFilename): (KWQFileButton::click): (KWQFileButton::sizeForCharacterWidth): (KWQFileButton::frameGeometry): (KWQFileButton::setFrameGeometry): (KWQFileButton::baselinePosition): (KWQFileButton::filenameChanged):

WebKit:

Reviewed by Darin.


  • Misc/WebStringTruncator.m: (+[WebStringTruncator centerTruncateString:toWidth:]): (+[WebStringTruncator centerTruncateString:toWidth:withFont:]): (+[WebStringTruncator rightTruncateString:toWidth:withFont:]): (+[WebStringTruncator widthOfString:font:]):
  • WebCoreSupport/WebFileButton.h: Removed.
  • WebCoreSupport/WebFileButton.m: Removed.
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge runOpenPanelForFileButtonWithResultListener:]):
  • WebCoreSupport/WebViewFactory.m: (-[WebViewFactory fileButtonChooseFileLabel]): (-[WebViewFactory fileButtonNoFileSelectedLabel]):
  • WebKit.xcodeproj/project.pbxproj:
4:11 PM Changeset in webkit [14029] by mjs
  • 7 edits
    4 deletes in trunk

WebCore:

Reviewed by Eric.

  • remove WebCoreCookieAdapter, instead make mac implementation of CookieJar use Foundation directly.
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/CookieJar.mm: (WebCore::cookies): (WebCore::setCookies): (WebCore::cookiesEnabled):
  • platform/mac/WebCoreCookieAdapter.h: Removed.
  • platform/mac/WebCoreCookieAdapter.m: Removed.

WebKit:

Reviewed by Eric.


  • remove WebCookieAdapter, WebCore can just use Foundation directly.
  • WebCoreSupport/WebCookieAdapter.h: Removed.
  • WebCoreSupport/WebCookieAdapter.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]):
4:09 PM Changeset in webkit [14028] by mjs
  • 21 edits in trunk/WebKit

Reviewed by Adele.


  • prune WebView SPI of unused calls


Specifically I moved methods that have no callers outside WebKit
to WebViewInternal.h or removed them entirely.

  • DefaultDelegates/WebDefaultContextMenuDelegate.m:
  • Plugins/WebBaseNetscapePluginView.m:
  • Plugins/WebNetscapePluginDocumentView.m:
  • Plugins/WebNetscapePluginStream.m:
  • Plugins/WebNullPluginView.m:
  • Plugins/WebPluginContainerCheck.m:
  • Plugins/WebPluginController.m:
  • WebCoreSupport/WebFrameBridge.m:
  • WebCoreSupport/WebPageBridge.m:
  • WebCoreSupport/WebSubresourceLoader.m:
  • WebView/WebDataSource.m:
  • WebView/WebHTMLView.m:
  • WebView/WebImageView.m:
  • WebView/WebLoader.m:
  • WebView/WebMainResourceLoader.m:
  • WebView/WebPDFView.m:
  • WebView/WebScriptDebugDelegate.m:
  • WebView/WebView.m: (-[WebView _downloadURL:]):
  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:
3:57 PM Changeset in webkit [14027] by eseidel
  • 3 edits
    4 adds in trunk

2006-04-21 Rob Buis <​buis@kde.org>

Reviewed by hyatt. Landed by eseidel.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8170:
SVG CSS property values with extra items do not get treated
as invalid (they should)

Fixes the handling of invalid svg css properties similar
to how invalid html css properties are handled, ie. discard
the property if there are more values in the value list than
expected.

Test: svg/custom/invalid-css.svg

  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
3:45 PM Changeset in webkit [14026] by eseidel
  • 2 edits in trunk/WebCore

2006-04-23 Michael Emmel <​mike.emmel@gmail.com>

Reviewed by mjs. Landed by eseidel.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8517
No test necessary, no functional change.

  • DerivedSources.make: use VPATH more consistently.
3:39 PM Changeset in webkit [14025] by eseidel
  • 8 edits
    2 adds in trunk

2006-04-21 Jon Shier <​jshier@iastate.edu>

Reviewed by ggaren. Landed by eseidel.



  • ChangeLog:
  • bindings/js/kjs_dom.cpp: (KJS::DOMEventTargetNode::getValueProperty): changed khtmlErrorEvent to errorEvent. (KJS::DOMEventTargetNode::putValueProperty): ditto.
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): ditto. (KJS::Window::put):
  • dom/EventNames.h: Removed khtmlError macro.


12:16 PM Changeset in webkit [14024] by adele
  • 3 edits in trunk/WebKitTools

Reviewed by Darin.

  • DumpRenderTree/DumpRenderTree.m: (dump): If display() has been called during the test, grab the pixels from the view, after letting it repaint invalidated rects. (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController display]): Added. Calls -display on the view and changes the subsequent behavior of dump(). (dumpRenderTree):
2:19 AM Changeset in webkit [14023] by eseidel
  • 3 edits
    8 adds in trunk

2006-04-23 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Reproducible crasher with <li value=1234567890 type=A>
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8542

Fixed our alphabetical list generation to match WinIE (not FireFox)
Previously our alphabetical lists were completely wrong past 26 items.

Tests:

  • fast/lists/alpha-list-wrap.html
  • fast/lists/li-style-alpha-huge-value-crash.html
  • rendering/render_list.cpp: (WebCore::toLetterString): (WebCore::toHebrew): (WebCore::RenderListMarker::calcMinMaxWidth):
Note: See TracTimeline for information about the timeline view.