Timeline



May 27, 2006:

11:33 AM Changeset in webkit [14619] by andersca
  • 2 edits in trunk/WebCore

2006-05-27 Anders Carlsson <​acarlsson@apple.com>

  • bindings/js/JSHTMLElementWrapperFactory.cpp: Correct include file names.

May 26, 2006:

7:23 PM Changeset in webkit [14618] by justing
  • 12 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi

Added, test for the crash by focusing an editable html element and then
inserting a tab

  • editing/selection/editable-html-element-expected.checksum: Added.
  • editing/selection/editable-html-element-expected.png: Added.
  • editing/selection/editable-html-element-expected.txt: Added.
  • editing/selection/editable-html-element.html: Added. Fixed:
  • editing/selection/focus_editable_html-expected.checksum:
  • editing/selection/focus_editable_html-expected.png:
  • editing/selection/focus_editable_html-expected.txt:

WebCore:

Reviewed by levi


<rdar://problem/4564296> Mail crashes on Leopard9A184 when I attempt to compose a new message

  • dom/Position.cpp: (WebCore::Position::inRenderedContent): Removed a candidate at [html, 0].
  • editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply): Added early return when there is no selection.
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Ditto.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Ditto.
  • editing/Selection.cpp: (WebCore::Selection::validate): If visible positions can't be created from the endpoints, then create a null selection. Not doing this was making editing code think there was a valid, editable selection even though there wasn't.
  • editing/UnlinkCommand.cpp: (WebCore::UnlinkCommand::doApply): Early return.
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::initDeepPosition): Special case the html/body element boundary. It looks like a non-editable/editable boundary since rootEditableElement stops at the body even if the html element is editable.
3:17 PM Changeset in webkit [14617] by adele
  • 2 edits in trunk/WebCore

Reviewed by Justin.

Fixes a mistake in my last checkin. Uses maxDeepOffset to get the end position for
the textarea's inner div.

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::textWithHardLineBreaks):
2:13 PM Changeset in webkit [14616] by adele
  • 8 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Added test for new textarea implementation. Tests
wrap attributes and form submission.

  • fast/forms/textarea-appearance-wrap-expected.txt: Added.
  • fast/forms/textarea-appearance-wrap.html: Added.

WebCore:

Reviewed by Hyatt.

Added support for wrap=hard for new textarea implementation.

Tests: fast/forms/textarea-appearance-wrap.html

  • dom/Range.h: Added version of toString that will convert BRs to newlines.
  • dom/Range.cpp: (WebCore::Range::toString):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): When in plain-text mode, and a white-space mode that doesn't collapse whitespace, create a fragment with one text node.
  • editing/visible_units.cpp: (WebCore::previousLinePosition): Subtract scroll offset so the absolute position for the containing block is correct. (WebCore::nextLinePosition): ditto.
  • rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates): If the position is equal to the left edge of the box, make the affinity downstream so the position doesn't jump back to the previous line. (WebCore::RenderText::atLineWrap): The logic was reversed here in a recent change. If the box is not at a line break, then its at a line wrap. (WebCore::RenderText::caretRect): Only go to the next text box if its at a line wrap and the affinity is also downstream. If its upstream, then the correct box is on the current line. (WebCore::RenderText::inlineBox): ditto.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::updateFromElement): multi line controls don't need to check valueMatchesRenderer before updating the renderer. For textareas, the renderer should always try to update. This matches our old textarea behavior. (WebCore::RenderTextField::text): Pass true to textContent so it converts BRs to newlines. (WebCore::RenderTextField::textWithHardLineBreaks): Iterate through the RootLineBoxes to find the soft wraps and replace them with newlines.
1:30 PM Changeset in webkit [14615] by andersca
  • 5 edits
    2 adds in trunk

WebCore:

2006-05-26 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9127
Invoke capturing event listeners when AT_TARGET


  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::handleLocalEvents): Invoke capturing event listeners for the AT_TARGET phase. This violates the DOM spec but it's what Mozilla does.

LayoutTests:

2006-05-26 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9127
Invoke capturing event listeners when AT_TARGET

  • dom/html/level2/events/dispatchEvent09-expected.txt:
  • dom/xhtml/level2/events/dispatchEvent09-expected.txt: These fail now.


  • fast/dom/capturing-event-listeners-expected.txt: Added.
  • fast/dom/capturing-event-listeners.html: Added.


12:34 PM Changeset in webkit [14614] by harrison
  • 3 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4514529> Add a list type parameter and a return value to _increaseSelectionListLevel

  • WebView/WebHTMLView.m: (-[WebHTMLView _increaseSelectionListLevel]):
  • Now returns DOMNode*

(-[WebHTMLView _increaseSelectionListLevelOrdered]):
(-[WebHTMLView _increaseSelectionListLevelUnordered]):

  • Added. These also return DOMNode*
  • WebView/WebHTMLViewPrivate.h:
  • Updated as above
12:31 PM Changeset in webkit [14613] by harrison
  • 7 edits
    2 moves in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/4514529> Add a list type parameter and a return value to _increaseSelectionListLevel


  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • Renamed ModifySelectionListLevelCommand .cpp and .h to ModifySelectionListLevel .cpp and .h


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canIncreaseSelectionListLevel]): (-[WebCoreFrameBridge canDecreaseSelectionListLevel]): (-[WebCoreFrameBridge increaseSelectionListLevel]): (-[WebCoreFrameBridge decreaseSelectionListLevel]):
  • Call functions in IncreaseSelectionListLevelCommand or DecreaseSelectionListLevelCommand instead of ModifySelectionListLevelCommand.


(-[WebCoreFrameBridge increaseSelectionListLevelOrdered]):
(-[WebCoreFrameBridge increaseSelectionListLevelUnordered]):

  • Added.


  • editing/ModifySelectionListLevel.cpp: Added.
  • Renamed from ModifySelectionListLevelCommand.cpp
  • Made ModifySelectionListLevelCommand class into a useful base class for new classes IncreaseSelectionListLevelCommand and DecreaseSelectionListLevelCommand.


(WebCore::ModifySelectionListLevelCommand::ModifySelectionListLevelCommand):
(WebCore::getStartEndListChildren):
(WebCore::ModifySelectionListLevelCommand::insertSiblingNodeRangeBefore):
(WebCore::ModifySelectionListLevelCommand::appendSiblingNodeRange):

  • ModifySelectionListLevelCommand is base class for IncreaseSelectionListLevelCommand and DecreaseSelectionListLevelCommand


(WebCore::IncreaseSelectionListLevelCommand::IncreaseSelectionListLevelCommand):
(WebCore::IncreaseSelectionListLevelCommand::listElement):
(WebCore::canIncreaseListLevel):
(WebCore::IncreaseSelectionListLevelCommand::doApply):
(WebCore::IncreaseSelectionListLevelCommand::canIncreaseSelectionListLevel):
(WebCore::increaseSelectionListLevelWithType):
(WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevel):
(WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelOrdered):
(WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelUnordered):

  • Now a subclass of ModifySelectionListLevelCommand
  • Added Ordered and Unordered increaser functions
  • Increaser functions return the list element that the items were moved into


(WebCore::DecreaseSelectionListLevelCommand::DecreaseSelectionListLevelCommand):
(WebCore::canDecreaseListLevel):
(WebCore::DecreaseSelectionListLevelCommand::doApply):
(WebCore::DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel):
(WebCore::DecreaseSelectionListLevelCommand::decreaseSelectionListLevel):

  • No functional changes other than to become a subclass of ModifySelectionListLevelCommand
  • editing/ModifySelectionListLevel.h: Added. (WebCore::):
    • Renamed from ModifySelectionListLevelCommand.cpp


  • editing/ModifySelectionListLevelCommand.cpp: Removed.
  • Renamed to ModifySelectionListLevel.cpp


  • editing/ModifySelectionListLevelCommand.h: Removed.
  • Renamed to ModifySelectionListLevel.h
  • editing/htmlediting.cpp: (WebCore::createOrderedListElement): (WebCore::createUnorderedListElement):
  • editing/htmlediting.h:
12:26 PM Changeset in webkit [14612] by brmorris
  • 1 edit in S60/trunk/build.bat

S60Webkit:

2006-05-25 Bradley <​bradley.morrison@nokia.com>

Reviewed by dacarson.

build.bat now deletes outdated headers.
(fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9126)

11:58 AM Changeset in webkit [14611] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Anders.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8347>
REGRESSION: Flash movie audible but not visible until window is resized

  • Plugins/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView dataSourceUpdated:]): Layout if needed here. Maciej recently removed the "LayoutAcceptable" frame state, which used to cause plugin document views to lay out immediately upon receiving data. This call to -layout has the same effect.
11:11 AM Changeset in webkit [14610] by sfalken
  • 4 edits in trunk/WebCore

2006-05-26 Steve Falkenburg <​sfalken@apple.com>

Reviewed by adele.

Build fixes/tweaks

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • config.h:
  • ksvg2/scripts/make_names.pl:
1:12 AM Changeset in webkit [14609] by sfalken
  • 2 edits in trunk/JavaScriptCore

2006-05-26 Steve Falkenburg <​sfalken@apple.com>

Build fixes/tweaks

1:10 AM Changeset in webkit [14608] by sfalken
  • 2 edits in trunk/WebKitWin

2006-05-26 Steve Falkenburg <​sfalken@apple.com>

Build fixes/tweaks

  • WebKitWin.vcproj/WebKitWin/WebKitWin.vcproj:
1:07 AM Changeset in webkit [14607] by sfalken
  • 3 edits in trunk/WebKitTools

2006-05-26 Steve Falkenburg <​sfalken@apple.com>

Build fixes/tweaks

  • Spinneret/Spinneret.sln:
  • Spinneret/Spinneret/Spinneret.vcproj:

May 25, 2006:

5:36 PM Changeset in webkit [14606] by sfalken
  • 3 edits in trunk/WebCore

2006-05-26 Steve Falkenburg <​sfalken@apple.com>

Reviewed by adele.

Fix build

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • config.h:
5:28 PM Changeset in webkit [14605] by hyatt
  • 2 edits in trunk/WebCore

Set the fixed pitch hardcoded default to 13 on windows.

5:24 PM Changeset in webkit [14604] by hyatt
  • 1 edit in trunk/WebKitTools/Spinneret/Spinneret/Spinneret.cpp

Make sure Spinneret inits and shuts down COM like a good boy.

5:19 PM Changeset in webkit [14603] by aliceli1
  • 2 adds in trunk/LayoutTests/fast/forms
5:15 PM Changeset in webkit [14602] by aliceli1
  • 5 edits in trunk/WebCore

Reviewed by Adele.

  • bindings/js/kjs_html.cpp: added bindings (KJS::HTMLElementFunction::callAsFunction): added case to handle namedItem for select elements
  • bindings/js/kjs_html.h: added enum value for bindings (KJS::JSHTMLElement::):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::namedItem): implemented namedItem method
  • html/HTMLSelectElement.h: added prototype for namedItem method
4:45 PM Changeset in webkit [14601] by hyatt
  • 2 edits in trunk/WebCore

Add soft hyphen support for Win32.

4:18 PM Changeset in webkit [14600] by hyatt
  • 2 edits in trunk/WebCore

Implement containsCharacters method on Win32 for determining if a fallback font has the necessary glyphs to be used.

3:42 PM Changeset in webkit [14599] by hyatt
  • 7 edits
    1 add
    1 delete in trunk/WebCore

Remove the logical scale factor from Cairo Win32 fonts.

3:17 PM Changeset in webkit [14598] by eseidel
  • 5 edits
    3 adds in trunk

2006-05-25 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by hyatt. Landed by eseidel.

Test: fast/table/border-collapsing/border-collapsing-head-foot.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::sectionAbove): Added. (WebCore::RenderTable::sectionBelow): Added. (WebCore::RenderTable::cellAbove): Changed to call sectionAbove. (WebCore::RenderTable::cellBelow): Changed to call sectionBelow.
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedTopBorder): Changed to call sectionAbove. (WebCore::RenderTableCell::collapsedBottomBorder): Changed to call sectionBelow.
3:11 PM Changeset in webkit [14597] by eseidel
  • 39 edits in trunk

2006-05-25 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by hyatt. Landed by eseidel.

  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): Assign the row renderer to the grid row. (WebCore::RenderTableSection::calcRowHeight): Fix off-by-one index bug and add vertical spacing only for grid rows that have a renderer. (WebCore::RenderTableSection::recalcCells): Assign row renderers to grid rows.
3:05 PM Changeset in webkit [14596] by eseidel
  • 1 delete in trunk/WebCore/WebCore

Remove bogus directory

3:00 PM Changeset in webkit [14595] by eseidel
  • 9 edits in trunk/WebCore

2006-05-19 Rob Buis <​buis@kde.org>

Reviewed by darin. Landed by eseidel.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5978
WebKIt+SVG should use SVGDocumentImpl for image/svg+xml

Make sure SVGDocument is created for standalone svg
documents.

  • ksvg2/svg/SVGDOMImplementation.cpp: (SVGDOMImplementation::instance): (SVGDOMImplementation::createDocument):
  • ksvg2/svg/SVGDOMImplementation.h:
  • ksvg2/svg/SVGDocument.cpp: (WebCore::SVGDocument::SVGDocument): (WebCore::SVGDocument::~SVGDocument):
  • ksvg2/svg/SVGDocument.h:
  • ksvg2/svg/SVGTests.cpp: (WebCore::SVGTests::isValid):
  • ksvg2/svg/SVGTitleElement.cpp:
  • ksvg2/svg/SVGTitleElement.h:
  • page/Frame.cpp: (WebCore::Frame::begin):
2:55 PM Changeset in webkit [14594] by eseidel
  • 5 edits
    6 adds
    2 deletes in trunk/WebCore

2006-05-17 Rob Buis <​buis@kde.org>

Reviewed by darin. Landed by eseidel.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5889
HTMLNames.* should be generated using make_names.pl

Use a patched make_names.pl to autogenerate HTMLNames.*

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLNames.cpp: Removed.
  • html/HTMLNames.h: Removed.
  • html/HTMLTagNames.in: Added.
  • html/HTMLAttributeNames.in: Added.
  • ksvg2/scripts/make_names.pl:
2:41 PM Changeset in webkit [14593] by eseidel
  • 24 edits
    5 adds in trunk

2006-05-23 Eric Seidel <​eric@eseidel.com>

Reviewed by andersca.

Add "HasIndexGetter" support to bindings autogen system.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9057

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLInputElementBase.cpp:
  • bindings/js/kjs_css.cpp: (KJS::toJS):
  • bindings/js/kjs_css.h:
  • bindings/js/kjs_dom.cpp: (KJS::DOMNamedNodeMap::getOwnPropertySlot):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSValueList.idl: Added.
1:15 PM Changeset in webkit [14592] by thatcher
  • 1 edit in trunk/WebKit/WebInspector/WebInspector.m

Build fix

12:10 PM Changeset in webkit [14591] by thatcher
  • 3 copies in tags/WebKit-521.11.1/WebKit

Tag for WebKit 521.11.1 (part 2 of 2.)

12:09 PM Changeset in webkit [14590] by thatcher
  • 1 delete in tags/WebKit-521.11.1/WebKit

Bad tag.

12:09 PM Changeset in webkit [14589] by thatcher
  • 1 copy in tags/WebKit-521.11.1/WebKit

Tag for WebKit 521.11.1 (part 2 of 2.)

12:07 PM Changeset in webkit [14588] by thatcher
  • 1 add in tags/WebKit-521.11.1

Tag for WebKit 521.11.1 (part 1 of 2.)

12:06 PM Changeset in webkit [14587] by thatcher
  • 2 edits in /

Versioning

12:00 PM Changeset in webkit [14586] by thatcher
  • 27 edits
    1 add in trunk/WebKit

Reviewed by Tim O.

<rdar://problem/4559808> WebKit fails to compile for ppc64
<rdar://problem/4522085> 64-bit: WebKit uses FSSpec which is not available in 64-bit
Gets WebKit building under 64-bit. Rename WebNSInt and WebNSUInt to WebNSInteger and WebNSUInteger.
Start using WebNSInteger where we need to match AppKit API usage of NSInteger.

HIWebView and a couple of helper functions are disabled until they can be moved off of QuickDraw.
<rdar://problem/4561772> HIWebView needs to be reworked to not use QuickDraw, needed for 64-bit

  • Carbon/CarbonUtils.m: disabled this file in 64-bit <rdar://problem/4561772>
  • Carbon/CarbonWindowAdapter.m: (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
  • Carbon/CarbonWindowFrame.m: (+[CarbonWindowFrame frameRectForContentRect:styleMask:]): (+[CarbonWindowFrame contentRectForFrameRect:styleMask:]): (+[CarbonWindowFrame minFrameSizeForMinContentSize:styleMask:]): (-[CarbonWindowFrame frameRectForContentRect:styleMask:]): (-[CarbonWindowFrame contentRectForFrameRect:styleMask:]): (-[CarbonWindowFrame minFrameSizeForMinContentSize:styleMask:]):
  • Carbon/HIViewAdapter.m: disabled this file in 64-bit <rdar://problem/4561772>
  • Carbon/HIWebView.m: disabled this file in 64-bit <rdar://problem/4561772> (HIWebViewEventHandler):
  • DefaultDelegates/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveContentLength:fromDataSource:]):
  • History/WebBackForwardList.m: (-[WebBackForwardList removeItem:]): (-[WebBackForwardList goToItem:]):
  • Misc/WebDownload.m: (-[WebDownloadInternal download:didReceiveDataOfLength:]):
  • Misc/WebFileDatabase.m: (UniqueFilePathForKey):
  • Misc/WebIconDatabase.m: (-[NSMutableDictionary retainIconForURL:]): (-[NSMutableDictionary releaseIconForURL:]): (-[WebIconDatabase _totalRetainCountForIconURLString:]): (-[WebIconDatabase _retainIconForIconURLString:]): (-[WebIconDatabase _releaseIconForIconURLString:]):
  • Misc/WebSearchableTextView.m: (-[NSString selectionRect]):
  • Misc/WebTypesInternal.h: Added.
  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream _destroyStream]): (CarbonPathFromPOSIXPath):
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendUpdateEvent]): (TSMEventHandler): (-[WebBaseNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]): (-[WebBaseNetscapePluginView _printedPluginBitmap]): (-[NSData _web_locationAfterFirstBlankLine]):
  • Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage hash]):
  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): (functionPointerForTVector):
  • WebInspector/WebInspector.m: (-_updateSystemColors):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSource _didReceiveData:contentLength:forResource:]):
  • WebView/WebFrame.m: (-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
  • WebView/WebHTMLView.m: (-[NSArray drawRect:]): (-[WebHTMLView characterIndexForPoint:]): (-[WebHTMLView conversationIdentifier]):
  • WebView/WebResourceLoadDelegate.h:
  • WebView/WebUIDelegate.h:
  • WebView/WebView.h:
  • WebView/WebView.m: (-[WebView _mouseDidMoveOverElement:modifierFlags:]): (-[WebView spellCheckerDocumentTag]):
  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:
10:57 AM Changeset in webkit [14585] by brmorris
  • 1 edit in S60/trunk/runATF.bat

S60Webkit:

2006-05-25 Bradley <​bradley.morrison@nokia.com>

Reviewed by Franklin.

runATF.bat sets compile environment
(fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9106)

1:08 AM Changeset in webkit [14584] by hyatt
  • 1 edit in trunk/WebKitTools/Scripts/run-webkit-tests

Modify DumpRenderTree so it will be able to spit out expected-win.txt files for win32 layout test results.

12:35 AM Changeset in webkit [14583] by hyatt
  • 2 edits in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree

Fix DumpRenderTree so that it works again.

Note: See TracTimeline for information about the timeline view.