Timeline



Jun 1, 2006:

11:59 PM Changeset in webkit [14682] by darin
  • 2 edits in trunk/WebCore
  • try to fix Windows build
  • bridge/win/FrameWin.cpp: Added include of Decoder.h.
11:56 PM Changeset in webkit [14681] by darin
  • 9 edits
    4 deletes in trunk

WebCore:

Reviewed by Maciej.

  • WebCore doesn't need to load WebKit images any more; removed code for that
  • WebCore.exp: Removed WebCoreImageRendererFactory.
  • WebCore.xcodeproj/project.pbxproj: Removed WebCoreImageRendererFactory.h/mm.
  • bridge/mac/WebCoreFrameBridge.mm: Removed include of WebCoreImageRendererFactory.h.
  • platform/mac/ImageMac.mm: Removed include of WebCoreImageRendererFactory.h.
  • platform/mac/WebCoreImageRendererFactory.h: Removed.
  • platform/mac/WebCoreImageRendererFactory.m: Removed.

WebKit:

Reviewed by Maciej.

  • WebCore doesn't need to load WebKit images any more; removed code for that
  • Resources/missing_image.tiff: Removed.
  • WebCoreSupport/WebImageRendererFactory.h: Removed.
  • WebCoreSupport/WebImageRendererFactory.m: Moved @interface in here. Removed all but the "threaded decoding" calls that older Safari calls. This file can go altogether when compatibility with that older Safari is no longer needed.
  • WebKit.xcodeproj/project.pbxproj: Removed WebImageRendererFactory.h and missing_image.tiff.
  • WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]): Removed call to [WebImageRendererFactory createSharedFactory].
11:30 PM Changeset in webkit [14680] by darin
  • 20 edits
    8 copies
    2 moves in trunk/WebCore

Reviewed by Geoff, tweaked a bit by Darin.

  • WebCore.xcodeproj/project.pbxproj: Updated for new files.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • bindings/js/kjs_traversal.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/objc/DOM.mm:
  • dom/Document.cpp:
  • dom/Document.h: Updated includes.
  • dom/NodeFilter.cpp: Added.
  • dom/NodeFilter.h: Added.
  • dom/NodeFilterCondition.cpp: Added.
  • dom/NodeFilterCondition.h: Added.
  • dom/NodeIterator.cpp: Added.
  • dom/NodeIterator.h: Added.
  • dom/Traversal.cpp: Added.
  • dom/Traversal.h: Added.
  • dom/TreeWalker.cpp: Added.
  • dom/TreeWalker.h: Added.
  • dom/dom2_traversalimpl.cpp: Removed.
  • dom/dom2_traversalimpl.h: Removed.
10:55 PM Changeset in webkit [14679] by darin
  • 23 edits
    8 adds in trunk

LayoutTests:

Reviewed by Maciej and Adele


Tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8398
Updated and extended select/option form tests


  • fast/forms/HTMLOptionElement_label01.html:
  • fast/forms/HTMLOptionElement_label01-expected.txt:
  • fast/forms/HTMLOptionElement_label01-expected.png:
  • fast/forms/HTMLOptionElement_label02.html:
  • fast/forms/HTMLOptionElement_label02-expected.txt:
  • fast/forms/HTMLOptionElement_label02-expected.png:
  • fast/forms/HTMLOptionElement_label03.html:
  • fast/forms/HTMLOptionElement_label03-expected.txt:
  • fast/forms/HTMLOptionElement_label03-expected.png
  • fast/forms/HTMLOptionElement_label04.html:
  • fast/forms/HTMLOptionElement_label04-expected.txt:
  • fast/forms/HTMLOptionElement_label04-expected.png
  • fast/forms/HTMLOptionElement_label05.html:
  • fast/forms/HTMLOptionElement_label05-expected.txt:
  • fast/forms/HTMLOptionElement_label05-expected.png: Updated to reflect success and added some description


  • fast/forms/HTMLOptionElement_label06.html:
  • fast/forms/HTMLOptionElement_label06-expected.txt:
  • fast/forms/HTMLOptionElement_label05-expected.png:
  • fast/forms/HTMLOptionElement_label07.html:
  • fast/forms/HTMLOptionElement_label07-expected.txt:
  • fast/forms/HTMLOptionElement_label07-expected.png: Added.

WebCore:

Reviewed by Maciej and Adele

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8398
REGRESSION: LABEL in OPTION element is clobbering display #TEXT
Patch provided by Darin.


  • rendering/RenderSelect.cpp (RenderSelect::updateFromElement): Changed to use the containing text by default, and not the label text
10:46 PM Changeset in webkit [14678] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt


Tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8646
Test the window.screen.pixelDepth and window.screen.colorDepth


  • fast/dom/window/window-screen-properties.html: Added
  • fast/dom/window/window-screen-properties-expected.txt: Added.

WebCore:

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8646
Correcting the value returned for window.screen.pixelDepth and
window.screen.colorDepth


  • platform/mac/ScreenMac.mm (screenDepth): Changed to return the BitsPerPixelFromDepth rather than the WindowDepth
8:15 PM Changeset in webkit [14677] by hyatt
  • 4 edits in trunk/WebCore

Fix win32 build bustage.

7:18 PM Changeset in webkit [14676] by adele
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Missed an initialization in my last checkin which caused too many
resizers to be drawn.

  • rendering/render_style.cpp: (WebCore::resize): Initialize resize to RESIZE_NONE.
6:13 PM Changeset in webkit [14675] by hyatt
  • 4 edits in trunk/WebCore

Implement form posting via WinINet. This code is crazy... CRAZY

5:05 PM Changeset in webkit [14674] by adele
  • 19 edits
    1 copy in trunk/WebCore

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9216
Implement CSS3 resize property

  • css/html4.css: Sets resize:both for textareas. This won't affect old-style textareas.
  • css/CSSPropertyNames.in: Added resize property.
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): Added case for CSS_PROP_RESIZE.
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): ditto.
  • rendering/render_style.cpp: (WebCore::StyleCSS3InheritedData): Initialize resize.
  • rendering/render_style.h: (WebCore::): Added EResize enum. (WebCore::RenderStyle::resize): (WebCore::RenderStyle::setResize): (WebCore::RenderStyle::initialResize):
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Added m_resizeLayer to keep track of a layer that has begun resizing. (WebCore::FrameViewPrivate::reset): Reset m_resizeLayer. (WebCore::FrameView::handleMousePressEvent): If the mouse was pressed in a layer's resize control, then put the layer into resize mode. (WebCore::selectCursor): Updated so we get a pointer cursor for the resize control. (WebCore::FrameView::handleMouseMoveEvent): If there's a layer currently resizing, then tell the layer to continue resizing. (WebCore::FrameView::handleMouseReleaseEvent): If there's a layer currently resizing, then pull it out of resize mode.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar): Updated so the resize control isn't considered part of the scrollbar.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): Initialize m_inResizeMode (WebCore::RenderLayer::updateLayerPositions): Calls positionResizeControl. (WebCore::RenderLayer::resize): Added. Sets a new width and height based on the current mouse point. (WebCore::RenderLayer::isPointInResizeControl): Added. (WebCore::RenderLayer::positionResizeControl): Added. (WebCore::RenderLayer::positionScrollbars): Calls positionResizeControl. (WebCore::RenderLayer::paintScrollbars): Calls positionResizeControl. (WebCore::RenderLayer::paintResizeControl): Added. (WebCore::RenderLayer::paintLayer): Calls paintResizeControl.
  • rendering/RenderLayer.h: Added m_inResizeMode. (WebCore::RenderLayer::resizeControlRect): (WebCore::RenderLayer::setResizeControlRect): (WebCore::RenderLayer::inResizeMode): Added. (WebCore::RenderLayer::setInResizeMode): Added.
  • platform/mac/ImageMac.mm: (WebCore::Image::loadResource): Moved code from WebImageRendererFactory. Now loads images from WebCore's resources. WebImageRendererFactory is no longer used and should be removed.
  • Resources/missingImage.tiff: Added. Copied from WebKit.
  • WebCore.xcodeproj/project.pbxproj: Added missingImage.tiff
  • loader/Cache.cpp: (WebCore::Cache::init): Updated name from missing_image to missingImage.
  • rendering/RenderTheme.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paintResizeControl): Added.
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::RenderThemeMac): Initialize resizeCornerImage. (WebCore::RenderThemeMac::paintResizeControl): Paints resizeCornerImage.
4:02 PM Changeset in webkit [14673] by beidson
  • 13 edits
    5 adds in trunk

WebKit:
Simple changes to hook up the new WebCore based Icon Database
for testing.
WebCore:
Added the beginnings of sqlite-based code in a WebCore
based version of the Icon Database. Right now the code
is very loosely hooked up through a Bridge and only
creates an sqlite3 database.
There are also changes to our String classes to allow appending
a single character to a String without creating a temporary object.

3:23 PM Changeset in webkit [14672] by andersca
  • 4 edits in trunk/WebCore

2006-06-01 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed and landed by Anders.

  • fixed all places in the Canvas to RenderView rename patch where view() should have been changed to frameView().
  • kwq/WebCoreAXObject.mm: (-[WebCoreAXObject position]): (-[WebCoreAXObject accessibilityAttributeValue:]):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/RenderTreeAsText.cpp: (externalRepresentation):
2:52 PM Changeset in webkit [14671] by ggaren
  • 3 edits
    2 adds in trunk

LayoutTests:

  • http/tests/xmlhttprequest/event-listener-gc.html: Added.
  • http/tests/xmlhttprequest/event-listener-gc-expected.txt: Added.

WebCore:

Fix by Mitz. Reviewed, tweaked, tested, landed by me.


An XMLHttpRequest must be added to the DOMObject cache so that its
DOM implementation object can protect it, and by extension, its event
listeners.


This design seems slightly backwards to me -- the bindings should know
about the DOM, not the other way around -- but I'm restoring it for
now to fix the regression.


  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::JSXMLHttpRequest): (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
2:41 PM Changeset in webkit [14670] by andersca
  • 2 edits in trunk/WebCore

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

  • platform/KURL.cpp: (equalIgnoringRef): Whoops. Fix build.


2:29 PM Changeset in webkit [14669] by andersca
  • 19 edits
    2 adds in trunk

WebCore:

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working


  • bindings/js/kjs_window.cpp: (KJS::Location::put): Handle the case where the hash starts with a "#". Also, don't do anything if the previous and new hashes are equal.


  • bridge/BrowserExtension.h:
  • bridge/mac/BrowserExtensionMac.h:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::historyURL):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: New function historyURL which returns the complete URL for a given item in the history.


  • page/Frame.cpp: (WebCore::Frame::scheduleLocationChange): (WebCore::Frame::scheduleHistoryNavigation): If the URL of the new location only differs in the hash, don't schedule the load. Instead, load it directly.


  • platform/KURL.cpp:
  • platform/KURL.h: Add equalsIgnoringRef which returns whether two URLs are equal, ignoring the ref.

WebKit:

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working

  • Misc/WebNSURLExtras.m: (-[NSString _webkit_URLFragment]): Don't include the "#" character in the fragment.


  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge historyURL:]): New function, returns the history URL for a given position in the back/forward list


  • WebView/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): Always call scrollToAnchorWithURL, even if there is no fragment. This way we keep the WebCore frame's URL up-to-date.

WebKitTools:

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController clearBackForwardList]): Add clearBackForwardList function to layoutTestController


LayoutTests:

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working


  • fast/dom/location-hash-expected.txt: Added.
  • fast/dom/location-hash.html: Added. Added tests.


12:06 PM Changeset in webkit [14668] by andersca
  • 5 edits in trunk/WebCore

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9212
dispatchEvent13.html crashes under GuardMalloc

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::addEventListener): (WebCore::EventTargetNode::removeEventListener): (WebCore::EventTargetNode::handleLocalEvents):


(WebCore::EventTargetNode::removeHTMLEventListener):
(WebCore::EventTargetNode::getHTMLEventListener):

  • dom/EventTargetNode.h: Make the list of registered event listeners refcount the listeners by using a value list of RefPtr objects.


Set removed flag to true in removeEventListener
Only invoke event listeners if they don't have the removed flag.


  • dom/dom2_eventsimpl.cpp: (WebCore::RegisteredEventListener::RegisteredEventListener):
  • dom/dom2_eventsimpl.h: Make RegisteredEventListener refcounted.


(WebCore::RegisteredEventListener::removed):
(WebCore::RegisteredEventListener::setRemoved):
Add removed flag and getter and setter

12:01 PM Changeset in webkit [14667] by mjs
  • 5 edits
    3 adds in trunk

LayoutTests:

Reviewed by Anders.


  • http/tests/misc/redirect-expected.txt: Added.
  • http/tests/misc/redirect.php: Added.
  • http/tests/misc/resources/redirect-result.php: Added.

WebKit:

Reviewed by Anders.


  • WebView/WebDataSource.m: (-[WebDataSource _willSendRequest:forResource:redirectResponse:]): Set up the User-Agent header.
  • WebView/WebDataSourceInternal.h:
  • WebView/WebLoader.m: (-[NSURLProtocol willSendRequest:redirectResponse:]): Pass a mutable URL request so the above can work.
11:33 AM Changeset in webkit [14666] by justing
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/selection/focus-body-expected.checksum: Added.
  • editing/selection/focus-body-expected.png: Added.
  • editing/selection/focus-body-expected.txt: Added.
  • editing/selection/focus-body.html: Added.
  • editing/selection/focus_editable_html-expected.checksum:
  • editing/selection/focus_editable_html-expected.png:
  • editing/selection/focus_editable_html-expected.txt:

WebCore:

Reviewed by harrison


<rdar://problem/4567752> When forwarding a message, pressing TAB key to place caret in body actually selects the entire message instead

  • dom/Element.cpp: (WebCore::Element::focus):
10:35 AM Changeset in webkit [14665] by andersca
  • 6 edits in trunk

WebKit:

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

  • WebView/WebFrameView.m: (+[WebFrameView _canShowMIMETypeAsHTML:]): Use _webkit_objectForMIMEType here so we'll get an object back for "text/".

WebKitTools:

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8996
slow-utf8-text layout test case failing (no longer deterministic?)


  • DumpRenderTree/DumpRenderTree.m: (dump): Dump as text when the response MIME type is text/plain

LayoutTests:

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8996
slow-utf8-text layout test case failing (no longer deterministic?)

  • http/tests/incremental/slow-utf8-text-expected.txt: Updated
4:00 AM Changeset in webkit [14664] by ddkilzer
  • 1 edit
    2 adds in trunk/WebCore

2006-06-01 David Kilzer <​ddkilzer@kilzer.net>

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9144
Test for Bug 8079 (REGRESSION: Redraw from page cache does not show visited links)

  • manual-tests/redraw-page-cache-visited-links.html: Added.
  • manual-tests/resources/redraw-page-cache-visited-links-2.html: Added.

May 31, 2006:

11:34 PM Changeset in webkit [14663] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/css/find-next-layer-expected.checksum: Added.
  • fast/css/find-next-layer-expected.png: Added.
  • fast/css/find-next-layer-expected.txt: Added.
  • fast/css/find-next-layer.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/css/find-next-layer.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::findNextLayer): Fixed a bug where this function could reach two levels down in the layer tree and return 0.
11:30 PM Changeset in webkit [14662] by adele
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

Changed the uninitialized value of m_tabWidth to -1 and removed the
assertion that it cannot be 0.

  • rendering/RenderBlock.cpp: (WebCore:::RenderBlock::RenderBlock): (WebCore::RenderBlock::setStyle):
  • rendering/bidi.cpp: (WebCore::RenderBlock::tabWidth):
11:24 PM Changeset in webkit [14661] by adele
  • 47 edits in trunk/LayoutTests

Updated test results for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8848
TFOOT borders are copied to THEAD and TBODY

  • tables/mozilla/marvin/backgr_layers-opacity-expected.checksum:
  • tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • tables/mozilla/marvin/backgr_position-table-expected.checksum:
  • tables/mozilla/marvin/backgr_position-table-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-cell-expected.checksum:
  • tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-column-expected.checksum:
  • tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum:
  • tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-expected.checksum:
  • tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-row-expected.checksum:
  • tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum:
  • tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
11:16 PM Changeset in webkit [14660] by adele
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/replaced/absolute-position-with-auto-height-and-top-and-bottom.html: Added.
  • fast/replaced/absolute-position-with-auto-width-and-left-and-right.html: Added.

WebCore:

Reviewed by Hyatt.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): Add support for case when all values are specified. (WebCore::RenderBox::calcAbsoluteVerticalReplaced): ditto
11:07 PM Changeset in webkit [14659] by adele
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/table/row-height-recalc-expected.checksum: Added.
  • fast/table/row-height-recalc-expected.png: Added.
  • fast/table/row-height-recalc-expected.txt: Added.
  • fast/table/row-height-recalc.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/table/row-height-recalc.html

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::setStyle): Mark the section as needing recalculation if the height property changed.
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::setStyle): Ditto.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::recalcCells): Initialize the grid row height to the height of the row element (like addChild() does).
10:56 PM Changeset in webkit [14658] by adele
  • 7 edits in trunk/WebCore

Reviewed by Hyatt.

No test possible (no functionality change)

  • dom/Document.cpp: (WebCore::Document::updateLayout): Changed to ensure that pending subtree layouts are performed too.
  • page/Frame.cpp: (WebCore::Frame::forceLayout): Force a full layout.
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::layout): Changed to relayout only the subtree rooted at d->layoutRoot if it's non-zero and allowSubtree is true. (WebCore::FrameView::scheduleRelayout): Change pending subtree relayout into normal relayout by clearing d->layoutRoot and propagating needsLayout to the root. (WebCore::FrameView::scheduleRelayoutOfSubtree): Added.
  • page/FrameView.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Added scheduleRelayout parameter. FrameView passes false to force marking all the way to the root when turning a pending subtree relayout into a full relayout. Otherwise, marking stops at the first textField (or at the root) and relayout of the last object reached is scheduled. (WebCore::RenderObject::scheduleRelayout):
  • rendering/RenderObject.h:
10:35 PM Changeset in webkit [14657] by adele
  • 3 edits in trunk/WebCore

Reviewed by Darin.

patch for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=8910>
Bug 8910: Various code cleanups in RenderBox


Clean up with some slight optimizations.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::contentWidth): (WebCore::RenderBox::contentHeight): (WebCore::RenderBox::setPos): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing):
  • rendering/RenderBox.h:
10:28 PM Changeset in webkit [14656] by adele
  • 4 edits in trunk/WebCore

Reviewed by Hyatt.

patch for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=8899>
Bug 8899: Removes some unneeded code from RenderBox


Removes the use of WidthType where not needed to simplify
the code a little.


  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::sizesToIntrinsicWidth): (WebCore::RenderBox::calcReplacedWidth): (WebCore::RenderBox::calcReplacedWidthUsing): (WebCore::RenderBox::calcReplacedHeight): (WebCore::RenderBox::calcReplacedHeightUsing):
  • rendering/RenderBox.h: (WebCore::): (WebCore::RenderBox::renderName):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight):
10:09 PM Changeset in webkit [14655] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

Testcase for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8455

  • fast/forms/select-reset.html: Added.

WebCore:

Reviewed by Geoff.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8455
selectedIndex for a select after a Form reset() has wrong value

Make sure the list items are reset properly by selecting
the first option in case no options have the selected attribute
set.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::reset):
10:02 PM Changeset in webkit [14654] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

Add a test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8024

  • fast/dom/document-all-input.html: Added.

WebCore:

Reviewed by Geoff.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8024
"Go" button (search) doesn't work at fifa.com (document.all.FormName)

Allow input elements with name attributes as possible named
items for document.all.

  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): (WebCore::HTMLCollection::updateNameCache):
6:06 PM Changeset in webkit [14653] by hyatt
  • 2 edits in trunk/WebCore/platform/win

Tweaks to remove fragments when loading urls via wininet or cookies.

3:19 PM Changeset in webkit [14652] by hyatt
  • 3 edits
    9 adds in trunk/WebCore

Add stubs for bmp/ico/xbm decoders on win32.

2:36 PM Changeset in webkit [14651] by hyatt
  • 14 edits in trunk

WebCore:

Fix for the gmail tab-focus-stealing bug.

Reviewed by darin

  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::focusWindow): (WebCore::FrameMac::unfocusWindow):
  • bridge/mac/WebCoreFrameBridge.h:
  • page/Frame.h:
  • platform/Widget.h:
  • platform/mac/WidgetMac.mm:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::focusWindow):
  • platform/win/WidgetWin.cpp:

WebKit:

Make programmatic focus/blur actually work on sub-frames. Make the
top-level UI delegate get called for deactivation of windows.

Reviewed by darin

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge activateWindow]): (-[WebFrameBridge deactivateWindow]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
  • WebKit.xcodeproj/project.pbxproj:
2:30 PM Changeset in webkit [14650] by bdakin
  • 7 edits
    73 adds in trunk

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6755 CSS3:
Borders rounded with border-radius don't draw the roundings

This patch does not draw all of the different border styles
perfectly, so I have filed a few followup bugs that I will
reference from this Bugzilla.

  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawArc): drawArc() has different parameters now, but mostly this needs to be implemented to match the Mac side later. (WebCore::GraphicsContext::addRoundedRectClip): Just a stub. Implement this later. (WebCore::GraphicsContext::addInnerRoundedRectClip): Just a stub. Implement this later.
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawArc): drawArc() now handles drawing elliptical arcs as well as circular arcs, it also takes a thickness parameter to draw an arc of a given thickness and draws with the appropriate pen style. (WebCore::GraphicsContext::addInnerRoundedRectClip): Adds a clip to the inside of an arc instead of to the outside which is already done by addRoundedClipRect()
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorderArc): Draws the border arcs in the appropriate styles. (WebCore::RenderObject::paintBorder): Calls drawBorderArc() when border arcs are needed.
  • rendering/RenderObject.h:
1:05 PM Changeset in webkit [14649] by hyatt
  • 2 edits in trunk/WebCore

Fix Win32 build bustage from Screen/Page FloatRect conversion

11:11 AM Changeset in webkit [14648] by brmorris
  • 8 edits in S60/trunk

S60WebKit:

2006-05-30 Pat <​vincent.bradley@nokia.com>

Reviewed by Bradley/Zalan


  • S60WebUi/WebUi/data/WebUi.rss
  • S60WebUi/WebUi/inc/WebUi.hrh
  • S60WebUi/WebUi/inc/WebUiAutomatedTests.h
  • S60WebUi/WebUi/src/WebUiAutomatedTests.cpp
  • S60WebUi/WebUi/src/WebUiLoadObserver.cpp
  • S60WebUi/WebUi/src/WebUiWindowContainer.cpp


11:04 AM Changeset in webkit [14647] by darin
  • 1 delete in trunk/WebCore/RenderView.cpp

Remove accidentally-checked-in file.

10:25 AM Changeset in webkit [14646] by eseidel
  • 121 edits
    1 copy
    12 moves
    10 adds
    6 deletes in trunk/WebCore

2006-05-30 Eric Seidel <​eric@eseidel.com>

Reviewed by andersca.

Add first-cut SVG JS bindings autogeneration.
SVGSVGElement and various other support classes are generated.
Various small style fixes.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4249

  • DerivedSources.make:
  • WebCore+SVG/RGBColor.cpp: Removed.
  • WebCore+SVG/RGBColor.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper): renamed from createJSWrapper
  • bindings/js/JSHTMLElementWrapperFactory.h:
  • bindings/js/kjs_dom.cpp: (KJS::DOMNode::DOMNode): (KJS::DOMNode::toBoolean): (KJS::DOMNode::getOwnPropertySlot): (KJS::DOMNode::getValueProperty): (KJS::DOMNode::put): (KJS::DOMNode::putValueProperty): (KJS::DOMNode::toPrimitive): (KJS::DOMNode::toString): (KJS::DOMNodeProtoFunc::callAsFunction): (KJS::toEventTargetNode): (KJS::DOMEventTargetNode::getOwnPropertySlot): (KJS::DOMEventTargetNode::getValueProperty): (KJS::DOMEventTargetNode::put): (KJS::DOMEventTargetNode::putValueProperty): (KJS::DOMEventTargetNode::setListener): (KJS::DOMEventTargetNode::getListener): (KJS::DOMEventTargetNode::pushEventHandlerScope): (KJS::DOMEventTargetNodeProtoFunc::callAsFunction): (KJS::DOMNodeList::toPrimitive): (KJS::DOMNodeList::getValueProperty): (KJS::DOMNodeList::indexGetter): (KJS::DOMNodeList::nameGetter): (KJS::DOMNodeList::getOwnPropertySlot): (KJS::DOMNodeList::callAsFunction): (KJS::DOMNodeListFunc::callAsFunction): (KJS::toElement): (KJS::toDocumentType): (KJS::DOMNamedNodeMap::DOMNamedNodeMap): (KJS::DOMNamedNodeMap::~DOMNamedNodeMap): (KJS::DOMNamedNodeMap::lengthGetter): (KJS::DOMNamedNodeMap::indexGetter): (KJS::DOMNamedNodeMap::nameGetter): (KJS::DOMNamedNodeMapProtoFunc::callAsFunction): (KJS::toJS): (KJS::checkNodeSecurity): (KJS::getRuntimeObject): (KJS::DOMExceptionConstructor::getOwnPropertySlot): (KJS::DOMExceptionConstructor::getValueProperty): (KJS::getDOMExceptionConstructor): (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection): (KJS::DOMNamedNodesCollection::lengthGetter): (KJS::DOMNamedNodesCollection::indexGetter): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Document.cpp: (WebCore::Document::implicitClose):
  • dom/Element.h:
  • dom/StyledElement.h:
  • ksvg2/bindings/idl/svg/SVGAngle.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGAnimatedLength.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGColor.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGDocument.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGElement.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGLength.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGMatrix.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGNumber.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPoint.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGRect.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGSVGElement.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGTransform.idl: Removed.
  • ksvg2/bindings/idl/svg/kdomdefs.idl: Removed.
  • ksvg2/bindings/js: Added.
  • ksvg2/bindings/js/JSSVGNumber.cpp: Added. (WebCore::): (WebCore::JSSVGNumber::~JSSVGNumber): (WebCore::JSSVGNumber::getOwnPropertySlot): (WebCore::JSSVGNumber::getValue): (WebCore::getJSSVGNumber):
  • ksvg2/bindings/js/JSSVGNumber.h: Added. (WebCore::JSSVGNumber::JSSVGNumber): (WebCore::JSSVGNumber::classInfo):
  • ksvg2/bindings/js/JSSVGPoint.cpp: Added. (WebCore::): (WebCore::JSSVGPoint::~JSSVGPoint): (WebCore::JSSVGPoint::getOwnPropertySlot): (WebCore::JSSVGPoint::getValueProperty): (WebCore::getJSSVGPoint): (WebCore::toFloatPoint):
  • ksvg2/bindings/js/JSSVGPoint.h: Added. (WebCore::JSSVGPoint::JSSVGPoint): (WebCore::JSSVGPoint::classInfo): (WebCore::JSSVGPoint::): (WebCore::JSSVGPoint::impl):
  • ksvg2/bindings/js/JSSVGRect.cpp: Added. (WebCore::): (WebCore::JSSVGRect::~JSSVGRect): (WebCore::JSSVGRect::getOwnPropertySlot): (WebCore::JSSVGRect::getValueProperty): (WebCore::getJSSVGRect): (WebCore::toFloatRect):
  • ksvg2/bindings/js/JSSVGRect.h: Added. (WebCore::JSSVGRect::JSSVGRect): (WebCore::JSSVGRect::classInfo): (WebCore::JSSVGRect::): (WebCore::JSSVGRect::impl):
  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • ksvg2/events/SVGZoomEvent.cpp: (SVGZoomEvent::SVGZoomEvent): (SVGZoomEvent::zoomRectScreen): (SVGZoomEvent::previousTranslate): (SVGZoomEvent::newTranslate):
  • ksvg2/events/SVGZoomEvent.h:
  • ksvg2/ksvg.h: (WebCore::):
  • ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::SVGDocumentExtensions): (WebCore::SVGDocumentExtensions::~SVGDocumentExtensions): (WebCore::SVGDocumentExtensions::addTimeContainer): (WebCore::SVGDocumentExtensions::removeTimeContainer): (WebCore::SVGDocumentExtensions::startAnimations): (WebCore::SVGDocumentExtensions::pauseAnimations): (WebCore::SVGDocumentExtensions::unpauseAnimations):
  • ksvg2/misc/SVGDocumentExtensions.h:
  • ksvg2/svg/SVGAElement.h:
  • ksvg2/svg/SVGAngle.h: (WebCore::SVGAngle::):
  • ksvg2/svg/SVGAngle.idl: Added.
  • ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::SVGAnimateColorElement): (WebCore::SVGAnimateColorElement::handleTimerEvent): (WebCore::SVGAnimateColorElement::clampColor):
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimateElement.cpp: (SVGAnimateElement::SVGAnimateElement): (SVGAnimateElement::handleTimerEvent):
  • ksvg2/svg/SVGAnimateElement.h:
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement): (WebCore::SVGAnimateTransformElement::parseMappedAttribute): (WebCore::SVGAnimateTransformElement::handleTimerEvent): (WebCore::SVGAnimateTransformElement::parseTransformValue): (WebCore::SVGAnimateTransformElement::calculateRotationFromMatrix): (WebCore::SVGAnimateTransformElement::initialMatrix):
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGAnimatedLength.idl: Added.
  • ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::closeRenderer):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGCircleElement.h:
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGColor.cpp: (WebCore::SVGColor::SVGColor): (WebCore::SVGColor::rgbColor): (WebCore::SVGColor::setRGBColor): (WebCore::SVGColor::setRGBColorICCColor): (WebCore::SVGColor::setColor): (WebCore::SVGColor::color):
  • ksvg2/svg/SVGColor.h: (WebCore::SVGColor::): (WebCore::SVGColor::setRGBColor):
  • ksvg2/svg/SVGColor.idl: Added.
  • ksvg2/svg/SVGComponentTransferFunctionElement.h:
  • ksvg2/svg/SVGCursorElement.h:
  • ksvg2/svg/SVGDefsElement.h:
  • ksvg2/svg/SVGDescElement.h:
  • ksvg2/svg/SVGDocument.idl: Added.
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement): (WebCore::SVGElement::isSupported): (WebCore::SVGElement::id): (WebCore::SVGElement::setId): (WebCore::SVGElement::xmlbase): (WebCore::SVGElement::setXmlbase): (WebCore::SVGElement::ownerSVGElement): (WebCore::SVGElement::viewportElement): (WebCore::SVGElement::tryGetAttribute): (WebCore::SVGElement::tryGetAttributeNS): (WebCore::SVGElement::childShouldCreateRenderer):
  • ksvg2/svg/SVGElement.h:
  • ksvg2/svg/SVGElement.idl: Added.
  • ksvg2/svg/SVGEllipseElement.h:
  • ksvg2/svg/SVGEvent.idl: Added.
  • ksvg2/svg/SVGFEBlendElement.h:
  • ksvg2/svg/SVGFEColorMatrixElement.h:
  • ksvg2/svg/SVGFEComponentTransferElement.h:
  • ksvg2/svg/SVGFECompositeElement.h:
  • ksvg2/svg/SVGFEDiffuseLightingElement.h:
  • ksvg2/svg/SVGFEDistantLightElement.h:
  • ksvg2/svg/SVGFEFloodElement.h:
  • ksvg2/svg/SVGFEFuncAElement.h:
  • ksvg2/svg/SVGFEFuncBElement.h:
  • ksvg2/svg/SVGFEFuncGElement.h:
  • ksvg2/svg/SVGFEFuncRElement.h:
  • ksvg2/svg/SVGFEGaussianBlurElement.h:
  • ksvg2/svg/SVGFEImageElement.h:
  • ksvg2/svg/SVGFELightElement.h:
  • ksvg2/svg/SVGFEMergeElement.h:
  • ksvg2/svg/SVGFEMergeNodeElement.h:
  • ksvg2/svg/SVGFEOffsetElement.h:
  • ksvg2/svg/SVGFEPointLightElement.h:
  • ksvg2/svg/SVGFESpecularLightingElement.h:
  • ksvg2/svg/SVGFESpotLightElement.h:
  • ksvg2/svg/SVGFETileElement.h:
  • ksvg2/svg/SVGFETurbulenceElement.h:
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
  • ksvg2/svg/SVGForeignObjectElement.h:
  • ksvg2/svg/SVGGElement.h:
  • ksvg2/svg/SVGGradientElement.h:
  • ksvg2/svg/SVGHelper.cpp: (WebCore::SVGHelper::PercentageOfViewport): (WebCore::SVGHelper::ParseSeperatedList):
  • ksvg2/svg/SVGImageElement.h:
  • ksvg2/svg/SVGLength.h: (WebCore::SVGLength::):
  • ksvg2/svg/SVGLength.idl: Added.
  • ksvg2/svg/SVGLineElement.h:
  • ksvg2/svg/SVGLinearGradientElement.h:
  • ksvg2/svg/SVGLocatable.cpp: (SVGLocatable::getBBox):
  • ksvg2/svg/SVGLocatable.h:
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGMatrix.cpp: (SVGMatrix::inverse): (SVGMatrix::rotateFromVector):
  • ksvg2/svg/SVGMatrix.h:
  • ksvg2/svg/SVGMatrix.idl: Added.
  • ksvg2/svg/SVGNumber.idl: Added.
  • ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::getPointAtLength):
  • ksvg2/svg/SVGPathElement.h:
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::x): (WebCore::SVGPatternElement::y): (WebCore::SVGPatternElement::width): (WebCore::SVGPatternElement::height): (WebCore::SVGPatternElement::pushAttributeContext): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::notifyClientsToRepaint): (WebCore::SVGPatternElement::notifyAttributeChange): (WebCore::SVGPatternElement::canvasResource): (WebCore::SVGPatternElement::getCTM):
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGPoint.idl: Added.
  • ksvg2/svg/SVGPolyElement.h:
  • ksvg2/svg/SVGPolygonElement.h:
  • ksvg2/svg/SVGPolylineElement.h:
  • ksvg2/svg/SVGRadialGradientElement.h:
  • ksvg2/svg/SVGRect.idl: Added.
  • ksvg2/svg/SVGRectElement.h:
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::~SVGSVGElement): (WebCore::SVGSVGElement::viewport): (WebCore::SVGSVGElement::currentTranslate): (WebCore::SVGSVGElement::unsuspendRedraw): (WebCore::SVGSVGElement::getIntersectionList): (WebCore::SVGSVGElement::getEnclosureList): (WebCore::SVGSVGElement::checkIntersection): (WebCore::SVGSVGElement::checkEnclosure): (WebCore::SVGSVGElement::createSVGNumber): (WebCore::SVGSVGElement::createSVGPoint): (WebCore::SVGSVGElement::createSVGRect): (WebCore::SVGSVGElement::pauseAnimations): (WebCore::SVGSVGElement::unpauseAnimations): (WebCore::SVGSVGElement::animationsPaused): (WebCore::SVGSVGElement::getCurrentTime): (WebCore::SVGSVGElement::setCurrentTime):
  • ksvg2/svg/SVGSVGElement.h: (WebCore::SVGSVGElement::timeScheduler):
  • ksvg2/svg/SVGSVGElement.idl: Added.
  • ksvg2/svg/SVGScriptElement.h:
  • ksvg2/svg/SVGSetElement.cpp: (WebCore::SVGSetElement::SVGSetElement): (WebCore::SVGSetElement::handleTimerEvent):
  • ksvg2/svg/SVGSetElement.h:
  • ksvg2/svg/SVGStopElement.h:
  • ksvg2/svg/SVGStyleElement.h:
  • ksvg2/svg/SVGStyledElement.h:
  • ksvg2/svg/SVGStyledLocatableElement.cpp: (SVGStyledLocatableElement::getBBox):
  • ksvg2/svg/SVGStyledLocatableElement.h:
  • ksvg2/svg/SVGStyledTransformableElement.cpp: (SVGStyledTransformableElement::getBBox):
  • ksvg2/svg/SVGStyledTransformableElement.h:
  • ksvg2/svg/SVGSwitchElement.h:
  • ksvg2/svg/SVGSymbolElement.h:
  • ksvg2/svg/SVGTRefElement.h:
  • ksvg2/svg/SVGTSpanElement.h:
  • ksvg2/svg/SVGTextContentElement.cpp: (SVGTextContentElement::getStartPositionOfChar): (SVGTextContentElement::getEndPositionOfChar): (SVGTextContentElement::getExtentOfChar): (SVGTextContentElement::getCharNumAtPosition): (SVGTextContentElement::parseMappedAttribute):
  • ksvg2/svg/SVGTextContentElement.h:
  • ksvg2/svg/SVGTextElement.cpp: (WebCore::SVGTextElement::getBBox):
  • ksvg2/svg/SVGTextElement.h:
  • ksvg2/svg/SVGTextPositioningElement.h:
  • ksvg2/svg/SVGTitleElement.h:
  • ksvg2/svg/SVGTransform.h: (WebCore::SVGTransform::):
  • ksvg2/svg/SVGTransform.idl: Added.
  • ksvg2/svg/SVGUseElement.h:
  • ksvg2/svg/SVGViewElement.h:
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::pauseTimeouts): (WebCore::Frame::resumeTimeouts):
  • platform/Color.h:
  • rendering/RenderBR.h:
  • rendering/RenderBox.h: (WebCore::RenderBox::renderName):
  • rendering/RenderCanvas.h: (WebCore::RenderCanvas::view):
  • rendering/RenderContainer.h:
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFlow.h: (WebCore::RenderFlow::RenderFlow):
  • rendering/RenderInline.h:
  • rendering/RenderTableSection.h:
  • rendering/RenderTextFragment.h: (WebCore::RenderTextFragment::contentString):
  • xml/xmlattrs.in: Added.
9:51 AM Changeset in webkit [14645] by brmorris
  • 2 edits in S60/trunk/S60WebUi/WebUi/src

2006-05-30 Zalan <​zbujtas@gmail.com>

Second commit, Reviewed by Bradley/David


  • S60WebUi/WebUi/src/WebUiLoadObserver.cpp:
  • S60WebUi/WebUi/src/WebUiWindowContainer.cpp:


9:50 AM Changeset in webkit [14644] by brmorris
  • 1 edit
    2 adds in S60/trunk

2006-05-30 Zalan <​zbujtas@gmail.com>

Reviewed by Bradley/David


  • S60WebUi/WebUi/src/WebUiLoadObserver.cpp:
  • S60WebUi/WebUi/src/WebUiWindowContainer.cpp:


12:48 AM Changeset in webkit [14643] by ggaren
  • 15 edits
    1 move in trunk/WebCore

Reviewed by Maciej.

  • Fixed <rdar://problem/4559720> window sizing: make javascript window and screen sizing methods and properties work @ HIDPI


The general approach here is to change some ints to floats, make
a few key functions that scale between WebView and window/screen
coordinates, and change other functions that work with screen
coordinates to use the scaling functions for their underlying
implementations.

  • manual-tests/window-open-features.html: Removed.
  • manual-tests/window-sizing.html: Added. More test coverage.
  • bindings/js/kjs_window.cpp: Changed ints to floats and IntRects to FloatRects, because window coordinates can be fractional when scaled to WebView/DOM coordinates. (KJS::floatFeature): (KJS::showModalDialog): (KJS::Window::getValueProperty): (KJS::constrainToVisible): (KJS::WindowFunc::callAsFunction):
  • bridge/BrowserExtension.h:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow): Removed custom scaling code and replaced with calls to Page::windowRect and Page::setWindowRect. Renamed 'page' and 'bridge' to 'pageBridge' and 'frameBridge,' respectively.
  • bridge/mac/PageMac.mm: (WebCore::Page::windowRect): Changed to use scaling (WebCore::Page::setWindowRect): ditto
  • bridge/mac/WebCoreFrameBridge.mm: (globalPoint):
  • page/Page.h:
  • platform/IntRect.h:
  • platform/Screen.h:
  • platform/mac/MouseEventMac.mm: (WebCore::globalPositionForEvent): Changed to use flipScreenPoint
  • platform/mac/ScreenMac.mm: (WebCore::flipScreenRect): New key function (WebCore::flipScreenPoint): New key function (WebCore::scaleScreenRectToView): New key function (WebCore::scaleViewRectToScreen): New key function (WebCore::screenRect): Changed to use scaling (WebCore::usableScreenRect): ditto

Feeble attempt to preserve Windows build:


  • platform/win/ScreenWin.cpp: (WebCore::scaleScreenRectToWidget): stub -- doesn't actually scale (WebCore::scaleWidgetRectToScreen): ditto
  • bridge/win/PageWin.cpp: (WebCore::Page::Page): (WebCore::Page::widget):
12:12 AM Changeset in webkit [14642] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderView.h

Fix layout tests.

May 30, 2006:

9:12 PM Changeset in webkit [14641] by thatcher
  • 1 copy in tags/WebCore-418.11/WebCore

Tag for WebCore 418.11 (part 2 of 2.)

9:12 PM Changeset in webkit [14640] by thatcher
  • 1 add in tags/WebCore-418.11

Tag for WebCore 418.11 (part 1 of 2.)

9:11 PM Changeset in webkit [14639] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

6:48 PM Changeset in webkit [14638] by hyatt
  • 41 edits
    1 copy
    2 moves in trunk/WebCore

Rename RenderCanvas to RenderView. Rename canvas(), isCanvas()
to view(), isView(). Rename the frame view accessor on the old canvas
from view() to frameView() (to avoid view()->view(), since that just looks
stupid). :)

Reviewed by andersca

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_window.cpp:
  • bridge/mac/FrameMac.mm:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge _setupRootForPrinting:]): (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]): (-[WebCoreFrameBridge selectionColor]): (-[WebCoreFrameBridge accessibilityTree]):
  • dom/Document.cpp: (WebCore::Document::attach): (WebCore::Document::updateSelection): (WebCore::Document::prepareMouseEvent):
  • editing/SelectionController.cpp:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
  • ksvg2/svg/SVGClipPathElement.cpp: (SVGClipPathElement::canvasResource):
  • ksvg2/svg/SVGFEFloodElement.cpp: (SVGFEFloodElement::filterEffect):
  • ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::rebuildStops):
  • ksvg2/svg/SVGHelper.cpp: (SVGHelper::PercentageOfViewport):
  • ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::getPointAtLength):
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentTranslate):
  • ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::view): (WebCore::SVGStyledElement::pushAttributeContext):
  • ksvg2/svg/SVGStyledElement.h:
  • kwq/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityShouldUseUniqueId]): (-[WebCoreAXObject role]): (-[WebCoreAXObject value]): (-[WebCoreAXObject position]): (-[WebCoreAXObject accessibilityIsIgnored]): (-[WebCoreAXObject accessibilityAttributeNames]): (-[WebCoreAXObject topView]): (-[WebCoreAXObject accessibilityAttributeValue:]):
  • page/Frame.cpp: (WebCore::Frame::selectionRect): (WebCore::Frame::paint): (WebCore::Frame::adjustPageHeight): (WebCore::Frame::forceLayoutWithPageWidthRange):
  • page/FrameView.cpp: (WebCore::FrameView::adjustViewSize): (WebCore::FrameView::layout):
  • page/FrameView.h:
  • rendering/AutoTableLayout.cpp: (WebCore::shouldScaleColumns):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::MarginInfo::MarginInfo): (WebCore::RenderBlock::isSelfCollapsingBlock): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::setSelectionState): (WebCore::RenderBlock::isSelectionRoot): (WebCore::RenderBlock::fillInlineSelectionGaps): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::clearFloats): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::calcBlocminMaxWidth): (WebCore::RenderBlock::inRootBlockContext):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBackgroundExtended): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::availableHeightUsing):
  • rendering/RenderCanvas.cpp: Removed.
  • rendering/RenderCanvas.h: Removed.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode):
  • rendering/RenderFileButton.cpp: (WebCore::RenderFileButton::RenderFileButton):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::destroy): (WebCore::RenderFlow::paintLines):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout): (WebCore::RenderFrameSet::userResize): (WebCore::RenderFrameSet::setResizing):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::stackingContext): (WebCore::RenderLayer::enclosingPositionedAncestor): (WebCore::RenderLayer::convertToLayerCoords): (WebCore::RenderLayer::scrollToOffset): (WebCore::isSubframeCanvas): (WebCore::RenderLayer::intersectsDamageRect):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::isStackingContext):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::scroll): (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::repaint): (WebCore::RenderObject::repaintRectangle): (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::draggableNode): (WebCore::RenderObject::selectionStartEnd): (WebCore::RenderObject::setStyle): (WebCore::RenderObject::viewRect): (WebCore::RenderObject::view): (WebCore::RenderObject::container): (WebCore::RenderObject::removeFromObjectLists): (WebCore::RenderObject::scheduleRelayout): (WebCore::RenderObject::imageChanged): (WebCore::RenderObject::maximalOutlineSize):
  • rendering/RenderObject.h: (WebCore::RenderObject::isRenderView):
  • rendering/RenderTextArea.cpp: (WebCore::RenderTextArea::RenderTextArea):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintCheckbox): (WebCore::RenderThemeMac::paintRadio): (WebCore::RenderThemeMac::paintButton):
  • rendering/RenderTreeAsText.cpp: (externalRepresentation):
  • rendering/RenderView.cpp: Added. (WebCore::RenderView::RenderView): (WebCore::RenderView::~RenderView): (WebCore::RenderView::calcHeight): (WebCore::RenderView::calcWidth): (WebCore::RenderView::calcMinMaxWidth): (WebCore::RenderView::layout): (WebCore::RenderView::absolutePosition): (WebCore::RenderView::paint): (WebCore::RenderView::paintBoxDecorations): (WebCore::RenderView::repaintViewRectangle): (WebCore::RenderView::getAbsoluteRepaintRect): (WebCore::RenderView::computeAbsoluteRepaintRect): (WebCore::RenderView::absoluteRects): (WebCore::RenderView::selectionRect): (WebCore::RenderView::setSelection): (WebCore::RenderView::clearSelection): (WebCore::RenderView::selectionStartEnd): (WebCore::RenderView::updateWidgetPositions): (WebCore::RenderView::addWidget): (WebCore::RenderView::removeWidget): (WebCore::RenderView::viewRect): (WebCore::RenderView::docHeight): (WebCore::RenderView::docWidth): (WebCore::RenderView::setBestTruncatedAt):
  • rendering/RenderView.h: Added. (WebCore::RenderView::renderName): (WebCore::RenderView::isRenderView): (WebCore::RenderView::frameView):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::RenderWidget): (WebCore::RenderWidget::destroy): (WebCore::RenderWidget::updateWidgetPosition):
  • rendering/RenderWidget.h: (WebCore::RenderWidget::widget):
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
6:31 PM Changeset in webkit [14637] by tomernic
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4567776> REGRESSION: window.open() links do not work at www.newarchery.com

  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Set the URL in the ResourceRequest; otherwise, it'll be uninitialized and createNewWindow() will not be able to load the URL into a pre-existing frame.
2:56 PM Changeset in webkit [14636] by lweintraub
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by justin.

<rdar://problem/4039661> crash in ApplyStyleCommand::applyBlockStyle(DOM::CSSMutableStyleDeclarationImpl*, DOM::Position const&, DOM::Position const&) pasting contents of webpage into Mail or Blot
<rdar://problem/4029632> Mail crashes in DOM::NodeImpl::isBlockFlow() after pasting text with alignment style and BR element from Safari

  • khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::applyBlockStyle): Swap reversed start and end selection points to avoid null dereference. (khtml::ApplyStyleCommand::removeInlineStyle): Modified assert to not complain about caret selections.
2:53 PM Changeset in webkit [14635] by brmorris
  • 1 edit
    1 add in S60/trunk

S60WebKit:

2006-05-30 Bradley Morrison <​bradley.morrison@nokia.com>

Reviewed by Antti K/Zalan


2:10 PM Changeset in webkit [14634] by bdakin
  • 3 edits
    8 adds in trunk

Reviewed by Maciej, landed by Beth.

Adds special case.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::calcReplacedHeightUsing):
1:47 PM Changeset in webkit [14633] by bdakin
  • 3 edits
    4 adds in trunk

Reviewed by Hyatt, landed by Beth.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
11:57 AM Changeset in webkit [14632] by thatcher
  • 1 copy in tags/JavaScriptCore-418.3/JavaScriptCore

Tag for JavaScriptCore 418.3 (part 2 of 2.)

11:57 AM Changeset in webkit [14631] by thatcher
  • 1 add in tags/JavaScriptCore-418.3

Tag for JavaScriptCore 418.3 (part 1 of 2.)

11:56 AM Changeset in webkit [14630] by thatcher
  • 1 copy in tags/WebCore-418.10/WebCore

Tag for WebCore 418.10 (part 2 of 2.)

11:56 AM Changeset in webkit [14629] by thatcher
  • 1 add in tags/WebCore-418.10

Tag for WebCore 418.10 (part 1 of 2.)

11:55 AM Changeset in webkit [14628] by thatcher
  • 4 edits in branches/Safari-2-0-branch

Versioning

11:32 AM Changeset in webkit [14627] by thatcher
  • 3 copies in tags/WebKit-521.12/WebKit

New tag (part 2)

11:31 AM Changeset in webkit [14626] by thatcher
  • 1 add in tags/WebKit-521.12

New tag

11:30 AM Changeset in webkit [14625] by thatcher
  • 2 copies in tags/WebCore-521.12/WebCore

New tag (part 2)

11:28 AM Changeset in webkit [14624] by thatcher
  • 1 add in tags/WebCore-521.12

New tag

11:20 AM Changeset in webkit [14623] by thatcher
  • 4 edits in /

Versioning

9:22 AM Changeset in webkit [14622] by thatcher
  • 8 edits in branches/Safari-2-0-branch

JavaScriptCore:

Reviewed by Maciej.


  • Rolling out the 'currentThreadIsMainThread' argument passed to Interpreter::mark because the fix for <rdar://problem/4562599> makes it superfluous.


  • kjs/collector.cpp: (KJS::Collector::collect):
  • kjs/internal.cpp: (InterpreterImp::mark):
  • kjs/internal.h:
  • kjs/interpreter.h: (KJS::Interpreter::mark):

WebCore:

Reviewed by Maciej.


  • Fixed <rdar://problem/4562599> 10.4.7 regression: After closing a window that contains macworld.com, creating a new window results in crash (KJS::PropertyMap::mark() )

ScriptInterpreter used to be responsible for marking cached DOM objects.
That was insufficient because once all the windows are closed, there's
no ScriptInterpreter left to do the marking.


The solution here is to allocate a static, protected 'DOMObjectsMarker'
object that takes care of marking the DOM object caches.


  • khtml/ecma/kjs_binding.cpp: (KJS::DOMObjectsMarker::mark): (KJS::ScriptInterpreter::domObjects): (KJS::ScriptInterpreter::domNodesPerDocument):
  • khtml/ecma/kjs_binding.h:
1:34 AM Changeset in webkit [14621] by eseidel
  • 6 edits in trunk/WebCore

2006-05-30 Eric Seidel <​eric@eseidel.com>

Reviewed by andersca.

Small amount of svg-related code cleanup.
No test case possible.

  • ksvg2/svg/SVGColor.h:
  • ksvg2/svg/SVGLength.cpp: (SVGLength::SVGLength): (SVGLength::value):
  • ksvg2/svg/SVGMarkerElement.cpp:
  • ksvg2/svg/SVGMatrix.cpp: (SVGMatrix::SVGMatrix): (SVGMatrix::copy): (SVGMatrix::postMultiply): (SVGMatrix::inverse): (SVGMatrix::postTranslate): (SVGMatrix::postScale): (SVGMatrix::postScaleNonUniform): (SVGMatrix::postRotate): (SVGMatrix::postRotateFromVector): (SVGMatrix::postFlipX): (SVGMatrix::postFlipY): (SVGMatrix::postSkewX): (SVGMatrix::postSkewY): (SVGMatrix::multiply): (SVGMatrix::translate): (SVGMatrix::scale): (SVGMatrix::scaleNonUniform): (SVGMatrix::rotate): (SVGMatrix::rotateFromVector): (SVGMatrix::flipX): (SVGMatrix::flipY): (SVGMatrix::skewX): (SVGMatrix::skewY): (SVGMatrix::setMatrix): (SVGMatrix::qmatrix): (SVGMatrix::removeScale):
  • ksvg2/svg/SVGMatrix.h:
1:30 AM Changeset in webkit [14620] by eseidel
  • 5 edits in trunk/WebCore

2006-05-30 Eric Seidel <​eric@eseidel.com>

Reviewed by andersca.

Small ammount of bindings-related code cleanup.
No test case possible.

  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::nameGetter):
  • bindings/js/JSXMLSerializer.cpp: (WebCore::JSXMLSerializerConstructorImp::JSXMLSerializerConstructorImp): (WebCore::JSXMLSerializerConstructorImp::implementsConstruct): (WebCore::JSXMLSerializerConstructorImp::construct): (WebCore::): (WebCore::JSXMLSerializer::JSXMLSerializer): (WebCore::JSXMLSerializerProtoFunc::callAsFunction):
  • bindings/js/JSXMLSerializer.h: (WebCore::JSXMLSerializer::toBoolean): (WebCore::JSXMLSerializer::classInfo): (WebCore::JSXMLSerializer::):
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
Note: See TracTimeline for information about the timeline view.