Timeline



Jun 4, 2006:

10:20 PM Changeset in webkit [14733] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • bindings/js/kjs_window.cpp: Added include of <wtf/MathExtras.h>. (WebCore::floatFeature): Remove WIN32 ifdef around isnan. (WebCore::toJS): Add null checks.
9:15 PM Changeset in webkit [14732] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

  • fast/loader/link-no-URL.html: Added.
  • fast/loader/link-no-URL-expected.txt: Added.

WebCore:

Reviewed by Maciej.

Test: fast/loader/link-no-URL.html

  • loader/Cache.h:
  • loader/Cache.cpp: (WebCore::Cache::updateCacheStatus): Removed the URL parameter. Instead get the URL from the cached object itself. Callers were passing in the wrong URL. When it was a null string, it caused the crash mentioned above. But in other cases it may have caused some other minor problems as well. Added an assert to catch cases where the URL is null (should never happen). (WebCore::Cache::requestImage): Changed call site to not pass URL. (WebCore::Cache::requestStyleSheet): Ditto. (WebCore::Cache::requestScript): Ditto. (WebCore::Cache::requestXSLStyleSheet): Ditto. (WebCore::Cache::requestXBLDocument): Ditto.
8:09 PM Changeset in webkit [14731] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.


  • kjs/value.h: Removed redundant declarations
4:05 PM Changeset in webkit [14730] by darin
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • platform/mac/WebCoreTextField.mm: (inputElement): Added. Helper function to get the Objective-C wrapper for an input element associated with a QTextEdit. Returns nil if the element is not an input element. The bug was caused by passing a non-input element to the delegate methods. (-[KWQTextFieldController controlTextDidBeginEditing:]): Use inputElement and don't make the delegate call at all if there is none. This happens only with isindex elements; it's not important to have auto-fill work with those. (-[KWQTextFieldController controlTextDidEndEditing:]): Ditto. (-[KWQTextFieldController controlTextDidChange:]): Ditto. (-[KWQTextFieldController control:textShouldEndEditing:]): Ditto. (-[KWQTextFieldController control:textView:doCommandBySelector:]): Ditto. (-[KWQTextFieldController textView:shouldHandleEvent:]): Ditto.
4:03 PM Changeset in webkit [14729] by darin
  • 36 edits in trunk/WebCore

Reviewed by Anders.

  • fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8995 memory leak in XPath code -- seen in layout tests
  • fixed malloc error on exit due to SVGDOMImplementation destructor
  • attempted to fix the no-XPATH_SUPPORT build by adding an #if
  • changed around includes and header-file formatting in XPath code
  • bindings/scripts/CodeGeneratorJS.pm: Include PlatformString.h when generating the bindings for XPathNSResolver.
  • dom/DOMImplementation.h: Added a virtual destructor for the benefit of SVGDOMImplementation.
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::~DOMImplementation): Added.
  • ksvg2/svg/SVGDOMImplementation.h: Reformatted a bit, removed unneeded declarations.
  • ksvg2/svg/SVGDOMImplementation.cpp: (SVGDOMImplementation::~SVGDOMImplementation): Remove commented-out code. (SVGDOMImplementation::createDocument): Remove a reference to KDOMView.
  • xpath/XPathExpression.cpp: (WebCore::XPathExpression::createExpression): Called release to avoid a tiny bit of reference count churn. (WebCore::XPathExpression::evaluate): Set exception code explicitly, because the code relies on it being 0 when the function succeeds.
  • xpath/XPathResult.cpp: (WebCore::InvalidatingEventListener::InvalidatingEventListener): Removed unneeded target node data member. (WebCore::XPathResult::XPathResult): Updated for enum name changes and InvalidatingEventListener name change. Added an assertion.
  • xpath/impl/XPathFunctions.h: Removed the FunctionLibrary class. Changed the parameter for createFunction to be a String instead of char*.
  • xpath/impl/XPathFunctions.cpp: Got rid of local implementation of "round", and used <wtf/MathExtras.h> instead. Also removed unused Interval::asString. Marked all the Interval functions inline. (WebCore::XPath::FunSubstring::doEvaluate): Use lround() instead of (long)round(). (WebCore::XPath::FunLang::doEvaluate): Removed some unneeded temporary String variables. Use equalIgnoringCase() instead of calling lower() on two strings. (WebCore::XPath::createFunctionMap): Changed how this works so that it's all local to this function. Also removed a duplicate entry for the "last" function. (WebCore::XPath::createFunction): Changed from a member function to a separate function. Also changed so that if the args are not used in the function they are deleted. This was one of the sources of the storage leaks.
  • xpath/impl/XPathGrammar.y: Put XPATH_SUPPORT ifdef in. Replaced <num> with values of specific types (numop, eqop). Updated for name change from AxisType to Axis. Changed tokens that were declared as <str> but weren't actually using the string to be declared with no type (PLUS, MINUS, OR, AND, DOTDOT, SLASHSLASH). Replaced use of unregisterString, unregisterPredicateVector, and unregisterExpressionVector to call delete functions instead that both unregister and delete. Change call sites for createFunction to just use the String, removing the deprecatedString().latin1() call that is no longer needed. Added a call to unregisterParseNode that was missing in the "FilterExpr DescendantOrSelf RelativeLocationPath" production.
  • xpath/impl/XPathParser.h: Changed Token to hold a String, Step::Axis, NumericOp::Opcode, and EqTestOp::Opcode. The token ID number tells us which to use. Rearranged to put the private part of the Parser class last. Moved a number of private things inside the cpp file.
  • xpath/impl/XPathParser.cpp: (WebCore::XPath::charCat): Made this a separate function, instead of a static member. (WebCore::XPath::isAxisName): Ditto. Also put the global axis map inside the function, allowing use of a map instead of a map pointer. (WebCore::XPath::isNodeTypeName): Ditto. (WebCore::XPath::Parser::isOperatorContext): Made this const. (WebCore::XPath::Parser::makeTokenAndAdvance): Got rid of the "int" version of this. By using the actual types, we can safely use overload instead. (WebCore::XPath::Parser::lexString): Use substring() instead of deprecatedString().mid(). (WebCore::XPath::Parser::lexNumber): Ditto. (WebCore::XPath::Parser::lexNCName): Changed to return a bool and a String instead of a Token. This avoids the hack of using a token value of "ERROR + 1" which I found quite confusing and is also a bit more explicit. (WebCore::XPath::Parser::lexQName): Ditto. (WebCore::XPath::Parser::nextTokenInternal): Changed to adapt to the changes above and to remove some unneeded else statements. (WebCore::XPath::Parser::lex): Changed the logic that sets up yylval to use the token ID to decide what the type is. This matches what the grammar expects, and removes the need for the token object to track which part of the value is good and the need to reserve 0 to have a special meaning. (WebCore::XPath::Parser::parseStatement): Added code to delete the predicates and the expressions in the predicate and expression vectors. Before, we were only deleting the vectors. This was one of the sources of the storage leaks. (WebCore::XPath::Parser::deletePredicateVector): Renamed, and changed to delete the vector. However this does not delete the predicates in the vector. (WebCore::XPath::Parser::deleteExpressionVector): Renamed, and changed to delete the vector. However this does not delete the expressions in the vector. (WebCore::XPath::Parser::deleteString): Renamed, and changed to delete the string.
  • xpath/impl/XPathPredicate.h:
  • xpath/impl/XPathPredicate.cpp: (WebCore::XPath::NumericOp::NumericOp): Changed opcode from an int to an enum, and renamed to "opcode" instead of "opCode". (WebCore::XPath::NumericOp::doEvaluate): More of the same. (WebCore::XPath::EqTestOp::EqTestOp): Ditto. (WebCore::XPath::EqTestOp::doEvaluate): Ditto. (WebCore::XPath::LogicalOp::LogicalOp): Ditto. (WebCore::XPath::LogicalOp::shortCircuitOn): Ditto. (WebCore::XPath::Predicate::evaluate): Removed an unneeded "new".
  • xpath/impl/XPathStep.h:
  • xpath/impl/XPathStep.cpp: Renamed AxisType to Axis. Removed unused axisAsString function and default constructor.
  • xpath/impl/XPathValue.h: Renamed the type constants to have a Value suffix, instead of the underscore suffix used before on NodeVector and String.
  • xpath/impl/XPathValue.cpp: Updated for name change. Added asserts.
  • xpath/impl/XPathVariableReference.cpp: (WebCore::XPath::VariableReference::doEvaluate): Use a reference instead of a pointer.
  • xpath/XPathEvaluator.cpp:
  • xpath/XPathEvaluator.h:
  • xpath/XPathExpression.h:
  • xpath/XPathNSResolver.cpp:
  • xpath/XPathNSResolver.h:
  • xpath/XPathNamespace.cpp:
  • xpath/XPathNamespace.h:
  • xpath/XPathResult.h:
  • xpath/impl/XPathExpressionNode.cpp:
  • xpath/impl/XPathExpressionNode.h:
  • xpath/impl/XPathPath.cpp:
  • xpath/impl/XPathPath.h:
  • xpath/impl/XPathUtil.cpp:
  • xpath/impl/XPathUtil.h:
  • xpath/impl/XPathVariableReference.h: Reformatted and changed includes around; no substantive changes.
3:51 PM Changeset in webkit [14728] by darin
  • 5 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • changed deleteAllValues so it can work on "const" collections Deleting the values affects the values, not the pointers in the collection, so it's legitimate to do it to a const collection, and a case of that actually came up in the XPath code.
  • wtf/HashMap.h: (WTF::deleteAllPairSeconds): Use const iterators. (WTF::deleteAllValues): Take const HashMap reference as a parameter.
  • wtf/HashSet.h: (WTF::deleteAllValues): Take const HashSet reference as a parameter, and use const iterators.
  • wtf/Vector.h: (WTF::deleteAllValues): Take const Vector reference as a parameter.
  • added more functions that are present in <math.h> on some platforms, but not on others; moved here from various files in WebCore
  • wtf/MathExtras.h: (isinf): Added. (isnan): Added. (lround): Added. (lroundf): Tweaked. (round): Added. (roundf): Tweaked. (signbit): Added.
3:41 PM Changeset in webkit [14727] by ddkilzer
  • 4 edits
    32 adds in trunk

LayoutTests:

Reviewed by hyatt.

  • fast/block/positioning/absolute-in-inline-ltr-2.html: Added.
  • fast/block/positioning/absolute-in-inline-ltr-3.html: Added.
  • fast/block/positioning/absolute-in-inline-ltr.html: Added.
  • fast/block/positioning/absolute-in-inline-rtl-2.html: Added.
  • fast/block/positioning/absolute-in-inline-rtl-3.html: Added.
  • fast/block/positioning/absolute-in-inline-rtl.html: Added.
  • fast/block/positioning/absolute-in-inline-short-ltr.html: Added.
  • fast/block/positioning/absolute-in-inline-short-rtl.html: Added.

WebCore:

Reviewed by hyatt.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
  • rendering/RenderBox.h:
2:41 PM Changeset in webkit [14726] by brmorris
  • 3 edits in S60/trunk

2006-06-04 Bradley <​bradley.morrison@nokia.com>

Reviewed by nobody (oops!)


Webkit.rsg gets processed before webkit.mmp. Fix for nonfatal:


No rule to make target `\EPOC32\INCLUDE\Webkit.rsg'

2:07 PM Changeset in webkit [14725] by brmorris
  • 22 edits
    17 adds in S60/trunk

2006-06-04 Zalan <​zalan.bujtas@nokia.com>

Reviewed by Sachin/Bradley


This commit introduces S60 3.1 support to S60WebKit's
WebKit / BrowserCore (part 3 of 3).

2:04 PM Changeset in webkit [14724] by brmorris
  • 19 edits
    15 adds in S60/trunk

2006-06-04 Zalan <​zalan.bujtas@nokia.com>

Reviewed by Sachin/Bradley


This commit introduces S60 3.1 support to S60WebKit's
WebKit / Plugin and BrowserView (part 2.8 of 3).

1:58 PM Changeset in webkit [14723] by brmorris
  • 46 edits
    11 adds in S60/trunk

2006-06-04 Zalan <​zalan.bujtas@nokia.com>

Reviewed by Sachin/Bradley


This commit introduces S60 3.1 support to S60WebKit's
WebKit / BrowserControl (part 2.6 of 3).

1:54 PM Changeset in webkit [14722] by brmorris
  • 11 edits
    1 add in S60/trunk

2006-06-04 Zalan <​zalan.bujtas@nokia.com>

Reviewed by Sachin/Bradley


This commit introduces S60 3.1 support to S60WebKit's
WebKit / BrowserControl (part 2.2 of 3).

1:37 PM Changeset in webkit [14721] by ddkilzer
  • 3 edits in trunk/WebKitSite

WebKitSite:

Reviewed by ggaren.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9303
JavaScript error when loading WebKit blog page

  • blog/wp-content/themes/webkit/sidebar.php: Removed unused JavaScript. Synced with nav.inc.
  • nav.inc: Removed evil tabs--whitespace change only.
1:12 PM Changeset in webkit [14720] by brmorris
  • 77 edits in S60/trunk

2006-06-04 Zalan <​zalan.bujtas@nokia.com>

Reviewed by Sachin/Bradley


This commit introduces S60 3.1 support to S60WebKit's
Reindeer UI and WebCore (part 2 of 3).

1:05 PM Changeset in webkit [14719] by brmorris
  • 19 edits
    2 adds in S60/trunk

2006-06-04 Zalan <​zalan.bujtas@nokia.com>

Reviewed by Sachin/Bradley


This commit introduces S60 3.1 support to S60WebKit's
JavaScriptCore, MemoryManager and S60Internals (part 1 of 3).

11:52 AM Changeset in webkit [14718] by ddkilzer
  • 4 edits in trunk/WebKitTools

WebKitTools:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9299
Teach svn-create-patch and friends to work with binary files

  • Scripts/svn-apply: Updated to use base64-encoded text for binary files when applying patches.
  • Scripts/svn-create-patch: Updated to include binary file content as base64-encoded text in patches.
  • Scripts/svn-unapply: Updated to recognize binary files when unapplying patches.
1:08 AM Changeset in webkit [14717] by andersca
  • 11 edits
    3 adds in trunk

WebCore:

2006-06-04 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9035
document.evaluate and createNSResolver miss on namespaced elements


  • xpath/XPathExpression.cpp: (WebCore::XPathExpression::createExpression): Pass the resolver to the parser.


  • xpath/XPathResult.cpp: (WebCore::XPathResult::iterateNext): Fix off-by-one error.


  • xpath/impl/XPathExpressionNode.h: (WebCore::XPath::EvaluationContext::EvaluationContext): Get rid of the resolver in the evaluation context.


  • xpath/impl/XPathGrammar.y: Fetch the resolver from the parser. Only return the local name.


  • xpath/impl/XPathParser.cpp: (WebCore::XPath::Parser::parseStatement):
  • xpath/impl/XPathParser.h: (WebCore::XPath::Parser::resolver): Update to hold the resolver.


  • xpath/impl/XPathStep.cpp: (WebCore::XPath::Step::Step): If the parser has stored a namespace URI, set it.


(WebCore::XPath::Step::nodeTestMatches):
Check namespace URIs.


  • xpath/impl/XPathStep.h: Add m_namespaceURI.

LayoutTests:

2006-06-04 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9035
document.evaluate and createNSResolver miss on namespaced elements

  • fast/xpath: Added.
  • fast/xpath/xpath-namespaces-expected.txt: Added.
  • fast/xpath/xpath-namespaces.html: Added.

Jun 3, 2006:

9:33 PM Changeset in webkit [14716] by ddkilzer
  • 1 edit
    1 add in trunk/LayoutTests

LayoutTests:

Reviewed by Eric.

Added missing pixel test output:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8848
TFOOT borders are copied to THEAD and TBODY

  • fast/table/border-collapsing/border-collapsing-head-foot-expected.png: Added.
3:23 PM Changeset in webkit [14715] by ddkilzer
  • 9 edits
    4 adds
    2 deletes in trunk

LayoutTests:

Reviewed by mjs. Tweaked and landed by ddkilzer.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7281
With java disabled wrong information is displayed.

  • fast/replaced/applet-rendering-java-disabled.html: Added.
  • fast/replaced/applet-rendering-java-disabled-expected.checksum: Added.
  • fast/replaced/applet-rendering-java-disabled-expected.html: Added.
  • fast/replaced/applet-rendering-java-disabled-expected.png: Added.
  • tables/mozilla_expected_failures/bugs/bug8499-expected.checksum: Changed after removing RenderEmptyApplet.
  • tables/mozilla_expected_failures/bugs/bug8499-expected.png: Ditto.
  • tables/mozilla_expected_failures/bugs/bug8499-expected.txt: Ditto.

WebCore:

Reviewed by mjs. Tweaked and landed by ddkilzer.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7281
With java disabled wrong information is displayed.

Test: fast/replaced/applet-rendering-java-disabled.html

Match WinIE, render applet content inline when java is
disabled.

  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed RenderEmptyApplet.cpp and RenderEmptyApplet.h.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::createRenderer):
  • rendering/RenderEmptyApplet.cpp: Removed.
  • rendering/RenderEmptyApplet.h: Removed.
1:40 PM Changeset in webkit [14714] by thatcher
  • 3 edits
    5 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/dom/HTMLLinkElement/pending-stylesheet-count.html: Added.
  • fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.txt: Added.
  • fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.png: Added.
  • fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.checksum: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/dom/HTMLLinkElement/pending-stylesheet-count.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::~HTMLLinkElement): If the stylesheet was being loaded, call stylesheetLoaded() on the document, to keep the pending stylesheet count correct.
1:38 PM Changeset in webkit [14713] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9296
Performance improvement for svn-create-patch

  • Scripts/svn-create-patch: Undef $indexPath after all paths have been fixed for a given patch.
1:03 PM Changeset in webkit [14712] by darin
  • 2 edits in trunk/WebCore
  • fix Windows build
  • platform/Widget.h: Moved scaleFactor function out of Apple-specific section of the header into the common part.
11:37 AM Changeset in webkit [14711] by bdakin
  • 5 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/4537274> HiDPI: <canvas> needs to apply a
scale. <canvas> needs to scale itself along with whatever scale
factor is set on the window.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createDrawingContext): Get the scale factor and use it to create a larger buffer and to scale the CGContext.
  • platform/Widget.h: Provide a new function that returns the user space scale factor.
  • platform/mac/WidgetMac.mm: (WebCore::Widget::scaleFactor): Get the scale factor from the window and return it.
  • platform/win/WidgetWin.cpp: (WebCore::Widget::scaleFactor): Just return 1.0f for now.
10:59 AM Changeset in webkit [14710] by ddkilzer
  • 3 edits in trunk/WebKitTools

WebKit:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9290
Teach svn-apply and svn-unapply to patch ChangeLogs cleanly

  • Scripts/svn-apply: Fixed to apply ChangeLog patches without failing.
  • Scripts/svn-unapply: Ditto. Also simplified reversing a deletion.
12:16 AM Changeset in webkit [14709] by sfalken
  • 1 delete in trunk/WebKitWin

2006-06-03 Steve Falkenburg <​sfalken@apple.com>

Reviewed by hyatt.


Removed unused code.

12:15 AM Changeset in webkit [14708] by sfalken
  • 5 edits in trunk/WebKitTools

2006-06-03 Steve Falkenburg <​sfalken@apple.com>

Reviewed by hyatt.


Switch Spinneret to new hosting mechanism

  • Spinneret/Spinneret.sln:
  • Spinneret/Spinneret/Spinneret.cpp: (SpinneretWebHost::updateAddressBar): (SpinneretWebHost::QueryInterface): (SpinneretWebHost::AddRef): (SpinneretWebHost::Release): (resizeSubViews): (_tWinMain): (WndProc): (MyEditProc): (About): (loadURL):
  • Spinneret/Spinneret/Spinneret.h: (SpinneretWebHost::didStartProvisionalLoadForFrame): (SpinneretWebHost::didReceiveServerRedirectForProvisionalLoadForFrame): (SpinneretWebHost::didFailProvisionalLoadWithError): (SpinneretWebHost::didCommitLoadForFrame): (SpinneretWebHost::didReceiveTitle): (SpinneretWebHost::didReceiveIcon): (SpinneretWebHost::didFinishLoadForFrame): (SpinneretWebHost::didFailLoadWithError): (SpinneretWebHost::didChangeLocationWithinPageForFrame): (SpinneretWebHost::willPerformClientRedirectToURL): (SpinneretWebHost::didCancelClientRedirectForFrame): (SpinneretWebHost::willCloseFrame): (SpinneretWebHost::windowScriptObjectAvailable):
  • Spinneret/Spinneret/Spinneret.vcproj:
12:13 AM Changeset in webkit [14707] by sfalken
  • 2 edits in trunk/WebKit

2006-06-03 Steve Falkenburg <​sfalken@apple.com>

Reviewed by hyatt.


Add implementation of loadHTMLString for Spinneret

  • COM/WebFrame.cpp: (WebFrame::loadHTMLString):
12:10 AM Changeset in webkit [14706] by sfalken
  • 2 edits in trunk/WebCore

2006-06-03 Steve Falkenburg <​sfalken@apple.com>

Reviewed by hyatt.

Don't send empty referrers. Fixes image load fail on Spinneret default content.

  • platform/win/TransferJobWin.cpp: (WebCore::TransferJob::start):

Jun 2, 2006:

9:56 PM Changeset in webkit [14705] by ddkilzer
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by ggaren.

Test: fast/js/string-replace-3.html

  • kjs/string_object.cpp: (substituteBackreferences): Added support for $& (matched substring), $` (everything preceding matched substring), $' (everything following matched substring) and 2-digit back references, and cleaned up a little.

LayoutTests:

Reviewed by ggaren.

  • fast/js/resources/string-replace-3.js: Added.
  • fast/js/string-replace-3-expected.txt: Added.
  • fast/js/string-replace-3.html: Added.
6:41 PM Changeset in webkit [14704] by adele
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Windows theme for textareas. Also made some formatting changes.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::supportsFocus): (WebCore::RenderThemeWin::getThemeData): (WebCore::RenderThemeWin::adjustButtonStyle): (WebCore::RenderThemeWin::adjustTextFieldStyle): (WebCore::RenderThemeWin::adjustTextAreaStyle): (WebCore::RenderThemeWin::paintTextArea):
  • rendering/RenderThemeWin.h: (WebCore::RenderThemeWin::supportsHover):
6:28 PM Changeset in webkit [14703] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Hyatt, checked in by Tim H.

Explicitly run perl on *.pl files instead of relying
on Windows shell figuring out which program to run for
this extention.

  • DerivedSources.make:
6:16 PM Changeset in webkit [14702] by adele
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Set incremental linking to no. This seems to fix a build problem I was seeing
where dftables couldn't find a dll.

6:15 PM Changeset in webkit [14701] by thatcher
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by Hyatt, checked in by Tim H.

For: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9115
Added test case to test opacity layers, in particular, opacities
with a value of zero.

  • fast/css/ZeroOpacityLayers.html: Added.
  • fast/css/ZeroOpacityLayers-expected.txt: Added.
  • fast/css/ZeroOpacityLayers-expected.png: Added.
  • fast/css/ZeroOpacityLayers-expected.checksum: Added.
  • fast/css/ZeroOpacityLayers2.html: Added.
  • fast/css/ZeroOpacityLayers2-expected.txt: Added.
  • fast/css/ZeroOpacityLayers2-expected.png: Added.
  • fast/css/ZeroOpacityLayers2-expected.checksum: Added.

WebCore:

Reviewed by Hyatt, checked in by Tim H.

fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9115
Changed RenderLayer to only render layers that are not
totally transparent.

  • rendering/RenderLayer.cpp (RenderLayer::paintLayer): Changed function to also check if the layer is totally transparent and if it is, don't bother painting it.
5:52 PM Changeset in webkit [14700] by thatcher
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt, checked in by Tim H.

Adding testcase for bug 8223.

  • fast/dom/css-inline-style-important-expected.checksum: Added.
  • fast/dom/css-inline-style-important-expected.png: Added.
  • fast/dom/css-inline-style-important-expected.txt: Added.
  • fast/dom/css-inline-style-important.html: Added.

WebCore:

Reviewed by Hyatt, checked in by Tim H.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8223
WebKit fails to update style on element via DOM

Handle !important by detecting it and using a different code
path from normal priority.

  • bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put):
  • css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::setProperty):
  • css/CSSStyleDeclaration.h:
5:19 PM Changeset in webkit [14699] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Geoff, checked in by Maciej.



  • dom/Element.cpp: (WebCore::Element::focus): Do the updateLayout call before calling isFocusable, since isFocusable looks at the size of the renderer.
3:35 PM Changeset in webkit [14698] by brmorris
  • 3 edits in S60/trunk

2006-06-02 Shyam <​Shyam.Sareen@nokia.com>

Reviewed by Zalan/Bradley


  • S60WebUi\HomePage\src\BookmarkPageGen.cpp
  • S60WebUi\HomePage\src\SettingsPageGen.cpp


  • Bookmarks & Setting Menu Options not working on hardware due to overzealous WINS flags.


Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9256

2:57 PM Changeset in webkit [14697] by brmorris
  • 13 edits
    9 deletes in S60/trunk

2006-06-02 Bradley <​bradley.morrison@nokia.com>

Reviewed by Sachin


  • Webkit/BrowserControl
  • Webkit/BrowserView
  • S60Internals


  • This is a port of ccm task 11164 (WML interface changes)
2:49 PM Changeset in webkit [14696] by thatcher
  • 1 copy in tags/WebCore-418.12/WebCore

Tag for WebCore 418.12 (part 2 of 2.)

2:49 PM Changeset in webkit [14695] by thatcher
  • 1 add in tags/WebCore-418.12

Tag for WebCore 418.12 (part 1 of 2.)

2:49 PM Changeset in webkit [14694] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

2:47 PM Changeset in webkit [14693] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Darin and Eric.

<rdar://problem/4523402> SUTiLondon: XSL file containing <xsl:include href="../Styles/EscapeString.xsl" /> fails to load file

The decoder was returning a null string for the EscapeString stylesheet because it didn't specify an encoding.
If we do not find an encoding we need to assume it is UTF-8.

We also need to load DTD files in xml documents for this test to fully work like Win IE.
Wrapping XMLTokenizer's xmlReadMemory with setLoaderForLibXMLCallbacks to load any files XML needs through the docLoader.

However, this further exposes <rdar://problem/4292995> (libxml2 looks for file in /etc/xml/catalog, but the file is not installed)
This causes Safari to show an error in the activity window about ​file:///etc/xml/catalog. To prevent this we can set
the XML_CATALOG_FILES environment variable to an empty string. We will only set this env var if it hasn't been set already.
This allows someone to launch Safari with a custom catalog if that was ever needed.

  • khtml/misc/decoder.cpp: (Decoder::decode):
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::setTransformSource):
1:50 PM Changeset in webkit [14692] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Maciej.



For a synchronous XMLHttpRequest, the JavaScript interpreter initiating
the request would deadlock with the JavaScript interpreter spawned by
the request to execute the PAC file.


The solution here is to temporarily drop the initiating interpreter's locks
before making the request, and re-acquire the locks afterwards. Because
the initiating interpreter waits for the request to complete before
continuing execution, it is free to drop its locks while the request
is in progress.

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send):
12:35 PM Changeset in webkit [14691] by sfalken
  • 2 edits in trunk/WebKitTools

2006-06-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by darin.


Updated build script

  • Scripts/build-webkit:
12:35 PM Changeset in webkit [14690] by sfalken
  • 3 edits in trunk/WebKitWin

2006-06-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by darin.


Updated to latest hosting interface

  • WebFramePrivate.cpp: (WebKit::WebFramePrivate::openURL): (WebKit::WebFramePrivate::setTitle): (WebKit::WebFramePrivate::setStatusText):
  • WebFramePrivate.h:
12:34 PM Changeset in webkit [14689] by sfalken
  • 5 edits in trunk/WebCore

2006-06-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by darin.

Platform hookup fixes

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::setTitle): (WebCore::FrameWin::setStatusBarText):
  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::overrideMediaType):
  • platform/win/TransferJobWin.cpp: (WebCore::TransferJobWndProc): (WebCore::TransferJob::start): (WebCore::TransferJob::fileLoadTimer): (WebCore::TransferJob::cancel):
12:32 PM Changeset in webkit [14688] by sfalken
  • 1 edit
    61 adds in trunk/WebKit

2006-06-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by darin.

New hosting for Spinneret to avoid static linking

  • COM: Added.
  • COM/Interfaces: Added.
  • COM/Interfaces/DOMCSS.idl: Added.
  • COM/Interfaces/DOMCore.idl: Added.
  • COM/Interfaces/DOMHTML.idl: Added.
  • COM/Interfaces/DOMRange.idl: Added.
  • COM/Interfaces/IWebArchive.idl: Added.
  • COM/Interfaces/IWebAttributedString.idl: Added.
  • COM/Interfaces/IWebBackForwardList.idl: Added.
  • COM/Interfaces/IWebDataSource.idl: Added.
  • COM/Interfaces/IWebDocument.idl: Added.
  • COM/Interfaces/IWebDownload.idl: Added.
  • COM/Interfaces/IWebEditingDelegate.idl: Added.
  • COM/Interfaces/IWebError.idl: Added.
  • COM/Interfaces/IWebFrame.idl: Added.
  • COM/Interfaces/IWebFrameLoadDelegate.idl: Added.
  • COM/Interfaces/IWebFrameView.idl: Added.
  • COM/Interfaces/IWebHistoryItem.idl: Added.
  • COM/Interfaces/IWebIconDatabase.idl: Added.
  • COM/Interfaces/IWebImage.idl: Added.
  • COM/Interfaces/IWebMutableURLRequest.idl: Added.
  • COM/Interfaces/IWebNotification.idl: Added.
  • COM/Interfaces/IWebPolicyDelegate.idl: Added.
  • COM/Interfaces/IWebPreferences.idl: Added.
  • COM/Interfaces/IWebResource.idl: Added.
  • COM/Interfaces/IWebResourceLoadDelegate.idl: Added.
  • COM/Interfaces/IWebScriptObject.idl: Added.
  • COM/Interfaces/IWebUIDelegate.idl: Added.
  • COM/Interfaces/IWebURLAuthenticationChallenge.idl: Added.
  • COM/Interfaces/IWebURLRequest.idl: Added.
  • COM/Interfaces/IWebURLResponse.idl: Added.
  • COM/Interfaces/IWebUndoManager.idl: Added.
  • COM/Interfaces/IWebView.idl: Added.
  • COM/Interfaces/WebKit.idl: Added.
  • COM/WebBackForwardList.cpp: Added. (WebBackForwardList::WebBackForwardList): (WebBackForwardList::~WebBackForwardList): (WebBackForwardList::createInstance): (WebBackForwardList::QueryInterface): (WebBackForwardList::AddRef): (WebBackForwardList::Release): (WebBackForwardList::addItem): (WebBackForwardList::goBack): (WebBackForwardList::goForward): (WebBackForwardList::goToItem): (WebBackForwardList::backItem): (WebBackForwardList::currentItem): (WebBackForwardList::forwardItem): (WebBackForwardList::backListWithLimit): (WebBackForwardList::forwardListWithLimit): (WebBackForwardList::capacity): (WebBackForwardList::setCapacity): (WebBackForwardList::backListCount): (WebBackForwardList::forwardListCount): (WebBackForwardList::containsItem): (WebBackForwardList::itemAtIndex): (WebBackForwardList::setPageCacheSize): (WebBackForwardList::pageCacheSize):
  • COM/WebBackForwardList.h: Added.
  • COM/WebDataSource.cpp: Added. (WebDataSource::WebDataSource): (WebDataSource::~WebDataSource): (WebDataSource::createInstance): (WebDataSource::QueryInterface): (WebDataSource::AddRef): (WebDataSource::Release): (WebDataSource::initWithRequest): (WebDataSource::data): (WebDataSource::representation): (WebDataSource::webFrame): (WebDataSource::initialRequest): (WebDataSource::request): (WebDataSource::response): (WebDataSource::textEncodingName): (WebDataSource::isLoading): (WebDataSource::pageTitle): (WebDataSource::unreachableURL): (WebDataSource::webArchive): (WebDataSource::mainResource): (WebDataSource::subresources): (WebDataSource::subresourceForURL): (WebDataSource::addSubresource):
  • COM/WebDataSource.h: Added.
  • COM/WebFrame.cpp: Added. (WebFrame::WebFramePrivate::WebFramePrivate): (WebFrame::WebFramePrivate::~WebFramePrivate): (WebFrame::WebFrame): (WebFrame::~WebFrame): (WebFrame::createInstance): (WebFrame::QueryInterface): (WebFrame::AddRef): (WebFrame::Release): (WebFrame::initWithName): (WebFrame::name): (WebFrame::webView): (WebFrame::frameView): (WebFrame::DOMDocument): (WebFrame::frameElement): (WebFrame::loadRequest): (WebFrame::loadData): (WebFrame::loadHTMLString): (WebFrame::loadAlternateHTMLString): (WebFrame::loadArchive): (WebFrame::dataSource): (WebFrame::provisionalDataSource): (WebFrame::stopLoading): (WebFrame::reload): (WebFrame::findFrameNamed): (WebFrame::parentFrame): (WebFrame::childFrames): (WebFrame::paint): (WebFrame::impl): (WebFrame::loadDataSource): (WebFrame::loading): (WebFrame::goToItem): (WebFrame::loadItem): (WebSystemMainMemory): (WebFrame::getObjectCacheSize): (WebFrame::receivedRedirect): (WebFrame::receivedResponse): (WebFrame::receivedData): (WebFrame::receivedAllData): (WebFrame::openURL): (WebFrame::submitForm): (WebFrame::setTitle): (WebFrame::setStatusText):
  • COM/WebFrame.h: Added.
  • COM/WebHistoryItem.cpp: Added. (WebHistoryItem::WebHistoryItem): (WebHistoryItem::~WebHistoryItem): (WebHistoryItem::createInstance): (WebHistoryItem::QueryInterface): (WebHistoryItem::AddRef): (WebHistoryItem::Release): (WebHistoryItem::initWithURLString): (WebHistoryItem::originalURLString): (WebHistoryItem::URLString): (WebHistoryItem::title): (WebHistoryItem::lastVisitedTimeInterval): (WebHistoryItem::setAlternateTitle): (WebHistoryItem::alternateTitle): (WebHistoryItem::icon):
  • COM/WebHistoryItem.h: Added.
  • COM/WebIconDatabase.cpp: Added. (WebIconDatabase::WebIconDatabase): (WebIconDatabase::~WebIconDatabase): (WebIconDatabase::createInstance): (WebIconDatabase::QueryInterface): (WebIconDatabase::AddRef): (WebIconDatabase::Release): (WebIconDatabase::sharedIconDatabase): (WebIconDatabase::iconForURL): (WebIconDatabase::defaultIconWithSize): (WebIconDatabase::retainIconForURL): (WebIconDatabase::releaseIconForURL): (WebIconDatabase::delayDatabaseCleanup): (WebIconDatabase::allowDatabaseCleanup):
  • COM/WebIconDatabase.h: Added.
  • COM/WebKitClassFactory.cpp: Added. (WebKitClassFactory::WebKitClassFactory): (WebKitClassFactory::~WebKitClassFactory): (WebKitClassFactory::QueryInterface): (WebKitClassFactory::AddRef): (WebKitClassFactory::Release): (WebKitClassFactory::CreateInstance): (WebKitClassFactory::LockServer):
  • COM/WebKitClassFactory.h: Added.
  • COM/WebKitDLL.cpp: Added. (DllMain): (DllGetClassObject): (DllCanUnloadNow): (DllUnregisterServer): (DllRegisterServer):
  • COM/WebKitDLL.h: Added.
  • COM/WebMutableURLRequest.cpp: Added. (WebMutableURLRequest::WebMutableURLRequest): (WebMutableURLRequest::~WebMutableURLRequest): (WebMutableURLRequest::createInstance): (WebMutableURLRequest::QueryInterface): (WebMutableURLRequest::AddRef): (WebMutableURLRequest::Release): (WebMutableURLRequest::requestWithURL): (WebMutableURLRequest::allHTTPHeaderFields): (WebMutableURLRequest::cachePolicy): (WebMutableURLRequest::HTTPBody): (WebMutableURLRequest::HTTPBodyStream): (WebMutableURLRequest::HTTPMethod): (WebMutableURLRequest::HTTPShouldHandleCookies): (WebMutableURLRequest::initWithURL): (WebMutableURLRequest::mainDocumentURL): (WebMutableURLRequest::timeoutInterval): (WebMutableURLRequest::URL): (WebMutableURLRequest::valueForHTTPHeaderField): (WebMutableURLRequest::addValue): (WebMutableURLRequest::setAllHTTPHeaderFields): (WebMutableURLRequest::setCachePolicy): (WebMutableURLRequest::setHTTPBody): (WebMutableURLRequest::setHTTPBodyStream): (WebMutableURLRequest::setHTTPMethod): (WebMutableURLRequest::setHTTPShouldHandleCookies): (WebMutableURLRequest::setMainDocumentURL): (WebMutableURLRequest::setTimeoutInterval): (WebMutableURLRequest::setURL): (WebMutableURLRequest::setValue): (WebMutableURLRequest::setFormData): (WebMutableURLRequest::formData):
  • COM/WebMutableURLRequest.h: Added.
  • COM/WebView.cpp: Added. (WebView::WebView): (WebView::~WebView): (WebView::createInstance): (WebView::mouseMoved): (WebView::mouseDown): (WebView::mouseUp): (WebView::mouseDoubleClick): (WebView::keyPress): (registerWebView): (WebViewWndProc): (calculateScrollDelta): (scrollMessageForKey): (WebView::goToItem): (WebView::QueryInterface): (WebView::AddRef): (WebView::Release): (WebView::canShowMIMEType): (WebView::canShowMIMETypeAsHTML): (WebView::MIMETypesShownAsHTML): (WebView::setMIMETypesShownAsHTML): (WebView::URLFromPasteboard): (WebView::URLTitleFromPasteboard): (WebView::initWithFrame): (WebView::setUIDelegate): (WebView::uiDelegate): (WebView::setResourceLoadDelegate): (WebView::resourceLoadDelegate): (WebView::setDownloadDelegate): (WebView::downloadDelegate): (WebView::setFrameLoadDelegate): (WebView::frameLoadDelegate): (WebView::setPolicyDelegate): (WebView::policyDelegate): (WebView::mainFrame): (WebView::backForwardList): (WebView::setMaintainsBackForwardList): (WebView::goBack): (WebView::goForward): (WebView::goToBackForwardItem): (WebView::setTextSizeMultiplier): (WebView::textSizeMultiplier): (WebView::setApplicationNameForUserAgent): (WebView::applicationNameForUserAgent): (WebView::setCustomUserAgent): (WebView::customUserAgent): (WebView::userAgentForURL): (WebView::supportsTextEncoding): (WebView::setCustomTextEncodingName): (WebView::customTextEncodingName): (WebView::setMediaStyle): (WebView::mediaStyle): (WebView::stringByEvaluatingJavaScriptFromString): (WebView::windowScriptObject): (WebView::setPreferences): (WebView::preferences): (WebView::setPreferencesIdentifier): (WebView::preferencesIdentifier): (WebView::setHostWindow): (WebView::hostWindow): (WebView::searchFor): (WebView::registerViewClass): (WebView::takeStringURLFrom): (WebView::stopLoading): (WebView::reload): (WebView::canGoBack): (WebView::canGoForward): (WebView::canMakeTextLarger): (WebView::makeTextLarger): (WebView::canMakeTextSmaller): (WebView::makeTextSmaller): (WebView::computedStyleForElement): (WebView::editableDOMRangeForPoint): (WebView::setSelectedDOMRange): (WebView::selectedDOMRange): (WebView::selectionAffinity): (WebView::setEditable): (WebView::isEditable): (WebView::setTypingStyle): (WebView::typingStyle): (WebView::setSmartInsertDeleteEnabled): (WebView::smartInsertDeleteEnabled): (WebView::setContinuousSpellCheckingEnabled): (WebView::isContinuousSpellCheckingEnabled): (WebView::spellCheckerDocumentTag): (WebView::undoManager): (WebView::setEditingDelegate): (WebView::editingDelegate): (WebView::styleDeclarationWithText): (WebView::replaceSelectionWithNode): (WebView::replaceSelectionWithText): (WebView::replaceSelectionWithMarkupString): (WebView::replaceSelectionWithArchive): (WebView::deleteSelection): (WebView::applyStyle): (WebView::copy): (WebView::cut): (WebView::paste): (WebView::copyFont): (WebView::pasteFont): (WebView::delete_): (WebView::pasteAsPlainText): (WebView::pasteAsRichText): (WebView::changeFont): (WebView::changeAttributes): (WebView::changeDocumentBackgroundColor): (WebView::changeColor): (WebView::alignCenter): (WebView::alignJustified): (WebView::alignLeft): (WebView::alignRight): (WebView::checkSpelling): (WebView::showGuessPanel): (WebView::performFindPanelAction): (WebView::startSpeaking): (WebView::stopSpeaking): (WebView::viewWindow):
  • COM/WebView.h: Added.
  • WebKit.vcproj: Added.
  • WebKit.vcproj/Interfaces.vcproj: Added.
  • WebKit.vcproj/WebKit.def: Added.
  • WebKit.vcproj/WebKit.rc: Added.
  • WebKit.vcproj/WebKit.sln: Added.
  • WebKit.vcproj/WebKit.vcproj: Added.
  • WebKit.vcproj/WebKitGUID.vcproj: Added.
  • WebKit.vcproj/autoversion.h: Added.
  • WebKit.vcproj/resource.h: Added.
10:24 AM Changeset in webkit [14687] by darin
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/css-generated-content/016-expected.checksum: Added.
  • fast/css-generated-content/016-expected.png: Added.
  • fast/css-generated-content/016-expected.txt: Added.
  • fast/css-generated-content/016.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/css-generated-content/016.html

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): Don't share style if the unique bit is set. (WebCore::CSSStyleSelector::applyProperty): When applying the "attr" property, set the unique bit and add to m_selectorAttrs.
  • rendering/render_style.cpp: Did a lot of reformatting, and this one real change. (WebCore::RenderStyle::RenderStyle): Initialize m_unique to false.
  • rendering/render_style.h: (WebCore::RenderStyle::unique): Added. Returns value of m_unique. (WebCore::RenderStyle::setUnique): Added. Sets m_unique.
10:04 AM Changeset in webkit [14686] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Maciej.


The fix is to mark all DOM Nodes when collecting on an alternate thread --
not just the nodes that are still in a document.


Previously, the DOMObjectsMarker didn't mark DOM nodes that were not in
a document, since we assumed such nodes would either be (a) unreachable
or (b) reachable, and therefore marked elsewhere. However, it seems that
heap/stack entropy allows for (c) non-deterministically reachable by the
conservative garbage collector. So, ironically, we need to mark
DOM nodes that are not in a document to avoid crashing when trying to
mark them later.

  • khtml/ecma/kjs_binding.cpp: (KJS::DOMObjectsMarker::mark): (KJS::DOMObjectsMarker::markOnMainThread): (KJS::DOMObjectsMarker::markOnAlternateThread):
9:39 AM Changeset in webkit [14685] by darin
  • 3 edits in trunk/LayoutTests

Reviewed by Anders.

Updated test so that is will once again exercise the fix for
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9009

  • fast/table/empty-section-crash-expected.txt:
  • fast/table/empty-section-crash.html:
2:50 AM Changeset in webkit [14684] by ddkilzer
  • 3034 edits in trunk

LayoutTests:

Reviewed by mjs.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9183
Finish renaming of RenderCanvas to RenderView

  • editing/selection/7152-1-expected.checksum: Layout changed due to text change in HTML file.
  • editing/selection/7152-1-expected.png: Ditto.
  • editing/selection/7152-1-expected.txt: Ditto.
  • editing/selection/7152-1.html: Changed text in HTML content.
  • editing/selection/7152-2-expected.checksum: Layout changed due to text change in HTML file.
  • editing/selection/7152-2-expected.png: Ditto.
  • editing/selection/7152-2-expected.txt: Ditto.
  • editing/selection/7152-2.html: Changed text in HTML content.
  • *-expected.txt: Replaced "RenderCanvas" with "RenderView" in 3023 more files.

WebCore:

Reviewed by mjs.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9183
Finish renaming of RenderCanvas to RenderView

  • rendering/RenderView.h: Changed renderName from "RenderCanvas" to "RenderView".
12:29 AM Changeset in webkit [14683] by darin
  • 2 edits in trunk/WebKit
  • WebCoreSupport/WebImageRendererFactory.m: Fix crash on Safari startup by include NSObject as a superclass (oops!).

Jun 1, 2006:

11:59 PM Changeset in webkit [14682] by darin
  • 2 edits in trunk/WebCore
  • try to fix Windows build
  • bridge/win/FrameWin.cpp: Added include of Decoder.h.
11:56 PM Changeset in webkit [14681] by darin
  • 9 edits
    4 deletes in trunk

WebCore:

Reviewed by Maciej.

  • WebCore doesn't need to load WebKit images any more; removed code for that
  • WebCore.exp: Removed WebCoreImageRendererFactory.
  • WebCore.xcodeproj/project.pbxproj: Removed WebCoreImageRendererFactory.h/mm.
  • bridge/mac/WebCoreFrameBridge.mm: Removed include of WebCoreImageRendererFactory.h.
  • platform/mac/ImageMac.mm: Removed include of WebCoreImageRendererFactory.h.
  • platform/mac/WebCoreImageRendererFactory.h: Removed.
  • platform/mac/WebCoreImageRendererFactory.m: Removed.

WebKit:

Reviewed by Maciej.

  • WebCore doesn't need to load WebKit images any more; removed code for that
  • Resources/missing_image.tiff: Removed.
  • WebCoreSupport/WebImageRendererFactory.h: Removed.
  • WebCoreSupport/WebImageRendererFactory.m: Moved @interface in here. Removed all but the "threaded decoding" calls that older Safari calls. This file can go altogether when compatibility with that older Safari is no longer needed.
  • WebKit.xcodeproj/project.pbxproj: Removed WebImageRendererFactory.h and missing_image.tiff.
  • WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]): Removed call to [WebImageRendererFactory createSharedFactory].
11:30 PM Changeset in webkit [14680] by darin
  • 20 edits
    8 copies
    2 moves in trunk/WebCore

Reviewed by Geoff, tweaked a bit by Darin.

  • WebCore.xcodeproj/project.pbxproj: Updated for new files.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • bindings/js/kjs_traversal.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/objc/DOM.mm:
  • dom/Document.cpp:
  • dom/Document.h: Updated includes.
  • dom/NodeFilter.cpp: Added.
  • dom/NodeFilter.h: Added.
  • dom/NodeFilterCondition.cpp: Added.
  • dom/NodeFilterCondition.h: Added.
  • dom/NodeIterator.cpp: Added.
  • dom/NodeIterator.h: Added.
  • dom/Traversal.cpp: Added.
  • dom/Traversal.h: Added.
  • dom/TreeWalker.cpp: Added.
  • dom/TreeWalker.h: Added.
  • dom/dom2_traversalimpl.cpp: Removed.
  • dom/dom2_traversalimpl.h: Removed.
10:55 PM Changeset in webkit [14679] by darin
  • 23 edits
    8 adds in trunk

LayoutTests:

Reviewed by Maciej and Adele


Tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8398
Updated and extended select/option form tests


  • fast/forms/HTMLOptionElement_label01.html:
  • fast/forms/HTMLOptionElement_label01-expected.txt:
  • fast/forms/HTMLOptionElement_label01-expected.png:
  • fast/forms/HTMLOptionElement_label02.html:
  • fast/forms/HTMLOptionElement_label02-expected.txt:
  • fast/forms/HTMLOptionElement_label02-expected.png:
  • fast/forms/HTMLOptionElement_label03.html:
  • fast/forms/HTMLOptionElement_label03-expected.txt:
  • fast/forms/HTMLOptionElement_label03-expected.png
  • fast/forms/HTMLOptionElement_label04.html:
  • fast/forms/HTMLOptionElement_label04-expected.txt:
  • fast/forms/HTMLOptionElement_label04-expected.png
  • fast/forms/HTMLOptionElement_label05.html:
  • fast/forms/HTMLOptionElement_label05-expected.txt:
  • fast/forms/HTMLOptionElement_label05-expected.png: Updated to reflect success and added some description


  • fast/forms/HTMLOptionElement_label06.html:
  • fast/forms/HTMLOptionElement_label06-expected.txt:
  • fast/forms/HTMLOptionElement_label05-expected.png:
  • fast/forms/HTMLOptionElement_label07.html:
  • fast/forms/HTMLOptionElement_label07-expected.txt:
  • fast/forms/HTMLOptionElement_label07-expected.png: Added.

WebCore:

Reviewed by Maciej and Adele

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8398
REGRESSION: LABEL in OPTION element is clobbering display #TEXT
Patch provided by Darin.


  • rendering/RenderSelect.cpp (RenderSelect::updateFromElement): Changed to use the containing text by default, and not the label text
10:46 PM Changeset in webkit [14678] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt


Tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8646
Test the window.screen.pixelDepth and window.screen.colorDepth


  • fast/dom/window/window-screen-properties.html: Added
  • fast/dom/window/window-screen-properties-expected.txt: Added.

WebCore:

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8646
Correcting the value returned for window.screen.pixelDepth and
window.screen.colorDepth


  • platform/mac/ScreenMac.mm (screenDepth): Changed to return the BitsPerPixelFromDepth rather than the WindowDepth
8:15 PM Changeset in webkit [14677] by hyatt
  • 4 edits in trunk/WebCore

Fix win32 build bustage.

7:18 PM Changeset in webkit [14676] by adele
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Missed an initialization in my last checkin which caused too many
resizers to be drawn.

  • rendering/render_style.cpp: (WebCore::resize): Initialize resize to RESIZE_NONE.
6:13 PM Changeset in webkit [14675] by hyatt
  • 4 edits in trunk/WebCore

Implement form posting via WinINet. This code is crazy... CRAZY

5:05 PM Changeset in webkit [14674] by adele
  • 19 edits
    1 copy in trunk/WebCore

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9216
Implement CSS3 resize property

  • css/html4.css: Sets resize:both for textareas. This won't affect old-style textareas.
  • css/CSSPropertyNames.in: Added resize property.
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): Added case for CSS_PROP_RESIZE.
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): ditto.
  • rendering/render_style.cpp: (WebCore::StyleCSS3InheritedData): Initialize resize.
  • rendering/render_style.h: (WebCore::): Added EResize enum. (WebCore::RenderStyle::resize): (WebCore::RenderStyle::setResize): (WebCore::RenderStyle::initialResize):
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Added m_resizeLayer to keep track of a layer that has begun resizing. (WebCore::FrameViewPrivate::reset): Reset m_resizeLayer. (WebCore::FrameView::handleMousePressEvent): If the mouse was pressed in a layer's resize control, then put the layer into resize mode. (WebCore::selectCursor): Updated so we get a pointer cursor for the resize control. (WebCore::FrameView::handleMouseMoveEvent): If there's a layer currently resizing, then tell the layer to continue resizing. (WebCore::FrameView::handleMouseReleaseEvent): If there's a layer currently resizing, then pull it out of resize mode.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar): Updated so the resize control isn't considered part of the scrollbar.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): Initialize m_inResizeMode (WebCore::RenderLayer::updateLayerPositions): Calls positionResizeControl. (WebCore::RenderLayer::resize): Added. Sets a new width and height based on the current mouse point. (WebCore::RenderLayer::isPointInResizeControl): Added. (WebCore::RenderLayer::positionResizeControl): Added. (WebCore::RenderLayer::positionScrollbars): Calls positionResizeControl. (WebCore::RenderLayer::paintScrollbars): Calls positionResizeControl. (WebCore::RenderLayer::paintResizeControl): Added. (WebCore::RenderLayer::paintLayer): Calls paintResizeControl.
  • rendering/RenderLayer.h: Added m_inResizeMode. (WebCore::RenderLayer::resizeControlRect): (WebCore::RenderLayer::setResizeControlRect): (WebCore::RenderLayer::inResizeMode): Added. (WebCore::RenderLayer::setInResizeMode): Added.
  • platform/mac/ImageMac.mm: (WebCore::Image::loadResource): Moved code from WebImageRendererFactory. Now loads images from WebCore's resources. WebImageRendererFactory is no longer used and should be removed.
  • Resources/missingImage.tiff: Added. Copied from WebKit.
  • WebCore.xcodeproj/project.pbxproj: Added missingImage.tiff
  • loader/Cache.cpp: (WebCore::Cache::init): Updated name from missing_image to missingImage.
  • rendering/RenderTheme.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paintResizeControl): Added.
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::RenderThemeMac): Initialize resizeCornerImage. (WebCore::RenderThemeMac::paintResizeControl): Paints resizeCornerImage.
4:02 PM Changeset in webkit [14673] by beidson
  • 13 edits
    5 adds in trunk

WebKit:
Simple changes to hook up the new WebCore based Icon Database
for testing.
WebCore:
Added the beginnings of sqlite-based code in a WebCore
based version of the Icon Database. Right now the code
is very loosely hooked up through a Bridge and only
creates an sqlite3 database.
There are also changes to our String classes to allow appending
a single character to a String without creating a temporary object.

3:23 PM Changeset in webkit [14672] by andersca
  • 4 edits in trunk/WebCore

2006-06-01 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed and landed by Anders.

  • fixed all places in the Canvas to RenderView rename patch where view() should have been changed to frameView().
  • kwq/WebCoreAXObject.mm: (-[WebCoreAXObject position]): (-[WebCoreAXObject accessibilityAttributeValue:]):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/RenderTreeAsText.cpp: (externalRepresentation):
2:52 PM Changeset in webkit [14671] by ggaren
  • 3 edits
    2 adds in trunk

LayoutTests:

  • http/tests/xmlhttprequest/event-listener-gc.html: Added.
  • http/tests/xmlhttprequest/event-listener-gc-expected.txt: Added.

WebCore:

Fix by Mitz. Reviewed, tweaked, tested, landed by me.


An XMLHttpRequest must be added to the DOMObject cache so that its
DOM implementation object can protect it, and by extension, its event
listeners.


This design seems slightly backwards to me -- the bindings should know
about the DOM, not the other way around -- but I'm restoring it for
now to fix the regression.


  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::JSXMLHttpRequest): (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
2:41 PM Changeset in webkit [14670] by andersca
  • 2 edits in trunk/WebCore

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

  • platform/KURL.cpp: (equalIgnoringRef): Whoops. Fix build.


2:29 PM Changeset in webkit [14669] by andersca
  • 19 edits
    2 adds in trunk

WebCore:

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working


  • bindings/js/kjs_window.cpp: (KJS::Location::put): Handle the case where the hash starts with a "#". Also, don't do anything if the previous and new hashes are equal.


  • bridge/BrowserExtension.h:
  • bridge/mac/BrowserExtensionMac.h:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::historyURL):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: New function historyURL which returns the complete URL for a given item in the history.


  • page/Frame.cpp: (WebCore::Frame::scheduleLocationChange): (WebCore::Frame::scheduleHistoryNavigation): If the URL of the new location only differs in the hash, don't schedule the load. Instead, load it directly.


  • platform/KURL.cpp:
  • platform/KURL.h: Add equalsIgnoringRef which returns whether two URLs are equal, ignoring the ref.

WebKit:

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working

  • Misc/WebNSURLExtras.m: (-[NSString _webkit_URLFragment]): Don't include the "#" character in the fragment.


  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge historyURL:]): New function, returns the history URL for a given position in the back/forward list


  • WebView/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): Always call scrollToAnchorWithURL, even if there is no fragment. This way we keep the WebCore frame's URL up-to-date.

WebKitTools:

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController clearBackForwardList]): Add clearBackForwardList function to layoutTestController


LayoutTests:

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working


  • fast/dom/location-hash-expected.txt: Added.
  • fast/dom/location-hash.html: Added. Added tests.


12:06 PM Changeset in webkit [14668] by andersca
  • 5 edits in trunk/WebCore

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9212
dispatchEvent13.html crashes under GuardMalloc

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::addEventListener): (WebCore::EventTargetNode::removeEventListener): (WebCore::EventTargetNode::handleLocalEvents):


(WebCore::EventTargetNode::removeHTMLEventListener):
(WebCore::EventTargetNode::getHTMLEventListener):

  • dom/EventTargetNode.h: Make the list of registered event listeners refcount the listeners by using a value list of RefPtr objects.


Set removed flag to true in removeEventListener
Only invoke event listeners if they don't have the removed flag.


  • dom/dom2_eventsimpl.cpp: (WebCore::RegisteredEventListener::RegisteredEventListener):
  • dom/dom2_eventsimpl.h: Make RegisteredEventListener refcounted.


(WebCore::RegisteredEventListener::removed):
(WebCore::RegisteredEventListener::setRemoved):
Add removed flag and getter and setter

12:01 PM Changeset in webkit [14667] by mjs
  • 5 edits
    3 adds in trunk

LayoutTests:

Reviewed by Anders.


  • http/tests/misc/redirect-expected.txt: Added.
  • http/tests/misc/redirect.php: Added.
  • http/tests/misc/resources/redirect-result.php: Added.

WebKit:

Reviewed by Anders.


  • WebView/WebDataSource.m: (-[WebDataSource _willSendRequest:forResource:redirectResponse:]): Set up the User-Agent header.
  • WebView/WebDataSourceInternal.h:
  • WebView/WebLoader.m: (-[NSURLProtocol willSendRequest:redirectResponse:]): Pass a mutable URL request so the above can work.
11:33 AM Changeset in webkit [14666] by justing
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/selection/focus-body-expected.checksum: Added.
  • editing/selection/focus-body-expected.png: Added.
  • editing/selection/focus-body-expected.txt: Added.
  • editing/selection/focus-body.html: Added.
  • editing/selection/focus_editable_html-expected.checksum:
  • editing/selection/focus_editable_html-expected.png:
  • editing/selection/focus_editable_html-expected.txt:

WebCore:

Reviewed by harrison


<rdar://problem/4567752> When forwarding a message, pressing TAB key to place caret in body actually selects the entire message instead

  • dom/Element.cpp: (WebCore::Element::focus):
10:35 AM Changeset in webkit [14665] by andersca
  • 6 edits in trunk

WebKit:

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

  • WebView/WebFrameView.m: (+[WebFrameView _canShowMIMETypeAsHTML:]): Use _webkit_objectForMIMEType here so we'll get an object back for "text/".

WebKitTools:

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8996
slow-utf8-text layout test case failing (no longer deterministic?)


  • DumpRenderTree/DumpRenderTree.m: (dump): Dump as text when the response MIME type is text/plain

LayoutTests:

2006-06-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8996
slow-utf8-text layout test case failing (no longer deterministic?)

  • http/tests/incremental/slow-utf8-text-expected.txt: Updated
4:00 AM Changeset in webkit [14664] by ddkilzer
  • 1 edit
    2 adds in trunk/WebCore

2006-06-01 David Kilzer <​ddkilzer@kilzer.net>

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9144
Test for Bug 8079 (REGRESSION: Redraw from page cache does not show visited links)

  • manual-tests/redraw-page-cache-visited-links.html: Added.
  • manual-tests/resources/redraw-page-cache-visited-links-2.html: Added.

May 31, 2006:

11:34 PM Changeset in webkit [14663] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/css/find-next-layer-expected.checksum: Added.
  • fast/css/find-next-layer-expected.png: Added.
  • fast/css/find-next-layer-expected.txt: Added.
  • fast/css/find-next-layer.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/css/find-next-layer.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::findNextLayer): Fixed a bug where this function could reach two levels down in the layer tree and return 0.
11:30 PM Changeset in webkit [14662] by adele
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

Changed the uninitialized value of m_tabWidth to -1 and removed the
assertion that it cannot be 0.

  • rendering/RenderBlock.cpp: (WebCore:::RenderBlock::RenderBlock): (WebCore::RenderBlock::setStyle):
  • rendering/bidi.cpp: (WebCore::RenderBlock::tabWidth):
11:24 PM Changeset in webkit [14661] by adele
  • 47 edits in trunk/LayoutTests

Updated test results for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8848
TFOOT borders are copied to THEAD and TBODY

  • tables/mozilla/marvin/backgr_layers-opacity-expected.checksum:
  • tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • tables/mozilla/marvin/backgr_position-table-expected.checksum:
  • tables/mozilla/marvin/backgr_position-table-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-cell-expected.checksum:
  • tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-column-expected.checksum:
  • tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum:
  • tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-expected.checksum:
  • tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-row-expected.checksum:
  • tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum:
  • tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
11:16 PM Changeset in webkit [14660] by adele
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/replaced/absolute-position-with-auto-height-and-top-and-bottom.html: Added.
  • fast/replaced/absolute-position-with-auto-width-and-left-and-right.html: Added.

WebCore:

Reviewed by Hyatt.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): Add support for case when all values are specified. (WebCore::RenderBox::calcAbsoluteVerticalReplaced): ditto
11:07 PM Changeset in webkit [14659] by adele
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/table/row-height-recalc-expected.checksum: Added.
  • fast/table/row-height-recalc-expected.png: Added.
  • fast/table/row-height-recalc-expected.txt: Added.
  • fast/table/row-height-recalc.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/table/row-height-recalc.html

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::setStyle): Mark the section as needing recalculation if the height property changed.
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::setStyle): Ditto.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::recalcCells): Initialize the grid row height to the height of the row element (like addChild() does).
10:56 PM Changeset in webkit [14658] by adele
  • 7 edits in trunk/WebCore

Reviewed by Hyatt.

No test possible (no functionality change)

  • dom/Document.cpp: (WebCore::Document::updateLayout): Changed to ensure that pending subtree layouts are performed too.
  • page/Frame.cpp: (WebCore::Frame::forceLayout): Force a full layout.
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::layout): Changed to relayout only the subtree rooted at d->layoutRoot if it's non-zero and allowSubtree is true. (WebCore::FrameView::scheduleRelayout): Change pending subtree relayout into normal relayout by clearing d->layoutRoot and propagating needsLayout to the root. (WebCore::FrameView::scheduleRelayoutOfSubtree): Added.
  • page/FrameView.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Added scheduleRelayout parameter. FrameView passes false to force marking all the way to the root when turning a pending subtree relayout into a full relayout. Otherwise, marking stops at the first textField (or at the root) and relayout of the last object reached is scheduled. (WebCore::RenderObject::scheduleRelayout):
  • rendering/RenderObject.h:
10:35 PM Changeset in webkit [14657] by adele
  • 3 edits in trunk/WebCore

Reviewed by Darin.

patch for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=8910>
Bug 8910: Various code cleanups in RenderBox


Clean up with some slight optimizations.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::contentWidth): (WebCore::RenderBox::contentHeight): (WebCore::RenderBox::setPos): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing):
  • rendering/RenderBox.h:
10:28 PM Changeset in webkit [14656] by adele
  • 4 edits in trunk/WebCore

Reviewed by Hyatt.

patch for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=8899>
Bug 8899: Removes some unneeded code from RenderBox


Removes the use of WidthType where not needed to simplify
the code a little.


  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::sizesToIntrinsicWidth): (WebCore::RenderBox::calcReplacedWidth): (WebCore::RenderBox::calcReplacedWidthUsing): (WebCore::RenderBox::calcReplacedHeight): (WebCore::RenderBox::calcReplacedHeightUsing):
  • rendering/RenderBox.h: (WebCore::): (WebCore::RenderBox::renderName):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight):
10:09 PM Changeset in webkit [14655] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

Testcase for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8455

  • fast/forms/select-reset.html: Added.

WebCore:

Reviewed by Geoff.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8455
selectedIndex for a select after a Form reset() has wrong value

Make sure the list items are reset properly by selecting
the first option in case no options have the selected attribute
set.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::reset):
10:02 PM Changeset in webkit [14654] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

Add a test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8024

  • fast/dom/document-all-input.html: Added.

WebCore:

Reviewed by Geoff.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8024
"Go" button (search) doesn't work at fifa.com (document.all.FormName)

Allow input elements with name attributes as possible named
items for document.all.

  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): (WebCore::HTMLCollection::updateNameCache):
6:06 PM Changeset in webkit [14653] by hyatt
  • 2 edits in trunk/WebCore/platform/win

Tweaks to remove fragments when loading urls via wininet or cookies.

3:19 PM Changeset in webkit [14652] by hyatt
  • 3 edits
    9 adds in trunk/WebCore

Add stubs for bmp/ico/xbm decoders on win32.

2:36 PM Changeset in webkit [14651] by hyatt
  • 14 edits in trunk

WebCore:

Fix for the gmail tab-focus-stealing bug.

Reviewed by darin

  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::focusWindow): (WebCore::FrameMac::unfocusWindow):
  • bridge/mac/WebCoreFrameBridge.h:
  • page/Frame.h:
  • platform/Widget.h:
  • platform/mac/WidgetMac.mm:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::focusWindow):
  • platform/win/WidgetWin.cpp:

WebKit:

Make programmatic focus/blur actually work on sub-frames. Make the
top-level UI delegate get called for deactivation of windows.

Reviewed by darin

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge activateWindow]): (-[WebFrameBridge deactivateWindow]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
  • WebKit.xcodeproj/project.pbxproj:
2:30 PM Changeset in webkit [14650] by bdakin
  • 7 edits
    73 adds in trunk

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6755 CSS3:
Borders rounded with border-radius don't draw the roundings

This patch does not draw all of the different border styles
perfectly, so I have filed a few followup bugs that I will
reference from this Bugzilla.

  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawArc): drawArc() has different parameters now, but mostly this needs to be implemented to match the Mac side later. (WebCore::GraphicsContext::addRoundedRectClip): Just a stub. Implement this later. (WebCore::GraphicsContext::addInnerRoundedRectClip): Just a stub. Implement this later.
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawArc): drawArc() now handles drawing elliptical arcs as well as circular arcs, it also takes a thickness parameter to draw an arc of a given thickness and draws with the appropriate pen style. (WebCore::GraphicsContext::addInnerRoundedRectClip): Adds a clip to the inside of an arc instead of to the outside which is already done by addRoundedClipRect()
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorderArc): Draws the border arcs in the appropriate styles. (WebCore::RenderObject::paintBorder): Calls drawBorderArc() when border arcs are needed.
  • rendering/RenderObject.h:
1:05 PM Changeset in webkit [14649] by hyatt
  • 2 edits in trunk/WebCore

Fix Win32 build bustage from Screen/Page FloatRect conversion

11:11 AM Changeset in webkit [14648] by brmorris
  • 8 edits in S60/trunk

S60WebKit:

2006-05-30 Pat <​vincent.bradley@nokia.com>

Reviewed by Bradley/Zalan


  • S60WebUi/WebUi/data/WebUi.rss
  • S60WebUi/WebUi/inc/WebUi.hrh
  • S60WebUi/WebUi/inc/WebUiAutomatedTests.h
  • S60WebUi/WebUi/src/WebUiAutomatedTests.cpp
  • S60WebUi/WebUi/src/WebUiLoadObserver.cpp
  • S60WebUi/WebUi/src/WebUiWindowContainer.cpp


11:04 AM Changeset in webkit [14647] by darin
  • 1 delete in trunk/WebCore/RenderView.cpp

Remove accidentally-checked-in file.

10:25 AM Changeset in webkit [14646] by eseidel
  • 121 edits
    1 copy
    12 moves
    10 adds
    6 deletes in trunk/WebCore

2006-05-30 Eric Seidel <​eric@eseidel.com>

Reviewed by andersca.

Add first-cut SVG JS bindings autogeneration.
SVGSVGElement and various other support classes are generated.
Various small style fixes.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4249

  • DerivedSources.make:
  • WebCore+SVG/RGBColor.cpp: Removed.
  • WebCore+SVG/RGBColor.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper): renamed from createJSWrapper
  • bindings/js/JSHTMLElementWrapperFactory.h:
  • bindings/js/kjs_dom.cpp: (KJS::DOMNode::DOMNode): (KJS::DOMNode::toBoolean): (KJS::DOMNode::getOwnPropertySlot): (KJS::DOMNode::getValueProperty): (KJS::DOMNode::put): (KJS::DOMNode::putValueProperty): (KJS::DOMNode::toPrimitive): (KJS::DOMNode::toString): (KJS::DOMNodeProtoFunc::callAsFunction): (KJS::toEventTargetNode): (KJS::DOMEventTargetNode::getOwnPropertySlot): (KJS::DOMEventTargetNode::getValueProperty): (KJS::DOMEventTargetNode::put): (KJS::DOMEventTargetNode::putValueProperty): (KJS::DOMEventTargetNode::setListener): (KJS::DOMEventTargetNode::getListener): (KJS::DOMEventTargetNode::pushEventHandlerScope): (KJS::DOMEventTargetNodeProtoFunc::callAsFunction): (KJS::DOMNodeList::toPrimitive): (KJS::DOMNodeList::getValueProperty): (KJS::DOMNodeList::indexGetter): (KJS::DOMNodeList::nameGetter): (KJS::DOMNodeList::getOwnPropertySlot): (KJS::DOMNodeList::callAsFunction): (KJS::DOMNodeListFunc::callAsFunction): (KJS::toElement): (KJS::toDocumentType): (KJS::DOMNamedNodeMap::DOMNamedNodeMap): (KJS::DOMNamedNodeMap::~DOMNamedNodeMap): (KJS::DOMNamedNodeMap::lengthGetter): (KJS::DOMNamedNodeMap::indexGetter): (KJS::DOMNamedNodeMap::nameGetter): (KJS::DOMNamedNodeMapProtoFunc::callAsFunction): (KJS::toJS): (KJS::checkNodeSecurity): (KJS::getRuntimeObject): (KJS::DOMExceptionConstructor::getOwnPropertySlot): (KJS::DOMExceptionConstructor::getValueProperty): (KJS::getDOMExceptionConstructor): (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection): (KJS::DOMNamedNodesCollection::lengthGetter): (KJS::DOMNamedNodesCollection::indexGetter): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Document.cpp: (WebCore::Document::implicitClose):
  • dom/Element.h:
  • dom/StyledElement.h:
  • ksvg2/bindings/idl/svg/SVGAngle.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGAnimatedLength.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGColor.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGDocument.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGElement.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGLength.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGMatrix.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGNumber.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPoint.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGRect.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGSVGElement.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGTransform.idl: Removed.
  • ksvg2/bindings/idl/svg/kdomdefs.idl: Removed.
  • ksvg2/bindings/js: Added.
  • ksvg2/bindings/js/JSSVGNumber.cpp: Added. (WebCore::): (WebCore::JSSVGNumber::~JSSVGNumber): (WebCore::JSSVGNumber::getOwnPropertySlot): (WebCore::JSSVGNumber::getValue): (WebCore::getJSSVGNumber):
  • ksvg2/bindings/js/JSSVGNumber.h: Added. (WebCore::JSSVGNumber::JSSVGNumber): (WebCore::JSSVGNumber::classInfo):
  • ksvg2/bindings/js/JSSVGPoint.cpp: Added. (WebCore::): (WebCore::JSSVGPoint::~JSSVGPoint): (WebCore::JSSVGPoint::getOwnPropertySlot): (WebCore::JSSVGPoint::getValueProperty): (WebCore::getJSSVGPoint): (WebCore::toFloatPoint):
  • ksvg2/bindings/js/JSSVGPoint.h: Added. (WebCore::JSSVGPoint::JSSVGPoint): (WebCore::JSSVGPoint::classInfo): (WebCore::JSSVGPoint::): (WebCore::JSSVGPoint::impl):
  • ksvg2/bindings/js/JSSVGRect.cpp: Added. (WebCore::): (WebCore::JSSVGRect::~JSSVGRect): (WebCore::JSSVGRect::getOwnPropertySlot): (WebCore::JSSVGRect::getValueProperty): (WebCore::getJSSVGRect): (WebCore::toFloatRect):
  • ksvg2/bindings/js/JSSVGRect.h: Added. (WebCore::JSSVGRect::JSSVGRect): (WebCore::JSSVGRect::classInfo): (WebCore::JSSVGRect::): (WebCore::JSSVGRect::impl):
  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • ksvg2/events/SVGZoomEvent.cpp: (SVGZoomEvent::SVGZoomEvent): (SVGZoomEvent::zoomRectScreen): (SVGZoomEvent::previousTranslate): (SVGZoomEvent::newTranslate):
  • ksvg2/events/SVGZoomEvent.h:
  • ksvg2/ksvg.h: (WebCore::):
  • ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::SVGDocumentExtensions): (WebCore::SVGDocumentExtensions::~SVGDocumentExtensions): (WebCore::SVGDocumentExtensions::addTimeContainer): (WebCore::SVGDocumentExtensions::removeTimeContainer): (WebCore::SVGDocumentExtensions::startAnimations): (WebCore::SVGDocumentExtensions::pauseAnimations): (WebCore::SVGDocumentExtensions::unpauseAnimations):
  • ksvg2/misc/SVGDocumentExtensions.h:
  • ksvg2/svg/SVGAElement.h:
  • ksvg2/svg/SVGAngle.h: (WebCore::SVGAngle::):
  • ksvg2/svg/SVGAngle.idl: Added.
  • ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::SVGAnimateColorElement): (WebCore::SVGAnimateColorElement::handleTimerEvent): (WebCore::SVGAnimateColorElement::clampColor):
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimateElement.cpp: (SVGAnimateElement::SVGAnimateElement): (SVGAnimateElement::handleTimerEvent):
  • ksvg2/svg/SVGAnimateElement.h:
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement): (WebCore::SVGAnimateTransformElement::parseMappedAttribute): (WebCore::SVGAnimateTransformElement::handleTimerEvent): (WebCore::SVGAnimateTransformElement::parseTransformValue): (WebCore::SVGAnimateTransformElement::calculateRotationFromMatrix): (WebCore::SVGAnimateTransformElement::initialMatrix):
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGAnimatedLength.idl: Added.
  • ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::closeRenderer):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGCircleElement.h:
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGColor.cpp: (WebCore::SVGColor::SVGColor): (WebCore::SVGColor::rgbColor): (WebCore::SVGColor::setRGBColor): (WebCore::SVGColor::setRGBColorICCColor): (WebCore::SVGColor::setColor): (WebCore::SVGColor::color):
  • ksvg2/svg/SVGColor.h: (WebCore::SVGColor::): (WebCore::SVGColor::setRGBColor):
  • ksvg2/svg/SVGColor.idl: Added.
  • ksvg2/svg/SVGComponentTransferFunctionElement.h:
  • ksvg2/svg/SVGCursorElement.h:
  • ksvg2/svg/SVGDefsElement.h:
  • ksvg2/svg/SVGDescElement.h:
  • ksvg2/svg/SVGDocument.idl: Added.
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement): (WebCore::SVGElement::isSupported): (WebCore::SVGElement::id): (WebCore::SVGElement::setId): (WebCore::SVGElement::xmlbase): (WebCore::SVGElement::setXmlbase): (WebCore::SVGElement::ownerSVGElement): (WebCore::SVGElement::viewportElement): (WebCore::SVGElement::tryGetAttribute): (WebCore::SVGElement::tryGetAttributeNS): (WebCore::SVGElement::childShouldCreateRenderer):
  • ksvg2/svg/SVGElement.h:
  • ksvg2/svg/SVGElement.idl: Added.
  • ksvg2/svg/SVGEllipseElement.h:
  • ksvg2/svg/SVGEvent.idl: Added.
  • ksvg2/svg/SVGFEBlendElement.h:
  • ksvg2/svg/SVGFEColorMatrixElement.h:
  • ksvg2/svg/SVGFEComponentTransferElement.h:
  • ksvg2/svg/SVGFECompositeElement.h:
  • ksvg2/svg/SVGFEDiffuseLightingElement.h:
  • ksvg2/svg/SVGFEDistantLightElement.h:
  • ksvg2/svg/SVGFEFloodElement.h:
  • ksvg2/svg/SVGFEFuncAElement.h:
  • ksvg2/svg/SVGFEFuncBElement.h:
  • ksvg2/svg/SVGFEFuncGElement.h:
  • ksvg2/svg/SVGFEFuncRElement.h:
  • ksvg2/svg/SVGFEGaussianBlurElement.h:
  • ksvg2/svg/SVGFEImageElement.h:
  • ksvg2/svg/SVGFELightElement.h:
  • ksvg2/svg/SVGFEMergeElement.h:
  • ksvg2/svg/SVGFEMergeNodeElement.h:
  • ksvg2/svg/SVGFEOffsetElement.h:
  • ksvg2/svg/SVGFEPointLightElement.h:
  • ksvg2/svg/SVGFESpecularLightingElement.h:
  • ksvg2/svg/SVGFESpotLightElement.h:
  • ksvg2/svg/SVGFETileElement.h:
  • ksvg2/svg/SVGFETurbulenceElement.h:
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
  • ksvg2/svg/SVGForeignObjectElement.h:
  • ksvg2/svg/SVGGElement.h:
  • ksvg2/svg/SVGGradientElement.h:
  • ksvg2/svg/SVGHelper.cpp: (WebCore::SVGHelper::PercentageOfViewport): (WebCore::SVGHelper::ParseSeperatedList):
  • ksvg2/svg/SVGImageElement.h:
  • ksvg2/svg/SVGLength.h: (WebCore::SVGLength::):
  • ksvg2/svg/SVGLength.idl: Added.
  • ksvg2/svg/SVGLineElement.h:
  • ksvg2/svg/SVGLinearGradientElement.h:
  • ksvg2/svg/SVGLocatable.cpp: (SVGLocatable::getBBox):
  • ksvg2/svg/SVGLocatable.h:
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGMatrix.cpp: (SVGMatrix::inverse): (SVGMatrix::rotateFromVector):
  • ksvg2/svg/SVGMatrix.h:
  • ksvg2/svg/SVGMatrix.idl: Added.
  • ksvg2/svg/SVGNumber.idl: Added.
  • ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::getPointAtLength):
  • ksvg2/svg/SVGPathElement.h:
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::x): (WebCore::SVGPatternElement::y): (WebCore::SVGPatternElement::width): (WebCore::SVGPatternElement::height): (WebCore::SVGPatternElement::pushAttributeContext): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::notifyClientsToRepaint): (WebCore::SVGPatternElement::notifyAttributeChange): (WebCore::SVGPatternElement::canvasResource): (WebCore::SVGPatternElement::getCTM):
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGPoint.idl: Added.
  • ksvg2/svg/SVGPolyElement.h:
  • ksvg2/svg/SVGPolygonElement.h:
  • ksvg2/svg/SVGPolylineElement.h:
  • ksvg2/svg/SVGRadialGradientElement.h:
  • ksvg2/svg/SVGRect.idl: Added.
  • ksvg2/svg/SVGRectElement.h:
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::~SVGSVGElement): (WebCore::SVGSVGElement::viewport): (WebCore::SVGSVGElement::currentTranslate): (WebCore::SVGSVGElement::unsuspendRedraw): (WebCore::SVGSVGElement::getIntersectionList): (WebCore::SVGSVGElement::getEnclosureList): (WebCore::SVGSVGElement::checkIntersection): (WebCore::SVGSVGElement::checkEnclosure): (WebCore::SVGSVGElement::createSVGNumber): (WebCore::SVGSVGElement::createSVGPoint): (WebCore::SVGSVGElement::createSVGRect): (WebCore::SVGSVGElement::pauseAnimations): (WebCore::SVGSVGElement::unpauseAnimations): (WebCore::SVGSVGElement::animationsPaused): (WebCore::SVGSVGElement::getCurrentTime): (WebCore::SVGSVGElement::setCurrentTime):
  • ksvg2/svg/SVGSVGElement.h: (WebCore::SVGSVGElement::timeScheduler):
  • ksvg2/svg/SVGSVGElement.idl: Added.
  • ksvg2/svg/SVGScriptElement.h:
  • ksvg2/svg/SVGSetElement.cpp: (WebCore::SVGSetElement::SVGSetElement): (WebCore::SVGSetElement::handleTimerEvent):
  • ksvg2/svg/SVGSetElement.h:
  • ksvg2/svg/SVGStopElement.h:
  • ksvg2/svg/SVGStyleElement.h:
  • ksvg2/svg/SVGStyledElement.h:
  • ksvg2/svg/SVGStyledLocatableElement.cpp: (SVGStyledLocatableElement::getBBox):
  • ksvg2/svg/SVGStyledLocatableElement.h:
  • ksvg2/svg/SVGStyledTransformableElement.cpp: (SVGStyledTransformableElement::getBBox):
  • ksvg2/svg/SVGStyledTransformableElement.h:
  • ksvg2/svg/SVGSwitchElement.h:
  • ksvg2/svg/SVGSymbolElement.h:
  • ksvg2/svg/SVGTRefElement.h:
  • ksvg2/svg/SVGTSpanElement.h:
  • ksvg2/svg/SVGTextContentElement.cpp: (SVGTextContentElement::getStartPositionOfChar): (SVGTextContentElement::getEndPositionOfChar): (SVGTextContentElement::getExtentOfChar): (SVGTextContentElement::getCharNumAtPosition): (SVGTextContentElement::parseMappedAttribute):
  • ksvg2/svg/SVGTextContentElement.h:
  • ksvg2/svg/SVGTextElement.cpp: (WebCore::SVGTextElement::getBBox):
  • ksvg2/svg/SVGTextElement.h:
  • ksvg2/svg/SVGTextPositioningElement.h:
  • ksvg2/svg/SVGTitleElement.h:
  • ksvg2/svg/SVGTransform.h: (WebCore::SVGTransform::):
  • ksvg2/svg/SVGTransform.idl: Added.
  • ksvg2/svg/SVGUseElement.h:
  • ksvg2/svg/SVGViewElement.h:
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::pauseTimeouts): (WebCore::Frame::resumeTimeouts):
  • platform/Color.h:
  • rendering/RenderBR.h:
  • rendering/RenderBox.h: (WebCore::RenderBox::renderName):
  • rendering/RenderCanvas.h: (WebCore::RenderCanvas::view):
  • rendering/RenderContainer.h:
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFlow.h: (WebCore::RenderFlow::RenderFlow):
  • rendering/RenderInline.h:
  • rendering/RenderTableSection.h:
  • rendering/RenderTextFragment.h: (WebCore::RenderTextFragment::contentString):
  • xml/xmlattrs.in: Added.
9:51 AM Changeset in webkit [14645] by brmorris
  • 2 edits in S60/trunk/S60WebUi/WebUi/src

2006-05-30 Zalan <​zbujtas@gmail.com>

Second commit, Reviewed by Bradley/David


  • S60WebUi/WebUi/src/WebUiLoadObserver.cpp:
  • S60WebUi/WebUi/src/WebUiWindowContainer.cpp:


9:50 AM Changeset in webkit [14644] by brmorris
  • 1 edit
    2 adds in S60/trunk

2006-05-30 Zalan <​zbujtas@gmail.com>

Reviewed by Bradley/David


  • S60WebUi/WebUi/src/WebUiLoadObserver.cpp:
  • S60WebUi/WebUi/src/WebUiWindowContainer.cpp:


12:48 AM Changeset in webkit [14643] by ggaren
  • 15 edits
    1 move in trunk/WebCore

Reviewed by Maciej.

  • Fixed <rdar://problem/4559720> window sizing: make javascript window and screen sizing methods and properties work @ HIDPI


The general approach here is to change some ints to floats, make
a few key functions that scale between WebView and window/screen
coordinates, and change other functions that work with screen
coordinates to use the scaling functions for their underlying
implementations.

  • manual-tests/window-open-features.html: Removed.
  • manual-tests/window-sizing.html: Added. More test coverage.
  • bindings/js/kjs_window.cpp: Changed ints to floats and IntRects to FloatRects, because window coordinates can be fractional when scaled to WebView/DOM coordinates. (KJS::floatFeature): (KJS::showModalDialog): (KJS::Window::getValueProperty): (KJS::constrainToVisible): (KJS::WindowFunc::callAsFunction):
  • bridge/BrowserExtension.h:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow): Removed custom scaling code and replaced with calls to Page::windowRect and Page::setWindowRect. Renamed 'page' and 'bridge' to 'pageBridge' and 'frameBridge,' respectively.
  • bridge/mac/PageMac.mm: (WebCore::Page::windowRect): Changed to use scaling (WebCore::Page::setWindowRect): ditto
  • bridge/mac/WebCoreFrameBridge.mm: (globalPoint):
  • page/Page.h:
  • platform/IntRect.h:
  • platform/Screen.h:
  • platform/mac/MouseEventMac.mm: (WebCore::globalPositionForEvent): Changed to use flipScreenPoint
  • platform/mac/ScreenMac.mm: (WebCore::flipScreenRect): New key function (WebCore::flipScreenPoint): New key function (WebCore::scaleScreenRectToView): New key function (WebCore::scaleViewRectToScreen): New key function (WebCore::screenRect): Changed to use scaling (WebCore::usableScreenRect): ditto

Feeble attempt to preserve Windows build:


  • platform/win/ScreenWin.cpp: (WebCore::scaleScreenRectToWidget): stub -- doesn't actually scale (WebCore::scaleWidgetRectToScreen): ditto
  • bridge/win/PageWin.cpp: (WebCore::Page::Page): (WebCore::Page::widget):
12:12 AM Changeset in webkit [14642] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderView.h

Fix layout tests.

Note: See TracTimeline for information about the timeline view.