Context Navigation

Merged InterpreterImp code into Interpreter, which implements all interpreter functionality now. This is part of my continuing quest to create an external notion of JS "execution context" that is unified and simple -- something to replace the mix of Context, ContextImp, ExecState, Interpreter, InterpreterImp, and JSRun.

All tests pass. Leaks test has not regressed from its baseline ~207 leaks
with ~3460 leaked nodes.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
bindings/NP_jsobject.cpp:
bindings/objc/WebScriptObject.mm: (+[WebScriptObject throwException:]):
bindings/runtime_root.cpp:
bindings/runtime_root.h:
kjs/Context.cpp: (KJS::Context::Context):
kjs/ExecState.cpp: Added. (KJS::ExecState::lexicalInterpreter):
kjs/ExecState.h: Added. (KJS::ExecState::dynamicInterpreter):
kjs/SavedBuiltins.h: Added.
kjs/bool_object.cpp: (BooleanPrototype::BooleanPrototype):
kjs/collector.cpp: (KJS::Collector::collect): (KJS::Collector::numInterpreters):
kjs/context.h:
kjs/debugger.cpp: (Debugger::attach): (Debugger::detach):
kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::GlobalFuncImp::callAsFunction):
kjs/function_object.cpp: (FunctionObjectImp::construct):
kjs/internal.cpp:
kjs/internal.h:
kjs/interpreter.cpp: (KJS::interpreterMap): (KJS::Interpreter::Interpreter): (KJS::Interpreter::init): (KJS::Interpreter::~Interpreter): (KJS::Interpreter::globalObject): (KJS::Interpreter::initGlobalObject): (KJS::Interpreter::globalExec): (KJS::Interpreter::checkSyntax): (KJS::Interpreter::evaluate): (KJS::Interpreter::builtinObject): (KJS::Interpreter::builtinFunction): (KJS::Interpreter::builtinArray): (KJS::Interpreter::builtinBoolean): (KJS::Interpreter::builtinString): (KJS::Interpreter::builtinNumber): (KJS::Interpreter::builtinDate): (KJS::Interpreter::builtinRegExp): (KJS::Interpreter::builtinError): (KJS::Interpreter::builtinObjectPrototype): (KJS::Interpreter::builtinFunctionPrototype): (KJS::Interpreter::builtinArrayPrototype): (KJS::Interpreter::builtinBooleanPrototype): (KJS::Interpreter::builtinStringPrototype): (KJS::Interpreter::builtinNumberPrototype): (KJS::Interpreter::builtinDatePrototype): (KJS::Interpreter::builtinRegExpPrototype): (KJS::Interpreter::builtinErrorPrototype): (KJS::Interpreter::builtinEvalError): (KJS::Interpreter::builtinRangeError): (KJS::Interpreter::builtinReferenceError): (KJS::Interpreter::builtinSyntaxError): (KJS::Interpreter::builtinTypeError): (KJS::Interpreter::builtinURIError): (KJS::Interpreter::builtinEvalErrorPrototype): (KJS::Interpreter::builtinRangeErrorPrototype): (KJS::Interpreter::builtinReferenceErrorPrototype): (KJS::Interpreter::builtinSyntaxErrorPrototype): (KJS::Interpreter::builtinTypeErrorPrototype): (KJS::Interpreter::builtinURIErrorPrototype): (KJS::Interpreter::mark): (KJS::Interpreter::interpreterWithGlobalObject): (KJS::Interpreter::saveBuiltins): (KJS::Interpreter::restoreBuiltins):
kjs/interpreter.h: (KJS::Interpreter::setCompatMode): (KJS::Interpreter::compatMode): (KJS::Interpreter::firstInterpreter): (KJS::Interpreter::nextInterpreter): (KJS::Interpreter::prevInterpreter): (KJS::Interpreter::debugger): (KJS::Interpreter::setDebugger): (KJS::Interpreter::setContext): (KJS::Interpreter::context):
kjs/nodes.cpp: (StatementNode::hitStatement): (RegExpNode::evaluate):
kjs/protect.h:

JavaScriptGlue:

Reviewed by TimO, Maciej.

JSGlue part of merging InterpreterImp into Interpreter.

Since there's now a kjs forwarding header, I moved all forwarding
headers into a "ForwardingHeaders" directory, like in WebCore.

ForwardingHeaders: Added.
ForwardingHeaders/kjs: Added.
ForwardingHeaders/kjs/ExecState.h: Added.
ForwardingHeaders/wtf: Added.
JavaScriptGlue.xcodeproj/project.pbxproj:
config.h:
wtf: Removed.
wtf/AlwaysInline.h: Removed.
wtf/Assertions.h: Removed.
wtf/FastMalloc.h: Removed.
wtf/Forward.h: Removed.
wtf/HashCountedSet.h: Removed.
wtf/HashSet.h: Removed.
wtf/Noncopyable.h: Removed.
wtf/OwnArrayPtr.h: Removed.
wtf/OwnPtr.h: Removed.
wtf/PassRefPtr.h: Removed.
wtf/Platform.h: Removed.
wtf/RefPtr.h: Removed.
wtf/Vector.h: Removed.

WebCore:

Reviewed by TimO, Maciej.

WebCore part of merging InterpreterImp into Interpreter. No test because there's no behavior change.

A substantive change here is that ScriptInterpreter::mark must now chain to
Interpreter::mark, since Interpreter needs to mark the things that
InterpreterImp used to mark.

WebCore.xcodeproj/project.pbxproj:
bindings/js/kjs_binding.cpp:
bindings/js/kjs_window.cpp: (KJS::Window::put):
bridge/mac/WebCoreFrameBridge.mm:
bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]):
kwq/KWQPageState.mm:

10:09 PM Changeset in webkit [14833] by mjs

3 edits in trunk/WebKit

fix for cocoa exception (whoops)

WebView/WebView.m: (+[WebView _generatedMIMETypeForURLScheme:]): put this back
WebView/WebDataSource.m: (+[WebDataSource _generatedMIMETypeForURLScheme:]): call WebView

8:36 PM Changeset in webkit [14832] by mjs

8 edits in trunk/WebKit

Reviewed by Darin.

remove use of WebView and related from WebMainResourceLoader

WebKit.xcodeproj/project.pbxproj:
WebView/WebDataSource.m: (+[WebDataSource _generatedMIMETypeForURLScheme:]): (+[WebDataSource _representationExistsForURLScheme:]): (+[WebDataSource _canShowMIMEType:]): (-[WebDataSource _handleFallbackContent]): (-[WebDataSource _decidePolicyForMIMEType:decisionListener:]):
WebView/WebDataSourceInternal.h:
WebView/WebFrame.m: (-[WebFrame _isMainFrame]):
WebView/WebFrameInternal.h:
WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader willSendRequest:redirectResponse:]): (-[WebMainResourceLoader continueAfterContentPolicy:response:]): (-[WebMainResourceLoader checkContentPolicyForResponse:]): (-[WebMainResourceLoader loadWithRequestNow:]):
WebView/WebView.m:

6:04 PM Changeset in webkit [14831] by beidson

8 edits in trunk/WebCore

Reviewed by Maciej.

Changed String::ascii() to return a Vector<char> instead of const char*
This allows us to use it "regularly" as the returned vector will destruct
and not leak memory like the previous approach.
We can now do a String.ascii().data() to get a char* buffer instead of
String.deprecatedString().ascii(). It doesn't improve the style much but
dumping the memory-leak issue is a plus.

icon/IconDatabase.cpp: (WebCore::IconDatabase::open): (WebCore::IconDatabase::clearDatabase):
icon/SQLDatabase.cpp: (SQLDatabase::open):
icon/SQLStatement.cpp: (WebCore::SQLStatement::prepare): (WebCore::SQLStatement::step): (WebCore::SQLStatement::returnTextResults): (WebCore::SQLStatement::returnTextResults16): (WebCore::SQLStatement::returnIntResults): (WebCore::SQLStatement::returnInt64Results): (WebCore::SQLStatement::returnDoubleResults): In addition to the changes to the string classes, changed my database code over to the new preferred method.

platform/PlatformString.h:
platform/String.cpp: (WebCore::String::ascii):
platform/StringImpl.cpp: (WebCore::StringImpl::ascii):
platform/StringImpl.h:

5:27 PM Changeset in webkit [14830] by tomernic

2 edits in trunk/WebKit

Reviewed by Maciej.

<rdar://problem/4526052> intermittent assertion failure in -[WebBasePluginPackage dealloc] running layout tests

Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage _initWithPath:]): Renamed from -initWithPath:. Instead of releasing/deallocating self on error, return NO. (-[WebNetscapePluginPackage initWithPath:]): Call the new -_initWithPath:. If it returns NO, unload the plugin package before deallocating it.

4:16 PM Changeset in webkit [14829] by thatcher

1 copy in tags/WebCore-418.16/WebCore

Tag for WebCore 418.16 (part 2 of 2.)

4:16 PM Changeset in webkit [14828] by thatcher

1 add in tags/WebCore-418.16

Tag for WebCore 418.16 (part 1 of 2.)

4:03 PM Changeset in webkit [14827] by hyatt

17 edits in trunk/WebCore

Add selection foreground color on Win32.

4:02 PM Changeset in webkit [14826] by sullivan

2 edits in trunk/WebCore

Reviewed by Darin Adler.

page/Frame.cpp: (WebCore::Frame::markAllMatchesForText): Do a "fake" paint here so that the rectangles for the text matches will have been computed by the time this method returns.

3:43 PM Changeset in webkit [14825] by beidson

4 edits in trunk/WebCore

Reviewed by Levi and Tim Omernick.

-Added a skeleton sqlite3 icon database file to IconDatabase
-Added functionality to validate and recreate this icon.db file
-Fixed some buggys in SQLDatabase.cpp

icon/IconDatabase.cpp: (WebCore::IconDatabase::open): (WebCore::IconDatabase::isValidDatabase): (WebCore::IconDatabase::clearDatabase): (WebCore::IconDatabase::recreateDatabase):
icon/IconDatabase.h:

icon/SQLStatement.cpp: (WebCore::SQLStatement::columnCount): (WebCore::SQLStatement::getColumnName): (WebCore::SQLStatement::getColumnName16): (WebCore::SQLStatement::getColumnText): (WebCore::SQLStatement::getColumnText16): (WebCore::SQLStatement::getColumnDouble): (WebCore::SQLStatement::getColumnInt): (WebCore::SQLStatement::getColumnInt64): (WebCore::SQLStatement::getColumnBlob): -Added checks to make sure we had a valid working sqlite3_statement as the sqlite3_* function calls weren't as error-tolerant as documentation advertised (maybe differences between the 3.3 docs I looked at and the 3.1.3 version installed on OSX)

1:54 PM Changeset in webkit [14824] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Versioning

1:53 PM Changeset in webkit [14823] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Maciej, Harrison.

Fixes <rdar://problem/4582172> frameset load events don't fire (can't login into Gmail account or see map at 511.org)

Framesets need to register their load, beforeunload and unload events with the window.

khtml/html/html_baseimpl.cpp: (HTMLFrameSetElementImpl::parseHTMLAttribute):

12:53 PM Changeset in webkit [14822] by hyatt

3 edits in trunk/WebCore/platform

Fix Win32 build bustage.

12:02 PM Changeset in webkit [14821] by ggaren

10 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Have *.lut.h files #include lookup.h to eliminate surprising header include order dependency.

DerivedSources.make:
kjs/array_object.cpp:
kjs/date_object.cpp:
kjs/date_object.h: (KJS::DateProtoFunc::):
kjs/lexer.cpp:
kjs/math_object.cpp:
kjs/number_object.cpp:
kjs/regexp_object.cpp:
kjs/string_object.cpp:

11:07 AM Changeset in webkit [14820] by beidson

7 edits
3 adds in trunk/WebCore

Reviewed by Levi.

-Added SQLite helper wrappers to ease use of SQLite in the IconDatabase.
-Changed the base IconDatabase over to this new framework.

WebCore.xcodeproj/project.pbxproj:
bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge closeSharedDatabase]):

-By popular request, removed an annoying log message I'd accidentally left in

icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::open): (WebCore::IconDatabase::close): (WebCore::IconDatabase::~IconDatabase):
icon/IconDatabase.h: (WebCore::IconDatabase::isOpen):

-Changed over IconDatabase from direct sqlite3_* calls to the new SQLDatabase calls

icon/SQLDatabase.cpp: Added. (SQLDatabase::SQLDatabase): (SQLDatabase::open): (SQLDatabase::close): (SQLDatabase::executeCommand): (SQLDatabase::tableExists):
icon/SQLDatabase.h: Added. (WebCore::SQLDatabase::isOpen): (WebCore::SQLDatabase::getPath): (WebCore::SQLDatabase::lastError): (WebCore::SQLDatabase::lastErrorMsg): (WebCore::SQLStatement::isPrepared): (WebCore::SQLStatement::lastError): (WebCore::SQLStatement::lastErrorMsg):
icon/SQLStatement.cpp: Added. (WebCore::SQLStatement::SQLStatement): (WebCore::SQLStatement::~SQLStatement): (WebCore::SQLStatement::prepare): (WebCore::SQLStatement::step): (WebCore::SQLStatement::finalize): (WebCore::SQLStatement::reset): (WebCore::SQLStatement::executeCommand): (WebCore::SQLStatement::bindBlob): (WebCore::SQLStatement::bindText): (WebCore::SQLStatement::columnCount): (WebCore::SQLStatement::getColumnName): (WebCore::SQLStatement::getColumnName16): (WebCore::SQLStatement::getColumnText): (WebCore::SQLStatement::getColumnText16): (WebCore::SQLStatement::getColumnDouble): (WebCore::SQLStatement::getColumnInt): (WebCore::SQLStatement::getColumnInt64): (WebCore::SQLStatement::getColumnBlob): (WebCore::SQLStatement::returnTextResults): (WebCore::SQLStatement::returnTextResults16): (WebCore::SQLStatement::returnIntResults): (WebCore::SQLStatement::returnInt64Results): (WebCore::SQLStatement::returnDoubleResults):

-Initial checking of SQLDatabase framework

platform/PlatformString.h:
platform/String.cpp: (WebCore::String::String):

-Added an explicit UChar* constructor to our string class as much of sqlite3's UTF16 handling is based on
null-terminated UTF16 which we didn't yet support.

Jun 11, 2006:

9:10 PM Changeset in webkit [14819] by ddkilzer

2 edits in trunk/WebCore

WebCore:

Reviewed by Maciej.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9408
Clean build fails with "make: * No rule to make target SVGElementFactory.cpp', needed by all'. Stop"

DerivedSources.make: Fix clean builds.

7:03 PM Changeset in webkit [14818] by darin

10 edits in trunk/WebCore

another try at fixing Windows

loader/CachedResource.h:
platform/cairo/GraphicsContextCairo.cpp:
platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::setData):
platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoderPrivate::decode): (WebCore::GIFImageDecoder::setData):
platform/image-decoders/gif/GIFImageDecoder.h:
platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode): (WebCore::JPEGImageDecoder::setData):
platform/image-decoders/jpeg/JPEGImageDecoder.h:
platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::decode): (WebCore::PNGImageDecoder::setData):
platform/image-decoders/png/PNGImageDecoder.h: s/DeprecatedByteArray/Vector<char>/

6:37 PM Changeset in webkit [14817] by darin

5 edits in trunk

WebCore:

try to fix Windows build

platform/cairo/ImageCairo.cpp: (WebCore::Image::loadResource): Use Vector<char> instead of DeprecatedByteArray.

platform/win/TemporaryLinkStubs.cpp: (KWQServeSynchronousRequest): Don't try to return 0 from a function that returns a Vector<char>.

WebKit:

try to fix Windows build

COM/WebKitDLL.cpp: (loadResourceIntoArray): Use Vector<char> instead of DeprecatedByteArray.

6:10 PM Changeset in webkit [14816] by darin

59 edits
2 deletes in trunk/WebCore

Reviewed by Hyatt, tweaked quite a bit and landed by Darin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8039 Remove use of DeprecatedArray in favor of new Vector class

This removes most of the uses of DeprecatedArray and
DeprecatedByteArray, with the exception of DeprecatedCString.

No test cases added because there is no change in
functionality.

loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::data):
loader/CachedCSSStyleSheet.h:
loader/CachedImage.cpp: (WebCore::CachedImage::bufferData): (WebCore::CachedImage::data): (WebCore::CachedImage::checkNotify): (WebCore::CachedImage::shouldStopAnimation):
loader/CachedImage.h:
loader/CachedObject.cpp: (WebCore::CachedObject::bufferData): (WebCore::CachedObject::setExpireDate):
loader/CachedObject.h: (WebCore::CachedObject::setCharset):
loader/CachedScript.cpp: (WebCore::CachedScript::data):
loader/CachedScript.h:
loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::data): (WebCore::CachedXBLDocument::checkNotify):
loader/CachedXBLDocument.h:
loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::data):
loader/CachedXSLStyleSheet.h:
loader/Request.cpp: (WebCore::Request::Request): (WebCore::Request::~Request):
loader/Request.h: (WebCore::Request::buffer): (WebCore::Request::cachedObject): (WebCore::Request::docLoader): (WebCore::Request::isIncremental): (WebCore::Request::setIsIncremental): (WebCore::Request::isMultipart): (WebCore::Request::setIsMultipart):
loader/loader.cpp: (WebCore::crossDomain): (WebCore::Loader::Loader): (WebCore::Loader::load): (WebCore::Loader::servePendingRequests): (WebCore::Loader::receivedAllData): (WebCore::Loader::receivedResponse): (WebCore::Loader::receivedData): (WebCore::Loader::numRequests): (WebCore::Loader::cancelRequests): (WebCore::Loader::removeBackgroundDecodingRequest): (WebCore::Loader::jobForRequest):
platform/Image.cpp: (WebCore::Image::setData):
platform/Image.h: (WebCore::Image::dataBuffer):

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::matchRules): (WebCore::CSSStyleSelector::matchRulesForList): (WebCore::CSSStyleSelector::sortMatchedRules): (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::CSSStyleSelector::createStyleForElement): (WebCore::CSSStyleSelector::createPseudoStyleForElement):
css/cssstyleselector.h: (WebCore::CSSStyleSelector::addMatchedRule): (WebCore::CSSStyleSelector::addMatchedDeclaration):
dom/xml_tokenizer.cpp: (WebCore::OffsetBuffer::OffsetBuffer): (WebCore::openFunc):
html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::index):
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::selectedIndex): (WebCore::HTMLSelectElement::setSelectedIndex): (WebCore::HTMLSelectElement::length): (WebCore::HTMLSelectElement::remove): (WebCore::HTMLSelectElement::value): (WebCore::HTMLSelectElement::setValue): (WebCore::HTMLSelectElement::state): (WebCore::HTMLSelectElement::restoreState): (WebCore::HTMLSelectElement::appendFormData): (WebCore::HTMLSelectElement::optionToListIndex): (WebCore::HTMLSelectElement::listToOptionIndex): (WebCore::HTMLSelectElement::recalcListItems): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::notifyOptionSelected):
html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::listItems):
kwq/KWQLoader.h:
kwq/KWQLoader.mm: (KWQServeSynchronousRequest):
kwq/KWQTextStream.cpp: (QTextStream::operator<<):
kwq/KWQTextStream.h:
loader/FormData.cpp: (WebCore::FormData::flatten): (WebCore::FormData::flattenToString):
loader/FormData.h: (WebCore::FormDataElement::FormDataElement):
platform/DeprecatedString.cpp:
platform/DeprecatedString.h:
platform/IntPointArray.cpp: Removed.
platform/IntPointArray.h: Removed.
platform/TextEncoding.cpp: (WebCore::TextEncoding::toUnicode):
platform/TextEncoding.h:
platform/cairo/pixman/src/pixregion.c:
platform/cg/PathCG.cpp: (WebCore::Path::Path):
rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorder):
rendering/RenderTable.h: (WebCore::RenderTable::colToEffCol): (WebCore::RenderTable::effColToCol):
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::ensureRows): (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::setCellWidths):
rendering/RenderTableSection.h:
rendering/bidi.cpp: (WebCore::addMidpoint): (WebCore::RenderBlock::layoutInlineChildren):
rendering/render_form.cpp: (WebCore::RenderSelect::updateFromElement): (WebCore::RenderSelect::layout): (WebCore::RenderSelect::valueChanged): (WebCore::RenderSelect::selectionChanged): (WebCore::RenderSelect::updateSelection):
rendering/table_layout.cpp: (WebCore::FixedTableLayout::layout):
rendering/table_layout.h:
xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::processSyncLoadResults):
xml/xmlhttprequest.h:

4:58 PM Changeset in webkit [14815] by ddkilzer

122 edits in trunk/WebCore

WebCore:

Reviewed by darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9394
Fix no-SVG build

DerivedSources.make: Removed tabs. Create empty SVGElementFactory.cpp on no-svg build.
ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp: Added #if SVG_SUPPORT/#endif.
ksvg2/bindings/js/JSSVGElementWrapperFactory.h: Ditto.
ksvg2/bindings/idl/svg/SVGAElement.idl: Add "Conditional=SVG" to all interfaces.
ksvg2/bindings/idl/svg/SVGAnimateColorElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGAnimateElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGAnimateTransformElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGAnimatedAngle.idl: Ditto.
ksvg2/bindings/idl/svg/SVGAnimatedBoolean.idl: Ditto.
ksvg2/bindings/idl/svg/SVGAnimatedEnumeration.idl: Ditto.
ksvg2/bindings/idl/svg/SVGAnimatedInteger.idl: Ditto.
ksvg2/bindings/idl/svg/SVGAnimatedLengthList.idl: Ditto.
ksvg2/bindings/idl/svg/SVGAnimatedNumber.idl: Ditto.
ksvg2/bindings/idl/svg/SVGAnimatedNumberList.idl: Ditto.
ksvg2/bindings/idl/svg/SVGAnimatedPathData.idl: Ditto.
ksvg2/bindings/idl/svg/SVGAnimatedPoints.idl: Ditto.
ksvg2/bindings/idl/svg/SVGAnimatedPreserveAspectRatio.idl: Ditto.
ksvg2/bindings/idl/svg/SVGAnimatedRect.idl: Ditto.
ksvg2/bindings/idl/svg/SVGAnimatedString.idl: Ditto.
ksvg2/bindings/idl/svg/SVGAnimatedTransformList.idl: Ditto.
ksvg2/bindings/idl/svg/SVGAnimationElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGCircleElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGClipPathElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGComponentTransferFunctionElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGCursorElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGDOMImplementation.idl: Ditto.
ksvg2/bindings/idl/svg/SVGDefsElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGDescElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGElementInstance.idl: Ditto.
ksvg2/bindings/idl/svg/SVGElementInstanceList.idl: Ditto.
ksvg2/bindings/idl/svg/SVGEllipseElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGEvent.idl: Ditto.
ksvg2/bindings/idl/svg/SVGException.idl: Ditto.
ksvg2/bindings/idl/svg/SVGExternalResourcesRequired.idl: Ditto.
ksvg2/bindings/idl/svg/SVGFEBlendElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGFEColorMatrixElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGFEComponentTransferElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGFECompositeElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGFEFloodElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGFEFuncAElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGFEFuncBElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGFEFuncGElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGFEFuncRElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGFEGaussianBlurElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGFEImageElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGFEMergeElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGFEMergeNodeElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGFEOffsetElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGFETileElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGFETurbulenceElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGFilterElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGFilterPrimitiveStandardAttributes.idl: Ditto.
ksvg2/bindings/idl/svg/SVGFitToViewBox.idl: Ditto.
ksvg2/bindings/idl/svg/SVGGElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGGradientElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGICCColor.idl: Ditto.
ksvg2/bindings/idl/svg/SVGImageElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGLangSpace.idl: Ditto.
ksvg2/bindings/idl/svg/SVGLengthList.idl: Ditto.
ksvg2/bindings/idl/svg/SVGLineElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGLinearGradientElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGLocatable.idl: Ditto.
ksvg2/bindings/idl/svg/SVGMarkerElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGNumberList.idl: Ditto.
ksvg2/bindings/idl/svg/SVGPaint.idl: Ditto.
ksvg2/bindings/idl/svg/SVGPathElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGPathSeg.idl: Ditto.
ksvg2/bindings/idl/svg/SVGPathSegArc.idl: Ditto.
ksvg2/bindings/idl/svg/SVGPathSegClosePath.idl: Ditto.
ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubic.idl: Ditto.
ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubicSmooth.idl: Ditto.
ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadratic.idl: Ditto.
ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadraticSmooth.idl: Ditto.
ksvg2/bindings/idl/svg/SVGPathSegLineto.idl: Ditto.
ksvg2/bindings/idl/svg/SVGPathSegLinetoHorizontal.idl: Ditto.
ksvg2/bindings/idl/svg/SVGPathSegLinetoVertical.idl: Ditto.
ksvg2/bindings/idl/svg/SVGPathSegList.idl: Ditto.
ksvg2/bindings/idl/svg/SVGPathSegMoveto.idl: Ditto.
ksvg2/bindings/idl/svg/SVGPatternElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGPointList.idl: Ditto.
ksvg2/bindings/idl/svg/SVGPolygonElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGPolylineElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGPreserveAspectRatio.idl: Ditto.
ksvg2/bindings/idl/svg/SVGRadialGradientElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGRectElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGRenderingIntent.idl: Ditto.
ksvg2/bindings/idl/svg/SVGScriptElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGSetElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGStopElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGStringList.idl: Ditto.
ksvg2/bindings/idl/svg/SVGStylable.idl: Ditto.
ksvg2/bindings/idl/svg/SVGStyleElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGSwitchElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGSymbolElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGTSpanElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGTests.idl: Ditto.
ksvg2/bindings/idl/svg/SVGTextContentElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGTextElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGTextPositioningElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGTitleElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGTransformList.idl: Ditto.
ksvg2/bindings/idl/svg/SVGTransformable.idl: Ditto.
ksvg2/bindings/idl/svg/SVGURIReference.idl: Ditto.
ksvg2/bindings/idl/svg/SVGUnitTypes.idl: Ditto.
ksvg2/bindings/idl/svg/SVGUseElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGViewElement.idl: Ditto.
ksvg2/bindings/idl/svg/SVGZoomAndPan.idl: Ditto.
ksvg2/bindings/idl/svg/SVGZoomEvent.idl: Ditto.
ksvg2/svg/SVGAngle.idl: Ditto.
ksvg2/svg/SVGAnimatedLength.idl: Ditto.
ksvg2/svg/SVGColor.idl: Ditto.
ksvg2/svg/SVGDocument.idl: Ditto.
ksvg2/svg/SVGElement.idl: Ditto.
ksvg2/svg/SVGEvent.idl: Ditto.
ksvg2/svg/SVGLength.idl: Ditto.
ksvg2/svg/SVGMatrix.idl: Ditto.
ksvg2/svg/SVGNumber.idl: Ditto.
ksvg2/svg/SVGPoint.idl: Ditto.
ksvg2/svg/SVGRect.idl: Ditto.
ksvg2/svg/SVGSVGElement.idl: Ditto.
ksvg2/svg/SVGTransform.idl: Ditto.

4:49 PM Changeset in webkit [14814] by ddkilzer

2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9395
Make prepare-ChangeLog faster

Scripts/prepare-ChangeLog: Use "svn diff" instead of "svn stat" to find changed files, then save the diff output for reuse. Keep a status variable if changes are made to LayoutTests so "svn diff LayoutTests" doesn't have to be run to check for changes when

WebCore is updated. Added -hhelp command-line switch and help message. Move test

for no changed files closer to the beginning of the program.

1:18 PM Changeset in webkit [14813] by thatcher

1 edit in trunk/WebKit/WebInspector/WebInspector.m

Removes a hardcoded path I had added for testing.

1:10 PM Changeset in webkit [14812] by thatcher

2 edits in trunk/WebKit

Reviewed by Tim H.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8672 Red outline from web inspector reappears after inspector is closed

WebInspector/WebInspector.m: (-[NSWindow windowWillClose:]): Added a call to setWebFrame to avoid further load progress notifications. (-[NSWindow setWebFrame:]): Changed to resign the WebView's hostWindow rather than its window for close notifications, to avoid resigning from all windows' close notifications (including the inspector window's) when the WebView is in a hidden tab. Also changed to prevent highlighting the initial focused node.

12:49 PM Changeset in webkit [14811] by andersca

30 edits
2 adds
6 deletes in trunk

WebCore:

2006-06-11 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9390
Move full-frame plugins to WebCore

WebCore.vcproj/WebCore/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj: Add PluginDocument

bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::redirectDataToPlugin): Call the bridge.

bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: Add redirectDataToPlugin which is used to redirect incoming data to a plugin.

bridge/mac/WebCoreViewFactory.h: Add pluginSupportsMIMEType which returns whether any plugins support a given MIME type.

dom/DOMImplementation.cpp:
dom/DOMImplementation.h: Get rid of createTextDocument and just create a text document explicitly when needed.

dom/Document.h: (WebCore::Document::isPluginDocument):
loader/PluginDocument.cpp: Added. (WebCore::PluginTokenizer::PluginTokenizer): (WebCore::PluginTokenizer::wantsRawData): (WebCore::PluginTokenizer::write): (WebCore::PluginTokenizer::createDocumentStructure): (WebCore::PluginTokenizer::writeRawData): (WebCore::PluginTokenizer::stopParsing): (WebCore::PluginTokenizer::finish): (WebCore::PluginTokenizer::isWaitingForScripts): (WebCore::PluginDocument::PluginDocument): (WebCore::PluginDocument::createTokenizer):
loader/PluginDocument.h: Added. (WebCore::PluginDocument::isPluginDocument): Add PluginDocument.

page/Frame.cpp: (WebCore::Frame::begin): Possibly create a plugin document.

page/Frame.h: (WebCore::Frame::redirectDataToPlugin): Add declaration.

platform/PlugInInfoStore.h:
platform/mac/PlugInInfoStoreMac.mm: (WebCore::PlugInInfoStore::supportsMIMEType): Ask WebCoreViewFactory if the MIME type is supported.

WebKit:

2006-06-11 Anders Carlsson <acarlsson@apple.com>

Reviewed by Tim.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9390
Move full-frame plugins to WebCore

Plugins/WebBaseNetscapePluginStream.h:
Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream instance]): Add instance method which returns the plugin instance.

Plugins/WebBasePluginPackage.h: Add WebPluginManualLoader protocol

Plugins/WebNetscapePluginDocumentView.h: Removed.
Plugins/WebNetscapePluginDocumentView.m: Removed.

Plugins/WebNetscapePluginEmbeddedView.h:
Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:]): (-[WebNetscapePluginEmbeddedView dealloc]): (-[WebNetscapePluginEmbeddedView didStart]): (-[WebNetscapePluginEmbeddedView pluginView:receivedResponse:]): (-[WebNetscapePluginEmbeddedView pluginView:receivedData:]): (-[WebNetscapePluginEmbeddedView pluginView:receivedError:]): (-[WebNetscapePluginEmbeddedView pluginViewFinishedLoading:]): (-[WebNetscapePluginEmbeddedView redeliverStream]): Make WebNetscapePluginEmbeddedView support the WebPluginManualLoader protocol. It creates a plugin stream and feeds the data manually. Much of this code has been copied from WebNetscapePluginRepresentation.

Plugins/WebNetscapePluginRepresentation.h: Removed.
Plugins/WebNetscapePluginRepresentation.m: Removed.

Plugins/WebPluginController.h:
Plugins/WebPluginController.m: (-[WebPluginController pluginView:receivedResponse:]): (-[WebPluginController pluginView:receivedData:]): (-[WebPluginController pluginView:receivedError:]): (-[WebPluginController pluginViewFinishedLoading:]): Make WebPluginController support the WebPluginManualLoader protocol so it can feed data manually to WebKit plugins.

Plugins/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): Use WebHTMLView and WebHTMLRepresentation when registering/unregistering plug-in MIME types.

Plugins/WebPluginDocumentView.h: Removed.
Plugins/WebPluginDocumentView.m: Removed.

WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:]): (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]): Add loadManually argument.

(-[WebFrameBridge redirectDataToPlugin:]):
Call down to the HTML representation.

(-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]):
Pass NO to loadManually.

(-[WebFrameBridge determineObjectFromMIMEType:URL:]):
Explicitly check if the MIME type is supported by a plug-in instead of checking the view class.

WebCoreSupport/WebViewFactory.m: (-[WebViewFactory pluginSupportsMIMEType:]): New function which returns whether any plugins support a given MIME type.

WebKit.xcodeproj/project.pbxproj: Update for removed files.

WebView/WebFrame.m: (-[WebFrame _reloadForPluginChanges]): Remove view type checks.

(-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
(-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
Remove FIXME comments.

WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation _redirectDataToManualLoader:forPluginView:]): New function which redirects incoming data to a manual loader.

(-[WebHTMLRepresentation receivedData:withDataSource:]):
(-[WebHTMLRepresentation receivedError:withDataSource:]):
(-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
Optionally redirect incoming data.

WebView/WebHTMLRepresentationPrivate.h:

Jun 10, 2006:

9:07 PM Changeset in webkit [14810] by ddkilzer

3 edits
4 adds in trunk

LayoutTests:

Patch by mitzpettel. Reviewed by hyatt.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9334 Incomplete repaint when changing block from non-positioned to positioned

fast/repaint/static-to-positioned-expected.checksum: Added.
fast/repaint/static-to-positioned-expected.png: Added.
fast/repaint/static-to-positioned-expected.txt: Added.
fast/repaint/static-to-positioned.html: Added.

WebCore:

Patch by mitzpettel. Reviewed by hyatt.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9334 Incomplete repaint when changing block from non-positioned to positioned

Test: fast/repaint/static-to-positioned.html

rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): If changing from static to positioned, repaint as static.

8:46 PM Changeset in webkit [14809] by ddkilzer

4 edits
9 adds in trunk

LayoutTests:

Reviewed by hyatt.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9193 REGRESSION: setting an opacity on an element with an outline causes the outline to disappear completely

test repainting of layer children's outlines that extend beyond the layer

fast/layers: Added.
fast/layers/opacity-outline-expected.checksum: Added.
fast/layers/opacity-outline-expected.png: Added.
fast/layers/opacity-outline-expected.txt: Added.
fast/layers/opacity-outline.html: Added.
fast/repaint/layer-child-outline-expected.checksum: Added.
fast/repaint/layer-child-outline-expected.png: Added.
fast/repaint/layer-child-outline-expected.txt: Added.
fast/repaint/layer-child-outline.html: Added.

WebCore:

Reviewed by hyatt.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9193 REGRESSION: setting an opacity on an element with an outline causes the outline to disappear completely

Test: fast/layers/opacity-outline.html

fix repainting of layer children's outlines that extend beyond the layer

Test: fast/repaint/layer-child-outline.html

rendering/RenderLayer.cpp: (WebCore::RenderLayer::intersectsDamageRect): Account for outlines. (WebCore::RenderLayer::absoluteBoundingBox): Ditto.
rendering/RenderObject.cpp: (WebCore::RenderObject::maximalOutlineSize): Changed to return the view's maximal outline size rather than 0 for PaintPhaseChildOutlines.

7:34 PM Changeset in webkit [14808] by sfalken

3 edits in trunk/WebCore

2006-06-10 Steve Falkenburg <sfalken@apple.com>

Fix build break

platform/cairo/GraphicsContextCairo.cpp:
platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::scale):

9:09 AM Changeset in webkit [14807] by ggaren

28 edits in trunk

JavaScriptCore:

http://bugzilla.opendarwin.org/show_bug.cgi?id=8515 Linux porting compile bug

Fix by Mike Emmel, Reviewed by Darin.

JavaScriptCoreSources.bkl:
jscore.bkl:
wtf/Platform.h:

WebCore:

http://bugzilla.opendarwin.org/show_bug.cgi?id=8515 Linux porting compile bug

Fix by Mike Emmel, Reviewed by Darin.

Projects/gdk/webcore-gdk.bkl:
WebCoreSources.bkl:
css/maketokenizer:
html/HTMLCanvasElement.cpp:
html/HTMLImageElement.h:
icon/IconDatabase.cpp:
make-generated-sources.sh:
page/Frame.h:
page/FramePrivate.h:
platform/Cursor.h:
platform/FontData.h: (WebCore::FontData::getGlyphIndex):
platform/GlyphBuffer.h: (WebCore::GlyphBuffer::glyphAt): (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add):
platform/GraphicsContext.h:
platform/PlatformKeyboardEvent.h:
platform/PlatformMouseEvent.h:
platform/PlatformWheelEvent.h:
platform/ScrollView.h:
platform/TransferJob.h: (WebCore::TransferJob::getInternal):
platform/TransferJobInternal.h: (WebCore::TransferJobInternal::TransferJobInternal):
platform/Widget.h:
platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::roundToDevicePixels):
webcore-base.bkl:
xpath/impl/XPathValue.cpp:

6:42 AM Changeset in webkit [14806] by sullivan

5 edits in trunk/WebKit

Reviewed by Tim Omernick and Dave Hyatt.

WebKit support for computing but not highlighting rects for text matches.

WebView/WebHTMLViewPrivate.h: added markedTextMatchesAreHighlighted/setMarkedTextMatchesAreHighlighted and rectsForTextMatches, and renamed related methods for clarity/consistency
WebView/WebHTMLView.m: (-[WebHTMLView markAllMatchesForText:caseSensitive:]): renamed, calls similarly-renamed method (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): new method, calls through to bridge (-[WebHTMLView markedTextMatchesAreHighlighted]): ditto (-[WebHTMLView unmarkAllTextMatches]): renamed (-[WebHTMLView rectsForTextMatches]): new method, calls through to bridge

WebView/WebViewPrivate.h: added rectsForTextMatches, renamed other methods (and added highlight: parameter)
WebView/WebView.m: (-[WebView markAllMatchesForText:caseSensitive:highlight:]): renamed for clarity/consistency, and now has highlight: parameter, which is passed down (-[WebView unmarkAllTextMatches]): renamed for clarity/consistency, and calls similarly-renamed method lower down. diff got confused with the end of this and the end of the next method. (-[WebView rectsForTextMatches]): new method, calls through to WebHTMLView as related methods currently do

6:42 AM Changeset in webkit [14805] by sullivan

6 edits in trunk/WebCore

Reviewed by Tim Omernick and Dave Hyatt.

WebCore support for computing but not highlighting rects for text matches.

dom/Document.h: added setRenderedRectForMarker() and renderedRectsForMarkers(), and redefined MarkerMap to be a hashtable of node -> (pair of vectors), one vector of markers and one vector of rects

dom/Document.cpp: (placeholderRectForMarker()): new function, returns a recognizable degenerate rect used until a real rect has been set (WebCore::Document::addMarker): Reworked for new MarkerMap data structure; now adds parallel placeholder rect along with marker (WebCore::Document::copyMarkers): Reworked for new MarkerMap data structure (WebCore::Document::removeMarkers): Reworked for new MarkerMap data structure; now removed corresponding rect along with marker (WebCore::Document::markersForNode): Reworked for new MarkerMap data structure (WebCore::Document::renderedRectsForMarkers): New method, returns an array of all non-placeholder rects for the given marker type (WebCore::Document::repaintMarkers): Reworked for new MarkerMap data structure (WebCore::Document::setRenderedRectForMarker): New method, sets the rendered rect for a given marker (WebCore::Document::shiftMarkers): Reworked for new MarkerMap data structure; resets rendered rects to placeholders.

rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): removed markedTextMatchesAreHighlighted guard; we always want to call paintTextMatchMarker now, but sometimes we will end up only computing the rect, not actually highlighting it. (Maybe some names should be improved here?) (WebCore::InlineTextBox::paintTextMatchMarker): Reorganized to move all the code that actually draws into a block that's guarded by markedTextMatchesAreHighlighted. The rest of the code computes where the highlight will go, and now we always use that computation in order to call setRenderedRectForMarker.

bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge rectsForTextMatches]): New method, returns an array of NSValues representing NSRects. Gets them from Document::renderedRectsForMarkers

6:38 AM Changeset in webkit [14804] by sullivan

2 edits in trunk/WebKit

<http://bugzilla.opendarwin.org/show_bug.cgi?id=9384>
WebView's initWithCoder: method does not set useBackForwardList
correctly

Reviewed by John Sullivan.

WebView/WebView.m: (-[WebView initWithCoder:]): Make sure that the function variable useBackForwardList is correctly set, so that the copy in the _private ivar is set.

3:24 AM Changeset in webkit [14803] by ap

2 edits in trunk/WebKitTools

2006-06-10 Mitz Pettel <opendarwin.org@mitzpettel.com>

Reviewed and landed by ap.

make DumpRenderTree build

DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): Changed _updateFocusState to _updateActiveState (-[WaitUntilDoneDelegate webViewFocus:]): Ditto. (-[LayoutTestController setWindowIsKey:]): Ditto. (-[LayoutTestController setMainFrameIsFirstResponder:]): Ditto.

2:59 AM Changeset in webkit [14802] by andersca

2 edits in trunk/WebCore

2006-06-10 Anders Carlsson <acarlsson@apple.com>

Reviewed by Eric.

bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::put): Call WebCore::JSHTMLElement::put so that autogenerated setters will work for HTMLElement.

Jun 9, 2006:

9:52 PM Changeset in webkit [14801] by ggaren

3 edits in trunk/JavaScriptCore

Build fix -- I think :).

JavaScriptCore.xcodeproj/project.pbxproj:
kjs/context.h:

9:34 PM Changeset in webkit [14800] by ggaren

2 edits in trunk/WebCore

Build fix after last JSC check-in (oops!)

bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame evaluateWebScript:]):

8:57 PM Changeset in webkit [14799] by ggaren

10 edits
1 copy in trunk/JavaScriptCore

Reviewed by Eric (yay!).

Removed Context wrapper for ContextImp, renamed ContextImp to Context, split Context into its own file -- Context.cpp -- renamed _var to m_var, change ' *' to '* '.

JavaScriptCore.xcodeproj/project.pbxproj:
kjs/Context.cpp: Added. (KJS::Context::Context): (KJS::Context::~Context): (KJS::Context::mark):
kjs/context.h: (KJS::Context::scopeChain): (KJS::Context::variableObject): (KJS::Context::setVariableObject): (KJS::Context::thisValue): (KJS::Context::callingContext): (KJS::Context::activationObject): (KJS::Context::currentBody): (KJS::Context::function): (KJS::Context::arguments): (KJS::Context::pushScope): (KJS::Context::seenLabels):
kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::processParameters): (KJS::FunctionImp::argumentsGetter): (KJS::GlobalFuncImp::callAsFunction):
kjs/internal.cpp: (KJS::InterpreterImp::evaluate):
kjs/internal.h: (KJS::InterpreterImp::setContext): (KJS::InterpreterImp::context):
kjs/interpreter.cpp:
kjs/interpreter.h: (KJS::ExecState::context): (KJS::ExecState::ExecState):
kjs/nodes.cpp: (currentSourceId): (currentSourceURL): (ThisNode::evaluate): (ResolveNode::evaluate): (FunctionCallResolveNode::evaluate): (PostfixResolveNode::evaluate): (DeleteResolveNode::evaluate): (TypeOfResolveNode::evaluate): (PrefixResolveNode::evaluate): (AssignResolveNode::evaluate): (VarDeclNode::evaluate): (VarDeclNode::processVarDecls): (DoWhileNode::execute): (WhileNode::execute): (ForNode::execute): (ForInNode::execute): (ContinueNode::execute): (BreakNode::execute): (ReturnNode::execute): (WithNode::execute): (SwitchNode::execute): (LabelNode::execute): (TryNode::execute): (FuncDeclNode::processFuncDecl): (FuncExprNode::evaluate):

8:09 PM Changeset in webkit [14798] by justing

1 edit in trunk/WebCore/ChangeLog

5:16 PM Changeset in webkit [14797] by thatcher

1 copy in tags/WebCore-418.15/WebCore

Tag for WebCore 418.15 (part 2 of 2.)

5:16 PM Changeset in webkit [14796] by thatcher

1 add in tags/WebCore-418.15

Tag for WebCore 418.15 (part 1 of 2.)

5:01 PM Changeset in webkit [14795] by hyatt

1 edit in trunk/WebCore/page/Frame.cpp

Fix win32 build bustage.

4:37 PM Changeset in webkit [14794] by hyatt

3 edits in trunk/WebKit

Rename updateFocusState to updateActiveState.

WebView/WebHTMLView.m: (-[WebHTMLView _updateActiveState]): (-[NSArray viewDidMoveToWindow]): (-[NSArray windowDidBecomeKey:]): (-[NSArray windowDidResignKey:]): (-[NSArray becomeFirstResponder]): (-[NSArray resignFirstResponder]): (-[WebHTMLView _formControlIsBecomingFirstResponder:]): (-[WebHTMLView _formControlIsResigningFirstResponder:]):
WebView/WebHTMLViewPrivate.h:

4:33 PM Changeset in webkit [14793] by thatcher

1 edit in branches/Safari-2-0-branch/WebCore/khtml/xml/dom_nodeimpl.cpp

Correcting a merge problem.

4:30 PM Changeset in webkit [14792] by thatcher

3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This fixes the regression from <rdar://problem/4578533> REGRESSION: vbulletin search box closes when clicked

2006-02-23 Vicki Murley <vicki@apple.com>

Reviewed by Hyatt.

fix <rdar://problem/4456004> onbeforeunload should cancel, and <rdar://problem/4453579> REGRESSION (TOT): onbeforeunload is broken (7421)

bridge/mac/MacFrame.mm: (WebCore::MacFrame::shouldClose): Onbeforeunload is a non-bubbling window event, so we should be using handleWindowEvent rather than dispatching a generic event on the body. It seems this only worked before because of incorrect code in other parts of the tree.
dom/dom2_eventsimpl.cpp: (WebCore::BeforeUnloadEventImpl::BeforeUnloadEventImpl): for this constructor, pass true for the cancel parameter

4:26 PM Changeset in webkit [14791] by hyatt

5 edits in trunk/WebCore

Rename m_isFocused on the frame to m_isActive, since it isn't really
about focus but is instead about whether or not the top-level window is
active.

Pull code that was incorrectly factored into Mac-only code out of FrameMac
and back up into Frame.

Reviewed by andersca

bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm:
page/Frame.cpp: (WebCore::Frame::setFocusNodeIfNeeded): (WebCore::Frame::isActive): (WebCore::Frame::setIsActive):
page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):

4:07 PM Changeset in webkit [14790] by hyatt

1 edit in trunk/WebKit/COM/WebView.cpp

Fix Win32 build bustage.

3:04 PM Changeset in webkit [14789] by thatcher

1 copy in tags/WebCore-418.14/WebCore

Tag for WebCore 418.14 (part 2 of 2.)

3:04 PM Changeset in webkit [14788] by thatcher

1 add in tags/WebCore-418.14

Tag for WebCore 418.14 (part 1 of 2.)

3:03 PM Changeset in webkit [14787] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Versioning

3:01 PM Changeset in webkit [14786] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Rolling out this fix, this caused a Mail regression.
<rdar://problem/4578653> Forwarding loses the attached images

2006-04-26 Tim Omernick <timo@apple.com>

Reviewed by Hyatt.

<rdar://problem/4068375> Flash inserted via innerHTML Fails to Show when CSS Display
Style is Toggled via Javascript

html/html_objectimpl.cpp: (WebCore::HTMLObjectElement::setComplete): Set needWidgetUpdate when finished parsing, even if the object element is not in a document. That way, when the element attaches to a document, it will update its widget (creating the plug-in view if necessary). This is important when the object is being inserted via setInnerHTML, since the parsed nodes are not added to the document until the whole HTML string is parsed.

2:25 PM Changeset in webkit [14785] by thatcher

1 edit in trunk/WebKitSite/coding/bsd-license.html

Removes some control characters that snuck in.

1:20 PM Changeset in webkit [14784] by hyatt

34 edits in trunk

WebCore:

Rework selection coloring. Rename displaysWithFocusAttributes
to isActive. Move the white-blending code onto the Color API to make
it more convenient to mutate colors for selection blending. Eliminate all
the selection state from the GraphicsContext and move it to the RenderTheme.
Implement both Win32 and Mac theme selection colors.

Reviewed by sfalken

bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::setIsActive):
bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:]): (-[WebCoreFrameBridge setIsActive:]): (-[WebCoreFrameBridge selectionColor]):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
page/Frame.cpp: (WebCore::Frame::isActive): (WebCore::Frame::setIsActive):
page/Frame.h:
platform/Color.cpp: (WebCore::blend): (WebCore::Color::blendWithWhite):
platform/Color.h: (WebCore::Color::hasAlpha):
platform/GraphicsContext.cpp: (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
platform/GraphicsContext.h:
platform/mac/GraphicsContextMac.mm:
platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::endTransparencyLayer):
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSelection):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::fillHorizontalSelectionGap): (WebCore::RenderBlock::fillVerticalSelectionGap): (WebCore::RenderBlock::fillLeftSelectionGap): (WebCore::RenderBlock::fillRightSelectionGap):
rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paint):
rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
rendering/RenderListMarker.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::selectionColor):
rendering/RenderObject.h:
rendering/RenderReplaced.cpp:
rendering/RenderReplaced.h:
rendering/RenderTheme.cpp: (WebCore::RenderTheme::activeSelectionColor): (WebCore::RenderTheme::inactiveSelectionColor): (WebCore::RenderTheme::platformActiveSelectionColor): (WebCore::RenderTheme::platformInactiveSelectionColor):
rendering/RenderTheme.h:
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::platformActiveSelectionColor): (WebCore::RenderThemeMac::platformInactiveSelectionColor):
rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::platformActiveSelectionColor): (WebCore::RenderThemeWin::platformInactiveSelectionColor):
rendering/RenderThemeWin.h:
rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):

WebKit:

Rename displaysWithFocusAttributes to isActive.

Reviewed by sfalken

WebKit.xcodeproj/project.pbxproj:
WebView/WebHTMLView.m: (-[WebHTMLView _updateFocusState]):

1:14 PM Changeset in webkit [14783] by thatcher

5 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This fixes <rdar://problem/4578533> REGRESSION: vbulletin search box closes when clicked

2006-02-08 Adele Peterson <adele@apple.com>

Reviewed by Maciej.

Fixed <rdar://problem/4325160> REGRESSION(416.12-420+): window events not stopped by stopPropagation (affects macnn forums)

Tests:

fast/events/window-events-bubble.html
fast/events/window-events-bubble2.html
fast/events/window-events-capture.html

khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::handleWindowEvent): Added to send events directly to the window. This code used to be in defaultEventHandler, but that wasn't sending them at the right time. (WebCore::DocumentImpl::defaultEventHandler): Moved code to send window events to handleWindowEvent.
khtml/xml/DocumentImpl.h: Added handleWindowEvent.
khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchGenericEvent): fire window events in capture and bubble phases. (WebCore::NodeImpl::dispatchWindowEvent): call handleWindowEvent.

12:14 PM Changeset in webkit [14782] by justing

10 edits
4 adds in trunk

LayoutTests:

Reviewed by levi

<rdar://problem/4549980>
REGRESSION: "Find Again" can get stuck when searching for string with a trailing space

editing/execCommand/findString-expected.checksum: Added.
editing/execCommand/findString-expected.png: Added.
editing/execCommand/findString-expected.txt: Added.
editing/execCommand/findString.html: Added.

WebCore:

Reviewed by levi

<rdar://problem/4549980>
REGRESSION: "Find Again" can get stuck when searching for string with a trailing space

bridge/mac/FrameMac.h: Moved findString to Frame.
bridge/mac/FrameMac.mm: Ditto.
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge searchFor:direction:caseSensitive:wrap:]): Convert the NSString to a String.
editing/JSEditor.cpp: Added execCommand(FindString, ...)
editing/Selection.cpp: Added a constructor for Ranges (WebCore::Selection::Selection):
editing/Selection.h:
page/Frame.cpp: (WebCore::Frame::findString): Moved from FrameMac. Compare a selection created using the found range with the current selection in case the current selection is the found range minus some collapsed whitespace on the edges.
page/Frame.h:

12:06 PM Changeset in webkit [14781] by ggaren

3 edits in trunk/WebKitTools

Reviewed by Darin, landed by Geoff.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9350
Use pathcmp() when sorting paths in svn-create-patch

Scripts/run-webkit-tests: Fixed splitpath() to use File::Basename subroutines instead of regex.
Scripts/svn-create-patch: Copied numericcmp(), pathcmp() and splitpath() from run-webkit-tests. Changed sort() functions to use pathcmp(). Added subroutine prototypes. Added -h command-line switch and printUsage() subroutine.

11:40 AM Changeset in webkit [14780] by sfalken

4 edits in trunk/WebCore

2006-06-09 Steve Falkenburg <sfalken@apple.com>

Fix build break

WebCore.vcproj/WebCore/WebCore.vcproj:
css/MediaQueryEvaluator.cpp:
platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::addRoundedRectClip): (GraphicsContext::addInnerRoundedRectClip): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome):

10:09 AM Changeset in webkit [14779] by bdakin

23 edits
234 adds in trunk

Reviewed by Hyatt. Tweaked by Maciej. Tweaks reviewed by Beth.
Landed by Beth.

CSS3 Media Queries implementation.
<http://bugzilla.opendarwin.org/show_bug.cgi?id=4127>

WebCore.xcodeproj/project.pbxproj:
bindings/js/kjs_css.cpp: (KJS::DOMMediaList::put): (KJS::KJS::DOMMediaListProtoFunc::callAsFunction):
bindings/objc/DOMCSS.mm: (-[DOMMediaList setMediaText:]): (-[DOMMediaList deleteMedium:]): (-[DOMMediaList appendMedium:]):
css/CSSGrammar.y:
css/MediaFeatureNames.cpp: Added. (WebCore::MediaFeatureNames::init):
css/MediaFeatureNames.h: Added.
css/MediaList.cpp: (WebCore::MediaList::MediaList): (WebCore::MediaList::~MediaList): (WebCore::parseMediaDescriptor): (WebCore::MediaList::deleteMedium): (WebCore::MediaList::mediaText): (WebCore::MediaList::setMediaText): (WebCore::MediaList::item): (WebCore::MediaList::appendMedium): (WebCore::MediaList::appendMediaQuery):
css/MediaList.h: (WebCore::MediaList::MediaList): (WebCore::MediaList::length): (WebCore::MediaList::mediaQueries):
css/MediaQuery.cpp: Added. (WebCore::MediaQuery::MediaQuery): (WebCore::MediaQuery::~MediaQuery): (WebCore::MediaQuery::operator==): (WebCore::MediaQuery::cssText):
css/MediaQuery.h: Added. (WebCore::MediaQuery::): (WebCore::MediaQuery::restrictor): (WebCore::MediaQuery::expressions): (WebCore::MediaQuery::mediaType): (WebCore::MediaQuery::append):
css/MediaQueryEvaluator.cpp: Added. (WebCore::): (WebCore::MediaQueryEvaluator): (WebCore::MediaQueryEvaluator::~MediaQueryEvaluator): (WebCore::MediaQueryEvaluator::mediaTypeMatch): (WebCore::applyRestrictor): (WebCore::MediaQueryEvaluator::eval): (WebCore::parseAspectRatio): (WebCore::cmpvalue): (WebCore::numberValue): (WebCore::colorMediaFeatureEval): (WebCore::monochromeMediaFeatureEval): (WebCore::device_aspect_ratioMediaFeatureEval): (WebCore::gridMediaFeatureEval): (WebCore::device_heightMediaFeatureEval): (WebCore::device_widthMediaFeatureEval): (WebCore::heightMediaFeatureEval): (WebCore::widthMediaFeatureEval): (WebCore::min_colorMediaFeatureEval): (WebCore::max_colorMediaFeatureEval): (WebCore::min_monochromeMediaFeatureEval): (WebCore::max_monochromeMediaFeatureEval): (WebCore::min_device_aspect_ratioMediaFeatureEval): (WebCore::max_device_aspect_ratioMediaFeatureEval): (WebCore::min_heightMediaFeatureEval): (WebCore::max_heightMediaFeatureEval): (WebCore::min_widthMediaFeatureEval): (WebCore::max_widthMediaFeatureEval): (WebCore::min_device_heightMediaFeatureEval): (WebCore::max_device_heightMediaFeatureEval): (WebCore::min_device_widthMediaFeatureEval): (WebCore::max_device_widthMediaFeatureEval): (WebCore::createFunctionMap):
css/MediaQueryEvaluator.h: Added.
css/MediaQueryExp.cpp: Added. (WebCore::MediaQueryExp::MediaQueryExp): (WebCore::MediaQueryExp::~MediaQueryExp):
css/MediaQueryExp.h: Added. (WebCore::MediaQueryExp::mediaFeature): (WebCore::MediaQueryExp::value): (WebCore::MediaQueryExp::operator==):
css/StyleSheet.cpp: (WebCore::StyleSheet::setMedia):
css/cssparser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::setupParser): (WebCore::CSSParser::parseMediaQuery): (WebCore::CSSParser::createFloatingMediaQueryExp): (WebCore::CSSParser::sinkFloatingMediaQueryExp): (WebCore::CSSParser::createFloatingMediaQueryExpList): (WebCore::CSSParser::sinkFloatingMediaQueryExpList): (WebCore::CSSParser::createFloatingMediaQuery): (WebCore::CSSParser::sinkFloatingMediaQuery):
css/cssparser.h:
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::~CSSStyleSelector): (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::matchUARules): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::CSSStyleSelector::updateFont): (WebCore::CSSStyleSelector::cacheBorderAndBackground): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSRuleSet::addRulesFromSheet):
css/cssstyleselector.h:
css/maketokenizer:
css/tokenizer.flex:
dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createCSSStyleSheet):
html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::setStyleSheet):
html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::childrenChanged):
ksvg2/svg/SVGDOMImplementation.cpp: (SVGDOMImplementation::createCSSStyleSheet):
ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::childrenChanged):
page/Frame.cpp: (WebCore::Frame::Frame):
platform/Screen.h:
platform/mac/ScreenMac.mm: (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome):

Jun 8, 2006:

11:14 PM Changeset in webkit [14778] by justing

1 edit in trunk/WebCore/ChangeLog

Tweaked ChangeLog

9:57 PM Changeset in webkit [14777] by justing

39 edits
26 adds in trunk

LayoutTests:

Reviewed by levi

<http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
Implement execCommand(Insert{Un}OrderedList)

Added:

editing/execCommand/create-list-from-range-selection-expected.checksum: Added.
editing/execCommand/create-list-from-range-selection-expected.png: Added.
editing/execCommand/create-list-from-range-selection-expected.txt: Added.
editing/execCommand/create-list-from-range-selection.html: Added.
editing/execCommand/insert-list-and-stitch-expected.checksum: Added.
editing/execCommand/insert-list-and-stitch-expected.png: Added.
editing/execCommand/insert-list-and-stitch-expected.txt: Added.
editing/execCommand/insert-list-and-stitch.html: Added.
editing/execCommand/insert-list-with-id-expected.checksum: Added.
editing/execCommand/insert-list-with-id-expected.png: Added.
editing/execCommand/insert-list-with-id-expected.txt: Added.
editing/execCommand/insert-list-with-id.html: Added.
editing/execCommand/remove-list-from-range-selection-expected.checksum: Added.
editing/execCommand/remove-list-from-range-selection-expected.png: Added.
editing/execCommand/remove-list-from-range-selection-expected.txt: Added.
editing/execCommand/remove-list-from-range-selection.html: Added.
editing/execCommand/remove-list-items-expected.checksum: Added.
editing/execCommand/remove-list-items-expected.png: Added.
editing/execCommand/remove-list-items-expected.txt: Added.
editing/execCommand/remove-list-items.html: Added.
editing/execCommand/switch-list-type-expected.checksum: Added.
editing/execCommand/switch-list-type-expected.png: Added.
editing/execCommand/switch-list-type-expected.txt: Added.
editing/execCommand/switch-list-type.html: Added.

Fixes:

editing/pasteboard/drag-drop-modifies-page-expected.txt:
editing/pasteboard/paste-list-001-expected.txt:
editing/selection/drag-to-contenteditable-iframe-expected.checksum:
editing/selection/drag-to-contenteditable-iframe-expected.png:
editing/selection/drag-to-contenteditable-iframe-expected.txt:
editing/style/block-style-005-expected.txt:
fast/text/textIteratorNilRenderer-expected.checksum:
fast/text/textIteratorNilRenderer-expected.png:
fast/text/textIteratorNilRenderer-expected.txt:
editing/deleting/delete-line-016-expected.checksum:
editing/deleting/delete-line-016-expected.png:
editing/deleting/delete-line-016-expected.txt:

WebCore:

Reviewed by levi

<http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
Implement execCommand(Insert{Un}OrderedList)

WebCore.xcodeproj/project.pbxproj: Added InsertListCommand.{h,cpp} to the project.
dom/Position.cpp: (WebCore::hasRenderedNonAnonymousDescendantsWithHeight): Added. A block with height is only a candidate if this is false. This should fix the problems getting carets into empty blocks. (WebCore::Position::inRenderedContent):
editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::doApply):
editing/CompositeEditCommand.cpp: (WebCore::hasARenderedDescendant): (WebCore::CompositeEditCommand::prune): A node can have DOM descendants that are rendered, yet have no rendered descendants. Fixed the pruning rule to avoid removing a node like this. (WebCore::CompositeEditCommand::mergeIdenticalElements): Put the two elements next to each other if they aren't already, as a convenience. (WebCore::CompositeEditCommand::moveParagraph): Added code to preserve the current selection. (WebCore::CompositeEditCommand::moveParagraphs): Ditto.
editing/CompositeEditCommand.h:
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): Expansion for special elements should continue to happen until it is no longer possible. (WebCore::DeleteSelectionCommand::handleGeneralDelete): The code to adjust the start node wouldn't always avoid removing the start block.
editing/InsertListCommand.cpp: Added. (WebCore::InsertListCommand::fixOrphanedListChild): Puts a list item that isn't inside a list into a list. (WebCore::InsertListCommand::InsertListCommand): (WebCore::InsertListCommand::modifyRange): (WebCore::InsertListCommand::doApply):
editing/InsertListCommand.h: Added. (WebCore::InsertListCommand::):
editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply):
editing/InsertParagraphSeparatorCommand.cpp:
editing/JSEditor.cpp:
editing/TextIterator.cpp: (WebCore::TextIterator::advance): Don't handle a node if the end of the range used to create the iterator ends at the start of that node. used to create the iterator.
editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): (WebCore::VisiblePosition::previous):
editing/VisiblePosition.h: Added a parameter to next/previous to prevent them from going outside the current editable region.
editing/htmlediting.cpp: (WebCore::highestAncestor): (WebCore::enclosingList): (WebCore::enclosingListChild): (WebCore::outermostEnclosingList): (WebCore::createListItemElement):
editing/htmlediting.h:
page/Frame.cpp: (WebCore::Frame::selectionListState): Added.
page/Frame.h:

WebKit:

Reviewed by levi

<http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
Implement execCommand(Insert{Un}OrderedList)

WebView/WebFrame.m: (-[WebFrame _findFrameWithSelection]): Removed an assertion that we only have one frame with a selection.
WebView/WebView.m: (-[WebView selectedFrame]): Ditto.

6:06 PM Changeset in webkit [14776] by thatcher

2 edits
2 adds in trunk/WebKitSite

Reviewed by Darin.

Include our own copies of the BSD and LGPL licenses.

coding/bsd-license.html: Added.
coding/lgpl-license.html: Added.
nav.inc: link to our copies of the licenses

3:10 PM Changeset in webkit [14775] by harrison

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Geoff and John.

<rdar://problem/4558879> -[DOMCSSPrimitiveValue setStringValue:] throws an exception (12)

fast/dom/setPrimitiveValue-expected.checksum: Added.
fast/dom/setPrimitiveValue-expected.png: Added.
fast/dom/setPrimitiveValue-expected.txt: Added.
fast/dom/setPrimitiveValue.html: Added.

WebCore:

Reviewed by Geoff and John.

<rdar://problem/4558879> -[DOMCSSPrimitiveValue setStringValue:] throws an exception (12)

Problem was the primitive value was getting reset to a generic state before the parameter
check that relies on that state.

Test: fast/dom/setPrimitiveValue.html

css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::setFloatValue): (WebCore::CSSPrimitiveValue::setStringValue): Move parameter checks ahead of call to cleanup().

2:38 PM Changeset in webkit [14774] by aliceli1

4 adds in trunk/LayoutTests/fast/dom/Range

added tests for Range.isPointInRange and Range.comparePoint

2:35 PM Changeset in webkit [14773] by aliceli1

4 edits in trunk/WebCore

Reviewed by Justin.

fixed <rdar://problem/4578115> support Range.isPointInRange
fixed <rdar://problem/4578123> support Range.comparePoint

dom/Range.cpp: (WebCore::Range::isPointInRange): added implementation (WebCore::Range::comparePoint): added implementation
dom/Range.h: added prototypes
dom/Range.idl: added bindings

2:20 PM Changeset in webkit [14772] by thatcher

1 edit in trunk/WebKit/WebView/WebView.m

Build fix.

2:05 PM Changeset in webkit [14771] by thatcher

6 edits in trunk/WebKit

Reviewed by Darin and John.

<rdar://problem/3600734> API: please add a way to turn vertical scrollbar
always on (for Mail, to avoid reflow when typing)

Adds new methods to lock the scrolling mode on WebDynamicScrollBarsView.
Locking the scroll mode prevents WebCore from changing it as needed.
Also adds an SPI on WebView that will lock the "always on" mode
for each scroller.

WebKit.xcodeproj/project.pbxproj:
WebView/WebDynamicScrollBarsView.h:
WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView setAllowsScrolling:]): (-[WebDynamicScrollBarsView allowsScrolling]): (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): (-[WebDynamicScrollBarsView setScrollingMode:]): (-[WebDynamicScrollBarsView setHorizontalScrollingModeLocked:]): (-[WebDynamicScrollBarsView setVerticalScrollingModeLocked:]): (-[WebDynamicScrollBarsView setScrollingModesLocked:]): (-[WebDynamicScrollBarsView horizontalScrollingModeLocked]): (-[WebDynamicScrollBarsView verticalScrollingModeLocked]):
WebView/WebView.m: (-[WebView setAlwaysShowVerticalScroller:]): (-[WebView alwaysShowVerticalScroller]): (-[WebView setAlwaysShowHorizontalScroller:]): (-[WebView alwaysShowHorizontalScroller]):
WebView/WebViewPrivate.h:

9:43 AM Changeset in webkit [14770] by darin

6 edits in trunk

WebCore:

Reviewed by Justin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8616 REGRESSION: TinyMCE: Crash on Undo

bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getInnerNonSharedNode:innerNode:URLElement:atPoint:allowShadowContent:]): Changed to call nodeInfoAtPoint directly. (-[WebCoreFrameBridge _visiblePositionForPoint:]): Changed to call nodeInfoAtPoint directly. Also added code to convert coordinates so it works for points that are in nodes in subframes.

page/Frame.cpp: (WebCore::Frame::setMark): Added assertions to catch if we attempt to set selection endpoints in another document. (WebCore::Frame::setSelection): Ditto.

WebKit:

Reviewed by Justin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8616 REGRESSION: TinyMCE: Crash on Undo

WebView/WebHTMLView.m: (-[WebHTMLView _topHTMLView]): Added. (-[WebHTMLView _isTopHTMLView]): Added. (-[WebHTMLView _insideAnotherHTMLView]): Changed to use _topHTMLView. (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Forward to the top HTML view, so that only the top view ever starts a dragging operation. Change dragging code to not assume that the dragged node is in the current view's document. Added checks that the node is an element in a couple places and coordinate conversions. (-[WebHTMLView _mayStartDragAtEventLocation:]): Forward to the top HTML view. (-[NSArray addMouseMovedObserver]): Change to do nothing when the dataSource field is 0, since we now use the dataSource field to get to the WebView. (-[NSArray removeMouseMovedObserver]): Added a comment. (-[NSArray dragImage:at:offset:event:pasteboard:source:slideBack:]): Forward to the top HTML view. (-[NSArray draggingSourceOperationMaskForLocal:]): Assert that it's the top HTML view. (-[NSArray draggedImage:movedTo:]): Ditto. (-[NSArray draggedImage:endedAt:operation:]): Ditto. (-[NSArray namesOfPromisedFilesDroppedAtDestination:]): Ditto. (-[NSArray _canProcessDragWithDraggingInfo:]): Ditto. (-[NSArray _isMoveDrag]): Ditto. (-[NSArray draggingUpdatedWithDraggingInfo:actionMask:]): Ditto. (-[NSArray draggingCancelledWithDraggingInfo:]): Ditto. (-[NSArray concludeDragForDraggingInfo:actionMask:]): Ditto. Also added code to work with the appropriate bridge when receiving a drag. This fixes the problem where the top level frame got a selection intended for the inner frame; the source of the bug. (-[NSArray elementAtPoint:allowShadowContent:]): Added code to convert the coordinates so this works properly when returning an element from an inner frame. (-[NSArray setDataSource:]): Added a call to addMouseMovedObserver, needed now that addMouseMovedObserver won't do anything if called when dataSource is nil. (-[WebHTMLView _delegateDragSourceActionMask]): Forward to the top HTML view.

WebView/WebView.m: (-[WebViewPrivate dealloc]): Removed code to release dragCaretBridge since that field is now gone. (-[WebView moveDragCaretToPoint:]): Always call the main frame's bridge, since the drag caret is now a page-level item. Later we'll move it to the page bridge. (-[WebView removeDragCaret]): Ditto.

9:36 AM Changeset in webkit [14769] by darin

1 edit in trunk/LayoutTests/ChangeLog

Added change log entry that I apparently forgot.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed