Context Navigation

Adds a native toolbar to Drosera to be a good citizen.
Adds a Debug menu with key-commands for Continue, Pause and Step Into.
Fixes a dragging bug from an earlier fix to the divider code.
Fixes some poor indenting in debugger.js.

Drosera/DebuggerDocument.h:
Drosera/DebuggerDocument.m: (-[DebuggerDocument stepInto]): (-[DebuggerDocument pause:]): (-[DebuggerDocument resume:]): (-[DebuggerDocument stepInto:]): (-[DebuggerDocument windowDidLoad]): (-[DebuggerDocument toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): (-[DebuggerDocument toolbarDefaultItemIdentifiers:]): (-[DebuggerDocument toolbarAllowedItemIdentifiers:]): (-[DebuggerDocument validateUserInterfaceItem:]):
Drosera/English.lproj/MainMenu.nib/classes.nib:
Drosera/English.lproj/MainMenu.nib/info.nib:
Drosera/English.lproj/MainMenu.nib/keyedobjects.nib:
Drosera/debugger.css:
Drosera/debugger.html:
Drosera/debugger.js:
Drosera/viewer.html:

9:07 PM Changeset in webkit [14983] by ddkilzer

9 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt. Patch by Mitz.

test and updated results for http://bugzilla.opendarwin.org/show_bug.cgi?id=9497 REGRESSION: Incomplete repainting when scrolling thumbnails on Flickr

fast/repaint/clipped-relative-expected.checksum: Added.
fast/repaint/clipped-relative-expected.png: Added.
fast/repaint/clipped-relative-expected.txt: Added.
fast/repaint/clipped-relative.html: Added.
fast/repaint/containing-block-position-change-expected.checksum: Updated.
fast/repaint/containing-block-position-change-expected.png: Updated.

WebCore:

Reviewed by Hyatt. Patch by Mitz.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9497 REGRESSION: Incomplete repainting when scrolling thumbnails on Flickr

Test: fast/repaint/clipped-relative.html

page/FrameView.cpp: (WebCore::FrameView::layout):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::removePositionedObjects): Removed call to computeRepaintRects(). Previously, it was needed to update the cached rects before RenderBox::setStyle() called updateLayerPositions().
rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): Changed to call updateLayerPositions() for a newly- created layer only if it does not need layout. Otherwise, updateLayerPositions() will be called after layout. This saves a repaint in some cases.
rendering/RenderLayer.cpp: (WebCore::RenderLayer::checkForRepaintOnResize): Renamed computeRepaintRects() to this and deleted the code that cached the absolute position and repaint rects. (WebCore::RenderLayer::updateLayerPositions): Added code to cache the absolute position and repaint rects right after updating the layer's position.
rendering/RenderLayer.h:

7:25 PM Changeset in webkit [14982] by thatcher

2 edits in trunk/WebKitTools/Drosera

Adding an image that wasn't added to the project earlier.

7:00 PM Changeset in webkit [14981] by bdakin

2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4599015> REGRESSION: Hand on clock widget
don't appear at all

This regression was caused by <rdar://problem/4567520> HIDPI: pixel
cracks in weather widget at 1.83 scaling

html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): Do the contains check before rounding to integral device pixels.

4:12 PM Changeset in webkit [14980] by andersca

3 edits
2 adds in trunk

WebCore:

2006-06-22 Anders Carlsson <acarlsson@apple.com>

Reviewed by John.

<rdar://problem/4529334> REGRESSION: Can't configure RadarInMotion widget for U.S. locations on Leopard (Javascript errors)

dom/Document.cpp: (WebCore::Document::completeURL): Check if both the URL and base URL are empty instead of using URL() which returns "about:blank" if the URL is empty.

LayoutTests:

2006-06-22 Anders Carlsson <acarlsson@apple.com>

Reviewed by John.

<rdar://problem/4529334> REGRESSION: Can't configure RadarInMotion widget for U.S. locations on Leopard (Javascript errors)

dom/Document.cpp: (WebCore::Document::completeURL): Check if both the URL and base URL are empty instead of using URL() which returns "about:blank" if the URL is empty.

2:31 PM Changeset in webkit [14979] by tomernic

2 edits in trunk/WebKit

Reviewed by NOBODY (build fix)

WebView/WebFrameLoader.m: Import WebMainResourceLoader instead of using @class so that we can call WebMainResourceLoader methods.

2:10 PM Changeset in webkit [14978] by thatcher

8 edits in /

Versioning

12:01 PM Changeset in webkit [14977] by tomernic

2 edits in trunk/WebKit

Reviewed by NOBODY (build fix)

WebView/WebFrameLoader.m: Import JavaScriptCore/Assertions.h instead of WebKit/WebAssertions.h (which no longer exists)

11:48 AM Changeset in webkit [14976] by mjs

5 edits
2 adds in trunk/WebKit

Reviewed by Adele.

start moving loading logic to new WebFrameLoader class; move management of WebLoaders there

Misc/WebIconLoader.h:
Misc/WebIconLoader.m: (-[WebIconLoader didFinishLoading]):
WebKit.xcodeproj/project.pbxproj:
WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _updateLoading]): (-[WebDataSource _loadIcon]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _stopLoading]): (-[WebDataSource _startLoading]): (-[WebDataSource _addSubresourceLoader:]): (-[WebDataSource _removeSubresourceLoader:]): (-[WebDataSource _addPlugInStreamLoader:]): (-[WebDataSource _removePlugInStreamLoader:]): (-[WebDataSource _iconLoaderReceivedPageIcon:]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _stopLoadingWithError:]): (-[WebDataSource _setupForReplaceByMIMEType:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource dealloc]): (-[WebDataSource finalize]): (-[WebDataSource data]): (-[WebDataSource isLoading]):
WebView/WebFrameLoader.h: Added.
WebView/WebFrameLoader.m: Added. (-[WebFrameLoader initWithDataSource:]): (-[WebFrameLoader dealloc]): (-[WebFrameLoader hasIconLoader]): (-[WebFrameLoader loadIconWithRequest:]): (-[WebFrameLoader stopLoadingIcon]): (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoadingPlugIns]): (-[WebFrameLoader isLoadingMainResource]): (-[WebFrameLoader isLoadingSubresources]): (-[WebFrameLoader isLoading]): (-[WebFrameLoader stopLoadingSubresources]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader mainResourceData]): (-[WebFrameLoader releaseMainResourceLoader]): (-[WebFrameLoader cancelMainResourceLoad]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader stopLoadingWithError:]):

11:34 AM Changeset in webkit [14975] by andersca

3 edits
2 adds in trunk

WebCore:

2006-06-22 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4499675> Package Tracker widget always crashes in WebCore::Frame::jScriptEnabled() const + 0

html/HTMLParser.cpp: (WebCore::HTMLParser::noscriptCreateErrorCheck): (WebCore::HTMLParser::canvasCreateErrorCheck): (WebCore::HTMLParser::isInline): Add null-checks for document->frame() since it can be 0 for documents created using createHTMLDocument.

LayoutTests:

2006-06-22 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4499675> Package Tracker widget always crashes in WebCore::Frame::jScriptEnabled() const + 0

fast/dom/noscript-canvas-in-created-html-document-expected.txt: Added.
fast/dom/noscript-canvas-in-created-html-document.html: Added.

10:48 AM Changeset in webkit [14974] by kdecker

3 edits
1 add in trunk/WebKitTools

10:46 AM Changeset in webkit [14973] by andersca

6 edits
4 adds in trunk

WebCore:

2006-06-22 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4524840> Entities contained in DOCTYPE referenced DTD in XSLT source document are unknown

dom/xml_tokenizer.cpp: (WebCore::shouldAllowExternalLoad): Use correct path for the catalog.

(WebCore::errorFunc):
Add error function to keep parser errors from going to the console.

(WebCore::XMLTokenizer::write):
Remove if (0 &&)

(WebCore::XMLTokenizer::end):
Pass DocLoader to xmlDocPtrForString.

(WebCore::xmlDocPtrForString):

dom/xml_tokenizer.h: Add DocLoader argument to xmlDocPtrForString so external DTDs and entities can be loaded.

xml/XSLTProcessor.cpp: (WebCore::xmlDocPtrFromNode): Pass DocLoader to xmlDocPtrForString

LayoutTests:

2006-06-22 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4524840> Entities contained in DOCTYPE referenced DTD in XSLT source document are unknown

fast/xsl/dtd-in-source-document-expected.txt: Added.
fast/xsl/dtd-in-source-document.xml: Added.
fast/xsl/resources/dtd-in-source-document.dtd: Added.
fast/xsl/resources/dtd-in-source-document.xsl: Added.

10:34 AM Changeset in webkit [14972] by thatcher

8 edits in trunk/WebKitTools

Reviewed by Kevin Decker.

Code clean up. Adds the stackframe and makes only the body
of the tables scrollable keeping the header visible.
Shows the current function stack when paused or stepping.

Drosera/DebuggerApplication.m: (-[DebuggerApplication awakeFromNib]): (-[DebuggerApplication numberOfRowsInTableView:]): (-[DebuggerApplication tableView:objectValueForTableColumn:row:]):
Drosera/DebuggerDocument.h:
Drosera/DebuggerDocument.m: (-[DebuggerDocument dealloc]): (-[DebuggerDocument currentFrame]): (-[DebuggerDocument currentFrameFunctionName]): (-[DebuggerDocument currentFunctionStack]): (-[DebuggerDocument log:]): (-[DebuggerDocument windowWillClose:]): (-[DebuggerDocument webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[DebuggerDocument webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
Drosera/Drosera.xcodeproj/project.pbxproj:
Drosera/debugger.css:
Drosera/debugger.html:
Drosera/debugger.js:

10:18 AM Changeset in webkit [14971] by ap

2 edits in trunk/WebKitTools

Reviewed by Anders.

Teach run-webkit-httpd to properly look for webkitdirs.pm.

Scripts/run-webkit-httpd:

8:01 AM Changeset in webkit [14970] by kdecker

5 edits
5 adds in trunk/WebKitTools

3:38 AM Changeset in webkit [14969] by ddkilzer

2 edits in trunk/JavaScriptCore

JavaScriptCore:

Build fix.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9539
Another case error preventing build

API/APICast.h: Changed "UString.h" to "ustring.h".

Jun 21, 2006:

5:58 PM Changeset in webkit [14968] by hyatt

5 edits in trunk/WebCore

Back out -webkit-overlay and just rename it back to overlay.

Reviewed by darin

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSValueKeywords.in:
css/cssparser.cpp: (WebCore::CSSParser::parseValue):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):

5:26 PM Changeset in webkit [14967] by thatcher

1 copy in tags/WebCore-315.14.3/WebCore

Tag for WebCore 315.14.3 (part 2 of 2.)

5:26 PM Changeset in webkit [14966] by thatcher

1 add in tags/WebCore-315.14.3

Tag for WebCore 315.14.3 (part 1 of 2.)

5:26 PM Changeset in webkit [14965] by thatcher

2 edits in branches/Safari-1-3-branch/WebCore

Versioning

5:22 PM Changeset in webkit [14964] by thatcher

1 copy in tags/WebCore-418.19.1/WebCore

Tag for WebCore 418.19.1 (part 2 of 2.)

5:22 PM Changeset in webkit [14963] by thatcher

1 add in tags/WebCore-418.19.1

Tag for WebCore 418.19.1 (part 1 of 2.)

5:20 PM Changeset in webkit [14962] by justing

4 edits
12 adds in trunk

LayoutTests:

Reviewed by levi

editing/deleting/table-cells-expected.checksum: Added.
editing/deleting/table-cells-expected.png: Added.
editing/deleting/table-cells-expected.txt: Added.
editing/deleting/table-cells.html: Added.
editing/inserting/paragraph-separator-in-table-1-expected.checksum: Added.
editing/inserting/paragraph-separator-in-table-1-expected.png: Added.
editing/inserting/paragraph-separator-in-table-1-expected.txt: Added.
editing/inserting/paragraph-separator-in-table-1.html: Added.
editing/inserting/paragraph-separator-in-table-2-expected.checksum: Added.
editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
editing/inserting/paragraph-separator-in-table-2-expected.txt: Added.
editing/inserting/paragraph-separator-in-table-2.html: Added.

WebCore:

Reviewed by levi

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): Fix a bug in the code to stop merges across table cells. (WebCore::DeleteSelectionCommand::mergeParagraphs): Move the code to stop merges across table cells to initializePositionData so that its changes to m_mergeBlocksAfterDelete can take effect on the endingPosition.
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Turn into an InsertLineBreak instead of splitting/cloning a table cell.

5:13 PM Changeset in webkit [14961] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Versioning

5:00 PM Changeset in webkit [14960] by thatcher

2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This fixes <rdar://problem/4571273> WebCore crash in khtml::RenderObject::getAbsoluteRepaintRectWithOutline

2005-10-21 Beth Dakin <Beth Dakin>

Reviewed by Hyatt

Fix for <rdar://problem/3947202> certain sequence of DOM
method calls involving CSS outline and display crashes Safari
(in repaint code).

khtml/rendering/render_flow.cpp: (RenderFlow::destroy): Need to set m_continuation to 0 after it is destroyed to prevent possible crashes.

4:50 PM Changeset in webkit [14959] by hyatt

4 adds in trunk/LayoutTests/fast/overflow

Add overflow-x and overflow-y tests.

4:40 PM Changeset in webkit [14958] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This fixes <rdar://problem/4571273> WebCore crash in khtml::RenderObject::getAbsoluteRepaintRectWithOutline

2005-10-21 Beth Dakin <Beth Dakin>

Reviewed by Hyatt

Fix for <rdar://problem/3947202> certain sequence of DOM
method calls involving CSS outline and display crashes Safari
(in repaint code).

khtml/rendering/render_flow.cpp: (RenderFlow::destroy): Need to set m_continuation to 0 after it is destroyed to prevent possible crashes.

4:38 PM Changeset in webkit [14957] by bdakin

3 edits in trunk/WebCore

Reviewed by John.

Fix for <rdar://problem/3914965> Misspelled text underline doesn't
look right at non-standard scale factors

platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspelling): We need to call into our previously-created SPI for pattern-drawing so that the phase is right at all scale factors.

4:15 PM Changeset in webkit [14956] by thatcher

4 edits in trunk

Switching to Stabs debugging format for Production builds.

4:13 PM Changeset in webkit [14955] by beidson

2 edits in trunk/WebKit

Reviewed by Maciej

The WebCoreIconDatabaseBridge was getting messages sent to it after it had been closed, resulting in a crash
on an ASSERT(). After closing the databaseBridge, we simply set it to nil so this can't happen.
anymore.

Misc/WebIconDatabase.m: (-[WebIconDatabase _applicationWillTerminate:]):

4:10 PM Changeset in webkit [14954] by ggaren

4 edits in trunk/JavaScriptCore

Fixed release build, fixed accidental infinite recursion due to
last minute global replace gone awry.

API/APICast.h: (toRef):
API/testapi.c: (assertEqualsAsBoolean): (assertEqualsAsNumber): (assertEqualsAsUTF8String): (assertEqualsAsCharactersPtr):
JavaScriptCore.xcodeproj/project.pbxproj:

3:45 PM Changeset in webkit [14953] by hyatt

18 edits in trunk/WebCore

Fix for 7362, implement the CSS3 overflow-x and overflow-y properties.

Reviewed by adele

WebCore.xcodeproj/project.pbxproj:
css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSPropertyNames.in:
css/cssparser.cpp: (WebCore::CSSParser::parseValue):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty):
page/FrameView.cpp: (WebCore::FrameView::applyOverflowToViewport): (WebCore::FrameView::layout):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::determineHorizontalPosition): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::rightOffset): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::calcMinMaxWidth):
rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::contentWidth): (WebCore::RenderBox::contentHeight): (WebCore::RenderBox::sizesToIntrinsicWidth): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcPercentageHeight):
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::shouldAutoscroll): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::RenderLayer::styleChanged):
rendering/RenderLayer.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::clientWidth): (WebCore::RenderObject::clientHeight):
rendering/RenderObject.h: (WebCore::RenderObject::hasAutoVerticalScrollbar): (WebCore::RenderObject::hasAutoHorizontalScrollbar): (WebCore::RenderObject::scrollsOverflow): (WebCore::RenderObject::scrollsOverflowX): (WebCore::RenderObject::scrollsOverflowY): (WebCore::RenderObject::includeVerticalScrollbarSize): (WebCore::RenderObject::includeHorizontalScrollbarSize):
rendering/RenderTextArea.cpp: (WebCore::RenderTextArea::setStyle):
rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): (WebCore::RenderTextField::calcHeight): (WebCore::RenderTextField::calcMinMaxWidth):
rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
rendering/render_style.cpp: (WebCore::RenderStyle::diff):
rendering/render_style.h: (WebCore::): (WebCore::RenderStyle::NonInheritedFlags::operator==): (WebCore::RenderStyle::setBitDefaults): (WebCore::RenderStyle::overflowX): (WebCore::RenderStyle::overflowY): (WebCore::RenderStyle::setOverflowX): (WebCore::RenderStyle::setOverflowY): (WebCore::RenderStyle::initialOverflowX): (WebCore::RenderStyle::initialOverflowY):

2:22 PM Changeset in webkit [14952] by justing

37 edits
9 adds
1 delete in trunk

LayoutTests:

Reviewed by levi

<rdar://problem/4590366>
REGRESSION: Selection incorrectly paints gaps on TOT

Added:

editing/selection/line-wrap-1-expected.checksum: Added.
editing/selection/line-wrap-1-expected.png: Added.
editing/selection/line-wrap-1-expected.txt: Added.
editing/selection/line-wrap-1.html: Added.
editing/selection/line-wrap-2-expected.checksum: Added.
editing/selection/line-wrap-2-expected.png: Added.
editing/selection/line-wrap-2-expected.txt: Added.
editing/selection/line-wrap-2.html: Added. Fixes:
editing/execCommand/findString-expected.checksum:
editing/execCommand/findString-expected.png:
editing/execCommand/findString-expected.txt:
editing/inserting/editing-empty-divs-expected.checksum:
editing/inserting/editing-empty-divs-expected.png:
editing/inserting/editing-empty-divs-expected.txt:
editing/inserting/insert-3659587-fix-expected.txt:
editing/inserting/insert-tab-002-expected.txt:
editing/inserting/insert-text-with-newlines-expected.txt:
editing/inserting/typing-001-expected.txt:
editing/inserting/typing-003-expected.txt:
editing/inserting/typing-around-br-001-expected.txt:
editing/style/remove-underline-across-paragraph-expected.txt:
editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
editing/style/remove-underline-after-paragraph-expected.txt:
editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
editing/style/remove-underline-expected.txt:
editing/style/remove-underline-from-stylesheet-expected.txt:
editing/style/remove-underline-in-bold-expected.txt:
editing/style/typing-style-002-expected.txt:
editing/style/typing-style-003-expected.txt:
editing/style/unbold-in-bold-expected.txt:
editing/style/underline-expected.txt: Disabled (9337):
editing/input/attributed-substring-from-range-lines.html

WebCore:

Reviewed by levi

<rdar://problem/4590366>
REGRESSION: Selection incorrectly paints gaps on TOT

dom/Document.cpp: (WebCore::Document::updateSelection): Use the leftmost candidate for the end of the selection and the rightmost candidate for the start of the selection.
dom/Position.cpp: (WebCore::Position::upstream): Cross line wraps so that we can use upstream/downstream to get to candidates before/after linewraps. (WebCore::Position::downstream): (WebCore::Position::inRenderedContent):
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): (WebCore::DeleteSelectionCommand::mergeParagraphs):
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Ensure that the leftmost candidate is used. We should sample the style from that one. When the block to insert is after a br, a br should be inserted even in strict mode.
editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Insert at the leftmost candidate, get rid of a use of trailingWhitespacePosition. Don't apply a style if its unnecessary.
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): "pos" can be invalidated, don't use it.
editing/VisiblePosition.cpp: Renamed initDeepPosition and made it return the canonical position. (WebCore::VisiblePosition::init): (WebCore::VisiblePosition::canonicalPosition):
editing/VisiblePosition.h: (WebCore::VisiblePosition::characterBefore): Added.
editing/visible_units.cpp: (WebCore::startOfParagraph):
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionState): When a selection ends at a line wrap, it shouldn't extend onto the next line.

2:09 PM Changeset in webkit [14951] by ggaren

20 edits
19 adds in trunk

JavaScriptCore:

Reviewed by Anders.

First cut at C API to JavaScript. Includes a unit test, 'testapi.c', and the outline of a test app, 'minidom.c'.

Includes one change to JSC internals: Rename propList to getPropertyList and have it
take its target property list by reference so that subclasses can
add properties to the list before calling through to their superclasses.

Also, I just ran prepare-ChangeLog in about 10 seconds, and I would like
to give a shout-out to that.

API/APICast.h: Added. (toJS): (toRef):
API/JSBase.h: Added.
API/JSCallbackObject.cpp: Added. (KJS::): (KJS::JSCallbackObject::JSCallbackObject): (KJS::JSCallbackObject::~JSCallbackObject): (KJS::JSCallbackObject::className): (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::implementsConstruct): (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::implementsCall): (KJS::JSCallbackObject::callAsFunction): (KJS::JSCallbackObject::getPropertyList): (KJS::JSCallbackObject::toBoolean): (KJS::JSCallbackObject::toNumber): (KJS::JSCallbackObject::toString): (KJS::JSCallbackObject::setPrivate): (KJS::JSCallbackObject::getPrivate): (KJS::JSCallbackObject::cachedValueGetter): (KJS::JSCallbackObject::callbackGetter):
API/JSCallbackObject.h: Added. (KJS::JSCallbackObject::classInfo):
API/JSCharBufferRef.cpp: Added. (JSStringMake): (JSCharBufferCreate): (JSCharBufferCreateUTF8): (JSCharBufferRetain): (JSCharBufferRelease): (JSValueCopyStringValue): (JSCharBufferGetLength): (JSCharBufferGetCharactersPtr): (JSCharBufferGetCharacters): (JSCharBufferGetMaxLengthUTF8): (JSCharBufferGetCharactersUTF8): (JSCharBufferIsEqual): (JSCharBufferIsEqualUTF8): (JSCharBufferCreateWithCFString): (CFStringCreateWithJSCharBuffer):
API/JSCharBufferRef.h: Added.
API/JSContextRef.cpp: Added. (JSContextCreate): (JSContextDestroy): (JSContextGetGlobalObject): (JSEvaluate): (JSCheckSyntax): (JSContextHasException): (JSContextGetException): (JSContextClearException): (JSContextSetException):
API/JSContextRef.h: Added.
API/JSObjectRef.cpp: Added. (JSValueToObject): (JSObjectMake): (JSFunctionMake): (JSObjectGetDescription): (JSObjectGetPrototype): (JSObjectSetPrototype): (JSObjectHasProperty): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectDeleteProperty): (JSObjectGetPrivate): (JSObjectSetPrivate): (JSObjectIsFunction): (JSObjectCallAsFunction): (JSObjectIsConstructor): (JSObjectCallAsConstructor): (JSPropertyListEnumerator::JSPropertyListEnumerator): (JSObjectCreatePropertyEnumerator): (JSPropertyEnumeratorGetNext): (JSPropertyEnumeratorRetain): (JSPropertyEnumeratorRelease): (JSPropertyListAdd):
API/JSObjectRef.h: Added.
API/JSValueRef.cpp: Added. (JSValueGetType): (JSValueIsUndefined): (JSValueIsNull): (JSValueIsBoolean): (JSValueIsNumber): (JSValueIsString): (JSValueIsObject): (JSValueIsEqual): (JSValueIsStrictEqual): (JSUndefinedMake): (JSNullMake): (JSBooleanMake): (JSNumberMake): (JSValueToBoolean): (JSValueToNumber): (JSGCProtect): (JSGCUnprotect): (JSGCCollect):
API/JSValueRef.h: Added.
API/JavaScriptCore.h: Added.
API/minidom.c: Added. (main):
API/minidom.html: Added.
API/minidom.js: Added.
API/testapi.c: Added. (assertEqualsAsBoolean): (assertEqualsAsNumber): (assertEqualsAsUTF8String): (assertEqualsAsCharactersPtr): (assertEqualsAsCharacters): (MyObject_initialize): (MyObject_copyDescription): (MyObject_hasProperty): (MyObject_getProperty): (MyObject_setProperty): (MyObject_deleteProperty): (MyObject_getPropertyList): (MyObject_callAsFunction): (MyObject_callAsConstructor): (MyObject_convertToType): (MyObject_finalize): (print_callAsFunction): (main): (createStringWithContentsOfFile):
API/testapi.js: Added.
ChangeLog:
JavaScriptCore.xcodeproj/project.pbxproj:
bindings/npruntime_impl.h:
kjs/array_instance.h:
kjs/array_object.cpp: (ArrayInstance::getPropertyList):
kjs/interpreter.cpp: (KJS::Interpreter::evaluate):
kjs/nodes.cpp: (ForInNode::execute):
kjs/object.cpp: (KJS::JSObject::put): (KJS::JSObject::canPut): (KJS::JSObject::deleteProperty): (KJS::JSObject::propertyIsEnumerable): (KJS::JSObject::getPropertyAttributes): (KJS::JSObject::getPropertyList):
kjs/object.h:
kjs/property_map.cpp: (KJS::PropertyMap::get):
kjs/property_map.h:
kjs/scope_chain.cpp: (KJS::ScopeChain::print):
kjs/string_object.cpp: (StringInstance::getPropertyList):
kjs/string_object.h:
kjs/ustring.h: (KJS::UString::Rep::ref):

JavaScriptGlue:

Reviewed by Anders.

Required for JS API: Rename propList to getPropertyList and have it take its target property list by reference so that subclasses can add properties to the list before calling through to their superclasses.

JSUtils.cpp: (KJSValueToCFTypeInternal):
JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames):
UserObjectImp.cpp: (UserObjectImp::getPropertyList):
UserObjectImp.h:

1:46 PM Changeset in webkit [14950] by bdakin

1 edit in trunk/WebCore/ChangeLog

Fixing ChangeLog.

1:44 PM Changeset in webkit [14949] by bdakin

2 edits in trunk/WebCore

Reviewed and committed by Beth.

Fix for <rdar://problem/4595337> Resizing a containing block
strictly vertically does not cause contained height:100% element to
also be resized.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Also layout if the child's min or max height is a percent.

1:35 PM Changeset in webkit [14948] by andersca

9 edits
3 adds in trunk

WebCore:

2006-06-21 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

http://bugzilla.opendarwin.org/show_bug.cgi?id=6058
XMLTokenizer runs all <script> tags at once instead of as they're encountered

dom/xml_tokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer): Initialize new members.

(WebCore::XMLTokenizer::endElementNs):
If we've encountered a script tag, execute the script here. If the script
tag refers to an external resource, pause the parser while loading it.

(WebCore::XMLTokenizer::end):
Move code from finish() to here

(WebCore::XMLTokenizer::finish):
Only call end() if the parser isn't paused.

(WebCore::XMLTokenizer::notifyFinished):
Evaluate the script here and resume the parser.

(WebCore::XMLTokenizer::resumeParsing):
If finish() was called, call end() after writing all data.

LayoutTests:

2006-06-21 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

http://bugzilla.opendarwin.org/show_bug.cgi?id=6058
XMLTokenizer runs all <script> tags at once instead of as they're encountered

dom/svg/level3/xpath/svgunit.js: The XPath tests depend on the document being loaded before running the tests. Add a "load" event listener and run the test in the handler.

fast/canvas/quadraticCurveTo.xml: Add onload handler and run tests there.

fast/innerHTML/004-expected.txt:
fast/innerHTML/004.xhtml: Add load event listener and run test there.

fast/parser/external-entities-expected.txt: This now dumps as text because the script is ran before the parse error is encountered.

fast/parser/resources/xhtml-scripts.js: Added.
fast/parser/xhtml-scripts-expected.txt: Added.
fast/parser/xhtml-scripts.xhtml: Added. Add new tests.

svg/custom/text-hit-test.svg: Run test in onload handler.

12:29 PM Changeset in webkit [14947] by tomernic

9 edits in trunk/WebKit

Reviewed by Geoff Garen.

<rdar://problem/4564131> WebPluginDatabase setAdditionalWebPlugInPaths needs to be per WebView

Added some WebView SPI so that individual WebViews may have different plugin search paths. There are some
limitations with the approach taken here:

JavaScript may only access the global plugin DB.
When this SPI is in use, certain WebView methods may not give accurate results, such as +canShowMIMEType:.
This only works for plugins referenced using the <object> or <embed> tags; plugins that reside in non-standard file system locations may not be loaded directly into frames.

None of these issues are important to the client that needs this SPI. Rather than re-architect our entire
plugin database, I think it is better to simply accept these limitations for now.

Plugins/WebPluginDatabase.h: Added "plugInPaths" ivar, so different plugin databases can have different search paths.
Plugins/WebPluginDatabase.m: (+[WebPluginDatabase installedPlugins]): Give the global plugin database the default plugin search paths. (+[WebPluginDatabase setAdditionalWebPlugInPaths:]): Removed static global; this method now sets the plugin paths on the global plugin database. (-[WebPluginDatabase setPlugInPaths:]): Setter method for plugin paths. (-[WebPluginDatabase close]): New method; called when the plugin database is no longer needed (when its WebView is being destroyed). (-[WebPluginDatabase init]): Don't refresh in -init, so that callers can set the DB's plugin path array before it refreshes. (-[WebPluginDatabase dealloc]): Moved here from near the bottom of the file. Release new ivar. (-[WebPluginDatabase refresh]): Use the plugInPaths ivar instead of calling pluginLocations(). Notify plugin packages when they are added to and removed from a plugin database. A plugin package will unload itself when it is removed from all of its plugin databases. The only really tricky thing here is that the global MIME <-> view class registrations are only modified by the shared plugin DB. (+[WebPluginDatabase _defaultPlugInPaths]): Refactored from the old pluginLocations() function; returns the default set of plugin search paths.

Plugins/WebBasePluginPackage.h:
Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage dealloc]): Assert that this package has been removed from all of its containing plugin databases. (-[WebBasePluginPackage finalize]): ditto (-[WebBasePluginPackage wasAddedToPluginDatabase:]): Add plugin database to set. (-[WebBasePluginPackage wasRemovedFromPluginDatabase:]): Remove plugin database from set. If it was the last DB, then unload the plugin package.

WebView/WebViewInternal.h: Added instance methods to find the view class or plugin package, given a MIME type or file extension.
WebView/WebViewPrivate.h: Added SPI to set plugin search paths per WebView.
WebView/WebView.m: (-[WebView _viewClass:andRepresentationClass:forMIMEType:]): New method; tries the global MIME <-> view map first; failing that, it checks the WebView's plugin DB. (-[WebView _close]): Close the plugin DB. (-[WebView _setAdditionalWebPlugInPaths:]): Create the plugin DB if necessary, and set its plugin paths. (-[WebView _pluginForMIMEType:]): Checks global plugin DB, falls back on WebView DB. (-[WebView _pluginForExtension:]): ditto (-[WebView _isMIMETypeRegisteredAsPlugin:]): ditto

WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]): Use new WebView instance methods to look for plugins. (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]): ditto (-[WebFrameBridge determineObjectFromMIMEType:URL:]): ditto

10:47 AM Changeset in webkit [14946] by sfalken

2 edits in trunk/WebCore

2006-06-21 Steve Falkenburg <sfalken@apple.com>

Fix build break

platform/win/TemporaryLinkStubs.cpp: (FrameWin::shouldInterruptJavaScript):

9:21 AM Changeset in webkit [14945] by ap

1 edit
1 add in trunk/WebKitTools

Reviewed by Anders.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9516 Would like a script to run a httpd server with the same configuration as run-webkit-tests http

Scripts/run-webkit-httpd: Added.

8:27 AM Changeset in webkit [14944] by andersca

2 edits in trunk/WebKitSite

2006-06-21 Joost de Valk <jdevalk@opendarwin.org>

Reviewed and landed by Anders.

blog/wp-content/themes/webkit/sidebar.php: Add link to Wiki in the navigation menu here too.

6:50 AM Changeset in webkit [14943] by andersca

2 edits in trunk/WebKitSite

2006-06-21 Joost de Valk <jdevalk@opendarwin.org>

Reviewed and landed by Anders.

nav.inc: Add link to Wiki in the navigation menu.

6:24 AM Changeset in webkit [14942] by andersca

3 edits in trunk/WebCore

2006-06-21 Anders Carlsson <acarlsson@apple.com>

Move FrameWin::shouldInterruptJavaScript to TemporaryLinkStubs.cpp

bridge/win/FrameWin.cpp:
platform/win/TemporaryLinkStubs.cpp: (FrameWin::shouldInterruptJavaScript):

1:40 AM Changeset in webkit [14941] by adele

4 edits in trunk/WebCore

Reviewed by Maciej.

Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=9523
More Win32 build bustage.

WebCore.vcproj/WebCore/WebCore.vcproj:
bridge/win/FrameWin.cpp: (WebCore::FrameWin::shouldInterruptJavaScript):
bridge/win/FrameWin.h:

12:45 AM Changeset in webkit [14940] by thatcher

7 edits
3 adds in trunk/WebKitTools

Reviewed by Eric.

Builds Drosera and a launcher to include with the nightly.

BuildSlaveSupport/build-launcher-app:
BuildSlaveSupport/build-launcher-dmg:
Drosera/Drosera.xcodeproj/project.pbxproj:
Drosera/Info.plist:
Drosera/LauncherInfo.plist: Added.
Drosera/launcher.m: Added. (displayErrorAndQuit): (checkMacOSXVersion): (myExecve): (main):
Scripts/build-drosera
WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
WebKitLauncher/main.m: (main):

12:27 AM Changeset in webkit [14939] by mjs

16 edits in trunk/LayoutTests

No review - updated results for earlier patch.

updated SVG test results where my recent fix affected bounding boxes

I think the new results are more accurate bounding boxes and in
any case there is no actual difference in rendered output.

svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
svg/custom/foreign-object-skew-expected.txt:
svg/custom/image-with-transform-clip-filter-expected.txt:
svg/custom/text-image-opacity-expected.txt:

12:27 AM Changeset in webkit [14938] by adele

4 edits in trunk/LayoutTests/dom

Updated results for: http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>

12:26 AM Changeset in webkit [14937] by adele

9 edits in trunk/LayoutTests/tables/mozilla/bugs

Updated results for: http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>

12:23 AM Changeset in webkit [14936] by adele

94 edits in trunk/LayoutTests

Reviewed by Anders.

Updated results for: http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>

Changes include some size differences since the new textareas have 4 pixels less horizontal padding,
and the renderer name for textareas has changed from RenderTextArea to RenderTextField.

dom/html/level2/html/HTMLTextAreaElement14-expected.txt:
dom/html/level2/html/HTMLTextAreaElement15-expected.txt:
dom/xhtml/level2/html/HTMLTextAreaElement14-expected.txt:
dom/xhtml/level2/html/HTMLTextAreaElement15-expected.txt:
fast/block/margin-collapse/103-expected.checksum:
fast/block/margin-collapse/103-expected.png:
fast/block/margin-collapse/103-expected.txt:
fast/dynamic/008-expected.checksum:
fast/dynamic/008-expected.png:
fast/dynamic/008-expected.txt:
fast/forms/001-expected.checksum:
fast/forms/002-expected.checksum:
fast/forms/003-expected.checksum:
fast/forms/004-expected.checksum:
fast/forms/005-expected.checksum:
fast/forms/006-expected.checksum:
fast/forms/007-expected.checksum:
fast/forms/8250-expected.checksum:
fast/forms/blankbuttons-expected.checksum:
fast/forms/button-cannot-be-nested-expected.checksum:
fast/forms/button-default-title-expected.checksum:
fast/forms/button-inner-block-reuse-expected.checksum:
fast/forms/button-positioned-expected.checksum:
fast/forms/button-sizes-expected.checksum:
fast/forms/button-table-styles-expected.checksum:
fast/forms/button-white-space-expected.checksum:
fast/forms/checkbox-radio-onchange-expected.checksum:
fast/forms/cursor-position-expected.txt:
fast/forms/double-focus-expected.txt:
fast/forms/file-input-disabled-expected.checksum:
fast/forms/form-element-geometry-expected.checksum:
fast/forms/form-element-geometry-expected.png:
fast/forms/form-element-geometry-expected.txt:
fast/forms/form-hides-table-expected.checksum:
fast/forms/formmove-expected.checksum:
fast/forms/formmove2-expected.checksum:
fast/forms/formmove3-expected.checksum:
fast/forms/indeterminate-expected.checksum:
fast/forms/input-appearance-bkcolor-expected.checksum:
fast/forms/input-appearance-default-bkcolor-expected.checksum:
fast/forms/input-appearance-disabled-expected.checksum:
fast/forms/input-appearance-focus-expected.checksum:
fast/forms/input-appearance-minWidth-expected.checksum:
fast/forms/input-appearance-preventDefault-expected.checksum:
fast/forms/input-appearance-readonly-expected.checksum:
fast/forms/input-appearance-selection-expected.checksum:
fast/forms/input-appearance-visibility-expected.checksum:
fast/forms/input-appearance-width-expected.checksum:
fast/forms/input-baseline-expected.checksum:
fast/forms/input-disabled-color-expected.checksum:
fast/forms/input-double-click-selection-gap-bug-expected.checksum:
fast/forms/input-maxlength-2-expected.checksum:
fast/forms/input-no-renderer-expected.checksum:
fast/forms/input-paste-undo-expected.checksum:
fast/forms/input-readonly-dimmed-expected.checksum:
fast/forms/input-readonly-empty-expected.checksum:
fast/forms/input-spaces-expected.checksum:
fast/forms/input-table-expected.checksum:
fast/forms/input-text-click-inside-expected.checksum:
fast/forms/input-text-click-outside-expected.checksum:
fast/forms/input-text-double-click-expected.checksum:
fast/forms/input-text-drag-down-expected.checksum:
fast/forms/input-text-maxlength-expected.checksum:
fast/forms/input-text-option-delete-expected.checksum:
fast/forms/input-text-paste-maxlength-expected.checksum:
fast/forms/input-text-scroll-left-on-blur-expected.checksum:
fast/forms/input-text-self-emptying-click-expected.checksum:
fast/forms/input-value-expected.checksum:
fast/forms/input-width-expected.checksum:
fast/forms/minWidthPercent-expected.checksum:
fast/forms/negativeLineHeight-expected.checksum:
fast/forms/negativeLineHeight-expected.png:
fast/forms/negativeLineHeight-expected.txt:
fast/forms/option-index-expected.checksum:
fast/forms/option-script-expected.checksum:
fast/forms/option-strip-whitespace-expected.checksum:
fast/forms/plaintext-mode-2-expected.checksum:
fast/forms/radio-attr-order-expected.checksum:
fast/forms/radio_checked-expected.checksum:
fast/forms/radio_checked_dynamic-expected.checksum:
fast/forms/selection-functions-expected.txt:
fast/forms/tabbing-input-iframe-expected.checksum:
fast/forms/textAreaLineHeight-expected.checksum:
fast/forms/textAreaLineHeight-expected.png:
fast/forms/textAreaLineHeight-expected.txt:
fast/forms/textarea-crlf-expected.txt:
fast/forms/textarea-setinnerhtml-expected.checksum:
fast/forms/textarea-setinnerhtml-expected.png:
fast/forms/textarea-setinnerhtml-expected.txt:
fast/forms/textarea-setvalue-submit-expected.txt:
fast/forms/visual-hebrew-text-field-expected.checksum:
fast/replaced/width100percent-expected.checksum:
fast/replaced/width100percent-expected.png:
fast/replaced/width100percent-expected.txt:
fast/table/003-expected.checksum:
fast/table/003-expected.png:
fast/table/003-expected.txt:
tables/mozilla/bugs/bug194024-expected.checksum:
tables/mozilla/bugs/bug194024-expected.png:
tables/mozilla/bugs/bug194024-expected.txt:
tables/mozilla/bugs/bug30559-expected.checksum:
tables/mozilla/bugs/bug30559-expected.png:
tables/mozilla/bugs/bug30559-expected.txt:
tables/mozilla/bugs/bug30692-expected.checksum:
tables/mozilla/bugs/bug30692-expected.png:
tables/mozilla/bugs/bug30692-expected.txt:

12:23 AM Changeset in webkit [14935] by adele

3 edits in trunk/WebCore

Reviewed by Anders.

Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>

css/html4.css:
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::selectionStart): (WebCore::HTMLTextAreaElement::selectionEnd): (WebCore::HTMLTextAreaElement::setSelectionStart): (WebCore::HTMLTextAreaElement::setSelectionEnd): (WebCore::HTMLTextAreaElement::select): (WebCore::HTMLTextAreaElement::setSelectionRange): (WebCore::HTMLTextAreaElement::createRenderer): (WebCore::HTMLTextAreaElement::appendFormData): (WebCore::HTMLTextAreaElement::isKeyboardFocusable): (WebCore::HTMLTextAreaElement::isMouseFocusable): (WebCore::HTMLTextAreaElement::focus): (WebCore::HTMLTextAreaElement::defaultEventHandler): (WebCore::HTMLTextAreaElement::updateValue): (WebCore::HTMLTextAreaElement::setValue):

Jun 20, 2006:

6:42 PM Changeset in webkit [14934] by beidson

2 edits in trunk/WebCore

Reviewed by Maciej

Fixed capitalization mistake that I made, someone else fixed, then I accidentally made it go back to the old way

icon/SQLStatement.cpp:

6:29 PM Changeset in webkit [14933] by beidson

16 edits
1 add in trunk

WebCore:

Reviewed by Maciej.

More changes/additions setting the stage for the major IconDatabase hookup.

WebCore.xcodeproj/project.pbxproj: Added SQLTransaction.cpp

bridge/mac/WebCoreIconDatabaseBridge.h: Added call-throughs and translations to pass WebKit DB to WebCore DB
bridge/mac/WebCoreIconDatabaseBridge.mm: (+[WebCoreIconDatabaseBridge sharedBridgeInstance]): (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]): (-[WebCoreIconDatabaseBridge iconForURL:withSize:]): (-[WebCoreIconDatabaseBridge iconURLForURL:]): (-[WebCoreIconDatabaseBridge defaultIconWithSize:]): (-[WebCoreIconDatabaseBridge retainIconForURL:]): (-[WebCoreIconDatabaseBridge releaseIconForURL:]): (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]): (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]): (-[WebCoreIconDatabaseBridge _setIconURL:forURL:]): (-[WebCoreIconDatabaseBridge _hasIconForIconURL:]):

bridge/mac/WebCorePageBridge.mm: Added WebCore's IconDatabase logging channel to the user-prefs check (initializeLoggingChannelsIfNecessary):

icon/IconDatabase.cpp: Added stubs and basic SQL usage to create the sqlite DB and respond to WebKit calls (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::open): (WebCore::IconDatabase::close): (WebCore::IconDatabase::isValidDatabase): (WebCore::IconDatabase::recreateDatabase): (WebCore::IconDatabase::setPrivateBrowsingEnabled): (WebCore::IconDatabase::iconForURL): (WebCore::IconDatabase::iconURLForURL): (WebCore::IconDatabase::defaultIcon): (WebCore::IconDatabase::retainIconForURL): (WebCore::IconDatabase::releaseIconForURL): (WebCore::IconDatabase::setIconForIconURL): (WebCore::IconDatabase::setHaveNoIconForIconURL): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::hasIconForIconURL):

icon/IconDatabase.h: WebIcon will be an internal class used in IconDatabase but is not complete yet (WebCore::WebIcon::getExpiration): (WebCore::WebIcon::getTouch):

icon/SQLDatabase.cpp: Added more SQLite convenience methods (SQLDatabase::setFullsync): (SQLDatabase::setBusyTimeout): (SQLDatabase::setBusyHandler):
icon/SQLDatabase.h:
icon/SQLStatement.cpp: (WebCore::SQLStatement::returnsAtLeastOneResult):

icon/SQLTransaction.cpp: Added basic commit/rollback support with this simple class (SQLTransaction::SQLTransaction): (SQLTransaction::~SQLTransaction): (SQLTransaction::begin): (SQLTransaction::commit): (SQLTransaction::rollback):

WebKit:

Reviewed by Maciej

Added calls through to the WebCoreIconDatabaseBridge for all the major WebIconDatabase API. For now these calls
are wrapped with #ifdef's and are for debugging only.

Misc/WebIconDatabase.h:
Misc/WebIconDatabase.m: (-[NSMutableDictionary _scaleIcon:toSize:]): (-[NSMutableDictionary init]): (-[NSMutableDictionary iconForURL:withSize:cache:]): (-[NSMutableDictionary iconURLForURL:]): (-[NSMutableDictionary retainIconForURL:]): (-[NSMutableDictionary releaseIconForURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _hasIconForIconURL:]):
Misc/WebIconLoader.m: (-[WebIconLoader didFinishLoading]):

Misc/WebKitLogging.h: Added a logging channel for WebIconDatabase debugging
Misc/WebKitLogging.m: (WebKitInitializeLoggingChannelsIfNecessary):

5:20 PM Changeset in webkit [14932] by thatcher

3 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Make sure we clear the exception before returning so
that future calls will not fail because of an earlier
exception state. Assert on entry that the WebScriptObject
is working with an ExecState that dose not have an exception.
Document that evaluateWebScript and callWebScriptMethod return
WebUndefined when an exception is thrown.

bindings/objc/WebScriptObject.h:
bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject setValue:forKey:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject removeWebScriptKey:]): (-[WebScriptObject webScriptValueAtIndex:]): (-[WebScriptObject setWebScriptValueAtIndex:value:]):

5:10 PM Changeset in webkit [14931] by adele

14 edits
8 adds in trunk

LayoutTests:

Reviewed by Maciej.

Tests for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=8724
REGRESSION: onSelect handler doesn't work for text fields

http://bugzilla.opendarwin.org/show_bug.cgi?id=7676
REGRESSION: Selection methods on new text fields don't work if text field is hidden

http://bugzilla.opendarwin.org/show_bug.cgi?id=8867
REGRESSION: selectionStart/End return 0 for input element once it no longer has focus

fast/forms/double-focus-expected.txt:
fast/forms/input-selection-hidden-expected.txt: Added.
fast/forms/input-selection-hidden.html: Added.
fast/forms/input-selection-restore-expected.txt: Added.
fast/forms/input-selection-restore.html: Added.
fast/forms/input-text-paste-maxlength-expected.txt:
fast/forms/onselect-textarea-expected.txt: Added.
fast/forms/onselect-textarea.html: Added.
fast/forms/onselect-textfield-expected.txt: Added.
fast/forms/onselect-textfield.html: Added.
fast/forms/selection-functions-expected.txt:

WebCore:

Reviewed by Maciej.

Fixes for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=8724
REGRESSION: onSelect handler doesn't work for text fields

http://bugzilla.opendarwin.org/show_bug.cgi?id=7676
REGRESSION: Selection methods on new text fields don't work if text field is hidden

http://bugzilla.opendarwin.org/show_bug.cgi?id=8867
REGRESSION: selectionStart/End return 0 for input element once it no longer has focus

Implemented onSelect for new text fields and textareas. Also fixed selection restore
behavior to better match other browsers and Safari 2.0 behavior.

Tests:

fast/forms/input-selection-restore.html
fast/forms/input-selection-hidden.html
fast/forms/onselect-textarea.html
fast/forms/onselect-textfield.html

html/HTMLInputElement.h: (WebCore::HTMLInputElement::cacheSelection): Added.
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::init): Initializes cached selection. (WebCore::HTMLInputElement::selectionStart): If this element doesn't have focus, return the cached selection value. (WebCore::HTMLInputElement::selectionEnd): ditto. (WebCore::HTMLInputElement::setValue): Restore a caret at the starting point of the old selection. Matches Safari 2.0 behavior.

html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::cacheSelection): Added.
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Initializes cached selection. (WebCore::HTMLTextAreaElement::selectionStart): If this element doesn't have focus, return the cached selection value. (WebCore::HTMLTextAreaElement::selectionEnd): ditto. (WebCore::HTMLTextAreaElement::focus): If this is the first focus, set a caret at the end of the text. Otherwise, restore the cached selection. This matches other browsers' behavior. (WebCore::HTMLTextAreaElement::setValue): Restore a caret at the starting point of the old selection. Matches Safari 2.0 behavior.

page/Frame.h: Added notifyRendererOfSelectionChange method.
page/Frame.cpp: (WebCore::Frame::notifyRendererOfSelectionChange): Added. Calls selectionChanged for text fields and textareas. Forwards a userTriggered argument so selectionChanged knows whether or not to fire onSelect. (WebCore::Frame::setSelection): Calls notifyRendererOfSelectionChange(false). This gets called for all selection changes, so the renderer can always update its cached selection values. (WebCore::Frame::handleMouseReleaseEvent): Calls notifyRendererOfSelectionChange(true) so onSelect will get fired when the user is done making a selection with the mouse.
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]): Calls notifyRendererOfSelectionChange(true) so onSelect gets fired when the user makes a selection with the keyboard. (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]): ditto.

rendering/RenderTextField.h: Add userTriggered parameter to selectionChanged.
rendering/RenderTextField.cpp: (WebCore::RenderTextField::setSelectionRange): For visibility:hidden, cache the selection and return early since we won't be able to actually set the selection. (WebCore::RenderTextField::selectionChanged): Caches the selection. If the selection is a range, and its triggered by user action, then fire the onSelect event.

3:11 PM Changeset in webkit [14930] by andersca

3 edits in trunk/WebCore

2006-06-21 Anders Carlsson <acarlsson@apple.com>

bridge/win/FrameWin.cpp: (WebCore::shouldInterruptJavaScript):
bridge/win/FrameWin.h: Try fixing the Windows build.

3:07 PM Changeset in webkit [14929] by adele

36 edits
2 moves in trunk

RS by Tim Hatcher.

Renamed RenderSelect to DeprecatedRenderSelect to prepare for new popup menu and list menu implementations.

WebCore.xcodeproj/project.pbxproj:
html/HTMLOptionElement.h:
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::createRenderer): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::notifyOptionSelected):
html/HTMLSelectElement.h:
rendering/DeprecatedRenderSelect.cpp: Added. (WebCore::DeprecatedRenderSelect::DeprecatedRenderSelect): (WebCore::DeprecatedRenderSelect::setWidgetWritingDirection): (WebCore::DeprecatedRenderSelect::setStyle): (WebCore::DeprecatedRenderSelect::updateFromElement): (WebCore::DeprecatedRenderSelect::baselinePosition): (WebCore::DeprecatedRenderSelect::calcMinMaxWidth): (WebCore::DeprecatedRenderSelect::layout): (WebCore::DeprecatedRenderSelect::valueChanged): (WebCore::DeprecatedRenderSelect::selectionChanged): (WebCore::DeprecatedRenderSelect::setOptionsChanged): (WebCore::DeprecatedRenderSelect::createListBox): (WebCore::DeprecatedRenderSelect::updateSelection):
rendering/DeprecatedRenderSelect.h: Added. (WebCore::DeprecatedRenderSelect::renderName):
rendering/RenderSelect.cpp: Removed.
rendering/RenderSelect.h: Removed.

3:01 PM Changeset in webkit [14928] by andersca

1 edit in trunk/WebCore/dom/xml_tokenizer.cpp

Commit for real this time - Not just the ChangeLog and some white-space

2:34 PM Changeset in webkit [14927] by andersca

2 edits in trunk/WebCore

2006-06-20 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9509
Would like a way to pause/resume XML parsing

dom/xml_tokenizer.cpp: (WebCore::PendingCallbacks::PendingCallbacks): (WebCore::PendingCallbacks::appendStartElementNSCallback): (WebCore::PendingCallbacks::appendEndElementNSCallback): (WebCore::PendingCallbacks::appendCharactersCallback): (WebCore::PendingCallbacks::appendProcessingInstructionCallback): (WebCore::PendingCallbacks::appendCDATABlockCallback): (WebCore::PendingCallbacks::appendCommentCallback): (WebCore::PendingCallbacks::appendInternalSubsetCallback): (WebCore::PendingCallbacks::appendErrorCallback): (WebCore::PendingCallbacks::callAndRemoveFirstCallback): (WebCore::PendingCallbacks::isEmpty): (WebCore::PendingCallbacks::PendingCallback::~PendingCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): (WebCore::PendingCallbacks::PendingEndElementNSCallback::call): (WebCore::PendingCallbacks::PendingCharactersCallback::~PendingCharactersCallback): (WebCore::PendingCallbacks::PendingCharactersCallback::call): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::~PendingProcessingInstructionCallback): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::call): (WebCore::PendingCallbacks::PendingCDATABlockCallback::~PendingCDATABlockCallback): (WebCore::PendingCallbacks::PendingCDATABlockCallback::call): (WebCore::PendingCallbacks::PendingCommentCallback::~PendingCommentCallback): (WebCore::PendingCallbacks::PendingCommentCallback::call): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::~PendingInternalSubsetCallback): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::call): (WebCore::PendingCallbacks::): New classes which manage a list of pending SAX callbacks that have not yet been sent to the tokenizer.

(WebCore::XMLTokenizer::XMLTokenizer):
Initialize new member variables.

(WebCore::XMLTokenizer::~XMLTokenizer):
Delete PendingCallbacks object.

(WebCore::XMLTokenizer::write):
If the parser is paused, queue the data to be written.

(WebCore::XMLTokenizer::startElementNs):
(WebCore::XMLTokenizer::endElementNs):
(WebCore::XMLTokenizer::characters):
(WebCore::XMLTokenizer::error):
(WebCore::XMLTokenizer::processingInstruction):
(WebCore::XMLTokenizer::cdataBlock):
(WebCore::XMLTokenizer::comment):
(WebCore::XMLTokenizer::internalSubset):
If the parser has been paused, queue the callbacks instead.

(WebCore::XMLTokenizer::handleError):
New function, called by both ::error and :PendingCallbacks::callAndRemoveFirstCallback

(WebCore::XMLTokenizer::finish):
(WebCore::XMLTokenizer::pauseParsing):

Set m_parserPaused to true.

(WebCore::XMLTokenizer::resumeParsing):
Call the pending callbacks and then parse the pending source.

2:24 PM Changeset in webkit [14926] by hyatt

3 edits in trunk/WebCore

Don't send the custom highlighter callback when painting is disabled.

Reviewed by harrison

WebCore.xcodeproj/project.pbxproj:
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):

2:04 PM Changeset in webkit [14925] by adele

2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

WebView/WebMainResourceLoader.m: Added missing header to fix build on Leopard.

12:44 PM Changeset in webkit [14924] by andersca

3 edits
8 adds in trunk

WebCore:

2006-06-20 Anders Carlsson <acarlsson@apple.com>

Reviewed by John.

<rdar://problem/4592244> REGRESSION (417.9.3 - 420+): (some?) plain text files have all lines concatenated into one line

loader/TextDocument.cpp: (WebCore::TextTokenizer::checkBuffer): (WebCore::TextTokenizer::TextTokenizer): (WebCore::TextTokenizer::write): (WebCore::TextTokenizer::finish): Add a text buffer which is used for translation of CR and CRLF to plain LF, like the HTML tokenizer does.

LayoutTests:

2006-06-20 Anders Carlsson <acarlsson@apple.com>

Reviewed by John.

<rdar://problem/4592244> REGRESSION (417.9.3 - 420+): (some?) plain text files have all lines concatenated into one line

fast/text/plain-text-line-breaks-expected.checksum: Added.
fast/text/plain-text-line-breaks-expected.png: Added.
fast/text/plain-text-line-breaks-expected.txt: Added.
fast/text/plain-text-line-breaks.html: Added.
fast/text/resources/line-breaks-cr.txt: Added.
fast/text/resources/line-breaks-crlf.txt: Added.
fast/text/resources/line-breaks-lf.txt: Added.

12:12 PM Changeset in webkit [14923] by thatcher

1 edit
51 adds in trunk/WebKitTools

Reviewed by Darin.

Adds a JavaScript debugger, called Drosera. Named after
a genus of bug eating plants.

Drosera/DebuggerApplication.h: Added.
Drosera/DebuggerApplication.m: Added. (-[DebuggerApplication applicationDidFinishLaunching:]): (-[DebuggerApplication serverLoaded:]): (-[DebuggerApplication serverUnloaded:]): (-[DebuggerApplication awakeFromNib]): (-[DebuggerApplication showAttachPanel:]): (-[DebuggerApplication attach:]): (-[DebuggerApplication numberOfRowsInTableView:]): (-[DebuggerApplication tableView:objectValueForTableColumn:row:]): (-[DebuggerApplication tableView:willDisplayCell:forTableColumn:row:]): (-[DebuggerApplication tableViewSelectionDidChange:]):
Drosera/DebuggerDocument.h: Added.
Drosera/DebuggerDocument.m: Added. (+[WebScriptCallFrame isSelectorExcludedFromWebScript:]): (+[WebScriptCallFrame isKeyExcludedFromWebScript:]): (+[DebuggerDocument isSelectorExcludedFromWebScript:]): (+[DebuggerDocument isKeyExcludedFromWebScript:]): (-[DebuggerDocument initWithServerName:]): (-[DebuggerDocument windowWillClose:]): (-[DebuggerDocument dealloc]): (-[DebuggerDocument isPaused]): (-[DebuggerDocument pause]): (-[DebuggerDocument resume]): (-[DebuggerDocument step]): (-[DebuggerDocument windowNibName]): (-[DebuggerDocument windowDidLoad]): (-[DebuggerDocument switchToServerNamed:]): (-[DebuggerDocument applicationTerminating:]): (-[DebuggerDocument serverConnectionDidDie:]): (-[DebuggerDocument webView:windowScriptObjectAvailable:]): (-[DebuggerDocument webView:didFinishLoadForFrame:]): (-[DebuggerDocument webView:didParseSource:fromURL:sourceId:forWebFrame:]): (-[DebuggerDocument webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[DebuggerDocument webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[DebuggerDocument webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
Drosera/Drosera.pch: Added.
Drosera/Drosera.xcodeproj/project.pbxproj: Added.
Drosera/English.lproj/Debugger.nib/classes.nib: Added.
Drosera/English.lproj/Debugger.nib/info.nib: Added.
Drosera/English.lproj/Debugger.nib/keyedobjects.nib: Added.
Drosera/English.lproj/MainMenu.nib/classes.nib: Added.
Drosera/English.lproj/MainMenu.nib/info.nib: Added.
Drosera/English.lproj/MainMenu.nib/keyedobjects.nib: Added.
Drosera/Images/breakPoint.tif: Added.
Drosera/Images/breakPointDisabled.tif: Added.
Drosera/Images/continue.tif: Added.
Drosera/Images/finishFunction.tif: Added.
Drosera/Images/glossyFooterFill.tif: Added.
Drosera/Images/glossyHeader.png: Added.
Drosera/Images/gradientBackground.png: Added.
Drosera/Images/gutter.png: Added.
Drosera/Images/navLeftDisabled.png: Added.
Drosera/Images/navLeftNormal.png: Added.
Drosera/Images/navLeftPressed.png: Added.
Drosera/Images/navRightDisabled.png: Added.
Drosera/Images/navRightNormal.png: Added.
Drosera/Images/navRightPressed.png: Added.
Drosera/Images/pause.tif: Added.
Drosera/Images/popUpArrows.png: Added.
Drosera/Images/programCounter.tif: Added.
Drosera/Images/programCounterBreakPoint.tif: Added.
Drosera/Images/programCounterBreakPointDisabled.tif: Added.
Drosera/Images/run.tif: Added.
Drosera/Images/splitterBar.tif: Added.
Drosera/Images/splitterDimple.tif: Added.
Drosera/Images/step.tif: Added.
Drosera/Images/stepOver.tif: Added.
Drosera/Images/stop.tif: Added.
Drosera/Images/toolbarBackground.png: Added.
Drosera/Info.plist: Added.
Drosera/debugger.css: Added.
Drosera/debugger.html: Added.
Drosera/debugger.js: Added.
Drosera/main.m: Added. (main):
Drosera/viewer.css: Added.
Drosera/viewer.html: Added.

12:08 PM Changeset in webkit [14922] by thatcher

5 edits in trunk/WebKit

Reviewed by Darin.

Removes the @try/@catch from the callbacks to improve performance,
simply check if the proxy object's connection is still valid first.
Listener objects are now required to be NSDistantObjects.

Adds pause, resume and step support. The debugger process use to handle this,
but it caused problems when there were multiple listeners.

Sends the bundle identifier in the notification userInfo dictionary along with
process name and process ID.

DefaultDelegates/WebScriptDebugServer.h:
DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer serverQuery:]): (-[WebScriptDebugServer addListener:]): (-[WebScriptDebugServer removeListener:]): (-[WebScriptDebugServer step]): (-[WebScriptDebugServer pause]): (-[WebScriptDebugServer resume]): (-[WebScriptDebugServer isPaused]): (-[WebScriptDebugServer suspendProcessIfPaused]): (-[WebScriptDebugServer webView:didParseSource:fromURL:sourceId:forWebFrame:]): (-[WebScriptDebugServer webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
DefaultDelegates/WebScriptDebugServerPrivate.h:
WebKit.exp:

1:14 AM Changeset in webkit [14921] by mjs

2 edits in trunk/WebCore

Reviewed by Eric.

fix crasher on one of the layout tests caused by my recent checkin

kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):

Jun 19, 2006:

10:17 PM Changeset in webkit [14920] by ap

8 edits
2 adds in trunk

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=5499 Page reload does not send any cache control headers

WebCore:

bindings/js/kjs_window.cpp: (KJS::LocationFunc::callAsFunction): Call scheduleRefresh() for Location::Reload.

page/Frame.h: Add scheduleRefresh(). Don't derive from TransferJob or implement its methods - that was used only for storing response HTTP headers, which was an overkill.

page/FramePrivate.h: Replace TransferJob with a HashMap for storing response headers.

page/Frame.cpp: (WebCore::Frame::didOpenURL): Don't needlessly change d->m_cachePolicy. Don't create a TransferJob. (WebCore::Frame::stopLoading): Directly access the metadata map, instead of going through a TransferJob. (WebCore::Frame::receivedFirstData): Ditto. (WebCore::Frame::addMetaData): Ditto. (WebCore::Frame::scheduleRefresh): A new function that schedules a refresh, similarly to what scheduleRedirection() does. (WebCore::Frame::changeLocation): Set request.reload attribute based on the current cache policy.

WebKit:

WebView/WebFrame.m: (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): Set a proper Cache-Control header for reload requests. (-[WebFrame loadRequest:]): Reset loadType to WebFrameLoadTypeStandard (after a reload, it stayed at WebFrameLoadTypeReload, so _addExtraFieldsToRequest erroneously added a Cache-Control header to them).

LayoutTests:

http/tests/misc/refresh-headers-expected.txt: Added.
http/tests/misc/refresh-headers.php: Added.

8:20 PM Changeset in webkit [14919] by ddkilzer

2 edits in trunk/WebCore

WebCore:

Reviewed by Darin. Patch by Ben Goodger.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9501
Windows build fails with link error CharsetTable not defined

platform/make-charset-table.pl: (process_iana_charsets): Move test for equality to alias "None" until after normalization steps to ensure escape characters in the input data don't interfere with processing. Convert nearby tabs to 4 spaces in this function.

7:43 PM Changeset in webkit [14918] by mjs

12 edits
6 adds in trunk/WebCore

Reviewed by Darin.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=9488 "Animated GIFs do not respect transforms in SVG"

http://bugzilla.opendarwin.org/show_bug.cgi?id=6946
"SVG shows invalidation issues in WebKit"

http://www.treebuilder.de/default.asp?file=441875.xml
"Invalidation issues with "SVG 3d" demo"

http://code.google.com/webstats/2005-12/pages.html
"SVG text doesn't repaint correctly"

kcanvas/KCanvasContainer.cpp: (WebCore::KCanvasContainer::computeAbsoluteRepaintRect): Override base class, and apply appropriate transforms, so damage rects in transformed SVG content get propagated up properly. (WebCore::KCanvasContainer::getAbsoluteRepaintRect): note a FIXME; this method seems wrong.
kcanvas/KCanvasContainer.h: Prototype new method.

css/svg.css: Don't apply overflow:hidden to foreignObject, since that makes it a RenderLayer so it paints twice.
kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint): Transform the damage rect before passing it down to HTML content, so everything paints that is supposed to. Also handle opacity here since we won't get layers. (WebCore::RenderForeignObject::computeAbsoluteRepaintRect): Override base class, and apply appropriate transforms, so damage rects in HTML embedded in SVG get propagated up properly. (WebCore::RenderForeignObject::requiresLayer): Never use a RenderLayer. (WebCore::RenderForeignObject::layout): Make sure to dirty our previous bounds when layout changes, as by transform.
kcanvas/RenderForeignObject.h:

kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): Transform the damage rect when painting. Also handle opacity here since we won't get layers. (WebCore::RenderForeignObject::computeAbsoluteRepaintRect): Override base class, and apply appropriate transforms, so damage rects in SVG images get propagated up properly. (WebCore::RenderSVGImage::translationForAttributes): New helper method, factored out of below. (WebCore::RenderSVGImage::translateForAttributes): Use above. (WebCore::RenderSVGImage::requiresLayer): Never use a RenderLayer. (WebCore::RenderSVGImage::layout): Make sure to properly dirty the old bounds, accounting for transforms. (WebCore::RenderSVGImage::relativeBBox): Correct bbox computation.
kcanvas/RenderSVGImage.h:

kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint): Transform incoming damage rect. Handle opacity here since we won't get a layer. (WebCore::RenderSVGText::computeAbsoluteRepaintRect): Apply transforms. (WebCore::RenderSVGText::requiresLayer): Never use a RenderLayer. (WebCore::RenderSVGText::layout): Make sure to dirty the old bounds.

platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::roundToDevicePixels): Instead of transforming rect to device space and back to user space, do this for the origin and lower right corner of the rect. Otherwise the rect will get inflated if user space is rotated or skewed.

kcanvas/RenderPath.cpp: (WebCore::RenderPath::layout): Make sure to dirty the old bounds. (WebCore::RenderPath::paint): Hhandle opacity here.

Bonus fix:

kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::nodeAtPoint): Fix hit testing. Wasn't applying the x/y attribute transform.

4:31 PM Changeset in webkit [14917] by thatcher

1 edit in trunk/WebKit/WebView/WebView.h

Build fix.

3:58 PM Changeset in webkit [14916] by weinig

40 edits
20 copies
2 moves in trunk/WebCore

2:58 PM Changeset in webkit [14915] by sullivan

3 edits in trunk/WebKit

Reviewed by Darin.

added mechanism to notify UIDelegate when part of the webview is redrawn. For now, it only works for HTML views.

WebView/WebUIDelegatePrivate.h: Define a new UIDelegate method -webView:didDrawRect:
WebView/WebHTMLView.m: (-[WebView drawSingleRect:]): Call through to UIDelegate if it implements that method. I tested that this does not impact PLT numbers in the case where the delegate implements the method but does nothing in it.

2:39 PM Changeset in webkit [14914] by darin

4 edits
3 deletes in trunk/WebCore

Reviewed by Brady.

removed a few empty/unused files Brady found by tracking down the nm error message

editing/VisibleRange.cpp: Removed.
editing/VisibleRange.h: Removed.
kcanvas/KCanvasImage.cpp: Removed.

WebCore.vcproj/WebCore/WebCore.vcproj: Removed VisibleRange.cpp/h.
WebCore.xcodeproj/project.pbxproj: Removed VisibleRange.cpp/h and KCanvasImage.cpp.
WebCoreSources.bkl: Removed VisibleRange.cpp.

12:23 PM Changeset in webkit [14913] by andersca

2 edits in trunk/JavaScriptCore

2006-06-19 Anders Carlsson <acarlsson@apple.com>

Reviewed by John.

kjs/interpreter.cpp: (KJS::TimeoutChecker::pauseTimeoutCheck): (KJS::TimeoutChecker::resumeTimeoutCheck): Fix argument order in setitimer calls.

9:42 AM Changeset in webkit [14912] by ap

2 edits in trunk/WebCore

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9492 Fix or remove window.debug.

It was only available in newly created windows, and became undefined after changing the URL
or reloading. Let's try removing it; hopefully, no-one will notice.

bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScriptIfNeeded): Don't add window.debug.

9:15 AM Changeset in webkit [14911] by ap

9 edits in trunk

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=8972 REGRESSION: invalid UTF-8 sequences are not displayed

Test: LayoutTests/fast/encoding/invalid-UTF-8.html

dom/xml_tokenizer.cpp: (WebCore::getXHTMLEntity): Properly null-terminate the result. This didn't matter before, because the garbage at the end was guaranteed to be invalid UTF-8, and was omitted in appendOmittingUnwanted();

platform/StreamingTextDecoder.cpp: (WebCore::StreamingTextDecoder::appendOmittingBOM): Only omit BOM characters. Renamed back from appendOmittingUnwanted();

(WebCore::StreamingTextDecoder::convertUsingICU):

platform/StreamingTextDecoder.h: Update for the above function renaming.

3:51 AM Changeset in webkit [14910] by ddkilzer

2 edits in trunk/WebKit

WebKit:

Reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9452 Assertion failure in -[WebFramePrivate setProvisionalDataSource:]

WebView/WebFrame.m: (-[WebFrame _checkLoadCompleteForThisFrame]): Avoid re-entering the delegate's -[webView:didFailProvisionalLoadWithError:forFrame].

Jun 18, 2006:

5:00 PM Changeset in webkit [14909] by ddkilzer

3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9485
Teach svn-apply and svn-unapply to use full path names

Scripts/svn-apply: Changed to use full path names. Cleaned up code.
Scripts/svn-unapply: Ditto.

4:54 PM Changeset in webkit [14908] by ddkilzer

2 edits in trunk/WebCore

WebCore:

Reviewed by darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9498
Remove dead code left in JSHTMLDocument::getOwnPropertySlot() from r14298 (Bug 7838)

bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::getOwnPropertySlot): Remove dead code.

3:20 PM Changeset in webkit [14907] by ddkilzer

4 edits in trunk

LayoutTests:

Reviewed by ggaren.

fast/history/clicked-link-is-visited.html: Changed to use DOM mouse event.

WebCore:

Reviewed by ggaren.

manual-tests/redraw-page-cache-visited-links.html: Changed to use DOM mouse event.

10:58 AM Changeset in webkit [14906] by ddkilzer

5 edits in trunk/WebKit

WebKit:

Reviewed by xenon.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9479 Disassociate the inspector from the frame when it detaches from its parent

WebInspector/WebInspector.m: (-[NSWindow setWebFrame:]): Added code to (de)register with the WebFrame the inspector is (no longer) targeting. (-_webFrameDetached:): Added. Moved the code that was previously in -[inspectedWindowWillClose:] here. This is called by the WebFrame when it is detached from its parent.
WebInspector/WebInspectorInternal.h:
WebView/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFrame _detachFromParent]): Added code to notify all registered inspectors that the WebFrame is detaching. (-[WebFrame _addInspector:]): Added. (-[WebFrame _removeInspector:]): Added.
WebView/WebFrameInternal.h:

10:54 AM Changeset in webkit [14905] by ddkilzer

7 edits
7 adds in trunk

LayoutTests:

Reviewed by ggaren.

test and results for http://bugzilla.opendarwin.org/show_bug.cgi?id=9150 DumpRenderTree should be able to keep URL history during runs

fast/history/clicked-link-is-visited-expected.checksum: Added.
fast/history/clicked-link-is-visited-expected.png: Added.
fast/history/clicked-link-is-visited-expected.txt: Added.
fast/history/clicked-link-is-visited.html: Added.
fast/history/resources/clicked-link-is-visited-2.html: Added.

WebCore:

Reviewed by ggaren.

Update a manual test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9150 DumpRenderTree should be able to keep URL history during runs

manual-tests/redraw-page-cache-visited-links.html: Added note about window.history hack. Fixed coordinates for mouse events. Added call to keepWebHistory().
manual-tests/resources/redraw-page-cache-visited-links-2.html: Added note about window.history hack.

WebKitTools:

Reviewed by ggaren.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9150 DumpRenderTree should be able to keep URL history during runs

Test: LayoutTests/fast/history/clicked-link-is-visited.html

DumpRenderTree/DumpRenderTree.m: Add keepWebHistory function to layoutTestController (+[LayoutTestController isSelectorExcludedFromWebScript:]): Updated for keepWebHistory. (-[LayoutTestController keepWebHistory]): Added. We only set optional shared history if it is currently nil since keepWebHistory() might be called more than once incidentally for the same test. (dumpRenderTree): Set optional shared history in WebHistory to nil by default.
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Xcode 2.3 clean up.

10:11 AM Changeset in webkit [14904] by andersca

16 edits in trunk

JavaScriptCore:

2006-06-18 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

kjs/interpreter.cpp: (KJS::TimeoutChecker::pauseTimeoutCheck): Do nothing if the timeout check hasn't been started.

(KJS::TimeoutChecker::resumeTimeoutCheck):
Do nothing if the timeout check hasn't been started.
Use the right signal handler when unblocking.

(KJS::Interpreter::handleTimeout):
pause/resume the timeout check around the call to
shouldInterruptScript().

WebCore:

2006-06-17 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::ScriptInterpreter): Set the default script timeout.

(KJS::ScriptInterpreter::shouldInterruptScript):
New function which asks the frame if the script should be interrupted.

bindings/js/kjs_binding.h:

bindings/js/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate): Add calls to startTimeoutCheck/stopTimeoutCheck

bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Add calls to pauseTimeoutCheck/unpauseTimeoutCheck

(KJS::ScheduledAction::execute):
Add calls to startTimeoutCheck/stopTimeoutCheck

bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::shouldInterruptJavaScript): New function which asks the bridge if the script should be interrupted.

bridge/mac/WebCoreFrameBridge.h:
page/Frame.h: Add function declarations.

WebKit:

2006-06-18 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge shouldInterruptJavaScript]): Ask the UI delegate if the script should be interrupted.

WebView/WebUIDelegatePrivate.h: Declare webViewShouldInterruptJavaScript: delegate method

12:00 AM Changeset in webkit [14903] by ap

3 edits
2 adds in trunk

Reviewed by ggaren.

http://bugzilla.opendarwin.org/show_bug.cgi?id=8131 Some properties and methods of window and document objects cannot be converted to a string

Most of the properties were already fixed, this just adds adds a prototype to window.debug.

Test: fast/dom/everything-to-string.html

bindings/js/kjs_proxy.cpp: (WebCore::TestFunctionImp::TestFunctionImp): (WebCore::KJSProxy::initScriptIfNeeded):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed