Context Navigation

← Previous Period
Next Period →

Timeline

Jun 24, 2006:

11:01 PM Changeset in webkit [15025] by ddkilzer

3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9570
Teach prepare-ChangeLog to operate on a list of files or directories

Scripts/prepare-ChangeLog: Accept a list of files and/or directories when running.
Scripts/svn-create-patch: Code refactoring.

8:02 PM Changeset in webkit [15024] by ddkilzer

8 edits
2 deletes in trunk

WebCore:

Build fix. Reviewed by NOBODY.

Backed out patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=8707 event.clientX and event.clientY should be relative to the viewport, not the canvas

dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
dom/MouseEvent.cpp: (WebCore::MouseEvent::MouseEvent):
dom/MouseEvent.h:
dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::MouseRelatedEvent): (WebCore::MouseRelatedEvent::initCoordinates):
dom/MouseRelatedEvent.h:
dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent):

LayoutTests:

Build fix. Reviewed by NOBODY.

Backed out patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=8707 event.clientX and event.clientY should be relative to the viewport, not the canvas

fast/dom/window-xy-properties-expected.txt: Removed.
fast/dom/window-xy-properties.html: Removed.

7:09 PM Changeset in webkit [15023] by ddkilzer

8 edits
2 adds in trunk

WebCore:

Reviewed by Darin. Patch by Rob Buis.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8707:
event.clientX and event.clientY should be relative to the viewport, not the canvas

Make sure clientX and clientY take into account the scroll offsets
of the view.

Test: fast/dom/window-xy-properties.html

dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
dom/MouseEvent.cpp: (WebCore::MouseEvent::MouseEvent):
dom/MouseEvent.h:
dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::MouseRelatedEvent): (WebCore::MouseRelatedEvent::initCoordinates):
dom/MouseRelatedEvent.h:
dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent):

LayoutTests:

Reviewed by Darin. Patch by Rob Buis.

Test cases for
<http://bugzilla.opendarwin.org/show_bug.cgi?id=8707>
event.clientX and event.clientY should be relative to the viewport, not the canvas

fast/dom/window-xy-properties-expected.txt: Added.
fast/dom/window-xy-properties.html: Added.

6:53 PM Changeset in webkit [15022] by ddkilzer

1 edit
4 adds in trunk/LayoutTests

LayoutTests:

Reviewed by Darin. Patch by James G. Speth.

Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=8843 add a way to build Objective-C test cases in HTML

plugins/jsobjc-dom-wrappers-expected.txt: Added.
plugins/jsobjc-dom-wrappers.html: Added.
plugins/jsobjc-simple-expected.txt: Added.
plugins/jsobjc-simple.html: Added.

2:55 PM Changeset in webkit [15021] by ddkilzer

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin. Patch by Rob Buis.

Test cases for
<http://bugzilla.opendarwin.org/show_bug.cgi?id=9352>
Webkit doesn't respect stroke-width in SVG for smaller <circle>s

svg/custom/gradient-stroke-width-expected.checksum: Added.
svg/custom/gradient-stroke-width-expected.png: Added.
svg/custom/gradient-stroke-width-expected.txt: Added.
svg/custom/gradient-stroke-width.svg: Added.

WebCore:

Reviewed by Darin. Patch by Rob Buis.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9352
Webkit doesn't respect stroke-width in SVG for smaller <circle>s

Make sure the stroke path is set before applying gradient transforms.

kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::renderPath):

2:08 PM Changeset in webkit [15020] by ddkilzer

3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin. Patch by James G. Speth.

http://bugzilla.opendarwin.org/show_bug.cgi?id=8843 add a way to build Objective-C test cases in HTML

Tests running in DumpRenderTree can choose to relax some restrictions of the JavaScript/Objective-C bridge
allowing more extensive testing of the Obj-C API. (and by more extensive, I mean this lets scripts do
pretty much whatever they want, including acting as delegates, generating events, instantiating obj-c
objects, etc... )

DumpRenderTree/ObjCPlugin.h:
DumpRenderTree/ObjCPlugin.m: this ability is only exposed to scripts running in DumpRenderTree (+[ObjCPlugin isSelectorExcludedFromWebScript:]): (+[ObjCPlugin webScriptNameForSelector:]): (-[ObjCPlugin removeBridgeRestrictions:]): scripts call this to open up obj-c for extensive testing (+[NSObject setAllowsScriptsFullAccess:]): makes NSObject allow all selectors to be invoked from script (+[NSObject allowsScriptsFullAccess]): (+[NSObject isSelectorExcludedFromWebScript:]): when full access is enabled, no selector is excluded (+[NSObject webScriptNameForSelector:]): always return nil for the default selector mutation (-[JSObjC classNameOfObject:isSelectorExcludedFromWebScript:]): (+[JSObjC webScriptNameForSelector:]): (-[JSObjC invokeDefaultMethodWithArguments:]): shortcut for accessing classes (-[JSObjC lookUpClass:]): allow scripts to retrieve obj-c classes by name (-[JSObjC log:]): access to NSLog function (-[JSObjC retainObject:]): useful obj-c functions that are otherwise hard to reach from javascript (-[JSObjC classOfObject:]): (-[JSObjC classNameOfObject:]):

2:07 PM Changeset in webkit [15019] by ap

4 edits in trunk

Rubber-stamped by Eric.

Add a -h (do not follow symlinks) option to ln in derived sources build script (without it,
a symlink was created inside the source directory on second build).

JavaScriptCore:

JavaScriptCore.xcodeproj/project.pbxproj:

WebCore:

WebCore.xcodeproj/project.pbxproj:

1:51 PM Changeset in webkit [15018] by ddkilzer

7 edits
1 add in trunk/WebCore

WebCore:

Reviewed by Darin. Patch by James G. Speth. Copyrights tweaked by ddkilzer.

Bug 8331: DOMNodeLists returned to Objective-C are not properly wrapped
http://bugzilla.opendarwin.org/show_bug.cgi?id=8331

DOMNodes were the only objects handled by createObjcInstanceForValue.
now it handles all of these: DOMNode, DOMNodeList, DOMNamedNodeMap, DOMStyleSheetList,
DOMStyleSheet, DOMMediaList, DOMCSSRuleList, DOMCSSRule, DOMCSSStyleDeclaration, and DOMCSSValue

WebCore.xcodeproj/project.pbxproj: added file DOMCSSInternal.h to project
bindings/js/kjs_css.cpp: (KJS::): changed ClassInfo for DOMCSSStyleSheet to have DOMStyleSheet as its parent class
bindings/objc/DOM.mm: (-[DOMDocumentType :]): moved DOMNamedNodeMap (WebCoreInternal) interface to DOMInternal.h
bindings/objc/DOMCSS.mm: moved WebCoreInternal interfaces to DOMCSSInternal.h
bindings/objc/DOMCSSInternal.h: Added file, contains WebCoreInternal interface for CSS classes
bindings/objc/DOMInternal.h: added DOMNamedNodeMap (WebCoreInternal) interface
bindings/objc/DOMUtility.mm: (KJS::ScriptInterpreter::createObjcInstanceForValue): support for more classes

1:01 PM Changeset in webkit [15017] by ddkilzer

14 edits in trunk

JavaScriptCore:

Reviewed by Timothy.

Info.plist: Fixed copyright to include 2003-2006.

JavaScriptGlue:

Reviewed by Timothy.

Info.plist: Fixed copyright to include 2003-2006.

WebCore:

Reviewed by Timothy.

Info.plist: Fixed copyright to include 2003-2006.
manual-tests/NPN_Invoke/Info.plist: Added copyright statement.

WebKit:

Reviewed by Timothy.

Info.plist: Fixed copyright to include 2003-2006.

WebKitTools:

Reviewed by Timothy.

DrawTest/Info.plist: Added copyright statement.
Drosera/Info.plist: Ditto.
DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist: Ditto.
WebKitLauncher/Info.plist: Ditto.

12:00 PM Changeset in webkit [15016] by ddkilzer

2 edits in trunk/WebKitTools

WebKitTools:

Build fix. Reviewed by NOBODY.

Backed out http://bugzilla.opendarwin.org/show_bug.cgi?id=7802 devenv.com not available in VC++ Express installations

Scripts/webkitdirs.pm: Backed out previous change.

11:45 AM Changeset in webkit [15015] by ddkilzer

2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Maciej. Patch by Bjoern Graf.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7802 devenv.com not available in VC++ Express installations

Scripts/webkitdirs.pm: Make Windows build work with Visual C++ Express.

9:02 AM Changeset in webkit [15014] by ap

5 edits
4 adds in trunk

2006-06-24 Mitz Pettel <opendarwin.org@mitzpettel.com>

Reviewed by Darin, landed by ap.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9547 Resize corner does not track the mouse accurately

Test: fast/css/resize-corner-tracking.html

page/FrameView.cpp: (WebCore::FrameView::handleMousePressEvent): Store the offset from the layer's resizing corner where dragging has started. (WebCore::FrameView::handleMouseMoveEvent): Pass the stored offset to the layer's resize method.
rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize): Added an offset parameter, which is added to the mouse location. For objects that may have intrinsic margins applied to them, added code to lift the margins into the object's style in order to keep them constant. Changed to take the content size as the base size if the box-sizing property is content-box. (WebCore::RenderLayer::offsetFromResizeCorner): Added. Returns the offset of the given point from the corner that tracks the mouse when resizing.
rendering/RenderLayer.h:

8:52 AM Changeset in webkit [15013] by ap

5 edits
4 adds in trunk

Reviewed by Darin, landed by ap.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9316 REGRESSION: text field width shrinks on first keystroke

Test: fast/forms/floating-textfield-relayout.html

page/FrameView.cpp: (WebCore::FrameView::layoutRoot): Added. During subtree relayout, returns the subtree root. Otherwise returns 0. (WebCore::FrameView::layoutPending): Made const.
page/FrameView.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::calcWidth): Added early return if this is the root of a subtree being laid out.

8:37 AM Changeset in webkit [15012] by ap

2 edits in trunk/WebKitTools

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9564 A bunch of fixes to run-webkit-httpd

Add an -all-interfaces (-a) flag to bind to all interfaces, not just 127.0.0.1. Useful for testing with WinIE running on another machine;
don't call checkFrameworks() - we do not need a built WebKit here;
changed tabs to spaces;
disable HTTP keepalive (since Apache doesn't spawn sub-processes in interactive mode, they were a hassle when testing with several browsers, as one had to wait for connection to expire);
remove httpd.pid when done, so that Apache doesn't complain next time.

Scripts/run-webkit-httpd:

8:09 AM Changeset in webkit [15011] by ddkilzer

116 edits in trunk

LayoutTests:

Reviewed by Hyatt. Patch by Mitz.

updated test results for http://bugzilla.opendarwin.org/show_bug.cgi?id=9531 Pages that need only a horizontal scroll bar get a vertical one as well

css1/classification/white_space-expected.checksum:
css1/classification/white_space-expected.png:
css1/classification/white_space-expected.txt:
editing/selection/select-all-004-expected.checksum:
editing/selection/select-all-004-expected.png:
editing/selection/select-all-004-expected.txt:
editing/selection/unrendered-001-expected.checksum:
editing/selection/unrendered-001-expected.png:
editing/selection/unrendered-001-expected.txt:
editing/selection/unrendered-002-expected.checksum:
editing/selection/unrendered-002-expected.png:
editing/selection/unrendered-002-expected.txt:
editing/selection/unrendered-003-expected.checksum:
editing/selection/unrendered-003-expected.png:
editing/selection/unrendered-003-expected.txt:
editing/selection/unrendered-004-expected.checksum:
editing/selection/unrendered-004-expected.png:
editing/selection/unrendered-004-expected.txt:
editing/selection/unrendered-005-expected.checksum:
editing/selection/unrendered-005-expected.png:
editing/selection/unrendered-005-expected.txt:
fast/block/float/019-expected.checksum:
fast/block/float/019-expected.png:
fast/block/float/019-expected.txt:
fast/block/margin-collapse/104-expected.checksum:
fast/block/margin-collapse/104-expected.png:
fast/block/margin-collapse/104-expected.txt:
fast/block/positioning/relative-overflow-block-expected.checksum:
fast/block/positioning/relative-overflow-block-expected.txt:
fast/block/positioning/relative-overflow-replaced-expected.checksum:
fast/block/positioning/relative-overflow-replaced-expected.txt:
fast/block/positioning/relative-overflow-replaced-float-expected.checksum:
fast/block/positioning/relative-overflow-replaced-float-expected.txt:
fast/lists/li-br-expected.checksum:
fast/lists/li-br-expected.png:
fast/lists/li-br-expected.txt:
fast/media/mq-relative-constraints-02-expected.checksum:
fast/media/mq-relative-constraints-02-expected.png:
fast/media/mq-relative-constraints-02-expected.txt:
fast/media/mq-relative-constraints-03-expected.checksum:
fast/media/mq-relative-constraints-03-expected.png:
fast/media/mq-relative-constraints-03-expected.txt:
fast/media/mq-relative-constraints-04-expected.checksum:
fast/media/mq-relative-constraints-04-expected.png:
fast/media/mq-relative-constraints-04-expected.txt:
fast/media/mq-relative-constraints-05-expected.checksum:
fast/media/mq-relative-constraints-05-expected.png:
fast/media/mq-relative-constraints-05-expected.txt:
fast/media/mq-relative-constraints-06-expected.checksum:
fast/media/mq-relative-constraints-06-expected.png:
fast/media/mq-relative-constraints-06-expected.txt:
fast/media/mq-relative-constraints-07-expected.checksum:
fast/media/mq-relative-constraints-07-expected.png:
fast/media/mq-relative-constraints-07-expected.txt:
fast/media/mq-relative-constraints-09-expected.checksum:
fast/media/mq-relative-constraints-09-expected.png:
fast/media/mq-relative-constraints-09-expected.txt:
fast/media/mq-width-absolute-01-expected.checksum:
fast/media/mq-width-absolute-01-expected.png:
fast/media/mq-width-absolute-01-expected.txt:
fast/media/mq-width-absolute-02-expected.checksum:
fast/media/mq-width-absolute-02-expected.png:
fast/media/mq-width-absolute-02-expected.txt:
fast/media/mq-width-absolute-03-expected.checksum:
fast/media/mq-width-absolute-03-expected.png:
fast/media/mq-width-absolute-03-expected.txt:
fast/media/mq-width-absolute-04-expected.checksum:
fast/media/mq-width-absolute-04-expected.png:
fast/media/mq-width-absolute-04-expected.txt:
fast/table/wide-colspan-expected.checksum:
fast/table/wide-colspan-expected.png:
fast/table/wide-colspan-expected.txt:
fast/table/wide-column-expected.checksum:
fast/table/wide-column-expected.png:
fast/table/wide-column-expected.txt:
tables/mozilla/bugs/bug131020-expected.checksum:
tables/mozilla/bugs/bug131020-expected.png:
tables/mozilla/bugs/bug131020-expected.txt:
tables/mozilla/bugs/bug23151-expected.checksum:
tables/mozilla/bugs/bug23151-expected.png:
tables/mozilla/bugs/bug23151-expected.txt:
tables/mozilla/bugs/bug29314-expected.checksum:
tables/mozilla/bugs/bug29314-expected.png:
tables/mozilla/bugs/bug29314-expected.txt:
tables/mozilla/bugs/bug43039-expected.checksum:
tables/mozilla/bugs/bug43039-expected.png:
tables/mozilla/bugs/bug43039-expected.txt:
tables/mozilla/bugs/bug43854-1-expected.checksum:
tables/mozilla/bugs/bug43854-1-expected.png:
tables/mozilla/bugs/bug43854-1-expected.txt:
tables/mozilla/bugs/bug625-expected.checksum:
tables/mozilla/bugs/bug625-expected.png:
tables/mozilla/bugs/bug625-expected.txt:
tables/mozilla/bugs/bug92143-expected.checksum:
tables/mozilla/bugs/bug92143-expected.png:
tables/mozilla/bugs/bug92143-expected.txt:
tables/mozilla/bugs/bug96334-expected.checksum:
tables/mozilla/bugs/bug96334-expected.png:
tables/mozilla/bugs/bug96334-expected.txt:
tables/mozilla/core/misc-expected.checksum:
tables/mozilla/core/misc-expected.png:
tables/mozilla/core/misc-expected.txt:
tables/mozilla/core/nested1-expected.checksum:
tables/mozilla/core/nested1-expected.png:
tables/mozilla/core/nested1-expected.txt:
tables/mozilla_expected_failures/bugs/bug220653-expected.checksum:
tables/mozilla_expected_failures/bugs/bug220653-expected.png:
tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
tables/mozilla_expected_failures/bugs/bug67915-2-expected.checksum:
tables/mozilla_expected_failures/bugs/bug67915-2-expected.png:
tables/mozilla_expected_failures/bugs/bug67915-2-expected.txt:

WebCore:

Reviewed by Hyatt. Patch by Mitz.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9531 Pages that need only a horizontal scroll bar get a vertical one as well

The change affects many existing tests.

page/FrameView.cpp: (WebCore::FrameView::layout): Mark the body renderer as needing layout if the view's height has changed and the body stretches to the view's height.
rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight):
rendering/RenderBox.h: (WebCore::RenderBox::stretchesToViewHeight): Added. Moved the logic for when the HTML block needs to stretch to the view's height from calcHeight() here.

8:00 AM Changeset in webkit [15010] by ap

3 edits
7 adds in trunk

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7461 Always encode the path part of an URI as UTF-8

Test: http/tests/uri/utf8-path.html

platform/KURL.cpp: (encodeRelativeString): Always set pathEncoding to UTF-8.

7:43 AM Changeset in webkit [15009] by ap

18 edits
4 adds in trunk

2006-06-24 Graham Dennis <Graham.Dennis@gmail.com>

Reviewed by Darin, landed by ap.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9467 TreeWalker/NodeIterator do not restrict the traversal

Test: traversal/stay-within-root.html

dom/Node.cpp: (WebCore::Node::traversePreviousNode):
dom/Node.h: Add a stayWithin argument to traversePreviousNode just like the other traversal functions
dom/NodeIterator.cpp: (WebCore::NodeIterator::findNextNode): (WebCore::NodeIterator::findPreviousNode): Ensure that when moving forward or backward that the root node is not exited
dom/TreeWalker.cpp: (WebCore::TreeWalker::previousNode): (WebCore::TreeWalker::nextNode): Ditto (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):

6:50 AM Changeset in webkit [15008] by ap

10 edits
3 adds in trunk

svn-commit.tmp

6:01 AM Changeset in webkit [15007] by ap

4 edits in trunk/WebCore

2006-06-24 Mitz Pettel <opendarwin.org@mitzpettel.com>

Reviewed and landed by ap.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9563 Remove unused layoutSuppressed field and inLayout() method

No test added because there is no change in functionality.

page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::layout):
page/FrameView.h:
rendering/RenderView.cpp: (WebCore::RenderView::layout):

5:53 AM Changeset in webkit [15006] by ap

19 edits in trunk/WebCore

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=8177 Javascript search incredibly slow

No change in functionality, thus no test.

Use info sharing for named collections, too. Moved shared HTMLCollection infos from HTMLDocument
to Document. Renamed collection types to use the preferred WebKit style. Replaced direct
HTMLCollection creation with using accessors from Document in a few places.

bindings/objc/DOMHTML.mm: (-[DOMHTMLElement children]): (-[DOMHTMLDocument images]): (-[DOMHTMLDocument applets]): (-[DOMHTMLDocument links]): (-[DOMHTMLDocument forms]): (-[DOMHTMLDocument anchors]): (-[DOMHTMLMapElement areas]): (-[DOMHTMLTableSectionElement rows]): (-[DOMHTMLTableElement rows]): (-[DOMHTMLTableElement tBodies]): (-[DOMHTMLTableRowElement cells]):
dom/Document.cpp: (WebCore::Document::images): (WebCore::Document::applets): (WebCore::Document::embeds): (WebCore::Document::objects): (WebCore::Document::scripts): (WebCore::Document::links): (WebCore::Document::forms): (WebCore::Document::anchors): (WebCore::Document::all): (WebCore::Document::windowNamedItems): (WebCore::Document::documentNamedItems): (WebCore::Document::nameCollectionInfo):
dom/Document.h: (WebCore::Document::collectionInfo):
html/HTMLCollection.cpp: (WebCore::HTMLCollection::HTMLCollection): (WebCore::HTMLCollection::traverseNextItem): (WebCore::HTMLCollection::checkForNameMatch): (WebCore::HTMLCollection::updateNameCache):
html/HTMLCollection.h: (WebCore::HTMLCollection::):
html/HTMLDocument.h:
html/HTMLElement.cpp: (WebCore::HTMLElement::children):
html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::areas):
html/HTMLNameCollection.h:
html/HTMLNameCollection.cpp: (WebCore::HTMLNameCollection::HTMLNameCollection): (WebCore::HTMLNameCollection::traverseNextItem):
html/HTMLFormCollection.cpp:
html/HTMLOptionsCollection.cpp: (WebCore::HTMLOptionsCollection::HTMLOptionsCollection):
html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::collectionInfo):
html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::rows): (WebCore::HTMLTableElement::tBodies):
html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::cells):
html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::rows):
kwq/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:]):
page/Frame.cpp: (WebCore::Frame::gotoAnchor):

4:50 AM Changeset in webkit [15005] by ap

6 edits in trunk

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9418 WebKit will not build when Space exists in path

Enclose search paths in quotes; create symlinks to avoid passing paths with spaces to make.

JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
WebCore/WebCore.xcodeproj/project.pbxproj:
WebKit/WebKit.xcodeproj/project.pbxproj:

Jun 23, 2006:

10:19 PM Changeset in webkit [15004] by tomernic

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Tim Hatcher.

<rdar://problem/4560947> Leopard REGRESSION: Dragging to TileGame Widget is broken

fast/events/ondragenter-expected.checksum: Added.
fast/events/ondragenter-expected.png: Added.
fast/events/ondragenter-expected.txt: Added.
fast/events/ondragenter.html: Added.

WebCore:

Reviewed by Tim Hatcher.

<rdar://problem/4560947> Leopard REGRESSION: Dragging to TileGame Widget is broken

page/FrameView.cpp: (WebCore::FrameView::updateDragAndDrop): Use the passed mouse event, instead of the "current" event. There is no such thing as a "drag event". Asking for the current event during a drag returns a weird system- internal event with an invalid mouse location.

10:07 PM Changeset in webkit [15003] by thatcher

22 edits
5 adds in trunk/WebCore

Reviewed by Eric.

Manual test added: cursor.html

Bug 9560: should support new CSS3 cursor types to get more resizing directions
http://bugzilla.opendarwin.org/show_bug.cgi?id=9560

Adds support for ew-resize, ns-resize, nesw-resize, nwse-resize,
col-resize and row-resize CSS3 cursor values.

Also converted some of the cursor images to grayscale tiffs,
some were RGB but had no color data.

Resources/eastResizeCursor.tiff:
Resources/eastWestResizeCursor.tiff: Added.
Resources/helpCursor.tiff:
Resources/moveCursor.tiff:
Resources/northEastResizeCursor.tiff:
Resources/northEastSouthWestResizeCursor.tiff: Added.
Resources/northResizeCursor.tiff:
Resources/northSouthResizeCursor.tiff: Added.
Resources/northWestResizeCursor.tiff:
Resources/northWestSouthEastResizeCursor.tiff: Added.
Resources/southEastResizeCursor.tiff:
Resources/southResizeCursor.tiff:
Resources/southWestResizeCursor.tiff:
Resources/textAreaResizeCorner.tiff:
Resources/waitCursor.tiff:
Resources/westResizeCursor.tiff:
WebCore.xcodeproj/project.pbxproj:
css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSValueKeywords.in:
css/cssparser.cpp: (WebCore::CSSParser::parseValue):
manual-tests/cursor.html: Added.
page/FrameView.cpp: (WebCore::selectCursor):
platform/Cursor.h:
platform/mac/CursorMac.mm: (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor):
platform/win/CursorWin.cpp: (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor):
rendering/render_style.h: cursor needs 5 bits now

6:09 PM Changeset in webkit [15002] by thatcher

2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Adding more operator[] overloads for long and short types.

wtf/Vector.h: (WTF::Vector::operator[]):

5:58 PM Changeset in webkit [15001] by kdecker

4 edits in trunk/WebKitTools

4:56 PM Changeset in webkit [15000] by tomernic

2 edits in trunk/WebKit

Reviewed by John Sullivan.

Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): Fixed a bug I found in the CoreGraphics drawing model that was preventing certain types of events from being dispatched to the plugin, unless the plugin was being updated. The check for portState was only required to call -setWindowIfNecessary, not required for the entire event dispatch. Also, don't paint the green debug rect unless this is a QuickDraw plugin. Otherwise the current QD port is not set, and the green rect fills the entire screen. Pretty awesome looking, but not intended behavior. (-[WebBaseNetscapePluginView setWindowIfNecessary]): Improved the logging here to include the NPWindow's width and height.

4:34 PM Changeset in webkit [14999] by thatcher

3 edits in trunk/WebKit

Reviewed by Tim O.

Adds back SPI that Mail is still depending on.

WebView/WebDataSource.m: (-[WebDataSource _addSubframeArchives:]):
WebView/WebDataSourcePrivate.h:

4:12 PM Changeset in webkit [14998] by sullivan

4 edits in trunk/WebCore

Reviewed by Tim Omernick

fixed <rdar://problem/4597685> stale rects for document markers can be left behind in certain cases

dom/Document.h:
dom/Document.cpp: (WebCore::Document::setRenderedRectForMarker): changed parameter from IntRect to const IntRect& at Darin's request (WebCore::Document::invalidateRenderedRectsForMarkersInRect): new method, tests whether the rendered rect for each marker intersects the passed rect. If so, sets the rendered rect back to the placeholder rect that means that the rect for this marker isn't known.

page/Frame.cpp: (WebCore::Frame::paint): call invalidateRenderedRectsForMarkersInRect on the rect we're about to paint. This ensures that old stale rects won't be preserved if the associated marker has moved such that it is out of the painted area.

3:38 PM Changeset in webkit [14997] by justing

1 edit in trunk/WebCore/ChangeLog

Added bug number.

3:36 PM Changeset in webkit [14996] by justing

3 edits
8 adds in trunk

LayoutTests:

Reviewed by levi

editing/deleting/merge-into-empty-block-1-expected.checksum: Added.
editing/deleting/merge-into-empty-block-1-expected.png: Added.
editing/deleting/merge-into-empty-block-1-expected.txt: Added.
editing/deleting/merge-into-empty-block-1.html: Added.
editing/deleting/merge-into-empty-block-2-expected.checksum: Added.
editing/deleting/merge-into-empty-block-2-expected.png: Added.
editing/deleting/merge-into-empty-block-2-expected.txt: Added.
editing/deleting/merge-into-empty-block-2.html: Added.

WebCore:

Reviewed by levi

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): Add a rule for when to merge into empty blocks.

3:08 PM Changeset in webkit [14995] by ggaren

1 edit in trunk/JavaScriptCore/ChangeLog

Reviewed by Adele.

Added JSConstructorMake to match JSFunctionMake, along with test code.

API/JSObjectRef.cpp: (JSConstructorMake):
API/JSObjectRef.h:
API/testapi.c: (myConstructor_callAsConstructor): (main):
API/testapi.js:
ChangeLog:
JavaScriptCore.xcodeproj/project.pbxproj: Moved testapi.c to the testapi target -- this was an oversight in my earlier check-in.

2:43 PM Changeset in webkit [14994] by thatcher

8 copies in tags/Safari-521.13

New tag for 521.13.

2:36 PM Changeset in webkit [14993] by thatcher

3 edits in trunk

Versoning

2:27 PM Changeset in webkit [14992] by thatcher

2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

<rdar://problem/4223619> Safari crashed in -[NSFont isSystemFont]
CFRetain and CFRelease NSFont's when FontPlatformData has a reference.
We only do this when GC is enabled for performance reasons.
No tests possible.

platform/mac/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData):

2:19 PM Changeset in webkit [14991] by justing

5 edits
12 adds in trunk

LayoutTests:

Reviewed by levi

<http://bugzilla.opendarwin.org/show_bug.cgi?id=8074>
Caret before/after block tables is too small
<rdar://problem/4598331>
right arrow out of a table shows cursor in a weird place

Demonstrates 9557:

editing/input/range-for-empty-document-expected.txt: Added:
editing/selection/table-caret-1-expected.checksum: Added.
editing/selection/table-caret-1-expected.png: Added.
editing/selection/table-caret-1-expected.txt: Added.
editing/selection/table-caret-1.html: Added.
editing/selection/table-caret-2-expected.checksum: Added.
editing/selection/table-caret-2-expected.png: Added.
editing/selection/table-caret-2-expected.txt: Added.
editing/selection/table-caret-2.html: Added.
editing/selection/table-caret-3-expected.checksum: Added.
editing/selection/table-caret-3-expected.png: Added.
editing/selection/table-caret-3-expected.txt: Added.
editing/selection/table-caret-3.html: Added.

WebCore:

Reviewed by levi

<http://bugzilla.opendarwin.org/show_bug.cgi?id=8074>
Caret before/after block tables is too small
<rdar://problem/4598331>
right arrow out of a table shows cursor in a weird place

rendering/RenderBox.cpp: (WebCore::RenderBox::caretRect): Don't propagate to children, VisiblePositions inside containers don't refer to children. Don't use the font height for tables.

1:04 PM Changeset in webkit [14990] by thatcher

9 edits in trunk/WebKit

Reviewed by Geoff.

script debugger should only attach to JavaScriptCore when there are listeners
http://bugzilla.opendarwin.org/show_bug.cgi?id=9552

Attaches the debugger to all WebFrames when the first listener
is added. Detaches when the last listener is removed.
Also detach when the script debug delegate is set to nil.

DefaultDelegates/WebScriptDebugServer.m: (+[WebScriptDebugServer listenerCount]): (-[WebScriptDebugServer dealloc]): (-[WebScriptDebugServer attachScriptDebuggerToAllWebViews]): (-[WebScriptDebugServer detachScriptDebuggerFromAllWebViews]): (-[WebScriptDebugServer listenerConnectionDidDie:]): (-[WebScriptDebugServer addListener:]): (-[WebScriptDebugServer removeListener:]):
DefaultDelegates/WebScriptDebugServerPrivate.h:
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge windowObjectCleared]):
WebView/WebFrame.m: (-[WebFrame _attachScriptDebugger]): (-[WebFrame _detachScriptDebugger]):
WebView/WebFramePrivate.h:
WebView/WebScriptDebugDelegate.m: (-[WebScriptCallFrame parsedSource:fromURL:sourceId:]): (-[WebScriptCallFrame enteredFrame:sourceId:line:]): (-[WebScriptCallFrame hitStatement:sourceId:line:]): (-[WebScriptCallFrame leavingFrame:sourceId:line:]):
WebView/WebView.m: (-[WebView _attachScriptDebuggerToAllFrames]): (-[WebView _detachScriptDebuggerFromAllFrames]): (-[WebView setScriptDebugDelegate:]):
WebView/WebViewPrivate.h:

10:51 AM Changeset in webkit [14989] by beidson

3 edits in trunk/WebCore

Reviewed by Kevin.

Added 64-bit String::number() functions

platform/PlatformString.h:
platform/String.cpp: (WebCore::String::number):

10:37 AM Changeset in webkit [14988] by thatcher

1 edit in trunk/WebCore/dom/Document.cpp

Build fix.

9:16 AM Changeset in webkit [14987] by sullivan

4 edits in trunk/WebKit

Reviewed by Tim Omernick

added support for UIDelegate to be notified of scrolling in any WebHTMLView
cleaned up recently-added UIDelegate code

WebView/WebUIDelegatePrivate.h: declared webView:didScrollDocumentInFrameView: method

DefaultDelegates/WebDefaultUIDelegate.m: (-[NSApplication webView:didDrawRect:]): provide default (empty) implementation of this recently-added method, so the DelegateForwarder mechanism will work for it (-[NSApplication webView:didScrollDocumentInFrameView:]): same thing for the new method

WebView/WebHTMLView.m: (-[WebHTMLView _frameOrBoundsChanged]): use _UIDelegateForwarder mechanism to notify delegate that scrolling occurred (-[NSArray drawSingleRect:]): use _UIDelegateForwarder mechanism instead of checking respondsToSelector stuff here (that's packaged up nicely by the forwarder mechanism)

Jun 22, 2006:

9:43 PM Changeset in webkit [14986] by ap

2 edits in trunk/JavaScriptCore

Build fix.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9539 Another case error preventing build

API/JSObjectRef.cpp: Changed "identifier.h" to "Identifier.h"

9:37 PM Changeset in webkit [14985] by ap

4 edits in trunk

Reviewed by darin and ggaren.

see http://bugzilla.opendarwin.org/show_bug.cgi?id=9539 Another case error preventing build

WebKitTools:

Scripts/webkitdirs.pm: Building WebKit now requires Xcode 2.3.

WebKitSite:

building/build.html: Ditto.

9:18 PM Changeset in webkit [14984] by thatcher

10 edits in trunk/WebKitTools

Reviewed by Eric.

Adds a native toolbar to Drosera to be a good citizen.
Adds a Debug menu with key-commands for Continue, Pause and Step Into.
Fixes a dragging bug from an earlier fix to the divider code.
Fixes some poor indenting in debugger.js.

Drosera/DebuggerDocument.h:
Drosera/DebuggerDocument.m: (-[DebuggerDocument stepInto]): (-[DebuggerDocument pause:]): (-[DebuggerDocument resume:]): (-[DebuggerDocument stepInto:]): (-[DebuggerDocument windowDidLoad]): (-[DebuggerDocument toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): (-[DebuggerDocument toolbarDefaultItemIdentifiers:]): (-[DebuggerDocument toolbarAllowedItemIdentifiers:]): (-[DebuggerDocument validateUserInterfaceItem:]):
Drosera/English.lproj/MainMenu.nib/classes.nib:
Drosera/English.lproj/MainMenu.nib/info.nib:
Drosera/English.lproj/MainMenu.nib/keyedobjects.nib:
Drosera/debugger.css:
Drosera/debugger.html:
Drosera/debugger.js:
Drosera/viewer.html:

9:07 PM Changeset in webkit [14983] by ddkilzer

9 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt. Patch by Mitz.

test and updated results for http://bugzilla.opendarwin.org/show_bug.cgi?id=9497 REGRESSION: Incomplete repainting when scrolling thumbnails on Flickr

fast/repaint/clipped-relative-expected.checksum: Added.
fast/repaint/clipped-relative-expected.png: Added.
fast/repaint/clipped-relative-expected.txt: Added.
fast/repaint/clipped-relative.html: Added.
fast/repaint/containing-block-position-change-expected.checksum: Updated.
fast/repaint/containing-block-position-change-expected.png: Updated.

WebCore:

Reviewed by Hyatt. Patch by Mitz.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9497 REGRESSION: Incomplete repainting when scrolling thumbnails on Flickr

Test: fast/repaint/clipped-relative.html

page/FrameView.cpp: (WebCore::FrameView::layout):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::removePositionedObjects): Removed call to computeRepaintRects(). Previously, it was needed to update the cached rects before RenderBox::setStyle() called updateLayerPositions().
rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): Changed to call updateLayerPositions() for a newly- created layer only if it does not need layout. Otherwise, updateLayerPositions() will be called after layout. This saves a repaint in some cases.
rendering/RenderLayer.cpp: (WebCore::RenderLayer::checkForRepaintOnResize): Renamed computeRepaintRects() to this and deleted the code that cached the absolute position and repaint rects. (WebCore::RenderLayer::updateLayerPositions): Added code to cache the absolute position and repaint rects right after updating the layer's position.
rendering/RenderLayer.h:

7:25 PM Changeset in webkit [14982] by thatcher

2 edits in trunk/WebKitTools/Drosera

Adding an image that wasn't added to the project earlier.

7:00 PM Changeset in webkit [14981] by bdakin

2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4599015> REGRESSION: Hand on clock widget
don't appear at all

This regression was caused by <rdar://problem/4567520> HIDPI: pixel
cracks in weather widget at 1.83 scaling

html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): Do the contains check before rounding to integral device pixels.

4:12 PM Changeset in webkit [14980] by andersca

3 edits
2 adds in trunk

WebCore:

2006-06-22 Anders Carlsson <acarlsson@apple.com>

Reviewed by John.

<rdar://problem/4529334> REGRESSION: Can't configure RadarInMotion widget for U.S. locations on Leopard (Javascript errors)

dom/Document.cpp: (WebCore::Document::completeURL): Check if both the URL and base URL are empty instead of using URL() which returns "about:blank" if the URL is empty.

LayoutTests:

2006-06-22 Anders Carlsson <acarlsson@apple.com>

Reviewed by John.

<rdar://problem/4529334> REGRESSION: Can't configure RadarInMotion widget for U.S. locations on Leopard (Javascript errors)

dom/Document.cpp: (WebCore::Document::completeURL): Check if both the URL and base URL are empty instead of using URL() which returns "about:blank" if the URL is empty.

2:31 PM Changeset in webkit [14979] by tomernic

2 edits in trunk/WebKit

Reviewed by NOBODY (build fix)

WebView/WebFrameLoader.m: Import WebMainResourceLoader instead of using @class so that we can call WebMainResourceLoader methods.

2:10 PM Changeset in webkit [14978] by thatcher

8 edits in /

Versioning

12:01 PM Changeset in webkit [14977] by tomernic

2 edits in trunk/WebKit

Reviewed by NOBODY (build fix)

WebView/WebFrameLoader.m: Import JavaScriptCore/Assertions.h instead of WebKit/WebAssertions.h (which no longer exists)

11:48 AM Changeset in webkit [14976] by mjs

5 edits
2 adds in trunk/WebKit

Reviewed by Adele.

start moving loading logic to new WebFrameLoader class; move management of WebLoaders there

Misc/WebIconLoader.h:
Misc/WebIconLoader.m: (-[WebIconLoader didFinishLoading]):
WebKit.xcodeproj/project.pbxproj:
WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _updateLoading]): (-[WebDataSource _loadIcon]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _stopLoading]): (-[WebDataSource _startLoading]): (-[WebDataSource _addSubresourceLoader:]): (-[WebDataSource _removeSubresourceLoader:]): (-[WebDataSource _addPlugInStreamLoader:]): (-[WebDataSource _removePlugInStreamLoader:]): (-[WebDataSource _iconLoaderReceivedPageIcon:]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _stopLoadingWithError:]): (-[WebDataSource _setupForReplaceByMIMEType:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource dealloc]): (-[WebDataSource finalize]): (-[WebDataSource data]): (-[WebDataSource isLoading]):
WebView/WebFrameLoader.h: Added.
WebView/WebFrameLoader.m: Added. (-[WebFrameLoader initWithDataSource:]): (-[WebFrameLoader dealloc]): (-[WebFrameLoader hasIconLoader]): (-[WebFrameLoader loadIconWithRequest:]): (-[WebFrameLoader stopLoadingIcon]): (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoadingPlugIns]): (-[WebFrameLoader isLoadingMainResource]): (-[WebFrameLoader isLoadingSubresources]): (-[WebFrameLoader isLoading]): (-[WebFrameLoader stopLoadingSubresources]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader mainResourceData]): (-[WebFrameLoader releaseMainResourceLoader]): (-[WebFrameLoader cancelMainResourceLoad]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader stopLoadingWithError:]):

11:34 AM Changeset in webkit [14975] by andersca

3 edits
2 adds in trunk

WebCore:

2006-06-22 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4499675> Package Tracker widget always crashes in WebCore::Frame::jScriptEnabled() const + 0

html/HTMLParser.cpp: (WebCore::HTMLParser::noscriptCreateErrorCheck): (WebCore::HTMLParser::canvasCreateErrorCheck): (WebCore::HTMLParser::isInline): Add null-checks for document->frame() since it can be 0 for documents created using createHTMLDocument.

LayoutTests:

2006-06-22 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4499675> Package Tracker widget always crashes in WebCore::Frame::jScriptEnabled() const + 0

fast/dom/noscript-canvas-in-created-html-document-expected.txt: Added.
fast/dom/noscript-canvas-in-created-html-document.html: Added.

10:48 AM Changeset in webkit [14974] by kdecker

3 edits
1 add in trunk/WebKitTools

10:46 AM Changeset in webkit [14973] by andersca

6 edits
4 adds in trunk

WebCore:

2006-06-22 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4524840> Entities contained in DOCTYPE referenced DTD in XSLT source document are unknown

dom/xml_tokenizer.cpp: (WebCore::shouldAllowExternalLoad): Use correct path for the catalog.

(WebCore::errorFunc):
Add error function to keep parser errors from going to the console.

(WebCore::XMLTokenizer::write):
Remove if (0 &&)

(WebCore::XMLTokenizer::end):
Pass DocLoader to xmlDocPtrForString.

(WebCore::xmlDocPtrForString):

dom/xml_tokenizer.h: Add DocLoader argument to xmlDocPtrForString so external DTDs and entities can be loaded.

xml/XSLTProcessor.cpp: (WebCore::xmlDocPtrFromNode): Pass DocLoader to xmlDocPtrForString

LayoutTests:

2006-06-22 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4524840> Entities contained in DOCTYPE referenced DTD in XSLT source document are unknown

fast/xsl/dtd-in-source-document-expected.txt: Added.
fast/xsl/dtd-in-source-document.xml: Added.
fast/xsl/resources/dtd-in-source-document.dtd: Added.
fast/xsl/resources/dtd-in-source-document.xsl: Added.

10:34 AM Changeset in webkit [14972] by thatcher

8 edits in trunk/WebKitTools

Reviewed by Kevin Decker.

Code clean up. Adds the stackframe and makes only the body
of the tables scrollable keeping the header visible.
Shows the current function stack when paused or stepping.

Drosera/DebuggerApplication.m: (-[DebuggerApplication awakeFromNib]): (-[DebuggerApplication numberOfRowsInTableView:]): (-[DebuggerApplication tableView:objectValueForTableColumn:row:]):
Drosera/DebuggerDocument.h:
Drosera/DebuggerDocument.m: (-[DebuggerDocument dealloc]): (-[DebuggerDocument currentFrame]): (-[DebuggerDocument currentFrameFunctionName]): (-[DebuggerDocument currentFunctionStack]): (-[DebuggerDocument log:]): (-[DebuggerDocument windowWillClose:]): (-[DebuggerDocument webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[DebuggerDocument webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
Drosera/Drosera.xcodeproj/project.pbxproj:
Drosera/debugger.css:
Drosera/debugger.html:
Drosera/debugger.js:

10:18 AM Changeset in webkit [14971] by ap

2 edits in trunk/WebKitTools

Reviewed by Anders.

Teach run-webkit-httpd to properly look for webkitdirs.pm.

Scripts/run-webkit-httpd:

8:01 AM Changeset in webkit [14970] by kdecker

5 edits
5 adds in trunk/WebKitTools

3:38 AM Changeset in webkit [14969] by ddkilzer

2 edits in trunk/JavaScriptCore

JavaScriptCore:

Build fix.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9539
Another case error preventing build

API/APICast.h: Changed "UString.h" to "ustring.h".

Jun 21, 2006:

5:58 PM Changeset in webkit [14968] by hyatt

5 edits in trunk/WebCore

Back out -webkit-overlay and just rename it back to overlay.

Reviewed by darin

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSValueKeywords.in:
css/cssparser.cpp: (WebCore::CSSParser::parseValue):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):

5:26 PM Changeset in webkit [14967] by thatcher

1 copy in tags/WebCore-315.14.3/WebCore

Tag for WebCore 315.14.3 (part 2 of 2.)

5:26 PM Changeset in webkit [14966] by thatcher

1 add in tags/WebCore-315.14.3

Tag for WebCore 315.14.3 (part 1 of 2.)

5:26 PM Changeset in webkit [14965] by thatcher

2 edits in branches/Safari-1-3-branch/WebCore

Versioning

5:22 PM Changeset in webkit [14964] by thatcher

1 copy in tags/WebCore-418.19.1/WebCore

Tag for WebCore 418.19.1 (part 2 of 2.)

5:22 PM Changeset in webkit [14963] by thatcher

1 add in tags/WebCore-418.19.1

Tag for WebCore 418.19.1 (part 1 of 2.)

5:20 PM Changeset in webkit [14962] by justing

4 edits
12 adds in trunk

LayoutTests:

Reviewed by levi

editing/deleting/table-cells-expected.checksum: Added.
editing/deleting/table-cells-expected.png: Added.
editing/deleting/table-cells-expected.txt: Added.
editing/deleting/table-cells.html: Added.
editing/inserting/paragraph-separator-in-table-1-expected.checksum: Added.
editing/inserting/paragraph-separator-in-table-1-expected.png: Added.
editing/inserting/paragraph-separator-in-table-1-expected.txt: Added.
editing/inserting/paragraph-separator-in-table-1.html: Added.
editing/inserting/paragraph-separator-in-table-2-expected.checksum: Added.
editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
editing/inserting/paragraph-separator-in-table-2-expected.txt: Added.
editing/inserting/paragraph-separator-in-table-2.html: Added.

WebCore:

Reviewed by levi

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): Fix a bug in the code to stop merges across table cells. (WebCore::DeleteSelectionCommand::mergeParagraphs): Move the code to stop merges across table cells to initializePositionData so that its changes to m_mergeBlocksAfterDelete can take effect on the endingPosition.
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Turn into an InsertLineBreak instead of splitting/cloning a table cell.

5:13 PM Changeset in webkit [14961] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Versioning

5:00 PM Changeset in webkit [14960] by thatcher

2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This fixes <rdar://problem/4571273> WebCore crash in khtml::RenderObject::getAbsoluteRepaintRectWithOutline

2005-10-21 Beth Dakin <Beth Dakin>

Reviewed by Hyatt

Fix for <rdar://problem/3947202> certain sequence of DOM
method calls involving CSS outline and display crashes Safari
(in repaint code).

khtml/rendering/render_flow.cpp: (RenderFlow::destroy): Need to set m_continuation to 0 after it is destroyed to prevent possible crashes.

4:50 PM Changeset in webkit [14959] by hyatt

4 adds in trunk/LayoutTests/fast/overflow

Add overflow-x and overflow-y tests.

4:40 PM Changeset in webkit [14958] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This fixes <rdar://problem/4571273> WebCore crash in khtml::RenderObject::getAbsoluteRepaintRectWithOutline

2005-10-21 Beth Dakin <Beth Dakin>

Reviewed by Hyatt

Fix for <rdar://problem/3947202> certain sequence of DOM
method calls involving CSS outline and display crashes Safari
(in repaint code).

khtml/rendering/render_flow.cpp: (RenderFlow::destroy): Need to set m_continuation to 0 after it is destroyed to prevent possible crashes.

4:38 PM Changeset in webkit [14957] by bdakin

3 edits in trunk/WebCore

Reviewed by John.

Fix for <rdar://problem/3914965> Misspelled text underline doesn't
look right at non-standard scale factors

platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspelling): We need to call into our previously-created SPI for pattern-drawing so that the phase is right at all scale factors.

4:15 PM Changeset in webkit [14956] by thatcher

4 edits in trunk

Switching to Stabs debugging format for Production builds.

4:13 PM Changeset in webkit [14955] by beidson

2 edits in trunk/WebKit

Reviewed by Maciej

The WebCoreIconDatabaseBridge was getting messages sent to it after it had been closed, resulting in a crash
on an ASSERT(). After closing the databaseBridge, we simply set it to nil so this can't happen.
anymore.

Misc/WebIconDatabase.m: (-[WebIconDatabase _applicationWillTerminate:]):

4:10 PM Changeset in webkit [14954] by ggaren

4 edits in trunk/JavaScriptCore

Fixed release build, fixed accidental infinite recursion due to
last minute global replace gone awry.

API/APICast.h: (toRef):
API/testapi.c: (assertEqualsAsBoolean): (assertEqualsAsNumber): (assertEqualsAsUTF8String): (assertEqualsAsCharactersPtr):
JavaScriptCore.xcodeproj/project.pbxproj:

3:45 PM Changeset in webkit [14953] by hyatt

18 edits in trunk/WebCore

Fix for 7362, implement the CSS3 overflow-x and overflow-y properties.

Reviewed by adele

WebCore.xcodeproj/project.pbxproj:
css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSPropertyNames.in:
css/cssparser.cpp: (WebCore::CSSParser::parseValue):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty):
page/FrameView.cpp: (WebCore::FrameView::applyOverflowToViewport): (WebCore::FrameView::layout):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::determineHorizontalPosition): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::rightOffset): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::calcMinMaxWidth):
rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::contentWidth): (WebCore::RenderBox::contentHeight): (WebCore::RenderBox::sizesToIntrinsicWidth): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcPercentageHeight):
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::shouldAutoscroll): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::RenderLayer::styleChanged):
rendering/RenderLayer.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::clientWidth): (WebCore::RenderObject::clientHeight):
rendering/RenderObject.h: (WebCore::RenderObject::hasAutoVerticalScrollbar): (WebCore::RenderObject::hasAutoHorizontalScrollbar): (WebCore::RenderObject::scrollsOverflow): (WebCore::RenderObject::scrollsOverflowX): (WebCore::RenderObject::scrollsOverflowY): (WebCore::RenderObject::includeVerticalScrollbarSize): (WebCore::RenderObject::includeHorizontalScrollbarSize):
rendering/RenderTextArea.cpp: (WebCore::RenderTextArea::setStyle):
rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): (WebCore::RenderTextField::calcHeight): (WebCore::RenderTextField::calcMinMaxWidth):
rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
rendering/render_style.cpp: (WebCore::RenderStyle::diff):
rendering/render_style.h: (WebCore::): (WebCore::RenderStyle::NonInheritedFlags::operator==): (WebCore::RenderStyle::setBitDefaults): (WebCore::RenderStyle::overflowX): (WebCore::RenderStyle::overflowY): (WebCore::RenderStyle::setOverflowX): (WebCore::RenderStyle::setOverflowY): (WebCore::RenderStyle::initialOverflowX): (WebCore::RenderStyle::initialOverflowY):

2:22 PM Changeset in webkit [14952] by justing

37 edits
9 adds
1 delete in trunk

LayoutTests:

Reviewed by levi

<rdar://problem/4590366>
REGRESSION: Selection incorrectly paints gaps on TOT

Added:

editing/selection/line-wrap-1-expected.checksum: Added.
editing/selection/line-wrap-1-expected.png: Added.
editing/selection/line-wrap-1-expected.txt: Added.
editing/selection/line-wrap-1.html: Added.
editing/selection/line-wrap-2-expected.checksum: Added.
editing/selection/line-wrap-2-expected.png: Added.
editing/selection/line-wrap-2-expected.txt: Added.
editing/selection/line-wrap-2.html: Added. Fixes:
editing/execCommand/findString-expected.checksum:
editing/execCommand/findString-expected.png:
editing/execCommand/findString-expected.txt:
editing/inserting/editing-empty-divs-expected.checksum:
editing/inserting/editing-empty-divs-expected.png:
editing/inserting/editing-empty-divs-expected.txt:
editing/inserting/insert-3659587-fix-expected.txt:
editing/inserting/insert-tab-002-expected.txt:
editing/inserting/insert-text-with-newlines-expected.txt:
editing/inserting/typing-001-expected.txt:
editing/inserting/typing-003-expected.txt:
editing/inserting/typing-around-br-001-expected.txt:
editing/style/remove-underline-across-paragraph-expected.txt:
editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
editing/style/remove-underline-after-paragraph-expected.txt:
editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
editing/style/remove-underline-expected.txt:
editing/style/remove-underline-from-stylesheet-expected.txt:
editing/style/remove-underline-in-bold-expected.txt:
editing/style/typing-style-002-expected.txt:
editing/style/typing-style-003-expected.txt:
editing/style/unbold-in-bold-expected.txt:
editing/style/underline-expected.txt: Disabled (9337):
editing/input/attributed-substring-from-range-lines.html

WebCore:

Reviewed by levi

<rdar://problem/4590366>
REGRESSION: Selection incorrectly paints gaps on TOT

dom/Document.cpp: (WebCore::Document::updateSelection): Use the leftmost candidate for the end of the selection and the rightmost candidate for the start of the selection.
dom/Position.cpp: (WebCore::Position::upstream): Cross line wraps so that we can use upstream/downstream to get to candidates before/after linewraps. (WebCore::Position::downstream): (WebCore::Position::inRenderedContent):
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): (WebCore::DeleteSelectionCommand::mergeParagraphs):
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Ensure that the leftmost candidate is used. We should sample the style from that one. When the block to insert is after a br, a br should be inserted even in strict mode.
editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Insert at the leftmost candidate, get rid of a use of trailingWhitespacePosition. Don't apply a style if its unnecessary.
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): "pos" can be invalidated, don't use it.
editing/VisiblePosition.cpp: Renamed initDeepPosition and made it return the canonical position. (WebCore::VisiblePosition::init): (WebCore::VisiblePosition::canonicalPosition):
editing/VisiblePosition.h: (WebCore::VisiblePosition::characterBefore): Added.
editing/visible_units.cpp: (WebCore::startOfParagraph):
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionState): When a selection ends at a line wrap, it shouldn't extend onto the next line.

2:09 PM Changeset in webkit [14951] by ggaren

20 edits
19 adds in trunk

JavaScriptCore:

Reviewed by Anders.

First cut at C API to JavaScript. Includes a unit test, 'testapi.c', and the outline of a test app, 'minidom.c'.

Includes one change to JSC internals: Rename propList to getPropertyList and have it
take its target property list by reference so that subclasses can
add properties to the list before calling through to their superclasses.

Also, I just ran prepare-ChangeLog in about 10 seconds, and I would like
to give a shout-out to that.

API/APICast.h: Added. (toJS): (toRef):
API/JSBase.h: Added.
API/JSCallbackObject.cpp: Added. (KJS::): (KJS::JSCallbackObject::JSCallbackObject): (KJS::JSCallbackObject::~JSCallbackObject): (KJS::JSCallbackObject::className): (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::implementsConstruct): (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::implementsCall): (KJS::JSCallbackObject::callAsFunction): (KJS::JSCallbackObject::getPropertyList): (KJS::JSCallbackObject::toBoolean): (KJS::JSCallbackObject::toNumber): (KJS::JSCallbackObject::toString): (KJS::JSCallbackObject::setPrivate): (KJS::JSCallbackObject::getPrivate): (KJS::JSCallbackObject::cachedValueGetter): (KJS::JSCallbackObject::callbackGetter):
API/JSCallbackObject.h: Added. (KJS::JSCallbackObject::classInfo):
API/JSCharBufferRef.cpp: Added. (JSStringMake): (JSCharBufferCreate): (JSCharBufferCreateUTF8): (JSCharBufferRetain): (JSCharBufferRelease): (JSValueCopyStringValue): (JSCharBufferGetLength): (JSCharBufferGetCharactersPtr): (JSCharBufferGetCharacters): (JSCharBufferGetMaxLengthUTF8): (JSCharBufferGetCharactersUTF8): (JSCharBufferIsEqual): (JSCharBufferIsEqualUTF8): (JSCharBufferCreateWithCFString): (CFStringCreateWithJSCharBuffer):
API/JSCharBufferRef.h: Added.
API/JSContextRef.cpp: Added. (JSContextCreate): (JSContextDestroy): (JSContextGetGlobalObject): (JSEvaluate): (JSCheckSyntax): (JSContextHasException): (JSContextGetException): (JSContextClearException): (JSContextSetException):
API/JSContextRef.h: Added.
API/JSObjectRef.cpp: Added. (JSValueToObject): (JSObjectMake): (JSFunctionMake): (JSObjectGetDescription): (JSObjectGetPrototype): (JSObjectSetPrototype): (JSObjectHasProperty): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectDeleteProperty): (JSObjectGetPrivate): (JSObjectSetPrivate): (JSObjectIsFunction): (JSObjectCallAsFunction): (JSObjectIsConstructor): (JSObjectCallAsConstructor): (JSPropertyListEnumerator::JSPropertyListEnumerator): (JSObjectCreatePropertyEnumerator): (JSPropertyEnumeratorGetNext): (JSPropertyEnumeratorRetain): (JSPropertyEnumeratorRelease): (JSPropertyListAdd):
API/JSObjectRef.h: Added.
API/JSValueRef.cpp: Added. (JSValueGetType): (JSValueIsUndefined): (JSValueIsNull): (JSValueIsBoolean): (JSValueIsNumber): (JSValueIsString): (JSValueIsObject): (JSValueIsEqual): (JSValueIsStrictEqual): (JSUndefinedMake): (JSNullMake): (JSBooleanMake): (JSNumberMake): (JSValueToBoolean): (JSValueToNumber): (JSGCProtect): (JSGCUnprotect): (JSGCCollect):
API/JSValueRef.h: Added.
API/JavaScriptCore.h: Added.
API/minidom.c: Added. (main):
API/minidom.html: Added.
API/minidom.js: Added.
API/testapi.c: Added. (assertEqualsAsBoolean): (assertEqualsAsNumber): (assertEqualsAsUTF8String): (assertEqualsAsCharactersPtr): (assertEqualsAsCharacters): (MyObject_initialize): (MyObject_copyDescription): (MyObject_hasProperty): (MyObject_getProperty): (MyObject_setProperty): (MyObject_deleteProperty): (MyObject_getPropertyList): (MyObject_callAsFunction): (MyObject_callAsConstructor): (MyObject_convertToType): (MyObject_finalize): (print_callAsFunction): (main): (createStringWithContentsOfFile):
API/testapi.js: Added.
ChangeLog:
JavaScriptCore.xcodeproj/project.pbxproj:
bindings/npruntime_impl.h:
kjs/array_instance.h:
kjs/array_object.cpp: (ArrayInstance::getPropertyList):
kjs/interpreter.cpp: (KJS::Interpreter::evaluate):
kjs/nodes.cpp: (ForInNode::execute):
kjs/object.cpp: (KJS::JSObject::put): (KJS::JSObject::canPut): (KJS::JSObject::deleteProperty): (KJS::JSObject::propertyIsEnumerable): (KJS::JSObject::getPropertyAttributes): (KJS::JSObject::getPropertyList):
kjs/object.h:
kjs/property_map.cpp: (KJS::PropertyMap::get):
kjs/property_map.h:
kjs/scope_chain.cpp: (KJS::ScopeChain::print):
kjs/string_object.cpp: (StringInstance::getPropertyList):
kjs/string_object.h:
kjs/ustring.h: (KJS::UString::Rep::ref):

JavaScriptGlue:

Reviewed by Anders.

Required for JS API: Rename propList to getPropertyList and have it take its target property list by reference so that subclasses can add properties to the list before calling through to their superclasses.

JSUtils.cpp: (KJSValueToCFTypeInternal):
JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames):
UserObjectImp.cpp: (UserObjectImp::getPropertyList):
UserObjectImp.h:

1:46 PM Changeset in webkit [14950] by bdakin

1 edit in trunk/WebCore/ChangeLog

Fixing ChangeLog.

1:44 PM Changeset in webkit [14949] by bdakin

2 edits in trunk/WebCore

Reviewed and committed by Beth.

Fix for <rdar://problem/4595337> Resizing a containing block
strictly vertically does not cause contained height:100% element to
also be resized.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Also layout if the child's min or max height is a percent.

1:35 PM Changeset in webkit [14948] by andersca

9 edits
3 adds in trunk

WebCore:

2006-06-21 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

http://bugzilla.opendarwin.org/show_bug.cgi?id=6058
XMLTokenizer runs all <script> tags at once instead of as they're encountered

dom/xml_tokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer): Initialize new members.

(WebCore::XMLTokenizer::endElementNs):
If we've encountered a script tag, execute the script here. If the script
tag refers to an external resource, pause the parser while loading it.

(WebCore::XMLTokenizer::end):
Move code from finish() to here

(WebCore::XMLTokenizer::finish):
Only call end() if the parser isn't paused.

(WebCore::XMLTokenizer::notifyFinished):
Evaluate the script here and resume the parser.

(WebCore::XMLTokenizer::resumeParsing):
If finish() was called, call end() after writing all data.

LayoutTests:

2006-06-21 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

http://bugzilla.opendarwin.org/show_bug.cgi?id=6058
XMLTokenizer runs all <script> tags at once instead of as they're encountered

dom/svg/level3/xpath/svgunit.js: The XPath tests depend on the document being loaded before running the tests. Add a "load" event listener and run the test in the handler.

fast/canvas/quadraticCurveTo.xml: Add onload handler and run tests there.

fast/innerHTML/004-expected.txt:
fast/innerHTML/004.xhtml: Add load event listener and run test there.

fast/parser/external-entities-expected.txt: This now dumps as text because the script is ran before the parse error is encountered.

fast/parser/resources/xhtml-scripts.js: Added.
fast/parser/xhtml-scripts-expected.txt: Added.
fast/parser/xhtml-scripts.xhtml: Added. Add new tests.

svg/custom/text-hit-test.svg: Run test in onload handler.

12:29 PM Changeset in webkit [14947] by tomernic

9 edits in trunk/WebKit

Reviewed by Geoff Garen.

<rdar://problem/4564131> WebPluginDatabase setAdditionalWebPlugInPaths needs to be per WebView

Added some WebView SPI so that individual WebViews may have different plugin search paths. There are some
limitations with the approach taken here:

JavaScript may only access the global plugin DB.
When this SPI is in use, certain WebView methods may not give accurate results, such as +canShowMIMEType:.
This only works for plugins referenced using the <object> or <embed> tags; plugins that reside in non-standard file system locations may not be loaded directly into frames.

None of these issues are important to the client that needs this SPI. Rather than re-architect our entire
plugin database, I think it is better to simply accept these limitations for now.

Plugins/WebPluginDatabase.h: Added "plugInPaths" ivar, so different plugin databases can have different search paths.
Plugins/WebPluginDatabase.m: (+[WebPluginDatabase installedPlugins]): Give the global plugin database the default plugin search paths. (+[WebPluginDatabase setAdditionalWebPlugInPaths:]): Removed static global; this method now sets the plugin paths on the global plugin database. (-[WebPluginDatabase setPlugInPaths:]): Setter method for plugin paths. (-[WebPluginDatabase close]): New method; called when the plugin database is no longer needed (when its WebView is being destroyed). (-[WebPluginDatabase init]): Don't refresh in -init, so that callers can set the DB's plugin path array before it refreshes. (-[WebPluginDatabase dealloc]): Moved here from near the bottom of the file. Release new ivar. (-[WebPluginDatabase refresh]): Use the plugInPaths ivar instead of calling pluginLocations(). Notify plugin packages when they are added to and removed from a plugin database. A plugin package will unload itself when it is removed from all of its plugin databases. The only really tricky thing here is that the global MIME <-> view class registrations are only modified by the shared plugin DB. (+[WebPluginDatabase _defaultPlugInPaths]): Refactored from the old pluginLocations() function; returns the default set of plugin search paths.

Plugins/WebBasePluginPackage.h:
Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage dealloc]): Assert that this package has been removed from all of its containing plugin databases. (-[WebBasePluginPackage finalize]): ditto (-[WebBasePluginPackage wasAddedToPluginDatabase:]): Add plugin database to set. (-[WebBasePluginPackage wasRemovedFromPluginDatabase:]): Remove plugin database from set. If it was the last DB, then unload the plugin package.

WebView/WebViewInternal.h: Added instance methods to find the view class or plugin package, given a MIME type or file extension.
WebView/WebViewPrivate.h: Added SPI to set plugin search paths per WebView.
WebView/WebView.m: (-[WebView _viewClass:andRepresentationClass:forMIMEType:]): New method; tries the global MIME <-> view map first; failing that, it checks the WebView's plugin DB. (-[WebView _close]): Close the plugin DB. (-[WebView _setAdditionalWebPlugInPaths:]): Create the plugin DB if necessary, and set its plugin paths. (-[WebView _pluginForMIMEType:]): Checks global plugin DB, falls back on WebView DB. (-[WebView _pluginForExtension:]): ditto (-[WebView _isMIMETypeRegisteredAsPlugin:]): ditto

WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]): Use new WebView instance methods to look for plugins. (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]): ditto (-[WebFrameBridge determineObjectFromMIMEType:URL:]): ditto

10:47 AM Changeset in webkit [14946] by sfalken

2 edits in trunk/WebCore

2006-06-21 Steve Falkenburg <sfalken@apple.com>

Fix build break

platform/win/TemporaryLinkStubs.cpp: (FrameWin::shouldInterruptJavaScript):

9:21 AM Changeset in webkit [14945] by ap

1 edit
1 add in trunk/WebKitTools

Reviewed by Anders.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9516 Would like a script to run a httpd server with the same configuration as run-webkit-tests http

Scripts/run-webkit-httpd: Added.

8:27 AM Changeset in webkit [14944] by andersca

2 edits in trunk/WebKitSite

2006-06-21 Joost de Valk <jdevalk@opendarwin.org>

Reviewed and landed by Anders.

blog/wp-content/themes/webkit/sidebar.php: Add link to Wiki in the navigation menu here too.

6:50 AM Changeset in webkit [14943] by andersca

2 edits in trunk/WebKitSite

2006-06-21 Joost de Valk <jdevalk@opendarwin.org>

Reviewed and landed by Anders.

nav.inc: Add link to Wiki in the navigation menu.

6:24 AM Changeset in webkit [14942] by andersca

3 edits in trunk/WebCore

2006-06-21 Anders Carlsson <acarlsson@apple.com>

Move FrameWin::shouldInterruptJavaScript to TemporaryLinkStubs.cpp

bridge/win/FrameWin.cpp:
platform/win/TemporaryLinkStubs.cpp: (FrameWin::shouldInterruptJavaScript):

1:40 AM Changeset in webkit [14941] by adele

4 edits in trunk/WebCore

Reviewed by Maciej.

Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=9523
More Win32 build bustage.

WebCore.vcproj/WebCore/WebCore.vcproj:
bridge/win/FrameWin.cpp: (WebCore::FrameWin::shouldInterruptJavaScript):
bridge/win/FrameWin.h:

12:45 AM Changeset in webkit [14940] by thatcher

7 edits
3 adds in trunk/WebKitTools

Reviewed by Eric.

Builds Drosera and a launcher to include with the nightly.

BuildSlaveSupport/build-launcher-app:
BuildSlaveSupport/build-launcher-dmg:
Drosera/Drosera.xcodeproj/project.pbxproj:
Drosera/Info.plist:
Drosera/LauncherInfo.plist: Added.
Drosera/launcher.m: Added. (displayErrorAndQuit): (checkMacOSXVersion): (myExecve): (main):
Scripts/build-drosera
WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
WebKitLauncher/main.m: (main):

12:27 AM Changeset in webkit [14939] by mjs

16 edits in trunk/LayoutTests

No review - updated results for earlier patch.

updated SVG test results where my recent fix affected bounding boxes

I think the new results are more accurate bounding boxes and in
any case there is no actual difference in rendered output.

svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
svg/custom/foreign-object-skew-expected.txt:
svg/custom/image-with-transform-clip-filter-expected.txt:
svg/custom/text-image-opacity-expected.txt:

12:27 AM Changeset in webkit [14938] by adele

4 edits in trunk/LayoutTests/dom

Updated results for: http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>

12:26 AM Changeset in webkit [14937] by adele

9 edits in trunk/LayoutTests/tables/mozilla/bugs

Updated results for: http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>

12:23 AM Changeset in webkit [14936] by adele

94 edits in trunk/LayoutTests

Reviewed by Anders.

Updated results for: http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>

Changes include some size differences since the new textareas have 4 pixels less horizontal padding,
and the renderer name for textareas has changed from RenderTextArea to RenderTextField.

dom/html/level2/html/HTMLTextAreaElement14-expected.txt:
dom/html/level2/html/HTMLTextAreaElement15-expected.txt:
dom/xhtml/level2/html/HTMLTextAreaElement14-expected.txt:
dom/xhtml/level2/html/HTMLTextAreaElement15-expected.txt:
fast/block/margin-collapse/103-expected.checksum:
fast/block/margin-collapse/103-expected.png:
fast/block/margin-collapse/103-expected.txt:
fast/dynamic/008-expected.checksum:
fast/dynamic/008-expected.png:
fast/dynamic/008-expected.txt:
fast/forms/001-expected.checksum:
fast/forms/002-expected.checksum:
fast/forms/003-expected.checksum:
fast/forms/004-expected.checksum:
fast/forms/005-expected.checksum:
fast/forms/006-expected.checksum:
fast/forms/007-expected.checksum:
fast/forms/8250-expected.checksum:
fast/forms/blankbuttons-expected.checksum:
fast/forms/button-cannot-be-nested-expected.checksum:
fast/forms/button-default-title-expected.checksum:
fast/forms/button-inner-block-reuse-expected.checksum:
fast/forms/button-positioned-expected.checksum:
fast/forms/button-sizes-expected.checksum:
fast/forms/button-table-styles-expected.checksum:
fast/forms/button-white-space-expected.checksum:
fast/forms/checkbox-radio-onchange-expected.checksum:
fast/forms/cursor-position-expected.txt:
fast/forms/double-focus-expected.txt:
fast/forms/file-input-disabled-expected.checksum:
fast/forms/form-element-geometry-expected.checksum:
fast/forms/form-element-geometry-expected.png:
fast/forms/form-element-geometry-expected.txt:
fast/forms/form-hides-table-expected.checksum:
fast/forms/formmove-expected.checksum:
fast/forms/formmove2-expected.checksum:
fast/forms/formmove3-expected.checksum:
fast/forms/indeterminate-expected.checksum:
fast/forms/input-appearance-bkcolor-expected.checksum:
fast/forms/input-appearance-default-bkcolor-expected.checksum:
fast/forms/input-appearance-disabled-expected.checksum:
fast/forms/input-appearance-focus-expected.checksum:
fast/forms/input-appearance-minWidth-expected.checksum:
fast/forms/input-appearance-preventDefault-expected.checksum:
fast/forms/input-appearance-readonly-expected.checksum:
fast/forms/input-appearance-selection-expected.checksum:
fast/forms/input-appearance-visibility-expected.checksum:
fast/forms/input-appearance-width-expected.checksum:
fast/forms/input-baseline-expected.checksum:
fast/forms/input-disabled-color-expected.checksum:
fast/forms/input-double-click-selection-gap-bug-expected.checksum:
fast/forms/input-maxlength-2-expected.checksum:
fast/forms/input-no-renderer-expected.checksum:
fast/forms/input-paste-undo-expected.checksum:
fast/forms/input-readonly-dimmed-expected.checksum:
fast/forms/input-readonly-empty-expected.checksum:
fast/forms/input-spaces-expected.checksum:
fast/forms/input-table-expected.checksum:
fast/forms/input-text-click-inside-expected.checksum:
fast/forms/input-text-click-outside-expected.checksum:
fast/forms/input-text-double-click-expected.checksum:
fast/forms/input-text-drag-down-expected.checksum:
fast/forms/input-text-maxlength-expected.checksum:
fast/forms/input-text-option-delete-expected.checksum:
fast/forms/input-text-paste-maxlength-expected.checksum:
fast/forms/input-text-scroll-left-on-blur-expected.checksum:
fast/forms/input-text-self-emptying-click-expected.checksum:
fast/forms/input-value-expected.checksum:
fast/forms/input-width-expected.checksum:
fast/forms/minWidthPercent-expected.checksum:
fast/forms/negativeLineHeight-expected.checksum:
fast/forms/negativeLineHeight-expected.png:
fast/forms/negativeLineHeight-expected.txt:
fast/forms/option-index-expected.checksum:
fast/forms/option-script-expected.checksum:
fast/forms/option-strip-whitespace-expected.checksum:
fast/forms/plaintext-mode-2-expected.checksum:
fast/forms/radio-attr-order-expected.checksum:
fast/forms/radio_checked-expected.checksum:
fast/forms/radio_checked_dynamic-expected.checksum:
fast/forms/selection-functions-expected.txt:
fast/forms/tabbing-input-iframe-expected.checksum:
fast/forms/textAreaLineHeight-expected.checksum:
fast/forms/textAreaLineHeight-expected.png:
fast/forms/textAreaLineHeight-expected.txt:
fast/forms/textarea-crlf-expected.txt:
fast/forms/textarea-setinnerhtml-expected.checksum:
fast/forms/textarea-setinnerhtml-expected.png:
fast/forms/textarea-setinnerhtml-expected.txt:
fast/forms/textarea-setvalue-submit-expected.txt:
fast/forms/visual-hebrew-text-field-expected.checksum:
fast/replaced/width100percent-expected.checksum:
fast/replaced/width100percent-expected.png:
fast/replaced/width100percent-expected.txt:
fast/table/003-expected.checksum:
fast/table/003-expected.png:
fast/table/003-expected.txt:
tables/mozilla/bugs/bug194024-expected.checksum:
tables/mozilla/bugs/bug194024-expected.png:
tables/mozilla/bugs/bug194024-expected.txt:
tables/mozilla/bugs/bug30559-expected.checksum:
tables/mozilla/bugs/bug30559-expected.png:
tables/mozilla/bugs/bug30559-expected.txt:
tables/mozilla/bugs/bug30692-expected.checksum:
tables/mozilla/bugs/bug30692-expected.png:
tables/mozilla/bugs/bug30692-expected.txt:

12:23 AM Changeset in webkit [14935] by adele

3 edits in trunk/WebCore

Reviewed by Anders.

Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>

css/html4.css:
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::selectionStart): (WebCore::HTMLTextAreaElement::selectionEnd): (WebCore::HTMLTextAreaElement::setSelectionStart): (WebCore::HTMLTextAreaElement::setSelectionEnd): (WebCore::HTMLTextAreaElement::select): (WebCore::HTMLTextAreaElement::setSelectionRange): (WebCore::HTMLTextAreaElement::createRenderer): (WebCore::HTMLTextAreaElement::appendFormData): (WebCore::HTMLTextAreaElement::isKeyboardFocusable): (WebCore::HTMLTextAreaElement::isMouseFocusable): (WebCore::HTMLTextAreaElement::focus): (WebCore::HTMLTextAreaElement::defaultEventHandler): (WebCore::HTMLTextAreaElement::updateValue): (WebCore::HTMLTextAreaElement::setValue):

Jun 20, 2006:

6:42 PM Changeset in webkit [14934] by beidson

2 edits in trunk/WebCore

Reviewed by Maciej

Fixed capitalization mistake that I made, someone else fixed, then I accidentally made it go back to the old way

icon/SQLStatement.cpp:

6:29 PM Changeset in webkit [14933] by beidson

16 edits
1 add in trunk

WebCore:

Reviewed by Maciej.

More changes/additions setting the stage for the major IconDatabase hookup.

WebCore.xcodeproj/project.pbxproj: Added SQLTransaction.cpp

bridge/mac/WebCoreIconDatabaseBridge.h: Added call-throughs and translations to pass WebKit DB to WebCore DB
bridge/mac/WebCoreIconDatabaseBridge.mm: (+[WebCoreIconDatabaseBridge sharedBridgeInstance]): (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]): (-[WebCoreIconDatabaseBridge iconForURL:withSize:]): (-[WebCoreIconDatabaseBridge iconURLForURL:]): (-[WebCoreIconDatabaseBridge defaultIconWithSize:]): (-[WebCoreIconDatabaseBridge retainIconForURL:]): (-[WebCoreIconDatabaseBridge releaseIconForURL:]): (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]): (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]): (-[WebCoreIconDatabaseBridge _setIconURL:forURL:]): (-[WebCoreIconDatabaseBridge _hasIconForIconURL:]):

bridge/mac/WebCorePageBridge.mm: Added WebCore's IconDatabase logging channel to the user-prefs check (initializeLoggingChannelsIfNecessary):

icon/IconDatabase.cpp: Added stubs and basic SQL usage to create the sqlite DB and respond to WebKit calls (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::open): (WebCore::IconDatabase::close): (WebCore::IconDatabase::isValidDatabase): (WebCore::IconDatabase::recreateDatabase): (WebCore::IconDatabase::setPrivateBrowsingEnabled): (WebCore::IconDatabase::iconForURL): (WebCore::IconDatabase::iconURLForURL): (WebCore::IconDatabase::defaultIcon): (WebCore::IconDatabase::retainIconForURL): (WebCore::IconDatabase::releaseIconForURL): (WebCore::IconDatabase::setIconForIconURL): (WebCore::IconDatabase::setHaveNoIconForIconURL): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::hasIconForIconURL):

icon/IconDatabase.h: WebIcon will be an internal class used in IconDatabase but is not complete yet (WebCore::WebIcon::getExpiration): (WebCore::WebIcon::getTouch):

icon/SQLDatabase.cpp: Added more SQLite convenience methods (SQLDatabase::setFullsync): (SQLDatabase::setBusyTimeout): (SQLDatabase::setBusyHandler):
icon/SQLDatabase.h:
icon/SQLStatement.cpp: (WebCore::SQLStatement::returnsAtLeastOneResult):

icon/SQLTransaction.cpp: Added basic commit/rollback support with this simple class (SQLTransaction::SQLTransaction): (SQLTransaction::~SQLTransaction): (SQLTransaction::begin): (SQLTransaction::commit): (SQLTransaction::rollback):

WebKit:

Reviewed by Maciej

Added calls through to the WebCoreIconDatabaseBridge for all the major WebIconDatabase API. For now these calls
are wrapped with #ifdef's and are for debugging only.

Misc/WebIconDatabase.h:
Misc/WebIconDatabase.m: (-[NSMutableDictionary _scaleIcon:toSize:]): (-[NSMutableDictionary init]): (-[NSMutableDictionary iconForURL:withSize:cache:]): (-[NSMutableDictionary iconURLForURL:]): (-[NSMutableDictionary retainIconForURL:]): (-[NSMutableDictionary releaseIconForURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _hasIconForIconURL:]):
Misc/WebIconLoader.m: (-[WebIconLoader didFinishLoading]):

Misc/WebKitLogging.h: Added a logging channel for WebIconDatabase debugging
Misc/WebKitLogging.m: (WebKitInitializeLoggingChannelsIfNecessary):

5:20 PM Changeset in webkit [14932] by thatcher

3 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Make sure we clear the exception before returning so
that future calls will not fail because of an earlier
exception state. Assert on entry that the WebScriptObject
is working with an ExecState that dose not have an exception.
Document that evaluateWebScript and callWebScriptMethod return
WebUndefined when an exception is thrown.

bindings/objc/WebScriptObject.h:
bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject setValue:forKey:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject removeWebScriptKey:]): (-[WebScriptObject webScriptValueAtIndex:]): (-[WebScriptObject setWebScriptValueAtIndex:value:]):

5:10 PM Changeset in webkit [14931] by adele

14 edits
8 adds in trunk

LayoutTests:

Reviewed by Maciej.

Tests for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=8724
REGRESSION: onSelect handler doesn't work for text fields

http://bugzilla.opendarwin.org/show_bug.cgi?id=7676
REGRESSION: Selection methods on new text fields don't work if text field is hidden

http://bugzilla.opendarwin.org/show_bug.cgi?id=8867
REGRESSION: selectionStart/End return 0 for input element once it no longer has focus

fast/forms/double-focus-expected.txt:
fast/forms/input-selection-hidden-expected.txt: Added.
fast/forms/input-selection-hidden.html: Added.
fast/forms/input-selection-restore-expected.txt: Added.
fast/forms/input-selection-restore.html: Added.
fast/forms/input-text-paste-maxlength-expected.txt:
fast/forms/onselect-textarea-expected.txt: Added.
fast/forms/onselect-textarea.html: Added.
fast/forms/onselect-textfield-expected.txt: Added.
fast/forms/onselect-textfield.html: Added.
fast/forms/selection-functions-expected.txt:

WebCore:

Reviewed by Maciej.

Fixes for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=8724
REGRESSION: onSelect handler doesn't work for text fields

http://bugzilla.opendarwin.org/show_bug.cgi?id=7676
REGRESSION: Selection methods on new text fields don't work if text field is hidden

http://bugzilla.opendarwin.org/show_bug.cgi?id=8867
REGRESSION: selectionStart/End return 0 for input element once it no longer has focus

Implemented onSelect for new text fields and textareas. Also fixed selection restore
behavior to better match other browsers and Safari 2.0 behavior.

Tests:

fast/forms/input-selection-restore.html
fast/forms/input-selection-hidden.html
fast/forms/onselect-textarea.html
fast/forms/onselect-textfield.html

html/HTMLInputElement.h: (WebCore::HTMLInputElement::cacheSelection): Added.
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::init): Initializes cached selection. (WebCore::HTMLInputElement::selectionStart): If this element doesn't have focus, return the cached selection value. (WebCore::HTMLInputElement::selectionEnd): ditto. (WebCore::HTMLInputElement::setValue): Restore a caret at the starting point of the old selection. Matches Safari 2.0 behavior.

html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::cacheSelection): Added.
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Initializes cached selection. (WebCore::HTMLTextAreaElement::selectionStart): If this element doesn't have focus, return the cached selection value. (WebCore::HTMLTextAreaElement::selectionEnd): ditto. (WebCore::HTMLTextAreaElement::focus): If this is the first focus, set a caret at the end of the text. Otherwise, restore the cached selection. This matches other browsers' behavior. (WebCore::HTMLTextAreaElement::setValue): Restore a caret at the starting point of the old selection. Matches Safari 2.0 behavior.

page/Frame.h: Added notifyRendererOfSelectionChange method.
page/Frame.cpp: (WebCore::Frame::notifyRendererOfSelectionChange): Added. Calls selectionChanged for text fields and textareas. Forwards a userTriggered argument so selectionChanged knows whether or not to fire onSelect. (WebCore::Frame::setSelection): Calls notifyRendererOfSelectionChange(false). This gets called for all selection changes, so the renderer can always update its cached selection values. (WebCore::Frame::handleMouseReleaseEvent): Calls notifyRendererOfSelectionChange(true) so onSelect will get fired when the user is done making a selection with the mouse.
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]): Calls notifyRendererOfSelectionChange(true) so onSelect gets fired when the user makes a selection with the keyboard. (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]): ditto.

rendering/RenderTextField.h: Add userTriggered parameter to selectionChanged.
rendering/RenderTextField.cpp: (WebCore::RenderTextField::setSelectionRange): For visibility:hidden, cache the selection and return early since we won't be able to actually set the selection. (WebCore::RenderTextField::selectionChanged): Caches the selection. If the selection is a range, and its triggered by user action, then fire the onSelect event.

3:11 PM Changeset in webkit [14930] by andersca

3 edits in trunk/WebCore

2006-06-21 Anders Carlsson <acarlsson@apple.com>

bridge/win/FrameWin.cpp: (WebCore::shouldInterruptJavaScript):
bridge/win/FrameWin.h: Try fixing the Windows build.

3:07 PM Changeset in webkit [14929] by adele

36 edits
2 moves in trunk

RS by Tim Hatcher.

Renamed RenderSelect to DeprecatedRenderSelect to prepare for new popup menu and list menu implementations.

WebCore.xcodeproj/project.pbxproj:
html/HTMLOptionElement.h:
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::createRenderer): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::notifyOptionSelected):
html/HTMLSelectElement.h:
rendering/DeprecatedRenderSelect.cpp: Added. (WebCore::DeprecatedRenderSelect::DeprecatedRenderSelect): (WebCore::DeprecatedRenderSelect::setWidgetWritingDirection): (WebCore::DeprecatedRenderSelect::setStyle): (WebCore::DeprecatedRenderSelect::updateFromElement): (WebCore::DeprecatedRenderSelect::baselinePosition): (WebCore::DeprecatedRenderSelect::calcMinMaxWidth): (WebCore::DeprecatedRenderSelect::layout): (WebCore::DeprecatedRenderSelect::valueChanged): (WebCore::DeprecatedRenderSelect::selectionChanged): (WebCore::DeprecatedRenderSelect::setOptionsChanged): (WebCore::DeprecatedRenderSelect::createListBox): (WebCore::DeprecatedRenderSelect::updateSelection):
rendering/DeprecatedRenderSelect.h: Added. (WebCore::DeprecatedRenderSelect::renderName):
rendering/RenderSelect.cpp: Removed.
rendering/RenderSelect.h: Removed.

3:01 PM Changeset in webkit [14928] by andersca

1 edit in trunk/WebCore/dom/xml_tokenizer.cpp

Commit for real this time - Not just the ChangeLog and some white-space

2:34 PM Changeset in webkit [14927] by andersca

2 edits in trunk/WebCore

2006-06-20 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9509
Would like a way to pause/resume XML parsing

dom/xml_tokenizer.cpp: (WebCore::PendingCallbacks::PendingCallbacks): (WebCore::PendingCallbacks::appendStartElementNSCallback): (WebCore::PendingCallbacks::appendEndElementNSCallback): (WebCore::PendingCallbacks::appendCharactersCallback): (WebCore::PendingCallbacks::appendProcessingInstructionCallback): (WebCore::PendingCallbacks::appendCDATABlockCallback): (WebCore::PendingCallbacks::appendCommentCallback): (WebCore::PendingCallbacks::appendInternalSubsetCallback): (WebCore::PendingCallbacks::appendErrorCallback): (WebCore::PendingCallbacks::callAndRemoveFirstCallback): (WebCore::PendingCallbacks::isEmpty): (WebCore::PendingCallbacks::PendingCallback::~PendingCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): (WebCore::PendingCallbacks::PendingEndElementNSCallback::call): (WebCore::PendingCallbacks::PendingCharactersCallback::~PendingCharactersCallback): (WebCore::PendingCallbacks::PendingCharactersCallback::call): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::~PendingProcessingInstructionCallback): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::call): (WebCore::PendingCallbacks::PendingCDATABlockCallback::~PendingCDATABlockCallback): (WebCore::PendingCallbacks::PendingCDATABlockCallback::call): (WebCore::PendingCallbacks::PendingCommentCallback::~PendingCommentCallback): (WebCore::PendingCallbacks::PendingCommentCallback::call): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::~PendingInternalSubsetCallback): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::call): (WebCore::PendingCallbacks::): New classes which manage a list of pending SAX callbacks that have not yet been sent to the tokenizer.

(WebCore::XMLTokenizer::XMLTokenizer):
Initialize new member variables.

(WebCore::XMLTokenizer::~XMLTokenizer):
Delete PendingCallbacks object.

(WebCore::XMLTokenizer::write):
If the parser is paused, queue the data to be written.

(WebCore::XMLTokenizer::startElementNs):
(WebCore::XMLTokenizer::endElementNs):
(WebCore::XMLTokenizer::characters):
(WebCore::XMLTokenizer::error):
(WebCore::XMLTokenizer::processingInstruction):
(WebCore::XMLTokenizer::cdataBlock):
(WebCore::XMLTokenizer::comment):
(WebCore::XMLTokenizer::internalSubset):
If the parser has been paused, queue the callbacks instead.

(WebCore::XMLTokenizer::handleError):
New function, called by both ::error and :PendingCallbacks::callAndRemoveFirstCallback

(WebCore::XMLTokenizer::finish):
(WebCore::XMLTokenizer::pauseParsing):

Set m_parserPaused to true.

(WebCore::XMLTokenizer::resumeParsing):
Call the pending callbacks and then parse the pending source.

2:24 PM Changeset in webkit [14926] by hyatt

3 edits in trunk/WebCore

Don't send the custom highlighter callback when painting is disabled.

Reviewed by harrison

WebCore.xcodeproj/project.pbxproj:
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):

2:04 PM Changeset in webkit [14925] by adele

2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

WebView/WebMainResourceLoader.m: Added missing header to fix build on Leopard.

12:44 PM Changeset in webkit [14924] by andersca

3 edits
8 adds in trunk

WebCore:

2006-06-20 Anders Carlsson <acarlsson@apple.com>

Reviewed by John.

<rdar://problem/4592244> REGRESSION (417.9.3 - 420+): (some?) plain text files have all lines concatenated into one line

loader/TextDocument.cpp: (WebCore::TextTokenizer::checkBuffer): (WebCore::TextTokenizer::TextTokenizer): (WebCore::TextTokenizer::write): (WebCore::TextTokenizer::finish): Add a text buffer which is used for translation of CR and CRLF to plain LF, like the HTML tokenizer does.

LayoutTests:

2006-06-20 Anders Carlsson <acarlsson@apple.com>

Reviewed by John.

<rdar://problem/4592244> REGRESSION (417.9.3 - 420+): (some?) plain text files have all lines concatenated into one line

fast/text/plain-text-line-breaks-expected.checksum: Added.
fast/text/plain-text-line-breaks-expected.png: Added.
fast/text/plain-text-line-breaks-expected.txt: Added.
fast/text/plain-text-line-breaks.html: Added.
fast/text/resources/line-breaks-cr.txt: Added.
fast/text/resources/line-breaks-crlf.txt: Added.
fast/text/resources/line-breaks-lf.txt: Added.

12:12 PM Changeset in webkit [14923] by thatcher

1 edit
51 adds in trunk/WebKitTools

Reviewed by Darin.

Adds a JavaScript debugger, called Drosera. Named after
a genus of bug eating plants.

Drosera/DebuggerApplication.h: Added.
Drosera/DebuggerApplication.m: Added. (-[DebuggerApplication applicationDidFinishLaunching:]): (-[DebuggerApplication serverLoaded:]): (-[DebuggerApplication serverUnloaded:]): (-[DebuggerApplication awakeFromNib]): (-[DebuggerApplication showAttachPanel:]): (-[DebuggerApplication attach:]): (-[DebuggerApplication numberOfRowsInTableView:]): (-[DebuggerApplication tableView:objectValueForTableColumn:row:]): (-[DebuggerApplication tableView:willDisplayCell:forTableColumn:row:]): (-[DebuggerApplication tableViewSelectionDidChange:]):
Drosera/DebuggerDocument.h: Added.
Drosera/DebuggerDocument.m: Added. (+[WebScriptCallFrame isSelectorExcludedFromWebScript:]): (+[WebScriptCallFrame isKeyExcludedFromWebScript:]): (+[DebuggerDocument isSelectorExcludedFromWebScript:]): (+[DebuggerDocument isKeyExcludedFromWebScript:]): (-[DebuggerDocument initWithServerName:]): (-[DebuggerDocument windowWillClose:]): (-[DebuggerDocument dealloc]): (-[DebuggerDocument isPaused]): (-[DebuggerDocument pause]): (-[DebuggerDocument resume]): (-[DebuggerDocument step]): (-[DebuggerDocument windowNibName]): (-[DebuggerDocument windowDidLoad]): (-[DebuggerDocument switchToServerNamed:]): (-[DebuggerDocument applicationTerminating:]): (-[DebuggerDocument serverConnectionDidDie:]): (-[DebuggerDocument webView:windowScriptObjectAvailable:]): (-[DebuggerDocument webView:didFinishLoadForFrame:]): (-[DebuggerDocument webView:didParseSource:fromURL:sourceId:forWebFrame:]): (-[DebuggerDocument webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[DebuggerDocument webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[DebuggerDocument webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
Drosera/Drosera.pch: Added.
Drosera/Drosera.xcodeproj/project.pbxproj: Added.
Drosera/English.lproj/Debugger.nib/classes.nib: Added.
Drosera/English.lproj/Debugger.nib/info.nib: Added.
Drosera/English.lproj/Debugger.nib/keyedobjects.nib: Added.
Drosera/English.lproj/MainMenu.nib/classes.nib: Added.
Drosera/English.lproj/MainMenu.nib/info.nib: Added.
Drosera/English.lproj/MainMenu.nib/keyedobjects.nib: Added.
Drosera/Images/breakPoint.tif: Added.
Drosera/Images/breakPointDisabled.tif: Added.
Drosera/Images/continue.tif: Added.
Drosera/Images/finishFunction.tif: Added.
Drosera/Images/glossyFooterFill.tif: Added.
Drosera/Images/glossyHeader.png: Added.
Drosera/Images/gradientBackground.png: Added.
Drosera/Images/gutter.png: Added.
Drosera/Images/navLeftDisabled.png: Added.
Drosera/Images/navLeftNormal.png: Added.
Drosera/Images/navLeftPressed.png: Added.
Drosera/Images/navRightDisabled.png: Added.
Drosera/Images/navRightNormal.png: Added.
Drosera/Images/navRightPressed.png: Added.
Drosera/Images/pause.tif: Added.
Drosera/Images/popUpArrows.png: Added.
Drosera/Images/programCounter.tif: Added.
Drosera/Images/programCounterBreakPoint.tif: Added.
Drosera/Images/programCounterBreakPointDisabled.tif: Added.
Drosera/Images/run.tif: Added.
Drosera/Images/splitterBar.tif: Added.
Drosera/Images/splitterDimple.tif: Added.
Drosera/Images/step.tif: Added.
Drosera/Images/stepOver.tif: Added.
Drosera/Images/stop.tif: Added.
Drosera/Images/toolbarBackground.png: Added.
Drosera/Info.plist: Added.
Drosera/debugger.css: Added.
Drosera/debugger.html: Added.
Drosera/debugger.js: Added.
Drosera/main.m: Added. (main):
Drosera/viewer.css: Added.
Drosera/viewer.html: Added.

12:08 PM Changeset in webkit [14922] by thatcher

5 edits in trunk/WebKit

Reviewed by Darin.

Removes the @try/@catch from the callbacks to improve performance,
simply check if the proxy object's connection is still valid first.
Listener objects are now required to be NSDistantObjects.

Adds pause, resume and step support. The debugger process use to handle this,
but it caused problems when there were multiple listeners.

Sends the bundle identifier in the notification userInfo dictionary along with
process name and process ID.

DefaultDelegates/WebScriptDebugServer.h:
DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer serverQuery:]): (-[WebScriptDebugServer addListener:]): (-[WebScriptDebugServer removeListener:]): (-[WebScriptDebugServer step]): (-[WebScriptDebugServer pause]): (-[WebScriptDebugServer resume]): (-[WebScriptDebugServer isPaused]): (-[WebScriptDebugServer suspendProcessIfPaused]): (-[WebScriptDebugServer webView:didParseSource:fromURL:sourceId:forWebFrame:]): (-[WebScriptDebugServer webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
DefaultDelegates/WebScriptDebugServerPrivate.h:
WebKit.exp:

1:14 AM Changeset in webkit [14921] by mjs

2 edits in trunk/WebCore

Reviewed by Eric.

fix crasher on one of the layout tests caused by my recent checkin

kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed