Timeline



Jun 26, 2006:

4:53 PM Changeset in webkit [15050] by hyatt
  • 18 edits
    3 adds in trunk/WebCore

Fix for 9538, support syntax highlighted HTML source. Lots of loose
ends still (script/style/comments/doctype/entities/accurate whitespace).

Reviewed by darin

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setInViewSourceMode:]): (-[WebCoreFrameBridge inViewSourceMode]):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::matchUARules):
  • css/cssstyleselector.h:
  • css/view-source.css: Added.
  • dom/Document.cpp: (WebCore::Document::implicitClose):
  • dom/xml_tokenizer.h: (WebCore::Tokenizer::Tokenizer): (WebCore::Tokenizer::~Tokenizer): (WebCore::Tokenizer::inViewSourceMode): (WebCore::Tokenizer::setInViewSourceMode):
  • html/HTMLAttributeNames.in:
  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::init): (WebCore::HTMLFrameElement::parseMappedAttribute): (WebCore::HTMLFrameElement::attach):
  • html/HTMLFrameElement.h: (WebCore::HTMLFrameElement::viewSourceMode):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::continueProcessing): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::timerFired): (WebCore::HTMLTokenizer::end): (WebCore::HTMLTokenizer::processToken): (WebCore::HTMLTokenizer::notifyFinished):
  • html/HTMLTokenizer.h:
  • html/HTMLViewSourceDocument.cpp: Added. (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): (WebCore::HTMLViewSourceDocument::createTokenizer): (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addViewSourceAttribute): (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
  • html/HTMLViewSourceDocument.h: Added.
  • page/Frame.cpp: (WebCore::Frame::begin): (WebCore::Frame::inViewSourceMode): (WebCore::Frame::setInViewSourceMode):
  • page/Frame.h:
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):
4:48 PM Changeset in webkit [15049] by hyatt
  • 4 edits in trunk/WebKit

Fix for 9538, support syntax highlighting for HTML source.

Reviewed by darin

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebView.m: (-[WebView _setInViewSourceMode:]): (-[WebView _inViewSourceMode]):
  • WebView/WebViewPrivate.h:
2:26 PM Changeset in webkit [15048] by andersca
  • 4 edits in trunk/WebCore

2006-06-26 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9031
REGRESSION: Crash when closing tabs on newegg.com


  • page/Frame.cpp: (WebCore::Frame::pageDestroyed):
  • page/Frame.h: Add new method which is invoked when the frame's page has been destroyed. Currently this function disassociates the JS Window object with the frame, stopping any running JS timers.


  • page/Page.cpp: (WebCore::Page::~Page): Call pageDestroyed on all frames.
9:38 AM Changeset in webkit [15047] by darin
  • 10 edits in trunk/WebCore

Reviewed and reworked by Darin.

Code cleanup, calculate clientX/clientY in one central place.

  • dom/EventTargetNode.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent): Renamed parameters to pageX/Y since they aren't clientX/Y values. Removed code to compute clientX/Y (was a bit confused in naming before), because that's now done inside MouseEvent.
  • dom/MouseEvent.h:
  • dom/MouseEvent.cpp: (WebCore::MouseEvent::MouseEvent): Removed clientX/Y parameters. (WebCore::MouseEvent::initMouseEvent): Added comments about problems I noticed. (WebCore::MouseEvent::which): Fixed comment that confusingly mentioned KHTML, when it was talking about the DOM standard.
  • dom/MouseRelatedEvent.h:
  • dom/MouseRelatedEvent.cpp: (WebCore::contentsX): Added helper function. (WebCore::contentsY): Ditto. (WebCore::MouseRelatedEvent::MouseRelatedEvent): Removed clientX/Y parameter, and added code to compute clientX/Y based on pageX/Y. (WebCore::MouseRelatedEvent::receivedTarget): Fixed comments.
  • dom/WheelEvent.h:
  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): Removed clientX/Y parameter.
  • page/FrameView.cpp: (WebCore::FrameView::dispatchDragEvent): Removed the code to compute coordinates, and renamed the confusingly named clientPos (which was a page-relative position) to contentsPos.
8:26 AM Changeset in webkit [15046] by darin
  • 4 edits in trunk

LayoutTests:

Reviewed by Darin.

  • LayoutTests/fast/events/objc-event-api-expected.txt: Updated to reflect flipped coordinates dumped by the layout tests.

WebKitTools:

Reviewed by Darin.

Bug 9579: LayoutTests/fast/events/objc-event-api.html failing due to screenY output
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9579

Report screenY values as (height of zero screen - screenY)

  • DumpRenderTree/EventSendingController.m: (-[EventSendingController handleEvent:]):

Jun 25, 2006:

10:09 PM Changeset in webkit [15045] by thatcher
  • 3 edits in trunk/WebKitTools

Reviewed by Geoff.

Bug 9591: [Drosera] breakpoints should be dragable and deletable by dragging off the gutter
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9591


Makes breakpoints dragable. If dragged off the gutter they are deleted.

  • Drosera/debugger.js:
  • Drosera/viewer.css:
9:51 PM Changeset in webkit [15044] by darin
  • 5 edits
    11 adds in trunk

LayoutTests:

Reviewed by Darin.

Tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9185

  • fast/forms/input-appearance-height-expected.png: Added.
  • fast/forms/input-appearance-height-expected.txt: Added.
  • fast/forms/input-appearance-height.html: Added. Tests the height attribute on all input types
  • fast/forms/input-type-change-expected.checksum: Added.
  • fast/forms/input-type-change-expected.png: Added.
  • fast/forms/input-type-change-expected.txt: Added.
  • fast/forms/input-type-change.html: Added. Tests changing an input type=TEXT to type=IMAGE with a height and width specified on the element.
  • fast/forms/input-type-change2-expected.checksum: Added.
  • fast/forms/input-type-change2-expected.png: Added.
  • fast/forms/input-type-change2-expected.txt: Added.
  • fast/forms/input-type-change2.html: Added. Tests changing an input type=IMAGE to type=TEXT with a height and width specified on the element.

WebCore:

Reviewed and tweaked by Darin.

  • dom/NamedMappedAttrMap.h: (WebCore::NamedMappedAttrMap::getAttributeItem): Added to static_cast method.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): Update the style decl if input type has changed. (WebCore::HTMLInputElement::mapToEntry): Only Cache height and width if it is an IMAGE or HIDDEN (WebCore::HTMLInputElement::parseMappedAttribute): Check type before adding height and width style. (WebCore::HTMLInputElement::attach): Remove code for discarding width.
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::respectHeightAndWidthAttrs): New method added to report if this input type uses height & width.
8:12 PM Changeset in webkit [15043] by ggaren
  • 6 edits in trunk/JavaScriptCore

Reviewed by Adele.


  • Added JSConstructorMake to match JSFunctionMake, along with test code.


[ I checked in the ChangeLog before without the actual files. ]

  • API/JSObjectRef.cpp: (JSConstructorMake):
  • API/JSObjectRef.h:
  • API/testapi.c: (myConstructor_callAsConstructor): (main):
  • API/testapi.js:
  • ChangeLog:
  • JavaScriptCore.xcodeproj/project.pbxproj: Moved testapi.c to the testapi target -- this was an oversight in my earlier check-in.
7:17 PM Changeset in webkit [15042] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.


Bug 9568: assertion failure in Safari after quitting Drosera
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9568

Call switchToServerNamed:nil and not removeLister to make sure
the server object is set to nil to prevent further removeListener calls.

  • Drosera/DebuggerDocument.m: (-[DebuggerDocument applicationTerminating:]):
5:28 PM Changeset in webkit [15041] by ddkilzer
  • 3 edits in trunk/LayoutTests

LayoutTests:

Reviewed by Darin.

  • fast/forms/textarea-hard-linewrap-empty.html: Submit form without setTimeout().
  • fast/forms/textarea-hard-linewrap.html: Ditto.
4:55 PM Changeset in webkit [15040] by ddkilzer
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

Test: fast/forms/textarea-hard-linewrap-empty.html

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::textWithHardLineBreaks): Added null check for m_div->firstChild()->renderer().

LayoutTests:

Reviewed by Darin.

  • fast/forms/textarea-hard-linewrap-empty-expected.txt: Added.
  • fast/forms/textarea-hard-linewrap-empty.html: Added.
  • fast/forms/textarea-hard-linewrap.html: Reduced timeout from 200ms to 0ms and renamed function from foo() to submitForm().
4:28 PM Changeset in webkit [15039] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

  • Scripts/svn-apply: Speed up isDirectoryEmptyForRemoval() by returning as soon as we find that the directory is not empty instead of reading in every single file and directory first, then checking the count. Avoid warning in removeDirectoriesIfNeeded() if $svnOutput is not defined.
4:17 PM Changeset in webkit [15038] by ddkilzer
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin.

Test: fast/repaint/outline-shrinking.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Always repaint with the old style if the outline is becoming narrower, even if we are going to relayout.

LayoutTests:

Reviewed by Darin.

  • fast/repaint/outline-shrinking-expected.checksum: Added.
  • fast/repaint/outline-shrinking-expected.png: Added.
  • fast/repaint/outline-shrinking-expected.txt: Added.
  • fast/repaint/outline-shrinking.html: Added.
2:45 PM Changeset in webkit [15037] by thatcher
  • 4 edits in tags/Safari-521.13.1/WebKit

Adds an SPI Mail needs, and versioning.

2:42 PM Changeset in webkit [15036] by thatcher
  • 4 edits in tags/Safari-521.13.1/WebCore

Build fix, and versioning.

2:38 PM Changeset in webkit [15035] by thatcher
  • 1 copy in tags/Safari-521.13.1

New tag.

1:56 PM Changeset in webkit [15034] by thatcher
  • 3 edits in trunk/WebCore

Build fix for for GCC 5406

1:37 PM Changeset in webkit [15033] by thatcher
  • 1 edit in trunk/WebCore/dom/Document.cpp

Rolls out a build fix I made on Friday, this was correctly fixed by adding a long version of operator[] to Vector.

1:37 PM Changeset in webkit [15032] by ddkilzer
  • 9 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8707:
event.clientX and event.clientY should be relative to the viewport, not the canvas

Make sure clientX and clientY take into account the scroll offsets
of the view.

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
  • dom/MouseEvent.cpp: (WebCore::MouseEvent::MouseEvent):
  • dom/MouseEvent.h:
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::MouseRelatedEvent): (WebCore::MouseRelatedEvent::initCoordinates):
  • dom/MouseRelatedEvent.h:
  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent):
  • page/FrameView.cpp: (WebCore::FrameView::dispatchDragEvent):

LayoutTests:

Reviewed by Darin.

Test cases for
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8707>
event.clientX and event.clientY should be relative to the viewport, not the canvas

  • fast/dom/window-xy-properties-expected.txt: Added.
  • fast/dom/window-xy-properties.html: Added.
1:32 PM Changeset in webkit [15031] by thatcher
  • 1 edit in trunk/WebKit/DefaultDelegates/WebScriptDebugServer.m

Leak fix

1:01 PM Changeset in webkit [15030] by darin
  • 4 edits in trunk/WebKitTools
  • Scripts/svn-apply: Tweak comments.
  • Scripts/svn-create-patch: Ditto.
  • Scripts/svn-unapply: Ditto.
12:42 PM Changeset in webkit [15029] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Formatting fix per Bug 9571 Comment #2. Reviewed by NOBODY.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9571#c2

  • Scripts/svn-apply: Formatting fix.
12:39 PM Changeset in webkit [15028] by ddkilzer
  • 3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9571
Teach svn-apply and svn-unapply to handle directory adds and removes better

  • Scripts/svn-apply: Handle directory adds more intelligently. Handle directory removes.
  • Scripts/svn-unapply: Handle undoing both directory adds and removes.
11:59 AM Changeset in webkit [15027] by thatcher
  • 20 edits in trunk/LayoutTests

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9560


This fix converted the resize corner image to a B/W tiff.
The pixel tests showed 0.0% changes but still said it had differences.
Updating the tests that use CSS3 resize or textarea.

  • fast/forms/floating-textfield-relayout-expected.checksum:
  • fast/forms/form-element-geometry-expected.checksum:
  • fast/forms/form-element-geometry-expected.png:
  • fast/forms/negativeLineHeight-expected.checksum:
  • fast/forms/negativeLineHeight-expected.png:
  • fast/forms/textAreaLineHeight-expected.checksum:
  • fast/forms/textAreaLineHeight-expected.png:
  • fast/forms/textarea-setinnerhtml-expected.checksum:
  • fast/forms/textarea-setinnerhtml-expected.png:
  • fast/overflow/overflow-x-y-expected.checksum:
  • fast/overflow/overflow-x-y-expected.png:
  • fast/table/003-expected.checksum:
  • fast/table/003-expected.png:
  • tables/mozilla/bugs/bug194024-expected.checksum:
  • tables/mozilla/bugs/bug194024-expected.png:
  • tables/mozilla/bugs/bug30559-expected.checksum:
  • tables/mozilla/bugs/bug30559-expected.png:
  • tables/mozilla/bugs/bug30692-expected.checksum:
  • tables/mozilla/bugs/bug30692-expected.png:
10:53 AM Changeset in webkit [15026] by thatcher
  • 22 edits in trunk

JavaScriptCore:

Reviewed by Darin.

Bug 9574: Drosera should show inline scripts within the original HTML
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9574

Pass the starting line number and error message to the debugger.

  • kjs/debugger.cpp: (Debugger::sourceParsed):
  • kjs/debugger.h:
  • kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function_object.cpp: (FunctionObjectImp::construct):
  • kjs/interpreter.cpp: (KJS::Interpreter::evaluate):

WebCore:

Reviewed by Darin.

Bug 9574: Drosera should show inline scripts within the original HTML
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9574

  • Pass the starting line number and error message to the debugger.
  • Call parsedSource even if there was a script parse error so the debugger can show the parse error.
  • Pass NSURL objects to the ObjC delegate for the script URLs.
  • bridge/mac/WebCoreScriptDebugger.h:
  • bridge/mac/WebCoreScriptDebugger.mm: (toNSURL): (WebCoreScriptDebuggerImp::sourceParsed):

WebKit:

Reviewed by Darin.

Bug 9574: Drosera should show inline scripts within the original HTML
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9574

  • Adds a new version of the didParseSource delegate callback with base line number.
  • Adds a new delegate callback for when a script fails to parse.
  • These new callbacks use NSURLs for the url parameter.
  • Adds a new script listener callback to notify when the main resource loads.
  • Adds a WebScriptErrorDomian and other keys for use with NSError.
  • DefaultDelegates/WebDefaultScriptDebugDelegate.m: (-[WebDefaultScriptDebugDelegate webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebDefaultScriptDebugDelegate webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
  • DefaultDelegates/WebScriptDebugServer.h:
  • DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer webView:didLoadMainResourceForDataSource:]): (-[WebScriptDebugServer webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebScriptDebugServer webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
  • DefaultDelegates/WebScriptDebugServerPrivate.h:
  • WebKit.exp:
  • WebView/WebDataSource.m: (-[WebDataSource _setPrimaryLoadComplete:]):
  • WebView/WebScriptDebugDelegate.h:
  • WebView/WebScriptDebugDelegate.m: (-[WebScriptCallFrame parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]):

WebKitTools:

Reviewed by Darin.

Bug 9574: Drosera should show inline scripts within the original HTML
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9574

Refactor the JavaScript code to have a distinction between files
and scripts. Show the script in the context of the HTML file if
it's URL is the same as the frame's main resource. At the time of
the disParseScript callback the main resource might not be completely
loaded, but Drosera needs to show whatever we have at the time. Once
the main resource is finished, update the file source and reload the file.

  • Drosera/DebuggerDocument.m: (-[DebuggerDocument pause]): (-[DebuggerDocument webView:didLoadMainResourceForDataSource:]): (-[DebuggerDocument webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[DebuggerDocument webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
  • Drosera/debugger.css:
  • Drosera/debugger.js:

Jun 24, 2006:

11:01 PM Changeset in webkit [15025] by ddkilzer
  • 3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9570
Teach prepare-ChangeLog to operate on a list of files or directories

  • Scripts/prepare-ChangeLog: Accept a list of files and/or directories when running.
  • Scripts/svn-create-patch: Code refactoring.
8:02 PM Changeset in webkit [15024] by ddkilzer
  • 8 edits
    2 deletes in trunk

WebCore:

Build fix. Reviewed by NOBODY.

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
  • dom/MouseEvent.cpp: (WebCore::MouseEvent::MouseEvent):
  • dom/MouseEvent.h:
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::MouseRelatedEvent): (WebCore::MouseRelatedEvent::initCoordinates):
  • dom/MouseRelatedEvent.h:
  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent):

LayoutTests:

Build fix. Reviewed by NOBODY.

  • fast/dom/window-xy-properties-expected.txt: Removed.
  • fast/dom/window-xy-properties.html: Removed.
7:09 PM Changeset in webkit [15023] by ddkilzer
  • 8 edits
    2 adds in trunk

WebCore:

Reviewed by Darin. Patch by Rob Buis.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8707:
event.clientX and event.clientY should be relative to the viewport, not the canvas

Make sure clientX and clientY take into account the scroll offsets
of the view.

Test: fast/dom/window-xy-properties.html

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
  • dom/MouseEvent.cpp: (WebCore::MouseEvent::MouseEvent):
  • dom/MouseEvent.h:
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::MouseRelatedEvent): (WebCore::MouseRelatedEvent::initCoordinates):
  • dom/MouseRelatedEvent.h:
  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent):

LayoutTests:

Reviewed by Darin. Patch by Rob Buis.

Test cases for
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8707>
event.clientX and event.clientY should be relative to the viewport, not the canvas

  • fast/dom/window-xy-properties-expected.txt: Added.
  • fast/dom/window-xy-properties.html: Added.
6:53 PM Changeset in webkit [15022] by ddkilzer
  • 1 edit
    4 adds in trunk/LayoutTests

LayoutTests:

Reviewed by Darin. Patch by James G. Speth.

  • plugins/jsobjc-dom-wrappers-expected.txt: Added.
  • plugins/jsobjc-dom-wrappers.html: Added.
  • plugins/jsobjc-simple-expected.txt: Added.
  • plugins/jsobjc-simple.html: Added.
2:55 PM Changeset in webkit [15021] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin. Patch by Rob Buis.

Test cases for
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9352>
Webkit doesn't respect stroke-width in SVG for smaller <circle>s

  • svg/custom/gradient-stroke-width-expected.checksum: Added.
  • svg/custom/gradient-stroke-width-expected.png: Added.
  • svg/custom/gradient-stroke-width-expected.txt: Added.
  • svg/custom/gradient-stroke-width.svg: Added.

WebCore:

Reviewed by Darin. Patch by Rob Buis.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9352
Webkit doesn't respect stroke-width in SVG for smaller <circle>s

Make sure the stroke path is set before applying gradient transforms.

  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::renderPath):
2:08 PM Changeset in webkit [15020] by ddkilzer
  • 3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin. Patch by James G. Speth.

Tests running in DumpRenderTree can choose to relax some restrictions of the JavaScript/Objective-C bridge
allowing more extensive testing of the Obj-C API. (and by more extensive, I mean this lets scripts do
pretty much whatever they want, including acting as delegates, generating events, instantiating obj-c
objects, etc... )

  • DumpRenderTree/ObjCPlugin.h:
  • DumpRenderTree/ObjCPlugin.m: this ability is only exposed to scripts running in DumpRenderTree (+[ObjCPlugin isSelectorExcludedFromWebScript:]): (+[ObjCPlugin webScriptNameForSelector:]): (-[ObjCPlugin removeBridgeRestrictions:]): scripts call this to open up obj-c for extensive testing (+[NSObject setAllowsScriptsFullAccess:]): makes NSObject allow all selectors to be invoked from script (+[NSObject allowsScriptsFullAccess]): (+[NSObject isSelectorExcludedFromWebScript:]): when full access is enabled, no selector is excluded (+[NSObject webScriptNameForSelector:]): always return nil for the default selector mutation (-[JSObjC classNameOfObject:isSelectorExcludedFromWebScript:]): (+[JSObjC webScriptNameForSelector:]): (-[JSObjC invokeDefaultMethodWithArguments:]): shortcut for accessing classes (-[JSObjC lookUpClass:]): allow scripts to retrieve obj-c classes by name (-[JSObjC log:]): access to NSLog function (-[JSObjC retainObject:]): useful obj-c functions that are otherwise hard to reach from javascript (-[JSObjC classOfObject:]): (-[JSObjC classNameOfObject:]):
2:07 PM Changeset in webkit [15019] by ap
  • 4 edits in trunk

Rubber-stamped by Eric.

Add a -h (do not follow symlinks) option to ln in derived sources build script (without it,
a symlink was created inside the source directory on second build).

JavaScriptCore:

WebCore:

  • WebCore.xcodeproj/project.pbxproj:
1:51 PM Changeset in webkit [15018] by ddkilzer
  • 7 edits
    1 add in trunk/WebCore

WebCore:

Reviewed by Darin. Patch by James G. Speth. Copyrights tweaked by ddkilzer.


Bug 8331: DOMNodeLists returned to Objective-C are not properly wrapped
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8331


DOMNodes were the only objects handled by createObjcInstanceForValue.
now it handles all of these: DOMNode, DOMNodeList, DOMNamedNodeMap, DOMStyleSheetList,
DOMStyleSheet, DOMMediaList, DOMCSSRuleList, DOMCSSRule, DOMCSSStyleDeclaration, and DOMCSSValue


  • WebCore.xcodeproj/project.pbxproj: added file DOMCSSInternal.h to project
  • bindings/js/kjs_css.cpp: (KJS::): changed ClassInfo for DOMCSSStyleSheet to have DOMStyleSheet as its parent class
  • bindings/objc/DOM.mm: (-[DOMDocumentType :]): moved DOMNamedNodeMap (WebCoreInternal) interface to DOMInternal.h
  • bindings/objc/DOMCSS.mm: moved WebCoreInternal interfaces to DOMCSSInternal.h
  • bindings/objc/DOMCSSInternal.h: Added file, contains WebCoreInternal interface for CSS classes
  • bindings/objc/DOMInternal.h: added DOMNamedNodeMap (WebCoreInternal) interface
  • bindings/objc/DOMUtility.mm: (KJS::ScriptInterpreter::createObjcInstanceForValue): support for more classes
1:01 PM Changeset in webkit [15017] by ddkilzer
  • 14 edits in trunk

JavaScriptCore:

Reviewed by Timothy.

  • Info.plist: Fixed copyright to include 2003-2006.

JavaScriptGlue:

Reviewed by Timothy.

  • Info.plist: Fixed copyright to include 2003-2006.

WebCore:

Reviewed by Timothy.

  • Info.plist: Fixed copyright to include 2003-2006.
  • manual-tests/NPN_Invoke/Info.plist: Added copyright statement.

WebKit:

Reviewed by Timothy.

  • Info.plist: Fixed copyright to include 2003-2006.

WebKitTools:

Reviewed by Timothy.

  • DrawTest/Info.plist: Added copyright statement.
  • Drosera/Info.plist: Ditto.
  • DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist: Ditto.
  • WebKitLauncher/Info.plist: Ditto.
12:00 PM Changeset in webkit [15016] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Build fix. Reviewed by NOBODY.

  • Scripts/webkitdirs.pm: Backed out previous change.
11:45 AM Changeset in webkit [15015] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Maciej. Patch by Bjoern Graf.

  • Scripts/webkitdirs.pm: Make Windows build work with Visual C++ Express.
9:02 AM Changeset in webkit [15014] by ap
  • 5 edits
    4 adds in trunk

2006-06-24 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by Darin, landed by ap.

Test: fast/css/resize-corner-tracking.html

  • page/FrameView.cpp: (WebCore::FrameView::handleMousePressEvent): Store the offset from the layer's resizing corner where dragging has started. (WebCore::FrameView::handleMouseMoveEvent): Pass the stored offset to the layer's resize method.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize): Added an offset parameter, which is added to the mouse location. For objects that may have intrinsic margins applied to them, added code to lift the margins into the object's style in order to keep them constant. Changed to take the content size as the base size if the box-sizing property is content-box. (WebCore::RenderLayer::offsetFromResizeCorner): Added. Returns the offset of the given point from the corner that tracks the mouse when resizing.
  • rendering/RenderLayer.h:
8:52 AM Changeset in webkit [15013] by ap
  • 5 edits
    4 adds in trunk

Reviewed by Darin, landed by ap.

Test: fast/forms/floating-textfield-relayout.html

  • page/FrameView.cpp: (WebCore::FrameView::layoutRoot): Added. During subtree relayout, returns the subtree root. Otherwise returns 0. (WebCore::FrameView::layoutPending): Made const.
  • page/FrameView.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcWidth): Added early return if this is the root of a subtree being laid out.
8:37 AM Changeset in webkit [15012] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

  • Add an -all-interfaces (-a) flag to bind to all interfaces, not just 127.0.0.1. Useful for testing with WinIE running on another machine;
  • don't call checkFrameworks() - we do not need a built WebKit here;
  • changed tabs to spaces;
  • disable HTTP keepalive (since Apache doesn't spawn sub-processes in interactive mode, they were a hassle when testing with several browsers, as one had to wait for connection to expire);
  • remove httpd.pid when done, so that Apache doesn't complain next time.
  • Scripts/run-webkit-httpd:
8:09 AM Changeset in webkit [15011] by ddkilzer
  • 116 edits in trunk

LayoutTests:

Reviewed by Hyatt. Patch by Mitz.

  • css1/classification/white_space-expected.checksum:
  • css1/classification/white_space-expected.png:
  • css1/classification/white_space-expected.txt:
  • editing/selection/select-all-004-expected.checksum:
  • editing/selection/select-all-004-expected.png:
  • editing/selection/select-all-004-expected.txt:
  • editing/selection/unrendered-001-expected.checksum:
  • editing/selection/unrendered-001-expected.png:
  • editing/selection/unrendered-001-expected.txt:
  • editing/selection/unrendered-002-expected.checksum:
  • editing/selection/unrendered-002-expected.png:
  • editing/selection/unrendered-002-expected.txt:
  • editing/selection/unrendered-003-expected.checksum:
  • editing/selection/unrendered-003-expected.png:
  • editing/selection/unrendered-003-expected.txt:
  • editing/selection/unrendered-004-expected.checksum:
  • editing/selection/unrendered-004-expected.png:
  • editing/selection/unrendered-004-expected.txt:
  • editing/selection/unrendered-005-expected.checksum:
  • editing/selection/unrendered-005-expected.png:
  • editing/selection/unrendered-005-expected.txt:
  • fast/block/float/019-expected.checksum:
  • fast/block/float/019-expected.png:
  • fast/block/float/019-expected.txt:
  • fast/block/margin-collapse/104-expected.checksum:
  • fast/block/margin-collapse/104-expected.png:
  • fast/block/margin-collapse/104-expected.txt:
  • fast/block/positioning/relative-overflow-block-expected.checksum:
  • fast/block/positioning/relative-overflow-block-expected.txt:
  • fast/block/positioning/relative-overflow-replaced-expected.checksum:
  • fast/block/positioning/relative-overflow-replaced-expected.txt:
  • fast/block/positioning/relative-overflow-replaced-float-expected.checksum:
  • fast/block/positioning/relative-overflow-replaced-float-expected.txt:
  • fast/lists/li-br-expected.checksum:
  • fast/lists/li-br-expected.png:
  • fast/lists/li-br-expected.txt:
  • fast/media/mq-relative-constraints-02-expected.checksum:
  • fast/media/mq-relative-constraints-02-expected.png:
  • fast/media/mq-relative-constraints-02-expected.txt:
  • fast/media/mq-relative-constraints-03-expected.checksum:
  • fast/media/mq-relative-constraints-03-expected.png:
  • fast/media/mq-relative-constraints-03-expected.txt:
  • fast/media/mq-relative-constraints-04-expected.checksum:
  • fast/media/mq-relative-constraints-04-expected.png:
  • fast/media/mq-relative-constraints-04-expected.txt:
  • fast/media/mq-relative-constraints-05-expected.checksum:
  • fast/media/mq-relative-constraints-05-expected.png:
  • fast/media/mq-relative-constraints-05-expected.txt:
  • fast/media/mq-relative-constraints-06-expected.checksum:
  • fast/media/mq-relative-constraints-06-expected.png:
  • fast/media/mq-relative-constraints-06-expected.txt:
  • fast/media/mq-relative-constraints-07-expected.checksum:
  • fast/media/mq-relative-constraints-07-expected.png:
  • fast/media/mq-relative-constraints-07-expected.txt:
  • fast/media/mq-relative-constraints-09-expected.checksum:
  • fast/media/mq-relative-constraints-09-expected.png:
  • fast/media/mq-relative-constraints-09-expected.txt:
  • fast/media/mq-width-absolute-01-expected.checksum:
  • fast/media/mq-width-absolute-01-expected.png:
  • fast/media/mq-width-absolute-01-expected.txt:
  • fast/media/mq-width-absolute-02-expected.checksum:
  • fast/media/mq-width-absolute-02-expected.png:
  • fast/media/mq-width-absolute-02-expected.txt:
  • fast/media/mq-width-absolute-03-expected.checksum:
  • fast/media/mq-width-absolute-03-expected.png:
  • fast/media/mq-width-absolute-03-expected.txt:
  • fast/media/mq-width-absolute-04-expected.checksum:
  • fast/media/mq-width-absolute-04-expected.png:
  • fast/media/mq-width-absolute-04-expected.txt:
  • fast/table/wide-colspan-expected.checksum:
  • fast/table/wide-colspan-expected.png:
  • fast/table/wide-colspan-expected.txt:
  • fast/table/wide-column-expected.checksum:
  • fast/table/wide-column-expected.png:
  • fast/table/wide-column-expected.txt:
  • tables/mozilla/bugs/bug131020-expected.checksum:
  • tables/mozilla/bugs/bug131020-expected.png:
  • tables/mozilla/bugs/bug131020-expected.txt:
  • tables/mozilla/bugs/bug23151-expected.checksum:
  • tables/mozilla/bugs/bug23151-expected.png:
  • tables/mozilla/bugs/bug23151-expected.txt:
  • tables/mozilla/bugs/bug29314-expected.checksum:
  • tables/mozilla/bugs/bug29314-expected.png:
  • tables/mozilla/bugs/bug29314-expected.txt:
  • tables/mozilla/bugs/bug43039-expected.checksum:
  • tables/mozilla/bugs/bug43039-expected.png:
  • tables/mozilla/bugs/bug43039-expected.txt:
  • tables/mozilla/bugs/bug43854-1-expected.checksum:
  • tables/mozilla/bugs/bug43854-1-expected.png:
  • tables/mozilla/bugs/bug43854-1-expected.txt:
  • tables/mozilla/bugs/bug625-expected.checksum:
  • tables/mozilla/bugs/bug625-expected.png:
  • tables/mozilla/bugs/bug625-expected.txt:
  • tables/mozilla/bugs/bug92143-expected.checksum:
  • tables/mozilla/bugs/bug92143-expected.png:
  • tables/mozilla/bugs/bug92143-expected.txt:
  • tables/mozilla/bugs/bug96334-expected.checksum:
  • tables/mozilla/bugs/bug96334-expected.png:
  • tables/mozilla/bugs/bug96334-expected.txt:
  • tables/mozilla/core/misc-expected.checksum:
  • tables/mozilla/core/misc-expected.png:
  • tables/mozilla/core/misc-expected.txt:
  • tables/mozilla/core/nested1-expected.checksum:
  • tables/mozilla/core/nested1-expected.png:
  • tables/mozilla/core/nested1-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug220653-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug67915-2-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug67915-2-expected.png:
  • tables/mozilla_expected_failures/bugs/bug67915-2-expected.txt:

WebCore:

Reviewed by Hyatt. Patch by Mitz.

The change affects many existing tests.

  • page/FrameView.cpp: (WebCore::FrameView::layout): Mark the body renderer as needing layout if the view's height has changed and the body stretches to the view's height.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight):
  • rendering/RenderBox.h: (WebCore::RenderBox::stretchesToViewHeight): Added. Moved the logic for when the HTML block needs to stretch to the view's height from calcHeight() here.
8:00 AM Changeset in webkit [15010] by ap
  • 3 edits
    7 adds in trunk

Reviewed by Darin.

Test: http/tests/uri/utf8-path.html

  • platform/KURL.cpp: (encodeRelativeString): Always set pathEncoding to UTF-8.
7:43 AM Changeset in webkit [15009] by ap
  • 18 edits
    4 adds in trunk

2006-06-24 Graham Dennis <​Graham.Dennis@gmail.com>

Reviewed by Darin, landed by ap.



Test: traversal/stay-within-root.html

  • dom/Node.cpp: (WebCore::Node::traversePreviousNode):
  • dom/Node.h: Add a stayWithin argument to traversePreviousNode just like the other traversal functions
  • dom/NodeIterator.cpp: (WebCore::NodeIterator::findNextNode): (WebCore::NodeIterator::findPreviousNode): Ensure that when moving forward or backward that the root node is not exited
  • dom/TreeWalker.cpp: (WebCore::TreeWalker::previousNode): (WebCore::TreeWalker::nextNode): Ditto (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
6:50 AM Changeset in webkit [15008] by ap
  • 10 edits
    3 adds in trunk

svn-commit.tmp

6:01 AM Changeset in webkit [15007] by ap
  • 4 edits in trunk/WebCore

2006-06-24 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed and landed by ap.

No test added because there is no change in functionality.

  • page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::layout):
  • page/FrameView.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::layout):
5:53 AM Changeset in webkit [15006] by ap
  • 19 edits in trunk/WebCore

Reviewed by Darin.

No change in functionality, thus no test.

Use info sharing for named collections, too. Moved shared HTMLCollection infos from HTMLDocument
to Document. Renamed collection types to use the preferred WebKit style. Replaced direct
HTMLCollection creation with using accessors from Document in a few places.

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLElement children]): (-[DOMHTMLDocument images]): (-[DOMHTMLDocument applets]): (-[DOMHTMLDocument links]): (-[DOMHTMLDocument forms]): (-[DOMHTMLDocument anchors]): (-[DOMHTMLMapElement areas]): (-[DOMHTMLTableSectionElement rows]): (-[DOMHTMLTableElement rows]): (-[DOMHTMLTableElement tBodies]): (-[DOMHTMLTableRowElement cells]):
  • dom/Document.cpp: (WebCore::Document::images): (WebCore::Document::applets): (WebCore::Document::embeds): (WebCore::Document::objects): (WebCore::Document::scripts): (WebCore::Document::links): (WebCore::Document::forms): (WebCore::Document::anchors): (WebCore::Document::all): (WebCore::Document::windowNamedItems): (WebCore::Document::documentNamedItems): (WebCore::Document::nameCollectionInfo):
  • dom/Document.h: (WebCore::Document::collectionInfo):
  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::HTMLCollection): (WebCore::HTMLCollection::traverseNextItem): (WebCore::HTMLCollection::checkForNameMatch): (WebCore::HTMLCollection::updateNameCache):
  • html/HTMLCollection.h: (WebCore::HTMLCollection::):
  • html/HTMLDocument.h:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::children):
  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::areas):
  • html/HTMLNameCollection.h:
  • html/HTMLNameCollection.cpp: (WebCore::HTMLNameCollection::HTMLNameCollection): (WebCore::HTMLNameCollection::traverseNextItem):
  • html/HTMLFormCollection.cpp:
  • html/HTMLOptionsCollection.cpp: (WebCore::HTMLOptionsCollection::HTMLOptionsCollection):
  • html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::collectionInfo):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::rows): (WebCore::HTMLTableElement::tBodies):
  • html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::cells):
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::rows):
  • kwq/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:]):
  • page/Frame.cpp: (WebCore::Frame::gotoAnchor):
4:50 AM Changeset in webkit [15005] by ap
  • 6 edits in trunk

Reviewed by Darin.

Enclose search paths in quotes; create symlinks to avoid passing paths with spaces to make.

  • JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
  • WebCore/WebCore.xcodeproj/project.pbxproj:
  • WebKit/WebKit.xcodeproj/project.pbxproj:

Jun 23, 2006:

10:19 PM Changeset in webkit [15004] by tomernic
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Tim Hatcher.

<rdar://problem/4560947> Leopard REGRESSION: Dragging to TileGame Widget is broken


  • fast/events/ondragenter-expected.checksum: Added.
  • fast/events/ondragenter-expected.png: Added.
  • fast/events/ondragenter-expected.txt: Added.
  • fast/events/ondragenter.html: Added.

WebCore:

Reviewed by Tim Hatcher.

<rdar://problem/4560947> Leopard REGRESSION: Dragging to TileGame Widget is broken

  • page/FrameView.cpp: (WebCore::FrameView::updateDragAndDrop): Use the passed mouse event, instead of the "current" event. There is no such thing as a "drag event". Asking for the current event during a drag returns a weird system- internal event with an invalid mouse location.
10:07 PM Changeset in webkit [15003] by thatcher
  • 22 edits
    5 adds in trunk/WebCore

Reviewed by Eric.

Manual test added: cursor.html

Bug 9560: should support new CSS3 cursor types to get more resizing directions
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9560

Adds support for ew-resize, ns-resize, nesw-resize, nwse-resize,
col-resize and row-resize CSS3 cursor values.

Also converted some of the cursor images to grayscale tiffs,
some were RGB but had no color data.

  • Resources/eastResizeCursor.tiff:
  • Resources/eastWestResizeCursor.tiff: Added.
  • Resources/helpCursor.tiff:
  • Resources/moveCursor.tiff:
  • Resources/northEastResizeCursor.tiff:
  • Resources/northEastSouthWestResizeCursor.tiff: Added.
  • Resources/northResizeCursor.tiff:
  • Resources/northSouthResizeCursor.tiff: Added.
  • Resources/northWestResizeCursor.tiff:
  • Resources/northWestSouthEastResizeCursor.tiff: Added.
  • Resources/southEastResizeCursor.tiff:
  • Resources/southResizeCursor.tiff:
  • Resources/southWestResizeCursor.tiff:
  • Resources/textAreaResizeCorner.tiff:
  • Resources/waitCursor.tiff:
  • Resources/westResizeCursor.tiff:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSValueKeywords.in:
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • manual-tests/cursor.html: Added.
  • page/FrameView.cpp: (WebCore::selectCursor):
  • platform/Cursor.h:
  • platform/mac/CursorMac.mm: (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor):
  • platform/win/CursorWin.cpp: (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor):
  • rendering/render_style.h: cursor needs 5 bits now
6:09 PM Changeset in webkit [15002] by thatcher
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Adding more operator[] overloads for long and short types.

  • wtf/Vector.h: (WTF::Vector::operator[]):
5:58 PM Changeset in webkit [15001] by kdecker
  • 4 edits in trunk/WebKitTools
4:56 PM Changeset in webkit [15000] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): Fixed a bug I found in the CoreGraphics drawing model that was preventing certain types of events from being dispatched to the plugin, unless the plugin was being updated. The check for portState was only required to call -setWindowIfNecessary, not required for the entire event dispatch. Also, don't paint the green debug rect unless this is a QuickDraw plugin. Otherwise the current QD port is not set, and the green rect fills the entire screen. Pretty awesome looking, but not intended behavior. (-[WebBaseNetscapePluginView setWindowIfNecessary]): Improved the logging here to include the NPWindow's width and height.
4:34 PM Changeset in webkit [14999] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Tim O.

Adds back SPI that Mail is still depending on.

  • WebView/WebDataSource.m: (-[WebDataSource _addSubframeArchives:]):
  • WebView/WebDataSourcePrivate.h:
4:12 PM Changeset in webkit [14998] by sullivan
  • 4 edits in trunk/WebCore

Reviewed by Tim Omernick


  • fixed <rdar://problem/4597685> stale rects for document markers can be left behind in certain cases
  • dom/Document.h:
  • dom/Document.cpp: (WebCore::Document::setRenderedRectForMarker): changed parameter from IntRect to const IntRect& at Darin's request (WebCore::Document::invalidateRenderedRectsForMarkersInRect): new method, tests whether the rendered rect for each marker intersects the passed rect. If so, sets the rendered rect back to the placeholder rect that means that the rect for this marker isn't known.


  • page/Frame.cpp: (WebCore::Frame::paint): call invalidateRenderedRectsForMarkersInRect on the rect we're about to paint. This ensures that old stale rects won't be preserved if the associated marker has moved such that it is out of the painted area.
3:38 PM Changeset in webkit [14997] by justing
  • 1 edit in trunk/WebCore/ChangeLog

Added bug number.

3:36 PM Changeset in webkit [14996] by justing
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by levi

  • editing/deleting/merge-into-empty-block-1-expected.checksum: Added.
  • editing/deleting/merge-into-empty-block-1-expected.png: Added.
  • editing/deleting/merge-into-empty-block-1-expected.txt: Added.
  • editing/deleting/merge-into-empty-block-1.html: Added.
  • editing/deleting/merge-into-empty-block-2-expected.checksum: Added.
  • editing/deleting/merge-into-empty-block-2-expected.png: Added.
  • editing/deleting/merge-into-empty-block-2-expected.txt: Added.
  • editing/deleting/merge-into-empty-block-2.html: Added.

WebCore:

Reviewed by levi

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): Add a rule for when to merge into empty blocks.
3:08 PM Changeset in webkit [14995] by ggaren
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Reviewed by Adele.


  • Added JSConstructorMake to match JSFunctionMake, along with test code.
  • API/JSObjectRef.cpp: (JSConstructorMake):
  • API/JSObjectRef.h:
  • API/testapi.c: (myConstructor_callAsConstructor): (main):
  • API/testapi.js:
  • ChangeLog:
  • JavaScriptCore.xcodeproj/project.pbxproj: Moved testapi.c to the testapi target -- this was an oversight in my earlier check-in.
2:43 PM Changeset in webkit [14994] by thatcher
  • 8 copies in tags/Safari-521.13

New tag for 521.13.

2:36 PM Changeset in webkit [14993] by thatcher
  • 3 edits in trunk

Versoning

2:27 PM Changeset in webkit [14992] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

<rdar://problem/4223619> Safari crashed in -[NSFont isSystemFont]
CFRetain and CFRelease NSFont's when FontPlatformData has a reference.
We only do this when GC is enabled for performance reasons.
No tests possible.

  • platform/mac/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData):
2:19 PM Changeset in webkit [14991] by justing
  • 5 edits
    12 adds in trunk

LayoutTests:

Reviewed by levi


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8074>
Caret before/after block tables is too small
<rdar://problem/4598331>
right arrow out of a table shows cursor in a weird place

Demonstrates 9557:

  • editing/input/range-for-empty-document-expected.txt: Added:
  • editing/selection/table-caret-1-expected.checksum: Added.
  • editing/selection/table-caret-1-expected.png: Added.
  • editing/selection/table-caret-1-expected.txt: Added.
  • editing/selection/table-caret-1.html: Added.
  • editing/selection/table-caret-2-expected.checksum: Added.
  • editing/selection/table-caret-2-expected.png: Added.
  • editing/selection/table-caret-2-expected.txt: Added.
  • editing/selection/table-caret-2.html: Added.
  • editing/selection/table-caret-3-expected.checksum: Added.
  • editing/selection/table-caret-3-expected.png: Added.
  • editing/selection/table-caret-3-expected.txt: Added.
  • editing/selection/table-caret-3.html: Added.

WebCore:

Reviewed by levi


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8074>
Caret before/after block tables is too small
<rdar://problem/4598331>
right arrow out of a table shows cursor in a weird place

  • rendering/RenderBox.cpp: (WebCore::RenderBox::caretRect): Don't propagate to children, VisiblePositions inside containers don't refer to children. Don't use the font height for tables.
1:04 PM Changeset in webkit [14990] by thatcher
  • 9 edits in trunk/WebKit

Reviewed by Geoff.

script debugger should only attach to JavaScriptCore when there are listeners
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9552

Attaches the debugger to all WebFrames when the first listener
is added. Detaches when the last listener is removed.
Also detach when the script debug delegate is set to nil.

  • DefaultDelegates/WebScriptDebugServer.m: (+[WebScriptDebugServer listenerCount]): (-[WebScriptDebugServer dealloc]): (-[WebScriptDebugServer attachScriptDebuggerToAllWebViews]): (-[WebScriptDebugServer detachScriptDebuggerFromAllWebViews]): (-[WebScriptDebugServer listenerConnectionDidDie:]): (-[WebScriptDebugServer addListener:]): (-[WebScriptDebugServer removeListener:]):
  • DefaultDelegates/WebScriptDebugServerPrivate.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge windowObjectCleared]):
  • WebView/WebFrame.m: (-[WebFrame _attachScriptDebugger]): (-[WebFrame _detachScriptDebugger]):
  • WebView/WebFramePrivate.h:
  • WebView/WebScriptDebugDelegate.m: (-[WebScriptCallFrame parsedSource:fromURL:sourceId:]): (-[WebScriptCallFrame enteredFrame:sourceId:line:]): (-[WebScriptCallFrame hitStatement:sourceId:line:]): (-[WebScriptCallFrame leavingFrame:sourceId:line:]):
  • WebView/WebView.m: (-[WebView _attachScriptDebuggerToAllFrames]): (-[WebView _detachScriptDebuggerFromAllFrames]): (-[WebView setScriptDebugDelegate:]):
  • WebView/WebViewPrivate.h:
10:51 AM Changeset in webkit [14989] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Kevin.

Added 64-bit String::number() functions

  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::number):
10:37 AM Changeset in webkit [14988] by thatcher
  • 1 edit in trunk/WebCore/dom/Document.cpp

Build fix.

9:16 AM Changeset in webkit [14987] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Tim Omernick


  • added support for UIDelegate to be notified of scrolling in any WebHTMLView
  • cleaned up recently-added UIDelegate code
  • WebView/WebUIDelegatePrivate.h: declared webView:didScrollDocumentInFrameView: method
  • DefaultDelegates/WebDefaultUIDelegate.m: (-[NSApplication webView:didDrawRect:]): provide default (empty) implementation of this recently-added method, so the DelegateForwarder mechanism will work for it (-[NSApplication webView:didScrollDocumentInFrameView:]): same thing for the new method


  • WebView/WebHTMLView.m: (-[WebHTMLView _frameOrBoundsChanged]): use _UIDelegateForwarder mechanism to notify delegate that scrolling occurred (-[NSArray drawSingleRect:]): use _UIDelegateForwarder mechanism instead of checking respondsToSelector stuff here (that's packaged up nicely by the forwarder mechanism)

Jun 22, 2006:

9:43 PM Changeset in webkit [14986] by ap
  • 2 edits in trunk/JavaScriptCore

Build fix.

  • API/JSObjectRef.cpp: Changed "identifier.h" to "Identifier.h"
9:37 PM Changeset in webkit [14985] by ap
  • 4 edits in trunk

Reviewed by darin and ggaren.

WebKitTools:

  • Scripts/webkitdirs.pm: Building WebKit now requires Xcode 2.3.

WebKitSite:

  • building/build.html: Ditto.
9:18 PM Changeset in webkit [14984] by thatcher
  • 10 edits in trunk/WebKitTools

Reviewed by Eric.

Adds a native toolbar to Drosera to be a good citizen.
Adds a Debug menu with key-commands for Continue, Pause and Step Into.
Fixes a dragging bug from an earlier fix to the divider code.
Fixes some poor indenting in debugger.js.

  • Drosera/DebuggerDocument.h:
  • Drosera/DebuggerDocument.m: (-[DebuggerDocument stepInto]): (-[DebuggerDocument pause:]): (-[DebuggerDocument resume:]): (-[DebuggerDocument stepInto:]): (-[DebuggerDocument windowDidLoad]): (-[DebuggerDocument toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): (-[DebuggerDocument toolbarDefaultItemIdentifiers:]): (-[DebuggerDocument toolbarAllowedItemIdentifiers:]): (-[DebuggerDocument validateUserInterfaceItem:]):
  • Drosera/English.lproj/MainMenu.nib/classes.nib:
  • Drosera/English.lproj/MainMenu.nib/info.nib:
  • Drosera/English.lproj/MainMenu.nib/keyedobjects.nib:
  • Drosera/debugger.css:
  • Drosera/debugger.html:
  • Drosera/debugger.js:
  • Drosera/viewer.html:
9:07 PM Changeset in webkit [14983] by ddkilzer
  • 9 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt. Patch by Mitz.

  • fast/repaint/clipped-relative-expected.checksum: Added.
  • fast/repaint/clipped-relative-expected.png: Added.
  • fast/repaint/clipped-relative-expected.txt: Added.
  • fast/repaint/clipped-relative.html: Added.
  • fast/repaint/containing-block-position-change-expected.checksum: Updated.
  • fast/repaint/containing-block-position-change-expected.png: Updated.

WebCore:

Reviewed by Hyatt. Patch by Mitz.

Test: fast/repaint/clipped-relative.html

  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removePositionedObjects): Removed call to computeRepaintRects(). Previously, it was needed to update the cached rects before RenderBox::setStyle() called updateLayerPositions().
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): Changed to call updateLayerPositions() for a newly- created layer only if it does not need layout. Otherwise, updateLayerPositions() will be called after layout. This saves a repaint in some cases.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::checkForRepaintOnResize): Renamed computeRepaintRects() to this and deleted the code that cached the absolute position and repaint rects. (WebCore::RenderLayer::updateLayerPositions): Added code to cache the absolute position and repaint rects right after updating the layer's position.
  • rendering/RenderLayer.h:
7:25 PM Changeset in webkit [14982] by thatcher
  • 2 edits in trunk/WebKitTools/Drosera

Adding an image that wasn't added to the project earlier.

7:00 PM Changeset in webkit [14981] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4599015> REGRESSION: Hand on clock widget
don't appear at all

This regression was caused by <rdar://problem/4567520> HIDPI: pixel
cracks in weather widget at 1.83 scaling

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): Do the contains check before rounding to integral device pixels.
4:12 PM Changeset in webkit [14980] by andersca
  • 3 edits
    2 adds in trunk

WebCore:

2006-06-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John.

<rdar://problem/4529334> REGRESSION: Can't configure RadarInMotion widget for U.S. locations on Leopard (Javascript errors)


  • dom/Document.cpp: (WebCore::Document::completeURL): Check if both the URL and base URL are empty instead of using URL() which returns "about:blank" if the URL is empty.

LayoutTests:

2006-06-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John.

<rdar://problem/4529334> REGRESSION: Can't configure RadarInMotion widget for U.S. locations on Leopard (Javascript errors)


  • dom/Document.cpp: (WebCore::Document::completeURL): Check if both the URL and base URL are empty instead of using URL() which returns "about:blank" if the URL is empty.
2:31 PM Changeset in webkit [14979] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by NOBODY (build fix)

  • WebView/WebFrameLoader.m: Import WebMainResourceLoader instead of using @class so that we can call WebMainResourceLoader methods.
2:10 PM Changeset in webkit [14978] by thatcher
  • 8 edits in /

Versioning

12:01 PM Changeset in webkit [14977] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by NOBODY (build fix)

  • WebView/WebFrameLoader.m: Import JavaScriptCore/Assertions.h instead of WebKit/WebAssertions.h (which no longer exists)
11:48 AM Changeset in webkit [14976] by mjs
  • 5 edits
    2 adds in trunk/WebKit

Reviewed by Adele.


  • start moving loading logic to new WebFrameLoader class; move management of WebLoaders there
  • Misc/WebIconLoader.h:
  • Misc/WebIconLoader.m: (-[WebIconLoader didFinishLoading]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _updateLoading]): (-[WebDataSource _loadIcon]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _stopLoading]): (-[WebDataSource _startLoading]): (-[WebDataSource _addSubresourceLoader:]): (-[WebDataSource _removeSubresourceLoader:]): (-[WebDataSource _addPlugInStreamLoader:]): (-[WebDataSource _removePlugInStreamLoader:]): (-[WebDataSource _iconLoaderReceivedPageIcon:]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _stopLoadingWithError:]): (-[WebDataSource _setupForReplaceByMIMEType:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource dealloc]): (-[WebDataSource finalize]): (-[WebDataSource data]): (-[WebDataSource isLoading]):
  • WebView/WebFrameLoader.h: Added.
  • WebView/WebFrameLoader.m: Added. (-[WebFrameLoader initWithDataSource:]): (-[WebFrameLoader dealloc]): (-[WebFrameLoader hasIconLoader]): (-[WebFrameLoader loadIconWithRequest:]): (-[WebFrameLoader stopLoadingIcon]): (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoadingPlugIns]): (-[WebFrameLoader isLoadingMainResource]): (-[WebFrameLoader isLoadingSubresources]): (-[WebFrameLoader isLoading]): (-[WebFrameLoader stopLoadingSubresources]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader mainResourceData]): (-[WebFrameLoader releaseMainResourceLoader]): (-[WebFrameLoader cancelMainResourceLoad]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader stopLoadingWithError:]):
11:34 AM Changeset in webkit [14975] by andersca
  • 3 edits
    2 adds in trunk

WebCore:

2006-06-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4499675> Package Tracker widget always crashes in WebCore::Frame::jScriptEnabled() const + 0

  • html/HTMLParser.cpp: (WebCore::HTMLParser::noscriptCreateErrorCheck): (WebCore::HTMLParser::canvasCreateErrorCheck): (WebCore::HTMLParser::isInline): Add null-checks for document->frame() since it can be 0 for documents created using createHTMLDocument.

LayoutTests:

2006-06-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4499675> Package Tracker widget always crashes in WebCore::Frame::jScriptEnabled() const + 0


  • fast/dom/noscript-canvas-in-created-html-document-expected.txt: Added.
  • fast/dom/noscript-canvas-in-created-html-document.html: Added.
10:48 AM Changeset in webkit [14974] by kdecker
  • 3 edits
    1 add in trunk/WebKitTools
10:46 AM Changeset in webkit [14973] by andersca
  • 6 edits
    4 adds in trunk

WebCore:

2006-06-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4524840> Entities contained in DOCTYPE referenced DTD in XSLT source document are unknown


  • dom/xml_tokenizer.cpp: (WebCore::shouldAllowExternalLoad): Use correct path for the catalog.


(WebCore::errorFunc):
Add error function to keep parser errors from going to the console.


(WebCore::XMLTokenizer::write):
Remove if (0 &&)


(WebCore::XMLTokenizer::end):
Pass DocLoader to xmlDocPtrForString.


(WebCore::xmlDocPtrForString):

  • dom/xml_tokenizer.h: Add DocLoader argument to xmlDocPtrForString so external DTDs and entities can be loaded.


  • xml/XSLTProcessor.cpp: (WebCore::xmlDocPtrFromNode): Pass DocLoader to xmlDocPtrForString


LayoutTests:

2006-06-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4524840> Entities contained in DOCTYPE referenced DTD in XSLT source document are unknown

  • fast/xsl/dtd-in-source-document-expected.txt: Added.
  • fast/xsl/dtd-in-source-document.xml: Added.
  • fast/xsl/resources/dtd-in-source-document.dtd: Added.
  • fast/xsl/resources/dtd-in-source-document.xsl: Added.
10:34 AM Changeset in webkit [14972] by thatcher
  • 8 edits in trunk/WebKitTools

Reviewed by Kevin Decker.

Code clean up. Adds the stackframe and makes only the body
of the tables scrollable keeping the header visible.
Shows the current function stack when paused or stepping.

  • Drosera/DebuggerApplication.m: (-[DebuggerApplication awakeFromNib]): (-[DebuggerApplication numberOfRowsInTableView:]): (-[DebuggerApplication tableView:objectValueForTableColumn:row:]):
  • Drosera/DebuggerDocument.h:
  • Drosera/DebuggerDocument.m: (-[DebuggerDocument dealloc]): (-[DebuggerDocument currentFrame]): (-[DebuggerDocument currentFrameFunctionName]): (-[DebuggerDocument currentFunctionStack]): (-[DebuggerDocument log:]): (-[DebuggerDocument windowWillClose:]): (-[DebuggerDocument webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[DebuggerDocument webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
  • Drosera/Drosera.xcodeproj/project.pbxproj:
  • Drosera/debugger.css:
  • Drosera/debugger.html:
  • Drosera/debugger.js:
10:18 AM Changeset in webkit [14971] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Anders.

Teach run-webkit-httpd to properly look for webkitdirs.pm.

  • Scripts/run-webkit-httpd:
8:01 AM Changeset in webkit [14970] by kdecker
  • 5 edits
    5 adds in trunk/WebKitTools
3:38 AM Changeset in webkit [14969] by ddkilzer
  • 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Build fix.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9539
Another case error preventing build

  • API/APICast.h: Changed "UString.h" to "ustring.h".
Note: See TracTimeline for information about the timeline view.