Context Navigation

WebView/WebViewPrivate.h: Added handleAuthenticationFromResource back into the header. Needed by the Dashboard, but was removed in r.14028 on 2006-04-23.

10:35 PM Changeset in webkit [15103] by ddkilzer

3 edits
4 adds in trunk

WebCore:

Reviewed by Justin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9505 moveParagraphContentsToNewBlockIfNecessary creates a new block outside the current position

editing/CompositeEditCommand.cpp: Added sanity checking to prevent modifying nodes outside of where we should be (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):

LayoutTests:

Reviewed by Justin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9505 moveParagraphContentsToNewBlockIfNecessary creates a new block outside the current position

editing/pasteboard/paste-table-002.html: Added.
editing/pasteboard/paste-table-002-expected.checksum: Added.
editing/pasteboard/paste-table-002-expected.png: Added.
editing/pasteboard/paste-table-002-expected.txt: Added.

9:45 PM Changeset in webkit [15102] by beidson

5 edits in trunk/WebCore

Reviewed by Levi.

In addition to a few small details, logging changes, and style cleanups, this is a stop-gap hack
for a problem in SQLite's blob handling. Querying for a blob in a void* form is reproducibly
returning a corrupt buffer. The temporary solution is to query for the blob as "quoted text" and
manually convert the return string into a character buffer.

icon/IconDatabase.cpp: (WebCore::IconDatabase::recreateDatabase): (WebCore::IconDatabase::createPrivateTables):

(WebCore::hexToUnsignedChar): These two functions are the text-to-character-data converters for the time being
(WebCore::hexStringToVector):

(WebCore::IconDatabase::imageDataForIconID):
(WebCore::IconDatabase::imageDataForIconURL):
(WebCore::IconDatabase::imageDataForPageURL):
(WebCore::IconDatabase::iconForPageURL):
(WebCore::IconDatabase::hasIconForIconURL):

icon/IconDatabase.h: changes the icon data accessors to return a Vector<unsigned char> instead of void*

icon/SQLStatement.cpp: (WebCore::SQLStatement::columnCount): (WebCore::SQLStatement::getColumnBlob):
icon/SiteIcon.cpp: (SiteIcon::getImage):

9:39 PM Changeset in webkit [15101] by ddkilzer

3 edits
4 adds in trunk

WebCore:

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9652 Assertion failure when changing an RTL table cell to display:none

Test: fast/table/rtl-cell-display-none-assert.html

rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows): Corrected the index used as the last index in the columnPos vector.

LayoutTests:

Reviewed by Darin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9652 Assertion failure when changing an RTL table cell to display:none

fast/table/rtl-cell-display-none-assert-expected.checksum: Added.
fast/table/rtl-cell-display-none-assert-expected.png: Added.
fast/table/rtl-cell-display-none-assert-expected.txt: Added.
fast/table/rtl-cell-display-none-assert.html: Added.

9:31 PM Changeset in webkit [15100] by tomernic

2 edits in trunk/WebKit

Reviewed by Kevin Decker.

<rdar://problem/4608487> REGRESSION: reproducible crash in +[WebCoreFrameBridge supportedImageMIMETypes]

Plugins/WebPluginDatabase.m: (+[WebPluginDatabase setAdditionalWebPlugInPaths:]): One might be tempted to add additionalWebPlugInPaths to the global WebPluginDatabase here. For backward compatibility with earlier versions of the +setAdditionalWebPlugInPaths: SPI, we need to save a copy of the additional paths and not cause a refresh of the plugin DB at this time. (-[WebPluginDatabase _plugInPaths]): Include additionalWebPlugInPaths if this is the global DB. (-[WebPluginDatabase refresh]): Call -_plugInPaths to get the modified array of paths. This is similar to what the old code (before we had per-WebView plugin search paths).

9:24 PM Changeset in webkit [15099] by ddkilzer

1 edit
14 adds in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

Bug 9615: Buildbot configuration should be in SVN repository
http://bugzilla.opendarwin.org/show_bug.cgi?id=9615

Import BuildBot configuration files as used by build.webkit.org.
auth.py has been stubbed out so that slave passwords are not disclosed.

BuildSlaveSupport/build.webkit.org-config/Makefile: Added.
BuildSlaveSupport/build.webkit.org-config/buildbot.css: Added.
BuildSlaveSupport/build.webkit.org-config/buildbot.tac: Added.
BuildSlaveSupport/build.webkit.org-config/master.cfg: Added.
BuildSlaveSupport/build.webkit.org-config/webkit/init.py: Added.
BuildSlaveSupport/build.webkit.org-config/webkit/auth.py: Added.
BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py: Added.
BuildSlaveSupport/build.webkit.org-config/webkit/builders.py: Added.
BuildSlaveSupport/build.webkit.org-config/webkit/factories.py: Added.
BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py: Added.
BuildSlaveSupport/build.webkit.org-config/webkit/status.py: Added.
BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Added.

9:20 PM Changeset in webkit [15098] by ddkilzer

6 edits
1 add in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

Bug 9614: Nightly builds should notify user if a newer build is available
http://bugzilla.opendarwin.org/show_bug.cgi?id=9614

BuildSlaveSupport/build-launcher-app: Write revision number to WebKit.app's VERSION file.
BuildSlaveSupport/build-launcher-dmg: Pass revision number to server-side nightly maintenance script so it can keep track of the latest revision.
Scripts/run-webkit-tests: Pass build-dumprendertree's exit status through correctly.
WebKitLauncher/VERSION: Added. Placeholder for SVN revision number
WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
WebKitLauncher/start.html: Retrieve revision number from VERSION file, and pass it through to the nightly start page.

7:56 PM Changeset in webkit [15097] by darin

6 edits
2 adds in trunk/WebCore

Reviewed by Anders.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9622 showModalDialog returnValue ignored, function result is always "undefined"

manual-tests/modal-dialog.html: Added.
manual-tests/show-modal-dialog-test.html: Added.

page/Frame.cpp: (WebCore::Frame::clear): Call KJSProxy::clear with the clearWindowProperties parameter instead of not calling it at all when clearWindowProperties is false.

bindings/js/kjs_proxy.h: Add boolean clearWindowProperties parameter.
bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::clear): Pass clearWindowProperties variable through to Window::clear instead of not calling it at all.

bindings/js/kjs_window.h: Add boolean clearWindowProperties parameter.
bindings/js/kjs_window.cpp: (KJS::Window::clear): If clearWindowProperties is false, do only the returnValue work, not the rest of the work.

manual-tests/modal-dialog.html: Added.
manual-tests/show-modal-dialog-test.html: Added.

4:32 PM Changeset in webkit [15096] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by Geoff.

add headerdoc comments to some of the new JS API headers

API/JSBase.h:
API/JSValueRef.h:

4:18 PM Changeset in webkit [15095] by bdakin

17 edits
5 adds in trunk

Reviewed by Hyatt.

Fix for <rdar://problem/4450615> Add composite mode to background
styles

-webkit-background-composite will set a composite mode on a
background image.

css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSPropertyNames.in: Add -webkit-background-composite
css/CSSValueKeywords.in: Add all possible values (clear, copy, source-over, source-in, source-out, source-atop, destination-over, destination-in, destination-out, destination-atop, xor, plus- darker, highlight, and plus-lighter)
css/cssparser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseBackgroundProperty):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundComposite):
css/cssstyleselector.h:
platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawTiledImage):
platform/GraphicsContext.h: drawTiledImage() now takes a composite operator.
platform/Image.h: drawTiled() now takes a composite operator.
platform/cairo/ImageCairo.cpp: (WebCore::Image::drawTiled): Set the composite operator.
platform/mac/ImageMac.mm: (WebCore::Image::drawTiled): Set the composite operator.
platform/win/TemporaryLinkStubs.cpp: (Image::drawTiled):
rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended): Send the composite operator in the render style over to the graphics context.
rendering/render_style.cpp: (WebCore::BackgroundLayer::BackgroundLayer): (WebCore::BackgroundLayer::operator=): (WebCore::BackgroundLayer::operator==): (WebCore::BackgroundLayer::fillUnsetProperties): (WebCore::BackgroundLayer::cullEmptyLayers):
rendering/render_style.h: (WebCore::BackgroundLayer::backgroundComposite): (WebCore::BackgroundLayer::isBackgroundCompositeSet): (WebCore::BackgroundLayer::setBackgroundComposite): (WebCore::BackgroundLayer::clearBackgroundComposite): (WebCore::RenderStyle::backgroundComposite): (WebCore::RenderStyle::initialBackgroundComposite):

12:28 PM Changeset in webkit [15094] by tomernic

3 edits in trunk/WebKit

Reviewed by John Sullivan.

WebHistoryItem now supports getting and setting arbitrary properties via _transientPropertyForKey: and
-_setTransientProperty:forKey:.
For now, these properties do not persist with the rest of the history data. They are intended to hold transient
per-history-item state, which is something that was until now difficult for a WebKit client app to do.

History/WebHistoryItemPrivate.h:
History/WebHistoryItem.m: (-[WebHistoryItemPrivate dealloc]): (-[WebHistoryItem _transientPropertyForKey:]): (-[WebHistoryItem _setTransientProperty:forKey:]):

11:18 AM Changeset in webkit [15093] by thatcher

6 edits in trunk/WebKit

Reviewed by Harrison.

Smart insert and delete, continuous spell checking and autoscroll
can now be used for any WebView, not just editable ones. All of
these make sense for documents that might contain content editable
areas or our new text fields. Autoscroll is usefull for dragging
for file input controls also.

Added a SPI to toggle WebViews tab key behavior, tabKeyCyclesThroughElements.
WebHTMLView's _interceptEditingKeyEvent now uses WebView's
tabKeyCyclesThroughElements state to determine whether or not
to process tab key events. The idea here is that tabKeyCyclesThroughElements
will be YES when this WebView is being used in a browser, and we
desire the behavior where tab moves to the next element in tab order.
If tabKeyCyclesThroughElements is NO, it is likely that the WebView
is being embedded as the whole view, as in Mail, and tabs should input
tabs as expected in a text editor. Using Option-Tab always cycles
through elements.

WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
WebView/WebHTMLView.m: (-[NSArray _interceptEditingKeyEvent:]):
WebView/WebView.m: (-[WebViewPrivate init]): (-[WebView _autoscrollForDraggingInfo:timeDelta:]): (-[WebView _shouldAutoscrollForDraggingInfo:]): (-[WebView validateUserInterfaceItem:]): (-[WebView toggleSmartInsertDelete:]): (-[WebView toggleContinuousSpellChecking:]): (-[WebView setTabKeyCyclesThroughElements:]): (-[WebView tabKeyCyclesThroughElements]):
WebView/WebViewPrivate.h:

8:28 AM Changeset in webkit [15092] by ddkilzer

6 edits in trunk/WebCore

WebCore:

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9649
The no-svg build broke after r15091

bindings/objc/DOMInternal.h: Added #if XPATH_SUPPORT/#endif.
bindings/objc/DOMInternal.mm: Ditto. (raiseDOMException):
bindings/objc/DOMXPath.h: Ditto.
bindings/objc/DOMXPath.mm: Ditto.
bindings/objc/DOMXPathInternal.h: Ditto.

12:54 AM Changeset in webkit [15091] by andersca

6 edits
3 adds in trunk

WebCore:

2006-06-29 Anders Carlsson <acarlsson@apple.com>

Reviewed by Tim O.

<rdar://problem/4599760> Objective-C XPath support

WebCore.xcodeproj/project.pbxproj: Add files.

bindings/objc/DOMInternal.h:
bindings/objc/DOMInternal.mm: (raiseDOMException): Handle XPath exceptions

bindings/objc/DOMXPath.h: Added. (-[DOMXPathNSResolver lookupNamespaceURI:]):
bindings/objc/DOMXPath.mm: Added. (-[DOMNativeXPathNSResolver dealloc]): (-[DOMNativeXPathNSResolver finalize]): (-[DOMNativeXPathNSResolver _xpathNSResolver]): (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:]): (+[DOMNativeXPathNSResolver _xpathNSResolverWith:]): (-[DOMNativeXPathNSResolver lookupNamespaceURI:]): (-[DOMXPathResult dealloc]): (-[DOMXPathResult finalize]): (-[DOMXPathResult resultType]): (-[DOMXPathResult numberValue]): (-[DOMXPathResult stringValue]): (-[DOMXPathResult booleanValue]): (-[DOMXPathResult singleNodeValue]): (-[DOMXPathResult invalidIteratorState]): (-[DOMXPathResult snapshotLength]): (-[DOMXPathResult iterateNext]): (-[DOMXPathResult snapshotItem:]): (-[DOMXPathResult _xpathResult]): (-[DOMXPathResult _initWithXPathResult:]): (+[DOMXPathResult _xpathResultWith:]): (-[DOMXPathExpression evaluate:::]): (-[DOMXPathExpression _xpathExpression]): (-[DOMXPathExpression _initWithXPathExpression:]): (+[DOMXPathExpression _xpathExpressionWith:]): (-[DOMDocument createExpression::]): (-[DOMDocument createNSResolver:]): (-[DOMDocument evaluate:::::]):
bindings/objc/DOMXPathInternal.h: Added. Add Objective-C XPath API.

WebKit:

2006-06-29 Anders Carlsson <acarlsson@apple.com>

Reviewed by Tim O.

WebKit.xcodeproj/project.pbxproj: Add DOMXPath.h header.

Jun 28, 2006:

5:32 PM Changeset in webkit [15090] by hyatt

11 edits in trunk

WebCore:

Add support for custom highlighting to paint at the root line box level
(and to inflate the box it uses so that it can go outside the bounds of
the line if necessary).

Reviewed by harrison

bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::customHighlightLineRect): (WebCore::FrameMac::paintCustomHighlight):
bridge/mac/WebCoreFrameBridge.h:
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintCustomHighlight):
rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::paintCustomHighlight): (WebCore::RootInlineBox::paint):
rendering/RootInlineBox.h:

WebKit:

Fix custom highlighting so that you can paint the entire line (and go
outside the bounds of the line).

Reviewed by harrison

WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge customHighlightRect:forLine:]): (-[WebFrameBridge paintCustomHighlight:forBox:onLine:behindText:entireLine:]):
WebKit.xcodeproj/project.pbxproj:
WebView/WebHTMLViewPrivate.h:

5:20 PM Changeset in webkit [15089] by mjs

2 edits in trunk/WebKit

Reviewed by Anders.

fix Frame leak on layout tests

WebCoreSupport/WebPageBridge.m: (-[WebPageBridge outerView]): Return WebFrameView for main frame instead of WebView to avoid reference cycle between WebView and Page.

4:44 PM Changeset in webkit [15088] by lweintraub

5 edits
16 adds in trunk

LayoutTests:

Reviewed by justin

<rdar://problem/4592005> FormatBlock inserts in the wrong place, disregarding editable content
<rdar://problem/4590763> FormatBlock for paragraph style doesn't work

editing/execCommand/format-block-with-braces-expected.checksum: Added.
editing/execCommand/format-block-with-braces-expected.png: Added.
editing/execCommand/format-block-with-braces-expected.txt: Added.
editing/execCommand/format-block-with-braces.html: Added.
editing/execCommand/indent-list-item-expected.checksum: Added.
editing/execCommand/indent-list-item-expected.png: Added.
editing/execCommand/indent-list-item-expected.txt: Added.
editing/execCommand/indent-list-item.html: Added.
editing/execCommand/indent-selection-expected.checksum: Added.
editing/execCommand/indent-selection-expected.png: Added.
editing/execCommand/indent-selection-expected.txt: Added.
editing/execCommand/indent-selection.html: Added.
editing/execCommand/outdent-selection-expected.checksum: Added.
editing/execCommand/outdent-selection-expected.png: Added.
editing/execCommand/outdent-selection-expected.txt: Added.
editing/execCommand/outdent-selection.html: Added.

WebCore:

Reviewed by justin

<rdar://problem/4592005> FormatBlock inserts in the wrong place, disregarding editable content
<rdar://problem/4590763> FormatBlock for paragraph style doesn't work

dom/Node.cpp: (WebCore::Node::rootEditableElement): Return inline nodes
editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply): Keep from inserting before editable content
editing/JSEditor.cpp: Support html braces (<>) around tag names

4:18 PM Changeset in webkit [15087] by justing

3 edits in trunk/WebCore

Reviewed by levi

svg/custom/text-hit-test.svg was failing

rendering/RenderContainer.cpp: (WebCore::RenderContainer::positionForCoordinates): Don't skip child renderers that have a height of 0 when looking for the closest child renderer, they may contain content that overflows.
rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates): Fixed typos.

1:43 PM Changeset in webkit [15086] by hyatt

3 edits in trunk/WebCore

Make the view source document properly handle <script>. We don't syntax
highlight the JS yet, but it shows up properly now.

Reviewed by john

WebCore.xcodeproj/project.pbxproj:
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler):

1:32 PM Changeset in webkit [15085] by thatcher

8 edits in trunk

JavaScriptCore:

Prefer the Stabs debugging symbols format until DWARF bugs are fixed.

JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

Prefer the Stabs debugging symbols format until DWARF bugs are fixed.

JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Prefer the Stabs debugging symbols format until DWARF bugs are fixed.

WebCore.xcodeproj/project.pbxproj:

WebKit:

Prefer the Stabs debugging symbols format until DWARF bugs are fixed.

WebKit.xcodeproj/project.pbxproj:

1:18 PM Changeset in webkit [15084] by justing

4 edits in trunk/WebCore

Reviewed by levi

Fixed EditActions for InsertHorizontalRule and RemoveFormat.

editing/JSEditor.cpp:
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::editingAction):
editing/ReplaceSelectionCommand.h:

1:09 PM Changeset in webkit [15083] by aliceli1

1 edit in trunk/WebKitSite/projects/compat/hitlist.html

added google spreadsheets and yahoo mail beta, moved google calendar and yahoo preview to alumni list.

11:58 AM Changeset in webkit [15082] by lweintraub

1 edit in trunk/WebCore/bridge/mac/WebCoreFrameBridge.h

Build Fix

11:36 AM Changeset in webkit [15081] by lweintraub

2 edits in trunk/WebCore

Build Fix. Reviewed by NOBODY

editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion):

11:17 AM Changeset in webkit [15080] by lweintraub

11 edits
2 adds in trunk

LayoutTests:

Reviewed by justin

http://bugzilla.opendarwin.org/show_bug.cgi?id=7568
Bug 7568: Implement Indent/Outdent

editing/execCommand/indent-list-item-expected.checksum: Added.
editing/execCommand/indent-list-item-expected.png: Added.
editing/execCommand/indent-list-item-expected.txt: Added.
editing/execCommand/indent-list-item.html: Added.
editing/execCommand/indent-selection-expected.checksum: Added.
editing/execCommand/indent-selection-expected.png: Added.
editing/execCommand/indent-selection-expected.txt: Added.
editing/execCommand/indent-selection.html: Added.
editing/execCommand/outdent-selection.html: Added.

WebCore:

Reviewed by justin

http://bugzilla.opendarwin.org/show_bug.cgi?id=7568
Bug 7568: Implement Indent/Outdent

WebCore.vcproj/WebCore/WebCore.vcproj: Added IndentOutdentCommand.h/cpp
WebCore.xcodeproj/project.pbxproj: Ditto.
editing/IndentOutdentCommand.cpp: Added. (WebCore::IndentOutdentCommand::IndentOutdentCommand): (WebCore::enclosingListOrBlockquote): (WebCore::IndentOutdentCommand::splitTreeToNode): Splits the DOM tree from a descendent node to an ending ancestor, duplicating nodes when necessary. Returns the last node split. Used to insert blockquotes at the topmost level. (WebCore::IndentOutdentCommand::indentRegion): (WebCore::IndentOutdentCommand::outdentParagraph): (WebCore::IndentOutdentCommand::outdentRegion): (WebCore::IndentOutdentCommand::doApply):
editing/IndentOutdentCommand.h: Added. (WebCore::IndentOutdentCommand::):
editing/JSEditor.cpp: Added the execCommands Indent and Outdent
editing/htmlediting.cpp: (WebCore::enclosingNodeWithTag): Finds the enclosing node with any specified tag. (WebCore::enclosingListChild): Added checks for nill and editable boundaries. (WebCore::outermostEnclosingListChild): Returns the highest ancestor list child. (WebCore::highestAncestor): Added. (WebCore::createElement): Changed the passed in string to a const reference.
editing/htmlediting.h:

WebKit:

Reviewed by justin

http://bugzilla.opendarwin.org/show_bug.cgi?id=7568
Bug 7568: Implement Indent/Outdent
Added undo action strings and enum values

English.lproj/Localizable.strings:
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge nameForUndoAction:]):

8:42 AM Changeset in webkit [15079] by darin

9 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin and Hyatt.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9561 REGRESSION: Content property on :before of button causes hang on click or hover

fast/forms/button-generated-content-expected.checksum: Added.
fast/forms/button-generated-content-expected.png: Added.
fast/forms/button-generated-content-expected.txt: Added.
fast/forms/button-generated-content.html: Added.

WebCore:

Reviewed by Darin and Hyatt.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9561 REGRESSION: Content property on :before of button causes hang on click or hover

Test: fast/forms/button-generated-content.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::setStyle):
rendering/RenderButton.cpp: (WebCore::RenderButton::updatePseudoChild): Added. Calls updatePseudoChildForObject() on the button itself or on its inner div, if it has one.
rendering/RenderButton.h: (WebCore::RenderButton::createsAnonymousWrapper): Added. Returns true.
rendering/RenderContainer.cpp: (WebCore::RenderContainer::pseudoChild): Added. Returns the child containing generated content of the requested type if there is one, or otherwise the child before/after which such generated content should come. (WebCore::RenderContainer::updatePseudoChild): Removed the child parameter and moved the guts of this method into updatePseudoChildForObject, which this method calls unless the object is an anonymous wrapper. (WebCore::RenderContainer::updatePseudoChildForObject): Added. Does the what updatePseudoChildForObject did previously, but fetches the pseudo style from the styledObject parameter.
rendering/RenderContainer.h:
rendering/RenderInline.cpp: (WebCore::RenderInline::setStyle): (WebCore::RenderInline::addChildToFlow): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow):
rendering/RenderObject.h: (WebCore::RenderObject::createsAnonymousWrapper): Added. This method replaces allowsReusingAnonymousChild and returns the opposite of what that method used to return. Returns true if the object creates an anonymous child to contain all its other children.

7:39 AM Changeset in webkit [15078] by darin

3 edits in trunk/LayoutTests

Reviewed by Darin.

Improved test to check offsetX/Y after dispatching instead of before.

fast/dom/window-xy-properties.html:
fast/dom/window-xy-properties-expected.txt:

12:18 AM Changeset in webkit [15077] by beidson

10 edits
1 add in trunk

WebCore:

Reviewed by Maciej

Hookup the new semi-functional SQLite icon database.
For now, it is living side-by-side with the old DB so one can compare the
two for debugging purposes. Also, it is disabled (in WebKit) by default unless you
compile with ICONDEBUG #defined.

WebCore.xcodeproj/project.pbxproj: Added file SiteIcon.cpp

bridge/mac/WebCoreIconDatabaseBridge.h:
bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]): (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]): (-[WebCoreIconDatabaseBridge iconURLForPageURL:]): (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):

icon/IconDatabase.cpp: (WebCore::IconDatabase::isValidDatabase): (WebCore::IconDatabase::recreateDatabase): (WebCore::IconDatabase::createPrivateTables): (WebCore::IconDatabase::deletePrivateTables): (WebCore::IconDatabase::imageDataForIconID): (WebCore::IconDatabase::imageDataForIconURL): (WebCore::IconDatabase::imageDataForPageURL): (WebCore::IconDatabase::setPrivateBrowsingEnabled): (WebCore::IconDatabase::iconForPageURL): (WebCore::IconDatabase::iconURLForURL): (WebCore::IconDatabase::setIconDataForIconURL): (WebCore::IconDatabase::establishIconIDForEscapedIconURL): (WebCore::IconDatabase::setHaveNoIconForIconURL): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::hasIconForIconURL):
icon/IconDatabase.h: (WebCore::SiteIcon::getIconURL): (WebCore::IconDatabase::getPrivateBrowsingEnabled):

icon/SiteIcon.cpp: Added. (SiteIcon::SiteIcon): (SiteIcon::~SiteIcon): (SiteIcon::getImage): (SiteIcon::resetExpiration): (SiteIcon::getExpiration):

WebKit:

Reviewed by Maciej

Hookup the new semi-functional SQLite icon database.
For now, it is living side-by-side with the old DB so one can compare the
two for debugging purposes. Also, it is disabled (in WebKit) by default unless you
compile with ICONDEBUG #defined.
Note: To repeat that, if you want to try the new DB, #define ICONDEBUG (WebKitPrefix.h is a good place to do it)

Misc/WebIconDatabase.m: (-[NSMutableDictionary iconForURL:withSize:cache:]): (-[NSMutableDictionary iconURLForURL:]): (-[NSMutableDictionary retainIconForURL:]): (-[NSMutableDictionary releaseIconForURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _hasIconForIconURL:]): (-[WebIconDatabase _resetCachedWebPreferences:]):
Misc/WebIconLoader.m: (-[WebIconLoader didFinishLoading]):
WebKit.xcodeproj/project.pbxproj:

Jun 27, 2006:

8:52 PM Changeset in webkit [15076] by darin

7 edits in trunk

LayoutTests:

Reviewed by Darin.

Updated test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9605

fast/dom/window-xy-properties.html:
fast/dom/window-xy-properties-expected.txt:

WebCore:

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9605
REGRESSION: pageX and pageY are both 0 for events created with initMouseEvent

Calculate pageX/pageY and clientX/clientY values when using initMouseEvent.

dom/MouseEvent.cpp: (WebCore::MouseEvent::initMouseEvent):
dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::initCoordinates):
dom/MouseRelatedEvent.h:

8:32 PM Changeset in webkit [15075] by darin

4 edits
2 adds in trunk

LayoutTests:

Reviewed by Darin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9317 REGRESSION: crash in HTML tokenizer at Japanese Apple support page

fast/tokenizer/write-unclosed-script-expected.txt: Added.
fast/tokenizer/write-unclosed-script.html: Added.

WebCore:

Reviewed by Maciej and Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9317 REGRESSION: crash in HTML tokenizer at Japanese Apple support page

Test: fast/tokenizer/write-unclosed-script.html

html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): Changed to reset the inScript flag and scriptCodeSize before possible script execution, but not afterwards. This way, if script execution write()s a <script> tag without closing it, the tokenizer is left in inScript state. Added code to set the requestingScript flag around the request for the cached script, to let notifiyFinished() know that it's being called under scriptHandler(). (WebCore::HTMLTokenizer::scriptExecution): Removed code that saved and restored the inScript flag. This function is always entered now with inScript being false. (WebCore::HTMLTokenizer::notifyFinished): Changed to use the new requestingScript state flag instead of the inScript flag, which is always false now when entering this function.
html/HTMLTokenizer.h: Added the requestingScript state bit, used to tell notifyFinished() that it is being called under scriptHandler() (which happens when the script is already in cache).

7:26 PM Changeset in webkit [15074] by justing

1 edit in trunk/LayoutTests/editing/execCommand/remove-formatting.html

Fixed some typos.

7:23 PM Changeset in webkit [15073] by justing

3 edits
4 adds in trunk

LayoutTests:

Reviewed by levi

editing/execCommand/remove-formatting-expected.checksum: Added.
editing/execCommand/remove-formatting-expected.png: Added.
editing/execCommand/remove-formatting-expected.txt: Added.
editing/execCommand/remove-formatting.html: Added.

WebCore:

Reviewed by levi

editing/JSEditor.cpp: Added RemoveFormat.

7:17 PM Changeset in webkit [15072] by kdecker

2 edits in trunk/WebCore

5:18 PM Changeset in webkit [15071] by thatcher

9 edits in trunk/JavaScriptCore

Reviewed by Tim O.

<rdar://problem/4448350> Deprecated ObjC language API used in JavaScriptCore, WebCore, WebKit and WebBrowser

Switch to the new ObjC 2 API, ifdefed the old code around OBJC_API_VERSION so it still works on Tiger.
Removed the use of the old stringWithCString, switched to the new Tiger version that accepts an encoding.
Lots of code style cleanup.

JavaScriptCore.xcodeproj/project.pbxproj:
bindings/objc/objc_class.h:
bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::~ObjcClass): (KJS::Bindings::_createClassesByIsAIfNecessary): (KJS::Bindings::ObjcClass::classForIsA): (KJS::Bindings::ObjcClass::name): (KJS::Bindings::ObjcClass::methodsNamed): (KJS::Bindings::ObjcClass::fieldNamed): (KJS::Bindings::ObjcClass::fallbackObject):
bindings/objc/objc_header.h:
bindings/objc/objc_instance.h:
bindings/objc/objc_instance.mm: (ObjcInstance::ObjcInstance): (ObjcInstance::~ObjcInstance): (ObjcInstance::operator=): (ObjcInstance::begin): (ObjcInstance::end): (ObjcInstance::getClass): (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod): (ObjcInstance::setValueOfField): (ObjcInstance::supportsSetValueOfUndefinedField): (ObjcInstance::setValueOfUndefinedField): (ObjcInstance::getValueOfField): (ObjcInstance::getValueOfUndefinedField): (ObjcInstance::defaultValue): (ObjcInstance::stringValue): (ObjcInstance::numberValue): (ObjcInstance::booleanValue): (ObjcInstance::valueOf):
bindings/objc/objc_runtime.h:
bindings/objc/objc_runtime.mm: (ObjcMethod::ObjcMethod): (ObjcMethod::name): (ObjcMethod::getMethodSignature): (ObjcMethod::setJavaScriptName): (ObjcField::name): (ObjcField::type): (ObjcField::valueFromInstance): (convertValueToObjcObject): (ObjcField::setValueToInstance): (ObjcArray::operator=): (ObjcArray::setValueAt): (ObjcArray::valueAt): (ObjcFallbackObjectImp::ObjcFallbackObjectImp): (ObjcFallbackObjectImp::callAsFunction): (ObjcFallbackObjectImp::defaultValue):

4:59 PM Changeset in webkit [15070] by andersca

2 edits in trunk/JavaScriptCore

2006-06-28 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

http://bugzilla.opendarwin.org/show_bug.cgi?id=8636
REGRESSION: JavaScript access to Java applet causes hang (_webViewURL not implemented)

bindings/jni/jni_objc.mm: (KJS::Bindings::dispatchJNICall): Just pass nil as the calling URL. This will cause the Java plugin to use the URL of the page containing the applet (which is what we used to do).

4:58 PM Changeset in webkit [15069] by andersca

3 edits in trunk/WebCore

2006-06-28 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Move FIXME comment here.

page/DOMWindow.cpp: (WebCore::DOMWindow::getComputedStyle): Don't do a null check on the renderer here. Everything's handled by CSSComputedStyleDeclaration anyway.

3:56 PM Changeset in webkit [15068] by justing

2 edits in trunk/WebCore

Reviewed by darin

rendering/RenderContainer.cpp: Fixed #include formatting.

3:26 PM Changeset in webkit [15067] by justing

6 edits
2 adds in trunk

LayoutTests:

Reviewed by levi

<rdar://problem/4599735> Clicking out of a table at the extremes of an editable document doesn't appear to work

Added:

editing/selection/click-before-and-after-table-expected.txt: Added.
editing/selection/click-before-and-after-table.html: Added. Updated to reflect fix:
editing/selection/move-by-line-001-expected.checksum:
editing/selection/move-by-line-001-expected.png:

WebCore:

Reviewed by levi

<rdar://problem/4599735> Clicking out of a table at the extremes of an editable document doesn't appear to work

rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForCoordinates): In the fall through case, where we can't find a child block that contains (x, y), pass to RenderFlow instead of the last visible child block.
rendering/RenderContainer.cpp: (WebCore::RenderContainer::positionForCoordinates): Don't pass to the closest child renderer if this is a table and (x, y) is outside the table. Return a VisiblePosition before or after the table. Fixed the code that finds the closest child renderer.

3:04 PM Changeset in webkit [15066] by hyatt

3 edits in trunk/WebCore

Preserve entity text in view source mode. This patch doesn't highlight the
the entities yet, but it at least prevents their resolution and removal.

Reviewed by darin

WebCore.xcodeproj/project.pbxproj:
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseEntity):

2:30 PM Changeset in webkit [15065] by andersca

3 edits
2 adds in trunk

WebCore:

2006-06-27 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9623
REGRESSION: getComputedStyle should do a relayout

page/DOMWindow.cpp: (WebCore::DOMWindow::getComputedStyle): Do a relayout.

LayoutTests:

2006-06-27 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9623
REGRESSION: getComputedStyle should do a relayout

fast/css/getComputedStyle-relayout-expected.txt: Added.
fast/css/getComputedStyle-relayout.html: Added.

2:13 PM Changeset in webkit [15064] by thatcher

1 edit in trunk/JavaScriptCore/JavaScriptCore.exp

Adding symbols for debug builds.

2:03 PM Changeset in webkit [15063] by thatcher

1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.7/JavaScriptCore

JavaScriptCore 10.4.7 release.

2:02 PM Changeset in webkit [15062] by thatcher

1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.7/WebCore

WebCore 10.4.7 release.

2:02 PM Changeset in webkit [15061] by thatcher

1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.7/WebKit

WebKit 10.4.7 release.

2:00 PM Changeset in webkit [15060] by thatcher

1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.7/JavaScriptGlue

JavaScriptGlue 10.4.7 release.

1:59 PM Changeset in webkit [15059] by thatcher

1 add in releases/Apple/Tiger/Mac OS X Update 10.4.7

10.4.7 release tag.

1:53 PM Changeset in webkit [15058] by thatcher

2 edits
1 add in trunk/JavaScriptCore

Reviewed by Darin.

<rdar://problem/4406785> Add an export file to TOT JavaScriptCore like the Safari-2-0-branch

JavaScriptCore.exp: Added.
JavaScriptCore.xcodeproj/project.pbxproj:

1:36 PM Changeset in webkit [15057] by mjs

3 edits in trunk/WebCore

Reviewed by Adele

fixed <rdar://problem/4550473> Reproducible hang on www.digg.com

dom/NodeList.cpp: (WebCore::NodeList::recursiveItem): Make NodeList caching also work for backwards iteration - if the requested index is before the last cached, but closer to it than to the start of the list, then search backwards from there. (WebCore::NodeList::itemForwardsFromCurrent): Split this out as a helper method. (WebCore::NodeList::itemBackwardsFromCurrent): New helper, similar to the above.
dom/NodeList.h:

12:07 PM Changeset in webkit [15056] by beidson

4 edits in trunk/WebCore

Reviewed by Levi

Some SQLDatabase cleanup (style stuff) and enhancements

icon/SQLDatabase.cpp: (SQLDatabase::open): (SQLDatabase::executeCommand): (SQLDatabase::returnsAtLeastOneResult): Accessor to see if this query returns results (SQLDatabase::lastInsertRowID): Accessor for the rowid of the last insert
icon/SQLDatabase.h: (WebCore::SQLStatement::prepareAndStep):
icon/SQLStatement.cpp: (WebCore::SQLStatement::bindInt64): -All of the following used to require the user to manually prepare and step a statement before asking for the result. Now it will prepare and step itself so you can use a temporary object to get a quick result (WebCore::SQLStatement::getColumnName): (WebCore::SQLStatement::getColumnName16): (WebCore::SQLStatement::getColumnText): (WebCore::SQLStatement::getColumnText16): (WebCore::SQLStatement::getColumnDouble): (WebCore::SQLStatement::getColumnInt): (WebCore::SQLStatement::getColumnInt64): (WebCore::SQLStatement::getColumnBlobAsVector): (WebCore::SQLStatement::getColumnBlob):

11:15 AM Changeset in webkit [15055] by adachan

2 edits in trunk/WebCore

2006-06-27 Ada Chan <adachan@apple.com>

Reviewed by sfalken.

Fixed build.

WebCore.vcproj/WebCore/WebCore.vcproj:

10:56 AM Changeset in webkit [15054] by bdakin

4 edits
15 adds in trunk

Reviewed by Hyatt.

Fix for <rdar://problem/4602635> Media queries must be extended to
address CSS pixel scaling factor

css/MediaFeatureNames.h: Add -webkit-device-pixel-ratio, -webkit- min-device-pixel-ratio, and -webkit-max-device-pixel-ratio to the list of feature names.
css/MediaQueryEvaluator.cpp: (WebCore::cmpvalue): Added a version of cmpvalue that compares floats. (WebCore::device_pixel_ratioMediaFeatureEval): (WebCore::min_device_pixel_ratioMediaFeatureEval): (WebCore::max_device_pixel_ratioMediaFeatureEval):

10:44 AM Changeset in webkit [15053] by darin

2 edits in trunk/WebCore

Reviewed by Geoff.

finish with http://bugzilla.opendarwin.org/show_bug.cgi?id=9606 REGRESSION: some callers are still using clientX/Y to get pageX/Y

rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize): Change to use pageX/Y, but this really doesn't matter since framesets can't be scrolled -- it's the frames that are scrolled. So this change has no user-visible effect, but it's still better this way.

10:22 AM Changeset in webkit [15052] by darin

4 edits
4 adds in trunk

LayoutTests:

Tests for fix for 2/3 of http://bugzilla.opendarwin.org/show_bug.cgi?id=9606
REGRESSION: some callers are still using clientX/Y to get pageX/Y

fast/events/anchor-image-scrolled-x-y-expected.txt: Added.
fast/events/anchor-image-scrolled-x-y.html: Added.
fast/events/input-image-scrolled-x-y-expected.txt: Added.
fast/events/input-image-scrolled-x-y.html: Added.

WebCore:

Reviewed by Geoff.

fix 2/3 of http://bugzilla.opendarwin.org/show_bug.cgi?id=9606 REGRESSION: some callers are still using clientX/Y to get pageX/Y

Test: fast/events/anchor-image-scrolled-x-y.html
Test: fast/events/input-image-scrolled-x-y.html

html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Use pageX/Y.
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Ditto.

12:35 AM Changeset in webkit [15051] by beidson

2 edits in trunk/WebCore

Reviewed by Maciej

Added functionality to WebCore::Image to get multiple representations/sizes into TIFF data

platform/mac/ImageMac.mm: (WebCore::Image::getTIFFRepresentation):

Jun 26, 2006:

4:53 PM Changeset in webkit [15050] by hyatt

18 edits
3 adds in trunk/WebCore

Fix for 9538, support syntax highlighted HTML source. Lots of loose
ends still (script/style/comments/doctype/entities/accurate whitespace).

Reviewed by darin

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setInViewSourceMode:]): (-[WebCoreFrameBridge inViewSourceMode]):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::matchUARules):
css/cssstyleselector.h:
css/view-source.css: Added.
dom/Document.cpp: (WebCore::Document::implicitClose):
dom/xml_tokenizer.h: (WebCore::Tokenizer::Tokenizer): (WebCore::Tokenizer::~Tokenizer): (WebCore::Tokenizer::inViewSourceMode): (WebCore::Tokenizer::setInViewSourceMode):
html/HTMLAttributeNames.in:
html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::init): (WebCore::HTMLFrameElement::parseMappedAttribute): (WebCore::HTMLFrameElement::attach):
html/HTMLFrameElement.h: (WebCore::HTMLFrameElement::viewSourceMode):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::continueProcessing): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::timerFired): (WebCore::HTMLTokenizer::end): (WebCore::HTMLTokenizer::processToken): (WebCore::HTMLTokenizer::notifyFinished):
html/HTMLTokenizer.h:
html/HTMLViewSourceDocument.cpp: Added. (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): (WebCore::HTMLViewSourceDocument::createTokenizer): (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addViewSourceAttribute): (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
html/HTMLViewSourceDocument.h: Added.
page/Frame.cpp: (WebCore::Frame::begin): (WebCore::Frame::inViewSourceMode): (WebCore::Frame::setInViewSourceMode):
page/Frame.h:
page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):

4:48 PM Changeset in webkit [15049] by hyatt

4 edits in trunk/WebKit

Fix for 9538, support syntax highlighting for HTML source.

Reviewed by darin

WebKit.xcodeproj/project.pbxproj:
WebView/WebView.m: (-[WebView _setInViewSourceMode:]): (-[WebView _inViewSourceMode]):
WebView/WebViewPrivate.h:

2:26 PM Changeset in webkit [15048] by andersca

4 edits in trunk/WebCore

2006-06-26 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9031
REGRESSION: Crash when closing tabs on newegg.com

page/Frame.cpp: (WebCore::Frame::pageDestroyed):
page/Frame.h: Add new method which is invoked when the frame's page has been destroyed. Currently this function disassociates the JS Window object with the frame, stopping any running JS timers.

page/Page.cpp: (WebCore::Page::~Page): Call pageDestroyed on all frames.

9:38 AM Changeset in webkit [15047] by darin

10 edits in trunk/WebCore

Reviewed and reworked by Darin.

Code cleanup, calculate clientX/clientY in one central place.

dom/EventTargetNode.h:
dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent): Renamed parameters to pageX/Y since they aren't clientX/Y values. Removed code to compute clientX/Y (was a bit confused in naming before), because that's now done inside MouseEvent.

dom/MouseEvent.h:
dom/MouseEvent.cpp: (WebCore::MouseEvent::MouseEvent): Removed clientX/Y parameters. (WebCore::MouseEvent::initMouseEvent): Added comments about problems I noticed. (WebCore::MouseEvent::which): Fixed comment that confusingly mentioned KHTML, when it was talking about the DOM standard.

dom/MouseRelatedEvent.h:
dom/MouseRelatedEvent.cpp: (WebCore::contentsX): Added helper function. (WebCore::contentsY): Ditto. (WebCore::MouseRelatedEvent::MouseRelatedEvent): Removed clientX/Y parameter, and added code to compute clientX/Y based on pageX/Y. (WebCore::MouseRelatedEvent::receivedTarget): Fixed comments.

dom/WheelEvent.h:
dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): Removed clientX/Y parameter.

page/FrameView.cpp: (WebCore::FrameView::dispatchDragEvent): Removed the code to compute coordinates, and renamed the confusingly named clientPos (which was a page-relative position) to contentsPos.

8:26 AM Changeset in webkit [15046] by darin

4 edits in trunk

LayoutTests:

Reviewed by Darin.

LayoutTests/fast/events/objc-event-api-expected.txt: Updated to reflect flipped coordinates dumped by the layout tests.

WebKitTools:

Reviewed by Darin.

Bug 9579: LayoutTests/fast/events/objc-event-api.html failing due to screenY output
http://bugzilla.opendarwin.org/show_bug.cgi?id=9579

Report screenY values as (height of zero screen - screenY)

DumpRenderTree/EventSendingController.m: (-[EventSendingController handleEvent:]):

Jun 25, 2006:

10:09 PM Changeset in webkit [15045] by thatcher

3 edits in trunk/WebKitTools

Reviewed by Geoff.

Bug 9591: [Drosera] breakpoints should be dragable and deletable by dragging off the gutter
http://bugzilla.opendarwin.org/show_bug.cgi?id=9591

Makes breakpoints dragable. If dragged off the gutter they are deleted.

Drosera/debugger.js:
Drosera/viewer.css:

9:51 PM Changeset in webkit [15044] by darin

5 edits
11 adds in trunk

LayoutTests:

Reviewed by Darin.

Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9185

fast/forms/input-appearance-height-expected.png: Added.
fast/forms/input-appearance-height-expected.txt: Added.
fast/forms/input-appearance-height.html: Added. Tests the height attribute on all input types

fast/forms/input-type-change-expected.checksum: Added.
fast/forms/input-type-change-expected.png: Added.
fast/forms/input-type-change-expected.txt: Added.
fast/forms/input-type-change.html: Added. Tests changing an input type=TEXT to type=IMAGE with a height and width specified on the element.

fast/forms/input-type-change2-expected.checksum: Added.
fast/forms/input-type-change2-expected.png: Added.
fast/forms/input-type-change2-expected.txt: Added.
fast/forms/input-type-change2.html: Added. Tests changing an input type=IMAGE to type=TEXT with a height and width specified on the element.

WebCore:

Reviewed and tweaked by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9185 REGRESSION: UserID field appears with an incorrect height on americanexpresslogin page
Height and Width attribute only applies to IMAGE and HIDDEN types.

dom/NamedMappedAttrMap.h: (WebCore::NamedMappedAttrMap::getAttributeItem): Added to static_cast method.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): Update the style decl if input type has changed. (WebCore::HTMLInputElement::mapToEntry): Only Cache height and width if it is an IMAGE or HIDDEN (WebCore::HTMLInputElement::parseMappedAttribute): Check type before adding height and width style. (WebCore::HTMLInputElement::attach): Remove code for discarding width.

html/HTMLInputElement.h: (WebCore::HTMLInputElement::respectHeightAndWidthAttrs): New method added to report if this input type uses height & width.

8:12 PM Changeset in webkit [15043] by ggaren

6 edits in trunk/JavaScriptCore

Reviewed by Adele.

Added JSConstructorMake to match JSFunctionMake, along with test code.

[ I checked in the ChangeLog before without the actual files. ]

API/JSObjectRef.cpp: (JSConstructorMake):
API/JSObjectRef.h:
API/testapi.c: (myConstructor_callAsConstructor): (main):
API/testapi.js:
ChangeLog:
JavaScriptCore.xcodeproj/project.pbxproj: Moved testapi.c to the testapi target -- this was an oversight in my earlier check-in.

7:17 PM Changeset in webkit [15042] by thatcher

2 edits in trunk/WebKitTools

Reviewed by Darin.

Bug 9568: assertion failure in Safari after quitting Drosera
http://bugzilla.opendarwin.org/show_bug.cgi?id=9568

Call switchToServerNamed:nil and not removeLister to make sure
the server object is set to nil to prevent further removeListener calls.

Drosera/DebuggerDocument.m: (-[DebuggerDocument applicationTerminating:]):

5:28 PM Changeset in webkit [15041] by ddkilzer

3 edits in trunk/LayoutTests

LayoutTests:

Reviewed by Darin.

fast/forms/textarea-hard-linewrap-empty.html: Submit form without setTimeout().
fast/forms/textarea-hard-linewrap.html: Ditto.

4:55 PM Changeset in webkit [15040] by ddkilzer

4 edits
2 adds in trunk

WebCore:

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9537 REGRESSION: Reproducible crash in WebCore::RenderTextField::textWithHardLineBreaks()

Test: fast/forms/textarea-hard-linewrap-empty.html

rendering/RenderTextField.cpp: (WebCore::RenderTextField::textWithHardLineBreaks): Added null check for m_div->firstChild()->renderer().

LayoutTests:

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9537 REGRESSION: Reproducible crash in WebCore::RenderTextField::textWithHardLineBreaks()

fast/forms/textarea-hard-linewrap-empty-expected.txt: Added.
fast/forms/textarea-hard-linewrap-empty.html: Added.
fast/forms/textarea-hard-linewrap.html: Reduced timeout from 200ms to 0ms and renamed function from foo() to submitForm().

4:28 PM Changeset in webkit [15039] by ddkilzer

2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

Scripts/svn-apply: Speed up isDirectoryEmptyForRemoval() by returning as soon as we find that the directory is not empty instead of reading in every single file and directory first, then checking the count. Avoid warning in removeDirectoriesIfNeeded() if $svnOutput is not defined.

4:17 PM Changeset in webkit [15038] by ddkilzer

3 edits
4 adds in trunk

WebCore:

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9388 REGRESSION: outlines don't get erased when removed in some cases

Test: fast/repaint/outline-shrinking.html

rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Always repaint with the old style if the outline is becoming narrower, even if we are going to relayout.

LayoutTests:

Reviewed by Darin.

repaint test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9388 REGRESSION: outlines don't get erased when removed in some cases

fast/repaint/outline-shrinking-expected.checksum: Added.
fast/repaint/outline-shrinking-expected.png: Added.
fast/repaint/outline-shrinking-expected.txt: Added.
fast/repaint/outline-shrinking.html: Added.

2:45 PM Changeset in webkit [15037] by thatcher

4 edits in tags/Safari-521.13.1/WebKit

Adds an SPI Mail needs, and versioning.

2:42 PM Changeset in webkit [15036] by thatcher

4 edits in tags/Safari-521.13.1/WebCore

Build fix, and versioning.

2:38 PM Changeset in webkit [15035] by thatcher

1 copy in tags/Safari-521.13.1

New tag.

1:56 PM Changeset in webkit [15034] by thatcher

3 edits in trunk/WebCore

Build fix for for GCC 5406

1:37 PM Changeset in webkit [15033] by thatcher

1 edit in trunk/WebCore/dom/Document.cpp

Rolls out a build fix I made on Friday, this was correctly fixed by adding a long version of operator[] to Vector.

1:37 PM Changeset in webkit [15032] by ddkilzer

9 edits
2 adds in trunk

WebCore:

Reviewed by Darin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8707:
event.clientX and event.clientY should be relative to the viewport, not the canvas

Make sure clientX and clientY take into account the scroll offsets
of the view.

dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
dom/MouseEvent.cpp: (WebCore::MouseEvent::MouseEvent):
dom/MouseEvent.h:
dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::MouseRelatedEvent): (WebCore::MouseRelatedEvent::initCoordinates):
dom/MouseRelatedEvent.h:
dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent):
page/FrameView.cpp: (WebCore::FrameView::dispatchDragEvent):

LayoutTests:

Reviewed by Darin.

Test cases for
<http://bugzilla.opendarwin.org/show_bug.cgi?id=8707>
event.clientX and event.clientY should be relative to the viewport, not the canvas

fast/dom/window-xy-properties-expected.txt: Added.
fast/dom/window-xy-properties.html: Added.

1:32 PM Changeset in webkit [15031] by thatcher

1 edit in trunk/WebKit/DefaultDelegates/WebScriptDebugServer.m

Leak fix

1:01 PM Changeset in webkit [15030] by darin

4 edits in trunk/WebKitTools

Scripts/svn-apply: Tweak comments.
Scripts/svn-create-patch: Ditto.
Scripts/svn-unapply: Ditto.

12:42 PM Changeset in webkit [15029] by ddkilzer

2 edits in trunk/WebKitTools

WebKitTools:

Formatting fix per Bug 9571 Comment #2. Reviewed by NOBODY.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9571#c2

Scripts/svn-apply: Formatting fix.

12:39 PM Changeset in webkit [15028] by ddkilzer

3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9571
Teach svn-apply and svn-unapply to handle directory adds and removes better

Scripts/svn-apply: Handle directory adds more intelligently. Handle directory removes.
Scripts/svn-unapply: Handle undoing both directory adds and removes.

11:59 AM Changeset in webkit [15027] by thatcher

20 edits in trunk/LayoutTests

http://bugzilla.opendarwin.org/show_bug.cgi?id=9560

This fix converted the resize corner image to a B/W tiff.
The pixel tests showed 0.0% changes but still said it had differences.
Updating the tests that use CSS3 resize or textarea.

fast/forms/floating-textfield-relayout-expected.checksum:
fast/forms/form-element-geometry-expected.checksum:
fast/forms/form-element-geometry-expected.png:
fast/forms/negativeLineHeight-expected.checksum:
fast/forms/negativeLineHeight-expected.png:
fast/forms/textAreaLineHeight-expected.checksum:
fast/forms/textAreaLineHeight-expected.png:
fast/forms/textarea-setinnerhtml-expected.checksum:
fast/forms/textarea-setinnerhtml-expected.png:
fast/overflow/overflow-x-y-expected.checksum:
fast/overflow/overflow-x-y-expected.png:
fast/table/003-expected.checksum:
fast/table/003-expected.png:
tables/mozilla/bugs/bug194024-expected.checksum:
tables/mozilla/bugs/bug194024-expected.png:
tables/mozilla/bugs/bug30559-expected.checksum:
tables/mozilla/bugs/bug30559-expected.png:
tables/mozilla/bugs/bug30692-expected.checksum:
tables/mozilla/bugs/bug30692-expected.png:

10:53 AM Changeset in webkit [15026] by thatcher

22 edits in trunk

JavaScriptCore:

Reviewed by Darin.

Bug 9574: Drosera should show inline scripts within the original HTML
http://bugzilla.opendarwin.org/show_bug.cgi?id=9574

Pass the starting line number and error message to the debugger.

kjs/debugger.cpp: (Debugger::sourceParsed):
kjs/debugger.h:
kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):
kjs/function_object.cpp: (FunctionObjectImp::construct):
kjs/interpreter.cpp: (KJS::Interpreter::evaluate):

WebCore:

Reviewed by Darin.

Bug 9574: Drosera should show inline scripts within the original HTML
http://bugzilla.opendarwin.org/show_bug.cgi?id=9574

Pass the starting line number and error message to the debugger.
Call parsedSource even if there was a script parse error so the debugger can show the parse error.
Pass NSURL objects to the ObjC delegate for the script URLs.

bridge/mac/WebCoreScriptDebugger.h:
bridge/mac/WebCoreScriptDebugger.mm: (toNSURL): (WebCoreScriptDebuggerImp::sourceParsed):

WebKit:

Reviewed by Darin.

Bug 9574: Drosera should show inline scripts within the original HTML
http://bugzilla.opendarwin.org/show_bug.cgi?id=9574

Adds a new version of the didParseSource delegate callback with base line number.
Adds a new delegate callback for when a script fails to parse.
These new callbacks use NSURLs for the url parameter.
Adds a new script listener callback to notify when the main resource loads.
Adds a WebScriptErrorDomian and other keys for use with NSError.

DefaultDelegates/WebDefaultScriptDebugDelegate.m: (-[WebDefaultScriptDebugDelegate webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebDefaultScriptDebugDelegate webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
DefaultDelegates/WebScriptDebugServer.h:
DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer webView:didLoadMainResourceForDataSource:]): (-[WebScriptDebugServer webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebScriptDebugServer webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
DefaultDelegates/WebScriptDebugServerPrivate.h:
WebKit.exp:
WebView/WebDataSource.m: (-[WebDataSource _setPrimaryLoadComplete:]):
WebView/WebScriptDebugDelegate.h:
WebView/WebScriptDebugDelegate.m: (-[WebScriptCallFrame parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]):

WebKitTools:

Reviewed by Darin.

Bug 9574: Drosera should show inline scripts within the original HTML
http://bugzilla.opendarwin.org/show_bug.cgi?id=9574

Refactor the JavaScript code to have a distinction between files
and scripts. Show the script in the context of the HTML file if
it's URL is the same as the frame's main resource. At the time of
the disParseScript callback the main resource might not be completely
loaded, but Drosera needs to show whatever we have at the time. Once
the main resource is finished, update the file source and reload the file.

Drosera/DebuggerDocument.m: (-[DebuggerDocument pause]): (-[DebuggerDocument webView:didLoadMainResourceForDataSource:]): (-[DebuggerDocument webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[DebuggerDocument webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
Drosera/debugger.css:
Drosera/debugger.js:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed