Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Jul 9, 2006:

11:16 PM Changeset in webkit [15289] by darin

• 6 edits in trunk/WebCore

• add back "unused code" for plain text fields, still used by <isindex>!

• platform/TextField.h:
• platform/mac/TextFieldMac.mm:
• platform/mac/WebCoreTextField.h:
• platform/mac/WebCoreTextField.mm:
• rendering/RenderLineEdit.cpp:

11:15 PM Changeset in webkit [15288] by darin

• 2 edits in trunk/WebKit

• try to fix Windows build

• COM/WebFrame.cpp: Rename QChar to DeprecatedChar.

11:05 PM Changeset in webkit [15287] by darin

• 51 edits in trunk/WebKit

• fix newlines to be consistent for all files in the COM directory (many had mixed style) and set the EOL style to "native" on them.

• COM/*: Set properties and changed files.

10:20 PM Changeset in webkit [15286] by darin

• 219 edits in trunk/WebCore

Reviewed by Tim Hatcher.

• put more into the WebCore namespace
• removed unused code for plain text fields

Put more classes, class templates, enums, functions, and constants into
the WebCore namespace, including all the headers in the platform directory.

Removed lots of unneeded "WebCore::" qualifiers and "using" directives.

Added some "WebCore::" qualifiers in a few places.

Removed "uses WebCore::" in headers that we said we'd remove "when
everything is in the WebCore namespace".

• bindings/js/JSDOMParser.cpp:
• bindings/js/JSHTMLElementWrapperFactory.cpp:
• bindings/js/JSXSLTProcessor.cpp:
• bindings/js/kjs_binding.cpp:
• bindings/js/kjs_css.cpp:
• bindings/js/kjs_dom.cpp:
• bindings/js/kjs_dom.h:
• bindings/js/kjs_events.cpp:
• bindings/js/kjs_proxy.h:
• bindings/js/kjs_window.h:
• bindings/objc/DOM.mm:
• bridge/History.h:
• bridge/JavaAppletWidget.h:
• bridge/mac/FormDataMac.h:
• bridge/mac/FormDataMac.mm:
• bridge/mac/WebCoreAXObject.mm:
• bridge/mac/WebCoreEncodings.mm:
• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCoreIconDatabaseBridge.mm:
• bridge/mac/WebCorePageState.h:
• bridge/mac/WebCoreScriptDebugger.mm:
• bridge/mac/WebCoreSettings.h:
• css/CSSGrammar.y:
• css/CSSPageRule.cpp:
• css/CSSPageRule.h:
• css/MediaList.cpp:
• css/cssstyleselector.h:
• dom/Clipboard.h:
• dom/Document.cpp:
• dom/Document.h:
• dom/EventTargetNode.h:
• dom/Node.cpp:
• dom/Node.h:
• dom/Position.h:
• dom/Range.cpp:
• dom/XMLTokenizer.cpp:
• editing/AppendNodeCommand.h:
• editing/ApplyStyleCommand.cpp:
• editing/BreakBlockquoteCommand.cpp:
• editing/BreakBlockquoteCommand.h:
• editing/CompositeEditCommand.cpp:
• editing/CompositeEditCommand.h:
• editing/CreateLinkCommand.h:
• editing/DeleteFromTextNodeCommand.h:
• editing/DeleteSelectionCommand.h:
• editing/FormatBlockCommand.h:
• editing/HTMLInterchange.cpp:
• editing/HTMLInterchange.h:
• editing/IndentOutdentCommand.h:
• editing/InsertIntoTextNodeCommand.h:
• editing/InsertLineBreakCommand.h:
• editing/InsertListCommand.h:
• editing/InsertNodeBeforeCommand.h:
• editing/InsertTextCommand.cpp:
• editing/InsertTextCommand.h:
• editing/JSEditor.cpp:
• editing/JSEditor.h:
• editing/JoinTextNodesCommand.h:
• editing/MergeIdenticalElementsCommand.cpp:
• editing/MergeIdenticalElementsCommand.h:
• editing/ModifySelectionListLevel.h:
• editing/MoveSelectionCommand.h:
• editing/RebalanceWhitespaceCommand.h:
• editing/RemoveNodeAttributeCommand.h:
• editing/RemoveNodeCommand.h:
• editing/RemoveNodePreservingChildrenCommand.h:
• editing/ReplaceSelectionCommand.h:
• editing/SetNodeAttributeCommand.h:
• editing/SplitElementCommand.cpp:
• editing/SplitElementCommand.h:
• editing/SplitTextNodeCommand.cpp:
• editing/SplitTextNodeCommand.h:
• editing/SplitTextNodeContainingElementCommand.h:
• editing/TypingCommand.cpp:
• editing/TypingCommand.h:
• editing/UnlinkCommand.h:
• editing/VisiblePosition.cpp:
• editing/WrapContentsInDummySpanCommand.cpp:
• editing/WrapContentsInDummySpanCommand.h:
• editing/markup.cpp:
• editing/markup.h:
• html/HTMLAnchorElement.cpp:
• html/HTMLBodyElement.cpp:
• html/HTMLButtonElement.h:
• html/HTMLCollection.h:
• html/HTMLDocument.h:
• html/HTMLEmbedElement.cpp:
• html/HTMLFormElement.cpp:
• html/HTMLFormElement.h:
• html/HTMLFrameElement.cpp:
• html/HTMLFrameSetElement.cpp:
• html/HTMLKeygenElement.cpp:
• html/HTMLLabelElement.cpp:
• html/HTMLObjectElement.cpp:
• html/HTMLObjectElement.h:
• html/HTMLTableElement.cpp:
• html/HTMLTablePartElement.cpp:
• icon/IconDatabase.h:
• kcanvas/KCanvasPath.h:
• kcanvas/KCanvasResources.cpp:
• kcanvas/KCanvasResources.h:
• kcanvas/KCanvasTreeDebug.cpp:
• kcanvas/KCanvasTreeDebug.h:
• kcanvas/RenderSVGContainer.cpp:
• kcanvas/RenderSVGText.h:
• kcanvas/device/KRenderingPaintServer.h:
• kcanvas/device/KRenderingPaintServerGradient.h:
• kcanvas/device/KRenderingPaintServerSolid.cpp:
• ksvg2/misc/SVGImageLoader.cpp:
• ksvg2/svg/SVGElement.cpp:
• ksvg2/svg/SVGElement.h:
• ksvg2/svg/SVGForeignObjectElement.cpp:
• ksvg2/svg/SVGForeignObjectElement.h:
• ksvg2/svg/SVGImageElement.cpp:
• ksvg2/svg/SVGPoint.h:
• ksvg2/svg/SVGStylable.h:
• ksvg2/svg/SVGTRefElement.cpp:
• ksvg2/svg/SVGTRefElement.h:
• ksvg2/svg/SVGTSpanElement.cpp:
• ksvg2/svg/SVGTSpanElement.h:
• ksvg2/svg/SVGTextElement.h:
• ksvg2/svg/svgpathparser.cpp:
• ksvg2/svg/svgpathparser.h:
• loader/Cache.h:
• loader/DocLoader.h:
• loader/LoaderFunctions.h:
• loader/mac/LoaderFunctionsMac.mm:
• page/Frame.h:
• page/FrameView.h:
• page/Page.h:
• page/Settings.h:
• platform/AffineTransform.cpp:
• platform/AffineTransform.h:
• platform/Arena.cpp:
• platform/Arena.h:
• platform/CookieJar.h:
• platform/DeprecatedCString.cpp:
• platform/DeprecatedCString.h:
• platform/DeprecatedPtrList.h:
• platform/DeprecatedPtrListImpl.cpp:
• platform/DeprecatedPtrListImpl.h:
• platform/DeprecatedPtrQueue.h:
• platform/DeprecatedString.cpp:
• platform/DeprecatedString.h:
• platform/DeprecatedStringList.cpp:
• platform/DeprecatedStringList.h:
• platform/DeprecatedValueList.h:
• platform/DeprecatedValueListImpl.cpp:
• platform/DeprecatedValueListImpl.h:
• platform/FileButton.h:
• platform/FloatPoint.h:
• platform/FloatRect.h:
• platform/FloatSize.h:
• platform/FontData.h:
• platform/FontFallbackList.h:
• platform/GraphicsContext.h:
• platform/IntPoint.h:
• platform/IntRect.h:
• platform/IntSize.h:
• platform/KURL.cpp:
• platform/KURL.h:
• platform/ListBox.h:
• platform/Logging.cpp:
• platform/Logging.h:
• platform/Pen.h:
• platform/PopUpButton.h:
• platform/RegularExpression.cpp:
• platform/RegularExpression.h:
• platform/SSLKeyGenerator.h:
• platform/ScrollBar.h:
• platform/SegmentedString.h:
• platform/Shared.h:
• platform/Slider.h:
• platform/StringImpl.h:
• platform/TextBox.h:
• platform/TextField.h:
• platform/TextStream.cpp:
• platform/TextStream.h:
• platform/TransferJob.h:
• platform/TransferJobClient.h:
• platform/Widget.h:
• platform/cg/AffineTransformCG.cpp:
• platform/mac/ClipboardMac.h:
• platform/mac/ClipboardMac.mm:
• platform/mac/DeprecatedStringListMac.mm:
• platform/mac/FontCacheMac.mm:
• platform/mac/KURLMac.mm:
• platform/mac/ListBoxMac.mm:
• platform/mac/PopUpButtonMac.mm:
• platform/mac/SSLKeyGeneratorMac.mm:
• platform/mac/TextBoxMac.mm:
• platform/mac/TextFieldMac.mm:
• platform/mac/WebCoreTextArea.h:
• platform/mac/WebCoreTextArea.mm:
• platform/mac/WebCoreTextField.h:
• platform/mac/WebCoreTextField.mm:
• rendering/DeprecatedRenderSelect.h:
• rendering/RenderArena.cpp:
• rendering/RenderArena.h:
• rendering/RenderBlock.cpp:
• rendering/RenderBox.cpp:
• rendering/RenderContainer.cpp:
• rendering/RenderFlexibleBox.cpp:
• rendering/RenderFlow.cpp:
• rendering/RenderLayer.cpp:
• rendering/RenderLineEdit.cpp:
• rendering/RenderObject.h:
• rendering/RenderStyle.cpp:
• rendering/RenderStyle.h:
• rendering/RenderText.cpp:
• rendering/RenderTextFragment.cpp:
• rendering/RenderTheme.h:
• rendering/RenderTreeAsText.cpp:
• rendering/RenderTreeAsText.h:
• rendering/RenderView.h:
• rendering/bidi.h:
• xml/XSLStyleSheet.cpp:
• xml/XSLTProcessor.cpp:

10:18 PM Changeset in webkit [15285] by ggaren

• 5 edits in trunk

LayoutTests:

Reviewed by Beth.

Now that we garbage collect after reinitalizing the global object, not
before, we have more free memory, so a custom property that used to
get collected during the initialization phase of this test now avoids
getting collected until the collection phase.

• fast/dom/gc-9-expected.txt:
• fast/dom/gc-9.html:

WebCore:

Reviewed by Beth.

• bindings/js/kjs_window.cpp: (KJS::Window::clear): Garbage collect after reinitalizing the global object, not before, since the reinitialization tends to create garbage.

9:45 PM Changeset in webkit [15284] by ddkilzer

• 2 edits in trunk/WebKitTools

WebKitTools:

Build fix. Reviewed by NOBODY.

• Backed out ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7802 devenv.com not available in VC++ Express installations

• Scripts/webkitdirs.pm: Backed out previous change.

9:25 PM Changeset in webkit [15283] by thatcher

• 3 edits in trunk/WebKit/WebView

Adding 2006 to the copyright years for headers I changed earlier.

9:18 PM Changeset in webkit [15282] by thatcher

• 3 edits in trunk/WebCore/bindings/objc

FIx the copyright dates to include all years published.

9:05 PM Changeset in webkit [15281] by thatcher

• 3 edits in trunk/WebCore/bindings/objc

Build fix for DumpRenderTree and other clients that don't use AppKit. Update the copyright date on headers I changed earlier.

9:00 PM Changeset in webkit [15280] by ddkilzer

• 3 edits in trunk/LayoutTests

LayoutTests:

Reviewed by Darin.

• ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9812 LayoutTests/svg/custom/foreign-object-skew.svg seems to be fixed

• svg/custom/foreign-object-skew-expected.checksum: Updated.
• svg/custom/foreign-object-skew-expected.png: Updated.

8:46 PM Changeset in webkit [15279] by ddkilzer

• 3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

• ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9693 svn-apply should set ChangeLog date correctly when applying patches

• Scripts/svn-apply: Set the ChangeLog entry date using a configurable timezone before applying the patch.
• Scripts/svn-unapply: Reset the ChangeLog entry date before unapplying the patch.

8:26 PM Changeset in webkit [15278] by tomernic

• 2 edits in trunk/WebKit

Reviewed by Maciej.

<rdar://problem/4404652> Netscape plug-in mouse events broken in HiDPI

Multiply global mouse coordinates by the window scale factor so that plug-ins can use GlobalToLocal() in HiDPI.
This fixes many bugs involving plug-in mouse event handling in HiDPI. Most notably, the Flash player will now
correctly respond to clicks.

• Plugins/WebBaseNetscapePluginView.m: (+[WebBaseNetscapePluginView getCarbonEvent:]): (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]):

8:13 PM Changeset in webkit [15277] by darin

• 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

• fix assertion firing in plug-in layout tests

• Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView restartNullEvents]): Don't start null events if the plug-in is not in the started state. This happens when the plug-in moves within its view hierarchy after it has been stopped.

8:02 PM Changeset in webkit [15276] by thatcher

• 14 edits in trunk

WebCore:

Reviewed by Darin.

Bug 9820: Move new DOM API that has been through API review to public headers
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9820

• bindings/objc/DOM.mm: (-[DOMElement focus]): (-[DOMElement blur]): (-[DOMRange text]): (-[DOMRange _text]):
• bindings/objc/DOMCSS.mm: (-[DOMRGBColor color]): (-[DOMRGBColor _color]):
• bindings/objc/DOMCore.h:
• bindings/objc/DOMEvents.h:
• bindings/objc/DOMExtensions.h:
• bindings/objc/DOMHTML.mm: (-[DOMHTMLElement titleDisplayString]): (-[DOMHTMLDocument createDocumentFragmentWithMarkupString:baseURL:]): (-[DOMHTMLDocument createDocumentFragmentWithText:]): (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): (-[DOMHTMLDocument _createDocumentFragmentWithText:]):
• bindings/objc/DOMPrivate.h:
• bindings/objc/DOMXPath.h:
• bindings/objc/DOMXPath.mm:

WebKit:

Reviewed by Darin.

Bug 9820: Move new DOM API that has been through API review to public headers
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9820

• Misc/WebElementDictionary.m: include DOMExtensions.h
• Misc/WebNSViewExtras.m: include DOMExtensions.h
• WebKit.xcodeproj/project.pbxproj: make DOMXPath.h public

7:49 PM Changeset in webkit [15275] by thatcher

• 8 edits in trunk/WebKit

Reviewed by Kevin.

Bug 9818: move new UIDelegate API that has been through API review to public headers
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9818

<rdar://problem/4387541> API: Remove webView:setContentRect: & webViewContentRect: delegate methods?
The fix for 4310363 removed the only use of webViewContentRect: in our code. webView:setContentRect:
was never used to begin with. There's no harm in leaving these around in the API, but they'll cruft it up.

Also removes the never used webViewPrint: SPI that was replaced by webView:printFrameView:.

• DefaultDelegates/WebDefaultUIDelegate.m:
• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge print]):
• WebView/WebFrameView.h:
• WebView/WebFrameView.m:
• WebView/WebFrameViewPrivate.h:
• WebView/WebUIDelegate.h:
• WebView/WebUIDelegatePrivate.h:

7:43 PM Changeset in webkit [15274] by darin

• 2 edits in trunk/LayoutTests

• fast/dom/delete-contents-expected.txt: Updated results that changed because we now keep comment nodes in the DOM.

7:31 PM Changeset in webkit [15273] by bdakin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9749 A
nested content editable div causes unnecessary screen redraws.

We were repainting too much because we were deciding that we needed
a full layout because we didn't have a first line box. Our code
used to hold a lot of assumptions that positioned elements would
always have line boxes, but I fixed a few bugs a while back that
appeared because this assumption isn't true. This assumption was
also causing the extra redraws because the check meant that we
would decide to do a full layout for any positioned element that
did not have any line boxes in the first place. Maciej and I talked
about this, and we couldn't figure out why the check for line boxes
was part of determining if we need a full layout in the first
place. After hunting around the code, we decided to assume that
this check is antiquated. Removing it fixes the bug and doesn't
seem to break any layout tests. So, fingers crossed!

Will add layout test so soon.

• rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Remove firstLineBox check.

5:57 PM Changeset in webkit [15272] by thatcher

• 4 edits in trunk/WebKit

Reviewed by Darin.

Bug 9814: Move new WebView API that has been through API review to public headers
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9814

• WebView/WebView.h:
• WebView/WebView.m: (-[WebView close]): (-[WebView setShouldCloseWithWindow:]): (-[WebView shouldCloseWithWindow]): (-[WebView selectedFrame]): (-[WebView setMainFrameURL:]): (-[WebView mainFrameURL]): (-[WebView isLoading]): (-[WebView mainFrameTitle]): (-[WebView mainFrameIcon]): (-[WebView mainFrameDocument]): (-[WebView setDrawsBackground:]): (-[WebView drawsBackground]): (-[WebView toggleSmartInsertDelete:]): (-[WebView toggleContinuousSpellChecking:]): (-[WebView canMakeTextStandardSize]): (-[WebView makeTextStandardSize:]): (-[WebView maintainsInactiveSelection]):
• WebView/WebViewPrivate.h:

5:11 PM Changeset in webkit [15271] by thatcher

• 4 edits in trunk/WebKit

Reviewed by Maciej.

Bug 9487: The XPath section should be removed and/or moved.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9487

• WebInspector/webInspector/inspector.css:
• WebInspector/webInspector/inspector.html:
• WebInspector/webInspector/inspector.js:

4:18 PM Changeset in webkit [15270] by harrison

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

<rdar://problem/4598149> Deleting the contents of a DOMRange and then inserting a node into it crashes in WebCore::Font::canUseGlyphCache

• fast/dom/delete-contents-expected.checksum: Added.
• fast/dom/delete-contents-expected.png: Added.
• fast/dom/delete-contents-expected.txt: Added.
• fast/dom/delete-contents.html: Added.

WebCore:

Reviewed by John Sullivan.

<rdar://problem/4598149> Deleting the contents of a DOMRange and then inserting a node into it crashes in WebCore::Font::canUseGlyphCache

Test: fast/dom/delete-contents.html

• dom/Range.cpp: (WebCore::Range::processContents):

3:48 PM Changeset in webkit [15269] by darin

• 64 edits
  12 copies
  5 moves
  2 deletes in trunk/WebCore

• another round of renaming; and KWQ is dead

• WebCore.vcproj/WebCore/WebCore.vcproj: Remove paths for kwq and khtml directories. Move files to their new locations. Did rename.
• WebCore.xcodeproj/project.pbxproj: Move files to their new locations. Did rename.
• WebCoreSources.bkl: Did rename.
• webcore-base.bkl: Removed kwq.

• kwq/AccessibilityObjectCache.h: Removed.
• kwq/AccessibilityObjectCache.mm: Removed.
• kwq/FormDataMac.h: Removed.
• kwq/FormDataMac.mm: Removed.
• kwq/WebCoreAXObject.h: Removed.
• kwq/WebCoreAXObject.mm: Removed.
• kwq/WebCoreEditCommand.h: Removed.
• kwq/WebCoreEditCommand.mm: Removed.
• kwq/WebCorePageState.h: Removed.
• kwq/WebCorePageState.mm: Removed.
• kwq/WebCoreResourceLoaderImp.h: Removed.
• kwq/WebCoreResourceLoaderImp.mm: Removed.

• bridge/AXObjectCache.h: Added.
• bridge/mac/AXObjectCacheMac.mm: Added.
• bridge/mac/WebCoreAXObject.h: Added.
• bridge/mac/WebCoreAXObject.mm: Added.

• loader/CachedObject.cpp: Removed.
• loader/CachedObject.h: Removed.
• loader/CachedObjectClient.h: Removed.
• loader/CachedObjectClientWalker.cpp: Removed.
• loader/CachedObjectClientWalker.h: Removed.

• loader/CachedResource.cpp: Added.
• loader/CachedResource.h: Added.
• loader/CachedResourceClient.h: Added.
• loader/CachedResourceClientWalker.cpp: Added.
• loader/CachedResourceClientWalker.h: Added.

• bridge/mac/FrameMac.mm:
• bridge/mac/WebCoreFrameBridge.mm:
• css/CSSImageValue.h:
• css/CSSImportRule.h:
• dom/Document.cpp:
• dom/Document.h:
• dom/Notation.h:
• dom/ProcessingInstruction.h:
• dom/XMLTokenizer.cpp:
• html/CanvasPattern.h:
• html/HTMLDocument.h:
• html/HTMLImageLoader.cpp:
• html/HTMLImageLoader.h:
• html/HTMLLinkElement.h:
• html/HTMLScriptElement.cpp:
• html/HTMLScriptElement.h:
• html/HTMLTokenizer.cpp:
• html/HTMLTokenizer.h:
• kcanvas/KCanvasFilters.h:
• ksvg2/svg/SVGCursorElement.cpp:
• ksvg2/svg/SVGCursorElement.h:
• ksvg2/svg/SVGFEImageElement.cpp:
• ksvg2/svg/SVGFEImageElement.h:
• loader/Cache.cpp:
• loader/Cache.h:
• loader/CachedCSSStyleSheet.cpp:
• loader/CachedCSSStyleSheet.h:
• loader/CachedImage.cpp:
• loader/CachedImage.h:
• loader/CachedScript.cpp:
• loader/CachedScript.h:
• loader/CachedXBLDocument.cpp:
• loader/CachedXBLDocument.h:
• loader/CachedXSLStyleSheet.cpp:
• loader/CachedXSLStyleSheet.h:
• loader/DocLoader.cpp:
• loader/DocLoader.h:
• loader/LoaderFunctions.h:
• loader/Request.cpp:
• loader/Request.h:
• loader/loader.cpp:
• loader/loader.h:
• loader/mac/LoaderFunctionsMac.mm:
• page/Frame.cpp:
• page/FrameView.cpp:
• platform/gdk/TemporaryLinkStubs.cpp:
• platform/mac/ClipboardMac.h:
• platform/win/TemporaryLinkStubs.cpp:
• rendering/RenderBox.h:
• rendering/RenderContainer.cpp:
• rendering/RenderImage.cpp:
• rendering/RenderImage.h:
• rendering/RenderLayer.h:
• rendering/RenderObject.cpp:
• rendering/RenderObject.h:
• rendering/RenderStyle.cpp:
• rendering/RenderStyle.h:
• xml/XSLImportRule.h: Did renaming.

• platform/mac/can-convert.mm: Removed.

3:39 PM Changeset in webkit [15268] by darin

• 2 edits in trunk/WebKitTools

• Scripts/do-webcore-rename: Final version of this round of renaming for posterity.

3:35 PM Changeset in webkit [15267] by ddkilzer

• 1 edit in trunk/WebCore/ChangeLog

Remove conflict marker.

2:42 PM Changeset in webkit [15266] by andersca

• 1 edit in trunk/WebKit/ChangeLog

Remove conflict marker. Thanks Mitz!

2:39 PM Changeset in webkit [15265] by andersca

• 7 edits in trunk

WebCore:

2006-07-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim O.

• WebCore.exp: Add wkPathFromFont.

• platform/mac/FontDataMac.mm: (-[NSFont WebCore]): Use wkPathFromFont.

• platform/mac/WebCoreSystemInterface.h:
• platform/mac/WebCoreSystemInterface.mm: Declare wkPathFromFont.

WebKit:

2006-07-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim O.

• WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Initialize wkPathFromFont.

2:31 PM Changeset in webkit [15264] by andersca

• 3 edits in trunk/WebKitLibraries

2006-07-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

• WebKitSystemInterface.h:
• libWebKitSystemInterface.a: Add WKPathFromFont.

2:11 PM Changeset in webkit [15263] by darin

• 2 edits in trunk/WebKit

• fix release build

• Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView restorePortState:]): Cast inside the assertion so that we don't have an unused variable in versions with assertions disabled. The alternative would be to wrap the whole thing in an #if statement.

1:37 PM Changeset in webkit [15262] by tomernic

• 6 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

Added an OpenGL drawing model to the Netscape Plug-in API.

• bindings/npapi.h:

WebKit:

Reviewed by John Sullivan.

• Plugins/WebBaseNetscapePluginView.h:
• Added ivars for OpenGL support. Someday it would be nice to refactor this class so that each drawing model is encapsulated in a class; this would allow WebBaseNetscapePluginView to make more efficient use of space, for example by not keeping OpenGL-related ivars for Quickdraw plug-ins.

• Plugins/WebBaseNetscapePluginView.m:
• Declared a bunch of internal methods for OpenGL support (see below).
• Removed "forUpdate" from CoreGraphics port state struct; it was always set to "YES", so I just cleaned up the silly code that used it.
• Declared OpenGL port state struct. (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
• Moved a CoreGraphics-related assertion down to the big "switch" statement.
• Don't set window.type here -- according to the Netscape Plug-in API docs, the plug-in should default to "windowed" mode, and may call NPN_SetValue() during its NPN_New() to request that the browser use a "windowless" (offscreen) context instead.
• Moved the assertion from the top of this method here; removed a less restrictive assertion that is now obsolete.
• Removed "forUpdate" flag from CoreGraphics port state struct.
• Fill in OpenGL port state struct. Set up the viewport appropriately for both windowed and windowless OpenGL plug-ins. Windowed plug-ins need to have their GL viewport transformed by the amount the plug-in is clipped; windowless plug-ins are drawn off-screen into a surface whose geometry is never changed or clipped, so they may always draw with a viewport origin of (0, 0). (-[WebBaseNetscapePluginView restorePortState:]):
• Removed "forUpdate" flag from CoreGraphics port state struct.
• Restore the old OpenGL context saved by -saveAndSetNewPortStateForUpdate:. (-[WebBaseNetscapePluginView sendEvent:]):
• Updated an assertion to also include OpenGL. To ensure that attached plug-in window movements happen atomically with web page redisplays, we assert that the plug-in's window is set only while the plug-in view is redrawing.
• Same deal as with the assertion; only save/set port state when redrawing the plug-in view. Plug-ins that use the new drawing models are only allowed to draw when the web page draws. I might consider changing this for windowed OpenGL plug-ins, since they always obscure the page content anyway. (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]):
• Compare new NP_GLContext structs. (-[WebBaseNetscapePluginView updateAndSetWindow]):
• In OpenGL mode, can only set window when updating plug-in view. (-[WebBaseNetscapePluginView setWindowIfNecessary]):
• ditto
• Updated logging for OpenGL drawing mode. (-[WebBaseNetscapePluginView addWindowObservers]):
• No need to observe frame/bounds change notifications for this and all parent views. See -renewGState comments below. (-[WebBaseNetscapePluginView removeWindowObservers]):
• Don't need to remove frame/bounds observers anymore. (-[WebBaseNetscapePluginView start]):
• Plug-ins are "windowed" by default. This is not a change from our previous behavior, but this is a better place to set the default value as it allows the plug-in to override it later. (-[WebBaseNetscapePluginView stop]):
• Destroy AGL context when the plug-in stops. (-[WebBaseNetscapePluginView dealloc]):
• Assert that the AGL stuff has been cleaned up. (-[WebBaseNetscapePluginView drawRect:]):
• If this is a windowless OpenGL plugin, blit its contents back into this view. (-[WebBaseNetscapePluginView renewGState]):
• This method is called when the view or one of its parents is moved or resized (see comments). (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
• Hide the AGL window if the plug-in view is about to be removed from its window. (-[WebBaseNetscapePluginView viewHasMoved:]):
• Renamed and moved to the "Internal" category. (-[WebBaseNetscapePluginView invalidateRegion:]):
• Style changes.
• Add support for OpenGL (uses the same region type as CoreGraphics). (-[WebBaseNetscapePluginView getVariable:value:]):
• Style changes.
• Implemented NPNVsupportsOpenGLBool; returns YES since we now support the OpenGL drawing model. (-[WebBaseNetscapePluginView setVariable:value:]):
• Implemented NPPVpluginWindowBool, which allows plug-ins to specify whether they should be rendered in "windowed" or "windowless" mode. This is an older part of the Netscape Plug-in API that was never implemented in WebKit. "Windowed" Quickdraw plug-ins do not actually reside in a separate window, and can already do many of the same things (such as transparency) that only "windowless" plug-ins can do on other platforms. However, we need the "windowed" vs. "windowless" distinction for OpenGL plug-ins so that they have some way of specifying whether they should be rendered on an accelerated overlay surface, composited into the browser window.
• Support for setting the drawing model to OpenGL. (-[WebBaseNetscapePluginView _viewHasMoved]):
• Renamed from -viewHasMoved:, and moved down in the file.
• None of this work is necessary when the plug-in is not in a window; the plug-in's state will be properly restored when it is moved back into a window.
• Reshape OpenGL surface window here. (-[WebBaseNetscapePluginView _createAGLContextIfNeeded]):
• Creates the AGL context of the appropriate type (windowed/windowless). (-[WebBaseNetscapePluginView _createWindowedAGLContext]):
• Creates a windowed AGL context, which is an AGL context attached to a child window. This is the only way to get true hardware acceleration. (-[WebBaseNetscapePluginView _createWindowlessAGLContext]):
• Creates a windowless AGL context, which is an AGL context attached to an offscreen buffer. This buffer can then be blitted back into the browser window with a different alpha, or scaled, or whatever. (-[WebBaseNetscapePluginView _cglContext]):
• Returns the underlying CGL context from the AGL context. We give the plug-in access to the CGL context because CGL is the more primitive of the GL drawable APIs and allows for finer control over the context. (-[WebBaseNetscapePluginView _getAGLOffscreenBuffer:width:height:]):
• Returns the buffer allocated for the offscreen AGL context, if there is one. (-[WebBaseNetscapePluginView _destroyAGLContext]):
• Destroys the AGL context, as well as the associated offscreen buffer or child window. (-[WebBaseNetscapePluginView _reshapeAGLWindow]):
• Positions the AGL window over the browser window. (-[WebBaseNetscapePluginView _hideAGLWindow]):
• Hides the AGL window. (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
• Returns an NSImage representation of the offscreen AGL context's framebuffer. This is used to draw the offscreen bits back into the plug-in view. This is kind of tricky because it has to convert the offscreen buffer in-place from BGRA to RGBA so that it can be wrapped in an NSBitmapImageRep. See comments.

• WebKit.xcodeproj/project.pbxproj: Link OpenGL and AGL.

11:10 AM Changeset in webkit [15261] by beidson

• 1 edit in trunk/WebKit/ChangeLog

Fixed a nearly unparsable ChangeLog entry

10:52 AM Changeset in webkit [15260] by beidson

• 5 edits in trunk/WebCore

Reviewed by Maciej

Set the stage to remove the workaround for the SQLite BLOB corruption. A few other small cleanups, and
preparation for pruning unreferenced and unretained icons.

• icon/IconDatabase.cpp: (WebCore::IconDatabase::recreateDatabase): Added another trigger to assist in icon removal (WebCore::IconDatabase::deletePrivateTables): Cleaned up logging messages (WebCore::IconDatabase::imageDataForIconID): #ifdefed the blobbing hack for impending removal, use the real blob by default (WebCore::IconDatabase::imageDataForIconURL): same (WebCore::IconDatabase::imageDataForPageURL): same (WebCore::IconDatabase::pruneUnreferencedIcons): Will delete any icons and their data that are not referenced by any PageURL
• icon/IconDatabase.h:

• icon/SQLDatabase.h: Changed BlobAsVector to be unsigned char as thats the most reasonable type for a byte-buffer, and is what CFData expects
• icon/SQLStatement.cpp: (WebCore::SQLStatement::getColumnBlobAsVector):

10:38 AM Changeset in webkit [15259] by beidson

• 2 edits in trunk/WebKit

Reviewed by Maciej

The ICONDEBUG flag no choose either/or the new icon database and the old one
No longer any need to live side by side to compare results

• Misc/WebIconDatabase.m: (-[NSMutableDictionary iconURLForURL:]): (-[NSMutableDictionary retainIconForURL:]): (-[NSMutableDictionary releaseIconForURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _resetCachedWebPreferences:]):

10:03 AM Changeset in webkit [15258] by darin

• 29 edits
  1 copy
  23 moves
  5 deletes in trunk/WebCore

• move all but the last 12 files out of kwq directory
• removed a few unused source files I discovered

• WebCore.vcproj/WebCore/WebCore.vcproj: Update for new file locations.
• WebCore.xcodeproj/project.pbxproj: Ditto.

• bridge/mac/FrameMac.mm:
• dom/Element.h:
• html/HTMLImageLoader.cpp:
• loader/Cache.cpp:
• loader/Cache.h:
• loader/CachedCSSStyleSheet.cpp:
• loader/CachedCSSStyleSheet.h:
• loader/CachedImage.cpp:
• loader/CachedImage.h:
• loader/CachedObject.h:
• loader/CachedScript.cpp:
• loader/CachedScript.h:
• loader/CachedXBLDocument.cpp:
• loader/CachedXBLDocument.h:
• loader/CachedXSLStyleSheet.cpp:
• loader/CachedXSLStyleSheet.h:
• loader/DocLoader.cpp:
• loader/DocLoader.h:
• page/Frame.cpp:
• page/Frame.h:
• page/FramePrivate.h:
• platform/gdk/TemporaryLinkStubs.cpp:
• platform/win/TemporaryLinkStubs.cpp:
• rendering/DeprecatedSlider.cpp:
• rendering/RenderObject.h:
• xml/xmlhttprequest.cpp: Updated includes as needed for file location changes. Changed CachePolicy uses to match new filename and enum names.

• loader/CachedResource.cpp: Removed.
• loader/CachedResource.h: Removed.
• loader/CachedResourceClient.h: Removed.
• loader/CachedResourceClientWalker.cpp: Removed.
• loader/CachedResourceClientWalker.h: Removed. The above files were checked in by accident a while back. The rename of CachedObject to CachedResource is now reflected in do-webcore-rename, and will be done soon.

• kwq/AffineTransform.cpp: Removed.
• kwq/AffineTransform.h: Removed.
• kwq/CacheControl.h: Removed.
• kwq/DeprecatedPtrQueue.h: Removed.
• kwq/FileButton.h: Removed.
• kwq/FileButton.mm: Removed.
• kwq/ListBox.h: Removed.
• kwq/ListBox.mm: Removed.
• kwq/LoaderFunctions.h: Removed.
• kwq/LoaderFunctions.mm: Removed.
• kwq/PopUpButton.h: Removed.
• kwq/PopUpButton.mm: Removed.
• kwq/SSLKeyGenerator.h: Removed.
• kwq/SSLKeyGenerator.mm: Removed.
• kwq/Settings.h: Removed.
• kwq/TextBox.h: Removed.
• kwq/TextBox.mm: Removed.
• kwq/TextField.h: Removed.
• kwq/TextField.mm: Removed.
• kwq/WebCoreScrollBar.h: Removed.
• kwq/WebCoreScrollBar.mm: Removed.
• kwq/WebCoreSlider.h: Removed.
• kwq/WebCoreSlider.mm: Removed.

• loader/CachePolicy.h: Added.
• loader/LoaderFunctions.h: Added.

• loader/mac/LoaderFunctionsMac.mm: Added.

• page/Settings.h: Added.

• platform/AffineTransform.cpp: Added.
• platform/AffineTransform.h: Added.
• platform/DeprecatedPtrQueue.h: Added.
• platform/FileButton.h: Added.
• platform/ListBox.h: Added.
• platform/PopUpButton.h: Added.
• platform/SSLKeyGenerator.h: Added.
• platform/ScrollBar.h: Added.
• platform/Slider.h: Added.
• platform/TextBox.h: Added.
• platform/TextField.h: Added.

• platform/cg/AffineTransformCG.cpp: Added.

• platform/mac/FileButtonMac.mm: Added.
• platform/mac/ListBoxMac.mm: Added.
• platform/mac/PopUpButtonMac.mm: Added.
• platform/mac/SSLKeyGeneratorMac.mm: Added.
• platform/mac/ScrollBarMac.mm: Added.
• platform/mac/ScrollBarMac.mm: Added.
• platform/mac/SliderMac.mm: Added.
• platform/mac/SliderMac.mm: Added.
• platform/mac/TextBoxMac.mm: Added.
• platform/mac/TextFieldMac.mm: Added.

9:36 AM Changeset in webkit [15257] by darin

• 2 edits in trunk/WebKitTools

• Scripts/do-webcore-rename: Next round of renaming. (Last round was done.)

8:53 AM Changeset in webkit [15256] by ddkilzer

• 2 edits in trunk/LayoutTests

LayoutTests:

Reviewed by Darin.

• ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9797 Make description() in fast/js/resources/js-test-pre.js work with MSIE 6

• fast/js/resources/js-test-pre.js: Change description() to work with MSIE 6.

8:42 AM Changeset in webkit [15255] by darin

• 4 edits
  4 moves in trunk/WebCore

• move 4 files out of kwq directory
• make some minor project adjustments for the WebCore project

• WebCore.xcodeproj/project.pbxproj: Link libsqlite3 the same way we do other libraries, rather than using a custom linker option. Moved the files from their old locations to the new ones. Removed "khtml" from the list of header search paths since that directory doesn't exist any more. Eliminated STYLE_LDFLAGS and just put -umbrella WebKit in OTHER_LDFLAGS in the Production configuration (was a leftover from "build styles" in Xcode 1). Changed to use EXPORTED_SYMBOLS_FILE instead of using -exported_symbols_list directly again now that Xcode has fixed the "strip twice" bug. Removed unneeded explicit SECTORDER_FLAGS = "" settings. Removed the explicit -Y,3 option now that Xcode does that by default.

• WebCore.vcproj/WebCore/WebCore.vcproj: Removed some obsolete uneeded files, many of which didn't exist any more. Moved the files from their old locations to the new ones.

• WebCoreSources.bkl: Moved the files from their old locations to the new ones.

• kwq/DeprecatedCString.cpp: Removed.
• kwq/DeprecatedCString.h: Removed.
• kwq/TextStream.cpp: Removed.
• kwq/TextStream.h: Removed.
• platform/DeprecatedCString.cpp: Added.
• platform/DeprecatedCString.h: Added.
• platform/TextStream.cpp: Added.
• platform/TextStream.h: Added.

8:23 AM Changeset in webkit [15254] by ddkilzer

• 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by NOBODY (build fix).

• ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7802 devenv.com not available in VC++ Express installations

• Scripts/webkitdirs.pm: Restore Hyatt's original logic to make buildbot work again. Add VC++ Express check as the fallback.

8:10 AM Changeset in webkit [15253] by darin

• 226 edits
  46 moves in trunk/WebCore

Rubber stamped by Maciej (kinda).

• did the next pass of renaming (used do-webcore-rename script) this takes care of most of the remaining KWQ names (almost all)

• WebCore+SVG/DOMList.h:
• WebCore.vcproj/WebCore/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• WebCoreSources.bkl:
• bindings/js/kjs_dom.cpp:
• bindings/js/kjs_window.cpp:
• bindings/objc/DOMHTML.mm:
• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm:
• bridge/mac/WebCoreFrameBridge.mm:
• bridge/mac/WebCoreSettings.h:
• bridge/mac/WebCoreSettings.mm:
• bridge/win/FrameWin.cpp:
• css/CSSPrimitiveValue.cpp:
• css/CSSValueKeywords.in:
• css/MediaQueryEvaluator.cpp:
• css/cssparser.cpp:
• css/cssstyleselector.cpp:
• css/cssstyleselector.h:
• dom/CharacterData.cpp:
• dom/CharacterData.h:
• dom/Document.cpp:
• dom/Element.cpp:
• dom/Element.h:
• dom/EventTargetNode.cpp:
• dom/EventTargetNode.h:
• dom/Node.cpp:
• dom/Node.h:
• dom/Position.cpp:
• dom/ProcessingInstruction.cpp:
• dom/QualifiedName.cpp:
• dom/QualifiedName.h:
• dom/XMLTokenizer.cpp: Added.
• dom/xml_tokenizer.cpp: Removed.
• dom/xml_tokenizer.h: Removed.
• editing/EditAction.h:
• editing/HTMLInterchange.cpp:
• editing/HTMLInterchange.h:
• editing/Selection.h:
• editing/SelectionController.h:
• editing/TextAffinity.h:
• editing/TextIterator.cpp:
• editing/TextIterator.h:
• editing/VisiblePosition.h:
• editing/htmlediting.cpp:
• editing/markup.cpp:
• editing/markup.h:
• editing/visible_units.cpp:
• editing/visible_units.h:
• html/HTMLDocument.cpp:
• html/HTMLFontElement.cpp:
• html/HTMLInputElement.cpp:
• html/HTMLKeygenElement.cpp:
• html/HTMLSelectElement.h:
• html/HTMLTextAreaElement.cpp:
• html/HTMLTextFieldInnerElement.cpp:
• html/HTMLTokenizer.cpp:
• html/HTMLTokenizer.h:
• kcanvas/KCanvasContainer.cpp: Removed.
• kcanvas/KCanvasContainer.h: Removed.
• kcanvas/KCanvasCreator.cpp:
• kcanvas/KCanvasFilters.cpp:
• kcanvas/KCanvasFilters.h:
• kcanvas/KCanvasMatrix.cpp:
• kcanvas/KCanvasMatrix.h:
• kcanvas/KCanvasPath.cpp:
• kcanvas/KCanvasPath.h:
• kcanvas/KCanvasResources.cpp:
• kcanvas/KCanvasResources.h:
• kcanvas/KCanvasTreeDebug.cpp:
• kcanvas/KCanvasTreeDebug.h:
• kcanvas/RenderForeignObject.cpp:
• kcanvas/RenderForeignObject.h:
• kcanvas/RenderPath.cpp:
• kcanvas/RenderPath.h:
• kcanvas/RenderSVGContainer.cpp: Added.
• kcanvas/RenderSVGContainer.h: Added.
• kcanvas/RenderSVGImage.cpp:
• kcanvas/RenderSVGImage.h:
• kcanvas/RenderSVGText.cpp:
• kcanvas/RenderSVGText.h:
• kcanvas/device/KRenderingPaintServer.h:
• kcanvas/device/KRenderingPaintServerGradient.cpp:
• kcanvas/device/KRenderingPaintServerGradient.h:
• kcanvas/device/KRenderingPaintServerPattern.cpp:
• kcanvas/device/KRenderingPaintServerPattern.h:
• kcanvas/device/KRenderingPaintServerSolid.cpp:
• kcanvas/device/KRenderingPaintServerSolid.h:
• kcanvas/device/quartz/KCanvasFilterQuartz.mm:
• kcanvas/device/quartz/KCanvasItemQuartz.h:
• kcanvas/device/quartz/KCanvasResourcesQuartz.h:
• kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
• kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
• kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
• ksvg2/css/CSSValueKeywords.in:
• ksvg2/css/SVGRenderStyleDefs.cpp:
• ksvg2/misc/KCanvasRenderingStyle.cpp:
• ksvg2/misc/KSVGTimeScheduler.cpp:
• ksvg2/svg/SVGAElement.cpp:
• ksvg2/svg/SVGAnimateTransformElement.cpp:
• ksvg2/svg/SVGAnimateTransformElement.h:
• ksvg2/svg/SVGGElement.cpp:
• ksvg2/svg/SVGHelper.cpp:
• ksvg2/svg/SVGHelper.h:
• ksvg2/svg/SVGImageElement.cpp:
• ksvg2/svg/SVGLinearGradientElement.cpp:
• ksvg2/svg/SVGMarkerElement.cpp:
• ksvg2/svg/SVGMaskElement.cpp:
• ksvg2/svg/SVGMatrix.cpp:
• ksvg2/svg/SVGMatrix.h:
• ksvg2/svg/SVGPatternElement.cpp:
• ksvg2/svg/SVGRadialGradientElement.cpp:
• ksvg2/svg/SVGSVGElement.cpp:
• ksvg2/svg/SVGStyledElement.h:
• ksvg2/svg/SVGStyledTransformableElement.cpp:
• ksvg2/svg/SVGStyledTransformableElement.h:
• ksvg2/svg/SVGSwitchElement.cpp:
• ksvg2/svg/SVGTextElement.cpp:
• ksvg2/svg/SVGTransformable.h:
• ksvg2/svg/SVGUseElement.cpp:
• kwq/AffineTransform.cpp: Added.
• kwq/AffineTransform.h: Added.
• kwq/DeprecatedCString.cpp: Added.
• kwq/DeprecatedCString.h: Added.
• kwq/DeprecatedPtrQueue.h: Added.
• kwq/FileButton.h: Added.
• kwq/FileButton.mm: Added.
• kwq/FormDataMac.mm: Added.
• kwq/KWQCString.cpp: Removed.
• kwq/KWQCString.h: Removed.
• kwq/KWQComboBox.h: Removed.
• kwq/KWQComboBox.mm: Removed.
• kwq/KWQEditCommand.h: Removed.
• kwq/KWQEditCommand.mm: Removed.
• kwq/KWQFileButton.h: Removed.
• kwq/KWQFileButton.mm: Removed.
• kwq/KWQFormData.h: Removed.
• kwq/KWQFormData.mm: Removed.
• kwq/KWQKHTMLSettings.h: Removed.
• kwq/KWQKIOGlobal.h: Removed.
• kwq/KWQKSSLKeyGen.h: Removed.
• kwq/KWQKSSLKeyGen.mm: Removed.
• kwq/KWQLineEdit.h: Removed.
• kwq/KWQLineEdit.mm: Removed.
• kwq/KWQListBox.h: Removed.
• kwq/KWQListBox.mm: Removed.
• kwq/KWQLoader.h: Removed.
• kwq/KWQLoader.mm: Removed.
• kwq/KWQPageState.h: Removed.
• kwq/KWQPageState.mm: Removed.
• kwq/KWQPtrQueue.h: Removed.
• kwq/KWQResourceLoader.h: Removed.
• kwq/KWQResourceLoader.mm: Removed.
• kwq/KWQScrollBar.h: Removed.
• kwq/KWQScrollBar.mm: Removed.
• kwq/KWQSlider.h: Removed.
• kwq/KWQSlider.mm: Removed.
• kwq/KWQTextEdit.h: Removed.
• kwq/KWQTextEdit.mm: Removed.
• kwq/KWQTextStream.cpp: Removed.
• kwq/KWQTextStream.h: Removed.
• kwq/KWQWMatrix.cpp: Removed.
• kwq/KWQWMatrix.h: Removed.
• kwq/ListBox.h: Added.
• kwq/ListBox.mm: Added.
• kwq/LoaderFunctions.h: Added.
• kwq/LoaderFunctions.mm: Added.
• kwq/PopUpButton.h: Added.
• kwq/PopUpButton.mm: Added.
• kwq/SSLKeyGenerator.h: Added.
• kwq/SSLKeyGenerator.mm: Added.
• kwq/Settings.h: Added.
• kwq/TextBox.h: Added.
• kwq/TextBox.mm: Added.
• kwq/TextField.h: Added.
• kwq/TextField.mm: Added.
• kwq/TextStream.cpp: Added.
• kwq/TextStream.h: Added.
• kwq/WebCoreEditCommand.h: Added.
• kwq/WebCoreEditCommand.mm: Added.
• kwq/WebCorePageState.h: Added.
• kwq/WebCorePageState.mm: Added.
• kwq/WebCoreResourceLoaderImp.h: Added.
• kwq/WebCoreResourceLoaderImp.mm: Added.
• kwq/WebCoreScrollBar.h: Added.
• kwq/WebCoreScrollBar.mm: Added.
• kwq/WebCoreSlider.h: Added.
• kwq/WebCoreSlider.mm: Added.
• loader/Cache.h:
• loader/CachedCSSStyleSheet.cpp:
• loader/CachedImage.cpp:
• loader/CachedObject.h:
• loader/CachedObjectClientWalker.h:
• loader/CachedResource.h:
• loader/CachedResourceClientWalker.h:
• loader/CachedScript.h:
• loader/CachedXBLDocument.h:
• loader/Decoder.h:
• loader/DocLoader.cpp:
• loader/DocLoader.h:
• loader/FormData.h:
• loader/ImageDocument.cpp:
• loader/PluginDocument.cpp:
• loader/TextDocument.cpp:
• loader/loader.cpp:
• loader/loader.h:
• page/Frame.cpp:
• page/Frame.h:
• page/FramePrivate.h:
• page/Page.cpp:
• page/Page.h:
• platform/DeprecatedPtrList.h:
• platform/DeprecatedPtrListImpl.cpp:
• platform/DeprecatedPtrListImpl.h:
• platform/DeprecatedString.cpp:
• platform/DeprecatedString.h:
• platform/DeprecatedStringList.cpp:
• platform/DeprecatedStringList.h:
• platform/DeprecatedValueList.h:
• platform/DeprecatedValueListImpl.cpp:
• platform/DeprecatedValueListImpl.h:
• platform/FloatSize.h:
• platform/Font.cpp:
• platform/KURL.cpp:
• platform/RegularExpression.cpp:
• platform/RegularExpression.h:
• platform/SegmentedString.h:
• platform/StreamingTextDecoder.cpp:
• platform/String.cpp:
• platform/StringImpl.cpp:
• platform/TextEncoding.cpp:
• platform/TransferJob.cpp:
• platform/TransferJob.h:
• platform/TransferJobInternal.h:
• platform/gdk/FrameGdk.cpp:
• platform/gdk/TemporaryLinkStubs.cpp:
• platform/mac/ClipboardMac.h:
• platform/mac/ClipboardMac.mm:
• platform/mac/CursorMac.mm:
• platform/mac/DeprecatedStringMac.mm: Added.
• platform/mac/FontCacheMac.mm:
• platform/mac/FontMac.mm:
• platform/mac/FoundationExtras.h:
• platform/mac/ImageMac.mm:
• platform/mac/KURLMac.mm:
• platform/mac/MouseEventMac.mm: Removed.
• platform/mac/QStringListMac.mm: Removed.
• platform/mac/QStringMac.mm: Removed.
• platform/mac/TransferJobMac.mm:
• platform/mac/WebCoreTextArea.h:
• platform/mac/WebCoreTextArea.mm:
• platform/mac/WebCoreTextField.h:
• platform/mac/WebCoreTextField.mm:
• platform/mac/WidgetMac.mm:
• platform/win/TemporaryLinkStubs.cpp:
• rendering/DataRef.h:
• rendering/DeprecatedRenderSelect.cpp:
• rendering/DeprecatedRenderSelect.h:
• rendering/DeprecatedSlider.cpp:
• rendering/InlineFlowBox.cpp:
• rendering/RenderApplet.cpp:
• rendering/RenderBlock.cpp:
• rendering/RenderBlock.h:
• rendering/RenderContainer.cpp:
• rendering/RenderFileButton.cpp:
• rendering/RenderFlexibleBox.cpp:
• rendering/RenderFlow.cpp:
• rendering/RenderFormElement.cpp:
• rendering/RenderFrameSet.cpp:
• rendering/RenderFrameSet.h:
• rendering/RenderImage.cpp:
• rendering/RenderInline.cpp:
• rendering/RenderLayer.cpp:
• rendering/RenderLayer.h:
• rendering/RenderLineEdit.cpp:
• rendering/RenderListItem.cpp:
• rendering/RenderListMarker.cpp:
• rendering/RenderObject.cpp:
• rendering/RenderObject.h:
• rendering/RenderPartObject.cpp:
• rendering/RenderReplaced.cpp:
• rendering/RenderStyle.cpp: Added.
• rendering/RenderStyle.h: Added.
• rendering/RenderTable.cpp:
• rendering/RenderTable.h:
• rendering/RenderTableCell.cpp:
• rendering/RenderTableCell.h:
• rendering/RenderTableCol.cpp:
• rendering/RenderTableCol.h:
• rendering/RenderTableRow.cpp:
• rendering/RenderTableSection.cpp:
• rendering/RenderTableSection.h:
• rendering/RenderText.cpp:
• rendering/RenderText.h:
• rendering/RenderTextArea.cpp:
• rendering/RenderTextControl.cpp: Added.
• rendering/RenderTextControl.h: Added.
• rendering/RenderTextField.cpp: Removed.
• rendering/RenderTextField.h: Removed.
• rendering/RenderTheme.cpp:
• rendering/RenderThemeMac.mm:
• rendering/RenderTreeAsText.cpp:
• rendering/RenderTreeAsText.h:
• rendering/RenderView.cpp:
• rendering/RenderWidget.cpp:
• rendering/bidi.cpp:
• rendering/render_style.cpp: Removed.
• rendering/render_style.h: Removed.
• xml/XSLStyleSheet.cpp:
• xml/XSLTProcessor.cpp:
• xml/xmlhttprequest.cpp:
• xpath/impl/XPathParser.cpp:

7:53 AM Changeset in webkit [15252] by ddkilzer

• 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Timothy Hatcher.

• ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7802 devenv.com not available in VC++ Express installations

• Scripts/webkitdirs.pm: Make Windows build work with Visual C++ Express.

5:05 AM Changeset in webkit [15251] by jdevalk

• 2 edits in trunk/WebKitTools

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9804

In the congratulations message, "capatibilies" should be "capabilities".

4:29 AM Changeset in webkit [15250] by ddkilzer

• 1 edit in trunk/WebCore/ChangeLog

Tweaked bug title in last comment to be correct.

4:09 AM Changeset in webkit [15249] by ddkilzer

• 2 edits in trunk/WebCore

WebCore:

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8251
navigator.product incorrect in WebKit.app on Intel Macs

For navigator.platform return "MacIntel" for Intel processors, "MacPPC"
otherwise.

• bindings/js/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):

3:46 AM Changeset in webkit [15248] by ddkilzer

• 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Timothy Hatcher.

• ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9794 Teach run-webkit-tests how to ignore tests with performance improvements

• Scripts/run-webkit-tests: Speed up test list generation, implement --ignore-tests feature, and minor clean up.

12:56 AM Changeset in webkit [15247] by thatcher

• 23 edits
  8 adds in trunk

LayoutTests:

Reviewed by Maciej.

Bug 5312: comments aren't available via DOM
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5312

New tests for DOM comment nodes. Updated results to account for new
nodes in the DOM (editing offsets changed.)

• editing/deleting/delete-line-013-expected.txt:
• editing/deleting/delete-line-014-expected.txt:
• editing/inserting/insert-3907422-fix-expected.txt:
• editing/inserting/insert-div-009-expected.txt:
• editing/inserting/insert-div-010-expected.txt:
• editing/selection/extend-by-character-006-expected.txt:
• editing/selection/move-between-blocks-no-001-expected.txt:
• editing/selection/move-between-blocks-yes-001-expected.txt:
• fast/dom/HTMLDocument/object-by-name-or-id-expected.txt:
• fast/dom/HTMLDocument/object-by-name-or-id.html:
• fast/dom/comment-document-fragment-expected.txt: Added.
• fast/dom/comment-document-fragment.html: Added.
• fast/dom/comment-dom-node-expected.txt: Added.
• fast/dom/comment-dom-node.html: Added.
• fast/dom/comment-not-documentElement-expected.checksum: Added.
• fast/dom/comment-not-documentElement-expected.png: Added.
• fast/dom/comment-not-documentElement-expected.txt: Added.
• fast/dom/comment-not-documentElement.html: Added.
• fast/text/atsui-pointtooffset-calls-cg-expected.txt:
• fast/text/atsui-rtl-override-selection-expected.txt:

WebCore:

Reviewed by Maciej.

Bug 5312: comments aren't available via DOM
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5312

<rdar://problem/4564414> getting comments via DOM isn't working (5312)
<rdar://problem/4545691> DOM_COMMENT node masking out real DOM elements

• dom/Document.cpp: (WebCore::Document::removedLastRef): set m_documentElement to 0 (WebCore::Document::childrenChanged): invalidate the document element we have cached in case it was replaced (WebCore::Document::documentElement): cache the first element as the document node if m_documentElement is 0
• dom/Document.h: added m_documentElement
• html/HTMLDocument.cpp: removed documentElement(), HTML documents just use Document's documentElement()
• html/HTMLDocument.h: ditto
• html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): make a new HTML node is the document's firstChild is NULL or the firstChild is not a HTML element (like a comment)
• html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseComment): removed the #ifdef to include comment nodes

WebKit:

Reviewed by Maciej.

Bug 5312: comments aren't available via DOM
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5312

Makes the Web Inspector show comment node contents.

• WebInspector/WebInspector.m: (-[DOMNode _displayName]): return the contents of the comment
• WebInspector/webInspector/inspector.js: check for comment nodes

12:04 AM Changeset in webkit [15246] by ap

• 3 edits in trunk/WebKit

Reviewed by Darin.

• ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9572 Add application/xhtml+xml to the Accept header

• WebView/WebFrame.m: (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): Add an Accept header to main resource requests.
• English.lproj/StringsNotToBeLocalized.txt: Added new strings.

Jul 8, 2006:

10:44 PM Changeset in webkit [15245] by thatcher

• 2 edits in trunk/LayoutTests/editing/selection

Update the pixel result to match.

10:13 PM Changeset in webkit [15244] by thatcher

• 5 edits in tags/JavaScriptCore-521.15.1/JavaScriptCore

Build fix.

10:03 PM Changeset in webkit [15243] by thatcher

• 1 copy in tags/JavaScriptCore-521.15.1/JavaScriptCore

New tag (part 2.)

10:02 PM Changeset in webkit [15242] by thatcher

• 1 add in tags/JavaScriptCore-521.15.1

New tag.

9:58 PM Changeset in webkit [15241] by thatcher

• 4 edits
  2 deletes in trunk/JavaScriptCore

Reviewed by Maciej.

Moved KJS_GetCreatedJavaVMs to jni_utility.cpp.
Switched KJS_GetCreatedJavaVMs over to use dlopen and dlsym
now that NSAddImage, NSLookupSymbolInImage and NSAddressOfSymbol
are deprecated in Leopard.

• JavaScriptCore.exp:
• JavaScriptCore.xcodeproj/project.pbxproj:
• bindings/jni/jni_utility.cpp: (KJS::Bindings::KJS_GetCreatedJavaVMs):
• bindings/softlinking.c: Removed.
• bindings/softlinking.h: Removed.

9:28 PM Changeset in webkit [15240] by mjs

• 8 edits in trunk/WebCore

Reviewed by Darin, tweaked slightly and landed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9787
fast/frames tests failing (bad pointer to owner element) under MallocScribble

• html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::close): Disconnect the owner element of our frame.

• html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::attach): Don't call setFrame here.

• html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::detach): Disconnect the owner element of our frame.

• html/HTMLPlugInElement.h: (WebCore::HTMLPlugInElement::setFrameName): New function.

• page/Frame.cpp: (WebCore::Frame::Frame): Don't call setFrame.

(WebCore::Frame::~Frame):
Null out the owner element.

(WebCore::Frame::requestObject):
When an object creates a child frame, assign it a name so it can be
accessed from HTMLPlugInElement.

• rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart): (WebCore::RenderPart::~RenderPart):
• rendering/RenderPart.h: Get rid of setFrame.

1:04 PM Changeset in webkit [15239] by darin

• 7 edits in trunk/WebCore

Reviewed by Geoff.

• better fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9622 REGRESSION: showModalDialog returnValue ignored, function result is always "undefined"

• bindings/js/kjs_window.cpp: (KJS::showModalDialog): Set the return value after returning from the function if the window is not cleared; this is a better way to handle the case where the window does not get cleared before returning, and handles some new cases created by slight changes in the latest Safari properly too. (KJS::Window::clear): Changed logic slightly so we always store the result of getDirect into the return value slot -- the old code left the storage untouched if it was 0. Also made it only overwrite the return value slot if it's 0.

• bindings/js/kjs_proxy.h:
• bindings/js/kjs_proxy.cpp:
• bindings/js/kjs_window.h:
• bindings/js/kjs_window.cpp:
• page/Frame.cpp: Roll the previous fix out.

12:45 PM Changeset in webkit [15238] by darin

• 5 edits in trunk

LayoutTests:

Reviewed by Geoff (well, half of it at least).

• ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9788 storage leaks in Objective-C tests

• plugins/jsobjc-simple.html: Add an autorelease to fix a storage leak.

WebKitTools:

Reviewed by Geoff (well, half of it at least).

• ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9788 storage leaks in Objective-C tests

• DumpRenderTree/DumpRenderTree.m: (-[LayoutTestController keepWebHistory]):
• DumpRenderTree/ObjCPlugin.m: (-[ObjCPlugin removeBridgeRestrictions:]): Add a release to fix a storage leak.

12:38 PM Changeset in webkit [15237] by darin

• 2 edits in trunk/WebKitTools

• Scripts/do-webcore-rename: A few more.

12:11 PM Changeset in webkit [15236] by darin

• 2 edits in trunk/WebKitTools

• Scripts/do-webcore-rename: Another cut at renames. About ready to go (later today).

11:08 AM Changeset in webkit [15235] by ggaren

• 4 edits in trunk/JavaScriptCore

Reviewed by Anders.

• Make JSObjectGetProperty return a JSValue or NULL, like JSEvaluate does.

• API/JSObjectRef.cpp: (JSObjectGetProperty):
• API/JSObjectRef.h:
• API/testapi.c: (main):

10:53 AM Changeset in webkit [15234] by ggaren

• 4 edits in trunk/JavaScriptCore

Style change -- no review necessary.

Use 0 instead of NULL in API .cpp files, to match our style guidelines.

• API/JSContextRef.cpp: (JSEvaluate):
• API/JSObjectRef.cpp: (JSFunctionMakeWithBody): (JSObjectCallAsFunction): (JSObjectCallAsConstructor):
• API/JSValueRef.cpp: (JSValueToObject):

10:42 AM Changeset in webkit [15233] by ggaren

• 4 edits in trunk/JavaScriptCore

Reviewed by TimO.

• Added ability to pass NULL for thisObject when calling JSObjectCallAsFunction, to match JSEvaluate.

• API/JSObjectRef.cpp: (JSObjectCallAsFunction):
• API/JSObjectRef.h:
• API/testapi.c: (main):

10:14 AM Changeset in webkit [15232] by darin

• 42 edits
  3 adds in trunk/LayoutTests

• clear up a few minor housekeeping problems

• fast/css/xml-stylesheet-pi-not-in-prolog-expected.checksum: Added.
• fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Added.
• fast/forms/input-appearance-height-expected.checksum: Added. Added missing test results.

• fast/block/float/nopaint-after-layer-destruction-expected.checksum:
• fast/block/positioning/absolute-positioned-overconstrained.html:
• fast/css/ZeroOpacityLayers.html:
• fast/css/ZeroOpacityLayers2.html:
• fast/css/font-shorthand-weight-only-expected.checksum:
• fast/css/hsl-color-expected.checksum:
• fast/css/hsla-color-expected.checksum:
• fast/css/resize-corner-tracking-expected.checksum:
• fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.checksum:
• fast/dynamic/selection-highlight-adjust-expected.checksum:
• fast/forms/button-generated-content-expected.checksum:
• fast/frames/calculate-fixed.html:
• fast/frames/calculate-order.html:
• fast/frames/calculate-percentage.html:
• fast/frames/calculate-relative.html:
• fast/frames/calculate-round.html:
• fast/history/clicked-link-is-visited-expected.checksum:
• fast/layers/opacity-outline-expected.checksum:
• fast/media/import-p-red.css:
• fast/parser/broken-comments-vs-parsing-mode-expected.checksum:
• fast/repaint/clipped-relative-expected.checksum:
• fast/repaint/float-move-during-layout-expected.checksum:
• fast/repaint/layer-child-outline-expected.checksum:
• fast/repaint/outline-shrinking-expected.checksum:
• fast/repaint/static-to-positioned-expected.checksum:
• fast/repaint/table-collapsed-border-expected.checksum:
• fast/table/absolute-table-at-bottom-expected.checksum:
• fast/table/border-collapsing/border-collapsing-head-foot-expected.checksum:
• fast/table/empty-section-crash-expected.checksum:
• fast/table/rtl-cell-display-none-assert-expected.checksum:
• fast/table/text-field-baseline-expected.checksum:
• fast/text/capitalize-empty-generated-string-expected.checksum:
• svg/custom/gradient-stroke-width-expected.checksum:
• traversal/stay-within-root-expected.checksum: Removed "No newline at end of file" that snuck in as part of the "apply patch" process.

• fast/block/positioning/absolute-positioned-overconstrained-expected.txt:
• fast/css/ZeroOpacityLayers-expected.checksum:
• fast/css/ZeroOpacityLayers-expected.png:
• fast/css/ZeroOpacityLayers-expected.txt:
• fast/css/ZeroOpacityLayers2-expected.checksum:
• fast/css/ZeroOpacityLayers2-expected.png:
• fast/css/ZeroOpacityLayers2-expected.txt: Updated tests results that changed due to the above.

9:54 AM Changeset in webkit [15231] by darin

• 2 edits in trunk/WebKit

• DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]): Removed misleading old comment.

7:30 AM Changeset in webkit [15230] by darin

• 2 edits in trunk/WebCore

• try to fix Windows build

• WebCore.vcproj/WebCore/WebCore.vcproj: Add missing source files.

2:34 AM Changeset in webkit [15229] by thatcher

• 9 copies in tags/Safari-521.15

New tag.

2:30 AM Changeset in webkit [15228] by thatcher

• 8 edits in /

Versioning

Jul 7, 2006:

8:36 PM Changeset in webkit [15227] by ggaren

• 3 edits in trunk/JavaScriptGlue

• build fix

• JSUtils.cpp: (KJSValueToCFTypeInternal):
• JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames):

7:32 PM Changeset in webkit [15226] by justing

• 12 edits
  4 adds in trunk

LayoutTests:

Reviewed by levi

• editing/selection/editable-non-editable-crash-expected.checksum: Added.
• editing/selection/editable-non-editable-crash-expected.png: Added.
• editing/selection/editable-non-editable-crash-expected.txt: Added.
• editing/selection/editable-non-editable-crash.html: Added.
• editing/selection/skip-non-editable-1-expected.txt:
• editing/selection/skip-non-editable-1.html:

WebCore:

Reviewed by levi

Fix Mail ToDo crashers.

• dom/Range.cpp: (WebCore::Range::compareBoundaryPoints): Added an ASSERT that both containers are non-null and an early return.
• editing/Selection.cpp: (WebCore::Selection::validate): Fix a dangling start/end. (WebCore::Selection::adjustForEditableContent): Added an early return if m_start or m_end are null. (WebCore::Selection::isContentEditable): Use isRichlyEditablePosition. (WebCore::Selection::isContentRichlyEditable): Ditto.
• editing/Selection.h:
• editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): Use the new highestEditableRoot. (WebCore::VisiblePosition::previous): Ditto.
• editing/htmlediting.cpp: (WebCore::highestEditableRoot): Takes in a position. (WebCore::isEditablePosition): Added. (WebCore::isRichlyEditablePosition): Added. (WebCore::rootEditableElement): Added. (WebCore::nextCandidate): Moved and split out from nextVisiblePosition. (WebCore::nextVisuallyDistinctCandidate): Ditto. (WebCore::previousCandidate): Moved and split out from previousVisiblePosition. (WebCore::previousVisuallyDistinctCandidate): Ditto. (WebCore::firstEditablePositionAfterPositionInRoot): Iterate over positions, using nextVisuallyDistinctCandidate, skipping atomic nodes that are non-editable. (WebCore::lastEditablePositionBeforePositionInRoot): Ditto.
• editing/htmlediting.h:
• editing/visible_units.cpp: (WebCore::startOfWord): Added a FIXME.

7:25 PM Changeset in webkit [15225] by ggaren

• 14 edits in trunk/JavaScriptCore

Reviewed by Maciej.

• Standardized which functions take a JSContext as an argument. The rule is: if you might execute JavaScript, you take a JSContext, otherwise you don't.

The FIXME in JSObjectRef.h requires refactoring some parts of Interpreter,
but not API changes, so I'm putting it off until later.

• API/JSCallbackObject.cpp: (KJS::JSCallbackObject::JSCallbackObject): (KJS::JSCallbackObject::init):
• API/JSCallbackObject.h:
• API/JSContextRef.cpp: (JSContextCreate):
• API/JSContextRef.h:
• API/JSObjectRef.cpp: (JSObjectMake): (JSPropertyEnumeratorGetNext):
• API/JSObjectRef.h:
• API/testapi.c: (MyObject_initialize): (main):
• JavaScriptCore.exp:
• kjs/array_object.cpp: (ArrayInstance::setLength): (ArrayInstance::pushUndefinedObjectsToEnd):
• kjs/nodes.cpp: (ForInNode::execute):
• kjs/reference.cpp: (KJS::Reference::getPropertyName): (KJS::Reference::getValue):
• kjs/reference.h:
• kjs/scope_chain.cpp: (KJS::ScopeChain::print):

7:02 PM Changeset in webkit [15224] by ggaren

• 21 edits in trunk/JavaScriptCore

Reviewed by Maciej.

More API action.

• Headerdoc finished

Semantic Changes:

• Added a JSContextRef argument to many functions, because you need a JSContextRef for doing virtually anything. I expect to add this argument to even more functions in a future patch.

• Removed the globalObjectPrototype argument to JSContextCreate because you can't create an object until you have a context, so it's impossible to pass a prototype object to JSContextCreate. That's OK because (1) there's no reason to give the global object a prototype and (2) if you really want to, you can just use a separate call to JSObjectSetPrototype.

• Removed the JSClassRef argument to JSClassCreate because it was unnecessary, and you need to be able to make the global object's class before you've created a JSContext.

• Added an optional exception parameter to JSFunctionMakeWithBody because anything less would be uncivilized.

• Made the return value parameter to JSObjectGetProperty optional to match all other return value parameters in the API.

• Made JSObjectSetPrivate/JSObjectGetPrivate work on JSCallbackFunctions and JSCallbackConstructors. You could use an abstract base class or strategic placement of m_privateData in the class structure to implement this, but the former seemed like overkill, and the latter seemed too dangerous.

• Fixed a bug where JSPropertyEnumeratorGetNext would skip the first property.

Cosmetic Changes:

• Reversed the logic of the JSChar #ifdef to avoid confusing headerdoc

• Removed function names from @function declarations because headeroc can parse them automatically, and I wanted to rule out manual mismatch.

• Changed Error::create to take a const UString& instead of a UString* because it was looking at me funny.

• Renamed JSStringBufferCreateWithCFString to JSStringBufferCreateCF because the latter is more concise and it matches JSStringBufferCreateUTF8.

• API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::getPropertyList): (KJS::JSCallbackObject::toBoolean): (KJS::JSCallbackObject::toNumber): (KJS::JSCallbackObject::toString):
• API/JSClassRef.cpp: (JSClassCreate):
• API/JSContextRef.cpp: (JSContextCreate): (JSContextSetException):
• API/JSContextRef.h:
• API/JSNode.c: (JSNodePrototype_class): (JSNode_class):
• API/JSNodeList.c: (JSNodeListPrototype_class): (JSNodeList_class):
• API/JSObjectRef.cpp: (JSObjectGetProperty): (JSObjectGetPrivate): (JSObjectSetPrivate): (JSObjectCallAsFunction): (JSObjectCallAsConstructor): (JSPropertyEnumeratorGetNext):
• API/JSObjectRef.h:
• API/JSStringBufferRef.cpp: (JSStringBufferCreateCF):
• API/JSStringBufferRef.h:
• API/JSValueRef.cpp: (JSValueIsInstanceOf):
• API/JSValueRef.h:
• API/minidom.c: (main):
• API/minidom.js:
• API/testapi.c: (MyObject_hasProperty): (MyObject_setProperty): (MyObject_deleteProperty): (MyObject_getPropertyList): (MyObject_convertToType): (MyObject_class): (main):
• JavaScriptCore.exp:

6:45 PM Changeset in webkit [15223] by lweintraub

• 4 edits in trunk/LayoutTests

Reviewed by NOBODY

Missed a few in the last update...

• fast/forms/input-delete-expected.txt:
• fast/repaint/inline-outline-repaint-expected.txt:
• fast/repaint/selection-after-delete-expected.txt:

5:46 PM Changeset in webkit [15222] by lweintraub

• 156 edits in trunk

LayoutTests:

Reviewed by justin

Deletion editing deligates now show up!

• editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
• editing/deleting/delete-3608430-fix-expected.txt:
• editing/deleting/delete-3608445-fix-expected.txt:
• editing/deleting/delete-3608462-fix-expected.txt:
• editing/deleting/delete-3775172-fix-expected.txt:
• editing/deleting/delete-3800834-fix-expected.txt:
• editing/deleting/delete-3857753-fix-expected.txt:
• editing/deleting/delete-3865854-fix-expected.txt:
• editing/deleting/delete-3928305-fix-expected.txt:
• editing/deleting/delete-3959464-fix-expected.txt:
• editing/deleting/delete-4038408-fix-expected.txt:
• editing/deleting/delete-4083333-fix-expected.txt:
• editing/deleting/delete-after-span-ws-001-expected.txt:
• editing/deleting/delete-after-span-ws-002-expected.txt:
• editing/deleting/delete-after-span-ws-003-expected.txt:
• editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
• editing/deleting/delete-and-undo-expected.txt:
• editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
• editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
• editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
• editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
• editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
• editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
• editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
• editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
• editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
• editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
• editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
• editing/deleting/delete-block-contents-001-expected.txt:
• editing/deleting/delete-block-contents-002-expected.txt:
• editing/deleting/delete-block-contents-003-expected.txt:
• editing/deleting/delete-block-merge-contents-001-expected.txt:
• editing/deleting/delete-block-merge-contents-002-expected.txt:
• editing/deleting/delete-block-merge-contents-003-expected.txt:
• editing/deleting/delete-block-merge-contents-004-expected.txt:
• editing/deleting/delete-block-merge-contents-005-expected.txt:
• editing/deleting/delete-block-merge-contents-006-expected.txt:
• editing/deleting/delete-block-merge-contents-007-expected.txt:
• editing/deleting/delete-block-merge-contents-008-expected.txt:
• editing/deleting/delete-block-merge-contents-009-expected.txt:
• editing/deleting/delete-block-merge-contents-010-expected.txt:
• editing/deleting/delete-block-merge-contents-012-expected.txt:
• editing/deleting/delete-block-merge-contents-013-expected.txt:
• editing/deleting/delete-block-merge-contents-014-expected.txt:
• editing/deleting/delete-block-merge-contents-015-expected.txt:
• editing/deleting/delete-block-merge-contents-016-expected.txt:
• editing/deleting/delete-block-merge-contents-017-expected.txt:
• editing/deleting/delete-block-merge-contents-018-expected.txt:
• editing/deleting/delete-block-merge-contents-019-expected.txt:
• editing/deleting/delete-block-merge-contents-020-expected.txt:
• editing/deleting/delete-block-merge-contents-021-expected.txt:
• editing/deleting/delete-block-merge-contents-022-expected.txt:
• editing/deleting/delete-block-merge-contents-023-expected.txt:
• editing/deleting/delete-block-merge-contents-024-expected.txt:
• editing/deleting/delete-br-001-expected.txt:
• editing/deleting/delete-br-002-expected.txt:
• editing/deleting/delete-br-003-expected.txt:
• editing/deleting/delete-br-004-expected.txt:
• editing/deleting/delete-br-005-expected.txt:
• editing/deleting/delete-br-006-expected.txt:
• editing/deleting/delete-br-007-expected.txt:
• editing/deleting/delete-br-008-expected.txt:
• editing/deleting/delete-br-009-expected.txt:
• editing/deleting/delete-br-010-expected.txt:
• editing/deleting/delete-br-011-expected.txt:
• editing/deleting/delete-character-001-expected.txt:
• editing/deleting/delete-contiguous-ws-001-expected.txt:
• editing/deleting/delete-image-001-expected.txt:
• editing/deleting/delete-image-002-expected.txt:
• editing/deleting/delete-image-003-expected.txt:
• editing/deleting/delete-image-004-expected.txt:
• editing/deleting/delete-leading-ws-001-expected.txt:
• editing/deleting/delete-line-001-expected.txt:
• editing/deleting/delete-line-002-expected.txt:
• editing/deleting/delete-line-003-expected.txt:
• editing/deleting/delete-line-004-expected.txt:
• editing/deleting/delete-line-005-expected.txt:
• editing/deleting/delete-line-006-expected.txt:
• editing/deleting/delete-line-007-expected.txt:
• editing/deleting/delete-line-008-expected.txt:
• editing/deleting/delete-line-009-expected.txt:
• editing/deleting/delete-line-010-expected.txt:
• editing/deleting/delete-line-011-expected.txt:
• editing/deleting/delete-line-012-expected.txt:
• editing/deleting/delete-line-013-expected.txt:
• editing/deleting/delete-line-014-expected.txt:
• editing/deleting/delete-line-015-expected.txt:
• editing/deleting/delete-line-016-expected.txt:
• editing/deleting/delete-line-017-expected.txt:
• editing/deleting/delete-line-end-ws-001-expected.txt:
• editing/deleting/delete-line-end-ws-002-expected.txt:
• editing/deleting/delete-listitem-001-expected.txt:
• editing/deleting/delete-listitem-002-expected.txt:
• editing/deleting/delete-select-all-001-expected.txt:
• editing/deleting/delete-select-all-002-expected.txt:
• editing/deleting/delete-select-all-003-expected.txt:
• editing/deleting/delete-selection-001-expected.txt:
• editing/deleting/delete-tab-001-expected.txt:
• editing/deleting/delete-tab-002-expected.txt:
• editing/deleting/delete-tab-003-expected.txt:
• editing/deleting/delete-tab-004-expected.txt:
• editing/deleting/delete-trailing-ws-001-expected.txt:
• editing/deleting/delete-trailing-ws-002-expected.txt:
• editing/deleting/delete-ws-fixup-001-expected.txt:
• editing/deleting/delete-ws-fixup-002-expected.txt:
• editing/deleting/delete-ws-fixup-003-expected.txt:
• editing/deleting/delete-ws-fixup-004-expected.txt:
• editing/deleting/forward-delete-expected.txt:
• editing/deleting/merge-different-styles-expected.txt:
• editing/deleting/merge-endOfParagraph-expected.txt:
• editing/deleting/merge-into-empty-block-1-expected.txt:
• editing/deleting/merge-into-empty-block-2-expected.txt:
• editing/deleting/merge-no-br-expected.txt:
• editing/deleting/merge-unrendered-space-expected.txt:
• editing/deleting/pruning-after-merge-1-expected.txt:
• editing/deleting/pruning-after-merge-2-expected.txt:
• editing/deleting/smart-delete-001-expected.txt:
• editing/deleting/smart-delete-002-expected.txt:
• editing/deleting/table-cells-expected.txt:
• editing/execCommand/insertHTML-expected.txt:
• editing/input/text-input-controller-expected.txt:
• editing/inserting/insert-3775316-fix-expected.txt:
• editing/inserting/insert-3851164-fix-expected.txt:
• editing/inserting/insert-after-delete-001-expected.txt:
• editing/inserting/insert-div-021-expected.txt:
• editing/inserting/insert-div-026-expected.txt:
• editing/pasteboard/4076267-2-expected.txt:
• editing/pasteboard/4076267-3-expected.txt:
• editing/pasteboard/4076267-expected.txt:
• editing/pasteboard/paste-table-002-expected.txt:
• editing/pasteboard/paste-text-015-expected.txt:
• editing/selection/move-between-blocks-no-001-expected.txt:
• editing/selection/select-all-iframe-expected.txt:
• editing/style/block-style-005-expected.txt:
• editing/style/smoosh-styles-001-expected.txt:
• editing/style/smoosh-styles-002-expected.txt:
• editing/style/style-3681552-fix-002-expected.txt:
• editing/style/typing-style-001-expected.txt:
• editing/style/typing-style-002-expected.txt:
• editing/unsupported-content/list-delete-001-expected.txt:
• editing/unsupported-content/list-delete-002-expected.txt:
• editing/unsupported-content/list-delete-003-expected.txt:
• editing/unsupported-content/table-delete-001-expected.txt:
• editing/unsupported-content/table-delete-002-expected.txt:
• editing/unsupported-content/table-delete-003-expected.txt:
• fast/forms/input-text-option-delete-expected.checksum:
• fast/forms/input-text-option-delete-expected.txt:

WebCore:

Reviewed by justin

Allowed deletion typing commands to take in a granularity

• bridge/mac/WebCoreFrameBridge.h: Pass granularity across the bridge
• bridge/mac/WebCoreFrameBridge.mm: Ditto (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]): (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
• editing/TypingCommand.cpp: Constructors take in a granularity (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
• editing/TypingCommand.h: ditto
• page/Frame.h: Fixed bug that shouldDeleteSelection wasn't virtual

WebKit:

Reviewed by justin

Finished moving deletion selection expansion across the bridge... say that 3 times fast.

• WebView/WebHTMLView.m: Pass granularity to WebCore to handle expansion (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]): (-[WebHTMLView _deleteSelection]): (-[NSArray _deleteWithDirection:granularity:killRing:isTypingAction:]): (-[NSArray deleteToMark:]):

5:27 PM Changeset in webkit [15221] by beidson

• 4 edits in trunk/WebCore

Reviewed by Anders and Tim Hatcher

Added an accessor to a SQLite config option to change its disk-syncing behavior.
Used this accessor to significantly speed up writes to the Icon DB.

• icon/IconDatabase.cpp: (WebCore::IconDatabase::open): Disable full syncing to the SQLite db to speed up writes to the icondb

• icon/SQLDatabase.cpp: (SQLDatabase::setFullsync): (SQLDatabase::setSynchronous):
• icon/SQLDatabase.h: (WebCore::SQLDatabase::): Added accessor to the SQLite config pragma "synchronous"

5:21 PM Changeset in webkit [15220] by darin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• fixed a storage leak noticed by the buildbot

• dom/Document.cpp: (WebCore::Document::removedLastRef): Call delete on the markers before clearing the map containing them.

4:46 PM Changeset in webkit [15219] by andersca

• 5 edits in trunk/WebCore

2006-07-08 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Brady.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9777
Reproducible crash in Loading/Frames in ToT.

The problem was that the renderpart destructor resets the frame's
owner element. For iframes, this should only be done when the element is
going to be removed from the document.

• html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::~HTMLIFrameElement): (WebCore::HTMLIFrameElement::willRemove): (WebCore::HTMLIFrameElement::removedFromDocument): (WebCore::HTMLIFrameElement::detach):
• html/HTMLIFrameElement.h: Remove the frame in willRemove instead.

• rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart): (WebCore::RenderPart::~RenderPart):
• rendering/RenderPart.h: Don't call setFrame(0) in the destructor when the element is an iframe element.

4:01 PM Changeset in webkit [15218] by darin

• 2 edits in trunk/WebCore

Reviewed by Anders.

• fixed a storage leak noticed by the buildbot

• page/FrameView.cpp: (WebCore::FrameViewPrivate::~FrameViewPrivate): Delete m_scheduledEvents.

3:39 PM Changeset in webkit [15217] by sullivan

• 1 edit in trunk/WebKit/ChangeLog

Added a bug number to an existing entry.

3:33 PM Changeset in webkit [15216] by darin

• 3 edits in trunk/WebCore

Reviewed by Adele.

• fixed a couple of storage leaks noticed by the buildbot

• html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::attach): Call deref on the style after calling setRenderStyle, since styleForRenderer returns us a "ref'd" RenderStyle object.
• html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::attach): Ditto.

3:18 PM Changeset in webkit [15215] by darin

• 6 edits in trunk/WebCore

Reviewed by Adele.

• fix some license mistakes

• LICENSE-APPLE: Added more years of publication to the copyright here.

• html/CanvasGradient.idl: Corrected license on this file. It had the wrong one.
• html/CanvasPattern.idl: Ditto.
• html/CanvasRenderingContext2D.idl: Ditto.
• html/HTMLCanvasElement.idl: Ditto.

2:13 PM Changeset in webkit [15214] by beidson

• 2 edits in trunk/WebKit

Reviewed by John

Changed an ASSERT to a LOG_ERROR for an error that could be handled gracefully, but
whose assertion was reproducibly causing a build bot failure

• Misc/WebIconDatabase.m: (-[WebIconDatabase _releaseIconForIconURLString:]):

1:41 PM Changeset in webkit [15213] by ggaren

• 3 edits in trunk/JavaScriptCore

Reviewed by John.

• Fixed a few crashes resulting from NULL parameters to JSClassCreate.

• API/JSClassRef.cpp: (JSClassCreate): (JSClassRelease):
• API/testapi.c: Added test for NULL parameters. (main):

1:39 PM Changeset in webkit [15212] by ggaren

• 3 edits in trunk/JavaScriptCore

Reviewed by John, mocked by Darin.

• Changed JSEvaluate to take a JSObjectRef instead of a JSValueRef as "this," since "this" must be an object.

• API/JSContextRef.cpp: (JSEvaluate):
• API/JSContextRef.h:

1:38 PM Changeset in webkit [15211] by ggaren

• 3 edits in trunk/JavaScriptCore

Reviewed by John.

• More headerdoc

• API/JSBase.h:
• JavaScriptCore.xcodeproj/project.pbxproj:

12:57 PM Changeset in webkit [15210] by thatcher

• 1 copy in tags/WebCore-315.14.4/WebCore

New tag (part 2).

12:56 PM Changeset in webkit [15209] by thatcher

• 1 add in tags/WebCore-315.14.4

New tag.

12:55 PM Changeset in webkit [15208] by thatcher

• 2 edits in branches/Safari-1-3-branch/WebCore

Versioning

12:54 PM Changeset in webkit [15207] by thatcher

• 4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
This fixes <rdar://problem/4600166> REGRESSION: Safari crash while loading web pages ( ​http://www.yahoo.com/ )

2005-10-16 David Hyatt <​hyatt@apple.com>

Clean up the deletion of anonymous boxes in the render tree.
Renamed methods to make it more clear and also added comments.

Reviewed by bdakin

• khtml/rendering/render_container.cpp: (RenderContainer::detach): this was renamed on the branch, from RenderContainer::destroy (RenderContainer::detachLeftoverChildren): this was renamed on the branch, from RenderContainer::destroyLeftoverChildren
• khtml/rendering/render_container.h:
• khtml/rendering/render_flow.cpp: (RenderFlow::detach): this was renamed on the branch, from RenderContainer::destroy

12:33 PM Changeset in webkit [15206] by lweintraub

• 12 edits
  4 adds in trunk

LayoutTests:

Reviewed by justin

Improved table editing

• editing/deleting/delete-to-select-table-expected.checksum: Added.
• editing/deleting/delete-to-select-table-expected.png: Added.
• editing/deleting/delete-to-select-table-expected.txt: Added.
• editing/deleting/delete-to-select-table.html: Added.
• editing/input/text-input-controller-expected.txt:

WebCore:

Reviewed by justin

Improved table editing: pressing delete directly before or after a table will now select
the table first, then delete it, instead of just deleting it. Useful for when the table's
existence is non-obvious.

• bridge/mac/FrameMac.h: Added shouldDeleteSelection, which allows WebCore to trigger deletion editing deligates
• bridge/mac/FrameMac.mm: ditto (WebCore::FrameMac::shouldDeleteSelection):
• bridge/mac/WebCoreFrameBridge.h: ditto
• editing/TypingCommand.cpp: Implemented check for a caret position next to a table, and subsequent selection (as opposed to removal) (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
• page/Frame.cpp: shouldDeleteSelection added (WebCore::Frame::shouldDeleteSelection):
• page/Frame.h: ditto

WebKit:

Reviewed by justin

Improved table editing

• WebCoreSupport/WebFrameBridge.m: Added method to allow WebCore to trigger deletion editing delegate (-[WebFrameBridge shouldDeleteSelectedDOMRange:]):
• WebView/WebHTMLView.m: Moved code that expanded a selection when the delete key is pressed over to WebCore so we can be more intelligent about how to handle it (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:]): (-[NSArray _deleteWithDirection:granularity:killRing:isTypingAction:]):

12:29 PM Changeset in webkit [15205] by thatcher

• 1 edit in branches/Safari-2-0-branch/WebCore/ChangeLog

Versioning

12:21 PM Changeset in webkit [15204] by thatcher

• 2 copies in tags/WebCore-418.20/WebCore

New tag (part 2).

12:20 PM Changeset in webkit [15203] by thatcher

• 1 add in tags/WebCore-418.20

New tag.

12:19 PM Changeset in webkit [15202] by thatcher

• 1 edit in branches/Safari-2-0-branch/WebCore/Info.plist

Versioning

11:24 AM Changeset in webkit [15201] by weinig

• 4 edits
  2 copies in trunk/WebCore

Reviewed by Eric.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9768 Split XSLImportRule out of XSLStyleSheet.* into separate files (one class per file).

• WebCore.xcodeproj/project.pbxproj:
• xml/XSLImportRule.cpp: Added. (WebCore::XSLImportRule::XSLImportRule): (WebCore::XSLImportRule::parentStyleSheet): (WebCore::XSLImportRule::loadSheet):
• xml/XSLImportRule.h: Added.
• xml/XSLStyleSheet.cpp:
• xml/XSLStyleSheet.h:

10:22 AM Changeset in webkit [15200] by andersca

• 3 edits
  2 adds in trunk

WebCore:

2006-07-07 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8300
REGRESSION: First mouse click is randomly ignored when clicking on checkbox and radio buttons

• css/html4.css: Set "-webkit-user-select: ignore" on radio buttons and check boxes .

LayoutTests:

2006-07-07 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8300
REGRESSION: First mouse click is randomly ignored when clicking on checkbox and radio buttons

• fast/forms/radio-check-click-and-drag-expected.txt: Added.
• fast/forms/radio-check-click-and-drag.html: Added.

10:09 AM Changeset in webkit [15199] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Tim Hatcher

• WebKit.exp: added surprisingly missing _WebPreferencesChangedNotification, defined in WebPreferences.h

1:36 AM Changeset in webkit [15198] by mjs

• 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

• fix 20 Node leaks on fast/events tests - these should be the last ones

• bindings/objc/DOMEvents.mm: (-[DOMEvent dealloc]): implement - deref the event! (-[DOMEvent finalize]): ditto

Jul 6, 2006:

9:48 PM Changeset in webkit [15197] by mjs

• 3 edits in trunk/WebCore

Reviewed by Tim Hatcher.

• fix 26 Node leaks on fast/dom tests

• dom/Document.cpp: (WebCore::Document::removedLastRef): delete tokenizer - if we are still parsing at this point, we don't want nodes held by the parser to keep the document alive.
• html/HTMLParser.cpp: (WebCore::RefNonDocNodePtr::RefNonDocNodePtr): Smart pointer that acts like RefPtr for Node, but avoids refing document nodes to avoid cycles. (WebCore::RefNonDocNodePtr::~RefNonDocNodePtr): (WebCore::RefNonDocNodePtr::get): (WebCore::RefNonDocNodePtr::operator*): (WebCore::RefNonDocNodePtr::operator->): (WebCore::RefNonDocNodePtr::operator!): (WebCore::RefNonDocNodePtr::operator UnspecifiedBoolType): (WebCore::RefNonDocNodePtr::operator=): (WebCore::operator==): (WebCore::operator!=): (WebCore::HTMLStackElem): Use a RefNonDocNodePtr instead of RefPtr<Node> (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Use a RefPtr here to avoid crashing

7:29 PM Changeset in webkit [15196] by adele

• 6 edits in trunk/WebCore

Reviewed by Maciej.

Fixed new popup control to open up when the spacebar and the up and down arrows are pressed.

• Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9762 [Native pop up] Highlighted item text is black instead of white

• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::isKeyboardFocusable): Added. (WebCore::HTMLSelectElement::isMouseFocusable): Added. (WebCore::HTMLSelectElement::defaultEventHandler): Updated to showPopup for up and down arrow keys and spacebar.
• html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::shouldUseMenuList): Made this const.
• rendering/RenderPopupMenu.cpp: (WebCore::RenderPopupMenu::populate): Added FIXME.
• rendering/RenderPopupMenuMac.mm: (WebCore::RenderPopupMenuMac::showPopup): Updated to save the NSEvent that triggers the popup, so we can send fake mouseUp and keyUp events when the NSMenu returns. (WebCore::RenderPopupMenuMac::addGroupLabel): Only set the NSForegroundColorAttributeName attribute if the text isn't black. Follow-up bug about other colors: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9769 (WebCore::RenderPopupMenuMac::addOption): ditto.
• bridge/mac/FrameMac.h: (WebCore::FrameMac::currentEvent): Returns the current NSEvent.

7:13 PM Changeset in webkit [15195] by justing

• 7 edits
  8 adds in trunk

LayoutTests:

Reviewed by levi

<rdar://problem/4609184>
Mail crashes at WebCore::Selection::adjustForEditableContent
<rdar://problem/4609140>
Crash at WebCore::Range::compareBoundaryPoints

• editing/selection/mixed-editability-1-expected.checksum: Added.
• editing/selection/mixed-editability-1-expected.png: Added.
• editing/selection/mixed-editability-1-expected.txt: Added.
• editing/selection/mixed-editability-1.html: Added.
• editing/selection/mixed-editability-2-expected.checksum: Added.
• editing/selection/mixed-editability-2-expected.png: Added.
• editing/selection/mixed-editability-2-expected.txt: Added.
• editing/selection/mixed-editability-2.html: Added.

WebCore:

Reviewed by levi

<rdar://problem/4609184>
Mail crashes at WebCore::Selection::adjustForEditableContent
<rdar://problem/4609140>
Crash at WebCore::Range::compareBoundaryPoints

• editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent):
• editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): Moved code into a helper function. (WebCore::VisiblePosition::previous): Ditto.
• editing/htmlediting.cpp: (WebCore::comparePositions): Moved from Selection.cpp. (WebCore::lowestEditableAncestor): Added. Returns rootEditableElement for a node in editable content and the rootEditableElement for the first ancestor that's editable for a node in non-editable content. (WebCore::firstEditablePositionAfterPositionInRoot): (WebCore::lastEditablePositionBeforePositionInRoot):
• editing/htmlediting.h:

6:00 PM Changeset in webkit [15194] by andersca

• 6 edits
  2 adds in trunk

WebCore:

2006-07-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adele.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9528
REGRESSION: arrow key skips '>' in Bugzilla replies due to '\n' in text nodes

Patch by Darin, tweaked by Anders.

• html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerText): Convert newline characters to <br> elements. I've verified that what's done here is what WinIE does when setting innerText.

(WebCore::HTMLElement::setOuterText):
Fix comment.

• rendering/RenderTextField.cpp: (WebCore::RenderTextField::textWithHardLineBreaks): Remove assert. m_div->firstChild() can be null now because setInnerText doesn't create text nodes for empty strings anymore.

LayoutTests:

2006-07-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adele.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9528
REGRESSION: arrow key skips '>' in Bugzilla replies due to '\n' in text nodes

• fast/dom/css-selectorText-expected.txt:
• fast/dom/css-shortHands-expected.txt: Update tests.

• fast/dom/set-inner-text-newlines-expected.txt: Added.
• fast/dom/set-inner-text-newlines.html: Added.

5:22 PM Changeset in webkit [15193] by adele

• 3 edits in trunk/WebCore

Reviewed by Tim Hatcher.

• Speculative fix for <rdar://problem/4605532> unrepro crash at cnn.com after upgrading to 10.4.7 (but happening with 10.4.6 too)

• page/FrameView.cpp: (WebCore::FrameView::layout): Ref's the view during layout, since a recalcStyle could cause the view to be deleted. If we get back from recalcStyle, and there's only one ref, return early since the the view will be deleted when we exit layout.
• page/FrameView.h: (WebCore::FrameView::hasOneRef): Added.

5:12 PM Changeset in webkit [15192] by adele

• 3 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Tim Hatcher.

• Speculative fix for <rdar://problem/4605532> unrepro crash at cnn.com after upgrading to 10.4.7 (but happening with 10.4.6 too)

• khtml/khtmlview.cpp: (KHTMLView::layout): Ref's the view during layout, since a recalcStyle could cause the view to be deleted. If we get back from recalcStyle, and there's only one ref, return early since the the view will be deleted when we exit layout.
• khtml/khtmlview.h: (KHTMLView::hasOneRef): Added.

4:11 PM Changeset in webkit [15191] by andersca

• 14 edits
  5 adds in trunk

WebCore:

2006-07-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4610891> Support overflow events

• DerivedSources.make: Add generated sources.

• WebCore.xcodeproj/project.pbxproj: Add new files.

• bindings/js/kjs_events.cpp: (KJS::toJS): Support creating wrappers for overflow events..

• bindings/objc/DOMEvents.h:
• bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:]): (-[DOMOverflowEvent _overflowEvent]): (-[DOMOverflowEvent orient]): (-[DOMOverflowEvent horizontalOverflow]): (-[DOMOverflowEvent verticalOverflow]): Add Objective-C wrapper for overflow events.

• dom/Event.cpp: (WebCore::Event::isOverflowEvent):
• dom/Event.h:
• dom/EventNames.h:
• dom/OverflowEvent.cpp: Added. (WebCore::OverflowEvent::OverflowEvent): (WebCore::OverflowEvent::isOverflowEvent):
• dom/OverflowEvent.h: Added. (WebCore::OverflowEvent::): (WebCore::OverflowEvent::orient): (WebCore::OverflowEvent::horizontalOverflow): (WebCore::OverflowEvent::verticalOverflow):
• dom/OverflowEvent.idl: Added. Add overflow events.

• page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::applyOverflowToViewport): (WebCore::FrameView::layout): Dispatch any scheduled events when layout is done.

(WebCore::FrameView::scheduleEvent):
New function which schedules an event.

(WebCore::FrameView::updateOverflowStatus):
Update overflow status for the viewport.

(WebCore::FrameView::dispatchScheduledEvents):
New function which dispatches all scheduled events.

• page/FrameView.h: Add declarations.

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateOverflowStatus): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
• rendering/RenderLayer.h: Schedule overflow events when overflow status changes.

LayoutTests:

2006-07-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4610891> Support overflow events

• fast/events/overflow-events-expected.txt: Added.
• fast/events/overflow-events.html: Added.

3:47 PM Changeset in webkit [15190] by thatcher

• 3 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4610881> Expose scroll-related JS properties to ObjC DOM interface
<rdar://problem/4519675> offsetLeft, offsetTop, offsetHeight, and offsetWidth
properties are not exposed to ObjC

• bindings/objc/DOMPrivate.h:
• bindings/objc/DOMHTML.mm: (-[DOMHTMLElement offsetLeft]): (-[DOMHTMLElement offsetTop]): (-[DOMHTMLElement offsetWidth]): (-[DOMHTMLElement offsetHeight]): (-[DOMHTMLElement offsetParent]): (-[DOMHTMLElement clientWidth]): (-[DOMHTMLElement clientHeight]): (-[DOMHTMLElement scrollLeft]): (-[DOMHTMLElement setScrollLeft:]): (-[DOMHTMLElement scrollTop]): (-[DOMHTMLElement setScrollTop:]): (-[DOMHTMLElement scrollWidth]): (-[DOMHTMLElement scrollHeight]):

3:45 PM Changeset in webkit [15189] by brmorris

• 3 edits in S60/trunk

S60WebKit:

2006-07-06 brmorris <​bradley.morrison@nokia.com>

Reviewed by dacarson. Fix for:

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9754

• S60Tools/patch.exe: Updated to version 2.5.
• S60Tools/prepare-ChangeLog.bat: Force forwardslashes.

3:30 PM Changeset in webkit [15188] by brmorris

• 1 edit
  5 adds in S60/trunk

S60WebKit:

2006-07-06 brmorris <​bradley.morrison@nokia.com>

Reviewed by dacarson.

• S60Tools\patch.exe: Added.
• S60Tools\prepare-ChangeLog.bat: Added.
• S60Tools\svn-apply.bat: Added.
• S60Tools\svn-create-patch.bat: Added.
• S60Tools\svn-unapply.bat: Added.

2:41 PM Changeset in webkit [15187] by mjs

• 2 edits in trunk/WebCore

Reviewed by Adele.

• fix 435 more layout tests Node leaks

• editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): fix more instances of leaked DOM ranges

11:39 AM Changeset in webkit [15186] by beidson

• 2 edits in trunk/WebKit

Reviewed by John.

Small fix to my previous small fix that only lets the ASSERT off the hook if the DB
is closing

• Misc/WebIconDatabase.m: (-[WebIconDatabase _releaseIconForIconURLString:]):

9:45 AM Changeset in webkit [15185] by harrison

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Geoff.

<rdar://problem/4565031> innerHTML of XMP tag returns special characters like '&gt;' instead of '>'

• fast/innerHTML/006-expected.checksum: Added.
• fast/innerHTML/006-expected.png: Added.
• fast/innerHTML/006-expected.txt: Added.
• fast/innerHTML/006.html: Added.

WebCore:

Reviewed by Geoff

<rdar://problem/4565031> innerHTML of XMP tag returns special characters like '&gt;' instead of '>'

Test: fast/innerHTML/006.html

• editing/markup.cpp: (WebCore::startMarkup): (WebCore::createMarkup): Do not special quote content of XMP nodes.

4:37 AM Changeset in webkit [15184] by mjs

• 3 edits in trunk/WebCore

Not reviewed - build fix.

• back out earlier leak fix, as it caused a crash on one of the fast/invalid layout tests

• dom/Document.cpp: (WebCore::Document::removedLastRef):
• html/HTMLParser.cpp: (WebCore::HTMLStackElem::HTMLStackElem): (WebCore::HTMLParser::popNestedHeaderTag): (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (WebCore::HTMLParser::reopenResidualStyleTags): (WebCore::HTMLParser::popBlock): (WebCore::HTMLParser::popOneBlock):

2:50 AM Changeset in webkit [15183] by mjs

• 2 edits in trunk/WebCore

Reviewed by Anders.

• fix ~3000 Node leaks on the editing tests

• editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): put a newly created Range in a RefPtr to avoid leaking it, as this leaks the whole document.

2:39 AM Changeset in webkit [15182] by mjs

• 3 edits in trunk/WebCore

Reviewed by Anders.

• fix 26 Node leaks on various fast/dom tests

• dom/Document.cpp: (WebCore::Document::removedLastRef): Delete the tokenizer here, since if we are in mid-parse, the parser might hold refs on some of our children that have self-only refs.
• html/HTMLParser.cpp: (WebCore::HTMLStackElem::HTMLStackElem): don't ref the node if it is a document to avoid ref cycles (WebCore::HTMLStackElem::~HTMLStackElem): ditto (WebCore::HTMLStackElem::node): changed interface a bit to support the above (WebCore::HTMLStackElem::setNode): ditto (WebCore::HTMLParser::popNestedHeaderTag): use new interface to HTMLStackElem (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): ditto (WebCore::HTMLParser::reopenResidualStyleTags): ditto (WebCore::HTMLParser::popBlock): ditto (WebCore::HTMLParser::popOneBlock): ditto

Jul 5, 2006:

11:39 PM Changeset in webkit [15181] by adele

• 2 edits in trunk/WebCore

Reviewed by Adele.

• rendering/RenderMenuList.h: (WebCore::RenderMenuList::createsAnonymousWrapper): This method replaces allowsReusingAnonymousChild() and has the opposite meaning.

11:35 PM Changeset in webkit [15180] by beidson

• 3 edits in trunk/WebKit

Reviewed by Maciej

Small fix that prevents an assertion from triggering if the DB is being cleaned up
(ie, the app being shut down)

• Misc/WebIconDatabase.h:
• Misc/WebIconDatabase.m: (-[NSMutableDictionary init]): (-[WebIconDatabase _applicationWillTerminate:]): (-[WebIconDatabase _releaseIconForIconURLString:]):

11:19 PM Changeset in webkit [15179] by adele

• 6 edits in trunk/WebCore

Build fixes.

• WebCore.vcproj/WebCore/WebCore.vcproj:
• platform/win/TemporaryLinkStubs.cpp:
• rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::calcMinMaxWidth):
• rendering/RenderPopupMenuWin.h: (WebCore::RenderPopupMenuWin::RenderPopupMenuWin):
• rendering/RenderThemeWin.cpp:

10:55 PM Changeset in webkit [15178] by mjs

• 2 edits in trunk/WebCore

Reviewed by Adele.

• fix 308 Node leaks on the editing layout tests

• dom/Document.cpp: (WebCore::Document::removedLastRef): Clear the markers once there are no real refs on the document, otherwise a self-only reference cycle w/ the document can occur.

10:47 PM Changeset in webkit [15177] by adele

• 28 edits
  7 adds in trunk

WebCore:

Reviewed by Maciej and Hyatt.

Initial implementation of popup menu control. This can be turned on by setting -webkit-appearance: menulist on a select element.

• WebCore.xcodeproj/project.pbxproj: Added RenderMenuList.h, RenderMenuList.cpp, RenderPopupMenu.h, RenderPopupMenu.cpp, RenderPopupMenuWin.h, RenderPopupMenuMac.h, RenderPopupMenuMac.mm,

• dom/Node.cpp: (WebCore::Node::renderStyle): Added. Returns the renderer's style. If there's no renderer, returns's a RenderStyle that's kept by the node. This is important for HTMLOptGroupElement and HTMLOptionElement, which don't have renderers. (WebCore::Node::setRenderStyle): Added.
• dom/Node.h:
• dom/Element.cpp: (WebCore::Element::recalcStyle): Updated to use renderStyle so recalcStyle will work for HTMLOptionElements and HTMLOptGroupElements.

• css/cssstyleselector.cpp: Updated to call renderStyle method on the node, so resolving style works on elements w/o renderers that cache style. (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::CSSStyleSelector::locateCousinList): (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::locateSharedStyle): (WebCore::CSSStyleSelector::checkOneSelector):

• css/html4.css: Removed display:none from options and optgroups, since we're now caching style for these elements. Added font-weight styles for option and optgroup.

• html/HTMLOptGroupElement.h: Added m_style to keep track of a RenderStyle for the element, even though we aren't creating a renderer. This will allow us to honor style for optgroups and options for popup menus (and eventually list boxes too). (WebCore::HTMLOptGroupElement::rendererIsNeeded): Added. (WebCore::HTMLOptGroupElement::renderStyle): Added.
• html/HTMLOptionElement.h: ditto. (WebCore::HTMLOptionElement::rendererIsNeeded): Added. (WebCore::HTMLOptionElement::renderStyle): Added.

• html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::HTMLOptGroupElement): Initialize m_style. (WebCore::HTMLOptGroupElement::attach): Set the renderStyle. (WebCore::HTMLOptGroupElement::detach): Clear m_style. (WebCore::HTMLOptGroupElement::setRenderStyle): Added. (WebCore::HTMLOptGroupElement::groupLabelText): Added.
• html/HTMLOptionElement.cpp: ditto. (WebCore::HTMLOptionElement::HTMLOptionElement): (WebCore::HTMLOptionElement::attach): (WebCore::HTMLOptionElement::detach): (WebCore::HTMLOptionElement::setRenderStyle): (WebCore::HTMLOptionElement::optionText):

• html/HTMLSelectElement.cpp: Added code to use the new RenderMenuList if the appearance is set to MenuListAppearance, and if we're not creating a list box renderer. (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::createRenderer): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::notifyOptionSelected): (WebCore::HTMLSelectElement::defaultEventHandler):
• html/HTMLSelectElement.h:

• WebCore.exp: Added _wkPopupMenu.
• platform/mac/WebCoreSystemInterface.h: Added wkPopupMenu to get the NSMenu to pop up.
• platform/mac/WebCoreSystemInterface.mm:

• platform/win/TemporaryLinkStubs.cpp: Added stubs for RenderPopupMenuWin. (RenderPopupMenuWin::RenderPopupMenuWin): (RenderPopupMenuWin::~RenderPopupMenuWin): (RenderPopupMenuWin::clear): (RenderPopupMenuWin::populate): (RenderPopupMenuWin::showPopup): (RenderPopupMenuWin::addSeparator): (RenderPopupMenuWin::addGroupLabel): (RenderPopupMenuWin::addOption):
• rendering/RenderPopupMenuWin.h: Added.

• rendering/RenderPopupMenu.cpp: Added. (WebCore::RenderPopupMenu::RenderPopupMenu): (WebCore::RenderPopupMenu::~RenderPopupMenu): (WebCore::RenderPopupMenu::clear): (WebCore::RenderPopupMenu::populate): Walks the DOM tree, and adds separators, options, and group labels to the RenderPopupMenu. (WebCore::RenderPopupMenu::showPopup): (WebCore::RenderPopupMenu::addSeparator): (WebCore::RenderPopupMenu::addGroupLabel): (WebCore::RenderPopupMenu::addOption):
• rendering/RenderPopupMenu.h: Added. (WebCore::RenderPopupMenu::renderName): (WebCore::RenderPopupMenu::getRenderMenuList):
• rendering/RenderPopupMenuMac.h: Added.
• rendering/RenderPopupMenuMac.mm: Added. (WebCore::RenderPopupMenuMac::RenderPopupMenuMac): (WebCore::RenderPopupMenuMac::~RenderPopupMenuMac): (WebCore::RenderPopupMenuMac::clear): Removes all items from the menu. (WebCore::RenderPopupMenuMac::populate): Disables menuChangedMessages before populating the menu. (WebCore::RenderPopupMenuMac::showPopup): Calculates the right position, and calls wkPopupMenu. (WebCore::RenderPopupMenuMac::addSeparator): (WebCore::RenderPopupMenuMac::addGroupLabel): (WebCore::RenderPopupMenuMac::addOption):

• rendering/RenderMenuList.cpp: Added. (WebCore::RenderMenuList::RenderMenuList): (WebCore::RenderMenuList::addChild): (WebCore::RenderMenuList::removeChild): (WebCore::RenderMenuList::setStyle): (WebCore::RenderMenuList::updateFromElement): If the options have changed, iterate through the children to find the menu item with the widest text. Set the button text to the selected item's text. (WebCore::RenderMenuList::setText): (WebCore::RenderMenuList::paintObject): (WebCore::RenderMenuList::baselinePosition): (WebCore::RenderMenuList::calcMinMaxWidth): (WebCore::RenderMenuList::showPopup): (WebCore::RenderMenuList::layout): (WebCore::RenderMenuList::updateSelection): (WebCore::RenderMenuList::valueChanged):
• rendering/RenderMenuList.h: Added. (WebCore::RenderMenuList::removeLeftoverAnonymousBoxes): (WebCore::RenderMenuList::allowsReusingAnonymousChild): (WebCore::RenderMenuList::canHaveChildren): (WebCore::RenderMenuList::renderName): (WebCore::RenderMenuList::setOptionsChanged): (WebCore::RenderMenuList::selectionChanged): (WebCore::RenderMenuList::setSelectionChanged): (WebCore::RenderMenuList::hasPopupMenu):

• rendering/RenderTheme.cpp: Added cases for MenuListAppearance. (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::isControlStyled): (WebCore::RenderTheme::adjustMenuListStyle): (WebCore::RenderTheme::createPopupMenu): creates platform-specific RenderPopupMenu.
• rendering/RenderTheme.h: (WebCore::RenderTheme::sizeOfArrowControl): Added. (WebCore::RenderTheme::paintMenuList): Added.
• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustRepaintRect): (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::adjustMenuListStyle): (WebCore::RenderThemeMac::setPopupButtonCellState): (WebCore::RenderThemeMac::createPopupMenu): (WebCore::RenderThemeMac::sizeOfArrowControl):
• rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::createPopupMenu):
• rendering/RenderThemeWin.h:

WebKit:

Reviewed by Maciej and Hyatt.

WebKit part of initial popup menu implementation.

• WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Initialize WKPopupMenu.

WebKitLibraries:

Reviewed by Maciej and Hyatt.

• WebKitSystemInterface.h: Updated.
• libWebKitSystemInterface.a: Updated.

7:57 PM Changeset in webkit [15176] by aliceli1

• 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This fixes <rdar://problem/4600166> REGRESSION: Safari crash while loading web pages ( ​http://www.yahoo.com/ )

2005-10-16 David Hyatt <​hyatt@apple.com>

Clean up the deletion of anonymous boxes in the render tree.
Renamed methods to make it more clear and also added comments.

Reviewed by bdakin

• khtml/rendering/render_container.cpp: (RenderContainer::detach): this was renamed on the branch, from RenderContainer::destroy (RenderContainer::detachLeftoverChildren): this was renamed on the branch, from RenderContainer::destroyLeftoverChildren
• khtml/rendering/render_container.h:
• khtml/rendering/render_flow.cpp: (RenderFlow::detach): this was renamed on the branch, from RenderContainer::destroy

4:45 PM Changeset in webkit [15175] by beidson

• 5 edits in trunk/WebCore

Reviewed by Tim Omernick.

IconDatabase now respects private browsing via the use of in memory, temporary tables

• bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]): (-[WebCoreIconDatabaseBridge iconURLForPageURL:]): Renamed WebCore::IconDatabase methods, changes reflected here

• icon/IconDatabase.cpp: (WebCore::IconDatabase::clearDatabase): (WebCore::IconDatabase::deletePrivateTables): (WebCore::IconDatabase::imageDataForIconID): (WebCore::IconDatabase::imageDataForIconURL): (WebCore::IconDatabase::imageDataForPageURL): (WebCore::IconDatabase::setPrivateBrowsingEnabled): (WebCore::IconDatabase::iconForPageURL): (WebCore::IconDatabase::iconURLForPageURL): (WebCore::IconDatabase::setIconDataForIconURL): (WebCore::IconDatabase::performSetIconDataForIconID): (WebCore::IconDatabase::establishTemporaryIconIDForEscapedIconURL): (WebCore::IconDatabase::establishIconIDForEscapedIconURL): (WebCore::IconDatabase::setHaveNoIconForIconURL): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::performSetIconURLForPageURL): (WebCore::IconDatabase::hasIconForIconURL): -Some style/comment cleanups, but mainly putting private browsing handling in place

• icon/IconDatabase.h: Some methods added, others renamed, some comments added

• icon/SQLStatement.cpp: (WebCore::SQLStatement::getColumnName): (WebCore::SQLStatement::getColumnName16): (WebCore::SQLStatement::getColumnText): (WebCore::SQLStatement::getColumnText16): -The above 4 had changes to return String() for empty results instead of "" as it's less expensive;

4:30 PM Changeset in webkit [15174] by sullivan

• 1 edit
  4 adds in trunk/LayoutTests

Reviewed by Adele.

• layout test for <rdar://problem/4609162> REGRESSION: When tabbing between links on a page, the window doesn't scroll to link that's not in view

The test verifies that focusing a link will scroll the link into view.

• fast/events/reveal-link-when-focused-expected.checksum: Added.
• fast/events/reveal-link-when-focused-expected.png: Added.
• fast/events/reveal-link-when-focused-expected.txt: Added.
• fast/events/reveal-link-when-focused.html: Added.

4:27 PM Changeset in webkit [15173] by sullivan

• 3 edits in trunk/WebCore

Reviewed by Darin and Adele.

• fixed <rdar://problem/4609162> REGRESSION: When tabbing between links on a page, the window doesn't scroll to link that's not in view

• html/HTMLAnchorElement.cpp:
• html/HTMLAnchorElement.h: removed HTMLAnchorElement::focus and HTMLAnchorElement::blur.

HTMLAnchorElement::focus just called document()->setFocusNode(). The scroll-to-reveal
code used to be inside document()->setFocusNode(), but now it's in Element::focus, and this override
was preventing that code from running.

HTMLAnchorElement::blur was exactly the same implementation as Element::blur (and there aren't any
other implementations of ::blur in the class hierarchy in between). This change has no practical
effect, other than removing duplicate code.

Adele and I think that it was an oversight not to remove these two methods on 12/20/05
these methods were removed from HTMLButtonElementImpl and HTMLInputElementImpl.

3:24 PM Changeset in webkit [15172] by andersca

• 4 edits in trunk/WebCore

2006-07-05 Anders Carlsson <​acarlsson@apple.com>

• bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
• bridge/win/FrameWin.h:
• platform/win/TemporaryLinkStubs.cpp: (FrameWin::createFrame): Fix Win32 build.

2:37 PM Changeset in webkit [15171] by andersca

• 2 edits in trunk/WebCore

2006-07-05 Anders Carlsson <​acarlsson@apple.com>

• WebCore.xcodeproj/project.pbxproj: Revert accidental change of debug format to DWARF.

2:29 PM Changeset in webkit [15170] by andersca

• 24 edits
  5 adds in trunk

WebCore:

2006-07-05 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=3581
iFrames set to display:none are Missing from frames array

• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::createFrame):
• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initSubframeWithOwnerElement:]): (-[WebCoreFrameBridge installInFrame:]): Modify to pass the owner element instead of the owner renderer.

• dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): Dispatch the node inserted events before attaching the nodes. This is what the tokenizer does.

• html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::openURL): (WebCore::HTMLFrameElement::attach): Pass the element to requestFrame.

(WebCore::HTMLFrameElement::setLocation):
Don't call attach/detach on an iframe.

• html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::insertedIntoDocument): Load the frame here (using openURL).

(WebCore::HTMLIFrameElement::removedFromDocument):
Call frameDetached.

(WebCore::HTMLIFrameElement::attach):
If there's a renderer, attach the content frame to it.

(WebCore::HTMLIFrameElement::detach):
Reset the renderer's frame.

(WebCore::HTMLIFrameElement::openURL):
Modify to request the frame.

• html/HTMLIFrameElement.h: Add detach.

• page/Frame.cpp: (WebCore::parentFromOwnerElement): (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::requestFrame): (WebCore::Frame::requestObject): (WebCore::Frame::loadSubframe): (WebCore::Frame::ownerElement): (WebCore::Frame::ownerRenderer): (WebCore::Frame::disconnectOwnerElement):
• page/Frame.h:
• page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
• rendering/RenderPart.cpp: (WebCore::RenderPart::setFrame): Modify to keep an owner element around instead of the renderer.

• rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Don't do anything for iframes.

WebKit:

2006-07-05 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=3581
iFrames set to display:none are Missing from frames array

• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]): Modify to pass the owner element instead of the owner renderer.

• WebView/WebHTMLView.m: (-[WebHTMLView _topHTMLView]): Remove assertion, it's not valid anymore.

LayoutTests:

2006-07-05 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=3581
iFrames set to display:none are Missing from frames array

• fast/events/mouseover-mouseout2-expected.txt:
• fast/events/mouseover-mouseout2.html: Update expected result. Since we now keep the frame around, the mouseout event is now dispatched to the element in the frame.

• fast/events/onloadFrameCrash-expected.checksum:
• fast/events/onloadFrameCrash-expected.png:
• fast/events/onloadFrameCrash-expected.txt: This does hide the frame now.

• fast/frames/iframe-display-none-expected.txt: Added.
• fast/frames/iframe-display-none.html: Added.
• fast/frames/resources/iframe-display-none-child.html: Added. New test that tests JS interaction with frames.

• fast/frames/iframe-double-attach-expected.txt: Added.
• fast/frames/iframe-double-attach.html: Added.

1:05 PM Changeset in webkit [15169] by thatcher

• 2 edits
  1 add in trunk/WebKit

Reviewed by Harrison.

<rdar://problem/4608423> HIViewAdapter used but not defined
Adds a new export file to fix the build.

• WebKit.LP64.exp: Added.
• WebKit.xcodeproj/project.pbxproj:

12:10 PM Changeset in webkit [15168] by ggaren

• 16 edits
  2 moves in trunk/JavaScriptCore

RS by Beth.

Renamed JSCharBufferRef, which was universally unpopular, to JSStringBufferRef,
which, hopefully, will be less unpopular.

• API/APICast.h: (toJS): (toRef):
• API/JSBase.h:
• API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::staticValueGetter): (KJS::JSCallbackObject::callbackGetter):
• API/JSCharBufferRef.cpp: Removed.
• API/JSCharBufferRef.h: Removed.
• API/JSContextRef.cpp: (JSEvaluate): (JSCheckSyntax):
• API/JSContextRef.h:
• API/JSNode.c: (JSNodePrototype_appendChild): (JSNode_getNodeType): (JSNode_getChildNodes): (JSNode_getFirstChild):
• API/JSNodeList.c: (JSNodeList_length): (JSNodeList_getProperty):
• API/JSObjectRef.cpp: (JSFunctionMakeWithBody): (JSObjectGetDescription): (JSObjectHasProperty): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectDeleteProperty): (JSPropertyEnumeratorGetNext): (JSPropertyListAdd):
• API/JSObjectRef.h:
• API/JSStringBufferRef.cpp: Added. (JSStringMake): (JSStringBufferCreate): (JSStringBufferCreateUTF8): (JSStringBufferRetain): (JSStringBufferRelease): (JSValueCopyStringValue): (JSStringBufferGetLength): (JSStringBufferGetCharactersPtr): (JSStringBufferGetCharacters): (JSStringBufferGetMaxLengthUTF8): (JSStringBufferGetCharactersUTF8): (JSStringBufferIsEqual): (JSStringBufferIsEqualUTF8): (JSStringBufferCreateWithCFString): (CFStringCreateWithJSStringBuffer):
• API/JSStringBufferRef.h: Added.
• API/JSValueRef.h:
• API/JavaScriptCore.h:
• API/minidom.c: (main): (print):
• API/testapi.c: (assertEqualsAsUTF8String): (assertEqualsAsCharactersPtr): (assertEqualsAsCharacters): (MyObject_hasProperty): (MyObject_getProperty): (MyObject_setProperty): (MyObject_deleteProperty): (MyObject_getPropertyList): (print_callAsFunction): (myConstructor_callAsConstructor): (main):
• JavaScriptCore.exp:
• JavaScriptCore.xcodeproj/project.pbxproj:

11:54 AM Changeset in webkit [15167] by thatcher

• 3 edits in tags/WebKit-521.14.3/WebKit

Build fixes and versioning.

11:35 AM Changeset in webkit [15166] by thatcher

• 1 copy in tags/WebKit-521.14.3

New tag.

11:07 AM Changeset in webkit [15165] by ggaren

• 6 edits in trunk/JavaScriptCore

RS by Beth.

Moved some code around for more logical file separation.

• API/JSBase.h:
• API/JSContextRef.h:
• API/JSObjectRef.cpp:
• API/JSValueRef.cpp: (JSValueToObject):
• API/JSValueRef.h:

10:46 AM Changeset in webkit [15164] by ggaren

• 6 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Implemented JSFunctionMakeWithBody, which parses a script as a function body
in the global scope, and returns the resulting anonymous function.

I also removed private data from JSCallbackFunction. It never worked,
since JSCallbackFunction doesn't inherit from JSCallbackObject.

• API/JSCallbackConstructor.cpp: Removed.
• API/JSCallbackConstructor.h: Removed.
• API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::JSCallbackFunction): (KJS::JSCallbackFunction::implementsConstruct): (KJS::JSCallbackFunction::construct): (KJS::JSCallbackFunction::implementsCall): (KJS::JSCallbackFunction::callAsFunction):
• API/JSCallbackFunction.h:
• API/JSCallbackObject.cpp: (KJS::JSCallbackObject::staticFunctionGetter):
• API/JSObjectRef.cpp: (JSFunctionMake): (JSFunctionMakeWithCallbacks):
• API/JSObjectRef.h:
• API/JSValueRef.h:
• API/minidom.c: (main):
• API/testapi.c: (main):
• JavaScriptCore.exp: Programmatically added all symbols exported by API object files, and sorted results
• JavaScriptCore.xcodeproj/project.pbxproj:

9:52 AM Changeset in webkit [15163] by ggaren

• 10 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

• Return syntax error in JSCheckSyntax through a JSValueRef* exception argument

• API/JSBase.h:
• API/JSContextRef.cpp: (JSCheckSyntax):
• API/testapi.c: (main):
• JavaScriptCore.exp:
• kjs/interpreter.cpp: (KJS::Interpreter::checkSyntax):
• kjs/interpreter.h:

JavaScriptGlue:

Reviewed by Maciej.

• JSRun.cpp: (JSRun::CheckSyntax): Updated to use new checkSyntax syntax in JSC.
• JavaScriptGlue.xcodeproj/project.pbxproj:

9:35 AM Changeset in webkit [15162] by thatcher

• 1 edit in trunk/WebKit/Carbon/CarbonWindowAdapter.m

Build fix.

9:35 AM Changeset in webkit [15161] by thatcher

• 1 edit in trunk/WebKit/Carbon/CarbonWindowAdapter.m

Build fix to work with the new linker.

9:27 AM Changeset in webkit [15160] by thatcher

• 1 edit in trunk/WebKit/Misc/WebNSDataExtras.m

Fixes backwards if statement logic.