Timeline



Jul 27, 2006:

10:13 PM Changeset in webkit [15666] by adele
  • 9 edits in trunk/WebCore

Reviewed by Anders.

No test possible (no functionality change)

  • rendering/RenderBox.cpp: (WebCore::RenderBox::position):
  • rendering/RenderBox.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::position):
  • rendering/RenderTableRow.h: (WebCore::RenderTableRow::position):
  • rendering/RenderTableSection.h: (WebCore::RenderTableSection::position):
  • rendering/RenderText.cpp: (WebCore::RenderText::position):
  • rendering/RenderText.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::constructLine): (WebCore::RenderBlock::computeVerticalPositionsForLine):
9:53 PM Changeset in webkit [15665] by adele
  • 14 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test case for
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9753>
SVG with width and height 100% leaves room for scrollbar on the right.

  • svg/custom/width-full-percentage-expected.txt: Added.
  • svg/custom/width-full-percentage-expected.checksum: Added.
  • svg/custom/width-full-percentage-expected.png: Added.
  • svg/custom/width-full-percentage.svg: Added.

WebCore:

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9753
SVG with width and height 100% leaves room for scrollbar on the right.

Relayout children of svg containers, except svg shapes that do not depend on percentages.

  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::hasPercentageValues):
  • kcanvas/RenderPath.h:
  • kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
  • ksvg2/svg/SVGCircleElement.cpp: (SVGCircleElement::hasPercentageValues):
  • ksvg2/svg/SVGCircleElement.h:
  • ksvg2/svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::hasPercentageValues):
  • ksvg2/svg/SVGEllipseElement.h:
  • ksvg2/svg/SVGLineElement.cpp: (SVGLineElement::hasPercentageValues):
  • ksvg2/svg/SVGLineElement.h:
  • ksvg2/svg/SVGRectElement.cpp: (WebCore::SVGRectElement::hasPercentageValues):
  • ksvg2/svg/SVGRectElement.h:
  • ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::hasPercentageValues):
6:07 PM Changeset in webkit [15664] by thatcher
  • 1 edit in tags/Safari-521.24/WebCore/Info.plist

Versioning

6:03 PM Changeset in webkit [15663] by thatcher
  • 4 edits in tags/Safari-521.24/WebCore

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-26 Justin Garcia <​justin.garcia@apple.com>

Reviewed by darin


<rdar://problem/4652788>
REGRESSION: Can't change size or style of any text in message body

  • dom/Node.cpp: (WebCore::Node::isContentRichlyEditable): Mimic Node::isContentEditable.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::isContentRichlyEditable): First check the frame for editability, then userModify, like what HTMLElement::isContentEditable() does.
  • html/HTMLElement.h:
6:02 PM Changeset in webkit [15662] by thatcher
  • 4 edits in branches/Safari-521/WebCore

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-26 Justin Garcia <​justin.garcia@apple.com>

Reviewed by darin


<rdar://problem/4652788>
REGRESSION: Can't change size or style of any text in message body

  • dom/Node.cpp: (WebCore::Node::isContentRichlyEditable): Mimic Node::isContentEditable.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::isContentRichlyEditable): First check the frame for editability, then userModify, like what HTMLElement::isContentEditable() does.
  • html/HTMLElement.h:
5:47 PM Changeset in webkit [15661] by thatcher
  • 1 copy in tags/Safari-521.24

New tag.

5:45 PM Changeset in webkit [15660] by thatcher
  • 4 edits in branches/Safari-521

Versioning

5:40 PM Changeset in webkit [15659] by thatcher
  • 2 edits in branches/Safari-521/WebCore

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-26 Alice Liu <​alice.liu@apple.com>

Reviewed by John Sullivan (and Kevin and Timo).

landing this patch for John et al.
Fixed <rdar://problem/4651380> REGRESSION (9A232->9A234): existing web clips don't render if you restart Dashboard

  • page/FrameView.cpp: (WebCore::FrameView::layout): moved the call to didFirstLayout to above the check for needsLayout because we need to call didFirstLayout for every webview, not just ones we think need layout.
5:38 PM Changeset in webkit [15658] by thatcher
  • 2 edits in branches/Safari-521/WebKit

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-25 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej, inspired by John.


  • Fixed <rdar://problem/4651931> 1% REGRESSION on iBench HTML due to repeated requests for non-existent favicon


An optimization to avoid serializing favicon data for missing icons had stomped an
optimization to avoid GETing a missing favicon more than once. The solution
is a happy marriage of optimizations, ensuring that we *retain* the missing
favicon's "i am missing" data without posting a notification or saving it to disk.

  • Misc/WebIconDatabase.m: (-[WebIconDatabase _setIconURL:forURL:]):
5:36 PM Changeset in webkit [15657] by thatcher
  • 3 edits in branches/Safari-521/WebCore

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-25 Justin Garcia <​justin.garcia@apple.com>

Reviewed by darin


<rdar://problem/4468458> Incoming HTML message is editable <body contenteditable="true">

  • dom/Document.cpp: (WebCore::Document::inDesignMode): Removed some spaces.
  • page/Frame.cpp: (WebCore::Frame::applyEditingStyleToElement): Just add CSS properties needed for editing. (WebCore::Frame::removeEditingStyleFromElement): Made this a no-op, we'll remove it eventually.
4:50 PM Changeset in webkit [15656] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4242293>
Poor paste fidelity of ​http://www.google.com/

  • editing/pasteboard/styled-element-markup-expected.checksum: Added.
  • editing/pasteboard/styled-element-markup-expected.png: Added.
  • editing/pasteboard/styled-element-markup-expected.txt: Added.
  • editing/pasteboard/styled-element-markup.html: Added.

WebCore:

Reviewed by levi


<rdar://problem/4242293>
Poor paste fidelity of ​http://www.google.com/

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): Fixed crasher with nil-check.
  • editing/markup.cpp: (WebCore::startMarkup): Style information wasn't added to an element if it had attributes but no style attribute.
2:56 PM Changeset in webkit [15655] by spadma
  • 2 edits in S60/trunk/WebKit

2006-07-27 zhalu <​Zhaosong.lu@nokia.com>

Reviewed by Sachin

  • BrowserCore/Formcontrols/src/FControlSelectSkin.cpp: (CFormSelectSkin::CalculateVisualClipTextL): Work around if Font returns zero for MaxNormalCharWidth


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10133

2:06 PM Changeset in webkit [15654] by lypanov
  • 4 edits
    2 adds in trunk

2006-07-27 Alexander Kellett <​lypanov@kde.org>

Reviewed by Darin.

  • bindings/scripts/CodeGeneratorJS.pm: add new attribute - HasOverridingNameGetter
  • html/HTMLFormElement.idl:

2006-07-27 Alexander Kellett <​lypanov@kde.org>

Reviewed by Darin.

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9867
REGRESSION: code that modifies form element in Firefox modifies form attribute in WebKit

  • fast/forms/input-named-action-overrides-action-attribute-expected.txt: Added.
  • fast/forms/input-named-action-overrides-action-attribute.html: Added.
1:18 PM Changeset in webkit [15653] by rwlbuis
  • 8 edits
    2 adds in trunk

Reviewed by Anders.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8992
Some HTML DOM attributes have incorrect types

Adjust idl and dom source code for HTMLImageElement and
HTMLBaseFontElement to choose correct type for
HTMLImageElement::border and HTMLBaseFontElement::size
attributes.

1:01 PM Changeset in webkit [15652] by justing
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4628409>
Safari crashes in CompositeEditCommand::removeBlockPlaceholder entering text in a web page form

  • fast/forms/4628409-expected.txt: Added.
  • fast/forms/4628409.html: Added.

WebCore:

Reviewed by levi


<rdar://problem/4628409>
Safari crashes in CompositeEditCommand::removeBlockPlaceholder entering text in a web page form

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeBlockPlaceholder): A script on the page shrinks the textarea down to zero rows just before insertion. That gives the shadow div a zero height, removing [div, 0] as a candidate for a VisiblePosition. Then InsertTextCommand::input() tries to create a VisiblePosition from [div, 0] and fails. A nil check is a quick fix. Another might be to make positions where there is a caret selection candidates. Another might be to make any [div, 0] where div is a shadow div inside a form element a candidate.
11:58 AM Changeset in webkit [15651] by ap
  • 3 edits
    4 adds in trunk

Fix by Graham Dennis, reviewed by Darin.


Test: fast/encoding/denormalised-voiced-japanese-chars.html

  • platform/Font.cpp: (WebCore::WidthIterator::advance): pass currentCharacter to normalizeVoicingMarks (WebCore::WidthIterator::normalizeVoicingMarks): turn the currentCharacter variable into an argument as WidthIterator::advance doesn't update m_currentCharacter while looping
11:11 AM Changeset in webkit [15650] by thatcher
  • 2 edits in tags/Safari-521.23/WebKit

Versioning

11:09 AM Changeset in webkit [15649] by thatcher
  • 2 edits in branches/Safari-521/WebKit

Versioning

2:22 AM Changeset in webkit [15648] by eseidel
  • 13 edits in trunk

2006-07-27 Eric Seidel <​eric@eseidel.com>

Reviewed by ap.

Complex entities seem to fail on TOT
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6390
Use an alternative work-around to an XML Entity parsing bug.

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::write): (WebCore::hackAroundLibXMLEntityBug): added. (WebCore::startElementNsHandler): (WebCore::endElementNsHandler): (WebCore::charactersHandler): (WebCore::processingInstructionHandler): (WebCore::cdataBlockHandler): (WebCore::commentHandler): (WebCore::getEntityHandler):
12:46 AM Changeset in webkit [15647] by rwlbuis
  • 3 edits
    8 adds in trunk

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9938
Fix viewBox issues in Hixie's test

Do a more accurate and quicker job of parsing the viewBox
attribute. Handle properly on negative width/height and
invalid syntax in general.

  • ksvg2/svg/SVGFitToViewBox.cpp: (SVGFitToViewBox::parseViewBox):

Jul 26, 2006:

10:26 PM Changeset in webkit [15646] by eseidel
  • 11 edits
    12 adds in trunk

2006-07-27 Eric Seidel <​eric@eseidel.com>

Reviewed by ap.

Enables getSVGDocument() support for HTMLObjectElement and HTMLEmbedElement
This patch does not try to autogenerate anything, but enables the SVG functionality.
Also fix HTMLObjectElement vspace and hspace to be numbers instead of strings to match IE & Firefox.

  • bindings/js/kjs_dom.cpp: (KJS::toJS):
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::objectGetter): (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::objectSetter):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • dom/Document.h: (WebCore::Document::isSVGDocument):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::contentDocument): (WebCore::HTMLEmbedElement::getSVGDocument):
  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::getInstance): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::contentDocument): (WebCore::HTMLObjectElement::rendererIsNeeded): (WebCore::HTMLObjectElement::createRenderer): (WebCore::HTMLObjectElement::setCode): (WebCore::HTMLObjectElement::setArchive): (WebCore::HTMLObjectElement::setBorder): (WebCore::HTMLObjectElement::setCodeBase): (WebCore::HTMLObjectElement::setCodeType): (WebCore::HTMLObjectElement::setData): (WebCore::HTMLObjectElement::hspace): (WebCore::HTMLObjectElement::setHspace): (WebCore::HTMLObjectElement::setStandby): (WebCore::HTMLObjectElement::setType): (WebCore::HTMLObjectElement::setUseMap): (WebCore::HTMLObjectElement::vspace): (WebCore::HTMLObjectElement::setVspace): (WebCore::HTMLObjectElement::getSVGDocument):
  • html/HTMLObjectElement.h:
  • ksvg2/svg/SVGDocument.h: (WebCore::SVGDocument::isSVGDocument):
  • rendering/RenderWidget.h: (WebCore::RenderWidget::frameView):
9:31 PM Changeset in webkit [15645] by ap
  • 3 edits
    3 adds in trunk

Reviewed by Darin.

Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9901
XSLTProcessor cannot parse text nodes for INPUT ELEMENTS in an XSLT stylesheet

Test: fast/js/xhtml-serialize.html

  • editing/markup.cpp: (WebCore::endMarkup): If the element has child nodes, write a closing tag even if it is not permitted in HTML, to make it valid XML.
6:43 PM Changeset in webkit [15644] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan (and Kevin and Timo).

landing this patch for John et al.
Fixed <rdar://problem/4651380> REGRESSION (9A232->9A234): existing web clips don't render if you restart Dashboard

  • page/FrameView.cpp: (WebCore::FrameView::layout): moved the call to didFirstLayout to above the check for needsLayout because we need to call didFirstLayout for every webview, not just ones we think need layout.
5:42 PM Changeset in webkit [15643] by justing
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/4652788>
REGRESSION: Can't change size or style of any text in message body

  • editing/style/designmode-expected.checksum: Added.
  • editing/style/designmode-expected.png: Added.
  • editing/style/designmode-expected.txt: Added.
  • editing/style/designmode.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/4652788>
REGRESSION: Can't change size or style of any text in message body

  • dom/Node.cpp: (WebCore::Node::isContentRichlyEditable): Mimic Node::isContentEditable.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::isContentRichlyEditable): First check the frame for editability, then userModify, like what HTMLElement::isContentEditable() does.
  • html/HTMLElement.h:
5:26 PM Changeset in webkit [15642] by thatcher
  • 1 copy in tags/Safari-521.23

New tag.

5:07 PM Changeset in webkit [15641] by thatcher
  • 2 edits in branches/Safari-521/WebCore

Versioning

4:22 PM Changeset in webkit [15640] by thatcher
  • 6 edits in branches/Safari-521

WebCore:

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-25 David Harrison <​harrison@apple.com>

Reviewed by timo and Darin.

<rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)


  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Add matchStyle parameter for use by WebKit.

WebKit:

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-25 David Harrison <​harrison@apple.com>

Reviewed by timo and Darin.

<rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)


  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebView.m: (-[WebView replaceSelectionWithNode:]): (-[WebView _replaceSelectionWithNode:matchStyle:]):
  • WebView/WebViewPrivate.h: (-[WebView _replaceSelectionWithNode:matchStyle::]): New SPI that is same as replaceSelectionWithNode: with added parameter whether to match existing style.
12:33 PM Changeset in webkit [15639] by ap
  • 2 edits in trunk/WebCore

Fix by Mitz Pettel, reviewed by ap.

  • fix debug-only information() string for table cells
  • rendering/RenderObject.cpp: (WebCore::RenderObject::information):
11:31 AM Changeset in webkit [15638] by brmorris
  • 5 edits
    1 add in S60/trunk

2006-06-26 David Carson <​david.carson@nokia.com>

Reviewed by Sachin & Zalan.


Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9073
Soft hyphens not breaking words


  • WebCore/WebCore/khtml/rendering/break_lines.cpp (isBreakable): Added check for soft hyphen character when determining where to break a word. Based on similar change made by Hyatt in Windows port of WebKit. Added copyright notice to the file, copied from same file in current Mac WebKit tree.


Testcases

  • LayoutTests/fast/js/global/encode-URI-test-mobile-expected.txt:
  • LayoutTests/fast/text/basic/014-mobile-expected.txt: Updated these results as the test now passes, and the results are different.
  • LayoutTests/fas/text/basic/013-mobile-expected.txt Added missing results file.
9:31 AM Changeset in webkit [15637] by brmorris
  • 5 edits
    2 adds in S60/trunk

2006-07-26 David Carson <​david.carson@nokia.com>


Implement location.assign.
Reviewed by Zalan.


Test cases added:

  • layout-tests/fast/js/location-assign.html: Added.
  • layout-tests/fast/js/location-assign-expected.txt: Added.
  • layout-tests/fast/js/resources/new-location.html: Added.
  • khtml/ecma/kjs_window.cpp: (Window::get): (Window::isSafeScript): (WindowFunc::tryCall): (ScheduledAction::execute): (Location::get): (LocationFunc::tryCall):
  • khtml/ecma/kjs_window.h: (KJS::Window::): (KJS::Location::):
  • khtml/ecma/kjs_window.lut.h: (KJS::): Implement location.assign.

Jul 25, 2006:

8:04 PM Changeset in webkit [15636] by ggaren
  • 2 edits in trunk/WebKit

Reviewed by Maciej, inspired by John.


  • Fixed <rdar://problem/4651931> 1% REGRESSION on iBench HTML due to repeated requests for non-existent favicon


An optimization to avoid serializing favicon data for missing icons had stomped an
optimization to avoid GETing a missing favicon more than once. The solution
is a happy marriage of optimizations, ensuring that we *retain* the missing
favicon's "i am missing" data without posting a notification or saving it to disk.

  • Misc/WebIconDatabase.m: (-[WebIconDatabase _setIconURL:forURL:]):
7:23 PM Changeset in webkit [15635] by thatcher
  • 1 copy in tags/Safari-521.22

New tag.

7:18 PM Changeset in webkit [15634] by thatcher
  • 6 edits in branches/Safari-521

Versioning

5:30 PM Changeset in webkit [15633] by harrison
  • 6 edits in trunk

WebCore:

Reviewed by timo and Darin.

<rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)


  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Add matchStyle parameter for use by WebKit.

WebKit:

Reviewed by timo and Darin.

<rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)


  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebView.m: (-[WebView replaceSelectionWithNode:]): (-[WebView _replaceSelectionWithNode:matchStyle:]):
  • WebView/WebViewPrivate.h: (-[WebView _replaceSelectionWithNode:matchStyle::]): New SPI that is same as replaceSelectionWithNode: with added parameter whether to match existing style.
5:27 PM Changeset in webkit [15632] by thatcher
  • 3 edits in branches/Safari-521/WebCore

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-24 Adele Peterson <​adele@apple.com>

Reviewed by Justin.

  • Fix for <rdar://problem/4632132> Changing style of content with mixed editability fails

Test: * editing/style/apple-style-editable-mix.html

  • dom/Node.cpp: (WebCore::Node::isContentRichlyEditable): Doesn't need to check the editable root. It now just checks the user modify property of its own renderer, since that is inherited.
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): If the end position is in a table, Adjust the end node to the last descendant of the table, so we don't skip over any runs.
5:23 PM Changeset in webkit [15631] by thatcher
  • 3 edits in branches/Safari-521/WebKit

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-24 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Geoff.


  • WebView/WebLoader.h:
  • WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader receivedError:]): Copy in some code from the base class to do it in the proper order, surrounding the call to [ds _receivedMainResourceError:error complete:YES].
5:17 PM Changeset in webkit [15630] by thatcher
  • 3 edits in branches/Safari-521/WebKit

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-24 Timothy Hatcher <​timothy@apple.com>

Reviewed by John and Darin.

<rdar://problem/4634290> Cannot selectively install a custom
scroller that differs from the default Aqua frame size.

Adds two new private methods to WebFrameView that allows
an application to set a custom scroll view class. This is needed
if the application wants to install a custom scroller that is wider
than the typical scroller, because NSScrollView does the content
rect calculations in a class method (ignoring custom scrollers.)
The _setScrollViewClass method requires the class to be a subclass
of WebDynamicScrollBarView, or nil can be passed to reset to the default class.
A new scroll view of the specified class will then replace the previous
one without the need to reload content of the frame.

  • WebView/WebFrameView.m: (-[WebFrameView _customScrollViewClass]): (-[WebFrameView _setCustomScrollViewClass:]):
  • WebView/WebFrameViewPrivate.h:
5:09 PM Changeset in webkit [15629] by thatcher
  • 5 edits in branches/Safari-521/WebCore

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-24 David Hyatt <​hyatt@apple.com>

Two bug fixes.

(1) Make sure to mark positioned objects that depend on line position to
mark themselves as needing layout when their line box placeholder gets
repositioned.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::position):


(2) Improve highlighting to factor the inflation into overflow so that
invalidation and repainting will work properly.

  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::addHighlightOverflow):
  • rendering/RootInlineBox.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
5:06 PM Changeset in webkit [15628] by thatcher
  • 2 edits in branches/Safari-521/WebCore

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adele.

<rdar://problem/4641824> REGRESSION: Wikipedia widget fails to complete a search after pressing return key


  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Don't eat enter events for search fields that have no enclosing form; they need to be passed to AppKit so that onsearch can be invoked.


  • manual-tests/onsearch-enter.html: Added.
4:13 PM Changeset in webkit [15627] by justing
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by adele


<rdar://problem/4649560>
REGRESSION: Can't Select All when the body is contentEditable="true"

  • editing/selection/select-all-005-expected.checksum: Added.
  • editing/selection/select-all-005-expected.png: Added.
  • editing/selection/select-all-005-expected.txt: Added.
  • editing/selection/select-all-005.html: Added.
  • editing/selection/select-all-006-expected.checksum: Added.
  • editing/selection/select-all-006-expected.png: Added.
  • editing/selection/select-all-006-expected.txt: Added.
  • editing/selection/select-all-006.html: Added.

WebCore:

Reviewed by adele


<rdar://problem/4649560>
REGRESSION: Can't Select All when the body is contentEditable="true"

  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition): Allow descent from a non-editable html element into an editable body as a convenience.
3:06 PM Changeset in webkit [15626] by brmorris
  • 2 edits in S60/trunk/WebKit

2006-07-25 brmorris <​bradley.morrison@nokia.com>

Quickfix for RD_32_BROWSER build


Reviewed by Sachin.

  • BrowserView/inc/WebKitToolBarInterface.h: Removed errant "\no newline at end of file" :-)
2:24 PM Changeset in webkit [15625] by brmorris
  • 3 edits
    1 add in S60/trunk

2006-07-25 brmorris <​bradley.morrison@nokia.com>

Reviewed by Sachin.

  • build.bat: restores variant.cfg to default at END
  • variant_default.cfg: Added.
2:06 PM Changeset in webkit [15624] by justing
  • 3 edits in trunk/WebCore

Reviewed by darin


<rdar://problem/4468458> Incoming HTML message is editable <body contenteditable="true">

  • dom/Document.cpp: (WebCore::Document::inDesignMode): Removed some spaces.
  • page/Frame.cpp: (WebCore::Frame::applyEditingStyleToElement): Just add CSS properties needed for editing. (WebCore::Frame::removeEditingStyleFromElement): Made this a no-op, we'll remove it eventually.
1:56 PM Changeset in webkit [15623] by spadma
  • 19 edits
    2 adds in S60/trunk

2006-07-25 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin


WARNING: NO TEST CASES ADDED OR CHANGED


Implement webkit changes for toolbar.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10101


  • BrowserControl/inc/BrCtl.h:
  • BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
  • BrowserControl/inc/BrCtlInterface.h:
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::~CBrCtl): (CBrCtl::HandleCommandL): (CBrCtl::AddCommandObserverL): (CBrCtl::RemoveCommandObserver): (CBrCtl::SendCommandsToClient):
  • BrowserView/inc/WebKitToolBarInterface.h: Added.
  • BrowserView/inc/WebKitView.h:
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL): (CKeyEventHandler::HandleActivateKeysL):
  • BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CursorUpdate):
  • BrowserView/src/WebKitToolBarInterface.cpp: Added. (CWebKitToolBarInterface::NewL): (CWebKitToolBarInterface::CWebKitToolBarInterface): (CWebKitToolBarInterface::ConstructL): (CWebKitToolBarInterface::~CWebKitToolBarInterface): (CWebKitToolBarInterface::CursorPosition): (CWebKitToolBarInterface::SetAndUpdateCursorPosition): (CWebKitToolBarInterface::SendCommandsToClient): (CWebKitToolBarInterface::ResolveUrlL): (CWebKitToolBarInterface::OpenPageViewL): (CWebKitToolBarInterface::HandleHistoryCommandL):
  • BrowserView/src/WebKitView.cpp: (CWebKitView::~CWebKitView): (CWebKitView::Draw): (CWebKitView::DrawToolTip): (CWebKitView::LaunchToolBarL): (CWebKitView::CloseToolBarL):
  • group/BWINSCW/WebKit_30U.def:
  • group/BrowserView.mmp:
  • group/EABI/browserengineU.def:
  • group/webkit.mmp:
  • rom/webkit.iby:
  • rom/webkitResources.iby:
1:32 PM Changeset in webkit [15622] by brmorris
  • 2 edits in S60/trunk

2006-07-25 brmorris <​bradley.morrison@nokia.com>

Reviewed by ​zbujtas@gmail.com.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9941


  • build.bat: Correct build drive print statement.

Allow BUILD_DRIVE env var support.

10:26 AM Changeset in webkit [15621] by brmorris
  • 2 edits in S60/trunk

2006-07-25 brmorris <​bradley.morrison@nokia.com>

Reviewed by Zalan.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10104

  • runATF.bat: Restore emulator startup on SIGINT
10:23 AM Changeset in webkit [15620] by spadma
  • 2 edits in S60/trunk/WebKit

2006-07-25 vbradley <​vincent.bradley@nokia.com>

Reviewed by Sachin & Sriram.

Changes to CreateStream to allow Plugins to make additional content requests.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10091

  • Plugin/src/PluginWin.cpp: (CPluginWin::ConstructL): (CPluginWin::~CPluginWin): (CPluginWin::SizeChanged): (CPluginWin::OfferKeyEventL): (CPluginWin::DestroyStream): (CPluginWin::CreateStreamL): (CPluginWin::WriteStreamL): (CPluginWin::WriteStreamToPluginL): (CPluginWin::DestroyStreamL): (CPluginWin::LoadRequestL): (CPluginWin::SetPluginFocusL): (CPluginWin::PluginConstructedL): (CPluginData::CPluginData): (CPluginData::NewL): (CPluginData::SetUrlL):
8:35 AM Changeset in webkit [15619] by ddkilzer
  • 7 edits in trunk/WebCore

WebCore:

Reviewed by Darin.

No test added because there is no change in functionality.

  • bindings/js/kjs_binding.cpp: Removed valueToBooleanTreatUndefinedAsTrue() method.
  • bindings/js/kjs_binding.h: Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Removed support for ConvertUndefinedToTrue parameter attribute.
  • dom/Element.h: Set default value to true for scrollIntoView() and scrollIntoViewIfNeeded() arguments.
  • dom/Element.idl: Replaced ConvertUndefinedToTrue attribute with Optional attribute. Fixed name of scrollIntoViewIfNeeded() argument to match implementation.
  • page/DOMWindow.idl: Replaced ConvertUndefinedToTrue attribute with Optional attribute.

Jul 24, 2006:

10:05 PM Changeset in webkit [15618] by darin
  • 9 edits in trunk

JavaScriptCore:

Reviewed and tweaked a bit by Darin.

  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue): Added case for converting NSNull to jsNull.

LayoutTests:

Reviewed and tweaked a bit by Darin.

  • added some new tests that use "echo" including one for JavaScript null
  • plugins/bindings-test-expected.txt: Added results.
  • plugins/bindings-test.html: Added tests.

WebCore:

Reviewed and tweaked a bunch by Darin.

Test: plugins/bindings-test.html

  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originExecutionContext:executionContext:]): Added case that converts jsNull to NSNull.

WebKitTools:

Reviewed and tweaked a bit by Darin.

  • DumpRenderTree/ObjCPlugin.m: (+[ObjCPlugin isSelectorExcludedFromWebScript:]): Added "echo:". (+[ObjCPlugin webScriptNameForSelector:]): Use the name "echo" for "echo:" so it's nice to call from JavaScript. (-[ObjCPlugin echo:]): Just returns the same object -- can be used to test a round trip through Objective-C types.
9:39 PM Changeset in webkit [15617] by darin
  • 50 edits
    8 adds
    2 deletes in trunk

LayoutTests:

Reviewed by Adele and Justin.

  • fast/forms/textarea-type-spaces-expected.txt: Added.
  • fast/forms/textarea-type-spaces.html: Added.
  • fast/forms/textarea-paste-newline-expected.txt: Added.
  • fast/forms/textarea-paste-newline.html: Added.
  • updated tests affected by above changes, results are equivalent or better
  • editing/pasteboard/4641033-expected.checksum:
  • editing/pasteboard/4641033-expected.png:
  • editing/pasteboard/4641033-expected.txt:
  • editing/pasteboard/paste-table-003-expected.checksum:
  • editing/pasteboard/paste-table-003-expected.png:
  • editing/pasteboard/paste-table-003-expected.txt:
  • editing/pasteboard/paste-text-016-expected.txt:
  • editing/pasteboard/quirks-mode-br-1-expected.txt:
  • editing/pasteboard/quirks-mode-br-2-expected.txt:
  • fast/forms/textarea-scrolled-type-expected.checksum:
  • fast/forms/textarea-scrolled-type-expected.png:
  • fast/forms/textarea-scrolled-type-expected.txt:
  • changed a test to be a "dump as text" test
  • fast/forms/paste-into-textarea-expected.txt:
  • fast/forms/paste-into-textarea.html:
  • fast/forms/paste-into-textarea-expected.checksum: Removed.
  • fast/forms/paste-into-textarea-expected.png: Removed.
  • changed a test to be a "dump as text" test, improved test a bit and also checked in new results
  • fast/forms/textarea-scrolled-endline-caret-expected.txt:
  • fast/forms/textarea-scrolled-endline-caret.html:
  • fixed a test that was raising an exception every time it ran
  • fast/forms/attributed-strings-expected.txt:
  • fast/forms/attributed-strings.html:
  • corrected checksums on a bunch of tests (pngs were right, but checksums wrong, apparently)
  • editing/deleting/delete-to-select-table-expected.checksum:
  • editing/selection/3690719-expected.checksum:
  • editing/selection/clear-selection-expected.checksum:
  • editing/undo/undo-misspellings-expected.checksum:
  • added some missing pixel test results
  • editing/pasteboard/nested-blocks-with-text-area-expected.checksum: Added.
  • editing/pasteboard/nested-blocks-with-text-area-expected.png: Added.
  • editing/pasteboard/nested-blocks-with-text-field-expected.checksum: Added.
  • editing/pasteboard/nested-blocks-with-text-field-expected.png: Added.

WebCore:

Reviewed by Adele and Justin.

Test: fast/forms/textarea-type-spaces.html
Test: fast/forms/textarea-paste-newline.html

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument createDocumentFragmentWithText:]): Updated call to pass a range -- in this case it is the range of the entire document, so this will not handle the whitespace properly.
  • bridge/mac/WebCoreFrameBridge.h: Added range context parameter to the documentFragmentWithText: method, so we can handle whitespace properly.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge nodesFromList:]): Changed from DeprecatedPtrList to Vector. (-[WebCoreFrameBridge markupStringFromNode:nodes:]): Ditto. (-[WebCoreFrameBridge markupStringFromRange:nodes:]): Ditto. (-[WebCoreFrameBridge documentFragmentWithText:inContext:]): Added range context parameter -- pass it on to createFragmentFromText. (-[WebCoreFrameBridge documentFragmentWithNodesAsParagraphs:]): Changed from DeprecatedPtrList to Vector. (-[WebCoreFrameBridge replaceSelectionWithText:selectReplacement:smartReplace:]): Pass the range of the current selection as context when creating the fragment.
  • dom/Position.cpp: (WebCore::Position::inRenderedText): Replace range check with a call to the new containsCaretOffset function -- helps make the caret work right when it is past the end of the last line in a textarea.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Don't do anything if the style does not call for collapsing whitespace. (WebCore::CompositeEditCommand::rebalanceWhitespace): Call replaceWhitespaceAt to share code, including the new logic mentioned above.
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Use a text node instead of a break element when inserting and the style is preserveNewline.
  • editing/JSEditor.cpp: (WebCore::execRemoveFormat): Pass the selection range to createFragmentFromText.
  • editing/RebalanceWhitespaceCommand.cpp: (WebCore::RebalanceWhitespaceCommand::doApply): Assert that we're in a style that collapses whitespace. It's the caller's responsibility not to call otherwise.
  • editing/ReplaceSelectionCommand.h: Removed unused destructor, type, isSingleTextNode, isTreeFragment, m_type, and added a context parameter to inertFragmentForTestRendering. Also changed the constructor to take a selection rather than a pointer to the root editable element, replaced removeEndBRIfNeeded with shouldRemoveEndBR and removed an unused parameter from shouldMergeEnd.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Removed code to set up m_type. Compute root editable element from passed-in selection. Used the start of the selection as a base node for style purposes for the test rendering. Removed the special case "single text node" alternative to createFragmentFromText in the plain text case, since createFragmentFromText now handles that correctly. (WebCore::ReplacementFragment::insertFragmentForTestRendering): Copy the whitespace property from the source location when creating a temporary element for test rendering. (WebCore::ReplacementFragment::shouldMergeEnd): Removed unneeded boolean parameter fragmentHadInterchangeNewlineAtEnd, which is always false. (WebCore::ReplaceSelectionCommand::doApply): Update for ReplacementFragment changes, change code to not remove end BR when it can be re-used instead, don't call the paragraph separator insertion when the position is at the start of a paragraph already, removed redundant computation of identical "next" value, removed unneeded boolean parameter to shouldMergeEnd, add case for merging when all we need to do is to delete a newline character, removed unneeded code to set insertionPos after all code that uses it, and use spaces instead of non-breaking spaces when doing smart paste if the context is one where we do not collapse white space. (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): Renamed and changed to return a boolean instead of doing the removal.
  • editing/markup.h: Use Vector instead of DeprecatedPtrList. Change the createFragmentFromText function to take a range for context instead of a document.
  • editing/markup.cpp: (WebCore::markup): Use Vector instead of DeprecatedPtrList. (WebCore::createMarkup): Ditto. (WebCore::createParagraphContentsFromString): Remove unneeded document parameter and changed a couple places to use isEmpty instead of comparing with "". (WebCore::createFragmentFromText): Given the new context parameter, if the context is one that preserves newlines, then use "\n" instead of <br> elements. (WebCore::createFragmentFromNodes): Use Vector instead of DeprecatedPtrList.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerText): Do not use <br> elements if the context of this node is one where we preserve newlines.
  • rendering/InlineTextBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::containsCaretOffset): Added. Implements the appropriate rule for determining if a caret position is in this line or not. Returns true for both one line and the next in cases where affinity must be considered to determine which line the caret is on.
  • rendering/RenderText.h: Make atLineWrap no longer be a member function.
  • rendering/RenderText.cpp: (WebCore::atLineWrap): Remove special rule about preserveNewline and isLineBreak, which will no longer apply due to the new containsCaretOffset function logic. (WebCore::RenderText::caretRect): Use containsCaretOffset. (WebCore::RenderText::inlineBox): Ditto.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::updateFromElement): Make a placeholder <br> element after calling setInnerText so that the last newline in the string has the effect we expect outside the HTML world (an additional line). (WebCore::RenderTextControl::setSelectionRange): Set granularity of the selection too. The layout tests caught this problem, which needs a better solution long term. (WebCore::RenderTextControl::text): Call textContent with the parameter false so it will not include newlines for <br> elements. Now the only <br> element that will ever be in the shadow DOM tree is the one to prevent collapsing, and that one should not show up in the text value.
  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Took a rule that specifically called out the pre whitespace mode and made it work for all the modes that preserve newlines. This makes sure we get a last line box for text after the last "\n" even in cases where there is no <br> afterward.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::fixupWhitespace):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Added assertions to make sure we don't do anything when we're not collapsing whitespace.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setDefaultValue): Changed to use Vector instead of DeprecatedPtrList.
  • editing/HTMLInterchange.cpp: Removed obsolete comment.
  • loader/Cache.h: Removed a stray include.

WebKit:

Reviewed by Adele and Justin.

  • update for change to require context when creating fragments from text (needed to handle whitespace properly)
  • WebView/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): Added context parameter, pass through to bridge. (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Pass selection range as context when calling above method. (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Pass drag caret as context when calling above method.
8:40 PM Changeset in webkit [15616] by adele
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Justin.

  • Test for <rdar://problem/4632132> Changing style of content with mixed editability fails
  • editing/style/apple-style-editable-mix-expected.checksum: Added.
  • editing/style/apple-style-editable-mix-expected.png: Added.
  • editing/style/apple-style-editable-mix-expected.txt: Added.
  • editing/style/apple-style-editable-mix.html: Added.

WebCore:

Reviewed by Justin.

  • Fix for <rdar://problem/4632132> Changing style of content with mixed editability fails

Test: * editing/style/apple-style-editable-mix.html

  • dom/Node.cpp: (WebCore::Node::isContentRichlyEditable): Doesn't need to check the editable root. It now just checks the user modify property of its own renderer, since that is inherited.
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): If the end position is in a table, Adjust the end node to the last descendant of the table, so we don't skip over any runs.
8:37 PM Changeset in webkit [15615] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Geoff.


  • WebView/WebLoader.h:
  • WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader receivedError:]): Copy in some code from the base class to do it in the proper order, surrounding the call to [ds _receivedMainResourceError:error complete:YES].
6:11 PM Changeset in webkit [15614] by darin
  • 3 edits
    2 adds in trunk/WebCore

Reviewed by Hyatt.

  • implement String::createCFString
  • WebCore.xcodeproj/project.pbxproj: Added StringImplMac.mm and StringMac.mm.
  • bindings/objc/DOMInternal.mm: Moved NSString conversion functions out of here.
  • platform/mac/StringImplMac.mm: Added. Moved NSString conversion members here and added the CFStringRef ones.
  • platform/mac/StringMac.mm: Added. Ditto.
5:22 PM Changeset in webkit [15613] by thatcher
  • 1 copy in tags/Safari-521.21

New tag.

4:16 PM Changeset in webkit [15612] by hyatt
  • 6 edits in trunk/WebCore

Two bug fixes.

(1) Make sure to mark positioned objects that depend on line position to
mark themselves as needing layout when their line box placeholder gets
repositioned.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::position):


(2) Improve highlighting to factor the inflation into overflow so that
invalidation and repainting will work properly.

  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::addHighlightOverflow):
  • rendering/RootInlineBox.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
3:50 PM Changeset in webkit [15611] by thatcher
  • 2 edits in branches/Safari-521/WebKit

Correcting WebKit versioning.

3:50 PM Changeset in webkit [15610] by andersca
  • 2 edits in trunk/WebKit

2006-07-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim O.

  • Misc/WebIconDatabase.m: (-[WebIconDatabase removeAllIcons]): Make an array of the keys and iterate through it to avoid modifying the dictionary while enumerating it.
3:47 PM Changeset in webkit [15609] by thatcher
  • 4 edits in branches/Safari-521

Versioning

1:55 PM Changeset in webkit [15608] by andersca
  • 1 edit in trunk/WebCore/manual-tests/onsearch-enter.html

Add a newline

1:48 PM Changeset in webkit [15607] by andersca
  • 2 edits
    1 add in trunk/WebCore

2006-07-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adele.

<rdar://problem/4641824> REGRESSION: Wikipedia widget fails to complete a search after pressing return key


  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Don't eat enter events for search fields that have no enclosing form; they need to be passed to AppKit so that onsearch can be invoked.


  • manual-tests/onsearch-enter.html: Added.
1:25 PM Changeset in webkit [15606] by spadma
  • 2 edits in S60/trunk/WebCore
  • bridge/WebCoreBridge.cpp:

(CWebCoreBridge::GetNextRenderTextForSmartLinksL): Fix ref counting of iSmartLinkNode

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10090

12:12 PM Changeset in webkit [15605] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by John and Darin.

<rdar://problem/4634290> Cannot selectively install a custom
scroller that differs from the default Aqua frame size.

Adds two new private methods to WebFrameView that allows
an application to set a custom scroll view class. This is needed
if the application wants to install a custom scroller that is wider
than the typical scroller, because NSScrollView does the content
rect calculations in a class method (ignoring custom scrollers.)
The _setScrollViewClass method requires the class to be a subclass
of WebDynamicScrollBarView, or nil can be passed to reset to the default class.
A new scroll view of the specified class will then replace the previous
one without the need to reload content of the frame.

  • WebView/WebFrameView.m: (-[WebFrameView _customScrollViewClass]): (-[WebFrameView _setCustomScrollViewClass:]):
  • WebView/WebFrameViewPrivate.h:
11:13 AM Changeset in webkit [15604] by brmorris
  • 30 edits
    4 adds in S60/trunk

2006-07-24 brmorris <​bradley.morrison@nokia.com>

Reviewed by Sachin.


Implement Smart Text recognition / context options.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10089

10:26 AM Changeset in webkit [15603] by ap
  • 3 edits
    4 adds in trunk

Fix by Dave MacLachlan, reviewed by Darin and Alexey.


Fix for: <​http://bugzilla.opendarwin.org/show_bug.cgi?id=8425>
and <​http://bugzilla.opendarwin.org/show_bug.cgi?id=6947>

Test: svg/custom/non-opaque-filters.svg

  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::prepareFilter): We create an autorelease pool so we can control the deallocation of the CIContext that we're creating. The CIContext retains the CGContext that you pass it internally so when the CIContext is released, the CGContext is released as well. This is all fine and dandy unless you wrap the creation of the CIFilter with a pair of CGBegin/EndTransparencyLayer calls which swap the context out from underneath you. So if you start with context A, CGBeginTransparencyLayer swaps it out and gives you B. You create a CIFilter with it and add a reference to B. CGEndTransparencyLayer swaps out B and gives you back A. Autorelease pool comes and cleans up the Filter, and calls release on A, but A never got the refcount in the first place. B did. BOOM! So we create a pool, then do a retain, then release the pool so that we don't have to worry about the pool releasing it at a later time. See <rdar://problem/4647735> for reduction of CGEndTransparencyLayer case
9:55 AM Changeset in webkit [15602] by ap
  • 4 edits
    4 adds in trunk

Fix by Mitz Pettel, reviewed by Hyatt.

Test: fast/repaint/line-overflow.html

  • rendering/RenderBlock.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Added repaintTop and repaintBottom variables to track the vertical edges of the area that changed, accounting for lines that were deleted, inserted or moved. Removed unnecessary updating of m_overflowHeight. (WebCore::RenderBlock::determineStartPosition): Removed unnecessary updating of m_overflowHeight. (WebCore::RenderBlock::determineEndPosition): (WebCore::RenderBlock::matchedEndLine): Added repaintTop and repaintBottom arguments, which this method updates to account for deleted lines. (WebCore::RenderBlock::checkLinesForOverflow): Removed outdated FIXME.
9:36 AM Changeset in webkit [15601] by ap
  • 2 edits in trunk

Land the ChangeLogs, too.

9:21 AM Changeset in webkit [15600] by ap
  • 1 edit
    4 adds in trunk

Fix by Mitz Pettel, reviewed by Darin.

Test: fast/forms/select-visual-hebrew.html

  • css/html4.css: Set "-webkit-rtl-ordering: logical" on select elements.
9:03 AM Changeset in webkit [15599] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10060
Improve iExploder results parsing

  • Scripts/run-iexploder-tests: Fix Apach logs parsing to produce a correct results in random mode, too.
8:58 AM Changeset in webkit [15598] by ap
  • 4 edits in trunk

Reviewed by Darin.

Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10009
REGRESSION: Schubert-IT PDF Plug-in not working for full page (works in frames)

No test case possible.

WebCore:

  • page/Frame.cpp: (WebCore::Frame::begin): Give PDF plugins a chance to handle frame content, before ImageDocument claims it.

WebKit:

  • WebView/WebView.m: (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): If we've got a type supported by WebPDFView, make sure to initialize the plugin database, in case a plugin wants to handle it.
8:44 AM Changeset in webkit [15597] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForCoordinates): Added back change from the fix for bug 9312: For coordinates outside a replaced object, return the position just before (after) the element if the coordinates are above or to the left (below or to the right).
8:41 AM Changeset in webkit [15596] by thatcher
  • 2 edits in branches/Safari-521/WebCore

Reviewed by Darin.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForCoordinates): Added back change from the fix for bug 9312: For coordinates outside a replaced object, return the position just before (after) the element if the coordinates are above or to the left (below or to the right).
6:13 AM Changeset in webkit [15595] by rwlbuis
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=4258
Date().toString() only includes GMT offset, not timezone string

Use the info in tm_zone to append timezone abbreviation
to Date().toString().

  • kjs/date_object.cpp: (KJS::formatTime):
4:45 AM Changeset in webkit [15594] by rwlbuis
  • 2 edits
    3 adds in trunk

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5257
setYear() does not match FireFox/IE behavior

Make sure the right values end up in tm_year.

  • kjs/date_object.cpp: (KJS::formatTime):

Jul 23, 2006:

11:06 PM Changeset in webkit [15593] by thatcher
  • 16 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

Bug 9686: [Drosera] Need the ability to break into Drosera on Javascript exceptions
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9686

JavaScriptCore portion of the fix.

  • JavaScriptCore.exp: Update symbol for change in argument type.
  • kjs/debugger.cpp: (Debugger::detach): Clear map of recent exceptions. (Debugger::hasHandledException): Track the most recent exception thrown by an interpreter. (Debugger::exception): Change exception argument to a JSValue.
  • kjs/debugger.h:
  • kjs/nodes.cpp: (Node::debugExceptionIfNeeded): Notify the debugger of an exception if it hasn't seen it before. (ThrowNode::execute): Notify the debugger that an exception is being thrown.
  • kjs/nodes.h:

2006-07-23 Geoffrey Garen <​ggaren@apple.com>

Patch by Eric Albert, reviewed by Darin and me.


  • Fixed <rdar://problem/4645931> JavaScriptCore stack-scanning code crashes (Collector::markStackObjectsConservatively)


  • bindings/jni/jni_jsobject.cpp: On 64bit systems, jint is a long, not an int. (JavaJSObject::getSlot): (JavaJSObject::setSlot):
  • kjs/collector.cpp: (KJS::Collector::markCurrentThreadConservatively): Use a pointer instead of an int as 'dummy,' because on LP64 systems, an int is not pointer-aligned, and we want to scan the stack for pointers.
  • JavaScriptCore.xcodeproj/project.pbxproj: After a tense cease-fire, the XCode war has started up again!

WebCore:

Reviewed by maciej.

Bug 9686: [Drosera] Need the ability to break into Drosera on Javascript exceptions
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9686

WebCore portion of the fix.

  • bridge/mac/WebCoreScriptDebugger.h: (-[WebScriptDebugger exceptionRaised:sourceId:line::]): Add delegate method.
  • bridge/mac/WebCoreScriptDebugger.mm: (WebCoreScriptDebuggerImp::exception): Call delegate method when an exception is raised.

WebKit:

Reviewed by Maciej.

Bug 9686: [Drosera] Need the ability to break into Drosera on Javascript exceptions
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9686

WebKit portion of the fix.

  • DefaultDelegates/WebDefaultScriptDebugDelegate.m: (-[WebDefaultScriptDebugDelegate webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
  • DefaultDelegates/WebScriptDebugServer.h:
  • DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer webView:exceptionWasRaised:sourceId:line:forWebFrame:]): Notify listeners that an exception has been raised.
  • WebView/WebScriptDebugDelegate.h:
  • WebView/WebScriptDebugDelegate.m: (-[WebScriptCallFrame exceptionRaised:sourceId:line:]): Dispatch through to delegate and WebScriptDebugServer.
8:21 PM Changeset in webkit [15592] by thatcher
  • 2 edits in branches/Safari-521/WebCore

Reviewed by Adele.
Actually Adele figured out how to fix the layout test failures. Landing this patch for her. Layout test failures exposed but not caused by r15584 (my patch earlier today).

  • editing/visible_units.cpp: (WebCore::previousLinePosition): When setting selection endpoints, don't traverse down into nodes where editing would ignore its contents. Use the parent node instead. (WebCore::nextLinePosition): same as above
7:53 PM Changeset in webkit [15591] by aliceli1
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by Adele.
Actually Adele figured out how to fix the layout test failures. Landing this patch for her. Layout test failures exposed but not caused by r15584 (my patch earlier today).

  • editing/visible_units.cpp: (WebCore::previousLinePosition): When setting selection endpoints, don't traverse down into nodes where editing would ignore its contents. Use the parent node instead. (WebCore::nextLinePosition): same as above
7:51 PM Changeset in webkit [15590] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Adele.
Actually Adele figured out how to fix the layout test failures. Landing this patch for her.

  • editing/visible_units.cpp: (WebCore::previousLinePosition): When setting selection endpoints, don't traverse down into nodes where editing would ignore its contents. Use the parent node instead. (WebCore::nextLinePosition): same as above
7:43 PM Changeset in webkit [15589] by thatcher
  • 13 edits
    4 deletes in branches/Safari-521

Rolling out CCC denied changes. r15553, r15536, r15529, r15455 and r15435.

6:41 PM Changeset in webkit [15588] by thatcher
  • 5 copies in branches/Safari-521

New branch

5:16 PM Changeset in webkit [15587] by harrison
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by timo.

<rdar://problem/4646759> Mail crash editing To Do - WebCore::InsertTextCommand::prepareForTextInsertion

  • editing/deleting/delete-mixed-editable-content-001-expected.checksum: Added.
  • editing/deleting/delete-mixed-editable-content-001-expected.png: Added.
  • editing/deleting/delete-mixed-editable-content-001-expected.txt: Added.
  • editing/deleting/delete-mixed-editable-content-001.html: Added.

WebCore:

Reviewed by timo.

<rdar://problem/4646759> Mail crash editing To Do - WebCore::InsertTextCommand::prepareForTextInsertion


  • Test: editing/deleting/delete-mixed-editable-content-001.html
  • editing/visible_units.cpp: (WebCore::startOfParagraph): Respect editable boundary the same way endOfParagraph does.
4:40 PM Changeset in webkit [15586] by adele
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • Fix for <rdar://problem/4646276> CrashTracer: 7 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::paint + 155
  • WebView/WebHTMLView.m: (-[WebHTMLView _web_layoutIfNeededRecursive:testDirtyRect:]): needsDisplay was returning NO even though the view has a dirty rect (see <rdar://problem/4647062>). Since we know about the dirty rect, we don't actually need to check needsDisplay.
4:36 PM Changeset in webkit [15585] by bdakin
  • 7 edits in trunk/WebCore

Reviewed by Maciej. (Patch by me, Maciej, and Harrison.)

Fix for <rdar://problem/4529398> WebCore crashes when pasting rich
text - WebCore::InlineBox::root()

The initial rendering crash was due to a render object having a
stale reference to an inline box that had already been deleted and
then recreated in the exact same location in memory. (Crazy, I
know.) The situation seemed pretty specific to list markers
according to Hyatt according to Maciej, so that is what I patched
specifically. Fixing this crash unearthed a separate editing crash
where we were trying to insert a block into itself. I worked on
that with Maciej and Harrison, and Harrison came up with a fix.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): This is the fix for the editing crash. If paragraphStart is an atomic node, insert the new block into the parent instead.
  • rendering/InlineBox.cpp: (WebCore::InlineBox::isChildOfParent): This function is for posterity. It will help keep the linebox tree in check.
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::addToLine): Added assert. (WebCore::InlineFlowBox::deleteLine): Added assert.
  • rendering/ListMarkerBox.cpp: (WebCore::ListMarkerBox::destroy): If this has a parent, call removeChild on this. (WebCore::ListMarkerBox::operator delete):
  • rendering/ListMarkerBox.h:
4:17 PM Changeset in webkit [15584] by aliceli1
  • 4 edits in trunk/WebCore

Reviewed by Darin.

fixed <rdar://problem/4617841> REGRESSION (NativeTextField): You can move keyboard focus to a field without getting insertion point

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForCoordinates): removed some unnecessary vertical position checks and added a fudge factor to be more forgiving for clicks near lines.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::nodeAtPoint): added implementation
  • rendering/RenderTextControl.h: added function protocol
2:59 PM Changeset in webkit [15583] by ggaren
  • 4 edits in trunk/JavaScriptCore

2006-07-23 Geoffrey Garen <​ggaren@apple.com>

Patch by Eric Albert, reviewed by Darin and me.


  • Fixed <rdar://problem/4645931> JavaScriptCore stack-scanning code crashes (Collector::markStackObjectsConservatively)


  • bindings/jni/jni_jsobject.cpp: On 64bit systems, jint is a long, not an int. (JavaJSObject::getSlot): (JavaJSObject::setSlot):
  • kjs/collector.cpp: (KJS::Collector::markCurrentThreadConservatively): Use a pointer instead of an int as 'dummy,' because on LP64 systems, an int is not pointer-aligned, and we want to scan the stack for pointers.
  • JavaScriptCore.xcodeproj/project.pbxproj: After a tense cease-fire, the XCode war has started up again!
10:28 AM Changeset in webkit [15582] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Updating fix from last checkin.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox): Only tell the view about this flexbox if there isn't another flexbox already cached.
1:52 AM Changeset in webkit [15581] by adele
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for: <rdar://problem/4644614> REGRESSION: Typing, pasting or dragging in new text areas causes unnecessary scrolling

  • fast/forms/textarea-scrolled-type-expected.checksum: Added.
  • fast/forms/textarea-scrolled-type-expected.png: Added.
  • fast/forms/textarea-scrolled-type-expected.txt: Added.
  • fast/forms/textarea-scrolled-type.html: Added.

WebCore:

Reviewed by Maciej.

  • Fix for <rdar://problem/4644614> REGRESSION: Typing, pasting or dragging in new text areas causes unnecessary scrolling
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Don't updateScrollInfoAfterLayout if an ancestor flexible box is just on its first layout.
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): ditto. (WebCore::RenderFlexibleBox::layoutVerticalBox): Let the view know if this flex box is doing its first pass at layout.
  • rendering/RenderView.cpp: (WebCore::RenderView::RenderView): Caches a flexible box that's doing its first layout.
  • rendering/RenderView.h: (WebCore::RenderView::setFlexBoxInFirstLayout): (WebCore::RenderView::flexBoxInFirstLayout):
Note: See TracTimeline for information about the timeline view.