Timeline



Aug 6, 2006:

11:10 PM Changeset in webkit [15810] by thatcher
  • 5 edits in trunk

Fixing the build for the newer Bison and our new use of -Wundef. Turns off -Wundef for WebKit because <CoreGraphics/CGBase.h> causes a warning we can't fix. We can turn it back on once this radar is fixed: <rdar://problem/4669823> CGBase.h fails to build with -Wundef enabled.

Aug 5, 2006:

4:53 PM Changeset in webkit [15809] by darin
  • 3 edits in trunk/WebCore

Reviewed by Eric Seidel.

  • fix a storage leak
  • rendering/RenderView.cpp: (WebCore::RenderView::setSelection): Delete the values if we are going to exit without using the maps. Otherwise all the values leak.
1:14 PM Changeset in webkit [15808] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/frames/iframe-option-crash-expected.checksum: Added.
  • fast/frames/iframe-option-crash-expected.png: Added.
  • fast/frames/iframe-option-crash-expected.txt: Added.
  • fast/frames/iframe-option-crash.xhtml: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/frames/iframe-option-crash.xhtml

  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations): Check for a nil renderer.

Aug 4, 2006:

4:27 PM Changeset in webkit [15807] by hyatt
  • 2 edits in trunk/WebCore

Fix for Radar bug #4644045, regression where dragging selection no longer
works for floats contained inside layers. I added an optimization to
refine dirty rect checking for layers, and it incorrectly excluded floats
from the paint bounds since PaintPhaseSelection was not considered when
analyzing the floatRect().

Reviewed by beth

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint):
4:19 PM Changeset in webkit [15806] by hyatt
  • 5 edits in trunk/WebCore

Fix remove() so that it is equivalent to calling removeChild on the
parent. This involved moving three operations that remove did.

(1) Move the accessibility object cache removal into the destroy methods,
since this really should just happen when a render object is going away.

(2) removeFromObjectLists shifted into removeChild, which means it will
now be called more often (this is a correct change). Note that there is
also now a new guard on removeFromObjectLists so that it won't do any
work unless the document is not being destroyed.

(3) The big one. deleteLineBoxWrapper was not getting called to clean up
the line box tree. This moved right into RenderContainer's removeChildNode so
that it is now done even in the lowest level RenderContainer removal primitive.

Reviewed by beth

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::removeChild):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::removeFromObjectLists): (WebCore::RenderObject::destroy):
  • rendering/RenderObject.h: (WebCore::RenderObject::remove):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):
4:03 PM Changeset in webkit [15805] by bdakin
  • 7 edits in branches/Safari-2-0-branch/WebCore

Reviewed by me/Hyatt.

Mostly this is merging over Hyatt's fix with r15801. Some other
things needed to be tweaked though. This is a better fix for
<rdar://problem/4541255> Safari hangs at ​http://www.kutilek.de/
safari-test/ somewhere from
WebCore::RenderBlock::layoutInlineChildren(bool)

  • khtml/rendering/render_box.cpp: (RenderBox::deleteLineBoxWrapper): Call remove.
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_list.cpp: (RenderListItem::updateMarkerLocation): Call remove.
  • khtml/rendering/render_list.h: (khtml::ListMarkerBox:::InlineBox):
  • khtml/rendering/render_object.cpp: Back out old fix. (RenderObject::remove):
  • khtml/rendering/render_object.h: Back out old fix.
2:13 PM Changeset in webkit [15804] by brmorris
  • 13 edits
    2 adds in S60/trunk

2006-08-04 yaharon <​yael.aharon@nokia.com>

Reviewed by Zalan, Yongjun and Steve.

Handle pointer events in WebKit

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10250

  • ChangeLog:
  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::MouseDown):
  • kwq/KWQWidget.cpp: (QWidget::focusPolicy):
2:12 PM Changeset in webkit [15803] by beidson
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff's rubber stamp

Fix a build break on Intel hardware causes by adapting stricter
compiler warnings (-Wshorten-64-to-32)

  • API/testapi.c: (assertEqualsAsNumber): manually cast some doubles to floats (main): ditto
2:04 PM Changeset in webkit [15802] by hyatt
  • 4 adds in trunk/LayoutTests/fast/lists

Add layout test for list marker crash

2:04 PM Changeset in webkit [15801] by hyatt
  • 4 edits in trunk/WebCore

Back out the fix for list marker crashes. The actual bug here is that
there is a confusing mismatch between remove() and removeChild() in the
render tree. remove() does a little bit of extra work that removeChild
should be doing instead (so that remove() can just be a shorthand for
removeChild).

This conservative fix does not solve the remove/removeChild mismatch
but instead just changes the list marker updating code to use remove
instead.

Reviewed by beth

Test Case: fast/lists/dynamic-marker-crash.html

  • rendering/ListMarkerBox.cpp:
  • rendering/ListMarkerBox.h:
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::updateMarkerLocation):
1:52 PM Changeset in webkit [15800] by brmorris
  • 1 copy in S60/tags/s60-RnD-06wk31

Tagging S60 RnD release 2006w31

11:57 AM Changeset in webkit [15799] by weinig
  • 30 edits in trunk

JavaScriptCore:

Reviewed by Darin.

  • Adds -Wshorten-64-to-32 flag to Xcode project.
  • Adds explicit casts where OK.
  • API/JSNodeList.c: (JSNodeList_item): (JSNodeList_getProperty):
  • JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

Reviewed by Darin.

  • Adds -Wshorten-64-to-32 flag to Xcode project.
  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Darin.

  • Adds -Wshorten-64-to-32 flag to Xcode project.
  • Adds 'f' to float literals where expecting a float.
  • Use cosf() instead of cos() when assigning to a float.
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/device/quartz/filters/WKDiffuseLightingFilter.m: (+[WKDiffuseLightingFilter initialize]):
  • kcanvas/device/quartz/filters/WKDiscreteTransferFilter.m: (-[WKDiscreteTransferFilter outputImage]):
  • kcanvas/device/quartz/filters/WKDisplacementMapFilter.m: (+[WKDisplacementMapFilter initialize]):
  • kcanvas/device/quartz/filters/WKSpecularLightingFilter.m: (+[WKSpecularLightingFilter initialize]):
  • kcanvas/device/quartz/filters/WKSpotLightFilter.m: (-[WKSpotLightFilter outputImage]):
  • kcanvas/device/quartz/filters/WKTableTransferFilter.m: (-[WKTableTransferFilter outputImage]):

WebKit:

Reviewed by Darin.

  • Adds 'f' to float literals where expecting a float.
  • Use ceilf() instead of ceil() when assigning to a float.
  • Adds explicit casts where OK.


NOTE: The -Wshorten-64-to-32 flag was not added for WebKit
because there are still a few places where no error handling
is in place. The flag can be added as soon as those are worked
out.

  • Misc/WebNSControlExtras.m: (-[NSControl sizeToFitAndAdjustWindowHeight]):
  • Misc/WebNSImageExtras.m: (-[NSImage _web_scaleToMaxSize:]):
  • Misc/WebNSViewExtras.h:
  • Misc/WebNSViewExtras.m:
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView drawRect:]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge expiresTimeForResponse:]):
  • WebInspector/WebInspector.m: (-[NSWindow window]): (-treeViewScrollTo:): (-_updateSystemColors): (-webView:plugInViewWithArguments:): (-outlineView:objectValueForTableColumn:byItem:):
  • WebInspector/WebInspectorOutlineView.m: (-[WebInspectorOutlineView _highlightRow:clipRect:]):
  • WebInspector/WebNodeHighlight.m: (-[WebNodeHighlight initWithBounds:andRects:forView:]):
  • WebInspector/WebNodeHighlightView.m: (-[WebNodeHighlightView roundedRect:withRadius:]): (-[WebNodeHighlightView initWithHighlight:andRects:forView:]): (-[WebNodeHighlightView drawRect:]):
  • WebView/WebFrame.m: (-[WebFrame _opened]):
  • WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]):
  • WebView/WebHTMLView.m: (-[WebHTMLView _dragImageForLinkElement:]): (-[WebHTMLView _web_setPrintingModeRecursive]): (-[WebHTMLView _web_clearPrintingModeRecursive]): (-[NSArray layout]): (-[NSArray _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]): (-[NSArray adjustPageHeightNew:top:bottom:limit:]): (-[NSArray _scaleFactorForPrintOperation:]): (-[NSArray setPageWidthForPrinting:]): (-[NSArray _endPrintMode]): (-[NSArray knowsPageRange:]): (-[NSArray _originalFontA]): (-[NSArray _originalFontB]): (-[WebTextCompleteController _buildUI]): (-[WebTextCompleteController _placePopupWindow:]):
  • WebView/WebPDFView.m: (-[WebPDFView _makeTextStandardSize:]): (-[WebPDFView selectionImageForcingWhiteText:]): (-[PDFPrefUpdatingProxy forwardInvocation:]):
  • WebView/WebPreferences.m: (-[WebPreferences _floatValueForKey:]):
  • WebView/WebView.m: (-[WebView makeTextSmaller:]): (-[WebView canMakeTextStandardSize]): (-[WebView makeTextStandardSize:]):
9:55 AM Changeset in webkit [15798] by aroben
  • 2 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Convert spaces to tabs
7:09 AM Changeset in webkit [15797] by zbujtas
  • 2 edits in S60/trunk/WebKit

2006-08-03 bujtas <​zbujtas@gmail.com>

Reviewed by Yongjun

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10244

Fix null pointer crash.


  • ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::HandleDMgrCompletedEventL): (CHttpDownloadObserver::FindDownloadL):
4:23 AM Changeset in webkit [15796] by ddkilzer
  • 1 edit
    6 copies in trunk/WebKit

WebKit:

Reviewed by NOBODY (build fix).

  • WebCoreSupport/WebSubresourceLoader.m: REALLY moved to Loader/
  • WebView/WebFrameLoader.h: REALLY moved to Loader/
  • WebView/WebFrameLoader.m: REALLY moved to Loader/
  • WebView/WebLoader.h: REALLY moved to Loader/
  • WebView/WebLoader.m: REALLY moved to Loader/
  • WebView/WebMainResourceLoader.m: REALLY moved to Loader/

Aug 3, 2006:

10:41 PM Changeset in webkit [15795] by hyatt
  • 2 edits in trunk/WebCore

Minor tweak to earlier patch. Use containsFloats instad.

10:35 PM Changeset in webkit [15794] by mjs
  • 3 edits
    2 moves
    3 adds
    6 deletes in trunk/WebKit

Reviewed by Darin.


  • moved all loader code that is slated to be moved down to WebCore to a new Loader directory


(next step is to remove dependencies on the rest of WebKit from this directory)

  • Loader/WebNetscapePlugInStreamLoader.h: Added.
  • Loader/WebNetscapePlugInStreamLoader.m: Added. Cut out of WebNetscapePluginStream.m (-[WebNetscapePlugInStreamLoader initWithStream:view:]): (-[WebNetscapePlugInStreamLoader isDone]): (-[WebNetscapePlugInStreamLoader releaseResources]): (-[WebNetscapePlugInStreamLoader didReceiveResponse:]): (-[WebNetscapePlugInStreamLoader didReceiveData:lengthReceived:]): (-[WebNetscapePlugInStreamLoader didFinishLoading]): (-[WebNetscapePlugInStreamLoader didFailWithError:]): (-[WebNetscapePlugInStreamLoader cancelWithError:]):
  • Plugins/WebNetscapePluginStream.m:
  • WebKit.xcodeproj/project.pbxproj:
  • WebCoreSupport/WebSubresourceLoader.h: Moved to Loader/
  • WebCoreSupport/WebSubresourceLoader.m: Moved to Loader/
  • WebView/WebFrameLoader.h: Moved to Loader/
  • WebView/WebFrameLoader.m: Moved to Loader/
  • WebView/WebLoader.h: Moved to Loader/
  • WebView/WebLoader.m: Moved to Loader/
  • WebView/WebMainResourceLoader.h: Moved to Loader/
  • WebView/WebMainResourceLoader.m: Moved to Loader/
7:08 PM Changeset in webkit [15793] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker.

<rdar://problem/4667460> Windowless OpenGL plug-ins render incorrectly on PowerPC

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]): Fixed color component swapping so that it works on both x86 and PPC. See comments.
6:38 PM Changeset in webkit [15792] by hyatt
  • 4 adds in trunk/LayoutTests/fast/block/float
6:35 PM Changeset in webkit [15791] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 10229, don't bother trying to clear when no floats are
present. I suspect there's still a bug in the math that follows, but
this fix is safer in that it just does the obvious thing (and doesn't
compute any clearance if no floats are even around).

Reviewed by maciej

  • ChangeLog:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::getClearDelta):
5:42 PM Changeset in webkit [15790] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


  • editing/style/non-inheritable-styles-expected.checksum: Added.
  • editing/style/non-inheritable-styles-expected.png: Added.
  • editing/style/non-inheritable-styles-expected.txt: Added.
  • editing/style/non-inheritable-styles.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4641033/4515463/4052426/4046570/4053718/4053724/4060115/4062858>
Copy/Paste fidelity was bad.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle):
  • editing/markup.cpp: (WebCore::startMarkup): We were not adding non-inheritable styles to the markup for an element unless they were in the elements inline style declaration.
5:37 PM Changeset in webkit [15789] by beidson
  • 1 edit in trunk/WebKit/ChangeLog

Cleaned up the ChangeLog from last checkin

5:00 PM Changeset in webkit [15788] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher's rubber stamp
Fixed Intel build break caused by weinig's -W change in r15781

  • WebView/WebView.m: wrapped cpu-dependent defs with defined() macro
3:58 PM Changeset in webkit [15787] by mjs
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed problem that could cause assertion failures in Safari


  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): Don't allow a plugin to start new loads once its document is no longer the one actively loading.
3:48 PM Changeset in webkit [15786] by brmorris
  • 3 edits in S60/trunk/WebKit

Rolling out r15783 which introduced a new, unwanted dependency. This patch needs to be re-thought.

3:35 PM Changeset in webkit [15785] by zbujtas
  • 2 edits in S60/trunk/JavaScriptCore

2006-08-03 bujtas <​zbujtas@gmail.com>

Reviewed by Yongjun.

fix hashtable crash in case of oom


  • kjs/identifier.cpp: (KJS::Identifier::rehash):
3:33 PM Changeset in webkit [15784] by mjs
  • 14 edits in trunk/WebKit

Reviewed by John.


  • remove use of WebDataSource from WebLoader and subclasses, just have them talk to the WebFrameLoader instead.


For now this is done by forarding all the calls.

  • Misc/WebIconLoader.m: (-[WebIconLoader didFinishLoading]):
  • Plugins/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]): (-[WebNetscapePluginStream start]): (-[WebNetscapePlugInStreamLoader didFinishLoading]): (-[WebNetscapePlugInStreamLoader didFailWithError:]): (-[WebNetscapePlugInStreamLoader cancelWithError:]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
  • WebCoreSupport/WebSubresourceLoader.h:
  • WebCoreSupport/WebSubresourceLoader.m: (-[WebSubresourceLoader initWithLoader:frameLoader:]): (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]): (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forFrameLoader:]): (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forFrameLoader:]): (-[WebSubresourceLoader receivedError:]): (-[WebSubresourceLoader signalFinish]): (-[WebSubresourceLoader didFailWithError:]): (-[WebSubresourceLoader cancel]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSource _updateLoading]): (-[WebDataSource textEncodingName]): (-[WebDataSource _mainReceivedBytesSoFar:complete:]):
  • WebView/WebFrameLoader.h:
  • WebView/WebFrameLoader.m: (-[WebFrameLoader loadIconWithRequest:]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader clearIconLoader]): (-[WebFrameLoader commitProvisionalLoad]): (-[WebFrameLoader activeDataSource]): (-[WebFrameLoader _archivedSubresourceForURL:]): (-[WebFrameLoader _defersCallbacks]): (-[WebFrameLoader _identifierForInitialRequest:]): (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]): (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _didReceiveData:contentLength:forResource:]): (-[WebFrameLoader _didFinishLoadingForResource:]): (-[WebFrameLoader _didFailLoadingWithError:forResource:]): (-[WebFrameLoader _privateBrowsingEnabled]): (-[WebFrameLoader _addPlugInStreamLoader:]): (-[WebFrameLoader _removePlugInStreamLoader:]): (-[WebFrameLoader _finishedLoadingResource]): (-[WebFrameLoader _receivedError:]): (-[WebFrameLoader _addSubresourceLoader:]): (-[WebFrameLoader _removeSubresourceLoader:]): (-[WebFrameLoader _originalRequest]): (-[WebFrameLoader webFrame]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader initialRequest]): (-[WebFrameLoader _receivedData:]): (-[WebFrameLoader _setRequest:]): (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]): (-[WebFrameLoader _handleFallbackContent]): (-[WebFrameLoader _isStopping]): (-[WebFrameLoader _decidePolicyForMIMEType:decisionListener:]): (-[WebFrameLoader _setupForReplaceByMIMEType:]): (-[WebFrameLoader _setResponse:]): (-[WebFrameLoader _mainReceivedError:complete:]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader _mainReceivedBytesSoFar:complete:]): (-[WebFrameLoader _iconLoaderReceivedPageIcon:]): (-[WebFrameLoader _URL]):
  • WebView/WebLoader.h:
  • WebView/WebLoader.m: (-[NSURLProtocol releaseResources]): (-[NSURLProtocol loadWithRequest:]): (-[NSURLProtocol setFrameLoader:]): (-[NSURLProtocol frameLoader]): (-[NSURLProtocol willSendRequest:redirectResponse:]): (-[NSURLProtocol didReceiveAuthenticationChallenge:]): (-[NSURLProtocol didCancelAuthenticationChallenge:]): (-[NSURLProtocol didReceiveResponse:]): (-[NSURLProtocol didReceiveData:lengthReceived:]): (-[NSURLProtocol signalFinish]): (-[NSURLProtocol didFailWithError:]): (-[NSURLProtocol willCacheResponse:]): (-[NSURLProtocol cancelWithError:]):
  • WebView/WebMainResourceLoader.h:
  • WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader initWithFrameLoader:]): (-[WebMainResourceLoader receivedError:]): (-[WebMainResourceLoader cancelWithError:]): (-[WebMainResourceLoader _isPostOrRedirectAfterPost:redirectResponse:]): (-[WebMainResourceLoader addData:]): (-[WebMainResourceLoader willSendRequest:redirectResponse:]): (-[WebMainResourceLoader continueAfterContentPolicy:response:]): (-[WebMainResourceLoader continueAfterContentPolicy:]): (-[WebMainResourceLoader checkContentPolicyForResponse:]): (-[WebMainResourceLoader didReceiveResponse:]): (-[WebMainResourceLoader didReceiveData:lengthReceived:]): (-[WebMainResourceLoader didFinishLoading]): (-[WebMainResourceLoader didFailWithError:]): (-[WebMainResourceLoader loadWithRequestNow:]):
3:12 PM Changeset in webkit [15783] by brmorris
  • 3 edits in S60/trunk/WebKit

2006-08-03 spaltis

Reviewed Yongjun.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10237

Unfinished download should be visible in the download list,
before connection is established.

  • ResourceLoader/inc/HttpDownloadObserver.h:
  • ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::~CHttpDownloadObserver): (CHttpDownloadObserver::ConstructL): (CHttpDownloadObserver::DlMgrInitCB): (CHttpDownloadObserver::InitDownloadMgrL): (CHttpDownloadObserver::HandleDMgrEventL): (CHttpDownloadObserver::HandleDMgrCompletedEventL):
3:03 PM Changeset in webkit [15782] by brmorris
  • 3 edits in S60/trunk/WebKit

2006-08-03 ligman <​joseph.ligman@nokia.com>

Reviewed by Yongjun.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10241


The browser engine opens same database 9 times in CFaviconHandler during startup
CFaviconHandler has only one instance. Open the database in ConstructL
and close it when the object is deleted.

  • BrowserCore/Misc/inc/Favicon.h:
  • BrowserCore/Misc/src/Favicon.cpp: (CFaviconHandler::NewL): (CFaviconHandler::CFaviconHandler): (CFaviconHandler::ConstructL): (CFaviconHandler::~CFaviconHandler): (CFaviconHandler::SetFaviconL): (CFaviconHandler::InsertFaviconL): (CFaviconHandler::GetFaviconL): (CFaviconHandler::OpenDatabaseL): (CFaviconHandler::DeleteFaviconL): (CFaviconHandler::UpdateTimeL): (CFaviconHandler::CreateDatabaseL): (CFaviconHandler::ExtractDomainL):
2:55 PM Changeset in webkit [15781] by weinig
  • 94 edits in trunk

JavaScriptCore:

Reviewed by Darin.

  • Adds -Wundef flag to Xcode project
  • Converts #ifs to #ifdef and #ifndefs where needed.
  • Added #define YYMAXDEPTH 10000 in kjs/grammar.y to fix a warning from within Bison.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::getSlot): (JavaJSObject::setSlot):
  • bindings/npapi.h:
  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::methodsNamed): (KJS::Bindings::ObjcClass::fieldNamed):
  • bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod):
  • bindings/objc/objc_runtime.mm: (ObjcMethod::getMethodSignature): (ObjcField::name): (ObjcField::type):
  • kjs/grammar.y:
  • kjs/identifier.h:

JavaScriptGlue:

Reviewed by Darin.

  • Adds -Wundef flag to Xcode project
  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Darin.

  • Adds -Wundef flag to Xcode project
  • Converts #ifs to #ifdef and #ifndefs where needed.
  • Replaces #ifdef WIN32 with #if PLATFORM(WIN_OS) or PLATFORM(WIN) (and in one instance in config.h with #if !COMPILER(MSVC))
  • Added #define YYMAXDEPTH 10000 in XPathGrammar.y and CSSGrammar.y to fix a warning from within Bison.
  • Cleaned up style a little in surrounding code.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
  • config.h:
  • css/CSSGrammar.y:
  • css/MediaFeatureNames.cpp:
  • css/MediaFeatureNames.h:
  • css/cssparser.cpp:
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::setActive):
  • dom/Element.cpp: (WebCore::Element::attach):
  • dom/Element.h:
  • dom/EventNames.cpp:
  • dom/EventNames.h:
  • dom/NamedAttrMap.h:
  • dom/Position.cpp:
  • dom/QualifiedName.cpp:
  • dom/QualifiedName.h:
  • dom/Range.h:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::error):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::continueProcessing): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::timerFired): (WebCore::HTMLTokenizer::notifyFinished):
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/css/SVGRenderStyleDefs.h:
  • ksvg2/scripts/make_names.pl:
  • loader/CachedResource.h:
  • loader/LoaderFunctions.h:
  • loader/loader.h:
  • page/Frame.cpp:
  • page/FrameTree.cpp:
  • page/FrameView.cpp: (WebCore::FrameView::clear): (WebCore::FrameView::layout): (WebCore::FrameView::layoutTimerFired): (WebCore::FrameView::scheduleRelayout): (WebCore::FrameView::unscheduleRelayout):
  • platform/AtomicString.cpp:
  • platform/AtomicString.h:
  • platform/Cursor.h:
  • platform/DeprecatedArray.h:
  • platform/DeprecatedString.cpp: (WebCore::allocateHandle): (WebCore::initializeHandleNodeBlock): (WebCore::freeHandle):
  • platform/FloatPoint.h:
  • platform/FloatRect.h:
  • platform/FloatSize.h:
  • platform/GraphicsContext.h:
  • platform/Image.h:
  • platform/IntPoint.h:
  • platform/IntRect.h: (WebCore::IntRect::inflateX): (WebCore::IntRect::inflateY):
  • platform/IntSize.h:
  • platform/PlatformKeyboardEvent.h:
  • platform/PlatformMouseEvent.h:
  • platform/PlatformString.h:
  • platform/ResourceLoader.h:
  • platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  • platform/ScrollView.h:
  • platform/StaticConstructors.h:
  • platform/StreamingTextDecoderICU.cpp: (WebCore::StreamingTextDecoderICU::convert):
  • platform/StringImpl.h:
  • platform/Widget.h:
  • platform/mac/BlockExceptions.mm:
  • platform/mac/ColorMac.mm: (+[WebCoreControlTintObserver WebCore]):
  • platform/mac/FloatPointMac.mm:
  • platform/mac/FloatRectMac.mm:
  • platform/mac/FloatSizeMac.mm:
  • platform/mac/FontMac.mm:
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawFocusRing):
  • platform/mac/IntPointMac.mm:
  • platform/mac/IntRectMac.mm:
  • platform/mac/IntSizeMac.mm:
  • platform/mac/WebCoreSystemInterface.h:
  • rendering/RenderBlock.h:
  • rendering/RenderTableCell.h:
  • rendering/bidi.cpp: (WebCore::appendRun): (WebCore::RenderBlock::layoutInlineChildren):
  • xml/XSLTProcessor.cpp: (WebCore::parseErrorFunc):
  • xpath/impl/XPathGrammar.y:

WebKit:

Reviewed by Darin.

  • Adds -Wundef flag to Xcode project
  • Converts #ifs to #ifdef and #ifndefs where needed.
  • Carbon/CarbonUtils.m:
  • Carbon/CarbonWindowAdapter.m:
  • Carbon/HIViewAdapter.m: (+[NSView bindHIViewToNSView:nsView:]):
  • Carbon/HIWebView.m: (HIWebViewEventHandler):
  • Misc/WebFileDatabase.m: (UniqueFilePathForKey):
  • Misc/WebNSWindowExtras.m: (swizzleInstanceMethod):
  • Misc/WebTypesInternal.h:
  • Plugins/WebNetscapeDeprecatedFunctions.c:
  • Plugins/WebNetscapeDeprecatedFunctions.h:
  • Plugins/WebNetscapePluginPackage.h:
  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage unloadWithoutShutdown]): (-[WebNetscapePluginPackage load]):
  • WebKit.xcodeproj/project.pbxproj:
1:25 PM Changeset in webkit [15780] by justing
  • 3 edits in trunk/LayoutTests

Reviewed by darin

  • fast/forms/plaintext-mode-1-expected.txt:
  • fast/forms/plaintext-mode-1.html:
1:13 PM Changeset in webkit [15779] by zbujtas
  • 4 edits in S60/trunk/WebKit

2006-08-03 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10008


Fix pending resource loading.


  • BrowserView/inc/WebKitLoader.h:
  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::CreateAsyncCancelHandleL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::StartLoadingResource):
12:51 PM Changeset in webkit [15778] by brmorris
  • 4 edits in S60/trunk/WebKit

2006-08-02 ligman <​joseph.ligman@nokia.com>

Reviewed by Yongjun.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9667

The SetClientResolvesUrl setting was not set when pages were loaded.
If the ResolveLinkL callback failed to handle the link the transaction was canceled
before it was added to the queue and a crash would occur. I delay the cancel by
putting it into a callback.


  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • ResourceLoader/inc/BufferTransaction.h:
  • ResourceLoader/src/BufferTransaction.cpp: (CBufferTransaction::CancelTransactionCB): (CBufferTransaction::~CBufferTransaction): (CBufferTransaction::DoSubmitL): (CBufferTransaction::HandleClientDataChunkL):
12:33 PM Changeset in webkit [15777] by andersca
  • 2 edits in trunk/JavaScriptCore

2006-08-03 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John Sullivan.

  • wtf/HashSet.h: (WTF::::operator): Return *this in operator=
12:29 PM Changeset in webkit [15776] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Maciej and Beth.

Fix use-after-dispose heap corruption bug.

  • rendering/ListMarkerBox.cpp: (WebCore::ListMarkerBox::destroy): Only call removeChild if we're not destroying the document
12:19 PM Changeset in webkit [15775] by brmorris
  • 2 edits in S60/trunk/WebKit

2006-08-03 vbradley <​vincent.bradley@nokia.com>

Reviewed by Yongjun & Sriram

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10215


Changes the cursor to correct image when loading a new page and was
was displaying the waiting cursor.

  • BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CursorUpdate): (CWebKitCursor::SetWaitCursor):
12:18 PM Changeset in webkit [15774] by aroben
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Anders.

  • Fixed Windows build
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • wtf/MathExtras.h: Implement inline versions of these functions (nextafter): (nextafterf):

WebCore:

Reviewed by Anders.

  • Fixed Windows build.
  • platform/Color.cpp: (WebCore::makeRGBAFromHSLA): Whitespace change
  • platform/win/TemporaryLinkStubs.cpp: Add new method stubs (PlatformScrollBar::PlatformScrollBar): (PlatformScrollBar::~PlatformScrollBar): (PlatformScrollBar::width): (PlatformScrollBar::height): (PlatformScrollBar::setEnabled): (PlatformScrollBar::paint): (PlatformScrollBar::setScrollBarValue): (PlatformScrollBar::setKnobProportion): (PlatformScrollBar::setRect): (ScrollBar::ScrollBar): (ScrollBar::scroll): (ScrollBar::setValue):
11:48 AM Changeset in webkit [15773] by brmorris
  • 2 edits in S60/trunk/WebKit

2006-08-03 ligman <​joseph.ligman@nokia.com>

Reviewed by Yongjun.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10231


FocusElementType is incosistent in tabbed view.
Resolved by setting the current focus element type prior to
calling TabbedNavigation in CKeyEventHandler::NavigateWithCursor which
will reset the focus element type.

  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::NavigateWithCursor):
11:04 AM Changeset in webkit [15772] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by mjs

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=10225>
GMail Editor: Change Hilite Color doesn't work

  • editing/execCommand/hilitecolor-expected.checksum: Added.
  • editing/execCommand/hilitecolor-expected.png: Added.
  • editing/execCommand/hilitecolor-expected.txt: Added.
  • editing/execCommand/hilitecolor.html: Added.

WebCore:

Reviewed by mjs


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=10225>
GMail Editor: Change Hilite Color doesn't work

  • editing/JSEditor.cpp: Added support for execCommand("HiliteColor", ...). It's what GMail uses to implement text hiliting. It's just a synonym for BackColor.
  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): Moved a comment a more appropriate place.
9:21 AM Changeset in webkit [15771] by brmorris
  • 1 edit
    50 adds in S60/trunk/LayoutTests

2006-07-31 brmorris <​bradley.morrison@nokia.com>

Reviewed by dacarson.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9199


Adding new LayoutTest baselines.

9:18 AM Changeset in webkit [15770] by brmorris
  • 2 edits in S60/trunk

2006-07-31 brmorris <​bradley.morrison@nokia.com>

Reviewed by dacarson.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=9199


  • runATF.bat: Generate and copy 'expected' if missing.
8:36 AM Changeset in webkit [15769] by darin
  • 4 edits in trunk/WebKitTools

2006-08-03 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by Darin.

Bug 10224: [Drosera] Drosera icon should be set on DroseraLauncher so it appears in nightly builds
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10224

  • Drosera/Drosera.xcodeproj/project.pbxproj:
  • Drosera/LauncherInfo.plist:

2006-08-03 Mitz Pettel <​opendarwin.org@mitzpettel.com>

  • fix ASSERTION FAILURE: draggingDocumentView == nil in -[WebViewPrivate dealloc] when a test performs an unsuccessful drag and drop operation.
  • DumpRenderTree/EventSendingController.m: (-[EventSendingController mouseUp]): Added a call to -draggingExited: if the drag operation for the mouse release is NSDragOperationNone.
8:34 AM Changeset in webkit [15768] by darin
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adele and Darin.

  • fast/forms/textfield-drag-into-disabled-expected.checksum: Added.
  • fast/forms/textfield-drag-into-disabled-expected.png: Added.
  • fast/forms/textfield-drag-into-disabled-expected.txt: Added.
  • fast/forms/textfield-drag-into-disabled.html: Added.
  • fast/forms/input-disabled-color-expected.txt: Updated.

WebCore:

Reviewed by Adele and Darin.

Test: fast/forms/textfield-drag-into-disabled.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createDivStyle): Changed to set -webkit-user-modify to read-only on the inner div if the control is disabled. (WebCore::RenderTextControl::updateFromElement): Ditto.
8:24 AM Changeset in webkit [15767] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/overflow/generated-content-crash-expected.txt: Added.
  • fast/overflow/generated-content-crash.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/overflow/generated-content-crash.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout): Added a null check for the renderer's element. Generated content does not have an element and therefore does not need to maintain overflow status.
8:22 AM Changeset in webkit [15766] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Anders.

  • fast/tokenizer/image-empty-crash-expected.txt: Added.
  • fast/tokenizer/image-empty-crash.html: Added.

WebCore:

Reviewed by Anders.

Test: fast/tokenizer/image-empty-crash.html

  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::stopParsing): Added null check for m_imageElement. (WebCore::ImageTokenizer::finish): Ditto.
8:21 AM Changeset in webkit [15765] by darin
  • 6 edits in trunk/WebCore

Reviewed by Anders.

  • clean up "flip"-related code a tiny bit
  • platform/Screen.h: Removed redundant parameter names.
  • platform/mac/ScreenMac.mm: (WebCore::flipScreenRect): Changed to call flipScreenPoint so we only have one copy of the flipping code. (WebCore::flipScreenPoint): Fixed indentation.
  • bridge/mac/WebCoreFrameBridge.mm: (globalPoint): Removed type casts and simplified a bit.
  • platform/mac/PlatformMouseEventMac.mm: (WebCore::globalPositionForEvent):
  • platform/mac/WheelEventMac.mm: (WebCore::globalPositionForEvent): Removed unneeded local variable.
8:17 AM Changeset in webkit [15764] by darin
  • 2 edits in trunk/WebKit

Reviewed by Eric Seidel.

  • fix storage leak
  • WebView/WebFrame.m: (-[WebFramePrivate dealloc]): Release the frame loader.

Aug 2, 2006:

11:08 PM Changeset in webkit [15763] by thatcher
  • 2 edits in trunk/WebKit

Rubber stamped by Maciej.

Adding back resultsWithXpathQuery, removed by Darin's earlier change.
This function is called from ObjC, but not used from JavaScript.

4:18 PM Changeset in webkit [15762] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

Bug 9632: [Drosera] syntax highlighting is slow (reproducible 40 second hang)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9632

Do not change the file source when normalizing the line endings.
We use this file source to compare against new versions of the source
as it comes in, so we can skip re-syntax highlighting if they are the same.
The problem is apparent on yahoo.com since they have mixed line endings and
once we normalize them the source will always be different. This was
compounded by the fact that yahoo has around 40 inline scripts. Each
inline script causes us to check if the main document has more loaded,
that is when we compare the source strings. Since they are always different
we would syntax highlight yahoo.com 40 times! We do check source length before
doing a more expensive string comparison, but the lengths were the same.

  • Drosera/debugger.js:
4:15 PM Changeset in webkit [15761] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Darin.

Bug 10200: [Drosera] Deadlock between Drosera and Safari while loading page
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10200

Prevent reentrancy in our debugger callbacks. This was causing a deadlock in Drosera because
suspendProcessIfPaused was being called during a DO call into Safari.

Preventing reentrancy also prevents scripts that Drosera injects and evaluates from showing
up in rare cases (such as a iframe loading about:blank). I thought this would prevent cases
where you call a function from the console and expect it to break on a breakpoint in them, but
this appears to never have worked even without this change. When that is figured out we can
reconsider a better solution to reentrancy. I have filed that as bug 10214.

I also removed the NSRunLoop runMode:beforeDate: calls since DO handles this for us since
we don't use "onway void" as the return type for the callbacks. Note: using onway void for
the listener callbacks causes bad synchronization issues and obscure crashes.

  • DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer webView:didLoadMainResourceForDataSource:]): (-[WebScriptDebugServer webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebScriptDebugServer webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]): (-[WebScriptDebugServer webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willLeaveCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
  • DefaultDelegates/WebScriptDebugServerPrivate.h:
3:59 PM Changeset in webkit [15760] by hyatt
  • 4 edits in trunk/WebCore

Abstract RenderLayer scrollbar creation and destruction so that there
is a clean spot in which to drop in engine scrollbar stuff.

Reviewed by timo

  • platform/ScrollBar.h: (WebCore::ScrollBar::hasPlatformScrollBars):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::destroyScrollbar): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar):
  • rendering/RenderLayer.h:
3:58 PM Changeset in webkit [15759] by ggaren
  • 2 edits
    1 add in trunk/WebKitSite

Reviewed by TimO.


Tweaked the build instructions a bit.

  • building/build.html:
  • building/debug.png: Added.
3:47 PM RecentChanges created by trac
3:47 PM SandBox created by trac
3:47 PM TitleIndex created by trac
3:47 PM CamelCase created by trac
3:47 PM TracAccessibility created by trac
3:47 PM TracAdmin created by trac
3:47 PM TracBackup created by trac
3:47 PM TracBrowser created by trac
3:47 PM TracCgi created by trac
3:47 PM TracInstall created by trac
3:47 PM TracInterfaceCustomization created by trac
3:47 PM TracLinks created by trac
3:47 PM TracChangeset created by trac
3:47 PM TracEnvironment created by trac
3:47 PM TracFastCgi created by trac
3:47 PM TracGuide created by trac
3:47 PM TracRss created by trac
3:47 PM TracImport created by trac
3:47 PM TracIni created by trac
3:47 PM TracLogging created by trac
3:47 PM TracModPython created by trac
3:47 PM TracNotification created by trac
3:47 PM TracPermissions created by trac
3:47 PM TracPlugins created by trac
3:47 PM TracQuery created by trac
3:47 PM TracReports created by trac
3:47 PM TracRoadmap created by trac
3:47 PM TracSearch created by trac
3:47 PM TracStandalone created by trac
3:47 PM TracSupport created by trac
3:47 PM TracSyntaxColoring created by trac
3:47 PM TracTickets created by trac
3:47 PM WikiHtml created by trac
3:47 PM TracTicketsCustomFields created by trac
3:47 PM TracTimeline created by trac
3:47 PM TracUnicode created by trac
3:47 PM TracUpgrade created by trac
3:47 PM TracWiki created by trac
3:47 PM WikiDeletePage created by trac
3:47 PM WikiFormatting created by trac
3:47 PM WikiMacros created by trac
3:47 PM WikiPageNames created by trac
3:47 PM WikiProcessors created by trac
3:47 PM WikiRestructuredText created by trac
3:47 PM WikiRestructuredTextLinks created by trac
3:47 PM WikiStart created by trac
3:47 PM InterWiki edited by trac
(diff)
3:47 PM TracFineGrainedPermissions created by trac
3:47 PM TracFastCgi edited by trac
(diff)
3:47 PM TracEnvironment edited by trac
(diff)
3:47 PM TracChangeset edited by trac
(diff)
3:47 PM TracCgi edited by trac
(diff)
3:47 PM InterTrac edited by trac
(diff)
3:47 PM TracRevisionLog edited by trac
(diff)
3:47 PM TracUpgrade edited by trac
(diff)
3:47 PM TracUnicode edited by trac
(diff)
3:47 PM TracTimeline edited by trac
(diff)
3:47 PM TracTicketsCustomFields edited by trac
(diff)
3:47 PM TracTickets edited by trac
(diff)
3:47 PM WikiProcessors edited by trac
(diff)
3:47 PM WikiMacros edited by trac
(diff)
3:47 PM WikiFormatting edited by trac
(diff)
3:47 PM WikiRestructuredTextLinks edited by trac
(diff)
3:47 PM WikiRestructuredText edited by trac
(diff)
3:47 PM WikiPageNames edited by trac
(diff)
3:47 PM WikiHtml edited by trac
(diff)
3:47 PM WikiDeletePage edited by trac
(diff)
3:47 PM TracWorkflow created by trac
3:47 PM TracWiki edited by trac
(diff)
3:47 PM TracSyntaxColoring edited by trac
(diff)
3:47 PM TracSupport edited by trac
(diff)
3:47 PM TracStandalone edited by trac
(diff)
3:47 PM TracSearch edited by trac
(diff)
3:47 PM TracRss edited by trac
(diff)
3:47 PM TracRoadmap edited by trac
(diff)
3:47 PM TracReports edited by trac
(diff)
3:47 PM TracQuery edited by trac
(diff)
3:47 PM TracPlugins edited by trac
(diff)
3:47 PM TracPermissions edited by trac
(diff)
3:47 PM TracNotification edited by trac
(diff)
3:47 PM TracNavigation created by trac
3:47 PM TracModPython edited by trac
(diff)
3:47 PM TracLogging edited by trac
(diff)
3:47 PM TracLinks edited by trac
(diff)
3:47 PM TracInterfaceCustomization edited by trac
(diff)
3:47 PM TracInstall edited by trac
(diff)
3:47 PM TracIni edited by trac
(diff)
3:47 PM TracImport edited by trac
(diff)
3:47 PM TracGuide edited by trac
(diff)
3:47 PM TracBrowser edited by trac
(diff)
3:47 PM TracBackup edited by trac
(diff)
3:47 PM TracAdmin edited by trac
(diff)
3:47 PM TracAccessibility edited by trac
(diff)
3:47 PM TitleIndex edited by trac
(diff)
3:47 PM RecentChanges edited by trac
(diff)
3:47 PM PageTemplates created by trac
3:47 PM CamelCase edited by trac
(diff)
1:32 PM Changeset in webkit [15758] by ap
  • 3 edits
    4 adds
    4 deletes in trunk

Fix by Mitz Pettel, reviewed by Darin.

Test: fast/replaced/image-solid-color-with-alpha.html

  • platform/mac/ImageMac.mm: (WebCore::Image::checkForSolidColor): Changed to divide each color component by the alpha component. You need to do that since the bitmap context has premultiplied alpha but m_solidColor should be non-premultiplied.
1:26 PM Changeset in webkit [15757] by aroben
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • Fixed build
  • kjs/date_object.cpp: (KJS::formatTime):
12:06 PM Changeset in webkit [15756] by mjs
  • 3 edits in trunk/WebKit

Reviewed by John.


  • fix assertion failure on layout tests by stopping plugins from loading at a clearly defined time
  • add more assertions for safety
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): Removed obsolete comment. (-[WebDataSource _updateLoading]): Add assertion ensuring this method is only called at a time when this data source is the one that might be loading for a frame. (-[WebDataSource _stopLoading]): Stop loading plugins as a FIXME suggests we should.
  • WebView/WebFrameLoader.m: (-[WebFrameLoader isLoadingPlugIns]): New helper method. (-[WebFrameLoader isLoading]): Consider plugin loads too - otherwise we won't stop them at stopLoading time.
11:35 AM Changeset in webkit [15755] by darin
  • 2 edits in trunk/WebKitSite
  • building/checkout.html: Fix a typo: "OpenSource" instead of "Open Source".
11:14 AM Changeset in webkit [15754] by aroben
  • 4 edits in trunk

WebCore:

Reviewed by Brady.

  • Remove redundant #include
  • loader/loader.cpp:

WebKit:

Reviewed by Brady.

  • Rename TransferJob to ResourceLoader (this file was forgotten in an earlier change by Maciej)
  • COM/WebView.cpp:
11:13 AM Changeset in webkit [15753] by thatcher
  • 3 edits
    1 add in trunk/WebKitTools

Reviewed by Timothy.

Bug 9931: [Drosera] Needs a cool icon
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9931

  • Drosera/Drosera.icns: Added.
  • Drosera/Drosera.xcodeproj/project.pbxproj:
  • Drosera/Info.plist:
11:07 AM Changeset in webkit [15752] by brmorris
  • 2 edits in S60/trunk/WebKit

2006-08-02 ligman <​joseph.ligman@nokia.com>

Reviewed by Yongjun, landed by Bradley.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10194
Assigned a default element type to keep the focus from being undefined.
TWebCoreFocusedElementType elType = EWebCoreElementNone;


  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):
1:11 AM Changeset in webkit [15751] by mjs
  • 8 edits in trunk/WebKit

Reviewed by Adele.


  • Change things around so WebFrameLoader tracks the main and provisional data source, as well as the frame load state, pulling much code out of WebFrame along the way.


The most significant aspects of this change are:


  • management of WebDataSources and WebFrameState was moved into WebFrameLoader
  • there is now just one WebFrameLoader shared between the primary and provisional data source
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _updateLoading]): (-[WebDataSource _loadIcon]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _stopLoading]): (-[WebDataSource _startLoading]): (-[WebDataSource _addSubresourceLoader:]): (-[WebDataSource _removeSubresourceLoader:]): (-[WebDataSource _addPlugInStreamLoader:]): (-[WebDataSource _removePlugInStreamLoader:]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _stopLoadingWithError:]): (-[WebDataSource _revertToProvisionalState]): (-[WebDataSource _setupForReplaceByMIMEType:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource data]): (-[WebDataSource isLoading]):
  • WebView/WebFrame.m: (-[WebFramePrivate init]): (-[WebFramePrivate dealloc]): (-[WebFrame _closeOldDataSources]): (-[WebFrame _detachFromParent]): (-[WebFrame _makeDocumentView]): (-[WebFrame _receivedMainResourceError:]): (-[WebFrame _transitionToCommitted:]): (+[WebFrame _timeOfLastCompletedLoad]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _continueAfterWillSubmitForm:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrame _initWithWebFrameView:webView:bridge:]): (-[WebFrame _frameLoader]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame stopLoading]):
  • WebView/WebFrameInternal.h:
  • WebView/WebFrameLoader.h:
  • WebView/WebFrameLoader.m: (-[WebFrameLoader initWithWebFrame:]): (-[WebFrameLoader dealloc]): (-[WebFrameLoader dataSource]): (-[WebFrameLoader _setDataSource:]): (-[WebFrameLoader clearDataSource]): (-[WebFrameLoader provisionalDataSource]): (-[WebFrameLoader _setProvisionalDataSource:]): (-[WebFrameLoader _clearProvisionalDataSource]): (-[WebFrameLoader state]): (+[WebFrameLoader timeOfLastCompletedLoad]): (-[WebFrameLoader _setState:]): (-[WebFrameLoader clearProvisionalLoad]): (-[WebFrameLoader markLoadComplete]): (-[WebFrameLoader commitProvisionalLoad]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader startLoading]): (-[WebFrameLoader startProvisionalLoad:]): (-[WebFrameLoader setupForReplace]):
  • WebView/WebFramePrivate.h:
Note: See TracTimeline for information about the timeline view.