Context Navigation

← Previous Period
Next Period →

Timeline

Aug 8, 2006:

2:11 PM Changeset in webkit [15822] by zbujtas

2 edits in S60/trunk/MemoryManager

2006-08-08 yongjzha <yongjun.zhang@nokia.com>

Reviewed by Zalan

http://bugzilla.opendarwin.org/show_bug.cgi?id=10311

Src/fast_malloc.cpp: (close_mem_pool): (ChunkClosingUtil::~ChunkClosingUtil):

1:53 PM Changeset in webkit [15821] by zbujtas

7 edits in S60/trunk

2006-08-08 w3liu <wei.liu@nokia.com>

Reviewed by Zalan.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10294
text decoding problem for www.yaplog.cn and www.sogou.com

BrowserView/inc/BrowserSettingsContainer.h:
BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
ChangeLog:

12:57 PM Changeset in webkit [15820] by zbujtas

4 edits in S60/trunk/WebKit

2006-08-08 bujtas <zbujtas@gmail.com>

Reviewed by Sriram.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10305
Turn off tabbed navigation when the pageoverview is on

BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::NavigateWithCursor):
BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CursorUpdate):
BrowserView/src/WebKitView.cpp: (CWebKitView::CWebKitView): (CWebKitView::ConstructL): (CWebKitView::SetCurrentZoomLevelIndex): (CWebKitView::ZoomLevelChanged): (CWebKitView::TouchScrolling): (CWebKitView::Draw): (CWebKitView::ScrollAndMoveCursor): (CWebKitView::FindNextSmartLink):

12:28 PM Changeset in webkit [15819] by rwlbuis

33 edits
2 adds
1 delete in trunk

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10230
SVGDOMImplementation should die (and be rolled into DOMImplementation)

Delete SVGDOMImplementation and references to it. The
svg specific functionality is now in DOMImplementation.

11:56 AM Changeset in webkit [15818] by zbujtas

2 edits in S60/trunk/S60Internals

2006-08-08 zbujtas <zbujtas@gmail.com>

add one more Download Manager include file:
\epoc32\include\DownloadMgrCRKeys.h

S60Headers.zip:

8:12 AM Changeset in webkit [15817] by zbujtas

2 edits in S60/trunk/WebKit

2006-08-07 yongjzha <yongjun.zhang@nokia.com>

Reviewed by Zalan.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10296
Horizontal wrapping from TFastWrapUtil starts from wrong offset.

BrowserCore/Renderers/inc/BitmapTiler.h: (TFastWrapUtil::operator++):

7:54 AM Changeset in webkit [15816] by zbujtas

2 edits in S60/trunk/S60Internals

12:28 AM Changeset in webkit [15815] by beidson

12 edits
2 adds in trunk

WebCore:

Reviewed by Anders and John

Icons can now refresh when new data is sent from WebKit, both on disk and in memory

bridge/mac/WebCoreIconDatabaseBridge.h:
bridge/mac/WebCoreIconDatabaseBridge.mm: (WebCore::IconDatabase::loadIconFromURL): Allows WebCore/Kit to kick off a load outside of any greater context (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]): (-[WebCoreIconDatabaseBridge isIconExpiredForPageURL:]): Allows WebKit to get whether or not an icon has expired

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::recreateDatabase): Changed database schema slightly (WebCore::IconDatabase::createPrivateTables): Changed database schema slightly (WebCore::IconDatabase::iconForPageURL): (WebCore::IconDatabase::isIconExpiredForIconURL): Get if an icon has expired (WebCore::IconDatabase::isIconExpiredForPageURL): Get if an icon has expired (WebCore::IconDatabase::setIconDataForIconURL): Force a refresh of the in memory image when new icon data is loaded (WebCore::IconDatabase::setIconURLForPageURL): added a check for null iconID

loader/icon/IconDatabase.h: added/changed some methods
loader/icon/SiteIcon.cpp: (SiteIcon::getImage): simplified/removed debugging code (SiteIcon::manuallySetImageData): allow the image data to be changed when new icon data is loaded

WebKit:

Reviewed by Anders and John

Misc/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase isIconExpiredForIconURL:]): Get if an icon expired (-[WebIconDatabase isIconExpiredForPageURL:]): Ditto (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _sendNotificationForURL:]): Moved to WebKitPendingPublic for use outside of WebIconDatabase (-[WebIconDatabase loadIconFromURL:]): Allow a load outside the context of a page load
Misc/WebIconDatabasePrivate.h:

Misc/WebIconLoader.m: (-[WebIconLoader didFinishLoading]): fixed up the "flipping the switch" #defs a bit (-[WebIconLoader willSendRequest:redirectResponse:]): override to allow a load outside of the context of a page load

WebCoreSupport/WebIconDatabaseBridge.h: Added.
WebCoreSupport/WebIconDatabaseBridge.m: Added. (-[WebIconDatabaseBridge init]): (-[WebIconDatabaseBridge dealloc]): (-[WebIconDatabaseBridge loadIconFromURL:]): Kick off a load on an icon outside of the context of any page load (-[WebIconDatabaseBridge _setIconData:forIconURL:]): WebKit side of bridge method (-[WebIconDatabaseBridge _setHaveNoIconForIconURL:]): WebKit side of bridge method (-[WebIconDatabaseBridge releaseCachedLoaderForIconURL:]): (+[WebIconDatabaseBridge sharedBridgeInstance]): Moved this from WebCore to WebKit so both sides of the bridge get the WebKit version
WebKit.xcodeproj/project.pbxproj: Added some files
WebView/WebDataSource.m: (-[WebDataSource _loadIcon]): Added check for reload/expired icon to force a load even if we already have it

Aug 7, 2006:

3:56 PM Changeset in webkit [15814] by zbujtas

3 edits in S60/trunk/WebKit

2006-08-07 ligman <joseph.ligman@nokia.com>

Reviewed by Yongjun.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10260
Browser crashes when trying to cancel a saved page refresh from options menu
Added a flag as to indicate the user has canceled the refresh of a saved page and
therefore the page should not be regenerated

BrowserView/inc/WebKitControl.h:
BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::PageInfoLC): (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::LoadUrlL): (CWebKitControl::IncrementProgressForLoadStart): (CWebKitControl::ResetProgress): (CWebKitControl::FinalProgressComplete):

3:50 PM Changeset in webkit [15813] by zbujtas

2 edits in S60/trunk/WebCore

2006-08-07 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas

WARNING: NO TEST CASES ADDED OR CHANGED

http://bugzilla.opendarwin.org/show_bug.cgi?id=10240

kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition): (KWQKHTMLPart::tabbedNavigation):

3:47 PM Changeset in webkit [15812] by zbujtas

3 edits in S60/trunk/WebCore

2006-08-07 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas

WARNING: NO TEST CASES ADDED OR CHANGED

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10195

kwq/KWQPainter.cpp: (QPainter::xForm): (QPainter::drawFocusRing):
kwq/KWQPainter.h:

3:31 PM Changeset in webkit [15811] by zbujtas

3 edits in S60/trunk/WebKit

2006-08-05 spaltis <Stanislav.Paltis@nokia.com>

Reviewed by Yongjun.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10237

Unfinished download should be visible in the download list,
before connection is established.

ResourceLoader/inc/HttpDownloadObserver.h:
ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::~CHttpDownloadObserver): (CHttpDownloadObserver::ConstructL): (CHttpDownloadObserver::DlMgrInitCB): (CHttpDownloadObserver::InitDownloadMgrL): (CHttpDownloadObserver::HandleDMgrEventL): (CHttpDownloadObserver::HandleDMgrCompletedEventL):

Aug 6, 2006:

11:10 PM Changeset in webkit [15810] by thatcher

5 edits in trunk

Fixing the build for the newer Bison and our new use of -Wundef. Turns off -Wundef for WebKit because <CoreGraphics/CGBase.h> causes a warning we can't fix. We can turn it back on once this radar is fixed: <rdar://problem/4669823> CGBase.h fails to build with -Wundef enabled.

Aug 5, 2006:

4:53 PM Changeset in webkit [15809] by darin

3 edits in trunk/WebCore

Reviewed by Eric Seidel.

fix a storage leak

rendering/RenderView.cpp: (WebCore::RenderView::setSelection): Delete the values if we are going to exit without using the maps. Otherwise all the values leak.

1:14 PM Changeset in webkit [15808] by darin

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10213 REGRESSION: Crash in WebCore::RenderLayer::isTransparent involving <iframe> and <select>

fast/frames/iframe-option-crash-expected.checksum: Added.
fast/frames/iframe-option-crash-expected.png: Added.
fast/frames/iframe-option-crash-expected.txt: Added.
fast/frames/iframe-option-crash.xhtml: Added.

WebCore:

Reviewed by Hyatt.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10213 REGRESSION: Crash in WebCore::RenderLayer::isTransparent involving <iframe> and <select>

Test: fast/frames/iframe-option-crash.xhtml

rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations): Check for a nil renderer.

Aug 4, 2006:

4:27 PM Changeset in webkit [15807] by hyatt

2 edits in trunk/WebCore

Fix for Radar bug #4644045, regression where dragging selection no longer
works for floats contained inside layers. I added an optimization to
refine dirty rect checking for layers, and it incorrectly excluded floats
from the paint bounds since PaintPhaseSelection was not considered when
analyzing the floatRect().

Reviewed by beth

rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint):

4:19 PM Changeset in webkit [15806] by hyatt

5 edits in trunk/WebCore

Fix remove() so that it is equivalent to calling removeChild on the
parent. This involved moving three operations that remove did.

(1) Move the accessibility object cache removal into the destroy methods,
since this really should just happen when a render object is going away.

(2) removeFromObjectLists shifted into removeChild, which means it will
now be called more often (this is a correct change). Note that there is
also now a new guard on removeFromObjectLists so that it won't do any
work unless the document is not being destroyed.

(3) The big one. deleteLineBoxWrapper was not getting called to clean up
the line box tree. This moved right into RenderContainer's removeChildNode so
that it is now done even in the lowest level RenderContainer removal primitive.

Reviewed by beth

rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::removeChild):
rendering/RenderObject.cpp: (WebCore::RenderObject::removeFromObjectLists): (WebCore::RenderObject::destroy):
rendering/RenderObject.h: (WebCore::RenderObject::remove):
rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):

4:03 PM Changeset in webkit [15805] by bdakin

7 edits in branches/Safari-2-0-branch/WebCore

Reviewed by me/Hyatt.

Mostly this is merging over Hyatt's fix with r15801. Some other
things needed to be tweaked though. This is a better fix for
<rdar://problem/4541255> Safari hangs at http://www.kutilek.de/
safari-test/ somewhere from
WebCore::RenderBlock::layoutInlineChildren(bool)

khtml/rendering/render_box.cpp: (RenderBox::deleteLineBoxWrapper): Call remove.
khtml/rendering/render_box.h:
khtml/rendering/render_list.cpp: (RenderListItem::updateMarkerLocation): Call remove.
khtml/rendering/render_list.h: (khtml::ListMarkerBox:::InlineBox):
khtml/rendering/render_object.cpp: Back out old fix. (RenderObject::remove):
khtml/rendering/render_object.h: Back out old fix.

2:13 PM Changeset in webkit [15804] by brmorris

13 edits
2 adds in S60/trunk

2006-08-04 yaharon <yael.aharon@nokia.com>

Reviewed by Zalan, Yongjun and Steve.

Handle pointer events in WebKit

http://bugzilla.opendarwin.org/show_bug.cgi?id=10250

ChangeLog:
kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::MouseDown):
kwq/KWQWidget.cpp: (QWidget::focusPolicy):

2:12 PM Changeset in webkit [15803] by beidson

2 edits in trunk/JavaScriptCore

Reviewed by Geoff's rubber stamp

Fix a build break on Intel hardware causes by adapting stricter
compiler warnings (-Wshorten-64-to-32)

API/testapi.c: (assertEqualsAsNumber): manually cast some doubles to floats (main): ditto

2:04 PM Changeset in webkit [15802] by hyatt

4 adds in trunk/LayoutTests/fast/lists

Add layout test for list marker crash

2:04 PM Changeset in webkit [15801] by hyatt

4 edits in trunk/WebCore

Back out the fix for list marker crashes. The actual bug here is that
there is a confusing mismatch between remove() and removeChild() in the
render tree. remove() does a little bit of extra work that removeChild
should be doing instead (so that remove() can just be a shorthand for
removeChild).

This conservative fix does not solve the remove/removeChild mismatch
but instead just changes the list marker updating code to use remove
instead.

Reviewed by beth

Test Case: fast/lists/dynamic-marker-crash.html

rendering/ListMarkerBox.cpp:
rendering/ListMarkerBox.h:
rendering/RenderListItem.cpp: (WebCore::RenderListItem::updateMarkerLocation):

1:52 PM Changeset in webkit [15800] by brmorris

1 copy in S60/tags/s60-RnD-06wk31

Tagging S60 RnD release 2006w31

11:57 AM Changeset in webkit [15799] by weinig

30 edits in trunk

JavaScriptCore:

Reviewed by Darin.

patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10192 Make WebCore (and friends) compile with -Wshorten-64-to-32

Adds -Wshorten-64-to-32 flag to Xcode project.
Adds explicit casts where OK.

API/JSNodeList.c: (JSNodeList_item): (JSNodeList_getProperty):
JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

Reviewed by Darin.

patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10192 Make WebCore (and friends) compile with -Wshorten-64-to-32

Adds -Wshorten-64-to-32 flag to Xcode project.

JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Darin.

patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10192 Make WebCore (and friends) compile with -Wshorten-64-to-32

Adds -Wshorten-64-to-32 flag to Xcode project.
Adds 'f' to float literals where expecting a float.
Use cosf() instead of cos() when assigning to a float.

WebCore.xcodeproj/project.pbxproj:
kcanvas/device/quartz/filters/WKDiffuseLightingFilter.m: (+[WKDiffuseLightingFilter initialize]):
kcanvas/device/quartz/filters/WKDiscreteTransferFilter.m: (-[WKDiscreteTransferFilter outputImage]):
kcanvas/device/quartz/filters/WKDisplacementMapFilter.m: (+[WKDisplacementMapFilter initialize]):
kcanvas/device/quartz/filters/WKSpecularLightingFilter.m: (+[WKSpecularLightingFilter initialize]):
kcanvas/device/quartz/filters/WKSpotLightFilter.m: (-[WKSpotLightFilter outputImage]):
kcanvas/device/quartz/filters/WKTableTransferFilter.m: (-[WKTableTransferFilter outputImage]):

WebKit:

Reviewed by Darin.

patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10192 Make WebCore (and friends) compile with -Wshorten-64-to-32

Adds 'f' to float literals where expecting a float.
Use ceilf() instead of ceil() when assigning to a float.
Adds explicit casts where OK.

NOTE: The -Wshorten-64-to-32 flag was not added for WebKit
because there are still a few places where no error handling
is in place. The flag can be added as soon as those are worked
out.

Misc/WebNSControlExtras.m: (-[NSControl sizeToFitAndAdjustWindowHeight]):
Misc/WebNSImageExtras.m: (-[NSImage _web_scaleToMaxSize:]):
Misc/WebNSViewExtras.h:
Misc/WebNSViewExtras.m:
Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView drawRect:]):
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge expiresTimeForResponse:]):
WebInspector/WebInspector.m: (-[NSWindow window]): (-treeViewScrollTo:): (-_updateSystemColors): (-webView:plugInViewWithArguments:): (-outlineView:objectValueForTableColumn:byItem:):
WebInspector/WebInspectorOutlineView.m: (-[WebInspectorOutlineView _highlightRow:clipRect:]):
WebInspector/WebNodeHighlight.m: (-[WebNodeHighlight initWithBounds:andRects:forView:]):
WebInspector/WebNodeHighlightView.m: (-[WebNodeHighlightView roundedRect:withRadius:]): (-[WebNodeHighlightView initWithHighlight:andRects:forView:]): (-[WebNodeHighlightView drawRect:]):
WebView/WebFrame.m: (-[WebFrame _opened]):
WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]):
WebView/WebHTMLView.m: (-[WebHTMLView _dragImageForLinkElement:]): (-[WebHTMLView _web_setPrintingModeRecursive]): (-[WebHTMLView _web_clearPrintingModeRecursive]): (-[NSArray layout]): (-[NSArray _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]): (-[NSArray adjustPageHeightNew:top:bottom:limit:]): (-[NSArray _scaleFactorForPrintOperation:]): (-[NSArray setPageWidthForPrinting:]): (-[NSArray _endPrintMode]): (-[NSArray knowsPageRange:]): (-[NSArray _originalFontA]): (-[NSArray _originalFontB]): (-[WebTextCompleteController _buildUI]): (-[WebTextCompleteController _placePopupWindow:]):
WebView/WebPDFView.m: (-[WebPDFView _makeTextStandardSize:]): (-[WebPDFView selectionImageForcingWhiteText:]): (-[PDFPrefUpdatingProxy forwardInvocation:]):
WebView/WebPreferences.m: (-[WebPreferences _floatValueForKey:]):
WebView/WebView.m: (-[WebView makeTextSmaller:]): (-[WebView canMakeTextStandardSize]): (-[WebView makeTextStandardSize:]):

9:55 AM Changeset in webkit [15798] by aroben