Timeline



Aug 23, 2006:

11:22 PM Changeset in webkit [16006] by mjs
  • 7 edits in trunk/WebKit

Reviewed by Brady.


  • move WebFrame code that creates WebDataSources down to WebFrameLoader, in preparation for WebFrameLoader just holding on to WebDocumentLoadState
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]):
  • WebView/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]): (-[WebFrame loadRequest:]): (-[WebFrame loadArchive:]): (-[WebFrame reload]):
  • WebView/WebFrameInternal.h:
  • WebView/WebFramePrivate.h:
  • WebView/WebView.m: (-[WebView setCustomTextEncodingName:]):
10:59 PM Changeset in webkit [16005] by beidson
  • 5 edits in trunk/WebKit

Reviewed by Maciej

First pass at pruning unused WebIconDatabase code. Focus on removing methods that simply
have no place in the new DB at all. A few renames and a few important FIXMEs result, but no
functionality changes.

  • Loader/WebIconLoader.m: (-[WebIconLoader didFinishLoading]): Call to WebIconDatabase instead of directly to the bridge
  • Misc/WebIconDatabase.h:
  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase iconForURL:withSize:cache:]): (-[WebIconDatabase iconURLForURL:]): (-[WebIconDatabase defaultIconWithSize:]): (-[WebIconDatabase retainIconForURL:]): (-[WebIconDatabase releaseIconForURL:]): (-[WebIconDatabase removeAllIcons]): (-[WebIconDatabase _setIconData:forIconURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _hasEntryForIconURL:]): (-[WebIconDatabase _applicationWillTerminate:]): (-[WebIconDatabase _resetCachedWebPreferences:]):
  • Misc/WebIconDatabasePrivate.h: Changed setIcon: to setIconData:
9:15 PM Changeset in webkit [16004] by mjs
  • 4 edits
    2 adds in trunk/WebKit

Reviewed by Adele.


  • started factoring most of the guts of WebDataSource into a new class


WebDocumentLoadState is decoupled from the rest of WebKit and will
be moved down to WebCore. I only moved one of the data fields of
WebDataSource for now.

  • Loader/WebDocumentLoadState.h: Added.
  • Loader/WebDocumentLoadState.m: Added. (-[WebDocumentLoadState initWithRequest:]): New class. (-[WebDocumentLoadState dealloc]): (-[WebDocumentLoadState setFrameLoader:]): (-[WebDocumentLoadState setMainResourceData:]): (-[WebDocumentLoadState mainResourceData]):
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _setDataSource:]): Remove redundant _setWebFrame: call, it would have been called already by this point. (-[WebFrameLoader _setProvisionalDataSource:]): ditto.
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setWebFrame:]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource data]):
6:28 PM Changeset in webkit [16003] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Adele.


  • refactoring of WebDataSource in preparation for moving a bunch of it to a new class


  • minimize WebDataSourceInternal.h to be only methods called from outside WebDataSource
  • reduce Private category implementation to be only the SPI methods
  • make new Internal and FileInternal categories which contain the remainder (depending on whether they are called from outside of WebDataSource)
  • WebView/WebDataSource.m: (-[WebDataSource _setMainDocumentError:]): (addTypesFromClass): (+[WebDataSource _representationClassForMIMEType:]): (-[WebDataSource _commitIfReady]): (-[WebDataSource _commitLoadWithData:]): (-[WebDataSource _doesProgressiveLoadWithMIMEType:]): (-[WebDataSource _addResponse:]): (-[WebDataSource _revertToProvisionalState]): (-[WebDataSource _mainDocumentError]): (-[WebDataSource _addSubframeArchives:]): (-[WebDataSource _fileWrapperForURL:]): (+[WebDataSource _repTypesAllowImageTypeOmission:]): (-[WebDataSource _decidePolicyForMIMEType:decisionListener:]): (-[WebDataSource _finishedLoading]): (-[WebDataSource _setResponse:]): (-[WebDataSource _setRequest:]): (-[WebDataSource _setupForReplaceByMIMEType:]): (-[WebDataSource _receivedMainResourceError:complete:]): (-[WebDataSource _mainReceivedError:complete:]): (-[WebDataSource _defersCallbacks]): (-[WebDataSource _downloadWithLoadingConnection:request:response:proxy:]): (-[WebDataSource _didFailLoadingWithError:forResource:]): (-[WebDataSource _didFinishLoadingForResource:]): (-[WebDataSource _didReceiveData:contentLength:forResource:]): (-[WebDataSource _didReceiveResponse:forResource:]): (-[WebDataSource _didCancelAuthenticationChallenge:forResource:]): (-[WebDataSource _didReceiveAuthenticationChallenge:forResource:]): (-[WebDataSource _willSendRequest:forResource:redirectResponse:]): (-[WebDataSource _identifierForInitialRequest:]): (-[WebDataSource _archivedSubresourceForURL:]): (-[WebDataSource _startLoading]): (-[WebDataSource _stopRecordingResponses]): (-[WebDataSource _loadingStartedTime]): (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): (-[WebDataSource _documentFragmentWithArchive:]): (-[WebDataSource _documentFragmentWithImageResource:]): (-[WebDataSource _imageElementWithImageResource:]): (-[WebDataSource _title]): (-[WebDataSource _isStopping]): (-[WebDataSource _setWebFrame:]): (-[WebDataSource _URL]): (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource _popSubframeArchiveWithName:]): (-[WebDataSource _setIsClientRedirect:]): (-[WebDataSource _setURL:]): (-[WebDataSource _setLastCheckedRequest:]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _lastCheckedRequest]): (-[WebDataSource _stopLoading]): (-[WebDataSource _bridge]): (-[WebDataSource _webView]): (-[WebDataSource _triggeringAction]): (-[WebDataSource _setTriggeringAction:]): (-[WebDataSource __adoptRequest:]): (-[WebDataSource _isDocumentHTML]): (-[WebDataSource _stopLoadingWithError:]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _responses]): (-[WebDataSource _makeRepresentation]): (-[WebDataSource _isClientRedirect]): (-[WebDataSource _originalRequest]): (-[WebDataSource _URLForHistory]): (-[WebDataSource _addToUnarchiveState:]): (-[WebDataSource _setOverrideEncoding:]): (-[WebDataSource _setIconURL:]): (-[WebDataSource _setIconURL:withType:]): (-[WebDataSource _overrideEncoding]): (-[WebDataSource _setTitle:]):
  • WebView/WebDataSourceInternal.h:
6:01 PM Changeset in webkit [16002] by hyatt
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fix Mac bustage.

5:38 PM Changeset in webkit [16001] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • added an assert to make it slightly easier to debug the common case of calling document() on a node of 0
  • dom/Node.h: (WebCore::Node::document): ASSERT(this).
5:04 PM Changeset in webkit [16000] by hyatt
  • 3 edits in trunk/JavaScriptCore

Fix Platform.h to include #defines for graphics features.

Reviewed by darin

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • wtf/Platform.h:
5:02 PM Changeset in webkit [15999] by hyatt
  • 41 edits
    7 copies
    3 moves
    1 add in trunk/WebCore

Refactor Cairo and CoreGraphics to use platform ifdefs. This patch
separates the graphics engines from their respective platforms and replaces
#ifdef PLATFORM(MAC) and PLATFORM(WIN) with PLATFORM(CG) and PLATFORM(CAIRO).

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • platform/AffineTransform.h:
  • platform/Color.h:
  • platform/Cursor.h:
  • platform/FloatPoint.h:
  • platform/FloatRect.h:
  • platform/FloatSize.h:
  • platform/Font.h:
  • platform/FontData.h:
  • platform/GlyphBuffer.h: (WebCore::GlyphBuffer::glyphAt): (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add):
  • platform/GraphicsContext.h:
  • platform/Image.h:
  • platform/ImageSource.h:
  • platform/IntPoint.h:
  • platform/IntRect.h:
  • platform/IntSize.h:
  • platform/ResourceLoader.h:
  • platform/ResourceLoaderClient.h:
  • platform/Widget.h:
  • platform/cairo/GraphicsContextCairo.cpp:
  • platform/cairo/ImageCairo.cpp:
  • platform/cairo/ImageSourceCairo.cpp:
  • platform/cg/AffineTransformCG.cpp:
  • platform/cg/FloatPointCG.cpp: Added.
  • platform/cg/FloatRectCG.cpp: Added.
  • platform/cg/FloatSizeCG.cpp: Added.
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::setFocusRingClip): (WebCore::GraphicsContext::clearFocusRingClip): (WebCore::GraphicsContext::platformContext): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine):
  • platform/cg/GraphicsContextPlatformPrivate.h: Added. (WebCore::GraphicsContextPlatformPrivate:::m_cgContext): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
  • platform/cg/ImageCG.cpp: Added. (WebCore::Image::drawTiled):
  • platform/cg/ImageSourceCG.cpp: Added.
  • platform/cg/IntPointCG.cpp: Added.
  • platform/cg/IntRectCG.cpp: Added.
  • platform/cg/IntSizeCG.cpp: Added.
  • platform/cg/PDFDocumentImage.cpp: Added. (WebCore::PDFDocumentImage::adjustCTM):
  • platform/cg/PDFDocumentImage.h: Added.
  • platform/cg/PathCG.cpp:
  • platform/image-decoders/bmp/BMPImageDecoder.cpp:
  • platform/image-decoders/gif/GIFImageDecoder.cpp:
  • platform/image-decoders/gif/GIFImageReader.cpp:
  • platform/image-decoders/ico/ICOImageDecoder.cpp:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
  • platform/image-decoders/png/PNGImageDecoder.cpp:
  • platform/image-decoders/xbm/XBMImageDecoder.cpp:
  • platform/mac/FloatPointMac.mm:
  • platform/mac/FloatRectMac.mm:
  • platform/mac/FloatSizeMac.mm:
  • platform/mac/GraphicsContextMac.mm:
  • platform/mac/ImageMac.mm:
  • platform/mac/ImageSourceMac.cpp: Removed.
  • platform/mac/IntPointMac.mm:
  • platform/mac/IntRectMac.mm:
  • platform/mac/IntSizeMac.mm:
  • platform/mac/PDFDocumentImage.h: Removed.
  • platform/mac/PDFDocumentImage.mm: Removed.
4:54 PM Changeset in webkit [22119] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin
4:46 PM Changeset in webkit [15998] by justing
  • 2 edits in trunk/LayoutTests

I forgot to check in these expected results yesterday.

2:42 PM Changeset in webkit [22118] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Ada.

Fixed placement of popups when document is scrolled.

2:36 PM Changeset in webkit [15997] by hyatt
  • 2 edits in trunk/WebCore

Remove the ifdef for platform scrollbars vs. engine scrollbars until
engine scrollbars actually exist.

  • platform/ScrollBar.h: (WebCore::ScrollBar::hasPlatformScrollBars):
2:33 PM Changeset in webkit [15996] by justing
  • 3 edits in trunk/WebCore

Reviewed by harrison


Removed the poorly named next/previousVisiblePosition
and use next/previousCandidate and next/previousVisuallyDistinctCandidate.
Removed the unused VisiblePosition::maxOffset()

  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): (WebCore::VisiblePosition::previous): (WebCore::VisiblePosition::canonicalPosition):
  • editing/VisiblePosition.h:
2:06 PM Changeset in webkit [15995] by beidson
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan

/me crosses fingers
Flip the switch to the new Icon Database
Massive code pruning is coming up

  • WebKitPrefix.h: Flipped the switch
2:04 PM Changeset in webkit [15994] by rwlbuis
  • 1 edit
    3 adds in trunk/WebCore

Reviewed by Alexey. Landed by rwlbuis.

Fixes parts of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support (Part II)

1:48 PM Changeset in webkit [15993] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Beth
Since I just pushed the default URL icon from WebKit to WebCore, but
WebKit was still using its version of the default icon, this patch makes it
use the WebCore version

  • Misc/WebIconDatabase.m: (-[WebIconDatabase defaultIconWithSize:]):
12:31 PM Changeset in webkit [15992] by beidson
  • 6 edits
    1 add in trunk/WebCore

Reviewed by Adele

Moved default URL icon from WebKit to WebCore

  • Resources/urlIcon.tiff: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • loader/icon/IconDataCache.cpp: (WebCore::IconDataCache::loadImageFromResource):
  • loader/icon/IconDataCache.h:
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::defaultIcon):
  • loader/icon/IconDatabase.h:
11:24 AM Changeset in webkit [22117] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-08-23 Steve Falkenburg <​sfalken@apple.com>

Build fix (many of our include paths were wrong!)

  • WebCore.vcproj/WebCore.vcproj:
11:08 AM Changeset in webkit [15991] by aroben
  • 6 edits in trunk/WebCore

Reviewed by Darin, Adele.

Some popup refactoring/cleanup.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::RenderMenuList): (WebCore::RenderMenuList::~RenderMenuList): (WebCore::RenderMenuList::showPopup): (WebCore::RenderMenuList::hidePopup):
  • rendering/RenderMenuList.h: (WebCore::RenderMenuList::popup): (WebCore::RenderMenuList::popupIsVisible):
  • rendering/RenderPopupMenu.h:
  • rendering/RenderPopupMenuMac.h: (WebCore::RenderPopupMenuMac::hidePopup):
11:03 AM Changeset in webkit [22116] by aroben
  • 4 edits
    1 add in branches/WindowsMerge/WebCore

Reviewed by Darin, Lou, Adele.

Initial implementation of <select> elements on Windows.

  • WebCore.vcproj/WebCore.vcproj:

Added RenderPopupMenuWin.cpp

  • platform/win/TemporaryLinkStubs.cpp: (RenderPopupMenuWin::addGroupLabel):
  • rendering/RenderPopupMenuWin.cpp: Added. (WebCore::RenderPopupMenuWin::RenderPopupMenuWin): (WebCore::RenderPopupMenuWin::~RenderPopupMenuWin): (WebCore::RenderPopupMenuWin::clear): (WebCore::RenderPopupMenuWin::populate): (WebCore::RenderPopupMenuWin::showPopup): (WebCore::RenderPopupMenuWin::hidePopup): (WebCore::RenderPopupMenuWin::setPositionAndSize): (WebCore::RenderPopupMenuWin::addOption): (WebCore::RenderPopupMenuWin::down): (WebCore::RenderPopupMenuWin::up): (WebCore::registerPopup): (WebCore::PopupWndProc):
  • rendering/RenderPopupMenuWin.h:

Added useful properties.

(WebCore::RenderPopupMenuWin::popupHandle):
(WebCore::RenderPopupMenuWin::containerHandle):
(WebCore::RenderPopupMenuWin::wasClicked):
(WebCore::RenderPopupMenuWin::setWasClicked):

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::RenderThemeWin): (WebCore::RenderThemeWin::openButtonTheme): (WebCore::RenderThemeWin::openTextFieldTheme): (WebCore::RenderThemeWin::openMenuListTheme): (WebCore::RenderThemeWin::close): (WebCore::RenderThemeWin::supportsFocus): (WebCore::RenderThemeWin::determineState): (WebCore::RenderThemeWin::getThemeData): (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField):

Refactored the above methods and added cases for
MenulistAppearance where appropriate.

(WebCore::RenderThemeWin::paintMenuList):
(WebCore::RenderThemeWin::adjustMenuListStyle):

Implemented the above methods.

  • rendering/RenderThemeWin.h:
10:44 AM Changeset in webkit [15990] by andersca
  • 10 edits in trunk/JavaScriptCore

2006-08-23 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

Make the bindings compile without CoreFoundation.


  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • bindings/c/c_instance.cpp:
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16):
  • bindings/npapi.h:
  • bindings/runtime.cpp: (KJS::Bindings::Instance::createBindingForLanguageInstance): (KJS::Bindings::Instance::createLanguageInstanceForValue):
  • bindings/runtime_root.cpp:
  • bindings/runtime_root.h:
  • kjs/interpreter.cpp: (KJS::Interpreter::createLanguageInstanceForValue):
  • kjs/interpreter.h:
9:18 AM Changeset in webkit [15989] by rwlbuis
  • 1 edit
    4 adds in trunk/WebCore

Reviewed by Anders. Landed by rwlbuis.

Fixes parts of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support

Note: StringQt.cpp is not part of the original patch, but was
mistakenly omitted from earlier 10467 patch.


7:58 AM Changeset in webkit [15988] by zbujtas
  • 5 edits in S60/trunk/WebKit

2006-08-22 bujtas <​zbujtas@gmail.com>

Reviewed by Sachin.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10515
limit the textarea height so that it can not go beyond
the screen height (it is already done for the width)

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::SetHeight): (CFormInputSkin::SizeForCharacterWidth):
  • BrowserView/inc/WebKitView.h:
  • BrowserView/src/WebKitFrame.cpp: (CWebKitFrame::ConstructL): (CWebKitFrame::~CWebKitFrame): (CWebKitFrame::CalcBidiWidth): (CWebKitFrame::FocusedPlugin):
  • BrowserView/src/WebKitView.cpp: (CWebKitView::FocusChanged): (CWebKitView::MaxBidiSize):
12:29 AM Changeset in webkit [15987] by beidson
  • 5 edits in trunk/WebCore

Reviewed by Maciej

Added escapeSQLString() - a helper to escape strings to be used in textual SQL queries

  • WebCore.xcodeproj/project.pbxproj: Reordered some files
  • loader/icon/IconDataCache.cpp: Use the new escapeSQLString() (WebCore::IconDataCache::writeToDatabase):
  • loader/icon/IconDatabase.cpp: Use the new escapeSQLString() throughout (WebCore::IconDatabase::retainIconURL): (WebCore::IconDatabase::releaseIconURL): (WebCore::IconDatabase::forgetIconForIconURLFromDatabase): (WebCore::IconDatabase::establishIconIDForIconURL): (WebCore::imageDataForIconURLQuery): (WebCore::timeStampForIconURLQuery): (WebCore::iconURLForPageURLQuery): (WebCore::forgetPageURLQuery): (WebCore::setIconIDForPageURLQuery): (WebCore::getIconIDForIconURLQuery): (WebCore::addIconForIconURLQuery): (WebCore::hasIconForIconURLQuery):
  • loader/icon/SQLDatabase.h: (WebCore::escapeSQLString): Added

Aug 22, 2006:

11:59 PM Changeset in webkit [15986] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Brady.


  • remove "loading" flag from WebDataSource and code that manages it; it is redundat.
  • Loader/WebFrameLoader.m: (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]):
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _stopLoading]): (-[WebDataSource _prepareForLoadStart]): (-[WebDataSource _startLoading]): (-[WebDataSource isLoading]):
  • WebView/WebDataSourceInternal.h:
11:50 PM Changeset in webkit [15985] by mjs
  • 9 edits
    3 adds in trunk/WebCore

Reviewed by Brady.

  • assorted style cleanup of icon loader code:


  • wrapped all implementation files in namespace WebCore {} instead of "using namespace WebCore;" at top
  • split headers to be one per class, to match impl files
  • made files that are purely local in IconDatabase.cpp static
  • make each impl file include config.h as first header (and no config.h includes in other headers)
  • avoid multiple copies of Vector<unsigned char> for image data
  • WebCore.xcodeproj/project.pbxproj:
  • loader/icon/IconDataCache.cpp:
  • loader/icon/IconDataCache.h: Added. (WebCore::): (WebCore::IconDataCache::getTimestamp): (WebCore::IconDataCache::setTimestamp): (WebCore::IconDataCache::getIconURL):
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::imageDataForIconURL): (WebCore::IconDatabase::iconForPageURL): (WebCore::pageURLTableIsEmptyQuery): (WebCore::imageDataForIconURLQuery): (WebCore::timeStampForIconURLQuery): (WebCore::iconURLForPageURLQuery): (WebCore::forgetPageURLQuery): (WebCore::setIconIDForPageURLQuery): (WebCore::getIconIDForIconURLQuery): (WebCore::addIconForIconURLQuery): (WebCore::hasIconForIconURLQuery):
  • loader/icon/IconDatabase.h:
  • loader/icon/SQLDatabase.cpp:
  • loader/icon/SQLDatabase.h:
  • loader/icon/SQLStatement.cpp: (WebCore::SQLStatement::getColumnBlobAsVector):
  • loader/icon/SQLStatement.h: Added. (WebCore::SQLStatement::isPrepared): (WebCore::SQLStatement::prepareAndStep): (WebCore::SQLStatement::lastError): (WebCore::SQLStatement::lastErrorMsg):
  • loader/icon/SQLTransaction.cpp:
  • loader/icon/SQLTransaction.h: Added.
11:05 PM Changeset in webkit [15984] by trey
  • 2 edits in trunk/LayoutTests

Reviewed by NOBODY


This test update was missing from the patch I posted, and ggarren just checked in.

  • fast/overflow/scrollRevealButton-expected.txt:
11:01 PM Changeset in webkit [15983] by beidson
  • 4 edits
    1 move in trunk/WebCore

Reviewed by Maciej

The role of the SiteIcon is now the original intention - to be a cache of data relating to an Icon
As such, I'm renaming it to IconDataCache.
Also, the IconDatabase has to manually set the image data on the IconDataCache and also sets the
TimeStamp when an icon is created or the data is changed.
IconDataCache now has a method to write itself *to* a given database, instead of read itself from one.
IconDatabase schema changes to have the timestamp set manually instead of via a trigger.
The overall purpose of this change is to cache the timestamp, killing off a very common SQL query.

  • WebCore.xcodeproj/project.pbxproj: Renamed a file
  • loader/icon/IconDataCache.cpp: Added. (IconDataCache::IconDataCache): (IconDataCache::getImage): Now either returns the stored image, or 0 - no attempt to grab data (IconDataCache::manuallySetImageData): Delete the old image and create the new one (IconDataCache::writeToDatabase): Write the current iconURL, data, and timestamp to the given DB (IconDataCache::imageDataStatus): Determine if an IconDataCache is new without data versus actually having null data
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::createDatabaseTables): Changed DB schema to version 5 (hopefully the final version) (WebCore::IconDatabase::iconForPageURL): (WebCore::IconDatabase::isIconExpiredForIconURL): Uses the timestamp in the IconDataCache object instead of always querying (WebCore::IconDatabase::getOrCreateIconDataCache): Added, to handle creation of new IconDataCache when appropriate (WebCore::IconDatabase::setIconDataForIconURL): Puts data in SiteIcon then marks it for a future write (WebCore::IconDatabase::syncDatabase): Now syncs SiteIconsPendingUpdate
  • loader/icon/IconDatabase.h: (WebCore::IconDataCache::getTimestamp): (WebCore::IconDataCache::setTimestamp):
  • loader/icon/SiteIcon.cpp: Removed.
10:49 PM Changeset in webkit [15982] by mjs
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Eric.

  • test for <rdar://problem/4683948> REGRESSION: Assertion failure in [FrameProgressEntry addChild:forDataSource:] (fandango.com)


(I both added a WebKit assertion that would fail under this test, and then did a fix to make it not fire)


  • fast/loader/start-load-in-unload-expected.txt: Added.
  • fast/loader/start-load-in-unload.html: Added.

WebKit:

Reviewed by Eric.

<rdar://problem/4683948> REGRESSION: Assertion failure in [FrameProgressEntry addChild:forDataSource:] (fandango.com)


  • Loader/WebFrameLoader.m: (-[WebFrameLoader addSubresourceLoader:]): Add a WebKit-level assertion that should fire when this bad situation occurs.
  • Loader/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]): Prevent the situation from occuring.
10:37 PM Changeset in webkit [15981] by mjs
  • 5 edits in trunk/LayoutTests

Fix for broken tests.

  • made newly added CGI scripts executable
  • http/tests/navigation/resources/error404.pl:
  • http/tests/navigation/resources/frameset.pl:
  • http/tests/navigation/resources/postresult.pl:
  • http/tests/navigation/resources/redirect302.pl:
7:32 PM Changeset in webkit [15980] by justing
  • 1 add
    1 delete in trunk/LayoutTests/fast/lists

Forgot to check this in in the previous commit.

5:47 PM Changeset in webkit [15979] by justing
  • 4 edits in trunk

LayoutTests:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=10449>
REGRESSION(r15918): drag-into-marker.html failing

  • editing/pasteboard/paste-list-001-expected.txt:
  • fast/lists/drag-into-marker.html: Added.
  • fast/lists/drag-into-marker.html-disabled: Removed.

WebCore:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=10449>
REGRESSION(r15918): drag-into-marker.html failing

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Don't avoid nesting in a list item.
5:42 PM Changeset in webkit [15978] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Kevin

Added a check in getTIFFRepresentation to not proceed if the frame count is zero
This is an error condition that was handled gracefully before - in certain circumstances
the call to CGImageDestinationCreateWithData will spam the Console if it is passed null/empty data
or invalid data. This small change bails out before that call if that call will definitely fail

  • platform/mac/ImageMac.mm: (WebCore::Image::getTIFFRepresentation):
5:23 PM Changeset in webkit [15977] by harrison
  • 2 edits in trunk/WebCore

Backed out my last change (r15966) because it broke lots of layout tests.

  • editing/TextIterator.cpp: (WebCore::TextIterator::advance):
5:09 PM Changeset in webkit [15976] by mjs
  • 19 edits in trunk

WebCore:

Reviewed by Anders.

  • added some SPI indirections to support the following in WebKit/Loader:
    • pull more WebDataSource code into WebFrameLoader
    • make WebMainResourceLoader not depend on WebKit or on SPI
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

WebKit:

Reviewed by Anders.


  • pull more WebDataSource code into WebFrameLoader
  • make WebMainResourceLoader not depend on WebKit or on SPI
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]): (-[WebFrameLoader _updateIconDatabaseWithURL:]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader _iconLoaderReceivedPageIcon:]): (-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]): (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]): (-[WebFrameLoader cancelContentPolicy]):
  • Loader/WebIconLoader.m: (-[WebIconLoader didFinishLoading]):
  • Loader/WebLoader.m: (-[NSURLProtocol loadWithRequest:]): (-[NSURLProtocol setDefersCallbacks:]):
  • Loader/WebMainResourceLoader.h:
  • Loader/WebMainResourceLoader.m: (-[WebMainResourceLoader initWithFrameLoader:]): (-[WebMainResourceLoader dealloc]): (-[WebMainResourceLoader cancelWithError:]): (-[WebMainResourceLoader continueAfterNavigationPolicy:formState:]): (-[WebMainResourceLoader willSendRequest:redirectResponse:]): (-[WebMainResourceLoader continueAfterContentPolicy:]): (-[WebMainResourceLoader checkContentPolicy]): (-[WebMainResourceLoader didReceiveResponse:]):
  • Plugins/WebPluginContainerCheck.m:
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
  • WebView/WebDataSource.m: (-[WebDataSource _loadIcon]): (-[WebDataSource _cancelledError]): (+[WebDataSource _repTypesAllowImageTypeOmission:]): (+[WebDataSource _representationClassForMIMEType:]): (-[WebDataSource _commitLoadWithData:]): (-[WebDataSource _isDocumentHTML]):
  • WebView/WebDataSourceInternal.h:
  • WebView/WebFramePrivate.h:
  • WebView/WebPolicyDelegate.m:
  • WebView/WebPolicyDelegatePrivate.h:
3:59 PM Changeset in webkit [15975] by justing
  • 50 edits in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4052343&4052343&4426622> Mail hung on paste text


Bugs exposed:

  • editing/pasteboard/paste-4039777-fix-expected.checksum:
  • editing/pasteboard/paste-4039777-fix-expected.png:
  • editing/pasteboard/paste-4039777-fix-expected.txt:
  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/pasteboard/styled-element-markup-expected.checksum:
  • editing/pasteboard/styled-element-markup-expected.png:
  • editing/pasteboard/styled-element-markup-expected.txt:
  • editing/execCommand/insertHTML-expected.checksum:
  • editing/execCommand/insertHTML-expected.png:
  • editing/execCommand/insertHTML-expected.txt:
  • editing/execCommand/insertHTML.html:


Removed some empty style spans, font tags are replaced by style spans
in a couple of cases:

  • editing/deleting/merge-different-styles-expected.txt:
  • editing/deleting/pruning-after-merge-1-expected.txt:
  • editing/deleting/pruning-after-merge-2-expected.txt:
  • editing/inserting/insert-3786362-fix-expected.txt:
  • editing/pasteboard/block-wrappers-necessary-expected.txt:
  • editing/pasteboard/display-block-on-spans-expected.txt:
  • editing/pasteboard/merge-end-table-expected.txt:
  • editing/pasteboard/paste-4035648-fix-expected.txt:
  • editing/pasteboard/paste-line-endings-001-expected.txt:
  • editing/pasteboard/paste-line-endings-006-expected.txt:
  • editing/pasteboard/paste-list-001-expected.txt:
  • editing/pasteboard/paste-pre-001-expected.txt:
  • editing/pasteboard/paste-pre-002-expected.txt:
  • editing/pasteboard/paste-table-001-expected.txt:
  • editing/pasteboard/paste-table-002-expected.txt:
  • editing/pasteboard/paste-text-001-expected.txt:
  • editing/pasteboard/paste-text-002-expected.txt:
  • editing/pasteboard/paste-text-003-expected.txt:
  • editing/pasteboard/paste-text-004-expected.txt:
  • editing/pasteboard/paste-text-005-expected.txt:
  • editing/pasteboard/paste-text-006-expected.txt:
  • editing/pasteboard/paste-text-011-expected.txt:
  • editing/pasteboard/paste-text-012-expected.txt:
  • editing/pasteboard/paste-text-013-expected.txt:
  • editing/pasteboard/paste-text-014-expected.txt:
  • editing/pasteboard/paste-text-015-expected.txt:
  • editing/pasteboard/paste-text-016-expected.txt:
  • editing/pasteboard/paste-text-017-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • editing/pasteboard/styled-element-markup.html:
  • editing/pasteboard/testcase-9507-expected.txt:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:

WebCore:

Reviewed by harrison

<rdar://problem/4052343&4052343&4426622> Mail hung on paste text


  • editing/ReplaceSelectionCommand.cpp: (WebCore::isInterchangeNewlineNode): (WebCore::isInterchangeConvertedSpaceSpan): (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Compute the redundant inheritable styles and remove them and remove style nodes and style spans which were only contributing redundant styles. (WebCore::ReplaceSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.h:
3:25 PM Changeset in webkit [15974] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-08-22 w3liu ​wei.liu@nokia.com

Reviewed by Zalan Bujtas.

WARNING: NO TEST CASES ADDED OR CHANGED

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10514
Thai website www.thairath.com text rendering incorrectly

  • kwq/KWQCharsetData.c:
2:55 PM Changeset in webkit [15973] by spadma
  • 3 edits in S60/trunk/WebKit

2006-08-22 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10496
Fix BC break in PluginAdapterInterface.
Remobe obsolete flags.

  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::~CControlInputWidget):
  • Plugin/inc/PluginAdapterInterface.h: (MPluginNotifier::):
2:05 PM Changeset in webkit [15972] by andersca
  • 8 edits in trunk/JavaScriptCore

2006-08-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

Move the npruntime code over to using HashMap and the runtime_root code over to using
HashMap and HashCountedSet.


  • bindings/NP_jsobject.cpp:
  • bindings/c/c_utility.cpp: (KJS::Bindings::identifierFromNPIdentifier):
  • bindings/c/c_utility.h:
  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::invoke):
  • bindings/npruntime.cpp: (getStringIdentifierMap): (getIntIdentifierMap): (_NPN_GetStringIdentifier): (_NPN_GetIntIdentifier):
  • bindings/runtime_root.cpp: (getReferencesByRootMap): (getReferencesSet): (KJS::Bindings::findReferenceSet): (KJS::Bindings::rootForImp): (KJS::Bindings::rootForInterpreter): (KJS::Bindings::addNativeReference): (KJS::Bindings::removeNativeReference): (RootObject::removeAllNativeReferences):
  • bindings/runtime_root.h:
1:59 PM Changeset in webkit [15971] by harrison
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4077676> Inline hole line adheres to the Japanese characters in inline hole

This happens because the underline is always 2 pixels thick, and placed 3 pixels above the bottom of the text box.

Test case added:

  • manual-tests/inline-input-marking.html: Added. Check that underlining of the inline input hole does not obscure the glyphs.


  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintMarkedTextUnderline): Position underline at bottom of text box. Height of underline is reduced to 1 px when font's descent is less than or equal to 2 px.
1:41 PM Changeset in webkit [22115] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore
1:23 PM Changeset in webkit [15970] by ggaren
  • 3 edits
    107 adds in trunk

LayoutTests:

Reviewed by ggaren.

Introducing a small test suite for bugs related to various navigation techniques,
e.g., back/forward, reload, various redirect flavors, POST, POST-then-redirect,
within-page anchors. Most of the tests are done with and without an enclosing frameset.
The tests verify the content of the final page (which may include restored form
state), scroll location (also sometimes restored), and the full content of the
back-forward list.

  • fast/overflow/scrollRevealButton-expected.txt:

Updated to include scroll location that is now emitted.

  • http/tests/navigation/anchor-basic-expected.txt: Added.
  • http/tests/navigation/anchor-basic.html: Added.
  • http/tests/navigation/anchor-frames-expected.txt: Added.
  • http/tests/navigation/anchor-frames.html: Added.
  • http/tests/navigation/anchor-goback-expected.txt: Added.
  • http/tests/navigation/anchor-goback.html: Added.
  • http/tests/navigation/anchor-subframeload-expected.txt: Added.
  • http/tests/navigation/anchor-subframeload.html: Added.
  • http/tests/navigation/error404-basic-expected.txt: Added.
  • http/tests/navigation/error404-basic.html: Added.
  • http/tests/navigation/error404-frames-expected.txt: Added.
  • http/tests/navigation/error404-frames.html: Added.
  • http/tests/navigation/error404-goback-expected.txt: Added.
  • http/tests/navigation/error404-goback.html: Added.
  • http/tests/navigation/error404-subframeload-expected.txt: Added.
  • http/tests/navigation/error404-subframeload.html: Added.
  • http/tests/navigation/javascriptlink-basic-expected.txt: Added.
  • http/tests/navigation/javascriptlink-basic.html: Added.
  • http/tests/navigation/javascriptlink-frames-expected.txt: Added.
  • http/tests/navigation/javascriptlink-frames.html: Added.
  • http/tests/navigation/javascriptlink-goback-expected.txt: Added.
  • http/tests/navigation/javascriptlink-goback.html: Added.
  • http/tests/navigation/javascriptlink-subframeload-expected.txt: Added.
  • http/tests/navigation/javascriptlink-subframeload.html: Added.
  • http/tests/navigation/metaredirect-basic-expected.txt: Added.
  • http/tests/navigation/metaredirect-basic.html: Added.
  • http/tests/navigation/metaredirect-frames-expected.txt: Added.
  • http/tests/navigation/metaredirect-frames.html: Added.
  • http/tests/navigation/metaredirect-goback-expected.txt: Added.
  • http/tests/navigation/metaredirect-goback.html: Added.
  • http/tests/navigation/metaredirect-subframeload-expected.txt: Added.
  • http/tests/navigation/metaredirect-subframeload.html: Added.
  • http/tests/navigation/post-basic-expected.txt: Added.
  • http/tests/navigation/post-basic.html: Added.
  • http/tests/navigation/post-frames-expected.txt: Added.
  • http/tests/navigation/post-frames-goback1.html-disabled: Added.
  • http/tests/navigation/post-frames.html: Added.
  • http/tests/navigation/post-goback1-expected.txt: Added.
  • http/tests/navigation/post-goback1.html: Added.
  • http/tests/navigation/post-goback2-expected.txt: Added.
  • http/tests/navigation/post-goback2.html: Added.
  • http/tests/navigation/postredirect-basic-expected.txt: Added.
  • http/tests/navigation/postredirect-basic.html: Added.
  • http/tests/navigation/postredirect-frames-expected.txt: Added.
  • http/tests/navigation/postredirect-frames-goback1.html-disabled: Added.
  • http/tests/navigation/postredirect-frames.html: Added.
  • http/tests/navigation/postredirect-goback1-expected.txt: Added.
  • http/tests/navigation/postredirect-goback1.html: Added.
  • http/tests/navigation/postredirect-goback2-expected.txt: Added.
  • http/tests/navigation/postredirect-goback2.html: Added.
  • http/tests/navigation/redirect302-basic-expected.txt: Added.
  • http/tests/navigation/redirect302-basic.html: Added.
  • http/tests/navigation/redirect302-frames-expected.txt: Added.
  • http/tests/navigation/redirect302-frames.html: Added.
  • http/tests/navigation/redirect302-goback-expected.txt: Added.
  • http/tests/navigation/redirect302-goback.html: Added.
  • http/tests/navigation/redirect302-subframeload-expected.txt: Added.
  • http/tests/navigation/redirect302-subframeload.html: Added.
  • http/tests/navigation/relativeanchor-basic-expected.txt: Added.
  • http/tests/navigation/relativeanchor-basic.html: Added.
  • http/tests/navigation/relativeanchor-frames-expected.txt: Added.
  • http/tests/navigation/relativeanchor-frames.html: Added.
  • http/tests/navigation/relativeanchor-goback-expected.txt: Added.
  • http/tests/navigation/relativeanchor-goback.html: Added.
  • http/tests/navigation/resources/error404.pl: Added.
  • http/tests/navigation/resources/frameset.pl: Added.
  • http/tests/navigation/resources/javascriptlink.html: Added.
  • http/tests/navigation/resources/metaredirect.html: Added.
  • http/tests/navigation/resources/otherpage.html: Added.
  • http/tests/navigation/resources/postresult.pl: Added.
  • http/tests/navigation/resources/redirect302.pl: Added.
  • http/tests/navigation/resources/slowmetaredirect.html: Added.
  • http/tests/navigation/resources/slowtimerredirect.html: Added.
  • http/tests/navigation/resources/success200.html: Added.
  • http/tests/navigation/resources/testcode.js: Added.
  • http/tests/navigation/resources/timerredirect.html: Added.
  • http/tests/navigation/slowmetaredirect-basic-expected.txt: Added.
  • http/tests/navigation/slowmetaredirect-basic.html: Added.
  • http/tests/navigation/slowtimerredirect-basic-expected.txt: Added.
  • http/tests/navigation/slowtimerredirect-basic.html: Added.
  • http/tests/navigation/success200-basic-expected.txt: Added.
  • http/tests/navigation/success200-basic.html: Added.
  • http/tests/navigation/success200-frames-expected.txt: Added.
  • http/tests/navigation/success200-frames-goback.html-disabled: Added.
  • http/tests/navigation/success200-frames-loadsame-expected.txt: Added.
  • http/tests/navigation/success200-frames-loadsame.html: Added.
  • http/tests/navigation/success200-frames-reload.html-disabled: Added.
  • http/tests/navigation/success200-frames.html: Added.
  • http/tests/navigation/success200-goback-expected.txt: Added.
  • http/tests/navigation/success200-goback.html: Added.
  • http/tests/navigation/success200-loadsame-expected.txt: Added.
  • http/tests/navigation/success200-loadsame.html: Added.
  • http/tests/navigation/success200-reload-expected.txt: Added.
  • http/tests/navigation/success200-reload.html: Added.
  • http/tests/navigation/success200-subframeload-expected.txt: Added.
  • http/tests/navigation/success200-subframeload-goback.html-disabled: Added.
  • http/tests/navigation/success200-subframeload.html: Added.
  • http/tests/navigation/timerredirect-basic-expected.txt: Added.
  • http/tests/navigation/timerredirect-basic.html: Added.
  • http/tests/navigation/timerredirect-frames-expected.txt: Added.
  • http/tests/navigation/timerredirect-frames.html: Added.
  • http/tests/navigation/timerredirect-goback-expected.txt: Added.
  • http/tests/navigation/timerredirect-goback.html: Added.
  • http/tests/navigation/timerredirect-subframeload-expected.txt: Added.
  • http/tests/navigation/timerredirect-subframeload.html: Added.

WebKitTools:

Reviewed by ggaren.

Added support for a new set of browser navigation tests. The main feature
is the ability for a test to queue up a set of future actions that will
happen after that first page is loaded. This is used to simulate a sequence
of user actions such as filling out forms, loading additional pages or
going back. In addition we can now dump out the state of the back/forward
list, and the scroll position is dumped if not at 0,0.

  • DumpRenderTree/DumpRenderTree.m: (main): Init new state (compareHistoryItems): New utility to support sorting. (dumpHistoryItem): Write out a WebHistoryItem and kids. (dumpFrameScrollPosition): Write out the scroll position. (dump): Optionally write b/f list or scroll position. (-[WaitUntilDoneDelegate processWork:]): Perform queued work. (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]): Kick off any queued actions. Fixed for the case of loads started in a subframe instead of the root frame. (-[WaitUntilDoneDelegate webView:didStartProvisionalLoadForFrame:]): Grab the topmost frame that is being loaded. Do this as early as possible, instead of in didCommitLoadForFrame. (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): Noting a load has started now happens in previous method. (+[LayoutTestController isSelectorExcludedFromWebScript:]): Boilerplate (+[LayoutTestController webScriptNameForSelector:]): Boilerplate (-[LayoutTestController notifyDone]): readyToDump var is subsumed by topFrameLoading (-[LayoutTestController dumpBackForwardList]): New impl, just set a bit. (-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]): Add new work to the queue. (-[LayoutTestController _doLoad:target:]): Do a queued load. (-[LayoutTestController _doBackOrForwardNav:]): Do a queued back/forward. (-[LayoutTestController scheduleBackNav:]): Ways for scripts to queue actions (-[LayoutTestController scheduleForwardNav:]): (-[LayoutTestController scheduleReload]): (-[LayoutTestController scheduleScript:]): (-[LayoutTestController scheduleLoad:target:]): (runTest): Clear new state for each test. Renamed from "dumpRenderTree" since it's not one of the functions that does any dumping.
12:45 PM Changeset in webkit [15969] by andersca
  • 11 edits in trunk/JavaScriptCore

2006-08-22 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.


Switch over the NPAPI and Java bindings to using HashMaps instead of dictionaries.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/c/c_class.cpp: (KJS::Bindings::CClass::CClass): (KJS::Bindings::CClass::~CClass): (KJS::Bindings::CClass::classForIsA): (KJS::Bindings::CClass::methodsNamed): (KJS::Bindings::CClass::fieldNamed):
  • bindings/c/c_class.h:
  • bindings/jni/jni_class.cpp: (JavaClass::JavaClass): (JavaClass::~JavaClass): (JavaClass::methodsNamed): (JavaClass::fieldNamed):
  • bindings/jni/jni_class.h:
  • bindings/objc/objc_class.h:
  • bindings/objc/objc_class.mm: (KJS::Bindings::deleteMethod): (KJS::Bindings::deleteField): (KJS::Bindings::): (KJS::Bindings::ObjcClass::methodsNamed): (KJS::Bindings::ObjcClass::fieldNamed):
  • bindings/runtime.cpp:
  • bindings/runtime.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::getOwnPropertySlot): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut):
11:56 AM Changeset in webkit [15968] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10402
REPRO: SVG crashes inside gradient code

Make sure we do not try to update the canvas resource/gradient paintserver when it is not yet built.

11:39 AM Changeset in webkit [22114] by sfalken
  • 14 edits
    6 adds in branches/WindowsMerge

Interface changes/additions in preparation for forms autofill.
Reviewed by Lou Amadio.

10:28 AM Changeset in webkit [15967] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/4523606> Represent heading elements in AXAttributedStringForTextMarkerRange

  • bridge/mac/WebCoreAXObject.mm: (headingLevel): (-[WebCoreAXObject headingLevel]): (-[WebCoreAXObject isHeading]): New. Heading level is per the tag (h1 == 1, h2 == 2, etc.)


(-[WebCoreAXObject role]):
(-[WebCoreAXObject roleDescription]):
Add role and roleDescription for headings.


(-[WebCoreAXObject value]):
Value is the headingLevel.


(AXAttributeStringSetHeadingLevel):
(AXAttributedStringAppendText):
Put text's heading level (if applicable) in the attributes.

10:24 AM Changeset in webkit [15966] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/4522205> Represent controls in AXAttributedStringForTextMarkerRange

Treat controls as replaced elements, so that AXAttributedStringForTextMarkerRange will, too.


  • editing/TextIterator.cpp: (WebCore::TextIterator::advance): Include controls.
5:47 AM Changeset in webkit [15965] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/4407336> Some non-text elements return AXTextMarkerRangeForUIElement with equal start and end marker

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject textMarkerRange]): Use 0 and maxDeepOffset(), instead of caretMinOffset() and caretMaxRenderedOffset(). Check for VisiblePositions being equal. If so, adjust end one to its next(). That happens with, e.g., buttons.
4:13 AM Changeset in webkit [15964] by rwlbuis
  • 28 edits
    2 deletes in trunk/WebCore

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10491
KCanvasMatrix removal

Remove KCanvasMatrix from project, using AffineTransform instead.

1:20 AM Changeset in webkit [15963] by rwlbuis
  • 4 edits
    4 adds in trunk

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10405
REPRO: SVG Maze crashes in RenderPath code

Do not render a path when it is empty so maze15.svg does not crash anymore.
Also get rid of a runtime warning issued by CGContextGetPathBoundingBox.

12:22 AM Changeset in webkit [15962] by mjs
  • 9 edits in trunk/WebKit

Reviewed by Brady.


  • move more code from WebDataSource to WebFrameLoader


Also marked a few more methods in WebDataSource as likely MOVABLE in a future round, since they do not
use any of WebDataSource's private data.

  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _didReceiveData:contentLength:forResource:]): (-[WebFrameLoader _didFinishLoadingForResource:]): (-[WebFrameLoader _didFailLoadingWithError:forResource:]): (-[WebFrameLoader _privateBrowsingEnabled]): (-[WebFrameLoader _finishedLoadingResource]): (-[WebFrameLoader _receivedError:]): (-[WebFrameLoader _finishedLoading]):
  • Loader/WebMainResourceLoader.m: (-[WebMainResourceLoader didReceiveData:lengthReceived:allAtOnce:]): (-[WebMainResourceLoader didFinishLoading]):
  • Loader/WebNetscapePlugInStreamLoader.m: (-[WebNetscapePlugInStreamLoader didFinishLoading]): (-[WebNetscapePlugInStreamLoader didFailWithError:]): (-[WebNetscapePlugInStreamLoader cancelWithError:]):
  • Loader/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]): (-[WebSubresourceLoader signalFinish]): (-[WebSubresourceLoader didFailWithError:]): (-[WebSubresourceLoader cancel]):
  • Plugins/WebNetscapePluginStream.m: (-[WebNetscapePluginStream start]):
  • WebView/WebDataSource.m: (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): (-[WebDataSource _updateIconDatabaseWithURL:]): (-[WebDataSource _loadIcon]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _cancelledError]): (+[WebDataSource _repTypesAllowImageTypeOmission:]): (+[WebDataSource _representationClassForMIMEType:]): (-[WebDataSource _commitLoadWithData:]): (-[WebDataSource _receivedMainResourceError:complete:]): (-[WebDataSource _iconLoaderReceivedPageIcon:]): (-[WebDataSource _isDocumentHTML]):
  • WebView/WebDataSourceInternal.h:
12:08 AM Changeset in webkit [15961] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Maciej

<rdar://4690949> - New IconDB: Need to prune unretained icons on startup

Added a flag to track whether or not the initial pruning has taken place on startup
If that flag is not set, IconURL retain counts will be tracked in a temporary db table
in addition to the in-memory hash. Then when the timer fires after initial retains
are complete, we prune those icons not in the retain table, prune dangling PageURL
references, delete the temporary table, and set the flag - and carry on as normal

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): initialize the flag (WebCore::IconDatabase::open): changed the schema of the temporary table (WebCore::IconDatabase::retainIconURL): store the icon retain to the temp table if starting up (WebCore::IconDatabase::releaseIconURL): ditto (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): remove all icons *not* in the retain table, then wipe all the PageURLs who no longer point to a valid IconURL
  • loader/icon/IconDatabase.h:

Aug 21, 2006:

9:32 PM Changeset in webkit [15960] by ap
  • 6 edits
    2 adds in trunk

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10419
XSLTProcessor transformToFragment fails because of an XML declaration

Test: fast/xsl/transformToFragment-XML-declaration.html

  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::transformToString): Always inhibit XML declaration printout.
5:51 PM Changeset in webkit [15959] by harrison
  • 4 edits in trunk/WebCore

Reviewed by Justin.

<rdar://problem/4471481> Represent misspellings in AXAttributedStringForTextMarkerRange

Added support for the NSAccessibilityMisspelledTextAttribute.


Test cases added: None. Manual AX testing is way too awkward, and automated testing
is not possible. See following bug...

<rdar://problem/4256882> Need automated testing support for accessibility APIs

  • bridge/mac/WebCoreAXObject.mm: Lots of trivial formatting in many methods.


(-[WebCoreAXObject accessibilityAttributeValue:]):
Fixed AXStartTextMarker and AXEndTextMarker to use startOfDocument and endOfDocument, instead of
of positionForCoordinates. I had seen erroneous endOfDocument results while testing the spelling
attribute.

(WebCore::AXAttributeStringSetSpelling):
New. Adds the NSAccessibilityMisspelledTextAttribute for misspelled words.

(-[WebCoreAXObject AXAttributedStringAppendText:]):
Added call to AXAttributeStringSetSpelling.


  • editing/visible_units.cpp: (WebCore::startOfDocument): (WebCore::endOfDocument): Added for AXStartTextMarker/AXEndTextMarker fix, these forms of the familiar functions take a Node*, so a previously existing VisiblePosition is not required.


  • editing/visible_units.h: Declare new forms of startOfDocument and endOfDocument.
5:16 PM Changeset in webkit [15958] by thatcher
  • 2 edits in trunk/WebKitSite

Reviewed by Darin.

Bug 9302: WebKit nightly download image says ~2.5 MB when
universal binaries make it ~5.0 MB
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9302


  • images/download.png:
4:35 PM Changeset in webkit [15957] by thatcher
  • 22 edits in trunk/WebKitSite

Stamped by Maciej.


Changes many opendarwin.org links to the proper webkit.org version.

  • blog/wp-content/themes/webkit/sidebar.php:
  • blog/wp-content/themes/webkit/style.css:
  • building/build.html:
  • coding/contributing.html:
  • contact.html:
  • index.html:
  • nav.inc:
  • projects/compat/hitlist.html:
  • projects/css/index.html:
  • projects/editing/index.html:
  • projects/forms/index.html:
  • projects/html/index.html:
  • projects/javascript/index.html:
  • projects/svg/index.html:
  • projects/svg/svg-status.xsl:
  • projects/xslt/index.html:
  • quality/bugpriorities.html:
  • quality/bugzilla.html:
  • quality/leakhunting.html:
  • quality/lifecycle.html:
  • quality/reporting.html:
4:26 PM Changeset in webkit [15956] by weinig
  • 1 edit
    1 add in trunk/WebCore

Reviewed by Eric.

Fixes parts of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support

  • platform/qt/TemporaryLinkStubs.cpp: Added. (JavaAppletWidget::JavaAppletWidget): (Font::selectionRectForComplexText): (Font::offsetForPositionForComplexText): (WebCore::refreshPlugins): (WebCore::focusRingColor): (Image::drawTiled): (WebCore::TextField::selectAll): (WebCore::TextField::addSearchResult): (WebCore::TextField::selectionStart): (WebCore::TextField::hasSelectedText): (WebCore::TextField::selectedText): (WebCore::TextField::setAutoSaveName): (WebCore::TextField::checksDescendantsForFocus): (WebCore::TextField::setSelection): (WebCore::TextField::setMaxResults): (WebCore::TextField::edited): (WebCore::TextField::focusPolicy): (WebCore::TextField::TextField): (WebCore::TextField::~TextField): (WebCore::TextField::setFont): (WebCore::TextField::setAlignment): (WebCore::TextField::setWritingDirection): (WebCore::TextField::maxLength): (WebCore::TextField::setMaxLength): (WebCore::TextField::text): (WebCore::TextField::setText): (WebCore::TextField::cursorPosition): (WebCore::TextField::setCursorPosition): (WebCore::TextField::setEdited): (WebCore::TextField::setReadOnly): (WebCore::TextField::setPlaceholderString): (WebCore::TextField::setColors): (WebCore::TextField::sizeForCharacterWidth): (WebCore::TextField::baselinePosition): (WebCore::TextField::setLiveSearch): (WebCore::Slider::Slider): (WebCore::Slider::sizeHint): (WebCore::Slider::~Slider): (WebCore::Slider::setValue): (WebCore::Slider::setMaxValue): (WebCore::Slider::setMinValue): (WebCore::Slider::setFont): (WebCore::Slider::value): (WebCore::Slider::focusPolicy): (WebCore::ScrollBar::ScrollBar): (WebCore::ScrollBar::setSteps): (WebCore::ScrollBar::scroll): (WebCore::ScrollBar::setValue): (WebCore::ScrollBar::setKnobProportion): (WebCore::PlatformScrollBar::PlatformScrollBar): (WebCore::PlatformScrollBar::~PlatformScrollBar): (WebCore::PlatformScrollBar::width): (WebCore::PlatformScrollBar::height): (WebCore::PlatformScrollBar::setEnabled): (WebCore::PlatformScrollBar::paint): (WebCore::PlatformScrollBar::setScrollBarValue): (WebCore::PlatformScrollBar::setKnobProportion): (WebCore::PlatformScrollBar::setRect): (WebCore::PlatformMouseEvent::PlatformMouseEvent): (WebCore::CheckCacheObjectStatus): (WebCore::CheckIfReloading): (WebCore::ServeSynchronousRequest): (WebCore::historyContains): (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::defaultLanguage): (WebCore::findNextSentenceFromIndex): (WebCore::findSentenceBoundary): (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary): (Frame::setNeedsReapplyStyles): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::searchableIndexIntroduction): (WebCore::setFocusRingColorChangeFunction): (FrameView::updateBorder): (loadResourceIntoArray): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (FileButton::FileButton): (FileButton::click): (FileButton::sizeForCharacterWidth): (FileButton::focusPolicy): (FileButton::frameGeometry): (FileButton::setFilename): (FileButton::baselinePosition): (FileButton::setFrameGeometry): (FileButton::setDisabled): (WebCore::supportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):
4:15 PM Changeset in webkit [15955] by weinig
  • 1 edit
    2 adds in trunk/WebCore

Reviewed by Maciej.

Fixes parts of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support

  • platform/qt/CursorQt.cpp: Added. (WebCore::Cursor::Cursor): (WebCore::Cursor::~Cursor): (WebCore::Cursor::operator=): (WebCore::Cursors::Cursors::self): (WebCore::moveCursor): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor): (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor):
  • platform/qt/RenderThemeQt.cpp: Added. (WebCore::RenderThemeQt::RenderThemeQt): (WebCore::RenderThemeQt::supportsHover): (WebCore::RenderThemeQt::paintCheckbox): (WebCore::RenderThemeQt::paintRadio): (WebCore::theme): (WebCore::RenderThemeQt::isControlStyled): (WebCore::RenderThemeQt::controlSupportsTints): (WebCore::RenderThemeQt::systemFont): (WebCore::RenderThemeQt::createPopupMenu): (WebCore::RenderThemeQt::addIntrinsicMargins): (WebCore::RenderThemeQt::stylePainterAndWidgetForPaintInfo): (WebCore::RenderThemeQt::setCheckboxSize): (WebCore::RenderThemeQt::setRadioSize): (WebCore::RenderThemeQt::supportsFocus): (WebCore::RenderThemeQt::applyTheme): (WebCore::RenderThemeQt::adjustButtonStyle): (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::adjustTextFieldStyle): (WebCore::RenderThemeQt::paintTextField):
4:04 PM Changeset in webkit [15954] by weinig
  • 1 edit
    3 adds in trunk/WebCore

Reviewed by Maciej.

Fixes parts of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
WebKit should have Qt platform support

  • platform/qt/SharedTimerQt.cpp: Added. (WebCore:setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
  • platform/qt/SharedTimerQt.h: Added. (WebCore::SharedTimerQt::SharedTimerQt): (WebCore::SharedTimerQt::~SharedTimerQt): (WebCore::SharedTimerQt::inst): (WebCore::SharedTimerQt::fire):
  • platform/qt/SystemTimeQt.cpp: Added. (WebCore::currentTime):
2:05 PM Changeset in webkit [15953] by beidson
  • 5 edits in trunk

WebCore:

Reviewed by John

-Defers writing to the database via a timer and handles starting the timer

intelligently

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::open): Don't start the update timer by default (WebCore::IconDatabase::close): Call syncDatabase() (WebCore::IconDatabase::setPrivateBrowsingEnabled): Call syncDatabase() (WebCore::IconDatabase::setIconURLForPageURL): Setup the cached url, but defer the DB call (WebCore::IconDatabase::setIconURLForPageURLInDatabase): Actually commit the url to the DB (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): (WebCore::IconDatabase::updateDatabase): The updateTimer calls this, which just calls syncDatabase() (WebCore::IconDatabase::syncDatabase): Add and remove pending pageURLs and iconURLs, and stop the updateTimer
  • loader/icon/IconDatabase.h:

WebKit:

Reviewed by John

Quick ICONDEBUG flag fix

  • Misc/WebIconDatabase.m: (-[WebIconDatabase _applicationWillTerminate:]):
10:43 AM Changeset in webkit [15952] by ap
  • 5 edits
    3 adds in trunk

2006-08-21 Vladimir Olexa <​vladimir.olexa@gmail.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6252
JavaScript 1.6 Array.lastIndexOf

Test: fast/js/array-lastIndexOf.html

  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Added a LastIndexOf case.
  • kjs/array_object.h: (KJS::ArrayProtoFunc::): Added LastIndexOf to enum.
  • tests/mozilla/expected.html: Two more tests now pass.
9:55 AM Changeset in webkit [15951] by ap
  • 3 edits
    3 adds in trunk

Reviewed by Eric.

Test: fast/js/xslt-fragment-in-empty-doc.html

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer): Don't iterate over the element stack if it's empty.
1:55 AM Changeset in webkit [15950] by beidson
  • 4 edits in trunk/WebKit

Reviewed by Anders

-Renamed an internal only method for clarity
-Tweaked WebDataSource for notification purposes with the new expiring icons
-Fixed a bug with the ICONDEBUG flag

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase iconForURL:withSize:cache:]): #ifdef bug fixed (-[WebIconDatabase _hasEntryForIconURL:]): Renamed for clarity
  • Misc/WebIconDatabasePrivate.h:
  • WebView/WebDataSource.m: (-[WebDataSource _updateIconDatabaseWithURL:]): (-[WebDataSource _notifyIconChanged:]): (-[WebDataSource _loadIcon]): (-[WebDataSource _iconLoaderReceivedPageIcon:]):
1:55 AM Changeset in webkit [15949] by beidson
  • 5 edits in trunk/WebCore

Reviewed by Anders

-Added timer-based, deferred deletion of database records - PageURLs and Icons handled seperately

In the near future, we'll also have timer-based deferred *addition* of database records

-Keep retain/release counts in a hash instead of a DB table
-Keep only one hash record for the SiteIcons
-Renamed some methods for clarity

  • bridge/mac/WebCoreIconDatabaseBridge.h: Renamed method for clarity
  • bridge/mac/WebCoreIconDatabaseBridge.mm: Ditto (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]): Ditto
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::open): Added new timer setup (WebCore::IconDatabase::iconForPageURL): Only work with one hash of the SiteIcons (WebCore::IconDatabase::retainIconForPageURL): Keep count in a hash (WebCore::IconDatabase::releaseIconForPageURL): Keep count in a hash, use deferred deletion (WebCore::IconDatabase::retainIconURL): Added (WebCore::IconDatabase::releaseIconURL): Added (WebCore::IconDatabase::forgetPageURL): Added (WebCore::IconDatabase::isIconURLRetained): New and improved simplicity (WebCore::IconDatabase::setIconDataForIconURL): Cleanup (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Renamed (WebCore::IconDatabase::pruneIconsPendingDeletion): Added (WebCore::IconDatabase::hasEntryForIconURL): Renamed for clarity
  • loader/icon/IconDatabase.h: Added multiple stuffs
12:51 AM Changeset in webkit [15948] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej's rubberstamp

Removed stale file references from the Xcode.proj

  • WebCore.xcodeproj/project.pbxproj:

Aug 20, 2006:

5:01 PM Changeset in webkit [15947] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Brady.


  • pull a bit of WebDataSource code into WebFrameLoader
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _receivedError:]): (-[WebFrameLoader webFrame]): (-[WebFrameLoader _handleFallbackContent]): (+[WebFrameLoader _canShowMIMEType:]): (+[WebFrameLoader _representationExistsForURLScheme:]): (+[WebFrameLoader _generatedMIMETypeForURLScheme:]):
  • WebView/WebDataSource.m:
  • WebView/WebDataSourceInternal.h:
3:27 PM Changeset in webkit [15946] by rwlbuis
  • 17 edits in trunk

JavaScriptCore:

Reviewed by Maciej. Landed by rwlbuis.

Fixes parts of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
WebKit should have Qt platform support

Removing obsolete QConstString/QString constructors in kjs code.

WebCore:

Reviewed by Maciej. Landed by rwlbuis.

Fixes parts of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
WebKit should have Qt platform support

Removing HelperQt.h usage by creating appropriate operators
constructor in some of the platform classes, as suggested by Darin.

Note: See TracTimeline for information about the timeline view.