Context Navigation

platform/Image.cpp: (WebCore::Image::shouldAnimate): Don't check that there is more than one frame, maybe the rest just hasn't been loaded yet. (WebCore::Image::startAnimation): Move the frame count check here - there is no need to start animating before we get at least two frames.

9:46 PM Changeset in webkit [16416] by eseidel

1 edit
2 adds in trunk/LayoutTests

2006-09-17 Eric Seidel <eric@eseidel.com>

Add a textual dump of the window object property tree.

Reviewed by Sarge.

fast/js/window-properties-expected.txt: Added.
fast/js/window-properties.html: Added.

5:48 PM Changeset in webkit [16415] by hyatt

6 edits in trunk/LayoutTests/tables/mozilla/bugs

Land updated tests for font changes.

5:46 PM Changeset in webkit [16414] by hyatt

3 edits in trunk/LayoutTests/css2.1

Land updated tests for font changes.

5:45 PM Changeset in webkit [16413] by hyatt

6 edits in trunk/LayoutTests/css1/font_properties

Land updated tests for font changes.

4:17 PM Changeset in webkit [16412] by beidson

2 edits in trunk/WebCore

Reviewed by Sarge

IconLoader now gracefully handles the condition where there's no document in the frame
(ie. PDFs)

loader/icon/IconLoader.cpp: (IconLoader::startLoading):

4:06 PM Changeset in webkit [16411] by hyatt

5 edits in trunk/WebCore

Fix for bug 10899, rework how CSS keywords work to be smarter about
using the correct size when generic families change (e.g., monospace to
serif and vice versa).

Reviewed by aroben

Added fast/text/basic/generic-family-changes.html

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::checkForGenericFamilyChange): (WebCore::CSSStyleSelector::fontSizeForKeyword):
css/cssstyleselector.h:
dom/Document.cpp: (WebCore::Document::recalcStyle):
platform/FontDescription.h: (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::keywordSize): (WebCore::FontDescription::setKeywordSize): (WebCore::FontDescription::operator==):

4:04 PM Changeset in webkit [16410] by hyatt

1 edit
4 adds in trunk/LayoutTests

Adding layout test for bug 10899.

fast/text/basic/generic-family-changes-expected.checksum: Added.
fast/text/basic/generic-family-changes-expected.png: Added.
fast/text/basic/generic-family-changes-expected.txt: Added.
fast/text/basic/generic-family-changes.html: Added.

2:39 PM Changeset in webkit [16409] by aroben

4 edits in trunk/WebKitTools

Reviewed by hyatt, sfalken.

Get DumpRenderTree compiling and limping along on Windows.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (loadResourceIntoArray): Added this function that WebCore::ImageWin needs from WebKit (main): Add NULL argument to Page constructor.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Remove incorrect "wininet.dll" argument to CC, fix JavaScriptCore.lib path, add *_SECURE_NO_DEPRECATE #defines
Scripts/webkitdirs.pm: Fix JavaScriptCore.lib path

1:18 PM Changeset in webkit [16408] by ap

4 edits
2 adds in trunk

Reviewed by Brady.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10852
REGRESSION: Reproducible crash in XMLHttpRequest::abort()

Test: http/tests/xmlhttprequest/xhr-onunload.html

xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): Check the return value of ResourceLoader::start().

loader/icon/IconLoader.cpp: (IconLoader::startLoading): Fix a similar latent bug here.

12:37 PM Changeset in webkit [16407] by aroben

2 edits in trunk/WebCore

Build fix.

loader/icon/IconDatabase.cpp:

12:29 PM Changeset in webkit [22176] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Build fix.

WebView.cpp: (WebView::keyPress): Add new "userTriggered" argument to calls to SelectionController::modify

12:24 PM Changeset in webkit [16406] by hyatt

1 edit in trunk/LayoutTests/fast/text/whitespace/013-expected.txt

Land updated results from font fix yesterday.

11:36 AM Changeset in webkit [16405] by andersca

29 edits in trunk/WebCore

2006-09-17 Anders Carlsson <acarlsson@apple.com>

Reviewed by Brady.

Add simplifyWhiteSpace and stripWhiteSpace to the String class.
Change the XSLT Parameter Map to use Strings instead of StringImpls.
General cleanup.

bindings/js/JSXSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
bindings/js/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute):
css/MediaList.cpp: (WebCore::MediaList::setMediaText):
dom/Document.cpp: (WebCore::Document::processHttpEquiv):
editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init):
html/HTMLDocument.cpp: (WebCore::parseDocTypeDeclaration):
html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute):
html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::attach): (WebCore::HTMLObjectElement::setComplete): (WebCore::HTMLObjectElement::detach): (WebCore::HTMLObjectElement::recalcStyle): (WebCore::HTMLObjectElement::childrenChanged): (WebCore::HTMLObjectElement::isImageType):
html/HTMLObjectElement.h:
html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::value):
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::appendFormData):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
ksvg2/svg/SVGColor.cpp: (WebCore::SVGColor::setRGBColor):
ksvg2/svg/SVGDescElement.cpp: (WebCore::SVGDescElement::description):
platform/PlatformString.h:
platform/String.cpp: (WebCore::String::stripWhiteSpace): (WebCore::String::simplifyWhiteSpace):
platform/StringImpl.cpp: (WebCore::isSpace): (WebCore::parseLength): (WebCore::StringImpl::stripWhiteSpace): (WebCore::StringImpl::simplifyWhiteSpace): (WebCore::StringImpl::toInt):
platform/StringImpl.h:
platform/mac/ClipboardMac.mm: (WebCore::cocoaTypeFromMIMEType):
rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):
xml/XPathFunctions.cpp: (WebCore::XPath::FunNormalizeSpace::doEvaluate):
xml/XPathGrammar.y:
xml/XPathStep.cpp: (WebCore::XPath::Step::nodeTestMatches):
xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::loadChildSheets): (WebCore::XSLStyleSheet::locateStylesheetSubResource):
xml/XSLTProcessor.cpp: (WebCore::xsltParamArrayFromParameterMap): (WebCore::XSLTProcessor::setParameter): (WebCore::XSLTProcessor::getParameter): (WebCore::XSLTProcessor::removeParameter):
xml/XSLTProcessor.h:
xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getStatusText):

8:28 AM Changeset in webkit [16404] by hyatt

4 adds in trunk/LayoutTests/fast/forms

Add fieldset layout test.

8:27 AM Changeset in webkit [16403] by hyatt

7 edits in trunk/WebCore

Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
are declared right before the fieldsets. It turns out fieldsets in other
browsers avoid floats (like overflow:auto/hidden/scroll sections do), so
adding that behavior to fieldset fixes the bug.

Made avoidsFloats virtual and did some refactoring to make tables, flexboxes
and fieldsets all subclass.

Reviewed by anders

Added fast/forms/float-before-fieldset.html

rendering/RenderFieldset.h: (WebCore::RenderFieldset::avoidsFloats):
rendering/RenderFlexibleBox.h: (WebCore::RenderFlexibleBox::avoidsFloats):
rendering/RenderObject.cpp: (WebCore::RenderObject::avoidsFloats):
rendering/RenderObject.h:
rendering/RenderTable.h: (WebCore::RenderTable::avoidsFloats):

7:35 AM Changeset in webkit [16402] by hyatt

1 edit in trunk/LayoutTests/tables/mozilla/bugs/bug24200.html

Update buggy table test to not have a degenrate column structure.

7:35 AM Changeset in webkit [16401] by hyatt

1 edit in trunk/LayoutTests/tables/mozilla_expected_failures/core/table_rules.html

Update buggy table test to say rules=groups and not rules=group

1:00 AM Changeset in webkit [16400] by hyatt

4 adds in trunk/LayoutTests/fast/table

Add frame/rules layout test.

12:57 AM Changeset in webkit [16399] by hyatt

9 edits in trunk/WebCore

Fix for bugzilla bug 3240, implement support for the HTML4 "frame" and
"rules" attributes on tables.

Reviewed by bradee-oh

Well-covered by existing layout tests.

html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::additionalAttributeStyleDecl):
html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::additionalAttributeStyleDecl):
html/HTMLTableColElement.h:
html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::HTMLTableElement): (WebCore::HTMLTableElement::~HTMLTableElement): (WebCore::HTMLTableElement::setCaption): (WebCore::HTMLTableElement::setTHead): (WebCore::HTMLTableElement::setTFoot): (WebCore::HTMLTableElement::setTBody): (WebCore::HTMLTableElement::createTHead): (WebCore::HTMLTableElement::deleteTHead): (WebCore::HTMLTableElement::createTFoot): (WebCore::HTMLTableElement::deleteTFoot): (WebCore::HTMLTableElement::createCaption): (WebCore::HTMLTableElement::deleteCaption): (WebCore::HTMLTableElement::insertRow): (WebCore::HTMLTableElement::deleteRow): (WebCore::HTMLTableElement::addChild): (WebCore::HTMLTableElement::childrenChanged): (WebCore::HTMLTableElement::mapToEntry): (WebCore::HTMLTableElement::parseMappedAttribute): (WebCore::HTMLTableElement::additionalAttributeStyleDecl): (WebCore::HTMLTableElement::getSharedCellDecl): (WebCore::HTMLTableElement::getSharedGroupDecl): (WebCore::HTMLTableElement::attach):
html/HTMLTableElement.h: (WebCore::HTMLTableElement::caption): (WebCore::HTMLTableElement::tHead): (WebCore::HTMLTableElement::tFoot): (WebCore::HTMLTableElement::):
html/HTMLTableRowElement.h:
html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecl):
html/HTMLTableSectionElement.h:

12:43 AM Changeset in webkit [16398] by hyatt

4 adds in trunk/LayoutTests/fast/text/basic

Add layout test for bug 4192.

12:39 AM Changeset in webkit [16397] by hyatt

1 edit in trunk/WebCore/ChangeLog

Fix for bugzilla bug 4192, font size wrong for <tt> elements that
specify their own new font-family list. Make sure to always
reset the generic family along with the family list when mapping in
new font-family values.

Reviewed by bradee-oh

fast/text/basic/generic-family-reset.html

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):

12:39 AM Changeset in webkit [16396] by hyatt

2 edits in trunk/WebCore

Fix for bugzilla bug 4129, font size wrong for <tt> elements that
specify their own new font-family list. Make sure to always
reset the generic family along with the family list when mapping in
new font-family values.

Reviewed by bradee-oh

fast/text/basic/generic-family-reset.html

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):

12:29 AM Changeset in webkit [16395] by beidson

18 edits
2 deletes in trunk

WebCore:

Reviewed by Hyatt

Pruning code relating to WebKit's icon loader

bridge/mac/WebCoreIconDatabaseBridge.h:
bridge/mac/WebCoreIconDatabaseBridge.mm:
loader/icon/IconDatabase.h:
page/Frame.cpp: (WebCore::Frame::endIfNotLoading): Moved a FIXME in from WebKit's IconLoader to its new home

WebKit:

Reviewed by Hyatt

WebIconLoader is dead, long live WebCore::IconLoader
(code prune)

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader dealloc]): (-[WebFrameLoader commitProvisionalLoad]):
Loader/WebIconLoader.h: Removed.
Loader/WebIconLoader.m: Removed.
Misc/WebIconDatabase.h:
Misc/WebIconDatabase.m:
Misc/WebIconDatabasePrivate.h:
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge notifyIconChanged:]):
WebCoreSupport/WebIconDatabaseBridge.h:
WebCoreSupport/WebIconDatabaseBridge.m: (-[WebIconDatabaseBridge _init]): (-[WebIconDatabaseBridge _setIconData:forIconURL:]): (-[WebIconDatabaseBridge _setHaveNoIconForIconURL:]):
WebKit.exp:
WebKit.xcodeproj/project.pbxproj:
WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _stopLoading]): (-[WebDataSource _setPrimaryLoadComplete:]):
WebView/WebDataSourceInternal.h:

Sep 16, 2006:

2:13 PM Changeset in webkit [16394] by weinig

9 edits
2 deletes in trunk/WebCore

Reviewed by Tim H.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10885
Auto-generate DOMHTMLDocument for the Objective-C bindings

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOMExtensions.h:
bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument createDocumentFragmentWithText:]):
bindings/objc/DOMHTMLDocument.h: Removed.
bindings/objc/DOMHTMLDocument.mm: Removed.
bindings/objc/PublicDOMInterfaces.h:
bindings/scripts/CodeGeneratorObjC.pm:
html/HTMLDocument.idl:
platform/DeprecatedString.h: (WebCore::DeprecatedString::operator NSString*):

9:15 AM Changeset in webkit [16393] by rwlbuis

15 edits in trunk/WebCore

Reviewed by Eric.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10866
Code in kcanvas/ should not use Private

Remove Private classes and tweak coding style.

8:13 AM Changeset in webkit [16392] by bdash

4 edits in trunk

2006-09-16 Mark Rowe <opendarwin.org@bdash.net.nz>

Reviewed by Anders.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10887
Fix build error

bindings/objc/DOMPrivate.h: Remove reference to DOMEventPrivate.h.

2006-09-16 Mark Rowe <opendarwin.org@bdash.net.nz>

Reviewed by Anders.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10887
Fix build error

MigrateHeaders.make: Remove reference to DOMEventPrivate.h.

8:11 AM Changeset in webkit [16391] by weinig

2 edits in trunk/WebCore

Reviewed by Anders.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10886
REGRESSION (r16387): Reproducible crash when mousing over HTML document

Special case method [DOMNode ownerDocument] to call document() instead or ownerDocument() to return to the old behavior.

WebCore.xcodeproj/project.pbxproj:
bindings/scripts/CodeGeneratorObjC.pm:

Sep 15, 2006:

9:19 PM Changeset in webkit [16390] by beidson

1 edit in trunk/WebCore/ChangeLog

My ChangeLog msg got out of order. *sigh*

9:17 PM Changeset in webkit [16389] by beidson

2 edits in trunk/WebCore

Reviewed by Brady.

Make new style ObjC methods public API.

WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOMPrivate.h:
bindings/objc/PublicDOMInterfaces.h:

9:04 PM Changeset in webkit [16388] by thatcher

6 edits in trunk

WebCore:

Reviewed by Brady.

Make new style ObjC methods public API.

WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOMPrivate.h:
bindings/objc/PublicDOMInterfaces.h:

WebKit:

Reviewed by Brady.

Make new style ObjC methods public API.

MigrateHeaders.make:

8:30 PM Changeset in webkit [16387] by weinig

11 edits
2 deletes in trunk

WebCore:

Reviewed by Tim H.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10870
Auto-generate DOMNode for the Objective-C bindings

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm: (-[DOMNode boundingBox]): (-[DOMNode lineBoxRects]):
bindings/objc/DOMEvents.h:
bindings/objc/DOMExtensions.h:
bindings/objc/DOMNode.h: Removed.
bindings/objc/DOMNode.mm: Removed.
bindings/objc/PublicDOMInterfaces.h:
bindings/scripts/CodeGeneratorObjC.pm:
dom/Node.idl:

WebKit:

Reviewed by Tim H.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10870
Auto-generate DOMNode for the Objective-C bindings

MigrateHeaders.make:

7:24 PM Changeset in webkit [16386] by thatcher

10 edits in trunk

WebCore:

Reviewed by Justin.

Removed alter selection logic from WebCoreFrameBridge and moved to SelectionController.

bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge centerSelectionInVisibleArea]): (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]): (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]): (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]): (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]): (-[WebCoreFrameBridge replaceMarkedTextWithText:]): (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreFrameBridge increaseSelectionListLevel]): (-[WebCoreFrameBridge increaseSelectionListLevelOrdered]): (-[WebCoreFrameBridge increaseSelectionListLevelUnordered]): (-[WebCoreFrameBridge decreaseSelectionListLevel]): (-[WebCoreFrameBridge insertLineBreak]): (-[WebCoreFrameBridge insertParagraphSeparator]): (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]): (-[WebCoreFrameBridge insertText:selectInsertedText:]): (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]): (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]): (createMouseEventFromDraggingInfo):
editing/SelectionController.cpp: (WebCore::SelectionController::moveTo): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::modify): (WebCore::SelectionController::setBase): (WebCore::SelectionController::setExtent):
editing/SelectionController.h:
page/Frame.cpp: (WebCore::Frame::revealSelection): (WebCore::Frame::revealCaret):
page/Frame.h:

WebKit:

Reviewed by Justin.

Call the bridge directly for alter selection calls. All of this logic is now
in WebCore's SelectionController.

WebView/WebHTMLView.m: (-[NSArray moveBackward:]): (-[NSArray moveBackwardAndModifySelection:]): (-[NSArray moveDown:]): (-[NSArray moveDownAndModifySelection:]): (-[NSArray moveForward:]): (-[NSArray moveForwardAndModifySelection:]): (-[NSArray moveLeft:]): (-[NSArray moveLeftAndModifySelection:]): (-[NSArray moveRight:]): (-[NSArray moveRightAndModifySelection:]): (-[NSArray moveToBeginningOfDocument:]): (-[NSArray moveToBeginningOfDocumentAndModifySelection:]): (-[NSArray moveToBeginningOfSentence:]): (-[NSArray moveToBeginningOfSentenceAndModifySelection:]): (-[NSArray moveToBeginningOfLine:]): (-[NSArray moveToBeginningOfLineAndModifySelection:]): (-[NSArray moveToBeginningOfParagraph:]): (-[NSArray moveToBeginningOfParagraphAndModifySelection:]): (-[NSArray moveToEndOfDocument:]): (-[NSArray moveToEndOfDocumentAndModifySelection:]): (-[NSArray moveToEndOfSentence:]): (-[NSArray moveToEndOfSentenceAndModifySelection:]): (-[NSArray moveToEndOfLine:]): (-[NSArray moveToEndOfLineAndModifySelection:]): (-[NSArray moveToEndOfParagraph:]): (-[NSArray moveToEndOfParagraphAndModifySelection:]): (-[NSArray moveParagraphBackwardAndModifySelection:]): (-[NSArray moveParagraphForwardAndModifySelection:]): (-[NSArray moveUp:]): (-[NSArray moveUpAndModifySelection:]): (-[NSArray moveWordBackward:]): (-[NSArray moveWordBackwardAndModifySelection:]): (-[NSArray moveWordForward:]): (-[NSArray moveWordForwardAndModifySelection:]): (-[NSArray moveWordLeft:]): (-[NSArray moveWordLeftAndModifySelection:]): (-[NSArray moveWordRight:]): (-[NSArray moveWordRightAndModifySelection:]): (-[NSArray pageUp:]): (-[NSArray pageDown:]): (-[NSArray pageUpAndModifySelection:]): (-[NSArray pageDownAndModifySelection:]):

6:40 PM Changeset in webkit [16385] by beidson

3 edits in trunk/WebCore

Reviewed by Anders

Added the ability to get a mutable char* from a CString, which will copy the internal
buffer if the ref count is greater than 1 so your mutable char* won't affect any other
referrer of that buffer.

platform/CString.cpp: (WebCore::CString::mutableData): (WebCore::CString::copyBufferIfNeeded):
platform/CString.h:

6:17 PM Changeset in webkit [16384] by justing

4 edits
4 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4674869>
REGRESSION: selecting text to write over results in cursor jumping to middle of next line

editing/deleting/whitespace-pre-1-expected.checksum: Added.
editing/deleting/whitespace-pre-1-expected.png: Added.
editing/deleting/whitespace-pre-1-expected.txt: Added.
editing/deleting/whitespace-pre-1.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4674869>
REGRESSION: selecting text to write over results in cursor jumping to middle of next line

editing/SelectionController.cpp: (WebCore::SelectionController::modify): Added lineBoundary to test fix.
editing/visible_units.cpp: (WebCore::endOfLine): If the last box on the line is a lineBreak, return the position before it, not after it.

5:55 PM Changeset in webkit [16383] by bdash

4 edits in trunk/WebKitTools

2006-09-15 Mark Rowe <opendarwin.org@bdash.net.nz>

Reviewed by Brady.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10635
Bug 10635: Buildbot configuration in SVN is out of sync with build.webkit.org

BuildSlaveSupport/build.webkit.org-config/webkit/builders.py: Reorder build slaves within build factories in an attempt to spread the load evenly.
BuildSlaveSupport/build.webkit.org-config/webkit/status.py: Return to sending status emails to <svnuser>@opensource.apple.com addresses.
BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Update configuration to match changes in Buildbot. Always do clean SVG builds.

5:39 PM Changeset in webkit [16382] by bdash

18 edits
1 add in trunk

2006-09-15 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Adam.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10864
Bug 10864: Linux\GDK build fixes

JavaScriptCoreSources.bkl:
jscore.bkl:

2006-09-15 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Adam.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10864
Bug 10864: Linux\GDK build fixes

Projects/gdk/webcore-gdk.bkl:
WebCoreSources.bkl:
platform/gdk/FontCacheGdk.cpp:
platform/gdk/FontDataGdk.cpp: (WebCore::FontData::platformInit):
platform/gdk/FontGdk.cpp: (WebCore::Font::drawGlyphs):
platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::handleGdkEvent):
platform/gdk/FrameGdk.h:
platform/gdk/ImageGdk.cpp: Added. (WebCore::Image::initPlatformData): (WebCore::Image::invalidatePlatformData): (WebCore::Image::loadPlatformResource): (WebCore::Image::supportsType):
platform/gdk/RenderPopupMenuGdk.cpp: (WebCore::RenderPopupMenuGdk::hidePopup):
platform/gdk/RenderPopupMenuGdk.h:
platform/gdk/ScreenGdk.cpp: (WebCore::drawableForPage): (WebCore::screenRect): (WebCore::screenDepth): (WebCore::usableScreenRect): (WebCore::scaleFactor):
platform/gdk/SystemTimeLinux.cpp: (WebCore::currentTime):
platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::bindingRootObject): (FrameGdk::markMisspellings): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (FrameGdk::shouldChangeSelection): (FrameGdk::respondToChangedSelection): (FrameGdk::respondToChangedContents): (Path::contains): (PlatformScrollBar::PlatformScrollBar): (PlatformScrollBar::~PlatformScrollBar): (PlatformScrollBar::width): (PlatformScrollBar::height): (PlatformScrollBar::setEnabled): (PlatformScrollBar::paint): (PlatformScrollBar::setScrollBarValue): (PlatformScrollBar::setKnobProportion): (PlatformScrollBar::setRect): (ScrollBar::ScrollBar): (FileChooser::FileChooser): (FileChooser::~FileChooser): (FileChooser::openFileChooser): (FileChooser::basenameForWidth): (FileChooser::uploadControlDetaching): (FileChooser::chooseFile): (Icon::Icon): (Icon::~Icon): (Icon::newIconForFile): (Icon::paint): (IconLoader::stopLoading): (IconLoader::startLoading): (IconLoader::createForFrame): (IconDatabase::isIconExpiredForIconURL): (IconDatabase::hasEntryForIconURL): (IconDatabase::sharedIconDatabase):
platform/gdk/WidgetGdk.cpp:
webcore-base.bkl:

5:36 PM Changeset in webkit [16381] by thatcher

3 edits in trunk/LayoutTests

Reviewed by Justin.

Updating results to new expected values.

fast/lists/drag-into-marker-expected.txt:
fast/repaint/selection-after-delete-expected.txt:

5:26 PM Changeset in webkit [16380] by aroben

2 edits in trunk/JavaScriptCore

Windows build fix.

JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:

4:57 PM Changeset in webkit [16379] by thatcher

3 edits in trunk/LayoutTests

Reviewed by Justin.

Updating results to new expected values.

editing/inserting/4278698-expected.txt:
fast/dom/window-xy-properties-expected.txt:

4:55 PM Changeset in webkit [16378] by bdash

18 edits
1 add in trunk/WebCore

2006-09-15 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Eric.

Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10835
Fix svg memory leaks.

Reworked SVGList to deal with RefPtr's for ptr types
which makes manual refcounting unnecessary, and is much safer.

Removing all virtual functions (nullItem) from SVGList, and
also remove SVGListBase. Switch to a similar concept like
Vector/VectorTraits (see new file SVGListTraits.h).

Credits go to Eric/Maciej for the inspiration.

CMakeLists.txt: Add SVGListTraits.cpp to build
WebCore.xcodeproj/project.pbxproj: Ditto.
bindings/scripts/CodeGeneratorJS.pm: Generator changes for SVGTransform/PathSeg/LengthList (now RefPtr based)
kcanvas/RenderSVGText.cpp: Add some get() methods, as SVGLengthList is RefPtr based now. (WebCore::RenderSVGText::translationForAttributes):
ksvg2/svg/SVGAnimateTransformElement.cpp: Add some get() methods, as SVGTransformList is RefPtr based now. (WebCore::SVGAnimateTransformElement::handleTimerEvent):
ksvg2/svg/SVGElementInstanceList.cpp: Be RefPtr based. (WebCore::SVGElementInstanceList::SVGElementInstanceList):
ksvg2/svg/SVGElementInstanceList.h:
ksvg2/svg/SVGLengthList.cpp: Ditto. (WebCore::SVGLengthList::SVGLengthList):
ksvg2/svg/SVGLengthList.h: Ditto.
ksvg2/svg/SVGList.h: Rewrote, as described above. (WebCore::SVGListTypeOperations::nullItem): (WebCore::SVGList::SVGList): (WebCore::SVGList::~SVGList): (WebCore::SVGList::clear): (WebCore::SVGList::getFirst): (WebCore::SVGList::getLast): (WebCore::SVGList::getItem): (WebCore::SVGList::replaceItem): (WebCore::SVGList::removeItem):
ksvg2/svg/SVGListTraits.cpp: Added.
ksvg2/svg/SVGListTraits.h: Added. (WebCore::):
ksvg2/svg/SVGPathElement.cpp: Add some get() methods, as SVGPathSegList is RefPtr based now. (WebCore::SVGPathElement::toPathData):
ksvg2/svg/SVGPathSegList.cpp: Be RefPtr based. (WebCore::SVGPathSegList::SVGPathSegList):
ksvg2/svg/SVGPathSegList.h: Ditto.
ksvg2/svg/SVGTransform.cpp: Style cleanup. (SVGTransform::SVGTransform):
ksvg2/svg/SVGTransformList.cpp: Be RefPtr based. (SVGTransformList::SVGTransformList): (SVGTransformList::createSVGTransformFromMatrix): (SVGTransformList::consolidate):
ksvg2/svg/SVGTransformList.h: Ditto.
ksvg2/svg/SVGTransformable.cpp: Fix RefPtr usage of SVGTransform. (SVGTransformable::parseTransformAttribute):

4:30 PM Changeset in webkit [16377] by eseidel

5 edits in trunk/WebCore

2006-09-15 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Fix build on Qt/Linux and implement Frame::addMessageToConsole to
be able to see javascript errors for instance.

CMakeLists.txt:
platform/qt/FrameQt.h:
platform/qt/FrameQt.cpp: Implement addMessageToConsole. (WebCore::FrameQt::bindingRootObject):
platform/qt/TemporaryLinkStubs.cp (WebCore::IconDatabase::hasEntryForIconURL): (WebCore::IconDatabase::sharedIconDatabase):

3:47 PM Changeset in webkit [16376] by andersca

2 edits in trunk/JavaScriptCore

2006-09-15 Anders Carlsson <acarlsson@apple.com>

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Fix the release build.

3:31 PM Changeset in webkit [16375] by aroben

2 edits in trunk/WebKit

Reviewed by eseidel.

Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10876
containsItemForURLUnicode uses matchLetter instead of
matchUnicodeLetter

Small fixes for _WebCoreHistoryProvider.

History/WebHistory.m: Consistently use BUFFER_SIZE #define (-[_WebCoreHistoryProvider containsItemForURLLatin1:length:]): (-[_WebCoreHistoryProvider containsItemForURLUnicode:length:]): Replace incorrect call to matchLetter to matchUnicodeLetter

3:23 PM Changeset in webkit [16374] by weinig

35 edits in trunk/WebCore

Reviewed by Tim H.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10869
Auto-generate the internal methods for the Objective-C bindings

Auto-generates the internal method (ie. the _fooBar and _fooBarWith methods) implementations where standard. For cases where a custom implementation was needed, added a [ObjCNoInternal] extended attribute to the corresponding IDL.

Some general cleanup of some of the non-generated bindings, to bring them in- line with what the generated bindings look like.

bindings/objc/DOM.mm: (-[DOMNode description]):
bindings/objc/DOMCSS.mm: (-[DOMCSSPrimitiveValue WebCore::]): (-[DOMDocument getComputedStyle::]): (-[DOMDocument getMatchedCSSRules::]):
bindings/objc/DOMEvents.mm: (-[DOMEvent WebCore::]):
bindings/objc/DOMHTML.mm:
bindings/objc/DOMHTMLDocument.mm: (-[DOMHTMLDocument title]): (-[DOMHTMLDocument setTitle:]): (-[DOMHTMLDocument referrer]): (-[DOMHTMLDocument domain]): (-[DOMHTMLDocument URL]): (-[DOMHTMLDocument body]): (-[DOMHTMLDocument setBody:]): (-[DOMHTMLDocument images]): (-[DOMHTMLDocument applets]): (-[DOMHTMLDocument links]): (-[DOMHTMLDocument forms]): (-[DOMHTMLDocument anchors]): (-[DOMHTMLDocument cookie]): (-[DOMHTMLDocument setCookie:]): (-[DOMHTMLDocument open]): (-[DOMHTMLDocument close]): (-[DOMHTMLDocument write:]): (-[DOMHTMLDocument writeln:]): (-[DOMHTMLDocument getElementById:]): (-[DOMHTMLDocument getElementsByName:]): (-[DOMHTMLDocument WebCore::]): (+[DOMHTMLDocument _HTMLDocumentWith:WebCore::]):
bindings/objc/DOMHTMLOptionElement.mm: (-[DOMHTMLOptionElement form]): (-[DOMHTMLOptionElement defaultSelected]): (-[DOMHTMLOptionElement setDefaultSelected:]): (-[DOMHTMLOptionElement text]): (-[DOMHTMLOptionElement index]): (-[DOMHTMLOptionElement disabled]): (-[DOMHTMLOptionElement setDisabled:]): (-[DOMHTMLOptionElement label]): (-[DOMHTMLOptionElement setLabel:]): (-[DOMHTMLOptionElement selected]): (-[DOMHTMLOptionElement setSelected:]): (-[DOMHTMLOptionElement value]): (-[DOMHTMLOptionElement setValue:]): (-[DOMHTMLOptionElement WebCore::]): (+[DOMHTMLOptionElement _HTMLOptionElementWith:WebCore::]):
bindings/objc/DOMInternal.h:
bindings/objc/DOMNode.mm: (-[DOMNode dealloc]): (-[DOMNode finalize]): (-[DOMNode nodeName]): (-[DOMNode nodeValue]): (-[DOMNode setNodeValue:]): (-[DOMNode nodeType]): (-[DOMNode parentNode]): (-[DOMNode childNodes]): (-[DOMNode firstChild]): (-[DOMNode lastChild]): (-[DOMNode previousSibling]): (-[DOMNode nextSibling]): (-[DOMNode attributes]): (-[DOMNode ownerDocument]): (-[DOMNode insertBefore::]): (-[DOMNode replaceChild::]): (-[DOMNode removeChild:]): (-[DOMNode appendChild:]): (-[DOMNode hasChildNodes]): (-[DOMNode cloneNode:]): (-[DOMNode normalize]): (-[DOMNode isSupported::]): (-[DOMNode namespaceURI]): (-[DOMNode prefix]): (-[DOMNode setPrefix:]): (-[DOMNode localName]): (-[DOMNode hasAttributes]): (-[DOMNode isSameNode:]): (-[DOMNode isEqualNode:]): (-[DOMNode isDefaultNamespace:]): (-[DOMNode lookupPrefix:]): (-[DOMNode lookupNamespaceURI:]): (-[DOMNode textContent]): (-[DOMNode setTextContent:]): (-[DOMNode boundingBox]): (-[DOMNode lineBoxRects]):
bindings/objc/DOMObject.mm: (-[DOMObject _init]):
bindings/objc/DOMXPath.mm: (-[DOMNativeXPathNSResolver dealloc]): (-[DOMNativeXPathNSResolver finalize]): (-[DOMNativeXPathNSResolver WebCore::]): (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]): (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]): (-[DOMNativeXPathNSResolver lookupNamespaceURI:]):
bindings/scripts/CodeGeneratorObjC.pm:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]):
css/CSSCharsetRule.idl:
css/CSSFontFaceRule.idl:
css/CSSImportRule.idl:
css/CSSMediaRule.idl:
css/CSSPageRule.idl:
css/CSSPrimitiveValue.idl:
css/CSSRule.idl:
css/CSSStyleRule.idl:
css/CSSStyleSheet.idl:
css/CSSUnknownRule.idl:
css/CSSValue.idl:
css/CSSValueList.idl:
css/StyleSheet.idl:
dom/Event.idl:
dom/KeyboardEvent.idl:
dom/MouseEvent.idl:
dom/MutationEvent.idl:
dom/NodeIterator.idl:
dom/OverflowEvent.idl:
dom/TreeWalker.idl:
dom/UIEvent.idl:
dom/WheelEvent.idl:

3:10 PM Changeset in webkit [16373] by aroben

7 edits in trunk

WebCore:

Reviewed by timothy.

Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10865
New file upload control should match the width of the old one

Make width of new file upload control match the old one as closely as
possible.

rendering/RenderFileUploadControl.cpp:

LayoutTests:

Reviewed by timothy.

Part of http://bugzilla.opendarwin.org/show_bug.cgi?id=10865
New file upload control should match the width of the old one

Update tests to match new file upload control.

fast/forms/file-input-disabled-expected.txt:
fast/forms/form-element-geometry-expected.txt:
fast/forms/input-appearance-height-expected.txt:
fast/forms/input-value-expected.txt:

3:01 PM Changeset in webkit [16372] by thatcher

2 edits in trunk/WebCore

Reviewed by Eric.

Remove the SVG IDL files from the Copy Resources phase.

WebCore.xcodeproj/project.pbxproj:

2:52 PM Changeset in webkit [16371] by andersca

11 edits
1 add in trunk/JavaScriptCore

2006-09-15 Anders Carlsson <acarlsson@apple.com>

Reviewed by Steve.

Add JavaScriptCore API to the build.

API/JSBase.cpp:
API/JSCallbackConstructor.cpp:
API/JSCallbackFunction.cpp:
API/JSCallbackObject.cpp:
API/JSClassRef.cpp:
API/JSContextRef.cpp:
API/JSObjectRef.cpp:
API/JSStringRef.cpp:
API/JSValueRef.cpp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
os-win32/stdbool.h: Added.

2:48 PM Changeset in webkit [22175] by andersca

2 edits in branches/WindowsMerge/WebCore

2006-09-15 Anders Carlsson <acarlsson@apple.com>

Reviewed by Steve.

WebCore.vcproj/WebCore.vcproj: Add JavaScriptCore/ to include path.

1:58 PM Changeset in webkit [22174] by aroben

6 edits
3 adds in branches/WindowsMerge

WebCore:

Reviewed by sfalken.

Implement historyContains() on Windows (rdar://4733770)

WebCore.vcproj/WebCore.vcproj: Add platform\win\WebCoreHistory.{cpp,h} and bridge\win\HistoryWin.cpp to project.
bridge/win/HistoryWin.cpp: Added. (WebCore::historyContains):
platform/win/TemporaryLinkStubs.cpp: Remove stub for WebCore::historyContains()
platform/win/WebCoreHistory.cpp: Added. (WebCore::WebCoreHistory::setHistoryProvider): (WebCore::WebCoreHistory::historyProvider):
platform/win/WebCoreHistory.h: Added.

WebKit:

Reviewed by sfalken.

Implement historyContains() on Windows (rdar://4733770)

WebHistory.cpp: Add new private _WebCoreHistoryProvider class. (WebHistory::setOptionalSharedHistory): Call WebCore::WebCoreHistory::setHistoryProvider so that WebCore can access history. (WebHistory::itemForURL): Extract itemForURLString method. (WebHistory::itemForURLString): Added. (WebHistory::containsItemForURLString): Added. (_WebCoreHistoryProvider::_WebCoreHistoryProvider): Added. (_WebCoreHistoryProvider::~_WebCoreHistoryProvider): Added. (matchLetter): Ported from Mac's WebHistory.m. (matchUnicodeLetter): Ditto. (_WebCoreHistoryProvider::containsItemForURLLatin1): Ditto. (_WebCoreHistoryProvider::containsItemForURLUnicode): Ditto.
WebHistory.h: Fix typo: IID_WebHistoryItemPrivate --> IID_WebHistoryPrivate, added new methods to IWebHistoryPrivate and WebHistory

11:09 AM Changeset in webkit [16370] by kmccullo

3 edits in trunk/LayoutTests

just layout test result changes

fast/dom/Range/range-compareNode-expected.txt:
fast/dom/Range/range-intersectsNode-expected.txt:

2:38 AM Changeset in webkit [16369] by beidson

2 edits in trunk/WebCore

Reviewed by Eric Siedel

Dumped the use of CGColorRef and directly use the floating point data from
WebCore::Color

This fixes the performance regression found between 16285 and 16286

platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): (WebCore::Font::drawGlyphs):

Sep 14, 2006:

11:09 PM Changeset in webkit [16368] by bdash

4 edits in trunk/WebCore

2006-09-14 Mark Rowe <opendarwin.org@bdash.net.nz>

Reviewed by Adam.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10838
Bug 10838: REGRESSION: Leaking of WebScriptObjectPrivate

FrameMac relies on its cleanupPluginObjects being called to perform cleanup. The virtual
Frame::cleanupPluginObjects method is called from Frame's destructor, which results
in Frame::cleanupPluginObjects being called rather than FrameMac::cleanupPluginObjects.

bridge/mac/FrameMac.mm: (WebCore::FrameMac::~FrameMac): Call cancelAndClear to ensure that FrameMac::cleanupPluginObjects will be called from Frame::clear
page/Frame.cpp: (WebCore::Frame::~Frame): Use cancelAndClear. (WebCore::Frame::cancelAndClear): Move cancellation and clearing into a separate method that FrameMac can use.
page/Frame.h:

4:44 PM Changeset in webkit [16367] by beidson

2 edits in trunk/WebCore

Reviewed by Maciej's rubber stamp

Exact same fix I just made, but in the other method I horked up
Also added a reference to the bugzilla in comments

page/Frame.cpp: (WebCore::Frame::endIfNotLoading): (WebCore::Frame::stop):

3:58 PM Changeset in webkit [16366] by beidson

2 edits in trunk/WebCore

Reviewed by Maciej

Fixed a bad iFrame crash, resolving some of the layout test badness

page/Frame.cpp: (WebCore::Frame::endIfNotLoading):
Added a RefPtr to protect the frame itself to prevent its destruction during this method

12:52 PM Changeset in webkit [16365] by justing

9 edits
12 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4655880> Up/Down arrows skip over To Do

editing/selection/mixed-editability-3-expected.checksum: Added.
editing/selection/mixed-editability-3-expected.png: Added.
editing/selection/mixed-editability-3-expected.txt: Added.
editing/selection/mixed-editability-3.html: Added.
editing/selection/mixed-editability-4-expected.checksum: Added.
editing/selection/mixed-editability-4-expected.png: Added.
editing/selection/mixed-editability-4-expected.txt: Added.
editing/selection/mixed-editability-4.html: Added.
editing/selection/mixed-editability-5-expected.checksum: Added.
editing/selection/mixed-editability-5-expected.png: Added.
editing/selection/mixed-editability-5-expected.txt: Added.
editing/selection/mixed-editability-5.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4655880> Up/Down arrows skip over To Do

bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canDeleteRange:]): Added a FIXME.
dom/Node.cpp: Removed the unused inSameRootEditableElement.
dom/Node.h:
editing/SelectionController.cpp: (WebCore::SelectionController::modify): Added documentboundary to granularities in order test a fix.
editing/visible_units.cpp: (WebCore::previousLinePosition): Use highestEditableRoot so that this function can move from editable content into editable content that's embedded in non-editable content. (WebCore::nextLinePosition): Ditto. (WebCore::startOfEditableContent): Renamed from startOfEditableRoot and use highestEditableRoot. This is the behavior that callers desire. This fixes Command + Up/Down. (WebCore::endOfEditableContent): Ditto.
editing/visible_units.h:

10:34 AM Changeset in webkit [22173] by sfalken

4 edits in branches/WindowsMerge

2006-09-14 Steve Falkenburg <sfalken@apple.com>

Reviewed by Lou Amadio.

iBench fix - fix null deref in form submission case without a form element.

WebFrame.cpp: (WebFrame::submitForm):

2006-09-14 Steve Falkenburg <sfalken@apple.com>

Reviewed by Lou Amadio.

iBench fix - fix WinInet form post code to not reference a stale pointer.
(found by Application Verifier)

platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderWndProc):

10:30 AM Changeset in webkit [22172] by aroben

3 edits in branches/WindowsMerge/WebCore

Reviewed by sfalken.

A little #include cleanup

WebCore.vcproj/WebCore.vcproj: Add loader/icon to AdditionalIncludeDirectories
platform/win/TemporaryLinkStubs.cpp: Remove "loader/icon" from #include of IconLoader.h

10:07 AM Changeset in webkit [16364] by aroben

3 edits in trunk/WebCore

2006-09-14 Karthik Kumar <karthikkumar@gmail.com>

Reviewed by timothy. Landed by aroben.

Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10856
Windows build fixes after r16360

WebCore.vcproj/WebCore/WebCore.vcproj: Add loader\icon to AdditionalIncludeDirectories
platform/win/TemporaryLinkStubs.cpp: Add link stubs for IconLoader, IconDatabase (IconLoader::stopLoading): (IconLoader::startLoading): (IconLoader::createForFrame): (IconDatabase::isIconExpiredForIconURL): (IconDatabase::hasEntryForIconURL): (IconDatabase::sharedIconDatabase):

2:00 AM Changeset in webkit [16363] by beidson

4 edits in trunk/WebCore

Part of a build fix - rest will be filling in some temporary link stubs

1:50 AM Changeset in webkit [22171] by beidson

3 edits in branches/WindowsMerge/WebCore

Build Fix

1:08 AM Changeset in webkit [16362] by bdash

7 edits in trunk

2006-09-14 Graham Dennis <graham.dennis@gmail.com>

Reviewed by Justin Garcia.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10726 Crash in ApplyStyleCommand::applyRelativeFontStyleChange

editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Prevent a crash by makeing sure that the 'beyondEnd' node is after the start node.

2006-09-14 Graham Dennis <graham.dennis@gmail.com>

Reviewed by Justin Garcia.

Modified testcase for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=10726
Crash in ApplyStyleCommand::applyRelativeFontStyleChange

editing/style/table-selection-expected.checksum:
editing/style/table-selection-expected.png:
editing/style/table-selection-expected.txt:
editing/style/table-selection.html: This testcase was for 10579, which is very similar to this bug (10726) Now the testcase tests both bugs.

12:29 AM Changeset in webkit [16361] by bdash

3 edits in trunk/WebCore

2006-09-14 MorganL <morlmor@yahoo.com>

Reviewed by Brady.

Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10845
Various bugs/crashes in ResourceLoaderWin with local files.

platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::fileLoadTimer):

12:20 AM Changeset in webkit [16360] by beidson

17 edits
3 adds in trunk

WebCore:

Reviewed by Maciej

Icon loads now take place in WebCore

WebCore.xcodeproj/project.pbxproj:
bridge/BrowserExtension.h:
bridge/mac/BrowserExtensionMac.h:
bridge/mac/BrowserExtensionMac.mm:
Moved enforcement of a Mozilla Favicon extension elsewhere

bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::originalRequestURL):
Added accessor to "original request URL"

bridge/mac/WebCoreFrameBridge.h:
Removed methods to set the iconURL as all loading is now done in WebCore
Added call throughs to notify WebKit an Icon is done loading, and a to get the original request URL

html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
Moved enforcement of a Mozilla Favicon extension elsewhere

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::setIconURLForPageURL):
Changed an ASSERT to correctly handle a sketchy (invalid) situation

loader/icon/IconLoader.h: Added.
loader/icon/IconLoader.cpp: Added. (IconLoader::IconLoader): (IconLoader::createForFrame):
Static factory method with a private constructor to enforce "you MUST have a Frame to create an IconLoader" semantics (IconLoader::~IconLoader): (IconLoader::startLoading): (IconLoader::stopLoading): (IconLoader::receivedData):
ResourceLoaderClient delegate (IconLoader::receivedAllData):
Ditto

loader/mac/IconLoaderMac.mm: Added. (IconLoader::receivedResponse): (IconLoader::notifyIconChanged):
For now, these are platform specific methods
One to get the HTTP response code of an icon load
The other to call through to the app when the icon has changed (loaded)

page/Frame.h:
page/Frame.cpp: (WebCore::Frame::iconURL): (WebCore::Frame::setIconURL):
Frame objects now have an inherent icon URL and a way to calculate/access it (WebCore::Frame::endIfNotLoading):
This is where we actually kick off the IconLoader (WebCore::Frame::stop):
Added call to stop loading the icon

page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): (WebCore::FramePrivate::~FramePrivate):
Added the icon URL as a private member
Added the IconLoader as a private member, and clean it up on deletion

platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): Added a valuable ASSERT

WebKit:

Reviewed by Maciej

Add infrastructure to support icon loads taking place in WebCore
Will remove WebKit icon loaders in a later patch

WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge notifyIconChanged:]): (-[WebFrameBridge originalRequestURL]):
Nuked two old, obsolete methods
Added bridge for notifying of an icon change
Added bridge for getting the "original request URL" which is still needed until that info is available in the WebCore loaders

WebView/WebDataSource.m: (-[WebDataSource _loadIcon]):
Empty body just for now, as it still gets called - next patch will prune all the old impl out

12:01 AM Changeset in webkit [16359] by hyatt

5 edits in trunk/WebCore

Fix for 10841, unable to check checkboxes inside labels.

Reviewed by xenon, bradee-oh

css/html4.css:
dom/Element.cpp: (WebCore::Element::contains):
dom/Element.h:
html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::defaultEventHandler):

Sep 13, 2006:

10:10 PM Changeset in webkit [22170] by sfalken

2 edits in branches/WindowsMerge/WebCore

2006-09-13 Steve Falkenburg <sfalken@apple.com>

Fixes for submission of WebCore. Doesn't affect build.

WebCore.vcproj/WebCore.vcproj:
WebCore.vcproj/merge-opensource.sh:

10:03 PM Changeset in webkit [16358] by bdash

2 edits in trunk/WebCore

2006-09-13 Mark Rowe <opendarwin.org@bdash.net.nz>

Reviewed by Adam.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10834
Bug 10834: FileChooser constructor in FileChooserMac appears to overretain m_controller

platform/mac/FileChooserMac.mm: (WebCore::FileChooser::FileChooser): Don't over-retain the OpenPanelController.

9:47 PM Changeset in webkit [16357] by aroben

30 edits in trunk/LayoutTests

Rubberstamped by hyatt.

Updating tables results after hyatt landed a fix for
http://bugzilla.opendarwin.org/show_bug.cgi?id=8126
Padding must not apply to columns

tables/mozilla/bugs/bug139524-2-expected.txt:
tables/mozilla/bugs/bug139524-4-expected.txt:
tables/mozilla/bugs/bug32841-expected.txt:
tables/mozilla/dom/appendCol2-expected.txt:
tables/mozilla/dom/deleteCol1-expected.txt:
tables/mozilla/dom/deleteCol2-expected.txt:
tables/mozilla/dom/deleteCol3-expected.txt:
tables/mozilla/dom/deleteColGroup1-expected.txt:
tables/mozilla/dom/deleteColGroup2-expected.txt:
tables/mozilla/dom/insertColGroups1-expected.txt:
tables/mozilla/dom/insertColGroups2-expected.txt:
tables/mozilla/dom/insertCols1-expected.txt:
tables/mozilla/dom/insertCols2-expected.txt:
tables/mozilla/dom/insertCols3-expected.txt:
tables/mozilla/dom/insertCols4-expected.txt:
tables/mozilla/dom/insertCols5-expected.txt:
tables/mozilla/marvin/body_col-expected.txt:
tables/mozilla/marvin/x_col_span-expected.txt:
tables/mozilla/marvin/x_col_width_px-expected.txt:
tables/mozilla/marvin/x_colgroup_span-expected.txt:
tables/mozilla/other/body_col-expected.txt:
tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
tables/mozilla_expected_failures/core/cols1-expected.txt:
tables/mozilla_expected_failures/dom/appendCol1-expected.txt:
tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt:
tables/mozilla_expected_failures/other/test4-expected.txt:

9:41 PM Changeset in webkit [16356] by bdash

2 edits in trunk/WebCore

2006-09-13 Mark Rowe <opendarwin.org@bdash.net.nz>

Reviewed by Eric.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10836
Bug 10836: REGRESSION: Mac implementation of Font::drawGlyphs leaks a CGColorRef

platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): Release CGColorRef after use. (WebCore::Font::drawGlyphs): Ditto.

7:27 PM Changeset in webkit [16355] by andersca

3 edits in trunk/WebCore

2006-09-14 Anders Carlsson <acarlsson@apple.com>

Try fixing the Win32 build.

bridge/win/FrameWin.h:
platform/win/TemporaryLinkStubs.cpp: (FrameWin::bindingRootObject):

6:59 PM Changeset in webkit [16354] by sfalken

5 edits
1 add in trunk/JavaScriptCore

2006-09-12 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada.

Build tweaks (doing JavaScriptCore now since it doesn't have
dependencies).

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
JavaScriptCore.vcproj/JavaScriptCore/dstroot-to-sdk.cmd: Added.
JavaScriptCore.vcproj/dftables/dftables.vcproj:
JavaScriptCore.vcproj/testkjs/testkjs.vcproj:

6:57 PM Changeset in webkit [22169] by sfalken

24 edits
3 adds in branches/WindowsMerge

6:56 PM Changeset in webkit [16353] by andersca

14 edits in trunk/WebCore

2006-09-14 Anders Carlsson <acarlsson@apple.com>

Reviewed by Tim O.

Add USE defines for the generic JavaScriptCore bindings as well as NPAPI bindings.

bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::createLanguageInstanceForValue):
bindings/js/kjs_dom.cpp: (KJS::getRuntimeObject):
bridge/mac/FrameMac.h:
config.h:
html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::~HTMLAppletElement): (WebCore::HTMLAppletElement::detach):
html/HTMLAppletElement.h:
html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::~HTMLEmbedElement): (WebCore::HTMLEmbedElement::detach):
html/HTMLEmbedElement.h:
html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::~HTMLObjectElement): (WebCore::HTMLObjectElement::detach):
html/HTMLObjectElement.h:
html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::HTMLPlugInElement): (WebCore::HTMLPlugInElement::~HTMLPlugInElement): (WebCore::HTMLPlugInElement::createNPObject):
html/HTMLPlugInElement.h:
page/Frame.h:

6:13 PM Changeset in webkit [22168] by adachan

3 edits in branches/WindowsMerge/WebKitWin

2006-09-13 Ada Chan <adachan@apple.com>

Reviewed by sfalken

WebBackForwardList::containsItem()
- we can break once we've found the item
Fixed a crashing bug with WebNotificationCenter::addObserver.

4:56 PM Changeset in webkit [22167] by aroben

3 edits in branches/WindowsMerge/WebCore

Build fix

WebCore.vcproj/WebCore.vcproj: Rename KHTML_XSLT to XSLT_SUPPORT, remove KHTML_NO_XBL
config.h: Ditto.

4:01 PM Changeset in webkit [16352] by thatcher

1 edit in tags/WebCore-521.26.1/WebCore/Info.plist

Versioning

3:59 PM Changeset in webkit [16351] by thatcher

1 copy in tags/WebCore-521.26.1/WebCore

New tag part two.

3:58 PM Changeset in webkit [16350] by thatcher

1 add in tags/WebCore-521.26.1

New tag.

3:55 PM Changeset in webkit [22166] by aroben

3 edits
2 adds in branches/WindowsMerge/WebCore

Reviewed by beidson.

Initial implementation of Icon, FileChooser on Windows.

WebCore.vcproj/WebCore.vcproj: Added FileChooserWin.cpp, IconWin.cpp
platform/win/FileChooserWin.cpp: Added. (WebCore::FileChooser::FileChooser): (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth): (WebCore::FileChooser::uploadControlDetaching): (WebCore::FileChooser::chooseFile):
platform/win/IconWin.cpp: Added. (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile): (WebCore::Icon::paint):
platform/win/TemporaryLinkStubs.cpp: Removed FileChooser, Icon stub functions

3:18 PM Changeset in webkit [16349] by thatcher

2 edits in trunk/WebKit

Reviewed by Tim O.

<rdar://problem/4726416> obsolete confusing "ADVISORY NOTE" comment in WebHistory.h

Removed the "ADVISORY NOTE: This method may change for the 1.0 SDK" comments.

History/WebHistory.h:

3:10 PM Changeset in webkit [16348] by hyatt

33 edits in trunk/WebCore

Clean up the XBL and XSLT ifdefs to be consistent with the SVG
and XPath ifdefs. KHTML_NO_XBL is flipped and is now XBL_SUPPORT.
KHTML_XSLT is now XSLT_SUPPORT.

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSXSLTProcessor.cpp:
bindings/js/JSXSLTProcessor.h:
bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
config.h:
css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/cssparser.cpp: (WebCore::CSSParser::parseValue):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::recalcStyleSelector):
dom/Document.h: (WebCore::Document::bindingManager):
dom/Node.cpp: (WebCore::Node::createRendererIfNeeded):
dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::ProcessingInstruction): (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::setStyleSheet):
dom/ProcessingInstruction.h:
dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::processingInstruction): (WebCore::XMLTokenizer::insertErrorMessageBlock):
dom/XMLTokenizer.h:
loader/Cache.cpp: (WebCore::Cache::getStatistics):
loader/Cache.h:
loader/CachedResource.h: (WebCore::CachedResource::):
loader/CachedResourceClient.h:
loader/CachedXBLDocument.cpp:
loader/CachedXBLDocument.h:
loader/CachedXSLStyleSheet.cpp:
loader/CachedXSLStyleSheet.h:
loader/DocLoader.cpp:
loader/DocLoader.h:
rendering/RenderStyle.cpp: (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData): (WebCore::StyleCSS3NonInheritedData::~StyleCSS3NonInheritedData): (WebCore::StyleCSS3NonInheritedData::operator==):
rendering/RenderStyle.h:
xml/XSLImportRule.cpp:
xml/XSLImportRule.h:
xml/XSLStyleSheet.cpp:
xml/XSLStyleSheet.h:
xml/XSLTProcessor.cpp:
xml/XSLTProcessor.h:

3:07 PM Changeset in webkit [16347] by eseidel

4 edits in trunk/WebCore

2006-09-13 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Fix newly introduced memory leaks in SVG.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10835

ksvg2/svg/SVGList.h: (WebCore::SVGListBase::~SVGListBase): (WebCore::SVGListBase::clearVector): (WebCore::SVGListBase::clear): (WebCore::SVGList::clearVector): (WebCore::):
ksvg2/svg/SVGNumberList.cpp: s/float/double/ - forgot that! (SVGNumberList::SVGNumberList):
ksvg2/svg/SVGNumberList.h: Ditto.

2:30 PM Changeset in webkit [22165] by andersca

4 edits in branches/WindowsMerge/WebCore

2006-09-13 Anders Carlsson <acarlsson@apple.com>

Reviewed by Tim O.

Implement postURL and postURLNotify.

plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::cancelAndDestroyStream):
plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::loadURL): (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::startsWithBlankLine): (WebCore::locationAfterFirstBlankLine): (WebCore::findEOL): (WebCore::capitalizeRFC822HeaderFieldName): (WebCore::parseRFC822HeaderFields): (WebCore::PluginViewWin::handlePost): (WebCore::PluginViewWin::postURLNotify): (WebCore::PluginViewWin::postURL):
plugins/win/PluginViewWin.h:

2:10 PM Changeset in webkit [22164] by lamadio

2 edits in branches/WindowsMerge/WebCore

11:37 AM Changeset in webkit [16346] by aroben

3 edits in trunk/WebCore

2006-09-13 MorganL <morlmor@yahoo.com>

Reviewed/landed by aroben.

Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10833
Windows build needs fixed after move to engine-rendered file upload widget

WebCore.vcproj/WebCore/WebCore.vcproj: Add RenderFileUpload files, remove RenderFileButton files
platform/win/TemporaryLinkStubs.cpp: Add stubs for FileChooser, Icon (FileChooser::FileChooser): (FileChooser::~FileChooser): (FileChooser::openFileChooser): (FileChooser::basenameForWidth): (FileChooser::uploadControlDetaching): (FileChooser::chooseFile): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (Icon::Icon): (Icon::~Icon): (Icon::newIconForFile): (Icon::paint):

11:15 AM Changeset in webkit [16345] by aroben

2 edits in trunk/WebCore

2006-09-13 MorganL <morlmor@yahoo.com>

Reviewed/landed by aroben.

Fixes http://bugzilla.opendarwin.org/attachment.cgi?id=10537
Webkit WebCore build fails on Windows

WebCore.vcproj/WebCore/build-generated-files.sh: export SOURCE_ROOT variable

9:16 AM Changeset in webkit [16344] by thatcher

2 adds in trunk/WebCore/platform/qt

Forgot these added files.

9:12 AM Changeset in webkit [16343] by thatcher

4 edits in trunk/WebCore

Reviewed by Tim H.

Fix Qt/Linux build.

CMakeLists.txt: Change SVGZoomEvent.idl location & add RenderFileUploadControl
platform/Icon.h: Add wtf/Platform.h include
platform/qt/FileChooserQt.cpp: Added as stub. Easy to implement though. (WebCore::FileChooser::FileChooser): (WebCore::FileChooser::~FileChooser): (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth): (WebCore::FileChooser::uploadControlDetaching): (WebCore::FileChooser::chooseFile):
platform/qt/IconQt.cpp: Added as stub. (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile): (WebCore::Icon::paint):
platform/qt/TemporaryLinkStubs.cpp: Remove old RenderFileButton code & some new *Labels needed (searchableIndexIntroduction): (fileButtonChooseFileLabel): (fileButtonNoFileSelectedLabel):

12:47 AM Changeset in webkit [22163] by aroben

2 edits in branches/WindowsMerge/WebCore

Build fix

WebCore.vcproj/build-generated-files.sh: Export SOURCE_ROOT which is now used by CodeGenerator.pm

12:08 AM Changeset in webkit [16342] by aroben

3 edits in trunk/WebCore

Reviewed by eseidel.

Switch back to passing relative paths to generate-bindings.pl when
generating JS bindings.

DerivedSources.make: Pass in relative paths to generate-bindings.pl
bindings/scripts/CodeGenerator.pm: Make ScanDirectory never call chdir and always construct absolute paths instead.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed