Timeline



Sep 20, 2006:

11:27 PM Changeset in webkit [16492] by bdash
  • 22 edits in trunk/WebKitSite

2006-09-21 Mark Rowe <opendarwin.org@bdash.net.nz>

Reviewed by TimH.

Updates to make static pages validate as HTML 4.01 Strict.

  • building/build.html:
  • coding/coding-style.html:
  • header.inc:
  • index.html: Move <style> tag into the document head.
  • projects/cleanup/index.html:
  • projects/compat/index.html:
  • projects/css/index.html:
  • projects/documentation/index.html:
  • projects/editing/index.html:
  • projects/forms/index.html: Remove note about <label> not being implemented correctly.
  • projects/html/index.html:
  • projects/javascript/index.html:
  • projects/performance/index.html:
  • projects/portability/index.html: Change mention of Windows port to note that it is in progress rather than non-existant.
  • projects/printing/index.html:
  • projects/svg/index.html:
  • projects/xslt/index.html:
  • quality/bugwriting.html: Update WebKit version numbers to be accurate. Move JS away from using innerHTML as W3C validator doesn't like it.
  • quality/reduction.html:
  • quality/reporting.html: Rename element IDs that start with numbers. Update WebKit and Mac OS X version numbers to be accurate.
  • quality/testing.html:
8:45 PM Changeset in webkit [16491] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Bug 10917: REGRESSION (r16027): iFrame transparency broken
http://bugzilla.opendarwin.org/show_bug.cgi?id=10917

Don't paint the base background color if we transparent.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended):
6:28 PM Changeset in webkit [22191] by sfalken
  • 12 edits in branches/WindowsMerge/WebKitWin

2006-09-20 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada Chan.


<rdar://4601547> Character encoding menu/switching


Encoding menu and prefs pop-up are now hooked up and working.


List of encodings is identical to the Mac version, with encodings
not supported by icu removed. Localized names of these encodings
and IANA names are retrieved via MLANG from code pages. It
would have been nice to use ICU for this, but the call to get
a displayable encoding name from an IANA name doesn't return
user readable names. CF couldn't be used, since the open source
CF doesn't have encoding support that it would normally get via TEC.


There's currently a problem where the encoding doesn't get
picked up out of the incoming HTML document out of <meta>, so
the text encoding menu comes in especially handy at the moment.

6:15 PM Changeset in webkit [22190] by beidson
  • 6 edits in branches/WindowsMerge/WebKitWin

Hook up the WebIconDatabase enabled preference

5:54 PM Changeset in webkit [16490] by aroben
  • 2 edits in trunk/WebCore

Reviewed by andersca.

  • platform/FileChooser.h: Remove no-longer-necessary namespace std
4:52 PM Changeset in webkit [16489] by seangies
  • 1 edit in trunk/WebCore/platform/FontData.h

Fix up conditional.

4:52 PM Changeset in webkit [22189] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Runtime fix - removed an obsolete, overzealous ASSERTion

4:38 PM Changeset in webkit [22188] by seangies
  • 2 edits
    2 adds in branches/WindowsMerge/WebCore

Add platform/cg/ColorCG.cpp

4:37 PM Changeset in webkit [16488] by eseidel
  • 44 edits in trunk/WebCore

2006-09-20 Eric Seidel <eric@eseidel.com>

Reviewed by beth.

Cleanup style in KCanvas.
Remove extra white-space, unneeded arguments, etc.

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasClipper.cpp: (WebCore::operator<<): (WebCore::KCanvasClipper::externalRepresentation):
  • kcanvas/KCanvasClipper.h:
  • kcanvas/KCanvasFilters.cpp: (WebCore::KCanvasFilter::externalRepresentation): (WebCore::operator<<): (WebCore::KCanvasFilterEffect::externalRepresentation): (WebCore::KCPointLightSource::externalRepresentation): (WebCore::KCSpotLightSource::externalRepresentation): (WebCore::KCDistantLightSource::externalRepresentation): (WebCore::KCanvasFEBlend::externalRepresentation): (WebCore::KCanvasFEColorMatrix::externalRepresentation): (WebCore::KCanvasFEComponentTransfer::externalRepresentation): (WebCore::KCanvasFEComposite::externalRepresentation): (WebCore::KCanvasFEConvolveMatrix::externalRepresentation): (WebCore::KCanvasFEDiffuseLighting::externalRepresentation): (WebCore::KCanvasFEDisplacementMap::externalRepresentation): (WebCore::KCanvasFEFlood::externalRepresentation): (WebCore::KCanvasFEGaussianBlur::externalRepresentation): (WebCore::KCanvasFEImage::externalRepresentation): (WebCore::KCanvasFEMerge::externalRepresentation): (WebCore::KCanvasFEMorphology::externalRepresentation): (WebCore::KCanvasFEOffset::externalRepresentation): (WebCore::KCanvasFESpecularLighting::externalRepresentation): (WebCore::KCanvasFETile::externalRepresentation): (WebCore::KCanvasFETurbulence::externalRepresentation):
  • kcanvas/KCanvasFilters.h: (WebCore::KCanvasFEDiffuseLighting::lightSource): (WebCore::KCanvasFESpecularLighting::lightSource):
  • kcanvas/KCanvasImage.h:
  • kcanvas/KCanvasMarker.cpp: (WebCore::KCanvasMarker::externalRepresentation):
  • kcanvas/KCanvasMarker.h:
  • kcanvas/KCanvasResource.cpp: (WebCore::operator<<):
  • kcanvas/KCanvasResource.h:
  • kcanvas/KCanvasTreeDebug.cpp: (WebCore::operator<<): (WebCore::writeIndent): (WebCore::writeStyle): (WebCore::write): (WebCore::writeRenderResources):
  • kcanvas/KCanvasTreeDebug.h: (WebCore::operator<<):
  • kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::drawStartAndMidMarkers):
  • kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::translateForAttributes):
  • kcanvas/RenderSVGImage.h:
  • kcanvas/device/KRenderingDevice.cpp: (WebCore::KRenderingDevice::currentContext): (WebCore::KRenderingDevice::popContext): (WebCore::KRenderingDevice::pushContext):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingFillPainter.h:
  • kcanvas/device/KRenderingPaintServer.h: (WebCore::KRenderingPaintServer::KRenderingPaintServer): (WebCore::KRenderingPaintServer::activeClient): (WebCore::KRenderingPaintServer::setActiveClient):
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (WebCore::operator<<): (WebCore::KRenderingPaintServerGradient::externalRepresentation): (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation): (WebCore::KRenderingPaintServerGradient::listener): (WebCore::KRenderingPaintServerGradient::setListener): (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerPattern.cpp: (WebCore::KRenderingPaintServerPattern::tile): (WebCore::KRenderingPaintServerPattern::setTile): (WebCore::KRenderingPaintServerPattern::listener): (WebCore::KRenderingPaintServerPattern::setListener): (WebCore::KRenderingPaintServerPattern::externalRepresentation):
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/KRenderingPaintServerSolid.cpp: (WebCore::KRenderingPaintServerSolid::externalRepresentation):
  • kcanvas/device/KRenderingPaintServerSolid.h:
  • kcanvas/device/KRenderingStrokePainter.cpp: (WebCore::KRenderingStrokePainter::strokeMiterLimit): (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
  • kcanvas/device/KRenderingStrokePainter.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::prepareFilter):
  • kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: (WebCore::KCanvasMaskerQuartz::applyMask):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: (WebCore::KCanvasImageQuartz::init):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (WebCore::KCanvasClipperQuartz::applyClip):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::quartzContext): (WebCore::KRenderingDeviceQuartz::contextForImage): (WebCore::KRenderingDeviceQuartz::createPaintServer): (WebCore::KRenderingDeviceQuartz::createResource): (WebCore::KRenderingDeviceQuartz::createFilterEffect):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::CGShadingRefForLinearGradient): (WebCore::CGShadingRefForRadialGradient): (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::KRenderingPaintServerQuartzHelper::strokePath): (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath): (WebCore::KRenderingPaintServerQuartzHelper::fillPath): (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath): (WebCore::KRenderingPaintServerSolidQuartz::draw): (WebCore::KRenderingPaintServerSolidQuartz::setup): (WebCore::KRenderingPaintServerSolidQuartz::renderPath): (WebCore::KRenderingPaintServerPatternQuartz::setup): (WebCore::KRenderingPaintServerPatternQuartz::renderPath): (WebCore::KRenderingPaintServerPatternQuartz::teardown):
  • kcanvas/device/quartz/QuartzSupport.h:
  • kcanvas/device/quartz/QuartzSupport.mm: (WebCore::applyStrokeStyleToContext):
3:45 PM Changeset in webkit [16487] by andersca
  • 4 edits in trunk

JavaScriptCore:

2006-09-20 Anders Carlsson <acarlsson@apple.com>

Reviewed by Dave Hyatt.

  • wtf/MathExtras.h: Get rid of lrint.

WebCore:

2006-09-20 Anders Carlsson <acarlsson@apple.com>

Reviewed by Dave Hyatt.

  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): Use lroundf instead of lround since deltas are floats.
3:38 PM Changeset in webkit [16486] by eseidel
  • 3 edits
    4 adds in trunk

2006-09-20 Julien Palmas <julien.palmas@gmail.com>

Reviewed by eseidel. Landed by eseidel.

Test: svg/custom/pattern-y-offset.svg

  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::KRenderingPaintServerPatternQuartz::setup):
3:37 PM Changeset in webkit [16485] by hyatt
  • 3 edits in trunk/WebCore

Add a new wheelEvent method to ScrollView. Platforms that wish
to handle the wheel event for the scroll view themselves can then
do so there. (Mac lets the underlying NSScrollView do it for now.)

  • page/FrameView.cpp: (WebCore::FrameView::handleWheelEvent):
  • platform/ScrollView.h: (WebCore::ScrollView::wheelEvent):
3:22 PM Changeset in webkit [22187] by seangies
  • 2 edits in branches/WindowsMerge/WebCore

Fixed font-spacing issue with CG

2:59 PM Changeset in webkit [16484] by seangies
  • 2 edits in trunk/JavaScriptCore

Send debug messages to debugger console.

2:44 PM Changeset in webkit [16483] by thatcher
  • 2 edits in trunk/WebKit/Misc

Fix copyright year.

2:32 PM Changeset in webkit [16482] by beidson
  • 5 edits in trunk

WebCore:

Reviewed by Tim Omernick

Part of fixing a crash Tim O showed me that I missed in a release build.
WebKit should be able to call through the bridge to WebCore no matter what -
Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()

  • bridge/mac/WebCoreIconDatabaseBridge.h:
  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge closeSharedDatabase]): (-[WebCoreIconDatabaseBridge isOpen]): (-[WebCoreIconDatabaseBridge removeAllIcons]): (-[WebCoreIconDatabaseBridge _isEmpty]): (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]): (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]): (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]): (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]): (-[WebCoreIconDatabaseBridge iconURLForPageURL:]): (-[WebCoreIconDatabaseBridge defaultIconWithSize:]): (-[WebCoreIconDatabaseBridge retainIconForURL:]): (-[WebCoreIconDatabaseBridge releaseIconForURL:]): (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]): (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]): (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]): (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]): (-[WebCoreIconDatabaseBridge _setEnabled:]): (-[WebCoreIconDatabaseBridge _isEnabled]):

WebKit:

Reviewed by Tim Omernick

Fixing part of a crash Tim O showed me. [WebIconDatabase init] should finish
gracefully even if we can't open the database

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]):
2:12 PM Changeset in webkit [16481] by hyatt
  • 2 edits in trunk/JavaScriptCore

Add an implementation of lrint for Win32.

Reviewed by anders

  • wtf/MathExtras.h: (lrint):
2:06 PM Changeset in webkit [16480] by zbujtas
  • 2 edits in S60/trunk/WebKit

2006-09-20 w3liu <wei.liu@nokia.com>

Reviewed by Zalan Bujtas.
DESC:
http://bugzilla.opendarwin.org/show_bug.cgi?id=10952
Changing the encoding in setting does not affect the browser behavior.

  • BrowserView/inc/CharsetData.h:
2:04 PM Changeset in webkit [16479] by andersca
  • 13 edits in trunk/WebCore

2006-09-20 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

Add String::split which returns a Vector of Strings and use it instead of
DeprecatedStringList.


  • bindings/js/kjs_events.cpp: (KJS::Clipboard::getValueProperty):
  • bindings/js/kjs_window.cpp: (KJS::parseModalDialogFeatures):
  • css/MediaList.cpp: (WebCore::MediaList::setMediaText):
  • dom/Clipboard.h:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::tokenizeRelAttribute):
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::split):
  • platform/StringImpl.cpp:
  • platform/StringImpl.h:
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::types):
1:43 PM Changeset in webkit [16478] by thatcher
  • 2 edits
    2 adds in trunk/WebKit

Reviewed by Tim O.

<rdar://problem/4741392> Develop a system to find what version of WebKit an app was linked with

  • Misc/WebKitVersionChecks.h: Added.
  • Misc/WebKitVersionChecks.m: Added. (WebKitLinkedOnOrAfter): Added. (WebKitLinkTimeVersion): Added. (WebKitRunTimeVersion): Added.
  • WebKit.xcodeproj/project.pbxproj:
1:31 PM Changeset in webkit [16477] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): Fixed a typo.
12:20 PM Changeset in webkit [16476] by justing
  • 3 edits
    1 add
    1 delete in trunk

LayoutTests:

Reviewed by harrison

  • editing/selection/editable-links.html: Added.
  • editing/selection/editable-links.html-disabled: Removed.

WebCore:

Reviewed by harrison

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call HTMLElement::isContentEditable just to check the Frame's editability, since it calls updateRenderering, which can get us into infinite recursion.
12:16 PM Changeset in webkit [16475] by spadma
  • 3 edits in S60/branches/3.1m/WebKit

2006-09-19 spadma <Sachin.Padma@nokia.com>

Reviewed by Sriram.
DESC: Fix key event handling in Auto Form Fill listbox
http://bugzilla.opendarwin.org/show_bug.cgi?id=

  • BrowserCore/Formcontrols/inc/FControlSelectWidget.h:
  • BrowserCore/Formcontrols/src/FControlSelectWidget.cpp: (CControlSelectWidget::OfferKeyEventL): (CControlSelectWidget::InputCapabilities):
12:12 PM Changeset in webkit [16474] by beidson
  • 4 edits in trunk

WebCore:

Reviewed by Darin

Cleaned up my last patch alot, and made the WebCore icon database disabled by default

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): Disabled by default (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed) (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto (WebCore::IconDatabase::iconForPageURL): Ditto (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto (WebCore::IconDatabase::iconURLForPageURL): Ditto (WebCore::IconDatabase::retainIconForPageURL): Ditto (WebCore::IconDatabase::releaseIconForPageURL): Ditto (WebCore::IconDatabase::setIconDataForIconURL): Ditto (WebCore::IconDatabase::setIconURLForPageURL): Ditto (WebCore::IconDatabase::hasEntryForIconURL): Ditto (WebCore::IconDatabase::setEnabled): Fixed a big bug here!

WebKit:

Reviewed by Darin

Preparing to make the WebIconDatabase disabled by default - this patch tells the bridge whether its enabled or not

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]):
11:33 AM Changeset in webkit [16473] by aroben
  • 3 edits in trunk/LayoutTests

Reviewed by timothy.

Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10953
Test results for fast/js/window-properties.html should include
children of window.document.body.firstChild

  • fast/js/window-properties-expected.txt: Regenerate results which now include window.document.body.firstChild.*
  • fast/js/window-properties.html: Print out 'null' for null objects instead of 'object' for more clarity
10:42 AM Changeset in webkit [16472] by aroben
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Adele.

Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10935
REGRESSION: file upload control with direction:rtl or text-align:right
draws button on top of filename/icon

  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::setStyle): Force text-align to match direction (WebCore::RenderFileUploadControl::paintObject): Fix positioning of the filename and icon in RTL

LayoutTests:

Reviewed by Adele.

Adding test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10935
REGRESSION: file upload control with direction:rtl or text-align:right
draws button on top of filename/icon

  • fast/forms/file-input-direction-expected.checksum: Added.
  • fast/forms/file-input-direction-expected.png: Added.
  • fast/forms/file-input-direction-expected.txt: Added.
  • fast/forms/file-input-direction.html: Added.
10:30 AM Changeset in webkit [16471] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

fixed windows build

  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): changed lrint to lround
9:20 AM Changeset in webkit [16470] by spadma
  • 3 edits in S60/trunk/WebKit

2006-09-19 spadma <Sachin.Padma@nokia.com>

Reviewed by Sriram.
DESC: Fix key event handling in Auto Form Fill listbox
http://bugzilla.opendarwin.org/show_bug.cgi?id=

  • BrowserCore/Formcontrols/inc/FControlSelectWidget.h:
  • BrowserCore/Formcontrols/src/FControlSelectWidget.cpp: (CControlSelectWidget::OfferKeyEventL): (CControlSelectWidget::InputCapabilities):
7:36 AM Changeset in webkit [16469] by brmorris
  • 2 edits in S60/trunk/WebKit

2006-09-20 brmorris <bradley.morrison@nokia.com>

Reviewed by Zalan.
DESC: SmartLink Handler needs phonebook view
dll resource loader.

  • BrowserView/inc/SmartLinkHandler.h: new include.
7:23 AM Changeset in webkit [16468] by weinig
  • 3 edits in trunk/WebCore

Build Fix. Adds isHorizontal attribute back to WheelEvent
for the Objective-C bindings. If it is found that isHorizontal
is not used, we should remove it again but also remove it's
declaration from PublicDOMInterfaces.h

  • dom/WheelEvent.h: (WebCore::WheelEvent::isHorizontal):
  • dom/WheelEvent.idl:
2:52 AM Changeset in webkit [16467] by hyatt
  • 8 edits in trunk/WebCore

Fix for 10945, WheelEvent should support two dimensions at once, since
MacBooks allow for diagonal scrolling. Also enhance the PlatformWheelEvent
to allow for diagonal scrolling.

Reviewed by Eric

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchWheelEvent):
  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): (WebCore::WheelEvent::initWheelEvent):
  • dom/WheelEvent.h: (WebCore::WheelEvent::wheelDelta): (WebCore::WheelEvent::wheelDeltaX): (WebCore::WheelEvent::wheelDeltaY):
  • dom/WheelEvent.idl:
  • page/FrameView.cpp: (WebCore::FrameView::handleWheelEvent):
  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::deltaX): (WebCore::PlatformWheelEvent::deltaY): (WebCore::PlatformWheelEvent::normalize):
  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2:38 AM Changeset in webkit [16466] by eseidel
  • 7 edits in trunk/LayoutTests

2006-09-20 Eric Seidel <eric@eseidel.com>

Reviewed by hyatt.


Commit two test updates I forgot to commit with:
Markers should clip to their viewport.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5967

  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.png:
  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.checksum:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
2:20 AM Changeset in webkit [16465] by eseidel
  • 25 edits
    6 copies
    2 moves in trunk/WebCore

2006-09-19 Eric Seidel <eric@eseidel.com>

Reviewed by hyatt.

Split KCanvasResources.* into multiple files (and some other minor spacing changes).


No tests were harmed in the making of this patch.

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasClipper.cpp: Added. (WebCore::operator<<):
  • kcanvas/KCanvasClipper.h: Added.
  • kcanvas/KCanvasFilters.h:
  • kcanvas/KCanvasImage.h:
  • kcanvas/KCanvasMarker.cpp: Added.
  • kcanvas/KCanvasMarker.h: Added.
  • kcanvas/KCanvasMasker.cpp: Added. (WebCore::KCanvasMasker::KCanvasMasker): (WebCore::KCanvasMasker::setMask): (WebCore::KCanvasMasker::externalRepresentation): (WebCore::getMaskerById):
  • kcanvas/KCanvasMasker.h: Added.
  • kcanvas/KCanvasResource.cpp: Added. (WebCore::KCanvasResource::invalidate): (WebCore::KCanvasResource::externalRepresentation): (WebCore::getResourceById): (WebCore::getPaintServerById):
  • kcanvas/KCanvasResource.h: Added.
  • kcanvas/KCanvasResources.cpp: Removed.
  • kcanvas/KCanvasResources.h: Removed.
  • kcanvas/RenderPath.cpp:
  • kcanvas/RenderSVGContainer.cpp:
  • kcanvas/RenderSVGImage.cpp:
  • kcanvas/RenderSVGText.cpp:
  • kcanvas/device/KRenderingPaintServer.h:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGFEColorMatrixElement.cpp:
  • ksvg2/svg/SVGFEComponentTransferElement.cpp:
  • ksvg2/svg/SVGFECompositeElement.cpp:
  • ksvg2/svg/SVGFEGaussianBlurElement.cpp:
  • ksvg2/svg/SVGFELightElement.cpp:
  • ksvg2/svg/SVGFEOffsetElement.cpp:
  • ksvg2/svg/SVGFETurbulenceElement.cpp:
  • ksvg2/svg/SVGFilterElement.cpp:
  • ksvg2/svg/SVGLinearGradientElement.cpp:
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.h:
12:16 AM Changeset in webkit [16464] by beidson
  • 9 edits in trunk

WebCore:

Reviewed by Sarge Decker

<rdar://problem/4739892> and <rdar://problem/4729797>

  • WebCore::IconDatabase needs to have and respect an enabled() flag
  • Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
  • bridge/mac/WebCoreIconDatabaseBridge.h:
  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge _setEnabled:]): Added (-[WebCoreIconDatabaseBridge _isEnabled]): Added
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::open): Don't open if disabled (WebCore::IconDatabase::removeAllIcons): Ignore if disabled/closed (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ignore if disabled/closed (WebCore::IconDatabase::iconForPageURL): Default Icon if disabled/closed (WebCore::IconDatabase::isIconExpiredForIconURL): Default return if disabled/closed (WebCore::IconDatabase::iconURLForPageURL): Default return if disabled/closed (WebCore::IconDatabase::retainIconForPageURL): Ignore if disabled/closed (WebCore::IconDatabase::releaseIconForPageURL): Ignore if disabled/closed (WebCore::IconDatabase::releaseIconURL): (WebCore::IconDatabase::setIconDataForIconURL): Ignore if disabled/closed (WebCore::IconDatabase::setIconURLForPageURL): Ignore if disabled/closed (WebCore::IconDatabase::hasEntryForIconURL): Default return if disabled/closed (WebCore::IconDatabase::setEnabled): Added
  • loader/icon/IconDatabase.h: (WebCore::IconDatabase::enabled): Added
  • page/Frame.cpp: (WebCore::Frame::endIfNotLoading): do an IconDatabase::enabled() check before bothering to load the icon
  • platform/mac/ResourceLoaderMac.mm: Removed extraneous #include

WebKit:

Reviewed by Sarge Decker

<rdar://problem/4739892> and <rdar://problem/4729797>

  • WebCore::IconDatabase needs to have and respect an enabled() flag
  • Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): If preference says icons are disabled, tell the bridge (-[WebIconDatabase _isEnabled]): Ask the bridge if the database is enabled
12:06 AM Changeset in webkit [16463] by hyatt
  • 7 edits in trunk/WebCore

Massage mouse wheel handling so that it is more cross-platform. Make
all the work happen in handleWheelEvent on the FrameView.

Reviewed by bradee-oh

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::wheelEvent):
  • page/FrameView.cpp: (WebCore::FrameView::handleWheelEvent):
  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::platformDelta): (WebCore::PlatformWheelEvent::delta):
  • platform/mac/WheelEventMac.mm: (WebCore::platformDeltaForEvent): (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scroll):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::scroll):

Sep 19, 2006:

10:37 PM Changeset in webkit [16462] by eseidel
  • 30 edits in trunk

2006-09-19 Eric Seidel <eric@eseidel.com>

Reviewed by adele.

Improve test output for filters with bounding-box relative sizes.
http://bugzilla.opendarwin.org/show_bug.cgi?id=8585

Many test results updated.

  • kcanvas/KCanvasFilters.cpp: (WebCore::KCanvasFilter::externalRepresentation):
10:26 PM Changeset in webkit [16461] by eseidel
  • 6 edits
    4 adds in trunk

2006-09-19 Eric Seidel <eric@eseidel.com>

Reviewed by adele.


Markers should clip to their viewport.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5967

Test: svg/custom/marker-overflow-clip.svg

  • kcanvas/KCanvasResources.cpp: (WebCore::KCanvasMarker::KCanvasMarker): (WebCore::KCanvasMarker::setMarker): (WebCore::KCanvasMarker::draw):
  • kcanvas/KCanvasResources.h: (WebCore::KCanvasMasker::mask):
  • ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::parseMappedAttribute): (WebCore::SVGMarkerElement::canvasResource): (WebCore::SVGMarkerElement::createRenderer):
8:57 PM Changeset in webkit [16460] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

Checking the mail post-commit hook on the new server

8:46 PM Changeset in webkit [16459] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

Checkin test on the new hardware!

6:57 PM Changeset in webkit [16458] by justing
  • 3 edits
    1 add
    1 delete in trunk

LayoutTests:

Reviewed by eseidel


Disabling this test temporarily.

  • editing/selection/editable-links.html: Removed.
  • editing/selection/editable-links.html-disabled: Added.

WebCore:

Reviewed by eseidel

Backing out my recent change.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
5:53 PM Changeset in webkit [16457] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Kevin McCullough

http://bugzilla.opendarwin.org/show_bug.cgi?id=10940
Opening a PDF in a new tab/window creates a documentless-frame
and we deref the document without checking its validity

  • page/Frame.cpp: (WebCore::Frame::iconURL):
4:36 PM Changeset in webkit [16456] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/selection/editable-links-expected.checksum: Added.
  • editing/selection/editable-links-expected.png: Added.
  • editing/selection/editable-links-expected.txt: Added.
  • editing/selection/editable-links.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4735272>
Can not click into link in programmatically editable content

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): We stopped using userModify to implement document wide editability.
4:25 PM Changeset in webkit [16455] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

I totally LIED in the Changelog

4:24 PM Changeset in webkit [16454] by beidson
  • 2 edits in trunk/WebCore

Reviewed and landed by Brady

Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10939
Build broken when SVG is not enabled.

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs):
3:44 PM Changeset in webkit [16453] by beidson
  • 1 edit
    1 add in trunk/WebKitSite

http://bugzilla.opendarwin.org/show_bug.cgi?id=8220
Add the favicon.ico to the site.
Notice, users of shipping Safari won't see the updated favicon
unless they clear their icon cache - ToT users can manually reload
the site and force the refresh ;)

  • favicon.ico: Added.
3:01 PM Changeset in webkit [16452] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/pasteboard/pasting-tabs-expected.checksum: Added.
  • editing/pasteboard/pasting-tabs-expected.png: Added.
  • editing/pasteboard/pasting-tabs-expected.txt: Added.
  • editing/pasteboard/pasting-tabs.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4727383> REGRESSION: Pasting plain text with tabs into Blot converts the tabs to single spaces

Pasting plain text results in a match style paste, and the insertion
position is whitespace normal, which clobbers the whitespace:pre on
tab spans. Skip changes to the whitespace mode when computing a style
change for tab spans or the text nodes inside tab spans.

  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): Don't change the whitespace mode inside tab spans.
2:31 PM Changeset in webkit [16451] by hyatt
  • 3 edits in trunk/WebCore

Fix for bug 5298, shape=default not supported for image maps. Implement
support for it.

Reviewed by timo

  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::getRegion):
  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::mapMouseEvent):
11:04 AM Changeset in webkit [16450] by ap
  • 2 edits in trunk/WebKit

Reviewed by Tim O.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10661
REGRESSION: CFM plug-ins (Shockwave, SVG) are not loaded

  • Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage initWithPath:]): On 32-bit PowerPC, don't bail out if the bundle is nil - it can be a CFM plugin.
10:25 AM Changeset in webkit [16449] by aroben
  • 5 edits in trunk/LayoutTests

Reviewed by Adele.

Update tests for the new file upload control.

  • fast/forms/file-input-disabled-expected.txt:
  • fast/forms/form-element-geometry-expected.txt:
  • fast/forms/input-appearance-height-expected.txt:
  • fast/forms/input-value-expected.txt:
10:23 AM Changeset in webkit [16448] by aroben
  • 3 edits in trunk/WebCore

Reviewed by Adele.

Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10824
"no file selected" placeholder text missing from file upload control

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderFileUploadControl.cpp: Remove class RenderFileUploadInnerFileBox, rename defaultFilenameNumChars to defaultWidthNumChars (WebCore::RenderFileUploadControl::RenderFileUploadControl): Call RenderBlock constructor instead of RenderFlexibleBox, (WebCore::RenderFileUploadControl::setStyle): Remove references to m_fileBox. (WebCore::RenderFileUploadControl::valueChanged): Call repaint() instead of updateIconAndFileName() (which has been removed) (WebCore::RenderFileUploadControl::updateFromElement): Remove references to m_fileBox, don't call updateIconAndFilename() (WebCore::RenderFileUploadControl::maxFilenameWidth): Calculate width without using m_fileBox (WebCore::RenderFileUploadControl::createButtonStyle): Remove now-unnecessary display:box rule. (WebCore::RenderFileUploadControl::paintObject): Remove redundant call to paintingDisabled() now that Icon::paint() does it, and add code to paint the filename directly. (WebCore::RenderFileUploadControl::calcMinMaxWidth): Move this method out of RenderFileUploadInnerFileBox and into RenderFileUploadControl
  • rendering/RenderFileUploadControl.h: Make RenderFileUploadControl a subclass of RenderBlock instead of RenderFlexibleBox, remove updateIconAndFilename() method, remove m_fileBox instance variable.
5:17 AM Changeset in webkit [22186] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-09-19 Anders Carlsson <acarlsson@apple.com>

Reviewed by Dave Hyatt.


<rdar://problem/4734743> Crash accessing YouTube.


  • config.h: Enable some more of the JSC bindings code on Windows.
2:48 AM Changeset in webkit [16447] by eseidel
  • 2 edits in trunk/WebCore

2006-09-19 Eric Seidel <eric@eseidel.com>

Reviewed by hyatt.

Exceptions thrown from <script> tags in XHTML/SVG docs show the wrong line numbers
http://bugzilla.opendarwin.org/show_bug.cgi?id=10846


No automated test case possible until http://bugzilla.opendarwin.org/show_bug.cgi?id=10905 is resolved.

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::XMLTokenizer::startElementNs): (WebCore::XMLTokenizer::endElementNs):
2:39 AM Changeset in webkit [16446] by eseidel
  • 2 edits in trunk/WebKitTools

2006-09-19 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by eseidel. Landed by eseidel.


Detect that close button was pressed and exit cleanly.

  • GdkLauncher/main.cpp: (handle_event): (main):
2:37 AM Changeset in webkit [16445] by eseidel
  • 4 edits in trunk/WebCore

2006-09-19 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by eseidel. Landed by eseidel.


Build fix only, no tests affected.

  • platform/gdk/FontPlatformDataGdk.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::isLoadTypeReload): (FrameGdk::originalRequestURL): (IconDatabase::setIconURLForPageURL):
2:10 AM Changeset in webkit [16444] by hyatt
  • 2 edits in trunk/WebCore

Refine the fix for 9805 to really get all the complex cases right.

Reviewed by Eric

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::handleBottomOfBlock):
2:08 AM Changeset in webkit [16443] by hyatt
  • 4 adds
    4 deletes in trunk/LayoutTests/fast/block/margin-collapse

Land changes for margin collapsing fixes. Yank bad layout test.

Sep 18, 2006:

11:23 PM Changeset in webkit [16442] by hyatt
  • 2 edits in trunk/WebCore

Fix for 9805, <hr> not positioned properly following a previous empty sibling
that had clear:both set on it. Update self-collapsing block clearance
behavior to match what is specified in the latest draft of CSS2.1.

Reviewed by Eric

Added fast/block/margin-collapse/empty-clear-blocks.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::handleBottomOfBlock):
7:47 PM Changeset in webkit [22185] by beidson
  • 4 edits in branches/WindowsMerge/WebCore

YABF and merged an open source change

7:36 PM Changeset in webkit [16441] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Brady, landed by Brady

Send receivedResponse callback to ResourceLoaderClient when loading
file URLs.

See http://bugzilla.opendarwin.org/show_bug.cgi?id=10845

  • platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::fileLoadTimer):
7:21 PM Changeset in webkit [16440] by beidson
  • 16 edits in trunk

WebCore:

Reviewed by Anders

<rdar://problem/3028061> - WebKit never updates favicon
The WebKit enforced expiration date for icons has worked for some time, but the
move to the new Icon Loader broke the "always get the icon if the user refreshes the page"
functionality. This patch fixes that up, along with some other architectural improvements,
the main one being that WebCore::Document now contains an iconURL for the Frame to query if needed.

  • bridge/mac/FrameMac.h: Added isLoadTypeReload()
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::isLoadTypeReload): Implementation, calls into the bridge
  • bridge/mac/WebCoreFrameBridge.h: Added isLoadTypeReload:
  • bridge/win/FrameWin.h: Added isLoadTypeReload() for temporary link stub
  • dom/Document.h: Added m_iconURL (WebCore::Document::iconURL): Added (WebCore::Document::setIconURL): Ditto
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): Sets the iconURL in the Document instead of the Frame
  • page/Frame.cpp: (WebCore::Frame::iconURL): Calculates the iconURL based on the document, then the default favicon.ico url (WebCore::Frame::endIfNotLoading): Checks for the load type - always loads icon on Reload
  • page/Frame.h: Nuked setIconURL(), added isLoadTypeReload()
  • page/FramePrivate.h: Nuked IconURL
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::isLoadTypeReload):

WebKit:

Reviewed by Anders

Implement a bridge method so WebCore can find the reload type of a frame load

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge isLoadTypeReload]):
7:10 PM Changeset in webkit [22184] by hyatt
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/WebKit.vcproj

Fix more build bustage. Remove CoreGraphics.lib from the set of linked against libraries.

6:55 PM Changeset in webkit [22183] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Fix build bustage caused by removal of ColorCG.cpp I guess?

5:53 PM Changeset in webkit [22182] by seangies
  • 2 edits in branches/WindowsMerge/WebCore

Support bold & italics text with CG on Windows

4:44 PM Changeset in webkit [22181] by seangies
  • 7 edits in branches/WindowsMerge

Last few CoreGraphics integration compile fixes

4:15 PM Changeset in webkit [16439] by weinig
  • 3 edits in trunk/WebCore

Reviewed by Tim H.

  • Re-add private method [DOMRGBColor _color] to DOMPrivate.h as it is it turns out that AppKit uses it.
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor _color]):
2:40 PM Changeset in webkit [16438] by weinig
  • 18 edits
    6 adds
    1 delete in trunk

WebCore:

Reviewed by Tim H.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10903
Yet Another Objective-C Bindings Patch

  • Whitespace cleanup for IDLParser.pm
  • Split DOMException, DOMRangeException, DOMXPathException, DOMEventsException and DOMAbstractView into their own files.
  • Remove private method [DOMRGBColor _color] from DOMPrivate.h as it is not used and a public method is available now.
  • Remove internal method [DOMDocument _ownerElement] from DOMInternal.h as it not used.
  • Auto-generate method isContentEditable for DOMNode.
  • General cleanup of bindings code including removing unneeded #imports and whitespace cleanup
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (addElementClass): (elementClass): (-[DOMNode _initWithNode:WebCore::]): (+[DOMNode _nodeWith:WebCore::]): (-[DOMNode WebCore::]): (-[DOMNode KJS::Bindings::]): (-[DOMNode addEventListener:::]): (-[DOMNode removeEventListener:::]): (-[DOMNode dispatchEvent:]): (-[DOMElement image]): (-[DOMElement _font]): (-[DOMElement _imageTIFFRepresentation]): (-[DOMElement _getURLAttribute:]): (-[DOMElement _NPObject]): (-[DOMElement isFocused]): (-[DOMRange dealloc]): (-[DOMRange finalize]): (-[DOMRange description]): (-[DOMRange startContainer]): (-[DOMRange startOffset]): (-[DOMRange endContainer]): (-[DOMRange endOffset]): (-[DOMRange collapsed]): (-[DOMRange commonAncestorContainer]): (-[DOMRange setStart::]): (-[DOMRange setEnd::]): (-[DOMRange setStartBefore:]): (-[DOMRange setStartAfter:]): (-[DOMRange setEndBefore:]): (-[DOMRange setEndAfter:]): (-[DOMRange collapse:]): (-[DOMRange selectNode:]): (-[DOMRange selectNodeContents:]): (-[DOMRange compareBoundaryPoints::]): (-[DOMRange deleteContents]): (-[DOMRange extractContents]): (-[DOMRange cloneContents]): (-[DOMRange insertNode:]): (-[DOMRange surroundContents:]): (-[DOMRange cloneRange]): (-[DOMRange toString]): (-[DOMRange detach]): (-[DOMRange _initWithRange:WebCore::]): (+[DOMRange _rangeWith:WebCore::]): (-[DOMRange WebCore::]): (-[DOMNodeFilter _initWithNodeFilter:WebCore::]): (+[DOMNodeFilter _nodeFilterWith:WebCore::]): (-[DOMNodeFilter WebCore::]): (-[DOMNodeFilter dealloc]): (-[DOMNodeFilter finalize]): (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]): (-[DOMNodeIterator WebCore::]): (+[DOMNodeIterator _nodeIteratorWith:WebCore::filter:]): (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]): (-[DOMTreeWalker WebCore::]): (+[DOMTreeWalker _treeWalkerWith:WebCore::filter:]): (ObjCNodeFilterCondition::acceptNode): (-[DOMDocument createNodeIterator::::]): (-[DOMDocument createTreeWalker::::]): (ObjCEventListener::find): (ObjCEventListener::create): (ObjCEventListener::handleEvent):
  • bindings/objc/DOMAbstractView.h: Added.
  • bindings/objc/DOMAbstractView.mm: Added. (-[DOMAbstractView document]): (-[DOMAbstractView WebCore::]): (-[DOMAbstractView _initWithAbstractView:WebCore::]): (+[DOMAbstractView _abstractViewWith:WebCore::]):
  • bindings/objc/DOMCSS.mm: (-[DOMStyleSheet _initWithStyleSheet:WebCore::]): (+[DOMStyleSheet _styleSheetWith:WebCore::]): (+[DOMCSSStyleSheet _CSSStyleSheetWith:WebCore::]): (-[DOMCSSRule _initWithRule:WebCore::]): (+[DOMCSSRule _CSSRuleWith:WebCore::]): (-[DOMCSSValue _initWithValue:WebCore::]): (+[DOMCSSValue _CSSValueWith:WebCore::]): (+[DOMCSSPrimitiveValue _CSSPrimitiveValueWith:WebCore::]): (-[DOMDocument getComputedStyle::]): (-[DOMDocument getMatchedCSSRules::]):
  • bindings/objc/DOMCore.h:
  • bindings/objc/DOMEventException.h: Added.
  • bindings/objc/DOMEvents.h:
  • bindings/objc/DOMEvents.mm:
  • bindings/objc/DOMException.h: Added.
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): (viewForElement): (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]): (-[DOMHTMLInputElement _selectedRange]): (-[DOMHTMLInputElement _setAutofilled:]):
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMObject.h:
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/DOMRange.h:
  • bindings/objc/DOMRangeException.h: Added.
  • bindings/objc/DOMViews.h:
  • bindings/objc/DOMViews.mm: Removed.
  • bindings/objc/DOMXPath.h:
  • bindings/objc/DOMXPathException.h: Added.
  • bindings/scripts/IDLParser.pm:
  • dom/Node.idl:

WebKit:

Reviewed by Tim H.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10903
Yet Another Objective-C Bindings Patch

  • MigrateHeaders.make:
2:37 PM Changeset in webkit [16437] by harrison
  • 5 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4494340> REGRESSION: Making the font size bigger/smaller in an HTML message doesn't affect the body until you reopen it

Problem was the public API -[WebView setTextSizeMultiplier] did not notify anyone that the value changed.


  • WebView/WebDocumentInternal.h: Add _textSizeMultiplierChanged to the _WebDocumentTextSizing protocol.


  • WebView/WebHTMLView.m: (-[WebHTMLView _textSizeMultiplierChanged]): Send [self _updateTextSizeMultiplier].


  • WebView/WebPDFView.m: (-[WebPDFView _textSizeMultiplierChanged]): ASSERT_NOT_REACHED() because WebPDFView does not track the common multiplier.


  • WebView/WebView.m: (-[WebView setTextSizeMultiplier:]): Send [self _notifyTextSizeMultiplierChanged];


(-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:newScaleFactor:]):
Alter the _textSizeMultiplier directly so that notification is not sent.
Minor formatting.


(-[WebView _notifyTextSizeMultiplierChanged]):
New. Send _textSizeMultiplierChanged to all document views that track the common multiplier.

1:50 PM Changeset in webkit [22180] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix (release).

  • WebHistory.cpp: (_WebCoreHistoryProvider::containsItemForURLLatin1): Remove unused HRESULT. (_WebCoreHistoryProvider::containsItemForURLUnicode): Ditto.
1:42 PM Changeset in webkit [16436] by beidson
  • 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

ACTUAL Windows build fix

1:32 PM Changeset in webkit [16435] by beidson
  • 2 edits in trunk/WebCore

Windows build fix

  • platform/win/TemporaryLinkStubs.cpp: (IconDatabase::setIconURLForPageURL):
12:56 PM Changeset in webkit [22179] by andersca
  • 7 adds in branches/WindowsMerge/WebKitTools

2006-09-18 Anders Carlsson <acarlsson@apple.com>

Reviewed by John.

Fork DumpRenderTree from OpenSource repository (r16433).


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Added. (loadResourceIntoArray): (localFileTest): (dumpRenderTreeMain): (dumpRenderTreeToStdOut): (serializeToStdOut): (main):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added.
12:20 PM Changeset in webkit [16434] by hyatt
  • 4 adds in trunk/LayoutTests/fast/block/float

Add layout test for float bug.

12:12 PM Changeset in webkit [16433] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 3969, hr width doesn't update when it clears a float. This
was also a problem with tables and overflow sections.

Reviewed by Eric

Added fast/block/float/width-update-after-clear.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded):
12:07 PM Changeset in webkit [16432] by hyatt
  • 171 edits in trunk/LayoutTests/tables

Update table layout test results.

12:06 PM Changeset in webkit [16431] by hyatt
  • 140 edits in trunk/LayoutTests/tables/mozilla_expected_failures/marvin

Update table layout test results.

12:05 PM Changeset in webkit [16430] by hyatt
  • 114 edits in trunk/LayoutTests/tables/mozilla_expected_failures/bugs

Update table layout test results.

12:00 PM Changeset in webkit [16429] by hyatt
  • 568 edits in trunk/LayoutTests/tables/mozilla/marvin

Update table layout test results.

11:55 AM Changeset in webkit [16428] by hyatt
  • 469 edits in trunk/LayoutTests/tables/mozilla/bugs

Update table layout test results.

11:51 AM Changeset in webkit [22178] by beidson
  • 3 edits in branches/WindowsMerge/WebCore

Build Fix

11:45 AM Changeset in webkit [22177] by seangies
  • 2 edits
    1 add in branches/WindowsMerge/WebCore

Forked FontCacheWin.cpp from OpenSource tree r16421

11:19 AM Changeset in webkit [16427] by thatcher
  • 2 edits in tags/WebKit-521.26.1/WebKit

Build fix and versioning.

11:16 AM Changeset in webkit [16426] by thatcher
  • 1 copy in tags/WebKit-521.26.1/WebKit

New tag part 2

11:15 AM Changeset in webkit [16425] by brmorris
  • 1 copy in S60/branches/3.1m

Creating new branch.

11:14 AM Changeset in webkit [16424] by thatcher
  • 1 add in tags/WebKit-521.26.1

New tag part 1.

11:13 AM Changeset in webkit [16423] by beidson
  • 7 edits in trunk/WebCore

Reviewed by John

http://bugzilla.opendarwin.org/show_bug.cgi?id=10907
REGRESSION: New Icon Loaders don't handle certain non-server-root URLs correctly

  • bridge/mac/FrameMac.h: Changed originalRequestURL() to virtual
  • bridge/win/FrameWin.h: Added originalRequestURL()
  • loader/icon/IconLoader.cpp: (IconLoader::receivedAllData): Moved the "pageURL to iconURL mapping logic" to Frame::commitIconURLToIconDatabase()
  • page/Frame.cpp: (WebCore::Frame::iconURL): Construct the icon URL from *only* the protocol and host of the frame's url. (WebCore::Frame::endIfNotLoading): Call commitIconURLToIconDatabase() if we're not kicking off an icon load (WebCore::Frame::commitIconURLToIconDatabase): Map the completed doc's pageURL to the iconURL
  • page/Frame.h: Added pure virtual originalRequestURL()
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::originalRequestURL): Added
11:11 AM Changeset in webkit [16422] by thatcher
  • 1 edit in trunk/WebKit/WebInspector/WebInspector.m

Build fix, NSIntMapValueCallBacks is deprecated infavor of the new name NSIntegerMapValueCallBacks. Just make a new NSMapTableValueCallBacks of {NULL, NULL, NULL} to make it build on new or older systems.

2:25 AM Changeset in webkit [16421] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10807
REGRESSION (r16259): Repro crash on manual-tests/svg-repaint-image.svg

Make sure the paint method is not exited without popping
context and transparency layer.

2:16 AM Changeset in webkit [16420] by bdash
  • 2 edits in trunk/WebCore

2006-09-18 Graham Dennis <graham.dennis@gmail.com>

Reviewed by Eric.



  • bindings/scripts/CodeGeneratorObjC.pm: For each file generated add a #ifdef <something>_SUPPORT / #endif pair if the idl file has a Conditional extended attribute

Sep 17, 2006:

11:45 PM Changeset in webkit [16419] by eseidel
  • 2 edits in trunk/WebCore

2006-09-17 Eric Seidel <eric@eseidel.com>

Reviewed by ap.


REGRESSION (r16245): double-clicking on javascript exceptions fails to show source
http://bugzilla.opendarwin.org/show_bug.cgi?id=10813

  • bridge/mac/WebCoreFrameBridge.mm: (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
11:14 PM Changeset in webkit [16418] by eseidel
  • 2 edits in trunk/LayoutTests

2006-09-17 Eric Seidel <eric@eseidel.com>

Reviewed by hyatt.

  • fast/js/window-properties.html: make work in Firefox (hangs IE)
10:03 PM Changeset in webkit [16417] by ap
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10779
REGRESSION: Animated GIF ignores frame intervals and loops infinitely

No test possible.

  • platform/Image.cpp: (WebCore::Image::shouldAnimate): Don't check that there is more than one frame, maybe the rest just hasn't been loaded yet. (WebCore::Image::startAnimation): Move the frame count check here - there is no need to start animating before we get at least two frames.
9:46 PM Changeset in webkit [16416] by eseidel
  • 1 edit
    2 adds in trunk/LayoutTests

2006-09-17 Eric Seidel <eric@eseidel.com>

Add a textual dump of the window object property tree.

Reviewed by Sarge.

  • fast/js/window-properties-expected.txt: Added.
  • fast/js/window-properties.html: Added.
5:48 PM Changeset in webkit [16415] by hyatt
  • 6 edits in trunk/LayoutTests/tables/mozilla/bugs

Land updated tests for font changes.

5:46 PM Changeset in webkit [16414] by hyatt
  • 3 edits in trunk/LayoutTests/css2.1

Land updated tests for font changes.

5:45 PM Changeset in webkit [16413] by hyatt
  • 6 edits in trunk/LayoutTests/css1/font_properties

Land updated tests for font changes.

4:17 PM Changeset in webkit [16412] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Sarge

IconLoader now gracefully handles the condition where there's no document in the frame
(ie. PDFs)

  • loader/icon/IconLoader.cpp: (IconLoader::startLoading):
4:06 PM Changeset in webkit [16411] by hyatt
  • 5 edits in trunk/WebCore

Fix for bug 10899, rework how CSS keywords work to be smarter about
using the correct size when generic families change (e.g., monospace to
serif and vice versa).

Reviewed by aroben

Added fast/text/basic/generic-family-changes.html

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::checkForGenericFamilyChange): (WebCore::CSSStyleSelector::fontSizeForKeyword):
  • css/cssstyleselector.h:
  • dom/Document.cpp: (WebCore::Document::recalcStyle):
  • platform/FontDescription.h: (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::keywordSize): (WebCore::FontDescription::setKeywordSize): (WebCore::FontDescription::operator==):
4:04 PM Changeset in webkit [16410] by hyatt
  • 1 edit
    4 adds in trunk/LayoutTests

Adding layout test for bug 10899.

  • fast/text/basic/generic-family-changes-expected.checksum: Added.
  • fast/text/basic/generic-family-changes-expected.png: Added.
  • fast/text/basic/generic-family-changes-expected.txt: Added.
  • fast/text/basic/generic-family-changes.html: Added.
2:39 PM Changeset in webkit [16409] by aroben
  • 4 edits in trunk/WebKitTools

Reviewed by hyatt, sfalken.

Get DumpRenderTree compiling and limping along on Windows.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (loadResourceIntoArray): Added this function that WebCore::ImageWin needs from WebKit (main): Add NULL argument to Page constructor.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Remove incorrect "wininet.dll" argument to CC, fix JavaScriptCore.lib path, add *_SECURE_NO_DEPRECATE #defines
  • Scripts/webkitdirs.pm: Fix JavaScriptCore.lib path
1:18 PM Changeset in webkit [16408] by ap
  • 4 edits
    2 adds in trunk

Reviewed by Brady.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10852
REGRESSION: Reproducible crash in XMLHttpRequest::abort()

Test: http/tests/xmlhttprequest/xhr-onunload.html

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): Check the return value of ResourceLoader::start().
  • loader/icon/IconLoader.cpp: (IconLoader::startLoading): Fix a similar latent bug here.
12:37 PM Changeset in webkit [16407] by aroben
  • 2 edits in trunk/WebCore

Build fix.

  • loader/icon/IconDatabase.cpp:
12:29 PM Changeset in webkit [22176] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix.

  • WebView.cpp: (WebView::keyPress): Add new "userTriggered" argument to calls to SelectionController::modify
12:24 PM Changeset in webkit [16406] by hyatt
  • 1 edit in trunk/LayoutTests/fast/text/whitespace/013-expected.txt

Land updated results from font fix yesterday.

11:36 AM Changeset in webkit [16405] by andersca
  • 29 edits in trunk/WebCore

2006-09-17 Anders Carlsson <acarlsson@apple.com>

Reviewed by Brady.

Add simplifyWhiteSpace and stripWhiteSpace to the String class.
Change the XSLT Parameter Map to use Strings instead of StringImpls.
General cleanup.

  • bindings/js/JSXSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
  • bindings/js/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute):
  • css/MediaList.cpp: (WebCore::MediaList::setMediaText):
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init):
  • html/HTMLDocument.cpp: (WebCore::parseDocTypeDeclaration):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::attach): (WebCore::HTMLObjectElement::setComplete): (WebCore::HTMLObjectElement::detach): (WebCore::HTMLObjectElement::recalcStyle): (WebCore::HTMLObjectElement::childrenChanged): (WebCore::HTMLObjectElement::isImageType):
  • html/HTMLObjectElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::value):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::appendFormData):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
  • ksvg2/svg/SVGColor.cpp: (WebCore::SVGColor::setRGBColor):
  • ksvg2/svg/SVGDescElement.cpp: (WebCore::SVGDescElement::description):
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::stripWhiteSpace): (WebCore::String::simplifyWhiteSpace):
  • platform/StringImpl.cpp: (WebCore::isSpace): (WebCore::parseLength): (WebCore::StringImpl::stripWhiteSpace): (WebCore::StringImpl::simplifyWhiteSpace): (WebCore::StringImpl::toInt):
  • platform/StringImpl.h:
  • platform/mac/ClipboardMac.mm: (WebCore::cocoaTypeFromMIMEType):
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunNormalizeSpace::doEvaluate):
  • xml/XPathGrammar.y:
  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodeTestMatches):
  • xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::loadChildSheets): (WebCore::XSLStyleSheet::locateStylesheetSubResource):
  • xml/XSLTProcessor.cpp: (WebCore::xsltParamArrayFromParameterMap): (WebCore::XSLTProcessor::setParameter): (WebCore::XSLTProcessor::getParameter): (WebCore::XSLTProcessor::removeParameter):
  • xml/XSLTProcessor.h:
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getStatusText):
8:28 AM Changeset in webkit [16404] by hyatt
  • 4 adds in trunk/LayoutTests/fast/forms

Add fieldset layout test.

8:27 AM Changeset in webkit [16403] by hyatt
  • 7 edits in trunk/WebCore

Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
are declared right before the fieldsets. It turns out fieldsets in other
browsers avoid floats (like overflow:auto/hidden/scroll sections do), so
adding that behavior to fieldset fixes the bug.

Made avoidsFloats virtual and did some refactoring to make tables, flexboxes
and fieldsets all subclass.

Reviewed by anders

Added fast/forms/float-before-fieldset.html

  • rendering/RenderFieldset.h: (WebCore::RenderFieldset::avoidsFloats):
  • rendering/RenderFlexibleBox.h: (WebCore::RenderFlexibleBox::avoidsFloats):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::avoidsFloats):
  • rendering/RenderObject.h:
  • rendering/RenderTable.h: (WebCore::RenderTable::avoidsFloats):
7:35 AM Changeset in webkit [16402] by hyatt
  • 1 edit in trunk/LayoutTests/tables/mozilla/bugs/bug24200.html

Update buggy table test to not have a degenrate column structure.

7:35 AM Changeset in webkit [16401] by hyatt
  • 1 edit in trunk/LayoutTests/tables/mozilla_expected_failures/core/table_rules.html

Update buggy table test to say rules=groups and not rules=group

1:00 AM Changeset in webkit [16400] by hyatt
  • 4 adds in trunk/LayoutTests/fast/table

Add frame/rules layout test.

12:57 AM Changeset in webkit [16399] by hyatt
  • 9 edits in trunk/WebCore

Fix for bugzilla bug 3240, implement support for the HTML4 "frame" and
"rules" attributes on tables.

Reviewed by bradee-oh

Well-covered by existing layout tests.

  • html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::additionalAttributeStyleDecl):
  • html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::additionalAttributeStyleDecl):
  • html/HTMLTableColElement.h:
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::HTMLTableElement): (WebCore::HTMLTableElement::~HTMLTableElement): (WebCore::HTMLTableElement::setCaption): (WebCore::HTMLTableElement::setTHead): (WebCore::HTMLTableElement::setTFoot): (WebCore::HTMLTableElement::setTBody): (WebCore::HTMLTableElement::createTHead): (WebCore::HTMLTableElement::deleteTHead): (WebCore::HTMLTableElement::createTFoot): (WebCore::HTMLTableElement::deleteTFoot): (WebCore::HTMLTableElement::createCaption): (WebCore::HTMLTableElement::deleteCaption): (WebCore::HTMLTableElement::insertRow): (WebCore::HTMLTableElement::deleteRow): (WebCore::HTMLTableElement::addChild): (WebCore::HTMLTableElement::childrenChanged): (WebCore::HTMLTableElement::mapToEntry): (WebCore::HTMLTableElement::parseMappedAttribute): (WebCore::HTMLTableElement::additionalAttributeStyleDecl): (WebCore::HTMLTableElement::getSharedCellDecl): (WebCore::HTMLTableElement::getSharedGroupDecl): (WebCore::HTMLTableElement::attach):
  • html/HTMLTableElement.h: (WebCore::HTMLTableElement::caption): (WebCore::HTMLTableElement::tHead): (WebCore::HTMLTableElement::tFoot): (WebCore::HTMLTableElement::):
  • html/HTMLTableRowElement.h:
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecl):
  • html/HTMLTableSectionElement.h:
12:43 AM Changeset in webkit [16398] by hyatt
  • 4 adds in trunk/LayoutTests/fast/text/basic

Add layout test for bug 4192.

12:39 AM Changeset in webkit [16397] by hyatt
  • 1 edit in trunk/WebCore/ChangeLog

Fix for bugzilla bug 4192, font size wrong for <tt> elements that
specify their own new font-family list. Make sure to always
reset the generic family along with the family list when mapping in
new font-family values.

Reviewed by bradee-oh

fast/text/basic/generic-family-reset.html

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
12:39 AM Changeset in webkit [16396] by hyatt
  • 2 edits in trunk/WebCore

Fix for bugzilla bug 4129, font size wrong for <tt> elements that
specify their own new font-family list. Make sure to always
reset the generic family along with the family list when mapping in
new font-family values.

Reviewed by bradee-oh

fast/text/basic/generic-family-reset.html

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
12:29 AM Changeset in webkit [16395] by beidson
  • 18 edits
    2 deletes in trunk

WebCore:

Reviewed by Hyatt

Pruning code relating to WebKit's icon loader

  • bridge/mac/WebCoreIconDatabaseBridge.h:
  • bridge/mac/WebCoreIconDatabaseBridge.mm:
  • loader/icon/IconDatabase.h:
  • page/Frame.cpp: (WebCore::Frame::endIfNotLoading): Moved a FIXME in from WebKit's IconLoader to its new home

WebKit:

Reviewed by Hyatt

WebIconLoader is dead, long live WebCore::IconLoader
(code prune)

  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader dealloc]): (-[WebFrameLoader commitProvisionalLoad]):
  • Loader/WebIconLoader.h: Removed.
  • Loader/WebIconLoader.m: Removed.
  • Misc/WebIconDatabase.h:
  • Misc/WebIconDatabase.m:
  • Misc/WebIconDatabasePrivate.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge notifyIconChanged:]):
  • WebCoreSupport/WebIconDatabaseBridge.h:
  • WebCoreSupport/WebIconDatabaseBridge.m: (-[WebIconDatabaseBridge _init]): (-[WebIconDatabaseBridge _setIconData:forIconURL:]): (-[WebIconDatabaseBridge _setHaveNoIconForIconURL:]):
  • WebKit.exp:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _stopLoading]): (-[WebDataSource _setPrimaryLoadComplete:]):
  • WebView/WebDataSourceInternal.h:

Sep 16, 2006:

2:13 PM Changeset in webkit [16394] by weinig
  • 9 edits
    2 deletes in trunk/WebCore

Reviewed by Tim H.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10885
Auto-generate DOMHTMLDocument for the Objective-C bindings

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument createDocumentFragmentWithText:]):
  • bindings/objc/DOMHTMLDocument.h: Removed.
  • bindings/objc/DOMHTMLDocument.mm: Removed.
  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • html/HTMLDocument.idl:
  • platform/DeprecatedString.h: (WebCore::DeprecatedString::operator NSString*):
9:15 AM Changeset in webkit [16393] by rwlbuis
  • 15 edits in trunk/WebCore

Reviewed by Eric.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10866
Code in kcanvas/ should not use Private

Remove Private classes and tweak coding style.

8:13 AM Changeset in webkit [16392] by bdash
  • 4 edits in trunk

2006-09-16 Mark Rowe <opendarwin.org@bdash.net.nz>

Reviewed by Anders.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10887
Fix build error

  • bindings/objc/DOMPrivate.h: Remove reference to DOMEventPrivate.h.

2006-09-16 Mark Rowe <opendarwin.org@bdash.net.nz>

Reviewed by Anders.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10887
Fix build error

  • MigrateHeaders.make: Remove reference to DOMEventPrivate.h.
8:11 AM Changeset in webkit [16391] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Anders.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10886
REGRESSION (r16387): Reproducible crash when mousing over HTML document

  • Special case method [DOMNode ownerDocument] to call document() instead or ownerDocument() to return to the old behavior.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorObjC.pm:
Note: See TracTimeline for information about the timeline view.