Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Oct 25, 2006:

10:04 PM Changeset in webkit [17299] by darin

• 40 edits in trunk

WebCore:

Reviewed by Anders.

• removed 55 methods from WebCoreFrameBridge
• changed callers to use Frame directly instead
• put FrameLoaderTypes.h types into the WebCore namespace
• first steps to get FrameLoader.h ready for cross-platform duty

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:
• bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::startRedirectionTimer): (WebCore::FrameMac::stopRedirectionTimer): (WebCore::FrameMac::passSubframeEventToSubframe): (WebCore::FrameMac::handledOnloadEvents): (WebCore::FrameMac::isLoadTypeReload):
• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge executionContextForView:]): (updateRenderingForBindings): (-[WebCoreFrameBridge canTargetLoadInFrame:]): (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]): (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): (-[WebCoreFrameBridge installInFrame:]): (-[WebCoreFrameBridge numPendingOrLoadingRequests]): (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreFrameBridge baseWritingDirectionForSelectionStart]): (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (stringByCollapsingNonPrintingCharacters): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
• loader/FrameLoaderTypes.h:
• loader/mac/FrameLoader.h:
• loader/mac/FrameLoader.mm: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::setupForReplace): (WebCore::FrameLoader::load): (WebCore::FrameLoader::activeDocumentLoader): (WebCore::FrameLoader::state): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::markLoadComplete): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::handleFallbackContent): (WebCore::FrameLoader::isLoadingMainFrame): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueAfterWillSubmitForm): (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]): (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]): (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]):
• loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
• loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::isLoadingInAPISense):
• loader/mac/WebMainResourceLoader.h:
• loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::continueAfterContentPolicy): (-[WebCoreMainResourceLoaderAsPolicyDelegate continueAfterContentPolicy:]):
• loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]):
• platform/mac/ListBoxMac.mm: (-[WebCoreTableView keyDown:]): (-[WebCoreTableView keyUp:]):
• platform/mac/WebCoreTextField.mm: (-[WebCoreTextFieldController textView:shouldHandleEvent:]):

WebKit:

Reviewed by Anders.

• removed 55 methods from WebCoreFrameBridge
• changed callers to use Frame directly instead
• put FrameLoaderTypes.h types into the WebCore namespace
• first steps to get FrameLoader.h ready for cross-platform duty

• DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
• Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView requestWithURLCString:]): (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView getVariable:value:]):
• Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView didStart]):
• Plugins/WebNetscapePluginStream.mm:
• Plugins/WebPluginContainerCheck.m: (-[WebPluginContainerCheck _continueWithPolicy:]): (-[WebPluginContainerCheck _isForbiddenFileLoad]):
• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldShowDeleteInterface):
• WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge webView]): (-[WebFrameBridge finishInitializingWithFrameName:view:]): (-[WebFrameBridge createWindowWithURL:]): (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]): (-[WebFrameBridge windowObjectCleared]): (-[WebFrameBridge createModalDialogWithURL:]):
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchWillSubmitForm):
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebArchiver.m: (+[WebArchiver archiveSelectionInFrame:]):
• WebView/WebDataSource.mm: (-[WebDataSource _documentFragmentWithImageResource:]): (-[WebDataSource _imageElementWithImageResource:]):
• WebView/WebEditingDelegatePrivate.h:
• WebView/WebFrame.mm: (core): (kit): (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): (-[WebFrame _canCachePage]): (-[WebFrame _childFramesMatchItem:]): (-[WebFrame _URLsMatchItem:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): (-[WebFrame _viewWillMoveToHostWindow:]): (-[WebFrame _viewDidMoveToHostWindow]): (-[WebFrame _addChild:]): (-[WebFrame _saveDocumentAndScrollState]): (-[WebFrame _numPendingOrLoadingRequests:]): (-[WebFrame _reloadForPluginChanges]): (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): (-[WebFrame _initWithWebFrameView:webView:coreFrame:]): (-[WebFrame _documentViews]): (-[WebFrame _updateBackground]): (-[WebFrame _unmarkAllMisspellings]): (-[WebFrame _hasSelection]): (-[WebFrame _atMostOneFrameHasSelection]): (-[WebFrame _findFrameWithSelection]): (-[WebFrame _frameLoader]): (-[WebFrame _isDescendantOfFrame:]): (-[WebFrame _setShouldCreateRenderers:]): (-[WebFrame _bodyBackgroundColor]): (-[WebFrame init]): (-[WebFrame initWithName:webFrameView:webView:]): (-[WebFrame dealloc]): (-[WebFrame finalize]): (-[WebFrame name]): (-[WebFrame webView]): (-[WebFrame DOMDocument]): (-[WebFrame frameElement]): (-[WebFrame findFrameNamed:]): (-[WebFrame parentFrame]): (-[WebFrame childFrames]): (-[WebFrame _invalidateCurrentItemPageCache]): (-[WebFrame _dispatchCreateWebViewWithRequest:]): (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _provisionalLoadStarted]):
• WebView/WebFrameInternal.h:
• WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation DOMDocument]): (-[WebHTMLRepresentation attributedText]):
• WebView/WebHTMLView.m: (-[WebHTMLView _documentRange]): (-[WebHTMLView _documentFragmentWithPaths:]): (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): (-[WebHTMLView _selectedRange]): (-[WebHTMLView _updateMouseoverWithEvent:]): (-[WebHTMLView _canEditRichly]): (-[WebHTMLView _hasSelection]): (-[WebHTMLView _hasSelectionOrInsertionPoint]): (-[WebHTMLView _hasInsertionPoint]): (-[WebHTMLView _isEditable]): (-[WebHTMLView _isSelectionInPasswordField]): (-[WebHTMLView _lookUpInDictionaryFromMenu:]): (-[WebHTMLView _selectionDraggingImage]): (-[WebHTMLView _canIncreaseSelectionListLevel]): (-[WebHTMLView _canDecreaseSelectionListLevel]): (-[WebHTMLView _updateActiveState]): (-[NSArray readSelectionFromPasteboard:]): (-[NSArray validateUserInterfaceItem:]): (-[NSArray maintainsInactiveSelection]): (-[NSArray menuForEvent:]): (-[NSArray scrollWheel:]): (-[NSArray acceptsFirstMouse:]): (-[NSArray shouldDelayWindowOrderingForEvent:]): (-[NSArray mouseDown:]): (-[NSArray mouseDragged:]): (-[NSArray mouseUp:]): (-[NSArray keyDown:]): (-[NSArray keyUp:]): (-[NSArray centerSelectionInVisibleArea:]): (-[NSArray _selectionStartFontAttributesAsRTF]): (-[NSArray _emptyStyle]): (-[NSArray performKeyEquivalent:]): (-[NSArray indent:]): (-[NSArray outdent:]): (-[WebHTMLView cut:]): (-[WebHTMLView paste:]): (-[WebHTMLView _selectRangeInMarkedText:]): (-[WebTextCompleteController doCompletion]): (-[WebHTMLView selectionRect]): (-[WebHTMLView selectionImageForcingWhiteText:]): (-[WebHTMLView selectionImageRect]): (-[WebHTMLView attributedString]): (-[WebHTMLView _isMoveDrag]): (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
• WebView/WebPolicyDelegate.mm: (-[WebPolicyDecisionListener _usePolicy:]): (-[WebPolicyDecisionListener use]): (-[WebPolicyDecisionListener ignore]): (-[WebPolicyDecisionListener download]): (-[WebPolicyDecisionListener continue]):
• WebView/WebScriptDebugDelegate.m: (-[WebScriptCallFrame _initWithFrame:initWithWebFrame:]): (-[WebScriptCallFrame globalObject]):
• WebView/WebView.mm: (-[WebView _attachScriptDebuggerToAllFrames]): (-[WebView _detachScriptDebuggerFromAllFrames]): (-[WebView windowScriptObject]): (incrementFrame): (-[WebView searchFor:direction:caseSensitive:wrap:]): (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]): (-[WebView removeDragCaret]): (-[WebView setScriptDebugDelegate:]): (-[WebView scriptDebugDelegate]): (-[WebView shouldClose]): (-[WebView selectedDOMRange]): (-[WebView styleDeclarationWithText:]):

7:43 PM Changeset in webkit [17298] by bdash

• 2 edits in trunk/WebKitSite

2006-10-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.

• ​http://bugs.webkit.org/show_bug.cgi?id=11412 Stray list item in coding/coding-style.html

• coding/coding-style.html:

5:48 PM Changeset in webkit [22428] by sfalken

• 3 edits in branches/WindowsMerge/WebKitWin

2006-10-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.

Checked in Luke's CG printing code

• WebView.cpp: (WebView::print): added (WebViewWndProc): call print from WM_PRINTCLIENT
• WebView.h: added print, m_pages, rearranged includes

5:48 PM Changeset in webkit [22427] by sfalken

• 3 edits in branches/WindowsMerge/WebCore

2006-10-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.

Checked in Luke's CG printing code

• bridge/win/FrameWin.cpp: (WebCore::FrameWin::setupRootForPrinting): Added (WebCore::FrameWin::computePageRects): Added
• bridge/win/FrameWin.h: Added setupRootForPrinting, computePageRects

5:43 PM Changeset in webkit [17297] by sfalken

• 3 edits in trunk/WebCore

2006-10-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.

Printing fixes

• page/Frame.cpp: (WebCore::Frame::adjustPageHeight):
• page/Frame.h: (WebCore::Frame::setupRootForPrinting): (WebCore::Frame::computePageRects):

5:29 PM Changeset in webkit [17296] by kmccullo

• 2 edits in trunk/JavaScriptCore

Reviewed by Steve (rubber stamp).

• Link against your local build of JavaScriptCore.lib first, this fixes some errors on release builds of testkjs.

• JavaScriptCore.vcproj/testkjs/testkjs.vcproj:

5:27 PM Changeset in webkit [17295] by thatcher

• 2 edits in trunk/WebKitLibraries

Reverting my change, broke the Tiger build.

5:12 PM Changeset in webkit [17294] by andersca

• 3 edits in trunk/WebCore

2006-10-25 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

<rdar://problem/4799088>
REGRESSION: Translation widget fails to convert data and reports a "Data unavailable" error.

• loader/mac/WebSubresourceLoader.h:
• loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]): Set the HTTP method before the HTTP body.

4:42 PM Changeset in webkit [17293] by thatcher

• 2 edits in trunk/WebKitLibraries

Reviewed by Kevin Decker.

• libWebKitSystemInterface.a: updated to be 64-bit universal

2:15 PM Changeset in webkit [17292] by brmorris

• 1 copy in S60/branches/s60-RnD-06wk43

New release branch.

1:51 PM Changeset in webkit [17291] by ggaren

• 2 edits in trunk/JavaScriptCore

Reviewed by Lou.

Removed duplicate symbol declaration.

• JavaScriptCore.xcodeproj/project.pbxproj:
• kjs/grammar.y:

1:49 PM Changeset in webkit [17290] by ggaren

• 20 edits
  2 moves in trunk

WebCore:

Reviewed by Adam.

Renamed WebFrameLoader to FrameLoader, to match class name.

• WebCore.xcodeproj/project.pbxproj:
• bridge/mac/FrameMac.mm:
• bridge/mac/WebCoreFrameBridge.mm:
• loader/mac/FrameLoader.mm: Added.
• loader/mac/IconLoaderMac.mm:
• loader/mac/WebDocumentLoader.mm:
• loader/mac/WebFrameLoader.h: Removed.
• loader/mac/WebFrameLoader.mm: Removed.
• loader/mac/WebLoader.mm:
• loader/mac/WebMainResourceLoader.mm:
• loader/mac/WebNetscapePlugInStreamLoader.mm:
• loader/mac/WebSubresourceLoader.mm:

WebKit:

Reviewed by Adam.

Renamed WebFrameLoader to FrameLoader, to match class name.

• Plugins/WebBaseNetscapePluginView.mm:
• Plugins/WebNetscapePluginStream.mm:
• Plugins/WebPluginController.mm:
• WebCoreSupport/WebFrameBridge.mm:
• WebView/WebDataSource.mm:
• WebView/WebFrame.mm:
• WebView/WebPDFView.mm:
• WebView/WebPolicyDelegate.mm:
• WebView/WebView.mm:

12:29 PM Changeset in webkit [17289] by darin

• 2 edits in trunk/WebCore

• fix full builds

• WebCore.xcodeproj/project.pbxproj: Mark bridge/mac/WebCoreResourceLoader.h as private.

5:12 AM Changeset in webkit [17288] by bdash

• 2 edits in trunk/WebCore

2006-10-25 David Smith <​catfish.man@gmail.com>

Reviewed by Mitz.

Fixed REGRESSION (r17280): Repro crash when clicking a link with target="_blank"
​http://bugs.webkit.org/show_bug.cgi?id=11411

• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canTargetLoadInFrame:]): Check that the target has a frame before using it.

2:57 AM Changeset in webkit [17287] by mjs

• 2 edits
  3 moves in trunk/WebCore

Rubber stamped by Mitz.

• moved some files that are essentially part of the ResourceLoader implementation to platform/network/mac

• WebCore.xcodeproj/project.pbxproj:
• bridge/mac/WebCoreResourceLoader.h: Moved to platform/network/mac.
• bridge/mac/WebCoreResourceLoaderImp.h: Moved to platform/network/mac.
• bridge/mac/WebCoreResourceLoaderImp.mm: Moved to platform/network/mac.

2:55 AM Changeset in webkit [17286] by mjs

• 2 edits in trunk/WebCore

Rubber stamped by Mark.

• remove no longer existing symbol that was breaking linking

• WebCore.exp:

1:52 AM Changeset in webkit [17285] by mjs

• 4 edits in trunk/WebCore

Reviewed by Mitz.

• fixed "REGRESSION: Activity window doesn't always list all files until refresh" ​http://bugs.webkit.org/show_bug.cgi?id=11212

I couldn't figure out how to write a test case.

• bindings/js/kjs_window.cpp: (KJS::Window::clear): Avoid crashing if already detached.
• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::clear): Change prototype to make this a proper overload for Frame::clear once again(!).

1:22 AM Changeset in webkit [17284] by bdash

• 2 edits in trunk/WebKitSite

2006-10-25 Mark Rowe <​bdash@webkit.org>

Reviewed by Maciej.

Fix some HTML bugs in the coding style guidelines.

• coding/coding-style.html:

12:52 AM Changeset in webkit [17283] by bdash

• 2 edits in trunk/WebKit

2006-10-25 Mark Rowe <​bdash@webkit.org>

Reviewed by Anders.

Build fix for the Buildbot.

• WebView/WebHTMLView.m: (-[NSArray _addToStyle:fontA:fontB:]): Explicit cast.

12:30 AM Changeset in webkit [17282] by mjs

• 2 edits in trunk/WebKit

Reviewed by Anders.

<rdar://problem/4785575> REGRESSION: form resubmission warning occurs twice, then Safari crashes in autorelease pool
<rdar://problem/4799383> REGRESSION: Crash occurs when dismissing the "Would you like to save this password" sheet

• WebView/WebPolicyDeciderMac.m: (-[WebPolicyDeciderMac dealloc]): release the listener, don't dealloc it

Oct 24, 2006:

10:38 PM Changeset in webkit [17281] by andersca

• 2 edits in trunk/WebKit

2006-10-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

• WebKitPrefix.h: Include FastMalloc.h from C++ code.

10:35 PM Changeset in webkit [17280] by darin

• 30 edits
  2 adds in trunk

WebCore:

Reviewed by Anders.

• converted WebFrameLoaderClient to C++
• renamed frame->frameLoader() function to frame->loader()
• renamed [bridge impl] to [bridge _frame]
• removed some bridge methods

• WebCore.exp: Added more exports.
• WebCore.xcodeproj/project.pbxproj: Made FrameTree.h private instead of project-internal so it can be used in WebKit.

• bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::createFrame): (WebCore::FrameMac::didFirstLayout):
• bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject rendererForView:]):
• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): (-[WebCoreFrameBridge canTargetLoadInFrame:]): (-[WebCoreFrameBridge setOpener:]): (-[WebCoreFrameBridge getData:andResponse:forURL:]): (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]): (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge isLoadTypeReload]): (-[WebCoreFrameBridge frameDetached]): (-[WebCoreFrameBridge tokenizerProcessedData]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebCoreFrameBridge reportClientRedirectCancelled:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge handledOnloadEvents]): (-[WebCoreFrameBridge mainResourceURLResponse]): (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]): (-[WebCoreFrameBridge _frame]): (-[WebCoreFrameBridge executionContextForView:]):
• bridge/mac/WebCorePageBridge.mm: (-[WebCorePageBridge setMainFrame:]):
• dom/Position.cpp: (WebCore::Position::upstream):
• loader/mac/IconLoaderMac.mm: (IconLoader::notifyIconChanged):
• loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
• loader/mac/WebFormState.mm: (WebCore::FormState::FormState):
• loader/mac/WebFrameLoader.h:
• loader/mac/WebFrameLoader.mm: (WebCore::FrameLoader::~FrameLoader): (WebCore::FrameLoader::prepareForLoadStart): (WebCore::FrameLoader::finalSetupForReplace): (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::stopLoadingSubframes): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::cancelPendingArchiveLoad): (WebCore::FrameLoader::defersCallbacksChanged): (WebCore::FrameLoader::setDefersCallbacks): (WebCore::FrameLoader::setDocumentLoader): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::identifierForInitialRequest): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::didReceiveAuthenticationChallenge): (WebCore::FrameLoader::didCancelAuthenticationChallenge): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::didFinishLoad): (WebCore::FrameLoader::didFailToLoad): (WebCore::FrameLoader::privateBrowsingEnabled): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::clientRedirectCancelledOrFinished): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::closeOldDataSources): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::download): (WebCore::FrameLoader::finishedLoading): (WebCore::FrameLoader::notifyIconChanged): (WebCore::FrameLoader::cancelledError): (WebCore::FrameLoader::fileDoesNotExistError): (WebCore::FrameLoader::willUseArchive): (WebCore::FrameLoader::isArchiveLoadPending): (WebCore::FrameLoader::handleUnimplementablePolicy): (WebCore::FrameLoader::cannotShowMIMEType): (WebCore::FrameLoader::interruptionForPolicyChangeError): (WebCore::FrameLoader::canShowMIMEType): (WebCore::FrameLoader::representationExistsForURLScheme): (WebCore::FrameLoader::generatedMIMETypeForURLScheme): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::committedLoad): (WebCore::FrameLoader::revertToProvisional): (WebCore::FrameLoader::setMainDocumentError): (WebCore::FrameLoader::mainReceivedCompleteError): (WebCore::FrameLoader::subframeIsLoading): (WebCore::FrameLoader::willChangeTitle): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::post): (WebCore::FrameLoader::detachChildren): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::actionInformation): (WebCore::FrameLoader::checkLoadComplete): (WebCore::FrameLoader::setClient): (WebCore::FrameLoader::client): (WebCore::FrameLoaderClient::~FrameLoaderClient):
• loader/mac/WebFrameLoaderClient.h:
• loader/mac/WebLoader.mm: (WebCore::WebResourceLoader::frameLoader):
• loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]):
• page/Frame.cpp: (WebCore::Frame::loader):
• page/Frame.h:
• platform/mac/SliderMac.mm: (Slider::focusPolicy):

WebKit:

Reviewed by Anders.

• converted WebFrameLoaderClient to C++
• renamed frame->frameLoader() function to frame->loader()
• renamed [bridge impl] to [bridge _frame]
• removed some bridge methods

• Plugins/WebNetscapePluginStream.mm:
• WebCoreSupport/WebEditorClient.mm:
• WebCoreSupport/WebFrameLoaderClient.h: Added. (WebFrameLoaderClient::webFrame):
• WebCoreSupport/WebFrameLoaderClient.mm: Added. (WebFrameLoaderClient::detachFrameLoader): (WebFrameLoaderClient::hasWebView): (WebFrameLoaderClient::hasFrameView): (WebFrameLoaderClient::hasBackForwardList): (WebFrameLoaderClient::resetBackForwardList): (WebFrameLoaderClient::provisionalItemIsTarget): (WebFrameLoaderClient::loadProvisionalItemFromPageCache): (WebFrameLoaderClient::invalidateCurrentItemPageCache): (WebFrameLoaderClient::privateBrowsingEnabled): (WebFrameLoaderClient::makeDocumentView): (WebFrameLoaderClient::makeRepresentation): (WebFrameLoaderClient::setDocumentViewFromPageCache): (WebFrameLoaderClient::forceLayout): (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::updateHistoryForCommit): (WebFrameLoaderClient::updateHistoryForBackForwardNavigation): (WebFrameLoaderClient::updateHistoryForReload): (WebFrameLoaderClient::updateHistoryForStandardLoad): (WebFrameLoaderClient::updateHistoryForInternalLoad): (WebFrameLoaderClient::updateHistoryAfterClientRedirect): (WebFrameLoaderClient::setCopiesOnScroll): (WebFrameLoaderClient::tokenForLoadErrorReset): (WebFrameLoaderClient::resetAfterLoadError): (WebFrameLoaderClient::doNotResetAfterLoadError): (WebFrameLoaderClient::detachedFromParent1): (WebFrameLoaderClient::detachedFromParent2): (WebFrameLoaderClient::detachedFromParent3): (WebFrameLoaderClient::detachedFromParent4): (WebFrameLoaderClient::loadedFromPageCache): (WebFrameLoaderClient::download): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchShow): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::dispatchDidLoadMainResource): (WebFrameLoaderClient::clearLoadingFromPageCache): (WebFrameLoaderClient::isLoadingFromPageCache): (WebFrameLoaderClient::revertToProvisionalState): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::clearUnarchivingState): (WebFrameLoaderClient::progressStarted): (WebFrameLoaderClient::progressCompleted): (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::completeProgress): (WebFrameLoaderClient::setMainFrameDocumentReady): (WebFrameLoaderClient::startDownload): (WebFrameLoaderClient::willChangeTitle): (WebFrameLoaderClient::didChangeTitle): (WebFrameLoaderClient::committedLoad): (WebFrameLoaderClient::finishedLoading): (WebFrameLoaderClient::finalSetupForReplace): (WebFrameLoaderClient::cancelledError): (WebFrameLoaderClient::cannotShowURLError): (WebFrameLoaderClient::interruptForPolicyChangeError): (WebFrameLoaderClient::cannotShowMIMETypeError): (WebFrameLoaderClient::fileDoesNotExistError): (WebFrameLoaderClient::shouldFallBack): (WebFrameLoaderClient::mainFrameURL): (WebFrameLoaderClient::setDefersCallbacks): (WebFrameLoaderClient::willUseArchive): (WebFrameLoaderClient::isArchiveLoadPending): (WebFrameLoaderClient::cancelPendingArchiveLoad): (WebFrameLoaderClient::clearArchivedResources): (WebFrameLoaderClient::canHandleRequest): (WebFrameLoaderClient::canShowMIMEType): (WebFrameLoaderClient::representationExistsForURLScheme): (WebFrameLoaderClient::generatedMIMETypeForURLScheme): (WebFrameLoaderClient::elementForEvent): (WebFrameLoaderClient::createPolicyDecider): (WebFrameLoaderClient::frameLoadCompleted): (WebFrameLoaderClient::restoreScrollPositionAndViewState): (WebFrameLoaderClient::provisionalLoadStarted): (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebFrameLoaderClient::addHistoryItemForFragmentScroll): (WebFrameLoaderClient::didFinishLoad): (WebFrameLoaderClient::prepareForDataSourceReplacement): (WebFrameLoaderClient::createDocumentLoader): (WebFrameLoaderClient::setTitle):
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebDataSource.mm: (-[WebDataSource webFrame]):
• WebView/WebFrame.mm: (frame): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _reloadForPluginChanges]): (-[WebFrame _initWithWebFrameView:webView:bridge:]): (-[WebFrame _frameLoader]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame parentFrame]): (-[WebFrame _provisionalLoadStarted]):
• WebView/WebFrameInternal.h:
• WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
• WebView/WebHTMLView.m: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): (-[NSArray validateUserInterfaceItem:]): (-[NSArray scrollWheel:]): (-[NSArray acceptsFirstMouse:]): (-[NSArray shouldDelayWindowOrderingForEvent:]): (-[NSArray _selectionStartFontAttributesAsRTF]): (-[NSArray changeBaseWritingDirection:]): (-[NSArray indent:]): (-[NSArray outdent:]): (-[WebHTMLView copy:]): (-[WebHTMLView cut:]): (-[WebHTMLView paste:]):
• WebView/WebView.mm: (-[WebView _dashboardRegions]): (-[WebView setProhibitsMainFrameScrolling:]): (-[WebView _setInViewSourceMode:]): (-[WebView _inViewSourceMode]): (-[WebView setEditable:]):

10:30 PM Changeset in webkit [17279] by darin

• 2 edits in trunk/WebCore

Rubber stamped by Anders.

• get rid of the assertion firing while running the layout tests

This does not fix the real problem, which is that we need to map offsets within
possibly-text-transformed text in the render tree to DOM tree offsets and vice
versa -- but it gets the tests running again.

• dom/Position.cpp: (WebCore::Position::upstream): Commented out the assertion.

9:25 PM Changeset in webkit [17278] by mjs

• 15 edits
  1 add in trunk

LayoutTests:

Reviewed by Oliver.

• re-enable testing of HEAD methods, now that bugs relating to these are fixed

• http/tests/xmlhttprequest/methods-async-expected.txt:
• http/tests/xmlhttprequest/methods-async.html:
• http/tests/xmlhttprequest/methods-expected.txt:
• http/tests/xmlhttprequest/methods.html:

WebCore:

Reviewed by Oliver.

• more ResourceLoader cleanup
  • moved HTTPHeaderMap out of ResourceRequest class, so ResourceResponse will be able to use it too
  • took out attempts to suppress setting of "HEAD" and "GET" methods, since underlying bugs are now fixed

• loader/LoaderFunctions.h:
• loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
• loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]):
• platform/network/HTTPHeaderMap.h: Added.
• platform/network/ResourceLoader.cpp: (WebCore::ResourceLoader::requestHeaders):
• platform/network/ResourceLoader.h:
• platform/network/ResourceRequest.h:
• platform/network/cf/ResourceLoaderCFNet.cpp: (WebCore::addHeadersFromHashMap):
• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
• xml/xmlhttprequest.h:

9:23 PM Changeset in webkit [17277] by slewis

• 2 edits in trunk/WebKitTools

2006-10-24 Stephanie Lewis <Stephanie Lewis>

Reviewed by Maciej.

• Changed run-javascriptcore tests to build testkjs before running.

• Scripts/run-javascriptcore-tests:

9:22 PM Changeset in webkit [22426] by mjs

• 5 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

• updated for ResourceRequest changes.

• plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::setRequestHeaders):
• plugins/win/PluginStreamWin.h:
• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::loadURL): (WebCore::parseRFC822HeaderFields): (WebCore::PluginViewWin::handlePost):
• plugins/win/PluginViewWin.h:

6:37 PM Changeset in webkit [17276] by justing

• 13 edits
  4 adds in trunk

LayoutTests:

Reviewed by darin

<​http://bugs.webkit.org/show_bug.cgi?id=10993>
GMail Editor: Caret doesn't always position itself after list marker

• editing/execCommand/create-list-1-expected.checksum: Added.
• editing/execCommand/create-list-1-expected.png: Added.
• editing/execCommand/create-list-1-expected.txt: Added.
• editing/execCommand/create-list-1.html: Added.

Fixed:

• editing/execCommand/create-list-with-hr-expected.checksum:
• editing/execCommand/create-list-with-hr-expected.png:
• editing/execCommand/create-list-with-hr-expected.txt:
• editing/execCommand/create-list-with-hr.html:
• editing/execCommand/remove-list-1-expected.checksum:
• editing/execCommand/remove-list-1-expected.png:
• editing/execCommand/remove-list-1-expected.txt:
• fast/text/attributed-substring-from-range-001-expected.txt:

WebCore:

Reviewed by darin

<​http://bugs.webkit.org/show_bug.cgi?id=10993>
GMail Editor: Caret doesn't always position itself after list marker

List creation uses moveParagraphs to push content into list items.
moveParagraphs uses a TextIterator to restore selections after moves.
Some characters emitted by the TextIterator had bad ranges associated
with them. rangeFromLocationAndLength would skip past the range it
should have used when asked for ranges of length 0.

• editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): No longer need to initialize a removed member variable. (WebCore::TextIterator::advance): An extra newline is emitted when leaving some blocks. Use the same range for this newline as for the first newline. We should remove this code and just emit two '\n's. (WebCore::TextIterator::handleTextNode): Setup m_range. (WebCore::TextIterator::handleTextBox): Ditto. (WebCore::TextIterator::handleReplacedElement): Ditto. (WebCore::TextIterator::handleNonTextNode): Ditto. (WebCore::TextIterator::exitNode): Use an m_range from the last VisiblePosition in the block we're leaving to that VP after that one. (WebCore::TextIterator::emitCharacter): This function now takes in the start and the end of the range associated with the emited character, and sets up m_range. (WebCore::TextIterator::range): Return m_range. If it is null (we are atEnd), return the end of the range used to create the iterator, as a convenience to callers that use call range() on an iterator that is atEnd. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Same as the changes made to TextIterator's constructor. (WebCore::SimplifiedBackwardsTextIterator::advance): Use a null m_range instead of a null m_positionNode to signal that we're finished. (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Ditto. (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement): Similar to changes made to TextIterator. (WebCore::SimplifiedBackwardsTextIterator::emitCharacter): Ditto. (WebCore::SimplifiedBackwardsTextIterator::emitNewline): Simplified. (WebCore::SimplifiedBackwardsTextIterator::range): Similar to the changes made to TextIterator::range. (WebCore::CharacterIterator::range): This function assumed that an iterator's range() was safe to modify. (WebCore::TextIterator::rangeFromLocationAndLength): If the range we're looking for starts in the current chunk, this function assumed that if the chunk started in a text node, it would end in the same text node. This is no longer the case. If the range we're looking for starts in the middle of the current chunk, I assume that the chunk is inside a text node, because those are the only chunks with length greater than one at the moment. If the range we're looking for is a zero length range that starts/ends at the end of the current chunk, we used to return the start of the next chunk, but that's wrong and is what caused this bug.
• editing/TextIterator.h: (WebCore::TextIterator::atEnd): The iterator is atEnd when m_range is null. (WebCore::SimplifiedBackwardsTextIterator::atEnd):
• editing/visible_units.cpp: (WebCore::previousBoundary): Cleaned up by using a convenience function. (WebCore::nextBoundary): Ditto.

6:05 PM Changeset in webkit [22425] by sfalken

• 4 edits in branches/WindowsMerge

2006-10-24 Steve Falkenburg <​sfalken@apple.com>

Build fix for official builds

5:31 PM Changeset in webkit [17275] by sfalken

• 2 edits in trunk/JavaScriptCore

2006-10-24 Steve Falkenburg <​sfalken@apple.com>

Build config change

• JavaScriptCore.vcproj/testkjs/testkjs.vcproj:

5:11 PM Changeset in webkit [17274] by sullivan

• 4 edits in trunk/WebKit

Reviewed by Kevin Decker

• fixed <rdar://problem/4801331> "Spelling..." menu item should be "Show/Hide Spelling" post-Tiger, to match AppKit

• WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): post-Tiger, update the menu item text to "Show Spelling"/"Hide Spelling" based on whether the spelling panel is already showing. Also, removed else's after returns, and removed braces around one-line if clauses. (-[NSArray showGuessPanel:]): post-Tiger, make this item hide the spelling panel if it's already showing

• English.lproj/Localizable.strings: updated for this change

4:49 PM Changeset in webkit [17273] by andersca

• 2 edits in trunk/WebCore

2006-10-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

• platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): Don't retain the header dictionary.

4:11 PM Changeset in webkit [17272] by ggaren

• 3 edits in trunk/WebCore

Reviewed by Anders.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=11404
REGRESSION: Reproducible assertion failure in Shared<WebCore::StringImpl>::ref()
running svg/custom/svg/custom/gradient-attr-update.svg

SVGRenderStyle wasn't ref-ing the shared objects it held onto. Oops.

• ksvg2/css/SVGRenderStyle.h:
• ksvg2/css/SVGRenderStyleDefs.h:

3:59 PM Changeset in webkit [22424] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

2006-10-24 Steve Falkenburg <​sfalken@apple.com>

Bump version to 521.28.6

• WebKit.vcproj/VERSION:

3:57 PM Changeset in webkit [22423] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2006-10-24 Steve Falkenburg <​sfalken@apple.com>

Fix build so it can be submitted.

• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcproj/merge-opensource.sh:
• rendering/RenderThemeWin.cpp:

3:56 PM Changeset in webkit [17271] by andersca

• 2 edits in trunk/WebCore

2006-10-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Mitz.

• platform/network/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): Set the http method to "GET" in the constructor that takes a String.

3:48 PM Changeset in webkit [17270] by weinig

• 3 edits
  20 moves in trunk/WebCore

Reviewed by Tim H.

Move kcanvas/Render* and kcanvas/SVG* to rendering/Render*
and rendering/SVG* respectively. Fix Xcode project and
CMakeLists.txt to account for the moves.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• kcanvas/RenderForeignObject.cpp: Removed.
• kcanvas/RenderForeignObject.h: Removed.
• kcanvas/RenderPath.cpp: Removed.
• kcanvas/RenderPath.h: Removed.
• kcanvas/RenderSVGContainer.cpp: Removed.
• kcanvas/RenderSVGContainer.h: Removed.
• kcanvas/RenderSVGImage.cpp: Removed.
• kcanvas/RenderSVGImage.h: Removed.
• kcanvas/RenderSVGInline.cpp: Removed.
• kcanvas/RenderSVGInline.h: Removed.
• kcanvas/RenderSVGInlineText.cpp: Removed.
• kcanvas/RenderSVGInlineText.h: Removed.
• kcanvas/RenderSVGTSpan.cpp: Removed.
• kcanvas/RenderSVGTSpan.h: Removed.
• kcanvas/RenderSVGText.cpp: Removed.
• kcanvas/RenderSVGText.h: Removed.
• kcanvas/SVGInlineFlowBox.cpp: Removed.
• kcanvas/SVGInlineFlowBox.h: Removed.
• kcanvas/SVGRootInlineBox.cpp: Removed.
• kcanvas/SVGRootInlineBox.h: Removed.

3:37 PM Changeset in webkit [17269] by thatcher

• 2 edits in trunk/WebKit/Misc

Build fix.

3:34 PM Changeset in webkit [17268] by thatcher

• 3 edits in trunk/WebKit

Reviewed by Anders.

<rdar://problem/4588878> 'WebHTMLView' may not respond to '-_webView'

• Misc/WebNSViewExtras.h:
• Misc/WebNSViewExtras.m: (-[NSView _webView]):

3:28 PM Changeset in webkit [22422] by ggaren

• 3 edits in branches/WindowsMerge/WebCore

Rolling back in, now fixed:

Nixed a few more redundant loading functions in Frame.

• bridge/win/FrameWin.h:
• platform/win/TemporaryLinkStubs.cpp: (FrameWin::shouldInterruptJavaScript): (FrameWin::lastEventIsMouseUp):

3:24 PM Changeset in webkit [17267] by ggaren

• 11 edits in trunk/WebCore

Rolling back in, now fixed:

Nixed a few more redundant loading functions in Frame. Did my best to update
the non-Mac builds.

• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::urlSelected): Kept always 'true' argument for userGesture always 'true', because changing it broke the world, and testing seems to indicate that the one caller that might have passed 'false' didn't need to.
• page/Frame.cpp: (WebCore::Frame::requestFrame): (WebCore::Frame::frameLoader): (WebCore::Frame::redirectionTimerFired):
• page/Frame.h:
• platform/gdk/FrameGdk.cpp:
• platform/gdk/FrameGdk.h:
• platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::issueCopyCommand):
• platform/qt/FrameQt.cpp:
• platform/qt/FrameQt.h:
• platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::shouldInterruptJavaScript): (WebCore::FrameWin::issueCopyCommand):

3:21 PM Changeset in webkit [22421] by andersca

• 2 edits in branches/WindowsMerge/WebKitWin

2006-10-24 Anders Carlsson <​acarlsson@apple.com>

• WebFrame.cpp: (WebFrame::loadDataSource): Forgot to save before committing. Call begin before trying to access the document.

3:15 PM Changeset in webkit [22420] by andersca

• 3 edits in branches/WindowsMerge/WebKitWin

2006-10-24 Anders Carlsson <​acarlsson@apple.com>

Fix build. (Update for changes to ResourceLoader)

• WebFrame.cpp: (WebFrame::loadDataSource):
• WebURLResponse.cpp: (WebURLResponse::createInstance):

3:06 PM Changeset in webkit [17266] by andersca

• 2 edits in trunk/WebCore

2006-10-24 Anders Carlsson <​acarlsson@apple.com>

Fix the build (Update for changes to ResourceLoader)

• platform/network/cf/ResourceLoaderCFNet.cpp: (WebCore::addHeadersFromHashMap): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::cancel):

2:58 PM Changeset in webkit [22419] by mjs

• 5 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

• update for ResourceLoader API changes

• platform/win/TemporaryLinkStubs.cpp: (WebCore::ServeSynchronousRequest):
• plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::receivedAllData):
• plugins/win/PluginStreamWin.h:
• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):

2:57 PM Changeset in webkit [17265] by weinig

• 7 edits in trunk/WebCore

Reviewed by Mitz.

Change #includes using <kcanvas/*.h> to use "*.h" instead
to prepare for moving the kcanvas files.

• kcanvas/RenderSVGContainer.h:
• ksvg2/svg/SVGAElement.cpp:
• ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
• ksvg2/svg/SVGFETileElement.cpp:
• ksvg2/svg/SVGStyledLocatableElement.cpp:
• ksvg2/svg/SVGStyledTransformableElement.cpp:

2:53 PM Changeset in webkit [17264] by mjs

• 18 edits in trunk/WebCore

Reviewed by Darin.

• More movement towards the final network API.

Changed ResourceLoader::create to take a ResurceRequest and start
the load. Removed methods relating to setting request
headers. Removed methods relating to metaData. Added some more
convenience methods to ResourceRequest.

• dom/XMLTokenizer.cpp: (WebCore::openFunc):
• loader/LoaderFunctions.h:
• loader/icon/IconLoader.cpp: (IconLoader::startLoading): (IconLoader::didFinishLoading):
• loader/icon/IconLoader.h:
• loader/loader.cpp: (WebCore::Loader::servePendingRequests):
• loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
• platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::openURL): (WebCore::FrameGdkClientDefault::submitForm):
• platform/network/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::create): (WebCore::ResourceLoader::responseHTTPHeadersAsString): (WebCore::ResourceLoader::url): (WebCore::ResourceLoader::postData): (WebCore::ResourceLoader::method): (WebCore::ResourceLoader::client):
• platform/network/ResourceLoader.h:
• platform/network/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
• platform/network/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::httpAccept): (WebCore::ResourceRequest::setHTTPAccept): (WebCore::ResourceRequest::addHTTPHeaderFields):
• platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::receivedResponse):
• platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::submitForm):
• platform/win/TemporaryLinkStubs.cpp: (WebCore::ResourceLoader::retrieveResponseEncoding):
• xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didReceiveData):
• xml/xmlhttprequest.h:

2:26 PM Changeset in webkit [17263] by andersca

• 3 edits in trunk/WebCore

2006-10-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

• loader/FormData.cpp: (WebCore::FormData::FormData):
• loader/FormData.h: (WebCore::FormData::FormData): Add new constructor that takes a void* and a size.

2:25 PM Changeset in webkit [17262] by thatcher

• 1 edit in trunk/WebKit/Plugins/WebBaseNetscapePluginView.mm

Build fix for un-initialized var.

2:24 PM Changeset in webkit [17261] by beidson

• 2 edits in trunk/WebKit

Reviewed by Anders

​http://bugs.webkit.org/show_bug.cgi?id=11406 - Crash in [WebFrame dataSource]
In the transition to ObjC++ we lost alot of our free nil checking that we must now do manually
to prevent null dereferencing.

• WebView/WebFrame.mm: (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]):

2:17 PM Changeset in webkit [22418] by ggaren

• 3 edits in branches/WindowsMerge/WebCore

Rolling out my last change because it broke the world.

• bridge/win/FrameWin.h:
• platform/win/TemporaryLinkStubs.cpp: (FrameWin::openURL):

2:14 PM Changeset in webkit [17260] by ggaren

• 11 edits in trunk/WebCore

Rolling out my last change because it broke the world.

• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::openURL): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected):
• page/Frame.cpp: (WebCore::Frame::openURL): (WebCore::Frame::frameLoader): (WebCore::Frame::requestFrame): (WebCore::Frame::redirectionTimerFired):
• page/Frame.h:
• platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::openURL):
• platform/gdk/FrameGdk.h:
• platform/gdk/TemporaryLinkStubs.cpp:
• platform/qt/FrameQt.cpp: (WebCore::FrameQt::openURL): (WebCore::FrameQt::openURLRequest):
• platform/qt/FrameQt.h:
• platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::openURL): (WebCore::FrameWin::openURLRequest):

1:50 PM Changeset in webkit [17259] by thatcher

• 2 edits in trunk/WebCore/loader/mac

Build fixes for 64-bit.

1:46 PM Changeset in webkit [17258] by kmccullo

• 2 edits in trunk/JavaScriptCore

Reviewed by Brady.

• Fixes a date formatting issue on win. Specifically strftime cannot handle some ranges of time so we shift time call strftime and then manipulate the returned string, if needed.

• kjs/date_object.cpp: (KJS::): (KJS::formatLocaleDate): (KJS::DateProtoFunc::callAsFunction):

1:03 PM Changeset in webkit [17257] by bdash

• 23 edits
  4 deletes in trunk/WebCore

2006-10-24 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Adam.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11396

Kill KRenderingFillPainter/KRenderingStrokePainter. Those are not needed
anymore, since kcanvas/ksvg2 are tightly integrated. No LayoutTests fixed
or broken.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• kcanvas/KCanvasTreeDebug.cpp: (WebCore::operator<<): (WebCore::writeStyle):
• kcanvas/RenderPath.cpp: (WebCore::RenderPath::fillContains):
• kcanvas/device/KRenderingFillPainter.cpp:
• kcanvas/device/KRenderingFillPainter.h:
• kcanvas/device/KRenderingStrokePainter.cpp:
• kcanvas/device/KRenderingStrokePainter.h:
• kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp: (WebCore::KRenderingPaintServerLinearGradientQt::setup): (WebCore::KRenderingPaintServerRadialGradientQt::setup):
• kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
• kcanvas/device/qt/KRenderingPaintServerQt.cpp: (WebCore::KRenderingPaintServerQt::setPenProperties):
• kcanvas/device/qt/KRenderingPaintServerQt.h:
• kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp: (WebCore::KRenderingPaintServerSolidQt::setup):
• kcanvas/device/qt/RenderPathQt.cpp: (WebCore::getPathStroke): (WebCore::RenderPath::strokeBBox):
• kcanvas/device/quartz/KCanvasItemQuartz.mm: (WebCore::RenderPath::strokeBBox):
• kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
• kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
• kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::KRenderingPaintServerQuartzHelper::fillPath): (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
• kcanvas/device/quartz/QuartzSupport.h: (WebCore::CGLineCapFromKC): (WebCore::CGLineJoinFromKC):
• kcanvas/device/quartz/QuartzSupport.mm: (WebCore::applyStrokeStyleToContext): (WebCore::strokeBoundingBox):
• ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
• ksvg2/css/SVGRenderStyle.h: (WebCore::SVGRenderStyle::InheritedFlags::):
• ksvg2/css/SVGRenderStyleDefs.h:
• ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
• ksvg2/misc/KCanvasRenderingStyle.h:
• ksvg2/svg/SVGFEImageElement.cpp:

12:54 PM Changeset in webkit [22417] by andersca

• 6 edits in branches/WindowsMerge/WebCore

2006-10-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

<rdar://problem/4760429> Crash in PluginStreamWin::~PluginStreamWin when
navigating away from mcdonalds.com

• plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::fetchInfo): Use fastFree instead of free when memory is allocated by fastMalloc. If the plugin name or description is null, don't try to fetch info about the plugin.

• plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::setRequestHeaders): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::stop):
• plugins/win/PluginStreamWin.h: Change type of header map to ResourceRequest::HTTPHeaderMap. When a plugin is stopped, set its state to StreamStopped.

• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::loadURL): (WebCore::parseRFC822HeaderFields): (WebCore::PluginViewWin::handlePost):
• plugins/win/PluginViewWin.h: Update for type changes to the header map.

12:20 PM Changeset in webkit [22416] by ggaren

• 3 edits in branches/WindowsMerge/WebCore

Reviewed by Anders.

Nixed a few more redundant loading functions in Frame.

• bridge/win/FrameWin.h:
• platform/win/TemporaryLinkStubs.cpp: (FrameWin::shouldInterruptJavaScript): (FrameWin::lastEventIsMouseUp):

12:17 PM Changeset in webkit [17256] by ggaren

• 11 edits in trunk/WebCore

Reviewed by Anders.

Nixed a few more redundant loading functions in Frame. Did my best to update
the non-Mac builds.

• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::urlSelected): Changed always 'true' argument for userGesture to actually check for a user gesture. New callers rely on this behavior, and it seems like the previous behavior must have been a bug.
• page/Frame.cpp: (WebCore::Frame::requestFrame): (WebCore::Frame::frameLoader): (WebCore::Frame::redirectionTimerFired):
• page/Frame.h:
• platform/gdk/FrameGdk.cpp:
• platform/gdk/FrameGdk.h:
• platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::issueCopyCommand):
• platform/qt/FrameQt.cpp:
• platform/qt/FrameQt.h:
• platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::shouldInterruptJavaScript): (WebCore::FrameWin::issueCopyCommand):

12:14 PM Changeset in webkit [17255] by sullivan

• 14 edits
  4 adds in trunk/WebKit

Reviewed by Darin

Initial plumbing for grammar checking. No actual grammar are checked at this time.

• English.lproj/WebViewEditingContextMenu.nib/classes.nib:
• English.lproj/WebViewEditingContextMenu.nib/info.nib:
• English.lproj/WebViewEditingContextMenu.nib/objects.nib: Added grammar-checking item, reworded to match changes in framework. This will be used post-Tiger.

• English.lproj/WebViewEditingContextMenuOld.nib/classes.nib: Added.
• English.lproj/WebViewEditingContextMenuOld.nib/info.nib: Added.
• English.lproj/WebViewEditingContextMenuOld.nib/objects.nib: Added. Copy of WebViewEditingContextMenu.nib, unchanged. This will be used on Tiger.

• DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): Choose the right context menu based on BUILDING_ON_TIGER.

• WebView/WebPreferenceKeysPrivate.h: declare grammar-related NSUserDefault value

• WebView/WebViewPrivate.h: declare grammar-related methods

• WebView/WebView.mm: declare static BOOL grammarCheckingEnabled (-[WebViewPrivate init]): initialize grammarCheckingEnabled to NSUserDefaults value (-[WebView validateUserInterfaceItem:]): validate toggleGrammarChecking: menu item (-[WebView isGrammarCheckingEnabled]): return value of grammarCheckingEnabled (-[WebView setGrammarCheckingEnabled:]): set value of grammarCheckingEnabled, call frame to remove existing bad grammar markers (-[WebView toggleGrammarChecking:]): flip the value

• WebView/WebFrameInternal.h:
• WebView/WebFrame.mm: (-[WebFrame _unmarkAllBadGrammar]): new placeholder method, does nothing yet

• WebView/WebHTMLViewInternal.h: declare grammar-related methods

• WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): validate toggleGrammarChecking: menu item (-[WebHTMLView isGrammarCheckingEnabled]): new method, calls through to WebView (-[WebHTMLView setGrammarCheckingEnabled:]): ditto (-[WebHTMLView toggleGrammarChecking:]): ditto

• English.lproj/StringsNotToBeLocalized.txt: Updated for these changes

• WebKit.xcodeproj/project.pbxproj: updated for new files

8:14 AM Changeset in webkit [17254] by brmorris

• 12 edits in S60/trunk

Reviewed by Sachin.
DESC: Automatically open download file progressively settings. If yes,

then download file will be open progressively. If no, then the user
need to open the file manually.

​http://bugs.webkit.org/show_bug.cgi?id=11392

6:10 AM Changeset in webkit [17253] by weinig

• 10 edits
  2 deletes in trunk

WebCore:

Reviewed by Maciej.

Fix Qt/Linux build.

• Remove BrowserExtensionQt, move it's methods to Page/FrameQt.
• Fix CMakeLists.txt to include platform/network.

• CMakeLists.txt:
• platform/qt/BrowserExtensionQt.cpp: Removed.
• platform/qt/BrowserExtensionQt.h: Removed.
• platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::createNewWindow): (WebCore::FrameQt::goBackOrForward): (WebCore::FrameQt::historyURL): (WebCore::FrameQt::getHistoryLength):
• platform/qt/FrameQt.h:
• platform/qt/PageQt.cpp: (WebCore::Page::canRunModal): (WebCore::Page::canRunModalNow): (WebCore::Page::runModal):

WebKitQt:

Reviewed by Maciej.

Fix Qt/Linux build.

• Remove BrowserExtensionQt, move it's methods to Page/FrameQt.
• Fix CMakeLists.txt to include platform/network.

• QtLauncher/CMakeLists.txt:
• WebKitPart/CMakeLists.txt:

WebKitTools:

Reviewed by Maciej.

Fix Qt/Linux build.

• Remove BrowserExtensionQt, move it's methods to Page/FrameQt.
• Fix CMakeLists.txt to include platform/network.

• DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt:

6:06 AM Changeset in webkit [17252] by weinig

• 2 edits in trunk/WebCore

Reviewed by Tim H.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11314
Fix build when XSLT_SUPPORT is not defined

Fix unconditional use of XSLT support.

• dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::end):

4:26 AM Changeset in webkit [17251] by bdash

• 5 edits in trunk

2006-10-24 Simon Hausmann <​hausmann@kde.org>

Reviewed by Darin.

• CMakeLists.txt: Added project name to kde4_automoc macro, as required by the latest KDE4 cmake module.

2006-10-24 Simon Hausmann <​hausmann@kde.org>

Reviewed by Darin.

• QtLauncher/CMakeLists.txt, WebKitPart/CMakeLists.txt: Added project name to kde4_automoc macro, as required by the latest KDE4 cmake module.

4:19 AM Changeset in webkit [17250] by bdash

• 2 edits in trunk/WebKitTools

2006-10-24 David Smith <​catfish.man@gmail.com>

Reviewed by Tim H.

Bug 11382: [Drosera] Dragging breakpoints onto each other can mess up inline editor
​http://bugs.webkit.org/show_bug.cgi?id=11382

• Drosera/debugger.js: Breakpoint dragging now ensures that editors aren't orphaned.

4:15 AM Changeset in webkit [17249] by bdash

• 2 edits in trunk/WebCore

2006-10-24 Mitz Pettel <​mitz@webkit.org>

Reviewed by Tim H.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11394 HTMLViewSourceDocuments are leaking

• html/HTMLViewSourceDocument.h: Changed RefPtr to plain pointer to avoid ref cycle.

1:49 AM Changeset in webkit [17248] by ggaren

• 8 edits in trunk/WebCore

Reviewed by Darin.

Removed one of Frame's redundant urlSelected methods.

• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::urlSelected): since it's unused.
• html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Changed DeprecatedString to String because the former is deprecated and its performance is irrelevant here. Added call to completeURL because Frame no longer does it for us. Having the call here also improves clarity about the element's behavior.
• ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): ditto. Also removed bizarre irrelevent NULL checks on ownerDocument() because I couldn't help myself.
• page/Frame.cpp: (WebCore::Frame::changeLocation): (WebCore::Frame::urlSelected):
• page/Frame.h:
• platform/network/ResourceRequest.h: Removed explicit keyword on constructor because we want to be able to use these constructors instead of helper functions mimicking their behavior sprinkled across different classes. (WebCore::ResourceRequest::ResourceRequest):

12:59 AM Changeset in webkit [17247] by beidson

• 11 edits in trunk/WebCore

Reviewed by Maciej

Moved FrameLoader from WebCoreFrameBridge to Frame. Frame.h/cpp have generic accessors to the FrameLoader itself
and creation/deletion is currently managed in FrameMac.mm

Besides explicitly commented-upon methods, most of the touched code simply changes to get the FrameLoader from the
frame instead of the bridge.

The method [WebCoreFrameBridge frameLoader] remains but only for WebKit's use - No new WebCore code should make
use of it as its days are numbered!

• bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Create the FrameLoader (WebCore::FrameMac::~FrameMac): Nuke it (WebCore::FrameMac::loadRequest):

• bridge/mac/WebCoreFrameBridge.h: No longer holds an m_frameLoader
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]): No longer creates the FrameLoader (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]): Ditto (-[WebCoreFrameBridge clearFrame]): No longer tears down the FrameLoader (-[WebCoreFrameBridge setFrameLoaderClient:]): (-[WebCoreFrameBridge frameLoader]): (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge didFirstLayout]): (-[WebCoreFrameBridge notifyIconChanged:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge isLoadTypeReload]): (-[WebCoreFrameBridge frameDetached]): (-[WebCoreFrameBridge tokenizerProcessedData]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebCoreFrameBridge reportClientRedirectCancelled:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge handledOnloadEvents]): (-[WebCoreFrameBridge mainResourceURLResponse]): (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):

• loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::frameLoader):

• loader/mac/WebFrameLoader.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::stopLoadingSubframes): (WebCore::FrameLoader::defersCallbacksChanged): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::closeOldDataSources): (WebCore::FrameLoader::subframeIsLoading): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (WebCore::FrameLoader::post): (WebCore::FrameLoader::detachChildren): (WebCore::FrameLoader::checkLoadComplete):

• loader/mac/WebLoader.mm: (WebCore::WebResourceLoader::frameLoader):

• loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]):

• page/Frame.cpp: (WebCore::Frame::frameLoader):
• page/Frame.h:
• page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):

12:33 AM Changeset in webkit [17246] by darin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• fixed two crashes in layout tests I just introduced

• loader/mac/WebFrameLoader.mm: (WebCore::FrameLoader::load): Add null check. (WebCore::FrameLoader::setState): Ditto.

Oct 23, 2006:

11:19 PM Changeset in webkit [17245] by darin

• 19 edits in trunk

WebCore:

Reviewed by Geoff.

• converted WebDocumentLoader to C++

• WebCore.exp:
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge mainResourceURLResponse]):
• loader/mac/WebDocumentLoader.h:
• loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::setMainResourceData): (WebCore::DocumentLoader::mainResourceData): (WebCore::DocumentLoader::originalRequest): (WebCore::DocumentLoader::originalRequestCopy): (WebCore::DocumentLoader::request): (WebCore::DocumentLoader::initialRequest): (WebCore::DocumentLoader::actualRequest): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::setResponse): (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::bridge): (WebCore::DocumentLoader::setMainDocumentError): (WebCore::DocumentLoader::mainDocumentError): (WebCore::DocumentLoader::clearErrors): (WebCore::DocumentLoader::mainReceivedError): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setupForReplace): (WebCore::DocumentLoader::commitIfReady): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setCommitted): (WebCore::DocumentLoader::isCommitted): (WebCore::DocumentLoader::setLoading): (WebCore::DocumentLoader::isLoading): (WebCore::DocumentLoader::commitLoad): (WebCore::DocumentLoader::doesProgressiveLoad): (WebCore::DocumentLoader::receivedData): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::updateLoading): (WebCore::DocumentLoader::response): (WebCore::DocumentLoader::setFrame): (WebCore::DocumentLoader::attachToFrame): (WebCore::DocumentLoader::detachFromFrame): (WebCore::DocumentLoader::prepareForLoadStart): (WebCore::DocumentLoader::loadingStartedTime): (WebCore::DocumentLoader::setIsClientRedirect): (WebCore::DocumentLoader::isClientRedirect): (WebCore::DocumentLoader::setPrimaryLoadComplete): (WebCore::DocumentLoader::isLoadingInAPISense): (WebCore::DocumentLoader::addResponse): (WebCore::DocumentLoader::stopRecordingResponses): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::setLastCheckedRequest): (WebCore::DocumentLoader::lastCheckedRequest): (WebCore::DocumentLoader::triggeringAction): (WebCore::DocumentLoader::setTriggeringAction): (WebCore::DocumentLoader::responses): (WebCore::DocumentLoader::setOverrideEncoding): (WebCore::DocumentLoader::overrideEncoding): (WebCore::DocumentLoader::setTitle): (WebCore::DocumentLoader::URLForHistory):
• loader/mac/WebFrameLoader.h:
• loader/mac/WebFrameLoader.mm: (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::finalSetupForReplace): (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::activeDocumentLoader): (WebCore::FrameLoader::addPlugInStreamLoader): (WebCore::FrameLoader::removePlugInStreamLoader): (WebCore::FrameLoader::addSubresourceLoader): (WebCore::FrameLoader::removeSubresourceLoader): (WebCore::FrameLoader::setDocumentLoader): (WebCore::FrameLoader::documentLoader): (WebCore::FrameLoader::setPolicyDocumentLoader): (WebCore::FrameLoader::provisionalDocumentLoader): (WebCore::FrameLoader::setProvisionalDocumentLoader): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::originalRequest): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::initialRequest): (WebCore::FrameLoader::receivedData): (WebCore::FrameLoader::setRequest): (WebCore::FrameLoader::isStopping): (WebCore::FrameLoader::setResponse): (WebCore::FrameLoader::mainReceivedError): (WebCore::FrameLoader::finishedLoading): (WebCore::FrameLoader::notifyIconChanged): (WebCore::FrameLoader::URL): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::committedLoad): (WebCore::FrameLoader::revertToProvisional): (WebCore::FrameLoader::setMainDocumentError): (WebCore::FrameLoader::mainReceivedCompleteError): (WebCore::FrameLoader::subframeIsLoading): (WebCore::FrameLoader::willChangeTitle): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::detachFromParent):
• loader/mac/WebFrameLoaderClient.h:

WebKit:

Reviewed by Geoff.

• converted WebDocumentLoader to C++

• Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]):
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebDataSource.mm: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _mainDocumentError]): (-[WebDataSource _URL]): (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource _bridge]): (-[WebDataSource _URLForHistory]): (-[WebDataSource _documentLoader]): (-[WebDataSource _initWithDocumentLoader:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource data]): (-[WebDataSource webFrame]): (-[WebDataSource initialRequest]): (-[WebDataSource request]): (-[WebDataSource response]): (-[WebDataSource textEncodingName]): (-[WebDataSource isLoading]): (-[WebDataSource unreachableURL]): (-[WebDataSource webArchive]):
• WebView/WebDataSourceInternal.h:
• WebView/WebDocumentLoaderMac.h:
• WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::WebDocumentLoaderMac): (WebDocumentLoaderMac::setDataSource): (WebDocumentLoaderMac::dataSource): (WebDocumentLoaderMac::attachToFrame): (WebDocumentLoaderMac::detachFromFrame):
• WebView/WebFrame.mm: (-[WebFrame _createItem:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _addChild:]): (dataSource): (-[WebFrame _dataSourceForDocumentLoader:]): (-[WebFrame _addDocumentLoader:toUnarchiveState:]): (-[WebFrame loadArchive:]): (-[WebFrame _updateHistoryForReload]): (-[WebFrame _updateHistoryForStandardLoad]): (-[WebFrame _updateHistoryForInternalLoad]): (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]): (-[WebFrame _dispatchResource:willSendRequest:redirectResponse:fromDocumentLoader:]): (-[WebFrame _dispatchDidReceiveAuthenticationChallenge:forResource:fromDocumentLoader:]): (-[WebFrame _dispatchDidCancelAuthenticationChallenge:forResource:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didReceiveResponse:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didReceiveContentLength:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didFinishLoadingFromDocumentLoader:]): (-[WebFrame _dispatchResource:didFailLoadingWithError:fromDocumentLoader:]): (-[WebFrame _dispatchDidLoadMainResourceForDocumentLoader:]): (-[WebFrame _clearLoadingFromPageCacheForDocumentLoader:]): (-[WebFrame _isDocumentLoaderLoadingFromPageCache:]): (-[WebFrame _makeRepresentationForDocumentLoader:]): (-[WebFrame _revertToProvisionalStateForDocumentLoader:]): (-[WebFrame _setMainDocumentError:forDocumentLoader:]): (-[WebFrame _clearUnarchivingStateForLoader:]): (-[WebFrame _willChangeTitleForDocument:]): (-[WebFrame _didChangeTitleForDocument:]): (-[WebFrame _finishedLoadingDocument:]): (-[WebFrame _committedLoadWithDocumentLoader:data:]): (-[WebFrame _documentLoader:setMainDocumentError:]): (-[WebFrame _finalSetupForReplaceWithDocumentLoader:]): (-[WebFrame _createDocumentLoaderWithRequest:]): (-[WebFrame _provisionalLoadStarted]):
• WebView/WebFrameInternal.h:
• WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation title]):
• WebView/WebView.mm: (-[WebView _mainFrameOverrideEncoding]):

11:18 PM Changeset in webkit [22415] by adachan

• 2 edits in branches/WindowsMerge/WebKitWin

2006-10-23 Ada Chan <​adachan@apple.com>

Reviewed by sfalken.

We forgot to add a reference in WebNotificationCenter::addObserver.

10:13 PM Changeset in webkit [17244] by ggaren

• 2 edits
  2 moves in trunk/WebKit

RS by Maciej.

Gave ObjC++ files .mm extension instead of .m.

• WebCoreSupport/WebPageBridge.m: Removed.
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebDocumentLoaderMac.m: Removed.

9:59 PM Changeset in webkit [17243] by beidson

• 6 edits in trunk/WebCore

Lovingly reviewed by Maciej

Moved loadURL and postURL logic out of WebCoreFrameBridge to FrameMac::loadRequest
This is a big step towards moving FrameLoader out of the Bridge into Frame/Mac itself

• bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow): Use FrameMac::loadRequest

• bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): loadURL and postURL logic moved from WebCoreFrameBridge to here

• bridge/mac/WebCoreFrameBridge.h: Nuked loadURL and postURL
• bridge/mac/WebCoreFrameBridge.mm: Ditto
• loader/mac/WebFrameLoader.mm: (-[WebFrameLoader safeLoadURL:]): Use FrameMac::loadRequest

9:45 PM Changeset in webkit [17242] by ggaren

• 5 edits in trunk/WebCore

RS by Maciej.

Inside Frame, moved the plethora of load() and stopLoading() functions next
to each other to facilitate merging and crying.

• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::openURL): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected): (WebCore::FrameMac::openURLFromPageCache): (WebCore::FrameMac::createFrame):
• page/Frame.cpp: (WebCore::Frame::openURL): (WebCore::Frame::changeLocation): (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::loadSubframe): (WebCore::Frame::submitFormAgain): (WebCore::Frame::submitForm): (WebCore::Frame::stop): (WebCore::Frame::closeURL): (WebCore::Frame::cancelRedirection): (WebCore::Frame::iconURL): (WebCore::Frame::didOpenURL): (WebCore::Frame::didExplicitOpen):
• page/Frame.h:

9:12 PM Changeset in webkit [17241] by ggaren

• 3 edits in trunk/WebCore

RS by Maciej.

Moved our plethora of load() and stopLoading() functions next to each other
to facilitate merging and laughter.

• loader/mac/WebFrameLoader.h:
• loader/mac/WebFrameLoader.mm: (WebCore::cancelAll): (WebCore::FrameLoader::prepareForLoadStart): (WebCore::FrameLoader::setupForReplace): (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::finalSetupForReplace): (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::stopLoadingPlugIns): (WebCore::FrameLoader::stopLoadingSubresources): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::stopLoadingSubframes): (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::cancelPendingArchiveLoad): (WebCore::FrameLoader::removeSubresourceLoader): (WebCore::FrameLoader::mainResourceData): (WebCore::FrameLoader::releaseMainResourceLoader):

8:55 PM Changeset in webkit [17240] by kmccullo

• 3 edits in trunk/JavaScriptCore

Reviewed by

• Build fix

• JavaScriptCore.xcodeproj/project.pbxproj:
• kjs/grammar.y:

8:44 PM Changeset in webkit [17239] by kmccullo

• 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

• Makes the toTM function an operator. Was going to piggy back on a patch but the patch needs more work.

• kjs/DateMath.cpp: (KJS::equivalentYearForDST):
• kjs/DateMath.h: (KJS::GregorianDateTime::operator tm):
• kjs/date_object.cpp: (KJS::formatTime): (KJS::DateProtoFunc::callAsFunction):

8:28 PM Changeset in webkit [17238] by darin

• 32 edits in trunk

WebCore:

Reviewed by Maciej.

• converted WebFrameLoader to C++

• WebCore.exp: Added many new entry points for WebKit.
• WebCore.xcodeproj/project.pbxproj: Made more files private (SPI).

• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]): (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]): (-[WebCoreFrameBridge dealloc]): (-[WebCoreFrameBridge close]): (-[WebCoreFrameBridge clearFrame]): (-[WebCoreFrameBridge setFrameLoaderClient:]): (-[WebCoreFrameBridge frameLoader]): (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge didFirstLayout]): (-[WebCoreFrameBridge notifyIconChanged:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge isLoadTypeReload]): (-[WebCoreFrameBridge frameDetached]): (-[WebCoreFrameBridge tokenizerProcessedData]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebCoreFrameBridge reportClientRedirectCancelled:]): (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge handledOnloadEvents]): (-[WebCoreFrameBridge mainResourceURLResponse]): (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
• loader/mac/WebDocumentLoader.h:
• loader/mac/WebDocumentLoader.mm: (-[WebDocumentLoader frameLoader]): (-[WebDocumentLoader dealloc]): (-[WebDocumentLoader mainResourceData]): (-[WebDocumentLoader setRequest:]): (-[WebDocumentLoader bridge]): (-[WebDocumentLoader setMainDocumentError:]): (-[WebDocumentLoader mainReceivedError:complete:]): (-[WebDocumentLoader stopLoading]): (-[WebDocumentLoader setupForReplace]): (-[WebDocumentLoader commitIfReady]): (-[WebDocumentLoader finishedLoading]): (-[WebDocumentLoader commitLoadWithData:]): (-[WebDocumentLoader doesProgressiveLoadWithMIMEType:]): (-[WebDocumentLoader setupForReplaceByMIMEType:]): (-[WebDocumentLoader updateLoading]): (-[WebDocumentLoader setFrame:]): (-[WebDocumentLoader attachToFrame]): (-[WebDocumentLoader detachFromFrame]): (-[WebDocumentLoader prepareForLoadStart]): (-[WebDocumentLoader setPrimaryLoadComplete:]): (-[WebDocumentLoader isLoadingInAPISense]): (-[WebDocumentLoader setTitle:]):
• loader/mac/WebFrameLoader.h: (WebCore::FrameLoader::frame):
• loader/mac/WebFrameLoader.mm: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::~FrameLoader): (WebCore::FrameLoader::activeDocumentLoader): (WebCore::FrameLoader::addPlugInStreamLoader): (WebCore::FrameLoader::removePlugInStreamLoader): (WebCore::FrameLoader::defersCallbacksChanged): (WebCore::FrameLoader::defersCallbacks): (WebCore::setAllDefersCallbacks): (WebCore::FrameLoader::setDefersCallbacks): (WebCore::cancelAll): (WebCore::FrameLoader::stopLoadingPlugIns): (WebCore::FrameLoader::isLoadingMainResource): (WebCore::FrameLoader::isLoadingSubresources): (WebCore::FrameLoader::isLoadingPlugIns): (WebCore::FrameLoader::isLoading): (WebCore::FrameLoader::stopLoadingSubresources): (WebCore::FrameLoader::addSubresourceLoader): (WebCore::FrameLoader::removeSubresourceLoader): (WebCore::FrameLoader::mainResourceData): (WebCore::FrameLoader::releaseMainResourceLoader): (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::setDocumentLoader): (WebCore::FrameLoader::documentLoader): (WebCore::FrameLoader::setPolicyDocumentLoader): (WebCore::FrameLoader::provisionalDocumentLoader): (WebCore::FrameLoader::setProvisionalDocumentLoader): (WebCore::FrameLoader::state): (WebCore::FrameLoader::timeOfLastCompletedLoad): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::markLoadComplete): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::stopLoadingSubframes): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::setupForReplace): (WebCore::FrameLoader::identifierForInitialRequest): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::didReceiveAuthenticationChallenge): (WebCore::FrameLoader::didCancelAuthenticationChallenge): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::didFinishLoad): (WebCore::FrameLoader::didFailToLoad): (WebCore::FrameLoader::privateBrowsingEnabled): (WebCore::FrameLoader::originalRequest): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::clientRedirectCancelledOrFinished): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::shouldReload): (WebCore::FrameLoader::load): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::closeOldDataSources): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::initialRequest): (WebCore::FrameLoader::receivedData): (WebCore::FrameLoader::setRequest): (WebCore::FrameLoader::download): (WebCore::FrameLoader::bridge): (WebCore::FrameLoader::handleFallbackContent): (WebCore::FrameLoader::isStopping): (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::setResponse): (WebCore::FrameLoader::mainReceivedError): (WebCore::FrameLoader::finishedLoading): (WebCore::FrameLoader::notifyIconChanged): (WebCore::FrameLoader::URL): (WebCore::FrameLoader::cancelledError): (WebCore::FrameLoader::fileDoesNotExistError): (WebCore::FrameLoader::willUseArchive): (WebCore::FrameLoader::isArchiveLoadPending): (WebCore::FrameLoader::cancelPendingArchiveLoad): (WebCore::FrameLoader::handleUnimplementablePolicy): (WebCore::FrameLoader::cannotShowMIMEType): (WebCore::FrameLoader::interruptionForPolicyChangeError): (WebCore::FrameLoader::isHostedByObjectElement): (WebCore::FrameLoader::isLoadingMainFrame): (WebCore::FrameLoader::canShowMIMEType): (WebCore::FrameLoader::representationExistsForURLScheme): (WebCore::FrameLoader::generatedMIMETypeForURLScheme): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::cancelContentPolicyCheck): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::committedLoad): (WebCore::FrameLoader::isReplacing): (WebCore::FrameLoader::setReplacing): (WebCore::FrameLoader::revertToProvisional): (WebCore::FrameLoader::setMainDocumentError): (WebCore::FrameLoader::mainReceivedCompleteError): (WebCore::FrameLoader::finalSetupForReplace): (WebCore::FrameLoader::prepareForLoadStart): (WebCore::FrameLoader::subframeIsLoading): (WebCore::FrameLoader::willChangeTitle): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::loadType): (WebCore::FrameLoader::invalidatePendingPolicyDecision): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueAfterWillSubmitForm): (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::firstLayoutDone): (WebCore::FrameLoader::isQuickRedirectComing): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::post): (WebCore::FrameLoader::detachChildren): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::actionInformation): (WebCore::FrameLoader::checkLoadComplete): (WebCore::FrameLoader::setFrameLoaderClient): (WebCore::FrameLoader::client): (WebCore::FrameLoader::asDelegate): (-[WebCoreFrameLoaderAsDelegate initWithLoader:]): (-[WebCoreFrameLoaderAsDelegate detachFromLoader]): (-[WebCoreFrameLoaderAsDelegate continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]): (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]): (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]): (-[WebCoreFrameLoaderAsDelegate continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebCoreFrameLoaderAsDelegate continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
• loader/mac/WebLoader.h: (WebCore::WebResourceLoader::identifier): (WebCore::WebResourceLoader::reachedTerminalState): (WebCore::WebResourceLoader::cancelled):
• loader/mac/WebLoader.mm: (WebCore::WebResourceLoader::WebResourceLoader): (WebCore::WebResourceLoader::releaseResources): (WebCore::WebResourceLoader::load): (WebCore::WebResourceLoader::frameLoader): (WebCore::WebResourceLoader::willSendRequest): (WebCore::WebResourceLoader::didReceiveAuthenticationChallenge): (WebCore::WebResourceLoader::didCancelAuthenticationChallenge): (WebCore::WebResourceLoader::didReceiveResponse): (WebCore::WebResourceLoader::didReceiveData): (WebCore::WebResourceLoader::didFinishLoading): (WebCore::WebResourceLoader::didFinishLoadingOnePart): (WebCore::WebResourceLoader::didFail): (WebCore::WebResourceLoader::willCacheResponse): (WebCore::WebResourceLoader::didCancel): (WebCore::WebResourceLoader::cancel): (WebCore::WebResourceLoader::cancelledError): (WebCore::WebResourceLoader::delegate):
• loader/mac/WebMainResourceLoader.h:
• loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::create): (WebCore::MainResourceLoader::receivedError): (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::interruptionForPolicyChangeError): (WebCore::MainResourceLoader::isPostOrRedirectAfterPost): (WebCore::MainResourceLoader::addData): (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::didFail): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::policyDelegate):
• loader/mac/WebNetscapePlugInStreamLoader.h:
• loader/mac/WebNetscapePlugInStreamLoader.mm: (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader): (WebCore::NetscapePlugInStreamLoader::create): (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): (WebCore::NetscapePlugInStreamLoader::didFinishLoading): (WebCore::NetscapePlugInStreamLoader::didFail): (WebCore::NetscapePlugInStreamLoader::didCancel):
• loader/mac/WebSubresourceLoader.h:
• loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]):

WebKit:

Reviewed by Maciej.

• converted WebFrameLoader to C++

• History/WebHistoryItem.m: (+[WebHistoryItem _closeObjectsInPendingPageCaches]):
• Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
• Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream stop]):
• Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): (-[WebPluginController pluginView:receivedResponse:]):
• WebCoreSupport/WebFrameBridge.h:
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebDataSource.mm: (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource _webView]): (-[WebDataSource webFrame]):
• WebView/WebDocumentLoaderMac.h:
• WebView/WebDocumentLoaderMac.m: (-[WebDocumentLoaderMac dealloc]): (-[WebDocumentLoaderMac attachToFrame]): (-[WebDocumentLoaderMac detachFromFrame]):
• WebView/WebFrame.mm: (+[WebFrame _timeOfLastCompletedLoad]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _itemForRestoringDocState]): (-[WebFrame _frameLoader]): (-[WebFrame _firstLayoutDone]): (-[WebFrame _loadType]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame loadRequest:]): (-[WebFrame loadArchive:]): (-[WebFrame stopLoading]): (-[WebFrame reload]): (-[WebFrame _updateHistoryForCommit]): (-[WebFrame _updateHistoryForReload]): (-[WebFrame _updateHistoryForInternalLoad]): (-[WebFrame _deliverArchivedResourcesAfterDelay]): (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]): (-[WebFrame _deliverArchivedResources]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _provisionalLoadStarted]):
• WebView/WebFrameInternal.h:
• WebView/WebHTMLView.m: (-[WebHTMLView _clearLastHitViewIfSelf]): (-[WebHTMLView _updateMouseoverWithEvent:]): (-[NSArray removeMouseMovedObserverUnconditionally]): (-[NSArray removeMouseMovedObserver]): (-[NSArray viewWillMoveToWindow:]): (-[NSArray viewDidMoveToWindow]): (-[WebHTMLView _canMakeTextSmaller]): (-[WebHTMLView _canMakeTextLarger]): (-[WebHTMLView _canMakeTextStandardSize]):
• WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
• WebView/WebView.mm: (-[WebView _close]): (-[WebView setDefersCallbacks:]): (-[WebView setCustomTextEncodingName:]):

8:23 PM Changeset in webkit [22414] by ggaren

• 3 edits in branches/WindowsMerge/WebCore

Reviewed by Bradee.

Removed methods from BrowserExtension.

• bridge/win/FrameWin.h:
• platform/win/TemporaryLinkStubs.cpp: (FrameWin::canPaste): (FrameWin::canGoBackOrForward): (FrameWin::goBackOrForward): (FrameWin::getHistoryLength): (FrameWin::historyURL): (Page::canRunModal): (Page::canRunModalNow): (Page::runModal): (BrowserExtensionWin::BrowserExtensionWin):

8:18 PM Changeset in webkit [17237] by kmccullo

• 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

• Fixes two regressions on win. Both are stack overflows. For one the number of regressions is capped at 100, and for the other, nested parenthesis pairs are not evaluated (since they would evaluate to whatever is in them anyway).

• kjs/grammar.y:
• kjs/object.cpp:

8:18 PM Changeset in webkit [17236] by ggaren

• 17 edits in trunk

WebCore:

Reviewed by Bradee.

Shrunk BrowserExtension in preparation for its imminent death, moving page-
level operations to Page and frame-level operations to Frame.

Removed bizarre Mac(this) syntax inside virtual FrameMac member functions,
because 'this' is guaranteed by the compiler to be a FrameMac*.

• bindings/js/kjs_window.cpp: Added NULL checks for m_frame in places where it can be NULL.
• bindings/js/kjs_window.cpp: (KJS::canShowModalDialog): (KJS::canShowModalDialogNow): (KJS::showModalDialog): (KJS::History::getValueProperty): (KJS::HistoryFunc::callAsFunction):
• bridge/BrowserExtension.h: (WebCore::BrowserExtension::~BrowserExtension):
• bridge/mac/BrowserExtensionMac.h:
• bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::frameDetached): (WebCore::FrameMac::unfocusWindow): (WebCore::FrameMac::bridgeForWidget): (WebCore::FrameMac::documentViewForNode): (WebCore::FrameMac::passSubframeEventToSubframe): (WebCore::Frame::setNeedsReapplyStyles): (WebCore::FrameMac::customHighlightLineRect): (WebCore::FrameMac::paintCustomHighlight): (WebCore::FrameMac::getHistoryLength): (WebCore::FrameMac::goBackOrForward): (WebCore::FrameMac::historyURL):
• bridge/mac/PageMac.mm: (WebCore::Page::canRunModal): (WebCore::Page::canRunModalNow): (WebCore::Page::runModal):
• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCorePageBridge.h:
• bridge/win/BrowserExtensionWin.h:
• page/Frame.cpp: (WebCore::Frame::scheduleHistoryNavigation): (WebCore::Frame::redirectionTimerFired):
• page/Frame.h:
• page/Page.h:

WebKit:

Reviewed by Bradee.

Moved some page-level operations from WebFrameBridge to WebPageBridge.

• WebCoreSupport/WebFrameBridge.m:
• WebCoreSupport/WebPageBridge.m: (-[WebPageBridge createModalDialogWithURL:referrer:]): (-[WebPageBridge canRunModal]): (-[WebPageBridge canRunModalNow]): (-[WebPageBridge runModal]):
• WebKit.xcodeproj/project.pbxproj: Made WebPageBridge.m ObjC++ to support WebCore #includes.

7:36 PM Changeset in webkit [17235] by justing

• 2 adds in trunk/LayoutTests/editing/execCommand

7:35 PM Changeset in webkit [17234] by justing

• 7 edits in trunk

LayoutTests:

Reviewed by mjs

<​http://bugs.webkit.org/show_bug.cgi?id=11334>
Writely Editor: Placing caret in a list "highlights" both Numbered List and Bulleted List toolbar icons

• editing/execCommand/queryCommandState-01-expected.txt: Added.
• editing/execCommand/queryCommandState-01.html: Added.

WebCore:

Reviewed by mjs

<​http://bugs.webkit.org/show_bug.cgi?id=11334>
Writely Editor: Placing caret in a list "highlights" both Numbered List and Bulleted List toolbar icons

• WebCore.xcodeproj/project.pbxproj:
• editing/Editor.cpp: (WebCore::Editor::selectionUnorderedListState): Added. (WebCore::Editor::selectionOrderedListState): Added.
• editing/Editor.h:
• editing/JSEditor.cpp:
• page/Frame.cpp:
• page/Frame.h:

4:57 PM Changeset in webkit [17233] by sullivan

• 2 edits in trunk/WebKit

• WebKitPrefix.h: Removed redundant definition of BUILDING_ON_TIGER that I just added. It turns out this had already been added between the last time I updated in this tree and when I needed it locally.

4:10 PM Changeset in webkit [17232] by sullivan

• 1 edit in trunk/WebKit/WebKitPrefix.h

Checked in this file that I mentioned in the previous ChangeLog entry but forgot to check in.

4:03 PM Changeset in webkit [17231] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Ander

• WebKit.xcodeproj/project.pbxproj: Move WebKitPrefix.h from Misc group to top level, to match WebCore

• WebKitPrefix.h: defined BUILDING_ON_TIGER a la WebCore, in preparation for future use of post-Tiger API

3:56 PM Changeset in webkit [17230] by sullivan

• 2 edits in trunk/WebCore

Reviewed by Tim H

• WebCore.xcodeproj/project.pbxproj: Include WebCorePrefix.h in Xcode project for convenience and for consistency with WebKit

3:40 PM Changeset in webkit [17229] by thatcher

• 4 edits
  10 moves in trunk/WebKit

Reviewed by Darin.

Rename the now ObjC++ files to be .mm and remove the explicit file types.

• DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
• English.lproj/StringsNotToBeLocalized.txt:
• Plugins/WebBaseNetscapePluginView.m: Removed.
• Plugins/WebNetscapePluginStream.m: Removed.
• Plugins/WebPluginController.m: Removed.
• WebCoreSupport/WebFrameBridge.m: Removed.
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebDataSource.m: Removed.
• WebView/WebFrame.m: Removed.
• WebView/WebFrameView.m: Removed.
• WebView/WebPDFView.m: Removed.
• WebView/WebPolicyDelegate.m: Removed.
• WebView/WebView.m: Removed.

3:27 PM Changeset in webkit [17228] by thatcher

• 5 edits
  2 adds in trunk/WebKit

Reviewed by Darin.

Move the undef try/catch to WebKitPrfix.h and include algorithm so we get
exception_defines.h and so the undef of try/catch works.

Break off the BGRA to ARGB code into WebGraphicsExtras.c, this lets
WebBaseNetscapePluginView.m safely compile as ObjC++ and not cause the Accelerate
framework to complain about C++ exceptions being disabled.

• Misc/WebGraphicsExtras.c: Added. (WebConvertBGRAToARGB):
• Misc/WebGraphicsExtras.h: Added.
• Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
• WebKit.xcodeproj/project.pbxproj:
• WebKitPrefix.h:
• WebView/WebView.m:

3:22 PM Changeset in webkit [17227] by weinig

• 3 edits
  16 adds
  16 deletes in trunk/WebCore

Reviewed by Tim H.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11291
PNG as cursor image format instead of TIFF

Original patch by Lars Naesbye Christensen (​larsnaesbye@stud.ku.dk)

• Convert cursor images from TIFF to PNG.

• Resources/eastResizeCursor.png: Added.
• Resources/eastResizeCursor.tiff: Removed.
• Resources/eastWestResizeCursor.png: Added.
• Resources/eastWestResizeCursor.tiff: Removed.
• Resources/helpCursor.png: Added.
• Resources/helpCursor.tiff: Removed.
• Resources/linkCursor.png: Added.
• Resources/linkCursor.tiff: Removed.
• Resources/moveCursor.png: Added.
• Resources/moveCursor.tiff: Removed.
• Resources/northEastResizeCursor.png: Added.
• Resources/northEastResizeCursor.tiff: Removed.
• Resources/northEastSouthWestResizeCursor.png: Added.
• Resources/northEastSouthWestResizeCursor.tiff: Removed.
• Resources/northResizeCursor.png: Added.
• Resources/northResizeCursor.tiff: Removed.
• Resources/northSouthResizeCursor.png: Added.
• Resources/northSouthResizeCursor.tiff: Removed.
• Resources/northWestResizeCursor.png: Added.
• Resources/northWestResizeCursor.tiff: Removed.
• Resources/northWestSouthEastResizeCursor.png: Added.
• Resources/northWestSouthEastResizeCursor.tiff: Removed.
• Resources/southEastResizeCursor.png: Added.
• Resources/southEastResizeCursor.tiff: Removed.
• Resources/southResizeCursor.png: Added.
• Resources/southResizeCursor.tiff: Removed.
• Resources/southWestResizeCursor.png: Added.
• Resources/southWestResizeCursor.tiff: Removed.
• Resources/waitCursor.png: Added.
• Resources/waitCursor.tiff: Removed.
• Resources/westResizeCursor.png: Added.
• Resources/westResizeCursor.tiff: Removed.
• WebCore.xcodeproj/project.pbxproj:
• platform/mac/CursorMac.mm: (WebCore::leakNamedCursor):

3:15 PM Changeset in webkit [17226] by mjs

• 3 edits in trunk/WebCore

Not reviewed.

• fixed build from last change.

• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::openURL):

3:03 PM Changeset in webkit [22413] by aroben

• 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Reviewed by Adele.

Fix: <rdar://problem/4796994> Styled <select>s should still use Windows
theme

The fix is to do most of our drawing for menulists in
RenderThemeWin::paintMenuListButton (which is called for styled
<select>s), and then do any extra drawing for unstyled <select>s in
RenderThemeWin::paintMenuList.

• rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::getThemeData): Case for MenulistButtonAppearance should be the same as MenulistAppearance. (WebCore::RenderThemeWin::paintMenuList): Draw the border, then defer to paintMenuListButton to handle the rest of painting. (WebCore::RenderThemeWin::adjustMenuListStyle): Reset the border so we can draw our own, then defer to adjustMenuListStyle. (WebCore::RenderThemeWin::adjustMenuListButtonStyle): Code moved from adjustMenuListStyle, less the call to resetBorder(). (WebCore::RenderThemeWin::paintMenuListButton): Code moved from paintMenuList, less the border-drawing code.
• rendering/RenderThemeWin.h:

3:00 PM Changeset in webkit [17225] by aroben

• 3 edits in trunk/WebCore

Reviewed by Adele.

Move border-radius rule for <select>s into RenderThemeMac, as this is
really a platform-specific look.

• css/html4.css:
• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustMenuListButtonStyle):

2:53 PM Changeset in webkit [22412] by sfalken

• 8 edits in branches/WindowsMerge/WebKitWin

2006-10-23 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou.

• MarshallingHelpers.cpp: (MarshallingHelpers::BSTRToCFStringRef): Fix leak in BSTRToCFStringRef
• WebEditorClient.cpp: (WebEditorClient::WebEditorClient): Break dependency cycle by not holding a COM ref to the WebView (WebEditorClient::~WebEditorClient): Break dependency cycle by not holding a COM ref to the WebView
• WebFrame.cpp: (WebFrame::initWithWebFrameView): (WebFrame::windowResizerRect): Fix reference leaks
• WebHistory.cpp: (createUserInfoFromArray): Fixed leak of key CFStringRef. (WebHistory::setOptionalSharedHistory): Made this callable with a 0 to release shared history (_WebCoreHistoryProvider::_WebCoreHistoryProvider): Don't hold a ref to the WebHistory (_WebCoreHistoryProvider::~_WebCoreHistoryProvider): Don't hold a ref to the WebHistory (_WebCoreHistoryProvider::containsItemForURLLatin1): Don't hold a ref to the WebHistoryPrivate
• WebHistoryItem.cpp: (WebHistoryItem::WebHistoryItem): Don't hold a reference to the WebIconDatabase
• WebIconDatabase.cpp: (WebIconDatabase::~WebIconDatabase): Delete core icon db on delete
• WebNotificationCenter.cpp: (ObserverKey::ObserverKey): Init data to 0 before calling assignment op (ObserverKey::operator=): Free old string, release old ref if needed before copy

2:44 PM Changeset in webkit [17224] by mjs

• 3 edits in trunk/WebCore

Reviewed by Brady.

• moved things around so loadURL:... is only called from one place

• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::frameDetached): (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::openURL): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected):

2:29 PM Changeset in webkit [17223] by justing

• 7 edits
  20 adds in trunk

LayoutTests:

Reviewed by john

<​http://bugs.webkit.org/show_bug.cgi?id=11333>
Writely Editor: After inserting a HR element, pressing return key creates a copy of this HR element in the document

• editing/inserting/insert-br-009-expected.checksum: Added.
• editing/inserting/insert-br-009-expected.png: Added.
• editing/inserting/insert-br-009-expected.txt: Added.
• editing/inserting/insert-br-009.html: Added.
• editing/inserting/insert-paragraph-01-expected.checksum: Added.
• editing/inserting/insert-paragraph-01-expected.png: Added.
• editing/inserting/insert-paragraph-01-expected.txt: Added.
• editing/inserting/insert-paragraph-01.html: Added.
• editing/inserting/insert-paragraph-02-expected.checksum: Added.
• editing/inserting/insert-paragraph-02-expected.png: Added.
• editing/inserting/insert-paragraph-02-expected.txt: Added.
• editing/inserting/insert-paragraph-02.html: Added.
• editing/inserting/insert-paragraph-03-expected.checksum: Added.
• editing/inserting/insert-paragraph-03-expected.png: Added.
• editing/inserting/insert-paragraph-03-expected.txt: Added.
• editing/inserting/insert-paragraph-03.html: Added.
• editing/inserting/insert-paragraph-04-expected.checksum: Added.
• editing/inserting/insert-paragraph-04-expected.png: Added.
• editing/inserting/insert-paragraph-04-expected.txt: Added.
• editing/inserting/insert-paragraph-04.html: Added.

WebCore:

Reviewed by john

<​http://bugs.webkit.org/show_bug.cgi?id=11333>
Writely Editor: After inserting a HR element, pressing return key creates a copy of this HR element in the document

Added special cases in InsertLineBreakCommand for inserting before
and after tables and horizontal rules. Also, perform InsertLineBreak
instead of InsertParagraphSeparator at these positions.

• editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Use the canonical form of the caret position when we check for the new special cases because we know that we canonicalize VisiblePositions to those positions. Added code to handle inserting before/after tables and horizontal rules. Fixed a bug when inserting at the end of a block (it checked for a collapse of the inserted br by looking for the absence of a br, but the line break might have been a '\n' in white-space:pre text). Removed unused LOGs.
• editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Perform an InsertLineBreakCommand when before/after a table or a horizontal rule so that we don't have to maintain two pieces of special case code. Migrated to enclosingBlock.
• editing/htmlediting.cpp: Added a FIXME.
• editing/visible_units.cpp: (WebCore::startOfParagraph): Added a workaround for 8622.

1:59 PM Changeset in webkit [17222] by sfalken

• 2 edits in trunk/JavaScriptCore

2006-10-21 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Add minimal compatibility with MSVCRT leak checker

• wtf/FastMalloc.h:

1:37 PM Changeset in webkit [22411] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

Fix: <rdar://problem/4786759> PageUp/PageDown/Home/End don't work in
<select> menus

• platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::setFocusedIndex): Only call ::UpdateWindow if we didn't scroll, because scrolling will do the update for us. (WebCore::PopupMenu::focusFirst): New method. (WebCore::PopupMenu::focusLast): New method. (WebCore::PopupMenu::down): Add a parameter to specify how far we should try to move the selection. (WebCore::PopupMenu::up): Ditto. (WebCore::PopupMenu::invalidateItem): Cleanup code by using IntRect instead of RECT. (WebCore::PopupMenu::scrollTo): Return a boolean to say whether scrolling actually happened. (WebCore::PopupMenu::scrollToRevealSelection): Ditto. (WebCore::PopupWndProc): Handle PageUp/PageDown/Home/End.

1:34 PM Changeset in webkit [17221] by aroben

• 2 edits in trunk/WebCore

Reviewed by Adele.

Make popups a little more flexible.

• platform/PopupMenu.h:

12:45 PM Changeset in webkit [17220] by weinig

• 2 edits in trunk/WebCore

Reviewed by Tim H.

Cleanup CodeGeneratorJS.pm

• bindings/scripts/CodeGeneratorJS.pm:

12:21 PM Changeset in webkit [17219] by thatcher

• 2 edits in trunk/WebCore/Resources

Reverting two images that got commited as empty files after being compressed.

12:03 PM Changeset in webkit [17218] by kmccullo

• 2 edits in trunk/JavaScriptCore

Reviewed by Geof.

• Sets the lowercase range correctly in the test and consolidates a variable to make the test more readable.

• tests/mozilla/ecma/String/15.5.4.11-2.js:

11:58 AM Changeset in webkit [17217] by thatcher

• 2 edits in trunk/WebKit

Build fix.

11:35 AM Changeset in webkit [17216] by thatcher

• 2 edits in trunk

Build fix. We can't make the internal DOM headers private since they are not generated at the time installhdrs is called, this break B&I builds.

11:24 AM Changeset in webkit [22410] by aroben

• 9 edits in branches/WindowsMerge

WebCoreWin:

Build fix.

• WebCore.vcproj/WebCore.vcproj: Copy headers from new platform/network directory and subdirectories.

WebKitWin:

Build fix.

• WebFrame.cpp: Change header paths to point to new platform/network directory and subdirectories.
• WebFrame.h: Ditto.
• WebURLResponse.cpp: Ditto.
• WebURLResponse.h: Ditto.
• WebView.cpp: Ditto.
• WebKit.vcproj/WebKit.vcproj: Add platform/network and subdirectories to AdditionalIncludeDirectories.

11:23 AM Changeset in webkit [17215] by thatcher

• 4 edits in trunk/WebCore/Resources

Compressing TIFFs to fix verification error.

10:02 AM Changeset in webkit [22409] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Build fix.

• plugins/win/PluginStreamWin.h: Rename methods to match Maciej's changes.

9:50 AM Changeset in webkit [17214] by aroben

• 2 edits in trunk/WebCore

Rubberstamped by Brady.

• loader/icon/IconLoader.h: Changed angle-brackets to quotes for #include of ResourceLoader.h, since it's a WebCore header.

9:50 AM Changeset in webkit [22408] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Build fix.

• WebCore.vcproj/WebCore.vcproj: Copied AdditionalIncludeDirectories from Release to All Configurations.

8:47 AM Changeset in webkit [17213] by darin

• 2 edits in trunk/WebCore

• fixed mistake that was preventing any loading from happening

• platform/network/ResourceLoaderClient.h: (WebCore::ResourceLoaderClient::didReceiveData): Changed parameter back to int. Perhaps we want to move to "long long" consistently, but I'll leave that up to Maciej.

3:01 AM Changeset in webkit [22407] by mjs

• 7 edits in branches/WindowsMerge

WebCoreWin:

Rubber-stamped by Anders.

• fixed for ResourceLoader refactoring.

• platform/network/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::onRequestComplete): (WebCore::ResourceLoader::fileLoadTimer): (WebCore::ResourceLoader::cancel):
• plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::didFinishLoading):
• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):

WebKitWin:

Rubber-stamped by Anders.

• fixed for ResourceLoader refactoring.

• WebFrame.cpp: (WebFrame::didReceiveData): (WebFrame::didFinishLoading):
• WebFrame.h:

2:07 AM Changeset in webkit [17212] by mjs

• 17 edits in trunk/WebCore

Reviewed by Anders.

• start converting ResourceLoaderClient to new API

Did the bits I could do without introducing new types:

• renamed receivedData to didReceiveData
• renamed version of receivedAllData that doesn't pass any data to didFinishLoading

• bridge/mac/WebCoreResourceLoaderImp.mm: (-[WebCoreResourceLoaderImp addData:]): (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
• loader/icon/IconLoader.cpp: (IconLoader::didReceiveData): (IconLoader::didFinishLoading):
• loader/icon/IconLoader.h:
• loader/loader.cpp: (WebCore::Loader::didReceiveData):
• loader/loader.h:
• platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::didReceiveData):
• platform/gdk/FrameGdk.h:
• platform/network/ResourceLoaderClient.h: (WebCore::ResourceLoaderClient::didReceiveData): (WebCore::ResourceLoaderClient::didFinishLoading): (WebCore::ResourceLoaderClient::receivedResponse):
• platform/network/cf/ResourceLoaderCFNet.cpp: (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::ResourceLoader::cancel):
• platform/network/gdk/ResourceLoaderManager.cpp: (WebCore::writeCallback): (WebCore::ResourceLoaderManager::downloadTimerCallback): (WebCore::ResourceLoaderManager::remove):
• platform/network/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::slotData): (WebCore::ResourceLoaderManager::remove):
• platform/network/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::onRequestComplete): (WebCore::ResourceLoader::fileLoadTimer): (WebCore::ResourceLoader::cancel):
• platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::didReceiveData):
• platform/qt/FrameQtClient.h:
• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::processSyncLoadResults): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didReceiveData):
• xml/xmlhttprequest.h:

1:00 AM Changeset in webkit [17211] by mjs

• 1 edit in trunk/WebCore/ChangeLog

Rubber stamped by Anders.

• marked files executable

• ksvg2/scripts/csscssmakeprops:
• ksvg2/scripts/csscssmakevalues:

Oct 22, 2006:

5:44 PM Changeset in webkit [22406] by mjs

• 2 edits
  2 moves
  2 adds in branches/WindowsMerge/WebCore

Reviewed by Anders.

• updated for new ResourceLoader file locations.

• WebCore.vcproj/WebCore.vcproj: Updated file paths.
• platform/win/ResourceLoaderWin.cpp: Moved to platform/network/win
• platform/win/ResourceLoaderWin.h: ditto

5:20 PM Changeset in webkit [17210] by mjs

• 6 edits
  15 moves
  6 adds in trunk/WebCore

Reviewed by Anders.

• moved ResourceLoader and related files to platform/network in preparation for building out this API.

I tried to update all the build systems but I'm not sure they are
all fixed properly

• page/ResourceRequest.h: Moved to platform/network.
• platform/ResourceLoader.cpp: Moved to platform/network.
• platform/ResourceLoader.h: Moved to platform/network.
• platform/ResourceLoaderClient.h: Moved to platform/network.
• platform/ResourceLoaderInternal.h: Moved to platform/network.
• platform/cf/ResourceLoaderCFNet.cpp: Moved to platform/network/cf.
• platform/gdk/ResourceLoaderCurl.cpp: Moved to platform/network/gdk.
• platform/gdk/ResourceLoaderManager.cpp: Moved to platform/network/gdk.
• platform/gdk/ResourceLoaderManager.h: Moved to platform/network/gdk.
• platform/mac/ResourceLoaderMac.mm: Moved to platform/network/mac.
• platform/qt/ResourceLoaderManager.cpp: Moved to platform/network/qt.
• platform/qt/ResourceLoaderManager.h: Moved to platform/network/qt.
• platform/qt/ResourceLoaderQt.cpp: Moved to platform/network/qt.
• platform/win/ResourceLoaderWin.cpp: Moved to platform/network/win.
• platform/win/ResourceLoaderWin.h: Moved to platform/network/win.
• webcore-base.bkl: Updated for new paths.
• CMakeLists.txt: ditto
• Projects/gdk/webcore-gdk.bkl: ditto
• WebCore.xcodeproj/project.pbxproj: ditto
• WebCoreSources.bkl: ditto

12:59 PM Changeset in webkit [22405] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

Fix some crashes caused by the <select> element being detached while
the popup is open.

• platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc):

11:01 AM Changeset in webkit [17209] by weinig

• 5 edits in trunk

WebCore:

Reviewed by Tim H.

• Add DOMHTMLFormElementPrivate.h to the project.

• WebCore.xcodeproj/project.pbxproj:
• bindings/objc/DOMPrivate.h:

WebKit:

Reviewed by Tim H.

• Add DOMHTMLFormElementPrivate.h to the project.

• MigrateHeaders.make:

12:31 AM Changeset in webkit [17208] by darin

• 4 edits in trunk/WebCore

• another try at fixing Qt

• CMakeLists.txt: Added DeleteButton.cpp and DeleteButtonController.cpp.

• and fix a couple warnings while I'm at it

• platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::setRGBA): Don't do unsigned *= float.

• rendering/break_lines.cpp: (WebCore::nextBreakablePosition): Move unused variable inside #if so it's consistent.

Oct 21, 2006:

11:51 PM Changeset in webkit [17207] by darin

• 4 edits in trunk/WebCore

• fix the Qt build

• platform/qt/EditorClientQt.cpp: (WebCore::EditorClientQt::shouldShowDeleteInterface):
• platform/qt/EditorClientQt.h:
• platform/qt/FrameQt.cpp:

11:39 PM Changeset in webkit [17206] by darin

• 21 edits in trunk

WebCore:

Reviewed by Adele.

• convert WebLoader and its 3 subclasses to C++ (this time with a leak fixed)

Renamed WebLoader to WebCore::WebResourceLoader (should be ResourceLoader, but
there's currently another class with that name).
Renamed WebMainResourceLoader to WebCore::MainResourceLoader.
Renamed WebSubresourceLoader to WebCore::SubresourceLoader.
Renamed WebNetscapePlugInStreamLoader to WebCore::NetscapePlugInStreamLoader.

Converted the classes to C++ and added Objective-C delegates to forward from
API that still requires Objective-C.

Did not yet rename the source files.

• WebCore.exp: Removed WebLoader, WebNetscapePlugInStreamLoader, and WebSubresourceLoader classes. Added 5 functions from the WebResourceLoader and NetscapePlugInStreamLoader classes.

• WebCore.xcodeproj/project.pbxproj: Made RetainPtr.h a private header instead of project.

• platform/cf/RetainPtr.h: Put into the WebCore namespace rather than the WTF namespace.

• loader/mac/WebLoader.h:
• loader/mac/WebLoader.mm:
• loader/mac/WebMainResourceLoader.h:
• loader/mac/WebMainResourceLoader.mm:
• loader/mac/WebNetscapePlugInStreamLoader.h:
• loader/mac/WebNetscapePlugInStreamLoader.mm:
• loader/mac/WebSubresourceLoader.h:
• loader/mac/WebSubresourceLoader.mm: Translate to C++.

• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
• loader/mac/WebFrameLoader.h:
• loader/mac/WebFrameLoader.mm: (isCaseInsensitiveEqual): (isBackForwardLoadType): (-[WebFrameLoader dealloc]): (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoadingPlugIns]): (-[WebFrameLoader isLoadingMainResource]): (-[WebFrameLoader isLoadingSubresources]): (-[WebFrameLoader isLoadingPlugIns]): (-[WebFrameLoader stopLoadingSubresources]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader mainResourceData]): (-[WebFrameLoader releaseMainResourceLoader]): (-[WebFrameLoader cancelMainResourceLoad]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader stopLoadingWithError:]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader archiveLoadPendingForLoader:]): (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
• loader/mac/WebFrameLoaderClient.h: Call the new C++ API.

WebKit:

Reviewed by Adele.

• convert WebLoader and its 3 subclasses to C++

• Plugins/WebNetscapePluginStream.h:
• Plugins/WebNetscapePluginStream.m: (-[WebNetscapePluginStream dealloc]): (-[WebNetscapePluginStream finalize]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream cancelLoadWithError:]): (-[WebNetscapePluginStream stop]):
• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge canRunModalNow]):
• WebView/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFramePrivate finalize]): (frame): Changed from uppercase to lowercase so that it won't conflict with the WebCore class named Frame. (-[WebFrame _firstChildFrame]): (-[WebFrame _lastChildFrame]): (-[WebFrame _previousSiblingFrame]): (-[WebFrame _nextSiblingFrame]): (-[WebFrame _traverseNextFrameStayWithin:]): (-[WebFrame _immediateChildFrameNamed:]): (-[WebFrame _nextFrameWithWrap:]): (-[WebFrame _previousFrameWithWrap:]): (-[WebFrame findFrameNamed:]): (-[WebFrame parentFrame]): (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]): (-[WebFrame _deliverArchivedResourcesAfterDelay]): (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]): (-[WebFrame _archiveLoadPendingForLoader:]): (-[WebFrame _cancelPendingArchiveLoadForLoader:]): (-[WebFrame _clearArchivedResources]): (-[WebFrame _deliverArchivedResources]):

8:22 PM Changeset in webkit [22404] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Anders.

Fix: <rdar://problem/4794151> Popup should scroll to reveal selected
item, not just one line at a time
Fix: <rdar://problem/4794229> Popup hot-tracking should not change text
in <select> control

• platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize): Cleaned up code by translating into screen coordinates right away. (WebCore::PopupMenu::setFocusedIndex): Added parameter to specify whether the text in the <select> control should be updated. (WebCore::PopupMenu::scrollTo): Extracted scrolling code from PopupWndProc to here. (WebCore::PopupMenu::scrollToRevealSelection): New method. (WebCore::PopupWndProc): Use scrollToRevealSelection() instead of manually scrolling one line at a time. Fixed a bug in detecting a mouse drag. Pass in HDC from ::BeginPaint to PopupMenu::paint.

8:19 PM Changeset in webkit [17205] by aroben

• 2 edits in trunk/WebCore

Reviewed by Anders.

Popup tweaks.

• platform/PopupMenu.h:

8:10 PM Changeset in webkit [17204] by darin

• 2 edits in trunk/WebCore

• editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableTable): Oops, edited this before landing it and introduced a null-deref! This fixes it.

7:59 PM Changeset in webkit [17203] by darin

• 2 edits in trunk/WebKitTools

• Scripts/commit-log-editor: Use baseProductDir() to find the base product directory. This was still using "symroots" so it almost never worked!

7:58 PM Changeset in webkit [17202] by darin

• 12 edits in trunk/WebCore

Reviewed by Anders.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11379 assertion failure seen in editing tests (in new DeleteButtonController)

I cleaned up the relationship between the Frame, Editor, EditorClient, and
DeleteButtonController a bit while also making the simple change to fix the
assertion failure.

• bridge/mac/FrameMac.h: Change EditorClient parameter to a PassRefPtr since we take ownership.
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac):

• page/Frame.h: Change EditorClient parameter to a PassRefPtr since we take ownership.
• page/Frame.cpp: (WebCore::Frame::Frame): Ditto. (WebCore::Frame::appliedEditing): Removed unneeded parameter to the respondToChangedContents function, and moved it to Editor rather than right on the DeleteButtonController. (WebCore::Frame::unappliedEditing): Ditto. (WebCore::Frame::reappliedEditing): Ditto.
• page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): More of the same.

• editing/DeleteButtonController.h:
• editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::DeleteButtonController): Replaced Editor* with a Frame*. The general pattern is that we always use the Frame* as the frame identifier. See FrameTree, for example. (WebCore::enclosingDeletableTable): Added. Helper function used by the respondToChangedSelection function. Includes an additional check for whether the container is contentEditable, which was missing from the old version. This prevents the assertion failure. Also added a check that the table itself is editable. (WebCore::DeleteButtonController::respondToChangedSelection): Rewrote to use the helper. (WebCore::DeleteButtonController::respondToChangedContents): Removed the unnecessary selection parameter. No need to pass in the state of the frame since we can get it if we need it. (WebCore::DeleteButtonController::show): Updated to use frame pointer rather than editor pointer.

• editing/Editor.cpp: Fixed formatting. Even the temporary placeholder functions should be formatted on multiple lines as usual. (WebCore::Editor::respondToChangedSelection): Added. Forwards to the delete button controller. (WebCore::Editor::respondToChangedContents): Ditto. (WebCore::Editor::Editor): Changed EditorClient parameter to a PassRefPtr since we take ownership.

• editing/Editor.h: Changed the DeleteButtonController to use an OwnPtr instead of being defined inline to decouple so that we don't have to include DeleteButtonController.h. That way changes to DeleteButtonController.h cause very little to recompile.

• editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Updated to call the editor instead of the delete button controller for the selection change.

7:38 PM Changeset in webkit [17201] by andersca

• 3 edits in trunk/WebCore

2006-10-21 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

• loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
• platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): Don't leak the header dictionary.

7:09 PM Changeset in webkit [22403] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Build fix.

• WebCore.vcproj/WebCore.vcproj: Add new DeleteButton* files to project.

6:55 PM Changeset in webkit [17200] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by Anders.

• ​http://bugs.webkit.org/show_bug.cgi?id=11377 swap(Vector, Vector) should be O(1) instead of O(n)

• wtf/Vector.h: (WTF::VectorBuffer::swap): Added. (WTF::Vector::swap): Added. (WTF::swap): Added overload that takes two Vector objects.

6:52 PM Changeset in webkit [17199] by darin

• 3 edits in trunk/WebKit

Reviewed by Anders.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=10328 REGRESSION: frame leak reported by buildbot

• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): Don't retain the web view. (WebEditorClient::~WebEditorClient): Don't release the web view. (WebEditorClient::setWebView): Ditto.

• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge finishInitializingWithFrameName:view:]): Added. Common code for use by both init methods below. (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): Changed to use new method. Also added comment pointing out design flaw -- we attach the client to the web view here, but we need to be sure to detach in case the web view is deallocated first. (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): Ditto.

6:24 PM Changeset in webkit [17198] by darin

• 6 edits in trunk

JavaScriptCore:

Reviewed by Adam.

• ​http://bugs.webkit.org/show_bug.cgi?id=11376 build scripts should invoke make with "-j" option for multiple processors

• JavaScriptCore.xcodeproj/project.pbxproj: Pass -j sysctl -n hw.ncpu to make.

WebCore:

Reviewed by Adam.

• ​http://bugs.webkit.org/show_bug.cgi?id=11376 build scripts should invoke make with "-j" option for multiple processors

• WebCore.xcodeproj/project.pbxproj: Pass -j sysctl -n hw.ncpu to make.

WebKit:

Reviewed by Adam.

• ​http://bugs.webkit.org/show_bug.cgi?id=11376 build scripts should invoke make with "-j" option for multiple processors

• WebKit.xcodeproj/project.pbxproj: Pass -j sysctl -n hw.ncpu to make.

6:15 PM Changeset in webkit [17197] by darin

• 3 edits
  1 copy in trunk/WebKitTools

• Makefile: Build DumpRenderTree too.
• Scripts/do-webcore-rename: Removed bogus comment.

11:46 AM Changeset in webkit [22402] by thatcher

• 3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Geoff.

Stub out the new shouldShowDeleteInterface method.

• WebEditorClient.cpp: (WebEditorClient::shouldShowDeleteInterface):
• WebEditorClient.h:

11:40 AM Changeset in webkit [17196] by thatcher

• 18 edits
  7 adds in trunk

WebCore:

Reviewed by Geoff.

<rdar://problem/4478625> HTML Editing: Basic table editing and culling

Initial implementaltion of table deletion user interface:

• Interface shows up on the nearest table containing the entire selection.
• Shows a Dashboard style close button in the top left corner.
• Shows a 60% opaque black outline around the table.
• Adds a new EditorClient function shouldShowDeleteInterface.

Also adds a new constructor CachedImage and setter functions on
HTMLImageElement and HTMLImageLoader allowing an Image object to be set
and image element in the page. This change also paves the way to allow an
NSImage setter on DOMHTMLImageElement.

• Resources/deleteButton.tiff: Added.
• Resources/deleteButtonPressed.tiff: Added.
• WebCore.xcodeproj/project.pbxproj:
• bridge/EditorClient.h:
• editing/DeleteButton.cpp: Added. (WebCore::DeleteButton::DeleteButton): (WebCore::DeleteButton::defaultEventHandler): notify the controller to delete on click
• editing/DeleteButton.h: Added.
• editing/DeleteButtonController.cpp: Added. (WebCore::DeleteButtonController::DeleteButtonController): (WebCore::DeleteButtonController::respondToChangedSelection): move the interface to the new element, or hide (WebCore::DeleteButtonController::respondToChangedContents): call updateOutlineStyle (WebCore::DeleteButtonController::updateOutlineStyle): resize the outline if the table changed size (WebCore::DeleteButtonController::show): shows the interface on a new element (WebCore::DeleteButtonController::hide): hides the existing interface (WebCore::DeleteButtonController::deleteTarget): deletes the targeted element
• editing/DeleteButtonController.h: Added. (WebCore::DeleteButtonController::target): getter for the current target
• editing/Editor.cpp: (WebCore::Editor::shouldShowDeleteInterface): call the new shouldShowDeleteInterface client function (WebCore::Editor::Editor): remove the manual ref now that we use RefPtr for m_client (WebCore::Editor::~Editor): remove the manual deref now that we use RefPtr for m_client
• editing/Editor.h: (WebCore::Editor::frame): new getter (WebCore::Editor::deleteButtonController): ditto
• editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): notify the DeleteButtonController about the new selection
• html/HTMLImageElement.h: (WebCore::HTMLImageElement::setCachedImage): new setter that replaces the CachedImage
• html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::setImage): ditto
• html/HTMLImageLoader.h:
• loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): new constructor that takes an Image
• loader/CachedImage.h: ditto
• page/Frame.cpp: (WebCore::Frame::selectionController): cleanup coding style (WebCore::Frame::editor): ditto (WebCore::Frame::command): ditto (WebCore::Frame::appliedEditing): tell the delete button outline to update (WebCore::Frame::unappliedEditing): ditto (WebCore::Frame::reappliedEditing): ditto
• rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): workaround until bug 11363 is fixed

WebKit:

Reviewed by Geoff.

<rdar://problem/4478625> HTML Editing: Basic table editing and culling

Initial implementaltion of table deletion user interface:

• Adds a new editing delegate method, webView:shouldShowDeleteInterfaceForElement:.
• The new delegate method is called from the new shouldShowDeleteInterface EditorClient function.

• DefaultDelegates/WebDefaultEditingDelegate.m: (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]):
• WebCoreSupport/WebEditorClient.h:
• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldShowDeleteInterface):
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebEditingDelegatePrivate.h: Added.

11:37 AM Changeset in webkit [17195] by weinig

• 4 edits in trunk/WebCore

Reviewed by Tim H.

Cleanup bindings generation a little through re-factoring
and general style cleanup.

• bindings/scripts/CodeGenerator.pm:
• bindings/scripts/CodeGeneratorJS.pm:
• bindings/scripts/CodeGeneratorObjC.pm:

8:41 AM Changeset in webkit [17194] by weinig

• 4 edits
  2 adds in trunk/WebCore

Reviewed by Mitz.

Fix crashes on Qt/Linux. Offer a default EditorClient and pass it down to Frame ctor.

• CMakeLists.txt:
• platform/qt/EditorClientQt.cpp: Added. (WebCore::EditorClientQt::shouldDeleteRange):
• platform/qt/EditorClientQt.h: Added. (WebCore::EditorClientQt::~EditorClientQt):
• platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt):
• platform/qt/FrameQt.h:

6:34 AM Changeset in webkit [17193] by weinig

• 8 edits in trunk/WebCore

Reviewed by Tim H.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11372
Auto-generate a few more Objective-C DOM methods.

• Auto-generate getMatchedCSSRules and getComputedStyle methods.

• bindings/objc/DOMCSS.h:
• bindings/objc/DOMCSS.mm:
• bindings/objc/DOMExtensions.h:
• bindings/objc/PublicDOMInterfaces.h:
• bindings/scripts/CodeGeneratorObjC.pm:
• dom/Document.idl:
• page/DOMWindow.idl:

3:15 AM Changeset in webkit [17192] by aliceli1

• 3 edits
  1 add in trunk/WebCore

2006-10-21 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by aliu, landed by aliu.

Fix Qt/Linux build.

• CMakeLists.txt:
• platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt):
• platform/qt/SoundQt.cpp: Added. (WebCore::systemBeep):

3:01 AM Changeset in webkit [17191] by aliceli1

• 3 edits in trunk/WebKit

Reviewed by Maciej.

fix leaks.

• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::setWebView): only change webview if its different

• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): actually use the client allocated in the line above instead of allocation again, duh.

2:12 AM Changeset in webkit [17190] by ap

• 2 edits in trunk/WebCore

2006-10-21 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Mitz, landed by ap.

Fix obscure crashes in RenderTableSection on Rob's musicdb file.
The problem was a missing layout() call on the frame view.
Thanks go to Mitz Pettel for the initial hint!

• platform/qt/ScrollViewCanvasQt.cpp: (WebCore::ScrollViewCanvasQt::paintEvent):

1:45 AM Changeset in webkit [17189] by aliceli1

• 3 edits in trunk/WebKit

Build fix.

• WebCoreSupport/WebEditorClient.h:
• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::setWebView):