Context Navigation

Reviewed by Yongjun.
DESC: [S60] Dependencies to SystemSW Internal headers; Browser HttpCacheStreamHandler.cpp
http://bugs.webkit.org/show_bug.cgi?id=11657

ResourceLoader/CacheSrc/HttpCacheStreamHandler.cpp:

12:24 PM Changeset in webkit [17862] by ap

10 edits in trunk

2006-11-20 W. Andy Carrel <wac@google.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=11501
REGRESSION: \u no longer escapes metacharacters in RegExps
http://bugs.webkit.org/show_bug.cgi?id=11502
Serializing RegExps doesn't preserve Unicode escapes

JavaScriptCore:

kjs/lexer.cpp: (Lexer::Lexer): (Lexer::setCode): (Lexer::shift): (Lexer::scanRegExp): Push \u parsing back down into the RegExp object rather than in the parser. This backs out r17354 in favor of a new fix that better matches the behavior of other browsers.

kjs/lexer.h:
kjs/regexp.cpp: (KJS::RegExp::RegExp): (KJS::sanitizePattern): (KJS::isHexDigit): (KJS::convertHex): (KJS::convertUnicode):
kjs/regexp.h: Translate \u escaped unicode characters for the benefit of pcre.

kjs/ustring.cpp: (KJS::UString::append): Fix failure to increment length on the first UChar appended to a UString that was copy-on-write.

tests/mozilla/ecma_2/RegExp/properties-001.js: Adjust tests back to the uniform standards.

LayoutTests:

fast/js/kde/RegExp-expected.txt:
fast/js/regexp-unicode-handling-expected.txt: Adjust these test results to passing as a result of other included changes in this revision.

11:58 AM Changeset in webkit [17861] by bdash

8 edits in trunk

2006-11-20 Samuel Weinig <sam@webkit.org>

Reviewed by Alexey.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11656
Fix Windows build

WebCore.vcproj/WebCore/WebCore.vcproj:
bridge/win/ContextMenuClientWin.h:
bridge/win/EditorClientWin.h:
bridge/win/FrameWin.h:
platform/win/TemporaryLinkStubs.cpp: (WebCore::ContextMenu::show): (WebCore::ContextMenuClientWin::copyLinkToClipboard): (WebCore::ContextMenuClientWin::downloadURL): (WebCore::ContextMenuClientWin::copyImageToClipboard): (WebCore::ContextMenuClientWin::lookUpInDictionary): (WebCore::EditorClientWin::shouldInsertText): (WebCore::FrameLoader::reload): (WebCore::FrameWin::ignoreSpelling): (WebCore::FrameWin::learnSpelling):

2006-11-20 Samuel Weinig <sam@webkit.org>

Reviewed by Alexey.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11656
Fix Windows build

WebKit.vcproj/WebKit.vcproj: don't include directories that no longer exist.

11:56 AM Changeset in webkit [17860] by ap

9 edits in trunk

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=10736
XMLHttpRequest.responseXML should be null on error

WebCore:

dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::wellFormed):
dom/XMLTokenizer.h: (WebCore::Tokenizer::wellFormed):
dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::implicitClose):
dom/Document.h: (WebCore::Document::wellFormed): Tell whether XMLTokenizer saw an error. Always true (success) for HTML.

xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseXML): Set the document to null if it's not well-formed.

LayoutTests:

http/tests/xmlhttprequest/zero-length-response-expected.txt:
http/tests/xmlhttprequest/zero-length-response-sync-expected.txt: Updated the results for the new behavior.

10:59 AM Changeset in webkit [17859] by ap

16 edits
5 adds in trunk

Reviewed by Sam Weinig.

http://bugs.webkit.org/show_bug.cgi?id=11633
Implement XMLDocument properties xmlEncoding, xmlVersion, xmlStandalone

WebCore:

dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::setXMLVersion): (WebCore::Document::setXMLStandalone):
dom/Document.h: (WebCore::Document::xmlEncoding): (WebCore::Document::xmlVersion): (WebCore::Document::xmlStandalone): (WebCore::Document::setXMLEncoding):
dom/Document.idl:
dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startDocument): (WebCore::startDocumentHandler): (WebCore::XMLTokenizer::initializeParserContext): Added support for these properties, getting them from an libxml2 context.

html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument): HTMLDocument is the only kind of document that doesn't have xmlVersion default to "1.0".

bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/CodeGeneratorObjC.pm: Added WK_ucfirst to properly uppercase xmlVersion and xmlStandalone.

LayoutTests:

dom/xhtml/level3/core/documentgetxmlencoding01-expected.txt:
dom/xhtml/level3/core/documentgetxmlencoding03-expected.txt
dom/xhtml/level3/core/documentgetxmlstandalone04-expected.txt:
dom/xhtml/level3/core/documentgetxmlversion01-expected.txt:
dom/xhtml/level3/core/documentgetxmlversion02-expected.txt:
dom/xhtml/level3/core/documentgetxmlversion03-expected.txt: These now pass.

dom/xhtml/level3/core/documentgetxmlencoding03.xhtml: Re-added a correct test.

fast/dom/Window/window-properties-expected.txt: Added these new properties.

http/tests/xmlhttprequest/xml-encoding-expected.txt: Added.
http/tests/xmlhttprequest/xml-encoding.html: Added.
http/tests/xmlhttprequest/resources/xml-encoding.xml: Added.
http/tests/xmlhttprequest/resources/post-echo-as-utf-8.cgi: Added. Test how xmlEncoding interacts with XMLHttpRequest.

8:12 AM Changeset in webkit [17858] by zimmermann

9 edits in trunk/WebCore

Reviewed by Rob.
Fix Qt/Linux build.

7:42 AM Writing Layout Tests for DumpRenderTree edited by mitz@webkit.org

(diff)

5:14 AM Changeset in webkit [17857] by bdash

1 add in trunk/WebCore/platform/graphics/svg/qt/SVGResourceFilterQt.cpp

Qt build fix after r17853: add missing SVGResourceFilterQt.cpp.

4:59 AM Changeset in webkit [17856] by bdash

7 edits in trunk

2006-11-20 Samuel Weinig <sam@webkit.org>

Reviewed by Maciej.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11647
Fix Win32 build

kjs/config.h: define NOMINMAX instead of min/max as themselves.
wtf/Vector.h: put back hack to ensure that min/max are not defined as macros.

2006-11-20 Samuel Weinig <sam@webkit.org>

Reviewed by Maciej.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11647
Fix Win32 build

config.h: add #define NOMINMAX for windows build
platform/win/FontCacheWin.cpp: (WebCore::FontCache::createFontPlatformData):
platform/win/TemporaryLinkStubs.cpp: add definitions for new cursors. (WebCore::aliasCursor): (WebCore::noDropCursor): (WebCore::progressCursor):

2:13 AM Changeset in webkit [22567] by andersca

2 edits in branches/WindowsMerge/WebCore

Add the same include paths to the debug build.

WebCore.vcproj/WebCore.vcproj:

1:42 AM Changeset in webkit [22566] by andersca

2 edits
1 move in branches/WindowsMerge/WebCore

Fix build.

WebCore.vcproj/WebCore.vcproj:
kcanvas/device/quartz/KCanvasFilterQuartz.cpp: Removed.
platform/graphics/svg/cg/SVGResourceFilterCg.cpp: Added. (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::SVGResourceFilter::~SVGResourceFilter): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):

1:39 AM Changeset in webkit [22565] by andersca

3 edits in branches/WindowsMerge/WebKitWin

Fix build.

WebEditorClient.cpp: (WebEditorClient::shouldInsertNode): (WebEditorClient::shouldInsertText):
WebEditorClient.h:

Nov 19, 2006:

10:51 PM TitleIndex edited by pewtermoose@gmail.com

removing spam (diff)

10:51 PM Writing Layout Tests for DumpRenderTree edited by pewtermoose@gmail.com

removing spam (diff)

10:48 PM TracInstall edited by pewtermoose@gmail.com

removing spam (diff)

10:48 PM TracGuide edited by pewtermoose@gmail.com

removing spam (diff)

5:27 PM Changeset in webkit [22564] by bdakin

9 edits in branches/WindowsMerge

WebCore:

Reviewed by Adam.

Boomer part of context menu actions.

bridge/win/FrameWin.h: New spelling functions on Frame.
platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::show): (WebCore::ContextMenu::hide):
platform/win/TemporaryLinkStubs.cpp: New stubs. (FrameWin::ignoreSpelling): (FrameWin::learnSpelling): (FrameLoader::reload):

WebKit:

Reviewed by Adam.

WebContextMenuClient.cpp: Stubs for the currently client- dependent menu actions. (WebContextMenuClient::copyLinkToClipboard): (WebContextMenuClient::downloadURL): (WebContextMenuClient::copyImageToClipboard): (WebContextMenuClient::lookUpInDictionary):
WebContextMenuClient.h:
WebEditorClient.cpp: (WebEditorClient::shouldInsertText): Remove comment markers since this is implemented now on the Mac.
WebEditorClient.h:

5:21 PM Changeset in webkit [17855] by bdakin

24 edits
1 add in trunk

WebCore:

Reviewed by Adam.

Implementation of actions for the new context menus.

WebCore.exp:
WebCore.xcodeproj/project.pbxproj:
bridge/EditorClient.h: Declaration of shouldInsertText.
bridge/mac/FrameMac.h: Two new spelling functions.
bridge/mac/FrameMac.mm: (WebCore::FrameMac::ignoreSpelling): (WebCore::FrameMac::learnSpelling):
editing/Editor.cpp: (WebCore::Editor::shouldInsertText): Call into the client.
editing/Editor.h:
editing/EditorInsertAction.h: Added. (WebCore::): The WebCore equivalent of WebViewInsertAction. This is defined in its own header so that we can use it from Editor.h and EditorClient.h without having one of the above include the other.
page/ContextMenuClient.h: A few currently WebKit-implemented function needed for menu actions.
page/ContextMenuController.cpp: (WebCore::makeGoogleSearchURL): (WebCore::ContextMenuController::contextMenuActionSelected): The actions!
page/ContextMenuController.h:
page/Frame.h: New pure-virtual spelling functions.
platform/ContextMenu.cpp: (WebCore::ContextMenu::controller): Get the controller from the menu.
platform/ContextMenu.h:
platform/mac/ContextMenuMac.mm: (-[MenuTarget forwardContextMenuAction:initWithContextMenuController:WebCore::]): Use the controller instead of the menu (-[MenuTarget WebCore::]): (-[MenuTarget setMenuController:WebCore::]): (-[MenuTarget forwardContextMenuAction:]): (getNSMenuItem): (ContextMenu::show): (ContextMenu::hide):

WebKit:

Reviewed by Adam.

WebKit side of new context menu actions.

WebCoreSupport/WebContextMenuClient.h: These are for the currently-WebKit-dependent menu actions.
WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::copyLinkToClipboard): (WebContextMenuClient::downloadURL): (WebContextMenuClient::copyImageToClipboard): (WebContextMenuClient::searchWithSpotlight): (WebContextMenuClient::lookUpInDictionary):
WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm: (core): These are to convert between WebViewInsertAction and EditorInsertAction. (kit): (WebEditorClient::shouldInsertText): Added implementation for shouldInsertText.
WebKit.xcodeproj/project.pbxproj:
WebView/WebHTMLView.m: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Moved _lookUpInDictionary to be within the implementation of WebHTMLView internal.
WebView/WebHTMLViewInternal.h: Add _lookUpInDictionaryFromMenu
WebView/WebViewInternal.h: Add _searchWithSpotlightFromMenu

2:22 PM Changeset in webkit [17854] by ap

1 edit
3 deletes in trunk/LayoutTests

Removed parts of an incorrectly committed test, to be re-added later.

dom/xhtml/level3/core/documentgetxmlencoding03-expected.png: Removed.
dom/xhtml/level3/core/documentgetxmlencoding03-expected.checksum: Removed.
dom/xhtml/level3/core/documentgetxmlencoding03.xhtml: Removed.

1:25 PM TracGuide edited by asas@asas.com

(diff)

1:25 PM TracInstall edited by asas@asas.com

(diff)

1:24 PM Writing Layout Tests for DumpRenderTree edited by asas@asas.com

(diff)

1:23 PM TitleIndex edited by asas@asas.com

(diff)

12:13 PM Writing Layout Tests for DumpRenderTree edited by mitz@webkit.org

Added GCController (diff)

10:39 AM Changeset in webkit [17853] by staikos

13 edits in trunk

top level:

Reviewed by Zack.

http://bugs.webkit.org/show_bug.cgi?id=11649

CMakeLists.txt: Fix Qt-only build without KDE cmake files

JavaScriptCore:

Reviewed by Zack.

http://bugs.webkit.org/show_bug.cgi?id=11649
Fix CMake Qt-only build without KDE CMake files

CMakeLists.txt:
pcre/CMakeLists.txt:

WebCore:

Reviewed by Zack.

http://bugs.webkit.org/show_bug.cgi?id=11649
Fix CMake files for Qt-only build without KDE cmake files.
Fix Qt/KDE build for the SVG support.
Fix Qt-only build in the resource handler.

CMakeLists.txt:
platform/graphics/svg/qt/SVGResourceFilterQt.cpp: Added. (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::SVGResourceFilter::~SVGResourceFilter): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
platform/network/qt/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::cancel): (WebCore::ResourceHandleManager::slotData): (WebCore::ResourceHandleManager::slotMimetype): (WebCore::ResourceHandleManager::slotResult): (WebCore::ResourceHandleManager::deliverJobData):
platform/network/qt/ResourceHandleManager.h:
platform/network/qt/ResourceHandleQt.cpp:
platform/qt/CursorQt.cpp: (WebCore::noDropCursor): (WebCore::progressCursor): (WebCore::aliasCursor):

WebKitQt:

Reviewed by Zack.

http://bugs.webkit.org/show_bug.cgi?id=11649
Fix Qt-only build

QtLauncher/CMakeLists.txt:

1:12 AM Changeset in webkit [17852] by ap

2 edits
4 adds
1 delete in trunk

2006-11-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=11626 Automate test for rdar://problem/4056100

WebCore:

manual-tests/delete-into-nested-block.html: Removed.

LayoutTests:

fast/repaint/delete-into-nested-block-expected.checksum: Added.
fast/repaint/delete-into-nested-block-expected.png: Added.
fast/repaint/delete-into-nested-block-expected.txt: Added.
fast/repaint/delete-into-nested-block.html: Added.

Nov 18, 2006:

11:20 PM Changeset in webkit [22563] by sfalken

1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

11:18 PM Changeset in webkit [17851] by sfalken

1 copy in tags/Safari-521.31b

New tag.

6:44 PM Changeset in webkit [17850] by zimmermann

59 edits
41 copies
61 adds
6 deletes in trunk/WebCore

Reviewed by Oliver.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11596

Split up KCanvasFilters & KCanvasFilterQuartz into several
new classes (SVGFEBlend, SVGFEComposite...) and move them
into platform/graphics/svg. This is still a temporary location,
as discussed with Darin; the whole platform/graphics/svg directory
will probably be moved into ksvg2/ in near future.

This commit removes the duplicated enumerations in the svg filter
classes and within kcanvas. ksvg2/ and platform/graphics/svg share
their enums now.

4:47 PM Changeset in webkit [17849] by andersca

1 edit
2 adds in trunk/LayoutTests

Reviewed by Darin.

Add tests for crash when garbage collecting node iterators and tree walkers
without a node filter.

fast/dom/node-filter-gc-expected.txt: Added.
fast/dom/node-filter-gc.html: Added.

3:45 PM Changeset in webkit [22562] by aroben

2 edits in branches/WindowsMerge/WebCore

Build fix from OpenSource r17841.

platform/win/CursorWin.cpp: New method stubs. (WebCore::aliasCursor): (WebCore::progressCursor): (WebCore::noDropCursor):

2:59 PM Changeset in webkit [17848] by rwlbuis

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Maciej.

Testcase for:
http://bugs.webkit.org/show_bug.cgi?id=11321
Element with :target pseudo-class still matched after fragment identifier change

fast/css/target-fragment-match-expected.checksum: Added.
fast/css/target-fragment-match-expected.png: Added.
fast/css/target-fragment-match-expected.txt: Added.
fast/css/target-fragment-match.html: Added.

WebCore:

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=11321
Element with :target pseudo-class still matched after fragment identifier change

Make sure the page does a style recalculation and possible rendering
when navigating back from a page with an anchor to a page without
an anchor.

loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor):

12:58 PM Changeset in webkit [17847] by ap

10 edits
2 adds in trunk

2006-11-18 Don Gibson <dgibson77@gmail.com>

Reviewed by Sam Weinig.

http://bugs.webkit.org/show_bug.cgi?id=11634:
Fix segfault on startup for Windows build. Also fix segfault when
typing in a URL.
Clean up some of the style of the patch that landed in r17816.

WebCore:

WebCore.vcproj/WebCore/WebCore.vcproj:
bridge/win/ChromeClientWin.h: (WebCore::ChromeClientWin::~ChromeClientWin): (WebCore::ChromeClientWin::ref): (WebCore::ChromeClientWin::deref):
bridge/win/ContextMenuClientWin.h: (WebCore::ContextMenuClientWin::~ContextMenuClientWin): (WebCore::ContextMenuClientWin::ref): (WebCore::ContextMenuClientWin::deref):
bridge/win/EditorClientWin.h: (WebCore::EditorClientWin::~EditorClientWin): (WebCore::EditorClientWin::ref): (WebCore::EditorClientWin::deref):
bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
bridge/win/FrameWin.h: (WebCore::Win):
loader/win/FrameLoaderClientWin.h: Added. (WebCore::FrameLoaderClientWin::~FrameLoaderClientWin): (WebCore::FrameLoaderClientWin::ref): (WebCore::FrameLoaderClientWin::deref):
platform/win/TemporaryLinkStubs.cpp: (WebCore::ChromeClientWin::createWindow): (WebCore::ChromeClientWin::createModalDialog): (WebCore::EditorClientWin::selectWordBeforeMenuEvent): (WebCore::EditorClientWin::isEditable): (WebCore::EditorClientWin::shouldBeginEditing): (WebCore::EditorClientWin::shouldEndEditing): (WebCore::EditorClientWin::shouldApplyStyle): (WebCore::EditorClientWin::didBeginEditing): (WebCore::EditorClientWin::respondToChangedContents): (WebCore::EditorClientWin::didEndEditing): (WebCore::EditorClientWin::registerCommandForUndo): (WebCore::EditorClientWin::registerCommandForRedo): (WebCore::EditorClientWin::clearUndoRedoOperations): (WebCore::EditorClientWin::canUndo): (WebCore::EditorClientWin::canRedo): (WebCore::EditorClientWin::undo): (WebCore::EditorClientWin::redo): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoaderClientWin::hasWebView): (WebCore::FrameLoaderClientWin::hasFrameView): (WebCore::FrameLoaderClientWin::hasBackForwardList): (WebCore::FrameLoaderClientWin::resetBackForwardList): (WebCore::FrameLoaderClientWin::provisionalItemIsTarget): (WebCore::FrameLoaderClientWin::loadProvisionalItemFromPageCache): (WebCore::FrameLoaderClientWin::invalidateCurrentItemPageCache): (WebCore::FrameLoaderClientWin::privateBrowsingEnabled): (WebCore::FrameLoaderClientWin::makeDocumentView): (WebCore::FrameLoaderClientWin::makeRepresentation): (WebCore::FrameLoaderClientWin::forceLayout): (WebCore::FrameLoaderClientWin::forceLayoutForNonHTML): (WebCore::FrameLoaderClientWin::updateHistoryForCommit): (WebCore::FrameLoaderClientWin::updateHistoryForBackForwardNavigation): (WebCore::FrameLoaderClientWin::updateHistoryForReload): (WebCore::FrameLoaderClientWin::updateHistoryForStandardLoad): (WebCore::FrameLoaderClientWin::updateHistoryForInternalLoad): (WebCore::FrameLoaderClientWin::updateHistoryAfterClientRedirect): (WebCore::FrameLoaderClientWin::setCopiesOnScroll): (WebCore::FrameLoaderClientWin::tokenForLoadErrorReset): (WebCore::FrameLoaderClientWin::resetAfterLoadError): (WebCore::FrameLoaderClientWin::doNotResetAfterLoadError): (WebCore::FrameLoaderClientWin::willCloseDocument): (WebCore::FrameLoaderClientWin::detachedFromParent1): (WebCore::FrameLoaderClientWin::detachedFromParent2): (WebCore::FrameLoaderClientWin::detachedFromParent3): (WebCore::FrameLoaderClientWin::detachedFromParent4): (WebCore::FrameLoaderClientWin::loadedFromPageCache): (WebCore::FrameLoaderClientWin::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientWin::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientWin::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientWin::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientWin::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientWin::dispatchWillClose): (WebCore::FrameLoaderClientWin::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientWin::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientWin::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientWin::dispatchDidCommitLoad): (WebCore::FrameLoaderClientWin::dispatchDidFinishLoad): (WebCore::FrameLoaderClientWin::dispatchDidFirstLayout): (WebCore::FrameLoaderClientWin::dispatchShow): (WebCore::FrameLoaderClientWin::cancelPolicyCheck): (WebCore::FrameLoaderClientWin::dispatchWillSubmitForm): (WebCore::FrameLoaderClientWin::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientWin::clearLoadingFromPageCache): (WebCore::FrameLoaderClientWin::isLoadingFromPageCache): (WebCore::FrameLoaderClientWin::revertToProvisionalState): (WebCore::FrameLoaderClientWin::clearUnarchivingState): (WebCore::FrameLoaderClientWin::progressStarted): (WebCore::FrameLoaderClientWin::progressCompleted): (WebCore::FrameLoaderClientWin::setMainFrameDocumentReady): (WebCore::FrameLoaderClientWin::willChangeTitle): (WebCore::FrameLoaderClientWin::didChangeTitle): (WebCore::FrameLoaderClientWin::finishedLoading): (WebCore::FrameLoaderClientWin::finalSetupForReplace): (WebCore::FrameLoaderClientWin::setDefersLoading): (WebCore::FrameLoaderClientWin::isArchiveLoadPending): (WebCore::FrameLoaderClientWin::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientWin::clearArchivedResources): (WebCore::FrameLoaderClientWin::canShowMIMEType): (WebCore::FrameLoaderClientWin::representationExistsForURLScheme): (WebCore::FrameLoaderClientWin::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientWin::frameLoadCompleted): (WebCore::FrameLoaderClientWin::restoreScrollPositionAndViewState): (WebCore::FrameLoaderClientWin::provisionalLoadStarted): (WebCore::FrameLoaderClientWin::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoaderClientWin::addHistoryItemForFragmentScroll): (WebCore::FrameLoaderClientWin::didFinishLoad): (WebCore::FrameLoaderClientWin::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientWin::setTitle): (WebCore::FrameLoaderClientWin::userAgent):

WebKit:

COM/WebFrame.cpp: (WebFrame::initWithName):

12:19 PM Changeset in webkit [17846] by zbujtas

2 edits in S60/branches/3.1m/WebCore

2006-11-16 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas <zbujtas@gmail.com>.
Merged from 3.2 r17845
DESC: Image map using ID attribute cannot be activated
http://bugs.webkit.org/show_bug.cgi?id=11618

WARNING: NO TEST CASES ADDED OR CHANGED

khtml/html/html_imageimpl.cpp: (HTMLMapElementImpl::parseHTMLAttribute):

12:17 PM Changeset in webkit [17845] by zbujtas

2 edits in S60/trunk/WebCore

2006-11-16 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas <zbujtas@gmail.com>.
DESC: Image map using ID attribute cannot be activated
http://bugs.webkit.org/show_bug.cgi?id=11618

WARNING: NO TEST CASES ADDED OR CHANGED

khtml/html/html_imageimpl.cpp: (HTMLMapElementImpl::parseHTMLAttribute):

11:29 AM Changeset in webkit [17844] by zbujtas

2 edits in S60/trunk/WebCore

2006-11-16 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas (zbujtas@gmail.com).
DESC: Fix for tabbed navigation
http://bugs.webkit.org/show_bug.cgi?id=11619

WARNING: NO TEST CASES ADDED OR CHANGED

kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition):

11:25 AM Changeset in webkit [17843] by zbujtas

2 edits in S60/trunk/WebCore

2006-11-16 shkeller <shaun.keller@nokia.com>

Reviewed by zalan.
DESC: render object of image type was wrongly typecast and move brace so changelog script works
http://bugs.webkit.org/show_bug.cgi?id=11608

WARNING: NO TEST CASES ADDED OR CHANGED

khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::isFocusable): (HTMLObjectElementImpl::getObjectInstance): (HTMLObjectElementImpl::isFocusable):

5:52 AM Changeset in webkit [17842] by ap

5 edits in trunk

Reviewed by Rob (yay!).

http://bugs.webkit.org/show_bug.cgi?id=11640
XMLHttpRequest produces undefined:undefined HTTP authentication

WebCore:

bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Treat undefined credentials as missing ones.

LayoutTests:

http/tests/xmlhttprequest/basic-auth-expected.txt:
http/tests/xmlhttprequest/basic-auth.html: Added tests for undefined.

3:24 AM Nightly Builds edited by mitz@webkit.org

Changed to talk about Safari extensions in general rather than about a … (diff)

3:01 AM Known incompatibilities between open-source WebKit and Safari edited by mitz@webkit.org

Deleted obsolete information. The context menu items are present and … (diff)

2:00 AM Changeset in webkit [17841] by ap

9 edits
3 adds in trunk/WebCore

2006-11-17 Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>

Reviewed by Tim H.

http://bugs.webkit.org/show_bug.cgi?id=11638
[CSS 2.1+3] add support for alias, progress, no-drop and not-allowed cursor styles

Resources/aliasCursor.png: Added.
Resources/noDropCursor.png: Added.
Resources/progressCursor.png: Added.
WebCore.xcodeproj/project.pbxproj:
css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSValueKeywords.in:
manual-tests/cursor.html:
page/EventHandler.cpp: (WebCore::selectCursor):
platform/Cursor.h:
platform/mac/CursorMac.mm: (WebCore::handCursor): (WebCore::aliasCursor): (WebCore::progressCursor): (WebCore::noDropCursor):
rendering/RenderStyle.h: (WebCore::):

1:30 AM Changeset in webkit [17840] by ap

2 edits in trunk/WebKitSite

2006-11-18 Mitz Pettel <mitz@webkit.org>

Reviewed by Maciej.

Gender-neutrality fix.

coding/contributing.html:

1:29 AM Changeset in webkit [17839] by sfalken

2 edits in trunk/WebCore

2006-11-18 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

Properly adjust CFAbsoluteTime to time_t to fix date calculations.

Compare lastModified w/ MAX_TIME_T when setting last modified date
instead of comparing expiration against MAX_TIME_T.

platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::getResourceResponse): Add kCFAbsoluteTimeIntervalSince1970 in assignment

Nov 17, 2006:

9:57 PM Changeset in webkit [17838] by andersca

10 edits in trunk/WebCore

Reviewed by Geoff.

More conversions from DeprecatedValueList to Vector and HashSet.

css/CSSValueList.cpp: (WebCore::CSSValueList::~CSSValueList): (WebCore::CSSValueList::append): (WebCore::CSSValueList::cssText):
css/CSSValueList.h: (WebCore::CSSValueList::length): (WebCore::CSSValueList::item):
dom/Document.cpp: (WebCore::Document::attachNodeIterator): (WebCore::Document::notifyBeforeNodeRemoval):
dom/Document.h:
ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::notifyAttributeChange):
ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::notifyClientsToRepaint):
platform/graphics/svg/SVGResource.cpp: (WebCore::SVGResource::invalidate): (WebCore::SVGResource::addClient):
platform/graphics/svg/SVGResource.h:
rendering/RenderBlock.h:

7:29 PM Changeset in webkit [22561] by andersca

19 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Add #defines in config.h to prevent the min and max macros from being used.

bridge/win/FrameWin.cpp:
config.h:
platform/win/FontCacheWin.cpp: (WebCore::FontCache::createFontPlatformData):
platform/win/PopupMenuWin.cpp:
plugins/win/PluginStreamWin.cpp:
plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handlePost):

WebKitWin:

Reviewed by Adam.

Make sure that all .cpp files and none of the headers include config.h.

MemoryStream.cpp:
WebBackForwardList.cpp:
WebBackForwardList.h:
WebElementPropertyBag.cpp:
WebHTMLRepresentation.cpp:
WebKitClassFactory.cpp:
WebKitDLL.cpp:
WebMutableURLRequest.cpp:
WebMutableURLRequest.h:
WebURLResponse.cpp:
WebURLResponse.h:

7:15 PM Changeset in webkit [17837] by andersca

4 edits in trunk/JavaScriptCore

2006-11-17 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

Make sure that we always use std::min and std::max instead of macros.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
kjs/config.h:
wtf/Vector.h:

7:09 PM Changeset in webkit [22560] by kmccullo

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Fixes Targetted Form Submission to now work. Radar: 4762693

ChangeLog:
loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm):

6:24 PM Changeset in webkit [17836] by thatcher

1 edit in trunk/WebCore/editing/EditCommand.cpp

Fixing the assertion failure, forgot to remove an enable() call.

5:24 PM Changeset in webkit [17835] by thatcher

1 edit
8 copies in tags/Safari-521.31

New tag.

5:21 PM Changeset in webkit [17834] by thatcher

6 edits in /

Versioning

5:06 PM Changeset in webkit [17833] by thatcher

3 edits in trunk/WebCore

Reviewed by Harrison.

<rdar://problem/4796730> table deletion elements are serialized out if they are visible when innerHTML or a Web Archive is made

Disable the delete button controller when cloning nodes, Mail does this before saving a draft.

dom/ContainerNode.cpp: (WebCore::ContainerNode::cloneChildNodes):
editing/markup.cpp: (WebCore::createFragmentFromNodes):

5:04 PM Changeset in webkit [17832] by justing

9 edits
12 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4237467> REGRESSION: Pasting word from quoted text quotes the destination
<rdar://problem/4017358> quoted text is wrong color, when pasted as quotation

Fixed:

editing/pasteboard/merge-end-blockquote-expected.checksum:
editing/pasteboard/merge-end-blockquote-expected.png:
editing/pasteboard/merge-end-blockquote-expected.txt:
editing/pasteboard/merge-end-blockquote.html:

Added:

editing/pasteboard/paste-blockquote-1-expected.checksum: Added.
editing/pasteboard/paste-blockquote-1-expected.png: Added.
editing/pasteboard/paste-blockquote-1-expected.txt: Added.
editing/pasteboard/paste-blockquote-1.html: Added.
editing/pasteboard/paste-blockquote-2-expected.checksum: Added.
editing/pasteboard/paste-blockquote-2-expected.png: Added.
editing/pasteboard/paste-blockquote-2-expected.txt: Added.
editing/pasteboard/paste-blockquote-2.html: Added.
editing/pasteboard/paste-blockquote-3-expected.checksum: Added.
editing/pasteboard/paste-blockquote-3-expected.png: Added.
editing/pasteboard/paste-blockquote-3-expected.txt: Added.
editing/pasteboard/paste-blockquote-3.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4237467> REGRESSION: Pasting word from quoted text quotes the destination
<rdar://problem/4017358> quoted text is wrong color, when pasted as quotation

editing/ReplaceSelectionCommand.cpp: (WebCore::isMailPasteAsQuotationNode): Added. Checks for the node that Mail wraps around an incoming fragment when it wants it to be pasted with quoting (no merging should be done). (WebCore::ReplaceSelectionCommand::removeNodePreservingChildren): Added this virtual method in order to adjust the nodes that ReplaceSelectionCommand tracks. (WebCore::ReplaceSelectionCommand::shouldMerge): Don't merge from content inside a Mail Paste as Quotation node. Allow merging from Mail blockquotes. (WebCore::ReplaceSelectionCommand::removeRedundantStyles): When pasting into a Mail blockquote, we ignore the parts of the source document's default style that are overriden by styles from the Mail blockquote. This is necessary in order for text that's black (because black is the source document's default font color) to appear blue/green/whatever when it's pasted into a Mail blockquote. (WebCore::ReplaceSelectionCommand::handlePasteAsQuotationNode): Turn an inserted Mail Paste as Quotation node into a normal Mail blockquote. This will prevent a copied blockquote that was inserted into the document using Paste as Quotation from triggering Paste as Quotation behavior when it's pasted. (WebCore::ReplaceSelectionCommand::doApply): Call the new/altered methods.
editing/ReplaceSelectionCommand.h:
editing/markup.cpp: (WebCore::styleFromMatchedRulesForElement): Put this code into a subroutine. (WebCore::removeEnclosingMailBlockquoteStyle): Added. (WebCore::startMarkup): When wrapping text nodes in style spans, leave out styles that Mail blockquotes contribute, so that Mail blockquote styles can be differentiated from styles that the user has applied. When creating markup for elements, do the same thing. (WebCore::createMarkup): Call the new subroutine.

4:22 PM Changeset in webkit [17831] by thatcher

1 edit in trunk/WebKit/WebKit.xcodeproj/project.pbxproj

Forgoet the project change.

4:21 PM Changeset in webkit [17830] by thatcher

2 edits in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/4841044> Temporarily default Mail.app editable link clicking behavior, until they do it themselves

WebKit.xcodeproj/project.pbxproj:
WebView/WebView.mm: (+[WebView initialize]): (-[WebView setPreferences:]):

4:04 PM Changeset in webkit [22559] by darin

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adele.

fix leak of Document ref count seen in updateCounterpartURLForRSS

WebScriptObject.h: Changed destructor to be virtual. Without this, when the COM object was released we wouldn't release the underlying WebCore::Node.

12:14 PM Changeset in webkit [17829] by rwlbuis

2 edits in trunk/WebCore

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=11635
Bug 11635: Fix potential issue with non-xslt build

Fix the issue and do style guideline corrections.

11:47 AM Changeset in webkit [17828] by thatcher

3 edits in trunk/WebCore

Reviewed by Harrison.

<rdar://problem/4843131> text entry is slow inside element that has the deletion rectangle around it

Only disable/enable the delete button inside applyCommand() to prevent slowing down typing.
This reintroduces <rdar://problem/4796657> table deletion outline does not always follow the table size as editing occurs inside

editing/EditCommand.cpp: (WebCore::EditCommand::apply): (WebCore::EditCommand::unapply): (WebCore::EditCommand::reapply): (WebCore::applyCommand):
editing/EditCommand.h:

11:42 AM Changeset in webkit [22558] by darin

4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adele.

fix leak of WebView when you close a tab or window

Interfaces/IWebView.idl: Added a close function, like the close method we added to WebView on the Macintosh side.

WebView.h: Added close function.
WebView.cpp: (WebView::close): First cut at implementation of close.

11:23 AM Changeset in webkit [17827] by zimmermann

13 edits
5 adds in trunk

Reviewed by Mitz. Landed by Niko.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11617
Adapt to latest API changes, fixing Qt/Linux build.

11:21 AM Changeset in webkit [17826] by harrison

2 edits in trunk/WebCore

Reviewed by Adele.

<rdar://problem/4799899> Frame::revealSelection() only scrolls the startContainer's layer

Replace an assert with a fixme that refers to this bug.

page/Frame.cpp: (WebCore::Frame::revealSelection):

Nov 16, 2006:

7:04 PM Changeset in webkit [22557] by aroben

2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve, Ada.

Added new WebMenuItemBaseApplicationTag to the WebMenuItemTag enum to
keep WebKit apps from conflicting with WebKit context menu identifiers.

Interfaces/IWebUIDelegate.idl:

6:11 PM Changeset in webkit [17825] by beidson

10 edits
4 adds in trunk

LayoutTests:

Reviewed and landed by Brady

Testcase for:
http://bugs.webkit.org/show_bug.cgi?id=11590
Bug 11590: REGRESSION (r17726-r17742): Wikipedia page intermittently loads but doesn't render

fast/css/import-rule-regression-11590-expected.txt: Added.
fast/css/import-rule-regression-11590.html: Added.
fast/css/resources/imports.css: Added.
fast/css/resources/style.css: Added.

WebCore:

Reviewed and landed by Brady

Fixes http://bugs.webkit.org/show_bug.cgi?id=11590 -
REGRESSION (r17726-r17742): Wikipedia page intermittently loads but doesn't render
Fix the regression by setting m_loadCompleted correctly.

css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::checkLoaded):
dom/Node.h: (WebCore::Node::sheetLoaded):
dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::sheetLoaded):
dom/ProcessingInstruction.h:
html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::sheetLoaded):
html/HTMLLinkElement.h:
html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::sheetLoaded):
html/HTMLStyleElement.h:

5:06 PM Changeset in webkit [17824] by harrison

8 edits
1 add in trunk/WebCore

Reviewed by Beth.

<rdar://problem/4056100> REGRESSION (Tiger): Deleting top part of reply email leaves fails to clear text at end of message

The problem was triggered by the fact that the parent div was changing both
in position and in height. The renderer normally bifurcates its logic for
x-position changes vs height changes.

Call repaintDuringLayoutIfMoved() with old rect (incl. width and height) instead of just the old position.

Test added:

manual-tests/delete-into-nested-block.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::positionNewFloats):
rendering/RenderBox.cpp: (WebCore::RenderBox::repaintDuringLayoutIfMoved):
rendering/RenderBox.h:
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::placeChild):
rendering/RenderObject.cpp: (WebCore::RenderObject::repaintDuringLayoutIfMoved):
rendering/RenderObject.h:
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows):

4:07 PM Changeset in webkit [22556] by adele

1 edit in branches/WindowsMerge/WebCore/ChangeLog

Reviewed by Adam.

Added theme for sider.

rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::sliderTheme): (WebCore::RenderThemeWin::close): (WebCore::RenderThemeWin::determineSliderThumbState): (WebCore::RenderThemeWin::getClassicThemeData): (WebCore::RenderThemeWin::getThemeData): (WebCore::drawControl): (WebCore::RenderThemeWin::paintSliderTrack): (WebCore::RenderThemeWin::paintSliderThumb): (WebCore::RenderThemeWin::adjustSliderThumbSize):
rendering/RenderThemeWin.h:

4:03 PM Changeset in webkit [17823] by adele

7 edits in trunk/WebCore

Reviewed by Adam.

Slider cleanup. Let the theme set the size of the slider thumb.

rendering/RenderSlider.cpp: (WebCore::RenderSlider::setStyle): Moving the thumb's appearance adjustment to createThumbStyle. (WebCore::RenderSlider::createThumbStyle): (WebCore::RenderSlider::layout): Let the theme set the size of the thumb.
rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustSliderThumbSize): Added.
rendering/RenderTheme.h: ditto.
rendering/RenderThemeMac.h: ditto.
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustSliderThumbSize): ditto.

3:34 PM Changeset in webkit [17822] by spadma

3 edits in S60/branches/3.1m/WebKit

2006-11-15 yaharon <yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: [S60] EJXO-6UUCVJ: Browser: The Saved page folder is empty after saving a page.
http://bugs.webkit.org/show_bug.cgi?id=110606

BrowserView/inc/WebKitControl.h:
BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::PageInfoLC): (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::LoadUrlL):

3:27 PM Changeset in webkit [17821] by spadma

3 edits in S60/trunk/WebKit

2006-11-15 yaharon <yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: [S60] EJXO-6UUCVJ: Browser: The Saved page folder is empty after saving a page.
http://bugs.webkit.org/show_bug.cgi?id=110606

BrowserView/inc/WebKitControl.h:
BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::PageInfoLC): (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::LoadUrlL):

3:24 PM Changeset in webkit [17820] by spadma

7 edits in S60/trunk/WebKit

2006-11-16 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: Fix copyright issues
http://bugs.webkit.org/show_bug.cgi?id=11620

BrowserView/inc/WidgetExtension.h:
BrowserView/inc/WidgetPreferences.h:
BrowserView/inc/WidgetRenderer.h:
BrowserView/src/WidgetExtension.cpp:
BrowserView/src/WidgetPreferences.cpp:
BrowserView/src/WidgetRenderer.cpp: (TWidgetRenderer::TWidgetRenderer): (TWidgetRenderer::PrepareForTransitionL): (TWidgetRenderer::PerformTransitionL): (TWidgetRenderer::TransitionCb): (TWidgetRenderer::DrawFadeMaskL): (TWidgetRenderer::DrawTransition):

2:54 PM Changeset in webkit [17819] by spadma

2 edits in S60/trunk/WebKit

2006-11-15 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: Feeds Engine / Form element in feed article: If input box is selected the browser crashes.
http://bugs.webkit.org/show_bug.cgi?id=11603

BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::SetCursorPositionL):

1:22 PM Changeset in webkit [17818] by andersca

19 edits in trunk/WebCore

Reviewed by Darin.

Use Vector instead of DeprecatedValueList in a few places.

bindings/js/kjs_dom.cpp: (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection): (KJS::DOMNamedNodesCollection::lengthGetter): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
bindings/js/kjs_dom.h:
bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::namedItemGetter): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLCollection::getNamedItems):
bindings/objc/DOM.mm:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::dashboardRegionsDictionary):
css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::diff):
html/HTMLCollection.cpp: (WebCore::HTMLCollection::namedItems):
html/HTMLCollection.h:
kcanvas/KCanvasFilters.cpp: (WebCore::KCanvasFilter::externalRepresentation):
kcanvas/KCanvasFilters.h: (WebCore::KCanvasFEColorMatrix::values): (WebCore::KCanvasFEColorMatrix::setValues): (WebCore::KCanvasFEConvolveMatrix::kernel): (WebCore::KCanvasFEConvolveMatrix::setKernel):
kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack): (WebCore::KCanvasFEColorMatrixQuartz::getCIFilter):
ksvg2/svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::filterEffect):
platform/graphics/svg/SVGResourceClipper.h:
platform/graphics/svg/cg/SVGResourceClipperCg.cpp: (WebCore::SVGResourceClipper::applyClip):
platform/network/FormData.h:
rendering/RenderPath.h:
rendering/SVGRenderTreeAsText.h: (WebCore::operator<<):

1:03 PM Changeset in webkit [17817] by andersca

2 edits in trunk/WebCore

Reviewed by Tim.

editing/markup.cpp: (WebCore::createMarkup): Add null-checks for the frame, it might not exist for all documents.

12:32 PM Changeset in webkit [17816] by ap

23 edits
2 adds
1 delete in trunk

2006-11-16 Don Gibson <dgibson77@gmail.com>

Reviewed and landed by ap.

http://bugs.webkit.org/show_bug.cgi?id=11509:
Windows build bustage.

Also reorganizes WebCore.vcproj to add files whose absence wasn't
causing compile errors, but which should have been there, and to
make the include directory ordering (and contents) sane.
Also reorganizes TemporaryLinkStubs.cpp to put headers and
function groups in alphabetical order, and ensure that all functions
in the file call notImplemented().

WebCore:

WebCore.vcproj/WebCore/WebCore.vcproj:
bridge/win/ChromeClientWin.h: (WebCore::ChromeClientWin::ref): (WebCore::ChromeClientWin::deref):
bridge/win/ContextMenuClientWin.h: Added. (WebCore::ContextMenuClientWin::~ContextMenuClientWin): (WebCore::ContextMenuClientWin::ref): (WebCore::ContextMenuClientWin::deref):
bridge/win/EditorClientWin.h:
bridge/win/FrameWin.cpp: (WebCore::FrameWin::~FrameWin): (WebCore::FrameWin::keyPress):
bridge/win/FrameWin.h:
bridge/win/PageWin.cpp: Removed.
editing/EditCommand.h:
loader/FormState.h:
loader/FrameLoader.h:
page/EventHandler.cpp:
platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):
platform/graphics/win/ImageWin.cpp:
platform/network/ResourceError.cpp:
platform/network/ResourceHandleInternal.h:
platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::onRequestRedirected): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel):
platform/win/ScreenWin.cpp: (WebCore::monitorInfo): (WebCore::screenRect): (WebCore::screenAvailableRect): (WebCore::screenDepth):
platform/win/SoundWin.cpp: Added. (WebCore::systemBeep):
platform/win/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::CheckCacheObjectStatus): (WebCore::CheckIfReloading): (WebCore::defaultLanguage): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::findNextSentenceFromIndex): (WebCore::findNextWordFromIndex): (WebCore::findSentenceBoundary): (WebCore::findWordBoundary): (WebCore::focusRingColor): (WebCore::historyContains): (WebCore::inputElementAltText): (WebCore::IsResponseURLEqualToURL): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::moveCursor): (WebCore::verticalTextCursor): (WebCore::refreshPlugins): (WebCore::resetButtonDefaultLabel): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::ResponseURL): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::searchableIndexIntroduction): (WebCore::ServeSynchronousRequest): (WebCore::setFocusRingColorChangeFunction): (WebCore::submitButtonDefaultLabel): (WebCore::CachedResource::setPlatformResponse): (WebCore::CachedResource::setAllData): (WebCore::ChromeClientWin::setWindowRect): (WebCore::ChromeClientWin::windowRect): (WebCore::ChromeClientWin::pageRect): (WebCore::ChromeClientWin::scaleFactor): (WebCore::ChromeClientWin::focus): (WebCore::ChromeClientWin::unfocus): (WebCore::ChromeClientWin::createWindow): (WebCore::ChromeClientWin::createModalDialog): (WebCore::ChromeClientWin::show): (WebCore::ChromeClientWin::canRunModal): (WebCore::ChromeClientWin::runModal): (WebCore::ChromeClientWin::setToolbarsVisible): (WebCore::ChromeClientWin::toolbarsVisible): (WebCore::ChromeClientWin::setStatusbarVisible): (WebCore::ChromeClientWin::statusbarVisible): (WebCore::ChromeClientWin::setScrollbarsVisible): (WebCore::ChromeClientWin::scrollbarsVisible): (WebCore::ChromeClientWin::setMenubarVisible): (WebCore::ChromeClientWin::menubarVisible): (WebCore::ChromeClientWin::setResizable): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenuClientWin::addCustomContextMenuItems): (WebCore::DocumentLoader::setFrame): (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setLoading): (WebCore::DocumentLoader::updateLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::isLoadingInAPISense): (WebCore::DocumentLoader::stopRecordingResponses): (WebCore::EditorClientWin::shouldDeleteRange): (WebCore::EditorClientWin::shouldShowDeleteInterface): (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled): (WebCore::EditorClientWin::isGrammarCheckingEnabled): (WebCore::EditorClientWin::spellCheckerDocumentTag): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::handleMouseUp): (WebCore::EventHandler::lastEventIsMouseUp): (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passWheelEventToSubframe): (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::passMousePressEventToScrollbar): (WebCore::EventHandler::shouldDragAutoNode): (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::tabsToLinks): (WebCore::Frame::setNeedsReapplyStyles): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::overrideMediaType): (WebCore::FrameLoader::createJavaAppletWidget): (WebCore::FrameLoader::redirectDataToPlugin): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::setTitle): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::saveDocumentState): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::goBackOrForward): (WebCore::FrameLoader::historyURL): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::partClearedInBegin): (WebCore::FrameLoader::originalRequestURL): (WebCore::FrameLoader::canGoBackOrForward): (WebCore::FrameLoader::objectContentType): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameView::updateBorder): (WebCore::FrameWin::bindingRootObject): (WebCore::FrameWin::canPaste): (WebCore::FrameWin::issuePasteAndMatchStyleCommand): (WebCore::FrameWin::markedTextRange): (WebCore::FrameWin::passSubframeEventToSubframe): (WebCore::FrameWin::lastEventIsMouseUp): (WebCore::FrameWin::addMessageToConsole): (WebCore::FrameWin::shouldChangeSelection): (WebCore::FrameWin::respondToChangedSelection): (WebCore::FrameWin::clearUndoRedoOperations): (WebCore::FrameWin::markMisspellingsInAdjacentWords): (WebCore::FrameWin::respondToChangedContents): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setLineWidth): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale): (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile): (WebCore::Icon::paint): (WebCore::IconDatabase::isIconExpiredForIconURL): (WebCore::IconDatabase::hasEntryForIconURL): (WebCore::IconDatabase::sharedIconDatabase): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::setIconDataForIconURL): (WebCore::Image::drawTiled): (WebCore::Image::getHBITMAP): (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::contains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::operator=): (WebCore::Path::clear): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::transform): (WebCore::PlatformMouseEvent::PlatformMouseEvent): (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::~PlatformScrollbar): (WebCore::PlatformScrollbar::width): (WebCore::PlatformScrollbar::height): (WebCore::PlatformScrollbar::setEnabled): (WebCore::PlatformScrollbar::paint): (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion): (WebCore::PlatformScrollbar::setRect): (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex): (WebCore::PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::PolicyCheck::PolicyCheck): (WebCore::PolicyCheck::clear): (WebCore::PolicyCheck::clearRequest): (WebCore::PolicyCheck::call): (WebCore::RenderThemeWin::systemFont): (WebCore::RenderThemeWin::paintMenuList): (WebCore::RenderThemeWin::adjustMenuListStyle): (WebCore::ResourceLoader::cancel): (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild): (WebCore::ScrollView::scrollPointRecursively): (WebCore::ScrollView::inWindow): (WebCore::ScrollView::paint): (WebCore::ScrollView::wheelEvent): (WebCore::ScrollView::themeChanged): (WebCore::ScrollView::convertChildToSelf): (WebCore::ScrollView::convertSelfToChild): (WebCore::ScrollView::geometryChanged): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::setFrameGeometry): (WebCore::ScrollView::windowResizerRect): (WebCore::ScrollView::resizerOverlapsContent): (WebCore::TextField::selectAll): (WebCore::TextField::addSearchResult): (WebCore::TextField::selectionStart): (WebCore::TextField::hasSelectedText): (WebCore::TextField::selectedText): (WebCore::TextField::setAutoSaveName): (WebCore::TextField::checksDescendantsForFocus): (WebCore::TextField::setSelection): (WebCore::TextField::setMaxResults): (WebCore::TextField::edited): (WebCore::TextField::focusPolicy): (WebCore::TextField::TextField): (WebCore::TextField::~TextField): (WebCore::TextField::setFont): (WebCore::TextField::setAlignment): (WebCore::TextField::setWritingDirection): (WebCore::TextField::maxLength): (WebCore::TextField::setMaxLength): (WebCore::TextField::text): (WebCore::TextField::setText): (WebCore::TextField::cursorPosition): (WebCore::TextField::setCursorPosition): (WebCore::TextField::setEdited): (WebCore::TextField::setReadOnly): (WebCore::TextField::setPlaceholderString): (WebCore::TextField::setColors): (WebCore::TextField::sizeForCharacterWidth): (WebCore::TextField::baselinePosition): (WebCore::TextField::setLiveSearch): (WebCore::Widget::enableFlushDrawing): (WebCore::Widget::isEnabled): (WebCore::Widget::focusPolicy): (WebCore::Widget::disableFlushDrawing): (WebCore::Widget::removeFromParent): (WebCore::Widget::lockDrawingFocus): (WebCore::Widget::unlockDrawingFocus): (WebCore::Widget::capturingMouse): (WebCore::Widget::setCapturingMouse): (WebCore::Widget::capturingTarget): (WebCore::Widget::capturingChild): (WebCore::Widget::setCapturingChild): (WebCore::Widget::convertChildToSelf): (WebCore::Widget::convertSelfToChild): (WebCore::Widget::setParent): (WebCore::Widget::parent): (WebCore::Widget::setEnabled): (WebCore::Widget::paint): (WebCore::Widget::setIsSelected): (WebCore::Widget::invalidate): (WebCore::Widget::invalidateRect):
platform/win/WidgetWin.cpp: (WebCore::Widget::clearFocus):

WebKit:

COM/WebFrame.cpp: (WebFrame::initWithName): (WebFrame::loadHTMLString): (WebFrame::stopLoading): (WebFrame::reload): (WebFrame::loadDataSource): (WebFrame::didReceiveData): (WebFrame::receivedResponse): (WebFrame::receivedAllData):
COM/WebFrame.h:
COM/WebView.cpp: (WebView::mouseMoved): (WebView::mouseDown): (WebView::mouseUp): (WebView::mouseDoubleClick):
WebKit.vcproj/WebKit.vcproj:

11:58 AM Changeset in webkit [17815] by thatcher

2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/4796730> table deletion elements are serialized out if they are visible when innerHTML or a Web Archive is made

editing/markup.cpp: (WebCore::createMarkup): disable the delete button so it's elements are not serialized into the markup

11:52 AM Changeset in webkit [17814] by staikos

3 edits in trunk/WebCore

Rubberstamped by Maciej.

Making the code valgrind clean.

11:49 AM Changeset in webkit [17813] by andersca

2 edits in trunk/WebKit

Reviewed by Tim.

<rdar://problem/4841123>
REGRESSION: Crash in WebCore::Range::boundaryPointsValid when replying to a mail Message

Misc/WebNSAttributedStringExtras.m: (+[NSAttributedString _web_attributedStringFromRange:]): If the range passed in is null, return null. When this function was in the bridge, it would never get called with a null range when nothing was selected. Instead, the range would just have invalid boundary points.

10:35 AM Changeset in webkit [17812] by thatcher

1 edit in trunk/WebCore/editing/DeleteButtonController.h

Adding back a correct version of this assert.

9:59 AM Changeset in webkit [17811] by harrison

2 edits in trunk/WebCore

Reviewed by Darin and Tim.

<rdar://problem/4799949> REGRESSION: Crash in FrameMac::eventMayStartDrag() by clicking on a page

page/mac/EventHandlerMac.mm: (WebCore::EventHandler::eventMayStartDrag): Add nil check of hitTest's result.innerNode().

9:52 AM Changeset in webkit [17810] by thatcher

2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4836897> Deletion rectangle disappears when multiple list items are selected

Consider the container of the selection range for deletion before asking enclosingNodeOfType().

editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableElement):

9:09 AM Changeset in webkit [17809] by spadma

6 edits in S60/branches/3.1m/WebKit

2006-11-16 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: [S60] Modify Autoload Images and Objects setting to include enabling/disabling of flash.
http://bugs.webkit.org/show_bug.cgi?id=11605

BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
BrowserView/inc/BrowserSettingsContainer.h:
BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
BrowserView/src/WebKitControl.cpp: (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL):

12:43 AM Changeset in webkit [17808] by rwlbuis

3 edits in trunk/WebCore

Reviewed by hyatt.

Removal of unused m_styleElement.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed