Timeline



Dec 2, 2006:

6:48 AM Changeset in webkit [17987] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Tim Omernick

Removed a couple of big chunks of duplicated code from the spelling and grammar stuff by merging
the find-next-instance functions with the mark-all-instances functions.

  • bridge/mac/FrameMac.mm: (WebCore::findFirstMisspellingInRange): added markAll parameter, and reworked loop so that if markAll parameter is true, this function loops through the entire range and marks each misspelling (WebCore::findFirstGrammarDetailInRange): extracted from findFirstBadGrammarInRange; loops through the potentially-multiple details in a given ungrammatical phrase (e.g., multiple grammar errors in one sentence). Has a markAll parameter akin to the one in findFirstMisspellingInRange. (WebCore::findFirstBadGrammarInRange): added markAll parameter like the one in findFirstMisspellingInRange, and extracted findFirstGrammarDetailInRange (WebCore::FrameMac::advanceToNextMisspelling): pass "false" for new markAll parameters (WebCore::markAllMisspellingsInRange): now just calls findFirstMisspellingInRange with markAll = true, thus removing a big hunk of duplicated code (WebCore::markAllBadGrammarInRange): now just calls findFirstBadGrammarInRange with markAll = true, thus removing a big hunk of duplicated code
6:02 AM Changeset in webkit [17986] by ap
  • 3 edits
    4 adds in trunk

2006-12-02 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Test: fast/dynamic/containing-block-change.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Changed the logic used to find absolutely positioned descendant's current containing block to match the changes made to containingBlock() in the fix for bug 9347.
5:41 AM Changeset in webkit [17985] by ap
  • 3 edits in trunk/WebCore

2006-12-02 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11709
DeprecatedString::format is broken on Windows

Use _vscprintf on Windows to compute the length of the buffer that
vsnprintf would need.

  • platform/DeprecatedString.cpp: (WebCore::DeprecatedString::format):
  • platform/String.cpp: (WebCore::String::format):

Dec 1, 2006:

6:52 PM Changeset in webkit [22606] by bdakin
  • 7 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Support for sub-menus in WebCore context menus. Also some
adjustments to make ContextMenuItem class a wrapper for the
platformDescription. (In this case, a wrapper for LPMENUITEMINFO.)

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::platformDescription): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setSubMenu):
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::insertItem):

WebKitWin:

Reviewed by Adam.

Changes to support sub-menus for WebCore ContextMenus.

  • Interfaces/IWebUIDelegate.idl: New tags.
  • WebContextMenuClient.cpp: (WebContextMenuClient::contextMenuItemSelected): ContextMenu::menu () is now called parentMenu()
6:35 PM Changeset in webkit [17984] by bdakin
  • 12 edits
    1 add in trunk

WebCore:

Reviewed by Adam.

Support for sub-menus in WebCore context menus. This also re-
architects the ContextMenuItem class so that it is more like
ContextMenu in that the class is now really just a wrapper for the
platformDescription

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Add place-holders for new tags for the sub-menu items. I will flesh these out in a separate check-in.
  • platform/ContextMenu.cpp: (WebCore::createFontSubMenu): (WebCore::createSpellingAndGrammarSubMenu): (WebCore::createSpellingSubMenu): (WebCore::createSpeechSubMenu): (WebCore::createWritingDirectionSubMenu): (WebCore::ContextMenu::populate): Call the above functions to add the appropriate sub-menus to editing context menus.
  • platform/ContextMenu.h:
  • platform/ContextMenuItem.h: (WebCore::): New tags in the ContextMenuAction enumeration. (WebCore::ContextMenuItem::parentMenu): (WebCore::ContextMenuItem::setType):
  • platform/PlatformMenuDescription.h: Added. This defines PlatformMenuDesciption. It needs to be its own header because we

have to include it from ContextMenu.h and ContextMenuItem.h

  • platform/mac/ContextMenuItemMac.mm: Lots of adjustments here to make this class basically just be a wrapper for NSMenuItem. (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): (WebCore::ContextMenuItem::platformDescription): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setSubMenu):
  • platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::ContextMenu): (WebCore::getNSMenuItem): Now we only have to get the platformDescription of the ContextMenuItem and then set its target and action. (WebCore::ContextMenu::itemCount):

WebKit:

Reviewed by Adam.

Changes to support sub-menus in WebCore ContextMenus.

  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuItemSelected): ContextMenuItem::menu() is now called parentMenu()
  • WebView/WebUIDelegatePrivate.h: New not-yet-API tags.
4:36 PM Changeset in webkit [17983] by kmccullo
  • 2 edits in trunk/WebCore

Reviewed by .

  • accidentally checked in with previous checkin
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::keyEvent):
4:23 PM Changeset in webkit [17982] by kmccullo
  • 5 edits in trunk/WebCore

Reviewed by Adam.

  • better solution to the ambiguous reference
  • platform/Widget.h: (WebCore::Widget::handleMouseMoveEvent): (WebCore::Widget::handleMouseReleaseEvent):
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::keyEvent):
  • platform/win/PlatformScrollBar.h:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::PlatformScrollbar::handleMouseMoveEvent): (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
3:40 PM Changeset in webkit [17981] by justing
  • 58 edits in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4826940>
Selection change performed even when delete delegate replies NO (11415)

Removed unnecessary shouldChangeSelection calls;

  • editing/deleting/delete-at-start-or-end-expected.txt:
  • editing/deleting/delete-br-002-expected.txt:
  • editing/deleting/delete-br-004-expected.txt:
  • editing/deleting/delete-br-005-expected.txt:
  • editing/deleting/delete-br-006-expected.txt:
  • editing/deleting/delete-br-009-expected.txt:
  • editing/deleting/delete-br-010-expected.txt:
  • editing/deleting/delete-br-012-expected.txt:
  • editing/deleting/delete-hr-expected.txt:
  • editing/deleting/delete-tab-004-expected.txt:
  • editing/deleting/forward-delete-expected.txt:
  • editing/deleting/merge-into-empty-block-1-expected.txt:
  • editing/deleting/merge-into-empty-block-2-expected.txt:
  • editing/execCommand/format-block-expected.txt:
  • editing/execCommand/outdent-selection-expected.txt:
  • editing/inserting/editing-empty-divs-expected.txt:
  • editing/inserting/insert-3800346-fix-expected.txt:
  • editing/inserting/insert-br-004-expected.txt:
  • editing/inserting/insert-br-005-expected.txt:
  • editing/inserting/insert-br-006-expected.txt:
  • editing/inserting/insert-br-008-expected.txt:
  • editing/inserting/insert-div-006-expected.txt:
  • editing/inserting/insert-div-008-expected.txt:
  • editing/inserting/insert-div-010-expected.txt:
  • editing/inserting/insert-div-011-expected.txt:
  • editing/inserting/insert-div-013-expected.txt:
  • editing/inserting/insert-div-015-expected.txt:
  • editing/inserting/insert-div-019-expected.txt:
  • editing/inserting/insert-div-021-expected.txt:
  • editing/inserting/insert-paragraph-01-expected.txt:
  • editing/inserting/insert-paragraph-03-expected.txt:
  • editing/inserting/insert-tab-004-expected.txt:
  • editing/inserting/insert-text-with-newlines-expected.txt:
  • editing/inserting/line-break-expected.txt:
  • editing/pasteboard/3976872-expected.txt:
  • editing/pasteboard/paste-text-005-expected.txt:
  • editing/pasteboard/paste-text-006-expected.txt:
  • editing/pasteboard/paste-text-007-expected.txt:
  • editing/pasteboard/paste-text-010-expected.txt:
  • editing/pasteboard/paste-text-014-expected.txt:
  • editing/pasteboard/paste-text-016-expected.txt:
  • editing/pasteboard/quirks-mode-br-2-expected.txt:
  • editing/style/apple-style-editable-mix-expected.txt:
  • editing/style/block-style-001-expected.txt:
  • editing/style/block-style-002-expected.txt:
  • editing/style/block-style-003-expected.txt:
  • editing/style/block-style-006-expected.txt:
  • editing/style/create-block-for-style-005-expected.txt:
  • editing/style/create-block-for-style-006-expected.txt:
  • editing/style/create-block-for-style-008-expected.txt:
  • editing/style/relative-font-size-change-002-expected.txt:
  • editing/style/relative-font-size-change-003-expected.txt:
  • editing/style/relative-font-size-change-004-expected.txt:
  • editing/style/table-selection-expected.txt:

WebCore:

Reviewed by john


<rdar://problem/4826940>
Selection change performed even when delete delegate replies NO (11415)

No layout test for the bug fix, because there's no way to register a custom
editing delegate from a layout test. Layout tests are effected by the change
to avoid sending unnecessary shouldChangeSelections, however.

  • editing/Editor.cpp: (WebCore::Editor::appliedEditing): Don't bother sending shouldChangeSelection if the editing operation didn't change the selection. Still call setSelection though, because it does work in this case that's necessary, like clearing the typing style. (WebCore::Editor::unappliedEditing): Ditto. (WebCore::Editor::reappliedEditing): Ditto.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Don't set the starting selection if the editing delegate returns NO from shouldDeleteRange. Notice we now call setStartingSelection in the case where the current selection was a range selection. This is fine because it's a no-op (the starting selection is already the current selection). (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
3:32 PM Changeset in webkit [17980] by sullivan
  • 4 edits in trunk/WebCore

Reviewed by Darin


Move subrange helper function from spellchecking code to TextIterator

  • editing/TextIterator.h: added TextIterator::subrange
  • editing/TextIterator.cpp: (WebCore::CharacterIterator::advance): early return if count is <= 0; assert that it's not < 0 (WebCore::TextIterator::subrange): new function, moved from FrameMac.mmm
  • bridge/mac/FrameMac.mm: moved subrange() function to TextIterator (WebCore::FrameMac::advanceToNextMisspelling): use TextIterator::subrange (WebCore::markAllMisspellingsInRange): ditto (WebCore::markAllBadGrammarInRange): ditto
2:53 PM Changeset in webkit [17979] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-004/JavaScriptCore

Tag for JavaScriptCore for Security Update 2006-004 (unchanged from 10.4.7).

2:52 PM Changeset in webkit [17978] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-004/JavaScriptGlue

Tag for JavaScriptGlue for Security Update 2006-004 (unchanged from 10.4.7).

2:51 PM Changeset in webkit [17977] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-004/WebKit

Tag for WebKit for Security Update 2006-004 (unchanged from 10.4.7).

2:46 PM Changeset in webkit [17976] by darin
  • 31 edits
    1 delete in trunk

WebCore:

Reviewed by Mitz.

I couldn't think of an easy way to make a regression test for this, but maybe
I'll get an idea later about how to do it.

The main thing I did was add a concept of a DOM event having an "underlying event".
That allows the DOM activate event to contain inside it the original keyboard event
that triggered the form submission, and thus allows WebKit to see the modifier keys
from that original event. The code that uses the underlying event is in WebKit, but
the code to set it up is here in WebCore.

  • also do some clean-up to related event handling code
  • bindings/js/kjs_events.cpp: (KJS::DOMEvent::getValueProperty): Updated for the name change of cancelBubble.
  • dom/Event.h: Removed a useless comment. Fixed some whitespace and formatting. Renamed getCancelBubble to cancelBubble to match the DOM -- I suspect the old name predated the use of the m_ prefix on data members. Added the underlying event, and a getter and setter.
  • dom/Event.cpp: (WebCore::Event::setTarget): Updated to take a PassRefPtr. (WebCore::Event::setUnderlyingEvent): Added.
  • dom/EventTargetNode.h: Added an optional underlyingEvent parameter to dispatchUIEvent, one of the overloads of dispatchMouseEvent, and dispatchSimulatedMouseEvent. Added a new dispatchSimulatedClick function here that mostly replaces the click function in HTMLElement.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent): Updated for the name change of cancelBubble. (WebCore::EventTargetNode::dispatchUIEvent): Added an underlying event parameter, which gets attached to the UIEvent object after it's created. (WebCore::EventTargetNode::dispatchMouseEvent): Tweaked formatting and parameter name for the version that creates a mouse event for a real platform mouse event. Added an underlying event parameter to the main version, and attached it to all three of the events that can be dispatched. (WebCore::EventTargetNode::dispatchSimulatedMouseEvent): Added an underlying event parameter, passed it along to dispatchMouseEvent. (WebCore::EventTargetNode::dispatchSimulatedClick): Moved this here from HTMLElement and renamed it from click. Added an underlyingEvent parameter, and passed that along in all three of the calls to dispatchSimulatedMouseEvent.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::shouldClose): Updated call to setTarget that no longer needs a get().
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible): Ditto.
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Converted a call to click to a call to dispatchSimulatedClick. (WebCore::HTMLAnchorElement::accessKeyAction): Ditto.
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::accessKeyAction): Ditto.
  • html/HTMLElement.h: Removed the parameters to click and made it non-virtual. We could move it down to the input and button elements, now that it's just a single function call, but it's also OK to just leave it here.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::click): Removed the parameters and changed this to just call dispatchSimulatedClick. The real work is now in dispatchSimulatedClick. (WebCore::HTMLElement::accessKeyAction): Converted a call to click to a call to dispatchSimulatedClick.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submitClick): Ditto. But unlike accessKeyAction callers, pass the event along as the underlying event.
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.cpp: Removed override of virtual click function. The special cases for the file control and hidden input elements aren't needed. (WebCore::HTMLInputElement::accessKeyAction): Converted a call to click to a call to dispatchSimulatedClick. (WebCore::HTMLInputElement::defaultEventHandler): Converted calls to click to calls to dispatchSimulatedClick, passing along the event as the underlying event.
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::defaultEventHandler): Converted a call to click to a call to dispatchSimulatedClick, passing the event along as the underlying event. Also changed the local variable for the element to a RefPtr since the code assumes it's still around after calling arbitrary JavaScript code.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::accessKeyAction): Converted a call to click to a call to dispatchSimulatedClick.
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click): Removed unneeded ignored parameter to the click function, and also made it non-virtual.
  • loader/NavigationAction.h: Removed unneeded includes.
  • loader/NavigationAction.cpp: Moved all the code here from NavigationActionMac.mm, since none of it is Mac-specific any more.
  • loader/mac/NavigationActionMac.mm: Removed.
  • WebCore.xcodeproj/project.pbxproj: Updated for removed file.
  • ksvg2/svg/SVGAElement.cpp: Removed an unnecessary include.
  • loader/FrameLoader.cpp: Added a newly-needed incluude.
  • loader/mac/DocumentLoaderMac.mm: Ditto.
  • loader/mac/FrameLoaderMac.mm: Ditto.
  • rendering/RenderWidget.cpp: Ditto.

WebKit:

Reviewed by Mitz.

  • WebCoreSupport/WebFrameLoaderClient.mm: (findKeyStateEvent): Added. Helper that finds the mouse or keyboard event in a chain of events and their underlying events. (findMouseEvent): Added. Same, but specifically for mouse events. (WebFrameLoaderClient::actionDictionary): Rewrote to use the above functions. This means we use the modifiers from the underlying events rather than just the one from the event itself. So if the event is a DOM activate event, we can still see the modifiers from the original keyboard event that triggered it. Has no effect if the event is already the right type or if there is no underlying event.
  • WebView/WebFrame.mm: Added a newly-needed include.
  • WebKit.xcodeproj/project.pbxproj: Xcode wants what it wants.
2:44 PM Changeset in webkit [17975] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-004/WebCore

Tag for WebCore for Security Update 2006-004.

2:43 PM Changeset in webkit [17974] by thatcher
  • 1 add in releases/Apple/Tiger/Security Update 2006-004

New tag for Security Update 2006-004

2:33 PM Changeset in webkit [17973] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-007/WebKit

Tag for WebKit for Security Update 2006-007.

2:31 PM Changeset in webkit [17972] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-007/WebCore

Tag for WebCore for Security Update 2006-007 (unchanged from 10.4.8).

2:30 PM Changeset in webkit [17971] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-007/JavaScriptGlue

Tag for JavaScriptGlue for Security Update 2006-007 (unchanged from 10.4.8).

2:29 PM Changeset in webkit [17970] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-007/JavaScriptCore

Tag for JavaScriptCore for Security Update 2006-007 (unchanged from 10.4.8).

2:28 PM Changeset in webkit [17969] by thatcher
  • 1 add in releases/Apple/Tiger/Security Update 2006-007

New tag for Security Update 2006-007

2:12 PM Changeset in webkit [17968] by sullivan
  • 3 edits in trunk/WebCore

Reviewed by Darin

  • fixed <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient context passed to grammar checker
  • bridge/mac/FrameMac.mm: (WebCore::markAllMisspellingsInRange): new function, extracted from markMisspellings -- ignores grammar (WebCore::markAllBadGrammarInRange): new function, extracted from markMisspellings -- ignores spelling, and operates on appropriately-sized chunks of text (WebCore::FrameMac::markMisspellings): now calls markAllMisspellingsInRange and (optionally) markAllBadGrammarInRange rather than trying to interweave the spelling and grammar logic
1:31 PM Changeset in webkit [17967] by sullivan
  • 1 edit in trunk/WebCore/ChangeLog

Removed stray conflict marker.

1:25 PM Changeset in webkit [17966] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin

With these changes, grammar checking works correctly for the one-by-one case.
It still doesn't work correctly for the check-as-you-type case; I need to make these
same kinds of changes in markMisspellings, and refactor to share more code between
the two cases, but I wanted to get this working code in before modifying it further.

The major change here is that advanceToNextMisspelling used to look at small chunks of
text at a time, checking each one for both misspellings and questionable grammar. But
grammar checking needs at least paragraph-sized chunks of text to have enough context
to work correctly, so the old mechanism was causing many spurious complaints of bad
grammar (e.g., almost every word seemed to be at the start of a sentence so the checker
would complain about missing capitalization). So now the spell checker runs in the
specified range first. Then the grammar checker runs on the same range (stopping at the
next misspelling, if any), but expanded to paragraph-aligned boundaries.

  • bridge/mac/FrameMac.mm: (WebCore::findFirstMisspellingInRange): new function, extracted from advanceToNextMisspelling, and ignores grammar (WebCore::paragraphAlignedRangeForRange): new function, used by findNextBadGrammarInRange (WebCore::findFirstBadGrammarInRange): new function, extracted from advanceToNextMisspelling, and rewritten to use paragraph-aligned chunks, and ignores spelling (WebCore::subrange): new helper function, used by advanceToNextMisspelling (WebCore::FrameMac::advanceToNextMisspelling): now calls out to both findFirstMisspellingInRange and findFirstBadGrammarInRange separately instead of trying to interweave the spelling and grammar logic
1:21 PM Changeset in webkit [17965] by rwlbuis
  • 14 edits in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11732:
Windows build bustage.

1:11 PM Changeset in webkit [17964] by yongjzha
  • 4 edits in S60/branches/3.1m/WebKit

2006-11-30 yaharon <​yael.aharon@nokia.com>

Reviewed by Yongjun <​yongjun.zhang@nokia.com>
DESC: [S60] JKRL-6VDTV8: browser crash on empty cache data when loading aborted
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11727

  • BrowserControl/inc/BrCtl.h:
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::CBrCtl): (CBrCtl::HandleBrowserLoadEventL): (CBrCtl::HandleCommandL): (CBrCtl::UpdateLoadState): (CBrCtl::UnloadDllWmlEngine):
  • BrowserView/src/LoadListeners.cpp: (CWmlResourceLoadListener::ResponseL): (CWmlResourceLoadListener::Complete):
1:06 PM Changeset in webkit [17963] by yongjzha
  • 4 edits in S60/trunk/WebKit

2006-11-30 yaharon <​yael.aharon@nokia.com>

Reviewed by Yongjun <​yongju.zhang@nokia.com>
DESC: [S60] JKRL-6VDTV8: browser crash on empty cache data when loading aborted
​http://bugs.webkit.org/show_bug.cgi?id=11727

  • BrowserControl/inc/BrCtl.h: (CBrCtl::HttpLoaderEventToUi):
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::CBrCtl): (CBrCtl::HandleBrowserLoadEventL): (CBrCtl::HandleCommandL): (CBrCtl::UpdateLoadState): (CBrCtl::UnloadDllWmlEngine):
  • BrowserView/src/LoadListeners.cpp: (CWmlResourceLoadListener::ResponseL): (CWmlResourceLoadListener::Complete):
11:08 AM Changeset in webkit [22605] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-12-01 Steve Falkenburg <​sfalken@apple.com>

Fix post-build step.
Need to copy CoreFoundation resources.
Bundles aren't config specific - removed ConfigSuffix from copy commands for resources.

  • WebKit.vcproj\WebKit.vcproj:
10:44 AM Changeset in webkit [17962] by thatcher
  • 4 edits
    1 add in trunk/WebKit

Reviewed by Adam.

<rdar://problem/4841432> 9A312: iWeb crashes on launch; _WebReportError missing from WebKit

Added back WebReportAssertionFailure and WebReportError for apps that still need these symbols.

  • Misc/OldWebAssertions.c: Added. (WebReportAssertionFailure): (WebReportError):
  • WebKit.LP64.exp: added the new symbols, and sorted the file
  • WebKit.exp: added the new symbols, and sorted the file
  • WebKit.xcodeproj/project.pbxproj:
10:34 AM Changeset in webkit [17961] by thatcher
  • 2 edits in trunk/WebKit/Misc

Correcting the copyright date since these are new files.

Nov 30, 2006:

11:28 PM Changeset in webkit [22604] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

11:22 PM Changeset in webkit [17960] by sfalken
  • 1 copy in tags/Safari-521.31.4

New tag.

10:35 PM Changeset in webkit [22603] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-30 Steve Falkenburg <​sfalken@apple.com>

Fix build.
Link against new WTF.lib

  • WebKit.vcproj/WebKit.vcproj:
9:42 PM Changeset in webkit [17959] by sfalken
  • 4 edits
    2 adds in trunk/JavaScriptCore

2006-11-30 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Oliver.


Move WTF from JavaScriptCore project into a new WTF project.

8:23 PM Changeset in webkit [22602] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Rubber Stamped by Anders Carlsson.

Global rename of Document::focusNode to Document::focusedNode. 'focusNode'
suggested a command, and conflicted with a different meaning for 'focusNode'
in the Mozilla selection API.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyEvent):
8:15 PM Changeset in webkit [17958] by ggaren
  • 24 edits in trunk

WebCore:

Rubber Stamped by Anders Carlsson.

Global rename of Document::focusNode to Document::focusedNode. 'focusNode'
suggested a command, and conflicted with a different meaning for 'focusNode'
in the Mozilla selection API.

WebKit:

Rubber Stamped by Anders Carlsson.

Global rename of Document::focusNode to Document::focusedNode. 'focusNode'
suggested a command, and conflicted with a different meaning for 'focusNode'
in the Mozilla selection API.

  • WebView/WebHTMLView.m: (-[NSArray clearFocus]):
6:16 PM Changeset in webkit [17957] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-11-30 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Tabbed navigation fixes
​http://bugs.webkit.org/show_bug.cgi?id=11725

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition): (KWQKHTMLPart::tabbedNavigation):
5:53 PM Changeset in webkit [22601] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

5:47 PM Changeset in webkit [17956] by sfalken
  • 1 copy in tags/Safari-521.31.3

New tag.

4:57 PM Changeset in webkit [22600] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Lather, rinse, repeat.

  • platform/win/GraphicsContextWin.cpp: (WebCore::contextForImage):
4:55 PM Changeset in webkit [17955] by sullivan
  • 15 edits in trunk

LayoutTests:

Reviewed by Justin

  • editing/execCommand/create-list-from-range-selection-expected.checksum:
  • editing/execCommand/create-list-from-range-selection-expected.png:
  • editing/execCommand/create-list-from-range-selection-expected.txt:
  • editing/execCommand/create-list-from-range-selection.html: This test's results were broken by using rangeCompliantEquivalent at appropriate places in CompositeEditCommand.cpp::moveParagraphs(), presumably by revealing a different bug. Justin is going to look into this; for now I've updated the result so that it won't appear to fail for others.


  • editing/execCommand/create-list-with-hr-expected.checksum:
  • editing/execCommand/create-list-with-hr-expected.png:
  • editing/execCommand/create-list-with-hr-expected.txt:
  • editing/execCommand/create-list-with-hr.html: This test's results were improved by using rangeCompliantEquivalent at appropriate places in CompositeEditCommand.cpp::moveParagraphs() -- it used to create an extra <div>, and now it does not.

WebCore:

Reviewed by Justin

With Darin, fixed a problem in the Range constructors found while implementing grammar checking.
That revealed another problem in the layout tests involving bad parameters passed to the Range
constructors.


With these fixes in place, one layout test (editing/execCommand/create-list-from-range-selection.html)
no longer works as intended. This is apparently due to yet another bug being flushed out somewhere.
I'm going to update the results for that test and file a separate radar about it, which Justin will
investigate.

  • dom/Position.h: removed equivalentRangeCompliantPosition(), which was declared but not implemented or called.


  • dom/Range.cpp: (WebCore::Range::Range): Call setStart and setEnd in the two Range constructors that take parameters, rather than just directly setting the instance variables. This makes Range perform the boundary checks and compensations that the DOM spec requires.


  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Use rangeCompliantEquivalent() on "editing-style" Positions before creating Ranges from them.


  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): Assert that the boundary points of the range are valid.
4:18 PM Changeset in webkit [22599] by aroben
  • 3 edits
    1 delete in branches/WindowsMerge/WebCore

Build fix.

  • platform/graphics/cg/GraphicsContextCG.cpp: Removed. This file was un-forked a while ago.
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::platformDescription):
  • platform/win/GraphicsContextWin.cpp: (WebCore::contextForImage):
4:14 PM Changeset in webkit [17954] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Mitz.

Bug 10698: Scroll wheel causes inspector to shift up
​http://bugs.webkit.org/show_bug.cgi?id=10698

Remove size attribute from the tree popup as a workaround for
​http://bugs.webkit.org/show_bug.cgi?id=11362 Bug 11362: Native popup with size="1" wraps options

4:11 PM Changeset in webkit [17953] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Tim H.

Move web inspector style markup to javascript to fix ​http://bugs.webkit.org/show_bug.cgi?id=6724
Bug 6724: Text copied from Web Inspector is different from actual text

4:03 PM Changeset in webkit [17952] by thatcher
  • 1 edit in trunk/WebCore/ChangeLog

Removing the conflict marker.

3:50 PM Changeset in webkit [17951] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-30 sareen <​shyam.sareen@nokia.com>

Reviewed by spadma <​Sachin.Padma@nokia.com>
DESC: Browser crashes when loading local page with iFrame.
​http://bugs.webkit.org/show_bug.cgi?id=11728

  • ResourceLoader/src/HttpStackConfig.cpp: (THttpStackConfig::AddSessionFiltersL): (THttpStackConfig::InstallAuthenticationFilterL): (THttpStackConfig::InstallCookieFilterL): (THttpStackConfig::InstallUaProfFilterL): (THttpStackConfig::InstallConnHandlerFilterL): (THttpStackConfig::InstallIopFilterL):
3:45 PM Changeset in webkit [17950] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-30 sareen <​shyam.sareen@nokia.com>

Reviewed by spadma <​Sachin.Padma@nokia.com>
DESC: Browser crashes when loading local page with iFrame.
​http://bugs.webkit.org/show_bug.cgi?id=11728

  • ResourceLoader/src/HttpStackConfig.cpp: (THttpStackConfig::AddSessionFiltersL): (THttpStackConfig::InstallAuthenticationFilterL): (THttpStackConfig::InstallCookieFilterL): (THttpStackConfig::InstallUaProfFilterL): (THttpStackConfig::InstallConnHandlerFilterL): (THttpStackConfig::InstallIopFilterL):
2:48 PM Changeset in webkit [22598] by aroben
  • 4 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/svg/cg/SVGResourceFilterCg.cpp: (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter): (WebCore::SVGResourceFilter::createFilterEffect):
  • platform/graphics/svg/cg/SVGResourceMaskerCg.cpp: (WebCore::SVGResourceMasker::applyMask):
2:29 PM Changeset in webkit [17949] by lamadio
  • 3 edits in trunk/WebCore

2006-11-30 Lou Amadio <​lamadio@apple.com>

Reviewed by Dave Hyatt
Cleaned up generated files.

2:07 PM Changeset in webkit [17948] by aroben
  • 7 edits in trunk

WebCore:

Reviewed by Beth.

Store ContextMenu's NSMutableArray inside a RetainPtr so that we
will retain/release it correctly.

  • WebCore.exp:
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Added a FIXME.
  • platform/ContextMenu.h:
  • platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::getNSMenuItem): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::setPlatformDescription): (WebCore::ContextMenu::platformDescription):

WebKit:

Reviewed by Beth.

Put code in place to use WebCore context menus when they are turned
on.

  • WebView/WebHTMLView.m: (-[NSArray menuForEvent:]):
1:47 PM Changeset in webkit [17947] by zimmermann
  • 81 edits
    4 copies
    1 delete in trunk/WebCore

Reviewed by Eric. Rubber stamped by Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10383

This is the final patch after the long "die kcanvas" journey.

All old kcanvas code is gone now, and properly integrated within
WebCore (stuff like GraphicsContext changes etc.). It shares
the platform/ design concept: no subclassing, but instead
implementing parts of the classes/methods per-platform.

This commit removes the last pieces: KRenderingDevice & KRenderingDeviceContext.
This layer was just obsolete, given the powerful GraphicsContext API we have
since quite a while now. All the ugly pushContext/popContext stuff is gone now.

The naming issues Cg vs. CG will be fixed in one shot, when moving the whole
platform/graphics/svg directory down into ksvg2/graphics - as discussed with Darin.

1:13 PM Changeset in webkit [22597] by ggaren
  • 4 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Beth Dakin.


Fixed <rdar://problem/4844838> Whole document leak seen
running HTML iBench

  • loader/win/FrameLoaderWin.cpp: Removed custom implementation for detachFromParent, since FrameLoader has a cross-platform version now.

WebKitWin:

Reviewed by Beth Dakin.


Fixed <rdar://problem/4844838> Whole document leak seen
running HTML iBench

Copied *very nice* (NOT!) WebKit Mac idiom of calling
FrameLoader::detachFromParent when closing the WebView.
We need to do this so event listeners that retain the document
get destroyed, and so the unload event gets dispatched.

This is pretty silly. Instead, the document/frame/interpreter should
be responsible for cleaning up after itself.


  • WebView.cpp: (WebView::close):
1:10 PM Changeset in webkit [17946] by yongjzha
  • 2 edits in S60/trunk/WebKit
1:06 PM Changeset in webkit [17945] by ggaren
  • 9 edits in trunk

JavaScriptCore:

Reviewed by Beth Dakin.


Fixed up garbage collection at window close time.

  • kjs/interpreter.cpp: (KJS::Interpreter::~Interpreter): Garbage collect here, since destroying the interpreter frees the global object and therefore creates a lot of garbage.

WebCore:

Reviewed by Beth Dakin.


Fixed up garbage collection at window close time.

  • bindings/js/kjs_proxy.cpp: Don't garbage collect in the KJSProxy destructor, since the global object hasn't been freed yet.
  • bindings/js/kjs_proxy.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromParent): Made this function cross- platform.
  • loader/FrameLoader.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::setTitle): Moved this function to FrameLoaderMac, since it's Mac-only. (WebCore::FrameLoader::closeBridge):
  • page/Page.cpp: (WebCore::Page::~Page): Don't garbage collect in the Page destructor, since the Interpreter destructor will do it for us.
12:26 PM Changeset in webkit [17944] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-30 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: If values are null in setPreferenceForKey remove them from the map.
​http://bugs.webkit.org/show_bug.cgi?id=11438

  • BrowserView/src/WidgetPreferences.cpp: (CWidgetPreferences::SetPreferenceL):
12:23 PM Changeset in webkit [17943] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-30 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: 3.1 & 3.2 Memory handling error in CHttpCacheEntry::Internalize(), BrowserCache.dll
​http://bugs.webkit.org/show_bug.cgi?id=11724

  • ResourceLoader/CacheSrc/HttpCacheEntry.cpp: (CHttpCacheEntry::Internalize):
12:16 PM Changeset in webkit [17942] by spadma
  • 8 edits in S60/trunk

2006-11-30 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Sachin Padma.
DESC: Refresh timer in the browser is not cancelled
​http://bugs.webkit.org/show_bug.cgi?id=11722

  • BrowserControl/src/WmlDispatcher.cpp: (CWmlDispatcher::Complete):


12:06 PM Changeset in webkit [22596] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-30 Steve Falkenburg <​sfalken@apple.com>

build WebKit.lib to proper directory

  • WebKit.vcproj/WebKit.vcproj:
11:24 AM Changeset in webkit [17941] by spadma
  • 5 edits in S60/trunk/WebKit

2006-11-30 sareen <​shyam.sareen@nokia.com>

Reviewed by Sachin Padma.
DESC: [s60] Saved Pages: Some Images not saved with the page.
​http://bugs.webkit.org/show_bug.cgi?id=11721

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • ResourceLoader/inc/UrlRequestInfo.h: (CUrlRequestInfo::IsSavedPageRequest): (CUrlRequestInfo::SetSavedPageRequest):
  • ResourceLoader/src/MultipartContentHandler.cpp: (CMultipartContentHandler::HandleMultipartMixedL):
  • ResourceLoader/src/UrlRequestInfo.cpp: (CUrlRequestInfo::CUrlRequestInfo): (CUrlRequestInfo::~CUrlRequestInfo): (CUrlRequestInfo::SetPostDataL):
11:23 AM Changeset in webkit [17940] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Tim's rubberstamp

Amazingly, DocumentLoader.h survived all this time without a header guard...

  • loader/DocumentLoader.h: Added header guard
10:48 AM Changeset in webkit [22595] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-30 Steve Falkenburg <​sfalken@apple.com>

B&I build fix. Add missing header files to vcproj.

  • WebCore.vcproj/WebCore.vcproj:
9:37 AM Changeset in webkit [17939] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Brady and Eric.

XMLHttpRequest fails in a page loaded with WebFrame's loadHTMLString: or loadData:
​http://bugs.webkit.org/show_bug.cgi?id=11723

Allow cross-domain XMLHTTPRequest for applewebdata URLs. No automated way to test,
tested in Safari's debug Snippet Editor.

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
7:05 AM Changeset in webkit [17938] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-11-29 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC:
​http://bugs.webkit.org/show_bug.cgi?id=11716
[S60] some Chinese characters displays as mess code on www.163.com

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::XMLHttpRequest): (KJS::XMLHttpRequest::~XMLHttpRequest): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::slotData):

Nov 29, 2006:

7:44 PM Changeset in webkit [22594] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • platform/win/TemporaryLinkStubs.cpp: Remove unused function.
7:26 PM Changeset in webkit [17937] by andersca
  • 12 edits in trunk/WebCore

Reviewed by Brady.

Get rid of PlatformResponse, the platform specific response object is stored inside of
the ResourceResponse object now. This also gets rid of receivedResponse in ResourceHandleClient.


  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]): (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::~CachedResource):
  • loader/CachedResource.h: (WebCore::CachedResource::response):
  • loader/loader.cpp:
  • loader/loader.h:
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didReceiveResponse):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceResponse.h: (WebCore::ResourceResponse::nsURLResponse): (WebCore::ResourceResponse::cfURLResponse):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveResponse):
6:54 PM Changeset in webkit [17936] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by sullivan


<rdar://problem/4845371>
In Mail, a crash occurs at WebCore::Node::traverseNextNode() when cutting selected text from a HTML message

  • editing/deleting/4845371-expected.checksum: Added.
  • editing/deleting/4845371-expected.png: Added.
  • editing/deleting/4845371-expected.txt: Added.
  • editing/deleting/4845371.html: Added.

WebCore:

Reviewed by sullivan


<rdar://problem/4845371>
In Mail, a crash occurs at WebCore::Node::traverseNextNode() when cutting selected text from a HTML message


  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): The start/end were being inflated even when they were the start/end of a partially selected special element.
6:01 PM Changeset in webkit [17935] by bdash
  • 1 edit in trunk/WebKit/WebCoreSupport/WebChromeClient.mm

Build fix: ResourceRequestMac.h was removed in r17911.

5:55 PM Changeset in webkit [17934] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-11-29 shkeller <​shaun.keller@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: QPen emulation in KWQ did not handle special
case for pen width zero.
​http://bugs.webkit.org/show_bug.cgi?id=11714

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQPainter.cpp:
4:59 PM Changeset in webkit [17933] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Oliver.

Keep preferences separate from the rest of the client, making sure we are using expected preference values.
This lets the inspector work when plugins are disabled for the WebView.

  • WebInspector/WebInspector.m: (-[NSWindow window]):
4:10 PM Changeset in webkit [22593] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fix fast/dom/xmlhttprequest-get layout test failure.

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse): Initialize the status code to 0 for non-http responses.
3:01 PM Changeset in webkit [22592] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-29 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Anders.


Minor fix to my recent COM registration/Vista fix.
Ignore errors during registration. Vista locks off more of
HKCU\Software\Classes than I thought.

  • WebKitDLL.cpp:
2:42 PM Changeset in webkit [17932] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

Fix fast/dom/xmlhttprequest-get layout test failure.


  • platform/network/mac/ResourceResponseMac.mm: Initialize the status code to 0 for non-http responses.
2:14 PM Changeset in webkit [17931] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=11712
REGRESSION: Crash when clicking JS link on crateandbarrel.com (window.open("http[...]"))


This was an accidental commit by Anders.

Chrome can't use the FrameView at window.open time, because it doesn't
exist yet.


  • page/Chrome.cpp: (WebCore::Chrome::pageRect):
1:58 PM Changeset in webkit [17930] by ggaren
  • 10 edits in trunk/WebCore

Reviewed by Mitz Pettel.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=11710
REGRESSION (r17906): Crash in WebCore::FrameMac

Added null checks for EditorClient, since it can be NULL when the page
has been destroyed. Removed external access to EditorClient, since it's
an implementation detail of the Editor.

No test case because this crash depends on window tear-down. Layout tests
pass.

11:31 AM Changeset in webkit [17929] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-28 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (​sachin.padma@nokia.com).
DESC: Zooming not working for auto-complete
​http://bugs.webkit.org/show_bug.cgi?id=11702

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::ActivateL): (CFormInputSkin::UpdatePopupL):


11:30 AM Changeset in webkit [17928] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-28 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (​sachin.padma@nokia.com).
DESC: Zooming not working for auto-complete
​http://bugs.webkit.org/show_bug.cgi?id=11702

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::ActivateL): (CFormInputSkin::UpdatePopupL):


11:26 AM Changeset in webkit [17927] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-29 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Can't upload an image to Blogger.com
​http://bugs.webkit.org/show_bug.cgi?id=11715

  • BrowserCore/Misc/src/CookieHandler.cpp: (CCookieHandler::AddCookieL):
11:24 AM Changeset in webkit [17926] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-29 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Can't upload an image to Blogger.com
​http://bugs.webkit.org/show_bug.cgi?id=11715

  • BrowserCore/Misc/src/CookieHandler.cpp: (CCookieHandler::AddCookieL):
10:47 AM Changeset in webkit [17925] by andersca
  • 4 edits in trunk/WebKit

Reviewed by Tim.

Add back methods in WebCoreStatistics that are still used by Tiger Safari.


  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.m: (+[WebCoreStatistics emptyCache]): (+[WebCoreStatistics setCacheDisabled:]):
10:38 AM Changeset in webkit [17924] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-29 spadma <​Sachin.Padma@nokia.com>

Reviewed by Zalan.
DESC: WEB browser crashes when attempting to view a local file
​http://bugs.webkit.org/show_bug.cgi?id=11711

  • ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::DownloadManagerContentL):
10:38 AM Changeset in webkit [17923] by andersca
  • 2 edits in trunk/WebCore

Fix build.


  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::receivedResponse): Fix tyop.
10:37 AM Changeset in webkit [17922] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-29 spadma <​Sachin.Padma@nokia.com>

Reviewed by Zalan.
DESC: WEB browser crashes when attempting to view a local file
​http://bugs.webkit.org/show_bug.cgi?id=11711

  • ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::DownloadManagerContentL):
10:35 AM Changeset in webkit [22591] by andersca
  • 5 edits
    2 deletes in branches/WindowsMerge/WebCore

Reviewed by Darin.

Have ResourceResponse hold on to the platform object and do lazy
initialization of the data members.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::didReceiveResponse):
  • platform/network/cf/ResourceRequestCFNet.h: Removed.
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse):
  • platform/network/cf/ResourceResponseCFNet.h: Removed.
  • platform/win/MimeTypeRegistryWin.cpp:
10:29 AM Changeset in webkit [17921] by andersca
  • 8 edits
    1 add
    1 delete in trunk/WebCore

Reviewed by Darin.

Have ResourceResponse hold on to the platform object and do lazy
initialization of the data members.


  • WebCore.xcodeproj/project.pbxproj:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::loadResourceSynchronously):
  • platform/network/ResourceRequest.cpp: (WebCore::ResourceRequest::updatePlatformRequest): (WebCore::ResourceRequest::updateResourceRequest):
  • platform/network/ResourceResponse.cpp: Added. (WebCore::ResourceResponse::url): (WebCore::ResourceResponse::mimeType): (WebCore::ResourceResponse::expectedContentLength): (WebCore::ResourceResponse::textEncodingName): (WebCore::ResourceResponse::suggestedFilename): (WebCore::ResourceResponse::httpStatusCode): (WebCore::ResourceResponse::setHTTPStatusCode): (WebCore::ResourceResponse::httpStatusText): (WebCore::ResourceResponse::setHTTPStatusText): (WebCore::ResourceResponse::httpHeaderField): (WebCore::ResourceResponse::httpHeaderFields): (WebCore::ResourceResponse::setExpirationDate): (WebCore::ResourceResponse::expirationDate): (WebCore::ResourceResponse::setLastModifiedDate): (WebCore::ResourceResponse::lastModifiedDate): (WebCore::ResourceResponse::updateResourceResponse):
  • platform/network/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::isMultipart):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::receivedResponse): (WebCore::ResourceHandle::willSendRequest):
  • platform/network/mac/ResourceResponseMac.h: Removed.
  • platform/network/mac/ResourceResponseMac.mm: (-[NSURLResponse WebCore]):
9:57 AM Changeset in webkit [22590] by aroben
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adele.

Give archive builds a separate set of CLSIDs so that they may be
installed/run alongside B&I builds and development builds.

  • Interfaces/WebKit.idl:
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.vcproj: Don't register WebKit.dll if ARCHIVE_BUILD or BuildBot is defined.

Nov 28, 2006:

11:43 PM Changeset in webkit [22589] by adachan
  • 14 edits
    3 adds in branches/WindowsMerge/WebKitWin

2006-11-28 Ada Chan <​adachan@apple.com>

Reviewed by Adam.


WebKitWin:

<rdar://4850020> Clear cache in WebKit

  • Added the IWebCache interface, which contains API to clear and disable the cache
  • Added implementation of WebCache which implements IWebCache.
  • the page cache related calls added in WebHistoryItem are just stubs right now because we haven't implemented page cache yet.
11:25 PM Changeset in webkit [17920] by aliceli1
  • 6 edits in trunk

WebCore:

Reviewed by Maciej.

A fix for a couple failing layout tests involving copy/cut in iframes.

  • bridge/EditorClient.h: Add frame parameter to dataForArchivedSelectionInFrame instead of just getting the webview's selectedFrame.
  • platform/mac/PasteboardMac.mm: (Pasteboard::writeSelection): Pass in the frame

WebKit:

Reviewed by Maciej.

A fix for a couple failing layout tests involving copy/cut in iframes.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::dataForArchivedSelection): Use the frame parameter instead of using the webview's selectedFrame.
10:42 PM Changeset in webkit [17919] by bdakin
  • 2 edits in trunk/WebKit

Reviewed by Geoffff.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11691 REGRESSION
(r17399, r17511): WebElementDictionary no longer returns nil
NSStrings

String's NSString* operator converts null Strings to empty
NSStrings for compatibility with AppKit. We need to work around
that here.

  • Misc/WebElementDictionary.m: (NSStringOrNil): (-[WebElementDictionary _altDisplayString]): (-[WebElementDictionary _spellingToolTip]): (-[WebElementDictionary _title]): (-[WebElementDictionary _titleDisplayString]): (-[WebElementDictionary _textContent]):
10:18 PM Changeset in webkit [22588] by ggaren
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4844855> Should clarify when to create clients in
the WebCore client API


All clients must now be supplied as constructor arguments. This clarifies
when you need to create clients, and also guarantees that objects can't
(for the most part) be in a clientless state.

Layout tests pass. No leaks reported.


  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • bridge/win/FrameWin.h:

WebKitWin:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4844855> Should clarify when to create clients in
the WebCore client API


All clients must now be supplied as constructor arguments. This clarifies
when you need to create clients, and also guarantees that objects can't
(for the most part) be in a clientless state.

Layout tests pass. No leaks reported.


  • WebFrame.cpp: (WebFrame::initWithWebFrameView):
10:11 PM Changeset in webkit [17918] by ggaren
  • 17 edits in trunk

WebCore:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4844855> Should clarify when to create clients in
the WebCore client API


All clients must now be supplied as constructor arguments. This clarifies
when you need to create clients, and also guarantees that objects can't
(for the most part) be in a clientless state.

Layout tests pass. No leaks reported.


  • bridge/mac/WebCoreFrameBridge.mm: I had to move some initialization up into WebKit to resolve circular dependencies at init time.

WebKit:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4844855> Should clarify when to create clients in
the WebCore client API


All clients must now be supplied as constructor arguments. This clarifies
when you need to create clients, and also guarantees that objects can't
(for the most part) be in a clientless state.

Layout tests pass. No leaks reported.


  • WebCoreSupport/WebFrameBridge.mm: Shuffled around initialization and changed some arguments to resolve ciruclar dependencies at init time. (-[WebFrame _initWithWebFrameView:webView:bridge:]): We no longer call setClient here, because the client is set up at construction time.
8:25 PM Changeset in webkit [22587] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Ada.

Add platform-specific constructor/destructor to ContextMenu so we can
properly dispose of the HMENU.

  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::at): (WebCore::ContextMenu::setPlatformDescription): (WebCore::ContextMenu::show):
8:19 PM Changeset in webkit [17917] by aroben
  • 3 edits in trunk/WebCore

Reviewed by Ada.

Add platform-specific constructor/destructor to ContextMenu so we can
properly retain/release the platform menu description.

  • platform/ContextMenu.h: (WebCore::ContextMenu::platformDescription):
  • platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::getNSMenuItem): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::setPlatformDescription):
7:27 PM Changeset in webkit [22586] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-28 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Geoff.


Make COM registration fall back to per-user for Vista LUA compatibility.

  • WebKitDLL.cpp:
7:24 PM Changeset in webkit [22585] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

7:15 PM Changeset in webkit [17916] by brmorris
  • 2 edits in S60/trunk/S60Tools

2006-11-28 brmorris <​bradley.morrison@nokia.com>

Reviewed by Sasha.

  • S60WebKitPlatformBuild.pl: Utility fixes.
6:30 PM Changeset in webkit [17915] by zbujtas
  • 3 edits in S60/branches/3.1m/WebCore

2006-11-27 shkeller <​shaun.keller@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Fix geometry calculations for tabbed navigation.
​http://bugs.webkit.org/show_bug.cgi?id=11678
Merged from 3.2 17914
WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition): (KWQKHTMLPart::tabbedNavigation):
  • kwq/KWQKHTMLPart.h:
6:15 PM Changeset in webkit [22584] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-28 Steve Falkenburg <​sfalken@apple.com>

B&I build fix

  • WebCore.vcproj/WebCore.vcproj:
6:09 PM Changeset in webkit [17914] by zbujtas
  • 3 edits in S60/trunk/WebCore

2006-11-22 shkeller <​shaun.keller@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Fix geometry calculations for tabbed navigation.
​http://bugs.webkit.org/show_bug.cgi?id=11678

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition): (KWQKHTMLPart::tabbedNavigation):
  • kwq/KWQKHTMLPart.h:
5:51 PM Changeset in webkit [17913] by aroben
  • 2 edits in trunk/WebCore

Build fix.

  • platform/network/mac/ResourceRequestMac.mm:
5:24 PM Changeset in webkit [17912] by harrison
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adele.

<rdar://problem/4852804> selection color does not get drawn over the missing image rectangle

  • editing/selection/select-missing-image-expected.checksum: Added.
  • editing/selection/select-missing-image-expected.png: Added.
  • editing/selection/select-missing-image-expected.txt: Added.
  • editing/selection/select-missing-image.html: Added.

WebCore:

Reviewed by Adele.

<rdar://problem/4852804> selection color does not get drawn over the missing image rectangle

Test:

  • editing/selection/select-missing-image.html: Added.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint): Draw the selection tint even if the image itself is not available.
5:23 PM Changeset in webkit [22583] by andersca
  • 5 edits in branches/WindowsMerge/WebCore

Fix the build by doing the same changes that were done in the open source WebCore repo.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::ResourceHandle::start):
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::cfURLRequest): (WebCore::addHeadersFromHashMap): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):
  • platform/network/cf/ResourceRequestCFNet.h:
5:15 PM Changeset in webkit [17911] by andersca
  • 11 edits
    1 add
    1 delete in trunk

WebCore:

Reviewed by Maciej.

Have ResourceRequest hold on to the platform object so we don't
have to convert back and forth when nothing in the object changes.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::continueAfterNavigationPolicy):
  • page/Chrome.cpp: (WebCore::Chrome::pageRect):
  • platform/network/ResourceRequest.cpp: Added. (WebCore::ResourceRequest::isEmpty): (WebCore::ResourceRequest::url): (WebCore::ResourceRequest::setURL): (WebCore::ResourceRequest::cachePolicy): (WebCore::ResourceRequest::setCachePolicy): (WebCore::ResourceRequest::timeoutInterval): (WebCore::ResourceRequest::setTimeoutInterval): (WebCore::ResourceRequest::mainDocumentURL): (WebCore::ResourceRequest::setMainDocumentURL): (WebCore::ResourceRequest::httpMethod): (WebCore::ResourceRequest::setHTTPMethod): (WebCore::ResourceRequest::httpHeaderFields): (WebCore::ResourceRequest::httpHeaderField): (WebCore::ResourceRequest::setHTTPHeaderField): (WebCore::ResourceRequest::httpBody): (WebCore::ResourceRequest::setHTTPBody): (WebCore::ResourceRequest::allowHTTPCookies): (WebCore::ResourceRequest::setAllowHTTPCookies): (WebCore::ResourceRequest::updatePlatformRequest): (WebCore::ResourceRequest::updateResourceRequest): (WebCore::ResourceRequest::addHTTPHeaderField): (WebCore::ResourceRequest::addHTTPHeaderFields):
  • platform/network/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willSendRequest):
  • platform/network/mac/ResourceRequestMac.h: Removed.
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::nsURLRequest): (WebCore::ResourceRequest::doUpdateResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest):

WebKit:

Reviewed by Maciej.

Update for changes to ResourceRequest.


  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): (WebChromeClient::createModalDialog):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::canHandleRequest):
4:49 PM Changeset in webkit [22582] by aroben
  • 15 edits
    1 add in branches/WindowsMerge

WebCoreWin:

Reviewed by Ada and Beth.

Fix: <rdar://problem/4601523> Contextual Menus (in web content)

  • WebCore.vcproj/WebCore.vcproj: Defined WEBCORE_CONTEXT_MENUS to turn on the context menus. Added new ContextMenuItem files.
  • platform/win/ContextMenuItemWin.cpp: Added. (WebCore::ContextMenuItem::ContextMenuItem):
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::itemCount): Updated to match ContextMenu.h and ContextMenuItem changes. (WebCore::ContextMenu::insertItem): Ditto. (WebCore::ContextMenu::appendItem): Ditto. (WebCore::ContextMenu::at): New method, similar to Vector<T>::at. (WebCore::ContextMenu::setPlatformDescription): Use MIM_APPLYTOSUBMENUS to make sure all submenus get the MNS_NOTIFYBYPOS style. (WebCore::ContextMenu::show): Implemented.

Updates to match OpenSource changes.

  • loader/win/FrameLoaderWin.cpp: Added missing #include.
  • page/win/EventHandlerWin.cpp: Return bools to signify whether the event was handled. (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passWheelEventToSubframe): (WebCore::EventHandler::passMousePressEventToScrollbar):
  • platform/win/PlatformScrollBar.h: Ditto.
  • platform/win/PlatformScrollBarWin.cpp: Ditto. (WebCore::PlatformScrollbar::handleMouseMoveEvent): (WebCore::PlatformScrollbar::handleMouseOutEvent): (WebCore::PlatformScrollbar::handleMousePressEvent): (WebCore::PlatformScrollbar::handleMouseReleaseEvent):

Small fix inspired by WebView.cpp changes.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize): Use ::ClientToScreen to do coordinate conversion instead of doing it ourselves.

WebKitWin:

Reviewed by Ada and Beth.

Fix: <rdar://problem/4601523> Contextual Menus (in web content)

  • Interfaces/IWebUIDelegate.idl: Added a new delegate method to be called when the user clicks on one of the application's context menu items.

Client updates from WebCore.

  • WebContextMenuClient.cpp: (WebContextMenuClient::addCustomContextMenuItems): Updated for method name changes. (WebContextMenuClient::contextMenuItemSelected): New client method that calls the UI delegate.
  • WebContextMenuClient.h: Updated to match ContextMenuClient.h

Windows context menu event handling.

  • WebView.cpp: (WebView::handleContextMenuEvent): New method to send a context menu event down into WebCore. (WebView::performContextMenuAction): New method to tell the ContextMenuController that the user clicked on a context menu item. (WebView::handleMouseEvent): Return a bool to signify whether the event was handled. (WebView::mouseWheel): Ditto. (WebViewWndProc): Handle WM_CONTEXTMENU and WM_MENUCOMMAND messages, and pass unhandled events to DefWindowProc.
  • WebView.h: New declarations.

Small (but necessary) fixes.

  • WebElementPropertyBag.cpp: (isEqual): Fixed to deal with LPCWSTRs, which is what was being passed in anyway. (WebElementPropertyBag::Read): Use FAILED() to check the return value of QueryInterface.
  • WebElementPropertyBag.h: Added missing #include.
4:42 PM Changeset in webkit [17910] by aroben
  • 23 edits
    1 copy
    1 add in trunk

WebCore:

Reviewed by Beth.

More WebCore context menu work (still not turned on, however).

Split ContextMenuItem into its own files and make it a class.

  • WebCore.exp: Updated symbols.
  • WebCore.xcodeproj/project.pbxproj: Added new ContextMenuItem files.
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Code cleanup.
  • platform/ContextMenu.h: Split ContextMenuItem into a separate file, removed redundant "Menu" part of platformMenuDescription(), setPlatformMenuDescription(). (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::hitTestResult): (WebCore::ContextMenu::platformDescription):
  • platform/ContextMenuItem.h: Added. Made ContextMenuItem a full-fledged class. (WebCore::): (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::menu): (WebCore::ContextMenuItem::platformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title):
  • platform/mac/ContextMenuItemMac.mm: Added. (WebCore::ContextMenuItem::ContextMenuItem):
  • platform/mac/ContextMenuMac.mm: Updated for ContextMenuItem changes. (-[MenuTarget forwardContextMenuAction:]): (getNSMenuItem): Handle separator items. (ContextMenu::appendItem): (ContextMenu::itemCount): (ContextMenu::insertItem): (ContextMenu::setPlatformDescription):
  • page/ContextMenuController.h: Updated declaration, added getter. (WebCore::ContextMenuController::contextMenu):

Added some more context menu plumbing.

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Added code to call the ContextMenuController when a context menu event is received.
  • page/ContextMenuClient.h: New client method declaration.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent): Set the event defaultHandled after handling it. (WebCore::ContextMenuController::contextMenuItemSelected): Take a ContextMenuItem instead of a separate action and title.

Changed event-handling methods to return bools to signify whether the
event was handled or not. This is needed so we can know whether to hand
the event off to the OS. Also restructured some code to use early
returns instead of nesting ifs.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventDoubleClick): (WebCore::EventHandler::handleMousePressEventTripleClick): (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleWheelEvent): (WebCore::EventHandler::canMouseDownStartSelect):
  • page/EventHandler.h:
  • page/FrameView.cpp: (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::handleMouseReleaseEvent):
  • page/FrameView.h:
  • platform/ScrollBar.h: More bool return values. (WebCore::Scrollbar::handleMouseMoveEvent): (WebCore::Scrollbar::handleMouseOutEvent):
  • platform/Widget.h: Ditto. (WebCore::Widget::handleMouseMoveEvent): (WebCore::Widget::handleMouseReleaseEvent):

Reverted the changes made in r17805 so that we can have fewer header
#includes.

  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h: Ditto. (WebCore::Page::dragCaretController): (WebCore::Page::chrome): (WebCore::Page::contextMenuController):

WebKit:

Reviewed by Beth.

More WebCore context menu work.

  • DefaultDelegates/WebDefaultUIDelegate.m: New stub delegate method implementation. (-[NSApplication webView:contextMenuItemSelected:forElement:]):
  • WebCoreSupport/WebContextMenuClient.h: Updated to match ContextMenuClient.h changes.
  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::addCustomContextMenuItems): Updated for method name changes. (WebContextMenuClient::contextMenuItemSelected): Added new client method.
  • WebView/WebUIDelegatePrivate.h: New private delegate method declaration.
4:12 PM Changeset in webkit [22581] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.


<rdar://problem/4850883>
Crash loading pdf page (W4 form)


  • platform/win/TemporaryLinkStubs.cpp: (FrameLoader::redirectDataToPlugin):
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::redirectDataToPlugin): Move the function to FrameLoaderWin.cpp and get rid of STOP_NOIMPL() for now, we do things differently on Windows so this function doesn't need do do anything. I've filed 4852889 about redoing this once the loader has been ported.
2:14 PM Changeset in webkit [22580] by aliceli1
  • 6 edits
    4 adds in branches/WindowsMerge

WebCoreWin:

Reviewed by Ada, Adam, and Lou.

  • WebCore.vcproj/WebCore.vcproj: Added the files listed below


  • platform/win/ClipboardWin.h: Added.
  • platform/win/ClipboardWin.cpp: Added. Added the minimum stubs for the ClipboardWin class (WebCore::ClipboardWin::isForDragging): (WebCore::ClipboardWin::dropEffect): (WebCore::ClipboardWin::setDropEffect): (WebCore::ClipboardWin::effectAllowed): (WebCore::ClipboardWin::setEffectAllowed): (WebCore::ClipboardWin::clearData): (WebCore::ClipboardWin::clearAllData): (WebCore::ClipboardWin::getData): (WebCore::ClipboardWin::setData): (WebCore::ClipboardWin::types): (WebCore::ClipboardWin::dragLocation): (WebCore::ClipboardWin::dragImage): (WebCore::ClipboardWin::setDragImage): (WebCore::ClipboardWin::dragImageElement): (WebCore::ClipboardWin::setDragImageElement): (WebCore::ClipboardWin::setAccessPolicy): (WebCore::ClipboardWin::~ClipboardWin):
  • platform/win/EditorWin.cpp: Added. Added this to make dispatchCPPEvent happy. (WebCore::Editor::newGeneralClipboard):
  • platform/win/PasteboardWin.cpp: Added. The pasteboard class follows a singleton pattern Implemented the following to support CF_HTML, CF_UNICODE, and CF_TEXT (WebCore::Pasteboard::generalPasteboard): (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::~Pasteboard): (WebCore::Pasteboard::registerSelectionPasteboardTypes): (WebCore::Pasteboard::clearTypes): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::createHandleFromString): (WebCore::Pasteboard::createHandleFromCString): (WebCore::Pasteboard::createCF_HTMLFromRange): (WebCore::Pasteboard::replaceNBSP): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment): (WebCore::PasteboardOwnerWndProc):

WebKitWin:

Reviewed by Ada, Adam, and Lou.

  • WebEditorClient.h:
  • WebEditorClient.cpp: These 3 functions are, for now, hard-coded to return true, letting paste work. Commented out previous unused code because the app would crash if the editingDelegate was called (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldInsertNode): (WebEditorClient::shouldInsertText): stub impl for: (WebEditorClient::smartInsertDeleteEnabled):
  • WebView.cpp: moved where cut/copy/paste was handled from (WebView::execCommand): (WebViewWndProc):


call the editor's version of these 4:
(WebView::copy):
(WebView::cut):
(WebView::paste):
(WebView::delete_):

2:06 PM Changeset in webkit [22579] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Anders Carlsson.

Fixed <rdar://problem/4844863> REGRESSION: screen flashes when scrolling/
resizing page with plug-in (@ cnn.com, for example).

LockWindowUpdate was to blame. It turns out that using LockWindowUpdate
was wrong to begin with. It's really only intended for use in drag-n-drop
operations, which explains why only one window can be locked at a time.
(See ​http://blogs.msdn.com/oldnewthing/archive/2004/06/10/152612.aspx.)


The new solution I've implemented for avoiding plug-in fragments while scrolling
is simply to clip the plug-in to the zero rect before moving it, and
then to un-clip it when done.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateHwnd):
2:05 PM Changeset in webkit [17909] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-28 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: [S60] browser fails to run the script when the page saved
​http://bugs.webkit.org/show_bug.cgi?id=11706

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::LoadSavedPageL):
2:02 PM Changeset in webkit [17908] by aliceli1
  • 17 edits
    1 move
    5 adds in trunk

WebCore:

Reviewed by Justin and Adam.

All layout tests pass as they do without this patch

  • WebCore.exp: Exposed functions in Editor and removed functions in FrameMac due to changes in WebHTMLView.m
  • WebCore.xcodeproj/project.pbxproj: Added Pasteboard.h, PasteboardMac.mm, WebNSAttributedStringExtras.h&mm, EditorMac.mm
  • bridge/EditorClient.h: Added smartInsertDeleteEnabled and shouldInsertNode and some mac-specific functions
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: Removed dispatchCPPEvent and [can|try]DHTML[cut|copy|paste] since the Editor's are called now
  • dom/CharacterData.h: (WebCore::CharacterData::isCharacterDataNode):
  • dom/Node.h: (WebCore::Node::isCharacterDataNode): Added a type-identifying function to Node and the proper subclass
  • dom/Clipboard.h: Exposed setAccessPolicy as public


  • editing/Editor.h:
  • editing/Editor.cpp: Implemented the following (WebCore::Editor::canDHTMLCut): (WebCore::Editor::canDHTMLCopy): (WebCore::Editor::canDHTMLPaste): (WebCore::Editor::canSmartCopyOrDelete): (WebCore::Editor::deleteSelection): (WebCore::Editor::pasteAsPlainTextWithPasteboard): (WebCore::Editor::pasteWithPasteboard): (WebCore::Editor::canSmartReplaceWithPasteboard): (WebCore::Editor::shouldInsertFragment): (WebCore::Editor::replaceSelectionWithFragment): (WebCore::Editor::replaceSelectionWithText): (WebCore::Editor::selectedRange): (WebCore::Editor::shouldDeleteRange): (WebCore::Editor::tryDHTMLCopy): (WebCore::Editor::tryDHTMLCut): (WebCore::Editor::tryDHTMLPaste): (WebCore::Editor::writeSelectionToPasteboard): (WebCore::Editor::dispatchCPPEvent): (WebCore::Editor::cut): (WebCore::Editor::copy): (WebCore::Editor::paste):


  • platform/mac/ClipboardAccessPolicy.h: Removed. Not removed, but moved to dom/ClipboardAccessPolicy.h


  • platform/mac/EditorMac.mm: Added. (WebCore::Editor::newGeneralClipboard):
  • platform/Pasteboard.h: Added.
  • platform/mac/PasteboardMac.mm: Added. The pasteboard class follows a singleton pattern (Pasteboard::generalPasteboard): (Pasteboard::~Pasteboard): (Pasteboard::Pasteboard): (Pasteboard::clearTypes): (Pasteboard::writeSelection): (Pasteboard::selectionPasteboardTypes): (Pasteboard::canSmartReplace): (Pasteboard::plainText): (Pasteboard::documentFragment):


  • platform/mac/WebNSAttributedStringExtras.h: Added.
  • platform/mac/WebNSAttributedStringExtras.mm: Added. Added select portions of this file from WebKit because the pasteboard needed the following function: (-[NSAttributedString _web_attributedStringByStrippingAttachmentCharacters]):

WebKit:

Reviewed by Justin and Adam.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: added the following (WebEditorClient::smartInsertDeleteEnabled): (WebEditorClient::dataForArchivedSelectionInFrame): (WebEditorClient::_web_userVisibleString): (WebEditorClient::shouldInsertNode):


  • WebKitPrefix.h: Added flags to control whether WebCore cut/copy/paste is enabled. Turned on Cut and Copy, left Paste and Delete off


  • WebView/WebHTMLViewPrivate.h:
  • WebView/WebHTMLView.m: removed _can[Cut|Copy|Paste|Delete] (-[NSArray validateUserInterfaceItem:]): call the editor for canDHTML[C|C|P|D] and _can[C|C|P|D] instead (-[NSArray delete:]): added code to call the editor's delete instead (not turned on) (-[WebHTMLView copy:]): added code to call the editor's copy (turned on) (-[WebHTMLView cut:]): added code to call the editor's cut (turned on) (-[WebHTMLView paste:]): added code to call the editor's paste (not turned on)
1:25 PM Changeset in webkit [17907] by justing
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4397952>
Cannot select buttons at the end of a document, preventing copy/paste

  • editing/selection/4397952-expected.checksum: Added.
  • editing/selection/4397952-expected.png: Added.
  • editing/selection/4397952-expected.txt: Added.
  • editing/selection/4397952.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4397952>
Cannot select buttons at the end of a document, preventing copy/paste


There were no VisiblePositions before/after buttons because editingIgnoresContent
returned false for buttons.

  • dom/Position.cpp: (WebCore::Position::upstream): Fixed a comment. (WebCore::Position::downstream): Ditto.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): Ditto.
  • editing/htmlediting.cpp: (WebCore::editingIgnoresContent): It's unnecessary to prefer renderer checks over tag name checks because it seems that a node of a tag name that we do not ignore content for can't have a renderer of a type that we do. (WebCore::canHaveChildrenForEditing): Added selects, buttons, applets, and embeds.
  • editing/visible_units.cpp: (WebCore::previousLinePosition): Migrate to enclosingBlock. Fixes a bug where the caret would get stuck moving up/down a line from a caret just before an input element. (WebCore::nextLinePosition): Ditto.
11:00 AM Changeset in webkit [22578] by ggaren
  • 14 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Fixed <rdar://problem/4844848> REGRESSION: extra cross-library ref/deref
calls cause .5% PLT regression.


Changed ref/deref calls to a single 'xxxDestroyed' call. Moved EditorClient
from the Frame to the Page, since it's only responsible for
Webview-level delegate calls.


I don't really love this design, but it fixes the regression and allows
a single WebKit object to implement multiple client interfaces.


Layout tests pass.

WebKitWin:

Reviewed by Adam.

Fixed <rdar://problem/4844848> REGRESSION: extra cross-library ref/deref
calls cause .5% PLT regression.


Changed ref/deref calls to a single 'xxxDestroyed' call. Moved EditorClient
from the Frame to the Page, since it's only responsible for
Webview-level delegate calls.


I don't really love this design, but it fixes the regression and allows
a single WebKit object to implement multiple client interfaces.


Layout tests pass.

10:54 AM Changeset in webkit [17906] by ggaren
  • 36 edits
    1 delete in trunk

WebCore:

Reviewed by Adam.

Fixed <rdar://problem/4844848> REGRESSION: extra cross-library ref/deref
calls cause .5% PLT regression.


Changed ref/deref calls to a single 'xxxDestroyed' call. Moved EditorClient
from the Frame to the Page, since it's only responsible for
Webview-level delegate calls.


I don't really love this design, but it fixes the regression and allows
a single WebKit object to implement multiple client interfaces.


Layout tests pass.

WebKit:

Reviewed by Adam.

Fixed <rdar://problem/4844848> REGRESSION: extra cross-library ref/deref
calls cause .5% PLT regression.


Changed ref/deref calls to a single 'xxxDestroyed' call. Moved EditorClient
from the Frame to the Page, since it's only responsible for
Webview-level delegate calls.


I don't really love this design, but it fixes the regression and allows
a single WebKit object to implement multiple client interfaces.


Layout tests pass.

9:21 AM Changeset in webkit [17905] by spadma
  • 33 edits in S60/trunk

2006-11-17 vbradley <​vincent.bradley@nokia.com>

Reviewed by Sachin.
DESC: Removed the obsolete flags RD_32_BROWSER and RD_BROWSER_VIDEO_PLUGIN
​http://bugs.webkit.org/show_bug.cgi?id=11604

  • BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL): (CBrCtl::CountComponentControls): (CBrCtl::ComponentControl):
  • BrowserCore/Formcontrols/inc/FControlInputWidget.h:
  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::ActivateL):
  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::ConstructTextEditorL): (CControlInputWidget::OfferKeyEventL): (CControlInputWidget::SetWebKitCursorPosition):
  • BrowserCore/Misc/src/CannedImages.cpp: (CCannedImages::GetImage):
  • BrowserView/inc/BrowserSettingsContainer.h:
  • BrowserView/inc/SmartLinkHandler.h:
  • BrowserView/inc/WebKitControl.h:
  • BrowserView/inc/WebKitCursor.h:
  • BrowserView/inc/WebKitFrame.h:
  • BrowserView/inc/WebKitView.h:
  • BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleArrowKeysL): (CKeyEventHandler::HandleActivateKeysL):
  • BrowserView/src/SmartLinkHandler.cpp: (CSmartLinkHandler::~CSmartLinkHandler): (CSmartLinkHandler::PrepareAiwHandlerL): (CSmartLinkHandler::HandleMakeCall):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::~CWebKitControl): (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL): (CWebKitControl::PageInfoLC): (CWebKitControl::ProgressCompleted):
  • BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::ConstructL): (CWebKitCursor::CursorUpdate): (CWebKitCursor::MoveCursorAdjusted): (CWebKitCursor::GetSmartLinkEntry): (CWebKitCursor::CalcSearchRect):
  • BrowserView/src/WebKitFrame.cpp: (CWebKitFrame::ConstructL): (CWebKitFrame::~CWebKitFrame):
  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • BrowserView/src/WebKitView.cpp: (CWebKitView::CWebKitView): (CWebKitView::ZoomLevelChanged): (CWebKitView::FindNextSmartLink):
  • Plugin/inc/PluginSkin.h: (CPluginSkin::CanInteract):
  • Plugin/inc/PluginWin.h:
  • Plugin/src/PluginWin.cpp:
  • ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::InitDownloadMgrL): (CHttpDownloadObserver::HandleDMgrCompletedEventL):
  • data/Webkit.loc:
  • data/Webkit.rss:
  • data/Webkit_sdk.loc:
  • data/Webkit_sdk.rss:
  • group/BrowserView.mmp:
  • group/webkit.mmp:
Note: See TracTimeline for information about the timeline view.