Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Dec 4, 2006:

10:50 PM Changeset in webkit [18016] by bdakin

• 2 edits in trunk/WebCore

Reviewed by Geoff.

Fix from last check-in. This line was badbad.

• platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::~ContextMenu):

10:33 PM Changeset in webkit [18015] by bdakin

• 3 edits in trunk/WebCore

Reviewed by Geoff.

With the new changes to ContextMenuItems, WebCore context menus
stopped appearing at all. And then when I got them to appear, they
crashed. This fixes both of these problems.

• platform/mac/ContextMenuItemMac.mm: (WebCore::ContextMenuItem::ContextMenuItem): keyEquivalent cannot be nil. This was causing Obj-C to throw an exception preventing the menus from popping up at all.
• platform/mac/ContextMenuMac.mm: (+[WebCoreMenuTarget sharedMenuTarget]): Re-name our static MenuTarget so that it is more clear that it is a static and shared WebCoreMenuTarget. (WebCore::ContextMenu::ContextMenu): Initialize the WebCoreMenuTarget's controller in the ContextMenu constructor instead of in getNSMenuItem since the controller will only possibly change when a new ContextMenu has been created. (WebCore::ContextMenu::~ContextMenu): Set the target's controller to 0. (WebCore::getNSMenuItem): A lot of this work is being done other places now. Call new class method on WebCoreMenuTarget to get the shared target. (WebCore::ContextMenu::appendItem): We should not be releasing the menuItem here! This caused the crashes I saw. (WebCore::ContextMenu::insertItem): Same.

7:37 PM Changeset in webkit [18014] by andersca

• 2 edits in trunk/WebCore

Fix the build.

• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::~SubresourceLoader): Add back the destructor.

7:17 PM Changeset in webkit [22613] by andersca

• 3 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

• WebCore.vcproj/WebCore.vcproj: Add SubresourceClient.h

• platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didReceiveResponse): Get rid of the receivedResponse call.

(WebCore::didFinishLoading):
Get rid of the receivedAllData call, that's handled by the subresource loader now.

7:07 PM Changeset in webkit [18013] by andersca

• 17 edits
  1 add in trunk/WebCore

Reviewed by Darin.

Change all ResourceHandleClients to be SubresourceLoaderClients instead. Also,
make SubresourceLoader a ResourceHandleClient. This is a first step towards turning ResourceHandle into a
standalone class which doesn't need to know about SubresourceLoader.

• WebCore.xcodeproj/project.pbxproj:
• loader/ResourceLoader.cpp: (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::setDefersLoading):
• loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::~SubresourceLoader): (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFailWithError): (WebCore::SubresourceLoader::receivedAllData):
• loader/SubresourceLoader.h: (WebCore::SubresourceLoader::loaderAsResourceHandleClient): (WebCore::SubresourceLoader::handle):
• loader/SubresourceLoaderClient.h: Added. (WebCore::SubresourceLoaderClient::~SubresourceLoaderClient): (WebCore::SubresourceLoaderClient::willSendRequest): (WebCore::SubresourceLoaderClient::didReceiveResponse): (WebCore::SubresourceLoaderClient::didReceiveData): (WebCore::SubresourceLoaderClient::didFinishLoading): (WebCore::SubresourceLoaderClient::didFailWithError): (WebCore::SubresourceLoaderClient::receivedAllData):
• loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading): (WebCore::IconLoader::stopLoading): (WebCore::IconLoader::didReceiveResponse): (WebCore::IconLoader::didReceiveData): (WebCore::IconLoader::didFailWithError): (WebCore::IconLoader::didFinishLoading): (WebCore::IconLoader::clearLoadingState):
• loader/icon/IconLoader.h:
• loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::receivedAllData): (WebCore::Loader::didFailWithError): (WebCore::Loader::didReceiveResponse): (WebCore::Loader::didReceiveData): (WebCore::Loader::cancelRequests):
• loader/loader.h:
• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
• platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
• platform/network/ResourceHandle.h:
• platform/network/ResourceHandleClient.h:
• platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::finishJobAndHandle): (WebCore::ResourceHandle::loader):
• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::didFailWithError): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::willSendRequest): (WebCore::XMLHttpRequest::didReceiveResponse): (WebCore::XMLHttpRequest::didReceiveData):
• xml/xmlhttprequest.h:

5:36 PM Changeset in webkit [22612] by darin

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

• WebCore.vcproj/WebCore.vcproj: Update for new UIEventWithKeyState.cpp file.

5:29 PM Changeset in webkit [18012] by darin

• 12 edits
  3 adds in trunk

LayoutTests:

Reviewed by Adele.

• test the part of ​http://bugs.webkit.org/show_bug.cgi?id=11628 REGRESSION (r17597): Command-return in text fields doesn't open a new tab or window that can easily be tested from the DOM -- this only checks that simulated mouse events from clicking on a link have the key state from the Enter key keyboard event, which is one part of the fix for the bug above

• fast/events/simulated-key-state-expected.txt: Added.
• fast/events/simulated-key-state.html: Added.

WebCore:

Reviewed by Adele.

• fix another part of ​http://bugs.webkit.org/show_bug.cgi?id=11628 REGRESSION (r17597): Command-return in text fields doesn't open a new tab or window

This fixes command-return when the focus is on a link.
Despite the title of the bug, Mitz wanted me to fix both, and I will not
say no to him!

Test: fast/events/simulated-key-state.html

• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchSimulatedMouseEvent): Instead of always passing false for all the key state in simulated mouse events, pass the state from the first underlying event in the chain that has key state; in the case in the bug, the keyboard event will be the underlying event itself and we'll propagate the alt key modifier to the mouse event, resulting in the effect we want. It's nice that JavaScript also gets to see the proper modifiers in the mouse event.

• html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Added code to pass in an underlying event to dispatchSimulatedClick. After looking at all the other callers, this seems to be the only one that needs to pass an event that is currently passing 0. Also removed the code that only simulated a click when the event has a PlatformKeyboardEvent -- no reason for that and it prevented me from writing a layout test for the fix.

• dom/UIEventWithKeyState.h: Added findEventWithKeyState function that walks the underlyingEvent chain to find the first event that has key state. This already existed in WebKit, but I wanted to use it in dispatchSimulatedMouseEvent.
• dom/UIEventWithKeyState.cpp: Added.

• CMakeLists.txt: Added UIEventWithKeyState.cpp.
• WebCore.vcproj/WebCore/WebCore.vcproj: Added UIEventWithKeyState.cpp.
• WebCore.xcodeproj/project.pbxproj: Added UIEventWithKeyState.cpp.
• WebCoreSources.bkl: Added UIEventWithKeyState.cpp.

• WebCore.exp: Added findEventWithKeyState, used by WebKit.

WebKit:

Reviewed by Adele.

• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary): Changed to use the new findEventWithKeyState function in WebCore instead of a local function in this file.

4:49 PM Changeset in webkit [18011] by kmccullo

• 11 edits in trunk/WebCore

Reviewed by Darin.

• removed the guards for the "multiple forms submission" issue, which may not be an issue anymore and the guards prevent perfectly legitimate websites from working correctly.

• bridge/mac/FrameMac.mm: (WebCore::FrameMac::setView):
• bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityPerformAction:]):
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyPress):
• config.h:
• loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm):
• loader/FrameLoader.h:
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::receivedMainResourceError):
• loader/qt/FrameLoaderQt.cpp: (WebCore::FrameLoader::submitForm):
• page/Frame.cpp: (WebCore::Frame::setView):
• page/mac/EventHandlerMac.mm: (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::mouseDown):
• platform/qt/FrameQt.cpp: (WebCore::FrameQt::keyEvent):

4:38 PM Changeset in webkit [22611] by kmccullo

• 3 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

• removed the guards for the "multiple forms submission" issue, which may not be an issue anymore and the guards prevent perfectly legitimate websites from working correctly.

• bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyEvent):
• config.h:
• loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm):

4:37 PM Changeset in webkit [18010] by ggaren

• 2 edits in trunk/WebKit

Rolled out the WebDashboardBehaviorUseBackwardCompatibilityModeEnabled
part of my last checkin.

We have to turn on support for backward compatibility mode to avoid Dashboard
regressions in the short term.

• WebView/WebView.mm: (-[WebView _setDashboardBehavior:to:]):

3:54 PM Changeset in webkit [18009] by ggaren

• 15 edits in trunk

LayoutTests:

Reviewed by Darin Adler.

Removed Dashboard quirk from expected results. Now that we have a Dashboard
quirks mode, there's no reason to keep the old, bad behavior in the browser.

• http/tests/xmlhttprequest/exceptions-expected.txt:
• http/tests/xmlhttprequest/exceptions.html:

WebCore:

Reviewed by Darin Adler.

Added support for Dashboard backward compatibility mode.

• html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::stroke): Added support for old behavior of automatically clearing the stroke path buffer after a call to stroke().
• html/HTMLCanvasElement.cpp: Added supoprt for old behavior of the canvas tag being self-closing. (WebCore::HTMLCanvasElement::endTagRequirement): (WebCore::HTMLCanvasElement::tagPriority):
• html/HTMLCanvasElement.h:
• html/HTMLParser.cpp: Ditto. (WebCore::HTMLParser::canvasCreateErrorCheck):
• xml/xmlhttprequest.cpp: Added support for old behavior of silently ignoring a call to setRequestHeader() if it preceded a call to open() or followed a call to send(). (WebCore::XMLHttpRequest::setRequestHeader):

WebKit:

Reviewed by Darin Adler.

Added SPI for enabling Dashboard backward compatibility mode. For now,
we enable it unconditionally for Dashboard and Dashcode. Once they
implement specific support for the backward compatibility mode behavior,
we can change that.

Set the default WebDashboardBehaviorUseBackwardCompatibilityModeEnabled
to YES in order to turn this code on.

• WebView/WebView.mm: (-[WebView _setDashboardBehavior:to:]): (-[WebView _dashboardBehavior:]):
• WebView/WebViewPrivate.h:

3:52 PM Changeset in webkit [22610] by darin

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Alice.

• platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::generalPasteboard): Got rid of s_generalPasteboard. Also removed definition of destructor.

3:43 PM Changeset in webkit [18008] by darin

• 11 edits in trunk

WebCore:

Reviewed by Alice.

• bridge/EditorClient.h: Removed "_web_" prefix from C++ userVisibleString member function. Alice will probably change this so it's not on the editor client any more later.

• editing/Editor.h: Removed "_web_" prefix from C++ userVisibleString member function.
• editing/Editor.cpp: Tweaked formatting a bit. Removed Mac-specific code from this file.

• editing/mac/EditorMac.mm: (WebCore::Editor::newGeneralClipboard): Removed unnneded local variable. (WebCore::Editor::userVisibleString): Moved this function here.

• platform/Pasteboard.h: Added some FIXMEs. Removed unneeded includes. Made Pasteboard noncopyable. Removed use of "protected" where we should be using "private". Removed s_generalPasteboard.
• platform/mac/PasteboardMac.mm: Added some FIXMEs. Removed the s_generalPasteboard global. Removed the unused destructor. Updated call to userVisibleString for name change. Tweaked formatting.

WebKit:

Reviewed by Alice.

• WebCoreSupport/WebEditorClient.h: Removed "_web_" prefix from C++ userVisibleString member function.
• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::userVisibleString): Ditto.

• WebView/WebView.mm: (-[WebView selectedFrame]): Removed extra return statement.

3:34 PM Changeset in webkit [22609] by andersca

• 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin, Geoff.

Get rid of ref() in ResourceHandle::start() and remove all uses of kill().

• platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::ResourceHandle::start):
• plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::stop):

WebKitWin:

Reviewed by Darin, Geoff.

Don't use ResourceHandle::kill().

• WebFrame.cpp: (WebFrame::stopMainResourceLoad):

3:31 PM Changeset in webkit [22608] by aliceli1

• 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Oliver.

Fixed <rdar://problem/4822632> clicks don't work if you move mouse immediately
This bug was fixed by implementing EventHandler::handleDrag. The part of that
function after the drag hysteresis is exceeded remains unimplemented until
drag&drop is implemented.

• page/win/EventHandlerWin.cpp: (WebCore::dragState): (WebCore::EventHandler::dragHysteresisExceeded): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::handleMouseUp): (WebCore::EventHandler::shouldDragAutoNode): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
• platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):

WebKitWin:

Reviewed by Oliver.

Fixed <rdar://problem/4822632> clicks don't work if you move mouse immediately
This bug was fixed by implementing EventHandler::handleDrag.

• WebView.cpp: (WebView::WebView): Added a data member (WebView::handleMouseEvent): Create the mouse event telling it it activated the webview (WebViewWndProc): Call setMouseActivated upon receiving the relevent message
• WebView.h: (WebView::setMouseActivated): Added this function so that the webview knows if it was brought to the foreground by a mouse event

3:30 PM Changeset in webkit [18007] by aliceli1

• 5 edits in trunk/WebCore

Reviewed by Oliver.

Moved some constants from EventHandlerMac.mm to EventHandler.cpp
Added some platform-specific data members and functions.

• page/EventHandler.cpp:
• page/EventHandler.h:
• page/mac/EventHandlerMac.mm:
• platform/PlatformMouseEvent.h: (WebCore::): (WebCore::PlatformMouseEvent::timestamp): (WebCore::PlatformMouseEvent::activatedWebView): (WebCore::PlatformMouseEvent::type):

3:26 PM Changeset in webkit [18006] by andersca

• 8 edits in trunk/WebCore

Reviewed by Darin, Geoff.

Get rid of ResourceHandle::kill(), all it did was to balance out a ref() in ResourceHandle::start().
We use RefPtrs to ResourceHandle instead.

• loader/icon/IconLoader.cpp: (WebCore::IconLoader::~IconLoader): (WebCore::IconLoader::stopLoading): (WebCore::IconLoader::didReceiveResponse):
• loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::cancelRequests): (WebCore::Loader::jobForRequest):
• loader/loader.h:
• platform/network/ResourceHandle.cpp:
• platform/network/ResourceHandle.h:
• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::finishJobAndHandle): (WebCore::ResourceHandle::reportError):
• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::didFinishLoading):

3:14 PM Changeset in webkit [18005] by bdash

• 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Build fix: set private attribute on ImageAnimationObserver.h so it is copied into the framework.

2:32 PM Changeset in webkit [18004] by oliver

• 2 edits in trunk/WebCore

2006-12-04 Oliver Hunt <​oliver@apple.com>

Build fix for non-SVG builds

• bindings/js/JSSVGPoint.cpp: (WebCore::JSSVGPointProtoFunc::callAsFunction):

2:31 PM Changeset in webkit [18003] by spadma

• 2 edits in S60/branches/3.1m/WebKit

2006-11-28 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: [S60] browser fails to run the script when the page saved
​http://bugs.webkit.org/show_bug.cgi?id=11706

• BrowserView/src/WebKitControl.cpp: (CWebKitControl::LoadSavedPageL):

2:00 PM Changeset in webkit [18002] by yongjzha

• 7 edits in S60/trunk/WebKit

2006-12-04 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun <​yongjun.zhang@nokia.com>.
DESC: [S60] PNIO-6TCGX3: document.referrer doesn't seem to have any value
​http://bugs.webkit.org/show_bug.cgi?id=11735

• BrowserView/inc/WebKitLoader.h: (CWebKitLoader::ReferrerUrl):
• BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::~CWebKitLoader): (CWebKitLoader::LoadPageL): (CWebKitLoader::SetPageUrlL): (CWebKitLoader::SetReferrerUrlL):
• BrowserView/src/webkitbridge.cpp: (CWebKitBridge::IncomingReferrer):
• ChangeLog:
• ResourceLoader/inc/UrlRequestInfo.h: (CUrlRequestInfo::RefererUrl):
• ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::AddRequestHeadersL):
• ResourceLoader/src/UrlRequestInfo.cpp: (CUrlRequestInfo::ConstructL): (CUrlRequestInfo::SetRefererUrlL):

1:29 PM Changeset in webkit [18001] by darin

• 2 edits in trunk/WebCore

Reviewed by Beth.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11632 AKA <rdar://problem/4858866> REGRESSION (r17770): Overflow areas' scrollbars don't work

No test case added at the moment, but Beth said she'd investigate
adding one after the fact.

• page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMousePressEventToScrollbar): Fix obvious-in-retrospect copy and paste error -- call passMouseDownEventToWidget instead of passWheelEventToWidget.

11:37 AM Changeset in webkit [18000] by ap

• 12 edits
  5 adds in trunk

2006-12-04 Don Gibson <​dgibson77@gmail.com>

Reviewed and landed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=11738:
Make link clicking work again on Windows.

WebCore:

This re-implements a few functions that used to be part of FrameWin in
their new loader-based locations, and copies a few things from the Mac
and Qt event handling code that aren't strictly necessary but are
pretty simple.

• WebCore.vcproj/WebCore/WebCore.vcproj:
• bridge/win/ChromeClientWin.h:
• bridge/win/ContextMenuClientWin.h:
• bridge/win/EditorClientWin.h:
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::client):
• bridge/win/FrameWin.h:
• loader/win/DocumentLoaderWin.cpp: Added. (WebCore::DocumentLoader::setTitle):
• loader/win/FrameLoaderClientWin.cpp: Added. (WebCore::FrameLoaderClientWin::userAgent):
• loader/win/FrameLoaderClientWin.h:
• loader/win/FrameLoaderWin.cpp: Added. (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::setTitle):
• page/win/EventHandlerWin.cpp: Added. (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passWheelEventToSubframe): (WebCore::EventHandler::passMousePressEventToScrollbar): (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
• platform/win/TemporaryLinkStubs.cpp: (WebCore::EventHandler::tabsToLinks): (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::lastEventIsMouseUp): (WebCore::EventHandler::passSubframeEventToSubframe): (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::historyURL): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoaderClientWin::setTitle):

WebKit:

The WebKit changes are to ignore WM_MOUSEMOVED messages when the mouse
hasn't actually moved, which were preventing clicks from actually
getting dispatched in many cases. It's a peculiarity of Windows mouse
handling that we receive these at all.

• COM/WebView.cpp: (WebView::WebView): (WebView::mouseMoved):
• COM/WebView.h:

10:49 AM Changeset in webkit [17999] by ap

• 4 edits in trunk/WebCore

2006-12-04 Don Gibson <​dgibson77@gmail.com>

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11748:
Windows build bustage.

• WebCore.vcproj/WebCore/WebCore.vcproj:
• platform/ContextMenuItem.h:
• platform/win/TemporaryLinkStubs.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::platformDescription): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu):

10:24 AM Changeset in webkit [17998] by sullivan

• 2 edits
  1 move
  1 add in trunk/WebCore

Reviewed by Anders

Moved EditorMac.mm to its appropriate location

• platform/mac/EditorMac.mm: Removed.
• editing/mac/EditorMac.mm: Added

• WebCore.xcodeproj/project.pbxproj: updated for this change

9:07 AM Changeset in webkit [17997] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Anders

• fixed <rdar://problem/4857833> REGRESSION: When ctrl-clicking on a misspelled word, "Ignore Spelling" and "Learn Spelling" menu items not displayed in the contextual menu

• WebView/WebHTMLView.m: (-[WebHTMLView _isSelectionMisspelled]): We were computing isSelectionMisspelled by calling WebCore, but then ignoring the result and always returning NO. D'oh!

7:14 AM Changeset in webkit [17996] by yongjzha

• 6 edits in S60/trunk/WebKit

2006-12-01 yaharon <​yael.aharon@nokia.com>

Reviewed by Yongjun <​yongjun.zhang@nokia.com>
DESC: [S60] Add platform scrollbars support, behind feature flag
​http://bugs.webkit.org/show_bug.cgi?id=11736

• BrowserControl/inc/BrCtl.h: (MBrHistoryInterface::~MBrHistoryInterface): (NONSHARABLE_CLASS): (CBrCtl::WmlEngineInterface):
• BrowserControl/inc/BrCtlScrollingProvider.h: (NONSHARABLE_CLASS):
• BrowserControl/src/BrCtl.cpp: (CBrCtl::ConstructL): (CBrCtl::~CBrCtl): (CBrCtl::DrawScrollbarBackground): (CBrCtl::MopSupplyObject): (CBrCtl::Draw): (CBrCtl::HandleResourceChange):
• BrowserControl/src/BrCtlScrollingProvider.cpp: (CBrCtlScrollingProvider::NewL): (CBrCtlScrollingProvider::ConstructL): (CBrCtlScrollingProvider::~CBrCtlScrollingProvider): (CBrCtlScrollingProvider::UpdateVScrollBarL): (CBrCtlScrollingProvider::UpdateHScrollBarL): (CBrCtlScrollingProvider::NotifyLayoutChange): (CBrCtlScrollingProvider::VScrollBarWidth): (CBrCtlScrollingProvider::HScrollBarHeight): (CBrCtlScrollingProvider::VScrollBar): (CBrCtlScrollingProvider::HScrollBar): (CBrCtlScrollingProvider::ScrollBarCornerWindow): (CBrCtlScrollingProvider::SetScrollDisplayRect): (CBrCtlScrollingProvider::ResizeBrCtlView): (CBrCtlScrollingProvider::ShiftBrCtlView): (CBrCtlScrollingProvider::HandleScrollEventL): (CBrCtlScrollingProvider::SkinChangedL): (CBrCtlScrollingProvider::DrawBackground):
• BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):
• ChangeLog:

1:21 AM Changeset in webkit [17995] by rwlbuis

• 3 edits
  4 adds in trunk

Reviewed by dhyatt.

Patch by pmax.

​http://bugs.webkit.org/show_bug.cgi?id=3280
With LEGEND element, align=right value is not supported
​http://bugs.webkit.org/show_bug.cgi?id=11544
<legend> rendering doesn't take align into account

Allow aligning for legends in both RTL and LTR mode.

Dec 3, 2006:

4:16 PM Changeset in webkit [17994] by bdash

• 2 edits in trunk/WebCore

2006-12-03 Mark Rowe <​bdash@webkit.org>

Reviewed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=11730
Bug 11730: Meta HTTP Refresh that contains a fraction / decimal get ignored.

• dom/Document.cpp: (WebCore::Document::processHttpEquiv): Parse the refresh interval as a double rather than an integer.

8:29 AM Changeset in webkit [22607] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

2006-12-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.

<rdar://4853816> CFNetwork crash on Vista loading any SSL page

Change link order so secur32.dll is initialized prior to its
indirect use in code called by CoreGraphics DllMain.

To help avoid similar problems in the future, I reordered the
imported DLLs by level/dependency so things like CoreFoundation
is listed prior to CFNetwork and CoreGraphics.

• WebKit.vcproj/WebKit.vcproj:

5:36 AM Changeset in webkit [17993] by zimmermann

• 13 edits
  16 adds in trunk

Reviewed by Oliver.

Fix following bugs:
​http://bugs.webkit.org/show_bug.cgi?id=11734
​http://bugs.webkit.org/show_bug.cgi?id=11685

SVGPoint/SVGRect/SVGNumber were missing put() support.
SVGPoint.matrixTransform() was missing.

4:19 AM Changeset in webkit [17992] by zimmermann

• 2 edits
  1 move in trunk/WebCore

Reviewed by Dave.
Another missing piece in the platform/graphics move.

4:02 AM Changeset in webkit [17991] by rwlbuis

• 10 edits
  4 adds in trunk

Reviewed by Oliver.

​http://bugs.webkit.org/show_bug.cgi?id=11667
SVG: method .getTransformToElement(elt) in SVGLocatable not implemented

Implement getTransformToElement functionality. Introduce virtual
baseclass SVGLocatable to allow one implementation of the functionality.
Finally cleanup some code.

3:55 AM Changeset in webkit [17990] by zimmermann

• 3 edits
  2 moves in trunk/WebCore

Reviewed by Rob.
Move some files around, which have been forgotton in the platform/graphics move.

3:39 AM Changeset in webkit [17989] by zimmermann

• 3 edits in trunk/WebCore

Reviewed by Mitz.
Fix non-svg build. (At least hope BuildBot doesn't moan anymore :-)

1:07 AM Changeset in webkit [17988] by ap

• 4 edits in trunk/LayoutTests

Reviewed by Mitz.

This test used to be a pixel one, but without pixel results provided - converted to text.

• http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt:
• http/tests/xmlhttprequest/frame-load-cancelled-abort.html:

• http/tests/xmlhttprequest/resources/frame-load-to-cancel.html: Added a parameter to send() to make the test work in Firefox.

Dec 2, 2006:

6:48 AM Changeset in webkit [17987] by sullivan

• 2 edits in trunk/WebCore

Reviewed by Tim Omernick

Removed a couple of big chunks of duplicated code from the spelling and grammar stuff by merging
the find-next-instance functions with the mark-all-instances functions.

• bridge/mac/FrameMac.mm: (WebCore::findFirstMisspellingInRange): added markAll parameter, and reworked loop so that if markAll parameter is true, this function loops through the entire range and marks each misspelling (WebCore::findFirstGrammarDetailInRange): extracted from findFirstBadGrammarInRange; loops through the potentially-multiple details in a given ungrammatical phrase (e.g., multiple grammar errors in one sentence). Has a markAll parameter akin to the one in findFirstMisspellingInRange. (WebCore::findFirstBadGrammarInRange): added markAll parameter like the one in findFirstMisspellingInRange, and extracted findFirstGrammarDetailInRange (WebCore::FrameMac::advanceToNextMisspelling): pass "false" for new markAll parameters (WebCore::markAllMisspellingsInRange): now just calls findFirstMisspellingInRange with markAll = true, thus removing a big hunk of duplicated code (WebCore::markAllBadGrammarInRange): now just calls findFirstBadGrammarInRange with markAll = true, thus removing a big hunk of duplicated code

6:02 AM Changeset in webkit [17986] by ap

• 3 edits
  4 adds in trunk

2006-12-02 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11672 REGRESSION (r17068): Repro crash due to painting without layout

Test: fast/dynamic/containing-block-change.html

• rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Changed the logic used to find absolutely positioned descendant's current containing block to match the changes made to containingBlock() in the fix for bug 9347.

5:41 AM Changeset in webkit [17985] by ap

• 3 edits in trunk/WebCore

2006-12-02 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11709
DeprecatedString::format is broken on Windows

Use _vscprintf on Windows to compute the length of the buffer that
vsnprintf would need.

• platform/DeprecatedString.cpp: (WebCore::DeprecatedString::format):
• platform/String.cpp: (WebCore::String::format):

Dec 1, 2006:

6:52 PM Changeset in webkit [22606] by bdakin

• 7 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Support for sub-menus in WebCore context menus. Also some
adjustments to make ContextMenuItem class a wrapper for the
platformDescription. (In this case, a wrapper for LPMENUITEMINFO.)

• WebCore.vcproj/WebCore.vcproj:
• platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::platformDescription): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setSubMenu):
• platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::insertItem):

WebKitWin:

Reviewed by Adam.

Changes to support sub-menus for WebCore ContextMenus.

• Interfaces/IWebUIDelegate.idl: New tags.
• WebContextMenuClient.cpp: (WebContextMenuClient::contextMenuItemSelected): ContextMenu::menu () is now called parentMenu()

6:35 PM Changeset in webkit [17984] by bdakin

• 12 edits
  1 add in trunk

WebCore:

Reviewed by Adam.

Support for sub-menus in WebCore context menus. This also re-
architects the ContextMenuItem class so that it is more like
ContextMenu in that the class is now really just a wrapper for the
platformDescription

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:
• page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Add place-holders for new tags for the sub-menu items. I will flesh these out in a separate check-in.
• platform/ContextMenu.cpp: (WebCore::createFontSubMenu): (WebCore::createSpellingAndGrammarSubMenu): (WebCore::createSpellingSubMenu): (WebCore::createSpeechSubMenu): (WebCore::createWritingDirectionSubMenu): (WebCore::ContextMenu::populate): Call the above functions to add the appropriate sub-menus to editing context menus.
• platform/ContextMenu.h:
• platform/ContextMenuItem.h: (WebCore::): New tags in the ContextMenuAction enumeration. (WebCore::ContextMenuItem::parentMenu): (WebCore::ContextMenuItem::setType):
• platform/PlatformMenuDescription.h: Added. This defines PlatformMenuDesciption. It needs to be its own header because we

have to include it from ContextMenu.h and ContextMenuItem.h

• platform/mac/ContextMenuItemMac.mm: Lots of adjustments here to make this class basically just be a wrapper for NSMenuItem. (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): (WebCore::ContextMenuItem::platformDescription): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setSubMenu):
• platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::ContextMenu): (WebCore::getNSMenuItem): Now we only have to get the platformDescription of the ContextMenuItem and then set its target and action. (WebCore::ContextMenu::itemCount):

WebKit:

Reviewed by Adam.

Changes to support sub-menus in WebCore ContextMenus.

• WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuItemSelected): ContextMenuItem::menu() is now called parentMenu()
• WebView/WebUIDelegatePrivate.h: New not-yet-API tags.

4:36 PM Changeset in webkit [17983] by kmccullo

• 2 edits in trunk/WebCore

Reviewed by .

• accidentally checked in with previous checkin

• platform/qt/FrameQt.cpp: (WebCore::FrameQt::keyEvent):

4:23 PM Changeset in webkit [17982] by kmccullo

• 5 edits in trunk/WebCore

Reviewed by Adam.

• better solution to the ambiguous reference

• platform/Widget.h: (WebCore::Widget::handleMouseMoveEvent): (WebCore::Widget::handleMouseReleaseEvent):
• platform/qt/FrameQt.cpp: (WebCore::FrameQt::keyEvent):
• platform/win/PlatformScrollBar.h:
• platform/win/TemporaryLinkStubs.cpp: (WebCore::PlatformScrollbar::handleMouseMoveEvent): (WebCore::PlatformScrollbar::handleMouseReleaseEvent):

3:40 PM Changeset in webkit [17981] by justing

• 58 edits in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4826940>
Selection change performed even when delete delegate replies NO (11415)

Removed unnecessary shouldChangeSelection calls;

• editing/deleting/delete-at-start-or-end-expected.txt:
• editing/deleting/delete-br-002-expected.txt:
• editing/deleting/delete-br-004-expected.txt:
• editing/deleting/delete-br-005-expected.txt:
• editing/deleting/delete-br-006-expected.txt:
• editing/deleting/delete-br-009-expected.txt:
• editing/deleting/delete-br-010-expected.txt:
• editing/deleting/delete-br-012-expected.txt:
• editing/deleting/delete-hr-expected.txt:
• editing/deleting/delete-tab-004-expected.txt:
• editing/deleting/forward-delete-expected.txt:
• editing/deleting/merge-into-empty-block-1-expected.txt:
• editing/deleting/merge-into-empty-block-2-expected.txt:
• editing/execCommand/format-block-expected.txt:
• editing/execCommand/outdent-selection-expected.txt:
• editing/inserting/editing-empty-divs-expected.txt:
• editing/inserting/insert-3800346-fix-expected.txt:
• editing/inserting/insert-br-004-expected.txt:
• editing/inserting/insert-br-005-expected.txt:
• editing/inserting/insert-br-006-expected.txt:
• editing/inserting/insert-br-008-expected.txt:
• editing/inserting/insert-div-006-expected.txt:
• editing/inserting/insert-div-008-expected.txt:
• editing/inserting/insert-div-010-expected.txt:
• editing/inserting/insert-div-011-expected.txt:
• editing/inserting/insert-div-013-expected.txt:
• editing/inserting/insert-div-015-expected.txt:
• editing/inserting/insert-div-019-expected.txt:
• editing/inserting/insert-div-021-expected.txt:
• editing/inserting/insert-paragraph-01-expected.txt:
• editing/inserting/insert-paragraph-03-expected.txt:
• editing/inserting/insert-tab-004-expected.txt:
• editing/inserting/insert-text-with-newlines-expected.txt:
• editing/inserting/line-break-expected.txt:
• editing/pasteboard/3976872-expected.txt:
• editing/pasteboard/paste-text-005-expected.txt:
• editing/pasteboard/paste-text-006-expected.txt:
• editing/pasteboard/paste-text-007-expected.txt:
• editing/pasteboard/paste-text-010-expected.txt:
• editing/pasteboard/paste-text-014-expected.txt:
• editing/pasteboard/paste-text-016-expected.txt:
• editing/pasteboard/quirks-mode-br-2-expected.txt:
• editing/style/apple-style-editable-mix-expected.txt:
• editing/style/block-style-001-expected.txt:
• editing/style/block-style-002-expected.txt:
• editing/style/block-style-003-expected.txt:
• editing/style/block-style-006-expected.txt:
• editing/style/create-block-for-style-005-expected.txt:
• editing/style/create-block-for-style-006-expected.txt:
• editing/style/create-block-for-style-008-expected.txt:
• editing/style/relative-font-size-change-002-expected.txt:
• editing/style/relative-font-size-change-003-expected.txt:
• editing/style/relative-font-size-change-004-expected.txt:
• editing/style/table-selection-expected.txt:

WebCore:

Reviewed by john

<rdar://problem/4826940>
Selection change performed even when delete delegate replies NO (11415)

No layout test for the bug fix, because there's no way to register a custom
editing delegate from a layout test. Layout tests are effected by the change
to avoid sending unnecessary shouldChangeSelections, however.

• editing/Editor.cpp: (WebCore::Editor::appliedEditing): Don't bother sending shouldChangeSelection if the editing operation didn't change the selection. Still call setSelection though, because it does work in this case that's necessary, like clearing the typing style. (WebCore::Editor::unappliedEditing): Ditto. (WebCore::Editor::reappliedEditing): Ditto.
• editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Don't set the starting selection if the editing delegate returns NO from shouldDeleteRange. Notice we now call setStartingSelection in the case where the current selection was a range selection. This is fine because it's a no-op (the starting selection is already the current selection). (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.

3:32 PM Changeset in webkit [17980] by sullivan

• 4 edits in trunk/WebCore

Reviewed by Darin

Move subrange helper function from spellchecking code to TextIterator

• editing/TextIterator.h: added TextIterator::subrange
• editing/TextIterator.cpp: (WebCore::CharacterIterator::advance): early return if count is <= 0; assert that it's not < 0 (WebCore::TextIterator::subrange): new function, moved from FrameMac.mmm

• bridge/mac/FrameMac.mm: moved subrange() function to TextIterator (WebCore::FrameMac::advanceToNextMisspelling): use TextIterator::subrange (WebCore::markAllMisspellingsInRange): ditto (WebCore::markAllBadGrammarInRange): ditto

2:53 PM Changeset in webkit [17979] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-004/JavaScriptCore

Tag for JavaScriptCore for Security Update 2006-004 (unchanged from 10.4.7).

2:52 PM Changeset in webkit [17978] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-004/JavaScriptGlue

Tag for JavaScriptGlue for Security Update 2006-004 (unchanged from 10.4.7).

2:51 PM Changeset in webkit [17977] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-004/WebKit

Tag for WebKit for Security Update 2006-004 (unchanged from 10.4.7).

2:46 PM Changeset in webkit [17976] by darin

• 31 edits
  1 delete in trunk

WebCore:

Reviewed by Mitz.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11628 REGRESSION (r17597): Command-return in native text fields doesn't open a new tab or window

I couldn't think of an easy way to make a regression test for this, but maybe
I'll get an idea later about how to do it.

The main thing I did was add a concept of a DOM event having an "underlying event".
That allows the DOM activate event to contain inside it the original keyboard event
that triggered the form submission, and thus allows WebKit to see the modifier keys
from that original event. The code that uses the underlying event is in WebKit, but
the code to set it up is here in WebCore.

• also do some clean-up to related event handling code

• bindings/js/kjs_events.cpp: (KJS::DOMEvent::getValueProperty): Updated for the name change of cancelBubble.

• dom/Event.h: Removed a useless comment. Fixed some whitespace and formatting. Renamed getCancelBubble to cancelBubble to match the DOM -- I suspect the old name predated the use of the m_ prefix on data members. Added the underlying event, and a getter and setter.
• dom/Event.cpp: (WebCore::Event::setTarget): Updated to take a PassRefPtr. (WebCore::Event::setUnderlyingEvent): Added.

• dom/EventTargetNode.h: Added an optional underlyingEvent parameter to dispatchUIEvent, one of the overloads of dispatchMouseEvent, and dispatchSimulatedMouseEvent. Added a new dispatchSimulatedClick function here that mostly replaces the click function in HTMLElement.
• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent): Updated for the name change of cancelBubble. (WebCore::EventTargetNode::dispatchUIEvent): Added an underlying event parameter, which gets attached to the UIEvent object after it's created. (WebCore::EventTargetNode::dispatchMouseEvent): Tweaked formatting and parameter name for the version that creates a mouse event for a real platform mouse event. Added an underlying event parameter to the main version, and attached it to all three of the events that can be dispatched. (WebCore::EventTargetNode::dispatchSimulatedMouseEvent): Added an underlying event parameter, passed it along to dispatchMouseEvent. (WebCore::EventTargetNode::dispatchSimulatedClick): Moved this here from HTMLElement and renamed it from click. Added an underlyingEvent parameter, and passed that along in all three of the calls to dispatchSimulatedMouseEvent.

• bridge/mac/FrameMac.mm: (WebCore::FrameMac::shouldClose): Updated call to setTarget that no longer needs a get().
• ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible): Ditto.

• html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Converted a call to click to a call to dispatchSimulatedClick. (WebCore::HTMLAnchorElement::accessKeyAction): Ditto.
• html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::accessKeyAction): Ditto.
• html/HTMLElement.h: Removed the parameters to click and made it non-virtual. We could move it down to the input and button elements, now that it's just a single function call, but it's also OK to just leave it here.
• html/HTMLElement.cpp: (WebCore::HTMLElement::click): Removed the parameters and changed this to just call dispatchSimulatedClick. The real work is now in dispatchSimulatedClick. (WebCore::HTMLElement::accessKeyAction): Converted a call to click to a call to dispatchSimulatedClick.
• html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submitClick): Ditto. But unlike accessKeyAction callers, pass the event along as the underlying event.
• html/HTMLInputElement.h:
• html/HTMLInputElement.cpp: Removed override of virtual click function. The special cases for the file control and hidden input elements aren't needed. (WebCore::HTMLInputElement::accessKeyAction): Converted a call to click to a call to dispatchSimulatedClick. (WebCore::HTMLInputElement::defaultEventHandler): Converted calls to click to calls to dispatchSimulatedClick, passing along the event as the underlying event.
• html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::defaultEventHandler): Converted a call to click to a call to dispatchSimulatedClick, passing the event along as the underlying event. Also changed the local variable for the element to a RefPtr since the code assumes it's still around after calling arbitrary JavaScript code.
• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::accessKeyAction): Converted a call to click to a call to dispatchSimulatedClick.

• rendering/RenderFileUploadControl.h:
• rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click): Removed unneeded ignored parameter to the click function, and also made it non-virtual.

• loader/NavigationAction.h: Removed unneeded includes.
• loader/NavigationAction.cpp: Moved all the code here from NavigationActionMac.mm, since none of it is Mac-specific any more.
• loader/mac/NavigationActionMac.mm: Removed.
• WebCore.xcodeproj/project.pbxproj: Updated for removed file.

• ksvg2/svg/SVGAElement.cpp: Removed an unnecessary include.

• loader/FrameLoader.cpp: Added a newly-needed incluude.
• loader/mac/DocumentLoaderMac.mm: Ditto.
• loader/mac/FrameLoaderMac.mm: Ditto.
• rendering/RenderWidget.cpp: Ditto.

WebKit:

Reviewed by Mitz.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11628 REGRESSION (r17597): Command-return in native text fields doesn't open a new tab or window

• WebCoreSupport/WebFrameLoaderClient.mm: (findKeyStateEvent): Added. Helper that finds the mouse or keyboard event in a chain of events and their underlying events. (findMouseEvent): Added. Same, but specifically for mouse events. (WebFrameLoaderClient::actionDictionary): Rewrote to use the above functions. This means we use the modifiers from the underlying events rather than just the one from the event itself. So if the event is a DOM activate event, we can still see the modifiers from the original keyboard event that triggered it. Has no effect if the event is already the right type or if there is no underlying event.

• WebView/WebFrame.mm: Added a newly-needed include.

• WebKit.xcodeproj/project.pbxproj: Xcode wants what it wants.

2:44 PM Changeset in webkit [17975] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-004/WebCore

Tag for WebCore for Security Update 2006-004.

2:43 PM Changeset in webkit [17974] by thatcher

• 1 add in releases/Apple/Tiger/Security Update 2006-004

New tag for Security Update 2006-004

2:33 PM Changeset in webkit [17973] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-007/WebKit

Tag for WebKit for Security Update 2006-007.

2:31 PM Changeset in webkit [17972] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-007/WebCore

Tag for WebCore for Security Update 2006-007 (unchanged from 10.4.8).

2:30 PM Changeset in webkit [17971] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-007/JavaScriptGlue

Tag for JavaScriptGlue for Security Update 2006-007 (unchanged from 10.4.8).

2:29 PM Changeset in webkit [17970] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-007/JavaScriptCore

Tag for JavaScriptCore for Security Update 2006-007 (unchanged from 10.4.8).

2:28 PM Changeset in webkit [17969] by thatcher

• 1 add in releases/Apple/Tiger/Security Update 2006-007

New tag for Security Update 2006-007

2:12 PM Changeset in webkit [17968] by sullivan

• 3 edits in trunk/WebCore

Reviewed by Darin

• fixed <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient context passed to grammar checker

• bridge/mac/FrameMac.mm: (WebCore::markAllMisspellingsInRange): new function, extracted from markMisspellings -- ignores grammar (WebCore::markAllBadGrammarInRange): new function, extracted from markMisspellings -- ignores spelling, and operates on appropriately-sized chunks of text (WebCore::FrameMac::markMisspellings): now calls markAllMisspellingsInRange and (optionally) markAllBadGrammarInRange rather than trying to interweave the spelling and grammar logic

1:31 PM Changeset in webkit [17967] by sullivan

• 1 edit in trunk/WebCore/ChangeLog

Removed stray conflict marker.

1:25 PM Changeset in webkit [17966] by sullivan

• 2 edits in trunk/WebCore

Reviewed by Darin

With these changes, grammar checking works correctly for the one-by-one case.
It still doesn't work correctly for the check-as-you-type case; I need to make these
same kinds of changes in markMisspellings, and refactor to share more code between
the two cases, but I wanted to get this working code in before modifying it further.

The major change here is that advanceToNextMisspelling used to look at small chunks of
text at a time, checking each one for both misspellings and questionable grammar. But
grammar checking needs at least paragraph-sized chunks of text to have enough context
to work correctly, so the old mechanism was causing many spurious complaints of bad
grammar (e.g., almost every word seemed to be at the start of a sentence so the checker
would complain about missing capitalization). So now the spell checker runs in the
specified range first. Then the grammar checker runs on the same range (stopping at the
next misspelling, if any), but expanded to paragraph-aligned boundaries.

• bridge/mac/FrameMac.mm: (WebCore::findFirstMisspellingInRange): new function, extracted from advanceToNextMisspelling, and ignores grammar (WebCore::paragraphAlignedRangeForRange): new function, used by findNextBadGrammarInRange (WebCore::findFirstBadGrammarInRange): new function, extracted from advanceToNextMisspelling, and rewritten to use paragraph-aligned chunks, and ignores spelling (WebCore::subrange): new helper function, used by advanceToNextMisspelling (WebCore::FrameMac::advanceToNextMisspelling): now calls out to both findFirstMisspellingInRange and findFirstBadGrammarInRange separately instead of trying to interweave the spelling and grammar logic

1:21 PM Changeset in webkit [17965] by rwlbuis

• 14 edits in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11732:
Windows build bustage.

1:11 PM Changeset in webkit [17964] by yongjzha

• 4 edits in S60/branches/3.1m/WebKit

2006-11-30 yaharon <​yael.aharon@nokia.com>

Reviewed by Yongjun <​yongjun.zhang@nokia.com>
DESC: [S60] JKRL-6VDTV8: browser crash on empty cache data when loading aborted
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11727

• BrowserControl/inc/BrCtl.h:
• BrowserControl/src/BrCtl.cpp: (CBrCtl::CBrCtl): (CBrCtl::HandleBrowserLoadEventL): (CBrCtl::HandleCommandL): (CBrCtl::UpdateLoadState): (CBrCtl::UnloadDllWmlEngine):
• BrowserView/src/LoadListeners.cpp: (CWmlResourceLoadListener::ResponseL): (CWmlResourceLoadListener::Complete):

1:06 PM Changeset in webkit [17963] by yongjzha

• 4 edits in S60/trunk/WebKit

2006-11-30 yaharon <​yael.aharon@nokia.com>

Reviewed by Yongjun <​yongju.zhang@nokia.com>
DESC: [S60] JKRL-6VDTV8: browser crash on empty cache data when loading aborted
​http://bugs.webkit.org/show_bug.cgi?id=11727

• BrowserControl/inc/BrCtl.h: (CBrCtl::HttpLoaderEventToUi):
• BrowserControl/src/BrCtl.cpp: (CBrCtl::CBrCtl): (CBrCtl::HandleBrowserLoadEventL): (CBrCtl::HandleCommandL): (CBrCtl::UpdateLoadState): (CBrCtl::UnloadDllWmlEngine):
• BrowserView/src/LoadListeners.cpp: (CWmlResourceLoadListener::ResponseL): (CWmlResourceLoadListener::Complete):

11:08 AM Changeset in webkit [22605] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

2006-12-01 Steve Falkenburg <​sfalken@apple.com>

Fix post-build step.
Need to copy CoreFoundation resources.
Bundles aren't config specific - removed ConfigSuffix from copy commands for resources.

• WebKit.vcproj\WebKit.vcproj:

10:44 AM Changeset in webkit [17962] by thatcher

• 4 edits
  1 add in trunk/WebKit

Reviewed by Adam.

<rdar://problem/4841432> 9A312: iWeb crashes on launch; _WebReportError missing from WebKit

Added back WebReportAssertionFailure and WebReportError for apps that still need these symbols.

• Misc/OldWebAssertions.c: Added. (WebReportAssertionFailure): (WebReportError):
• WebKit.LP64.exp: added the new symbols, and sorted the file
• WebKit.exp: added the new symbols, and sorted the file
• WebKit.xcodeproj/project.pbxproj:

10:34 AM Changeset in webkit [17961] by thatcher

• 2 edits in trunk/WebKit/Misc

Correcting the copyright date since these are new files.

Nov 30, 2006:

11:28 PM Changeset in webkit [22604] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

11:22 PM Changeset in webkit [17960] by sfalken

• 1 copy in tags/Safari-521.31.4

New tag.

10:35 PM Changeset in webkit [22603] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

2006-11-30 Steve Falkenburg <​sfalken@apple.com>

Fix build.
Link against new WTF.lib

• WebKit.vcproj/WebKit.vcproj:

9:42 PM Changeset in webkit [17959] by sfalken

• 4 edits
  2 adds in trunk/JavaScriptCore

2006-11-30 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Oliver.

Move WTF from JavaScriptCore project into a new WTF project.

• JavaScriptCore.vcproj/JavaScriptCore.sln: Add WTF.vcproj to sln
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Remove WTF source files
• JavaScriptCore.vcproj/WTF/WTF.vcproj: Added.
• JavaScriptCore.vcproj/testkjs/testkjs.vcproj: Add dependency on WTF.lib

8:23 PM Changeset in webkit [22602] by ggaren

• 2 edits in branches/WindowsMerge/WebCore

Rubber Stamped by Anders Carlsson.

Global rename of Document::focusNode to Document::focusedNode. 'focusNode'
suggested a command, and conflicted with a different meaning for 'focusNode'
in the Mozilla selection API.

• bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyEvent):

8:15 PM Changeset in webkit [17958] by ggaren

• 24 edits in trunk

WebCore:

Rubber Stamped by Anders Carlsson.

Global rename of Document::focusNode to Document::focusedNode. 'focusNode'
suggested a command, and conflicted with a different meaning for 'focusNode'
in the Mozilla selection API.

WebKit:

Rubber Stamped by Anders Carlsson.

Global rename of Document::focusNode to Document::focusedNode. 'focusNode'
suggested a command, and conflicted with a different meaning for 'focusNode'
in the Mozilla selection API.

• WebView/WebHTMLView.m: (-[NSArray clearFocus]):

6:16 PM Changeset in webkit [17957] by zbujtas

• 2 edits in S60/trunk/WebCore

2006-11-30 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Tabbed navigation fixes
​http://bugs.webkit.org/show_bug.cgi?id=11725

WARNING: NO TEST CASES ADDED OR CHANGED

• kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition): (KWQKHTMLPart::tabbedNavigation):

5:53 PM Changeset in webkit [22601] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

5:47 PM Changeset in webkit [17956] by sfalken

• 1 copy in tags/Safari-521.31.3

New tag.

4:57 PM Changeset in webkit [22600] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Lather, rinse, repeat.

• platform/win/GraphicsContextWin.cpp: (WebCore::contextForImage):

4:55 PM Changeset in webkit [17955] by sullivan

• 15 edits in trunk

LayoutTests:

Reviewed by Justin

• editing/execCommand/create-list-from-range-selection-expected.checksum:
• editing/execCommand/create-list-from-range-selection-expected.png:
• editing/execCommand/create-list-from-range-selection-expected.txt:
• editing/execCommand/create-list-from-range-selection.html: This test's results were broken by using rangeCompliantEquivalent at appropriate places in CompositeEditCommand.cpp::moveParagraphs(), presumably by revealing a different bug. Justin is going to look into this; for now I've updated the result so that it won't appear to fail for others.

• editing/execCommand/create-list-with-hr-expected.checksum:
• editing/execCommand/create-list-with-hr-expected.png:
• editing/execCommand/create-list-with-hr-expected.txt:
• editing/execCommand/create-list-with-hr.html: This test's results were improved by using rangeCompliantEquivalent at appropriate places in CompositeEditCommand.cpp::moveParagraphs() -- it used to create an extra <div>, and now it does not.

WebCore:

Reviewed by Justin

With Darin, fixed a problem in the Range constructors found while implementing grammar checking.
That revealed another problem in the layout tests involving bad parameters passed to the Range
constructors.

With these fixes in place, one layout test (editing/execCommand/create-list-from-range-selection.html)
no longer works as intended. This is apparently due to yet another bug being flushed out somewhere.
I'm going to update the results for that test and file a separate radar about it, which Justin will
investigate.

• dom/Position.h: removed equivalentRangeCompliantPosition(), which was declared but not implemented or called.

• dom/Range.cpp: (WebCore::Range::Range): Call setStart and setEnd in the two Range constructors that take parameters, rather than just directly setting the instance variables. This makes Range perform the boundary checks and compensations that the DOM spec requires.

• editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Use rangeCompliantEquivalent() on "editing-style" Positions before creating Ranges from them.

• editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): Assert that the boundary points of the range are valid.

4:18 PM Changeset in webkit [22599] by aroben

• 3 edits
  1 delete in branches/WindowsMerge/WebCore

Build fix.

• platform/graphics/cg/GraphicsContextCG.cpp: Removed. This file was un-forked a while ago.
• platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::platformDescription):
• platform/win/GraphicsContextWin.cpp: (WebCore::contextForImage):

4:14 PM Changeset in webkit [17954] by thatcher

• 3 edits in trunk/WebKit

Reviewed by Mitz.

Bug 10698: Scroll wheel causes inspector to shift up
​http://bugs.webkit.org/show_bug.cgi?id=10698

Remove size attribute from the tree popup as a workaround for
​http://bugs.webkit.org/show_bug.cgi?id=11362 Bug 11362: Native popup with size="1" wraps options

• WebInspector/webInspector/inspector.css:
• WebInspector/webInspector/inspector.html:

4:11 PM Changeset in webkit [17953] by thatcher

• 3 edits in trunk/WebKit

Reviewed by Tim H.

Move web inspector style markup to javascript to fix ​http://bugs.webkit.org/show_bug.cgi?id=6724
Bug 6724: Text copied from Web Inspector is different from actual text

• WebInspector/webInspector/inspector.css:
• WebInspector/webInspector/inspector.js:

4:03 PM Changeset in webkit [17952] by thatcher

• 1 edit in trunk/WebCore/ChangeLog

Removing the conflict marker.

3:50 PM Changeset in webkit [17951] by spadma

• 2 edits in S60/branches/3.1m/WebKit

2006-11-30 sareen <​shyam.sareen@nokia.com>

Reviewed by spadma <​Sachin.Padma@nokia.com>
DESC: Browser crashes when loading local page with iFrame.
​http://bugs.webkit.org/show_bug.cgi?id=11728

• ResourceLoader/src/HttpStackConfig.cpp: (THttpStackConfig::AddSessionFiltersL): (THttpStackConfig::InstallAuthenticationFilterL): (THttpStackConfig::InstallCookieFilterL): (THttpStackConfig::InstallUaProfFilterL): (THttpStackConfig::InstallConnHandlerFilterL): (THttpStackConfig::InstallIopFilterL):

3:45 PM Changeset in webkit [17950] by spadma

• 2 edits in S60/trunk/WebKit

2006-11-30 sareen <​shyam.sareen@nokia.com>

Reviewed by spadma <​Sachin.Padma@nokia.com>
DESC: Browser crashes when loading local page with iFrame.
​http://bugs.webkit.org/show_bug.cgi?id=11728

• ResourceLoader/src/HttpStackConfig.cpp: (THttpStackConfig::AddSessionFiltersL): (THttpStackConfig::InstallAuthenticationFilterL): (THttpStackConfig::InstallCookieFilterL): (THttpStackConfig::InstallUaProfFilterL): (THttpStackConfig::InstallConnHandlerFilterL): (THttpStackConfig::InstallIopFilterL):

2:48 PM Changeset in webkit [22598] by aroben

• 4 edits in branches/WindowsMerge/WebCore

Build fix.

• WebCore.vcproj/WebCore.vcproj:
• platform/graphics/svg/cg/SVGResourceFilterCg.cpp: (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter): (WebCore::SVGResourceFilter::createFilterEffect):
• platform/graphics/svg/cg/SVGResourceMaskerCg.cpp: (WebCore::SVGResourceMasker::applyMask):

2:29 PM Changeset in webkit [17949] by lamadio

• 3 edits in trunk/WebCore

2006-11-30 Lou Amadio <​lamadio@apple.com>

Reviewed by Dave Hyatt
Cleaned up generated files.

2:07 PM Changeset in webkit [17948] by aroben

• 7 edits in trunk

WebCore:

Reviewed by Beth.

Store ContextMenu's NSMutableArray inside a RetainPtr so that we
will retain/release it correctly.

• WebCore.exp:
• platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Added a FIXME.
• platform/ContextMenu.h:
• platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::getNSMenuItem): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::setPlatformDescription): (WebCore::ContextMenu::platformDescription):

WebKit:

Reviewed by Beth.

Put code in place to use WebCore context menus when they are turned
on.

• WebView/WebHTMLView.m: (-[NSArray menuForEvent:]):

1:47 PM Changeset in webkit [17947] by zimmermann

• 81 edits
  4 copies
  1 delete in trunk/WebCore

Reviewed by Eric. Rubber stamped by Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10383

This is the final patch after the long "die kcanvas" journey.

All old kcanvas code is gone now, and properly integrated within
WebCore (stuff like GraphicsContext changes etc.). It shares
the platform/ design concept: no subclassing, but instead
implementing parts of the classes/methods per-platform.

This commit removes the last pieces: KRenderingDevice & KRenderingDeviceContext.
This layer was just obsolete, given the powerful GraphicsContext API we have
since quite a while now. All the ugly pushContext/popContext stuff is gone now.

The naming issues Cg vs. CG will be fixed in one shot, when moving the whole
platform/graphics/svg directory down into ksvg2/graphics - as discussed with Darin.

1:13 PM Changeset in webkit [22597] by ggaren

• 4 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4844838> Whole document leak seen
running HTML iBench

• loader/win/FrameLoaderWin.cpp: Removed custom implementation for detachFromParent, since FrameLoader has a cross-platform version now.

WebKitWin:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4844838> Whole document leak seen
running HTML iBench

Copied *very nice* (NOT!) WebKit Mac idiom of calling
FrameLoader::detachFromParent when closing the WebView.
We need to do this so event listeners that retain the document
get destroyed, and so the unload event gets dispatched.

This is pretty silly. Instead, the document/frame/interpreter should
be responsible for cleaning up after itself.

• WebView.cpp: (WebView::close):

1:10 PM Changeset in webkit [17946] by yongjzha

• 2 edits in S60/trunk/WebKit

1:06 PM Changeset in webkit [17945] by ggaren

• 9 edits in trunk

JavaScriptCore:

Reviewed by Beth Dakin.

Fixed up garbage collection at window close time.

• kjs/interpreter.cpp: (KJS::Interpreter::~Interpreter): Garbage collect here, since destroying the interpreter frees the global object and therefore creates a lot of garbage.

WebCore:

Reviewed by Beth Dakin.

Fixed up garbage collection at window close time.

• bindings/js/kjs_proxy.cpp: Don't garbage collect in the KJSProxy destructor, since the global object hasn't been freed yet.
• bindings/js/kjs_proxy.h:
• loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromParent): Made this function cross- platform.
• loader/FrameLoader.h:
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::setTitle): Moved this function to FrameLoaderMac, since it's Mac-only. (WebCore::FrameLoader::closeBridge):
• page/Page.cpp: (WebCore::Page::~Page): Don't garbage collect in the Page destructor, since the Interpreter destructor will do it for us.

12:26 PM Changeset in webkit [17944] by spadma

• 2 edits in S60/trunk/WebKit

2006-11-30 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: If values are null in setPreferenceForKey remove them from the map.
​http://bugs.webkit.org/show_bug.cgi?id=11438

• BrowserView/src/WidgetPreferences.cpp: (CWidgetPreferences::SetPreferenceL):

12:23 PM Changeset in webkit [17943] by spadma

• 2 edits in S60/trunk/WebKit

2006-11-30 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: 3.1 & 3.2 Memory handling error in CHttpCacheEntry::Internalize(), BrowserCache.dll
​http://bugs.webkit.org/show_bug.cgi?id=11724

• ResourceLoader/CacheSrc/HttpCacheEntry.cpp: (CHttpCacheEntry::Internalize):

12:16 PM Changeset in webkit [17942] by spadma

• 8 edits in S60/trunk

2006-11-30 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Sachin Padma.
DESC: Refresh timer in the browser is not cancelled
​http://bugs.webkit.org/show_bug.cgi?id=11722

• BrowserControl/src/WmlDispatcher.cpp: (CWmlDispatcher::Complete):

12:06 PM Changeset in webkit [22596] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

2006-11-30 Steve Falkenburg <​sfalken@apple.com>

build WebKit.lib to proper directory

• WebKit.vcproj/WebKit.vcproj:

11:24 AM Changeset in webkit [17941] by spadma

• 5 edits in S60/trunk/WebKit

2006-11-30 sareen <​shyam.sareen@nokia.com>

Reviewed by Sachin Padma.
DESC: [s60] Saved Pages: Some Images not saved with the page.
​http://bugs.webkit.org/show_bug.cgi?id=11721

• BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
• ResourceLoader/inc/UrlRequestInfo.h: (CUrlRequestInfo::IsSavedPageRequest): (CUrlRequestInfo::SetSavedPageRequest):
• ResourceLoader/src/MultipartContentHandler.cpp: (CMultipartContentHandler::HandleMultipartMixedL):
• ResourceLoader/src/UrlRequestInfo.cpp: (CUrlRequestInfo::CUrlRequestInfo): (CUrlRequestInfo::~CUrlRequestInfo): (CUrlRequestInfo::SetPostDataL):

11:23 AM Changeset in webkit [17940] by beidson

• 2 edits in trunk/WebCore

Reviewed by Tim's rubberstamp

Amazingly, DocumentLoader.h survived all this time without a header guard...

• loader/DocumentLoader.h: Added header guard

10:48 AM Changeset in webkit [22595] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2006-11-30 Steve Falkenburg <​sfalken@apple.com>

B&I build fix. Add missing header files to vcproj.

• WebCore.vcproj/WebCore.vcproj:

9:37 AM Changeset in webkit [17939] by thatcher

• 2 edits in trunk/WebCore

Reviewed by Brady and Eric.

XMLHttpRequest fails in a page loaded with WebFrame's loadHTMLString: or loadData:
​http://bugs.webkit.org/show_bug.cgi?id=11723

Allow cross-domain XMLHTTPRequest for applewebdata URLs. No automated way to test,
tested in Safari's debug Snippet Editor.

• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):

7:05 AM Changeset in webkit [17938] by zbujtas

• 2 edits in S60/trunk/WebCore

2006-11-29 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC:
​http://bugs.webkit.org/show_bug.cgi?id=11716
[S60] some Chinese characters displays as mess code on www.163.com

WARNING: NO TEST CASES ADDED OR CHANGED

• khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::XMLHttpRequest): (KJS::XMLHttpRequest::~XMLHttpRequest): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::slotData):