Timeline



Dec 26, 2006:

11:46 PM Changeset in webkit [22717] by ggaren
  • 3 edits in branches/WindowsMerge/WebKitWin

Build fix.

  • WebFrame.cpp: Removed willCloseDocument, which is now gone from WebCore::FrameLoaderClient.
  • WebFrame.h: ditto
11:38 PM Changeset in webkit [18430] by ggaren
  • 16 edits in trunk

WebCore:

Reviewed by Eric Seidel.

Fixed <rdar://problem/4740328> Safari crash on quit in _NPN_ReleaseObject
from KJS::Bindings::CInstance::~CInstance


No testcase because we can't open and close windows in DumpRenderTree.


  • loader/FrameLoader.cpp: Removed closeDocument helper function because its only purpose was to call didCloseDocument, which is gone now. (WebCore::FrameLoader::detachFromParent): closeDocument => closeURL, since didCloseDocument is gone now.
  • loader/FrameLoaderClient.h: Removed didCloseDocument because it proved unnecessary and harmful.


  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::transitionToCommitted): closeDocument => closeURL, since didCloseDocument is gone now.

WebKit:

Reviewed by Eric Seidel.

Fixed <rdar://problem/4740328> Safari crash on quit in _NPN_ReleaseObject
from KJS::Bindings::CInstance::~CInstance


The essence of this change is that WebKit shouldn't meddle in plug-in
lifetime, since WebCore already manages it. The rest is details.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView removeTrackingRect]): Autorelease our window instead of releasing it, since we might hold the last reference to our window, and releasing it immediately would crash AppKit. (-[WebBaseNetscapePluginView resetTrackingRect]):
  • Plugins/WebNetscapePluginEmbeddedView.h:
  • Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView dataSource]): Use our DOMElement to access our WebFrame, since we don't keep around a direct pointer to our WebFrame anymore.
  • Plugins/WebNullPluginView.h:
  • Plugins/WebNullPluginView.m: (-[WebNullPluginView initWithFrame:error:DOMElement:]): (-[WebNullPluginView dealloc]): (-[WebNullPluginView viewDidMoveToWindow]): Use our DOMElement to access our WebFrame, as above.
  • WebCoreSupport/WebFrameBridge.mm: Don't call _addPlugInView because it doesn't exist anymore. Do pass a DOMElement to WebNullPluginView's initializer, so it can access its frame like WebNetscapePluginEmbeddedView does. (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]): (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: Removed didCloseDocument. It had two purposes -- one unnecessary, one harmful: (1) NULL out plug-ins' weak references to their frames. Unnecessary. Having plug-ins access their frames through their DOM elements solves this problem. (2) Unload plug-ins. Harmful. If a plug-in unloads before WebCore is done with it, WebCore will access unmapped memory. Also unnecessary. WebCore Widgets take care of calling -removeFromSuperview on their NSViews, which is sufficient for stopping plug-ins.
  • WebKit.xcodeproj/project.pbxproj: Made WebNullPluginView.m ObjC++.
  • WebView/WebFrame.mm: Removed _addPlugInView, since it was only used to call -setWebFrame, which is gone. (-[WebFramePrivate dealloc]):
  • WebView/WebFrameInternal.h: Removed plugInViews, since it was only used by _addPlugInView, which is gone.
8:13 PM Changeset in webkit [18429] by eseidel
  • 6 edits
    4 adds in trunk

2006-12-26 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

ASSERT while loading SVG map
​http://bugs.webkit.org/show_bug.cgi?id=11987

  • ksvg2/css/SVGCSSParser.cpp: remove a few .impl() calls previously missed. (WebCore::CSSParser::parseSVGValue): (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
  • ksvg2/misc/KCanvasRenderingStyle.cpp: handle invalid colors (WebCore::KSVGPainterFactory::fillPaintServer): (WebCore::KSVGPainterFactory::strokePaintServer):
7:13 PM Changeset in webkit [18428] by eseidel
  • 29 edits in trunk/WebCore

2006-12-26 Eric Seidel <​eric@webkit.org>

Reviewed by ggaren.

No test cases changed.


Remove unnecessary (and inefficient) .impl() and .deprecatedString() calls.
​http://bugs.webkit.org/show_bug.cgi?id=11989

  • bindings/js/kjs_dom.cpp: (KJS::DOMNodeList::getOwnPropertySlot):
  • dom/Document.cpp: (WebCore::Document::createAttributeNS):
  • dom/Element.cpp: (WebCore::Element::getAttributeNS): (WebCore::Element::setAttribute): (WebCore::Element::setAttributeNS): (WebCore::Element::removeAttributeNS): (WebCore::Element::getAttributeNode): (WebCore::Element::getAttributeNodeNS): (WebCore::Element::hasAttribute): (WebCore::Element::hasAttributeNS):
  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::getNamedItemNS): (WebCore::NamedAttrMap::removeNamedItemNS):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::process):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute):
  • html/HTMLEmbedElement.h:
  • html/HTMLHRElement.cpp: (WebCore::HTMLHRElement::parseMappedAttribute):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::insertedIntoDocument):
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::parseMappedAttribute):
  • ksvg2/svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::handleTimerEvent):
  • ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute):
  • ksvg2/svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::parseMappedAttribute):
  • ksvg2/svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::parseMappedAttribute):
  • ksvg2/svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::parseMappedAttribute):
  • ksvg2/svg/SVGImageElement.cpp: (WebCore::SVGImageElement::parseMappedAttribute):
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::notifyAttributeChange):
  • ksvg2/svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::notifyAttributeChange):
  • ksvg2/svg/SVGStopElement.cpp: (WebCore::SVGStopElement::parseMappedAttribute):
  • ksvg2/svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::updateReferencedText):
  • ksvg2/svg/SVGTests.cpp: (WebCore::SVGTests::parseMappedAttribute):
  • ksvg2/svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::parseMappedAttribute):
  • ksvg2/svg/SVGUseElement.cpp: (WebCore::SVGUseElement::closeRenderer):
  • ksvg2/svg/SVGViewElement.cpp: (WebCore::SVGViewElement::parseMappedAttribute):
  • page/Frame.cpp: (WebCore::Frame::selectionComputedStyle):
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeRenderResources):
4:14 PM Changeset in webkit [18427] by eseidel
  • 26 adds in trunk/PageLoadTests

2006-12-26 Eric Seidel <​eric@webkit.org>

Reviewed by bradee-oh.


Add new PageLoadTests directory (this one)
Add LICENSES file to explain where each SVG came from.

  • ChangeLog: Added.
  • svg/LICENSES: Added.
  • svg/files/33041-Samurai.svg: Added.
  • svg/files/42470-flower_from_my_garden_v2.svg: Added.
  • svg/files/Harvey_Rayner.svg: Added.
  • svg/files/az-lizard_benji_park_01.svg: Added.
  • svg/files/bamboo_01.svg: Added.
  • svg/files/cacuts_01.svg: Added.
  • svg/files/cowboy.svg: Added.
  • svg/files/crawfish2_ganson.svg: Added.
  • svg/files/deb9frac1.svg: Added.
  • svg/files/food_leif_lodahl_01.svg: Added.
  • svg/files/france.svg: Added.
  • svg/files/francobollo_gnome_ezechi_02.svg: Added.
  • svg/files/gearflowers.svg: Added.
  • svg/files/hereGear4.svg: Added.
  • svg/files/mtsthelens.svg: Added.
  • svg/files/mtsthelens0.jpg: Added.
  • svg/files/world-iso.svg: Added.
  • svg/files/worldcup.svg: Added.
  • svg/svg.pltsuite: Added.
4:12 PM Changeset in webkit [18426] by eseidel
  • 1 edit
    1 add in trunk/WebKitTools

2006-12-26 Eric Seidel <​eric@webkit.org>

Reviewed by bradee-oh.


Add very simple run-pageloadtest script for running SVG page load test.

  • Scripts/run-pageloadtest: Added.
4:03 PM Changeset in webkit [18425] by zimmermann
  • 7 edits in trunk

Reviewed by Oliver.

Add patternContentUnits support, and cleanup SVGPaintServerGradientCg.cpp
Fixes coords-units-01-b.svg

2:10 PM Changeset in webkit [18424] by ggaren
  • 11 edits in trunk

JavaScriptCore:

Reviewed by Eric Seidel.

Some cleanup in preparation for fixing <rdar://problem/4740328> Safari
crash on quit in _NPN_ReleaseObject from KJS::Bindings::CInstance::~CInstance

  • bindings/c/c_instance.cpp:
  • bindings/c/c_instance.h: Removed unused copy constructor and assignment operator. They made tracking data flow more difficult. Unused code is also dangerous because it can succumb to bit rot with the stealth of a Ninja.


Replaced #include with forward declaration to reduce header dependency.


  • bindings/npruntime.cpp: Sorted #includes. (_NPN_GetStringIdentifier): Replaced assert with ASSERT. (_NPN_GetStringIdentifiers): ditto (_NPN_ReleaseVariantValue): ditto (_NPN_CreateObject): ditto (_NPN_RetainObject): ditto (_NPN_ReleaseObject): ditto (_NPN_DeallocateObject): ditto

WebKit:

Reviewed by Eric Seidel.

Some cleanup in preparation for fixing <rdar://problem/4740328> Safari
crash on quit in _NPN_ReleaseObject from KJS::Bindings::CInstance::~CInstance


Renamed "installedPlugins" to "sharedDatabase." This better follows
the Cocoa naming scheme, and calls out the key attribute that produced this
crash -- namely, that the database is shared throughout the process.


-installedPlugins is actually a part of SPI, but a global search showed
that it had no users.

  • Plugins/WebPluginDatabase.h:
  • Plugins/WebPluginDatabase.m: (+[WebPluginDatabase sharedDatabase]): (-[WebPluginDatabase refresh]): (-[WebPluginDatabase _plugInPaths]): (-[WebPluginDatabase _removePlugin:]):
  • WebCoreSupport/WebViewFactory.m: (-[WebViewFactory pluginsInfo]): (-[WebViewFactory refreshPlugins:]): (-[WebViewFactory pluginSupportsMIMEType:]):
  • WebView/WebView.mm: (+[WebView _supportedMIMETypes]): (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): (-[WebView _close]): (-[WebView _pluginForMIMEType:]): (-[WebView _pluginForExtension:]): (-[WebView _isMIMETypeRegisteredAsPlugin:]):

WebKitTools:

Reviewed by Eric Seidel.

Some cleanup in preparation for fixing <rdar://problem/4740328> Safari
crash on quit in _NPN_ReleaseObject from KJS::Bindings::CInstance::~CInstance


(dumpRenderTree): Renamed "installedPlugins" to "sharedDatabase."

12:03 PM Changeset in webkit [18423] by eseidel
  • 12 edits in trunk/WebCore

2006-12-26 Eric Seidel <​eric@eseidel.com>

Reviewed by ggaren

No test cases changed.


Remove unneeded isPaintingText() and activeClient() from SVGPaintServer system

  • platform/graphics/svg/SVGPaintServer.cpp: (WebCore::SVGPaintServer::SVGPaintServer):
  • platform/graphics/svg/SVGPaintServer.h:
  • platform/graphics/svg/SVGPaintServerGradient.h:
  • platform/graphics/svg/SVGPaintServerPattern.h:
  • platform/graphics/svg/SVGPaintServerSolid.h:
  • platform/graphics/svg/cg/SVGPaintServerCg.cpp: (WebCore::SVGPaintServer::teardown):
  • platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::SVGPaintServerGradient::teardown): (WebCore::SVGPaintServerGradient::setup):
  • platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp: (WebCore::SVGPaintServerPattern::setup): (WebCore::SVGPaintServerPattern::teardown):
  • platform/graphics/svg/cg/SVGPaintServerSolidCg.cpp: (WebCore::SVGPaintServerSolid::setup):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
  • rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow):
10:12 AM Changeset in webkit [18422] by ggaren
  • 7 edits in trunk

WebCore:

Reviewed by Adam Roben.


Fixed <rdar://problem/4778898> REGRESSION: crash in getInstanceForView()
when quitting from kcbs.com


No testcase because we can't open and close windows in DRT.


The crash was caused by deallocating plug-ins that were later referenced
in the unload event handler.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::closeDocument): Call didCloseDocument after closing instead of before, so plugins don't get deallocated until the document has been destroyed and all event handlers have fired.


  • loader/FrameLoaderClient.h: Renamed "willCloseDocument" to "didCloseDocument", since we call it after closing now.

WebKit:

Reviewed by Adam Roben.


Fixed <rdar://problem/4778898> REGRESSION: crash in getInstanceForView()
when quitting from kcbs.com

No testcase because we can't open and close windows in DRT.

The crash was caused by deallocating plug-ins that were later referenced
in the unload event handler.

  • Plugins/WebBaseNetscapePluginView.mm: Don't call stop on ourselves because we may destroy our plugin before the unload handler fires. Also, we don't need to, since didCloseDocument will do it for us.

(-[WebBaseNetscapePluginView addWindowObservers]): We don't need to listen
for windowWillClose anymore, since we don't want to call -stop on ourselves.
(-[WebBaseNetscapePluginView removeWindowObservers]): ditto.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didCloseDocument): Renamed from "willCloseDocument."
8:26 AM Changeset in webkit [18421] by eseidel
  • 18 edits
    4 adds in trunk

2006-12-26 Eric Seidel <​eric@webkit.org>

Reviewed by rwlbuis.

Replace bogus SVGLength::isFraction() method with valueAsPercentage() to fix:
​http://bugs.webkit.org/show_bug.cgi?id=11973


  • ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::valueInSpecifiedUnits): remove extra spaces (WebCore::SVGLength::valueAsPercentage): new method
  • ksvg2/svg/SVGLength.h:
  • ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient): use valueAsPercentage()
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::drawPatternContentIntoTile): return if malloc fails
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient): use valueAsPercentage()
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::createImageBuffer): return 0 if malloc fails
  • platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::SVGPaintServerGradient::setup): return if malloc fails
  • platform/graphics/svg/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask): add comment about possible crash

Dec 25, 2006:

9:36 PM Changeset in webkit [18420] by ggaren
  • 6 edits in trunk/WebKit

More "plugin" => "pluginPackage" renaming that I forgot to check in.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView setPluginPackage:]):
  • Plugins/WebNetscapePluginEmbeddedView.h:
  • Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]): (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]):
9:24 PM Changeset in webkit [18419] by ggaren
  • 2 edits in trunk/WebKit

Reviewed by Eric Seidel.


Fixed crash when opening view source window.

  • WebView/WebView.mm: (-[WebView initWithCoder:]): Don't use the WebView until calling _commonInitialization...
7:43 PM Changeset in webkit [22716] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Fixed build. Tsk, tsk, Oliver.

  • WebCore.vcproj/WebCore.vcproj:
5:44 PM Changeset in webkit [18418] by zimmermann
  • 3 edits
    4 adds in trunk

Reviewed by Oliver.

In the DOMParser class, we have to create content-type specific
documents, instead of a pure "Document" object. Real-life SVG
files us this way to convert strings "<svg><rect x=...></svg>
to a new Document structure.

Add new testcase dynamic-svg-document-creation.svg.

5:30 PM Changeset in webkit [22715] by ggaren
  • 9 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Oliver Hunt.

Removed WebCoreSettings, cleaned up WebCore::Settings.

  • WebCore.vcproj/WebCore.vcproj: Added Settings.cpp to the project.
  • bridge/win/FrameWin.cpp: Updated to use new preferences names. (WebCore::FrameWin::bindingRootObject): (WebCore::FrameWin::windowScriptNPObject):
  • loader/win/FrameLoaderWin.cpp: ditto. (WebCore::FrameLoader::partClearedInBegin):
  • plugins/win/PluginViewWin.cpp: ditto. (WebCore::PluginViewWin::load):

WebKitWin:

Reviewed by Oliver Hunt.

Removed WebCoreSettings, cleaned up WebCore::Settings.

  • WebFrame.cpp: (WebFrame::initWithWebFrameView): Used core() here, now that WebView::settings() is gone.
  • WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences): Simplified this code, now that WebCore handles most of it.
  • WebView.h: Removed settings() accessor. Settings belong to the WebCore page, not the WebView.
5:22 PM Changeset in webkit [18417] by ggaren
  • 37 edits
    1 add
    2 deletes in trunk

WebCore:

Reviewed by Oliver Hunt.

Removed WebCoreSettings, cleaned up WebCore::Settings.

  • WebCore.exp: Exported Settings for use by WebKit, removed WebCoreSettings class.


  • WebCore.xcodeproj/project.pbxproj: Removed WebCoreSetttings.h/.mm. Added Settings.cpp.
  • page/Frame.cpp: Removed cruft that duplicated Settings data. Callers now call through to Settings to get Settings data.
  • page/Page.cpp: Added Settings data member, to replace the one that WebView used to hold.
  • page/Settings.cpp: Added.
  • page/Settings.h:
    • Renamed all functions to match WebKit API. Renamed all variables to match functions. Favorite old name: "isPluginsEnabled."
    • Moved EditableLinkBehavior outside of the class. Having it inside just made it harder to type.
    • Merged in old WebCoreSettings functionality, like guarding against re-setting to the same value, and making sure to update page layout.
    • Paired setters and getters, putting setters first.

WebKit:

Reviewed by Oliver Hunt.


Removed WebCoreSettings, cleaned up WebCore::Settings.

  • WebView/WebFrame.mm: Added helper functions for converting between WebKitEditableLinkBehavior and WebCore::EditableLinkBehavior. I'm not sure that this is the best place for these functions, but it's where all the other functions like them reside. (core): (kit):
  • WebView/WebFrameInternal.h:
  • WebView/WebView.mm: Removed uses of WebCoreSettings. Replaced with direct use of underlying page's settings.
4:45 PM Changeset in webkit [18416] by zimmermann
  • 5 edits in trunk/WebCore

Reviewed by Oliver.
Fix some minor style issues.

4:37 PM Changeset in webkit [18415] by zimmermann
  • 22 edits
    9 adds in trunk

Reviewed by Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11963
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11123

Fix SVGList JS wrappers, which operate on POD types (ie. Point).
There exists a special JSSVGPODTypeWrapperCreatorForList class now,
which operators on specialized SVGPODList's. It makes it possible
to support stuff like "myList.getItem(0).value = 200", for POD lists.

Adding two new testcases demonstrating the usage of SVG DOM & SVGAnimatedPoints.

2:32 PM Changeset in webkit [18414] by ggaren
  • 8 edits in trunk/WebKit

Reviewed by Oliver Hunt.


Some refactoring in preparation for fixing <rdar://problem/4778898>
REGRESSION: crash in getInstanceForView() when quitting from kcbs.com


Two renames:

  • "plugin" => "pluginPackage" (since the type is WebNetscapePluginPackage *)
  • "instance" and/or "pluginPointer" => plugin (since NPP is an opaque handle to a plug-in)


Removed braces around single-line 'if' statements.


Made plugin a pointer instead of an inline ivar. This allows us to NULL
it out once we call NPP_Destroy on it.


Added helper functions for creating and destroying plugin. The destroy function
NULLs out plugin, which helps with debugging.


(-[WebBaseNetscapePluginView willCallPlugInFunction]): Added an ASSERT
to catch attempts to call functions on destroyed plug-ins.

(-[WebBaseNetscapePluginView _createPlugin]): New helper function.
(-[WebBaseNetscapePluginView _destroyPlugin]): New helper function.

10:37 AM Changeset in webkit [18413] by ap
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=10313
Reproducible crash when doing importStylesheet in javascript with
xsl files that use xsl:import

This doesn't fully address the bug, but makes a couple of steps
in that direction.

  • xml/XSLTProcessor.cpp: (WebCore::transformToString): Set m_stylesheet even if it's created implicitly, rather than passed from outside. Always reset it in the end (this doesn't affect Document::applyXSLTransform(), which was the only user of setXSLStylesheet()).
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseXML): Set the loaded document's URL.

Dec 24, 2006:

10:02 AM Changeset in webkit [18412] by ddkilzer
  • 1 edit
    1 delete in trunk/WebKit

2006-12-24 David Kilzer <​ddkilzer@webkit.org>

Removed empty directory.

  • WebKit/Loader: Removed.
8:46 AM Changeset in webkit [18411] by weinig
  • 3 edits in trunk/WebCore

Reviewed by Maciej and Geoff.

  • remove unused member variable m_styleSelectorDirty

No test possible (no functionality change)

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::recalcStyleSelector):
  • dom/Document.h:
7:48 AM Changeset in webkit [18410] by weinig
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by Geoff.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=11952
style changes made through CSSMediaRule functions insertRule()
and deleteRule do not show up on the screen

  • fast/dom/css-mediarule-deleteRule-update-expected.checksum: Added.
  • fast/dom/css-mediarule-deleteRule-update-expected.png: Added.
  • fast/dom/css-mediarule-deleteRule-update-expected.txt: Added.
  • fast/dom/css-mediarule-deleteRule-update.html: Added.
  • fast/dom/css-mediarule-insertRule-update-expected.checksum: Added.
  • fast/dom/css-mediarule-insertRule-update-expected.png: Added.
  • fast/dom/css-mediarule-insertRule-update-expected.txt: Added.
  • fast/dom/css-mediarule-insertRule-update.html: Added.

WebCore:

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11952
style changes made through CSSMediaRule functions insertRule()
and deleteRule do not show up on the screen

Tests added:

  • fast/dom/css-mediarule-deleteRule-update.html
  • fast/dom/css-mediarule-insertRule-update.html
  • css/CSSMediaRule.cpp: (WebCore::CSSMediaRule::insertRule): (WebCore::CSSMediaRule::deleteRule):
7:45 AM Changeset in webkit [18409] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Alexey.

Get rid of unused variable.

Dec 23, 2006:

11:39 PM Changeset in webkit [18408] by ap
  • 5 edits in trunk/LayoutTests

​http://bugs.webkit.org/show_bug.cgi?id=9801
fast/encoding/utf-16-big-endian-diffs.html pixel test fails

  • fast/encoding/utf-16-big-endian-expected.checksum:
  • fast/encoding/utf-16-big-endian-expected.png:
  • fast/encoding/utf-16-little-endian-expected.checksum:
  • fast/encoding/utf-16-little-endian-expected.png: Updated the pixel results, which weren't landed with the fix for bug 3297.
11:19 PM Changeset in webkit [18407] by ggaren
  • 3 edits in trunk/WebKitTools

Reviewed by Maciej Stachowiak.


Added --threaded support to run-webkit-tests and DumpRenderTree.


In "threaded" mode, DRT runs a concurrent JavaScript thread with each test,
stressing the thread safety of JavaScriptCore and the JavaScriptCore/WebCore
interface. This is useful for tracking down bugs you might see on a system
configured to use a PAC file.


Ironically, I can proudly state that very few layout tests pass.

  • DumpRenderTree/DumpRenderTree.m: Added javaScriptThread and helper functions for starting and stopping it. (runJavaScriptThread): helper function (startJavaScriptThread): helper function (stopJavaScriptThread): helper function

(dumpRenderTree): Added --threaded command line argument.

  • Scripts/run-webkit-tests: ditto
11:09 PM Changeset in webkit [18406] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=11933
REGRESSION: trying to change a property in a computed style declaration results in a crash

Test: fast/dom/computed-style-set-property.html

  • bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put): Added a check for null m_impl->stylesheet(). Also, fixed incorrect logic in Dashboard branch - it didn't return in time if removeProperty() raised an exception (credit for noticing this bug goes to Geoff).
7:19 PM Changeset in webkit [18405] by weinig
  • 7 edits in trunk/WebCore

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11940
Bad transparency in some cursor pointer images

  • Resources/northEastResizeCursor.png:
  • Resources/northEastSouthWestResizeCursor.png:
  • Resources/northWestResizeCursor.png:
  • Resources/northWestSouthEastResizeCursor.png:
  • Resources/southEastResizeCursor.png:
  • Resources/southWestResizeCursor.png:
4:48 PM Changeset in webkit [18404] by weinig
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=11876
CSSMediaRule functions insertRule and deleteRule don't raise exceptions

  • fast/dom/css-mediarule-functions-expected.txt: Added.
  • fast/dom/css-mediarule-functions.html: Added.

WebCore:

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11876
CSSMediaRule functions insertRule and deleteRule don't raise exceptions

Test added:

  • fast/dom/css-mediarule-functions.html
  • bindings/js/kjs_css.cpp: (KJS::DOMCSSRuleFunc::callAsFunction):
  • css/CSSMediaRule.cpp: add exception handling (WebCore::CSSMediaRule::insertRule): (WebCore::CSSMediaRule::deleteRule):
  • css/CSSMediaRule.h: add ExceptionCode arguments
  • css/CSSMediaRule.idl: un-comment exceptions
10:18 AM Changeset in webkit [18403] by hyatt
  • 1 edit in trunk/LayoutTests/editing/pasteboard/paste-table-002-expected.txt

Update editing/pasteboard/paste-table-002 results now that the two style decl arrays are in sync.

8:19 AM Changeset in webkit [18402] by ddkilzer
  • 3 edits in trunk/LayoutTests

2006-12-23 David Kilzer <​ddkilzer@webkit.org>

Reviewed by Mitz.

Regenerate test results with default fonts installed.

  • svg/custom/js-font-test-expected.png: Regenerated.
  • svg/custom/js-font-test-expected.txt: Regenerated.
4:39 AM Changeset in webkit [18401] by hyatt
  • 3 edits in trunk/WebCore

Fix 11942. The inheritable properties array is duplicated (lame). Make
sure to keep both in sync.

Reviewed by mitz

  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::):

Dec 22, 2006:

10:01 PM Changeset in webkit [18400] by bdash
  • 2 edits in trunk/WebKitTools

2006-12-22 Mark Rowe <​bdash@webkit.org>

Reviewed by Brady.

Fix for <rdar://problem/4265976>
prepare-ChangeLog sometimes lists the wrong Objective-C class name for a changed method

  • Scripts/prepare-ChangeLog: Treat @end as the end of both the interface and the method declaration.
6:29 PM Changeset in webkit [22714] by aliceli1
  • 7 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Geoff.

Fixed <rdar://4766681> and <rdar://4766685> concerning editable link behavior

  • Interfaces/IWebPreferences.idl:
  • WebHistoryItem.cpp: (WebHistoryItem::dictionaryRepresentation):
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initialize): (WebPreferences::editableLinkBehavior): (WebPreferences::setEditableLinkBehavior):
  • WebPreferences.h:
  • WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences):
4:19 PM Changeset in webkit [18399] by ggaren
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Brady Eidson.


Test for <rdar://problem/4871518> Leopard9A321: Crash visiting www.audible.com
(WebCore::FrameLoader::loadSubframe)


Tests an onload handler for a synchronously loaded iframe removing the iframe
from the document.

  • fast/frames/onload-remove-iframe-crash-expected.txt: Added.
  • fast/frames/onload-remove-iframe-crash.html: Added.

WebCore:

Reviewed by Brady Eidson.


Fixed <rdar://problem/4871518> Leopard9A321: Crash visiting www.audible.com
(WebCore::FrameLoader::loadSubframe)

  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::createFrame): Updated to reflect the fact that createChildFrameNamed: now returns a WebCore::Frame* instead of a WebCoreFrameBridge *.
  • page/mac/WebCoreFrameBridge.h:

WebKit:

Reviewed by Brady Eidson.


Fixed <rdar://problem/4871518> Leopard9A321: Crash visiting www.audible.com
(WebCore::FrameLoader::loadSubframe)

  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]):
  • The fix:

Changed to re-fetch the child frame we're trying to load before returning it,
since its onload handler may have removed it from the document. This
allows us to treat a removed frame like a frame that never loaded.


  • Plus some cleanup:
    • Changed to return a WebCore::Frame* instead of a WebFrameBridge *, to simplify some code.
    • Grouped ObjC objects by usage, and moved calls to -release so that they immediately follow the calls that retain.
4:03 PM Changeset in webkit [22713] by adachan
  • 2 edits in branches/WindowsMerge/WebCore

2006-12-22 Ada Chan <​adachan@apple.com>

Reviewed by Anders.

Build fix.

3:28 PM Changeset in webkit [18398] by hyatt
  • 3 edits in trunk/WebCore

Make sure to actually set the stroke thickness for text decorations.
Covered by bugzilla bug 11921.

Reviewed by mitz

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintDecorations):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintDecoration):
2:06 PM Changeset in webkit [18397] by thatcher
  • 2 edits in tags/WebCore-521.32.1/WebCore

Versioning

2:04 PM Changeset in webkit [18396] by thatcher
  • 5 edits in tags/WebCore-521.32.1/WebCore

Merging fix r18328 and r18386.

1:52 PM Changeset in webkit [18395] by thatcher
  • 1 copy in tags/WebCore-521.32.1/WebCore

New tag (part 2.)

1:52 PM Changeset in webkit [18394] by thatcher
  • 1 add in tags/WebCore-521.32.1

New tag. (part 1).

12:49 PM Changeset in webkit [22712] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • WebCore.vcproj/WebCore.vcproj:
11:35 AM Changeset in webkit [18393] by zimmermann
  • 33 edits
    5 adds
    1 delete in trunk

Reviewed by Rob.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11934

Adding/removing SVGPathSeg* items to a SVGPathElement (through SVGPathSegList
interface) has live update problems, as the notifyAttributeChange() function
isn't called anywhere. The context param is currently stored per SVGPathSeg,
which is not needed - as it can be done using SVGPathSegList completely. It
wastes memory, that is fixed. In order to get rid of the context param in
SVGPathSeg, we need a way to map SVGPathSeg* objects to SVGStyledElement*
objects ("context element"). That is done using a new HashMap in the
SVGDocumentExtensions class.

11:26 AM Changeset in webkit [18392] by ap
  • 2 edits in trunk/WebCore

2006-12-22 Mitz Pettel <​mitz@webkit.org>

Reviewed by Beth.

This fixes a bunch of existing pixel tests.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorder):
10:57 AM Changeset in webkit [22711] by sullivan
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Kevin Decker

Renamed stub method name to match change in WebCore

  • platform/win/TemporaryLinkStubs.cpp: (WebCore::Editor::markMisspellingsAfterTypingToPosition): renamed from markMisspellingsInAdjacentWords
10:49 AM Changeset in webkit [18391] by sullivan
  • 4 edits in trunk/WebCore

Reviewed by Kevin Decker

  • renamed markMisspellingsInAdjacentWords to markMisspellingsAfterTypingToPosition in anticipation of fixing it to work more correctly with grammar checking, where only checking adjacent words isn't good enough.
  • editing/Editor.h: renamed markMisspellingsInAdjacentWords to markMisspellingsAfterTypingToPosition
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::markMisspellingsAfterTyping): updated for name change
  • editing/mac/EditorMac.mm: (WebCore::Editor::markMisspellingsAfterTypingToPosition): renamed from markMisspellingsInAdjacentWords and added FIXME comment
9:43 AM Changeset in webkit [18390] by eseidel
  • 3 edits
    16 adds in trunk

2006-12-22 Eric Seidel <​eric@webkit.org>

Reviewed by aroben.

​http://bugs.webkit.org/show_bug.cgi?id=11912
Overriding visibility does not behave as expected.

  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): allow children to draw when container is visibility='hidden'
8:51 AM Changeset in webkit [18389] by yongjzha
  • 3 edits in S60/trunk/WebKit

2006-12-22 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Steve Winship and Yongjun Zhang.
DESC: TSW ID# SRAY-6WQKA6: Formdataautofill: If the form field contains single or double quotes the SQL query to insert, delete data does not work.
​http://bugs.webkit.org/show_bug.cgi?id=11927

  • BrowserView/inc/FormDataAutoFillStore.h:
  • BrowserView/src/FormDataAutoFillStore.cpp: (CFormDataAutoFillStore::NewL): (CFormDataAutoFillStore::ConstructL): (CFormDataAutoFillStore::GetDataL): (CFormDataAutoFillStore::DeleteDataL): (CFormDataAutoFillStore::InsertDataL): (CFormDataAutoFillStore::SaveData): (CFormDataAutoFillStore::OpenTableForUse): (CFormDataAutoFillStore::CloseTableAfterUse): (CFormDataAutoFillStore::CreateFormDataTableL): (CFormDataAutoFillStore::WriteLongTextL): (CFormDataAutoFillStore::ReadLongTextL):
6:11 AM Changeset in webkit [18388] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Geoff Garen

  • improved concept and implementation of my previous checkin after discussing with Darin
  • WebView/WebViewPrivate.h:
  • WebView/WebView.mm: (-[WebView setHoverFeedbackSuspended:]): renamed from setIgnoresMouseMovedEvents, and now tells the main WebHTMLView (if any) that this state has changed. Telling just the main WebHTMLView is a bit of an implementation hack. Hopefully someday we can rework the document architecture and make this kind of thing less hacky (but this is following existing customs, so I don't feel too bad) (-[WebView isHoverFeedbackSuspended]): renamed from ignoresMouseMovedEvents
  • WebView/WebHTMLViewInternal.h: declare _hoverFeedbackSuspendedChanged
  • WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): test the webView's state of the hit-tested WebHTMLView rather than self (-[WebHTMLView _hoverFeedbackSuspendedChanged]): generate a fake mouse-moved event, which simulates the mouse moving away from the current element or back over it
1:30 AM Changeset in webkit [18387] by zimmermann
  • 4 edits
    5 adds in trunk

Reviewed by Rob.

Fix SVGPathSeg JS object creation. SVGPathSegList has to return
the actual SVGPathSegLineToAbs/MoveToRel... object instead of a pure
SVGPathSeg JS object.

Note: See TracTimeline for information about the timeline view.