Timeline



Jan 1, 2007:

9:13 PM Changeset in webkit [18517] by ddkilzer
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Darin.

Modified pcre_compile() (and the functions that it calls) to work with patterns
containing null characters.

Covered by JavaScriptCore tests ecma_3/RegExp/octal-002.js and ecma_3/RegExp/regress-85721.js

  • kjs/regexp.cpp: (KJS::RegExp::RegExp): Changed to not null-terminate the pattern string and instead pass its length to pcre_compile.
  • pcre/pcre.h:
  • pcre/pcre_compile.c: (check_escape): (get_ucp): (is_counted_repeat): (check_posix_syntax): (compile_branch): (compile_regex): (pcre_compile): Added a parameter specifying the length of the pattern, which is no longer required to be null-terminated and may contain null characters. (pcre_compile2):
  • pcre/pcre_internal.h:
  • tests/mozilla/expected.html: Updated for the two tests that this patch fixes. Also updated failing results for ecma_3/RegExp/regress-100199.js which were not updated after bug 6257 was fixed.

WebCore:

Reviewed by Darin.

  • platform/RegularExpression.cpp: (WebCore::RegularExpression::Private::compile): Changed to not null-terminate the pattern string and instead pass its length to pcre_compile.
8:37 PM Changeset in webkit [18516] by ddkilzer
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/repaint/table-cell-collapsed-border-expected.checksum: Added.
  • fast/repaint/table-cell-collapsed-border-expected.png: Added.
  • fast/repaint/table-cell-collapsed-border-expected.txt: Added.
  • fast/repaint/table-cell-collapsed-border.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/repaint/table-cell-collapsed-border.html

  • rendering/RenderTable.h: Added needsSectionRecalc() accessor.
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::getAbsoluteRepaintRect): Overloaded to add the outer half of any collapsed borders. This function checks the cell's borders' widths but also the widths of the adjoining cells' borders, since they can contribute to the length of this cell's borders perpendicular to them, making such a border overflow the cell in both dimensions. (WebCore::RenderTableCell::borderLeft): Split the collapsing borders case off to borderHalfLeft(). (WebCore::RenderTableCell::borderRight): Ditto. (WebCore::RenderTableCell::borderTop): Ditto. (WebCore::RenderTableCell::borderBottom): Ditto. (WebCore::RenderTableCell::borderHalfLeft): Added. Takes an 'outer' boolean parameter. When true, this function returns the width of the part of the border that is outside the cell (different from the inner width when the total width is odd). (WebCore::RenderTableCell::borderHalfRight): Ditto. (WebCore::RenderTableCell::borderHalfTop): Ditto. (WebCore::RenderTableCell::borderHalfBottom): Ditto.
  • rendering/RenderTableCell.h:
8:27 PM Changeset in webkit [18515] by ddkilzer
  • 4 edits in trunk/WebCore

WebCore:

WebCore.vcproj change reviewed by Darin. Additional build files updated by ddkilzer.

  • CMakeLists.txt: Removed RenderLineEdit.cpp.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed RenderLineEdit.cpp and RenderLineEdit.h.
  • WebCoreSources.bkl: Removed RenderLineEdit.cpp.
8:19 PM Changeset in webkit [18514] by ddkilzer
  • 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by Darin.

Because Mac OS X returns geographically and historically accurate time zone information,
converting Jan 02, 1970 12:00:00 AM to local time then subtracting 24 hours did not work
in GMT (London - England) since it was in BST (+0100) all year in 1970[1]. Instead, the
UTC offset is calculated by converting Jan 01, 2000 12:00:00 AM to local time then
subtracting that from the same date in UTC.

[1] ​http://en.wikipedia.org/wiki/British_Summer_Time

  • kjs/DateMath.cpp: (KJS::getUTCOffset): Updated UTC offset calculation. (KJS::getDSTOffset): Improved comment.
8:13 PM Changeset in webkit [18513] by ddkilzer
  • 4 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12023
svn-create-patch and friends should handle moved/copied files

  • Scripts/svn-apply: Identify copied files and handle those before all other patches.
  • Scripts/svn-create-patch: Generate patches with subtle changes for copied files. (findMimeType($)): Added. (findModificationTime($)): Added. (findSourceFileAndRevision($)): Added. (generateDiff($$$)): Changed to use svn stat instead of svn diff. (isBinaryMimeType($)): Added. (manufacturePatchForAdditionWithHistory($$)): Added.
  • Scripts/svn-unapply: Identify copied files and handle those after unapplying all other patches.
6:27 PM Changeset in webkit [18512] by darin
  • 2 edits in trunk/WebKitSite
  • quality/bugzilla.html: Fix a lingering reference to opendarwin.org.
6:03 PM Changeset in webkit [18511] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Mark Rowe.

  • fast/borders/outline-offset-min-assert-expected.checksum: Added.
  • fast/borders/outline-offset-min-assert-expected.png: Added.
  • fast/borders/outline-offset-min-assert-expected.txt: Added.
  • fast/borders/outline-offset-min-assert.html: Added.

WebCore:

Reviewed by Mark Rowe.

Test: fast/borders/outline-offset-min-assert.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline): Bail out if the width or height is smaller than twice the outline inset.
5:42 PM Changeset in webkit [18510] by bdash
  • 3 edits
    2 adds in trunk

2007-01-01 Mark Rowe <​bdash@webkit.org>

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=12061
Bug 12061: Crash in WebCore::Shared<WebCore::StringImpl>::deref

  • rendering/RenderStyle.cpp: (WebCore::ContentData::clearContent): Reset _contentType to CONTENT_NONE to ensure repeated calls to clearContent do not result in derefing deallocated members.

2007-01-01 Mark Rowe <​bdash@webkit.org>

Reviewed by Eric.

Layout test for ​http://bugs.webkit.org/show_bug.cgi?id=12061
Bug 12061: Crash in WebCore::Shared<WebCore::StringImpl>::deref

  • fast/css-generated-content/reset-content-to-initial-expected.txt: Added.
  • fast/css-generated-content/reset-content-to-initial.html: Added.
12:48 PM Changeset in webkit [18509] by eseidel
  • 10 edits in trunk/WebCore

2007-01-01 Eric Seidel <​eric@webkit.org>

Reviewed by andersca.

Begin pushing code down into SVGAnimateElement

  • ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::handleStartCondition):
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimateElement.h: (WebCore::SVGAnimateElement::updateCurrentValue): (WebCore::SVGAnimateElement::handleStartCondition): (WebCore::SVGAnimateElement::handleEndCondition):
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::handleStartCondition):
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::handleTimerEvent):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGSetElement.cpp: (WebCore::SVGSetElement::updateCurrentValue): (WebCore::SVGSetElement::handleStartCondition): (WebCore::SVGSetElement::handleEndCondition):
  • ksvg2/svg/SVGSetElement.h:
11:40 AM Changeset in webkit [18508] by eseidel
  • 4 edits in trunk/WebCore

2007-01-01 Eric Seidel <​eric@webkit.org>

Reviewed by andersca.

Add static function SVGColor::colorFromRGBColorString to allow parsing Colors from SVG color strings w/o creating an SVGColor object.

  • ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::storeInitialValue): use colorFromRGBColorString (WebCore::SVGAnimateColorElement::startIfNecessary): use colorFromRGBColorString
  • ksvg2/svg/SVGColor.cpp: (WebCore::SVGColor::setRGBColor): use colorFromRGBColorString (WebCore::parseNumberOrPercent): new color parsing helper (WebCore::SVGColor::colorFromRGBColorString): cleaned up version of setRGBColor parsing logic
  • ksvg2/svg/SVGColor.h:
10:58 AM Changeset in webkit [18507] by eseidel
  • 5 edits in trunk/WebCore

2007-01-01 Eric Seidel <​eric@webkit.org>

Reviewed by andersca.

Split handleTimerEvent logic into separate functions in preparation for moving down into SVGAnimationElement

  • ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::storeInitialValue): (WebCore::SVGAnimateColorElement::resetValues): (WebCore::SVGAnimateColorElement::updateCurrentValue): (WebCore::SVGAnimateColorElement::startIfNecessary): (WebCore::SVGAnimateColorElement::handleEndCondition): (WebCore::SVGAnimateColorElement::handleTimerEvent):
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::storeInitialValue): (WebCore::SVGAnimateTransformElement::resetValues): (WebCore::SVGAnimateTransformElement::updateCurrentValue): (WebCore::SVGAnimateTransformElement::startIfNecessary): (WebCore::SVGAnimateTransformElement::handleEndCondition): (WebCore::SVGAnimateTransformElement::handleTimerEvent):
  • ksvg2/svg/SVGAnimateTransformElement.h:
10:56 AM Changeset in webkit [18506] by rwlbuis
  • 3 edits in trunk/WebCore

Reviewed by Eric.

Simple cleanups, removing unused color table, copyright and include guard fixes.

10:20 AM Changeset in webkit [18505] by eseidel
  • 1 edit in trunk/WebCore/ChangeLog

correct reviewer, was andersca not mitz

10:19 AM Changeset in webkit [18504] by eseidel
  • 7 edits in trunk/WebCore

2007-01-01 Eric Seidel <​eric@eseidel.com>

Reviewed by mitz.

More animation code cleanup.

  • ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::handleTimerEvent):
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::handleTimerEvent):
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::SVGAnimationElement): (WebCore::SVGAnimationElement::connectedToTimer): (WebCore::SVGAnimationElement::connectTimer): (WebCore::SVGAnimationElement::disconnectTimer): (WebCore::SVGAnimationElement::updateForElapsedSeconds):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGSetElement.cpp: (WebCore::SVGSetElement::handleTimerEvent):
  • ksvg2/svg/SVGSetElement.h:
9:53 AM Changeset in webkit [18503] by eseidel
  • 3 edits in trunk/WebCore

2007-01-01 Eric Seidel <​eric@eseidel.com>

Reviewed by mitz.

More clean-up to animation code.

  • ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::handleTimerEvent):
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::handleTimerEvent): (WebCore::SVGAnimateTransformElement::parseTransformValue): (WebCore::SVGAnimateTransformElement::calculateRotationFromMatrix):
12:12 AM Changeset in webkit [18502] by eseidel
  • 12 edits in trunk/WebCore

2007-01-01 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

Begin pushing more animation logic out of SVGTimer and into the SVGAnimate* classes.


  • ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::animationsByElement): add comment (WebCore::SVGTimer::notifyAll): push logic into SVGAnimte* classes
  • ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::applyAnimationToValue): added.
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimateElement.cpp:
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::applyAnimationToValue): added.
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::calculateTimePercentage): logic moved from SVGTimer (WebCore::SVGAnimationElement::updateForElapsedSeconds): logic moved from SVGTimer
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGTransformList.cpp: (SVGTransformList::concatenate): fixed spacing

Dec 31, 2006:

10:47 PM Changeset in webkit [18501] by eseidel
  • 5 edits in trunk/WebCore

2007-01-01 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

Split out animationsByElement() logic in preparation for adding AnimationCompositor class
Add addColorsAndClamp helper (since adding and clamping is the common case)

  • ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::animationsByElement): split out from notifyAll (WebCore::SVGTimer::notifyAll):
  • ksvg2/misc/SVGTimer.h:
  • ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::addColorsAndClamp): added.
  • ksvg2/svg/SVGAnimateColorElement.h:
10:03 PM Changeset in webkit [18500] by eseidel
  • 10 edits
    2 copies
    2 moves in trunk/WebCore

2006-12-31 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

Split KSVGTimeScheduler into SVGTimer and TimeScheduler.
(Basic clean-up before re-working animation system)

  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/misc/KSVGTimeScheduler.cpp: Removed.
  • ksvg2/misc/KSVGTimeScheduler.h: Removed.
  • ksvg2/misc/SVGTimer.cpp: Added. (WebCore::SVGTimer::SVGTimer): (WebCore::SVGTimer::calculateTimePercentage): (WebCore::SVGTimer::notifyAll):
  • ksvg2/misc/SVGTimer.h: Added.
  • ksvg2/misc/TimeScheduler.cpp: Added. (WebCore::TimeScheduler::TimeScheduler):
9:15 PM Changeset in webkit [18499] by eseidel
  • 2 edits in trunk/WebCore

2006-12-31 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

Re-enable animateTransform (now that SVGList is fixed)
(Things are only "less broken" not totally fixed yet.)

  • ksvg2/misc/KSVGTimeScheduler.cpp: (WebCore::SVGTimer::notifyAll):
9:07 PM Changeset in webkit [18498] by ddkilzer
  • 23 edits
    1 move
    1 delete in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by Geoff.

Update embedded pcre library from version 6.2 to 6.4. Changes from pcre 6.2 to 6.3
did not include any files in JavaScriptCore/pcre.

All changes include renaming EXPORT to PCRE_EXPORT, renaming of ucp_findchar() to
_pcre_ucp_findchar(), or comment changes. Additional changes noted below.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Updated source file list.
  • JavaScriptCore.xcodeproj/project.pbxproj: Renamed pcre_printint.c to pcre_printint.src and changed it from a source file to a header file.
  • JavaScriptCoreSources.bkl: Updated source file list.
  • pcre/CMakeLists.txt: Updated source file list.
  • pcre/pcre-config.h:
  • pcre/pcre.h: Updated version.
  • pcre/pcre.pri: Updated source file list.
  • pcre/pcre_compile.c: Include pcre_printint.src #if DEBUG. (pcre_compile2):
  • pcre/pcre_config.c:
  • pcre/pcre_exec.c: (match):
  • pcre/pcre_fullinfo.c:
  • pcre/pcre_info.c:
  • pcre/pcre_internal.h: Added header guard. Removed export of _pcre_printint().
  • pcre/pcre_ord2utf8.c:
  • pcre/pcre_printint.c: Renamed to pcre_printint.src.
  • pcre/pcre_printint.src: Added. Renamed _pcre_printint() to pcre_printint().
  • pcre/pcre_refcount.c:
  • pcre/pcre_study.c:
  • pcre/pcre_tables.c:
  • pcre/pcre_try_flipped.c:
  • pcre/pcre_ucp_findchar.c: Added contents of ucp_findchar.c.
  • pcre/pcre_version.c:
  • pcre/pcre_xclass.c: (_pcre_xclass):
  • pcre/ucp.h: Removed export of ucp_findchar().
  • pcre/ucp_findchar.c: Removed. Contents moved to pcre_ucp_findchar.c.
4:49 PM Changeset in webkit [18497] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Hyatt.

No test possible (no change to functionality).

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcMinMaxWidth): Call calc{Inline,Block}MinMaxWidth() only if their result is needed.
4:37 PM Changeset in webkit [18496] by bdash
  • 1 copy
    1 add in trunk/WebCore

Roll over WebCore ChangeLog

1:45 PM Changeset in webkit [18495] by eseidel
  • 21 edits in trunk/WebCore

2006-12-31 Eric Seidel <​eric@webkit.org>

Reviewed by weinig.

Make SVGPathSeg construction take fewer lines of code.

  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::createSVGPathSegMovetoAbs): (WebCore::SVGPathElement::createSVGPathSegMovetoRel): (WebCore::SVGPathElement::createSVGPathSegLinetoAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel): (WebCore::SVGPathElement::createSVGPathSegArcAbs): (WebCore::SVGPathElement::createSVGPathSegArcRel): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
  • ksvg2/svg/SVGPathSegArc.cpp: (WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs): (WebCore::SVGPathSegArcRel::SVGPathSegArcRel):
  • ksvg2/svg/SVGPathSegArc.h:
  • ksvg2/svg/SVGPathSegCurvetoCubic.cpp: (WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs): (WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel):
  • ksvg2/svg/SVGPathSegCurvetoCubic.h:
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp: (WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs): (WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel):
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp: (WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs): (WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel):
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp: (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel):
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
  • ksvg2/svg/SVGPathSegLineto.cpp: (WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs): (WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel):
  • ksvg2/svg/SVGPathSegLineto.h:
  • ksvg2/svg/SVGPathSegLinetoHorizontal.cpp: (WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs): (WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel):
  • ksvg2/svg/SVGPathSegLinetoHorizontal.h:
  • ksvg2/svg/SVGPathSegLinetoVertical.cpp: (WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs): (WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel):
  • ksvg2/svg/SVGPathSegLinetoVertical.h:
  • ksvg2/svg/SVGPathSegMoveto.cpp: (WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs): (WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel):
  • ksvg2/svg/SVGPathSegMoveto.h:
12:38 PM Changeset in webkit [18494] by eseidel
  • 3 edits
    2 deletes in trunk/LayoutTests

2006-12-31 Eric Seidel <​eric@eseidel.com>

Reviewed by mitz.


Make getTotalLength test case work in Opera and FireFox.

  • svg/custom/path-getTotalLength-expected.checksum: Removed.
  • svg/custom/path-getTotalLength-expected.png: Removed.
  • svg/custom/path-getTotalLength-expected.txt:
  • svg/custom/path-getTotalLength.svg:
11:37 AM Changeset in webkit [18493] by eseidel
  • 6 edits
    6 adds in trunk

2006-12-31 Eric Seidel <​eric@eseidel.com>

Reviewed by weinig.

Implement path length measuring for SVGPathElement::getTotalLength and friends.
​http://bugs.webkit.org/show_bug.cgi?id=12033

  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::getTotalLength): (WebCore::SVGPathElement::getPointAtLength):
  • platform/graphics/Path.cpp: (WebCore::pathLengthApplierFunction): (WebCore::Path::length): (WebCore::Path::pointAtLength):
  • platform/graphics/Path.h:
  • platform/graphics/PathTraversalState.cpp: Added. (WebCore::midPoint): (WebCore::distanceLine): (WebCore::QuadraticBezier::QuadraticBezier): (WebCore::QuadraticBezier::approximateDistance): (WebCore::QuadraticBezier::split): (WebCore::CubicBezier::CubicBezier): (WebCore::CubicBezier::approximateDistance): (WebCore::CubicBezier::split): (WebCore::curveLength): (WebCore::PathTraversalState::PathTraversalState): (WebCore::PathTraversalState::closeSubpath): (WebCore::PathTraversalState::moveTo): (WebCore::PathTraversalState::lineTo): (WebCore::PathTraversalState::quadraticBezierTo): (WebCore::PathTraversalState::cubicBezierTo):
  • platform/graphics/PathTraversalState.h: Added. (WebCore::PathTraversalState::):
8:08 AM Changeset in webkit [18492] by weinig
  • 5 edits in trunk/WebCore

Reviewed by Mitz.

Move the SVGZoomAndPanType enum out of SVGSVGElement and
SVGViewElement and into SVGZoomAndPan where it belongs.

  • ksvg2/svg/SVGSVGElement.h:
  • ksvg2/svg/SVGViewElement.h:
  • ksvg2/svg/SVGZoomAndPan.cpp: (WebCore::SVGZoomAndPan::SVGZoomAndPan): (WebCore::SVGZoomAndPan::parseMappedAttribute):
  • ksvg2/svg/SVGZoomAndPan.h: (WebCore::SVGZoomAndPan::):
6:25 AM Changeset in webkit [18491] by ddkilzer
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt. Tweaked by Mitz.

  • fast/overflow/clip-rects-fixed-ancestor-expected.checksum: Added.
  • fast/overflow/clip-rects-fixed-ancestor-expected.png: Added.
  • fast/overflow/clip-rects-fixed-ancestor-expected.txt: Added.
  • fast/overflow/clip-rects-fixed-ancestor.html: Added.

WebCore:

Reviewed by Hyatt.

Added a 'fixed' flag to ClipRects, indicating that the cached rects are in
viewport coordinates. The flag is set (and scrolling is compensated for) for
fixed objects and their descendants.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects):
  • rendering/RenderLayer.h: (WebCore::ClipRects::ClipRects): (WebCore::ClipRects::fixed):
6:00 AM Changeset in webkit [18490] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Sam.

  • fast/block/positioning/relative-overconstrained-expected.checksum: Added.
  • fast/block/positioning/relative-overconstrained-expected.png: Added.
  • fast/block/positioning/relative-overconstrained-expected.txt: Added.
  • fast/block/positioning/relative-overconstrained.html: Added.

WebCore:

Reviewed by Sam.

Test: fast/block/positioning/relative-overconstrained.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::relativePositionOffsetX):

Dec 30, 2006:

3:02 PM Changeset in webkit [18489] by rwlbuis
  • 15 edits
    2 deletes in trunk

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=12004
Webkit doesnt handle omitting M at the start of path syntax well

Improve path parsing error handling.

1:54 PM Changeset in webkit [18488] by rwlbuis
  • 6 edits in trunk

Reviewed by Darin.

The marker is used for start, mid and end.

12:53 PM Changeset in webkit [18487] by rwlbuis
  • 15 edits in trunk/WebCore

Reviewed by weinig.

​http://bugs.webkit.org/show_bug.cgi?id=12035
Use SVGParserUtilities in lists of values

Use SVGParserUtilities in some more places.

8:09 AM Changeset in webkit [18486] by rwlbuis
  • 5 edits
    4 adds in trunk

Reviewed by weinig.

​http://bugs.webkit.org/show_bug.cgi?id=12034
Adapt preserveAspectRatio parsing to SVGParserUtilities

Use the new SVGParserUtilities methods to parse prserveAspectRatio attribute.

2:12 AM Changeset in webkit [18485] by ap
  • 3 edits in trunk/WebCore

2006-12-30 Mitz Pettel <​mitz@webkit.org>

Reviewed by Alexey.

  • remove unused member variables m_loadingSheet and m_bAllDataReceived

No test possible (no change to functionality).

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::setCSSStyleSheet):
  • dom/Document.h:
12:34 AM Changeset in webkit [18484] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11998
Incorrect serialization of quotation marks in XML attributes.

Test: fast/dom/serialize-attribute.xhtml

  • editing/markup.cpp: (WebCore::escapeTextForMarkup): Added an isAttributeValue parameter, as the quotation mark only needs to be encoded in attribute values. (WebCore::startMarkup): Pass appropriate isAttributeValue to escapeTextForMarkup().

Dec 29, 2006:

7:03 PM Changeset in webkit [18483] by ddkilzer
  • 4 edits in trunk/JavaScriptCore

2006-12-29 David Kilzer <​ddkilzer@webkit.org>

Reviewed by Geoff.

Update embedded pcre library from version 6.1 to 6.2. From the pcre ChangeLog:

  1. Added "b" to the 2nd argument of fopen() in dftables.c, for non-Unix-like operating environments where this matters.
  1. Named capturing subpatterns were not being correctly counted when a pattern was compiled. This caused two problems: (a) If there were more than 100 such subpatterns, the calculation of the memory needed for the whole compiled pattern went wrong, leading to an overflow error. (b) Numerical back references of the form \12, where the number was greater than 9, were not recognized as back references, even though there were sufficient previous subpatterns.
  • pcre/dftables.c: Item 3. (main):
  • pcre/pcre.h: Updated version.
  • pcre/pcre_compile.c: Item 5. (read_repeat_counts): (pcre_compile2):
5:30 PM Changeset in webkit [18482] by ddkilzer
  • 3 edits in trunk/WebCore

2006-12-29 David Kilzer <​ddkilzer@webkit.org>

Build fix for no-svg build.

Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT.

  • bindings/js/kjs_css.cpp: (KJS::toJS):
  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
5:27 PM Changeset in webkit [22720] by ggaren
  • 1 edit in branches/WindowsMerge/WebCore/bridge/win/FrameWin.cpp

build fix

5:24 PM Changeset in webkit [22719] by ggaren
  • 3 edits in branches/WindowsMerge/WebCore

Build fix.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::bindingRootObject):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::bindingInstance):
4:48 PM Changeset in webkit [18481] by ggaren
  • 13 edits in trunk

JavaScriptCore:

Reviewed by Brian Dash... err... Mark Rowe.

More cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)


The key change here is to RootObject::RootObject().


  • bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant): Changed to use new constructor.
  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::createNative): Changed to use new constructor. Replaced large 'if' followed by default condition with "if !" and explicit default condition.
  • bindings/objc/objc_runtime.mm: (convertValueToObjcObject): Changed to use new constructor.
  • bindings/runtime_root.cpp: (KJS::Bindings::RootObject::destroy): "removeAllNativeReferences" => "destroy" because this function actually destroys the RootObject.
  • bindings/runtime_root.h: Changed Interpreter* to RefPtr<Interpreter> to prevent a RootObject from holding a stale Interperter*.


(KJS::Bindings::RootObject::RootObject): Changed constructor to take an
Interpreter*, since it's pointless to create a RootObject without one.
Removed setRootObjectImp() and rootObjectImp() because they were just
a confusing way of setting and getting the Interpreter's global object.

(KJS::Bindings::RootObject::nativeHandle): "_nativeHandle" => "m_nativeHandle"
(KJS::Bindings::RootObject::interpreter): "_interpreter" => "m_interpreter"

WebCore:

Reviewed by Brian Dash... err... Mark Rowe.

More cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)


The key change here is to RootObject::RootObject().


Layout tests pass.


Renamed "_bindingRoot" => "_bindingRootObject" because "RootObject" is the
type name.


  • bindings/objc/WebScriptObject.mm: (_didExecute): Use Interpreter::globalObject(), since RootObject::rootObjectImp() no longer exists.
  • page/mac/FrameMac.mm: (WebCore::FrameMac::bindingRootObject): Use the new RootObject constructor. Stop lying about who deletes _bindingRoot.

(WebCore::FrameMac::cleanupPluginObjects): => "destroy". Fixed a bug where
the RootObject would only free its own memory if there were a ReferencesSet*
associated with it.

  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge rootObjectForView:]): Use new constructor. Changed misleading comment.
2:14 PM Changeset in webkit [18480] by rwlbuis
  • 12 edits
    4 adds in trunk

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=12007
SVGColor::setRGBColor color creates/deletes many strings, slowing down parsing

Refactor code so svg reuses cssparser methods. Also make
SVGColor and SVGPaint more efficient by avoiding using
setRGBColor internally.

12:59 PM Changeset in webkit [18479] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by weinig.

​http://bugs.webkit.org/show_bug.cgi?id=12022
typo in SVGTransformable.cpp introduce in r18440


Use the helper method proposed by Eric.

12:47 PM Changeset in webkit [18478] by rwlbuis
  • 3 edits
    4 adds
    8 deletes in trunk

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=12028
Adapt viewBox parsing to SVGParserUtilities

Use the new parseNumber and add tests for viewBox parsing.

12:00 PM Changeset in webkit [18477] by ggaren
  • 2 edits in trunk/WebCore

Build fix: SVGImage only works on Mac.

  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
11:28 AM Changeset in webkit [18476] by weinig
  • 17 edits in trunk/WebCore

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12018
Cleanup of CSSRule and its subclasses

  • Make CSSRule::type() virtual instead of using a member variable.
  • General style cleanup.
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSCharsetRule.cpp: (WebCore::CSSCharsetRule::CSSCharsetRule):
  • css/CSSCharsetRule.h: (WebCore::CSSCharsetRule::isCharsetRule): (WebCore::CSSCharsetRule::type):
  • css/CSSFontFaceRule.cpp: (WebCore::CSSFontFaceRule::CSSFontFaceRule): (WebCore::CSSFontFaceRule::cssText):
  • css/CSSFontFaceRule.h: (WebCore::CSSFontFaceRule::isFontFaceRule): (WebCore::CSSFontFaceRule::type):
  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::CSSImportRule): (WebCore::CSSImportRule::setCSSStyleSheet): (WebCore::CSSImportRule::insertedIntoParent):
  • css/CSSImportRule.h: (WebCore::CSSImportRule::isImportRule): (WebCore::CSSImportRule::type):
  • css/CSSMediaRule.cpp: (WebCore::CSSMediaRule::CSSMediaRule): (WebCore::CSSMediaRule::insertRule): (WebCore::CSSMediaRule::deleteRule): (WebCore::CSSMediaRule::cssText):
  • css/CSSMediaRule.h: (WebCore::CSSMediaRule::isMediaRule): (WebCore::CSSMediaRule::type):
  • css/CSSPageRule.cpp: (WebCore::CSSPageRule::CSSPageRule): (WebCore::CSSPageRule::selectorText): (WebCore::CSSPageRule::setSelectorText): (WebCore::CSSPageRule::cssText):
  • css/CSSPageRule.h: (WebCore::CSSPageRule::style): (WebCore::CSSPageRule::type):
  • css/CSSRule.cpp: (WebCore::CSSRule::cssText): (WebCore::CSSRule::setCssText):
  • css/CSSRule.h: (WebCore::CSSRule::): (WebCore::CSSRule::CSSRule):
  • css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::CSSStyleRule): (WebCore::CSSStyleRule::setSelectorText): (WebCore::CSSStyleRule::cssText): (WebCore::CSSStyleRule::parseString):
  • css/CSSStyleRule.h: (WebCore::CSSStyleRule::isStyleRule): (WebCore::CSSStyleRule::style): (WebCore::CSSStyleRule::type):
  • css/CSSUnknownRule.h: (WebCore::CSSUnknownRule::CSSUnknownRule): (WebCore::CSSUnknownRule::type):
9:45 AM Changeset in webkit [18475] by eseidel
  • 2 edits in trunk/WebCore

2006-12-29 Eric Seidel <​eric@eseidel.com>

Reviewed by ap.

  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::size): explicitly cast to integers to prevent compile error
6:47 AM Changeset in webkit [18474] by staikos
  • 5 edits in trunk

Make the Qt port not crash on many sites such as www.apple.com: painter was closed too
early, and I think also there is a Qt bug that it complains about a painter being
around on a destroyed object that's really just a QShared reference going away. Worked
around.

3:17 AM Changeset in webkit [18473] by zimmermann
  • 2 edits in trunk/WebCore

Build fixed, not reviewed. Noticed by Daniel Molkentin.

  • platform/graphics/svg/SVGImage.h: s/WTF/wtf/ in include.
1:17 AM Changeset in webkit [18472] by eseidel
  • 2 edits in trunk/WebCore

2006-12-29 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyCromeClient::scaleFactor): build fix, use 1.f instead of 1f
12:36 AM Changeset in webkit [18471] by eseidel
  • 3 edits
    9 adds in trunk/LayoutTests

2006-12-29 Eric Seidel <​eric@eseidel.com>

Reviewed by olliej.


Add updated SVGImage results, forgotten in last commit.

  • fast/images/svg-as-background-expected.checksum: Added.
  • fast/images/svg-as-background-expected.png: Added.
  • fast/images/svg-as-background-expected.txt: Added.
  • fast/images/svg-as-image-expected.checksum: Added.
  • fast/images/svg-as-image-expected.png: Added.
  • fast/images/svg-as-image-expected.txt: Added.
  • fast/images/svg-as-tiled-background-expected.checksum: Added.
  • fast/images/svg-as-tiled-background-expected.png: Added.
  • fast/images/svg-as-tiled-background-expected.txt: Added.
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
12:27 AM Changeset in webkit [18470] by eseidel
  • 10 edits
    9 adds in trunk

2006-12-29 Eric Seidel <​eric@webkit.org>

Reviewed by hyatt.

New tests:

  • fast/images/svg-as-image.html
  • fast/images/svg-as-background.html
  • fast/images/svg-as-tiled-background.html


Implement basic SVGImage support.
​http://bugs.webkit.org/show_bug.cgi?id=5971


This implementation depends on (rather ugly) stub Page and Frame clients in SVGImageEmptyClients.h

  • WebCore.xcodeproj/project.pbxproj: add SVGImage.*
  • ksvg2/svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::parseMappedAttribute): ignore fragment urls
  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
  • platform/graphics/Image.h: made setData virtual
  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::drawTiled): stub method
  • platform/graphics/cg/PDFDocumentImage.h:
  • platform/graphics/svg/SVGImage.cpp: Added. (WebCore::SVGImage::SVGImage): (WebCore::SVGImage::~SVGImage): (WebCore::SVGImage::size): (WebCore::SVGImage::draw): (WebCore::SVGImage::drawTiled): stub method (WebCore::SVGImage::setData):
  • platform/graphics/svg/SVGImage.h: Added. (WebCore::SVGImage::frameAtIndex):
  • platform/graphics/svg/SVGImageEmptyClients.h: Added. (WebCore::SVGEmptyCromeClient::~SVGEmptyCromeClient): (WebCore::SVGEmptyCromeClient::chromeDestroyed): (WebCore::SVGEmptyCromeClient::setWindowRect): (WebCore::SVGEmptyCromeClient::windowRect): (WebCore::SVGEmptyCromeClient::pageRect): (WebCore::SVGEmptyCromeClient::scaleFactor): (WebCore::SVGEmptyCromeClient::focus): (WebCore::SVGEmptyCromeClient::unfocus): (WebCore::SVGEmptyCromeClient::createWindow): (WebCore::SVGEmptyCromeClient::createModalDialog): (WebCore::SVGEmptyCromeClient::show): (WebCore::SVGEmptyCromeClient::canRunModal): (WebCore::SVGEmptyCromeClient::runModal): (WebCore::SVGEmptyCromeClient::setToolbarsVisible): (WebCore::SVGEmptyCromeClient::toolbarsVisible): (WebCore::SVGEmptyCromeClient::setStatusbarVisible): (WebCore::SVGEmptyCromeClient::statusbarVisible): (WebCore::SVGEmptyCromeClient::setScrollbarsVisible): (WebCore::SVGEmptyCromeClient::scrollbarsVisible): (WebCore::SVGEmptyCromeClient::setMenubarVisible): (WebCore::SVGEmptyCromeClient::menubarVisible): (WebCore::SVGEmptyCromeClient::setResizable): (WebCore::SVGEmptyCromeClient::addMessageToConsole): (WebCore::SVGEmptyCromeClient::canRunBeforeUnloadConfirmPanel): (WebCore::SVGEmptyCromeClient::runBeforeUnloadConfirmPanel): (WebCore::SVGEmptyCromeClient::closeWindowSoon): (WebCore::SVGEmptyFrameLoaderClient::~SVGEmptyFrameLoaderClient): (WebCore::SVGEmptyFrameLoaderClient::frameLoaderDestroyed): (WebCore::SVGEmptyFrameLoaderClient::hasWebView): (WebCore::SVGEmptyFrameLoaderClient::hasFrameView): (WebCore::SVGEmptyFrameLoaderClient::hasBackForwardList): (WebCore::SVGEmptyFrameLoaderClient::resetBackForwardList): (WebCore::SVGEmptyFrameLoaderClient::provisionalItemIsTarget): (WebCore::SVGEmptyFrameLoaderClient::loadProvisionalItemFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::invalidateCurrentItemPageCache): (WebCore::SVGEmptyFrameLoaderClient::privateBrowsingEnabled): (WebCore::SVGEmptyFrameLoaderClient::makeDocumentView): (WebCore::SVGEmptyFrameLoaderClient::makeRepresentation): (WebCore::SVGEmptyFrameLoaderClient::setDocumentViewFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::forceLayout): (WebCore::SVGEmptyFrameLoaderClient::forceLayoutForNonHTML): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForCommit): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForBackForwardNavigation): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForReload): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForStandardLoad): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForInternalLoad): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryAfterClientRedirect): (WebCore::SVGEmptyFrameLoaderClient::setCopiesOnScroll): (WebCore::SVGEmptyFrameLoaderClient::tokenForLoadErrorReset): (WebCore::SVGEmptyFrameLoaderClient::resetAfterLoadError): (WebCore::SVGEmptyFrameLoaderClient::doNotResetAfterLoadError): (WebCore::SVGEmptyFrameLoaderClient::detachedFromParent1): (WebCore::SVGEmptyFrameLoaderClient::detachedFromParent2): (WebCore::SVGEmptyFrameLoaderClient::detachedFromParent3): (WebCore::SVGEmptyFrameLoaderClient::detachedFromParent4): (WebCore::SVGEmptyFrameLoaderClient::loadedFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::download): (WebCore::SVGEmptyFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveContentLength): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoading): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoading): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelClientRedirect): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillPerformClientRedirect): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillClose): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveIcon): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveTitle): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCommitLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFirstLayout): (WebCore::SVGEmptyFrameLoaderClient::dispatchCreatePage): (WebCore::SVGEmptyFrameLoaderClient::dispatchShow): (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebCore::SVGEmptyFrameLoaderClient::cancelPolicyCheck): (WebCore::SVGEmptyFrameLoaderClient::dispatchUnableToImplementPolicy): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSubmitForm): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidLoadMainResource): (WebCore::SVGEmptyFrameLoaderClient::clearLoadingFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::isLoadingFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::revertToProvisionalState): (WebCore::SVGEmptyFrameLoaderClient::setMainDocumentError): (WebCore::SVGEmptyFrameLoaderClient::clearUnarchivingState): (WebCore::SVGEmptyFrameLoaderClient::progressStarted): (WebCore::SVGEmptyFrameLoaderClient::progressCompleted): (WebCore::SVGEmptyFrameLoaderClient::incrementProgress): (WebCore::SVGEmptyFrameLoaderClient::completeProgress): (WebCore::SVGEmptyFrameLoaderClient::setMainFrameDocumentReady): (WebCore::SVGEmptyFrameLoaderClient::startDownload): (WebCore::SVGEmptyFrameLoaderClient::willChangeTitle): (WebCore::SVGEmptyFrameLoaderClient::didChangeTitle): (WebCore::SVGEmptyFrameLoaderClient::committedLoad): (WebCore::SVGEmptyFrameLoaderClient::finishedLoading): (WebCore::SVGEmptyFrameLoaderClient::finalSetupForReplace): (WebCore::SVGEmptyFrameLoaderClient::cancelledError): (WebCore::SVGEmptyFrameLoaderClient::cannotShowURLError): (WebCore::SVGEmptyFrameLoaderClient::interruptForPolicyChangeError): (WebCore::SVGEmptyFrameLoaderClient::cannotShowMIMETypeError): (WebCore::SVGEmptyFrameLoaderClient::fileDoesNotExistError): (WebCore::SVGEmptyFrameLoaderClient::shouldFallBack): (WebCore::SVGEmptyFrameLoaderClient::setDefersLoading): (WebCore::SVGEmptyFrameLoaderClient::willUseArchive): (WebCore::SVGEmptyFrameLoaderClient::isArchiveLoadPending): (WebCore::SVGEmptyFrameLoaderClient::cancelPendingArchiveLoad): (WebCore::SVGEmptyFrameLoaderClient::clearArchivedResources): (WebCore::SVGEmptyFrameLoaderClient::canHandleRequest): (WebCore::SVGEmptyFrameLoaderClient::canShowMIMEType): (WebCore::SVGEmptyFrameLoaderClient::representationExistsForURLScheme): (WebCore::SVGEmptyFrameLoaderClient::generatedMIMETypeForURLScheme): (WebCore::SVGEmptyFrameLoaderClient::frameLoadCompleted): (WebCore::SVGEmptyFrameLoaderClient::restoreScrollPositionAndViewState): (WebCore::SVGEmptyFrameLoaderClient::provisionalLoadStarted): (WebCore::SVGEmptyFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebCore::SVGEmptyFrameLoaderClient::addHistoryItemForFragmentScroll): (WebCore::SVGEmptyFrameLoaderClient::didFinishLoad): (WebCore::SVGEmptyFrameLoaderClient::prepareForDataSourceReplacement): (WebCore::SVGEmptyFrameLoaderClient::createDocumentLoader): (WebCore::SVGEmptyFrameLoaderClient::setTitle): (WebCore::SVGEmptyFrameLoaderClient::userAgent): (WebCore::SVGEmptyEditorClient::~SVGEmptyEditorClient): (WebCore::SVGEmptyEditorClient::pageDestroyed): (WebCore::SVGEmptyEditorClient::shouldDeleteRange): (WebCore::SVGEmptyEditorClient::shouldShowDeleteInterface): (WebCore::SVGEmptyEditorClient::smartInsertDeleteEnabled): (WebCore::SVGEmptyEditorClient::isContinuousSpellCheckingEnabled): (WebCore::SVGEmptyEditorClient::toggleContinuousSpellChecking): (WebCore::SVGEmptyEditorClient::isGrammarCheckingEnabled): (WebCore::SVGEmptyEditorClient::toggleGrammarChecking): (WebCore::SVGEmptyEditorClient::spellCheckerDocumentTag): (WebCore::SVGEmptyEditorClient::selectWordBeforeMenuEvent): (WebCore::SVGEmptyEditorClient::isEditable): (WebCore::SVGEmptyEditorClient::shouldBeginEditing): (WebCore::SVGEmptyEditorClient::shouldEndEditing): (WebCore::SVGEmptyEditorClient::shouldInsertNode): (WebCore::SVGEmptyEditorClient::shouldInsertText): (WebCore::SVGEmptyEditorClient::shouldApplyStyle): (WebCore::SVGEmptyEditorClient::didBeginEditing): (WebCore::SVGEmptyEditorClient::respondToChangedContents): (WebCore::SVGEmptyEditorClient::didEndEditing): (WebCore::SVGEmptyEditorClient::registerCommandForUndo): (WebCore::SVGEmptyEditorClient::registerCommandForRedo): (WebCore::SVGEmptyEditorClient::clearUndoRedoOperations): (WebCore::SVGEmptyEditorClient::canUndo): (WebCore::SVGEmptyEditorClient::canRedo): (WebCore::SVGEmptyEditorClient::undo): (WebCore::SVGEmptyEditorClient::redo): (WebCore::SVGEmptyEditorClient::dataForArchivedSelection): (WebCore::SVGEmptyEditorClient::userVisibleString): (WebCore::SVGEmptyContextMenuClient::~SVGEmptyContextMenuClient): (WebCore::SVGEmptyContextMenuClient::contextMenuDestroyed): (WebCore::SVGEmptyContextMenuClient::addCustomContextMenuItems): (WebCore::SVGEmptyContextMenuClient::contextMenuItemSelected): (WebCore::SVGEmptyContextMenuClient::downloadURL): (WebCore::SVGEmptyContextMenuClient::copyImageToClipboard): (WebCore::SVGEmptyContextMenuClient::lookUpInDictionary): (WebCore::SVGEmptyContextMenuClient::speak): (WebCore::SVGEmptyContextMenuClient::stopSpeaking): (WebCore::SVGEmptyContextMenuClient::searchWithSpotlight):
12:27 AM Changeset in webkit [18469] by eseidel
  • 2 edits in trunk/WebKitTools

2006-12-29 Eric Seidel <​eric@eseidel.com>

Reviewed by olliej.

Stop DumpRenderTree from reporting false Frame/Node leaks due to new SVGImage

  • DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): clear WebCore cache before exiting
12:15 AM Changeset in webkit [18468] by ddkilzer
  • 3 edits
    1 delete in trunk

LayoutTests:

Reviewed by NOBODY (build fix).

Reverted last commit until WebResourceData issue is fixed.

​http://bugs.webkit.org/show_bug.cgi?id=11882
Need a way to regression test .webarchive output files

  • webarchive/resources/apple.gif: Removed.
  • webarchive/resources/dump-webarchive.js: Removed.
  • webarchive/resources/test-frame.html: Removed.
  • webarchive/resources/test-style.css: Removed.
  • webarchive/test-body-background-expected.txt: Removed.
  • webarchive/test-body-background.html: Removed.
  • webarchive/test-duplicate-resources-expected.txt: Removed.
  • webarchive/test-duplicate-resources.html: Removed.
  • webarchive/test-frameset-expected.txt: Removed.
  • webarchive/test-frameset.html: Removed.
  • webarchive/test-img-src-expected.txt: Removed.
  • webarchive/test-img-src.html: Removed.
  • webarchive/test-input-src-expected.txt: Removed.
  • webarchive/test-input-src.html: Removed.
  • webarchive/test-link-href-expected.txt: Removed.
  • webarchive/test-link-href.html: Removed.
  • webarchive/test-object-data-expected.txt: Removed.
  • webarchive/test-object-data.html: Removed.
  • webarchive/test-script-src-expected.txt: Removed.
  • webarchive/test-script-src.html: Removed.
  • webarchive/test-table-background-expected.txt: Removed.
  • webarchive/test-table-background.html: Removed.
  • webarchive/test-td-background-expected.txt: Removed.
  • webarchive/test-td-background.html: Removed.

WebKitTools:

Reviewed by NOBODY (build fix).

Reverted last commit until WebResourceData issue is fixed.

​http://bugs.webkit.org/show_bug.cgi?id=11882
Need a way to regression test .webarchive output files

  • DumpRenderTree/DumpRenderTree.m: (serializeWebArchiveToXML): Removed. (dump): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController dumpAsWebArchive]): Removed. (runTest):

Dec 28, 2006:

9:50 PM Changeset in webkit [18467] by staikos
  • 2 edits in trunk/WebCore

Make redirects work.

8:38 PM Changeset in webkit [18466] by ddkilzer
  • 3 edits
    1 copy
    25 adds in trunk

LayoutTests:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11882
Need a way to regression test .webarchive output files

Created webarchive tests that exercise various features of the WebArchive format.

  • webarchive/resources/apple.gif: Copied from fast/canvas/resources/apple.gif.
  • webarchive/resources/dump-webarchive.js: Added.
  • webarchive/resources/test-frame.html: Added.
  • webarchive/resources/test-style.css: Added.
  • webarchive/test-body-background-expected.txt: Added.
  • webarchive/test-body-background.html: Added.
  • webarchive/test-duplicate-resources-expected.txt: Added.
  • webarchive/test-duplicate-resources.html: Added.
  • webarchive/test-frameset-expected.txt: Added.
  • webarchive/test-frameset.html: Added.
  • webarchive/test-img-src-expected.txt: Added.
  • webarchive/test-img-src.html: Added.
  • webarchive/test-input-src-expected.txt: Added.
  • webarchive/test-input-src.html: Added.
  • webarchive/test-link-href-expected.txt: Added.
  • webarchive/test-link-href.html: Added.
  • webarchive/test-object-data-expected.txt: Added.
  • webarchive/test-object-data.html: Added.
  • webarchive/test-script-src-expected.txt: Added.
  • webarchive/test-script-src.html: Added.
  • webarchive/test-table-background-expected.txt: Added.
  • webarchive/test-table-background.html: Added.
  • webarchive/test-td-background-expected.txt: Added.
  • webarchive/test-td-background.html: Added.

WebKitTools:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11882
Need a way to regression test .webarchive output files

Implement layoutTestController.dumpAsWebArchive() to test WebArchive format.
Saves WebArchive plist in xml format, then alters ​file:// URLs to remove path
where WebKit was checked out.

  • DumpRenderTree/DumpRenderTree.m: (serializeWebArchiveToXML): Added. (dump): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController dumpAsWebArchive]): Added. (runTest):
7:36 PM Changeset in webkit [18465] by staikos
  • 6 edits in trunk

Fix the Qt build. Reviewed by Olliej.

7:09 PM Changeset in webkit [18464] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.


More cleanup. Layout tests pass.


Use a helper function to initialize and access WebUndefined and WebScriptObject.

  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm: (KJS::Bindings::webScriptObjectClass): (KJS::Bindings::webUndefinedClass): (convertValueToObjcObject):
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue):
5:57 PM Changeset in webkit [18463] by eseidel
  • 13 edits in trunk/WebCore

2006-12-28 Daniel Molkentin <​molkentin@kde.org>

Reviewed by Eric Seidel <​eric@webkit.org>

  • Fix font sizes
  • Make Qt plattform build again:
    • Adjust Qt platform to the Image class split.
    • Introduce BitmapImage class
    • add stub PDFDocumentImage class
  • WebCore.pro:
  • editing/qt/EditorQt.cpp: (WebCore::Editor::markMisspellingsAfterTypingToPosition):
  • loader/qt/FrameLoaderQt.cpp: (WebCore::FrameLoader::partClearedInBegin):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::initPlatformData): (WebCore::BitmapImage::invalidatePlatformData): (WebCore::Image::loadPlatformResource): (WebCore::BitmapImage::draw): (WebCore::BitmapImage::drawTiled): (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/svg/SVGPaintServerLinearGradient.h:
  • platform/graphics/svg/SVGPaintServerRadialGradient.h:
  • platform/graphics/svg/qt/SVGPaintServerLinearGradientQt.cpp: (WebCore::SVGPaintServerLinearGradient::setup):
  • platform/graphics/svg/qt/SVGPaintServerPatternQt.cpp: (WebCore::SVGPaintServerPattern::setup):
  • platform/graphics/svg/qt/SVGPaintServerQt.cpp: (WebCore::SVGPaintServer::teardown):
  • platform/graphics/svg/qt/SVGPaintServerRadialGradientQt.cpp: (WebCore::SVGPaintServerRadialGradient::setup):
  • platform/graphics/svg/qt/SVGPaintServerSolidQt.cpp: (WebCore::SVGPaintServerSolid::setup):
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::bindingRootObject):
5:48 PM Changeset in webkit [18462] by ggaren
  • 1 edit
    2 moves in trunk/LayoutTests

Reviewed by Eric Seidel.

Disable MS-font dependent tests until ​http://bugs.webkit.org/show_bug.cgi?id=11662 is fixed.

  • svg/W3C-SVG-1.1/text-align-08-b.svg: Removed.
  • svg/custom/js-font-test.svg: Removed.
5:44 PM Changeset in webkit [18461] by ggaren
  • 35 edits in trunk

JavaScriptCore:

Reviewed by Brady Eidson.


Some cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)


I'm just trying to make heads or tails of this baffling code.


Renamed "root" | "execContext" | "executionContext" => "rootObject", because
that's the object's (admittedly vague) type name.


  • bindings/runtime.cpp: Removed createLanguageInstanceForValue because I'll give you a dollar if you can explain to me what it actually did.


  • bindings/runtime_root.cpp: Put everything in the KJS::Bindings namespace, removing the KJS::Bindings prefix from individual functions and datatypes. This matches the header and eliminates a lot of syntax cruft.


  • bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant): Replaced use of createLanguageInstanceForValue with call to _NPN_CreateScriptObject because that's what createLanguageInstanceForValue actually did (but don't ask me for that dollar now; that's cheating.)
  • bindings/objc/objc_utility.h:
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): Removed. Its only purpose was to call a single function for WebKit, which WebKit can do on its own.
  • kjs/interpreter.h: Removed rtti() because it was unused, and this class is scheduled for demolition anyway.


  • kjs/interpreter.cpp: Removed createLanguageInstanceForValue because it had nothing to do with the Interpreter, and nothing makes Chuck Norris more mad than a function whose sole purpose is to call another function of the same name. (Really, I asked him.)

WebCore:

Reviewed by Brady Eidson.


Some cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)


Layout tests pass.

Renamed "root" | "execContext" | "executionContext" => rootObject, because
that's the object's (admittedly vague) type name.


  • bindings/js/kjs_binding.cpp:
  • bindings/js/kjs_binding.h: Removed createLanguageInstanceForValue and createObjcInstanceForValue because their only purpose was to confuse you.


  • bindings/objc/DOMInternal.h: Moved declaration of createDOMWrapper here. createDOMWrapper is the new name for createObjcInstanceForValue.


  • bindings/objc/DOMInternal.mm: Renamed Interpreter::createObjcInstanceForValue to createDOMWrapper because creating DOM wrappers has nothing to do with the interpreter, and everything to do with the DOM. Renamed value to object because it is one. Removed newObj nil check that is unnecessary in ObjC.
  • bindings/objc/WebScriptObject.mm: Replaced call to createLanguageInstanceForValue with explicit code to do the same thing it would have done: (1) try to create a DOM wrapper; (2) if the object is not a wrappable DOM object, create a vanilla WebScriptObject for it instead.
3:33 PM Changeset in webkit [18460] by ddkilzer
  • 3 edits in trunk/WebCore

2006-12-28 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromParent): Added call to pageDestroyed().
  • page/FrameTree.cpp: (WebCore::FrameTree::appendChild): Added an assertion that the parent and the child are in the same page. (WebCore::FrameTree::removeChild): Added calls to decrementFrameCount() and pageDestroyed().
2:53 PM Changeset in webkit [18459] by ddkilzer
  • 3 edits in trunk/WebCore

2006-12-28 David Kilzer <​ddkilzer@webkit.org>

Reviewed by Mitz.

No test cases (no change in functionality).

  • platform/TextStream.cpp: Properly initialize presicionFormats.
  • rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation): HTML tests now print out the stroke width, which is a float, so the precision needs to be set.
1:39 PM Changeset in webkit [18458] by eseidel
  • 2 edits in trunk/WebCore

2006-12-28 Eric Seidel <​eric@webkit.org>

Reviewed by rwlbuis.

Fix for memory smasher when drawing markers.
​http://bugs.webkit.org/show_bug.cgi?id=12015


No test case possible (crashes for some folks but not others, not even under --guard)

  • platform/graphics/cg/PathCG.cpp: (WebCore::CGPathApplierToPathApplier): array was too small
11:53 AM Changeset in webkit [18457] by weinig
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/text/atsui-partial-selection-expected.checksum: Added.
  • fast/text/atsui-partial-selection-expected.png: Added.
  • fast/text/atsui-partial-selection-expected.txt: Added.
  • fast/text/atsui-partial-selection.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/text/atsui-partial-selection.html

  • platform/Font.h: Changed comment.
  • platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): Corrected the run length calculation. Changed the ATSUI layout parameters to know about the entire text run, rather than just the range we are drawing. ATSUI measures the characters before the range and positions the range accordingly.
11:28 AM Changeset in webkit [18456] by weinig
  • 16 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Based on a test by Joost de Valk.

  • fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Added.
  • fast/borders/borderRadiusAllStylesAllCorners-expected.png: Added.
  • fast/borders/borderRadiusAllStylesAllCorners-expected.txt: Added.
  • fast/borders/borderRadiusAllStylesAllCorners.html: Added.
  • fast/borders/borderRadiusArcs01-expected.checksum:
  • fast/borders/borderRadiusArcs01-expected.png:
  • fast/borders/borderRadiusGroove01-expected.checksum:
  • fast/borders/borderRadiusGroove01-expected.png:
  • fast/borders/borderRadiusGroove02-expected.checksum:
  • fast/borders/borderRadiusGroove02-expected.png:
  • fast/borders/borderRadiusInset01-expected.checksum:
  • fast/borders/borderRadiusInset01-expected.png:
  • fast/borders/borderRadiusInvalidColor-expected.checksum:
  • fast/borders/borderRadiusOutset01-expected.checksum:
  • fast/borders/borderRadiusOutset01-expected.png:
  • fast/borders/borderRadiusRidge01-expected.checksum:
  • fast/borders/borderRadiusRidge01-expected.png:

WebCore:

Reviewed by Darin.

Test: fast/borders/borderRadiusAllStylesAllCorners.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintBorder): Changed to not draw "arcs" at straight corners and to paint half-corners only where the styles mismatch. Corrected the condition for matching styles: ridge, groove, inset and outset all mismatch in the upper right and lower left corners and match in the other two. The incorrect condition for a match was (almost) unnoticeable because of the painting of both half-corners on each side that had at least one mismatch.
11:15 AM Changeset in webkit [18455] by ap
  • 4 edits
    4 deletes in trunk

Reverting the previous checkin, as it caused an assertion in layout tests.

10:29 AM Changeset in webkit [18454] by ap
  • 4 edits
    4 adds in trunk

2006-12-28 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/repaint/table-cell-collapsed-border.html

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::getAbsoluteRepaintRect): Overloaded to add the outer half of any collapsed borders. This function checks the cell's borders' widths but also the widths of the adjoining cells' borders, since they can contribute to the length of this cell's borders perpendicular to them, making such a border overflow the cell in both dimensions. (WebCore::RenderTableCell::borderLeft): Split the collapsing borders case off to borderHalfLeft(). (WebCore::RenderTableCell::borderRight): Ditto. (WebCore::RenderTableCell::borderTop): Ditto. (WebCore::RenderTableCell::borderBottom): Ditto. (WebCore::RenderTableCell::borderHalfLeft): Added. Takes an 'outer' boolean parameter. When true, this function returns the width of the part of the border that is outside the cell (different from the inner width when the total width is odd). (WebCore::RenderTableCell::borderHalfRight): Ditto. (WebCore::RenderTableCell::borderHalfTop): Ditto. (WebCore::RenderTableCell::borderHalfBottom): Ditto.
  • rendering/RenderTableCell.h:
10:17 AM Changeset in webkit [18453] by ap
  • 3 edits
    4 adds in trunk

2006-12-28 Mitz Pettel <​mitz@webkit.org>

Reviewed by Alexey.

Test: fast/text/capitalize-preserve-nbsp.html

  • platform/StringImpl.cpp: (WebCore::StringImpl::capitalize): Copy back non-breaking spaces from the original string to the capitalized string. Change a 'previous' non-breaking space into a space (this improves the fix for <rdar://problem/4502311> from r13702).
8:09 AM Changeset in webkit [18452] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/repaint/border-radius-repaint-expected.checksum: Added.
  • fast/repaint/border-radius-repaint-expected.png: Added.
  • fast/repaint/border-radius-repaint-expected.txt: Added.
  • fast/repaint/border-radius-repaint.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/repaint/border-radius-repaint.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
1:13 AM Changeset in webkit [18451] by darin
  • 2 edits in trunk/WebCore
  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage): Fixed an #ifdef PLATFORM(CG) that should be #if PLATFORM(CG). Might have broken the build on some platforms.
12:51 AM Changeset in webkit [18450] by rwlbuis
  • 2 edits in trunk/LayoutTests

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=12011
svg/custom/dynamic-svg-document-creation.svg is failing

Correct the transform syntax errors (since the new transform
parser is more strict).

Note: See TracTimeline for information about the timeline view.