Context Navigation

history/BackForwardList.cpp: Added - This largely emulates the design of WebBackForwardList (WebCore::BackForwardList::BackForwardList): (WebCore::BackForwardList::~BackForwardList): (WebCore::BackForwardList::addItem): (WebCore::BackForwardList::goBack): (WebCore::BackForwardList::goForward): (WebCore::BackForwardList::goToItem): (WebCore::BackForwardList::backItem): (WebCore::BackForwardList::currentItem): (WebCore::BackForwardList::forwardItem): (WebCore::BackForwardList::backListWithLimit): (WebCore::BackForwardList::forwardListWithLimit): (WebCore::BackForwardList::capacity): (WebCore::BackForwardList::setCapacity): (WebCore::BackForwardList::setPageCacheSize): (WebCore::BackForwardList::pageCacheSize): (WebCore::BackForwardList::clearPageCache): (WebCore::BackForwardList::usesPageCache): (WebCore::BackForwardList::backListCount): (WebCore::BackForwardList::forwardListCount): (WebCore::BackForwardList::itemAtIndex): (WebCore::BackForwardList::entries): (WebCore::BackForwardList::close): (WebCore::BackForwardList::closed): (WebCore::BackForwardList::removeItem): (WebCore::BackForwardList::containsItem): (WebCore::BackForwardList::setDefaultPageCacheSize): (WebCore::BackForwardList::defaultPageCacheSize):
history/BackForwardList.h: Added.

history/HistoryItem.cpp: Added - This largely emulates the design of WebBackForwardList (WebCore::defaultNotifyHistoryItemChanged): (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::~HistoryItem): (WebCore::HistoryItem::copy): (WebCore::HistoryItem::setHasPageCache): (WebCore::HistoryItem::retainIconInDatabase): (WebCore::HistoryItem::urlString): (WebCore::HistoryItem::originalURLString): (WebCore::HistoryItem::title): (WebCore::HistoryItem::alternateTitle): (WebCore::HistoryItem::icon): (WebCore::HistoryItem::lastVisitedTime): (WebCore::HistoryItem::url): (WebCore::HistoryItem::originalURL): (WebCore::HistoryItem::target): (WebCore::HistoryItem::parent): (WebCore::HistoryItem::setAlternateTitle): (WebCore::HistoryItem::setURLString): (WebCore::HistoryItem::setURL): (WebCore::HistoryItem::setOriginalURLString): (WebCore::HistoryItem::setTitle): (WebCore::HistoryItem::setTarget): (WebCore::HistoryItem::setParent): (WebCore::HistoryItem::setLastVisitedTime): (WebCore::HistoryItem::visitCount): (WebCore::HistoryItem::setVisitCount): (WebCore::HistoryItem::scrollPoint): (WebCore::HistoryItem::setScrollPoint): (WebCore::HistoryItem::clearScrollPoint): (WebCore::HistoryItem::setDocumentState): (WebCore::HistoryItem::documentState): (WebCore::HistoryItem::clearDocumentState): (WebCore::HistoryItem::isTargetItem): (WebCore::HistoryItem::setIsTargetItem): (WebCore::HistoryItem::alwaysAttemptToUsePageCache): (WebCore::HistoryItem::setAlwaysAttemptToUsePageCache): (WebCore::HistoryItem::addChildItem): (WebCore::HistoryItem::childItemWithName): (WebCore::HistoryItem::recurseToFindTargetItem): (WebCore::HistoryItem::targetItem): (WebCore::HistoryItem::pageCache): (WebCore::HistoryItem::children): (WebCore::HistoryItem::hasChildren): (WebCore::HistoryItem::formContentType): (WebCore::HistoryItem::formReferrer): (WebCore::HistoryItem::rssFeedReferrer): (WebCore::HistoryItem::setRSSFeedReferrer): (WebCore::HistoryItem::setFormInfoFromRequest): (WebCore::HistoryItem::formData): (WebCore::HistoryItem::mergeAutoCompleteHints): (WebCore::HistoryItem::hasPageCache): (WebCore::timer): Function to manage the global release timer (WebCore::pendingPageCacheToRelease): Function to manage the global queue of caches to be released (WebCore::HistoryItem::releasePageCache): (WebCore::closeObjectsInPendingPageCaches): (WebCore::HistoryItem::releaseAllPendingPageCaches): (WebCore::HistoryItem::scheduleRelease): (WebCore::HistoryItem::print):
history/HistoryItem.h: Added.
history/mac/HistoryItemMac.mm: Added. (WebCore::HistoryItem::viewState): In the future we need a platform agnostic way to manage the view state (WebCore::HistoryItem::setViewState): (WebCore::HistoryItem::getTransientProperty): Transient properties are, for now, only a Mac concept (WebCore::HistoryItem::setTransientProperty):

history/HistoryItemTimer.cpp: Added (WebCore::HistoryItemTimer::HistoryItemTimer): We need a specific class to be the history item timer because WebCore::Timers only work when you have an instance of an object, but the caches pending release is a static concept (WebCore::HistoryItemTimer::isActive): (WebCore::HistoryItemTimer::schedule): (WebCore::HistoryItemTimer::invalidate): (WebCore::HistoryItemTimer::callReleasePageCache):
history/HistoryItemTimer.h: Added.

history/PageCache.cpp Added - This is a class that contains the fields that used to be in an NSDictionary in WebKit (WebCore::PageCache::PageCache): (WebCore::PageCache::setPageState): (WebCore::PageCache::~PageCache): (WebCore::PageCache::pageState): (WebCore::PageCache::setDocumentLoader): (WebCore::PageCache::documentLoader): (WebCore::PageCache::setTimeStamp): (WebCore::PageCache::setTimeStampToNow): (WebCore::PageCache::timeStamp):
history/PageCache.h: Added.
history/mac/PageCacheMac.mm: Added. (WebCore::PageCache::close): (WebCore::PageCache::setDocumentView): In the future we need a platform agnostic way to manage the documentView (WebCore::PageCache::documentView):

loader/DocumentLoader.cpp: (WebCore::DocumentLoader::loadFromPageCache): (WebCore::DocumentLoader::setLoadingFromPageCache): (WebCore::DocumentLoader::isLoadingFromPageCache): (WebCore::DocumentLoader::originalURL): (WebCore::DocumentLoader::requestURL): (WebCore::DocumentLoader::responseURL): (WebCore::DocumentLoader::responseMIMEType):
loader/DocumentLoader.h:

loader/FrameLoader.cpp: Responsibilities previously scattered in WebKit but concentrated in WebView and WebFrame are now here, where they should be. (WebCore::FrameLoader::clear): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::goBackOrForward): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::canCachePage): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoader::dispatchDidFinishLoadToClient): (WebCore::FrameLoader::updateGlobalHistoryForStandardLoad): Marked for usage in future GlobalHistory (uses client for now) (WebCore::FrameLoader::updateGlobalHistoryForReload): Ditto (WebCore::FrameLoader::shouldGoToHistoryItem): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::addHistoryItemForFragmentScroll): (WebCore::FrameLoader::loadProvisionalItemFromPageCache): (WebCore::FrameLoader::createPageCache): (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoader::createItem): (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): (WebCore::FrameLoader::createItemTree): (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem): (WebCore::FrameLoader::restoreScrollPositionAndViewState): (WebCore::FrameLoader::purgePageCache): (WebCore::FrameLoader::invalidateCurrentItemPageCache): (WebCore::FrameLoader::saveDocumentState): (WebCore::FrameLoader::loadItem): (WebCore::FrameLoader::urlsMatchItem): (WebCore::FrameLoader::goToItem): (WebCore::FrameLoader::recursiveGoToItem): (WebCore::FrameLoader::childFramesMatchItem): (WebCore::FrameLoader::updateHistoryForStandardLoad): (WebCore::FrameLoader::updateHistoryForClientRedirect): (WebCore::FrameLoader::updateHistoryForBackForwardNavigation): (WebCore::FrameLoader::updateHistoryForReload): (WebCore::FrameLoader::updateHistoryForInternalLoad): (WebCore::FrameLoader::updateHistoryForCommit): (WebCore::FrameLoader::saveDocumentAndScrollState): (WebCore::FrameLoader::currentHistoryItem): (WebCore::FrameLoader::previousHistoryItem): (WebCore::FrameLoader::provisionalHistoryItem): (WebCore::FrameLoader::setCurrentHistoryItem): (WebCore::FrameLoader::setPreviousHistoryItem): (WebCore::FrameLoader::setProvisionalHistoryItem):
loader/FrameLoader.h:

loader/FrameLoaderClient.h:

loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::getResponseRefreshAndModifiedHeaders): (WebCore::DocumentLoader::commitIfReady): (WebCore::DocumentLoader::urlForHistory):

loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::dataURLBaseFromRequest): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::checkLoadCompleteForThisFrame):

page/FrameTree.cpp: (WebCore::FrameTree::removeChild):

page/Page.cpp: Transfered a handful of concepts from WebView (WebCore::Page::Page): (WebCore::Page::~Page): (WebCore::Page::backForwardList): (WebCore::Page::goBack): (WebCore::Page::goForward): (WebCore::Page::goToItem):
page/Page.h:

page/PageState.h:
page/mac/FrameMac.h:
page/mac/FrameMac.mm:
page/mac/WebCoreFrameBridge.h:
page/mac/WebCoreFrameBridge.mm:

platform/KURL.cpp: (WebCore::KURL::print): Added debug only method for debugging convenience
platform/KURL.h:

platform/Logging.cpp: (WebCore::): Added some logging channels
platform/Logging.h:

platform/PlatformString.h: (WebCore::nsStringNilIfEmpty): Added for WebKit use

platform/SystemTime.h: Added userIdleTime()

platform/graphics/svg/SVGImage.cpp:
platform/graphics/svg/SVGImageEmptyClients.h: Updated for new FrameLoaderClient methods (WebCore::SVGEmptyFrameLoaderClient::setDocumentViewFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::updateGlobalHistoryForStandardLoad): (WebCore::SVGEmptyFrameLoaderClient::updateGlobalHistoryForReload): (WebCore::SVGEmptyFrameLoaderClient::shouldGoToHistoryItem): (WebCore::SVGEmptyFrameLoaderClient::saveScrollPositionAndViewStateToItem): (WebCore::SVGEmptyFrameLoaderClient::saveDocumentViewToPageCache): (WebCore::SVGEmptyFrameLoaderClient::canCachePage): (WebCore::SVGEmptyEditorClient::~SVGEmptyEditorClient):

platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):

platform/mac/SystemTimeMac.cpp: (WebCore::userIdleTime):

platform/mac/WebCoreSystemInterface.h: Added wkSecondsSinceLastInput for use in userIdleTime
platform/mac/WebCoreSystemInterface.mm:

platform/network/FormData.cpp: (WebCore::FormData::FormData): (WebCore::FormData::copy):
platform/network/FormData.h:

platform/network/ResourceHandle.h:
platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willLoadFromCache): For "are you sure you want to resubmit?" nag

platform/qt/TemporaryLinkStubs.cpp: (WebCore::userIdleTime):
rendering/RenderPart.h:

WebKit:

Reviewed extensively and repeatedly by Darin

<rdar://problem/4887137> - WebCore Back/Forward Cache
Most things not specifically commented on in the ChangeLog can be summed up as
"Do things exactly the same way as we used to, but just stick in WebCore-land as much as possible"

History/WebBackForwardList.mm: (kitPrivate): Convenience functions to help with subbing "WebBackForwardListPrivate" for WebCore::BackForwardList (core): (backForwardListWrappers): A HashMap pattern used to map WebCore objects to their WebKit counterpart (kit): (+[WebBackForwardList setDefaultPageCacheSizeIfNecessary]): (-[WebBackForwardList initWithWebCoreBackForwardList:]): (-[WebBackForwardList init]): (-[WebBackForwardList dealloc]): (-[WebBackForwardList finalize]): (-[WebBackForwardList _close]): (-[WebBackForwardList addItem:]): (-[WebBackForwardList removeItem:]): (-[WebBackForwardList containsItem:]): (-[WebBackForwardList goBack]): (-[WebBackForwardList goForward]): (-[WebBackForwardList goToItem:]): (-[WebBackForwardList backItem]): (-[WebBackForwardList currentItem]): (-[WebBackForwardList forwardItem]): (vectorToNSArray): (-[WebBackForwardList backListWithLimit:]): (-[WebBackForwardList forwardListWithLimit:]): (-[WebBackForwardList capacity]): (-[WebBackForwardList setCapacity:]): (-[WebBackForwardList description]): (-[WebBackForwardList _clearPageCache]): (-[WebBackForwardList setPageCacheSize:]): (-[WebBackForwardList pageCacheSize]): (-[WebBackForwardList _usesPageCache]): (-[WebBackForwardList backListCount]): (-[WebBackForwardList forwardListCount]): (-[WebBackForwardList itemAtIndex:]):
History/WebBackForwardListInternal.h: Added.

History/WebHistory.m: Removed.
History/WebHistory.mm: Added - Needed to be .mm to accept C++ header style (-[_WebCoreHistoryProvider containsItemForURLLatin1:length:]): (-[_WebCoreHistoryProvider containsItemForURLUnicode:length:]):

History/WebHistoryItem.mm: (kitPrivate): Same pattern as WebBackForwardList (core): (historyItemWrappers): (WKNotifyHistoryItemChanged): (-[WebHistoryItem init]): (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]): (-[WebHistoryItem dealloc]): (-[WebHistoryItem finalize]): (-[WebHistoryItem copyWithZone:]): (-[WebHistoryItem URLString]): (-[WebHistoryItem originalURLString]): (-[WebHistoryItem title]): (-[WebHistoryItem setAlternateTitle:]): (-[WebHistoryItem alternateTitle]): (-[WebHistoryItem icon]): (-[WebHistoryItem lastVisitedTimeInterval]): (-[WebHistoryItem hash]): (-[WebHistoryItem isEqual:]): (-[WebHistoryItem description]): (kit): (+[WebHistoryItem entryWithURL:]): (+[WebHistoryItem initWindowWatcherIfNecessary]): (-[WebHistoryItem initWithURL:target:parent:title:]): (-[WebHistoryItem initWithWebCoreHistoryItem:]): (-[WebHistoryItem setTitle:]): (-[WebHistoryItem setVisitCount:]): (-[WebHistoryItem setViewState:]): (-[WebHistoryItem _mergeAutoCompleteHints:]): (-[WebHistoryItem initFromDictionaryRepresentation:]): (-[WebHistoryItem scrollPoint]): (-[WebHistoryItem _transientPropertyForKey:]): (-[WebHistoryItem _setTransientProperty:forKey:]): (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem target]): (-[WebHistoryItem isTargetItem]): (-[WebHistoryItem visitCount]): (-[WebHistoryItem RSSFeedReferrer]): (-[WebHistoryItem setRSSFeedReferrer:]): (-[WebHistoryItem children]): (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]): (-[WebHistoryItem URL]): (-[WebHistoryItem _setLastVisitedTimeInterval:]): (-[WebHistoryItem _lastVisitedDate]): (-[WebHistoryItem targetItem]): (+[WebHistoryItem _releaseAllPendingPageCaches]): (-[WebWindowWatcher windowWillClose:]):
History/WebHistoryItemInternal.h:
History/WebHistoryItemPrivate.h:

WebCoreSupport/WebFrameBridge.mm:
WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setDocumentViewFromPageCache): (WebFrameLoaderClient::detachedFromParent1): (WebFrameLoaderClient::loadedFromPageCache): (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad): (WebFrameLoaderClient::updateGlobalHistoryForReload): (WebFrameLoaderClient::shouldGoToHistoryItem): (WebFrameLoaderClient::frameLoadCompleted): (WebFrameLoaderClient::saveScrollPositionAndViewStateToItem): (WebFrameLoaderClient::restoreScrollPositionAndViewState): (WebFrameLoaderClient::provisionalLoadStarted): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::saveDocumentViewToPageCache): (WebFrameLoaderClient::canCachePage):

WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKit.xcodeproj/project.pbxproj:

WebView/WebDataSource.mm:
WebView/WebDataSourceInternal.h:

WebView/WebFrame.mm: (-[WebFramePrivate dealloc]): (-[WebFrame _canCachePage]): (-[WebFrame _loadURL:referrer:intoChild:]):
WebView/WebFrameInternal.h:

WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): (-[WebFrameView keyDown:]):

WebView/WebHTMLView.m: (-[WebHTMLView closeIfNotCurrentView]): Added for a dirty hack in WebCore that is marked with a FIXME Radar
WebView/WebHTMLViewInternal.h:

WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebViewPrivate dealloc]): (-[WebView _close]): (-[WebView _loadBackForwardListFromOtherView:]): (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView initWithCoder:]): (-[WebView backForwardList]): (-[WebView goBack]): (-[WebView goForward]): (-[WebView goToBackForwardItem:]): (-[WebView canGoBack]): (-[WebView canGoForward]):

5:05 PM Changeset in webkit [18540] by sullivan

2 edits in trunk/WebKit

Reviewed by Kevin Decker

fixed <rdar://problem/4892525> Cannot open PDF in Preview if you attempted to open it in Preview while PDF was loading

WebView/WebPDFView.mm: (-[WebPDFView menuForEvent:]): added comment (-[WebPDFView validateUserInterfaceItem:]): disable this menu item when there's no document yet (-[WebPDFView _openWithFinder:]): If this is invoked when there is no document yet (e.g. via the PDFKit delegate method), just beep and return. I should make a nice error message here, but I'll do that separately.

4:48 PM Changeset in webkit [18539] by bdash

2 edits in tags/Safari-421.32/WebCore

Merge fix r18352.

4:45 PM Changeset in webkit [18538] by bdash

2 edits in tags/Safari-421.32/JavaScriptCore

Merge fix r18349.

4:41 PM Changeset in webkit [18537] by bdash

5 edits in tags/Safari-421.32/WebCore

Merge fix r18328 and r18386.

4:32 PM Changeset in webkit [18536] by zimmermann

2 edits in trunk/WebKit

Reviewed by Timothy.
Fix inspection of RenderSVGInlineText objects (#text nodes in SVG documents).

4:23 PM Changeset in webkit [18535] by bdash

1 copy in tags/Safari-421.32

New tag.

3:40 PM Changeset in webkit [22722] by sfalken

1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

3:34 PM Changeset in webkit [18534] by darin

7 edits in trunk/WebCore

Rubber stamped by Mitz.

Rename isRenderSVGContainer to isSVGContainer.

platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::renderSubtreeToImage):
rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock):
rendering/RenderObject.h: (WebCore::RenderObject::isSVGContainer):
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::viewportTransform):
rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::isSVGContainer):
rendering/RenderTreeAsText.cpp: (WebCore::write):

3:31 PM Changeset in webkit [18533] by sfalken

1 copy in tags/Safari-521.32.8b

New tag.

3:22 PM Changeset in webkit [18532] by zimmermann

1 edit in trunk/WebCore/ChangeLog

Forgot to commit the ChangeLog changes in last commit (Rename isKCanvasContainer to isRenderSVGContainer)

3:20 PM Changeset in webkit [18531] by zimmermann

6 edits in trunk/WebCore

Reviewed by Mitz.
Rename isKCanvasContainer to isRenderSVGContainer.

3:18 PM Changeset in webkit [18530] by bdakin

4 edits in trunk

WebCore:

Reviewed by Darin.

Fix assertion failure with WebCore context menus by getting "Copy
Image" item added in.

platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Check if the image url is a local file or if we have an image in the cache.

WebKit:

Reviewed by Darin.

Fix bug with WebCore context menu item "Copy Image."

WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::copyImageToClipboard): We must call declareTypes on the pasteboard.

11:31 AM Changeset in webkit [22721] by andersca

2 edits in branches/WindowsMerge/WebCore

Build fix.

WebCore.vcproj/WebCore.vcproj:

10:58 AM Changeset in webkit [18529] by weinig

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Anders.

Testcase for http://bugs.webkit.org/show_bug.cgi?id=12072

fast/forms/select-align-expected.checksum: Added.
fast/forms/select-align-expected.png: Added.
fast/forms/select-align-expected.txt: Added.
fast/forms/select-align.html: Added.

WebCore:

Reviewed by Anders.

Patch for http://bugs.webkit.org/show_bug.cgi?id=12072
select with align attribute should not affect contained text

Don't map align for select elements.

Test: fast/forms/select-align.html

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):

10:04 AM Changeset in webkit [18528] by weinig

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Mitz.

Testcase for http://bugs.webkit.org/show_bug.cgi?id=12071

fast/forms/button-align-expected.checksum: Added.
fast/forms/button-align-expected.png: Added.
fast/forms/button-align-expected.txt: Added.
fast/forms/button-align.html: Added.

WebCore:

Reviewed by Mitz.

Patch for http://bugs.webkit.org/show_bug.cgi?id=12071
button with align attribute should not affect contained text

Don't map align for button elements.

Test: fast/forms/button-align.html

html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::parseMappedAttribute):

9:41 AM Changeset in webkit [18527] by weinig

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Mitz and Anders.

Testcases for http://bugs.webkit.org/show_bug.cgi?id=7075

fast/forms/textarea-align-expected.checksum: Added.
fast/forms/textarea-align-expected.png: Added.
fast/forms/textarea-align-expected.txt: Added.
fast/forms/textarea-align.html: Added.

WebCore:

Reviewed by Mitz and Anders.

Patch for http://bugs.webkit.org/show_bug.cgi?id=7075
textarea with align=right should not cause contained text to
be right-justified

Don't map align for textarea elements.

Test: fast/forms/textarea-align.html

html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):

9:39 AM Changeset in webkit [18526] by darin

3 edits in trunk/JavaScriptCore

minor tweak (hope this doesn't re-break Windows)

pcre/pcre_compile.c: Removed use of const pcre_uchar const * -- Mitz probably meant const pcre_uchar *const, but I think we can do without the explicit const here.

pcre/pcre_internal.h: Re-enabled warning C4114.

9:22 AM Changeset in webkit [18525] by ddkilzer

3 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by NOBODY (Windows build fix).

The MSVC compiler requires variables to be declared at the top of the enclosing block in C source.

Disable this warning to prevent MSVC from complaining about the 'const pcre_uchar const *' type:
warning C4114: same type qualifier used more than once

pcre/pcre_compile.c: (pcre_compile2): Moved variable declarations to top of their respective enclosing blocks.
pcre/pcre_internal.h: Added pragma to disable compiler warning.

9:08 AM Changeset in webkit [18524] by eseidel

4 edits in trunk/WebCore

2007-01-02 Eric Seidel <eric@webkit.org>

Reviewed by mitz.

Implement SVGSVGElement::deselectAll()

ksvg2/svg/SVGAnimationElement.h: (WebCore::SVGAnimationElement::updateLastValueWithCurrent): add comment
ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::deselectAll): implement (WebCore::SVGSVGElement::setCurrentTime): add comment about bug
ksvg2/svg/SVGSVGElement.idl: remove unnecessary comment

6:12 AM Changeset in webkit [18523] by weinig

4 edits
8 adds in trunk

LayoutTests:

Reviewed by Darin.

Testcases for http://bugs.webkit.org/show_bug.cgi?id=3360

fast/forms/input-align-expected.checksum: Added.
fast/forms/input-align-expected.png: Added.
fast/forms/input-align-expected.txt: Added.
fast/forms/input-align-image-expected.checksum: Added.
fast/forms/input-align-image-expected.png: Added.
fast/forms/input-align-image-expected.txt: Added.
fast/forms/input-align-image.html: Added.
fast/forms/input-align.html: Added.

WebCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=3360
align="right" on a text input aligns the input field to the right

Don't map align if input type is not 'image'.

Test: fast/forms/input-align-image.html
Test: fast/forms/input-align.html

WebCore.xcodeproj/project.pbxproj:
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::mapToEntry): (WebCore::HTMLInputElement::parseMappedAttribute):

5:46 AM Changeset in webkit [18522] by zimmermann

1 edit
66 adds in trunk/LayoutTests

Rubber stamped by Rob.
Adding all carto.net SVG/JS examples. Highlights some nifty bugs.

4:09 AM Changeset in webkit [18521] by zimmermann

79 edits
32 adds in trunk

Reviewed by Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12013
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11980
Partly fixes: http://bugs.webkit.org/show_bug.cgi?id=6000 (pattern/gradient recursion works now)

Rewrite gradient & pattern code, fixing all known bugs & regressions.

2:13 AM Changeset in webkit [18520] by zack

2 edits in trunk/WebCore

fix compile for svg as well (filenames are case-sensitive)

2:05 AM Changeset in webkit [18519] by zack

7 edits in trunk

compilation fixes for the Qt port

1:03 AM Changeset in webkit [18518] by eseidel

18 edits
2 adds in trunk/WebCore

2007-01-02 Eric Seidel <eric@webkit.org>

Reviewed by rwlbuis.

Refactor more animation code for better sharing between SVGAnimate*Element classes.

replace handleEndCondition with resetValues() and updateLastValueWithCurrent()
move initialTransform() function down into SVGTimer (eventually to AnimationCompositor) Add non-functional (only parses) SVGAnimateMotionElement Improve precision of getPointAtLength calculations and add support for "getNormalAtLength" functionality (needed for rotate='auto' support in animateMotion) Move add getSegmentAtLength functionality to SVGPathSegList, move toPathData into SVGPathSegList as well. Add SVGAnimationElement::hasValidTarget() for future better/simpler ASSERT checking change transformMatrix() to currentTransform() to match AffineTransform class name

WebCore.xcodeproj/project.pbxproj:
ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::animationsByElement): (WebCore::baseValueTransformList): (WebCore::SVGTimer::applyAnimations):
ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::updateLastValueWithCurrent):
ksvg2/svg/SVGAnimateColorElement.h:
ksvg2/svg/SVGAnimateMotionElement.cpp: Added. (WebCore::SVGAnimateMotionElement::SVGAnimateMotionElement): (WebCore::SVGAnimateMotionElement::~SVGAnimateMotionElement): (WebCore::SVGAnimateMotionElement::hasValidTarget): added. (WebCore::SVGAnimateMotionElement::parseMappedAttribute): (WebCore::SVGAnimateMotionElement::animationPath): fetch path from <mpath> or d attribute (WebCore::SVGAnimateMotionElement::updateCurrentValue): (WebCore::SVGAnimateMotionElement::handleStartCondition): (WebCore::SVGAnimateMotionElement::applyAnimationToValue):
ksvg2/svg/SVGAnimateMotionElement.h: Added. (WebCore::SVGAnimateMotionElement::contextElement): (WebCore::SVGAnimateMotionElement::):
ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::hasValidTarget): added. (WebCore::SVGAnimateTransformElement::storeInitialValue): (WebCore::SVGAnimateTransformElement::updateCurrentValue): (WebCore::SVGAnimateTransformElement::updateLastValueWithCurrent): (WebCore::SVGAnimateTransformElement::applyAnimationToValue): (WebCore::SVGAnimateTransformElement::currentTransform):
ksvg2/svg/SVGAnimateTransformElement.h:
ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::hasValidTarget): added. (WebCore::SVGAnimationElement::parseMappedAttribute): (WebCore::SVGAnimationElement::isAdditive): (WebCore::SVGAnimationElement::isAccumulated): (WebCore::SVGAnimationElement::handleTimerEvent):
ksvg2/svg/SVGAnimationElement.h: (WebCore::SVGAnimationElement::updateLastValueWithCurrent): (WebCore::SVGAnimationElement::resetValues):
ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::getPointAtLength): (WebCore::SVGPathElement::getPathSegAtLength): (WebCore::SVGPathElement::parseMappedAttribute): (WebCore::SVGPathElement::toPathData):
ksvg2/svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::getPathSegAtLength): added. (WebCore::SVGPathSegList::toPathData): added.
ksvg2/svg/SVGPathSegList.h:
ksvg2/svg/svgtags.in: add animateMotion
platform/graphics/Path.cpp: (WebCore::pathLengthApplierFunction): add support for TraversalNormalAngleAtLength
platform/graphics/PathTraversalState.cpp: (WebCore::curveLength): support higher precision pointAtLength calculations, and add normalAtLength support (WebCore::PathTraversalState::quadraticBezierTo): (WebCore::PathTraversalState::cubicBezierTo):
platform/graphics/PathTraversalState.h: (WebCore::PathTraversalState::): add TraversalNormalAngleAtLength mode

Jan 1, 2007:

9:13 PM Changeset in webkit [18517] by ddkilzer

8 edits in trunk

JavaScriptCore:

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=11849 REGRESSION (r18182): Google Calendar is broken (a regular expression containing a null character is not parsed correctly)

Modified pcre_compile() (and the functions that it calls) to work with patterns
containing null characters.

Covered by JavaScriptCore tests ecma_3/RegExp/octal-002.js and ecma_3/RegExp/regress-85721.js

kjs/regexp.cpp: (KJS::RegExp::RegExp): Changed to not null-terminate the pattern string and instead pass its length to pcre_compile.
pcre/pcre.h:
pcre/pcre_compile.c: (check_escape): (get_ucp): (is_counted_repeat): (check_posix_syntax): (compile_branch): (compile_regex): (pcre_compile): Added a parameter specifying the length of the pattern, which is no longer required to be null-terminated and may contain null characters. (pcre_compile2):
pcre/pcre_internal.h:
tests/mozilla/expected.html: Updated for the two tests that this patch fixes. Also updated failing results for ecma_3/RegExp/regress-100199.js which were not updated after bug 6257 was fixed.

WebCore:

Reviewed by Darin.

WebCore changes for http://bugs.webkit.org/show_bug.cgi?id=11849 REGRESSION (r18182): Google Calendar is broken (a regular expression containing a null character is not parsed correctly)

platform/RegularExpression.cpp: (WebCore::RegularExpression::Private::compile): Changed to not null-terminate the pattern string and instead pass its length to pcre_compile.

8:37 PM Changeset in webkit [18516] by ddkilzer

5 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

repaint test for http://bugs.webkit.org/show_bug.cgi?id=11359 Incomplete repaint of table cell's collapsed border when changing only the cell

fast/repaint/table-cell-collapsed-border-expected.checksum: Added.
fast/repaint/table-cell-collapsed-border-expected.png: Added.
fast/repaint/table-cell-collapsed-border-expected.txt: Added.
fast/repaint/table-cell-collapsed-border.html: Added.

WebCore:

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=11359 Incomplete repaint of table cell's collapsed border when changing only the cell

Test: fast/repaint/table-cell-collapsed-border.html

rendering/RenderTable.h: Added needsSectionRecalc() accessor.
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::getAbsoluteRepaintRect): Overloaded to add the outer half of any collapsed borders. This function checks the cell's borders' widths but also the widths of the adjoining cells' borders, since they can contribute to the length of this cell's borders perpendicular to them, making such a border overflow the cell in both dimensions. (WebCore::RenderTableCell::borderLeft): Split the collapsing borders case off to borderHalfLeft(). (WebCore::RenderTableCell::borderRight): Ditto. (WebCore::RenderTableCell::borderTop): Ditto. (WebCore::RenderTableCell::borderBottom): Ditto. (WebCore::RenderTableCell::borderHalfLeft): Added. Takes an 'outer' boolean parameter. When true, this function returns the width of the part of the border that is outside the cell (different from the inner width when the total width is odd). (WebCore::RenderTableCell::borderHalfRight): Ditto. (WebCore::RenderTableCell::borderHalfTop): Ditto. (WebCore::RenderTableCell::borderHalfBottom): Ditto.
rendering/RenderTableCell.h:

8:27 PM Changeset in webkit [18515] by ddkilzer

4 edits in trunk/WebCore

WebCore:

WebCore.vcproj change reviewed by Darin. Additional build files updated by ddkilzer.

CMakeLists.txt: Removed RenderLineEdit.cpp.
WebCore.vcproj/WebCore/WebCore.vcproj: Removed RenderLineEdit.cpp and RenderLineEdit.h.
WebCoreSources.bkl: Removed RenderLineEdit.cpp.

8:19 PM Changeset in webkit [18514] by ddkilzer

2 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=12057 REGRESSION: JavaScript Date Is One Day In The Future in GMT time zone

Because Mac OS X returns geographically and historically accurate time zone information,
converting Jan 02, 1970 12:00:00 AM to local time then subtracting 24 hours did not work
in GMT (London - England) since it was in BST (+0100) all year in 1970[1]. Instead, the
UTC offset is calculated by converting Jan 01, 2000 12:00:00 AM to local time then
subtracting that from the same date in UTC.

[1] http://en.wikipedia.org/wiki/British_Summer_Time

kjs/DateMath.cpp: (KJS::getUTCOffset): Updated UTC offset calculation. (KJS::getDSTOffset): Improved comment.

8:13 PM Changeset in webkit [18513] by ddkilzer

4 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12023
svn-create-patch and friends should handle moved/copied files

Scripts/svn-apply: Identify copied files and handle those before all other patches.
Scripts/svn-create-patch: Generate patches with subtle changes for copied files. (findMimeType($)): Added. (findModificationTime($)): Added. (findSourceFileAndRevision($)): Added. (generateDiff($$$)): Changed to use svn stat instead of svn diff. (isBinaryMimeType($)): Added. (manufacturePatchForAdditionWithHistory($$)): Added.
Scripts/svn-unapply: Identify copied files and handle those after unapplying all other patches.

6:27 PM Changeset in webkit [18512] by darin

2 edits in trunk/WebKitSite

quality/bugzilla.html: Fix a lingering reference to opendarwin.org.

6:03 PM Changeset in webkit [18511] by ddkilzer

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Mark Rowe.

pixel test for http://bugs.webkit.org/show_bug.cgi?id=12042 Assertion failure in WebCore::RenderObject::drawBorder

fast/borders/outline-offset-min-assert-expected.checksum: Added.
fast/borders/outline-offset-min-assert-expected.png: Added.
fast/borders/outline-offset-min-assert-expected.txt: Added.
fast/borders/outline-offset-min-assert.html: Added.

WebCore:

Reviewed by Mark Rowe.

fix http://bugs.webkit.org/show_bug.cgi?id=12042 Assertion failure in WebCore::RenderObject::drawBorder

Test: fast/borders/outline-offset-min-assert.html

rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline): Bail out if the width or height is smaller than twice the outline inset.

5:42 PM Changeset in webkit [18510] by bdash

3 edits
2 adds in trunk

2007-01-01 Mark Rowe <bdash@webkit.org>

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=12061
Bug 12061: Crash in WebCore::Shared<WebCore::StringImpl>::deref

rendering/RenderStyle.cpp: (WebCore::ContentData::clearContent): Reset _contentType to CONTENT_NONE to ensure repeated calls to clearContent do not result in derefing deallocated members.

2007-01-01 Mark Rowe <bdash@webkit.org>

Reviewed by Eric.

Layout test for http://bugs.webkit.org/show_bug.cgi?id=12061
Bug 12061: Crash in WebCore::Shared<WebCore::StringImpl>::deref

fast/css-generated-content/reset-content-to-initial-expected.txt: Added.
fast/css-generated-content/reset-content-to-initial.html: Added.

12:48 PM Changeset in webkit [18509] by eseidel

10 edits in trunk/WebCore

2007-01-01 Eric Seidel <eric@webkit.org>

Reviewed by andersca.

Begin pushing code down into SVGAnimateElement

ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::handleStartCondition):
ksvg2/svg/SVGAnimateColorElement.h:
ksvg2/svg/SVGAnimateElement.h: (WebCore::SVGAnimateElement::updateCurrentValue): (WebCore::SVGAnimateElement::handleStartCondition): (WebCore::SVGAnimateElement::handleEndCondition):
ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::handleStartCondition):
ksvg2/svg/SVGAnimateTransformElement.h:
ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::handleTimerEvent):
ksvg2/svg/SVGAnimationElement.h:
ksvg2/svg/SVGSetElement.cpp: (WebCore::SVGSetElement::updateCurrentValue): (WebCore::SVGSetElement::handleStartCondition): (WebCore::SVGSetElement::handleEndCondition):
ksvg2/svg/SVGSetElement.h:

11:40 AM Changeset in webkit [18508] by eseidel

4 edits in trunk/WebCore

2007-01-01 Eric Seidel <eric@webkit.org>

Reviewed by andersca.

Add static function SVGColor::colorFromRGBColorString to allow parsing Colors from SVG color strings w/o creating an SVGColor object.

ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::storeInitialValue): use colorFromRGBColorString (WebCore::SVGAnimateColorElement::startIfNecessary): use colorFromRGBColorString
ksvg2/svg/SVGColor.cpp: (WebCore::SVGColor::setRGBColor): use colorFromRGBColorString (WebCore::parseNumberOrPercent): new color parsing helper (WebCore::SVGColor::colorFromRGBColorString): cleaned up version of setRGBColor parsing logic
ksvg2/svg/SVGColor.h:

10:58 AM Changeset in webkit [18507] by eseidel

5 edits in trunk/WebCore

2007-01-01 Eric Seidel <eric@webkit.org>

Reviewed by andersca.

Split handleTimerEvent logic into separate functions in preparation for moving down into SVGAnimationElement

ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::storeInitialValue): (WebCore::SVGAnimateColorElement::resetValues): (WebCore::SVGAnimateColorElement::updateCurrentValue): (WebCore::SVGAnimateColorElement::startIfNecessary): (WebCore::SVGAnimateColorElement::handleEndCondition): (WebCore::SVGAnimateColorElement::handleTimerEvent):
ksvg2/svg/SVGAnimateColorElement.h:
ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::storeInitialValue): (WebCore::SVGAnimateTransformElement::resetValues): (WebCore::SVGAnimateTransformElement::updateCurrentValue): (WebCore::SVGAnimateTransformElement::startIfNecessary): (WebCore::SVGAnimateTransformElement::handleEndCondition): (WebCore::SVGAnimateTransformElement::handleTimerEvent):
ksvg2/svg/SVGAnimateTransformElement.h:

10:56 AM Changeset in webkit [18506] by rwlbuis

3 edits in trunk/WebCore

Reviewed by Eric.

Simple cleanups, removing unused color table, copyright and include guard fixes.

10:20 AM Changeset in webkit [18505] by eseidel

1 edit in trunk/WebCore/ChangeLog

correct reviewer, was andersca not mitz

10:19 AM Changeset in webkit [18504] by eseidel

7 edits in trunk/WebCore

2007-01-01 Eric Seidel <eric@eseidel.com>

Reviewed by mitz.

More animation code cleanup.

ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::handleTimerEvent):
ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::handleTimerEvent):
ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::SVGAnimationElement): (WebCore::SVGAnimationElement::connectedToTimer): (WebCore::SVGAnimationElement::connectTimer): (WebCore::SVGAnimationElement::disconnectTimer): (WebCore::SVGAnimationElement::updateForElapsedSeconds):
ksvg2/svg/SVGAnimationElement.h:
ksvg2/svg/SVGSetElement.cpp: (WebCore::SVGSetElement::handleTimerEvent):
ksvg2/svg/SVGSetElement.h:

9:53 AM Changeset in webkit [18503] by eseidel

3 edits in trunk/WebCore

2007-01-01 Eric Seidel <eric@eseidel.com>

Reviewed by mitz.

More clean-up to animation code.

ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::handleTimerEvent):
ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::handleTimerEvent): (WebCore::SVGAnimateTransformElement::parseTransformValue): (WebCore::SVGAnimateTransformElement::calculateRotationFromMatrix):

12:12 AM Changeset in webkit [18502] by eseidel

12 edits in trunk/WebCore

2007-01-01 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

Begin pushing more animation logic out of SVGTimer and into the SVGAnimate* classes.

ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::animationsByElement): add comment (WebCore::SVGTimer::notifyAll): push logic into SVGAnimte* classes
ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::applyAnimationToValue): added.
ksvg2/svg/SVGAnimateColorElement.h:
ksvg2/svg/SVGAnimateElement.cpp:
ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::applyAnimationToValue): added.
ksvg2/svg/SVGAnimateTransformElement.h:
ksvg2/svg/SVGAnimationElement.cpp: (WebCore::calculateTimePercentage): logic moved from SVGTimer (WebCore::SVGAnimationElement::updateForElapsedSeconds): logic moved from SVGTimer
ksvg2/svg/SVGAnimationElement.h:
ksvg2/svg/SVGTransformList.cpp: (SVGTransformList::concatenate): fixed spacing

Dec 31, 2006:

10:47 PM Changeset in webkit [18501] by eseidel

5 edits in trunk/WebCore

2007-01-01 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

Split out animationsByElement() logic in preparation for adding AnimationCompositor class
Add addColorsAndClamp helper (since adding and clamping is the common case)

ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::animationsByElement): split out from notifyAll (WebCore::SVGTimer::notifyAll):
ksvg2/misc/SVGTimer.h:
ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::addColorsAndClamp): added.
ksvg2/svg/SVGAnimateColorElement.h:

10:03 PM Changeset in webkit [18500] by eseidel

10 edits
2 copies
2 moves in trunk/WebCore

2006-12-31 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

Split KSVGTimeScheduler into SVGTimer and TimeScheduler.
(Basic clean-up before re-working animation system)

WebCore.xcodeproj/project.pbxproj:
ksvg2/misc/KSVGTimeScheduler.cpp: Removed.
ksvg2/misc/KSVGTimeScheduler.h: Removed.
ksvg2/misc/SVGTimer.cpp: Added. (WebCore::SVGTimer::SVGTimer): (WebCore::SVGTimer::calculateTimePercentage): (WebCore::SVGTimer::notifyAll):
ksvg2/misc/SVGTimer.h: Added.
ksvg2/misc/TimeScheduler.cpp: Added. (WebCore::TimeScheduler::TimeScheduler):

9:15 PM Changeset in webkit [18499] by eseidel

2 edits in trunk/WebCore

2006-12-31 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

Re-enable animateTransform (now that SVGList is fixed)
(Things are only "less broken" not totally fixed yet.)

ksvg2/misc/KSVGTimeScheduler.cpp: (WebCore::SVGTimer::notifyAll):

9:07 PM Changeset in webkit [18498] by ddkilzer

23 edits
1 move
1 delete in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by Geoff.

Update embedded pcre library from version 6.2 to 6.4. Changes from pcre 6.2 to 6.3
did not include any files in JavaScriptCore/pcre.

All changes include renaming EXPORT to PCRE_EXPORT, renaming of ucp_findchar() to
_pcre_ucp_findchar(), or comment changes. Additional changes noted below.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Updated source file list.
JavaScriptCore.xcodeproj/project.pbxproj: Renamed pcre_printint.c to pcre_printint.src and changed it from a source file to a header file.
JavaScriptCoreSources.bkl: Updated source file list.
pcre/CMakeLists.txt: Updated source file list.
pcre/pcre-config.h:
pcre/pcre.h: Updated version.
pcre/pcre.pri: Updated source file list.
pcre/pcre_compile.c: Include pcre_printint.src #if DEBUG. (pcre_compile2):
pcre/pcre_config.c:
pcre/pcre_exec.c: (match):
pcre/pcre_fullinfo.c:
pcre/pcre_info.c:
pcre/pcre_internal.h: Added header guard. Removed export of _pcre_printint().
pcre/pcre_ord2utf8.c:
pcre/pcre_printint.c: Renamed to pcre_printint.src.
pcre/pcre_printint.src: Added. Renamed _pcre_printint() to pcre_printint().
pcre/pcre_refcount.c:
pcre/pcre_study.c:
pcre/pcre_tables.c:
pcre/pcre_try_flipped.c:
pcre/pcre_ucp_findchar.c: Added contents of ucp_findchar.c.
pcre/pcre_version.c:
pcre/pcre_xclass.c: (_pcre_xclass):
pcre/ucp.h: Removed export of ucp_findchar().
pcre/ucp_findchar.c: Removed. Contents moved to pcre_ucp_findchar.c.

4:49 PM Changeset in webkit [18497] by ddkilzer

2 edits in trunk/WebCore

WebCore:

Reviewed by Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=12049 RenderBlock::calcMinMaxWidth() should not examine children of fixed-width blocks

No test possible (no change to functionality).

rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcMinMaxWidth): Call calc{Inline,Block}MinMaxWidth() only if their result is needed.

4:37 PM Changeset in webkit [18496] by bdash

1 copy
1 add in trunk/WebCore

Roll over WebCore ChangeLog

1:45 PM Changeset in webkit [18495] by eseidel

21 edits in trunk/WebCore

2006-12-31 Eric Seidel <eric@webkit.org>

Reviewed by weinig.

Make SVGPathSeg construction take fewer lines of code.

WebCore.xcodeproj/project.pbxproj:
ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::createSVGPathSegMovetoAbs): (WebCore::SVGPathElement::createSVGPathSegMovetoRel): (WebCore::SVGPathElement::createSVGPathSegLinetoAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel): (WebCore::SVGPathElement::createSVGPathSegArcAbs): (WebCore::SVGPathElement::createSVGPathSegArcRel): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
ksvg2/svg/SVGPathSegArc.cpp: (WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs): (WebCore::SVGPathSegArcRel::SVGPathSegArcRel):
ksvg2/svg/SVGPathSegArc.h:
ksvg2/svg/SVGPathSegCurvetoCubic.cpp: (WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs): (WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel):
ksvg2/svg/SVGPathSegCurvetoCubic.h:
ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp: (WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs): (WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel):
ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp: (WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs): (WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel):
ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp: (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel):
ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
ksvg2/svg/SVGPathSegLineto.cpp: (WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs): (WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel):
ksvg2/svg/SVGPathSegLineto.h:
ksvg2/svg/SVGPathSegLinetoHorizontal.cpp: (WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs): (WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel):
ksvg2/svg/SVGPathSegLinetoHorizontal.h:
ksvg2/svg/SVGPathSegLinetoVertical.cpp: (WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs): (WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel):
ksvg2/svg/SVGPathSegLinetoVertical.h:
ksvg2/svg/SVGPathSegMoveto.cpp: (WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs): (WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel):
ksvg2/svg/SVGPathSegMoveto.h:

12:38 PM Changeset in webkit [18494] by eseidel

3 edits
2 deletes in trunk/LayoutTests

2006-12-31 Eric Seidel <eric@eseidel.com>

Reviewed by mitz.

Make getTotalLength test case work in Opera and FireFox.

svg/custom/path-getTotalLength-expected.checksum: Removed.
svg/custom/path-getTotalLength-expected.png: Removed.
svg/custom/path-getTotalLength-expected.txt:
svg/custom/path-getTotalLength.svg:

11:37 AM Changeset in webkit [18493] by eseidel

6 edits
6 adds in trunk

2006-12-31 Eric Seidel <eric@eseidel.com>

Reviewed by weinig.

Implement path length measuring for SVGPathElement::getTotalLength and friends.
http://bugs.webkit.org/show_bug.cgi?id=12033

WebCore.xcodeproj/project.pbxproj:
ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::getTotalLength): (WebCore::SVGPathElement::getPointAtLength):
platform/graphics/Path.cpp: (WebCore::pathLengthApplierFunction): (WebCore::Path::length): (WebCore::Path::pointAtLength):
platform/graphics/Path.h:
platform/graphics/PathTraversalState.cpp: Added. (WebCore::midPoint): (WebCore::distanceLine): (WebCore::QuadraticBezier::QuadraticBezier): (WebCore::QuadraticBezier::approximateDistance): (WebCore::QuadraticBezier::split): (WebCore::CubicBezier::CubicBezier): (WebCore::CubicBezier::approximateDistance): (WebCore::CubicBezier::split): (WebCore::curveLength): (WebCore::PathTraversalState::PathTraversalState): (WebCore::PathTraversalState::closeSubpath): (WebCore::PathTraversalState::moveTo): (WebCore::PathTraversalState::lineTo): (WebCore::PathTraversalState::quadraticBezierTo): (WebCore::PathTraversalState::cubicBezierTo):
platform/graphics/PathTraversalState.h: Added. (WebCore::PathTraversalState::):

8:08 AM Changeset in webkit [18492] by weinig

5 edits in trunk/WebCore

Reviewed by Mitz.

Move the SVGZoomAndPanType enum out of SVGSVGElement and
SVGViewElement and into SVGZoomAndPan where it belongs.

ksvg2/svg/SVGSVGElement.h:
ksvg2/svg/SVGViewElement.h:
ksvg2/svg/SVGZoomAndPan.cpp: (WebCore::SVGZoomAndPan::SVGZoomAndPan): (WebCore::SVGZoomAndPan::parseMappedAttribute):
ksvg2/svg/SVGZoomAndPan.h: (WebCore::SVGZoomAndPan::):

6:25 AM Changeset in webkit [18491] by ddkilzer

4 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt. Tweaked by Mitz.

test for http://bugs.webkit.org/show_bug.cgi?id=9659 Quirksmode: Fixed / Overflow > Positioned objects get hidden when scrolling

fast/overflow/clip-rects-fixed-ancestor-expected.checksum: Added.
fast/overflow/clip-rects-fixed-ancestor-expected.png: Added.
fast/overflow/clip-rects-fixed-ancestor-expected.txt: Added.
fast/overflow/clip-rects-fixed-ancestor.html: Added.

WebCore:

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=9659 Quirksmode: Fixed / Overflow > Positioned objects get hidden when scrolling

Added a 'fixed' flag to ClipRects, indicating that the cached rects are in
viewport coordinates. The flag is set (and scrolling is compensated for) for
fixed objects and their descendants.

rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects):
rendering/RenderLayer.h: (WebCore::ClipRects::ClipRects): (WebCore::ClipRects::fixed):

6:00 AM Changeset in webkit [18490] by ddkilzer

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Sam.

test for http://bugs.webkit.org/show_bug.cgi?id=12037 For relatively positioned boxes in an RTL block, 'right' should win over 'left' if both are not 'auto'

fast/block/positioning/relative-overconstrained-expected.checksum: Added.
fast/block/positioning/relative-overconstrained-expected.png: Added.
fast/block/positioning/relative-overconstrained-expected.txt: Added.
fast/block/positioning/relative-overconstrained.html: Added.

WebCore:

Reviewed by Sam.

fix http://bugs.webkit.org/show_bug.cgi?id=12037 For relatively positioned boxes in an RTL block, 'right' should win over 'left' if both are not 'auto'

Test: fast/block/positioning/relative-overconstrained.html

rendering/RenderBox.cpp: (WebCore::RenderBox::relativePositionOffsetX):

Dec 30, 2006:

3:02 PM Changeset in webkit [18489] by rwlbuis

15 edits
2 deletes in trunk

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=12004
Webkit doesnt handle omitting M at the start of path syntax well

Improve path parsing error handling.

1:54 PM Changeset in webkit [18488] by rwlbuis

6 edits in trunk

Reviewed by Darin.

The marker is used for start, mid and end.

12:53 PM Changeset in webkit [18487] by rwlbuis

15 edits in trunk/WebCore

Reviewed by weinig.

http://bugs.webkit.org/show_bug.cgi?id=12035
Use SVGParserUtilities in lists of values

Use SVGParserUtilities in some more places.

8:09 AM Changeset in webkit [18486] by rwlbuis

5 edits
4 adds in trunk

Reviewed by weinig.

http://bugs.webkit.org/show_bug.cgi?id=12034
Adapt preserveAspectRatio parsing to SVGParserUtilities

Use the new SVGParserUtilities methods to parse prserveAspectRatio attribute.

2:12 AM Changeset in webkit [18485] by ap

3 edits in trunk/WebCore

2006-12-30 Mitz Pettel <mitz@webkit.org>

Reviewed by Alexey.

remove unused member variables m_loadingSheet and m_bAllDataReceived

No test possible (no change to functionality).

dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::setCSSStyleSheet):
dom/Document.h:

12:34 AM Changeset in webkit [18484] by ap

3 edits
2 adds in trunk

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=11998
Incorrect serialization of quotation marks in XML attributes.

Test: fast/dom/serialize-attribute.xhtml

editing/markup.cpp: (WebCore::escapeTextForMarkup): Added an isAttributeValue parameter, as the quotation mark only needs to be encoded in attribute values. (WebCore::startMarkup): Pass appropriate isAttributeValue to escapeTextForMarkup().

Dec 29, 2006:

7:03 PM Changeset in webkit [18483] by ddkilzer

4 edits in trunk/JavaScriptCore

2006-12-29 David Kilzer <ddkilzer@webkit.org>

Reviewed by Geoff.

Update embedded pcre library from version 6.1 to 6.2. From the pcre ChangeLog:

Added "b" to the 2nd argument of fopen() in dftables.c, for non-Unix-like operating environments where this matters.

Named capturing subpatterns were not being correctly counted when a pattern was compiled. This caused two problems: (a) If there were more than 100 such subpatterns, the calculation of the memory needed for the whole compiled pattern went wrong, leading to an overflow error. (b) Numerical back references of the form \12, where the number was greater than 9, were not recognized as back references, even though there were sufficient previous subpatterns.

pcre/dftables.c: Item 3. (main):
pcre/pcre.h: Updated version.
pcre/pcre_compile.c: Item 5. (read_repeat_counts): (pcre_compile2):

5:30 PM Changeset in webkit [18482] by ddkilzer

3 edits in trunk/WebCore

2006-12-29 David Kilzer <ddkilzer@webkit.org>

Build fix for no-svg build.

Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT.

bindings/js/kjs_css.cpp: (KJS::toJS):
loader/CachedImage.cpp: (WebCore::CachedImage::createImage):

5:27 PM Changeset in webkit [22720] by ggaren

1 edit in branches/WindowsMerge/WebCore/bridge/win/FrameWin.cpp

build fix

5:24 PM Changeset in webkit [22719] by ggaren

3 edits in branches/WindowsMerge/WebCore

Build fix.

bridge/win/FrameWin.cpp: (WebCore::FrameWin::bindingRootObject):
plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::bindingInstance):

4:48 PM Changeset in webkit [18481] by ggaren

13 edits in trunk

JavaScriptCore:

Reviewed by Brian Dash... err... Mark Rowe.

More cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)

The key change here is to RootObject::RootObject().

JavaScriptCore.exp:

bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant): Changed to use new constructor.

bindings/jni/jni_jsobject.cpp: (JavaJSObject::createNative): Changed to use new constructor. Replaced large 'if' followed by default condition with "if !" and explicit default condition.

bindings/objc/objc_runtime.mm: (convertValueToObjcObject): Changed to use new constructor.

bindings/runtime_root.cpp: (KJS::Bindings::RootObject::destroy): "removeAllNativeReferences" => "destroy" because this function actually destroys the RootObject.

bindings/runtime_root.h: Changed Interpreter* to RefPtr<Interpreter> to prevent a RootObject from holding a stale Interperter*.

(KJS::Bindings::RootObject::RootObject): Changed constructor to take an
Interpreter*, since it's pointless to create a RootObject without one.
Removed setRootObjectImp() and rootObjectImp() because they were just
a confusing way of setting and getting the Interpreter's global object.

(KJS::Bindings::RootObject::nativeHandle): "_nativeHandle" => "m_nativeHandle"
(KJS::Bindings::RootObject::interpreter): "_interpreter" => "m_interpreter"

WebCore:

Reviewed by Brian Dash... err... Mark Rowe.

More cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)

The key change here is to RootObject::RootObject().

Layout tests pass.

Renamed "_bindingRoot" => "_bindingRootObject" because "RootObject" is the
type name.

bindings/objc/WebScriptObject.mm: (_didExecute): Use Interpreter::globalObject(), since RootObject::rootObjectImp() no longer exists.

page/mac/FrameMac.mm: (WebCore::FrameMac::bindingRootObject): Use the new RootObject constructor. Stop lying about who deletes _bindingRoot.

(WebCore::FrameMac::cleanupPluginObjects): => "destroy". Fixed a bug where
the RootObject would only free its own memory if there were a ReferencesSet*
associated with it.

page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge rootObjectForView:]): Use new constructor. Changed misleading comment.

2:14 PM Changeset in webkit [18480] by rwlbuis

12 edits
4 adds in trunk

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=12007
SVGColor::setRGBColor color creates/deletes many strings, slowing down parsing

Refactor code so svg reuses cssparser methods. Also make
SVGColor and SVGPaint more efficient by avoiding using
setRGBColor internally.

12:59 PM Changeset in webkit [18479] by rwlbuis

2 edits in trunk/WebCore

Reviewed by weinig.

http://bugs.webkit.org/show_bug.cgi?id=12022
typo in SVGTransformable.cpp introduce in r18440

Use the helper method proposed by Eric.

12:47 PM Changeset in webkit [18478] by rwlbuis

3 edits
4 adds
8 deletes in trunk

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=12028
Adapt viewBox parsing to SVGParserUtilities

Use the new parseNumber and add tests for viewBox parsing.

12:00 PM Changeset in webkit [18477] by ggaren

2 edits in trunk/WebCore

Build fix: SVGImage only works on Mac.

loader/CachedImage.cpp: (WebCore::CachedImage::createImage):

11:28 AM Changeset in webkit [18476] by weinig

17 edits in trunk/WebCore

Reviewed by Geoff.

Patch for http://bugs.webkit.org/show_bug.cgi?id=12018
Cleanup of CSSRule and its subclasses

Make CSSRule::type() virtual instead of using a member variable.
General style cleanup.

WebCore.xcodeproj/project.pbxproj:
css/CSSCharsetRule.cpp: (WebCore::CSSCharsetRule::CSSCharsetRule):
css/CSSCharsetRule.h: (WebCore::CSSCharsetRule::isCharsetRule): (WebCore::CSSCharsetRule::type):
css/CSSFontFaceRule.cpp: (WebCore::CSSFontFaceRule::CSSFontFaceRule): (WebCore::CSSFontFaceRule::cssText):
css/CSSFontFaceRule.h: (WebCore::CSSFontFaceRule::isFontFaceRule): (WebCore::CSSFontFaceRule::type):
css/CSSImportRule.cpp: (WebCore::CSSImportRule::CSSImportRule): (WebCore::CSSImportRule::setCSSStyleSheet): (WebCore::CSSImportRule::insertedIntoParent):
css/CSSImportRule.h: (WebCore::CSSImportRule::isImportRule): (WebCore::CSSImportRule::type):
css/CSSMediaRule.cpp: (WebCore::CSSMediaRule::CSSMediaRule): (WebCore::CSSMediaRule::insertRule): (WebCore::CSSMediaRule::deleteRule): (WebCore::CSSMediaRule::cssText):
css/CSSMediaRule.h: (WebCore::CSSMediaRule::isMediaRule): (WebCore::CSSMediaRule::type):
css/CSSPageRule.cpp: (WebCore::CSSPageRule::CSSPageRule): (WebCore::CSSPageRule::selectorText): (WebCore::CSSPageRule::setSelectorText): (WebCore::CSSPageRule::cssText):
css/CSSPageRule.h: (WebCore::CSSPageRule::style): (WebCore::CSSPageRule::type):
css/CSSRule.cpp: (WebCore::CSSRule::cssText): (WebCore::CSSRule::setCssText):
css/CSSRule.h: (WebCore::CSSRule::): (WebCore::CSSRule::CSSRule):
css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::CSSStyleRule): (WebCore::CSSStyleRule::setSelectorText): (WebCore::CSSStyleRule::cssText): (WebCore::CSSStyleRule::parseString):
css/CSSStyleRule.h: (WebCore::CSSStyleRule::isStyleRule): (WebCore::CSSStyleRule::style): (WebCore::CSSStyleRule::type):
css/CSSUnknownRule.h: (WebCore::CSSUnknownRule::CSSUnknownRule): (WebCore::CSSUnknownRule::type):

9:45 AM Changeset in webkit [18475] by eseidel

2 edits in trunk/WebCore

2006-12-29 Eric Seidel <eric@eseidel.com>

Reviewed by ap.

platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::size): explicitly cast to integers to prevent compile error

6:47 AM Changeset in webkit [18474] by staikos

5 edits in trunk

Make the Qt port not crash on many sites such as www.apple.com: painter was closed too
early, and I think also there is a Qt bug that it complains about a painter being
around on a destroyed object that's really just a QShared reference going away. Worked
around.

3:17 AM Changeset in webkit [18473] by zimmermann

2 edits in trunk/WebCore

Build fixed, not reviewed. Noticed by Daniel Molkentin.

platform/graphics/svg/SVGImage.h: s/WTF/wtf/ in include.

1:17 AM Changeset in webkit [18472] by eseidel

2 edits in trunk/WebCore

2006-12-29 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyCromeClient::scaleFactor): build fix, use 1.f instead of 1f

12:36 AM Changeset in webkit [18471] by eseidel

3 edits
9 adds in trunk/LayoutTests

2006-12-29 Eric Seidel <eric@eseidel.com>

Reviewed by olliej.

Add updated SVGImage results, forgotten in last commit.

fast/images/svg-as-background-expected.checksum: Added.
fast/images/svg-as-background-expected.png: Added.
fast/images/svg-as-background-expected.txt: Added.
fast/images/svg-as-image-expected.checksum: Added.
fast/images/svg-as-image-expected.png: Added.
fast/images/svg-as-image-expected.txt: Added.
fast/images/svg-as-tiled-background-expected.checksum: Added.
fast/images/svg-as-tiled-background-expected.png: Added.
fast/images/svg-as-tiled-background-expected.txt: Added.
svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:

12:27 AM Changeset in webkit [18470] by eseidel

10 edits
9 adds in trunk

2006-12-29 Eric Seidel <eric@webkit.org>

Reviewed by hyatt.

New tests:

fast/images/svg-as-image.html
fast/images/svg-as-background.html
fast/images/svg-as-tiled-background.html

Implement basic SVGImage support.
http://bugs.webkit.org/show_bug.cgi?id=5971

This implementation depends on (rather ugly) stub Page and Frame clients in SVGImageEmptyClients.h

WebCore.xcodeproj/project.pbxproj: add SVGImage.*
ksvg2/svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::parseMappedAttribute): ignore fragment urls
loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
platform/graphics/Image.h: made setData virtual
platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::drawTiled): stub method
platform/graphics/cg/PDFDocumentImage.h:
platform/graphics/svg/SVGImage.cpp: Added. (WebCore::SVGImage::SVGImage): (WebCore::SVGImage::~SVGImage): (WebCore::SVGImage::size): (WebCore::SVGImage::draw): (WebCore::SVGImage::drawTiled): stub method (WebCore::SVGImage::setData):
platform/graphics/svg/SVGImage.h: Added. (WebCore::SVGImage::frameAtIndex):
platform/graphics/svg/SVGImageEmptyClients.h: Added. (WebCore::SVGEmptyCromeClient::~SVGEmptyCromeClient): (WebCore::SVGEmptyCromeClient::chromeDestroyed): (WebCore::SVGEmptyCromeClient::setWindowRect): (WebCore::SVGEmptyCromeClient::windowRect): (WebCore::SVGEmptyCromeClient::pageRect): (WebCore::SVGEmptyCromeClient::scaleFactor): (WebCore::SVGEmptyCromeClient::focus): (WebCore::SVGEmptyCromeClient::unfocus): (WebCore::SVGEmptyCromeClient::createWindow): (WebCore::SVGEmptyCromeClient::createModalDialog): (WebCore::SVGEmptyCromeClient::show): (WebCore::SVGEmptyCromeClient::canRunModal): (WebCore::SVGEmptyCromeClient::runModal): (WebCore::SVGEmptyCromeClient::setToolbarsVisible): (WebCore::SVGEmptyCromeClient::toolbarsVisible): (WebCore::SVGEmptyCromeClient::setStatusbarVisible): (WebCore::SVGEmptyCromeClient::statusbarVisible): (WebCore::SVGEmptyCromeClient::setScrollbarsVisible): (WebCore::SVGEmptyCromeClient::scrollbarsVisible): (WebCore::SVGEmptyCromeClient::setMenubarVisible): (WebCore::SVGEmptyCromeClient::menubarVisible): (WebCore::SVGEmptyCromeClient::setResizable): (WebCore::SVGEmptyCromeClient::addMessageToConsole): (WebCore::SVGEmptyCromeClient::canRunBeforeUnloadConfirmPanel): (WebCore::SVGEmptyCromeClient::runBeforeUnloadConfirmPanel): (WebCore::SVGEmptyCromeClient::closeWindowSoon): (WebCore::SVGEmptyFrameLoaderClient::~SVGEmptyFrameLoaderClient): (WebCore::SVGEmptyFrameLoaderClient::frameLoaderDestroyed): (WebCore::SVGEmptyFrameLoaderClient::hasWebView): (WebCore::SVGEmptyFrameLoaderClient::hasFrameView): (WebCore::SVGEmptyFrameLoaderClient::hasBackForwardList): (WebCore::SVGEmptyFrameLoaderClient::resetBackForwardList): (WebCore::SVGEmptyFrameLoaderClient::provisionalItemIsTarget): (WebCore::SVGEmptyFrameLoaderClient::loadProvisionalItemFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::invalidateCurrentItemPageCache): (WebCore::SVGEmptyFrameLoaderClient::privateBrowsingEnabled): (WebCore::SVGEmptyFrameLoaderClient::makeDocumentView): (WebCore::SVGEmptyFrameLoaderClient::makeRepresentation): (WebCore::SVGEmptyFrameLoaderClient::setDocumentViewFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::forceLayout): (WebCore::SVGEmptyFrameLoaderClient::forceLayoutForNonHTML): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForCommit): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForBackForwardNavigation): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForReload): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForStandardLoad): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForInternalLoad): (WebCore::SVGEmptyFrameLoaderClient::updateHistoryAfterClientRedirect): (WebCore::SVGEmptyFrameLoaderClient::setCopiesOnScroll): (WebCore::SVGEmptyFrameLoaderClient::tokenForLoadErrorReset): (WebCore::SVGEmptyFrameLoaderClient::resetAfterLoadError): (WebCore::SVGEmptyFrameLoaderClient::doNotResetAfterLoadError): (WebCore::SVGEmptyFrameLoaderClient::detachedFromParent1): (WebCore::SVGEmptyFrameLoaderClient::detachedFromParent2): (WebCore::SVGEmptyFrameLoaderClient::detachedFromParent3): (WebCore::SVGEmptyFrameLoaderClient::detachedFromParent4): (WebCore::SVGEmptyFrameLoaderClient::loadedFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::download): (WebCore::SVGEmptyFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveContentLength): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoading): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoading): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelClientRedirect): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillPerformClientRedirect): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillClose): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveIcon): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveTitle): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCommitLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoad): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFirstLayout): (WebCore::SVGEmptyFrameLoaderClient::dispatchCreatePage): (WebCore::SVGEmptyFrameLoaderClient::dispatchShow): (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebCore::SVGEmptyFrameLoaderClient::cancelPolicyCheck): (WebCore::SVGEmptyFrameLoaderClient::dispatchUnableToImplementPolicy): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSubmitForm): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidLoadMainResource): (WebCore::SVGEmptyFrameLoaderClient::clearLoadingFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::isLoadingFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::revertToProvisionalState): (WebCore::SVGEmptyFrameLoaderClient::setMainDocumentError): (WebCore::SVGEmptyFrameLoaderClient::clearUnarchivingState): (WebCore::SVGEmptyFrameLoaderClient::progressStarted): (WebCore::SVGEmptyFrameLoaderClient::progressCompleted): (WebCore::SVGEmptyFrameLoaderClient::incrementProgress): (WebCore::SVGEmptyFrameLoaderClient::completeProgress): (WebCore::SVGEmptyFrameLoaderClient::setMainFrameDocumentReady): (WebCore::SVGEmptyFrameLoaderClient::startDownload): (WebCore::SVGEmptyFrameLoaderClient::willChangeTitle): (WebCore::SVGEmptyFrameLoaderClient::didChangeTitle): (WebCore::SVGEmptyFrameLoaderClient::committedLoad): (WebCore::SVGEmptyFrameLoaderClient::finishedLoading): (WebCore::SVGEmptyFrameLoaderClient::finalSetupForReplace): (WebCore::SVGEmptyFrameLoaderClient::cancelledError): (WebCore::SVGEmptyFrameLoaderClient::cannotShowURLError): (WebCore::SVGEmptyFrameLoaderClient::interruptForPolicyChangeError): (WebCore::SVGEmptyFrameLoaderClient::cannotShowMIMETypeError): (WebCore::SVGEmptyFrameLoaderClient::fileDoesNotExistError): (WebCore::SVGEmptyFrameLoaderClient::shouldFallBack): (WebCore::SVGEmptyFrameLoaderClient::setDefersLoading): (WebCore::SVGEmptyFrameLoaderClient::willUseArchive): (WebCore::SVGEmptyFrameLoaderClient::isArchiveLoadPending): (WebCore::SVGEmptyFrameLoaderClient::cancelPendingArchiveLoad): (WebCore::SVGEmptyFrameLoaderClient::clearArchivedResources): (WebCore::SVGEmptyFrameLoaderClient::canHandleRequest): (WebCore::SVGEmptyFrameLoaderClient::canShowMIMEType): (WebCore::SVGEmptyFrameLoaderClient::representationExistsForURLScheme): (WebCore::SVGEmptyFrameLoaderClient::generatedMIMETypeForURLScheme): (WebCore::SVGEmptyFrameLoaderClient::frameLoadCompleted): (WebCore::SVGEmptyFrameLoaderClient::restoreScrollPositionAndViewState): (WebCore::SVGEmptyFrameLoaderClient::provisionalLoadStarted): (WebCore::SVGEmptyFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebCore::SVGEmptyFrameLoaderClient::addHistoryItemForFragmentScroll): (WebCore::SVGEmptyFrameLoaderClient::didFinishLoad): (WebCore::SVGEmptyFrameLoaderClient::prepareForDataSourceReplacement): (WebCore::SVGEmptyFrameLoaderClient::createDocumentLoader): (WebCore::SVGEmptyFrameLoaderClient::setTitle): (WebCore::SVGEmptyFrameLoaderClient::userAgent): (WebCore::SVGEmptyEditorClient::~SVGEmptyEditorClient): (WebCore::SVGEmptyEditorClient::pageDestroyed): (WebCore::SVGEmptyEditorClient::shouldDeleteRange): (WebCore::SVGEmptyEditorClient::shouldShowDeleteInterface): (WebCore::SVGEmptyEditorClient::smartInsertDeleteEnabled): (WebCore::SVGEmptyEditorClient::isContinuousSpellCheckingEnabled): (WebCore::SVGEmptyEditorClient::toggleContinuousSpellChecking): (WebCore::SVGEmptyEditorClient::isGrammarCheckingEnabled): (WebCore::SVGEmptyEditorClient::toggleGrammarChecking): (WebCore::SVGEmptyEditorClient::spellCheckerDocumentTag): (WebCore::SVGEmptyEditorClient::selectWordBeforeMenuEvent): (WebCore::SVGEmptyEditorClient::isEditable): (WebCore::SVGEmptyEditorClient::shouldBeginEditing): (WebCore::SVGEmptyEditorClient::shouldEndEditing): (WebCore::SVGEmptyEditorClient::shouldInsertNode): (WebCore::SVGEmptyEditorClient::shouldInsertText): (WebCore::SVGEmptyEditorClient::shouldApplyStyle): (WebCore::SVGEmptyEditorClient::didBeginEditing): (WebCore::SVGEmptyEditorClient::respondToChangedContents): (WebCore::SVGEmptyEditorClient::didEndEditing): (WebCore::SVGEmptyEditorClient::registerCommandForUndo): (WebCore::SVGEmptyEditorClient::registerCommandForRedo): (WebCore::SVGEmptyEditorClient::clearUndoRedoOperations): (WebCore::SVGEmptyEditorClient::canUndo): (WebCore::SVGEmptyEditorClient::canRedo): (WebCore::SVGEmptyEditorClient::undo): (WebCore::SVGEmptyEditorClient::redo): (WebCore::SVGEmptyEditorClient::dataForArchivedSelection): (WebCore::SVGEmptyEditorClient::userVisibleString): (WebCore::SVGEmptyContextMenuClient::~SVGEmptyContextMenuClient): (WebCore::SVGEmptyContextMenuClient::contextMenuDestroyed): (WebCore::SVGEmptyContextMenuClient::addCustomContextMenuItems): (WebCore::SVGEmptyContextMenuClient::contextMenuItemSelected): (WebCore::SVGEmptyContextMenuClient::downloadURL): (WebCore::SVGEmptyContextMenuClient::copyImageToClipboard): (WebCore::SVGEmptyContextMenuClient::lookUpInDictionary): (WebCore::SVGEmptyContextMenuClient::speak): (WebCore::SVGEmptyContextMenuClient::stopSpeaking): (WebCore::SVGEmptyContextMenuClient::searchWithSpotlight):

12:27 AM Changeset in webkit [18469] by eseidel

2 edits in trunk/WebKitTools

2006-12-29 Eric Seidel <eric@eseidel.com>

Reviewed by olliej.

Stop DumpRenderTree from reporting false Frame/Node leaks due to new SVGImage

DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): clear WebCore cache before exiting

12:15 AM Changeset in webkit [18468] by ddkilzer

3 edits
1 delete in trunk

LayoutTests:

Reviewed by NOBODY (build fix).

Reverted last commit until WebResourceData issue is fixed.

http://bugs.webkit.org/show_bug.cgi?id=11882
Need a way to regression test .webarchive output files

webarchive/resources/apple.gif: Removed.
webarchive/resources/dump-webarchive.js: Removed.
webarchive/resources/test-frame.html: Removed.
webarchive/resources/test-style.css: Removed.
webarchive/test-body-background-expected.txt: Removed.
webarchive/test-body-background.html: Removed.
webarchive/test-duplicate-resources-expected.txt: Removed.
webarchive/test-duplicate-resources.html: Removed.
webarchive/test-frameset-expected.txt: Removed.
webarchive/test-frameset.html: Removed.
webarchive/test-img-src-expected.txt: Removed.
webarchive/test-img-src.html: Removed.
webarchive/test-input-src-expected.txt: Removed.
webarchive/test-input-src.html: Removed.
webarchive/test-link-href-expected.txt: Removed.
webarchive/test-link-href.html: Removed.
webarchive/test-object-data-expected.txt: Removed.
webarchive/test-object-data.html: Removed.
webarchive/test-script-src-expected.txt: Removed.
webarchive/test-script-src.html: Removed.
webarchive/test-table-background-expected.txt: Removed.
webarchive/test-table-background.html: Removed.
webarchive/test-td-background-expected.txt: Removed.
webarchive/test-td-background.html: Removed.

WebKitTools:

Reviewed by NOBODY (build fix).

Reverted last commit until WebResourceData issue is fixed.

http://bugs.webkit.org/show_bug.cgi?id=11882
Need a way to regression test .webarchive output files

DumpRenderTree/DumpRenderTree.m: (serializeWebArchiveToXML): Removed. (dump): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController dumpAsWebArchive]): Removed. (runTest):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed