Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Jan 5, 2007:

10:24 PM Changeset in webkit [18638] by adele

• 2 edits in trunk/WebCore

Release build fix.

• rendering/RenderListItem.cpp: (WebCore::RenderListItem::explicitValueChanged): Initialize listRenderer.

5:36 PM Changeset in webkit [18637] by darin

• 391 edits
  935 adds
  152 deletes in trunk

LayoutTests:

Reviewed by Hyatt.

• added a new version of the CSS 2.1 test from the W3C site
• added counters, list, and other CSS tests for my counter-related check-in

• css2.1: Updated to the 2006-10-11 version of the test suite. I downloaded it from ​http://www.w3.org/Style/CSS/Test/CSS2.1/20061011/ added UTF-8 BOMs to the beginning of all the files, and generated expected results.

• fast/css-generated-content/reset-content-to-initial-expected.txt: Updated to reflect a bug fix in CSS content property support.

• fast/css/counters/*: Removed all the existing tests since they are now part of the CSS 2.1 test suite.

• fast/css/counters/counter-text-security-expected.checksum: Added. New test.
• fast/css/counters/counter-text-security-expected.png: Ditto.
• fast/css/counters/counter-text-security-expected.txt: Ditto.
• fast/css/counters/counter-text-security.html: Ditto.

• fast/css/counters/counter-text-transform-expected.checksum: Added. New test.
• fast/css/counters/counter-text-transform-expected.png: Ditto.
• fast/css/counters/counter-text-transform-expected.txt: Ditto.
• fast/css/counters/counter-text-transform.html: Ditto.

• fast/lists/decimal-leading-zero-expected.checksum: Added. New test.
• fast/lists/decimal-leading-zero-expected.png: Ditto.
• fast/lists/decimal-leading-zero-expected.txt: Ditto.
• fast/lists/decimal-leading-zero.html: Ditto.

• fast/css/text-security-expected.checksum: Added. New test.
• fast/css/text-security-expected.png: Ditto.
• fast/css/text-security-expected.txt: Ditto.
• fast/css/text-security.html: Ditto.

• fast/lists/decimal-leading-zero-expected.checksum: Added. New test.
• fast/lists/decimal-leading-zero-expected.png: Ditto.
• fast/lists/decimal-leading-zero-expected.txt: Ditto.
• fast/lists/decimal-leading-zero.html: Ditto.

• fast/lists/li-values-expected.checksum: Added. New test.
• fast/lists/li-values-expected.png: Ditto.
• fast/lists/li-values-expected.txt: Ditto.
• fast/lists/li-values.html: Ditto.

• fast/css/import-rule-regression-11590-expected.checksum: Added. Missing pixel-test results.
• fast/css/import-rule-regression-11590-expected.png: Ditto.
• fast/dom/css-insert-import-rule-expected.checksum: Ditto.
• fast/dom/css-insert-import-rule-expected.png: Ditto.
• fast/forms/encoding-test-expected.checksum: Ditto.
• fast/forms/encoding-test-expected.png: Ditto.
• fast/frames/frame-src-attribute-expected.checksum: Ditto.
• fast/frames/frame-src-attribute-expected.png: Ditto.
• fast/frames/onlyCommentInIFrame-expected.png: Ditto.
• fast/frames/viewsource-attribute-expected.checksum: Ditto.
• fast/frames/viewsource-attribute-expected.png: Ditto.
• fast/loader/start-load-in-unload-expected.checksum: Ditto.
• fast/loader/start-load-in-unload-expected.png: Ditto.

WebCore:

Reviewed by Hyatt.

• eliminated use of DeprecatedString for list item markers
• eliminated use of DeprecatedValueList for border style collapsing
• made many members private instead of protected or public

• reworked counter implementation to fix most of the CSS 2.1 counter tests;

made CounterNode be a simple non-polymorphic class, moved most counter-
specific code out of RenderObject into RenderCounter, changed the data
structure in RenderStyle to be more speed-efficient but less space-
efficient for nodes with counter styles

• fixed ​http://bugs.webkit.org/show_bug.cgi?id=11557

Tests: css2.1

• fixed a bug where counter text did not have text transform or text security applied to it

Test: fast/css/counters/counter-text-security.html
Test: fast/css/counters/counter-text-transform.html

• improved handling of CSS content property values with data of the wrong type; this probably needs a bit more refinement

Test: fast/css-generated-content/reset-content-to-initial-expected.txt

• fixed a bug where removing the value attribute from an HTMLLIElement would set the list item's value to 0 instead of restoring it to normal

Test: fast/lists/li-values.html

• fixed a bug where changing the text security style from one style to another would not change the displayed text

Test: fast/css/text-security.html

• fixed some problems handling long sequences of counter-related styles; still needs more work and some super-large test cases to check if recursive algorithms for these that will overflow stack remain

• added support for list styles decimal-leading-zero, hiragana, hirigana-iroha, katakana, katakana-iroha, cjk-ideographic, armenian, and georgian

Test: fast/lists/decimal-leading-zero.html

• minor tweaks and bug fixes for other list styles, including range checking

• WebCore.exp: Updated for RenderListItem change.

• bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject value]): Updated to use String instead of DeprecatedString.

• css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Removed implementation for counter styles for now. We should probably restore it later, but we need to make sure the returned list is separate from the original list in the DOM -- modifying the list should not change the element it was computed from.

• css/Counter.h: Removed unneeded empty constructor and destructor.

• css/cssstyleselector.cpp: (WebCore::applyCounterList): Added. Stores counter directives in hash tables that should allow us to efficiently implement dynamic counter changes. Full support will have to wait for a future check-in. (WebCore::CSSStyleSelector::applyProperty): Changed counter properties to call applyCounterList. Reformatted the code to parse the content property for changes to RenderStyle and to handle the case where some the items in the content list don't generate any content.

• editing/visible_units.cpp:
• rendering/RenderBox.cpp:
• rendering/RenderFlexibleBox.cpp:
• rendering/RenderFlow.cpp:
• rendering/RenderSlider.cpp: Added includes needed because of header changes.

• html/HTMLLIElement.H: Removed unneeded m_isValued.
• html/HTMLLIElement.cpp: (WebCore::HTMLLIElement::parseMappedAttribute): To match test results seen in WinIE, ignore values that are 0 or negative, and use new functions in RenderListItem to communicate the lack of a valid value. (WebCore::HTMLLIElement::attach): More of the same.

• rendering/CounterNode.h: Made CounterNode be a non-polymorphic class, removing all the subclasses. Merged in CounterResetNode. Removed m_total from CounterResetNode, because it isn't needed for any of the styles (decimal-leading-zero always uses two digits). Removed m_hasSeparator and m_willNeedLayout since they aren't needed any more. Renamed m_count to m_countInParent for clarify, and named the list links the same as their associated functions. Removed many functions as well.
• rendering/CounterNode.cpp: (WebCore::CounterNode::CounterNode): Added new fields. (WebCore::CounterNode::computeCountInParent): Added. Used by recount. (WebCore::CounterNode::recount): Simplified by removing unused parameter and the "get next" idiom. Changed to be iterative instead of recursive so we can handle arbitrarily long lists. (WebCore::CounterNode::insertAfter): Moved here from CounterResetNode. Updated for field name changes. Corrected rule for when to recount. (WebCore::CounterNode::removeChild): Moved here from CounterResetNode. Changed to only work on nodes without children. Corrected rule for when to recount. (WebCore::nextInPreOrderAfterChildren): Added. For debugging only. (WebCore::nextInPreOrder): Ditto. (WebCore::showTreeAndMark): Ditto. (showTree): Ditto.

• rendering/CounterListItem.h:
• rendering/CounterResetNode.h:
• rendering/CounterResetNode.cpp: Marked ready to remove. I'll do the remove in a separate patch, since I have to update a lot of different make files when I do.

• rendering/ListMarkerBox.cpp: (WebCore::ListMarkerBox::isText): Changed for the change to RenderListMarker.

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::addChildToFlow): Changed to use functions instead of direct field access so the fields can be private and we don't need to be friends. (WebCore::RenderBlock::getBaselineOfFirstLineBox): Ditto. (WebCore::RenderBlock::getBaselineOfLastLineBox): Ditto.
• rendering/RenderBlock.h: (WebCore::RenderBlock::initMaxMarginValues): Ditto. (WebCore::RenderBlock::firstRootBox): Ditto. (WebCore::RenderBlock::lastRootBox): Ditto.
• rendering/RenderBox.h: (WebCore::RenderBox::setWidth): Ditto. (WebCore::RenderBox::setHeight): Ditto.
• rendering/RenderButton.cpp: (WebCore::RenderButton::addChild): Ditto.
• rendering/bidi.cpp: (WebCore::RenderBlock::determineStartPosition): Ditto.

• rendering/RenderContainer.h: Renamed m_first and m_last to m_firstChild and m_lastChild. Made them private instead of proected. Removed the setFirstChild and setLastChild functions.
• rendering/RenderContainer.cpp: (WebCore::RenderContainer::RenderContainer): Updated for field name change. Changed all calls to get at fields directly instead of using functions. (WebCore::RenderContainer::destroyLeftoverChildren): Ditto. (WebCore::updateListMarkerNumbers): Updated for RenderListItem change. (WebCore::RenderContainer::addChild): Changed to get at fields directly instead of using functions. Also used release() since RenderText::setText now takes PassRefPtr. (WebCore::RenderContainer::removeChildNode): Changed to get at fields directly instead of using functions. (WebCore::RenderContainer::updatePseudoChildForObject): Create the anonymous box only if at least one of of the items in the content list actually generates content. Since a RenderCounter is a RenderText, don't bother making a new style for it -- it just shares the style with its parent. Changed code to use RenderImage::setCachedImage() instead of of setContentObject(). Added a call to setIsAnonymousImage() here, which was the only special thing that setContentObject() used to do. Pass a reference to the counter to the RenderCounter rather than a pointer. Pass document() as the node instead of passing the element to RenderCounter, which makes it anonymous automatically, and removed the setIsAnonymous call. (WebCore::RenderContainer::appendChildNode): Chagned to get at fields directly instead of using functions. (WebCore::RenderContainer::insertChildNode): Ditto. (WebCore::RenderContainer::layout): Ditto. (WebCore::RenderContainer::removeLeftoverAnonymousBoxes): Ditto. (WebCore::RenderContainer::positionForCoordinates): Ditto. (WebCore::RenderContainer::addLineBoxRects): Ditto.

• rendering/RenderCounter.h: Removed unneeded layout override, never called on a text node. Added override of originalString. Replaced CounterData* with a copy of the CounterContent -- it's two atomic strings and an integer so it's efficient enough to store all three in the render object, and this eliminates the lifetime problems we could have if we used a pointer.
• rendering/RenderCounter.cpp: Removed duplicate copy of list marker code. (WebCore::counterMaps): Moved these maps here from RenderObject. (WebCore::previousSiblingOrParent): Added. (WebCore::lastDescendant): Added. (WebCore::previousInPreOrder): Added. (WebCore::planCounter): Added. (WebCore::findPlaceForCounter): Added. (WebCore::counter): New name of function that was named RenderObject::findCounter. Also uses a new algorithm that passes all the CSS 2.1 tests. (WebCore::RenderCounter::RenderCounter): Changed to take a Document* instead of a Node*, since at the moment counters are always anonymous. (WebCore::RenderCounter::originalString): Added. This overrides the originalString in the RenderText base class so that any text transforms will use the counter's value. This code was previously in calcMinMaxWidth. (WebCore::RenderCounter::calcMinMaxWidth): Changed to call setInternalString and pass originalString -- this uses the counter's value from the counter tree. (WebCore::destroyCounterNodeChildren): Added. (WebCore::RenderCounter::destroyCounterNodes): Added. Called as needed from RenderObject::destroy for objects that have counter nodes.

• rendering/RenderFlow.h: Made m_continuation private instead of protected.

• rendering/RenderImage.h: Removed unneeded includes, and unnecessary element() function that casts to HTMLElement*. Made image() protected, and made the two calcAspectRatio functions private. Removed setContentObject(). Renamed the errorOccured() function to isErrorImage() and made it private.
• rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): Removed initialization of removed m_selectionState field. (WebCore::RenderImage::setCachedImage): Rearrange code so it won't try to call isErrorImage() on a null image. (WebCore::RenderImage::paint): Updated for name change.

• rendering/RenderListBox.h: Removed unneeded forward declarations.

• rendering/RenderListItem.h: Renamed markerStringValue() to markerText() and made it return a String instead of a DeprecatedString. Renamed m_prededfVal to m_explicitValue. Added booleans named m_hasExplicitValue and m_isValueUpToDate and marked m_value mutable so it can be computed in const member functions. (WebCore::RenderListItem::value): Changed to update value on demand at the time you ask for it. (WebCore::RenderListItem::hasExplicitValue): Added. Use instead of magic -1 value to indicate that the item does or does not have an explicit value. (WebCore::RenderListItem::explicitValue): Added. (WebCore::RenderListItem::setExplicitValue): Added. (WebCore::RenderListItem::clearExplicitValue): Added.
• rendering/RenderListItem.cpp: (WebCore::RenderListItem::RenderListItem): Updated to not use magic -1 values. (WebCore::RenderListItem::setStyle): Removed call to RenderListMarker::setListItem since it's not needed any more, and instead pass the list item to the constructor. (WebCore::previousListItem): Made parameter const. (WebCore::RenderListItem::calcValue): Restructed the function a bit. (WebCore::RenderListItem::updateValueNow): Added. Calls calcValue. (WebCore::RenderListItem::updateValue): Added. New name for resetValue(). Unlike the old version, this no longer calculates the value until it's asked-for later. (WebCore::RenderListItem::markerText): Changed to return String rather than a DeprecatedString and to return a null string rather than empty string when there is no marker.

• rendering/RenderListMarker.h: Added listMarkerText function -- common code shared with anyone who needs to convert a value into text given a list style. Changed constructor to take a RenderListItem and figure out the document from that. Added isImage() and isText() functions and removed listImage() function. Changed the type of the text() function from DeprecatedString to String. Removed the listItem() and seListeItem() functions. Made the getRelativeMarkerRect() function private. Renamed m_item to m_text and chagned it from DeprecatedString to String. Renamed m_listImage to m_image.
• rendering/RenderListMarker.cpp: (WebCore::toRoman): Added range checking to fix buffer overrun for large or negative numbers. Rewrote to use a local UChar array and String rather than prepending to a DeprecatedString. (WebCore::toAlphabetic): Replaces toLetterString, and is more flexible since it takes an alphabet array. Changed to match CSS 3 specification by using decimal numbering for 0 and negative numbers. Rewrote to use a local UChar array and String rather than prepending to a DeprecatedString. (WebCore::toHebrewUnder1000): Added. Helper function for Hebrew numbers so we can handle numbers up to a million. (WebCore::toHebrew): Changed to use toHebrewUnder1000, added a special case for zero, negative, and too-large numbers. (WebCore::toArmenianUnder10000): Added. Used by toArmenian. (WebCore::toArmenian): Added. (WebCore::toGeorgian): Added. (WebCore::toCJKIdeographic): Added. (WebCore::listMarkerText): Added. Moved the code here from calcMinMaxWidth, but added support for text for the styles disc, circle, square, decimal-leading-zero, hiragana, hirigana-iroha, katakana, katakana-iroha, cjk-ideographic, armenian, and georgian. Also changed some of the styles to share the new toAlphabetic function. (WebCore::RenderListMarker::RenderListMarker): Updated for name changes and list item parameter. (WebCore::RenderListMarker::~RenderListMarker): Updated for name changes. (WebCore::RenderListMarker::setStyle): Updated for name changes. (WebCore::RenderListMarker::isImage): Added. Useful helper that unifies the check for no image and the error image. (WebCore::RenderListMarker::paint): Updated for name changes to to use isImage() and rearranged the code a bit. (WebCore::RenderListMarker::imageChanged): Updated for name change (WebCore::RenderListMarker::calcMinMaxWidth): Updated for name change, fixed a bug where we'd leave the old text around if we were using an image-based marker. Also changed the code to use isImage() instead of checking m_listImage. (WebCore::RenderListMarker::calcWidth): Changed to use isImage(). (WebCore::RenderListMarker::lineHeight): Changed to use isImage(). (WebCore::RenderListMarker::baselinePosition): Changed to use isImage(). (WebCore::RenderListMarker::getRelativeMarkerRect): Changed to use isImage(), restructured the code a little.

• rendering/RenderObject.h: Removed now-uneeded includes. Removed collectBorders() and isFormElement(). Made remove() function and m_hasCounterNodeMap public so we could remove friend declarations for RenderListItem and RenderView. Moved findCounter() to become a private function inside RenderCounter.cpp.
• rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): Fix bug where a contentData() with CONTENT_NONE is treated as image content -- only look at the content property if it has exactly one entry which is a CONTENT_OBJECT. (WebCore::RenderObject::selectionStartEnd): Add const. (WebCore::RenderObject::destroy): Moved counter-specific code to RenderCounter::destroyCounterNodes. (WebCore::RenderObject::recalcMinMaxWidths): Changed code to set m_recalcMinMax near the top of the function -- the old code would potentially reset it after it was set by the calcMinMaxWidths functions, and possibly skip a future needed recalc. That came up in counter test cases. Removed unneeded boolean check right after an assertion.

• rendering/RenderPart.h: Marked two virtual functions virtual for clarity.

• rendering/RenderReplaced.h: Made shouldPaint be protected, and made m_intrinsicWidth, m_intrinsicHeight, and m_selectionState be private. Also marked isSelected() const.
• rendering/RenderReplaced.cpp: Added newly-needed include. (WebCore::RenderReplaced::RenderReplaced): Use constructor syntax. (WebCore::RenderReplaced::isSelected): Made const and changed to call the selectionStartEnd function in the straightforward way.

• rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteRects): Use functions instead of direct field access so the fields can be private. (WebCore::RenderSVGText::relativeBBox): Ditto.

• rendering/RenderStyle.h: Tweaked formatting. Changed names of CSS3 holders to say "rare" instead, since it's not all CSS 3. Renamed CounterData to CounterContent, since it's used inside ContentData. Changed names of fields in ContentData to have m prefix. Moved content and counter fields into the rare non-inherited data object. Removed unneeded assignment operator from a class that already inherits from Shared which makes it start out noncopyable.
• rendering/RenderStyle.cpp: Name changes, plus: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Updated for added fields (content, counter-reset, counter-increment). (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): Ditto. (WebCore::StyleRareNonInheritedData::operator==): Reformatted and sorted so it's easy to see if any fields are missing. (WebCore::operator!=): Added. Compares two CounterContent objects. (WebCore::RenderStyle::arenaDelete): Removed code to handle content, which is now in the rareNonInheritedData structure. (WebCore::RenderStyle::RenderStyle): Ditto. (WebCore::RenderStyle::inheritFrom): Ditto. (WebCore::RenderStyle::operator==): Ditto. (WebCore::RenderStyle::inheritedNotEqual): (WebCore::RenderStyle::diff): (WebCore::RenderStyle::contentDataEquivalent): Added case for counter, which previously would be ignored when determining if content is equivalent. (WebCore::RenderStyle::clearContent): Added. (WebCore::RenderStyle::setContent): Updated for change in content location. (WebCore::ContentData::clear): Changed algorithm so that it's not recursive and thus can handle a very long list of ContentData. (WebCore::operator==): Added. Compares two CounterDirective objects. (WebCore::RenderStyle::counterDirectives): Added. (WebCore::RenderStyle::accessCounterDirectives): Added.

• rendering/RenderTable.h: Made m_currentBorder const to better reflect the paint algorithm.
• rendering/RenderTable.cpp: (WebCore::RenderTable::paint): Changed to use Vector instead of DeprecatedValueList for the border styles, and to sort rather than inserting in sorted order as we go. Put the code to loop through the nodes and collect border styles here instead of in a RenderObject virtual function. Also set m_currentBorder to 0 after the loop for greater clarity.

• rendering/RenderTableCell.h: Added a typedef for a vector of border values. Removed the virtual collectBorders and replaced with the non-virtual named collectBorderStyles. Also added a static member function named sortBorderStyles.
• rendering/RenderTableCell.cpp: (WebCore::CollapsedBorders::CollapsedBorders): Removed unneeded constructor parameter. (WebCore::addBorderStyle): Changed to use a vector instead of a DeprecatedValueList. Wrote out a loop since Vector doesn't have a contains member function. Removed the code to insert the border at a sorted location; instead we have a separate call to sort the border styles (WebCore::RenderTableCell::collectBorderStyles): Renamed, and changed the parameter type. (WebCore::compareBorderStylesForQSort): Added. (WebCore::RenderTableCell::sortBorderStyles): Added.

• rendering/RenderText.h: Changed StringImpl parameters in setText functions to be PassRefPtr; added a new setInternalString function. Made a bunch of the member functions private and made all the data members private instead of protected.
• rendering/RenderText.cpp: (WebCore::RenderText::setStyle): Restructure a bit for clarity. Fix case where the old style has a different security than the new style. Use release() since RenderText::setText now takes PassRefPtr. Always call cacheWidths here. (WebCore::RenderText::setTextWithOffset): Changed to take the string as a PassRefPtr instead of a raw pointer. (WebCore::isInlineFlowOrEmptyText): Added. (WebCore::RenderText::setInternalString): Refactored core of setText into a separate protected member function that can be used RenderCounter. Changed the text security square character to match what's used in list markers. Changed the text transform switch statement so that gcc will warn us if we add a new value and don't add a case for it. (WebCore::RenderText::setText): Refactored most of the function into setInternalString. Removed the call to cacheWidths -- that's now done in the setStyle function only.

• rendering/RenderView.h:
• rendering/RenderView.cpp: (WebCore::RenderView::selectionStartEnd): Now const.

• rendering/RenderWidget.cpp: Added newly-needed include. (WebCore::RenderWidget::setSelectionState): Don't bother setting m_selectionState here since RenderReplaced::setSelectionState already does that.

WebKit:

Reviewed by Hyatt.

• Misc/WebNSAttributedStringExtras.m: (+[NSAttributedString _web_attributedStringFromRange:]): Updated to use new list marker text API that is String rather than DeprecatedString. Also removed code to do text form of non-text list markers since the list marker class now deals with that.

5:13 PM Changeset in webkit [18636] by andersca

• 3 edits in trunk/WebKit

Reviewed by Darin.

Fix build.

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchCreatePage):

5:09 PM Changeset in webkit [22734] by andersca

• 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Update temporary link stubs.

• platform/win/TemporaryLinkStubs.cpp: (FrameLoader::referrer): (FrameLoader::overrideMediaType): (FrameLoader::checkLoadCompleteForThisFrame): (DocumentLoader::getResponseRefreshAndModifiedHeaders): (MainResourceLoader::create): (ResourceLoader::cancel): (ResourceLoader::load): (ResourceLoader::releaseResources): (ResourceLoader::addData):

WebKitWin:

Reviewed by Adam.

Add stubs for FrameLoaderClient methods.

• WebFrame.cpp: (WebFrame::setMainDocumentError): (WebFrame::cancelledError): (WebFrame::cannotShowURLError): (WebFrame::interruptForPolicyChangeError): (WebFrame::cannotShowMIMETypeError): (WebFrame::fileDoesNotExistError): (WebFrame::committedLoad): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction): (WebFrame::dispatchUnableToImplementPolicy): (WebFrame::download): (WebFrame::willUseArchive): (WebFrame::dispatchWillSendRequest): (WebFrame::dispatchDidReceiveResponse): (WebFrame::dispatchDidReceiveContentLength): (WebFrame::dispatchDidFinishLoading): (WebFrame::dispatchDidFailLoading): (WebFrame::dispatchDidLoadResourceFromMemoryCache): (WebFrame::dispatchDidFailProvisionalLoad): (WebFrame::dispatchDidFailLoad): (WebFrame::dispatchCreatePage): (WebFrame::incrementProgress): (WebFrame::completeProgress): (WebFrame::startDownload):

4:55 PM Changeset in webkit [18635] by andersca

• 9 edits in trunk/WebCore

Rubber stamped by Adam.

Move even more code to .cpp files.

• WebCore.xcodeproj/project.pbxproj:
• loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::load): (WebCore::FrameLoader::canLoad): (WebCore::FrameLoader::initialRequest): (WebCore::FrameLoader::receivedData): (WebCore::FrameLoader::setRequest): (WebCore::FrameLoader::setResponse): (WebCore::FrameLoader::willUseArchive): (WebCore::FrameLoader::handleUnimplementablePolicy): (WebCore::FrameLoader::cannotShowMIMEType): (WebCore::FrameLoader::interruptionForPolicyChangeError): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::finishedLoading): (WebCore::FrameLoader::continueAfterWillSubmitForm): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::post): (WebCore::FrameLoader::isReloading): (WebCore::FrameLoader::loadEmptyDocumentSynchronously): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::identifierForInitialRequest): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::didFailToLoad): (WebCore::FrameLoader::originalRequest): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::dataURLBaseFromRequest): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::loadedResourceFromMemoryCache): (WebCore::FrameLoader::applyUserAgent): (WebCore::PolicyCheck::PolicyCheck): (WebCore::PolicyCheck::clear): (WebCore::PolicyCheck::set): (WebCore::PolicyCheck::call): (WebCore::PolicyCheck::clearRequest):
• loader/FrameLoader.h:
• loader/FrameLoaderClient.h:
• loader/MainResourceLoader.h:
• loader/ResourceLoader.h: (WebCore::ResourceLoader::setIdentifier): (WebCore::ResourceLoader::identifier):
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::didReceiveAuthenticationChallenge): (WebCore::FrameLoader::didCancelAuthenticationChallenge): (WebCore::FrameLoader::didChangeTitle):
• platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::dispatchCreatePage):

4:21 PM Changeset in webkit [22733] by aliceli1

• 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Lou.

Fixed <rdar://problem/4853400> disable commands in the Edit menu when they're not applicable
and <rdar://problem/4769487> Some editing operations should be disabled in View Source window

• Interfaces/IWebView.idl:
• WebView.cpp: (WebView::hasSelectedRange): (WebView::cutEnabled): (WebView::copyEnabled): (WebView::pasteEnabled): (WebView::deleteEnabled): (WebView::editingEnabled):
• WebView.h:

3:03 PM Changeset in webkit [18634] by adele

• 7 edits
  8 adds in trunk

LayoutTests:

Reviewed by Hyatt.

• repaint tests and updated results for ​http://bugs.webkit.org/show_bug.cgi?id=12079 Nested tables don't repaint properly when a certain row is added

• fast/repaint/table-section-overflow-expected.checksum: Added.
• fast/repaint/table-section-overflow-expected.png: Added.
• fast/repaint/table-section-overflow-expected.txt: Added.
• fast/repaint/table-section-overflow.html: Added.
• fast/repaint/table-section-repaint-expected.checksum: Added.
• fast/repaint/table-section-repaint-expected.png: Added.
• fast/repaint/table-section-repaint-expected.txt: Added.
• fast/repaint/table-section-repaint.html: Added.
• tables/mozilla/core/misc-expected.txt:
• tables/mozilla/core/misc-expected.png:
• tables/mozilla/core/misc-expected.checksum:

WebCore:

Reviewed by Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12079 Nested tables don't repaint properly when a certain row is added

Tests: fast/repaint/table-section-repaint.html

fast/repaint/table-section-overflow.html

Fixed repainting when table sections move during layout.

Made table cells' overflows propagate to table sections and gave tables
overflows.

• rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Added computation of horizontal and vertical overflows based on the caption's and the table sections' overflows. Added checks for table sections that change position during layout. When that happens, we assume all sections below the first section that moved also moved, and repaint everything downwards from there. Added calls to repaintDuringLayoutIfMoved() for the caption. Changed the way table sections are iterated over and added a FIXME to change it again once bug 12124 is fixed. (WebCore::RenderTable::paint): Changed to paint overflow. (WebCore::RenderTable::outerBorderBottom):
• rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): (WebCore::RenderTableSection::layoutRows): Added code to compute the section's overflow and a flag saying whether any cells in this section overflow. (WebCore::RenderTableSection::paint): Changed to paint overflow. If any cell in the section has overflow, then all cells are given a chance to paint. This is needed because there can be internal overflow, and external overflow can be coming from any cell inside.
• rendering/RenderTableSection.h: (WebCore::RenderTableSection::overflowWidth): (WebCore::RenderTableSection::overflowLeft):

2:48 PM Changeset in webkit [18633] by bdakin

• 2 edits in trunk/WebCore

Reviewed by Adam.

Fix for <rdar://problem/4863434> Wrong contextual menu appears for
textarea and input elements at ​http://www.apple.com/feedback/
ical.html

No test cases added since context menus are not in DRT.

• page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent): Call EventHandler's hitTestResultAtPoint() instead of just hit testing the layer.

2:37 PM Changeset in webkit [22732] by andersca

• 5 edits in branches/WindowsMerge

WebCoreWin:

Fix build.

• platform/win/TemporaryLinkStubs.cpp: (ResourceLoader::cancel): (FrameLoader::didChangeTitle): (DocumentLoader::unreachableURL):

WebKitWin:

Reviewed by Adam.

Add stubs for new FrameLoaderClient methods.

• WebFrame.cpp: (WebFrame::createDocumentLoader): (WebFrame::setMainDocumentError): (WebFrame::cancelledError): (WebFrame::cannotShowURLError): (WebFrame::interruptForPolicyChangeError): (WebFrame::cannotShowMIMETypeError): (WebFrame::fileDoesNotExistError): (WebFrame::shouldFallBack): (WebFrame::committedLoad):
• WebFrame.h:

2:27 PM Changeset in webkit [18632] by andersca

• 1 edit in trunk/WebCore/ChangeLog

independEnt

2:26 PM Changeset in webkit [18631] by andersca

• 9 edits in trunk/WebCore

Rubber-stamped by Adam.

Move a bunch of platform independant code over to DocumentLoader.cpp

• WebCore.xcodeproj/project.pbxproj:
• loader/DocumentLoader.cpp: (WebCore::canonicalizedTitle): (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::setMainResourceData): (WebCore::DocumentLoader::mainResourceData): (WebCore::DocumentLoader::originalRequest): (WebCore::DocumentLoader::originalRequestCopy): (WebCore::DocumentLoader::request): (WebCore::DocumentLoader::initialRequest): (WebCore::DocumentLoader::actualRequest): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::setMainDocumentError): (WebCore::DocumentLoader::clearErrors): (WebCore::DocumentLoader::mainReceivedError): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setupForReplace): (WebCore::DocumentLoader::commitIfReady): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setCommitted): (WebCore::DocumentLoader::isCommitted): (WebCore::DocumentLoader::setLoading): (WebCore::DocumentLoader::isLoading): (WebCore::DocumentLoader::commitLoad): (WebCore::DocumentLoader::doesProgressiveLoad): (WebCore::DocumentLoader::receivedData): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::updateLoading): (WebCore::DocumentLoader::setFrame): (WebCore::DocumentLoader::attachToFrame): (WebCore::DocumentLoader::detachFromFrame): (WebCore::DocumentLoader::prepareForLoadStart): (WebCore::DocumentLoader::setIsClientRedirect): (WebCore::DocumentLoader::isClientRedirect): (WebCore::DocumentLoader::setPrimaryLoadComplete): (WebCore::DocumentLoader::isLoadingInAPISense): (WebCore::DocumentLoader::addResponse): (WebCore::DocumentLoader::stopRecordingResponses): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::setLastCheckedRequest): (WebCore::DocumentLoader::lastCheckedRequest): (WebCore::DocumentLoader::triggeringAction): (WebCore::DocumentLoader::setTriggeringAction): (WebCore::DocumentLoader::responses): (WebCore::DocumentLoader::setOverrideEncoding): (WebCore::DocumentLoader::overrideEncoding): (WebCore::DocumentLoader::setTitle): (WebCore::DocumentLoader::urlForHistory):
• loader/DocumentLoader.h:
• loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::committedLoad): (WebCore::FrameLoader::setMainDocumentError): (WebCore::FrameLoader::mainReceivedCompleteError): (WebCore::FrameLoader::mainReceivedError): (WebCore::FrameLoader::cancelledError): (WebCore::FrameLoader::fileDoesNotExistError): (WebCore::FrameLoader::mainResourceData):
• loader/FrameLoader.h:
• loader/FrameLoaderClient.h:
• loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::unreachableURL):
• loader/mac/FrameLoaderMac.mm:

2:18 PM Changeset in webkit [18630] by spadma

• 2 edits in S60/trunk/WebKit

2006-12-20 sareen <​shyam.sareen@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: Change SDK exported files path MACRO for S60 builds.
​http://bugs.webkit.org/show_bug.cgi?id=11895

• group/bld.inf:

2:16 PM Changeset in webkit [18629] by spadma

• 2 edits in S60/trunk/WebKit

2007-01-05 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Sachin Padma.
DESC: xhtml link not opened 2nd time (TSW error id : MSZR-6TGH7D)
​http://bugs.webkit.org/show_bug.cgi?id=12130

• ResourceLoader/CacheSrc/HttpCacheUtil.cpp: (HttpCacheUtil::MergeHeadersLC):

2:13 PM Changeset in webkit [18628] by spadma

• 2 edits in S60/branches/3.1m/WebKit

2007-01-05 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Sachin Padma.
DESC: xhtml link not opened 2nd time (TSW error id : MSZR-6TGH7D)
​http://bugs.webkit.org/show_bug.cgi?id=12130

• ResourceLoader/CacheSrc/HttpCacheUtil.cpp: (HttpCacheUtil::MergeHeadersLC):

1:18 PM Changeset in webkit [18627] by beidson

• 1 edit in trunk/WebCore/ChangeLog

Fixed Eric's name

1:14 PM Changeset in webkit [18626] by beidson

• 2 edits in trunk/WebCore

Reviewed by Eric Siedel

​http://bugs.webkit.org/show_bug.cgi?id=12117
Fixes null deref when opening links from a gmail account

• loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForStandardLoad): Null check m_currentHistoryItem (WebCore::FrameLoader::updateHistoryForClientRedirect): Ditto

1:08 PM Changeset in webkit [22731] by andersca

• 4 edits in branches/WindowsMerge/WebCore

Fix the build.

• WebCore.vcproj/WebCore.vcproj:
• platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::bufferedData): (WebCore::ResourceHandle::supportsBufferedData):
• platform/win/TemporaryLinkStubs.cpp: (WebCore::CheckCacheObjectStatus):

1:00 PM Changeset in webkit [18625] by andersca

• 9 edits in trunk/WebCore

Move some now cross platform functions over to ResourceLoader.cpp in an attempt to fix the non Mac builds.

• loader/CachedResource.h: (WebCore::CachedResource::setAllData):
• loader/ResourceLoader.cpp: (WebCore::ResourceLoader::resourceData):
• loader/ResourceLoader.h:
• loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didFinishLoading):
• loader/mac/LoaderFunctionsMac.mm:
• loader/mac/ResourceLoaderMac.mm:
• platform/SharedBuffer.cpp: (WebCore::SharedBuffer::platformDataSize):
• platform/network/ResourceHandle.h:

12:57 PM Changeset in webkit [18624] by hyatt

• 3 edits in trunk/LayoutTests/fast/block/float

Land updated results for float tests.

12:56 PM Changeset in webkit [18623] by hyatt

• 2 edits in trunk/WebCore

Back out fix for 12114. I missed rule #5 in the float positioning part of the CSS2.1 spec. Keep all
the code cleanup though.

Reviewed by mitz

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionNewFloats):

12:54 PM Changeset in webkit [18622] by spadma

• 2 edits in S60/branches/3.1m/WebKit

2007-01-05 sareen <​shyam.sareen@nokia.com>

Reviewed by Sachin Padma.
DESC: BrowserNG does not open hyperlinks with a space in the anchor.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12127

• ResourceLoader/src/FileTransaction.cpp: (CFileTransaction::ParseFileNameLC):

11:33 AM Changeset in webkit [18621] by andersca

• 24 edits
  3 adds in trunk

WebCore:

Reviewed by Maciej.

Add a shared buffer class which is backed by either a vector or an NSData object. This object can also
be held in a custom NSData subclass. Use this in the loader wherever NSData was used.

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:
• loader/CachedResource.h: (WebCore::CachedResource::allData):
• loader/DocumentLoader.h:
• loader/FrameLoader.h:
• loader/ResourceLoader.h:
• loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didFail):
• loader/loader.cpp: (WebCore::Loader::didFinishLoading):
• loader/loader.h:
• loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::setMainResourceData): (WebCore::DocumentLoader::mainResourceData): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::mainResourceData):
• loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
• loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): (WebCore::CachedResource::setAllData):
• loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::resourceData): (WebCore::ResourceLoader::clearResourceData): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::willStopBufferingData):
• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didFinishLoading):
• page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]): (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
• platform/KURL.h:
• platform/SharedBuffer.cpp: Added. (WebCore::SharedBuffer::SharedBuffer): (WebCore::SharedBuffer::size): (WebCore::SharedBuffer::data): (WebCore::SharedBuffer::append): (WebCore::SharedBuffer::clear): (WebCore::SharedBuffer::clearPlatformData): (WebCore::SharedBuffer::maybeTransferPlatformData): (WebCore::SharedBuffer::hasPlatformData): (WebCore::SharedBuffer::platformData):
• platform/SharedBuffer.h: Added.
• platform/mac/SharedBufferMac.mm: Added. (-[SharedBufferData dealloc]): (-[SharedBufferData finalize]): (-[SharedBufferData initWithSharedBuffer:WebCore::]): (-[SharedBufferData length]): (-[SharedBufferData bytes]): (WebCore::SharedBuffer::wrapNSData): (WebCore::SharedBuffer::SharedBuffer): (WebCore::SharedBuffer::createNSData): (WebCore::SharedBuffer::hasPlatformData): (WebCore::SharedBuffer::platformData): (WebCore::SharedBuffer::platformDataSize): (WebCore::SharedBuffer::maybeTransferPlatformData): (WebCore::SharedBuffer::clearPlatformData):
• platform/network/ResourceHandle.h:
• platform/network/ResourceHandleClient.h:
• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::bufferedData):

WebKit:

Reviewed by Maciej.

The data returned is now a SharedBuffer so wrap it in an NSData object.

• WebView/WebDataSource.mm: (-[WebDataSource data]):

11:26 AM Changeset in webkit [18620] by ap

• 2 edits in trunk/LayoutTests

Reviewed by Darin.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=3420
XMLHttpRequest does not handle set-cookie headers

• http/tests/xmlhttprequest/resources/get-set-cookie.cgi: Set the cookies unconditionally (previously, the test failed if there were other cookies for 127.0.0.1:8000.

11:02 AM Changeset in webkit [18619] by andersca

• 3 edits in trunk/WebCore

Reviewed by Adam.

​http://bugs.webkit.org/show_bug.cgi?id=12120
REGRESSION(r18605): Safari snippet editor no longer works

• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest): Put back the code change in r18607.

• platform/mac/KURLMac.mm: (WebCore::KURL::KURL): Convert nil NSURLs to null KURLs.

8:15 AM Changeset in webkit [18618] by ap

• 6 edits in trunk

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=7296
Disable JavaScript exceptions when dynamically changing CSS properties.

• bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put): Removed the Dashboard quirk logic.

• css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setProperty): Don't raise an exception if parsing fails.

5:24 AM Changeset in webkit [18617] by zack

• 2 edits in trunk/WebKitTools

be smarter when detecting the display (hopefully fixes
running the layout tests with the buildbot)

1:00 AM Changeset in webkit [18616] by antti

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by hyatt.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=12109
layer visibility incorrect in some cases

• fast/layers/layer-visibility-sublayer-expected.checksum: Added.
• fast/layers/layer-visibility-sublayer-expected.png: Added.
• fast/layers/layer-visibility-sublayer-expected.txt: Added.
• fast/layers/layer-visibility-sublayer.html: Added.

WebCore:

Reviewed by hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=12109

Fix layer visibility in some cases with nested layers.

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateVisibilityStatus):

12:43 AM Changeset in webkit [18615] by lars

• 7 edits in trunk

the daily checkin to get the Qt build compiling again :)

Jan 4, 2007:

11:44 PM Changeset in webkit [18614] by aroben

• 7 edits in trunk

WebCore:

Reviewed by Geoff, cheered by others.

Dead code elimination.

All layout tests pass.

• page/EventHandler.h:
• page/mac/EventHandlerMac.mm:
• page/mac/WebCoreFrameBridge.h:
• page/mac/WebCoreFrameBridge.mm:

WebKit:

Reviewed by Geoff, cheered by others.

Dead code elimination.

• WebView/WebHTMLView.m:

11:26 PM Changeset in webkit [18613] by aroben

• 2 edits in trunk/WebKit

Boo on me for undoing Beth's hard work.

• WebView/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): Undo a mistaken roll out of r18597.

11:21 PM Changeset in webkit [18612] by ddkilzer

• 2 edits in trunk/WebKit

WebKit:

Reviewed by Brady.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12111 Uninitialized variable in -[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]

• DefaultDelegates/WebDefaultPolicyDelegate.m: Initialize isDirectory.

10:36 PM Changeset in webkit [18611] by ddkilzer

• 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Mark Rowe.

Speed up svn-create-patch for copied and moved files.

• Scripts/svn-create-patch: (manufacturePatchForAdditionWithHistory($$)): Use 'svn cat' instead of 'svn cat -rNNNNN' so svn pulls original from local disk.

10:28 PM Changeset in webkit [22730] by aroben

• 5 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Geoff.

Fix: <rdar://4763580> Support tabbing between subframes
Fix: <rdar://4763595> Support tabbing out of the document back into the
Safari UI

• Interfaces/IWebUIDelegate.idl: Added declarations of new methods.
• WebBackForwardList.cpp: (WebBackForwardList::backItem): Changed to return E_FAIL if returning a null pointer. (WebBackForwardList::currentItem): Ditto. (WebBackForwardList::forwardItem): Ditto.
• WebChromeClient.cpp: (WebChromeClient::canTakeFocus): Added new click method. (WebChromeClient::takeFocus): Ditto. (WebChromeClient::focus): Removed unnecessary null check. (WebChromeClient::unfocus): Ditto. (WebChromeClient::createWindow): Ditto. (WebChromeClient::createModalDialog): Ditto. (WebChromeClient::show): Ditto. (WebChromeClient::canRunModal): Ditto. (WebChromeClient::runModal): Ditto. (WebChromeClient::setToolbarsVisible): Ditto. (WebChromeClient::toolbarsVisible): Ditto. (WebChromeClient::setStatusbarVisible): Ditto. (WebChromeClient::statusbarVisible): Ditto. (WebChromeClient::setMenubarVisible): Ditto. (WebChromeClient::menubarVisible): Ditto. (WebChromeClient::setResizable): Ditto. (WebChromeClient::addMessageToConsole): Ditto.
• WebChromeClient.h: Added declarations.

10:18 PM Changeset in webkit [18610] by aroben

• 36 edits
  14 adds in trunk

LayoutTests:

Reviewed by Geoff.

Added new tests for tabindex and tabbing into/out of subframes.

• fast/dom/tabindex-clamp-expected.txt: Added.
• fast/dom/tabindex-clamp.html: Added.
• fast/events/frame-click-focus-expected.txt: Added.
• fast/events/frame-click-focus.html: Added.
• fast/events/frame-tab-focus-expected.txt: Added.
• fast/events/frame-tab-focus.html: Added.
• fast/events/resources/frame-tab-focus-child.html: Added.
• fast/events/resources/frame-tab-focus-empty-child.html: Added.
• fast/events/resources/frame-tab-focus-empty-middle.html: Added.
• fast/events/resources/frame-tab-focus-middle.html: Added.
• fast/events/resources/frame-tab-focus-upper.html: Added.
• fast/html/tab-order-expected.txt: Added.
• fast/html/tab-order.html: Added.

Updated test to match new behavior.

• fast/forms/focus2-expected.txt: Updated results.
• fast/forms/focus2.html: Fixed typo, and reduced the number of tab events dispatched now that frames containing focusable elements aren't themselves in the tab order.

WebCore:

Reviewed by Geoff.

Fix: <rdar://4800335> REGRESSION: shift-tabbing from location field
goes to first field rather than last (businessweek.com)

Fix: <rdar://4800373> REGRESSION: tabbing from last control focuses
nothing visible (busniessweek.com)

Handle tabbing into/out of subframes in WebCore instead of letting
AppKit do the dirty work. This change also fixes a number of bugs and
changes some behavior to match other browsers:

• No frames receive a focus event when the page is first loaded.
• When a frame is clicked or focused with the keyboard, it receives a focus event and all other frames receive a blur event.
• tabindex values are clamped to the range of a signed short, rather than overflowing within an unsigned short.
• tabindex is respected on frame owner elements, even though HTML4 says it shouldn't be.
• Subframes will be focused when tabbing if they don't contain any focusable elements within them (it would be nice to only focus the frame if it has scrollbars).

Renamed SelectionDirection to FocusDirection and put it in its own file.

• page/FocusDirection.h: Added. (WebCore::):
• page/mac/WebCoreFrameBridge.mm: Updated for renames. (-[WebCoreFrameBridge nextKeyView]): (-[WebCoreFrameBridge previousKeyView]): (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]):

Moved advanceFocus from EventHandler to FocusController and added
support for moving into/out of subframes..

• page/EventHandler.cpp: Moved advanceFocus to FocusController.
• page/EventHandler.h: Ditto.
• page/FocusController.cpp: (WebCore::deepFocusableNode): Static helper function to find focusable nodes nested within frames. (WebCore::FocusController::advanceFocus): Moved from EventHandler and rewritten to handle subframes.
• page/FocusController.h: Added advanceFocus declaration.
• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Updated for the move of advanceFocus to FocusController.
• html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::isFrameOwnerElement): New method. (WebCore::HTMLFrameOwnerElement::isKeyboardFocusable): New virtual implementation used to trick Document::nextFocusableNode so that we can focus frames.

Rewrote/renamed
Document::nextFocusableNode/Document::previousFocusableNode.

• dom/Document.cpp: (WebCore::nextNodeWithExactTabIndex): New static helper function. (WebCore::previousNodeWithExactTabIndex): Ditto. (WebCore::nextNodeWithGreaterTabIndex): Ditto. (WebCore::previousNodeWithLowerTabIndex): Ditto. (WebCore::Document::nextFocusableNode): Renamed from nextFocusedNode, and rewritten with much simpler logic. (WebCore::Document::previousFocusableNode): Ditto.
• dom/Document.h: Updated declarations for renames.
• page/mac/EventHandlerMac.mm: Updated for rename of SelectionDirection to FocusDirection. (WebCore::EventHandler::nextKeyViewInFrame): Updated for renames. (WebCore::EventHandler::nextKeyViewInFrameHierarchy): Ditto. (WebCore::EventHandler::nextKeyView): Ditto. (WebCore::EventHandler::focusDocumentView): Added call to setFocusedFrame when focusing the document view. (WebCore::EventHandler::passMouseDownEventToWidget): Removed LOG_ERROR when a nil NSView is returned from AppKit, as this is a fairly common occurrence when a RenderWidget has a border. (WebCore::EventHandler::passWheelEventToWidget): Added a nil-check of the hit-tested NSView.

Changed storage of tabIndex to a signed short, and added clamping of
tabindex attribute values to match Firefox's behavior.

• dom/Node.h: Use a signed short to store m_tabIndex. (WebCore::Node::isFrameOwnerElement): New method. (WebCore::Node::tabIndex): Updated for signedness. (WebCore::Node::setTabIndex): Ditto.
• html/HTMLAnchorElement.cpp: Remove implementation of tabIndex() so that Node::tabIndex() will be called instead and return the clamped value (which matches Firefox's behavior).
• html/HTMLAnchorElement.h: Ditto.
• html/HTMLAreaElement.cpp: Ditto.
• html/HTMLAreaElement.h: Ditto.
• html/HTMLGenericFormElement.cpp: Ditto.
• html/HTMLGenericFormElement.h: Ditto.
• html/HTMLObjectElement.cpp: Ditto.
• html/HTMLObjectElement.h: Ditto.
• html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute): Clamp tabIndex to the range of a signed short to match Firefox.

Added two new Chrome methods for transferring focus out of the
WebView.

• page/Chrome.cpp: (WebCore::Chrome::canTakeFocus): (WebCore::Chrome::takeFocus):
• page/Chrome.h:
• page/ChromeClient.h:
• platform/graphics/svg/SVGImageEmptyClients.h: Fixed typo "CromeClient" -> "ChromeClient". (WebCore::SVGEmptyChromeClient::~SVGEmptyChromeClient): (WebCore::SVGEmptyChromeClient::canTakeFocus): (WebCore::SVGEmptyChromeClient::takeFocus):
• platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::setData): Fixed typo.

Miscellaneous:

• WebCore.exp: Updated/sorted symbols.
• WebCore.xcodeproj/project.pbxproj: Made FocusController.h Private so WebKit can access it.

WebKit:

Reviewed by Geoff.

Remove WebKit/AppKit from handling tabbing between subframes.

• WebCoreSupport/WebChromeClient.h: Added new ChromeClient methods for moving focus out of the WebView.
• WebCoreSupport/WebChromeClient.mm: Ditto. (WebChromeClient::canTakeFocus): (WebChromeClient::takeFocus):
• WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge webView]): Added null-check of m_frame.
• WebView/WebHTMLView.m: Removed -[WebHTMLView nextValidKeyView]. (-[WebHTMLView _updateActiveState]): Changed to focus the frame if WebCore believes it to be the focused frame. (-[WebHTMLView becomeFirstResponder]): Rewrote to call into FocusController to place focus correctly within the WebView.

9:58 PM Changeset in webkit [18609] by beidson

• 2 edits in trunk/WebCore

Reverted Anders' change to fix the world

• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse):

9:56 PM Changeset in webkit [18608] by ddkilzer

• 14 edits in trunk/WebCore

WebCore:

Reviewed by Sam Weinig.

• ​http://bugs.webkit.org/show_bug.cgi?id=12078 Clean up RenderTable*

• Coding style cleanup.
• Canceled AutoTableLayout and FixedTableLayout being friend classes of RenderTable. Instead, added public accessors to RenderTable for what the table layout classes need and changed TableLayout::calcMinMaxWidth() to take references to the caller's min and max widths.
• Made RenderTableSection's grid protected and moved code that accessed it from RenderTable into RenderTableSection.

No test possible (no change to functionality).

• rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::layout):
• rendering/AutoTableLayout.h:
• rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::calcMinMaxWidth): (WebCore::FixedTableLayout::layout):
• rendering/FixedTableLayout.h:
• rendering/RenderTable.cpp: (WebCore::RenderTable::RenderTable): (WebCore::RenderTable::~RenderTable): (WebCore::RenderTable::setStyle): (WebCore::RenderTable::addChild): (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout): (WebCore::RenderTable::setCellWidths): (WebCore::RenderTable::paint): (WebCore::RenderTable::paintBoxDecorations): (WebCore::RenderTable::calcMinMaxWidth): (WebCore::RenderTable::splitColumn): Factored out the section work to RenderTableSection::splitColumn(). (WebCore::RenderTable::appendColumn): Factored out the section work to RenderTableSection::appendColumn(). (WebCore::RenderTable::colElement): (WebCore::RenderTable::recalcSections): (WebCore::RenderTable::removeChildNode): (WebCore::RenderTable::calcBorderLeft): (WebCore::RenderTable::calcBorderRight): (WebCore::RenderTable::outerBorderTop): (WebCore::RenderTable::outerBorderBottom): (WebCore::RenderTable::outerBorderLeft): (WebCore::RenderTable::outerBorderRight): (WebCore::RenderTable::sectionAbove): (WebCore::RenderTable::sectionBelow): (WebCore::RenderTable::cellAbove): (WebCore::RenderTable::cellBelow): (WebCore::RenderTable::cellBefore): (WebCore::RenderTable::getOverflowClipRect): (WebCore::RenderTable::dump):
• rendering/RenderTable.h: (WebCore::RenderTable::getColumnPos): (WebCore::RenderTable::hBorderSpacing): (WebCore::RenderTable::vBorderSpacing): (WebCore::RenderTable::getRules): (WebCore::RenderTable::cellPadding): (WebCore::RenderTable::setCellPadding): (WebCore::RenderTable::ColumnStruct::ColumnStruct): (WebCore::RenderTable::columns): Added this accessor. (WebCore::RenderTable::columnPositions): Added this accessor. (WebCore::RenderTable::header): (WebCore::RenderTable::footer): (WebCore::RenderTable::firstBody): (WebCore::RenderTable::numEffCols): (WebCore::RenderTable::spanOfEffCol): (WebCore::RenderTable::colToEffCol): (WebCore::RenderTable::effColToCol): (WebCore::RenderTable::bordersPaddingAndSpacing): (WebCore::RenderTable::needsSectionRecalc): (WebCore::RenderTable::setNeedsSectionRecalc): Renamed setNeedSectionRecalc() to this. (WebCore::RenderTable::hasSections): (WebCore::RenderTable::recalcSectionsIfNeeded):
• rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::RenderTableCell): (WebCore::RenderTableCell::destroy): (WebCore::RenderTableCell::updateFromElement): (WebCore::RenderTableCell::styleOrColWidth): (WebCore::RenderTableCell::computeAbsoluteRepaintRect): (WebCore::RenderTableCell::absolutePosition): (WebCore::RenderTableCell::baselinePosition): (WebCore::RenderTableCell::setStyle): (WebCore::compareBorders): (WebCore::RenderTableCell::collapsedTopBorder): (WebCore::RenderTableCell::paint): (WebCore::collapsedBorderStyle): (WebCore::CollapsedBorder::CollapsedBorder): (WebCore::CollapsedBorders::CollapsedBorders): (WebCore::CollapsedBorders::addBorder): (WebCore::CollapsedBorders::nextBorder): (WebCore::RenderTableCell::paintCollapsedBorder): (WebCore::RenderTableCell::paintBackgroundsBehindCell): (WebCore::RenderTableCell::paintBoxDecorations): (WebCore::RenderTableCell::dump):
• rendering/RenderTableCell.h: (WebCore::RenderTableCell::colSpan): (WebCore::RenderTableCell::setColSpan): (WebCore::RenderTableCell::rowSpan): (WebCore::RenderTableCell::setRowSpan): (WebCore::RenderTableCell::col): (WebCore::RenderTableCell::setCol): (WebCore::RenderTableCell::row): (WebCore::RenderTableCell::setRow): (WebCore::RenderTableCell::section): (WebCore::RenderTableCell::table): (WebCore::RenderTableCell::yPos): (WebCore::RenderTableCell::setCellTopExtra): (WebCore::RenderTableCell::setCellBottomExtra): (WebCore::RenderTableCell::borderTopExtra): (WebCore::RenderTableCell::borderBottomExtra):
• rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::destroy): (WebCore::RenderTableRow::setStyle): (WebCore::RenderTableRow::addChild): (WebCore::RenderTableRow::layout): (WebCore::RenderTableRow::getAbsoluteRepaintRect): (WebCore::RenderTableRow::paint):
• rendering/RenderTableRow.h: (WebCore::RenderTableRow::section): (WebCore::RenderTableRow::table): (WebCore::RenderTableRow::lineHeight):
• rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): (WebCore::RenderTableSection::destroy): (WebCore::RenderTableSection::setStyle): (WebCore::RenderTableSection::addChild): (WebCore::RenderTableSection::ensureRows): (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::setCellWidths): (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::lowestPosition): (WebCore::RenderTableSection::rightmostPosition): (WebCore::RenderTableSection::leftmostPosition): (WebCore::RenderTableSection::calcOuterBorderTop): (WebCore::RenderTableSection::calcOuterBorderBottom): (WebCore::RenderTableSection::calcOuterBorderLeft): (WebCore::RenderTableSection::calcOuterBorderRight): (WebCore::RenderTableSection::paint): (WebCore::RenderTableSection::recalcCells): (WebCore::RenderTableSection::clearGrid): (WebCore::RenderTableSection::numColumns): (WebCore::RenderTableSection::appendColumn): Added. Moved code from RenderTable::appendColumn() into here. (WebCore::RenderTableSection::splitColumn): Added. Moved code from RenderTable::splitColumn() into here. (WebCore::RenderTableSection::removeChildNode): (WebCore::RenderTableSection::dump):
• rendering/RenderTableSection.h: (WebCore::RenderTableSection::renderName): (WebCore::RenderTableSection::isTableSection): (WebCore::RenderTableSection::lineHeight): (WebCore::RenderTableSection::table): (WebCore::RenderTableSection::cellAt): (WebCore::RenderTableSection::numRows): (WebCore::RenderTableSection::recalcCellsIfNeeded): (WebCore::RenderTableSection::needsCellRecalc): (WebCore::RenderTableSection::setNeedsCellRecalc): (WebCore::RenderTableSection::getBaseline):
• rendering/TableLayout.h:

9:14 PM Changeset in webkit [18607] by andersca

• 2 edits in trunk/WebCore

Reviewed by Adam.

​http://bugs.webkit.org/show_bug.cgi?id=12120
REGRESSION(r18605): Safari snippet editor no longer works

• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest): Fix logic so applewebdata: URLs no longer cause the underlying URL to be fetched .

7:34 PM Changeset in webkit [18606] by andersca

• 10 edits in trunk/WebCore

Reviewed by Adam.

Move all remaining instances of NSURLRequest over to ResourceRequest (well, pretty much all).

• loader/MainResourceLoader.h:
• loader/ResourceLoader.h:
• loader/SubresourceLoader.h:
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::startLoadingMainResource):
• loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::load): (WebCore::MainResourceLoader::setDefersLoading):
• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::load):
• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::load): (WebCore::SubresourceLoader::create):
• platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::setData):
• platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):

6:46 PM Changeset in webkit [22729] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

6:40 PM Changeset in webkit [18605] by andersca

• 17 edits in trunk

WebCore:

Reviewed by Brady.

Move more NSURLRequests over to ResourceRequests.

• loader/DocumentLoader.h:
• loader/FrameLoader.h:
• loader/FrameLoaderClient.h:
• loader/MainResourceLoader.h:
• loader/ResourceLoader.h: (WebCore::ResourceLoader::request):
• loader/SubresourceLoader.h:
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::loadedResourceFromMemoryCache): (WebCore::FrameLoader::loadResourceSynchronously):
• loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::setDefersLoading):
• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::cancelledError):
• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::willSendRequest):
• platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
• platform/network/ResourceRequest.cpp: (WebCore::ResourceRequest::isNull):
• platform/network/ResourceRequest.h:

WebKit:

Reviewed by Brady.

FrameLoaderClient changed yet again.

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::dispatchWillSendRequest):

6:38 PM Changeset in webkit [18604] by sfalken

• 1 copy in tags/Safari-521.32.9b

New tag.

6:20 PM Changeset in webkit [18603] by beidson

• 2 edits in trunk/WebCore

Reviewed by Mark Rowe

​http://bugs.webkit.org/show_bug.cgi?id=12119
Changing the behavior of HistoryItem::pageCache() this morning also necessitated
changing the behavior of HistoryItem::hasPageCache()

• history/HistoryItem.cpp: (WebCore::HistoryItem::hasPageCache): Add the same pendingRelease check pageCache() has

4:36 PM Changeset in webkit [18602] by bdash

• 4 edits
  4 adds in trunk

2007-01-04 Mitz Pettel <​mitz@webkit.org>

Reviewed by Sam Weinig.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12043 Another assertion failure in WebCore::RenderObject::drawBorder

Test: fast/borders/border-radius-huge-assert.html

• platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::addRoundedRectClip): Fixed the check for border radii that do not fit in the given width or height to work with radii that sum up to more than MAX_INT.
• rendering/RenderObject.cpp: (WebCore::RenderObject::paintBorder): Ditto.

2007-01-04 Mitz Pettel <​mitz@webkit.org>

Reviewed by Sam Weinig.

• pixel test for ​http://bugs.webkit.org/show_bug.cgi?id=12043 Another assertion failure in WebCore::RenderObject::drawBorder

• fast/borders/border-radius-huge-assert-expected.checksum: Added.
• fast/borders/border-radius-huge-assert-expected.png: Added.
• fast/borders/border-radius-huge-assert-expected.txt: Added.
• fast/borders/border-radius-huge-assert.html: Added.

4:35 PM Changeset in webkit [18601] by justing

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4861080>
GMail Editor: Crash when dropping content into certain list items

• editing/pasteboard/4861080-expected.checksum: Added.
• editing/pasteboard/4861080-expected.png: Added.
• editing/pasteboard/4861080-expected.txt: Added.
• editing/pasteboard/4861080.html: Added.

WebCore:

Reviewed by john

<rdar://problem/4861080>
GMail Editor: Crash when dropping content into certain list items

A rendering bug (4907469) creates unwanted space at the top of a
list item when its contents are wrapped in span. Dropping content
inside that space causes a crash because positionForCoordinates
fails there and the code that creates drag carets can't handle it.

• page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge _visiblePositionForPoint:]): Added the that's inside click handling for the case where positionForCoordinates returns null. We should also fix positionForCoordinates but that's less important: now its only side effect is that a no-op drop is performed instead of a snap back when you drop the contents of one of these list items its own unwanted space.

4:14 PM Changeset in webkit [18600] by bdakin

• 2 edits in trunk/WebCore

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12118 REGRESSION
(Context menus): No context menu displayed when clicking outside a
short document

No test case added since we do not currently have a way to automate
context menus.

• page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent): If the hit test does not find a node, use the document node.

4:04 PM Changeset in webkit [18599] by hyatt

• 1 edit in trunk/LayoutTests/fast/table/absolute-table-at-bottom-expected.txt

Fix table test for bold change. No idea why this changed by a pixel though.

3:59 PM Changeset in webkit [18598] by andersca

• 10 edits in trunk

WebCore:

Reviewed by Adam.

Convert NSURLRequest to ResourceRequest in a few places

• loader/FrameLoader.h:
• loader/FrameLoaderClient.h:
• loader/MainResourceLoader.h:
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::identifierForInitialRequest): (WebCore::FrameLoader::willUseArchive):
• loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
• platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::download): (WebCore::SVGEmptyFrameLoaderClient::willUseArchive):

WebKit:

Reviewed by Adam.

FrameLoaderClient changed again.

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::download): (WebFrameLoaderClient::willUseArchive):

3:22 PM Changeset in webkit [18597] by bdakin

• 2 edits in trunk/WebKit

Reviewed by Adam.

No need to hit test twice.

• WebView/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):

3:13 PM Changeset in webkit [18596] by zbujtas

• 2 edits in S60/branches/3.1m/WebCore

2007-01-04 sareen <​shyam.sareen@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Submit button can not be pressed after unsuccessful login to gmail.com
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12113

WARNING: NO TEST CASES ADDED OR CHANGED

• kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::activateNodeAtPoint):

2:58 PM Changeset in webkit [18595] by hyatt

• 4 adds in trunk/LayoutTests/fast/block/float

New layout test for bug 12114.

2:58 PM Changeset in webkit [18594] by hyatt

• 2 edits in trunk/WebCore

Bug 12114 fix, make sure left/right floats are allowed to go above
other floats of opposite alignment.

Reviewed by aroben

fast/block/float/independent-align-positioning.html

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionNewFloats):

2:56 PM Changeset in webkit [18593] by andersca

• 2 edits in trunk/WebCore

Reviewed by Brady.

​http://bugs.webkit.org/show_bug.cgi?id=12116
REGRESSION: ASSERTION FAILED: URL in +[WebDataProtocol _webIsDataProtocolURL:]

<rdar://problem/4908910>
REGRESSION: After switching to Bookmarks view, the browser window is completely empty (no bookmarks are displayed)

• platform/network/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): Initialize m_isNull

1:57 PM Changeset in webkit [22728] by bdakin

• 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

A few changes needed to turn on WebCore context menus on the Mac.

• WebContextMenuClient.cpp: Name change and have the former getCustomMenuFromDefaultItems function return the PlatformMenuDescription since it feels funny to have the client set the new platform description. (WebContextMenuClient::getCustomMenuFromDefaultItems): Same.
• WebContextMenuClient.h: Same.

1:47 PM Changeset in webkit [18592] by bdakin

• 13 edits in trunk

WebCore:

Reviewed by Adam.

Turn on WebCore context menus.

• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Turn on WebCore menus.
• page/ContextMenuClient.h: Name change and have the former getCustomMenuFromDefaultItems function return the PlatformMenuDescription since it feels funny to have the client set the new platform description.
• page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent): Above name change. (WebCore::ContextMenuController::contextMenuItemSelected): Use local variable.
• platform/ContextMenu.cpp: (WebCore::createAndAppendSpeechSubMenu): Fix silly mistake -- make "Stop speaking" actually stop speaking.
• platform/graphics/svg/SVGImageEmptyClients.h: Name change and have the former getCustomMenuFromDefaultItems function return the PlatformMenuDescription since it feels funny to have the client set the new platform description.

(WebCore::SVGEmptyContextMenuClient::getCustomMenuFromDefaultItems):

WebKit:

Reviewed by Adam.

Turn on WebCore context menus. Delete a bunch of WebKit context
menu code that is no longer needed.

• DefaultDelegates/WebDefaultContextMenuDelegate.m: Removed a lot of code from this class. This class only still needs to exist for PDF context menus, so we only need to deal with the menu items that might possibly be added to a PDF context menu. (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): Same. (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Same.
• WebCoreSupport/WebContextMenuClient.h: Name change and have the former getCustomMenuFromDefaultItems function return the PlatformMenuDescription since it feels funny to have the client set the new platform description.
• WebCoreSupport/WebContextMenuClient.mm: Same. (WebContextMenuClient::getCustomMenuFromDefaultItems): Same. Also move in some code that used to be in _menuForElement.
• WebView/WebHTMLView.m: Deleted a bunch of un-used functions (-[WebHTMLView menuForEvent:]): Turn on menus, and append the Inspect Element item.
• WebView/WebHTMLViewPrivate.h: Deleted a bunch of un-used functions.
• WebView/WebView.mm: (-[WebView _menuForElement:defaultItems:]): Removed a lot of code from _menuForElement that now makes more sense elsewhere. Only PDF context menus use this function now. Hopefully we can just get rid of it soon, too.

1:27 PM Changeset in webkit [18591] by yongjzha

• 2 edits in S60/trunk/WebKit

2007-01-02 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Sachin Padma.
DESC: Clicking links does not work after browser looses focus (TMCN-6UVJRL)
​http://bugs.webkit.org/show_bug.cgi?id=11983

• BrowserView/src/WebKitControl.cpp: (CWebKitControl::SyncCancelL): (CWebKitControl::FinalProgressComplete):

1:03 PM Changeset in webkit [18590] by hyatt

• 3 edits in trunk/LayoutTests/svg/W3C-SVG-1.1

Update for synthetic bold change.

1:02 PM Changeset in webkit [18589] by yongjzha

• 2 edits in S60/branches/3.1m/WebKit

2007-01-04 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Clicking links does not work after browser looses focus (TMCN-6UVJRL)
​http://bugs.webkit.org/show_bug.cgi?id=11983

• BrowserView/src/WebKitControl.cpp: (CWebKitControl::SyncCancelL): (CWebKitControl::FinalProgressComplete):

12:59 PM Changeset in webkit [22727] by hyatt

• 2 edits in branches/WindowsMerge/WebCore

Always use 1.0 as the synthetic bold offset for now. Fixes bug 9534.

Reviewed by olliej

• platform/win/FontDataWin.cpp: (WebCore::FontData::platformInit):

12:52 PM Changeset in webkit [18588] by beidson

• 5 edits in trunk/WebCore

Reviewed and landed by Brady

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12087 REGRESSION: Reproducible crash going back in Back/Forward history

Allow a PageCache that is pending release to be resurrected by its
HistoryItem instead of creating a new PageCache. This avoids the
the condition of having two PageCaches for the same HistoryItem, one
current and one pending release but not yet released, which was causing
this and other bugs before.

Replaced the vector of PageCaches pending release with a set of
HistoryItems that are pending release of their PageCache.

• history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::setHasPageCache): Check for an existing PageCache pending release, and if found, resurrect it by canceling the release. (WebCore::HistoryItem::pageCache): Return 0 if the PageCache is pending release. (WebCore::itemsWithPendingPageCacheToRelease): Renamed pendingPageCacheToRelease to this. This method now returns a HashSet of HistoryItems that have scheduled their PageCaches for release. (WebCore::HistoryItem::releasePageCachesOrReschedule): Renamed releasePageCache to this. (WebCore::HistoryItem::releasePageCache): Added. Actually closes and releases the PageCache. (WebCore::HistoryItem::releaseAllPendingPageCaches): Rolled closeObjectsInPendingPageCaches into this method. (WebCore::HistoryItem::scheduleRelease): (WebCore::HistoryItem::cancelRelease): Added.
• history/HistoryItem.h: Removed unused declaration of scheduleReleaseTimer()
• history/HistoryItemTimer.cpp: (WebCore::HistoryItemTimer::HistoryItemTimer): (WebCore::HistoryItemTimer::callReleasePageCachesOrReschedule):
• history/HistoryItemTimer.h:

12:50 PM Changeset in webkit [18587] by hyatt

• 2 edits in trunk/WebCore

Just make the synthetic bold offset always be 1.0. This fixes bug
9534, synthetic bold looks doubled.

Reviewed by olliej

• platform/mac/FontDataMac.mm: (WebCore::FontData::platformInit):

11:25 AM Changeset in webkit [18586] by andersca

• 26 edits in trunk

WebCore:

Reviewed by Brady.

Convert almost all occurrences of NSURLResponse to ResourceResponse.

• WebCore.exp:
• loader/DocumentLoader.h:
• loader/FrameLoader.h:
• loader/FrameLoaderClient.h:
• loader/MainResourceLoader.h:
• loader/NetscapePlugInStreamLoader.h:
• loader/ResourceLoader.h:
• loader/SubresourceLoader.h:
• loader/loader.h:
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::loadedResourceFromMemoryCache): (WebCore::FrameLoader::loadResourceSynchronously):
• loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus):
• loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::isPostOrRedirectAfterPost): (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::loadNow):
• loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
• loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::response):
• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse):
• platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::download): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebCore::SVGEmptyFrameLoaderClient::incrementProgress):
• platform/network/ResourceHandle.h:
• platform/network/ResourceHandleClient.h:
• platform/network/ResourceResponse.cpp: (WebCore::ResourceResponse::isHTTP):
• platform/network/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::isNull):
• platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::nsURLResponse): (WebCore::ResourceResponse::doUpdateResourceResponse):

WebKit:

Reviewed by Brady.

Update for WebCore changes.

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::download): (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::incrementProgress):

11:21 AM Changeset in webkit [18585] by adele

• 5 edits
  4 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/4887422>
​http://bugs.webkit.org/show_bug.cgi?id=11848
REGRESSION (SearchField): Search field on developer.apple.com not drawn with top/bottom borders (11848)

• fast/forms/searchfield-heights-expected.checksum: Added.
• fast/forms/searchfield-heights-expected.png: Added.
• fast/forms/searchfield-heights-expected.txt: Added.
• fast/forms/searchfield-heights.html: Added.

WebCore:

Reviewed by Darin.

• Fix for <rdar://problem/4887422> ​http://bugs.webkit.org/show_bug.cgi?id=11848 REGRESSION (SearchField): Search field on developer.apple.com not drawn with top/bottom borders (11848)

Test: fast/forms/searchfield-heights.html

Override the border and the height for search fields that use -webkit-appearance: searchfield.

• css/html4.css: Use box-sizing: border-box for search fields. We don't need to have the border-box quirk that we use for the other text fields for this control.
• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::searchFieldSizes): Added. (WebCore::RenderThemeMac::setSearchFieldSize): Added. (WebCore::RenderThemeMac::adjustSearchFieldStyle): Override the border and the height of the search field.

10:58 AM Changeset in webkit [18584] by kmccullo

• 2 edits in trunk/JavaScriptCore

Reviewed by Kevin McCullough.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12070 REGRESSION: KJS::getUTCOffset() caches UTC offset but ignores time zone changes

• kjs/DateMath.cpp: (KJS::getUTCOffset): Don't cache UTC offset.

10:42 AM Changeset in webkit [18583] by yongjzha

• 4 edits in S60/branches/3.1m/WebKit

2007-01-03 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang.
DESC: TSW Id: PNIO-6TF99Y: "system error" is displayed for http status code 301
​http://bugs.webkit.org/show_bug.cgi?id=11787

• BrowserView/inc/HttpLoaderEventToUiListener.h:
• BrowserView/src/HttpLoaderEventToUiListener.cpp: (CHttpLoaderEventToUiListener::ReportHttpError):
• BrowserView/src/LoadListeners.cpp: (CPageLoadListener::Complete):

10:31 AM Changeset in webkit [18582] by yongjzha

• 2 edits in S60/trunk/WebKit

2007-01-03 vbradley <​vincent.bradley@nokia.com>

Reviewed by Yongjun Zhang.
DESC: fix for aol.co.uk crash (3.2)
​http://bugs.webkit.org/show_bug.cgi?id=12102

• BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::TileInRect):

6:09 AM Changeset in webkit [18581] by lars

• 2 edits in trunk/WebKitTools

compile DumpRenderTree with RPATH. Hopefully this will
fix the automatic regression tests.

6:08 AM Changeset in webkit [18580] by lars

• 2 edits in trunk/WebCore

Add some missing stubs

4:49 AM Changeset in webkit [18579] by ap

• 19 edits in trunk

2007-01-04 Don Gibson <​dgibson77@gmail.com>

Reviewed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=11900:
Windows build bustage

WebCore:

• WebCore.vcproj/WebCore/WebCore.vcproj:
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
• platform/graphics/BitmapImage.h:
• platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setPlatformStrokeColor):
• platform/graphics/Image.h:
• platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::adjustLineToPixelBoundaries): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon):
• platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::checkForSolidColor): (WebCore::BitmapImage::draw): (WebCore::BitmapImage::drawTiled):
• platform/graphics/win/ImageWin.cpp: (WebCore::BitmapImage::initPlatformData): (WebCore::BitmapImage::invalidatePlatformData): (WebCore::Image::loadPlatformResource):
• platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs):
• platform/win/TemporaryLinkStubs.cpp: (WebCore::userIdleTime): (WebCore::BitmapImage::drawTiled): (WebCore::BitmapImage::getHBITMAP): (WebCore::ContextMenu::~ContextMenu): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::setType): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setSubMenu): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::setEnabled): (WebCore::DocumentLoader::originalRequest): (WebCore::DocumentLoader::request): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::getResponseRefreshAndModifiedHeaders): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::setCommitted): (WebCore::DocumentLoader::isLoading): (WebCore::DocumentLoader::prepareForLoadStart): (WebCore::DocumentLoader::isClientRedirect): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::urlForHistory): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::FrameLoader::load): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::dataURLBaseFromRequest): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::applyUserAgent): (WebCore::GraphicsContext::strokeRect): (WebCore::IconDatabase::iconForPageURL): (WebCore::IconDatabase::defaultIcon): (WebCore::IconDatabase::retainIconForPageURL): (WebCore::IconDatabase::releaseIconForPageURL): (WebCore::PageCache::close): (WebCore::ResourceHandle::willLoadFromCache): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches): (WebCore::SearchPopupMenu::SearchPopupMenu):

WebKit:

• COM/ChromeClientWin.cpp: (ChromeClientWin::addMessageToConsole): (ChromeClientWin::runBeforeUnloadConfirmPanel):
• COM/ChromeClientWin.h:
• COM/ContextMenuClientWin.cpp: (ContextMenuClientWin::contextMenuItemSelected):
• COM/ContextMenuClientWin.h:
• COM/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::setDocumentViewFromPageCache): (WebFrameLoaderClient::forceLayout): (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad): (WebFrameLoaderClient::updateGlobalHistoryForReload): (WebFrameLoaderClient::shouldGoToHistoryItem): (WebFrameLoaderClient::saveScrollPositionAndViewStateToItem): (WebFrameLoaderClient::restoreScrollPositionAndViewState): (WebFrameLoaderClient::provisionalLoadStarted): (WebFrameLoaderClient::saveDocumentViewToPageCache): (WebFrameLoaderClient::canCachePage):
• COM/WebFrameLoaderClient.h:
• WebKit.vcproj/WebKit.vcproj:

3:38 AM Changeset in webkit [18578] by ap

• 2 edits in trunk/WebKitSite

2007-01-04 Lars Naesbye Christensen <​larsnaesbye@stud.ku.dk>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11295
Nightly download size is misleading

• images/download.png: Changed the size to 6 MB.

3:23 AM Changeset in webkit [18577] by ap

• 7 edits
  3 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11611
REGRESSION: No http referer header sent on XMLHttpRequest

Test: http/tests/xmlhttprequest/referer.html

• loader/FrameLoader.h: Removed FrameLoader::addExtraFieldsToRequest(NSMutableURLRequest*, bool, bool), which is no longer used.
• loader/mac/FrameLoaderMac.mm: Ditto.
• WebCore.exp: Do not export this method (WebKit doesn't use it).

• loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create): Rewrote to create the request with ResourceRequest::nsURLRequest.

• platform/PlatformString.h: (WebCore::operator!): Added. Previously, attempts to use operator! on a String would result with an NSString* conversion, which never returns nil. This was causing a problem in SubresourceLoader::create().

Jan 3, 2007:

11:48 PM Changeset in webkit [18576] by lars

• 2 edits in trunk/WebCore

fix the Qt build

10:36 PM Changeset in webkit [18575] by bdash

• 4 edits in trunk/LayoutTests

2007-01-03 Mitz Pettel <​mitz@webkit.org>

Reviewed by Mark Rowe.

• more updated results for ​http://bugs.webkit.org/show_bug.cgi?id=5164 Non-integer percentages are incorrectly rounded down in Safari

• css1/box_properties/acid_test-expected.checksum:
• css1/box_properties/acid_test-expected.png:
• css1/box_properties/acid_test-expected.txt:

9:28 PM Changeset in webkit [18574] by ddkilzer

• 37 edits
  4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

• test and updated results for ​http://bugs.webkit.org/show_bug.cgi?id=5164 Non-integer percentages are incorrectly rounded down in Safari

• css2.1/t0804-c5507-padn-r-00-c-ag-expected.checksum:
• css2.1/t0804-c5507-padn-r-00-c-ag-expected.png:
• css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
• css2.1/t0804-c5509-padn-l-00-b-ag-expected.checksum:
• css2.1/t0804-c5509-padn-l-00-b-ag-expected.png:
• css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt:
• css2.1/t09-c5526c-display-00-e-expected.checksum:
• css2.1/t09-c5526c-display-00-e-expected.png:
• css2.1/t09-c5526c-display-00-e-expected.txt:
• fast/block/basic/011-expected.checksum:
• fast/block/basic/011-expected.png:
• fast/block/basic/011-expected.txt:
• fast/css/percentage-non-integer-expected.checksum: Added.
• fast/css/percentage-non-integer-expected.png: Added.
• fast/css/percentage-non-integer-expected.txt: Added.
• fast/css/percentage-non-integer.html: Added.
• tables/mozilla/bugs/bug4385-expected.checksum:
• tables/mozilla/bugs/bug4385-expected.png:
• tables/mozilla/bugs/bug4385-expected.txt:
• tables/mozilla_expected_failures/core/col_span2-expected.checksum:
• tables/mozilla_expected_failures/core/col_span2-expected.txt:

WebCore:

Reviewed by Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=5164 Non-integer percentages are incorrectly rounded down in Safari

Test: fast/css/percentage-non-integer.html

Added floating point constructor and accessors to Length for use with
Percent lengths only. The raw value of a percent length is the integer
part of a constant multiple of the original double value. The constant
is percentScaleFactor, which is currently 128.

Added assertions that the correct constructors and accessors are used
depending on the type: the double-based percent(), setValue() and Length()
for the Percent type, and the integer-based value(), setValue() and Length()
for all other types.

calcValue() and calcMinValue() work the same as before, regardless of the
type.

Added helpers for testing if the value is 0, positive, negative or undefined
without having to check the type first.

Added raw value accessors. These are useful for doing integer math and
comparisons with scaled percent values or doing Length type-agnostic math.

Changed the rest of the code to use the appropriate accessors and helpers.

• css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForLength): (WebCore::primitiveValueFromLength): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
• css/cssstyleselector.cpp: (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundSize): (WebCore::CSSStyleSelector::mapBackgroundXPosition): (WebCore::CSSStyleSelector::mapBackgroundYPosition):
• platform/StringImpl.cpp: (WebCore::parseLength):
• rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::fullRecalc): (WebCore::AutoTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout): (WebCore::AutoTableLayout::calcPercentages):
• rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::layout):
• rendering/Length.h: (WebCore::Length::Length): (WebCore::Length::value): (WebCore::Length::rawValue): (WebCore::Length::percent): (WebCore::Length::setValue): (WebCore::Length::setRawValue): (WebCore::Length::calcValue): (WebCore::Length::calcMinValue): (WebCore::Length::isUndefined): (WebCore::Length::isZero): (WebCore::Length::isPositive): (WebCore::Length::isNegative):
• rendering/RenderBR.cpp: (WebCore::RenderBR::lineHeight):
• rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelfCollapsingBlock):
• rendering/RenderBox.cpp: (WebCore::cacluateBackgroundSize): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcReplacedWidth): (WebCore::RenderBox::calcReplacedHeight): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteVertical):
• rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::allowedChildFlex):
• rendering/RenderFlow.cpp: (WebCore::RenderFlow::lineHeight):
• rendering/RenderImage.cpp: (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight):
• rendering/RenderLayer.cpp: (WebCore::Marquee::direction): (WebCore::Marquee::start):
• rendering/RenderObject.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::lineHeight):
• rendering/RenderSlider.cpp: (WebCore::RenderSlider::layout): Added FIXMEs.
• rendering/RenderStyle.h: (WebCore::LengthBox::nonZero): (WebCore::RenderStyle::initialLineHeight):
• rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth):
• rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::layoutRows):

9:25 PM Changeset in webkit [18573] by bdash

• 2 edits in tags/WebKit-521.32.1/WebKit

Versioning.

9:23 PM Changeset in webkit [18572] by ddkilzer

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=11744 Setting the 'content' property dynamically has no effect

• fast/css/content-dynamic-expected.checksum: Added.
• fast/css/content-dynamic-expected.png: Added.
• fast/css/content-dynamic-expected.txt: Added.
• fast/css/content-dynamic.html: Added.

WebCore:

Reviewed by Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11744 Setting the 'content' property dynamically has no effect

Test: fast/css/content-dynamic.html

• dom/Node.cpp: (WebCore::Node::diff): Changed to return 'Detach' if the styles' content data are not equivalent.

9:19 PM Changeset in webkit [18571] by ddkilzer

• 3 edits
  2 adds in trunk

LayoutTests:

Reviewed by Darin.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=12082 REGRESSION (r18333): Crash in RenderFrameSet::layOutAxis()

• fast/frames/negative-remaining-length-crash-expected.txt: Added.
• fast/frames/negative-remaining-length-crash.html: Added.

WebCore:

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12082 REGRESSION (r18333): Crash in RenderFrameSet::layOutAxis()

Test: fast/frames/negative-remaining-length-crash.html

• rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layOutAxis): Treat negative availableLength as zero.

6:17 PM Changeset in webkit [18570] by bdash

• 2 edits in trunk/WebKitTools

2007-01-03 Mark Rowe <​bdash@webkit.org>

Reviewed by Anders.

• Scripts/run-webkit-tests: Launch Safari using the same WebKit build configuration as the layout tests used.

6:01 PM Changeset in webkit [18569] by sullivan

• 2 edits in trunk/WebCore

Written by Darin over my shoulder; reviewed by me

• fixed <rdar://problem/4907437> Find doesn't work if invoked when a form field is focused

• page/Frame.cpp: (WebCore::isInShadowTree): new helper function used by findString (WebCore::Frame::findString): when deciding whether to start from the selection, ignore selections that are in a shadow tree (i.e. in a form control)

5:21 PM Changeset in webkit [18568] by beidson

• 2 edits in trunk/WebCore

Reviewed by Mark Rowe

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=12089

• loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForCommit): Null check the documentLoader

5:20 PM Changeset in webkit [18567] by sullivan

• 2 edits in trunk/WebKit

• WebView/WebPDFView.mm: (-[WebPDFView _openWithFinder:]): Tiger build fix: use [NSNumber initWithInt:] rather than the new [NSNumber initWithInteger:]

5:07 PM Changeset in webkit [18566] by hyatt

• 4 adds in trunk/LayoutTests/fast/css-generated-content

Add layout test for inline generated content.

5:07 PM Changeset in webkit [18565] by hyatt

• 2 edits in trunk/WebCore

Relax the display type restriction a little bit for generated content inside
inlines. We still don't allow block display types like we should (since this
will cause a crash), but we at least handle inline-table and inline-block now.

Reviewed by beth

fast/css-generated-content/inline-display-types.html

• rendering/RenderContainer.cpp: (WebCore::RenderContainer::updatePseudoChildForObject):

5:05 PM Changeset in webkit [18564] by justing

• 4 edits in trunk

LayoutTests:

Reviewed by john

• editing/pasteboard/merge-end-blockquote-expected.txt: A recent change caused an acceptable change in these expected results.

WebCore:

Reviewed by john

<rdar://problem/4663571> Spell checking won't cross boundary of individual To-Do item

No layout tests because advanceToNextMisspelling isn't yet exposed to automated tests.

• editing/mac/EditorMac.mm: (WebCore::Editor::advanceToNextMisspelling): Confine spell checking to the highest editable root, instead of the lowest. Use firstEditablePosition... to look for an editable position.

4:57 PM Changeset in webkit [18563] by bdakin

• 2 edits in trunk/WebCore

Fixing silly mistake.

• platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): Called wrong string function.

4:55 PM Changeset in webkit [18562] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Kevin Decker

• fixed <rdar://problem/4145714> WebKit's PDFView's "Open in Preview" puts the PDF in /tmp, both group and world-readable

• WebView/WebPDFView.mm: (-[WebPDFView _openWithFinder:]): Make the file only readable by the current user

4:53 PM Changeset in webkit [18561] by beidson

• 2 edits in trunk/WebCore

Reviewed by Anders

​http://bugs.webkit.org/show_bug.cgi?id=12093 - Assertion in certain SVG layout tests
I can't really think of a cleaner way to fix this then to help these SVG cases avoid
the ASSERT - hopefully we can clean up the svg-as-image situation as the loader stabilizes
and we find better ways to handle it...

• loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::urlForHistory): empty-check the url before passing it to the ASSERTing method

4:49 PM Changeset in webkit [22726] by darin

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

• removed some obsolete source files

• WebCore.vcproj/WebCore.vcproj: Removed obsolete files.

4:40 PM Changeset in webkit [18560] by darin

• 7 edits
  8 deletes in trunk/WebCore

Reviewed by Adele.

• removed some obsolete source files

• CMakeLists.txt: Removed obsolete files.
• WebCore.pro: Ditto.
• WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• WebCoreSources.bkl: Ditto.

• html/HTMLGenericFormElement.h: Removed reference to RenderFormElement.

• platform/qt/ComboBoxQt.cpp: Removed.
• platform/qt/LineEditQt.cpp: Removed.
• platform/qt/ListBoxQt.cpp: Removed.
• platform/qt/TextEditQt.cpp: Removed.
• rendering/RenderFormElement.cpp: Removed.
• rendering/RenderFormElement.h: Removed.
• rendering/RenderLabel.cpp: Removed.
• rendering/RenderLabel.h: Removed.

4:27 PM Changeset in webkit [18559] by darin

• 4 edits
  5 adds in trunk

LayoutTests:

Reviewed by Hyatt.

• test for bug where :after content appeared in the wrong order

• fast/css-generated-content/after-order-expected.checksum: Added.
• fast/css-generated-content/after-order-expected.png: Added.
• fast/css-generated-content/after-order-expected.txt: Added.
• fast/css-generated-content/after-order.html: Added.
• fast/css-generated-content/resources/greenbox.png: Added.

WebCore:

Reviewed by Hyatt.

• fix bug where :after content appears backwards

Test: fast/css-generated-content/after-order.html

• rendering/RenderBlock.cpp: (WebCore::isAfterContent): Added. (WebCore::RenderBlock::addChildToFlow): Use isAfterContent.
• rendering/RenderInline.cpp: (WebCore::isAfterContent): Added. (WebCore::RenderInline::addChildToFlow): Use isAfterContent.

4:15 PM Changeset in webkit [18558] by thatcher

• 5 edits in tags/WebKit-521.32.1/WebKit

Merging r18381 and r18388.

4:04 PM Changeset in webkit [18557] by hyatt

• 7 edits in trunk/WebCore

Implement box-shadow parsing... getting it all into the RenderStyle.

Reviewed by beth

• css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
• css/CSSPropertyNames.in:
• css/cssparser.cpp: (WebCore::CSSParser::parseValue):
• css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
• rendering/RenderStyle.cpp: (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData): (WebCore::StyleCSS3NonInheritedData::operator==): (WebCore::StyleCSS3NonInheritedData::shadowDataEquivalent): (WebCore::RenderStyle::diff): (WebCore::RenderStyle::setBoxShadow):
• rendering/RenderStyle.h: (WebCore::RenderStyle::boxShadow):

3:48 PM Changeset in webkit [22725] by bdakin

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by John.

Add stubs for all of the localized context menu item titles. The
stubs just return English Strings until we have a localization
solution in WebKit.

3:47 PM Changeset in webkit [18556] by thatcher

• 1 copy in tags/WebKit-521.32.1/WebKit

New tag (part 2).

3:46 PM Changeset in webkit [18555] by thatcher

• 1 add in tags/WebKit-521.32.1

New tag (part 1).

3:38 PM Changeset in webkit [18554] by bdakin

• 8 edits in trunk

WebCore:

Reviewed by John.

Call into WebKit to get localized strings for all of the context
menu item titles.

WebKit:

Reviewed by John.

Make localized strings for all of the context menu item titles that
are accessible to WebCore.

2:24 PM Changeset in webkit [22724] by andersca

• 4 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

<rdar://problem/4857027>
ragnarok online misrenders (due to lack of support for windowless plugins)

• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateWindow): Rename from updateHwnd since this now handles updating the clip rect for windowless plugins.

(WebCore::PluginViewWin::paintMissingPluginIcon):
New function which paints the missing plugin icon.

(WebCore::PluginViewWin::paint):
Do windowless painting here.

(WebCore::PluginViewWin::handleKeyboardEvent):
(WebCore::PluginViewWin::handleMouseEvent):
(WebCore::PluginViewWin::handleEvent):
New functions for handling mouse and keyboard events, translating them and handing them to the plugin.

(WebCore::PluginViewWin::setNPWindowRect):
Set correct window rect for windowless plugins.

(WebCore::PluginViewWin::getValue):
Add variable for containing HWND.

(WebCore::PluginViewWin::setValue):
Add windowless and transparent variables.

(WebCore::PluginViewWin::invalidateRect):
(WebCore::PluginViewWin::invalidateRegion):
(WebCore::PluginViewWin::forceRedraw):
Implement these.

(WebCore::PluginViewWin::determineQuirks):
Set quirks now that we support windowless flash.

(WebCore::PluginViewWin::PluginViewWin):
Only create the window if the plugin isn't windowless.

• plugins/win/PluginViewWin.h: New declarations.

• plugins/win/npapi.cpp: (NPN_InvalidateRect): (NPN_InvalidateRegion): (NPN_ForceRedraw): Implement these and forward them to the plugin view.

2:19 PM Changeset in webkit [18553] by beidson

• 3 edits in trunk/WebCore

Reviewed by Darin and Geoff

​http://bugs.webkit.org/show_bug.cgi?id=12105 - Crash visiting Acid2 test page
-Replace lost "free nil checking" in the WebKit->WebCore conversion of the BackForwardList
-Changed ::createItem and ::createItemTree to ::createHistoryItem and ::createHistoryItemTree

• loader/FrameLoader.cpp: (WebCore::FrameLoader::createHistoryItem): (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): (WebCore::FrameLoader::createHistoryItemTree): (WebCore::FrameLoader::updateHistoryForInternalLoad):
• loader/FrameLoader.h:

1:48 PM Changeset in webkit [18552] by andersca

• 4 edits in trunk/WebCore

Reviewed by Geoff.

Allow plugin elements to handle off events to their widgets.

• html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::defaultEventHandler):
• html/HTMLPlugInElement.h:
• platform/Widget.h: (WebCore::Widget::handleEvent):

12:56 PM Changeset in webkit [18551] by beidson

• 2 edits in trunk/WebKit

Reviewed by John Sullivan

In the Bookmarks View/History View, favicon may be the incorrect size

• History/WebHistoryItem.mm: (-[WebHistoryItem icon]): Call to the WebIconDatabase until a WebCore issue is resolved

11:35 AM Changeset in webkit [18550] by adele

• 2 edits in trunk/WebKit

Reviewed by Darin.

• Fix for <rdar://problem/4455147> Safari allows division slash character in URLs, which looks like slash character (not fixed by IDNScriptWhiteList.txt)

• Misc/WebNSURLExtras.m: (allCharactersInIDNScriptWhiteList): Always disallow the division slash character.

11:16 AM Changeset in webkit [18549] by ap

• 1 edit
  3 adds in trunk/LayoutTests

Reviewed by Darin.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=3420
XMLHttpRequest does not handle set-cookie headers

• http/tests/xmlhttprequest/cookies-expected.txt: Added.
• http/tests/xmlhttprequest/cookies.html: Added.
• http/tests/xmlhttprequest/resources/get-set-cookie.cgi: Added.

10:38 AM Changeset in webkit [18548] by yongjzha

• 3 edits in S60/branches/3.1m/WebKit

2006-12-28 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Fix the issue with the SQL query associated with the checkin made for the following bug:
TSW id:EYWG-6W7B4F: Error note "Program closed:BrowserNG" after clicking Submit button on test page
​http://bugs.webkit.org/show_bug.cgi?id=11781

• BrowserView/inc/FormDataAutoFillStore.h:
• BrowserView/src/FormDataAutoFillStore.cpp: (CFormDataAutoFillStore::GetDataL): (CFormDataAutoFillStore::DeleteData): (CFormDataAutoFillStore::InsertData): (CFormDataAutoFillStore::CreateDatabase): (CFormDataAutoFillStore::ReadLongTextL):

10:25 AM Changeset in webkit [18547] by yongjzha

• 2 edits in S60/trunk/WebKit

2007-01-03 sareen <​shyam.sareen@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Vodafone Specific Storage test failing.
​http://bugs.webkit.org/show_bug.cgi?id=12101

• ResourceLoader/CacheSrc/HttpCacheUtil.cpp: (HttpCacheUtil::VSSCacheContent):

10:17 AM Changeset in webkit [18546] by yongjzha

• 3 edits in S60/trunk/WebKit

2006-12-28 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Put back the patches r18389, r18183 as well as fix the issue with the SQL query.
Patches r18389, r18183 fix the following two bugs:
TSW ID# SRAY-6WQKA6: Formdataautofill: If the form field contains single or double quotes the SQL query to insert, delete data does not work.
​http://bugs.webkit.org/show_bug.cgi?id=11927
TSW id:EYWG-6W7B4F: Error note "Program closed:BrowserNG" after clicking Submit button on test page
​http://bugs.webkit.org/show_bug.cgi?id=11781

• BrowserView/inc/FormDataAutoFillStore.h:
• BrowserView/src/FormDataAutoFillStore.cpp: (CFormDataAutoFillStore::NewL): (CFormDataAutoFillStore::CFormDataAutoFillStore): (CFormDataAutoFillStore::ConstructL): (CFormDataAutoFillStore::~CFormDataAutoFillStore): (CFormDataAutoFillStore::GetDataL): (CFormDataAutoFillStore::DeleteDataL): (CFormDataAutoFillStore::InsertDataL): (CFormDataAutoFillStore::SaveData): (CFormDataAutoFillStore::ClearData): (CFormDataAutoFillStore::OpenDatabase): (CFormDataAutoFillStore::CloseDatabase): (CFormDataAutoFillStore::OpenTableForUse): (CFormDataAutoFillStore::CloseTableAfterUse): (CFormDataAutoFillStore::CreateDatabase): (CFormDataAutoFillStore::CreateFormDataTableL): (CFormDataAutoFillStore::WriteLongTextL): (CFormDataAutoFillStore::ReadLongTextL):

4:04 AM Changeset in webkit [18545] by lars

• 10 edits
  2 adds in trunk

Fix the Qt build

12:31 AM Changeset in webkit [18544] by beidson

• 2 edits in trunk/WebKit

Controversially reviewed by Tim H. and Maciej

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=12086, ​http://bugs.webkit.org/show_bug.cgi?id=12088,
possibly ​http://bugs.webkit.org/show_bug.cgi?id=12087, and probably a slew of others

WebHistoryItems returned from the WebBackForwardList accessors were being release/retained out-of-order
by the Safari app. This bug never surfaced before because the WebBackForwardList had a retain on the
item, preventing deallocation. Since the items are now just temporary wrappers, the list
is no longer actually retaining them.

This solution is to simulate the ownership with a [[id retain] autorelease] - gross, but maybe the
only solution for now... =/

We can possibly consider reverting this fix at a later date - that task is marked by
<rdar://problem/4905705>

• History/WebBackForwardList.mm: (-[WebBackForwardList backItem]): (-[WebBackForwardList currentItem]): (-[WebBackForwardList forwardItem]): (-[WebBackForwardList itemAtIndex:]):

Jan 2, 2007:

10:59 PM Changeset in webkit [18543] by bdash

• 4 edits in tags/Safari-421.32

Versioning.

8:16 PM Changeset in webkit [18542] by bdakin

• 3 edits in trunk/WebKit

Reviewed by Geoff.

Remove un-used function.

• WebCoreSupport/WebContextMenuClient.h:
• WebCoreSupport/WebContextMenuClient.mm:

7:28 PM Changeset in webkit [22723] by beidson

• 6 edits in branches/WindowsMerge

Temporary Link Stub fix after landing Back/Forward cache in OpenSource

7:11 PM Changeset in webkit [18541] by beidson

• 54 edits
  1 move
  13 adds
  2 deletes in trunk

WebCore:

Reviewed extensively and repeatedly by Darin

<rdar://problem/4887137> - WebCore Back/Forward Cache

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:

• bridge/mac/WebCorePageState.h: Removed.
• bridge/mac/WebCorePageState.mm: Removed.

• history/BackForwardList.cpp: Added - This largely emulates the design of WebBackForwardList (WebCore::BackForwardList::BackForwardList): (WebCore::BackForwardList::~BackForwardList): (WebCore::BackForwardList::addItem): (WebCore::BackForwardList::goBack): (WebCore::BackForwardList::goForward): (WebCore::BackForwardList::goToItem): (WebCore::BackForwardList::backItem): (WebCore::BackForwardList::currentItem): (WebCore::BackForwardList::forwardItem): (WebCore::BackForwardList::backListWithLimit): (WebCore::BackForwardList::forwardListWithLimit): (WebCore::BackForwardList::capacity): (WebCore::BackForwardList::setCapacity): (WebCore::BackForwardList::setPageCacheSize): (WebCore::BackForwardList::pageCacheSize): (WebCore::BackForwardList::clearPageCache): (WebCore::BackForwardList::usesPageCache): (WebCore::BackForwardList::backListCount): (WebCore::BackForwardList::forwardListCount): (WebCore::BackForwardList::itemAtIndex): (WebCore::BackForwardList::entries): (WebCore::BackForwardList::close): (WebCore::BackForwardList::closed): (WebCore::BackForwardList::removeItem): (WebCore::BackForwardList::containsItem): (WebCore::BackForwardList::setDefaultPageCacheSize): (WebCore::BackForwardList::defaultPageCacheSize):
• history/BackForwardList.h: Added.

• history/HistoryItem.cpp: Added - This largely emulates the design of WebBackForwardList (WebCore::defaultNotifyHistoryItemChanged): (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::~HistoryItem): (WebCore::HistoryItem::copy): (WebCore::HistoryItem::setHasPageCache): (WebCore::HistoryItem::retainIconInDatabase): (WebCore::HistoryItem::urlString): (WebCore::HistoryItem::originalURLString): (WebCore::HistoryItem::title): (WebCore::HistoryItem::alternateTitle): (WebCore::HistoryItem::icon): (WebCore::HistoryItem::lastVisitedTime): (WebCore::HistoryItem::url): (WebCore::HistoryItem::originalURL): (WebCore::HistoryItem::target): (WebCore::HistoryItem::parent): (WebCore::HistoryItem::setAlternateTitle): (WebCore::HistoryItem::setURLString): (WebCore::HistoryItem::setURL): (WebCore::HistoryItem::setOriginalURLString): (WebCore::HistoryItem::setTitle): (WebCore::HistoryItem::setTarget): (WebCore::HistoryItem::setParent): (WebCore::HistoryItem::setLastVisitedTime): (WebCore::HistoryItem::visitCount): (WebCore::HistoryItem::setVisitCount): (WebCore::HistoryItem::scrollPoint): (WebCore::HistoryItem::setScrollPoint): (WebCore::HistoryItem::clearScrollPoint): (WebCore::HistoryItem::setDocumentState): (WebCore::HistoryItem::documentState): (WebCore::HistoryItem::clearDocumentState): (WebCore::HistoryItem::isTargetItem): (WebCore::HistoryItem::setIsTargetItem): (WebCore::HistoryItem::alwaysAttemptToUsePageCache): (WebCore::HistoryItem::setAlwaysAttemptToUsePageCache): (WebCore::HistoryItem::addChildItem): (WebCore::HistoryItem::childItemWithName): (WebCore::HistoryItem::recurseToFindTargetItem): (WebCore::HistoryItem::targetItem): (WebCore::HistoryItem::pageCache): (WebCore::HistoryItem::children): (WebCore::HistoryItem::hasChildren): (WebCore::HistoryItem::formContentType): (WebCore::HistoryItem::formReferrer): (WebCore::HistoryItem::rssFeedReferrer): (WebCore::HistoryItem::setRSSFeedReferrer): (WebCore::HistoryItem::setFormInfoFromRequest): (WebCore::HistoryItem::formData): (WebCore::HistoryItem::mergeAutoCompleteHints): (WebCore::HistoryItem::hasPageCache): (WebCore::timer): Function to manage the global release timer (WebCore::pendingPageCacheToRelease): Function to manage the global queue of caches to be released (WebCore::HistoryItem::releasePageCache): (WebCore::closeObjectsInPendingPageCaches): (WebCore::HistoryItem::releaseAllPendingPageCaches): (WebCore::HistoryItem::scheduleRelease): (WebCore::HistoryItem::print):
• history/HistoryItem.h: Added.
• history/mac/HistoryItemMac.mm: Added. (WebCore::HistoryItem::viewState): In the future we need a platform agnostic way to manage the view state (WebCore::HistoryItem::setViewState): (WebCore::HistoryItem::getTransientProperty): Transient properties are, for now, only a Mac concept (WebCore::HistoryItem::setTransientProperty):

• history/HistoryItemTimer.cpp: Added (WebCore::HistoryItemTimer::HistoryItemTimer): We need a specific class to be the history item timer because WebCore::Timers only work when you have an instance of an object, but the caches pending release is a static concept (WebCore::HistoryItemTimer::isActive): (WebCore::HistoryItemTimer::schedule): (WebCore::HistoryItemTimer::invalidate): (WebCore::HistoryItemTimer::callReleasePageCache):
• history/HistoryItemTimer.h: Added.

• history/PageCache.cpp Added - This is a class that contains the fields that used to be in an NSDictionary in WebKit (WebCore::PageCache::PageCache): (WebCore::PageCache::setPageState): (WebCore::PageCache::~PageCache): (WebCore::PageCache::pageState): (WebCore::PageCache::setDocumentLoader): (WebCore::PageCache::documentLoader): (WebCore::PageCache::setTimeStamp): (WebCore::PageCache::setTimeStampToNow): (WebCore::PageCache::timeStamp):
• history/PageCache.h: Added.
• history/mac/PageCacheMac.mm: Added. (WebCore::PageCache::close): (WebCore::PageCache::setDocumentView): In the future we need a platform agnostic way to manage the documentView (WebCore::PageCache::documentView):

• loader/DocumentLoader.cpp: (WebCore::DocumentLoader::loadFromPageCache): (WebCore::DocumentLoader::setLoadingFromPageCache): (WebCore::DocumentLoader::isLoadingFromPageCache): (WebCore::DocumentLoader::originalURL): (WebCore::DocumentLoader::requestURL): (WebCore::DocumentLoader::responseURL): (WebCore::DocumentLoader::responseMIMEType):
• loader/DocumentLoader.h:

• loader/FrameLoader.cpp: Responsibilities previously scattered in WebKit but concentrated in WebView and WebFrame are now here, where they should be. (WebCore::FrameLoader::clear): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::goBackOrForward): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::canCachePage): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoader::dispatchDidFinishLoadToClient): (WebCore::FrameLoader::updateGlobalHistoryForStandardLoad): Marked for usage in future GlobalHistory (uses client for now) (WebCore::FrameLoader::updateGlobalHistoryForReload): Ditto (WebCore::FrameLoader::shouldGoToHistoryItem): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::addHistoryItemForFragmentScroll): (WebCore::FrameLoader::loadProvisionalItemFromPageCache): (WebCore::FrameLoader::createPageCache): (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoader::createItem): (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): (WebCore::FrameLoader::createItemTree): (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem): (WebCore::FrameLoader::restoreScrollPositionAndViewState): (WebCore::FrameLoader::purgePageCache): (WebCore::FrameLoader::invalidateCurrentItemPageCache): (WebCore::FrameLoader::saveDocumentState): (WebCore::FrameLoader::loadItem): (WebCore::FrameLoader::urlsMatchItem): (WebCore::FrameLoader::goToItem): (WebCore::FrameLoader::recursiveGoToItem): (WebCore::FrameLoader::childFramesMatchItem): (WebCore::FrameLoader::updateHistoryForStandardLoad): (WebCore::FrameLoader::updateHistoryForClientRedirect): (WebCore::FrameLoader::updateHistoryForBackForwardNavigation): (WebCore::FrameLoader::updateHistoryForReload): (WebCore::FrameLoader::updateHistoryForInternalLoad): (WebCore::FrameLoader::updateHistoryForCommit): (WebCore::FrameLoader::saveDocumentAndScrollState): (WebCore::FrameLoader::currentHistoryItem): (WebCore::FrameLoader::previousHistoryItem): (WebCore::FrameLoader::provisionalHistoryItem): (WebCore::FrameLoader::setCurrentHistoryItem): (WebCore::FrameLoader::setPreviousHistoryItem): (WebCore::FrameLoader::setProvisionalHistoryItem):
• loader/FrameLoader.h:

• loader/FrameLoaderClient.h:

• loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::getResponseRefreshAndModifiedHeaders): (WebCore::DocumentLoader::commitIfReady): (WebCore::DocumentLoader::urlForHistory):

• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::dataURLBaseFromRequest): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::checkLoadCompleteForThisFrame):

• page/FrameTree.cpp: (WebCore::FrameTree::removeChild):

• page/Page.cpp: Transfered a handful of concepts from WebView (WebCore::Page::Page): (WebCore::Page::~Page): (WebCore::Page::backForwardList): (WebCore::Page::goBack): (WebCore::Page::goForward): (WebCore::Page::goToItem):
• page/Page.h:

• page/PageState.h:
• page/mac/FrameMac.h:
• page/mac/FrameMac.mm:
• page/mac/WebCoreFrameBridge.h:
• page/mac/WebCoreFrameBridge.mm:

• platform/KURL.cpp: (WebCore::KURL::print): Added debug only method for debugging convenience
• platform/KURL.h:

• platform/Logging.cpp: (WebCore::): Added some logging channels
• platform/Logging.h:

• platform/PlatformString.h: (WebCore::nsStringNilIfEmpty): Added for WebKit use

• platform/SystemTime.h: Added userIdleTime()

• platform/graphics/svg/SVGImage.cpp:
• platform/graphics/svg/SVGImageEmptyClients.h: Updated for new FrameLoaderClient methods (WebCore::SVGEmptyFrameLoaderClient::setDocumentViewFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::updateGlobalHistoryForStandardLoad): (WebCore::SVGEmptyFrameLoaderClient::updateGlobalHistoryForReload): (WebCore::SVGEmptyFrameLoaderClient::shouldGoToHistoryItem): (WebCore::SVGEmptyFrameLoaderClient::saveScrollPositionAndViewStateToItem): (WebCore::SVGEmptyFrameLoaderClient::saveDocumentViewToPageCache): (WebCore::SVGEmptyFrameLoaderClient::canCachePage): (WebCore::SVGEmptyEditorClient::~SVGEmptyEditorClient):

• platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):

• platform/mac/SystemTimeMac.cpp: (WebCore::userIdleTime):

• platform/mac/WebCoreSystemInterface.h: Added wkSecondsSinceLastInput for use in userIdleTime
• platform/mac/WebCoreSystemInterface.mm:

• platform/network/FormData.cpp: (WebCore::FormData::FormData): (WebCore::FormData::copy):
• platform/network/FormData.h:

• platform/network/ResourceHandle.h:
• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willLoadFromCache): For "are you sure you want to resubmit?" nag

• platform/qt/TemporaryLinkStubs.cpp: (WebCore::userIdleTime):
• rendering/RenderPart.h:

WebKit:

Reviewed extensively and repeatedly by Darin

<rdar://problem/4887137> - WebCore Back/Forward Cache
Most things not specifically commented on in the ChangeLog can be summed up as
"Do things exactly the same way as we used to, but just stick in WebCore-land as much as possible"

• History/WebBackForwardList.mm: (kitPrivate): Convenience functions to help with subbing "WebBackForwardListPrivate" for WebCore::BackForwardList (core): (backForwardListWrappers): A HashMap pattern used to map WebCore objects to their WebKit counterpart (kit): (+[WebBackForwardList setDefaultPageCacheSizeIfNecessary]): (-[WebBackForwardList initWithWebCoreBackForwardList:]): (-[WebBackForwardList init]): (-[WebBackForwardList dealloc]): (-[WebBackForwardList finalize]): (-[WebBackForwardList _close]): (-[WebBackForwardList addItem:]): (-[WebBackForwardList removeItem:]): (-[WebBackForwardList containsItem:]): (-[WebBackForwardList goBack]): (-[WebBackForwardList goForward]): (-[WebBackForwardList goToItem:]): (-[WebBackForwardList backItem]): (-[WebBackForwardList currentItem]): (-[WebBackForwardList forwardItem]): (vectorToNSArray): (-[WebBackForwardList backListWithLimit:]): (-[WebBackForwardList forwardListWithLimit:]): (-[WebBackForwardList capacity]): (-[WebBackForwardList setCapacity:]): (-[WebBackForwardList description]): (-[WebBackForwardList _clearPageCache]): (-[WebBackForwardList setPageCacheSize:]): (-[WebBackForwardList pageCacheSize]): (-[WebBackForwardList _usesPageCache]): (-[WebBackForwardList backListCount]): (-[WebBackForwardList forwardListCount]): (-[WebBackForwardList itemAtIndex:]):
• History/WebBackForwardListInternal.h: Added.

• History/WebHistory.m: Removed.
• History/WebHistory.mm: Added - Needed to be .mm to accept C++ header style (-[_WebCoreHistoryProvider containsItemForURLLatin1:length:]): (-[_WebCoreHistoryProvider containsItemForURLUnicode:length:]):

• History/WebHistoryItem.mm: (kitPrivate): Same pattern as WebBackForwardList (core): (historyItemWrappers): (WKNotifyHistoryItemChanged): (-[WebHistoryItem init]): (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]): (-[WebHistoryItem dealloc]): (-[WebHistoryItem finalize]): (-[WebHistoryItem copyWithZone:]): (-[WebHistoryItem URLString]): (-[WebHistoryItem originalURLString]): (-[WebHistoryItem title]): (-[WebHistoryItem setAlternateTitle:]): (-[WebHistoryItem alternateTitle]): (-[WebHistoryItem icon]): (-[WebHistoryItem lastVisitedTimeInterval]): (-[WebHistoryItem hash]): (-[WebHistoryItem isEqual:]): (-[WebHistoryItem description]): (kit): (+[WebHistoryItem entryWithURL:]): (+[WebHistoryItem initWindowWatcherIfNecessary]): (-[WebHistoryItem initWithURL:target:parent:title:]): (-[WebHistoryItem initWithWebCoreHistoryItem:]): (-[WebHistoryItem setTitle:]): (-[WebHistoryItem setVisitCount:]): (-[WebHistoryItem setViewState:]): (-[WebHistoryItem _mergeAutoCompleteHints:]): (-[WebHistoryItem initFromDictionaryRepresentation:]): (-[WebHistoryItem scrollPoint]): (-[WebHistoryItem _transientPropertyForKey:]): (-[WebHistoryItem _setTransientProperty:forKey:]): (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem target]): (-[WebHistoryItem isTargetItem]): (-[WebHistoryItem visitCount]): (-[WebHistoryItem RSSFeedReferrer]): (-[WebHistoryItem setRSSFeedReferrer:]): (-[WebHistoryItem children]): (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]): (-[WebHistoryItem URL]): (-[WebHistoryItem _setLastVisitedTimeInterval:]): (-[WebHistoryItem _lastVisitedDate]): (-[WebHistoryItem targetItem]): (+[WebHistoryItem _releaseAllPendingPageCaches]): (-[WebWindowWatcher windowWillClose:]):
• History/WebHistoryItemInternal.h:
• History/WebHistoryItemPrivate.h:

• WebCoreSupport/WebFrameBridge.mm:
• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setDocumentViewFromPageCache): (WebFrameLoaderClient::detachedFromParent1): (WebFrameLoaderClient::loadedFromPageCache): (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad): (WebFrameLoaderClient::updateGlobalHistoryForReload): (WebFrameLoaderClient::shouldGoToHistoryItem): (WebFrameLoaderClient::frameLoadCompleted): (WebFrameLoaderClient::saveScrollPositionAndViewStateToItem): (WebFrameLoaderClient::restoreScrollPositionAndViewState): (WebFrameLoaderClient::provisionalLoadStarted): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::saveDocumentViewToPageCache): (WebFrameLoaderClient::canCachePage):

• WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

• WebKit.xcodeproj/project.pbxproj:

• WebView/WebDataSource.mm:
• WebView/WebDataSourceInternal.h:

• WebView/WebFrame.mm: (-[WebFramePrivate dealloc]): (-[WebFrame _canCachePage]): (-[WebFrame _loadURL:referrer:intoChild:]):
• WebView/WebFrameInternal.h:

• WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): (-[WebFrameView keyDown:]):

• WebView/WebHTMLView.m: (-[WebHTMLView closeIfNotCurrentView]): Added for a dirty hack in WebCore that is marked with a FIXME Radar
• WebView/WebHTMLViewInternal.h:

• WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebViewPrivate dealloc]): (-[WebView _close]): (-[WebView _loadBackForwardListFromOtherView:]): (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView initWithCoder:]): (-[WebView backForwardList]): (-[WebView goBack]): (-[WebView goForward]): (-[WebView goToBackForwardItem:]): (-[WebView canGoBack]): (-[WebView canGoForward]):

5:05 PM Changeset in webkit [18540] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Kevin Decker

• fixed <rdar://problem/4892525> Cannot open PDF in Preview if you attempted to open it in Preview while PDF was loading

• WebView/WebPDFView.mm: (-[WebPDFView menuForEvent:]): added comment (-[WebPDFView validateUserInterfaceItem:]): disable this menu item when there's no document yet (-[WebPDFView _openWithFinder:]): If this is invoked when there is no document yet (e.g. via the PDFKit delegate method), just beep and return. I should make a nice error message here, but I'll do that separately.

4:48 PM Changeset in webkit [18539] by bdash

• 2 edits in tags/Safari-421.32/WebCore

Merge fix r18352.

4:45 PM Changeset in webkit [18538] by bdash

• 2 edits in tags/Safari-421.32/JavaScriptCore

Merge fix r18349.

4:41 PM Changeset in webkit [18537] by bdash

• 5 edits in tags/Safari-421.32/WebCore

Merge fix r18328 and r18386.

4:32 PM Changeset in webkit [18536] by zimmermann

• 2 edits in trunk/WebKit

Reviewed by Timothy.
Fix inspection of RenderSVGInlineText objects (#text nodes in SVG documents).

4:23 PM Changeset in webkit [18535] by bdash

• 1 copy in tags/Safari-421.32

New tag.

3:40 PM Changeset in webkit [22722] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

3:34 PM Changeset in webkit [18534] by darin

• 7 edits in trunk/WebCore

Rubber stamped by Mitz.

Rename isRenderSVGContainer to isSVGContainer.

• platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::renderSubtreeToImage):
• rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock):
• rendering/RenderObject.h: (WebCore::RenderObject::isSVGContainer):
• rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::viewportTransform):
• rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::isSVGContainer):
• rendering/RenderTreeAsText.cpp: (WebCore::write):

3:31 PM Changeset in webkit [18533] by sfalken

• 1 copy in tags/Safari-521.32.8b

New tag.

3:22 PM Changeset in webkit [18532] by zimmermann

• 1 edit in trunk/WebCore/ChangeLog

Forgot to commit the ChangeLog changes in last commit (Rename isKCanvasContainer to isRenderSVGContainer)

3:20 PM Changeset in webkit [18531] by zimmermann

• 6 edits in trunk/WebCore

Reviewed by Mitz.
Rename isKCanvasContainer to isRenderSVGContainer.

3:18 PM Changeset in webkit [18530] by bdakin

• 4 edits in trunk

WebCore:

Reviewed by Darin.

Fix assertion failure with WebCore context menus by getting "Copy
Image" item added in.

• platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Check if the image url is a local file or if we have an image in the cache.

WebKit:

Reviewed by Darin.

Fix bug with WebCore context menu item "Copy Image."

• WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::copyImageToClipboard): We must call declareTypes on the pasteboard.

11:31 AM Changeset in webkit [22721] by andersca

• 2 edits in branches/WindowsMerge/WebCore

Build fix.

• WebCore.vcproj/WebCore.vcproj:

10:58 AM Changeset in webkit [18529] by weinig

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Anders.

Testcase for ​http://bugs.webkit.org/show_bug.cgi?id=12072

• fast/forms/select-align-expected.checksum: Added.
• fast/forms/select-align-expected.png: Added.
• fast/forms/select-align-expected.txt: Added.
• fast/forms/select-align.html: Added.

WebCore:

Reviewed by Anders.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12072
select with align attribute should not affect contained text

Don't map align for select elements.

Test: fast/forms/select-align.html

• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):

10:04 AM Changeset in webkit [18528] by weinig

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Mitz.

Testcase for ​http://bugs.webkit.org/show_bug.cgi?id=12071

• fast/forms/button-align-expected.checksum: Added.
• fast/forms/button-align-expected.png: Added.
• fast/forms/button-align-expected.txt: Added.
• fast/forms/button-align.html: Added.

WebCore:

Reviewed by Mitz.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12071
button with align attribute should not affect contained text

Don't map align for button elements.

Test: fast/forms/button-align.html

• html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::parseMappedAttribute):

9:41 AM Changeset in webkit [18527] by weinig

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Mitz and Anders.

Testcases for ​http://bugs.webkit.org/show_bug.cgi?id=7075

• fast/forms/textarea-align-expected.checksum: Added.
• fast/forms/textarea-align-expected.png: Added.
• fast/forms/textarea-align-expected.txt: Added.
• fast/forms/textarea-align.html: Added.

WebCore:

Reviewed by Mitz and Anders.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=7075
textarea with align=right should not cause contained text to
be right-justified

Don't map align for textarea elements.

Test: fast/forms/textarea-align.html

• html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):

9:39 AM Changeset in webkit [18526] by darin

• 3 edits in trunk/JavaScriptCore

• minor tweak (hope this doesn't re-break Windows)

• pcre/pcre_compile.c: Removed use of const pcre_uchar const * -- Mitz probably meant const pcre_uchar *const, but I think we can do without the explicit const here.

• pcre/pcre_internal.h: Re-enabled warning C4114.

9:22 AM Changeset in webkit [18525] by ddkilzer

• 3 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by NOBODY (Windows build fix).

The MSVC compiler requires variables to be declared at the top of the enclosing block in C source.

Disable this warning to prevent MSVC from complaining about the 'const pcre_uchar const *' type:
warning C4114: same type qualifier used more than once

• pcre/pcre_compile.c: (pcre_compile2): Moved variable declarations to top of their respective enclosing blocks.
• pcre/pcre_internal.h: Added pragma to disable compiler warning.

9:08 AM Changeset in webkit [18524] by eseidel

• 4 edits in trunk/WebCore

2007-01-02 Eric Seidel <​eric@webkit.org>

Reviewed by mitz.

Implement SVGSVGElement::deselectAll()

• ksvg2/svg/SVGAnimationElement.h: (WebCore::SVGAnimationElement::updateLastValueWithCurrent): add comment
• ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::deselectAll): implement (WebCore::SVGSVGElement::setCurrentTime): add comment about bug
• ksvg2/svg/SVGSVGElement.idl: remove unnecessary comment

6:12 AM Changeset in webkit [18523] by weinig

• 4 edits
  8 adds in trunk

LayoutTests:

Reviewed by Darin.

Testcases for ​http://bugs.webkit.org/show_bug.cgi?id=3360

• fast/forms/input-align-expected.checksum: Added.
• fast/forms/input-align-expected.png: Added.
• fast/forms/input-align-expected.txt: Added.
• fast/forms/input-align-image-expected.checksum: Added.
• fast/forms/input-align-image-expected.png: Added.
• fast/forms/input-align-image-expected.txt: Added.
• fast/forms/input-align-image.html: Added.
• fast/forms/input-align.html: Added.

WebCore:

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=3360
align="right" on a text input aligns the input field to the right

Don't map align if input type is not 'image'.

Test: fast/forms/input-align-image.html
Test: fast/forms/input-align.html

• WebCore.xcodeproj/project.pbxproj:
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::mapToEntry): (WebCore::HTMLInputElement::parseMappedAttribute):

5:46 AM Changeset in webkit [18522] by zimmermann

• 1 edit
  66 adds in trunk/LayoutTests

Rubber stamped by Rob.
Adding all carto.net SVG/JS examples. Highlights some nifty bugs.

4:09 AM Changeset in webkit [18521] by zimmermann

• 79 edits
  32 adds in trunk

Reviewed by Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12013
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11980
Partly fixes: ​http://bugs.webkit.org/show_bug.cgi?id=6000 (pattern/gradient recursion works now)

Rewrite gradient & pattern code, fixing all known bugs & regressions.

2:13 AM Changeset in webkit [18520] by zack

• 2 edits in trunk/WebCore

fix compile for svg as well (filenames are case-sensitive)

2:05 AM Changeset in webkit [18519] by zack

• 7 edits in trunk

compilation fixes for the Qt port

1:03 AM Changeset in webkit [18518] by eseidel

• 18 edits
  2 adds in trunk/WebCore

2007-01-02 Eric Seidel <​eric@webkit.org>

Reviewed by rwlbuis.

Refactor more animation code for better sharing between SVGAnimate*Element classes.

• replace handleEndCondition with resetValues() and updateLastValueWithCurrent()
• move initialTransform() function down into SVGTimer (eventually to AnimationCompositor) Add non-functional (only parses) SVGAnimateMotionElement Improve precision of getPointAtLength calculations and add support for "getNormalAtLength" functionality (needed for rotate='auto' support in animateMotion) Move add getSegmentAtLength functionality to SVGPathSegList, move toPathData into SVGPathSegList as well. Add SVGAnimationElement::hasValidTarget() for future better/simpler ASSERT checking change transformMatrix() to currentTransform() to match AffineTransform class name

• WebCore.xcodeproj/project.pbxproj:
• ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::animationsByElement): (WebCore::baseValueTransformList): (WebCore::SVGTimer::applyAnimations):
• ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::updateLastValueWithCurrent):
• ksvg2/svg/SVGAnimateColorElement.h:
• ksvg2/svg/SVGAnimateMotionElement.cpp: Added. (WebCore::SVGAnimateMotionElement::SVGAnimateMotionElement): (WebCore::SVGAnimateMotionElement::~SVGAnimateMotionElement): (WebCore::SVGAnimateMotionElement::hasValidTarget): added. (WebCore::SVGAnimateMotionElement::parseMappedAttribute): (WebCore::SVGAnimateMotionElement::animationPath): fetch path from <mpath> or d attribute (WebCore::SVGAnimateMotionElement::updateCurrentValue): (WebCore::SVGAnimateMotionElement::handleStartCondition): (WebCore::SVGAnimateMotionElement::applyAnimationToValue):
• ksvg2/svg/SVGAnimateMotionElement.h: Added. (WebCore::SVGAnimateMotionElement::contextElement): (WebCore::SVGAnimateMotionElement::):
• ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::hasValidTarget): added. (WebCore::SVGAnimateTransformElement::storeInitialValue): (WebCore::SVGAnimateTransformElement::updateCurrentValue): (WebCore::SVGAnimateTransformElement::updateLastValueWithCurrent): (WebCore::SVGAnimateTransformElement::applyAnimationToValue): (WebCore::SVGAnimateTransformElement::currentTransform):
• ksvg2/svg/SVGAnimateTransformElement.h:
• ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::hasValidTarget): added. (WebCore::SVGAnimationElement::parseMappedAttribute): (WebCore::SVGAnimationElement::isAdditive): (WebCore::SVGAnimationElement::isAccumulated): (WebCore::SVGAnimationElement::handleTimerEvent):
• ksvg2/svg/SVGAnimationElement.h: (WebCore::SVGAnimationElement::updateLastValueWithCurrent): (WebCore::SVGAnimationElement::resetValues):
• ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::getPointAtLength): (WebCore::SVGPathElement::getPathSegAtLength): (WebCore::SVGPathElement::parseMappedAttribute): (WebCore::SVGPathElement::toPathData):
• ksvg2/svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::getPathSegAtLength): added. (WebCore::SVGPathSegList::toPathData): added.
• ksvg2/svg/SVGPathSegList.h:
• ksvg2/svg/svgtags.in: add animateMotion
• platform/graphics/Path.cpp: (WebCore::pathLengthApplierFunction): add support for TraversalNormalAngleAtLength
• platform/graphics/PathTraversalState.cpp: (WebCore::curveLength): support higher precision pointAtLength calculations, and add normalAtLength support (WebCore::PathTraversalState::quadraticBezierTo): (WebCore::PathTraversalState::cubicBezierTo):
• platform/graphics/PathTraversalState.h: (WebCore::PathTraversalState::): add TraversalNormalAngleAtLength mode

Jan 1, 2007:

9:13 PM Changeset in webkit [18517] by ddkilzer

• 8 edits in trunk

JavaScriptCore:

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11849 REGRESSION (r18182): Google Calendar is broken (a regular expression containing a null character is not parsed correctly)

Modified pcre_compile() (and the functions that it calls) to work with patterns
containing null characters.

Covered by JavaScriptCore tests ecma_3/RegExp/octal-002.js and ecma_3/RegExp/regress-85721.js

• kjs/regexp.cpp: (KJS::RegExp::RegExp): Changed to not null-terminate the pattern string and instead pass its length to pcre_compile.
• pcre/pcre.h:
• pcre/pcre_compile.c: (check_escape): (get_ucp): (is_counted_repeat): (check_posix_syntax): (compile_branch): (compile_regex): (pcre_compile): Added a parameter specifying the length of the pattern, which is no longer required to be null-terminated and may contain null characters. (pcre_compile2):
• pcre/pcre_internal.h:
• tests/mozilla/expected.html: Updated for the two tests that this patch fixes. Also updated failing results for ecma_3/RegExp/regress-100199.js which were not updated after bug 6257 was fixed.

WebCore:

Reviewed by Darin.

• WebCore changes for ​http://bugs.webkit.org/show_bug.cgi?id=11849 REGRESSION (r18182): Google Calendar is broken (a regular expression containing a null character is not parsed correctly)

• platform/RegularExpression.cpp: (WebCore::RegularExpression::Private::compile): Changed to not null-terminate the pattern string and instead pass its length to pcre_compile.

8:37 PM Changeset in webkit [18516] by ddkilzer

• 5 edits
  4 adds in trunk

LayoutTests:

Reviewed by Darin.

• repaint test for ​http://bugs.webkit.org/show_bug.cgi?id=11359 Incomplete repaint of table cell's collapsed border when changing only the cell

• fast/repaint/table-cell-collapsed-border-expected.checksum: Added.
• fast/repaint/table-cell-collapsed-border-expected.png: Added.
• fast/repaint/table-cell-collapsed-border-expected.txt: Added.
• fast/repaint/table-cell-collapsed-border.html: Added.

WebCore:

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11359 Incomplete repaint of table cell's collapsed border when changing only the cell

Test: fast/repaint/table-cell-collapsed-border.html

• rendering/RenderTable.h: Added needsSectionRecalc() accessor.
• rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::getAbsoluteRepaintRect): Overloaded to add the outer half of any collapsed borders. This function checks the cell's borders' widths but also the widths of the adjoining cells' borders, since they can contribute to the length of this cell's borders perpendicular to them, making such a border overflow the cell in both dimensions. (WebCore::RenderTableCell::borderLeft): Split the collapsing borders case off to borderHalfLeft(). (WebCore::RenderTableCell::borderRight): Ditto. (WebCore::RenderTableCell::borderTop): Ditto. (WebCore::RenderTableCell::borderBottom): Ditto. (WebCore::RenderTableCell::borderHalfLeft): Added. Takes an 'outer' boolean parameter. When true, this function returns the width of the part of the border that is outside the cell (different from the inner width when the total width is odd). (WebCore::RenderTableCell::borderHalfRight): Ditto. (WebCore::RenderTableCell::borderHalfTop): Ditto. (WebCore::RenderTableCell::borderHalfBottom): Ditto.
• rendering/RenderTableCell.h:

8:27 PM Changeset in webkit [18515] by ddkilzer

• 4 edits in trunk/WebCore

WebCore:

WebCore.vcproj change reviewed by Darin. Additional build files updated by ddkilzer.

• CMakeLists.txt: Removed RenderLineEdit.cpp.
• WebCore.vcproj/WebCore/WebCore.vcproj: Removed RenderLineEdit.cpp and RenderLineEdit.h.
• WebCoreSources.bkl: Removed RenderLineEdit.cpp.

8:19 PM Changeset in webkit [18514] by ddkilzer

• 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12057 REGRESSION: JavaScript Date Is One Day In The Future in GMT time zone

Because Mac OS X returns geographically and historically accurate time zone information,
converting Jan 02, 1970 12:00:00 AM to local time then subtracting 24 hours did not work
in GMT (London - England) since it was in BST (+0100) all year in 1970[1]. Instead, the
UTC offset is calculated by converting Jan 01, 2000 12:00:00 AM to local time then
subtracting that from the same date in UTC.

[1] ​http://en.wikipedia.org/wiki/British_Summer_Time

• kjs/DateMath.cpp: (KJS::getUTCOffset): Updated UTC offset calculation. (KJS::getDSTOffset): Improved comment.

8:13 PM Changeset in webkit [18513] by ddkilzer

• 4 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12023
svn-create-patch and friends should handle moved/copied files

• Scripts/svn-apply: Identify copied files and handle those before all other patches.
• Scripts/svn-create-patch: Generate patches with subtle changes for copied files. (findMimeType($)): Added. (findModificationTime($)): Added. (findSourceFileAndRevision($)): Added. (generateDiff($$$)): Changed to use svn stat instead of svn diff. (isBinaryMimeType($)): Added. (manufacturePatchForAdditionWithHistory($$)): Added.
• Scripts/svn-unapply: Identify copied files and handle those after unapplying all other patches.

6:27 PM Changeset in webkit [18512] by darin

• 2 edits in trunk/WebKitSite

• quality/bugzilla.html: Fix a lingering reference to opendarwin.org.

6:03 PM Changeset in webkit [18511] by ddkilzer

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Mark Rowe.

• pixel test for ​http://bugs.webkit.org/show_bug.cgi?id=12042 Assertion failure in WebCore::RenderObject::drawBorder

• fast/borders/outline-offset-min-assert-expected.checksum: Added.
• fast/borders/outline-offset-min-assert-expected.png: Added.
• fast/borders/outline-offset-min-assert-expected.txt: Added.
• fast/borders/outline-offset-min-assert.html: Added.

WebCore:

Reviewed by Mark Rowe.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12042 Assertion failure in WebCore::RenderObject::drawBorder

Test: fast/borders/outline-offset-min-assert.html

• rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline): Bail out if the width or height is smaller than twice the outline inset.

5:42 PM Changeset in webkit [18510] by bdash

• 3 edits
  2 adds in trunk

2007-01-01 Mark Rowe <​bdash@webkit.org>

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=12061
Bug 12061: Crash in WebCore::Shared<WebCore::StringImpl>::deref

• rendering/RenderStyle.cpp: (WebCore::ContentData::clearContent): Reset _contentType to CONTENT_NONE to ensure repeated calls to clearContent do not result in derefing deallocated members.

2007-01-01 Mark Rowe <​bdash@webkit.org>

Reviewed by Eric.

Layout test for ​http://bugs.webkit.org/show_bug.cgi?id=12061
Bug 12061: Crash in WebCore::Shared<WebCore::StringImpl>::deref

• fast/css-generated-content/reset-content-to-initial-expected.txt: Added.
• fast/css-generated-content/reset-content-to-initial.html: Added.

12:48 PM Changeset in webkit [18509] by eseidel

• 10 edits in trunk/WebCore

2007-01-01 Eric Seidel <​eric@webkit.org>

Reviewed by andersca.

Begin pushing code down into SVGAnimateElement

• ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::handleStartCondition):
• ksvg2/svg/SVGAnimateColorElement.h:
• ksvg2/svg/SVGAnimateElement.h: (WebCore::SVGAnimateElement::updateCurrentValue): (WebCore::SVGAnimateElement::handleStartCondition): (WebCore::SVGAnimateElement::handleEndCondition):
• ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::handleStartCondition):
• ksvg2/svg/SVGAnimateTransformElement.h:
• ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::handleTimerEvent):
• ksvg2/svg/SVGAnimationElement.h:
• ksvg2/svg/SVGSetElement.cpp: (WebCore::SVGSetElement::updateCurrentValue): (WebCore::SVGSetElement::handleStartCondition): (WebCore::SVGSetElement::handleEndCondition):
• ksvg2/svg/SVGSetElement.h:

11:40 AM Changeset in webkit [18508] by eseidel

• 4 edits in trunk/WebCore

2007-01-01 Eric Seidel <​eric@webkit.org>

Reviewed by andersca.

Add static function SVGColor::colorFromRGBColorString to allow parsing Colors from SVG color strings w/o creating an SVGColor object.

• ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::storeInitialValue): use colorFromRGBColorString (WebCore::SVGAnimateColorElement::startIfNecessary): use colorFromRGBColorString
• ksvg2/svg/SVGColor.cpp: (WebCore::SVGColor::setRGBColor): use colorFromRGBColorString (WebCore::parseNumberOrPercent): new color parsing helper (WebCore::SVGColor::colorFromRGBColorString): cleaned up version of setRGBColor parsing logic
• ksvg2/svg/SVGColor.h:

10:58 AM Changeset in webkit [18507] by eseidel

• 5 edits in trunk/WebCore

2007-01-01 Eric Seidel <​eric@webkit.org>

Reviewed by andersca.

Split handleTimerEvent logic into separate functions in preparation for moving down into SVGAnimationElement

• ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::storeInitialValue): (WebCore::SVGAnimateColorElement::resetValues): (WebCore::SVGAnimateColorElement::updateCurrentValue): (WebCore::SVGAnimateColorElement::startIfNecessary): (WebCore::SVGAnimateColorElement::handleEndCondition): (WebCore::SVGAnimateColorElement::handleTimerEvent):
• ksvg2/svg/SVGAnimateColorElement.h:
• ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::storeInitialValue): (WebCore::SVGAnimateTransformElement::resetValues): (WebCore::SVGAnimateTransformElement::updateCurrentValue): (WebCore::SVGAnimateTransformElement::startIfNecessary): (WebCore::SVGAnimateTransformElement::handleEndCondition): (WebCore::SVGAnimateTransformElement::handleTimerEvent):
• ksvg2/svg/SVGAnimateTransformElement.h:

10:56 AM Changeset in webkit [18506] by rwlbuis

• 3 edits in trunk/WebCore

Reviewed by Eric.

Simple cleanups, removing unused color table, copyright and include guard fixes.

10:20 AM Changeset in webkit [18505] by eseidel

• 1 edit in trunk/WebCore/ChangeLog

correct reviewer, was andersca not mitz

10:19 AM Changeset in webkit [18504] by eseidel

• 7 edits in trunk/WebCore

2007-01-01 Eric Seidel <​eric@eseidel.com>

Reviewed by mitz.

More animation code cleanup.

• ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::handleTimerEvent):
• ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::handleTimerEvent):
• ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::SVGAnimationElement): (WebCore::SVGAnimationElement::connectedToTimer): (WebCore::SVGAnimationElement::connectTimer): (WebCore::SVGAnimationElement::disconnectTimer): (WebCore::SVGAnimationElement::updateForElapsedSeconds):
• ksvg2/svg/SVGAnimationElement.h:
• ksvg2/svg/SVGSetElement.cpp: (WebCore::SVGSetElement::handleTimerEvent):
• ksvg2/svg/SVGSetElement.h:

9:53 AM Changeset in webkit [18503] by eseidel

• 3 edits in trunk/WebCore

2007-01-01 Eric Seidel <​eric@eseidel.com>

Reviewed by mitz.

More clean-up to animation code.

• ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::handleTimerEvent):
• ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::handleTimerEvent): (WebCore::SVGAnimateTransformElement::parseTransformValue): (WebCore::SVGAnimateTransformElement::calculateRotationFromMatrix):

12:12 AM Changeset in webkit [18502] by eseidel

• 12 edits in trunk/WebCore

2007-01-01 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

Begin pushing more animation logic out of SVGTimer and into the SVGAnimate* classes.

• ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::animationsByElement): add comment (WebCore::SVGTimer::notifyAll): push logic into SVGAnimte* classes
• ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::applyAnimationToValue): added.
• ksvg2/svg/SVGAnimateColorElement.h:
• ksvg2/svg/SVGAnimateElement.cpp:
• ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::applyAnimationToValue): added.
• ksvg2/svg/SVGAnimateTransformElement.h:
• ksvg2/svg/SVGAnimationElement.cpp: (WebCore::calculateTimePercentage): logic moved from SVGTimer (WebCore::SVGAnimationElement::updateForElapsedSeconds): logic moved from SVGTimer
• ksvg2/svg/SVGAnimationElement.h:
• ksvg2/svg/SVGTransformList.cpp: (SVGTransformList::concatenate): fixed spacing