Timeline



Jan 11, 2007:

10:46 PM Changeset in webkit [18798] by hyatt
  • 3 edits in trunk/WebCore

Fix for bug 8705, readonly text fields should not get focus rings. Add a rule to that effect to
html4.css and then also add readonly as a special case for style sharing so that we can retain the
performance boost from sharing styles on inputs.

Reviewed by bdash

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::checkOneSelector):
  • css/html4.css:
10:28 PM Changeset in webkit [18797] by hyatt
  • 3 edits in trunk/LayoutTests/fast/overflow

Update overflow layout test results after autoscroll fix.

10:25 PM Changeset in webkit [18796] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 11595. Autoscrolling of layers didn't really work at all unless the layer was coincidentally
in the root layer's coordinate space. The event point was an absolute position within the document, but
the layer's rect was only local coords. This patch makes sure to use absolute bounds for the layer
when comparing it with the point.

This is covered by the scrollRevealButton test case already in the tree... the results change to be more
correct.

Reviewed by ggaren

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):
10:25 PM Changeset in webkit [18795] by ggaren
  • 9 edits in trunk/JavaScriptCore

RS by Brady Eidson.


Rolling out r18786 because it caused leaks.

9:50 PM Changeset in webkit [22759] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-01-11 Steve Falkenburg <​sfalken@apple.com>

  • WebKit.vcproj/WebKit.make:
9:33 PM Changeset in webkit [18794] by beidson
  • 9 edits in trunk/WebCore

Reviewed by Oliver

-Move more HTTP Auth handling towards ResourceHandle, away from ResourceHandleClient
-Make more of ResourceLoader cross-platform

  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::releaseResources): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::receivedCancellation):
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::willStopBufferingData): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::willCacheResponse):
  • loader/mac/ResourceLoaderMac.mm:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willStopBufferingData):
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::didCancelAuthenticationChallenge): (WebCore::ResourceHandle::receivedCredential): (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandle::receivedCancellation): (WebCore::ResourceHandle::clearAuthentication): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):


8:48 PM Changeset in webkit [18793] by hyatt
  • 2 edits in trunk/WebCore

A hit test is returning a null renderer. Make sure to null-check it in the autoscroll code.
This really shouldn't happen, but I'm just going to bullet proof for now given that it's happening
on the front page of yahoo.com!

Reviewed by mark

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll):
8:37 PM Changeset in webkit [18792] by hyatt
  • 3 edits
    5 adds in trunk

LayoutTests:

Force column-width to parse in strict mode so that there is no confusion when it is used in the columns
shorthand (it can be mistaken for column-count otherwise).

Reviewed by Mark


  • fast/multicol/columns-shorthand-parsing-expected.checksum: Added.
  • fast/multicol/columns-shorthand-parsing-expected.png: Added.
  • fast/multicol/columns-shorthand-parsing-expected.txt: Added.
  • fast/multicol/columns-shorthand-parsing.html: Added.

WebCore:

Force column-width to parse in strict mode so that there is no confusion when it is used in the columns
shorthand (it can be mistaken for column-count otherwise).

Reviewed by Mark

fast/multicol/columns-shorthand-parsing.html

  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
8:29 PM Changeset in webkit [18791] by bdash
  • 27 edits in trunk

2007-01-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

  • rendering/RenderTable.cpp: (WebCore::resetSectionPointerIfNotBefore): Added this function to help with checking if a section being inserted is the going to be the first of its kind. (WebCore::RenderTable::addChild): Changed to maintain the pointers to the header, the footer, the caption and the first table body properly when objects are inserted in the middle. Also changed to make the first caption win over any other captions. This matches Firefox and what already used to happen when a section recalc took place. (WebCore::RenderTable::layout): Changed to use sectionBelow() for iterating over the sections from top to bottom. (WebCore::RenderTable::calcBorderLeft): Changed to really find the section containing the first row. (WebCore::RenderTable::calcBorderRight): Ditto. (WebCore::RenderTable::sectionAbove): Fixed a bug when the last section was skipped if the input was the footer. (WebCore::RenderTable::sectionBelow): Ditto for "first" and "header" respectively.

2007-01-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Collapsed borders changed in the "marvin" tests, as the footer cells now
collapse correctly with the last row of the body. Visual differences not
captured by the pixel results since they occurred below 600px.

The "other" test has changed since in a table with multiple captions,
now the first one wins. No visual difference in this case since both captions
are the same.

  • tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • tables/mozilla/marvin/backgr_position-table-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
  • tables/mozilla_expected_failures/other/test4-expected.txt:
8:28 PM Changeset in webkit [18790] by bdash
  • 13 edits in trunk

2007-01-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Fixed fixed table layout. Implemented an algorithm that matches the behavior
of Firefox, up to rounding errors.

Fixes three existing table tests.

  • rendering/FixedTableLayout.cpp: Undid accidental search-and-replace of "width" to "m_width" in the comments. Removed an outdated comment, since WebKit no longer honors table-layout:fixed for variable-width tables. (WebCore::FixedTableLayout::calcWidthArray): Fixed the logic that finds the first row. Changed to divide the width specified for a cell that spans multiple columns between the columns rather than assign its entire width to each column. (WebCore::FixedTableLayout::calcMinMaxWidth): (WebCore::FixedTableLayout::layout): Implemented the behavior observed in Firefox.
  • rendering/FixedTableLayout.h:

2007-01-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

  • tables/mozilla/bugs/bug157890-expected.checksum:
  • tables/mozilla/bugs/bug157890-expected.png:
  • tables/mozilla/bugs/bug157890-expected.txt:
  • tables/mozilla/bugs/bug44505-expected.checksum:
  • tables/mozilla/bugs/bug44505-expected.png:
  • tables/mozilla/bugs/bug44505-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug7243-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug7243-expected.png:
  • tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
8:25 PM Changeset in webkit [18789] by bdash
  • 2 edits in trunk/WebKitTools

2007-01-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Changed the ImageDiff tool not to use CoreImage filters.

  • DumpRenderTree/ImageDiff.m: (main): (createImageFromStdin): (compareImages): (getDifferenceBitmap):
8:24 PM Changeset in webkit [18788] by bdash
  • 6 edits
    4 adds in trunk

2007-01-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Test: fast/block/basic/fieldset-stretch-to-legend.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcWidth): Stretch to the minimum intrinsic width if the object requires it. (WebCore::RenderBox::calcHorizontalMargins): Some style cleanup. (WebCore::RenderBox::calcAbsoluteHorizontal): Stretch to the minimum intrinsic width if the object requires it.
  • rendering/RenderBox.h: (WebCore::RenderBox::stretchesToMinIntrinsicWidth): Added. Returns false.
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::calcMinMaxWidth): Overloaded RenderBlock's implementation to ensure that the legend's will fit in the fieldset's minimum intrinsic width. (WebCore::RenderFieldset::findLegend): Made const. (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintBorderMinusLegend): Fixed the behavior when the legend does overflow the fieldset. This is the part of the fix that prevents the assertion failure. If the legend intersects with a corner of the fieldset's border, that corner will not be painted, even if it is not completely occluded. This edge case can be improved with clipping in the future. Added FIXME to implement border-radius.
  • rendering/RenderFieldset.h: (WebCore::RenderFieldset::stretchesToMinIntrinsicWidth): Overloaded to return true.

2007-01-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

  • fast/block/basic/fieldset-stretch-to-legend-expected.checksum: Added.
  • fast/block/basic/fieldset-stretch-to-legend-expected.png: Added.
  • fast/block/basic/fieldset-stretch-to-legend-expected.txt: Added.
  • fast/block/basic/fieldset-stretch-to-legend.html: Added.
6:53 PM Changeset in webkit [22758] by andersca
  • 2 edits in branches/WindowsMerge/WebCore
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::cfURLResponse): Add getter that I forgot to commit.
5:14 PM Changeset in webkit [22757] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

5:05 PM Changeset in webkit [18787] by sfalken
  • 1 copy in tags/Safari-521.32.11b

New tag.

4:46 PM Changeset in webkit [18786] by ggaren
  • 8 edits in trunk/JavaScriptCore

Reviewed by Anders Carlsson.

Even more cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)


Layout tests pass.


Renames:

ReferencesSet | ProtectCounts => ProtectCountSet (because it's a typename for a set of GC protect counts)
ReferencesByRootMap => RootObjectMap (because RootObjectToProtectCountSetMap would have been confusing)
pv => protectedValues
rootObjectForImp => getRootObject (overloaded for JSObject* and Interpreter*)
rootObjectForInterpreter => getRootObject (ditto)
findReferenceSet => getProtectCountSet
imp => jsObject


(KJS::Bindings::getRootObjectMap): Changed to take advantage of built-in
facility for initializing static variables.

(KJS::Bindings::getProtectCountSet):
(KJS::Bindings::destroyProtectCountSet): Added. Helps encapsulate the fact
that getting a ProtectCountSet entails adding a RootObject to a hash table,
and destroying one entails the reverse.

(KJS::Bindings::getRootObject): Removed spurious NULL check.


(KJS::Bindings::findReferenceSet): Renamed. Changed to use getRootObject()
instead of iterating on its own.

(KJS::Bindings::addNativeReference): Changed to use an early return instead
of indenting the whole function.
(KJS::Bindings::removeNativeReference): Ditto.

3:35 PM Changeset in webkit [22756] by sfalken
  • 4 edits in branches/WindowsMerge/WebKitWin

2007-01-11 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou.

Implement "Make Text Normal Size".

  • WebView.cpp: (WebView::canMakeTextStandardSize): Added (WebView::makeTextStandardSize): Added (WebView::toggleContinuousSpellChecking): Added (WebView::toggleSmartInsertDelete): Added
3:14 PM Changeset in webkit [18785] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Build Fix Karma

I broke the release build (debug build passed)

  • platform/network/mac/AuthenticationMac.mm: (WebCore::core):
3:04 PM Changeset in webkit [22755] by beidson
  • 5 edits in branches/WindowsMerge

Make it build again after my HTTP Auth opensource checkin

2:35 PM Changeset in webkit [18784] by beidson
  • 1 edit in trunk/WebCore/platform/network/mac/AuthenticationMac.mm

Blind build fix attempt

2:20 PM Changeset in webkit [18783] by beidson
  • 23 edits
    8 adds in trunk

WebCore:

Reviewed by Anders

Rewrites HTTP Authentication setting up a more platform-independent structure

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didReceiveAuthenticationChallenge): (WebCore::FrameLoader::didCancelAuthenticationChallenge):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::didCancel):
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::receivedCredential): (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential): (WebCore::ResourceLoader::receivedCancellation):
  • loader/mac/FrameLoaderMac.mm:
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::receivedCredential): (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential): (WebCore::ResourceLoader::receivedCancellation):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willSendRequest): (WebCore::ResourceHandleClient::didReceiveAuthenticationChallenge): (WebCore::ResourceHandleClient::didCancelAuthenticationChallenge): (WebCore::ResourceHandleClient::receivedCredential): (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandleClient::receivedCancellation): (WebCore::ResourceHandleClient::willCacheResponse):
  • platform/network/ResourceResponse.h: (WebCore::operator!=):
  • platform/network/URLAuthenticationChallenge.cpp: Added. (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge): (WebCore::URLAuthenticationChallenge::previousFailureCount): (WebCore::URLAuthenticationChallenge::proposedCredential): (WebCore::URLAuthenticationChallenge::protectionSpace): (WebCore::URLAuthenticationChallenge::failureResponse): (WebCore::URLAuthenticationChallenge::error): (WebCore::URLAuthenticationChallenge::isNull): (WebCore::URLAuthenticationChallenge::nullify): (WebCore::operator==): (WebCore::operator!=):
  • platform/network/URLAuthenticationChallenge.h: Added. (WebCore::URLAuthenticationChallenge::sender): (WebCore::URLAuthenticationChallenge::nsURLAuthenticationChallenge):
  • platform/network/URLCredential.cpp: Added. (WebCore::URLCredential::URLCredential): (WebCore::URLCredential::user): (WebCore::URLCredential::password): (WebCore::URLCredential::hasPassword): (WebCore::URLCredential::persistence): (WebCore::operator==):
  • platform/network/URLCredential.h: Added. (WebCore::): (WebCore::operator!=):
  • platform/network/URLProtectionSpace.cpp: Added. (WebCore::URLProtectionSpace::URLProtectionSpace): (WebCore::URLProtectionSpace::host): (WebCore::URLProtectionSpace::port): (WebCore::URLProtectionSpace::serverType): (WebCore::URLProtectionSpace::realm): (WebCore::URLProtectionSpace::authenticationScheme): (WebCore::operator==):
  • platform/network/URLProtectionSpace.h: Added. (WebCore::): (WebCore::operator!=):
  • platform/network/mac/AuthenticationMac.h: Added.
  • platform/network/mac/AuthenticationMac.mm: Added. (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge): (WebCore::mac): (WebCore::core):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::operator==):

WebKit:

Reviewed by Anders

Rewrites HTTP Authentication setting up a more platform-independent structure

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
  • WebKit.xcodeproj/project.pbxproj:

WebKitQt:

Keep the fancy new FrameLoaderClientQt building with a small api change in WebCore
Yay for the loader on QT!

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidReceiveAuthenticationChallenge): (WebCore::FrameLoaderClientQt::dispatchDidCancelAuthenticationChallenge):
  • WebCoreSupport/FrameLoaderClientQt.h:
2:02 PM Changeset in webkit [18782] by ggaren
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Anders Carlsson.

Even more cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)


Layout tests pass.


Renames:

findRootObjectForNativeHandleFunction => createRootObject
FindRootObjectForNativeHandleFunctionPtr => CreateRootObjectFunction


Also removed unnecessary use of "Bindings::" prefix.

  • JavaScriptCore.exp:
  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::createNative): (JavaJSObject::convertValueToJObject): (JavaJSObject::convertJObjectToValue):
  • bindings/runtime_root.cpp: (KJS::Bindings::RootObject::setCreateRootObject):
  • bindings/runtime_root.h: (KJS::Bindings::RootObject::createRootObject):

WebCore:

Reviewed by Anders Carlsson.


Even more cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)


Layout tests pass.


Renames:

findRootObjectForNativeHandleFunction => createRootObject
FindRootObjectForNativeHandleFunctionPtr => createRootObjectFunction
rootForView => createRootObject
getInstanceForView => getPluginInstanceForWidget

  • page/mac/FrameMac.mm: (WebCore::FrameMac::getAppletInstanceForWidget): Put the NSView * in a void* variable named "nativeHandle" to be more explicit about the fact that JavaScript's "nativeHandle" is just an NSView *.

(WebCore::getPluginInstanceForWidget): This function now does the NSView *
fetching that its callers used to do.
(WebCore::FrameMac::getEmbedInstanceForWidget): Updated for rename.
(WebCore::FrameMac::getObjectInstanceForWidget): ditto

  • page/mac/WebCoreFrameBridge.mm: Killed the WebCoreBridgeInternal category, which was really more of a shmategory. (createRootObject): Removed rootObjectForView, folding it into its only caller, the similarly named rootForView. Renamed the pair to "createRootObject" because that's what they do.

(-[WebCoreFrameBridge init]): Updated for renames

1:52 PM Changeset in webkit [18781] by andersca
  • 1 edit in trunk/WebCore/loader/DocLoader.cpp

Get rid of garbage

1:47 PM Changeset in webkit [18780] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix crash on platforms that don't use the new loader yet.


  • loader/DocLoader.cpp: (WebCore::DocLoader::requestResource):
1:45 PM Changeset in webkit [18779] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adam.

  • fast/forms/select-type-ahead-non-latin-expected.txt: Added.
  • fast/forms/select-type-ahead-non-latin.html: Added.

WebCore:

Reviewed by Adam.

Test: fast/forms/select-type-ahead-non-latin.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler): Changed locale-specific isprint() condition to a Unicode isPrintableChar().
1:41 PM Changeset in webkit [18778] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by geoff


<rdar://problem/4889140>
GMail Editor: List creation fails in new message

  • editing/execCommand/insert-list-empty-div-expected.checksum: Added.
  • editing/execCommand/insert-list-empty-div-expected.png: Added.
  • editing/execCommand/insert-list-empty-div-expected.txt: Added.
  • editing/execCommand/insert-list-empty-div.html: Added.

WebCore:

Reviewed by geoff


<rdar://problem/4889140>
GMail Editor: List creation fails in new message

  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Inserting the list into an empty paragraph not held open by a br or a '\n', will invalidate start and end. Insert a placeholder and then recompute start and end.
1:15 PM Changeset in webkit [18777] by lars
  • 2 edits
    1 delete in trunk/WebCore

This one is not needed any longer neither.

1:04 PM Changeset in webkit [18776] by lars
  • 2 edits in trunk/WebKitTools

fix compilation of DumpRenderTree. Will hopefully
make the built bot happy :)

12:45 PM Changeset in webkit [18775] by lars
  • 2 edits
    1 delete in trunk/WebCore

remove now unused file.

12:33 PM Changeset in webkit [18774] by ddkilzer
  • 3 edits in trunk/WebCore

WebCore:

Reviewed by NOBODY (build fix).

  • loader/mac/FrameLoaderMac.mm: Removed import of LoaderNSURLRequestExtras.h.
  • loader/mac/SubresourceLoaderMac.mm: Ditto.
12:03 PM Changeset in webkit [18773] by staikos
  • 2 edits in trunk/WebCore

Fix compile

12:00 PM Changeset in webkit [22754] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::Editor::advanceToNextMisspelling):
11:53 AM Changeset in webkit [18772] by andersca
  • 8 edits in trunk/WebCore

Fix build.


  • dom/XMLTokenizer.cpp:
  • loader/CachedCSSStyleSheet.cpp:
  • loader/CachedImage.cpp:
  • loader/DocLoader.cpp:
  • loader/loader.cpp:
  • xml/XSLTProcessor.cpp:
  • xml/xmlhttprequest.cpp:
11:30 AM Changeset in webkit [18771] by andersca
  • 8 edits
    5 deletes in trunk/WebCore

Reviewed by Adam.

Loader cleanup, get rid of unused code.


  • WebCore.xcodeproj/project.pbxproj:
  • loader/CachedResource.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): (WebCore::DocLoader::checkCacheObjectStatus):
  • loader/DocLoader.h:
  • loader/LoaderFunctions.h: Removed.
  • loader/mac/CachedResourceMac.mm: Removed.
  • loader/mac/LoaderFunctionsMac.mm: Removed.
  • loader/mac/LoaderNSURLRequestExtras.h: Removed.
  • loader/mac/LoaderNSURLRequestExtras.m: Removed.
  • loader/mac/SubresourceLoaderMac.mm:
  • page/mac/WebCoreFrameBridge.mm:
  • platform/network/ResourceHandle.cpp:
10:25 AM Changeset in webkit [18770] by bdakin
  • 1 edit in trunk/WebCore/ChangeLog

Better Changelog.

10:19 AM Changeset in webkit [18769] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12135 REGRESSION:
<input> and <textarea> not focused on right click (4908884 in
Radar)

  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): Ask if we *have* swallowed the event instead of if we *haven't* when deciding to perform a selection.
8:42 AM Changeset in webkit [18768] by darin
  • 2 edits in trunk/WebCore

Reviewed by Anders.

  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): Added null check.
8:39 AM Changeset in webkit [18767] by darin
  • 2 edits in trunk/WebKit

Reviewed by Mitz.

  • WebView/WebDataSource.mm: (-[WebDataSource data]): Added null check.
6:55 AM Changeset in webkit [18766] by darin
  • 2 edits in trunk/WebCore
  • platform/CharacterNames.h: Oops! horizontalEllipsis != zeroWidthSpace!
4:34 AM Changeset in webkit [18765] by lars
  • 10 edits in trunk

Start using the loader in the Qt port.

4:23 AM Changeset in webkit [18764] by darin
  • 22 edits
    6 deletes in trunk

WebCore:

Reviewed by Hyatt.

  • removed a couple Mac bridging classes; put the code in WebKit instead
  • WebCore.exp: Updated for new WebKit uses.
  • WebCore.xcodeproj/project.pbxproj: Removed files.
  • bridge/mac/WebCoreEncodings.h: Removed.
  • bridge/mac/WebCoreEncodings.mm: Removed.
  • bridge/mac/WebMimeTypeRegistryBridge.h: Removed.
  • bridge/mac/WebMimeTypeRegistryBridge.mm: Removed.
  • platform/mac/WebNSAttributedStringExtras.h: Removed.
  • platform/mac/WebNSAttributedStringExtras.mm: Removed.
  • platform/mac/PasteboardMac.mm: (WebCore::stripAttachmentCharacters): Added. Moved code from WebNSAttributedStringExtras.mm, and fixed a garbage collection problem (a global with a plain old retain rather than HardRetain). (WebCore::Pasteboard::writeSelection): Updated to use stripAttachmentCharacters.
  • removed some DeprecatedCString use
  • loader/FrameLoader.cpp: Changed to use String more to eliminate use of DeprecatedCString here in the mailto form support. But maybe we can remove this entirely. Do we really care about mailto forms any more?
  • platform/Pasteboard.h: Removed unneeded DeprecatedCString declaration.
  • platform/PlatformString.h: Added replace that takes two strings.
  • platform/StringImpl.h: Ditto.
  • platform/StringImpl.cpp: (WebCore::StringImpl::replace): Ditto.
  • platform/TextStream.h: Remove DeprecatedCString case.
  • platform/TextStream.cpp: Ditto.
  • made a few more files use CharacterNames.h
  • platform/CharacterNames.h: Added some more character names and sorted alphabetically.
  • bridge/mac/WebCoreStringTruncator.mm: (centerTruncateToBuffer): Use character name from CharacterNames.h. (rightTruncateToBuffer): Ditto. (truncateString): Ditto.
  • platform/mac/FontMac.mm: (WebCore::addDirectionalOverride): Ditto.
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto.
  • rendering/bidi.cpp: (WebCore::RenderBlock::checkLinesForTextOverflow): Ditto.

WebKit:

Reviewed by Hyatt.

  • moved code from a couple WebCore bridging classes here instead
  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]): Use MimeTypeRegistry instead of WebMimeTypeRegistryBridge.
  • WebView/WebHTMLRepresentation.mm: (stringArray): Added. Helper to convert a HashSet to an NSArray. (concatenateArrays): Added. Helper to concatenate two NSArray objects. (+[WebHTMLRepresentation supportedMIMETypes]): Use MimeTypeRegistry instead of WebMimeTypeRegistryBridge. Also fix a potential GC problem by using a RetainPtr instead of a [retain] on a global variable. (+[WebHTMLRepresentation supportedNonImageMIMETypes]): Ditto. (+[WebHTMLRepresentation supportedImageMIMETypes]): Ditto.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _imageExistsAtPaths:]): Use MimeTypeRegistry instead of WebMimeTypeRegistryBridge. (-[WebHTMLView _documentFragmentWithPaths:]): Ditto.
  • WebView/WebView.mm: (+[WebView _decodeData:]): Moved code here from the old WebCoreEncodings class.
  • WebKit.xcodeproj/project.pbxproj: Let Xcode have its way with this file. Moved WebRenderNode into the appropriate group.
4:22 AM Changeset in webkit [18763] by hyatt
  • 2 edits in trunk/LayoutTests/fast/overflow

Land reverted layout tests for the two overflow cases. Although the new results were better, there are issues with what I did to achieve them, so for now going back to the (broken) old results.

4:21 AM Changeset in webkit [18762] by hyatt
  • 3 edits in trunk/WebCore

Fix two bugs in positionForCoordinates. (Make it work when you have a margin in between your border and
your first child block.)

Rewrite column rebalancing to have two modes: constrained and unconstrained. In unconstrained mode,
the system will dynamically rebalance as it loses space to breaks and compute a final intrinsic height
for the overall block. In constrained mode, columns flow into the fixed height block, and extra columns
spill out horizontally in the appropriate direction (RTL/LTR).

Make columns work properly with both LTR and RTL overflow blocks.

Initial column test suite coming soon now that the basic layout is right.

Reviewed by darin

  • rendering/RenderBlock.cpp: (WebCore:::RenderFlow): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::paintColumns): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::hitTestColumns): (WebCore::RenderBlock::positionForCoordinates): (WebCore::RenderBlock::availableWidth): (WebCore::RenderBlock::calcColumnWidth): (WebCore::RenderBlock::layoutColumns): (WebCore::RenderBlock::adjustPointToColumnContents):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::hasColumns):
3:13 AM Changeset in webkit [18761] by hyatt
  • 4 edits in trunk/LayoutTests/svg/custom

Fix SVG test cases.

12:51 AM Changeset in webkit [18760] by rwlbuis
  • 14 edits in trunk

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=12201
Fix image dragging issues with ​http://www.carto.net/papers/svg/gui/scrollbar/index.svg

Fix calculation of absolute transform so that viewport x,y
translation is always done, also when viewBox is set.

Jan 10, 2007:

11:48 PM Changeset in webkit [18759] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderBlock.cpp

Remove unused variable.

11:26 PM Changeset in webkit [18758] by hyatt
  • 30 edits in trunk/WebCore

Rework positionForCoordinates to be more efficient and to handle multi-column content. This entailed
adding a new field to HitTestResult called localPoint that cached the mouse coordinate in the coordinate
space of the renderer.

positionForCoordinates now takes local coordinates and so no longer needs to waste time recomputing
absolute positions over and over again.

Reviewed by darin

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject value]): (-[WebCoreAXObject doAXTextMarkerRangeForLine:]): (-[WebCoreAXObject doAXTextMarkerForPosition:]):
  • dom/Document.cpp: (WebCore::Document::prepareMouseEvent):
  • editing/SelectionController.cpp: (WebCore::SelectionController::contains):
  • editing/visible_units.cpp: (WebCore::previousLinePosition): (WebCore::nextLinePosition):
  • page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent): (WebCore::EventHandler::handleMousePressEventDoubleClick): (WebCore::EventHandler::handleMousePressEventTripleClick): (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::sendContextMenuEvent):
  • page/EventHandler.h:
  • page/MouseEventWithHitTestResults.cpp: (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
  • page/MouseEventWithHitTestResults.h: (WebCore::MouseEventWithHitTestResults::localPoint):
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge _visiblePositionForPoint:]):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint):
  • rendering/HitTestResult.h: (WebCore::HitTestResult::localPoint): (WebCore::HitTestResult::setLocalPoint):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestContents): (WebCore::RenderBlock::positionForCoordinates):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::positionForCoordinates):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::hitTestLines):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::positionForCoordinates):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): (WebCore::RenderLayer::hitTestLayer):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::updateHitTestResult):
  • rendering/RenderObject.h:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::positionForCoordinates):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint):
  • rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::nodeAtPoint): (WebCore::RootInlineBox::closestLeafChildForXPos):
  • rendering/RootInlineBox.h:
11:12 PM Changeset in webkit [18757] by staikos
  • 9 edits in trunk

Fix Qt build again

8:44 PM Changeset in webkit [18756] by bdash
  • 2 edits in trunk/WebKit

2007-01-10 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _resetCachedWebPreferences:]): (-[WebHTMLView setDataSource:]): Added a call to _resetCachedWebPreferences:. Added an assertion that the view is not closed, instead of reopening it. Reopening should not occur, now that <​http://bugs.webkit.org/show_bug.cgi?id=12087> is fixed.
6:24 PM Changeset in webkit [18755] by bdash
  • 11 edits
    12 adds in trunk

2007-01-10 Kirby White <​KWhiteRight@gmail.com>

Reviewed by Darin.

Fixes for ​http://bugs.webkit.org/show_bug.cgi?id=11841

Set image size to fit alt text when image or input-image element
has no src attribute, so that those images show their alt text instead
of showing nothing at all.

  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::attach):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::attach):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::setImageSizeForAltText): (WebCore::RenderImage::imageChanged):
  • rendering/RenderImage.h:

2007-01-10 Kirby White <​KWhiteRight@gmail.com>

Reviewed by Darin.

New and adjusted test cases for
​http://bugs.webkit.org/show_bug.cgi?id=11841

  • fast/dom/HTMLImageElement/image-alt-text-expected.checksum: Added.
  • fast/dom/HTMLImageElement/image-alt-text-expected.png: Added.
  • fast/dom/HTMLImageElement/image-alt-text-expected.txt: Added.
  • fast/dom/HTMLImageElement/image-alt-text.html: Added.
  • fast/dom/HTMLImageElement/resources/blue_rect.jpg: Added.
  • fast/dom/HTMLInputElement/input-image-alt-text-expected.checksum: Added.
  • fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
  • fast/dom/HTMLInputElement/input-image-alt-text-expected.txt: Added.
  • fast/dom/HTMLInputElement/input-image-alt-text.html: Added.
  • fast/dom/HTMLInputElement/resources/blue_rect.jpg: Added.
  • fast/forms/focus2-expected.txt:
  • fast/forms/focus2.html:
  • fast/forms/input-value-expected.checksum:
  • fast/forms/input-value-expected.png:
  • fast/forms/input-value-expected.txt:
6:18 PM Changeset in webkit [18754] by bdash
  • 2 edits in trunk/WebCore

2007-01-11 Mark Rowe <​mrowe@apple.com>

Build fix.

  • rendering/RenderView.cpp: (WebCore::RenderView::printing):
5:47 PM Changeset in webkit [22753] by sfalken
  • 3 edits in branches/WindowsMerge/WebCore

2007-01-10 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou.

<rdar://problem/4818840> Crash occurs after selecting Print Preview from under the File menu if no printer is selected


  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::computePageRects): removed calls to setupRootForPrinting
  • bridge/win/FrameWin.h: removed setupRootForPrinting
5:46 PM Changeset in webkit [18753] by bdash
  • 4 edits
    2 adds in trunk

2007-01-10 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/css/remove-shorthand.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::PropertyLonghand::PropertyLonghand): Added this structure containing a pointer to an array if properties and the array's length. (WebCore::PropertyLonghand::properties): (WebCore::PropertyLonghand::length): (WebCore::initShorthandMap): Initialize the mapping from shorthand properties to their dependent properties. (WebCore::CSSMutableStyleDeclaration::removeProperty): Changed to check if the property being removed is a shorthand, and if so, to remove all of its dependent properties. (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet): Added a 'notifyChanged' boolean parameter which controls whether this method calls setChanged() if it actually removes any property.
  • css/CSSMutableStyleDeclaration.h:

2007-01-10 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/css/remove-shorthand-expected.txt: Added.
  • fast/css/remove-shorthand.html: Added.
5:39 PM Changeset in webkit [18752] by sfalken
  • 9 edits in trunk/WebCore

2007-01-10 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Kevin.

Removed unnecessary printing state

5:23 PM Changeset in webkit [22752] by andersca
  • 3 edits in branches/WindowsMerge/WebKitWin

Another build fix.


  • WebContextMenuClient.cpp: (WebContextMenuClient::lookUpInDictionary):
  • WebContextMenuClient.h:
5:20 PM Changeset in webkit [22751] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Another build fix.


  • WebContextMenuClient.cpp: (WebContextMenuClient::lookUpInDictionary):
5:11 PM Changeset in webkit [22750] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Yet another build fix.


  • platform/win/TemporaryLinkStubs.cpp: (DocumentLoader::getResponseModifiedHeader):
4:56 PM Changeset in webkit [18751] by andersca
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

Get the Refresh header directly from the ResourceResponse.


  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad):
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::getResponseModifiedHeader):
4:17 PM Applications using WebKit edited by markmalone@mac.com
(diff)
4:16 PM Changeset in webkit [18750] by ggaren
  • 2 edits in trunk/WebKitSite
  • coding/coding-style.html: Fixed minor validation error.
4:10 PM Changeset in webkit [18749] by ggaren
  • 2 edits in trunk/WebKitSite

Reviewed by Beth Dakin.


Updated coding style guidelines to cover a lot of stuff previously absent.

  • coding/coding-style.html:
3:42 PM Changeset in webkit [22749] by bdakin
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by John.

Fix for <rdar://problem/4914258> REGRESSION: Search in Google now
operates on the current WebView instead of invoking Safari's
service

  • WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle): Do all of the work we used to do in WebCore over here in WebKit.
  • WebContextMenuClient.h:
3:32 PM Changeset in webkit [18748] by bdakin
  • 8 edits in trunk

WebCore:

Reviewed by John.

Fix for <rdar://problem/4914258> REGRESSION: Search in Google now
operates on the current WebView instead of invoking Safari's
service

  • page/ContextMenuClient.h: New call to the client to search in google.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Call into the client instead of forming a new url string and loading it.
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyContextMenuClient::searchWithGoogle): New call.

WebKit:

Reviewed by John.

Fix for <rdar://problem/4914258> REGRESSION: Search in Google now
operates on the current WebView instead of invoking Safari's
service

  • WebCoreSupport/WebContextMenuClient.h:
  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::searchWithGoogle): Call into WebView to search in Google.
  • WebView/WebViewInternal.h: Make _searchWithGoogleFromMenu available.
1:38 PM Changeset in webkit [18747] by aroben
  • 2 edits in trunk/WebCore

Rubberstamped by Darin.

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Pass 0 instead of an empty Event to FrameLoader::load and FrameLoader::urlSelected.
12:58 PM Changeset in webkit [22748] by andersca
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Another build fix.


  • bridge/win/FrameWin.h:
  • loader/win/FrameLoaderWin.cpp:

WebKitWin:

Build fix.


  • WebFrame.cpp: (WebFrame::dispatchDidFirstLayout):
  • WebFrame.h:
12:57 PM Changeset in webkit [18746] by andersca
  • 2 edits in trunk/WebCore
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::~ResourceLoader): Disable assertion (I forgot to do this even though I added the comment!)
12:53 PM Changeset in webkit [18745] by andersca
  • 2 edits in trunk/WebCore

Reviewed and landed by Anders.

Fix case in vcproj file (the GTK+ port uses the vcproj file).

  • WebCore.vcproj/WebCore/WebCore.vcproj:
12:12 PM Changeset in webkit [18744] by lars
  • 6 edits
    2 deletes in trunk/WebCore

Make the Qt build compile again after
the ResourceLoader was made platform
independent.

12:01 PM Changeset in webkit [22747] by andersca
  • 5 edits
    2 adds in branches/WindowsMerge/WebKitWin

Reviewed by Darin.

Add WebDocumentLoader. Implement some of the FrameLoaderClient methods.
Add a resourceRequest() getter to WebMutableURLRequest.


  • WebDocumentLoader.cpp: Added. (WebDocumentLoader::WebDocumentLoader): (WebDocumentLoader::setDataSource): (WebDocumentLoader::dataSource): (WebDocumentLoader::attachToFrame): (WebDocumentLoader::detachFromFrame):
  • WebDocumentLoader.h: Added.
  • WebFrame.cpp: (WebFrame::dispatchWillPerformClientRedirect): (WebFrame::dispatchDidChangeLocationWithinPage): (WebFrame::dispatchWillClose): (WebFrame::dispatchDidStartProvisionalLoad): (WebFrame::dispatchDidReceiveTitle): (WebFrame::dispatchDidCommitLoad): (WebFrame::dispatchDidFinishLoad): (WebFrame::updateGlobalHistoryForStandardLoad): (WebFrame::updateGlobalHistoryForReload): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction): (WebFrame::dispatchDidFailProvisionalLoad): (WebFrame::dispatchDidFailLoad):
  • WebKit.vcproj/WebKit.vcproj:
  • WebMutableURLRequest.cpp: (WebMutableURLRequest::resourceRequest):
  • WebMutableURLRequest.h:
11:59 AM Changeset in webkit [22746] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • platform/win/TemporaryLinkStubs.cpp: (ResourceHandle::setDefersLoading):
11:39 AM Changeset in webkit [18743] by andersca
  • 9 edits
    1 delete in trunk/WebCore

Rubber-stamped by Maciej.


Move most of ResourceLoader and MainResourceLoader into the platform-independent files.


  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didFinishLoad):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::~MainResourceLoader): (WebCore::MainResourceLoader::create): (WebCore::MainResourceLoader::receivedError): (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::interruptionForPolicyChangeError): (WebCore::MainResourceLoader::stopLoadingForPolicyChange): (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy): (WebCore::MainResourceLoader::continueAfterNavigationPolicy): (WebCore::MainResourceLoader::isPostOrRedirectAfterPost): (WebCore::MainResourceLoader::addData): (WebCore::MainResourceLoader::willSendRequest): (WebCore::shouldLoadAsEmptyDocument): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::callContinueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::didFail): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::load): (WebCore::MainResourceLoader::setDefersLoading):
  • loader/MainResourceLoader.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::releaseResources): (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::setDefersLoading): (WebCore::ResourceLoader::frameLoader): (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::clearResourceData): (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::willStopBufferingData): (WebCore::ResourceLoader::didFinishLoading): (WebCore::ResourceLoader::didFinishLoadingOnePart): (WebCore::ResourceLoader::didFail): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::response): (WebCore::ResourceLoader::cancelledError):
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::willStopBufferingData): (WebCore::ResourceLoader::setRequest):
  • loader/mac/FrameLoaderMac.mm:
  • loader/mac/MainResourceLoaderMac.mm: Removed.
  • loader/mac/ResourceLoaderMac.mm:
10:46 AM Changeset in webkit [18742] by lars
  • 2 edits
    5 adds
    5 deletes in trunk/WebCore

Move files to the correct location, and remove a few
unused methods from LoaderFunctionsQt.cpp

10:45 AM Changeset in webkit [22745] by andersca
  • 5 edits in branches/WindowsMerge/WebKitWin

Reviewed by Brady.

Make WebBackForwardList wrap a WebCore::BackForwardList. Add wrapper map to WebHistoryItem.

  • WebBackForwardList.cpp: (backForwardListWrappers): (WebBackForwardList::WebBackForwardList): (WebBackForwardList::~WebBackForwardList): (WebBackForwardList::createInstance): (WebBackForwardList::addItem): (WebBackForwardList::goBack): (WebBackForwardList::goForward): (WebBackForwardList::goToItem): (WebBackForwardList::backItem): (WebBackForwardList::currentItem): (WebBackForwardList::forwardItem): (WebBackForwardList::backListWithLimit): (WebBackForwardList::forwardListWithLimit): (WebBackForwardList::capacity): (WebBackForwardList::setCapacity): (WebBackForwardList::backListCount): (WebBackForwardList::forwardListCount): (WebBackForwardList::containsItem): (WebBackForwardList::itemAtIndex): (WebBackForwardList::setPageCacheSize): (WebBackForwardList::pageCacheSize): (WebBackForwardList::setDefaultPageCacheSizeIfNecessary):
  • WebBackForwardList.h:
  • WebHistoryItem.cpp: (historyItemWrappers): (WebHistoryItem::WebHistoryItem): (WebHistoryItem::~WebHistoryItem): (WebHistoryItem::createInstance): (WebHistoryItem::initFromDictionaryRepresentation): (WebHistoryItem::QueryInterface): (WebHistoryItem::initWithURLString): (WebHistoryItem::historyItem):
  • WebHistoryItem.h:
9:20 AM Changeset in webkit [18741] by aroben
  • 1 edit in trunk/WebCore/ChangeLog

Corrected Radar reference.

9:15 AM Changeset in webkit [18740] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

Fix: <rdar://problem/4903003> ContextMenuController leaks Events

No layout tests possible.

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Use RefPtr to manage the lifetime of Shared objects.
6:11 AM Changeset in webkit [18739] by rwlbuis
  • 3 edits in trunk/WebCore

Reviewed by Sam.

​http://bugs.webkit.org/show_bug.cgi?id=12196
SVGPatternElement should not be locatable

Replace SVGStyledLocatableElement derivation with
SVGStyledElement.

4:14 AM Changeset in webkit [18738] by zimmermann
  • 2 edits in trunk/WebCore

Build fix, not reviewed.
Use correct method name in the ASSERT in RenderSVGText.

3:40 AM Changeset in webkit [18737] by zimmermann
  • 102 edits in trunk

Reviewed by Eric.
Large SVG dynamic update rework/optimization.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10262 (SVG fails to redraw top 20 pixels)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10263 (SVG seems to repaint way too many times during load)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10404 (Invalidation issues with text skew)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10407 (bad SVG text invalidation issues on mouseover/mouseout)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10806 (failing manual-tests/svg-repaint-group.svg)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10913 (SVG charts from plotkit fail to render unless you scroll them offscreen)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10964 (inclusion of svg into svg leave a ghost invisible rectangle)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11680 (DojoKit SVG test chart fails to render (clipping issue?))
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11883 (SVG Text has updating/repainting issues)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11907 (RenderSVGContainer does not mark itself for repaint after setting viewBox, slice or align)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11913 (Invalidation issues in SVG javascript-based animation example)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11979 (SVG text does not respect font-size scaling in bbox calculation)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11984 (SVG <text> does not calculate the correct absoluteRepaintRect)
Partly fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10745 (SVG layout needs to move out of DOM and into rendering tree during layout() call)

Fixes text redrawing issues seen in svg/carto.net (when actually playing with those files, manually)
Fixes svg/carto.net/window.svg (moving "Navigation Window" caused artefacts)
Fixes svg/W3C-SVG-1.1/types-basicDOM-01-b.svg (bbox calculations had one pixel offset)

1:57 AM Changeset in webkit [18736] by lars
  • 2 edits in trunk/JavaScriptCore

Use the new functionality in Qt 4.3, to make
the methods closer compliant with the Unicode
spec.

Keep the old code so that it still compiles against
Qt 4.2.

12:59 AM Changeset in webkit [18735] by hyatt
  • 2 edits in trunk/WebCore

Make the selectionRect() method of RenderText better by reusing computeAbsoluteRepaintRect. This enables
the method to be multi-column aware and also to understand when the selection is clipped out by overflow.

Reviewed by bdash

  • rendering/RenderText.cpp: (WebCore::RenderText::selectionRect):
12:09 AM Changeset in webkit [18734] by hyatt
  • 5 edits in trunk/WebCore

Make the absolutePosition method multi-column aware. Note that there is now a real problem with the
absoluteRects method, since an object can split across multiple columns and break into multiple rects.
absolutePosition just returns the top-left corner of the element's box in the first column in which it
appears.

Reviewed by bdash

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::adjustRectForColumns):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::absolutePosition): (WebCore::RenderBox::computeAbsoluteRepaintRect):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::getAbsoluteRepaintRect):

Jan 9, 2007:

11:47 PM Changeset in webkit [22744] by adachan
  • 8 edits
    1 add in branches/WindowsMerge/WebKitWin

2007-01-09 Ada Chan <​adachan@apple.com>

Reviewed by Steve.

<rdar://4602355> Undo/Redo

WebKitWin changes:

  • Added new undo methods in the IWebUIDelegate.
  • Removed the internal WebUndoManager in WebEditorClient. Instead, we'll call methods on the ui delegate to register undo operations, execute undo/redo, etc.


11:39 PM Changeset in webkit [18733] by hyatt
  • 2 edits in trunk/WebCore

Avoid crashing when repainting multiple columns... make sure to use the current vector's size and
not the newly-computed column count.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutColumns): (WebCore::RenderBlock::adjustRepaintRectForColumns):
11:24 PM Changeset in webkit [18732] by hyatt
  • 5 edits in trunk/WebCore

Break up painting and hit testing of children into helper methods and add multi-column versions for both.


Make incremental repainting able to invalidate the right spot in multiple column layouts so that e.g., link
hover works.

Turn off selection gap filling in columns for now until it can be made to work correctly.

Improve the column balancing heuristic by adding in the block's lineHeight/2 to each column initially to
account for column break adjustments that shrink the columns slightly. Avoid clipping of the last column's
contents by ensuring it gets all the remaining available height.

Reviewed by mitz

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumns): (WebCore::RenderBlock::paintContents): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::fillSelectionGaps): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestColumns): (WebCore::RenderBlock::layoutColumns): (WebCore::RenderBlock::adjustRepaintRectForColumns):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::getAbsoluteRepaintRect):
8:42 PM Changeset in webkit [18731] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Darin and Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12150

Don't use memset to set float to 0

  • platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::cgGradientCallback):
7:45 PM Changeset in webkit [22743] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

7:36 PM Changeset in webkit [18730] by sfalken
  • 1 copy in tags/Safari-521.32.10b

New tag.

5:21 PM Changeset in webkit [22742] by andersca
  • 6 edits
    1 add in branches/WindowsMerge/WebKitWin

Reviewed by Darin.

Add COMPtr. Make MemoryStream backed by a SharedBuffer. Use SharedBuffer in
WebFrame.


  • COMPtr.h: Added. (COMPtr::COMPtr): (COMPtr::~COMPtr): (COMPtr::get): (COMPtr::operator*): (COMPtr::operator->): (COMPtr::operator&): (COMPtr::operator!): (COMPtr::operator UnspecifiedBoolType): (::copyTo): (::adopt): (::operator):
  • MemoryStream.cpp: (MemoryStream::MemoryStream): (MemoryStream::~MemoryStream): (MemoryStream::createInstance): (MemoryStream::Clone):
  • MemoryStream.h:
  • WebFrame.cpp: (WebFrame::WebFrame): (WebFrame::didReceiveResponse): (WebFrame::didReceiveData):
  • WebFrame.h: (WebFrame::data):
  • WebKit.vcproj/WebKit.vcproj:
5:19 PM Changeset in webkit [22741] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-01-09 Steve Falkenburg <​sfalken@apple.com>

B&I build fix

  • WebCore.vcproj/WebCore.vcproj:
5:09 PM Changeset in webkit [18729] by hyatt
  • 30 edits
    4 adds in trunk/LayoutTests/fast/overflow

Update overflow tests. Add new overflow test.

4:54 PM Changeset in webkit [18728] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Brady.

Add default constructor to SharedBuffer.

  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::SharedBuffer):
  • platform/SharedBuffer.h:
4:52 PM Changeset in webkit [18727] by hyatt
  • 11 edits in trunk/WebCore

This patch gets rudimentary column layout working. Normal flow content only gets laid out into
columns properly and painted correctly initially. What doesn't work: hit testing, incremental repainting,
column rule painting, child layers.

Some work needs to be done on the render tree dumper before column tests will be
meaningful.

Also reworked overflow and fixed a bunch of bugs with the computation of overflow. These include an error
in the height calculations caused by not adding in the horizontal scrollbar height and other errors caused
by not checking overflow in lowest/rightmostPosition. Existing tests improve their rendering to match
Firefox with this change.

Fixed a bug where a table cell incorrectly expanded to encompass floats inside an overflow:auto block.
This should not have happened. Covered by new test fast/overflow/table-overflow-float.html.

Reviewed by mitz

  • page/Frame.cpp:
  • rendering/RenderBlock.cpp: (WebCore:::RenderFlow): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::paintContents): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::avoidsFloats): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestContents): (WebCore::RenderBlock::layoutColumns):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::hasOverhangingFloats): (WebCore::RenderBlock::hasColumns):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines): (WebCore::RenderFlow::lowestPosition): (WebCore::RenderFlow::rightmostPosition): (WebCore::RenderFlow::leftmostPosition):
  • rendering/RenderFlow.h: (WebCore::RenderFlow::hasColumns):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderObject.h: (WebCore::RenderObject::expandsToEncloseOverflow):
  • rendering/RenderTableCell.h: (WebCore::RenderTableCell::expandsToEncloseOverflow):
  • rendering/RenderView.cpp: (WebCore::RenderView::paint):
4:23 PM Changeset in webkit [18726] by justing
  • 1 edit in trunk/LayoutTests/editing/pasteboard/4840662.html

Removed some extraneous text from this layout test. It passes now.

4:21 PM Changeset in webkit [22740] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-01-09 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou.


<rdar://4906546> Win2K: crash when entering new URL in address field

Win2K compatibility fix. SafeArrayCreateVector doesn't work correctly on older systems (Win2K, etc.)


Some references to people stumbling across this bug (apologies for not being able to find a Microsoft support article):
​http://discuss.develop.com/archives/wa.exe?A2=ind0104a&L=dotnet&D=0&T=0&P=69575
​http://www.eggheadcafe.com/ng/microsoft.public.platformsdk.com_ole/Jul2005/post22989606.asp
​http://www.pcreview.co.uk/forums/thread-1470025.php

  • MarshallingHelpers.cpp: (MarshallingHelpers::stringArrayToSafeArray): (MarshallingHelpers::intArrayToSafeArray): (MarshallingHelpers::intRectToSafeArray): (MarshallingHelpers::iunknownArrayToSafeArray):
4:11 PM Changeset in webkit [18725] by thatcher
  • 3 edits
    17 moves in trunk/WebKit

Reviewed by Darin.

Rename the now ObjC++ files to be .mm and remove the explicit file types.

  • DOM/WebDOMOperations.m: Removed.
  • DefaultDelegates/WebDefaultContextMenuDelegate.m: Removed.
  • English.lproj/StringsNotToBeLocalized.txt:
  • Misc/WebCoreStatistics.m: Removed.
  • Misc/WebElementDictionary.m: Removed.
  • Misc/WebIconDatabase.m: Removed.
  • Misc/WebNSAttributedStringExtras.m: Removed.
  • Misc/WebNSPasteboardExtras.m: Removed.
  • Plugins/WebNetscapePluginEmbeddedView.m: Removed.
  • Plugins/WebNullPluginView.m: Removed.
  • Plugins/WebPluginContainerCheck.m: Removed.
  • WebCoreSupport/WebViewFactory.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebArchiver.m: Removed.
  • WebView/WebHTMLRepresentation.m: Removed.
  • WebView/WebHTMLView.m: Removed.
  • WebView/WebRenderNode.m: Removed.
  • WebView/WebResource.m: Removed.
  • WebView/WebScriptDebugDelegate.m: Removed.
4:08 PM Changeset in webkit [18724] by darin
  • 30 edits in trunk

JavaScriptCore:

  • update 2007 Apple copyright for the new company name
  • kjs/DateMath.cpp:

WebCore:

  • update all 2007 Apple copyrights for the new company name
  • css/cssstyleselector.cpp:
  • html/HTMLLIElement.cpp:
  • platform/CharacterNames.h:
  • platform/TextBreakIterator.h:
  • platform/TextBreakIteratorICU.cpp:
  • platform/graphics/ImageBuffer.h:
  • rendering/CounterNode.cpp:
  • rendering/CounterNode.h:
  • rendering/RenderBox.h:
  • rendering/RenderContainer.cpp:
  • rendering/RenderCounter.cpp:
  • rendering/RenderCounter.h:
  • rendering/RenderImage.h:
  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.h:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderStyle.cpp:
  • rendering/RenderStyle.h:
  • rendering/RenderTable.cpp:
  • rendering/RenderTableCell.cpp:
  • rendering/RenderTableCell.h:
  • rendering/RenderText.cpp:
  • rendering/RenderText.h:
  • rendering/RenderTreeAsText.cpp:
  • rendering/SVGRenderTreeAsText.cpp:
  • rendering/break_lines.cpp:
2:49 PM Changeset in webkit [18723] by justing
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by john

  • editing/inserting/4840662-expected.checksum: Added.
  • editing/inserting/4840662-expected.png: Added.
  • editing/inserting/4840662-expected.txt: Added.
  • editing/inserting/4840662.html: Added.
  • editing/pasteboard/4840662-expected.checksum: Added.
  • editing/pasteboard/4840662-expected.png: Added.
  • editing/pasteboard/4840662-expected.txt: Added.
  • editing/pasteboard/4840662.html: Added.

WebCore:

Reviewed by john

<rdar://problem/4840662>
REGRESSION: Mail crash when dragging text into a link


moveParagraphs fails to move content into a display:block
anchor because of code in positionAvoidingSpecialElementBoundary,
and so it infinitely recurs.


  • editing/htmlediting.cpp: (WebCore::positionAvoidingSpecialElementBoundary): Don't avoid anchors that have display:block so that content is inserted in the expected paragraph. This fixes the bug and weird behavior when typing before/after anchors with display:block.
2:29 PM Changeset in webkit [18722] by rwlbuis
  • 4 edits
    8 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12145
Color parsing is too relaxed in strict mode
​http://bugs.webkit.org/show_bug.cgi?id=12166
REGRESSION (r18480): "336633" is not parsed as a color

Fix a regression by using String::format return value.
Also make strict mode more strict for cases where hexcolors
lack a #.

1:48 PM Changeset in webkit [18721] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed regression where redirects did not have user-agent any more

Showed up as a failure in one of the http tests, so no new test needed.

  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest): Don't use a copy of the ResourceRequest; pass the original so it can be modified.
1:39 PM Changeset in webkit [22739] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • platform/win/TextBoundariesWin.cpp:
1:36 PM Changeset in webkit [18720] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-01-09 sareen <​shyam.sareen@nokia.com>

Reviewed by Sachin Padma.
DESC: Switching to landscape while graphical back is open causes UI problem.
​http://bugs.webkit.org/show_bug.cgi?id=12168

  • BrowserView/src/WebKitView.cpp: (CWebKitView::SizeChanged):
1:32 PM Changeset in webkit [18719] by spadma
  • 2 edits in S60/trunk/WebKit

2007-01-09 sareen <​shyam.sareen@nokia.com>

Reviewed by Sachin Padma.
DESC: Switching to landscape while graphical back is open causes UI problem.
​http://bugs.webkit.org/show_bug.cgi?id=12168

  • BrowserView/src/WebKitView.cpp: (CWebKitView::SizeChanged):
1:19 PM Changeset in webkit [18718] by darin
  • 2 edits in trunk/JavaScriptCore
  • fix build
  • kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction): Actually compile it this time.
1:13 PM Changeset in webkit [18717] by darin
  • 2 edits in trunk/JavaScriptCore
  • fix build
  • kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction): Change types.
1:11 PM Changeset in webkit [18716] by darin
  • 2 edits in trunk/JavaScriptCore
  • fix build on platforms where Unicode::UChar is != uint16_t
  • kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction): Change types.
9:38 AM Changeset in webkit [18715] by ap
  • 7 edits
    2 adds in trunk

2007-01-09 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

JavaScriptCore:

  • JavaScriptCore.exp:
  • kjs/value.cpp: (KJS::JSValue::toInt32): Folded toInt32Inline into this method, which was its only caller. (KJS::JSValue::toUInt32): Added a variant that reports if the conversion has succeeded.
  • kjs/value.h:

WebCore:

  • bindings/js/kjs_html.cpp: (KJS::JSHTMLCollectionProtoFunc::callAsFunction): Changed item() to fall back to namedItem() if its argument does not convert to a number.

LayoutTests:

  • fast/dom/collection-namedItem-via-item-expected.txt: Added.
  • fast/dom/collection-namedItem-via-item.html: Added.
7:13 AM Changeset in webkit [18714] by spadma
  • 2 edits in S60/branches/3.1m/MemoryManager

2007-01-09 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Fix build break caused by removing simple notifier
​http://bugzilla.opendarwin.org/show_bug.cgi?id=

  • EABI/MemManU.DEF:
6:57 AM Changeset in webkit [18713] by spadma
  • 2 edits in S60/trunk/MemoryManager

2007-01-09 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Fix build break by removing SimpleNotifier.
​http://bugs.webkit.org/show_bug.cgi?id=

  • EABI/MemManU.DEF:
6:54 AM Changeset in webkit [18712] by darin
  • 39 edits
    1 add in trunk

JavaScriptCore:

Reviewed by Maciej.

  • wtf/unicode/icu/UnicodeIcu.h: Change parameter and return types to UChar32 and UChar. Removed unneeded type casts and added some const to functions that lacked it. Removed WTF::Unicode::memcmp. (WTF::Unicode::umemcasecmp): Renamed from strcasecmp since this doesn't work on 0-terminated strings as the str functions do.
  • wtf/unicode/qt4/UnicodeQt4.h: Ditto.
  • got rid of namespace prefixes from most uses of WTF::Unicode
  • kjs/function.cpp: (KJS::isStrWhiteSpace): (KJS::escapeStringForPrettyPrinting):
  • kjs/lexer.cpp: (KJS::Lexer::isWhiteSpace): (KJS::Lexer::isIdentStart): (KJS::Lexer::isIdentPart):
  • kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):

WebCore:

Reviewed by Maciej.

  • got rid of namespace prefixes from most uses of WTF::Unicode
  • updated for removal of WTF::Unicode::memcmp
  • updated for renaming of WTF::Unicode::strcasecmp to umemcasecmp.
  • unified constants for special Unicode characters in a new CharacterNames.h header
  • WebCore.xcodeproj/project.pbxproj:
  • css/cssparser.cpp: (WebCore::ParseString::lower):
  • dom/Document.cpp: (WebCore::isValidNameStart): (WebCore::isValidNamePart):
  • dom/Position.cpp: (WebCore::Position::leadingWhitespacePosition): (WebCore::Position::trailingWhitespacePosition):
  • editing/CompositeEditCommand.cpp: (WebCore::isWhitespace):
  • editing/HTMLInterchange.cpp:
  • editing/TextIterator.cpp: (WebCore::CircularSearchBuffer::CircularSearchBuffer): (WebCore::CircularSearchBuffer::append):
  • editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): (WebCore::nonBreakingSpaceString):
  • editing/htmlediting.h:
  • html/HTMLFontElement.cpp: (WebCore::parseFontSizeNumber):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
  • html/HTMLSelectElement.cpp: (WebCore::stripLeadingWhiteSpace):
  • platform/Font.cpp: (WebCore::WidthIterator::advance): (WebCore::WidthIterator::normalizeVoicingMarks):
  • platform/GlyphMap.cpp: (WebCore::GlyphMap::locatePage):
  • platform/MimeTypeRegistry.h:
  • platform/StringHash.h:
  • platform/StringImpl.cpp: (WebCore::isSpace): (WebCore::StringImpl::append): (WebCore::StringImpl::insert): (WebCore::StringImpl::truncate): (WebCore::StringImpl::remove): (WebCore::parseLength): (WebCore::StringImpl::isLower): (WebCore::StringImpl::lower): (WebCore::StringImpl::upper): (WebCore::StringImpl::secure): (WebCore::StringImpl::foldCase): (WebCore::StringImpl::capitalize):t (WebCore::StringImpl::toInt): (WebCore::equalIgnoringCase): (WebCore::StringImpl::find):
  • platform/TextBoundaries.h:
  • platform/TextCodec.h:
  • platform/TextCodecLatin1.cpp:
  • platform/TextEncoding.h:
  • platform/TextEncodingRegistry.h:
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection):
  • platform/mac/TextCodecMac.cpp: (WebCore::TextCodecMac::decode):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
  • rendering/RenderListMarker.cpp: (WebCore::listMarkerText): (WebCore::RenderListMarker::paint):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::isSpaceAccordingToStyle): (WebCore::RenderText::setInternalString):
  • rendering/RenderTreeAsText.cpp: (WebCore::quoteAndEscapeNonPrintables): (WebCore::operator<<):
  • rendering/bidi.cpp: (WebCore::BidiState::BidiState): (WebCore::BidiContext::BidiContext): (WebCore::bidiNext): (WebCore::bidiFirst): (WebCore::BidiIterator::direction): (WebCore::appendRun): (WebCore::embed): (WebCore::RenderBlock::bidiReorderLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::skipNonBreakingSpace): (WebCore::RenderBlock::findNextLineBreak):
  • rendering/break_lines.cpp: (WebCore::nextBreakablePosition):
  • rendering/break_lines.h:
  • xml/XPathParser.cpp: (WebCore::XPath::charCat):
6:43 AM Changeset in webkit [18711] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Another change log tweak.

6:42 AM Changeset in webkit [18710] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Add the bug number.

6:36 AM Changeset in webkit [18709] by darin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • rendering/RenderText.h: (WebCore::RenderText::selectionState): Change the m_selectionState enum-bitfield to an unsigned-bitfield, because enums on Windows are signed, which caused it to become negative (whereas the valid values are all positive).
6:28 AM Changeset in webkit [18708] by darin
  • 5 edits in trunk/WebCore

Reviewed by Hyatt.

  • platform/TextBreakIterator.h: Added lineBreakIterator. Removed ICU-specific stuff from the header.
  • platform/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Added helper to be shared by the three different creation functions. (WebCore::characterBreakIterator): Changed to use setUpIterator. (WebCore::wordBreakIterator): Ditto. (WebCore::lineBreakIterator): Added.
  • platform/qt/TextBreakIteratorQt.cpp: (WebCore::lineBreakIterator): Added a stub.
  • rendering/break_lines.cpp: (WebCore::isBreakableSpace): Added. (WebCore::shouldBreakAfter): Added. (WebCore::needsAdvancedBreakAnalysis): Added. (WebCore::nextBreakablePosition): Changed to use TextBreakIterator on platforms other than Mac.
6:19 AM Changeset in webkit [18707] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Mitz.

  • added a Thai line breaking test
  • fast/text/international/thai-line-breaks-expected.checksum: Added.
  • fast/text/international/thai-line-breaks-expected.png: Added.
  • fast/text/international/thai-line-breaks-expected.txt: Added.
  • fast/text/international/thai-line-breaks.html: Added.
6:15 AM Changeset in webkit [18706] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Darin.

  • move WebDataProtocol load handling from ResourceLoader to MainResourceLoader


(it's only ever used for main resources)

  • loader/ResourceLoader.h: (WebCore::ResourceLoader::setRequest):
  • loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::continueAfterContentPolicy):
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse):
5:56 AM Changeset in webkit [18705] by rwlbuis
  • 4 edits
    4 adds in trunk

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=12129
repaint issue after setting viewBox attribute with ECMAScript

Make sure RenderSVGContainer updates after setting viewBox from js.

5:50 AM Changeset in webkit [18704] by mjs
  • 5 edits in trunk/WebKit

Reviewed by Darin.


  • remove window display throttling code; no longer used
  • Misc/WebNSWindowExtras.h:
  • Misc/WebNSWindowExtras.m:
  • WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]):
  • WebView/WebPreferenceKeysPrivate.h:
12:20 AM Changeset in webkit [18703] by lars
  • 6 edits in trunk/WebCore

Make the Qt build compile... again!

12:15 AM Changeset in webkit [18702] by hyatt
  • 2 edits in trunk/WebCore

Fix for background: inherit bug where background-color wasn't getting properly overridden. This was a
regression from Safari 1.3 to 2.0.

Reviewed by bdash

fast/backgrounds/background-color-inherit-bug.html

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
12:14 AM Changeset in webkit [18701] by hyatt
  • 4 adds in trunk/LayoutTests/fast/backgrounds

Add new layout test for background inherit color bug.

Jan 8, 2007:

11:55 PM Changeset in webkit [18700] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Brian Dash

<rdar://problem/4895178>
WebCore::BackForwardList vector should be backed by a HashSet to remove
the potential expense in frequently calling BackForwardList::containsItem()

  • history/BackForwardList.cpp: (WebCore::BackForwardList::addItem): Maintain HashSet as well as Vector (WebCore::BackForwardList::setCapacity): Ditto (WebCore::BackForwardList::close): Ditto (WebCore::BackForwardList::removeItem): Ditto (WebCore::BackForwardList::containsItem): Make a hash lookup instead of iterate through the Vector
  • history/BackForwardList.h:
9:53 PM Changeset in webkit [18699] by hyatt
  • 2 edits in trunk/WebCore

Fix a regression where layout is triggering on all recalcStyles, due to a bad comparison
in the multicol assignment operator.

  • rendering/RenderStyle.cpp: (WebCore::StyleMultiColData::operator==):
9:25 PM Changeset in webkit [18698] by darin
  • 1 edit in trunk/WebCore/ChangeLog

And forgot change log.

9:25 PM Changeset in webkit [18697] by darin
  • 1 edit in trunk/WebCore/rendering/InlineBox.cpp

Oops, forgot one file.

9:18 PM Changeset in webkit [18696] by darin
  • 2 edits in trunk/WebCore
  • rolled out Beth's RenderFlow::destroy change, which broke 5 editing tests
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::destroy): Used svn merge to roll the change out.
7:52 PM Changeset in webkit [18695] by bdash
  • 3 edits in trunk/WebCore

2007-01-09 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim H.

Build fix for 64-bit platforms.

  • platform/graphics/svg/SVGPaintServerGradient.h:
  • platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
7:23 PM Changeset in webkit [22738] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Remove FrameLoader functions that have been implemented.


  • platform/win/TemporaryLinkStubs.cpp:
6:54 PM Changeset in webkit [18694] by andersca
  • 6 edits in trunk

WebCore:

Reviewed by Brady.

Move some history related functions off the bridge and into FrameLoader directly.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::canGoBackOrForward): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::historyURL):
  • loader/mac/FrameLoaderMac.mm:
  • page/mac/WebCoreFrameBridge.h:

WebKit:

Reviewed by Brady.

Remove bridge functions that are implemented directly in FrameLoader now.


  • WebCoreSupport/WebFrameBridge.mm:
6:48 PM Changeset in webkit [18693] by weinig
  • 7 edits in trunk

LayoutTests:

Reviewed by Mark.

Update results to include outline-color.

  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style.html:

WebCore:

Reviewed by Mark.

Adds outline-color to list of computable styles.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::):

WebKit:

Reviewed by Mark.

Adds default value for outline-color and fixes default
values of the recently fixed *-color properties.

6:01 PM Changeset in webkit [18692] by zbujtas
  • 2 edits in S60/trunk/WebCore

2007-01-08 shkeller <​shaun.keller@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: XMLHttpRequest object not gcprotected when !USE_CONSERVATIVE_GC
​http://bugs.webkit.org/show_bug.cgi?id=12157

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::slotFinished):
5:54 PM Changeset in webkit [18691] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2007-01-08 shkeller <​shaun.keller@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: XMLHttpRequest object not gcprotected when !USE_CONSERVATIVE_GC
​http://bugs.webkit.org/show_bug.cgi?id=12157

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::slotFinished):
5:21 PM Applications using WebKit edited by markmalone@mac.com
Added Vienna (diff)
5:03 PM Changeset in webkit [18690] by bdakin
  • 3 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for a bug that Adam, Hyatt, and I noticed when debugging
another problem.

  • rendering/InlineBox.cpp: (WebCore::InlineBox::root): Added assertion. If we are casting to a root, we should make sure we are root.
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::destroy): It is not enough to remove the child boxes for anonymous blocks. We need to be more thorough when cleaning these up. Adam's test case illustrates the problem well.
4:54 PM Changeset in webkit [18689] by hyatt
  • 1 edit in trunk/LayoutTests/fast/css/computed-style-expected.txt

Land updated computed style results.

4:51 PM Changeset in webkit [18688] by hyatt
  • 2 edits in trunk/LayoutTests/fast/text

Land updated stroke results.

4:12 PM Changeset in webkit [18687] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderTreeAsText.cpp

Only dump stroke/fill if it's different from color

3:28 PM Changeset in webkit [18686] by ddkilzer
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix typo.

3:14 PM Changeset in webkit [18685] by sullivan
  • 1 edit in trunk/WebCore/ChangeLog

Fixed text of previous comment.

3:11 PM Changeset in webkit [18684] by sullivan
  • 2 edits in trunk/WebCore

Tweak to previous checkin

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Adam suggested I should nil-check page->frame()
3:06 PM Changeset in webkit [22737] by lamadio
  • 3 edits in branches/WindowsMerge/WebKitWin

2007-01-08 Lou Amadio <​lamadio@apple.com>

Reviewed by ggaren

  • DOMCoreClasses.cpp: (DOMNode::createInstance):

Build break

  • WebView.cpp: (WebView::handleMouseEvent):

passing incorrect flag

3:05 PM Changeset in webkit [18683] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Brady and Beth


  • fixed <rdar://problem/4912541> GMAIL: With selected text in a rich text message, choosing "Search in Google" displays search results in the message body field
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Visit google URL in main frame rather than in current frame
3:01 PM Changeset in webkit [18682] by hyatt
  • 2 edits in trunk/WebCore

Fix computed style errors for color properties that had invalid colors.
They should return the value of the 'color' property when their colors
are not valid.

Fixed the computed style value for border-top-color (a typo was causing it to
use border-left-color instead).

Implement outline-color computed style.

Reviewed by harrison

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::currentColorOrValidColor): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2:51 PM Changeset in webkit [18681] by weinig
  • 7 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin and Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12150
Corrected results for W3C's pservers-grad-16-b.
Add a test for stop calues corner cases.

  • svg/W3C-SVG-1.1/pservers-grad-16-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt:
  • svg/custom/gradient-stop-corner-cases-expected.checksum: Added.
  • svg/custom/gradient-stop-corner-cases-expected.png: Added.
  • svg/custom/gradient-stop-corner-cases-expected.txt: Added.
  • svg/custom/gradient-stop-corner-cases.svg: Added.

WebCore:

Reviewed by Darin and Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12150
Handle correctly cases where no stops are defined, cases where a
stop offset value is less than previous stops offset value, and cases
where a stop offset value is greater than 1.0.


  • platform/graphics/svg/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::setGradientStops): Don't sort stops
  • platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::cgGradientCallback): When there are no stops, use a transparent fill (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache): a stop offset must always be considered at greater or equal to all preceding stop offsets, but no more than 1.0
2:45 PM Changeset in webkit [22736] by andersca
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Brady.


Use a WebCore HistoryItem object to back WebHistoryItem.


  • WebHistoryItem.cpp: (WebHistoryItem::WebHistoryItem): (WebHistoryItem::~WebHistoryItem): (WebHistoryItem::createInstance): (WebHistoryItem::initFromDictionaryRepresentation): (WebHistoryItem::dictionaryRepresentation): (WebHistoryItem::hasURLString): (WebHistoryItem::visitCount): (WebHistoryItem::setVisitCount): (WebHistoryItem::mergeAutoCompleteHints): (WebHistoryItem::setLastVisitedTimeInterval): (WebHistoryItem::setTitle): (WebHistoryItem::RSSFeedReferrer): (WebHistoryItem::setRSSFeedReferrer): (WebHistoryItem::initWithURLString): (WebHistoryItem::URLString): (WebHistoryItem::title): (WebHistoryItem::lastVisitedTimeInterval):
  • WebHistoryItem.h:
2:15 PM Changeset in webkit [18680] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4865325> please re-add auto font activation support in WebKit

  • platform/mac/WebFontCache.mm: (+[WebFontCache fontWithFamily:traits:size:]):
1:36 PM Changeset in webkit [18679] by darin
  • 5 edits in trunk/LayoutTests
  • turn off the Armenian part of this test for now, since it gives different results with different fonts
  • fast/lists/w3-list-styles-expected.checksum:
  • fast/lists/w3-list-styles-expected.png:
  • fast/lists/w3-list-styles-expected.txt:
  • fast/lists/w3-list-styles.html:
1:32 PM Changeset in webkit [18678] by bdakin
  • 2 edits in trunk/WebKit

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12161 REGRESSION:
Crash when control-clicking on an image for contextual menu

  • WebView/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): We need to nil-check coreMenu since it will be nil if the DOM popped up a menu instead. I cleaned up the function to make all the nil checks early returns instead of nesting all of the content. Also moved the autorelease to be with the creation of the menu instead of at the return.
12:55 PM Changeset in webkit [18677] by weinig
  • 28 edits in trunk/WebCore

Reviewed by Adam.

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLSelectElement _activateItemAtIndex:]): Removed useless implementation that would only work with NSView-based <select> elements, and added a FIXME about the fact that this function doesn't do anything any more. I think it's used by Safari forms auto-fill.
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject rendererForView:]): Removed code that depends on elementForView:, since that always returns nil now.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::~HTMLFormElement): Use a formDestroyed() function rather than clearing m_form directly so that this class doesn't have to be a friend of HTMLGenericFormElement.
  • html/HTMLGenericFormElement.h: Removed now-unneeded friend declaration for HTMLFormElement. Moved definition of supportsFocus into the .cpp file. Added a public formDestroyed function for use by HTMLFormElement.
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::attach): Removed widget-specific code. (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto. (WebCore::HTMLGenericFormElement::isMouseFocusable): Ditto. (WebCore::HTMLGenericFormElement::supportsFocus): Added this here; it was in the header file before, for no good reason.
  • page/EventHandler.h: Removed unused Mac-specific currentEventIsMouseDownInWidget.
  • page/mac/EventHandlerMac.mm: Ditto.
  • page/Frame.cpp: (WebCore::Frame::frameForWidget): Changed to use RenderWidget to find the frame rather than the WigetClient element() function.
  • page/mac/FrameMac.h: Removed unused bridgeForWidget.
  • page/mac/FrameMac.mm: Ditto.
  • page/mac/WebCoreFrameBridge.h: Removed elementForView.
  • page/mac/WebCoreFrameBridge.mm: Ditto. While the scroll bar still did implement WebCoreWidgetHolder, it does not correspond to a DOM element, so this method was always returning nil.
  • platform/Widget.h: Moved unused types and functions that are still in the platform-specific implementations into a "to be deleted" section: FocusPolicy, NoFocus, TabFocus, ClickFocus, StrongFocus, WheelFocus, lockDrawingFocus, font, focusPolicy, hasFocus, clearFocus, setFont, disableFlushDrawing, enableFlushDrawing, unlockDrawingFocus. Removed unused functions that are not in platform-specific implementations: sizeHint, baselinePosition, checksDescendantsForFocus.
  • platform/Widget.cpp: Removed functions.
  • platform/WidgetClient.h: Emptied out the class. Soon we can delete it.
  • platform/mac/PlatformScrollBarMac.mm: (-[WebCoreScrollBar mouseDown:]): Got rid of unneeded includes, removed use of the WebCoreWidgetHolder protocol and the one method in it, and changed the calls to beforeMouseDown and afterMouseDown to pass the widget pointer in.
  • platform/mac/WebCoreWidgetHolder.h: Emptied out the file -- to be deleted later.
  • platform/mac/WidgetMac.mm: (WebCore::Widget::~Widget): Removed code to manage deferredFirstResponder. (WebCore::Widget::hasFocus): Removed body of function and replaced with an assertion that it's never called. Later we'll remove it. (WebCore::Widget::setFocus): Tweaked a bit to work given changes to the FrameMac class. Also added a FIXME. Given how this works, it does not belong in the platform layer. (WebCore::Widget::clearFocus): Removed body of function and replaced with an assertion that it's never called. Later we'll remove it. (WebCore::Widget::focusPolicy): Ditto. (WebCore::Widget::font): Ditto. (WebCore::Widget::setFont): Ditto. (WebCore::Widget::lockDrawingFocus): Ditto. (WebCore::Widget::unlockDrawingFocus): Ditto. (WebCore::Widget::disableFlushDrawing): Ditto. (WebCore::Widget::enableFlushDrawing): Ditto. (WebCore::Widget::paint): Removed obsolete comment. (WebCore::Widget::sendConsumedMouseUp): Removed body of function and replaced with an assertion that it's never called. Later we'll remove it. (WebCore::Widget::setIsSelected): Tweaked a bit to work given changes to the FrameMac class. Also added a FIXME. Given how this works, it does not belong in the platform layer. (WebCore::Widget::beforeMouseDown): Changed to take an explicit Widget parameter. (WebCore::Widget::afterMouseDown): Ditto.
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::intrinsicWidth): Changed to not call sizeHint() any more. I didn't change the values returned by the function, but they make no sense and this should probably be fixed later. (WebCore::RenderApplet::intrinsicHeight): Ditto.
  • rendering/RenderWidget.h: Removed unneeded WidgetClient.h include. Changed RenderWidget to no longer inherit from WidgetClient. Added a find function to find a RenderWidget given a Widget. Removed all the virtual functions that override WidgetClient hooks.
  • rendering/RenderWidget.cpp: Removed all the WidgetClient functions. (WebCore::widgetRendererMap): Added. Map that gives the RenderWidget for each Widget that is owned by a RenderWidget. (WebCore::RenderWidget::destroy): Removed the setClient call and added a call to remove the widget from the widgetRendererMap. (WebCore::RenderWidget::setWidget): Ditto. (WebCore::RenderWidget::setStyle): Removed the call to Widget::setFont. (WebCore::RenderWidget::find): Added. Returns the RenderWidget for a Widget, if any.
  • other changes
  • dom/Node.cpp: (WebCore::Node::dump): Removed unnecessary use of DeprecatedString. (WebCore::appendAttributeDesc): Ditto. (WebCore::Node::showNode): Ditto. (WebCore::Node::formatForDebugger): Ditto.
  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage): Cleaned up conditional compilation so adding more MIME types here doesn't make the function more and more difficult to read.
  • page/Frame.h: Removed unneeded includes and declarations. Tweaked formatting.
  • page/Page.h: Removed unneeded declarations.
  • platform/ScrollView.h: Removed unneeded includes.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::renderName): Tweaked formatting.
11:55 AM Changeset in webkit [18676] by weinig
  • 6 edits in trunk/WebCore

Reviewed by Darin.

No test possible (no change to functionality).

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::removeComputedInheritablePropertiesFrom): Added. Removes the inheritable properties that CSSComputedStyleDeclaration knows how to compute from the given mutable declaration.
  • css/CSSComputedStyleDeclaration.h:
  • css/CSSMutableStyleDeclaration.cpp: Removed one copy of the inheritableProperties array.
  • css/CSSMutableStyleDeclaration.h:
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Changed to call CSSComputedStyleDeclaration::removeComputedInheritablePropertiesFrom.
11:48 AM Changeset in webkit [18675] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12099
XMLHttpRequest shouldn't honor a charset specified via setRequestHeader

Test: http/tests/xmlhttprequest/request-encoding.html

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): Don't try to get the charset from Content-Type. Keep checking for unknown charsets, because that will be needed again when we start using document.xmlEncoding.
11:42 AM Changeset in webkit [18674] by ap
  • 10 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=7640
Menu items are displayed as "undefined"

WebCore:

  • bindings/js/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction):
  • bindings/js/kjs_domnode.h: (KJS::DOMNode::): Removed Node::item. No idea why it was there in the first place.
  • bindings/js/kjs_html.cpp: (KJS::HTMLElementFunction::callAsFunction):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::): Added HTMLSelectElement::item. It is not in DOM2 IDL, but the spec seems to mentions it anyway: "The contained options can be directly accessed through the select element as a collection."
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::namedItem): (WebCore::HTMLSelectElement::item):
  • html/HTMLSelectElement.h:
  • html/HTMLSelectElement.idl: Added this method to DOM and IDL, too. Made namedItem() non-virtual.

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt: Updated the results.
  • fast/dom/node-item-expected.txt: Added.
  • fast/dom/node-item.html: Added. Check that there is no Node:item or HTMLElement:item.
11:31 AM Changeset in webkit [18673] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4912254> REGRESSION: After copying text to
the clipboard, the paste contextual remains dimmed when it should
be active

No layout test for context menu problems.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): Remove check to see if the content is richly editable; it only has to be regular editable and the call to canPaste() takes care of that.
11:17 AM Changeset in webkit [18672] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

Attempt to fix build for buildbots.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::columnGap): (WebCore::RenderBlock::calcColumnWidth):
11:15 AM Changeset in webkit [18671] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

  • added a W3C list style test that was cited in a bug
  • fast/lists/w3-list-styles-expected.checksum: Added.
  • fast/lists/w3-list-styles-expected.png: Added.
  • fast/lists/w3-list-styles-expected.txt: Added.
  • fast/lists/w3-list-styles.html: Added.

WebCore:

Reviewed by Maciej.

Test case showed problems in cjk-ideographic and hebrew
Test: fast/lists/w3-list-styles.html

  • rendering/RenderListMarker.cpp: (WebCore::toCJKIdeographic): Fix the algorithm so it doesn't include leading zeroes. I had misread the part that says you start with the decimal form of the number. Fix an assertion that was too stringent. Fix the code to collapse consecutive zeroes so that it doesn't get confused by intervening "noChar" characters. (WebCore::RenderListMarker::paint): Reverse the text before painting if the first character's direction is right to left.
11:10 AM Changeset in webkit [22735] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • WebCore.vcproj/WebCore.vcproj:
10:59 AM Changeset in webkit [18670] by darin
  • 138 edits in trunk

LayoutTests:

Reviewed by Beth.

  • css1/basic/class_as_selector-expected.txt:
  • css1/basic/containment-expected.txt:
  • css1/basic/contextual_selectors-expected.txt:
  • css1/basic/id_as_selector-expected.txt:
  • css1/box_properties/border_bottom-expected.txt:
  • css1/box_properties/border_left-expected.txt:
  • css1/box_properties/border_right_inline-expected.txt:
  • css1/box_properties/border_top-expected.txt:
  • css1/box_properties/clear_float-expected.txt:
  • css1/box_properties/margin-expected.txt:
  • css1/box_properties/margin_bottom-expected.txt:
  • css1/box_properties/margin_left-expected.txt:
  • css1/box_properties/margin_right-expected.txt:
  • css1/box_properties/margin_top-expected.txt:
  • css1/box_properties/padding_left-expected.txt:
  • css1/box_properties/padding_right-expected.txt:
  • css1/cascade/cascade_order-expected.txt:
  • css1/classification/display-expected.txt:
  • css1/classification/list_style-expected.txt:
  • css1/classification/list_style_image-expected.txt:
  • css1/classification/list_style_position-expected.txt:
  • css1/classification/list_style_type-expected.txt:
  • css1/conformance/forward_compatible_parsing-expected.txt:
  • css1/pseudo/anchor-expected.txt:
  • css2.1/t0402-c71-fwd-parsing-02-f-expected.txt:
  • css2.1/t0505-c16-descendant-01-e-expected.txt:
  • css2.1/t050803-c14-classes-00-e-expected.txt:
  • css2.1/t0509-c15-ids-01-e-expected.txt:
  • css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
  • css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
  • css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
  • css2.1/t1205-c561-list-displ-00-b-expected.txt:
  • css2.1/t1205-c563-list-type-00-b-expected.txt:
  • css2.1/t1205-c563-list-type-01-b-expected.txt:
  • css2.1/t1205-c564-list-img-00-b-g-expected.txt:
  • css2.1/t1205-c565-list-pos-00-b-expected.txt:
  • css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
  • editing/deleting/4866671-expected.txt:
  • editing/deleting/delete-first-list-item-expected.txt:
  • editing/deleting/delete-link-1-expected.txt:
  • editing/deleting/delete-listitem-002-expected.txt:
  • editing/deleting/list-item-1-expected.txt:
  • editing/deleting/merge-into-empty-block-2-expected.txt:
  • editing/execCommand/4641880-1-expected.txt:
  • editing/execCommand/create-list-from-range-selection-expected.txt:
  • editing/execCommand/create-list-with-hr-expected.txt:
  • editing/execCommand/indent-list-item-expected.txt:
  • editing/execCommand/indent-selection-expected.txt:
  • editing/execCommand/insert-list-and-stitch-expected.txt:
  • editing/execCommand/remove-list-from-range-selection-expected.txt:
  • editing/execCommand/remove-list-item-1-expected.txt:
  • editing/execCommand/remove-list-items-expected.txt:
  • editing/execCommand/switch-list-type-expected.txt:
  • editing/inserting/insert-div-022-expected.txt:
  • editing/inserting/insert-div-023-expected.txt:
  • editing/inserting/insert-div-024-expected.txt:
  • editing/pasteboard/4861080-expected.txt:
  • editing/pasteboard/drop-link-expected.txt:
  • editing/pasteboard/innerText-inline-table-expected.txt:
  • editing/pasteboard/input-field-1-expected.txt:
  • editing/pasteboard/merge-end-list-expected.txt:
  • editing/pasteboard/merge-start-list-expected.txt:
  • editing/pasteboard/paste-4039777-fix-expected.txt:
  • editing/pasteboard/paste-list-001-expected.txt:
  • editing/pasteboard/select-element-1-expected.txt:
  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • editing/selection/extend-by-word-002-expected.txt:
  • editing/selection/move-by-line-002-expected.txt:
  • editing/selection/select-all-iframe-expected.txt:
  • editing/selection/selectNode-expected.txt:
  • editing/selection/selectNodeContents-expected.txt:
  • editing/unsupported-content/list-delete-001-expected.txt:
  • editing/unsupported-content/list-type-after-expected.txt:
  • editing/unsupported-content/list-type-before-expected.txt:
  • fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt:
  • fast/block/float/014-expected.txt:
  • fast/css-generated-content/009-expected.txt:
  • fast/css/001-expected.txt:
  • fast/css/continuationCrash-expected.txt:
  • fast/css/css2-system-fonts-expected.txt:
  • fast/css/css3-modsel-22-expected.txt:
  • fast/css/list-outline-expected.txt:
  • fast/doctypes/001-expected.txt:
  • fast/doctypes/002-expected.txt:
  • fast/doctypes/003-expected.txt:
  • fast/doctypes/004-expected.txt:
  • fast/dom/Window/window-onFocus-expected.txt:
  • fast/forms/form-hides-table-expected.txt:
  • fast/forms/plaintext-mode-2-expected.txt:
  • fast/lists/001-expected.txt:
  • fast/lists/002-expected.txt:
  • fast/lists/003-expected.txt:
  • fast/lists/004-expected.txt:
  • fast/lists/005-expected.txt:
  • fast/lists/006-expected.txt:
  • fast/lists/007-expected.txt:
  • fast/lists/008-expected.txt:
  • fast/lists/alpha-list-wrap-expected.txt:
  • fast/lists/decimal-leading-zero-expected.txt:
  • fast/lists/drag-into-marker-expected.txt:
  • fast/lists/dynamic-marker-crash-expected.txt:
  • fast/lists/inlineBoxWrapperNullCheck-expected.txt:
  • fast/lists/li-br-expected.txt:
  • fast/lists/li-style-alpha-huge-value-crash-expected.txt:
  • fast/lists/li-values-expected.txt:
  • fast/lists/markers-in-selection-expected.txt:
  • fast/lists/numeric-markers-outside-list-expected.txt:
  • fast/lists/ol-display-types-expected.txt:
  • fast/lists/olstart-expected.txt:
  • fast/lists/ordered-list-with-no-ol-tag-expected.txt:
  • fast/lists/scrolled-marker-paint-expected.txt:
  • fast/overflow/overflow-rtl-expected.txt:
  • fast/selectors/001-expected.txt:
  • fast/selectors/013-expected.txt:
  • fast/selectors/015-expected.txt:
  • fast/selectors/166-expected.txt:
  • fast/table/018-expected.txt:
  • fast/table/form-with-table-style-expected.txt:
  • fast/text/whitespace/tab-character-basics-expected.txt:
  • fast/tokenizer/004-expected.txt:
  • tables/mozilla/bugs/bug23235-expected.txt:
  • tables/mozilla/bugs/bug30692-expected.txt:
  • tables/mozilla/bugs/bug3191-expected.txt:
  • tables/mozilla/bugs/bug32205-2-expected.txt:
  • tables/mozilla/marvin/backgr_index-expected.txt:
  • tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • tables/mozilla/marvin/x_table-expected.txt:
  • tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • tables/mozilla/other/wa_table_tr_align-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • traversal/stay-within-root-expected.txt:

WebCore:

Reviewed by Beth.

  • rendering/RenderTreeAsText.cpp: (WebCore::getTagName): Changed to use String instead of DeprecatedString. (WebCore::quoteAndEscapeNonPrintables): Ditto. Also moved up so it can be used in the operator below. (WebCore::operator<<): Added clause for RenderListMarker that dumps the value of the list marker's text. (WebCore::nodePosition): Changed to use String instead of DeprecatedString.
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::TextStreamSeparator::TextStreamSeparator): Changed to use String instead of DeprecatedString. (WebCore::getTagName): Ditto. (WebCore::write): Ditto.
9:50 AM Changeset in webkit [18669] by weinig
  • 8 edits
    1 copy in trunk/WebCore

Reviewed by ap and the rubber stamp of Maciej.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12164
Cleanup Tokenizers

  • Moves Tokenizer class into its own file.
  • Move XMLTokenizer declaration from XMLTokenizer.cpp to XMLTokenizer.h
  • Fixup #includes.
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::createTokenizer):
  • dom/Tokenizer.h: Added. (WebCore::Tokenizer::Tokenizer): (WebCore::Tokenizer::~Tokenizer): (WebCore::Tokenizer::stopParsing): (WebCore::Tokenizer::processingData): (WebCore::Tokenizer::executingScript): (WebCore::Tokenizer::wantsRawData): (WebCore::Tokenizer::writeRawData): (WebCore::Tokenizer::inViewSourceMode): (WebCore::Tokenizer::setInViewSourceMode): (WebCore::Tokenizer::wellFormed): (WebCore::Tokenizer::lineNumber): (WebCore::Tokenizer::columnNumber):
  • dom/XMLTokenizer.cpp:
  • dom/XMLTokenizer.h: (WebCore::XMLTokenizer::): (WebCore::XMLTokenizer::setIsXHTMLDocument): (WebCore::XMLTokenizer::isXHTMLDocument): (WebCore::XMLTokenizer::wellFormed):
  • html/HTMLElement.cpp:
  • html/HTMLTokenizer.h: (WebCore::Token::reset): (WebCore::HTMLTokenizer::checkBuffer): (WebCore::HTMLTokenizer::checkScriptBuffer): (WebCore::HTMLTokenizer::State::State): (WebCore::HTMLTokenizer::State::setBit):
  • xml/XSLTProcessor.cpp:
9:49 AM S60Reindeer edited by mboudreau@ftrd.us
fixed grammatical typo (diff)
9:31 AM Changeset in webkit [18668] by spadma
  • 9 edits in S60/branches/3.1m

2007-01-08 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: OOM notification when browser running out of memory.
TSW Id : AHUN-6X6PW3
​http://bugs.webkit.org/show_bug.cgi?id=

  • BrowserView/inc/WebKitControl.h:
  • BrowserView/src/WebKitControl.cpp: (CWebKitOOMNotifier::NewL): (CWebKitOOMNotifier::~CWebKitOOMNotifier): (CWebKitOOMNotifier::Notify): (CStaticObjectContainer::Instance): (CStaticObjectContainer::CStaticObjectContainer): (CStaticObjectContainer::~CStaticObjectContainer):
  • data/Webkit.rss:
  • data/Webkit_sdk.loc:
  • data/Webkit_sdk.rss:
8:45 AM Changeset in webkit [18667] by spadma
  • 9 edits in S60/trunk

2007-01-08 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: OOM notification when browser running out of memory.
TSW Id : AHUN-6X6PW3
​http://bugs.webkit.org/show_bug.cgi?id=

  • BrowserView/inc/WebKitControl.h:
  • BrowserView/src/WebKitControl.cpp: (CWebKitOOMNotifier::NewL): (CWebKitOOMNotifier::~CWebKitOOMNotifier): (CWebKitOOMNotifier::Notify): (CStaticObjectContainer::Instance): (CStaticObjectContainer::CStaticObjectContainer): (CStaticObjectContainer::~CStaticObjectContainer):
  • data/Webkit.rss:
  • data/Webkit_sdk.loc:
  • data/Webkit_sdk.rss:
7:42 AM Changeset in webkit [18666] by weinig
  • 6 edits in trunk

LayoutTests:

Reviewed by Tim H.

Update results to include -webkit-box-shadow.

  • fast/css/computed-style-expected.txt:

WebCore:

Reviewed by Tim H.

Adds -webkit-box-shadow to list of computable styles.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::):

WebKit:

Reviewed by Tim H.

Adds default value for -webkit-box-shadow and fixes default
value of -webkit-column-count to be "auto". Also sorts the
list of defaults.

5:43 AM Changeset in webkit [18665] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by bdash.

Initialize the member vars, fixes testcases
pointer-events-path.svg and pointer-events-text.svg
on the PPC build.

4:36 AM Changeset in webkit [18664] by bdash
  • 4 edits in trunk

2007-01-08 Andrew Wellington <​proton@wiretapped.net>

Reviewed by Mark.

2007-01-08 Andrew Wellington <​proton@wiretapped.net>

Reviewed by Mark.

  • fast/css/computed-style-expected.txt: Update results to include -webkit-column styles.
3:57 AM Changeset in webkit [18663] by hyatt
  • 4 edits in trunk/WebCore

This patch computes the correct column width and column count. It ensures that content lays out constrained
to the column width in one long strip. It does not yet balance the long strip into multiple columns.

Reviewed by Mark

  • rendering/RenderBlock.cpp: (WebCore:::RenderFlow): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::rightOffset): (WebCore::RenderBlock::availableWidth): (WebCore::RenderBlock::columnGap): (WebCore::RenderBlock::calcColumnWidth):
  • rendering/RenderBlock.h:
  • rendering/RenderStyle.h: (WebCore::RenderStyle::setColumnWidth):
2:30 AM Changeset in webkit [18662] by hyatt
  • 11 edits in trunk/WebCore

Fix column-count so that it supports auto just like column-width does.

Add a new function, availableWidth(), that will be used to return the width available to content placed inside
a block. For now it still returns contentWidth(), so no behavioral change has occurred yet.

Subclass calcWidth() in RenderBlock, but don't change anything yet. This is where RenderBlock will calc the
correct column width.

Reviewed by mark

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::leftRelOffset): (WebCore::RenderBlock::rightRelOffset): (WebCore::RenderBlock::getClearDelta): (WebCore::RenderBlock::availableWidth): (WebCore::RenderBlock::calcWidth):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockWidth):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlockWidth): (WebCore::RenderObject::paddingTop): (WebCore::RenderObject::paddingBottom): (WebCore::RenderObject::paddingLeft): (WebCore::RenderObject::paddingRight):
  • rendering/RenderObject.h: (WebCore::RenderObject::availableWidth):
  • rendering/RenderStyle.cpp: (WebCore::StyleMultiColData::StyleMultiColData): (WebCore::StyleMultiColData::operator==):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::hasAutoColumnCount): (WebCore::RenderStyle::setColumnCount): (WebCore::RenderStyle::setHasAutoColumnCount):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth):
12:45 AM Changeset in webkit [18661] by hyatt
  • 3 edits
    4 adds in trunk

LayoutTests:

Add layout test for inheritance of auto z-index.

Reviewed by eric

  • fast/layers/zindex-inherit-expected.checksum: Added.
  • fast/layers/zindex-inherit-expected.png: Added.
  • fast/layers/zindex-inherit-expected.txt: Added.
  • fast/layers/zindex-inherit.html: Added.

WebCore:

Fix z-index:inherit so that it works properly when inheriting from z-index:auto.

Reviewed by eric

fast/layers/zindex-inherit.html

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
12:41 AM Changeset in webkit [18660] by hyatt
  • 8 edits in trunk/WebCore

Add support for all of the CSS3 multi-column properties in preparation for implementing the
feature.

Reviewed by eric

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::):
  • css/CSSPropertyNames.in:
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • rendering/RenderStyle.cpp: (WebCore::StyleMultiColData::StyleMultiColData): (WebCore::StyleMultiColData::operator==): (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::RenderStyle::RenderStyle): (WebCore::RenderStyle::diff):
  • rendering/RenderStyle.h: (WebCore::StyleMultiColData::operator!=): (WebCore::StyleMultiColData::ruleWidth): (WebCore::RenderStyle::columnWidth): (WebCore::RenderStyle::hasAutoColumnWidth): (WebCore::RenderStyle::columnCount): (WebCore::RenderStyle::columnGap): (WebCore::RenderStyle::hasAutoColumnGap): (WebCore::RenderStyle::columnRuleColor): (WebCore::RenderStyle::columnRuleStyle): (WebCore::RenderStyle::columnRuleWidth): (WebCore::RenderStyle::columnBreakBefore): (WebCore::RenderStyle::columnBreakInside): (WebCore::RenderStyle::columnBreakAfter): (WebCore::RenderStyle::setColumnWidth): (WebCore::RenderStyle::setHasAutoColumnWidth): (WebCore::RenderStyle::setColumnCount): (WebCore::RenderStyle::setColumnGap): (WebCore::RenderStyle::setHasAutoColumnGap): (WebCore::RenderStyle::setColumnRuleColor): (WebCore::RenderStyle::setColumnRuleStyle): (WebCore::RenderStyle::setColumnRuleWidth): (WebCore::RenderStyle::resetColumnRule): (WebCore::RenderStyle::setColumnBreakBefore): (WebCore::RenderStyle::setColumnBreakInside): (WebCore::RenderStyle::setColumnBreakAfter): (WebCore::RenderStyle::initialColumnCount): (WebCore::RenderStyle::initialColumnWidth):

Jan 7, 2007:

10:45 PM Changeset in webkit [18659] by rwlbuis
  • 10 edits
    10 adds in trunk

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10587
pointer-events is not implemented for RenderSVGImage or RenderSVGText
Implement pointer-events for raster images and svg text.

9:17 PM Changeset in webkit [18658] by ddkilzer
  • 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by Darin.

  • kjs/date_object.cpp: (KJS::DateProtoFunc::callAsFunction): Removed dead code.
9:11 PM Changeset in webkit [18657] by ddkilzer
  • 6 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by Darin.

Change JNI so that it is not wrapped in the PLATFORM(MAC) ifdef, enabling
other platforms who have JNI to use it.

  • bindings/jni/jni_instance.h: Removed unnecessary include of <CoreFoundation/CoreFoundation.h>
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::setJavaVM):
  • bindings/jni/jni_utility.h: Added new method for clients to set the JavaVM
  • bindings/runtime.cpp: (KJS::Bindings::Instance::createBindingForLanguageInstance): Changed code to utilize new #if HAVE(JNI)
  • kjs/config.h: Added new #define for JNI, ie HAVE_JNI
9:08 PM Changeset in webkit [18656] by ddkilzer
  • 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by Darin.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=11431
ARM platform has some byte alignment issues

Fix for NaN being 4 bytes and it must start on a byte boundary
for ARM architectures.

  • kjs/fpconst.cpp: (KJS::):
5:16 PM Changeset in webkit [18655] by hyatt
  • 5 edits in trunk/WebCore

Fix a regression where border-radius was not clipping the background when border was set to none.
Fix multi-line inline flow painting to properly apply border-radius to the background only at the
beginning of the first line and end of the last line.

Reviewed by eric

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBackground):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackground): (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/RenderBox.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::paintBackgroundExtended):
3:31 PM Changeset in webkit [18654] by hyatt
  • 22 edits
    5 adds in trunk

LayoutTests:

Add support for the CSS3 box-shadow property.

Reviewed by olliej

  • fast/box-shadow/basic-shadows-expected.checksum: Added.
  • fast/box-shadow/basic-shadows-expected.png: Added.
  • fast/box-shadow/basic-shadows-expected.txt: Added.
  • fast/box-shadow/basic-shadows.html: Added.

WebCore:

Add support for the CSS3 box-shadow property.

Reviewed by olliej

fast/box-shadow/ contains the tests for this feature.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::clipOutRoundedRect):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): (WebCore::InlineFlowBox::paintBoxShadow): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::shouldDrawTextDecoration): (WebCore::InlineFlowBox::paintTextDecorations):
  • rendering/InlineFlowBox.h:
  • rendering/InlineRunBox.h: (WebCore::InlineRunBox::paintBoxDecorations): (WebCore::InlineRunBox::paintTextDecorations):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paint):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderImage.h:
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::paintBoxShadow): (WebCore::RenderObject::dump): (WebCore::RenderObject::setStyle):
  • rendering/RenderObject.h: (WebCore::RenderObject::hasBoxDecorations): (WebCore::RenderObject::setHasBoxDecorations):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint): (WebCore::RenderTable::paintBoxDecorations):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::RenderTableCell): (WebCore::RenderTableCell::setStyle): (WebCore::RenderTableCell::paintBoxDecorations):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
2:37 PM New features in WebKit since Safari 2.0 edited by eric@webkit.org
(diff)
2:36 PM New features in WebKit since Safari 2.0 edited by eric@webkit.org
(diff)
2:35 PM New features in WebKit since Safari 2.0 created by eric@webkit.org
2:29 PM WikiStart edited by eric@webkit.org
(diff)
10:15 AM Changeset in webkit [18653] by rwlbuis
  • 2 edits in trunk/LayoutTests

Reviewed by weinig.

Correct results from previous patch.

8:47 AM Changeset in webkit [18652] by rwlbuis
  • 22 edits in trunk/WebCore

Reviewed by weinig.

​http://bugs.webkit.org/show_bug.cgi?id=10362
SVG needs to support SVGError events and some form of "error state"
Report SVG warnings and errors on (JS) console.
Expose line and column number getters in Tokenizer in
order to display them with the error message.

6:00 AM Changeset in webkit [18651] by zimmermann
  • 58 edits in trunk

Reviewed by Sam.
Cleanup code & fix InlineBox positioning when text-anchor is used.

4:47 AM Changeset in webkit [18650] by staikos
  • 12 edits
    1 add in trunk

Make it compile and link again. (Qt) Includes implementation of a few stubs
which should be moved to other locations, as well as a non-Qt-specific change
to make it compile (nil->ResourceResponse()). Qt port continues to function as
well as before.

4:01 AM Changeset in webkit [18649] by ap
  • 3 edits in trunk/LayoutTests

Updated pixel results that weren't landed with r17141.

  • http/tests/incremental/slow-utf8-css-expected.checksum:
  • http/tests/incremental/slow-utf8-css-expected.png:
3:47 AM Changeset in webkit [18648] by ap
  • 4 edits
    4 adds in trunk

2007-01-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Mark Rowe.

Test: fast/forms/listbox-clip.html

  • platform/mac/PlatformScrollBarMac.mm: (-[WebCoreScrollBar initWithPlatformScrollbar:]): Get the correct scrollbar width/height based on control size.
  • rendering/RenderListBox.cpp: Renamed optionsSpacingLeft to optionsSpacingHorizontal since it is applied on both sides. (WebCore::RenderListBox::calcMinMaxWidth): Account for optionsSpacingHorizontal. Not including the spacing before went unnoticed since the scrollbar was lying about its width by exactly the same amount. (WebCore::RenderListBox::paintObject): Clip out the scrollbar. (WebCore::RenderListBox::paintItemForeground): Changed for the rename.
3:35 AM Changeset in webkit [18647] by ap
  • 3 edits
    4 adds in trunk

2007-01-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Test: fast/repaint/erase-overflow.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): Added a repaint before changing hasOverflowClip to true, to ensure that the current overflow is erased.
3:26 AM Changeset in webkit [18646] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12106
Changed URL from WebResourceLoadDelegate's webView:resource:willSendRequest:... is ignored

3:26 AM Changeset in webkit [18645] by ap
  • 5 edits in trunk/LayoutTests

Re-apply r17618, which got reverted with CSS suite update.

Reviewed by Sam Weinig.

Fix a layout test failure that happened with additional fonts installed - replace a fancy
Unicode character with a plain asterisk.

  • css2.1/t0905-c414-flt-00-d-expected.checksum:
  • css2.1/t0905-c414-flt-00-d-expected.png:
  • css2.1/t0905-c414-flt-00-d-expected.txt:
  • css2.1/t0905-c414-flt-00-d.html:
3:14 AM Changeset in webkit [18644] by ap
  • 3 edits
    5 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=10313
xsl:import doesn't work in stylesheets loaded via XMLHttpRequest

This is a partial fix that makes a couple more steps towards fixing the problem.

Test: fast/xsl/transform-xhr-doc.xhtml

  • xml/XSLTProcessor.cpp: (WebCore::xsltStylesheetPointer): Pass an URL for the stylesheet. I'm not sure why this constructor even needs it, given that it has a Node, but this is a small modifications that makes XSLImportRule try to load from a correct URL. (WebCore::XSLTProcessor::transformToString): Fix the crash for real this time.
12:37 AM Changeset in webkit [18643] by rwlbuis
  • 8 edits
    4 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12125
overflow attribute of the symbol element not respected

Copy the attribute map to the cloned node so the overflow on
the symbol is respected.

Note: See TracTimeline for information about the timeline view.