Timeline



Jan 22, 2007:

11:00 PM Changeset in webkit [22813] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adele.

Implemented search field painting, and did some cleanup.

8:00 PM Changeset in webkit [19038] by bdash
  • 2 edits in trunk/WebCore

2007-01-22 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11692
Bug 11692: REGRESSION(r17352): Disappearing page title

  • dom/Document.cpp: (WebCore::Document::setTitle): If the title has already been set explicitly via JavaScript, ignore any changes to it due to encountering <title> tags.
6:23 PM Changeset in webkit [22812] by andersca
  • 6 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.


<rdar://problem/4771115>
Windows Media Player plugin crashes.

  • WebCore.vcproj/WebCore.vcproj: Formatting changes.


  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::defaultPluginPaths): Add Windows Media Player path.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::sendJavaScriptStream):
  • plugins/win/PluginStreamWin.h: New function which sends a JavaScript result stream and handles any errors that the plug-in returns.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setFrameGeometry): Always call NPP_SetWindow, some plugins (like WMP) relies on it.


(WebCore::PluginViewWin::performRequest):
If a plug-in requests a javascript: URL that doesn't evaluate to a string, call toString on it.
The Windows Media Player plugin calls javascript:document.location and expects to get the location back.

5:36 PM Changeset in webkit [19037] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/listbox-selection-2-expected.checksum: Added.
  • fast/forms/listbox-selection-2-expected.png: Added.
  • fast/forms/listbox-selection-2-expected.txt: Added.
  • fast/forms/listbox-selection-2.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/listbox-selection-2.html

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::numVisibleItems): Changed height() to contentHeight() since items are visible only in the content box. (WebCore::RenderListBox::listIndexAtOffset): Adjusted for vertical padding and borders. Changed to return -1 instead of the last item's index if the given offset is below the last item. (WebCore::RenderListBox::autoscroll): Adjusted for vertical padding and borders. (WebCore::RenderListBox::controlClipRect): Changed to return the content box since items should not spill into the padding box. This change is the reason the test generates pixel results.
5:30 PM Changeset in webkit [19036] by justing
  • 15 edits
    11 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/4944770>
editing/pasteboard/4641033 layout test is broken (12328)

The fixes not only make this test pass, but also fix a bug that
was reflected in the results checked in for this test. The caret
was in the wrong position:

  • editing/pasteboard/4641033-expected.checksum:
  • editing/pasteboard/4641033-expected.png:
  • editing/pasteboard/4641033-expected.txt: Added:
  • editing/pasteboard/4944770-1-expected.checksum: Added.
  • editing/pasteboard/4944770-1-expected.png: Added.
  • editing/pasteboard/4944770-1-expected.txt: Added.
  • editing/pasteboard/4944770-1.html: Added.
  • editing/pasteboard/4944770-2-expected.checksum: Added.
  • editing/pasteboard/4944770-2-expected.png: Added.
  • editing/pasteboard/4944770-2-expected.txt: Added.
  • editing/pasteboard/4944770-2.html: Added.
  • editing/pasteboard/4944770-expected.checksum: Added.
  • editing/pasteboard/4944770-expected.png: Added.
  • editing/pasteboard/4944770-expected.txt: Added. Equivalent render trees:
  • editing/execCommand/format-block-from-range-selection-expected.txt:
  • editing/pasteboard/drag-drop-modifies-page-expected.txt: Fixed:
  • editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
  • editing/pasteboard/nested-blocks-with-text-area-expected.png:
  • editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
  • editing/pasteboard/nested-blocks-with-text-field-expected.png:
  • editing/pasteboard/nested-blocks-with-text-field-expected.txt:

WebCore:

Reviewed by darin


<rdar://problem/4944770>
editing/pasteboard/4641033 layout test is broken (12328)


This layout test failure demonstrates three bugs:
Smart replace shouldn't be turned on, but is because a word
selection granularity from the previous test isn't cleared.
Smart replace shouldn't add any spaces because the paste is performed
in an empty paragraph.
Smart replace spaces are added to the text of options inside
the select element instead of before/after the select element.


This patch fixes the second two problems. During a
ReplaceSelectionCommand, the VisiblePosition for the end of
the inserted content is the last position in the last leaf
inserted. This is a problem when the last leaf is inside a
select element, since VP creation is inconsistent there.
Second, smart spaces were inserted inside the last leaf, not
at the endOfInsertedContent.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart): Renamed m_lastNodeInserted to m_lastLeafInserted. Use the start/endOfInsertedContent getters. (WebCore::ReplaceSelectionCommand::shouldMergeEnd): Ditto. (WebCore::ReplaceSelectionCommand::removeNodePreservingChildren): Ditto. (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Ditto. (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent): Added. Special case for when the last leaf inserted is inside a select element: return the VisiblePosition after the select element. (WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): Added. (WebCore::ReplaceSelectionCommand::doApply): Did renaming. Used the start/endOfInsertedContent getters. Insert smart replace spaces into the right nodes. (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): Renaming. (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Ditto. (WebCore::ReplaceSelectionCommand::updateNodesInserted): Ditto.
  • editing/ReplaceSelectionCommand.h:
4:51 PM Changeset in webkit [22811] by darin
  • 3 edits in branches/WindowsMerge/WebCore
  • WebCore.vcproj/WebCore.vcproj: Added FileChooser.cpp.
  • platform/win/FileChooserWin.cpp: Removed many now-unneeded functions. (WebCore::FileChooser::FileChooser): Updated for changed parameters and members. (WebCore::FileChooser::openFileChooser): Changed to take document parmaeter and find the FrameView from that instead of the upload control. (WebCore::FileChooser::basenameForWidth): Added ignored Font parameter.
4:46 PM Changeset in webkit [22810] by aroben
  • 9 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Anders, Brady, and Steve.

WebKit part of <rdar://problem/4601321> HTTP Authentication Alerts

Made WebURLCredential use a registered CLSID so the app can get instantiate it:

  • Interfaces/IWebURLAuthenticationChallenge.idl: Changed method name.
  • Interfaces/WebKit.idl: Added GUIDs for WebURLCredential.
  • WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance): Added case for WebURLCredential.
  • WebKitDLL.cpp: Added WebURLCredential and WebError (it was omitted from r11821). (DllGetClassObject):
  • WebURLAuthenticationChallenge.cpp: (WebURLAuthenticationChallenge::initWithProtectionSpace): Changed to use CLSID, and return the failing HRESULT. (WebURLAuthenticationChallenge::initWithAuthenticationChallenge): Changed to return the failing HRESULT.
  • WebURLAuthenticationChallengeSender.cpp: (WebURLAuthenticationChallengeSender::useCredential): Ditto.
  • WebURLCredential.cpp: Removed IID definition. (WebURLCredential::QueryInterface): Switched to use CLSID. (WebURLCredential::initWithUser): Updated method name.
  • WebURLCredential.h: Ditto.
4:40 PM Changeset in webkit [19035] by darin
  • 11 edits
    1 add in trunk/WebCore

Reviewed by Adam.

  • made more of the file chooser code cross-platform
  • fixed an Objective-C garbage collection problem in FileChooser
  • tried to remove layering violations where FileChooser in the platform directory knows about the rendering and DOM trees (but wasn't able to do it entirely)
  • platform/FileChooser.cpp: Added. (WebCore::FileChooser::create): Changed parameters. (WebCore::FileChooser::chooseFile): Changed to call chooseIcon function. (WebCore::FileChooser::chooseIcon): Added.
  • platform/FileChooser.h: Added FileChooserClient so this file doesn't have to know about RenderFileUploadControl. Used RetainPtr instead of retain/release so this works properly with Objective-C GC. Replaced disconnectUploadControl with disconnectClient, which has a simple inline implementation. Moved the Document parameter from the constructor to openFileChooser, along with a comment about why it should not be there. Added a filename parameter to the constructor for the initial filename. Added a font parameter to basenameForWidth so we don't depend on having a pointer to the renderer. Removed the uploadControl() and document() functions since no one calls either of them.
  • platform/mac/FileChooserMac.mm: Removed code that is now cross-platform. (-[OpenPanelController beginSheetWithFrame:]): Added frame parameter, instead of storing a document pointer in the FileChooser. (WebCore::FileChooser::FileChooser): Updated for changed parameters. Also added code to choose the icon based on the initial filename. Pass the adopt parameter to the constructor of the RetainPtr. (WebCore::FileChooser::~FileChooser): Removed the release call, since the RetainPtr will take care of it. Added a call to disconnectFileChooser here. There's no need to disconnect at disconnectClient time, and that lets us have one more cross-platform function. (WebCore::FileChooser::openFileChooser): Added document parameter. Added code to get the frame from the document. And added a nil check since there's no ironclad guarantee the document won't have outlived its frame. (WebCore::FileChooser::basenameForWidth): Added font parameter. Use that instead of going at the upload control's style. The caller can handle that now.
  • rendering/RenderFileUploadControl.h: Removed unnecessary includes. Made class inherit privately from FileChooserClient. Changed constructor parameter to HTMLInputElement rather than Node. Made protected members be private instead, and made a couple function members const.
  • rendering/RenderFileUploadControl.cpp: Moved constants to the top of the file, but after the "using namespace" (WebCore::RenderFileUploadControl::RenderFileUploadControl): Updated for changes to the FileChooser::create function and the parameter types. (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Removed unneeded null check -- there's no case where the FileChooser fails to be created. (WebCore::RenderFileUploadControl::click): Pass document to openFileChooser. (WebCore::RenderFileUploadControl::updateFromElement): Tweaked code a bit by using updateFromElement and setValue instead of casting the renderer to a RenderButton and calling setText directly. Put setInputType call here. (WebCore::RenderFileUploadControl::maxFilenameWidth): Made const. Broke long line. (WebCore::RenderFileUploadControl::createButtonStyle): Made const. (WebCore::RenderFileUploadControl::paintObject): Moved buttonShadowHeight constant to the top of the file. Call isEmpty instead of checking width and height of IntRect for 0. Computed font to pass to FileChooser::basenameForWidth. Broke long lines. (WebCore::HTMLFileUploadInnerButtonElement::HTMLFileUploadInnerButtonElement): Moved the setInputType call to the caller; concept here is that this class is as simple as possible, rather than doing as much of the button job as possible.
  • WebCore.xcodeproj/project.pbxproj: Added FileChooser.cpp.
  • WebCore.pro: Ditto.
  • CMakeLists.txt: Ditto.
  • WebCoreSources.bkl: Ditto.
  • platform/gdk/TemporaryLinkStubs.cpp: Updated stubs.
  • platform/qt/FileChooserQt.cpp: Updated stubs.
3:39 PM Changeset in webkit [22809] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-01-22 Steve Falkenburg <​sfalken@apple.com>

Updated strings not to be localized, added native line endings svn flag.

2:51 PM Changeset in webkit [19034] by bdakin
  • 5 edits in trunk/LayoutTests

Reviewed by Darin.

Darin and I looked into these tests that are adding an empty
RenderText, and we think they just need new results. Here they are!

  • editing/execCommand/find-after-replace-expected.txt:
  • fast/css/beforeSelectorOnCodeElement-expected.txt:
  • fast/forms/control-restrict-line-height-expected.txt:
  • fast/forms/select-size-expected.txt:
1:46 PM Changeset in webkit [22808] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4903230>
Boomer crashes at Flickr website when "View as slideshow" is clicked.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::bindingInstance): Return null if m_plugin is null (which it can be if the plugin failed to load).
1:37 PM Changeset in webkit [19033] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/select-item-background-clip-expected.checksum: Added.
  • fast/forms/select-item-background-clip-expected.png: Added.
  • fast/forms/select-item-background-clip-expected.txt: Added.
  • fast/forms/select-item-background-clip.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/select-item-background-clip.html

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemBackground): Intersect the item's rect with the list box's clip rect.
1:28 PM Changeset in webkit [19032] by sullivan
  • 2 edits in trunk/WebKit
  • WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Tiger build fix: remove unused variable for return value of dictionaryServiceWindowShow
1:15 PM Changeset in webkit [19031] by darin
  • 2 edits in trunk/WebCore

Reviewed by Beth.

I caused this a few hours ago. Oops!

  • rendering/RenderText.cpp: (WebCore::RenderText::setStyle): Compute whether the font changed before calling RenderObject::setStyle.
1:09 PM Changeset in webkit [19030] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Adam and Darin

  • fixed <rdar://problem/4794320> "Look Up in Dictionary" does nothing in WebKit (need to adopt new API)
  • Misc/WebNSURLExtras.m: (-[NSString _web_isUserVisibleURL]): random typo correction in comment
  • English.lproj/StringsNotToBeLocalized.txt: updated for these changes
  • WebView/WebHTMLView.mm: (coreGraphicsScreenPointForAppKitScreenPoint): new function to convert an AppKit screen point to a CG screen point (-[WebHTMLView _lookUpInDictionaryFromMenu:]): on Leopard now uses new API. There's something of an impedance mismatch between this API and WebKit, but that was true for the SPI we were using in Tiger also. Bug 4945808 covers the ways in which this is not perfect.
1:01 PM Changeset in webkit [22807] by andersca
  • 10 edits in branches/WindowsMerge/WebKitWin

Reviewed by Brady.

  • Interfaces/IWebError.idl: Clean up the IWebError interface.


  • Interfaces/WebKit.idl:
  • WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance): Make it possible for clients to create WebErrors.


  • WebError.cpp: (WebError::QueryInterface): (WebError::init):
  • WebError.h:
  • WebURLAuthenticationChallenge.cpp: (WebURLAuthenticationChallenge::initWithProtectionSpace): Get rid of IID_WebError and use CLSID_WebError instad.


  • WebView.cpp: (WebView::canHandleRequest): Return true for "about" URLs.


(WebView::canHandleRequest):
Add private COM method.


(WebView::close):
Reset the policy delegate.

12:54 PM Changeset in webkit [19029] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4912129> REGRESSION: Crash occurs at
WebCore::Frame::eventHandler() after clicking to dismiss a
contextual menu on the page

  • page/EventHandler.cpp: (WebCore::EventHandler::stopAutoscrollTimer): Added nil-check.
10:42 AM Changeset in webkit [22806] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • WebCore.vcproj/WebCore.vcproj:
10:10 AM Changeset in webkit [22805] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Moved ifdefs to match Darin's suggestion.

9:39 AM Changeset in webkit [19028] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Mitz.

  • a couple tiny tweaks to make --reset-results work better
  • Scripts/run-webkit-tests: Always generate results when --reset-results is specified. Don't make a separate "new" entry while generating results when --reset-results is specified since new results are the norm in that case.
9:30 AM Changeset in webkit [22804] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Build fix.

9:28 AM Changeset in webkit [19027] by darin
  • 28 edits
    8 adds in trunk

LayoutTests:

Test by Andrew Wellington <​proton@wiretapped.net>.
Reviewed by Darin.


  • fast/css/beforeSelectorOnCodeElement-expected.checksum: Added.
  • fast/css/beforeSelectorOnCodeElement-expected.png: Added.
  • fast/css/beforeSelectorOnCodeElement-expected.txt: Added.
  • fast/css/beforeSelectorOnCodeElement.html: Added.

Test by Mitz.
Reviewed by Darin.

  • test for monospace problem mentioned in the above bug


  • fast/text/monospace-width-cache-expected.checksum: Added.
  • fast/text/monospace-width-cache-expected.png: Added.
  • fast/text/monospace-width-cache-expected.txt: Added.
  • fast/text/monospace-width-cache.html: Added.

WebCore:

Reviewed by Mitz.

Inspired by a much simpler patch by Andrew Wellington <​proton@wiretapped.net>.

Test: fast/css/beforeSelectorOnCodeElement.html

  • fix regression I recently introduced where the monospace cache could be used for text that was not ASCII, if text was changed after the style was set

Test: fast/text/monospace-width-cache.html

  • streamline RenderText.h -- remove unneeded functions, make some needlessly virtual functions non-virtual, remove unneeded header includes, replace use of Font* with Font& for consistency with RenderStyle, use "text" consistently instead of "string"
  • rendering/RenderText.h: Removed unneeded include of "Text.h", declarations of SOFT_HYPHEN, DocumentMarker, InlineBox, Position, String. Got rid of friend declaration for InlineTextBox. Changed constructor to take a PassRefPtr since we do take owership of the passed-in text. Made deleteTextBoxes() private. Removed unneeded data(). Made override of length() private so people will use the faster textLength() instead. Renamed string() to text() so it matches up better with setText(). Same for stringLength(), originalString(), and setInternalString(), which are now textLength(), originalText(), and setTextInternal(). Renamed the old text() function to characters(), since it returns a pointer as StringImpl::characters does. Changed Font* to Font& everywhere. Renamed the internal calcMinMaxWidth() function to calcMinMaxWidthInternal() and made it non-virtual since it's not overriden anywhere. Also made the trimmedMinMaxWidth() function non-virtual. Made containsOnlyWhitespace() private. Removed both font() functions (one was needlessly virtual) and element(). Renamed cacheWidths() to updateMonospaceCharacterWidth() and removed the shouldUseMonospaceCache() function. Renamed allAscii() to isAllASCII() and made it an inline function. Removed the m_allAsciiChecked flag and renamed the m_allAscii flag to m_isAllASCII.
  • rendering/RenderText.cpp: (WebCore::RenderText::RenderText): Removed initialization of m_allAsciiChecked. Initialize m_isAllASCII. Changed all occurrences of m_str->length() and m_str->characters () to use the stringLength() and characters() inline functions instead. (WebCore::RenderText::setStyle): Replaced the unconditional call to cacheWidths with a conditional call to updateMonospaceCharacterWidth. This speeds up the common case where style is changed without changing the font. (WebCore::RenderText::originalText): Changed code to not depend on overridden element() function with casts to a Text node -- this was one of only two call sites. Also renamed. (WebCore::RenderText::positionForCoordinates): Name change. (WebCore::RenderText::caretRect): Ditto. (WebCore::RenderText::updateMonospaceCharacterWidth): Renamed from cacheWidths and incorporate the check that was formerly in a separate shouldUseMonospaceCache function. (WebCore::RenderText::widthFromCache): Changed to take a Font& instead of Font*. Changed to take advantage of the fact that the string is known to be all ASCII in the m_monospaceCharacterWidth code path. (WebCore::RenderText::trimmedMinMaxWidth): Ditto. Also use style()->font() instead of font(false). (WebCore::RenderText::calcMinMaxWidth): Ditto. Also changed to use softHyphen instead of SOFT_HYPHEN. (WebCore::RenderText::containsOnlyWhitespace): More of the same. (WebCore::RenderText::setSelectionState): Ditto. (WebCore::RenderText::setTextWithOffset): Ditto. (WebCore::isInlineFlowOrEmptyText): Ditto. (WebCore::RenderText::setTextInternal): Updated for name changes. Also changed to set the m_isAllASCII flag every time, in the more-efficient way we use elsewhere (or'ing all the characters together), and to call updateMonospaceCharacterWidth if the "all ASCII"-ness of the text changes. (WebCore::RenderText::setText): Updated for name changes. (WebCore::RenderText::width): More like above. (WebCore::RenderText::selectionRect): Ditto. (WebCore::RenderText::caretMaxOffset): Ditto. (WebCore::RenderText::previousOffset): Ditto. (WebCore::RenderText::nextOffset): Ditto.
  • dom/Position.cpp:
  • dom/Range.cpp:
  • editing/CompositeEditCommand.cpp:
  • editing/DeleteSelectionCommand.cpp:
  • editing/VisiblePosition.cpp:
  • html/HTMLElement.cpp: Added now-needed include of "Text.h" which is no longer included by "RenderText.h".
  • editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer):
  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::handleTextBox): (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Update for name changes of stringLength(), string(), and originalString() to textLength(), text(), and originalText(), and to always use textLength() instead of length() when we have a RenderText* rather than a RenderObject*.
  • editing/visible_units.cpp: (WebCore::startOfParagraph): Ditto. (WebCore::endOfParagraph): Ditto.
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Ditto. Also removed use of the RenderObject::font() function and replaced it with explicit access to the style. (WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): Ditto. (WebCore::InlineTextBox::isLineBreak): Ditto. (WebCore::InlineTextBox::paint): Ditto. (WebCore::InlineTextBox::selectionStartEnd): Ditto. (WebCore::InlineTextBox::paintSelection): Ditto. (WebCore::InlineTextBox::paintMarkedTextBackground): Ditto. (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Ditto. (WebCore::InlineTextBox::paintTextMatchMarker): Ditto. (WebCore::InlineTextBox::offsetForPosition): Ditto. (WebCore::InlineTextBox::positionForOffset): Ditto.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): Ditto.
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::originalText): Ditto. (WebCore::RenderCounter::calcMinMaxWidth): Ditto.
  • rendering/RenderCounter.h: Ditto.
  • rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::originalText): Ditto.
  • rendering/RenderTextFragment.h: Ditto.
  • rendering/SVGInlineFlowBox.cpp: (WebCore::placePositionedBoxesHorizontally): Ditto. (WebCore::placeBoxesVerticallyWithAbsBaseline): Ditto.
  • rendering/bidi.cpp: (WebCore::BidiIterator::increment): Ditto. (WebCore::BidiIterator::current): Ditto. (WebCore::BidiIterator::direction): Ditto. (WebCore::addRun): Ditto. (WebCore::checkMidpoints): Ditto. (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto. (WebCore::RenderBlock::skipWhitespace): Ditto. (WebCore::RenderBlock::findNextLineBreak): Ditto.
  • rendering/RenderBR.h: Updated signature of width function which now takes a Font& instead of a Font*.
  • rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace): Updated to no longer use the RenderObject::font() function, and added a comment about first-line, which is not handled properly here.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::text):
  • rendering/RenderTreeAsText.cpp: (WebCore::writeTextRun): Eliminated use of RenderText::data().
  • rendering/RenderObject.h: Removed RenderObject::font(). This had the bad effect of having everyone pass in a boolean rather than using the cleaner style() and firstLineStyle() functions in cases where there's no a firstLineStyle boolean.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::getVerticalPosition): Replaced use of RenderObject::font() with direct use of the style instead, which is arguably easier to understand anyway. (WebCore::RenderObject::baselinePosition): Ditto.
6:38 AM Changeset in webkit [19026] by weinig
  • 3 edits
    1 move in trunk/WebCore

Reviewed by The Mitz.

Move JSHTMLSelectElementCustom.cpp from bindings to bindings/js
where it belongs.

  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/JSHTMLSelectElementCustom.cpp: Removed.
  • bindings/js/JSHTMLSelectElementCustom.cpp: Added.
2:54 AM Changeset in webkit [19025] by zack
  • 2 edits in trunk/WebCore

Fix Qt build

Jan 21, 2007:

10:54 PM Changeset in webkit [22803] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Maciej.

Implemented drawing button states and control sizes.

9:23 PM Changeset in webkit [19024] by ap
  • 54 edits
    3 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=10934
REGRESSION: prototype.js logs error (HTMLFormElement) on webkit builds

Added constructors for most HTML elements; started auto-generating HTMLSelectElement JS binding.

Test: fast/dom/Window/element-constructors-on-window.html

  • DerivedSources.make: Generate JSHTMLSelectElement.
  • WebCore.xcodeproj/project.pbxproj: Added JSHTMLSelectElement{Custom}.
  • bindings/js/JSHTMLElementWrapperFactory.cpp: Create a proper binding for SELECT.
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLElement::getOwnPropertySlot): (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::put):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::): Removed everything related to SELECT. Renamed getHTMLOptionsCollection to toJS for autogenerated code to be happy, and rewrote it using cacheDOMObject.
  • bindings/scripts/CodeGeneratorJS.pm: Added HTMLElement to the list of types that cannot fail conversion.
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLTitleElement.idl:
  • html/HTMLUListElement.idl: Generate constructors.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::length):
  • html/HTMLSelectElement.h: Make length() return unsigned for auto-generated code to be happy.
  • html/HTMLSelectElement.idl: Adjusted to be usable for JS.
  • bindings/JSHTMLSelectElementCustom.cpp: Added. Implements remove().
  • page/DOMWindow.idl: Added properties for most elements' constructors.
8:54 PM Changeset in webkit [22802] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Maciej.

7:45 PM Changeset in webkit [19023] by bdash
  • 2 edits in trunk/WebCore

2007-01-21 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12357
Bug 12357: Reproducible crash in WebCore::Settings::isJavaScriptEnabled in svg/custom/js-update-bounce.svg under guard-malloc

  • page/Frame.cpp: (WebCore::Frame::~Frame): Access the global object directly rather than via Window::retrieveWindow to prevent our reference to a deleted settings object being used.
6:46 PM Changeset in webkit [19022] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fix <rdar://problem/4930503> REGRESSION: Page changes title when command-clicking on named anchor link (12299)
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): Return if shouldContinue is false. This matches the other similar functions and prevents us from doing extra work in the "ignore" case.
6:16 PM Changeset in webkit [19021] by bdash
  • 2 edits in trunk/WebCore

2007-01-21 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12355
Bug 12355: Reproducible crash in WebCore::parseNumber in svg/custom/js-update-bounce.svg under guard-malloc

  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::parseNumber): Parenthesize to prevent reading past end of buffer.
5:41 PM Changeset in webkit [22801] by adele
  • 2 edits
    2 adds in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adam.

Adding RenderThemeSafari.


5:33 PM Changeset in webkit [19020] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/select-disabled-appearance-expected.checksum: Added.
  • fast/forms/select-disabled-appearance-expected.png: Added.
  • fast/forms/select-disabled-appearance-expected.txt: Added.
  • fast/forms/select-disabled-appearance.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/select-disabled-appearance.html

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustMenuListStyle):
5:17 PM Changeset in webkit [19019] by darin
  • 4 edits in trunk/WebCore
  • fix non-Mac builds
  • CMakeLists.txt: Added JSDocumentCustom.cpp.
  • WebCore.pro: Ditto.
  • WebCoreSources.bkl: Ditto.
5:09 PM Changeset in webkit [19018] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/HTMLImageElement/constructor-mutation-event-dispatch-expected.txt: Added.
  • fast/dom/HTMLImageElement/constructor-mutation-event-dispatch.html: Added.

WebCore:

Reviewed by Darin.


Test: fast/dom/HTMLImageElement/constructor-mutation-event-dispatch.html

  • bindings/js/kjs_html.cpp: (KJS::ImageConstructorImp::construct): Protect the image element before setting its attributes.
4:54 PM Changeset in webkit [22800] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Added JSDocumentCustom.cpp.
4:53 PM Changeset in webkit [19017] by darin
  • 2 edits in trunk/WebKit

Reviewed by Tim H.

  • WebInspector/webInspector/inspector.css: Use row-resize for the splitter cursor instead of move. It's a horizontal splitter resizer.
3:42 PM Changeset in webkit [19016] by weinig
  • 4 edits
    4 deletes in trunk

LayoutTests:

Rolling out patch for ​http://bugs.webkit.org/show_bug.cgi?id=8360.

  • fast/layers/removed-by-scroll-handler-expected.checksum: Removed.
  • fast/layers/removed-by-scroll-handler-expected.png: Removed.
  • fast/layers/removed-by-scroll-handler-expected.txt: Removed.
  • fast/layers/removed-by-scroll-handler.html: Removed.

WebCore:

Rolling out patch for ​http://bugs.webkit.org/show_bug.cgi?id=8360.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::Marquee::start):
  • rendering/RenderLayer.h:
2:07 PM Changeset in webkit [19015] by ddkilzer
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/document-all-select-expected.txt: Added.
  • fast/dom/document-all-select.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/dom/document-all-select.html

  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): (WebCore::HTMLCollection::updateNameCache):
1:03 PM Changeset in webkit [19014] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • manual-tests/onblur-remove.html: Changed the test to not require pressing Enter, since the correct behavior for Enter is to send a blur event.
12:51 PM Changeset in webkit [19013] by weinig
  • 10 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for: <rdar://problem/4928583> Memory usage grows when reloading google.com/ig

  • fast/dom/gc-10-expected.txt: Added.
  • fast/dom/gc-10.html: Added.
  • fast/dom/resources/gc-10-frame.html: Added.

WebCore:

Reviewed by Darin.

Fix for: <rdar://problem/4928583> Memory usage grows when reloading google.com/ig

JSDocuments are now responsible for marking the DOM wrappers associated with them, when they get marked.
This fixes a JS object leak when a DOM wrapper has a reference to a JSDocument that is otherwise not reachable.

Test: fast/dom/gc-10.html

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDocumentCustom.cpp: Added. (WebCore::JSDocument::mark):
  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::markDOMNodesForDocument): (KJS::ScriptInterpreter::mark):
  • bindings/js/kjs_binding.h:
  • dom/Document.idl:

WebKitTools:

Reviewed by Darin.

Test support for: <rdar://problem/4928583> Memory usage grows when reloading google.com/ig

This adds a getJSObjectCount test-accessible function to allow test scripts to track JSObject usage.

  • DumpRenderTree/GCController.h:
  • DumpRenderTree/GCController.mm: (+[GCController isSelectorExcludedFromWebScript:]): (-[GCController getJSObjectCount]):
12:29 PM Changeset in webkit [19012] by weinig
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/overflow/position-relative-expected.checksum: Added.
  • fast/overflow/position-relative-expected.png: Added.
  • fast/overflow/position-relative-expected.txt: Added.
  • fast/overflow/position-relative.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/overflow/position-relative.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::lowestPosition): Add the relative position offset only if 'includeSelf' is true. (WebCore::RenderBox::rightmostPosition): Ditto. (WebCore::RenderBox::leftmostPosition): Ditto.
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::lowestPosition): Ditto. (WebCore::RenderFlow::rightmostPosition): Ditto. (WebCore::RenderFlow::leftmostPosition): Ditto.
9:19 AM Changeset in webkit [19011] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/HTMLSelectElement/options-collection-detached-expected.txt: Added.
  • fast/dom/HTMLSelectElement/options-collection-detached.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/dom/HTMLSelectElement/options-collection-detached.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setRecalcListItems): Reset the options collection info if the <select> is not in the document. For in-document <select>s this happens anyway as a result of the DOM tree version increasing.
9:05 AM Changeset in webkit [19010] by weinig
  • 7 edits in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/file-input-disabled-expected.checksum:
  • fast/forms/file-input-disabled-expected.png:
  • fast/forms/file-input-disabled-expected.txt:

WebCore:

Reviewed by Darin.

Covered by fast/forms/file-input-disabled.html

  • css/html4.css: Changed selectors that had pseudo-classes after the -webkit-file-upload-button pseudo-element to have the pseudo-element at the end. Pseudo-elements must be at the end.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::createButtonStyle): Changed to not overwrite the button's style with its parent's style. getPseudoStyle() handles inheritance properly.
8:55 AM Changeset in webkit [19009] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • platform/Font.cpp: (WebCore::Font::glyphDataForCharacter):
8:20 AM Changeset in webkit [19008] by darin
  • 3 edits in trunk/WebCore

Reviewed by Adam and Mitz.

Covered by existing test: fast/forms/listbox-selection.html

  • rendering/RenderListBox.h: Added override of layout(), made selectionChanged() no longer an inline. Added private scrollToRevealSelection(), m_scrollToRevealSelectionAfterLayout, and m_inAutoscroll.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::RenderListBox): Initialize new data members. (WebCore::RenderListBox::updateFromElement): Remove scrolling code. (WebCore::RenderListBox::selectionChanged): Moved from header. Calls repaint and then scrollToRevealSelection, but if we need layout, instead schedules scrollToRevealSelection to be done after layout. (WebCore::RenderListBox::layout): Added. After calling base class, calls scrollToRevealSelection if the m_scrollToRevealSelectionAfterLayout is set. (WebCore::RenderListBox::scrollToRevealSelection): Added. Code was originally in updateFromElement. (WebCore::RenderListBox::autoscroll): Set m_inAutoscroll so that the selectionChanged function knows not to scroll. Also removed the repaint() here because updateListBoxSelection() takes care of repainting by calling selectionChanged().
5:07 AM Changeset in webkit [19007] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by NOBODY (no-svg build fix).

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): Changed #if SVG_SUPPORT to #ifdef SVG_SUPPORT.

Jan 20, 2007:

4:44 PM Changeset in webkit [19006] by weinig
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/forms/text-set-value-crash-expected.txt: Added.
  • fast/forms/text-set-value-crash.html: Added.

WebCore:

Reviewed by Maciej.

Test: fast/forms/text-set-value-crash.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): Added a call to Document::updateRendering().
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue): Ditto.
4:35 PM Changeset in webkit [19005] by weinig
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/layers/removed-by-scroll-handler-expected.checksum: Added.
  • fast/layers/removed-by-scroll-handler-expected.png: Added.
  • fast/layers/removed-by-scroll-handler-expected.txt: Added.
  • fast/layers/removed-by-scroll-handler.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/layers/removed-by-scroll-handler.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::dispatchScrollEvent): Added. Called when the timer fires and dispatches the scroll event to the layer's element. (WebCore::RenderLayer::scrollToOffset): Instead of dispatching the scroll event from this function, which is called during layout, schedule a 0-duration timer to dispatch the event after layout. (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::Marquee::start):
  • rendering/RenderLayer.h:
3:45 PM Changeset in webkit [19004] by zimmermann
  • 1 edit
    12 adds in trunk/LayoutTests

Forgot to include the new layout tests in the last commit.

3:40 PM Changeset in webkit [19003] by zimmermann
  • 14 edits in trunk/WebCore

Reviewed by Sam.

Fix JS bindings for SVGAnimated{Boolean, Enumeration, Integer, Number, String}.

Dynamic SVG DOM updates (ie. "someUse.href.baseVal = '#rect'") with these types
didn't work. Existing gradient updating examples relied on calling setAttribute
after a SVG DOM update - that was the only reason it worked, added a new test
only using SVG DOM updates (js-update-stop.svg).

1:52 PM Changeset in webkit [19002] by rwlbuis
  • 5 edits
    1 add in trunk/WebCore

Reviewed by Sam.

​http://bugs.webkit.org/show_bug.cgi?id=12334
Respect <text> boundaries for svg text selecting

Make sure the text selection for svg stays inside
containing blocks.
Added one manual test since html selection does not
seem to work for SVG and selectSubString for SVG
is not implemented yet.

7:03 AM Changeset in webkit [19001] by darin
  • 27 edits
    88 adds in trunk/LayoutTests
  • updated results because my recent check-in made list boxes one pixel taller
  • fast/forms/HTMLOptionElement_label05-expected.checksum:
  • fast/forms/HTMLOptionElement_label05-expected.png:
  • fast/forms/HTMLOptionElement_label05-expected.txt:
  • fast/forms/form-element-geometry-expected.checksum:
  • fast/forms/form-element-geometry-expected.png:
  • fast/forms/form-element-geometry-expected.txt:
  • fast/forms/listbox-clip-expected.checksum:
  • fast/forms/listbox-clip-expected.png:
  • fast/forms/listbox-clip-expected.txt:
  • fast/forms/listbox-width-change-expected.checksum:
  • fast/forms/listbox-width-change-expected.png:
  • fast/forms/listbox-width-change-expected.txt:
  • fast/forms/option-strip-whitespace-expected.checksum:
  • fast/forms/option-strip-whitespace-expected.png:
  • fast/forms/option-strip-whitespace-expected.txt:
  • fast/forms/select-change-popup-to-listbox-expected.checksum:
  • fast/forms/select-change-popup-to-listbox-expected.png:
  • fast/forms/select-change-popup-to-listbox-expected.txt:
  • fast/replaced/replaced-breaking-expected.checksum:
  • fast/replaced/replaced-breaking-expected.png:
  • fast/replaced/replaced-breaking-expected.txt:
  • fast/text/updateNewFont-expected.checksum:
  • fast/text/updateNewFont-expected.png:
  • fast/text/updateNewFont-expected.txt:
  • reset results since the ones I generated before were on Leopard
  • fast/forms/select-list-box-with-height-expected.checksum:
  • fast/forms/select-list-box-with-height-expected.png:
  • generated some missing pixel results
  • http/tests/navigation/anchor-basic-expected.checksum: Added.
  • http/tests/navigation/anchor-basic-expected.png: Added.
  • http/tests/navigation/anchor-frames-expected.checksum: Added.
  • http/tests/navigation/anchor-frames-expected.png: Added.
  • http/tests/navigation/anchor-goback-expected.checksum: Added.
  • http/tests/navigation/anchor-goback-expected.png: Added.
  • http/tests/navigation/anchor-subframeload-expected.checksum: Added.
  • http/tests/navigation/anchor-subframeload-expected.png: Added.
  • http/tests/navigation/error404-basic-expected.checksum: Added.
  • http/tests/navigation/error404-basic-expected.png: Added.
  • http/tests/navigation/error404-frames-expected.checksum: Added.
  • http/tests/navigation/error404-frames-expected.png: Added.
  • http/tests/navigation/error404-goback-expected.checksum: Added.
  • http/tests/navigation/error404-goback-expected.png: Added.
  • http/tests/navigation/error404-subframeload-expected.checksum: Added.
  • http/tests/navigation/error404-subframeload-expected.png: Added.
  • http/tests/navigation/javascriptlink-basic-expected.checksum: Added.
  • http/tests/navigation/javascriptlink-basic-expected.png: Added.
  • http/tests/navigation/javascriptlink-frames-expected.checksum: Added.
  • http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • http/tests/navigation/javascriptlink-goback-expected.checksum: Added.
  • http/tests/navigation/javascriptlink-goback-expected.png: Added.
  • http/tests/navigation/javascriptlink-subframeload-expected.checksum: Added.
  • http/tests/navigation/javascriptlink-subframeload-expected.png: Added.
  • http/tests/navigation/metaredirect-basic-expected.checksum: Added.
  • http/tests/navigation/metaredirect-basic-expected.png: Added.
  • http/tests/navigation/metaredirect-frames-expected.checksum: Added.
  • http/tests/navigation/metaredirect-frames-expected.png: Added.
  • http/tests/navigation/metaredirect-goback-expected.checksum: Added.
  • http/tests/navigation/metaredirect-goback-expected.png: Added.
  • http/tests/navigation/metaredirect-subframeload-expected.checksum: Added.
  • http/tests/navigation/metaredirect-subframeload-expected.png: Added.
  • http/tests/navigation/post-basic-expected.checksum: Added.
  • http/tests/navigation/post-basic-expected.png: Added.
  • http/tests/navigation/post-frames-expected.checksum: Added.
  • http/tests/navigation/post-frames-expected.png: Added.
  • http/tests/navigation/post-goback1-expected.checksum: Added.
  • http/tests/navigation/post-goback1-expected.png: Added.
  • http/tests/navigation/post-goback2-expected.checksum: Added.
  • http/tests/navigation/post-goback2-expected.png: Added.
  • http/tests/navigation/postredirect-basic-expected.checksum: Added.
  • http/tests/navigation/postredirect-basic-expected.png: Added.
  • http/tests/navigation/postredirect-frames-expected.checksum: Added.
  • http/tests/navigation/postredirect-frames-expected.png: Added.
  • http/tests/navigation/postredirect-goback1-expected.checksum: Added.
  • http/tests/navigation/postredirect-goback1-expected.png: Added.
  • http/tests/navigation/postredirect-goback2-expected.checksum: Added.
  • http/tests/navigation/postredirect-goback2-expected.png: Added.
  • http/tests/navigation/redirect302-basic-expected.checksum: Added.
  • http/tests/navigation/redirect302-basic-expected.png: Added.
  • http/tests/navigation/redirect302-frames-expected.checksum: Added.
  • http/tests/navigation/redirect302-frames-expected.png: Added.
  • http/tests/navigation/redirect302-goback-expected.checksum: Added.
  • http/tests/navigation/redirect302-goback-expected.png: Added.
  • http/tests/navigation/redirect302-subframeload-expected.checksum: Added.
  • http/tests/navigation/redirect302-subframeload-expected.png: Added.
  • http/tests/navigation/relativeanchor-basic-expected.checksum: Added.
  • http/tests/navigation/relativeanchor-basic-expected.png: Added.
  • http/tests/navigation/relativeanchor-frames-expected.checksum: Added.
  • http/tests/navigation/relativeanchor-frames-expected.png: Added.
  • http/tests/navigation/relativeanchor-goback-expected.checksum: Added.
  • http/tests/navigation/relativeanchor-goback-expected.png: Added.
  • http/tests/navigation/slowmetaredirect-basic-expected.checksum: Added.
  • http/tests/navigation/slowmetaredirect-basic-expected.png: Added.
  • http/tests/navigation/slowtimerredirect-basic-expected.checksum: Added.
  • http/tests/navigation/slowtimerredirect-basic-expected.png: Added.
  • http/tests/navigation/success200-basic-expected.checksum: Added.
  • http/tests/navigation/success200-basic-expected.png: Added.
  • http/tests/navigation/success200-frames-expected.checksum: Added.
  • http/tests/navigation/success200-frames-expected.png: Added.
  • http/tests/navigation/success200-frames-loadsame-expected.checksum: Added.
  • http/tests/navigation/success200-frames-loadsame-expected.png: Added.
  • http/tests/navigation/success200-goback-expected.checksum: Added.
  • http/tests/navigation/success200-goback-expected.png: Added.
  • http/tests/navigation/success200-loadsame-expected.checksum: Added.
  • http/tests/navigation/success200-loadsame-expected.png: Added.
  • http/tests/navigation/success200-reload-expected.checksum: Added.
  • http/tests/navigation/success200-reload-expected.png: Added.
  • http/tests/navigation/success200-subframeload-expected.checksum: Added.
  • http/tests/navigation/success200-subframeload-expected.png: Added.
  • http/tests/navigation/timerredirect-basic-expected.checksum: Added.
  • http/tests/navigation/timerredirect-basic-expected.png: Added.
  • http/tests/navigation/timerredirect-frames-expected.checksum: Added.
  • http/tests/navigation/timerredirect-frames-expected.png: Added.
  • http/tests/navigation/timerredirect-goback-expected.checksum: Added.
  • http/tests/navigation/timerredirect-goback-expected.png: Added.
  • http/tests/navigation/timerredirect-subframeload-expected.checksum: Added.
  • http/tests/navigation/timerredirect-subframeload-expected.png: Added.
1:14 AM Changeset in webkit [19000] by bdash
  • 2 edits in trunk/WebKitTools

2007-01-20 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

  • BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Track the output of run-javascriptcore-tests, catch single regressions, and don't generate tests results for new tests.
12:45 AM Changeset in webkit [18999] by aroben
  • 2 edits in trunk/WebKitTools

Rubberstamped by Maciej.

  • Scripts/run-webkit-tests: Change the default behavior back to generating results for new tests (this can be disabled with --no-new-test-results)

Jan 19, 2007:

11:07 PM Changeset in webkit [18998] by aroben
  • 1 edit in branches/Safari-2-0-branch/WebKit/ChangeLog

Fixed ChangeLog.

7:21 PM Changeset in webkit [18997] by kdecker
  • 6 edits in branches/Safari-2-0-branch/WebKit

Reviewed by Adam.


Merged r10259 and r15845 from TOT to Safari-2-0-branch.

2006-08-11 Tim Omernick <​timo@apple.com>

Reviewed by Darin.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=10111> - Menu flickers over Flash content
<rdar://problem/3052546> Plugins don't work with z-index (overlapping elements, etc.)

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Don't just clip to the dirty region for "transparent" plug-ins -- do it for all plug-ins. This is a generally useful thing to do, as it prevents the plug-in from drawing over parts of the window that have already been drawn and are not expected to be redrawn in the same update.

2005-09-13 Tim Omernick <​tomernick@apple.com>

Reviewed by Justin Garcia, Darin Adler.

  • <rdar://problem/3163393> Safari does not support Windowless mode in Flash
  • Plugins.subproj/WebBaseNetscapePluginView.h:

Added 'isTransparent' instance variable.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]):

When updating a plugin in "windowless" (transparent) mode, clip drawing to the dirty
region of the opaque ancestor. This means that a partially-transparent plugin, which
by definition does not clear its port on redraw, will not overdraw the valid parts
of its port.

(-[WebBaseNetscapePluginView sendEvent:]):

Disabled the "green debug background" for transparent plugins -- since they are not
expected to cover their entire port every redraw, this debug code makes no sense.

(-[WebBaseNetscapePluginView setVariable:value:]):

Implemented -setVariable:value:, which is called from NPN_SetValue() (previously
unimplemented).
Right now we only handle NPPVpluginTransparentBool; if we choose to handle the other
plugin variables, then we may do so here.

  • Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:

Added SPI for -[WebBaseNetscapePluginView setVariable:value].

  • Plugins.subproj/npapi.m: (NPN_SetValue):

Implemented this function so that plugins may set state (such as window mode).


4:40 PM Changeset in webkit [18996] by adele
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/4697438> REGRESSION: select menu lists match the wrong css rule on www.chainreaction.com

  • fast/forms/select-size-expected.checksum: Added.
  • fast/forms/select-size-expected.png: Added.
  • fast/forms/select-size-expected.txt: Added.
  • fast/forms/select-size.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for: <rdar://problem/4697438> REGRESSION: select menu lists match the wrong css rule on www.chainreaction.com

Update the size attribute value for select elements to match the numeric value. This is a special case since this
attribute is used to determine which control to use. We want to make sure that the size attribute is valid when we match
CSS rules.

Test: fast/forms/select-size.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): If the attribute string value is not the same as its integer value, then update the attribute value to match the integer.
  • dom/Attribute.h: Made setValue and setPrefix public.
4:33 PM Changeset in webkit [22799] by adachan
  • 4 edits
    1 add in branches/WindowsMerge/WebKitWin

2007-01-19 Ada Chan <​adachan@apple.com>

WebKitWin:

Fixed build.

Reviewed by Anders.
Added IWebResourceLoadDelegatePrivate which has one method: didLoadResourceFromMemoryCache.

  • ChangeLog:
  • Interfaces/IWebResourceLoadDelegatePrivate.idl: Added.
  • WebFrame.cpp: (WebFrame::dispatchDidFinishDocumentLoad):
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:


4:32 PM Changeset in webkit [18995] by aroben
  • 3 edits in trunk/WebKit

Reviewed by Beth.

Fix <rdar://problem/4942294> REGRESSION: "Spelling and Grammar",
"Font", "Speech", and "Writing Direction" are missing from contextual
menu

  • WebCoreSupport/WebContextMenuClient.mm: (fixMenusForOldClients): Change our new SPI tags to WebMenuItemTagOther because old clients aren't expecting the new tags. (fixMenusFromOldClients): Use each menu item's title to figure out its correct tag again. (WebContextMenuClient::getCustomMenuFromDefaultItems): Call fixMenusForOldClients before calling up to the delegate.
  • WebView/WebUIDelegatePrivate.h: Define WEBMENUITEMTAG_SPI_START so that we can use it in WebContextMenuClient.
4:14 PM Changeset in webkit [22798] by sullivan
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Lou.


Added mechanism for new callbacks, to try to avoid breaking the Windows build.

  • Interfaces/IWebFrameLoadDelegatePrivate.idl:
  • WebFrame.cpp: (WebFrame::dispatchDidFinishDocumentLoad):
  • WebFrame.h:
4:02 PM Changeset in webkit [18994] by sullivan
  • 13 edits in trunk

WebCore:

Reviewed by Darin

  • WebCore part of fix for: <rdar://problem/4451715> REGRESSION: On some sites, have to type a character before username/password autofill kicks in
  • loader/FrameLoaderClient.h: new dispatchDidFinishDocumentLoad call
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedParsing): call dispatchDidFinishDocumentLoad


  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishDocumentLoad): empty implementation for dispatchDidFinishDocumentLoad

WebKit:

Reviewed by Darin

  • WebKit part of fix for: <rdar://problem/4451715> REGRESSION: On some sites, have to type a character before username/password autofill kicks in


Added new webView:didFinishDocumentLoadForFrame: SPI and wired it up

  • WebView/WebViewPrivate.h: declare new delegate method
  • WebCoreSupport/WebFrameLoaderClient.h: declare dispatchDidFinishDocumentLoad()
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidFinishDocumentLoad): new method, calls new delegate method
  • DefaultDelegates/WebDefaultFrameLoadDelegate.m: (-[WebDefaultFrameLoadDelegate webView:didFinishDocumentLoadForFrame:]): empty default implementation of new delegate method

WebKitQt:

Added stubs for new callbacks, to try to avoid breaking the Qt port.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidFinishDocumentLoad):
  • WebCoreSupport/FrameLoaderClientQt.h:
3:48 PM Changeset in webkit [18993] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/4760280> REGRESSION: Bottom portion of text hangs off edge of SELECT element at ​http://macreviewzone.com/index.php

  • fast/forms/control-restrict-line-height-expected.checksum: Added.
  • fast/forms/control-restrict-line-height-expected.png: Added.
  • fast/forms/control-restrict-line-height-expected.txt: Added.
  • fast/forms/control-restrict-line-height.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/4760280> REGRESSION: Bottom portion of text hangs off edge of SELECT element at ​http://macreviewzone.com/index.php


Test: fast/forms/control-restrict-line-height.html

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::setFontFromControlSize): Don't honor line-height for controls that have restricted font size.
3:18 PM Changeset in webkit [18992] by andersca
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

​http://bugs.webkit.org/show_bug.cgi?id=12308
REGRESSION(r18910): Crash in WebBaseNetscapePluginStream cancelLoadAndDestroyStreamWithError


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): Move code from initWithFrame in here.
3:15 PM Changeset in webkit [18991] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Fix date.

3:15 PM Changeset in webkit [18990] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Fix bug number.

3:12 PM Changeset in webkit [18989] by darin
  • 8 edits
    8 adds in trunk

LayoutTests:

Reviewed by Adele.

  • test for html4.css problem where we had a missing semicolon and thus missed parsing a style rule
  • fast/forms/radio-no-theme-padding-expected.txt: Added.
  • fast/forms/radio-no-theme-padding.html: Added.
  • fast/forms/select-list-box-mouse-focus-expected.txt: Added.
  • fast/forms/select-list-box-mouse-focus.html: Added.

Note: Only the pixel test shows the failure in the old version.

Note: I generated the pixel results on Leopard -- may need to be
regenated on Tiger.

  • fast/forms/select-list-box-with-height-expected.checksum: Added.
  • fast/forms/select-list-box-with-height-expected.png: Added.
  • fast/forms/select-list-box-with-height-expected.txt: Added.
  • fast/forms/select-list-box-with-height.html: Added.

WebCore:

Reviewed by Adele.

  • fix ​http://bugs.webkit.org/show_bug.cgi?id=11999 <rdar://problem/4940442> REGRESSION: Incomplete listing in TVListings window (11999) Fix was to use the actual size of the renderer in the RenderListBox case, instead of always using the size specified by the select element.

Test: fast/forms/select-list-box-with-height.html

Test: fast/forms/select-list-box-mouse-focus.html

  • fix bug where auto-scrolling was not working in list box select elements

No test yet.

  • fix a missing semicolon in the radio/checkbox section of html4.css

Test: fast/forms/radio-no-theme-padding.html

  • fix bug where the scroll bars for select elements were pixel-type scroll bars even though the scrolling is line at a time scrolling

No test.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::selectAll): Removed an explicit call to repaint, since the RenderListBox now does that in selectionChanged. (WebCore::HTMLSelectElement::notifyOptionSelected): Call the new selectionChanged instead of the old setSelectionChanged. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Added a call to focus. Removed an explicit call to repaint and added a call to the new setMouseDownMayStartAutoscroll function in EventHandler. Removed an explicit call to repaint as above. (WebCore::HTMLSelectElement::updateListBoxSelection): Call the new selectionChanged instead of the old setSelectionChanged.
  • page/EventHandler.h: Added setMouseDownMayStartAutoscroll, needed because the existing code to set that flag won't get triggered when the select element's default event handler handles the event.
  • rendering/RenderListBox.h: Made ScrollbarClient a private base class. Removed setSelectionChanged and m_selectionChanged. Added selectionChanged, which is really just a synonym for repaint for now. Moved valueChanged, the ScrollbarClient function implementations, and itemHeight into the private part of the class. Added numVisibleItems() and listHeight() to the private section. Changed m_vBar to be a RefPtr.
  • rendering/RenderListBox.cpp: Removed unneeded includes. Moved all the constants to the top of the file. (WebCore::RenderListBox::RenderListBox): Removed initialization of m_selectionChanged because it was removed and of m_vBar because it's now a RefPtr which is automaticall initialized. (WebCore::RenderListBox::~RenderListBox): Removed the explicit deref of m_vBar because it's a RefPtr. Added null checking for FrameView. (WebCore::RenderListBox::updateFromElement): Use numItems(). (WebCore::RenderListBox::calcMinMaxWidth): Added null checking for FrameView and used RefPtr for the newly-created scroll bar. (WebCore::RenderListBox::size): Tweaked formatting. Also renamed the misleading minDefaultSize to maxDefaultSize, since it's a maximum. (WebCore::RenderListBox::numVisibleItems): Added. Used in many places where size() was used before. This computes the number of rows we have room for. We don't need a row space after the last row, and this takes that into account. (WebCore::RenderListBox::numItems): Tweaked to remove the local variable. (WebCore::RenderListBox::listHeight): Added. Total height of all the rows and spaces between them. (WebCore::RenderListBox::calcHeight): Changed to call itemHeight for the row height, and to subtract the last row spacing off since we don't need a space after the last row. Changed the scroll bar setup to make it correspond to row numbers, not pixel numbers. (WebCore::RenderListBox::baselinePosition): Moved the comment to the constant declaration at the top of the file. (WebCore::RenderListBox::itemBoundingBoxRect): Simplified by using the itemHeight() function. (WebCore::RenderListBox::paintObject): Changed to use numItems and to use numVisibleItems instead of size. (WebCore::RenderListBox::isPointInScrollbar): Added get() call since m_vBar is now a RefPtr. (WebCore::RenderListBox::listIndexAtOffset): Changed to use numItems(), itemHeight(), and rearranged a min/max combo so it starts with the low, then the value, then the high value for pinning. (WebCore::RenderListBox::autoscroll): Use numVisibleItems() instead of size(). (WebCore::RenderListBox::stopAutoscroll): Removed an unneeded nil check of the element. (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Changed to use numItems() and to use numVisibleItems() instead of size(). Also changed scroll bar code to work more simply now that the scroll bar is row-based. (WebCore::RenderListBox::listIndexIsVisible): Changed to use numVisibleItems() instead of size(). (WebCore::RenderListBox::valueChanged): Simplified since the scrollbar is now row-based. Also removed an unnecessary null check. (WebCore::RenderListBox::itemHeight): Updated for name change from optionsSpacingMiddle to rowSpacing. (WebCore::RenderListBox::scrollHeight): Changed to use listHeight(). (WebCore::RenderListBox::setScrollTop): Simplified, and removed the code that does nothing if the computed list index is visible (which did not make sense for this function and seemed a cut and paste error from the scrollToReveal function). The scrollbar part is simpler now that it's row-based. (WebCore::RenderListBox::windowClipRect): Changed to use document()->view() so we don't have to include RenderView.h.
  • css/html4.css: Added a semicolon I noticed was missing.
2:36 PM Changeset in webkit [22797] by beidson
  • 6 edits in branches/WindowsMerge/WebKitWin

Reviewed by Ada

Much more realistic WebDownload interface that delegates will actually have to implement


  • Interfaces/IWebDownload.idl:

Also updated svn:eol-style on .idls

1:57 PM Changeset in webkit [18988] by bdakin
  • 8 edits
    8 adds
    4 deletes in trunk

WebCore:

Reviewed by Maciej and Darin.

Fix for <rdar://problem/4702420> REGRESSION: Null characters need
to be stripped from text nodes (townhall.com)

This was a regression from the fix for <rdar://problem/3727939>
Safari strips \0 characters from HTML tags making them valid, which
was fixed with r12652. We still need to strip null characters in
text nodes.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write): No behavior change here, this is just to make Darin happy. (WebCore::HTMLTokenizer::processToken): Call into StringImpl's new createStrippingNull function instead of the normal StringImpl constructor.
  • platform/StringImpl.cpp: (WebCore::StringImpl::createStrippingNull): Strip null.
  • platform/StringImpl.h:

LayoutTests:

Reviewed by Maciej and Darin.

New layout tests and some updates results for the fix for <rdar://
problem/4702420> REGRESSION: Null characters need to be stripped
from text nodes (townhall.com)

  • fast/dom/stripNullFromTextNodes-expected.checksum: Added.
  • fast/dom/stripNullFromTextNodes-expected.png: Added.
  • fast/dom/stripNullFromTextNodes-expected.txt: Added.
  • fast/dom/stripNullFromTextNodes.html: Added.
  • fast/js/null-char-in-string-expected.txt: New results.
  • fast/text/stripNullFromText-expected.checksum: Added.
  • fast/text/stripNullFromText-expected.png: Added.
  • fast/text/stripNullFromText-expected.txt: Added.
  • fast/text/stripNullFromText.html: Added.
  • tables/mozilla/images/adforce_imgis_com-expected.txt: New results.
  • tables/mozilla_expected_failures/images/adforce_imgis_com- expected.checksum: Removed. This is the same test as the one above. The same test was in two places.
  • tables/mozilla_expected_failures/images/adforce_imgis_com- expected.png: Removed.
  • tables/mozilla_expected_failures/images/adforce_imgis_com- expected.txt: Removed.
  • tables/mozilla_expected_failures/images/adforce_imgis_com.html: Removed.
1:16 PM Changeset in webkit [18987] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by NOBODY (no-svg build fix).

  • ksvg2/svg/SVGMPathElement.cpp: Added #ifdef SVG_SUPPORT/#endif guards.
12:47 PM Changeset in webkit [22796] by adachan
  • 10 edits
    2 adds in branches/WindowsMerge

2007-01-18 Ada Chan <​adachan@apple.com>

Reviewed by Steve.


WebKitWin:

<rdar://4601522> Activity Window

  • Added some NSURL equivalent constants in IWebURLResponse.idl and IWebError.idl
  • Added IWebErrorPrivate.idl which contains some private error codes
  • Added IWebHTTPURLResponse interface which extends IWebURLResponse. It has the same API as NSHTTPURLResponse.

WebCoreWin:

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
  • Interfaces/IWebError.idl:
  • Interfaces/IWebErrorPrivate.idl: Added.
  • Interfaces/IWebHTTPURLResponse.idl: Added.
  • Interfaces/IWebResourceLoadDelegate.idl: fixed a typo in parameter name
  • Interfaces/IWebURLResponse.idl: added WebURLResponseUnknownLength
  • WebKit.vcproj/Interfaces.vcproj: for adding IWebErrorPrivate.idl and IWebHTTPURLResponse.idl
  • WebKit.vcproj/WebKitGUID.vcproj: for the new IID_IWebHTTPURLResponse
  • WebURLResponse.cpp: (WebURLResponse::QueryInterface): also returns the new IWebHTTPURLResponse interface (WebURLResponse::allHeaderFields): Added stub for IWebHTTPURLResponse::allHeaderFields. (WebURLResponse::localizedStringForStatusCode): Added stub for IWebHTTPURLResponse::localizedStringforStatusCode (WebURLResponse::statusCode): Implemented IWebHTTPURLResponse::statusCode.
  • WebURLResponse.h:


10:25 AM Changeset in webkit [18986] by andersca
  • 3 edits in trunk/WebKit

Yet another build fix.


  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::setStatusbarText):
10:12 AM Changeset in webkit [22795] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Add SVG files.
9:59 AM Changeset in webkit [18985] by andersca
  • 3 edits in trunk/WebKitQt

Try fixing the QT build.


  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runJavaScriptAlert): (WebCore::ChromeClientQt::runJavaScriptConfirm): (WebCore::ChromeClientQt::runJavaScriptPrompt): (WebCore::ChromeClientQt::setStatusbarText):
  • WebCoreSupport/ChromeClientQt.h:
9:58 AM Changeset in webkit [22794] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::enabled): Use correct class name.
9:52 AM Changeset in webkit [18984] by andersca
  • 2 edits in trunk/WebCore

Build fix.


  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::setStatusbarText):
9:42 AM Changeset in webkit [22793] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

The obligatory build fix.


  • WebChromeClient.cpp: (WebChromeClient::runJavaScriptPrompt):
9:38 AM Changeset in webkit [22792] by andersca
  • 9 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Remove some unused FrameWin functions.


  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::~FrameWin):
  • bridge/win/FrameWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::status):

WebKitWin:

Reviewed by Adam.

  • WebChromeClient.cpp: (WebChromeClient::runJavaScriptAlert): (WebChromeClient::runJavaScriptConfirm): (WebChromeClient::runJavaScriptPrompt): (WebChromeClient::setStatusbarText):
  • WebChromeClient.h: Add new ChromeClient methods.


  • WebFrame.cpp: (WebFrame::userAgent): (WebFrame::updateGlobalHistoryForReload):
  • WebFrame.h: Remove unused FrameWinClient functions.
9:28 AM Changeset in webkit [18983] by andersca
  • 15 edits in trunk

WebCore:

Reviewed by Adam.

Move JavaScript alert and status bar functions to the chrome.


  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • page/Chrome.cpp: (WebCore::Chrome::runJavaScriptAlert): (WebCore::Chrome::runJavaScriptConfirm): (WebCore::Chrome::runJavaScriptPrompt): (WebCore::Chrome::setStatusBarText):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Frame.cpp: (WebCore::Frame::setJSStatusBarText): (WebCore::Frame::setJSDefaultStatusBarText):
  • page/Frame.h:
  • page/mac/FrameMac.h:
  • page/mac/FrameMac.mm:
  • page/mac/WebCoreFrameBridge.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::runJavaScriptAlert): (WebCore::SVGEmptyChromeClient::runJavaScriptConfirm): (WebCore::SVGEmptyChromeClient::runJavaScriptPrompt): (WebCore::SVGEmptyChromeClient::setStatusBarText):

WebKit:

Reviewed by Adam.

Move functions from the bridge to the chrome client.


  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::runJavaScriptAlert): (WebChromeClient::runJavaScriptConfirm): (WebChromeClient::runJavaScriptPrompt): (WebChromeClient::setStatusBarText):
  • WebCoreSupport/WebFrameBridge.mm:
8:02 AM Changeset in webkit [18982] by zack
  • 2 edits in trunk/WebCore

Fix the build

6:27 AM Changeset in webkit [18981] by eseidel
  • 5 edits in trunk/WebCore

2007-01-19 Eric Seidel <​eric@webkit.org>

Reviewed by rwlbuis.

More cleanup to SVGAnimated* classes.

No tests possible (only code cleanup)

  • ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::applyAnimationToValue):
  • ksvg2/svg/SVGAnimateMotionElement.h:
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseBeginOrEndValue): (WebCore::SVGAnimationElement::parseMappedAttribute): (WebCore::SVGAnimationElement::parseClockValue): (WebCore::SVGAnimationElement::isIndefinite):
  • ksvg2/svg/SVGAnimationElement.h:
6:09 AM Changeset in webkit [18980] by zimmermann
  • 2 edits in trunk/WebCore

Not reviewed.
Remove accidently commited debug output. Shame on me :-)

6:03 AM Changeset in webkit [18979] by zimmermann
  • 44 edits
    31 adds in trunk

Reviewed by Eric.

Rewrite <use> support with a real-shadow tree (as the spec demands), and implement SVGElementInstance.
AFAIK we're the first implementing this SVG feature - after ASV3 (!).

5:42 AM Changeset in webkit [18978] by eseidel
  • 5 edits
    2 adds in trunk/WebCore

2007-01-19 Eric Seidel <​eric@webkit.org>

Reviewed by rwlbuis.

Add support for SVGMPathElement parsing.

No test cases possible (SVGAnimateMotion doesn't work yet)

  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::animationPath):
  • ksvg2/svg/SVGMPathElement.cpp: Added. (WebCore::SVGMPathElement::SVGMPathElement): (WebCore::SVGMPathElement::~SVGMPathElement): (WebCore::SVGMPathElement::parseMappedAttribute): (WebCore::SVGMPathElement::pathElement):
  • ksvg2/svg/SVGMPathElement.h: Added.
  • ksvg2/svg/SVGNumberList.cpp: (WebCore::SVGNumberList::parse): fix typo in comment
  • ksvg2/svg/svgtags.in: add back mpath
4:59 AM Changeset in webkit [18977] by eseidel
  • 5 edits in trunk/WebCore

2007-01-19 Eric Seidel <​eric@webkit.org>

Reviewed by rwlbuis.

Implement better parsing for keyTimes, keySplines and keyPoints.

Unfortunately none of this code is used much yet, thus isn't very testable.

  • ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseKeyNumbers): (WebCore::parseKeySplines): (WebCore::SVGAnimationElement::parseMappedAttribute):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGNumberList.cpp: (WebCore::SVGNumberList::parse):
2:09 AM Changeset in webkit [18976] by lars
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

run-webkit-tests does now not generate new results by default anymore.
You'll have to pass the --new-tests flag to it to force it to do so.

This is required to make it possible to have tests running on multiple
platforms peacefully together.

Jan 18, 2007:

11:01 PM Changeset in webkit [22791] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenu::enabled): Implemented.
10:49 PM Changeset in webkit [18975] by aroben
  • 9 edits in trunk

WebCore:

Reviewed by Beth.

Fix: <rdar://problem/4939672> REGRESSION: With text selected that is
not a link, the "Remove Link" contextual menu item remains active

  • platform/ContextMenuItem.h: Added enabled method.
  • platform/qt/ContextMenuItemQt.cpp: (WebCore::ContextMenuItem::enabled): Implemented.
  • platform/mac/ContextMenuItemMac.mm: (WebCore::ContextMenuItem::enabled): Ditto.
  • platform/mac/ContextMenuMac.mm: (-[WebCoreMenuTarget validateMenuItem:]): Implemented to fulfill the NSMenuValidation protocol.

WebKit:

Reviewed by Beth.

Fix <rdar://problem/4939672> REGRESSION: With text selected that is
not a link, the "Remove Link" contextual menu item remains active

  • WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]): Leave autoenabling of menu items on so that clients can implement validateMenuItem:.
10:28 PM Changeset in webkit [18974] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Adele.

Fix for <rdar://problem/4939558> REGRESSION: "Search in Google",
"Search in Spotlight" and "Look up in Dictionary" are missing
initially from the contextual menu

The bug here is that we select the we were selecting the word after
the context menu event was dispatched and after the context menu
was built up.

  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): Select the word before dispatching the event. It is safe to remove the check for swallowEvent since WebCore context menus ensure that we always swallow the event anyway.
9:11 PM Changeset in webkit [18973] by bdash
  • 2 edits in trunk/WebCore

2007-01-18 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim H.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=7926
Bug 7926: Crash using -callWebScriptMethod to access offsetTop property

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): Bail out early if function value is an immediate, or if the function object is not callable.
7:34 PM Changeset in webkit [18972] by bdash
  • 2 edits
    1 add in trunk/WebCore

2007-01-18 Sam Weinig <​sam@webkit.org>

Reviewed by Maciej.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11853
REGRESSION (r17352): Whitespace in <title> is rendered

  • loader/DocumentLoader.cpp: (WebCore::canonicalizedTitle): Changed to also collapse internal whitespace. This required removing an optimization that is no longer possible.
  • manual-tests/title-internal-whitespace.html: Added.
6:27 PM Changeset in webkit [22790] by andersca
  • 7 edits in branches/WindowsMerge/WebKitTools

Reviewed by Adam.

Major cleanups and bugfixes, such as:


Update for changes to the API.
Implement a timer which prevents test from hanging indefinitely.
Fix bugs which would cause the same test result to be dumped twice.


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (DumpRenderTreeWndProc): Handle timer.


(initialize):
Initialize CoreGraphics so we get fonts.
(runTest):
Add timer.


(initializePreferences):
Turn off Java and Plug-ins.


(main):

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (waitUntilDoneCallback): (notifyDoneCallback): Fix bug where dump could be called twice.


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Fix newlines, update for new API.
5:41 PM Changeset in webkit [22789] by andersca
  • 2 edits
    1 move in branches/WindowsMerge/WebCore

Build fix.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/GlyphMapWin.cpp: Removed.
  • platform/win/GlyphPageTreeNodeWin.cpp: Added. (WebCore::GlyphPage::fill):
5:23 PM Changeset in webkit [18971] by bdash
  • 3 edits
    4 adds in trunk

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

Test: fast/text/font-initial.html

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): Give 'font: initial' the Standard generic family. This makes the FontDescription different from that of the initial font of a GraphicsContext, ensuring that the latter will not be used.

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

  • fast/text/font-initial-expected.checksum: Added.
  • fast/text/font-initial-expected.png: Added.
  • fast/text/font-initial-expected.txt: Added.
  • fast/text/font-initial.html: Added.
5:19 PM Changeset in webkit [18970] by bdash
  • 3 edits in trunk/WebKitSite

2007-01-19 Nicholas Shanks <​contact@nickshanks.com>

Reviewed by Maciej.

Change doctype for webkit.org/blog/ admin interface to HTML 4.01.

  • blog/wp-admin/admin-header.php:
  • blog/wp-login.php:
5:14 PM Changeset in webkit [18969] by bdash
  • 3 edits
    3 adds in trunk

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: http/tests/misc/css-accept-any-type.html

  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): Changed the accept header for stylesheets to "text/css,*/*;q=0.1" to match Firefox, accepting CSS served as any type.

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • http/tests/misc/css-accept-any-type-expected.txt: Added.
  • http/tests/misc/css-accept-any-type.html: Added.
  • http/tests/misc/resources/stylesheet.php: Added.
5:11 PM Changeset in webkit [18968] by bdash
  • 3 edits
    4 adds in trunk

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: editing/selection/display-table-text.html

  • editing/htmlediting.cpp: (WebCore::isTableElement): Changed to return false for text nodes.

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • editing/selection/display-table-text-expected.checksum: Added.
  • editing/selection/display-table-text-expected.png: Added.
  • editing/selection/display-table-text-expected.txt: Added.
  • editing/selection/display-table-text.html: Added.
5:10 PM Changeset in webkit [18967] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Adele

<rdar://problem/4917290> -
Null deref in WebFrameLoaderClient::restoreScrollPositionAndViewState()
after regaining network connection

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::restoreScrollPositionAndViewState): Bail early with a null currentItem, preventing a crash in release builds. Leave the ASSERT to help find other cases where this might happen in debug builds.
5:08 PM Changeset in webkit [18966] by bdash
  • 12 edits
    6 moves in trunk/WebCore

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

This patch takes character-to-glyph mapping out of FontData and instead makes
each Font keep its own mapping, using a shared set of glyph page fallback trees.

For each page number there is (at most) one tree. A path from the root to a
node in the tree corresponds to a fallback list of FontDatas. The node points to
a page (which may be shared with other nodes) that maps each character in its range
to a glyph in the first FontData in the fallback list that has it, or to 0 if none of
the FontDatas has a glyph for that character. A special kind of node, that can
only occur as a leaf, corresponds to using system fallback fonts after the list
has been exhausted. This prevents system fallback from polluting non-leaf
nodes.

Nodes and pages are initialized lazily and employ "copy on write".

  • CMakeLists.txt:
  • WebCore.pro:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • platform/Font.cpp: (WebCore::WidthIterator::WidthIterator): Removed substituteFontData. (WebCore::WidthIterator::advance): Moved all character-to-glyph mapping logic out of here and replaced it with a call to Font::glyphDataForCharacter(). (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::glyphDataForCharacter): Added. This method performs the lookup in the page fallback trees, triggering lazy initialization as needed, and caching pointers to the retrieved page tree nodes in the font. (WebCore::Font::update): (WebCore::Font::drawSimpleText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText): Removed substituteFont argument. (WebCore::Font::offsetForPositionForSimpleText):
  • platform/Font.h:
  • platform/FontData.cpp: (WebCore::FontData::FontData):
  • platform/FontData.h: (WebCore::FontData::missingGlyphData): Added. Returns the "missing glyph" GlyphData for this FontData.
  • platform/GlyphMap.cpp: Removed.
  • platform/GlyphMap.h: Removed.
  • platform/GlyphPageTreeNode.cpp: Renamed GlyphMap.cpp to this. (WebCore::GlyphPageTreeNode::getRoot): Added. Returns the root of the page fallback tree for the given page number. (WebCore::GlyphPageTreeNode::initializePage): Added. Helper method that initializes the page pointer of a node, possibly to a pointer to another node's page or to 0. (WebCore::GlyphPageTreeNode::getChild): Added.
  • platform/GlyphPageTreeNode.h: Renamed GlyphMap.h to this. (WebCore::GlyphPage::glyphDataForCharacter): (WebCore::GlyphPage::setGlyphDataForCharacter): (WebCore::GlyphPage::setGlyphDataForIndex): (WebCore::GlyphPageTreeNode::GlyphPageTreeNode): (WebCore::GlyphPageTreeNode::getRootChild): (WebCore::GlyphPageTreeNode::parent): (WebCore::GlyphPageTreeNode::page): (WebCore::GlyphPageTreeNode::level): (WebCore::GlyphPageTreeNode::isSystemFallback): Added. Returns whether the node corresponds to the system providing fallback fonts, which is done on a character-by-character basis.
  • platform/gdk/GlyphMapGdk.cpp: Removed.
  • platform/gdk/GlyphPageTreeNodeGdk.cpp: Renamed GlyphMapGdk.cpp to this. (WebCore::GlyphPage::fill):
  • platform/mac/FontDataMac.mm: (WebCore::FontData::platformInit):
  • platform/mac/FontMac.mm: (WebCore::Font::Font):
  • platform/mac/GlyphMapMac.cpp: Removed.
  • platform/mac/GlyphPageTreeNodeMac.cpp: Renamed GlypMapMac.cpp to this. (WebCore::GlyphPage::fill): Changed to return false if the font has no glyphs in the page.
  • platform/qt/GlyphMapQt.cpp: Removed.
  • platform/qt/GlyphPageTreeNodeQt.cpp: Renamed GlyphMapQt.cpp to this. (WebCore::GlyphPage::fill):
  • platform/win/GlyphMapWin.cpp: Removed.
  • platform/win/GlyphPageTreeNodeWin.cpp: Renamed GlyphMapWin to this. (WebCore::GlyphPage::fill):
5:03 PM Changeset in webkit [18965] by bdash
  • 2 edits in trunk/WebCore

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • page/FrameView.cpp: (WebCore::FrameView::~FrameView): Removed the call to Document::detach(). If this view is the current view, then the Frame should have already detached the document. Added an assertion that this is the case. If this view is not the current view, then it cannot access its document, but the page cache should have detached it already. Similarly, changed to call RenderPart::setWidget() only if this is the current view in the frame. (WebCore::FrameView::adjustViewSize): Added an assertion that this view is the current view in the frame. (WebCore::FrameView::layout): Ditto. (WebCore::FrameView::scheduleRelayout): Ditto. (WebCore::FrameView::scheduleRelayoutOfSubtree): Ditto. (WebCore::FrameView::windowClipRect): Ditto.
5:00 PM Changeset in webkit [18964] by eseidel
  • 2 edits in trunk/WebCore

2007-01-18 Eric Seidel <​eric@webkit.org>

Reviewed by bdash.

No test needed, removed bogus debug-only ASSERT.

  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
5:00 PM Changeset in webkit [18963] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-01-18 Sanjay Madhav <​sanjay12@gmail.com>

Reviewed by Darin.

Add JavaScriptCore define to help with tracing of when objects are marked.

  • kjs/object.cpp: (KJS::JSObject::mark):
4:54 PM Changeset in webkit [18962] by aliceli1
  • 2 edits in trunk/WebCore

Build Fix

  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection):
4:14 PM Changeset in webkit [22788] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

4:04 PM Changeset in webkit [18961] by sfalken
  • 1 copy in tags/Safari-521.32.13b

New tag.

4:01 PM Changeset in webkit [18960] by aliceli1
  • 4 edits in trunk/WebCore

Reviewed by Mark Rowe.

Fixes the leaks from my last patch, except for the first change below which is a missing delegate call for Mail purposes

  • editing/Editor.cpp: (WebCore::Editor::cut):
  • platform/Pasteboard.h:
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
3:27 PM Changeset in webkit [22787] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

  • WebView.cpp: (WebView::scrollBackingStore): Only try to scroll the backing store if it actually exists.
2:37 PM Changeset in webkit [18959] by brmorris
  • 3 edits in S60/branches/3.1m/WebKit

2007-01-18 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Phone doesn't recognises http link to a ram file (fix on 3.1m) AKKO-6X4B3D


​http://bugs.webkit.org/show_bug.cgi?id=12316

2:30 PM Changeset in webkit [18958] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

2007-01-17 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: [S60] TSW ID: PNIO-6X4H9N: S60 A3.1 wk50_004: www.lookcyclesusa.com crashes browser
​http://bugs.webkit.org/show_bug.cgi?id=12304

  • khtml/rendering/render_box.cpp: (RenderBox::paintBoxDecorations):
2:20 PM Changeset in webkit [18957] by kdecker
  • 2 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/4939511> WebKit should set the CG clip path for plug-ins that draw using CoreGraphics

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView drawRect:]): Set the CG clip path to the plug-in dirty rect. This allows plug-ins to obtain their dirty rect using functions like CGContextGetClipBoundingBox().
2:07 PM Changeset in webkit [22786] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Brady.

Fix ownership handling of CFRequestRef. A ResourceRequest holds on to its CFRequestRef
and doesn't ref it when returning it. Also, implement willCacheResponse.


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::willCacheResponse): (WebCore::ResourceHandle::start):
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):
2:03 PM Changeset in webkit [18956] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

2007-01-18 brmorris

3.0 S60 sdk build fix: avkon.loc not visible on sdk,
flag out its inclusion in Webkit.rss

1:38 PM Changeset in webkit [18955] by sullivan
  • 1 edit in trunk/LayoutTests/ChangeLog

Removed accidentally-duplicated entries.

1:33 PM Changeset in webkit [18954] by brmorris
  • 3 edits in S60

spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Phone doesn't recognises http link to a ram file


​http://bugs.webkit.org/show_bug.cgi?id=12316

1:33 PM Changeset in webkit [18953] by sullivan
  • 1 edit
    9 adds in trunk/LayoutTests

Reviewed by Darin


  • Tests for: <rdar://problem/4912002> REGRESSION: Series of words marked as a single misspelled word <rdar://problem/4462420> REGRESSION: Mail hangs during Replace All if the replacement string contains the search string
  • editing/spelling/spelling-expected.checksum: Added.
  • editing/spelling/spelling-expected.png: Added.
  • editing/spelling/spelling-expected.txt: Added.
  • editing/spelling/spelling.html: Added.
  • editing/execCommand/find-after-replace-expected.checksum: Added.
  • editing/execCommand/find-after-replace-expected.png: Added.
  • editing/execCommand/find-after-replace-expected.txt: Added.
  • editing/execCommand/find-after-replace.html: Added.
1:25 PM Changeset in webkit [18952] by brmorris
  • 2 edits in S60

2007-01-17 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: [S60] TSW ID: PNIO-6X4H9N: S60 A3.1 wk50_004: www.lookcyclesusa.com crashes browser
​http://bugs.webkit.org/show_bug.cgi?id=12304

  • khtml/rendering/render_box.cpp: (RenderBox::paintBoxDecorations):
1:14 PM Changeset in webkit [18951] by hyatt
  • 3 edits in trunk/WebCore

Make sure layer autoscrolling puts the event coordinates into the layer's coordinate space before
calling hitTest on it. Fixes "flashy" selection in textareas.

Reviewed by darin

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::nodeAtPoint):
1:09 PM Changeset in webkit [18950] by andersca
  • 6 edits
    1 delete in trunk/WebCore

Reviewed by Adam.

Get rid of ResourceLoaderMac.mm and make willCacheResponse platform-independent.


  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willCacheResponse):
  • loader/ResourceLoader.h:
  • loader/mac/ResourceLoaderMac.mm: Removed.
  • platform/network/ResourceHandleClient.h: (WebCore::): (WebCore::ResourceHandleClient::willCacheResponse): (WebCore::ResourceHandleClient::willStopBufferingData):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
1:01 PM Changeset in webkit [18949] by brmorris
  • 2 edits in S60/trunk/WebCore

2007-01-17 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: [S60] TSW ID: PNIO-6X4H9N: S60 A3.1 wk50_004: www.lookcyclesusa.com crashes browser
​http://bugs.webkit.org/show_bug.cgi?id=12304

  • khtml/rendering/render_box.cpp: (RenderBox::paintBoxDecorations):
12:48 PM Changeset in webkit [22785] by andersca
  • 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Improve wording.

12:44 PM Changeset in webkit [18948] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by John Sullivan.

  • Scripts/run-webkit-tests: Fix handling of configuration so it does the right thing when no explicit configuration is passed in. The old code assumed that the result of setConfiguration() was the configuration, but it's undefined when no configuration is explicitly passed in. The correct function to use is configuration(), and I also streamlined the code.
12:13 PM Changeset in webkit [18947] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

2007-01-18 brmorris <​bradley.morrison@nokia.com>

Reviewed by Sachin.
DESC: Explicitly include avkon.loc in webkit.rss (AHUN-6X6PW3)

  • data/Webkit.rss:
12:11 PM Changeset in webkit [18946] by yongjzha
  • 2 edits in S60/branches/3.1m/WebCore

Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 18870)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,15 @@
+2007-01-15 raalexan <​rasvan.alexandrescu@nokia.com>
+
+ Reviewed by Yongjun Zhang.
+ DESC: Crashes in web pages with rss feeds like www.google.com/ig
+ ​http://bugs.webkit.org/show_bug.cgi?id=12289
+
+ WARNING: NO TEST CASES ADDED OR CHANGED
+
+ * khtml/xml/xml_tokenizer.cpp:
+ (khtml::createQStringParser):
+ (khtml::parseQString):

11:57 AM Changeset in webkit [22784] by andersca
  • 7 edits
    2 adds in branches/WindowsMerge/WebKitWin

Reviewed by Lou and Adam.

Dispatch all the right delegate methods.


  • Interfaces/IWebPolicyDelegate.idl: Add some definitions needed.


  • WebActionPropertyBag.cpp: Added. (WebActionPropertyBag::WebActionPropertyBag): (WebActionPropertyBag::~WebActionPropertyBag): (WebActionPropertyBag::createInstance): (WebActionPropertyBag::QueryInterface): (WebActionPropertyBag::AddRef): (WebActionPropertyBag::Release): (isEqual): (findMouseEvent): (WebActionPropertyBag::Read): (WebActionPropertyBag::Write):
  • WebActionPropertyBag.h: Added. New class which wraps a NavigationAction in a property bag.


  • WebFrame.cpp: (WebFrame::dispatchWillSubmitForm): (WebFrame::clearUnarchivingState): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction): (WebFrame::dispatchWillSendRequest): (WebFrame::dispatchDidFailLoading):
  • WebFrame.h: Dispatch correct delegate methods.


  • WebKit.vcproj/WebKit.vcproj: Add WebActionPropertyBag files.


  • WebURLResponse.cpp: (WebURLResponse::createInstance): Return 0 for null responses.
11:54 AM Changeset in webkit [18945] by brmorris
  • 2 edits in S60/trunk/WebKit

2007-01-18 brmorris <​bradley.morrison@nokia.com>

Reviewed by Sachin.
DESC: Explicitly include avkon.loc in webkit.rss

  • data/Webkit.rss:
11:13 AM Changeset in webkit [18944] by mjs
  • 4 edits
    1 add in trunk/WebCore

Reviewed by John.


  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Don't insert extra paragraph separators to avoid nesting blocks in plaintext mode, since that's not an issue under normal circumstances.
  • html/HTMLInputElement.h:
  • manual-tests/drag-move-in-search-field.html: Added.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::subtreeHasChanged): constrain the value; we'd rather truncate it than end up with an illegal value here.
10:47 AM Changeset in webkit [18943] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-01-17 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Secure icon shown in www.blogger.com and stays on afterwards
​http://bugs.webkit.org/show_bug.cgi?id=12303

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::HeadersL):
10:43 AM Changeset in webkit [18942] by spadma
  • 2 edits in S60/trunk/WebKit

2007-01-17 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Secure icon shown in www.blogger.com and stays on afterwards
​http://bugs.webkit.org/show_bug.cgi?id=12303

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::HeadersL):
9:23 AM Changeset in webkit [22783] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by John Sullivan

  • WebView.cpp: (WebView::searchFor): Build fix.
9:07 AM Changeset in webkit [18941] by hausmann
  • 2 edits in trunk/WebCore

parallel build fix

8:39 AM Changeset in webkit [18940] by darin
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin and Mitz.

  • fast/dom/HTMLImageElement/image-lowsrc-getset-expected.txt: Added.
  • fast/dom/HTMLImageElement/image-lowsrc-getset.html: Added.

WebCore:

Reviewed by Darin and Mitz.

<rdar://problem/4931480> REGRESSION: Images do not load in video sections on CNN.com homepage (12305)

Test: fast/dom/HTMLImageElement/image-lowsrc-getset.html

  • html/HTMLAttributeNames.in: Added lowsrc.
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::isURLAttribute): Added lowsrc. (WebCore::HTMLImageElement::lowsrc): Added. (WebCore::HTMLImageElement::setLowsrc): Added.
  • html/HTMLImageElement.h: Added lowsrc and setLowsrc.
  • html/HTMLImageElement.idl: Added lowsrc.
8:32 AM Changeset in webkit [18939] by yongjzha
  • 3 edits in S60/trunk/WebCore

2007-01-14 sareen <​shyam.sareen@nokia.com>

Reviewed by Antti Kovisto.Browser
DESC: Browser - Form/The TC is not displayed, it's a white page displayed
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12269

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag):
  • khtml/html/htmltokenizer.h:
8:16 AM Changeset in webkit [18938] by yongjzha
  • 3 edits in S60/branches/3.1m/WebCore

Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 18858)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,15 @@
+2007-01-15 sareen <​shyam.sareen@nokia.com>
+
+ Reviewed by Antti Kovisto.Browser
+ DESC: Browser - Form/The TC is not displayed, it's a white page displayed
+ ​http://bugzilla.opendarwin.org/show_bug.cgi?id=12269
+
+ WARNING: NO TEST CASES ADDED OR CHANGED
+
+ * khtml/html/htmltokenizer.cpp:
+ (khtml::HTMLTokenizer::parseTag):
+ * khtml/html/htmltokenizer.h:

8:12 AM Changeset in webkit [18937] by yongjzha
  • 3 edits in S60/branches/3.1m/WebCore

2007-01-17 w3liu <​wei.liu@nokia.com>

Reviewed by Yongjun Zhang <​yongjun.zhang@nokia.com>
DESC: [S60] TSW ID: AIYR-6W29Z7, Browser crashes when entered Hindi character in textbox as Search character in Search engine site.
​http://bugs.webkit.org/show_bug.cgi?id=12306

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/khtml_part.cpp: (KHTMLPart::encoding):
  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode): (KWQTextDecoder::checkRealloc):
8:03 AM Changeset in webkit [18936] by yongjzha
  • 2 edits in S60/trunk/WebCore

2007-01-18 sareen <​shyam.sareen@yahoo.com>

Reviewed by Yongjun.
DESC: Wrong rendering of danish national characters for UTF8 coded web pages.(TSW ID: TMCN-6UQNXY)

Additional fix.

​http://bugs.webkit.org/show_bug.cgi?id=12217

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQTextCodec.cpp: (validateUtf8):
7:59 AM Changeset in webkit [18935] by yongjzha
  • 3 edits in S60/trunk/WebCore

2007-01-17 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC:
​http://bugs.webkit.org/show_bug.cgi?id=12306

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/khtml_part.cpp: (KHTMLPart::encoding):
  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode): (KWQTextDecoder::checkRealloc):
6:33 AM Changeset in webkit [18934] by yongjzha
  • 2 edits in S60/trunk/WebCore

2007-01-15 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Crashes in web pages with rss feeds like www.google.com/ig
​http://bugs.webkit.org/show_bug.cgi?id=12289

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/xml/xml_tokenizer.cpp: (khtml::createQStringParser): (khtml::parseQString):
5:00 AM Changeset in webkit [18933] by hausmann
  • 5 edits in trunk

fix make clean in the qt build to remove all generated files

2:04 AM Changeset in webkit [18932] by zack
  • 8 edits in trunk/WebKitQt

Implementing some load progress tracking in the Qt port.
Reviewed by Lars.

Note: See TracTimeline for information about the timeline view.