Timeline
Jan 29, 2007:
- 11:30 PM Changeset in webkit [22871] by
-
- 2 edits in branches/WindowsMerge/WebCore
Build fix.
- platform/win/TemporaryLinkStubs.cpp: Removed old stub.
- 11:22 PM Changeset in webkit [22870] by
-
- 5 edits in branches/WindowsMerge
More engine download tweaks - still relies on a custom ToT CFNetwork until they submit
- 11:13 PM Changeset in webkit [22869] by
-
- 3 edits in branches/WindowsMerge/WebKitWin
Reviewed by Adam & Steve.
- hook up new cross-platform data-loading code
- fixed <rdar://4910106> - Need to support loadData and loadHTMLString
- WebFrame.cpp: (WebFrame::loadData): add a SharedBuffer overload, and implement IStream* version using that. (WebFrame::loadHTMLString): implement using loadData
- WebFrame.h: prototype new method
- 10:09 PM Changeset in webkit [19247] by
-
- 2 edits in trunk/WebCore
I am the chosen one! I have seen the faces of the final five! I will
save the WebKit build!
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::load):
- 9:32 PM Changeset in webkit [19246] by
-
- 83 edits6 adds in trunk/LayoutTests
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=12464
Fix XPath test suite conversion problems
- dom/svg/level3/xpath/svgunit.js: Fixed createXPathEvaluator() to work in Firefox (whose document.getFeature returns null for XPath). Changed load() to use XMLHttpRequest, instead of merely cloning the current document.
- dom/svg/level3/xpath/resources/internaldtd.xml: Added.
- dom/svg/level3/xpath/resources/staff.dtd: Added.
- dom/svg/level3/xpath/resources/staff.xml: Added.
- dom/svg/level3/xpath/resources/staffNS.dtd: Added.
- dom/svg/level3/xpath/resources/staffNS.xml: Added. Added external test documents.
- dom/svg/level3/xpath/XPathEvaluator_evaluate_WRONG_DOCUMENT_ERR-expected.txt:
- dom/svg/level3/xpath/XPathExpression_evaluate_WRONG_DOCUMENT_ERR-expected.txt: These tests now run, but fail. They also fail in Firefox, but pass in Opera.
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_ITERATOR_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_ITERATOR_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_iterateNext_INVALID_STATE_ERR-expected.txt: These now fail, because XPathResult relies on DOMSubtreeModified event for invalidation, but event listeners cannot be registered on nodes in documents that aren't attached (such as XHR.responseXML). Not yet sure what exactly the bug is, but I think it's good to have the tests fail, as it appears to be a genuine issue.
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_TYPE.js:
- dom/svg/level3/xpath/XPathResult_numberValue.js: Updated these tests to use /staff instead of /svg paths.
- dom/svg/level3/xpath/XPathResult_booleanValue_true-expected.txt:
- dom/svg/level3/xpath/XPathResult_iteratorNext_ORDERED_NODE_ITERATOR_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_singleNodeValue_ANY_UNORDERED_NODE_TYPE.js:
- dom/svg/level3/xpath/XPathResult_singleNodeValue_FIRST_ORDERED_NODE_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_order-expected.txt:
- dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_count-expected.txt:
- dom/svg/level3/xpath/XPathResult_snapshotLength_ORDERED_NODE_SNAPSHOT_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_snapshotLength_UNORDERED_NODE_SNAPSHOT_TYPE-expected.txt:
- dom/svg/level3/xpath/XPathResult_stringValue-expected.txt: These tests now pass.
- dom/svg/level3/xpath/Attribute_Nodes.svg:
- dom/svg/level3/xpath/Attribute_Nodes_xmlns.svg:
- dom/svg/level3/xpath/Comment_Nodes.svg:
- dom/svg/level3/xpath/Conformance_Expressions.svg:
- dom/svg/level3/xpath/Conformance_ID.svg:
- dom/svg/level3/xpath/Conformance_hasFeature_3.svg:
- dom/svg/level3/xpath/Conformance_hasFeature_empty.svg:
- dom/svg/level3/xpath/Conformance_hasFeature_null.svg:
- dom/svg/level3/xpath/Conformance_isSupported_3.svg:
- dom/svg/level3/xpath/Conformance_isSupported_empty.svg:
- dom/svg/level3/xpath/Conformance_isSupported_null.svg:
- dom/svg/level3/xpath/Element_Nodes.svg:
- dom/svg/level3/xpath/Processing_Instruction_Nodes.svg:
- dom/svg/level3/xpath/Text_Nodes.svg:
- dom/svg/level3/xpath/XPathEvaluatorCast01.svg:
- dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.svg:
- dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_01.svg:
- dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_02.svg:
- dom/svg/level3/xpath/XPathEvaluator_createExpression_NS.svg:
- dom/svg/level3/xpath/XPathEvaluator_createExpression_no_NS.svg:
- dom/svg/level3/xpath/XPathEvaluator_createNSResolver_all.svg:
- dom/svg/level3/xpath/XPathEvaluator_createNSResolver_document.svg:
- dom/svg/level3/xpath/XPathEvaluator_createNSResolver_documentElement.svg:
- dom/svg/level3/xpath/XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR.svg:
- dom/svg/level3/xpath/XPathEvaluator_evaluate_NAMESPACE_ERR.svg:
- dom/svg/level3/xpath/XPathEvaluator_evaluate_NOT_SUPPORTED_ERR.svg:
- dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg:
- dom/svg/level3/xpath/XPathEvaluator_evaluate_WRONG_DOCUMENT_ERR.svg:
- dom/svg/level3/xpath/XPathEvaluator_evaluate_document.svg:
- dom/svg/level3/xpath/XPathEvaluator_evaluate_documentElement.svg:
- dom/svg/level3/xpath/XPathExpression_evaluate_NOT_SUPPORTED_ERR.svg:
- dom/svg/level3/xpath/XPathExpression_evaluate_WRONG_DOCUMENT_ERR.svg:
- dom/svg/level3/xpath/XPathExpression_evaluate_document.svg:
- dom/svg/level3/xpath/XPathExpression_evaluate_documentElement.svg:
- dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc.svg:
- dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_null.svg:
- dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_prefix.svg:
- dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_xml.svg:
- dom/svg/level3/xpath/XPathResult_TYPE_ERR.svg:
- dom/svg/level3/xpath/XPathResult_booleanValue_false.svg:
- dom/svg/level3/xpath/XPathResult_booleanValue_true.svg:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_TYPE.svg:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_UNORDERED_NODE_TYPE.svg:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_BOOLEAN_TYPE.svg:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_FIRST_ORDERED_NODE_TYPE.svg:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_NUMBER_TYPE.svg:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_ITERATOR_TYPE.svg:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_SNAPSHOT_TYPE.svg:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_STRING_TYPE.svg:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_ITERATOR_TYPE.svg:
- dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_SNAPSHOT_TYPE.svg:
- dom/svg/level3/xpath/XPathResult_iterateNext_INVALID_STATE_ERR.svg:
- dom/svg/level3/xpath/XPathResult_iteratorNext_ORDERED_NODE_ITERATOR_TYPE.svg:
- dom/svg/level3/xpath/XPathResult_numberValue.svg:
- dom/svg/level3/xpath/XPathResult_resultType.svg:
- dom/svg/level3/xpath/XPathResult_singleNodeValue_ANY_UNORDERED_NODE_TYPE.svg:
- dom/svg/level3/xpath/XPathResult_singleNodeValue_FIRST_ORDERED_NODE_TYPE.svg:
- dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_null.svg:
- dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_order.svg:
- dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_count.svg:
- dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_null.svg:
- dom/svg/level3/xpath/XPathResult_snapshotLength_ORDERED_NODE_SNAPSHOT_TYPE.svg:
- dom/svg/level3/xpath/XPathResult_snapshotLength_UNORDERED_NODE_SNAPSHOT_TYPE.svg:
- dom/svg/level3/xpath/XPathResult_stringValue.svg: Removed unneeded inline test data.
- 9:07 PM Changeset in webkit [19245] by
-
- 5 edits in trunk
Reviewed by Maciej Stachowiak.
Fixed <rdar://problem/4485644> REGRESSION: JavaScriptCore has init routines
The TCMalloc module now initializes, if needed, inside GetCache() and
fastMallocSetIsMultiThreaded(). We leverage the same synchronization
technique used for enabling / disabling the single-threaded optimization
to synchronize initialization of the library without requiring a lock
for every malloc.
1,251 runs of tcmalloc_unittest, 2 runs of a custom, massively multi-threaded
tcmalloc_unittest, and my custom version of the PLT show no regressions.
Super-accurate JS iBench reports a .24% regression, which is right at the
limit of its error range, so I'm declaring victory.
- wtf/FastMalloc.cpp: (WTF::fastMallocSetIsMultiThreaded): Initialize, if needed. (InitModule() checks the "if needed" part.) (WTF::TCMalloc_ThreadCache::GetCache): Restored original TCMalloc code inside #ifdef, for posterity. Added new initialization logic. (WTF::TCMalloc_ThreadCache::InitModule): Call InitTSD(), since we don't have a static initializer to call it for us, now. This means that fastMalloc is not usable as a general libc allocator, but it never was, and if it were the general libc allocator, we wouldn't be here in the first place, so whatever. (WTF::TCMalloc_ThreadCache::InitTSD): Don't try to take the pageheap_lock, since InitModule already has it.
WebKitTools:
Reviewed by Maciej Stachowiak.
Fixed <rdar://problem/4485644> REGRESSION: JavaScriptCore has init routines
No more mollycoddling for you, FastMalloc.o!
- Scripts/check-for-global-initializers:
- 8:57 PM Changeset in webkit [19244] by
-
- 14 edits10 adds in trunk
LayoutTests:
Reviewed by Maciej.
- test for http://bugs.webkit.org/show_bug.cgi?id=10725 Image data in from RTFD clipboard data thrown away
- editing/pasteboard/paste-RTFD-expected.checksum: Added.
- editing/pasteboard/paste-RTFD-expected.png: Added.
- editing/pasteboard/paste-RTFD-expected.txt: Added.
- editing/pasteboard/paste-RTFD.html: Added.
- editing/pasteboard/paste-TIFF-expected.checksum: Added.
- editing/pasteboard/paste-TIFF-expected.png: Added.
- editing/pasteboard/paste-TIFF-expected.txt: Added.
- editing/pasteboard/paste-TIFF.html: Added.
- editing/resources/RTFD-pasteboard-data.dat: Added.
- editing/resources/TIFF-pasteboard-data.dat: Added.
WebCore:
Reviewed by Maciej.
Part of fix for http://bugs.webkit.org/show_bug.cgi?id=10725
Image data in from RTFD clipboard data thrown away
ResourceHandles no longer need to be able to defer loading as that is
now handled by the ResourceLoader.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::loadNow): updated to remove defersLoading argument.
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::releaseResources): release the deferred request. (WebCore::ResourceLoader::load): defer creating the ResourceHandle instead of asking the ResourceHandle to defer loading. (WebCore::ResourceLoader::setDefersLoading): create the ResourceHandle if we have deferred creating it.
- loader/ResourceLoader.h:
- platform/network/ResourceHandle.cpp: ResourceHandle's don't need to know about deferLoading. (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
- platform/network/ResourceHandle.h: ditto.
- platform/network/ResourceHandleInternal.h: ditto. (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/mac/ResourceHandleMac.mm: ditto. (WebCore::ResourceHandle::start):
WebKit:
Reviewed by Maciej.
Part of fix for http://bugs.webkit.org/show_bug.cgi?id=10725
Image data in from RTFD clipboard data thrown away
The URLs for images in RTFD data must not be loaded until the resources
have been added to the WebUnarchivingState. This can't happen until
after the RTFD data has been parsed, so we must delay loading while this
RTFD data is being parsed to a document fragment.
- WebView/WebHTMLView.mm: (uniqueURLWithRelativePart): (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): defer loading the resources while RTFD data is being parsed. (+[NSURL _web_uniqueWebDataURL]): Added this back because AppKit uses it.
- WebView/WebUnarchivingState.m: (-[WebUnarchivingState archivedResourceForURL:]): orkaround for workaround for rdar://problem/4699166 so that other people can use archivedResourceForURL: too.
WebKitTools:
Reviewed by Maciej.
Enables layout test for: http://bugs.webkit.org/show_bug.cgi?id=10725
Image data in from RTFD clipboard data thrown away
- This method is needed because NSArray's ar bridged to JS Array's, which in turn are bridged back to WebScriptObject's when passed from JS to ObjC. Hence it is not possbile to pass an NSArray from JS.
- DumpRenderTree/DumpRenderTree.m: (-[DumpRenderTreePasteboard declareType:owner:]): Added a convenience method for JS.
- 8:31 PM Changeset in webkit [22868] by
-
- 1 edit in branches/WindowsMerge/WebCore/platform/network/cf/ResourceHandleCFNet.cpp
Emergency build fix + other changes I'll have review after the fact
- 8:05 PM Changeset in webkit [19243] by
-
- 3 edits in trunk/WebKit
2007-01-29 Jim Correia <jim.correia@pobox.com>
Reviewed by Mark.
Added support for -allowsUndo/-setAllowsUndo: to allow editable WebView
clients to completely disable undo registration. This is functionally
equivalent to the methods with the same names on NSTextView.
- WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebView initWithCoder:]): (-[WebView encodeWithCoder:]): (-[WebView allowsUndo]): (-[WebView setAllowsUndo:]): (-[WebView undoManager]):
- WebView/WebViewPrivate.h:
- 7:19 PM Changeset in webkit [19242] by
-
- 2 edits in trunk/WebCore
Use a RetainPtr instead of a raw pointer
- 6:21 PM Changeset in webkit [22867] by
-
- 2 edits in branches/WindowsMerge/WebCore
Make NotImplemented use a logging channel so you can turn it off independent of other logging
- 6:11 PM Changeset in webkit [19241] by
-
- 2 edits in S60/trunk/WebCore
2007-01-29 bujtas <zbujtas@gmail.com>
Reviewed by zalan bujtas
DESC:
http://bugs.webkit.org/show_bug.cgi?id=12422
jscript->schedule action->turn off jscript->action timeouts->crash. fix: check if the proxy is available in ScheduledAction::execute()
- khtml/ecma/kjs_window.cpp: (ScheduledAction::execute):
- 6:08 PM Changeset in webkit [19240] by
-
- 2 edits in S60/branches/3.1m/WebCore
2007-01-29 bujtas <zbujtas@gmail.com>
Reviewed by zalan bujtas
DESC:
http://bugs.webkit.org/show_bug.cgi?id=12422
jscript->schedule action->turn off jscript->action timeouts->crash. fix: check if the proxy is available in ScheduledAction::execute()
- khtml/ecma/kjs_window.cpp: (ScheduledAction::execute):
- 5:13 PM Changeset in webkit [19239] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by harrison
<rdar://problem/4960137>
ASSERTION FAILURE calling SelectionController::setBaseAndExtent (11833)
- editing/selection/4960137-expected.checksum: Added.
- editing/selection/4960137-expected.png: Added.
- editing/selection/4960137-expected.txt: Added.
- editing/selection/4960137.html: Added.
WebCore:
Reviewed by harrison
<rdar://problem/4960137>
ASSERTION FAILURE calling SelectionController::setBaseAndExtent (11833)
- editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Hand off the selection to the selectionController responsible for it, instead of asserting. A selection object can't be constructed with endpoints in different documents, so this code is only necessary for one endpoint.
- 4:40 PM Changeset in webkit [19238] by
-
- 4 edits in trunk
2007-01-29 Ada Chan <adachan@apple.com>
Reviewed by Brady.
Moved the update of the title of the current entry in the backforward list to WebCore.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::didChangeTitle):
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setTitle):
- 4:26 PM Changeset in webkit [22866] by
-
- 3 edits in branches/WindowsMerge/WebKitWin
Reviewed by Darin.
- WebEditorClient.cpp: (WebEditorClient::handleKeyPress): Removed EventTargetNode paramenter.
- WebEditorClient.h:
- 4:15 PM Changeset in webkit [19237] by
-
- 17 edits in trunk
WebCore:
Reviewed by Darin.
More preparation for event handling fixes.
- bridge/EditorClient.h: Removed EventTargetNode parameter from handleKeyPress since we can just get that from the event.
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): ditto.
- page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): ditto.
- page/EventHandler.h: ditto.
- platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::handleKeyPress): ditto.
- editing/Editor.h:
- editing/Editor.cpp: (WebCore::Editor::handleKeyPress): Removed EventTargetNode parameter. (WebCore::Editor::execCommand): Made commandMap use AtomicStringImpls instead of Strings. (WebCore::Editor::insertText): Moved from the bridge.
- page/mac/WebCoreFrameBridge.h: Moved insertText method to Editor.
- page/mac/WebCoreFrameBridge.mm:
- WebCore.exp: Updated exports.
WebKit:
Reviewed by Darin.
More preparation for event handling fixes.
- WebCoreSupport/WebEditorClient.h: Removed EventTargetNode parameter, since you can just get this from the KeyboardEvent.
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyPress): ditto.
- WebView/WebHTMLViewInternal.h: Added interpretKeyEventsParameters struct.
- WebView/WebViewInternal.h: Changed parameter from NSEvent to WebCoreKeyboardEvent in _interceptEditingKeyEvent.
- WebView/WebHTMLView.mm: (-[WebHTMLView yankAndSelect:]): Updated for new triggeringEvent parameter. (-[WebHTMLView _interceptEditingKeyEvent:]): Set the WebHTMLViewInterpretKeyEventsParameters. (-[WebHTMLView doCommandBySelector:]): Access WebHTMLViewInterpretKeyEventsParameters. (-[WebHTMLView insertText:]): ditto. (-[WebHTMLView _insertText:selectInsertedText:triggeringEvent:]): Added parameter for triggeringEvent.
- 3:45 PM Changeset in webkit [22865] by
-
- 2 edits in branches/WindowsMerge/WebKitTools
Build fix.
- DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: (WaitUntilDoneDelegate::dragDestinationActionMaskForDraggingInfo): (WaitUntilDoneDelegate::willPerformDragDestinationAction):
- 2:42 PM Changeset in webkit [19236] by
-
- 6 edits2 adds in trunk
LayoutTests:
Reviewed by Geoff.
<rdar://problem/4960097>
http://bugs.webkit.org/show_bug.cgi?id=12444
Assertion failure in -[WebCoreFrameBridge installInFrame:]
- fast/parser/xhtml-document-with-html-object-expected.txt: Added.
- fast/parser/xhtml-document-with-html-object.xhtml: Added.
WebCore:
Reviewed by Geoff.
<rdar://problem/4960097>
http://bugs.webkit.org/show_bug.cgi?id=12444
Assertion failure in -[WebCoreFrameBridge installInFrame:]
The problem was that the XML tokenizer didn't create elements with
createdByParser set to true.
- dom/Document.cpp: (WebCore::Document::createElement): New method which takes a QName. This is used by both the XML tokenizer and createElementNS.
(WebCore::Document::createElementNS):
Call new createElement method.
- dom/XMLTokenizer.h:
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::XMLTokenizer::~XMLTokenizer): Use an OwnPtr for the pending callbacks object. Also, use String instead of StringImpl in the hash map.
(WebCore::toString):
(WebCore::XMLTokenizer::startElementNs):
Call createElement.
- 2:00 PM Changeset in webkit [19235] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver
http://bugs.webkit.org/show_bug.cgi?id=12465
Only set the iconURL port for non-zero ports
- loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL):
- 1:58 PM Changeset in webkit [19234] by
-
- 5 edits2 adds in trunk
Reviewed by Geoff and Oliver.
- rdar://problem/4955561
- missusing JavaScript shouldn't crash webkit. Now it doesn't, in this case.
- bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::callAsFunction):
- bindings/runtime_method.cpp: (RuntimeMethod::callAsFunction):
- bindings/runtime_object.cpp: (RuntimeObjectImp::callAsFunction):
LayoutTests:
Reviewed by Geoff and Oliver.
- rdar://problem/4955561
- missusing JavaScript shouldn't crash webkit. Now it doesn't in this case.
- plugins/call-as-function-test-expected.txt: Added.
- plugins/call-as-function-test.html: Added.
- 11:49 AM Changeset in webkit [19233] by
-
- 2 edits in trunk/WebKit
2007-01-29 Oliver Hunt <oliver@apple.com>
build fix
- WebView/WebHTMLView.mm: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
- 10:47 AM Changeset in webkit [22864] by
-
- 3 edits in branches/WindowsMerge/WebKitWin
WebKitWin:
Reviewed by Oliver.
<rdar://problem/4892067>
DnD a font file in Boomer locks it up.
Create a drop target helper so we get snazzy drag images.
- WebView.cpp: (WebView::WebView): (WebView::DragEnter): (WebView::DragOver): (WebView::DragLeave): (WebView::Drop):
- WebView.h:
- 10:38 AM Changeset in webkit [22863] by
-
- 3 edits in branches/WindowsMerge/WebKitWin
2007-01-29 Oliver Hunt <oliver@apple.com>
Reviewed by Adam.
Basic implementation of new dragclient method
- WebDragClient.cpp: (WebDragClient::dragSourceActionMaskForPoint):
- WebDragClient.h:
- 10:36 AM Changeset in webkit [19232] by
-
- 2 edits in trunk/WebCore
- platform/network/mac/ResourceRequestMac.mm: Build fix -- removed #import of no-longer-extant WebDataProtocol.h (and also one of the two #imports for WebCoreSystemInterface.h, while I was at it)
- 10:33 AM Changeset in webkit [19231] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver.
- page/DragController.cpp: (WebCore::DragController::dragEnteredOrUpdated): Only try a drag operation if the drag client explicitly specified that it is OK
- 10:25 AM Changeset in webkit [19230] by
-
- 19 edits in trunk
2007-01-25 Oliver Hunt <oliver@apple.com>
Reviewed by Adam.
WebKit:
Migrated drag state and logic to WebCore, removed superfluous methods
- ChangeLog:
- WebCoreSupport/WebDragClient.h:
- WebCoreSupport/WebDragClient.mm: (WebDragClient::dragSourceActionMaskForPoint):
- WebCoreSupport/WebFrameBridge.mm:
allowDHTMLDrag move to WebCore::EventHandler
- WebView/WebHTMLView.mm: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[WebHTMLView draggedImage:movedTo:]): (-[WebHTMLView draggedImage:endedAt:operation:]): dragOffset and dragSourecAction is now stored in WebCore::DragController migrated _delegateDragSourceActionMask to WebCore::DragController
- WebView/WebHTMLViewInternal.h: Removed dragOffset declaration, migrated to WebCore::DragController
- WebView/WebView.mm: removed unnecessary method, _loadingDragOperationForDraggingInfo
WebKitQt:
Reviewed by Adam.
Stub for new DragClient method
- WebCoreSupport/DragClientQt.cpp: (WebCore::DragClientQt::dragSourceActionMaskForPoint):
- WebCoreSupport/DragClientQt.h:
WebCore:
Reviewed by Adam.
Migrated more drag logic and state to WebCore
- page/DragClient.h:
- page/DragController.cpp: (WebCore::DragController::delegateDragSourceAction): New forwarding method for the UI delegate
- page/DragController.h: (WebCore::DragController::dragOffset): Now store the drag offset -- the offset of the cursor relative to the drag image) in DragController
- page/EventHandler.cpp: (WebCore::EventHandler::allowDHTMLDrag): Moved from WebFrameBridge
- page/EventHandler.h:
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::handleDrag): EventHandlerMac now uses EventHandler::allowDHTMLDrag rather than the implementation in WebFrameBridge
- page/mac/WebCoreFrameBridge.h: removed definition of allowDHTMLDrag from WebFrameBridge
- platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyDragClient::dragSourceActionMaskForPoint): Updated empty DragClient
- 10:20 AM Changeset in webkit [19229] by
-
- 2 edits in S60/branches/3.1m/WebKit
brmorris <bradley.morrison@nokia.com>
Reviewed by nobody - build fix.
DESC: Fix for build bustage in r19200 - MLIO-6XCCTG
- 10:18 AM Changeset in webkit [19228] by
-
- 2 edits in S60/trunk/WebKit
brmorris <bradley.morrison@nokia.com>
Reviewed by nobody - build fix.
DESC: Fix for build bustage caused by r19201 - MLIO-6XCCTG
- ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):
- 10:04 AM Changeset in webkit [19227] by
-
- 4 edits2 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=12359
XPathEvaluator may return some nodes more than once in a result set
Test: fast/xpath/nodeset-duplicates.html
- xml/XPathPath.cpp: (WebCore::XPath::LocationPath::doEvaluate): Ensure uniqueness of elements in the node-set.
- xml/XPathPredicate.cpp: (WebCore::XPath::Union::doEvaluate): Fixed a uniqueness algorithm that was already present here. Added a FIXME about incorrect result ordering.
- 9:55 AM Changeset in webkit [19226] by
-
- 4 edits2 moves2 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=12340
XPathEvaluator behavior does not match Firefox - name() and attribute nodes
WebCore:
- xml/XPathFunctions.cpp: (WebCore::XPath::FunName::doEvaluate): Do not try to append a prefix if it doesn't exist.
LayoutTests:
- fast/xpath/name-null-namespace-expected.txt: Added.
- fast/xpath/name-null-namespace.html: Added. Test for the bug.
- fast/dom/xpath-empty-string-expected.txt: Removed.
- fast/dom/xpath-empty-string.html: Removed. Moved these to fast/xpath.
- fast/xpath/xpath-namespaces.html: Fixed an inline document to be well-formed, so the test now passes in Firefox. This is really a quirk of our DOMParser that the test passed in WebKit: on error, a descriptive message is appended to the partially parsed document, instead of replacing it.
- 9:40 AM Changeset in webkit [19225] by
-
- 4 edits2 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11815
XPathEvaluator behavior does not match Firefox - substring() and empty element
Test: fast/xpath/empty-string-substring.html
- xml/XPathValue.cpp: (WebCore::XPath::Value::Value):
- xml/XPathValue.h: Added a constructor taking const char*, so that string literals and arrays don't get converted to boolean values.
- 8:11 AM Changeset in webkit [19224] by
-
- 3 edits in trunk/WebCore
Cosmetic fixes - don't resize the widget in the constructor
(it was a hack from the initial port) and fix the paint
signature)
- 7:23 AM Changeset in webkit [22862] by
-
- 4 edits in branches/WindowsMerge
WebCoreWin:
- fix build
- platform/win/TemporaryLinkStubs.cpp:
WebKitWin:
- fix build
- WebFrame.h:
- 7:10 AM Changeset in webkit [19223] by
-
- 2 edits in trunk/WebCore
- change from struct to class to make picky compilers happy
- loader/SubstituteData.h:
- 6:28 AM Changeset in webkit [19222] by
-
- 2 edits in trunk/WebCore
2007-01-30 Mark Rowe <mrowe@apple.com>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=12458
Bug 12458: Crash in W3C-SVG-1.1/animate-elem-09-t.svg running layout tests under guard malloc
- ksvg2/svg/SVGAnimationElement.cpp: (WebCore::parseValues): ptr either points to a ';' or off the end of the buffer. We're interested in what comes before the ';', so start there instead.
- 5:37 AM Changeset in webkit [19221] by
-
- 4 edits in trunk/WebCore
Take the scrollbars into considation when computing
the contents size of the main frame
- 5:06 AM Changeset in webkit [19220] by
-
- 2 edits in trunk/WebCore
- fix includes
- loader/SubstituteData.h:
- 5:03 AM Changeset in webkit [22861] by
-
- 5 edits in branches/WindowsMerge/WebKitWin
Reviewed by Mark.
<rdar://problem/4910106> Need to support loadData and loadHTMLString
I added the underlying support, but did not turn on the new cross-platform versions yet as I've
not had sufficient time to test.
- WebDocumentLoader.cpp: (WebDocumentLoader::WebDocumentLoader):
- WebDocumentLoader.h:
- WebFrame.cpp: (WebFrame::createDocumentLoader):
- WebFrame.h:
- 5:01 AM Changeset in webkit [19219] by
-
- 1 edit1 add in trunk/WebCore
- added new file that I forgot in the last commit
- loader/SubstituteData.h: Added. (WebCore::SubstituteData::SubstituteData): (WebCore::SubstituteData::isValid): (WebCore::SubstituteData::content): (WebCore::SubstituteData::mimeType): (WebCore::SubstituteData::textEncoding): (WebCore::SubstituteData::failingURL):
- 4:50 AM Changeset in webkit [19218] by
-
- 28 edits2 deletes in trunk
WebCore:
Reviewed by Mark.
- made data loading cross-platform
- fixed <rdar://problem/4910106>
- WebCore.exp:
- WebCore.xcodeproj/project.pbxproj:
- loader/CachedResource.cpp:
- loader/CachedResource.h:
- loader/DocLoader.cpp: (WebCore::DocLoader::requestResource):
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::urlForHistory): (WebCore::DocumentLoader::unreachableURL):
- loader/DocumentLoader.h: (WebCore::DocumentLoader::substituteData):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::checkNavigationPolicy):
- loader/FrameLoader.h:
- loader/FrameLoaderClient.h:
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::handleEmptyLoad): (WebCore::MainResourceLoader::handleDataLoad): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::load):
- loader/MainResourceLoader.h:
- loader/mac/DocumentLoaderMac.mm:
- loader/mac/WebDataProtocol.h: Removed.
- loader/mac/WebDataProtocol.mm: Removed.
- loader/qt/DocumentLoaderQt.cpp:
- platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::createDocumentLoader):
WebKit:
Reviewed by Mark.
- updated for cross-platform data loading support
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createDocumentLoader):
- WebView/WebDataSource.mm: (-[WebDataSource initWithRequest:]):
- WebView/WebDocumentLoaderMac.h:
- WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::WebDocumentLoaderMac):
- WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): (-[WebFrame loadArchive:]):
- WebView/WebFrameInternal.h:
- WebView/WebHTMLView.mm: (uniqueURLWithRelativePart): (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]):
WebKitQt:
Reviewed by Mark.
- updated for cross-platform data loading support
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createDocumentLoader):
- WebCoreSupport/FrameLoaderClientQt.h:
- 3:57 AM Changeset in webkit [19217] by
-
- 2 edits in trunk/WebCore
Order the build files alphabetically instead of
the random mess we had before
- 3:30 AM Changeset in webkit [19216] by
-
- 3 edits in trunk/WebCore
Use the platform independent scrollbar code.
Remove the redundant empty stubs and forward
few missing platform scrollbar calls
r=Lars
- 2:37 AM Changeset in webkit [19215] by
-
- 4 edits in trunk/WebKitQt
Make window resizing work
- 2:24 AM Changeset in webkit [19214] by
-
- 4 edits in trunk/WebKitQt
Make popup windows work
- 1:24 AM Changeset in webkit [19213] by
-
- 11 edits in trunk
Reviewed by Zack
Fix the way we handle native widgets (QWidget) inside
WebCore. Now WebCore::Widget owns the QWidget in all
cases. This is the only way to get well defined semantics
for all teh native widgets we have (currently ScrollView
and ScrollBar, but plugins will follow).
This has the side effect that one cannot rely on a defined
lifetime of a QWebFrame when using the API.
- 1:01 AM Changeset in webkit [22860] by
-
- 4 edits in branches/WindowsMerge/WebCore
2007-01-29 Steve Falkenburg <sfalken@apple.com>
Fix build break from RootObject ownership change.
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::createRootObject): Added (WebCore::FrameWin::cleanupPluginObjects): change destroy to invalidate (WebCore::FrameWin::bindingRootObject): change new RootObject to RootObject::create
- bridge/win/FrameWin.h:
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::bindingInstance): change new RootObject to FrameWin::createRootObject.
- 1:00 AM Changeset in webkit [19212] by
-
- 1 edit in trunk/WebKitQt/WebCoreSupport/ChromeClientQt.cpp
Missed saving this file before the previous checkin.
- 12:47 AM Changeset in webkit [19211] by
-
- 7 edits in trunk/WebKitQt
Implement more functions for the Qt build
Jan 28, 2007:
- 10:28 PM Changeset in webkit [19210] by
-
- 2 edits in trunk/WebCore
Fix redirects with the Qt resource implementation.
- 10:17 PM Changeset in webkit [19209] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Maciej Stachowiak.
First step in fixing <rdar://problem/4485644> REGRESSION: JavaScriptCore
has init routines
Don't rely on a static initializer to store the main thread's ID (which
we would use to detect allocations on secondary threads). Instead, require
the caller to notify fastMalloc if it might allocate on a secondary thread.
Also fixed what seemed like a race condition in do_malloc.
tcmalloc_unittest and my custom versions of JS iBench and PLT show no
regressions.
- wtf/FastMalloc.cpp: (WTF::fastMallocSetIsMultiThreaded): (1) Renamed from "fastMallocRegisterThread", which was a misleading name because not all threads need to register with fastMalloc -- only secondary threads need to, and only for the purpose of disabling its single-threaded optimization.
(2) Use the pageheap_lock instead of a custom one, since we need to synchronize
with the read of isMultiThreaded inside CreateCacheIfNecessary. This is a new
requirement, now that we can't guarantee that the first call to CreateCacheIfNecessary
will occur on the main thread at init time, before any other threads have been created.
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
(WTF::do_malloc): Reverted WTF change only to call GetCache() if size <= kMaxSize.
The WTF code would read phinited without holding the pageheap_lock, which
seemed like a race condition. Regardless, calling GetCache reduces the number
of code paths to module initialization, which will help in writing the
final fix for this bug.
- 10:00 PM Changeset in webkit [19208] by
-
- 2 edits in trunk/WebCore
2007-01-29 Mark Rowe <mrowe@apple.com>
Reviewed by Brady.
http://bugs.webkit.org/show_bug.cgi?id=11085
Bug 11085: REGRESSION: favicon.ico always looked for on port 80
- loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL): Copy the port over to the favicon URL.
- 7:22 PM Changeset in webkit [19207] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele.
Fix http://bugs.webkit.org/show_bug.cgi?id=12453
REGRESSION(r19197): Tabbing into web page requires two key presses
All layout tests pass.
- page/FocusController.cpp: (WebCore::FocusController::advanceFocus): If there's no focused frame, actually go ahead and find a focusable node instead of just focusing the main frame and quitting. This behavior was a holdover from a previous desired tabbing behavior with respect to frames.
- 7:10 PM Changeset in webkit [19206] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Darin and David Hyatt.
- Test for http://bugs.webkit.org/show_bug.cgi?id=12423 Mixing white-space:pre text with non white-space:pre text does not wrap properly
- fast/block/basic/white-space-pre-wraps-expected.checksum: Added.
- fast/block/basic/white-space-pre-wraps-expected.png: Added.
- fast/block/basic/white-space-pre-wraps-expected.txt: Added.
- fast/block/basic/white-space-pre-wraps.html: Added.
WebCore:
Reviewed by Darin and David Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=12423 Mixing white-space:pre text with non white-space:pre text does not wrap properly
Test: fast/block/basic/white-space-pre-wraps.html
- rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Wrap a non-wrapping text run if it appears on a line with previous text runs that do wrap.
- 6:38 PM Changeset in webkit [19205] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Removed files that were not committed from the ChangeLog entry.
- 6:36 PM Changeset in webkit [19204] by
-
- 4 edits2 adds in trunk
LayoutTests:
Reviewed by Darin. Patch by Mitz.
- test for http://bugs.webkit.org/show_bug.cgi?id=8360 Repro crash when onscroll handler deletes the scrolled object
- fast/layers/removed-by-scroll-handler-expected.checksum: Added.
- fast/layers/removed-by-scroll-handler-expected.png: Added.
- fast/layers/removed-by-scroll-handler-expected.txt: Added.
- fast/layers/removed-by-scroll-handler.html: Added.
WebCore:
Reviewed by Darin. Patch by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=8360 Repro crash when onscroll handler deletes the scrolled object
Test: fast/layers/removed-by-scroll-handler.html
- page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Added a m_enqueueEvents count. (WebCore::FrameView::layout): Raise the enqueue count before starting layout and until after enqueued events are dispatched. (WebCore::FrameView::scheduleEvent): Made this function dispatch the event immediately unless the enqueue count is positive.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): Schedule the scroll event through the FrameView. (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::Marquee::start):
- 6:30 PM Changeset in webkit [19203] by
-
- 3 edits2 adds in trunk
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=9815 JavaScript TypeError loading Dean Edwards' JS compressor/obfuscator
Creating a function using 'new Function()' was not setting its prototype with the
same flags as 'function() { }'.
Test: fast/js/function-prototype.html
- kjs/function_object.cpp: (FunctionObjectImp::construct): Change flags from DontEnum|DontDelete|ReadOnly to Internal|DontDelete to match FuncDeclNode::processFuncDecl() and FuncExprNode::evaluate() in kjs/nodes.cpp.
LayoutTests:
Reviewed by Darin.
- Test for http://bugs.webkit.org/show_bug.cgi?id=9815 JavaScript TypeError loading Dean Edwards' JS compressor/obfuscator
- fast/js/function-prototype-expected.txt: Added.
- fast/js/function-prototype.html: Added.
- 4:03 PM Changeset in webkit [19202] by
-
- 9 edits2 adds in trunk/WebCore
2007-01-28 Charles Ying <charles_ying@yahoo.com>
Reviewed by eseidel. Landed by eseidel.
Fix http://bugs.webkit.org/show_bug.cgi?id=12429
animateTransform rotate, with cx/cy is broken
SVGTransform now contains a float point to store the rotation center, needed
to track rotation center for interpolation by animateTransform.
SVGTransform now has an additional constructor:
SVGTransform(type) to make empty base value transforms that match their
distanced values.
Removed m_colorDistance and m_transformDistance from their respective classes
as they are now computed at update time.
Fix a case where animateTransform did not parse transform values correctly
according to BNF in W3C spec:
Test case in:
- manual-tests/animation/animateTransform-toanimation.svg: Added.
Fix a case where animateTransform only specified a to animation only.
Test case in:
- manual-tests/animation/animateTransform-parser.svg: Added.
- ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::updateAnimationBaseValueFromElement): (WebCore::SVGAnimateColorElement::updateAnimatedValue): (WebCore::SVGAnimateColorElement::calculateFromAndToValues):
- ksvg2/svg/SVGAnimateColorElement.h:
- ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::updateAnimatedValue): (WebCore::SVGAnimateTransformElement::updateAnimationBaseValueFromElement): (WebCore::SVGAnimateTransformElement::calculateFromAndToValues): (WebCore::SVGAnimateTransformElement::parseTransformValue):
- ksvg2/svg/SVGAnimateTransformElement.h:
- ksvg2/svg/SVGTransform.cpp: (SVGTransform::SVGTransform): (SVGTransform::angle): (SVGTransform::rotationCenter): (SVGTransform::setTranslate): (SVGTransform::setScale): (SVGTransform::setRotate): (SVGTransform::setSkewX): (SVGTransform::setSkewY):
- ksvg2/svg/SVGTransform.h:
- ksvg2/svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::SVGTransformDistance): (WebCore::SVGTransformDistance::scaledDistance): (WebCore::SVGTransformDistance::addSVGTransforms): (WebCore::SVGTransformDistance::addSVGTransform): (WebCore::SVGTransformDistance::addToSVGTransform): (WebCore::SVGTransformDistance::distance):
- ksvg2/svg/SVGTransformDistance.h:
- manual-tests/animation/animateTransform-parser.svg: Added.
- manual-tests/animation/animateTransform-toanimation.svg: Added.
- 2:48 PM Changeset in webkit [19201] by
-
- 5 edits in S60/trunk/WebKit
spadma
DESC: Entering or leaving a secure web site causes several confirmations MLIO-6XCCTG
Reviewed by Zalan, merge of r19200 from 3.1 branch to s60/trunk by brad.
http://bugzilla.opendarwin.org/show_bug.cgi?id=12415
- 2:12 PM Changeset in webkit [19200] by
-
- 5 edits in S60/branches/3.1m/WebKit
spadma <Sachin.Padma@nokia.com>
Reviewed by Zalan, landed by brad.
DESC: Entering or leaving a secure web site causes several confirmations MLIO-6XCCTG
http://bugzilla.opendarwin.org/show_bug.cgi?id=12415
- 11:35 AM Changeset in webkit [19199] by
-
- 3 edits2 deletes in trunk/LayoutTests
Fixed a broken test to actually work (and fail).
- dom/svg/level3/xpath/Conformance_ID-expected.checksum: Removed.
- dom/svg/level3/xpath/Conformance_ID-expected.png: Removed.
- dom/svg/level3/xpath/Conformance_ID-expected.txt:
- dom/svg/level3/xpath/Conformance_ID.svg:
- 10:17 AM Changeset in webkit [19198] by
-
- 8 edits in S60/trunk
bujtas <zbujtas@gmail.com>
Rs'd by Brad
DESC: display fallback content in case of unsupported plugin.
http://bugs.webkit.org/show_bug.cgi?id=12426
fix: webkit should return null, if the plugin is not supported.
- bridge/WebCoreBridge.h:
- kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::createPart): (KWQKHTMLPart::createSoundstart):
Jan 27, 2007:
- 10:00 PM Changeset in webkit [19197] by
-
- 3 edits in trunk/WebCore
Reviewed by Ada.
Fix <rdar://problem/4957184> REGRESSION: After creating a new mail
message, the caret is automatically in message body
-[WebHTMLView _updateActiveState] was calling
FocusController::focusedOrMainFrame, which had the surprising
side-effect of setting the focused frame if there was none. The fix
was to remove this side-effect.
No tests possible, as this bug involves focus outside the WebView,
which we have no support for in DRT.
Change inspired by Dave Harrison.
- page/FocusController.cpp: (WebCore::FocusController::focusedOrMainFrame): Removed this method's non-obvious side-effect of setting the focused frame.
- WebCore.xcodeproj/project.pbxproj: Version wars.
- 8:39 PM Changeset in webkit [19196] by
-
- 4 edits in trunk/WebCore
WebCore:
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=11880: Improve some egregious
Windows form control drawing issues:
Provide Classic mode fallbacks for the button/textfield drawing
routines.
Provide some basic drawing of menulists (still relatively broken).
Some cleanup.
- platform/win/TemporaryLinkStubs.cpp: (WebCore::RenderThemeWin::systemFont):
- rendering/RenderThemeWin.cpp: (WebCore::m_menuListTheme): (WebCore::RenderThemeWin::close): (WebCore::RenderThemeWin::determineClassicState): (WebCore::RenderThemeWin::getThemeData): (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField): (WebCore::RenderThemeWin::paintMenuList): (WebCore::RenderThemeWin::paintMenuListButton):
- rendering/RenderThemeWin.h: (WebCore::ThemeData::m_classicState): (WebCore::RenderThemeWin::setRadioSize): (WebCore::RenderThemeWin::paintTextArea):
- 8:34 PM Changeset in webkit [19195] by
-
- 11 edits in trunk
WebCore:
Reviewed by Adam.
- fix http://bugs.webkit.org/show_bug.cgi?id=12260 Windows platform build is not maintained
- loader/win/FrameLoaderWin.cpp:
- platform/network/win/ResourceHandleWin.cpp:
- platform/win/TemporaryLinkStubs.cpp: (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::DocumentLoader::unreachableURL): (WebCore::FrameLoader::redirectDataToPlugin): (WebCore::FrameLoader::partClearedInBegin): (WebCore::FrameLoader::createPlugin):
WebKit:
Reviewed by Adam.
- fix http://bugs.webkit.org/show_bug.cgi?id=12260 Windows platform build is not maintained
- COM/ChromeClientWin.cpp: (ChromeClientWin::canTakeFocus): (ChromeClientWin::takeFocus):
- COM/ChromeClientWin.h:
- COM/ContextMenuClientWin.cpp: (ContextMenuClientWin::getCustomMenuFromDefaultItems): (ContextMenuClientWin::searchWithGoogle):
- COM/ContextMenuClientWin.h:
- COM/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::completeProgress): (WebFrameLoaderClient::startDownload): (WebFrameLoaderClient::committedLoad): (WebFrameLoaderClient::cancelledError): (WebFrameLoaderClient::cannotShowURLError): (WebFrameLoaderClient::interruptForPolicyChangeError): (WebFrameLoaderClient::cannotShowMIMETypeError): (WebFrameLoaderClient::fileDoesNotExistError): (WebFrameLoaderClient::shouldFallBack): (WebFrameLoaderClient::willUseArchive): (WebFrameLoaderClient::createDocumentLoader): (WebFrameLoaderClient::download):
- COM/WebFrameLoaderClient.h:
- 8:29 PM Changeset in webkit [19194] by
-
- 1 edit4 adds in trunk/LayoutTests
LayoutTests:
Reviewed by NOBODY (missing pixel test results).
- fast/dom/gc-10-expected.checksum: Added.
- fast/dom/gc-10-expected.png: Added.
- http/tests/misc/location-replace-crossdomain-expected.checksum: Added.
- http/tests/misc/location-replace-crossdomain-expected.png: Added.
- 6:58 PM Changeset in webkit [19193] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Beth Dakin.
Added some missing JSLocks, which might fix <rdar://problem/4889707>.
We need to lock whenever we might allocate memory because our FastMalloc
implementation requires clients to register their threads, which we do
through JSLock.
We also need to lock whenever modifying ref-counts because they're not
thread-safe.
- API/JSObjectRef.cpp: (JSClassCreate): Allocates memory (JSClassRetain): Modifies a ref-count (JSClassRelease): Modifies a ref-count (JSPropertyNameArrayRetain): Modifies a ref-count (JSPropertyNameArrayRelease): Modifies a ref-count
- API/JSStringRef.cpp: (JSStringRetain): Modifies a ref-count
- API/JSValueRef.cpp: (JSValueIsInstanceOfConstructor): Might allocate memory if an exception is thrown.
- 2:37 PM Changeset in webkit [19192] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Mitz.
- Test for http://bugs.webkit.org/show_bug.cgi?id=11957 Unordered List Bullets too big and changing from size
- fast/lists/big-list-marker-expected.checksum: Added.
- fast/lists/big-list-marker-expected.png: Added.
- fast/lists/big-list-marker-expected.txt: Added.
- fast/lists/big-list-marker.html: Added.
WebCore:
Reviewed by Mitz.
- Patch for http://bugs.webkit.org/show_bug.cgi?id=11957 REGRESSION: Unordered List Bullets too big and changing from size
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): Explicitly set the stroke size to 1.0f.
- 1:01 PM Changeset in webkit [19191] by
-
- 2 edits in trunk/WebKit
Reviewed by Kevin.
<rdar://problem/4958902> REGRESSION: Dashboard widgets fail to load
This was caused by the WebView preferences rework in r18417. Specifically, in
_updateWebCoreSettingsFromPreferences when calling setUserStyleSheetLocation,
[NSURL URLWithString:] is now messaged directly with the result of
preferences userStyleSheetLocation] _web_originalDataAsString, which will
be nil if the userStyleSheetLocation has not been set yet. [NSURL URLWithString:]
throws an exception when the string is nil. DashboardClient.app calls
setUserStyleSheetEnabled *before* calling setUserStyleSheetLocation.
- WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]): Pass empty string instead of nil string to [NSURL URLWithString:].
- 12:34 PM Changeset in webkit [19190] by
-
- 9 edits in trunk
Fix the Qt build and disable the usage
of QScrollbars for PlatformScrollBar for
now as it causes crashes in the layout tests.
- 7:52 AM Changeset in webkit [19189] by
-
- 2 edits in trunk/WebCore
WebCore:
Reviewed by NOBODY (buildbot build fix).
- ksvg2/svg/ColorDistance.cpp: (WebCore::ColorDistance::scaledDistance): Added static cast of arguments to int.
- 7:00 AM Changeset in webkit [19188] by
-
- 3 edits in trunk/WebCore
Reviewed by NOBODY (typo in method name fix).
- 3:24 AM Changeset in webkit [19187] by
-
- 3 edits1 add in trunk/WebCore
2007-01-27 Eric Seidel <eric@webkit.org>
Reviewed by olliej.
Fix support for SVG's <set> element.
Manual test added.
- ksvg2/svg/SVGSetElement.cpp: (WebCore::SVGSetElement::updateAnimatedValue): (WebCore::SVGSetElement::calculateFromAndToValues):
- ksvg2/svg/SVGSetElement.h:
- manual-tests/animation/set-to.svg: Added.
- 2:16 AM Changeset in webkit [19186] by
-
- 2 edits in trunk/WebCore
Release build fix.
- loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset):
- 2:02 AM Changeset in webkit [19185] by
-
- 3 edits2 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=12389
Chinese decoding error at hk.antispam.yahoo.com
Test: fast/encoding/noscript-in-head.html
- loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): We were already allowing NOSCRIPT tags in head, let's actually skip over their content.
- 12:13 AM Changeset in webkit [22859] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
Reviewed by Oliver.
Fix <rdar://problem/4944863> WebError::localizedDescription needs to be implemented.
This was so simple, I don't know why I didn't do this before.
- WebError.cpp: (WebError::localizedDescription): Implemented.
Jan 26, 2007:
- 11:53 PM Changeset in webkit [19184] by
-
- 1 edit in trunk/WebCore/ChangeLog
Added forgotten Radar reference.
- 8:50 PM Changeset in webkit [19183] by
-
- 34 edits2 adds in trunk
Reviewed by Maciej Stachowiak.
Fixed <rdar://problem/4608404> WebScriptObject's _rootObject lack
of ownership policy causes crashes (e.g., in Dashcode)
The old model for RootObject ownership was either to (1) leak them or (2) assign
them to a single owner -- the WebCore::Frame -- which would destroy them
when it believed that all of its plug-ins had unloaded.
This model was broken because of (1) and also because plug-ins are not the only
RootObject clients. All Bindings clients are RootObjects clients, including
applications, which outlive any particular WebCore::Frame.
The new model for RootObject ownership is to reference-count them, with a
throw-back to the old model: The WebCore::Frame tracks the RootObjects
it creates, and invalidates them when it believes that all of its plug-ins
have unloaded.
We maintain this throw-back to avoid plug-in leaks, particularly from Java.
Java is completely broken when it comes to releasing JavaScript objects.
Comments in our code allege that Java does not always call finalize when
collecting objects. Moreoever, my own testing reveals that, when Java does
notify JavaScript of a finalize, the data it provides is totally bogus.
This setup is far from ideal, but I don't think we can do better without
completely rewriting the bindings code, and possibly part of the Java
plug-in / VM.
Layout tests pass. No additional leaks reported. WebCore/manual-tests/*liveconnect*
and a few LiveConnect demos on the web also run without a hitch.
const RootObject* => RootObject*, since we need to ref/deref
- bindings/NP_jsobject.cpp: (jsDeallocate): deref our RootObjects. Also unprotect or JSObject, instead of just relying on the RootObject to do it for us when it's invalidated. (_isSafeScript): Check RootObject validity. (_NPN_CreateScriptObject): ditto (_NPN_Invoke): ditto (_NPN_Evaluate): ditto (_NPN_GetProperty): ditto (_NPN_SetProperty): ditto (_NPN_RemoveProperty): ditto (_NPN_HasProperty): ditto (_NPN_HasMethod): ditto (_NPN_SetException): ditto
- bindings/runtime_root.cpp: Revived bit-rotted LIAR LIAR LIAR comment.
LOOK: Added support for invalidating RootObjects without deleting them,
which is the main goal of this patch.
Moved protect counting into the RootObject class, to emphasize that
the RootObject protects the JSObject, and unprotects it upon being invalidated.
addNativeReference => RootObject::gcProtect
removeNativeReference => RootObject::gcUnprotect
ProtectCountSet::contains => RootObject::gcIsProtected
I know we'll all be sad to see the word "native" go.
- bindings/runtime_root.h: Added ref-counting support to RootObject, with all the standard accoutrements.
- bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant): If we can't find a valid RootObject, return void instead of just leaking.
- bindings/jni/jni_instance.cpp: (JavaInstance::JavaInstance): Don't take a RootObject in our constructor; be like other Instances and require the caller to call setRootObject. This reduces the number of ownership code paths. (JavaInstance::invokeMethod): Check RootObject for validity.
- bindings/jni/jni_instance.h: Removed private no-arg constructor. Having an arg constructor accomplishes the same thing.
- bindings/jni/jni_jsobject.cpp: (JavaJSObject::invoke): No need to call findProtectCountSet, because finalize() checks for RootObject validity. (JavaJSObject::JavaJSObject): check RootObject for validity (JavaJSObject::call): ditto (JavaJSObject::eval): ditto (JavaJSObject::getMember): ditto (JavaJSObject::setMember): ditto (JavaJSObject::removeMember): ditto (JavaJSObject::getSlot): ditto (JavaJSObject::setSlot): ditto (JavaJSObject::toString): ditto (JavaJSObject::finalize): ditto (JavaJSObject::createNative): No need to tell the RootObject to protect the global object, since the RootObject already owns the interpreter.
- bindings/jni/jni_runtime.cpp: (JavaArray::JavaArray): Removed copy construcutor becaue it was unused. Dead code is dangerous code.
- bindings/objc/objc_runtime.mm: Added WebUndefined protocol. Previous use of WebScriptObject was bogus, because WebUndefined is not a subclass of WebScriptObject. (convertValueToObjcObject): If we can't find a valid RootObject, return nil instead of just leaking.
- bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): If we can't find a valid RootObject, return nil instead of just leaking.
LayoutTests:
Reviewed by Maciej Stachowiak.
Added test for <rdar://problem/4608404> WebScriptObject's _rootObject lack
of ownership policy causes crashes (e.g., in Dashcode)
No test for Java or NPP versions of this bug because there's no reliable way to
make Java and NPP objects outlive their RootObjects (although Java objects
sometimes do).
- plugins/root-object-premature-delete-crash-expected.txt: Added.
- plugins/root-object-premature-delete-crash.html: Added.
WebCore:
Reviewed by Maciej Stachowiak.
Fixed <rdar://problem/4608404> WebScriptObject's _executionContext lack
of ownership policy causes crashes (e.g., in Dashcode)
Added RootObject ref-counting goodness.
- page/mac/FrameMac.h:
- page/mac/FrameMac.mm: (WebCore::FrameMac::cleanupPluginObjects): Invalidate our RootObjects instead of detroying them. Track _bindingRootObject separately from the rest of our RootObjects, since it has its own variable.
- page/mac/WebCoreFrameBridge.mm: (createRootObject): Use the Frame's new, more encapsulated function to create a RootObject.
- bindings/objc/WebScriptObject.mm: Nixed rootObject setters, since they were unused and they complicated reference-counting.
WebKitTools:
Reviewed by Maciej Stachowiak.
Added support for test for <rdar://problem/4608404> WebScriptObject's
_rootObject lack of ownership policy causes crashes (e.g., in Dashcode)
- DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController storeWebScriptObject:]): (-[LayoutTestController accessStoredWebScriptObject]): (-[LayoutTestController dealloc]):
- 8:28 PM Changeset in webkit [19182] by
-
- 2 edits in trunk/WebKit
WebKit:
Reviewed by Timothy.
Fixes crash drawing avatar on mail.yahoo.com.
- Plugins/WebBaseNetscapePluginStream.m: Retain the object since destroyStreamWithError: might release the last reference to it.
- 8:10 PM Changeset in webkit [22858] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
2007-01-26 Steve Falkenburg <sfalken@apple.com>
B&I build fix
- WebKit.vcproj/WebKit.vcproj:
- 7:51 PM Changeset in webkit [19181] by
-
- 2 edits in trunk/WebCore
WebCore:
Reviewed by Eric.
Release build fix.
- ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::calculateValueIndexAndPercentagePast): Added static cast to unsigned when calculating flooredValueIndex.
- 6:38 PM Changeset in webkit [19180] by
-
- 2 edits in S60/branches/3.1m/WebCore
bujtas <zbujtas@gmail.com>
Rs'd & merged to 3.1 branch by Brad
DESC: HTMLScriptElementImpl gets notified twice about 'insert new script' event. MLIO-6X9HKM
fix: prevents double notification.
- 6:37 PM Changeset in webkit [19179] by
-
- 2 edits in S60/trunk/WebCore
bujtas <zbujtas@gmail.com>
Rs'd by Brad.
DESC: HTMLScriptElementImpl gets notified twice about 'insert new script' event. MLIO-6X9HKM
fix: prevents double notification.
- 6:31 PM Changeset in webkit [19178] by
-
- 4 edits3 adds in trunk
Reviewed by Maciej.
Fix for Repeated string concatenation results in OOM crash
http://bugs.webkit.org/show_bug.cgi?id=11131
- kjs/operations.cpp: (KJS::add): Throw exception if string addition result is null
- kjs/ustring.cpp: (KJS::UString::UString): Don't call memcpy when malloc failed
LayoutTests:
Reviewed by Maciej.
Test for "Repeated string concatenation results in OOM crash"
http://bugs.webkit.org/show_bug.cgi?id=11131
- fast/js/resources/string-concatenate-outofmemory.js: Added.
- fast/js/string-concatenate-outofmemory-expected.txt: Added.
- fast/js/string-concatenate-outofmemory.html: Added.
- 6:28 PM Changeset in webkit [19177] by
-
- 8 edits in S60/branches/3.1m
bujtas <zbujtas@gmail.com>
Rs'd by Brad.
DESC: display fallback content in case of unsupported plugin PKAI-6WGSHS
http://bugs.webkit.org/show_bug.cgi?id=12426
fix: webkit should return null, if the plugin is not supported.
- bridge/WebCoreBridge.h:
- kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::createPart): (KWQKHTMLPart::createSoundstart):
- 6:21 PM Changeset in webkit [19176] by
-
- 4 edits in trunk/WebCore
- checked in slightly newer revision of the patch below
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Grouped all the unimplemented values at the bottom. Fixed the ifdef for CSS_PROPWEBKIT_DASHBOARD_REGION so that it compiles on all platforms.
- css/cssparser.cpp: (WebCore::CSSParser::parseValue): Removed default case and added type so that the compiler warns about missing properties.
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): Ditto.
- 6:13 PM Changeset in webkit [19175] by
-
- 12 edits in trunk
LayoutTests:
Reviewed by Beth.
- updated test results for change to computed style
- editing/pasteboard/paste-table-002-expected.txt: Updated for change to order of style properties.
- fast/css/computed-style-expected.txt: Updated for change to order of style properties and to add new ones.
WebCore:
Reviewed by Beth.
- fix http://bugs.webkit.org/show_bug.cgi?id=12412 "unimplemented propertyID: 46" seen at dojotoolkit.org
Covered by fast/css/computed-style.html
- css/CSSPropertyNames.in: Sorted the file into two separate sections, one for properties without the -webkit- prefix and another for properties with.
- css/makeprop: Generate a CSSPropertyID enum instead of a set of #defines. Removed unused CSS_PROP_MIN and CSS_PROP_MAX. Renamed CSS_PROP_TOTAL to numCSSProperties and changed it to a const int instead of #define. Added a declaration of getPropertyName in the header. Changed the return type of getPropertyName to const char* and the parameter type to CSSPropertyID.
- css/CSSComputedStyleDeclaration.cpp: Sort the lists of properties in an easier to maintain order -- properties without a WebKit prefix first. (WebCore::valueForLength): Changed return value to PassRefPtr. (WebCore::valueForMaxLength): Ditto. (WebCore::valueForBorderStyle): Ditto. (WebCore::valueForTextAlign): Ditto. (WebCore::valueForAppearance): Added. (WebCore::valueForMarginCollapse): Added. (WebCore::valueForShadow): Changed return value to PassRefPtr. (WebCore::getPositionOffsetValue): Ditto. (WebCore::currentColorOrValidColor): Ditto. (WebCore::CSSComputedStyleDeclaration::cssText): Added cast since getPropertyName now takes an enum value. (WebCore::primitiveValueFromLength): Changed return value to PassRefPtr. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added cast to CSSPropertyID so that gcc will detect missing enums in the switch statement. Simplified the background-size and border-spacing implementations so they don't have local variables. Added lots of cases to the switch statement for unimplemented properties. Implemented the outline-width, box-sizing, -webkit-appearance, -webkit-rtl-ordering, -webkit-user-drag, and -webkit-user-select properties. (WebCore::CSSComputedStyleDeclaration::item): Added cast since getPropertyName now takes an enum value.
- css/CSSMutableStyleDeclaration.cpp: Removed declaration of getPropertyName. (WebCore::CSSMutableStyleDeclaration::item): Added cast since getPropertyName now takes an enum value.
- css/CSSProperty.cpp: Removed declaration of getPropertyName. (WebCore::CSSProperty::cssText): Added cast since getPropertyName now takes an enum value and returns a const char*.
- css/CSSStyleDeclaration.cpp: Removed declaration of getPropertyName. (WebCore::CSSStyleDeclaration::getPropertyShorthand): Added cast since getPropertyName now takes an enum value and returns a const char*.
WebKit:
Reviewed by Beth.
- WebInspector/webInspector/inspector.js: Updated for new computed style properties.
- 6:11 PM Changeset in webkit [19174] by
-
- 2 edits in trunk/WebCore
Reviewed by Brady.
Fixed <rdar://problem/4838076> CrashTracer: 10 crashes in Mail at com.apple.WebCore: WTF::HashMap<WebCore::String
- loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): Added nil check around resource from cache.
- 6:11 PM Changeset in webkit [22857] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Oliver.
Fix frequent failed assertions when painting scroll bars.
- 6:05 PM Changeset in webkit [19173] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver.
Build fix.
- ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::calculateValueIndexAndPercentagePast): Keep index variables as unsigned until we need to convert to float.
- 6:04 PM Changeset in webkit [19172] by
-
- 7 edits4 adds in trunk
LayoutTests:
Reviewed by Ada.
Added tests for <rdar://problem/4919097> REGRESSION: Ctrl-Y fails to yank (11076)
- editing/pasteboard/emacs-ctrl-a-k-y-expected.checksum: Added.
- editing/pasteboard/emacs-ctrl-a-k-y-expected.png: Added.
- editing/pasteboard/emacs-ctrl-a-k-y-expected.txt: Added.
- editing/pasteboard/emacs-ctrl-a-k-y.html: Added. Test for <rdar://problem/4919097>
- editing/deleting/delete-by-word-001-expected.txt:
- editing/deleting/delete-by-word-002-expected.txt:
- editing/deleting/delete-to-end-of-paragraph-expected.txt:
- editing/pasteboard/emacs-cntl-y-001-expected.txt: The expected results of these tests were affected by the WebCore checkin of the same number. The results are the same, but there were more editing delegates that were called, as expected. I suspect these tests were created during the time that <rdar://problem/4919097> was broken
WebCore:
Reviewed by Ada.
Fixed <rdar://problem/4919097> REGRESSION: Ctrl-Y fails to yank (11076)
- editing/Editor.cpp: (WebCore::Editor::deleteWithDirection): If there's no selection, locally create a range that is to the end of the granularity unit and pass that to deleteRange().
- 6:01 PM Changeset in webkit [22856] by
-
- 3 edits in branches/WindowsMerge/WebKitWin
WebKitWin:
Reviewed by Oliver.
Engine side of fix for <rdar://problem/4958371> Boomer leaks WebViews
The problem was that we were calling RevokeDragDrop after our view
window had been destroyed, RevokeDragDrop wouldn't call Release on us.
Fix <rdar://problem/4958382> WebViews leak their HWND if no host window is set
- WebView.cpp: (WebView::~WebView): Call DestroyWindow if our view window hasn't been destroyed yet. (WebViewWndProc): Added an ASSERT, and added call to revokeDragDrop when handling WM_DESTROY. (WebView::initWithFrame): Call our own registerDragDrop. (WebView::close): Removed call to RevokeDragDrop. At this point our window has been destroyed, so it's too late to do this. (WebView::registerDragDrop): Added. (WebView::revokeDragDrop): Added.
- WebView.h: Added declarations.
- 5:55 PM Changeset in webkit [19171] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
Qt build fix.
- page/qt/EventHandlerQt.cpp:
- 5:44 PM Changeset in webkit [22855] by
-
- 2 edits in branches/WindowsMerge/WebCore
2007-01-26 Oliver Hunt <oliver@apple.com>
Build fix.
- WebCore.vcproj/WebCore.vcproj:
- 5:43 PM Changeset in webkit [19170] by
-
- 2 edits in trunk/WebCore
Reviewed by Hyatt.
Fix so that we only relayout frameset children on calls to layout.
- page/FrameView.cpp: (WebCore::FrameView::layout):
- 5:35 PM Changeset in webkit [19169] by
-
- 3 edits in trunk/WebCore
2007-01-26 Oliver Hunt <oliver@apple.com>
Build Fix
- ksvg2/svg/ColorDistance.cpp:
- ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::handleTimerEvent):
- 4:59 PM Changeset in webkit [19168] by
-
- 20 edits14 adds in trunk/WebCore
2007-01-26 Eric Seidel <eric@webkit.org>
Reviewed by olliej.
Add support for calcMode, keyTimes and (nearly) keySplines.
http://bugs.webkit.org/show_bug.cgi?id=12350
Re-architect much of the animation system to remove huge sections of code.
Added new ColorDistance, SVGTransformDistance to simplify animateColor, animateTransform calculations.
I also added basic <animateMotion> support since it was so easy w/ the new architecture.
Adding manual animation tests until bug 12074 is fixed.
- WebCore.xcodeproj/project.pbxproj:
- ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::applyAnimations):
- ksvg2/svg/ColorDistance.cpp: Added. (WebCore::ColorDistance::ColorDistance): (WebCore::clampColorValue): (WebCore::ColorDistance::scaledDistance): (WebCore::ColorDistance::addColorsAndClamp): (WebCore::ColorDistance::addToColorAndClamp): (WebCore::ColorDistance::isZero): (WebCore::ColorDistance::distance):
- ksvg2/svg/ColorDistance.h: Added.
- ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::SVGAnimateColorElement): (WebCore::SVGAnimateColorElement::updateAnimationBaseValueFromElement): (WebCore::SVGAnimateColorElement::applyAnimatedValueToElement): (WebCore::SVGAnimateColorElement::updateAnimatedValue): (WebCore::SVGAnimateColorElement::calculateFromAndToValues):
- ksvg2/svg/SVGAnimateColorElement.h: (WebCore::SVGAnimateColorElement::contextElement):
- ksvg2/svg/SVGAnimateElement.h: (WebCore::SVGAnimateElement::updateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues):
- ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::hasValidTarget): (WebCore::SVGAnimateMotionElement::updateAnimatedValue): (WebCore::parsePoint): (WebCore::SVGAnimateMotionElement::calculateFromAndToValues): (WebCore::SVGAnimateMotionElement::updateAnimationBaseValueFromElement): (WebCore::SVGAnimateMotionElement::applyAnimatedValueToElement):
- ksvg2/svg/SVGAnimateMotionElement.h:
- ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement): (WebCore::SVGAnimateTransformElement::updateAnimatedValue): (WebCore::SVGAnimateTransformElement::updateAnimationBaseValueFromElement): (WebCore::SVGAnimateTransformElement::applyAnimatedValueToElement): (WebCore::SVGAnimateTransformElement::calculateFromAndToValues): (WebCore::SVGAnimateTransformElement::parseTransformValue):
- ksvg2/svg/SVGAnimateTransformElement.h: (WebCore::SVGAnimateTransformElement::contextElement):
- ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseKeyNumbers): (WebCore::parseValues): (WebCore::parseKeySplines): (WebCore::SVGAnimationElement::parseMappedAttribute): (WebCore::SVGAnimationElement::targetAttributeAnimatedValue): (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue): (WebCore::SVGAnimationElement::detectAnimationMode): (WebCore::adjustPercentagePastForKeySplines): (WebCore::SVGAnimationElement::valueIndexAndPercentagePastForDistance): (WebCore::SVGAnimationElement::calculateTotalDistance): (WebCore::caculateValueIndexForKeyTimes): (WebCore::SVGAnimationElement::isValidAnimation): (WebCore::SVGAnimationElement::calculateValueIndexAndPercentagePast): (WebCore::SVGAnimationElement::updateAnimationBaseValueFromElement): (WebCore::SVGAnimationElement::applyAnimatedValueToElement): (WebCore::SVGAnimationElement::handleTimerEvent): (WebCore::SVGAnimationElement::updateAnimatedValueForElapsedSeconds):
- ksvg2/svg/SVGAnimationElement.h:
- ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPolyParser::parsePoints):
- ksvg2/svg/SVGParserUtilities.h:
- ksvg2/svg/SVGSetElement.cpp:
- ksvg2/svg/SVGSetElement.h: (WebCore::SVGSetElement::updateAnimatedValue): (WebCore::SVGSetElement::calculateFromAndToValues):
- ksvg2/svg/SVGTransform.cpp: (SVGTransform::type): (SVGTransform::translate): (SVGTransform::scale): (SVGTransform::setSkewX): (SVGTransform::setSkewY):
- ksvg2/svg/SVGTransform.h: (WebCore::operator==): (WebCore::operator!=):
- ksvg2/svg/SVGTransformDistance.cpp: Added. (WebCore::SVGTransformDistance::SVGTransformDistance): (WebCore::SVGTransformDistance::scaledDistance): (WebCore::SVGTransformDistance::addSVGTransforms): (WebCore::SVGTransformDistance::addSVGTransform): (WebCore::SVGTransformDistance::addToSVGTransform): (WebCore::SVGTransformDistance::isZero): (WebCore::SVGTransformDistance::distance):
- ksvg2/svg/SVGTransformDistance.h: Added.
- ksvg2/svg/SVGTransformList.cpp: (SVGTransformList::concatenateForType):
- ksvg2/svg/SVGTransformList.h:
- manual-tests/animation/animateColor-by.svg: Added.
- manual-tests/animation/animateColor-from-by.svg: Added.
- manual-tests/animation/animateColor-repeat-indefinite.svg: Added.
- manual-tests/animation/animateColor-to-from.svg: Added.
- manual-tests/animation/animateColor-to.svg: Added.
- manual-tests/animation/animateColor-values-simple.svg: Added.
- manual-tests/animation/animateMotion-to.svg: Added.
- manual-tests/animation/animateTransform-keyTimes.svg: Added.
- manual-tests/animation/animateTransform-repeat-once.svg: Added.
- 4:52 PM Changeset in webkit [19167] by
-
- 4 edits in trunk/WebKit
Reviewed by andersca.
Fixed: <rdar://problem/4946922> WebBaseNetscapePluginView leaks memory
http://bugs.webkit.org/show_bug.cgi?id=11523
- Plugins/WebBaseNetscapePluginStream.m:
(-[WebBaseNetscapePluginStream setPlugin:]): Calls -[WebBaseNetscapePluginView disconnectStream:]
- Plugins/WebBaseNetscapePluginView.h: Added disconnectStream: to header.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView stop]): Make a copy of the streams collection prior to calling stop all streams. This is necessary because calling stop has the side effect of removing the stream from this same collection. (-[WebBaseNetscapePluginView disconnectStream:]): Added. Removes the stream from the streams collection.
- 4:16 PM Changeset in webkit [22854] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Darin.
Due to <rdar://problem/4956565> REGRESSION: After scrolling frame,
hovering over link in this frame doesn't change cursor to pointing
hand
lastEventIsMouseUp() is a Mac-only issue. This patch makes it Mac-
only code, so we can remove the temporary link stub for it.
- platform/win/TemporaryLinkStubs.cpp:
- 4:03 PM Changeset in webkit [19166] by
-
- 4 edits in trunk/WebCore
Reviewed by Darin.
Fix for <rdar://problem/4956565> REGRESSION: After scrolling frame,
hovering over link in this frame doesn't change cursor to pointing
hand
The mouseMove event was not being propagated correctly after using
the mouse to scroll the frame because m_mousePressed was never
getting set to false.
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): This code does not belong here.
- page/EventHandler.h: lastEventIsMouseUp() is only ever relevant in EventHandlerMac, so it can just be a static function there.
- page/mac/EventHandlerMac.mm: (WebCore::lastEventIsMouseUp): Make this static. (WebCore::EventHandler::passMouseDownEventToWidget): Here is where we need to set m_mousePressed to false if lastEventIsMouseUp() is true.
- 3:58 PM Changeset in webkit [22853] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
Reviewed by Adam.
- WebKitDLL.cpp: Add WebURLRequest entries to the big array.
- 3:36 PM Changeset in webkit [22852] by
-
- 6 edits in branches/WindowsMerge/WebKitWin
WebKitWin:
Reviewed by Adam.
<rdar://problem/4923845>
Implement IWebURLRequest.
- Interfaces/WebKit.idl:
- WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance):
- WebKitDLL.cpp: (DllGetClassObject):
- WebMutableURLRequest.cpp: (WebMutableURLRequest::WebMutableURLRequest): (WebMutableURLRequest::createInstance): (WebMutableURLRequest::createImmutableInstance): (WebMutableURLRequest::QueryInterface):
- WebMutableURLRequest.h:
- 2:47 PM Changeset in webkit [19165] by
-
- 4 adds in trunk/LayoutTests/fast/css
Add layout test for orphaned CSS unit coalescing.
- 2:45 PM Changeset in webkit [19164] by
-
- 4 edits in trunk/WebCore
Fix for style regression caused by strictness checking of the number of properties. This caused code like:
"width: 20 px" to fail, because we interpreted it as two values and rejected it. Our old code allowed 20 to be
used like a pixel value and then ignored the orphaned unit.
This patch actually scans the list of values looking for orphaned units and reattaches them to the numeric
values that they should correspond to. This means rules like "width: 5 em" will now work in quirks mdoe and
the "em" unit type will be honored.
Reviewed by beth
- WebCore.xcodeproj/project.pbxproj:
- css/cssparser.cpp: (WebCore::unitFromString): (WebCore::CSSParser::checkForOrphanedUnits): (WebCore::CSSParser::parseValue):
- css/cssparser.h: (WebCore::ValueList::valueAt): (WebCore::ValueList::deleteValueAt):
- 2:19 PM Changeset in webkit [19163] by
-
- 14 edits in trunk
What's left of my trashed work to add more Qt functionality
- 2:02 PM Changeset in webkit [19162] by
-
- 2 edits in trunk/WebCore
Fixed build that use RetainPtr::adoptCFReference(CFTypeRef)
- 1:13 PM Changeset in webkit [19161] by
-
- 3 edits in trunk/WebKitQt
Make it compile again with Qt 4.2 and add the copyright
headers where forgotten in the last submit.
- 11:51 AM Changeset in webkit [22851] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
2007-01-26 Steve Falkenburg <sfalken@apple.com>
B&I build fix
- WebKit.vcproj/WebKit.vcproj:
- 11:50 AM Changeset in webkit [22850] by
-
- 3 edits in branches/WindowsMerge/WebKitWin
WebKitWin:
Reviewed by Adam.
Don't pretend that we're an IWebHTTPURLResponse when we're not.
- WebURLResponse.cpp: (WebURLResponse::QueryInterface): (WebURLResponse::allHeaderFields): (WebURLResponse::localizedStringForStatusCode): (WebURLResponse::statusCode):
- WebView.cpp: (WebView::canShowMIMEType): Implement this.
- 11:31 AM Changeset in webkit [19160] by
-
- 5 edits in trunk/WebCore
Reviewed by Brady.
- fix <rdar://problem/4956688> move Mac-specific part of icon code into IconMac
- fix a GC-compatibility problem in the icon code I noticed by code inspection
- platform/FileChooser.cpp: (WebCore::FileChooser::chooseIcon): Removed Mac-specific path check -- that's in newIconForFile now.
- platform/graphics/Icon.h: Changed the image to be a RetainPtr. The old code was using -[NSObject retain] which is not good enough for a pointer in a C++ object.
- platform/graphics/mac/IconMac.mm: (WebCore::Icon::Icon): Got rid of unneeded code to do what RetainPtr does for us. (WebCore::Icon::~Icon): Ditto. (WebCore::Icon::newIconForFile): Added check for non-absolute file names. Updated for use of RetainPtr. Use constructor that takes NSImage. (WebCore::Icon::paint): Add get() calls needed now that we are using a RetainPtr.
- WebCore.xcodeproj/project.pbxproj: Let Xcode do its thing.
- 10:10 AM Changeset in webkit [19159] by
-
- 3 edits2 adds in trunk
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=12385
Assertion failure when loading subresources from "data:" frames
Test: fast/loader/opaque-base-url.html
- platform/KURL.cpp: (WebCore::KURL::init): Make the URL invalid if it's relative, but has an opaque or empty base.
- 10:01 AM Changeset in webkit [22849] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
I'm in ur WebDownloadz, null checkin ur pointerz
- 9:20 AM Changeset in webkit [19158] by
-
- 4 edits in trunk
LayoutTests:
- fast/events/objc-event-api-expected.txt: Updated test result now that we no longer invalidate clicks when the mouse moves a bit.
WebCore:
Reviewed by Darin.
- page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): Removed a call to invalidateClick(), since we don't want to cancel a click if the mouse moves.
- 9:14 AM Changeset in webkit [19157] by
-
- 2 edits in trunk/WebCore
- css/MediaQueryEvaluator.cpp: (WebCore::MediaQueryEvaluator::mediaTypeMatchSpecific): Oops, forgot a !.
- 9:10 AM Changeset in webkit [19156] by
-
- 5 edits in trunk/WebCore
Patch by Nate Begeman.
Reviewed by Darin and Maciej.
- <rdar://problem/4946877> Avoid unnecessary allocations in CSS, patch attached (12401) http://bugs.webkit.org/show_bug.cgi?id=12401
- css/MediaQueryEvaluator.h: Add mediaTypeMatchSpecific, a function that takes a char* to avoid creating and destroying a String for simple media type queries.
- css/MediaQueryEvaluator.cpp: (WebCore::MediaQueryEvaluator::mediaTypeMatchSpecific): Added. Besides avoiding the conversion to String, this also doesn't have the special case code to handle "" and "all".
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::matchUARules): Call mediaTypeMatchSpecific here when deciding whether to use the print version of the user agent style sheet.
- loader/Cache.cpp: (WebCore::Cache::requestResource): Don't convert to a string and back to a KURL when calling createResource. Avoids reparsing the URL string.
- 8:55 AM Changeset in webkit [19155] by
-
- 3 edits in S60/trunk/WebCore
yongjzha
Reviewed by <zbujtas@gmail.com>
DESC: PNUN-6XJJLF When use css border property outset, and set border color to blue, the browser
shows black at the bottom edge and right edge.
fix: correct RGB to HSV and HSV to RGB conversion algorithms in KWQColor.cpp
- 8:53 AM Changeset in webkit [19154] by
-
- 3 edits in S60/branches/3.1m/WebCore
yongjzha
Reviewed by <zbujtas@gmail.com>
DESC: PNUN-6XJJLF When use css border property outset, and set border color to blue, the browser
shows black at the bottom edge and right edge.
fix: correct RGB to HSV and HSV to RGB conversion algorithms in KWQColor.cpp
- 8:49 AM Changeset in webkit [19153] by
-
- 2 edits in S60/branches/3.1m/WebKit
2007-01-26 Deepa
Reviewed by Sachin.
DESC: Resolve FavIcon issue in cases of websites with the same sub domain name (AKKO-6XJDCQ)
The function ExtractDomainL( ) was changed to include the entire host name
instead of just the last two parts.
- 8:48 AM Changeset in webkit [19152] by
-
- 2 edits in S60/trunk/WebKit
2007-01-26 Deepa
Reviewed by Sachin.
DESC: Resolve FavIcon issue in cases of websites with the same sub domain name (AKKO-6XJDCQ)
The function ExtractDomainL( ) was changed to include the entire host name
instead of just the last two parts.
- 5:13 AM Changeset in webkit [19151] by
-
- 5 edits3 adds in trunk
History support on platform Qt. r=lars
We might switch to a model but for now this is ok.
- 5:01 AM Changeset in webkit [19150] by
-
- 4 edits1 add in trunk/WebCore
introduce platform scrollbars on Qt platform
- 3:40 AM Changeset in webkit [19149] by
-
- 19 edits2 adds in trunk
2007-01-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=11109 REGRESSION (r15471): menus are offset on eink.com <rdar://problem/4824760>
Changed offset{Left,Top} to match Firefox. If the body element is statically
positioned, it is still returned as the offsetParent of elements whose containing
block is the initial containing block (the root), but their offset{Left,Top} are
relative to the root. If the body element is positioned, then offsets are relative
to it. The body's own offset{Left,Top} are always 0.
Test: fast/dom/Element/offsetLeft-offsetTop-body-quirk.html
- rendering/RenderObject.cpp: (WebCore::RenderObject::offsetLeft): (WebCore::RenderObject::offsetTop):
2007-01-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- test and updated tests and results for http://bugs.webkit.org/show_bug.cgi?id=11109 REGRESSION (r15471): menus are offset on eink.com <rdar://problem/4824760>
- editing/execCommand/findString-2.html:
- editing/pasteboard/4947130.html:
- editing/pasteboard/drop-text-without-selection.html:
- editing/selection/anchor-focus1-expected.txt:
- editing/selection/click-before-and-after-table.html:
- editing/selection/drag-select-1.html:
- editing/selection/editable-links-expected.txt:
- editing/selection/mixed-editability-1.html:
- editing/selection/paragraph-granularity.html:
- editing/selection/selection-actions.html:
- editing/selection/word-granularity.html:
- fast/dom/Element/offsetLeft-offsetTop-body-quirk-expected.txt: Added.
- fast/dom/Element/offsetLeft-offsetTop-body-quirk.html: Added.
- fast/forms/drag-into-textarea.html:
- fast/forms/listbox-selection-2.html:
- fast/forms/listbox-selection.html:
- fast/table/click-near-anonymous-table-expected.txt:
- fast/table/click-near-anonymous-table.html:
- 3:35 AM Changeset in webkit [19148] by
-
- 6 edits4 adds in trunk
2007-01-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Reviewed by Darin and Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=10983 REGRESSION (r12290): Drop shadow of flickr photo note is positioned incorrectly the second time it's shown
Test: fast/dynamic/staticY.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutPositionedObjects): Avoid marking the object's parents, since they have already been laid out.
- rendering/RenderBox.cpp: (WebCore::RenderBox::setStaticY): Added a call to setChildNeedsLayout() to ensure relayout by this box's container (third and fourth cases in the layout test).
- rendering/RenderBox.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): For positioned objects with static y, also mark the object's parent to ensure that it recomputes the static y value (first case in the layout test).
2007-01-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin and Maciej.
- test for http://bugs.webkit.org/show_bug.cgi?id=10983 REGRESSION (r12290): Drop shadow of flickr photo note is positioned incorrectly the second time it's shown
Tests three cases that the patch fixes and another one that was fixed in
r8284 but did not have a test.
- fast/dynamic/staticY-expected.checksum: Added.
- fast/dynamic/staticY-expected.png: Added.
- fast/dynamic/staticY-expected.txt: Added.
- fast/dynamic/staticY.html: Added.
- 3:16 AM Changeset in webkit [19147] by
-
- 10 edits2 deletes in trunk
Get rid of FrameQtClient. It's unused since we moved over
to the loader.
- 3:14 AM Changeset in webkit [19146] by
-
- 2 edits in trunk/WebKitQt
Correctly position child frames within the
toplevel frame (put them on the viewport). r=lars
- 2:25 AM Changeset in webkit [22848] by
-
- 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog
Updated ChangeLog with Radar reference.
- 1:57 AM Changeset in webkit [19145] by
-
- 1904 edits3 deletes in trunk/LayoutTestResults
Update the test cases after the last change to
DumpRenderTree. Hope this will not be needed again.
- 1:50 AM Changeset in webkit [19144] by
-
- 2 edits in trunk/WebCore
fix the compile
- 1:44 AM Changeset in webkit [19143] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
Fixed an issue on tivofaq.com where you could never tab forward into
the left frame after tabbing out of the document.
- page/FocusController.cpp: (WebCore::FocusController::advanceFocus): Clear the focused frame before passing off focus to Chrome so that when we re-enter the document we start at the main frame instead of the last focused frame.
- 1:27 AM Changeset in webkit [22847] by
-
- 2 edits in branches/WindowsMerge/WebCore
2007-01-26 Oliver Hunt <oliver@apple.com>
Build fix -- adding SVGInlineTextBox.{cpp,h} to project
- WebCore.vcproj/WebCore.vcproj:
- 1:22 AM Changeset in webkit [19142] by
-
- 6 edits in trunk
Reviewed by Zack
WebKitQt:
Make sure we resize the HTML when resizing a
QWebFrame. Also ensure that the render tree
is up to date before dumping it.
DumpRenderTree:
Small hack to ensure that our top level frame actually has the
correct size. Unfortunately this means I'll have to regenerate
all test cases :/
- 1:20 AM Changeset in webkit [19141] by
-
- 2 edits in trunk/LayoutTestResults
Minor update, skip two test case that are hanging
forever.
- 1:03 AM Changeset in webkit [19140] by
-
- 8 edits2 adds in trunk/WebCore
Reviewed by olliej.
http://bugs.webkit.org/show_bug.cgi?id=11911
SVG exhibits double-text-selection behavior
Fix selection height of the inline text boxes for svg.
- 1:00 AM Changeset in webkit [19139] by
-
- 2 edits in trunk/WebKitQt
Display pages inside a mainwindow instead of a custom qwidget
in the qtlauncher.
- 12:54 AM Changeset in webkit [19138] by
-
- 2 edits in trunk/WebCore
Fix drawing of tiled images. r=lars
- 12:25 AM Changeset in webkit [19137] by
-
- 9 edits in trunk/WebCore
Fix image loading and implement icon class
Jan 25, 2007:
- 11:53 PM Changeset in webkit [22846] by
-
- 2 edits in branches/WindowsMerge/WebCore
2007-01-25 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej.
Fixed DragDataWin behaviour so that it will provide plain text
for a file dropped on the window.
- platform/win/DragDataWin.cpp: (WebCore::DragData::asPlainText):
- 11:32 PM Changeset in webkit [22845] by
-
- 5 edits in branches/WindowsMerge/WebKitWin
Make WebDownloads no longer start themselves
- 11:30 PM Changeset in webkit [19136] by
-
- 2 edits in trunk/JavaScriptCore
Patch from Jan Kraemer.
Reviewed by Maciej
Fix crash on architectures with 32 bit ints and
64 bit longs (For example Linux on AMD64)
- 8:25 PM Changeset in webkit [22844] by
-
- 1 edit in branches/WindowsMerge/WebCore/platform/network/cf/FormDataStreamCFNet.cpp
Fix the build for people who aren't me and aren't currently running ToT CF
- 7:18 PM Changeset in webkit [22843] by
-
- 3 edits in branches/WindowsMerge/WebCore
Prepare for upcoming CF/CFNetwork api changes
- 7:13 PM Changeset in webkit [22842] by
-
- 3 edits in branches/WindowsMerge/WebCore
WebCoreWin:
Reviewed by Adam.
Added support for slider.
- 4:51 PM Changeset in webkit [22841] by
-
- 3 edits in branches/WindowsMerge/WebKitWin
2007-01-25 Ada Chan <adachan@apple.com>
WebDownload.cpp reviewed by Brady.
WebFrame.cpp reviewed by Anders.
- WebDownload.cpp: (WebDownload::cancel): added null check
- WebFrame.cpp: (WebFrame::dispatchDecidePolicyForMIMEType): fixed bug that we treated loading image urls as downloads.
- 4:35 PM Changeset in webkit [22840] by
-
- 6 edits in branches/WindowsMerge/WebKitWin
WebKitWin:
Reviewed by Steve and Darin.
- 3:56 PM Changeset in webkit [22839] by
-
- 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION
Bump version for submit
- 3:51 PM Changeset in webkit [19135] by
-
- 4 edits in trunk/WebKit
Backed out my last patch because it crashes espn.com. Stay tuned for a newer version..
- Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setPlugin:]): Removed call to streamIsDead.
- Plugins/WebBaseNetscapePluginView.h: Removed streamIsDead.
- Plugins/WebBaseNetscapePluginView.mm: Ditto.
- 3:46 PM Changeset in webkit [19134] by
-
- 1 copy in tags/Safari-521.32.15b
New tag.
- 3:05 PM Changeset in webkit [19133] by
-
- 5 edits in trunk
LayoutTests:
Reviewed by oliver
<http://bugs.webkit.org/show_bug.cgi?id=12409>
REGRESSION (r19039): Drag caret isn't cleared after a drop
- editing/pasteboard/4947130-expected.checksum:
- editing/pasteboard/4947130-expected.png:
WebCore:
Reviewed by oliver
<http://bugs.webkit.org/show_bug.cgi?id=12409>
REGRESSION (r19039): Drag caret isn't cleared after a drop
No new layout tests because the regression was
caught by current layout tests.
- page/DragController.cpp: (WebCore::DragController::concludeDrag): Clear the drag caret.
- 3:01 PM Changeset in webkit [22838] by
-
- 2 edits in branches/WindowsMerge/WebCore
2007-01-25 Steve Falkenburg <sfalken@apple.com>
B&I build fix
- WebCore.vcproj/WebCore.vcproj:
- 2:46 PM Changeset in webkit [19132] by
-
- 3 edits in trunk/WebKit
Reviewed by Beth.
- fix <rdar://problem/4952766> Safari has a top secret color picker that can be used to... uhh... I don't know
- Panels/English.lproj/WebAuthenticationPanel.nib/info.nib: Let Interface Builder have its way.
- Panels/English.lproj/WebAuthenticationPanel.nib/objects.nib: Remove the NSColorWell that was in here (for no good reason).
- 1:30 PM Changeset in webkit [19131] by
-
- 4 edits in trunk/WebKit
Reviewed by andersca.
A few tweaks with of a fix done by Steve Gehrman.
Fixed: <rdar://problem/4946922> WebBaseNetscapePluginView leaks memory
- Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setPlugin:]): Calls -[WebBaseNetscapePluginView streamIsDead:]
- Plugins/WebBaseNetscapePluginView.h: Added streamIsDead to header.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView streamIsDead:]): Added. Removes the stream from the streams collection.
- 12:21 PM Changeset in webkit [19130] by
-
- 4 edits4 adds in trunk
LayoutTests:
Reviewed by Geoffrey Garen.
Added tests for http://bugs.webkit.org/show_bug.cgi?id=12342
REGRESSION: destroying a frame from its own script causes various crashes
Thanks to Alexey Proskuryakov for the original versions of these tests.
- fast/dom/exception-no-frame-inline-script-crash-expected.txt: Added.
- fast/dom/exception-no-frame-inline-script-crash.html: Added.
- fast/dom/exception-no-frame-timeout-crash-expected.txt: Added.
- fast/dom/exception-no-frame-timeout-crash.html: Added.
WebCore:
Reviewed and landed by Geoffrey Garen.
- fix http://bugs.webkit.org/show_bug.cgi?id=12342 REGRESSION: destroying a frame from its own script causes various crashes
- bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute): Use RefPtr for the frame and the interpreter object so they don't get deleted out from underneath us.
- bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate): Add a check for a page of 0. This was the only call site for the addMessageToConsole function that did not have a check for a page of 0.
- 11:52 AM Changeset in webkit [19129] by
-
- 2 edits94 adds in trunk/LayoutTestResults
Add the next 100 test cases.
- 11:27 AM Changeset in webkit [19128] by
-
- 2 edits300 adds in trunk/LayoutTestResults
Add more test cases that pass on the Qt build.
- 10:42 AM Changeset in webkit [19127] by
-
- 2 edits157 adds in trunk/LayoutTestResults
The tests in dom/svg and dom/xhtml as well as
most of the remaining tests in tables/ pass now as
well, so lets run the test suite over them.
- 10:13 AM Changeset in webkit [19126] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed and merged by Beth.
Fix for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)
This is equivalent to commit 626791 in the KDE tree. Basically, the
patch allows comment parsing in titles to avoid capturing a
<script> tag by accident.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment):
LayoutTests:
Test for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)
- fast/parser/parseCommentsInTitles-expected.checksum: Added.
- fast/parser/parseCommentsInTitles-expected.png: Added.
- fast/parser/parseCommentsInTitles-expected.txt: Added.
- fast/parser/parseCommentsInTitles.html: Added.
- 10:12 AM Changeset in webkit [19125] by
-
- 2 edits in S60/trunk/WebCore
bujtas <zbujtas@gmail.com>
Reviewed by Sachin.
DESC: ISHG-6S8Q5X fix list marker offset problem.
markers get off when the marker image, specified in CSS, is 404.
fix: issue relayout, when the errorImage is set on the marker.
- 10:12 AM Changeset in webkit [19124] by
-
- 2 edits in S60/branches/3.1m/WebCore
bujtas <zbujtas@gmail.com>
Reviewed by Sachin.
DESC: ISHG-6S8Q5X fix list marker offset problem.
markers get off when the marker image, specified in CSS, is 404.
fix: issue relayout, when the errorImage is set on the marker.
- 9:41 AM Changeset in webkit [22837] by
-
- 6 edits in branches/WindowsMerge/WebKitWin
Reviewed by Anders.
Part of <rdar://problem/4855618> HTML-based load failure pages.
- Interfaces/IWebError.idl: Added failingURL method declaration.
- WebError.cpp: (WebError::failingURL): Implemented.
- WebError.h: Updated for interface changes.
- WebFrame.cpp: (WebFrame::loadHTMLString): New protected helper method called by IWebFrame::loadHTMLString and IWebFrame::loadAlternateHTMLString. (WebFrame::loadAlternateHTMLString): Calls loadHTMLString.
- WebFrame.h: Added new declaration.
- 8:09 AM Changeset in webkit [19123] by
-
- 2 edits in S60/branches/3.1m/WebKit
spadma
Reviewed by Zalan.
DESC: ResolveEmbedded link not called for plugins (ASAA-6X5DX8)
http://bugzilla.opendarwin.org/show_bug.cgi?id=12400
- BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPluginL):
- 7:39 AM Changeset in webkit [19122] by
-
- 2 edits in trunk/WebCore
- ksvg2/svg/SVGPreserveAspectRatio.cpp: Add a couple of comments.
- 7:33 AM Changeset in webkit [19121] by
-
- 3 edits3 adds in trunk
LayoutTests:
Reviewed by Maciej.
- test for bugs found by code inspection in the SVGPreserveAspectRatio parser
- svg/dom/preserve-aspect-ratio-parser-expected.txt: Added.
- svg/dom/preserve-aspect-ratio-parser.html: Added.
WebCore:
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=12365 Reproducible crash in WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio in svg/W3C-SVG-1.1/animate-elem-40-t.svg under guard malloc
- fix bug where the parser accepts "meet" or "slice" as an entire string
- fix bug where "slice" is ignored if the old alignment was "none" even if the newly-parsed alignment is something other than "none", and "slice" is not ignored if the old alignment was not "none", but the newly-parsed alignment is "none"
- optimize to only call notifyAttributeChange if the attribute actually changed
Test: svg/dom/preserve-aspect-ratio-parser-test.html
- ksvg2/svg/SVGPreserveAspectRatio.cpp: (WebCore::checkString): Added an overload for using char* constants which is much simpler than the old one, and almost as fast. (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): Fail if there's no more text after "defer". Fail if there's neither "none" nor an x/y specified. Check that there's more text before looking at the "m" and "s" for "meet" and "slice". Merged the failure and success cases. Only call notifyAttributeChange if something changed.
I think all the "optimized" code where we check the first character before
calling checkString isn't really helpful, but I decided to leave it as-is
for now.
- 6:54 AM Changeset in webkit [19120] by
-
- 3 edits in trunk/WebCore
Reviewed by Zack
Trivial implementation of getMIMETypeForExtension.
Use the above method in the ResourceHandleManager to set
a mimetype on Resources that don't have one set (which
includes everything loaded from local disk).
Should fix quite a few test cases :)
- 6:20 AM Changeset in webkit [19119] by
-
- 3 edits in trunk/WebKit
Reviewed by Kevin, Geoff, Brady, and Darin
- fixed <rdar://problem/4918446> Safari's temp files (PDF's) should be in a sub-folder when calling Preview
- WebView/WebPDFView.mm: (-[WebPDFView _path]): use _temporaryPDFDirectoryPath method instead of #defines for hardwiring strings; stop bad practice of modifying the const char* returned by fileSystemRepresentation (-[WebPDFView _temporaryPDFDirectoryPath]): new method, lazily creates and returns a secure temporary directory created with NSTemporaryDirectory() and mkdtemp
- English.lproj/StringsNotToBeLocalized.txt: Updated for these and other recent changes
- 6:03 AM Changeset in webkit [19118] by
-
- 2 edits808 adds in trunk/LayoutTestResults
Add more test results for the Qt build.
- 5:06 AM Changeset in webkit [19117] by
-
- 2 edits in trunk/WebCore
Path from Harald Fernengel to fix compile on platforms
where qreal is not a double.
r=me
- 4:48 AM Changeset in webkit [19116] by
-
- 7 edits1 add in trunk/WebCore
implement wheel event handling and use eventhandler explictly.
r=lars
- 3:07 AM BuildingOnWindows edited by
- (diff)
- 2:54 AM Changeset in webkit [19115] by
-
- 3 edits4 adds in trunk
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=12391
SVG containers with viewports should respect overflow when hit testing
Take into account the overflow property when hit testing <svg>.
- 2:04 AM Changeset in webkit [19114] by
-
- 2 edits in trunk/WebKitQt
Reviewed by Zack
Emit the loadDone() signal from teh onload event callback
again. This hangs on one or two test cases, but removes
hundreds of failures elsewhere.
- 2:04 AM Changeset in webkit [19113] by
-
- 2 edits in trunk/LayoutTestResults
remove dom/html/level2/html from skipped tests.
- 12:56 AM Changeset in webkit [19112] by
-
- 611 adds in trunk/LayoutTestResults
Add css1 and css2.1 test results for the Qt build
- 12:54 AM Changeset in webkit [19111] by
-
- 4 edits1 delete in trunk/WebKitTools
Reviewed by Darin and Zack
Move the test results for Qt into a directory of it's own
(WebKit/LayoutTestResults/qt). Leave the Mac results where
they are for now and share the text only results between
Mac and Qt.
Add support for a LayoutTestResults/platform/Skipped file
to run-webkit-tests to be able to ignore certain tests
Remove the old tests-skipped.txt from Qts DumpRenderTree
implementation.
- 12:47 AM Changeset in webkit [22836] by
-
- 3 edits in branches/WindowsMerge/WebKitWin
2007-01-25 Ada Chan <adachan@apple.com>
WebKitWin:
Reviewed by Maciej.
Added init methods instead of doing all the initialization in the constructor.
There was a lifetime issue with passing the WebDownload to delegate calls when
its ref count is still 0.
- WebDownload.cpp: (WebDownload::init): (WebDownload::createInstance):
- WebDownload.h:
- 12:38 AM Changeset in webkit [19110] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Maciej.
added test for
<rdar://problem/4808039> REGRESSION: eBay ID check never completes
also known as
http://bugs.webkit.org/show_bug.cgi?id=11230
- http/tests/misc/location-replace-crossdomain-expected.txt: Added.
- http/tests/misc/location-replace-crossdomain.html: Added.
- http/tests/misc/resources/failure.html: Added.
- http/tests/misc/resources/success.html: Added.
WebCore:
Reviewed by Maciej.
fixed <rdar://problem/4808039> REGRESSION: eBay ID check never completes
Also known as http://bugs.webkit.org/show_bug.cgi?id=11230
- bindings/js/kjs_window.cpp: It's not necessary to check safeScript when doing a location.replace, .reload, or .assign (KJS::Location::getOwnPropertySlot): (KJS::LocationFunc::callAsFunction):
- 12:34 AM Changeset in webkit [19109] by
-
- 4 edits2 adds in trunk
LayoutTests:
Reviewed by Geoff and Adele
added test for <rdar://problem/4866655> REGRESSION: Copying out of Calculator & CIFIlterWidget is broken on 9A320
- editing/execCommand/copy-without-selection-expected.txt: Added.
- editing/execCommand/copy-without-selection.html: Added.
WebCore:
Reviewed by Geoff and Adele.
fixed <rdar://problem/4866655> REGRESSION: Copying out of Calculator & CIFIlterWidget is broken on 9A320
- editing/Editor.cpp: (WebCore::Editor::canDHTMLCut): (WebCore::Editor::canDHTMLCopy): (WebCore::Editor::tryDHTMLCopy): (WebCore::Editor::tryDHTMLCut): Reverting some mistakes made in r17504: Anything in r17503 that used to call mayDHTML* still calls canDHTML* as it was changed in r17504, where canDHTML* now calls !selectionController::isInPasswordField instead of editor::canCopy Anything else in r17503 that used to call mayCopy now calls (!)selectionController::isInPasswordField.
- editing/JSEditor.cpp: copy via JS should be enabled as long as selection is not in a password field. a range selection shouldn't be required.
