Timeline



Feb 4, 2007:

10:59 PM Changeset in webkit [22900] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-02-04 Ada Chan <​adachan@apple.com>

Reviewed by Steve.

WebKitWin:

<rdar://4946475> Private browsing is not working correctly
Implemented FrameLoaderClient::privateBrowsingEnabled().

  • WebFrame.cpp: (WebFrame::privateBrowsingEnabled):


10:06 PM Changeset in webkit [19399] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12602
XPath functions string(), normalize-space() and string-length() don't work
without arguments

Test: fast/xpath/implicit-node-args.html

  • xml/XPathFunctions.cpp: (WebCore::XPath::FunString::doEvaluate): (WebCore::XPath::FunStringLength::doEvaluate): (WebCore::XPath::FunNormalizeSpace::doEvaluate): Don't try to pass RefPtr<Node> to the Value ctor.
9:56 PM Changeset in webkit [19398] by ap
  • 11 edits
    14 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=8791
XPath should support custom node resolvers

WebCore:

  • bindings/js/JSCustomXPathNSResolver.cpp: Added. (WebCore::JSCustomXPathNSResolver::create): (WebCore::JSCustomXPathNSResolver::JSCustomXPathNSResolver): (WebCore::JSCustomXPathNSResolver::~JSCustomXPathNSResolver): (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  • bindings/js/JSCustomXPathNSResolver.h: Added.
  • bindings/objc/DOMCustomXPathNSResolver.h: Added.
  • bindings/objc/DOMCustomXPathNSResolver.mm: Added. (WebCore::DOMCustomXPathNSResolver::DOMCustomXPathNSResolver): (WebCore::DOMCustomXPathNSResolver::~DOMCustomXPathNSResolver): (WebCore::DOMCustomXPathNSResolver::lookupNamespaceURI): Wrappers for JS/ObjC objects that can be used as resolvers.
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm: Use the above wrappers to support custom resolvers.
  • xml/XPathNSResolver.cpp:
  • xml/XPathNSResolver.h: Turned this class into an abstract one.
  • xml/NativeXPathNSResolver.cpp: Added. (WebCore::NativeXPathNSResolver::NativeXPathNSResolver): (WebCore::NativeXPathNSResolver::~NativeXPathNSResolver): (WebCore::NativeXPathNSResolver::lookupNamespaceURI):
  • xml/NativeXPathNSResolver.h: Added. A XPathNSResolver subclass, doing what XPathNSResolver used to do.
  • xml/XPathEvaluator.cpp: (WebCore::XPathEvaluator::createNSResolver): Create a NativeXPathNSResolver.
  • WebCore.xcodeproj/project.pbxproj: Added new files.

LayoutTests:

  • fast/xpath/nsresolver-bad-object-expected.txt: Added.
  • fast/xpath/nsresolver-bad-object.xhtml: Added.
  • fast/xpath/nsresolver-exception-expected.txt: Added.
  • fast/xpath/nsresolver-exception.xhtml: Added.
  • fast/xpath/nsresolver-function-expected.txt: Added.
  • fast/xpath/nsresolver-function.xhtml: Added.
  • fast/xpath/nsresolver-object-expected.txt: Added.
  • fast/xpath/nsresolver-object.xhtml: Added.
9:55 PM Changeset in webkit [22899] by aliceli1
  • 4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Fix some memory leaks. This fixes WebFrame leak as well.
Can be considered a partial fix for <rdar://4974495> Boomer leaks while running HTML iBench

  • WebActionPropertyBag.cpp: (WebActionPropertyBag::WebActionPropertyBag):
  • WebDataSource.cpp: (WebDataSource::representation):
  • WebURLResponse.cpp: (:m_refCount):
7:52 PM Changeset in webkit [22898] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Fix <rdar://problem/4972498> REGRESSION: Crash while closing View Source window

  • WebView.cpp: (WebView::WebView): Initialize new member. (WebViewWndProc): Set flag when we receive WM_DESTROY, and don't handle WM_SIZE if that flag is true. (WebView::mainFrame): Added argument check.
  • WebView.h: (WebView::setIsBeingDestroyed): Added. (WebView::isBeingDestroyed): Added.
6:54 PM Changeset in webkit [19397] by weinig
  • 19 edits in trunk/LayoutTests

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12562
Fix test cases that are now spewing console errors that
they are not testing for

  • fast/events/iframe-object-onload-expected.txt:
  • fast/events/iframe-object-onload.html: Change nil to null.
  • fast/forms/display-none-in-onchange-keyboard-expected.txt:
  • fast/forms/display-none-in-onchange-keyboard.html: Add missing id to div, change its text, and change the resulting text.
  • fast/forms/input-text-click-inside-expected.checksum:
  • fast/forms/input-text-click-inside-expected.png:
  • fast/forms/input-text-click-inside-expected.txt:
  • fast/forms/input-text-click-inside.html: Change moveTo(x,y) to mouseMoveTo(x,y).
  • fast/forms/input-text-click-outside-expected.txt:
  • fast/forms/input-text-click-outside.html: Ditto.
  • fast/js/array-foreach-expected.txt:
  • fast/js/array-foreach.html: Add try-catch blocks to catch exceptions and print them and general cleanup.
  • fast/js/array-some-expected.txt:
  • fast/js/array-some.html: Ditto.
  • fast/table/click-near-anonymous-table-expected.checksum:
  • fast/table/click-near-anonymous-table-expected.png:
  • fast/table/click-near-anonymous-table-expected.txt:
  • fast/table/click-near-anonymous-table.html: Change timeForward(ms) to leapForward(ms) and change the amount of time from 500ms to 1000ms to avoid clicking.
6:38 PM Changeset in webkit [22897] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-02-04 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Removed unimplemented EventHandler::handleMouseUp,
as a platform independent version is available now.

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::eventActivatedView): Now we use this method, it needs to be implemented
6:37 PM Changeset in webkit [19396] by oliver
  • 6 edits in trunk/WebCore

2007-02-04 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Tidying up EventHandler, and moving more of
EventHandlerMac.mm to EventHandler.cpp

Also added EventHandler::eventLoopHandleMouse[Dragged,Up]
these are basically helper functions to allow correct event
handling on MacOS.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseUp): (WebCore::EventHandler::dragSourceMovedTo): (WebCore::EventHandler::dragSourceEndedAt): (WebCore::EventHandler::dispatchDragSrcEvent):

Moved from EventHandlerMac to EventHandler

  • page/EventHandler.h: (WebCore::EventHandler::eventLoopHandleMouseUp): (WebCore::EventHandler::eventLoopHandleMouseDragged): Null implementations of two Mac helper functions
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::eventLoopHandleMouseDragged): (WebCore::EventHandler::handleDrag): Much tidying, reduced nesting, made less dependent on NS types (WebCore::EventHandler::eventLoopHandleMouseDragged): (WebCore::EventHandler::eventLoopHandleMouseUp): Helper functions to let us process events properly on MacOS
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
5:08 PM Changeset in webkit [22896] by aroben
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Hyatt.

Fix <rdar://problem/4968183> Cross-window frame targeting doesn't work

  • Interfaces/IWebView.idl: Pass RECT by value.
  • WebView.cpp: (WebView::initWithFrame): Uses the passed-in RECT for the frame, and sets the frame/group names.
  • WebView.h: Updated declaration.
6:15 AM Changeset in webkit [19395] by staikos
  • 3 edits in trunk/WebCore

Various Qt related hacks and cleanups to make forms work better

Feb 3, 2007:

11:56 PM Changeset in webkit [19394] by mjs
  • 1 edit
    1 delete in trunk/WebCore

Rubber stamped by Adam.

  • remove obsolete code that has an annoying space in the directory name
  • WebCore.vcproj/Image Viewer.cpp: Removed.
  • WebCore.vcproj/Image Viewer.h: Removed.
  • WebCore.vcproj/Image Viewer.ico: Removed.
  • WebCore.vcproj/Image Viewer.rc: Removed.
  • WebCore.vcproj/Image Viewer.reg: Removed.
  • WebCore.vcproj/Image Viewer.vcproj: Removed.
  • WebCore.vcproj/Image Viewer/ImageDocument.cpp: Removed.
  • WebCore.vcproj/Image Viewer/ImageDocument.h: Removed.
  • WebCore.vcproj/Image Viewer/ImageMainFrame.cpp: Removed.
  • WebCore.vcproj/Image Viewer/ImageMainFrame.h: Removed.
  • WebCore.vcproj/Image Viewer/ImageView.cpp: Removed.
  • WebCore.vcproj/Image Viewer/ImageView.h: Removed.
  • WebCore.vcproj/Image Viewer/Resource.h: Removed.
  • WebCore.vcproj/Image Viewer/res/ImageViewer.rc2: Removed.
  • WebCore.vcproj/Image Viewer/res/Toolbar.bmp: Removed.
  • WebCore.vcproj/Image Viewer/stdafx.cpp: Removed.
  • WebCore.vcproj/Image Viewer/stdafx.h: Removed.
  • WebCore.vcproj/Image iewerDoc.ico: Removed.
11:37 PM Changeset in webkit [19393] by staikos
  • 2 edits in trunk/JavaScriptCore

fix crash on JS that ends with an identifier

11:34 PM Changeset in webkit [19392] by oliver
  • 2 edits in trunk/WebCore

2007-02-04 Mitz Pettel <​mitz@webkit.org>

Reviewed by Oliver.

  • platform/mac/PlatformMouseEventMac.mm: (WebCore::eventNumberForEvent): Scroll wheel events don't have an event number.
10:50 PM Changeset in webkit [22895] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-02-03 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.


<rdar://problem/4930947> Regression: History is not saved when boomer window is closed.


Fix boolean test causing lost history regression.

  • WebHistoryItem.cpp: (WebHistoryItem::hasURLString): isEmpty returns true if there is NO url, not if there is one.
6:07 PM Changeset in webkit [19391] by ggaren
  • 1 edit
    1 add in trunk/LayoutTests

Landing results that I think Maciej intended to land, to get the buildbot
back to green.

  • fast/forms/disabled-select-change-index-expected.txt: Added.
5:25 PM Changeset in webkit [19390] by zimmermann
  • 12 edits
    4 adds in trunk

Reviewed by Sam.

Add support for xml:space="preserve" for SVG text.
It can be modeled by using white-space="pre" and replace \n by spaces.

Handle xml:space="default" correctly.
Always remove tabs from SVG text - as demanded by spec.

Added test: svg/custom/text-whitespace-handling.svg

12:35 PM Changeset in webkit [19389] by ap
  • 5 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12560
W3C XPath test Text_Nodes.svg fails

Covered by dom/svg/level3/xpath/Text_Nodes.svg

  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodeTestMatches): Only include the first text sibling in text() matches.
12:22 PM Changeset in webkit [19388] by ap
  • 4 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12485
XPath id() function doesn't work as root in paths

Test: fast/xpath/id-path.html

  • xml/XPathPath.cpp: (WebCore::XPath::Path::doEvaluate): Implemented. (WebCore::XPath::LocationPath::evaluate): A new overload that takes an initial NodeVector. (WebCore::XPath::LocationPath::doEvaluate): Moved most of the logic to the new evaluate().
  • xml/XPathPath.h: Added a new evaluate() overload and a using declaration to keep the generic one visible.
12:14 PM Changeset in webkit [19387] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12559
REGRESSION: Crash in checkForHeadCharset() under GuardMalloc

No tests possible.

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Fix end of buffer checks; sprinkle a number of new ones over the function.
7:00 AM Changeset in webkit [19386] by weinig
  • 2 edits in trunk/WebKitTools

Reviewed by Mark.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12555
Drosera doesn't handle CR ( carriage returns ) well

  • Normalize all the line endings.
  • Drosera/debugger.js:
4:16 AM Changeset in webkit [19385] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by NOBODY (no-svg build fix).

  • page/EventHandler.cpp: Include FloatPoint.h.
2:53 AM Changeset in webkit [19384] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=12549
Wrong character encoding at www.ravmilim.co.il

Test: fast/encoding/meta-charset.html

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Fix an off by one error.

Feb 2, 2007:

9:54 PM Changeset in webkit [19383] by mjs
  • 3 edits
    1 add in trunk

LayoutTests:

Reviewed by Hyatt & Adele.

  • test case for <rdar://problem/4896972> TV guide listings page doesn't finish loading (11674)
  • fast/forms/disabled-select-change-index.html: Added.

WebCore:

Reviewed by Hyatt & Adele.


  • <rdar://problem/4896972> TV guide listings page doesn't finish loading (11674)


Test case: fast/forms/disabled-select-change-index.html


  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setSelected): Allow changing selected state of a disabled option.
8:16 PM Changeset in webkit [19382] by bdash
  • 3 edits in tags/Safari-521.34

Versioning.

8:11 PM Changeset in webkit [22894] by aliceli1
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Maciej.

Fixed <rdar://4956286> Find: Deleting all text in the Find banner search field should clear the page's selection

  • Interfaces/IWebView.idl:
  • WebView.cpp: (WebView::clearSelection):
  • WebView.h:

Added a clearSelection function to webview so the findbanner can call it.

8:09 PM Changeset in webkit [19381] by bdash
  • 21 edits in tags/Safari-521.34

Roll out r19327.

7:58 PM Changeset in webkit [19380] by bdash
  • 1 copy in tags/Safari-521.34

New tag.

5:36 PM Changeset in webkit [19379] by zimmermann
  • 2 edits in trunk/WebCore

Build fix, not reviewed.
Blind attempt to fix Qt build.

5:33 PM Changeset in webkit [19378] by zimmermann
  • 14 edits
    16 adds in trunk

Reviewed by Eric & Maciej.

Fix serveral <use> issues:

  • When events are dispatch to a referenced element, the actual event.target

has to be set to the corresponding SVGElementInstance object

  • Node::shadowAncestorNode() should _not_ return the shadowParentNode for SVG elements

This is only needed for the HTML forms concept and breaks event dispatching for SVG shadow tree elements.

  • Add SVGElementInstance as possible EventTarget in bindings/js/kjs_dom.cpp

(Now event.target returns the actual SVGElementInstance object for a shadow tree element)

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12502 (Reproducible crash when browsing SVG map.)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12511 (<use> has event dispatching issues)

Added test: svg/custom/use-event-handler-on-use-element.svg
Added test: svg/custom/use-event-handler-on-referenced-element.svg
Added test: svg/custom/use-elementInstance-event-target.svg
Added test: svg/custom/use-elementInstance-methods.svg

5:06 PM Changeset in webkit [19377] by ggaren
  • 3 edits in trunk/WebKitTools

Reviewed by Darin Adler.

Added some more known leaks to the leaks ignore list.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Why does XCode hate itself so much?
  • Scripts/run-webkit-tests:
4:30 PM Changeset in webkit [22893] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Anders.

Fix a crash when running the PLT.

  • WebView.cpp: (WebView::initWithFrame):

Added assertions to make catching this easier.

4:25 PM Changeset in webkit [19376] by oliver
  • 2 edits in trunk/WebCore

2007-02-02 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoff.

Add guard around accessing [NSEvent eventNumber] to ensure
we don't attempt to access it on on non-mouse related NSEvent.

  • platform/mac/PlatformMouseEventMac.mm: (WebCore::eventNumberForEvent): (WebCore::PlatformMouseEvent::PlatformMouseEvent):
3:53 PM Changeset in webkit [19375] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Anders.

Try to be a little less selfish about DocumentLoader.

Spotted while working on <rdar://problem/4957747>.

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):

Everyone can open frames in new windows.

3:45 PM Changeset in webkit [19374] by zimmermann
  • 9 edits in trunk/WebCore

Reviewed by Eric.

Move xml:space/xml:lang from svgattrs.in to xmlattrs.in where they actually belong.
Now they are actually recognized by SVGLangSpace::parseMappedAttribute.
Patch implementing xml:space="preserve" coming soon, which acts as test for this stuff.

Always build XMLNames.cpp (not only for SVG) and replace all occourences of
"​http://www.w3.org/XML/1998/namespace" by "XMLNames::xmlNamespaceURI".

3:03 PM Changeset in webkit [19373] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Working on a layout test.

Fix for <rdar://problem/4966100> REGRESSION: Reproducible ASSERT
hit at Walgreens.com

  • page/Frame.cpp: (WebCore::Frame::setView): If we are setting the view to 0 and detaching the document, call unscheduleRealyout() on the old view before setting it to 0.
12:42 PM Changeset in webkit [19372] by brmorris
  • 26 edits in S60/branches/3.1m

yongjzha, Reviewed by zalan.

DESC: backport google.com/ig refreshing memory leak fix in <​http://bugs.webkit.org/show_bug.cgi?id=10773> PPEN-6QYG7L
improve stability under low memory condition.
​http://bugs.webkit.org/show_bug.cgi?id=12541

11:57 AM Changeset in webkit [19371] by ggaren
  • 1 edit in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.m

add const back, too

11:56 AM Changeset in webkit [19370] by ggaren
  • 2 edits in trunk/WebKitTools

Even better build fix than the last.

  • ChangeLog:
  • DumpRenderTree/DumpRenderTree.m: (shouldIgnoreWebCoreNodeLeaks):
11:50 AM Changeset in webkit [19369] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

bujtas, Reviewed by yongjun.

Merge of r19368 to 3.1 by Brad.
DESC: browser crashes on www.tays.fi. when multiple layers are referring to the same background image, the render_object does not do proper deref on the image. MLIO-6XJAXG
fix: loop through the background layers and defer background images
​http://bugs.webkit.org/show_bug.cgi?id=12543

11:47 AM Changeset in webkit [19368] by brmorris
  • 2 edits in S60/trunk/WebCore

bujtas, Reviewed by yongjun.

DESC: browser crashes on www.tays.fi. when multiple layers are referring to the same background image, the render_object does not do proper deref on the image.
fix: loop through the background layers and defer background images
​http://bugs.webkit.org/show_bug.cgi?id=12543

10:57 AM Changeset in webkit [19367] by ggaren
  • 2 edits in trunk/WebKitTools

Fixed build. Added work-around for GCC bug.

  • DumpRenderTree/DumpRenderTree.m: (shouldIgnoreWebCoreNodeLeaks):
10:48 AM Changeset in webkit [22892] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-02-02 Steve Falkenburg <​sfalken@apple.com>

Fix build.

  • WebCore.vcproj/WebCore.vcproj:
10:36 AM Changeset in webkit [19366] by ggaren
  • 1 edit in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.m

build fix? i don't think so, but let's see...

10:04 AM Changeset in webkit [22891] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore
9:57 AM Changeset in webkit [19365] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • fix copying and assigning a ListHashSet

No test because the code path with bugs I am fixing is not used yet.

  • wtf/ListHashSet.h: Tweaked ListHashSetNodeAllocator a little bit for clarity. Changed m_allocator to be an OwnPtr instead of doing an explicit delete. Fixed bug in copy constructor where we'd have an uninitialized m_allocator. Fixed bug in assignment operator where it would swap only the hash table, and not the head, tail, and allocator pointers.
9:55 AM Changeset in webkit [19364] by ggaren
  • 12 edits in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.


Use WTFLog instead of fprintf for logging KJS::Node leaks.

  • kjs/nodes.cpp: (NodeCounter::~NodeCounter): Changed count to unsigned, updated to match style guidelines.

WebCore:

Reviewed by Maciej Stachowiak.


Added support for selectively ignoring WebCore::Node leaks during layout
tests, so that we can ignore known leaks in other components.

  • WebCore.exp:
  • dom/Node.cpp: (WebCore::Node::isSupported): Moved isSupported up with the rest of the static functions.

(WebCore::): Added an ignoreSet, which collects WebCore::Nodes whose lifetime
we want to ignore. We need to track which nodes to ignore rather than, say,
just suspending the count, because node destruction depends on lots of
different variables, so it would be nearly impossible to know when exactly
to suspend the count and when exactly to resume it.

(WebCore::NodeCounter::~NodeCounter): Changed to use WTFLog instead of fprintf.

(WebCore::Node::startIgnoringLeaks): Do the ignoring.
(WebCore::Node::stopIgnoringLeaks): ditto
(WebCore::Node::Node): ditto
(WebCore::Node::~Node): ditto

  • dom/Node.h: Moved isSupported up with the rest of the static functions.
  • platform/mac/LoggingMac.mm: (WebCore::initializeWithUserDefault): Renamed from "initializeLoggingChannel" because the real goal here is to honor a user default -- WTFLoggingChannels need no run-time initialization. Also replaced "off by default, on if a user default says so" behavior with "only override existing setting if a user default says so" behavior. It seemed like a bug that you would specify a channel's on/off state in its definition, but this function would unconditionally blow that state away. (WebCore::InitializeLoggingChannelsIfNecessary):

WebKit:

Reviewed by Maciej Stachowiak.


Added support for selectively ignoring WebCore::Node leaks during layout
tests, so that we can ignore known leaks in other components.

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics startIgnoringWebCoreNodeLeaks]): (+[WebCoreStatistics stopIgnoringWebCoreNodeLeaks]):

WebKitTools:

Reviewed by Maciej Stachowiak.


Added support for selectively ignoring WebCore::Node leaks during layout
tests, so that we can ignore known leaks in other components.

  • DumpRenderTree/DumpRenderTree.m: (shouldIgnoreWebCoreNodeLeaks): Implements a black list of tests whose WebCore::Node leaks we have to ignore. Does this CFString gobbledy-gook confuse anyone else? (runTest):
8:47 AM Changeset in webkit [19363] by brmorris
  • 2 edits in S60/trunk/WebKit

yaharon, Reviewed by Yongjun.

DESC: [S60] FUTE_32: If web page included a link, which name is e.g. T0000900 user can't open it, cause phone starts calling to number 0000900. (KDIS-6XYCL5)
​http://bugs.webkit.org/show_bug.cgi?id=12534

8:28 AM Changeset in webkit [19362] by eseidel
  • 190 edits
    8 adds in trunk

2007-02-02 Eric Seidel <​eric@webkit.org>

Reviewed by mitz.

Fix gradient stop style resolution to be less of a hack, fixing style invalidation:
​http://bugs.webkit.org/show_bug.cgi?id=12193
and fix stop-color and stop-opacity not to inherit:
​http://bugs.webkit.org/show_bug.cgi?id=12193


Tests:

  • svg/custom/gradient-stops-style-change.svg: added
  • svg/W3C-SVG-1.1/pservers-grad-18-b.svg: updated
  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • ksvg2/css/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::inheritedNotEqual): (WebCore::SVGRenderStyle::inheritFrom):
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/svg/SVGDefsElement.cpp: (WebCore::SVGDefsElement::createRenderer):
  • ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::createRenderer): (WebCore::SVGGradientElement::buildStops):
  • ksvg2/svg/SVGGradientElement.h: (WebCore::SVGGradientElement::rendererIsNeeded):
  • ksvg2/svg/SVGStopElement.cpp: (WebCore::SVGStopElement::createRenderer):
  • ksvg2/svg/SVGStopElement.h: (WebCore::SVGStopElement::rendererIsNeeded):
  • rendering/RenderSVGGradientStop.cpp: Added.
  • rendering/RenderSVGGradientStop.h: Added.
  • rendering/RenderSVGHiddenContainer.cpp: Added.
  • rendering/RenderSVGHiddenContainer.h: Added.
  • rendering/RenderSVGContainer.cpp:
  • rendering/RenderSVGContainer.h:
6:41 AM Changeset in webkit [19361] by zack
  • 2 edits in trunk/WebCore

Fix scrolling-on-selection bug by correctly
scrolling to the offset instead of trying to
ensure visibility with margins
r=Lars

6:09 AM Changeset in webkit [19360] by bdash
  • 3 edits in tags/Safari-419.1

Versioning.

6:07 AM Changeset in webkit [19359] by bdash
  • 1 copy in tags/Safari-419.1

New tag.

6:06 AM Changeset in webkit [19358] by bdash
  • 6 edits in branches/Safari-2-0-branch

Update bundle identifiers.

4:27 AM Changeset in webkit [22890] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Turn on Lucida Grande.

3:06 AM Changeset in webkit [22889] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Maciej.

Implemented menulist drawing.

2:26 AM Changeset in webkit [19357] by zack
  • 1 edit in trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

actually set the pen on color setting

2:24 AM Changeset in webkit [19356] by zack
  • 2 edits in trunk/WebCore

Fix drawing of dashed and colored lines. Pen
has to be inherited for stroke to stay consistent.
r=Lars

1:49 AM Changeset in webkit [19355] by zack
  • 2 edits in trunk/WebKitQt

Compilation fix: forward declare d-ptr.

1:35 AM Changeset in webkit [19354] by mjs
  • 2 edits in trunk/JavaScriptCore
  • not reviewed, build fix
  • wtf/ListHashSet.h: (WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator): ummm, use union correctly
1:14 AM Changeset in webkit [19353] by mjs
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Reviewed by Darin.


  • use a custom allocator for ListHashSet, to fix ~1% perf regression using it for form control
  • wtf/ListHashSet.h: (WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator): (WTF::ListHashSetNodeAllocator::allocate): (WTF::ListHashSetNodeAllocator::deallocate): (WTF::ListHashSetNode::operator new): (WTF::ListHashSetNode::operator delete): (WTF::ListHashSetNode::destroy): (WTF::ListHashSetTranslator::translate): (WTF::::ListHashSet): (WTF::::~ListHashSet): (WTF::::add): (WTF::::unlinkAndDelete): (WTF::::deleteAllNodes):
1:09 AM Changeset in webkit [19352] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • use a custom allocator for ListHashSet, to fix ~1% per regression using it for form control
  • wtf/ListHashSet.h: (WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator): (WTF::ListHashSetNodeAllocator::allocate): (WTF::ListHashSetNodeAllocator::deallocate): (WTF::ListHashSetNode::operator new): (WTF::ListHashSetNode::operator delete): (WTF::ListHashSetNode::destroy): (WTF::ListHashSetTranslator::translate): (WTF::::ListHashSet): (WTF::::~ListHashSet): (WTF::::add): (WTF::::unlinkAndDelete): (WTF::::deleteAllNodes):
12:41 AM Changeset in webkit [19351] by zack
  • 3 edits in trunk/WebKitQt

Make the frames white by default and get the
files that WebCore can handle render inside
the frames.
r=Lars

Feb 1, 2007:

11:43 PM Changeset in webkit [19350] by bdash
  • 13 edits
    4 adds in trunk

2007-02-01 Nicholas Shanks <​webkit@nickshanks.com>

Reviewed by Mark.

Add support for CSS2 font-stretch property.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty):
  • platform/FontCache.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): (WebCore::FontPlatformDataCacheKey::operator==): (WebCore::computeHash): (WebCore::FontPlatformDataCacheKeyTraits::deletedValue): (WebCore::FontPlatformDataCacheKeyTraits::emptyValue): (WebCore::FontCache::getCachedFontPlatformData):
  • platform/FontDescription.h: (WebCore::): (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::stretch): (WebCore::FontDescription::narrowerStretch): (WebCore::FontDescription::widerStretch): (WebCore::FontDescription::setStretch): (WebCore::FontDescription::operator==):
  • platform/mac/FontCacheMac.mm: (WebCore::FontCache::createFontPlatformData):
  • platform/mac/WebFontCache.mm: (acceptableChoice): (betterChoice): (+[WebFontCache fontWithFamily:traits:size:]):

2007-02-01 Nicholas Shanks <​webkit@nickshanks.com>

Reviewed by Mark.

CSS2 font-stretch property; uses American Typewriter and Helvetica Neue fonts,
requiring Regular, Condensed, Bold and Bold Condensed faces.

  • fast/css/computed-style-expected.txt: Updated.
  • fast/css/font-stretch-expected.checksum: Added.
  • fast/css/font-stretch-expected.png: Added.
  • fast/css/font-stretch-expected.txt: Added.
  • fast/css/font-stretch.html: Added.

2007-02-01 Nicholas Shanks <​webkit@nickshanks.com>

Reviewed by Mark.

Add support for CSS2 font-stretch property.

  • WebInspector/webInspector/inspector.js:
  • WebView/WebHTMLView.mm: (-[WebHTMLView _addToStyle:fontA:fontB:]):
10:57 PM Changeset in webkit [19349] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

<rdar://problem/4969201> REGRESSION: Safari applies the wrong font to BODY element at ​http://www.apple.com/downloads/dashboard/

  • platform/mac/WebFontCache.mm: (+[WebFontCache fontWithFamily:traits:size:]): Don't call [NSFont fontWithName:] with the desiredFamily on Tiger.
9:52 PM Changeset in webkit [19348] by ap
  • 4 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12506
REGRESSION: Safari doesn't display hebrew text on a web page,
displayed correctly on Tiger

WebCore:

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Advance the pointer when necessary.

LayoutTests:

  • fast/encoding/pseudo-tags-in-attributes-expected.txt: Changing back to success.
9:44 PM Changeset in webkit [19347] by staikos
  • 4 edits
    2 adds in trunk

Add a cookie interface for the Qt build.

7:11 PM Changeset in webkit [19346] by bdakin
  • 1530 edits in trunk/LayoutTests/tables/mozilla/bugs

un-doing accidental change that made all of the files in tables/mozilla/bugs allow tabs. whoopsie!

6:40 PM Changeset in webkit [19345] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Adele.


  • fixed <rdar://problem/4922764> ASSERTION: (!m_contentFunction) in PolicyCheck::call trying to visit feed URL (CNN, Apple, etc.)
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopPolicyCheck): Call new cancel method instead of call(false) on old check. (WebCore::PolicyCheck::cancel): call any callback function that is set with false or PolicyIgnore as appropriate.
  • loader/FrameLoader.h:
5:55 PM Changeset in webkit [22888] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

5:55 PM Changeset in webkit [19344] by sfalken
  • 1 copy in tags/Safari-521.33.1b

New tag.

5:41 PM Changeset in webkit [22887] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-02-01 Ada Chan <​adachan@apple.com>

Reviewed by Anders.


Forgot to assign document to 0 in case of failure in WebView::mainFrameDocument().

  • WebView.cpp: (WebView::mainFrameDocument):
5:34 PM Changeset in webkit [19343] by andersca
  • 74 edits in trunk

LayoutTests:

Reviewed by Darin.

Update test results that have console messages.


  • dom/html/level2/html/HTMLFrameElement09-expected.txt:
  • dom/html/level2/html/HTMLIFrameElement11-expected.txt:
  • dom/xhtml/level2/html/HTMLBaseElement01-expected.txt:
  • dom/xhtml/level2/html/HTMLBaseElement02-expected.txt:
  • dom/xhtml/level2/html/frame-expected.txt:
  • dom/xhtml/level2/html/iframe-expected.txt:
  • editing/execCommand/4920488-expected.txt:
  • editing/selection/contenteditable-click-inside-expected.txt:
  • editing/selection/contenteditable-click-outside-expected.txt:
  • fast/AppleScript/001-expected.txt:
  • fast/dynamic/015-expected.txt:
  • fast/events/iframe-object-onload-expected.txt:
  • fast/events/updateLayoutForHitTest-expected.txt:
  • fast/forms/display-none-in-onchange-keyboard-expected.txt:
  • fast/forms/input-text-click-inside-expected.txt:
  • fast/forms/input-text-click-outside-expected.txt:
  • fast/forms/selected-index-assert-expected.txt:
  • fast/js/array-foreach-expected.txt:
  • fast/js/array-some-expected.txt:
  • fast/js/kde/exception_propagation-expected.txt:
  • fast/js/kde/garbage-n-expected.txt:
  • fast/js/kde/string-1-n-expected.txt:
  • fast/js/kde/string-2-n-expected.txt:
  • fast/parser/script-tag-with-trailing-slash-expected.txt:
  • fast/table/click-near-anonymous-table-expected.txt:
  • fast/tokenizer/002-expected.txt:
  • fast/tokenizer/external-script-document-write_2-expected.txt:
  • fast/tokenizer/script_extra_close-expected.txt:
  • fast/xsl/transform-xhr-doc-expected.txt:
  • http/tests/navigation/error404-goback-expected.txt:
  • http/tests/xmlhttprequest/set-dangerous-headers-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
  • svg/custom/dynamic-empty-path-expected.txt:
  • svg/custom/js-update-container-expected.txt:
  • svg/custom/js-update-gradient-expected.txt:
  • svg/custom/js-update-polygon-changes-expected.txt:
  • svg/custom/js-update-polygon-removal-expected.txt:
  • svg/custom/path-bad-data-expected.txt:
  • svg/custom/polyline-hittest-expected.txt:
  • svg/custom/polyline-invalid-points-expected.txt:
  • svg/custom/polyline-setattribute-points-null-expected.txt:
  • svg/custom/svgpolyparser-extra-space-expected.txt:
  • svg/custom/use-modify-target-symbol-expected.txt:
  • svg/custom/viewbox-syntax-expected.txt:
  • tables/mozilla/bugs/bug53690-1-expected.txt:
  • tables/mozilla/bugs/bug9024-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug3517-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
  • tables/mozilla_expected_failures/core/captions1-expected.txt:
  • tables/mozilla_expected_failures/dom/appendCells1-expected.txt:
  • tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.txt:
  • tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
  • tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:

WebKitTools:

Reviewed by Darin.

  • DumpRenderTree/UIDelegate.m: (-[UIDelegate webView:addMessageToConsole:]): Dump console messages.
4:52 PM Changeset in webkit [19342] by bdakin
  • 1525 edits
    3 moves
    13 adds
    9 deletes in trunk

WebCore:

Reviewed by Hyatt.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=10517 REGRESSION
(r12065-r12082): Navigation graphic wraps to the next line on
duart.com and <rdar://problem/4960505> REGRESSION: The Awesome
Windows Vista page has a layout error in the header table (10517)

The problem is that we never supported a quirk that other browsers
support where, under very specific circumstances, a table cell will
grow to fit an image inside of it. This is only a regression
because a bug was fixed were we were 1 pixel off in the calculation
of overflow in some cases.

  • rendering/RenderBlock.cpp: (WebCore::shouldGrowTableCellForImage): (WebCore::RenderBlock::calcInlineMinMaxWidth):
4:48 PM Changeset in webkit [22886] by adachan
  • 3 edits in branches/WindowsMerge/WebKitWin

2007-02-01 Ada Chan <​adachan@apple.com>

Reviewed by Steve, Geoff.

WebKitWin:

<rdar://4969341> Regression: crash: when Resetting Safari
<rdar://4953390> Closing my two open boomer windows produced a crash
Fixed crash when closing second window and doing the close
all safari window option in Reset Safari.

  • WebFrame.cpp: WebFramePrivate has a pointer to frameView but does not hold a reference to it. The frame holds a ref to the frameView anyway, so it's safest to get the frameView through the frame. The crash happened because frame already has cleared out its frameView but WebFrame was still accessing the old stale frameView through that data member in WebFramePrivate. (WebFrame::WebFramePrivate::m_policyFunction): (WebFrame::WebFramePrivate::frameView): (WebFrame::initWithWebFrameView): (WebFrame::layoutIfNeeded): (WebFrame::hasFrameView):
  • WebView.cpp: (WebView::paintIntoBackingStore): bail if frameView is null. (WebView::setHostWindow): don't set the view window's parent to 0. It'll end up creating a standalone window.


3:35 PM Changeset in webkit [22885] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Brady.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): Make sure to always retain the request we return. (In practice, we were already doing this since client can never be null).


(WebCore::didReceiveResponse):
Remove client null check.

3:06 PM Changeset in webkit [22884] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-02-01 Steve Falkenburg <​sfalken@apple.com>

B&I build fix

  • WebCore.vcproj/WebCore.vcproj:
11:57 AM Changeset in webkit [22883] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

<rdar://problem/4969348>
REGRESSION: Crash loading pdf


  • WebView.cpp: (WebView::canShowMIMEType): Return true if the MIME type can be handled by a plug-in.
11:57 AM Changeset in webkit [19341] by lars
  • 2 edits in trunk/WebKitQt

Reviewed by Adam.

Fix form loading for the Qt build.

11:53 AM Changeset in webkit [19340] by brmorris
  • 2 edits in S60/trunk/WebCore

brmorris, reviewed by zalan

DESC: Updated def file

  • BWINS/WEBCOREU.DEF:
9:34 AM Changeset in webkit [19339] by darin
  • 2 edits in trunk/LayoutTests
  • fast/encoding/pseudo-tags-in-attributes-expected.txt: Change test result to reflect failure because bug 12506 isn't fixed yet; we'll change it back once the bug is re-fixed.
4:27 AM Changeset in webkit [19338] by zack
  • 5 edits in trunk/WebCore

Implement native look for comboboxes
and fix/implement popup menus. Also add the m_timestamp
and m_eventType setting to PlatformMouseEvent
r=Lars

12:56 AM Changeset in webkit [19337] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Adam.


<rdar://problem/4730469> REGRESSION: Assertion failure in -[WebDataSource(WebInternal) _bridge] when forwarding message

  • WebView/WebDataSource.mm: (-[WebDataSource subresources]): Check for being uncommitted and return emtpy result. (-[WebDataSource subresourceForURL:]): ditto
12:44 AM Changeset in webkit [22882] by aroben
  • 7 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve.

Fix <rdar://problem/4849601> Implement printing of individual subframes

This just moves some functions from IWebViewPrivate to IWebFramePrivate.

  • Interfaces/IWebFramePrivate.idl: Added declarations.
  • Interfaces/IWebViewPrivate.idl: Removed declarations.
  • WebFrame.cpp: Added functions from WebView.cpp. (WebFrame::computePageRects): (WebFrame::getPrintedPageCount): (WebFrame::spoolPages):
  • WebFrame.h: Added declarations.
  • WebView.cpp: Moved functions to WebFrame.cpp.
  • WebView.h: Removed declarations.
12:36 AM Changeset in webkit [19336] by darin
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • test for <rdar://problem/4887428> REGRESSION: Implement slight delay for firing incremental onSearch event
  • fast/forms/search-event-delay-expected.txt: Added.
  • fast/forms/search-event-delay.html: Added.

WebCore:

Reviewed by Maciej.

  • fix <rdar://problem/4887428> REGRESSION: Implement slight delay for firing incremental onSearch event
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): Set up timer. (WebCore::RenderTextControl::subtreeHasChanged): Start timer here instead of immediately sending event. (WebCore::RenderTextControl::searchEventTimerFired): Added. Sends search event. (WebCore::RenderTextControl::stopSearchEventTimer): Added. (WebCore::RenderTextControl::startSearchEventTimer): Added. Sends search event right away if there is no text. If there is some text, sets the timer using the same delay rule as NSSearchField. If you keep typing, then the timer keeps getting reset 0.2 seconds into the future until you pause.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::onSearch): Tell the renderer to stop the timer, since we're sending a search event. This helps when a caller other than the timer decides to send an explicit search event.
12:23 AM Changeset in webkit [19335] by mjs
  • 2 edits in trunk/WebCore

Fix by Darin, reviewed by Maciej.

  • fix ~10% performance regression from encoding fix
  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Fix a logic error which made huge strings accidentally.

Jan 31, 2007:

11:53 PM Changeset in webkit [19334] by lars
  • 2 edits in trunk/WebCore

fix the Qt build

11:18 PM Changeset in webkit [19333] by bdash
  • 4 edits in tags/Safari-521.33

Versioning.

11:08 PM Changeset in webkit [19332] by bdash
  • 3 edits in tags/Safari-521.33/WebKit

Merge in r19308.

10:55 PM Changeset in webkit [19331] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adam and Geoff.

  • test for <rdar://problem/4786767> REGRESSION: <select> controls are not resized when zooming text
  • fast/forms/select-width-font-change-expected.txt: Added.
  • fast/forms/select-width-font-change.html: Added.

WebCore:

Reviewed by Adam and Geoff.

  • fix <rdar://problem/4786767> REGRESSION: <select> controls are not resized when zooming text

Test: fast/forms/select-width-font-change.html

  • rendering/RenderMenuList.h: Cleaned up formatting a bit. Removed unneeded include of PopupMenu.h. Made a lot more things private, including the PopupMenuClient base class, all of the virtual functions from PopupMenuClient, and the setTextFromOption function. Added updateOptionsWidth.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setStyle): Added code to call updateOptionsWidth when the font changes. (WebCore::RenderMenuList::updateOptionsWidth): Added. Factored code out of updateFromElement. Changed to do nothing when m_optionsWidth is already correct. (WebCore::RenderMenuList::updateFromElement): Moved code to recomputed options width to the new updateOptionsWidth function. (WebCore::RenderMenuList::text): Made const.
10:37 PM Changeset in webkit [19330] by bdash
  • 1 copy in tags/Safari-521.33

New tag.

10:04 PM Changeset in webkit [19329] by bdash
  • 2 edits in tags/WebKit-421.33.1/WebKit

Versioning.

10:03 PM Changeset in webkit [22881] by oliver
  • 3 edits in branches/WindowsMerge/WebCore

2007-01-31 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

WebCoreWin:

Updating event handler logic to make use of methods migrated from
WebKit to WebCore

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::handleDrag): Updating handleDrag to use methods that we've migrated to WebCore
  • platform/win/PlatformMouseEventWin.cpp: (WebCore::messageToEventType): (WebCore::PlatformMouseEvent::PlatformMouseEvent): provide the type of mouse event
10:02 PM Changeset in webkit [19328] by bdash
  • 3 edits in tags/WebKit-421.33.1/WebKit

Merge in r19308.

10:02 PM Changeset in webkit [19327] by oliver
  • 21 edits in trunk

liver Hunt <​oliver@apple.com>

Reviewed by Adam.

WebCore:

Migrate more drag and drop logic to WebCore, start preparing
to move EventHandler::handleDrag from EventHandlerMac to EventHandler

  • WebCore.exp: updating methods


  • dom/Clipboard.cpp:
  • dom/Clipboard.h: (WebCore::Clipboard::Clipboard): (WebCore::Clipboard::setDragHasStarted): (WebCore::Clipboard::dragStarted): Moving from ClipboardMac to Clipboard
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent): PlatformMouseEvent no longer lies about button state, however DOM Events don't allow NoButton, so we need to convert NoButton to LeftButton when we create a DOM Event from PlatformMouseEvent
  • page/DragClient.h: Tidying comment
  • page/DragController.cpp: (WebCore::createMouseEvent): Updated for new PlatformMouseEvent constructors (WebCore::DragController::mayStartDragAtEventLocation): Migrated from WebKit
  • page/DragController.h: Added above function declarations
  • page/EventHandler.cpp: (WebCore::EventHandler::dragState): (WebCore::EventHandler::dragHysteresisExceeded): (WebCore::EventHandler::freeClipboard): (WebCore::EventHandler::shouldDragAutoNode): Moved from EventHandlerMac (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::handleMousePressEvent): Use DragController
  • page/EventHandler.h: Added DragState struct definition to EventHandler
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::eventActivatedView): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::handleMouseUp): (WebCore::EventHandler::mouseDown): Update to use DragController and PlatformMouseEvent
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dragSourceMovedTo:]): (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): Use DragController for state

WebKit:

Migrating methods to WebCore

  • WebCoreSupport/WebFrameBridge.mm:
  • WebView/WebHTMLView.mm:
  • WebView/WebHTMLViewPrivate.h:


9:59 PM Changeset in webkit [19326] by bdash
  • 1 copy in tags/WebKit-421.33.1/WebKit

New tag (part 2).

9:58 PM Changeset in webkit [19325] by bdash
  • 1 add in tags/WebKit-421.33.1

New tag.

9:13 PM Changeset in webkit [22880] by adachan
  • 3 edits in branches/WindowsMerge/WebKitWin

2007-01-31 Ada Chan <​adachan@apple.com>

Reviewed by Adam.


Adam and I found a missing retain on WebFrame::setUpPolicyListener(). The mac
code returns a RefPtr which retains it, but we are returning the raw pointer.
Changed the code to return a COMPtr. Without this change, loading bogus urls
will crash.

  • WebFrame.cpp: (WebFrame::dispatchWillSubmitForm): (WebFrame::setUpPolicyListener): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction):
  • WebFrame.h:
8:26 PM Changeset in webkit [19324] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12506
REGRESSION: Safari doesn't display hebrew text on a web page,
displayed correctly on Tiger

  • fast/encoding/pseudo-tags-in-attributes-expected.txt: Added.
  • fast/encoding/pseudo-tags-in-attributes.html: Added.

WebCore:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12506
REGRESSION: Safari doesn't display hebrew text on a web page,
displayed correctly on Tiger

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Skip over quoted attributes.
8:20 PM Changeset in webkit [19323] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • rendering/RenderLayer.cpp: (WebCore::Marquee::Marquee):
7:51 PM Changeset in webkit [19322] by andersca
  • 7 edits
    5 adds in trunk

LayoutTests:

Reviewed by Maciej.

<rdar://problem/4886776>
REGRESSION: After opening a web archive, location shows the actual URL, not the webarchive file

  • webarchive/loading/resources/helloworld.webarchive: Added.
  • webarchive/loading/test-loading-archive-expected.txt: Added.
  • webarchive/loading/test-loading-archive.html: Added.

WebCore:

Reviewed by Maciej.

<rdar://problem/4886776>
REGRESSION: After opening a web archive, location shows the actual URL, not the webarchive file

  • WebCore.exp:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadWithData):
  • loader/FrameLoader.h: New function which continues a load but using a given buffer instead.

WebKit:

Reviewed by Maciej.

<rdar://problem/4886776>
REGRESSION: After opening a web archive, location shows the actual URL, not the webarchive file


"Revert" the change done in 13734.


  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation loadArchive]): Don't do a new load here, as this would cancel the current load and call the resource load delegate's didFailLoadingWithError: method. Instead, call continueLoadWithData.
7:50 PM Changeset in webkit [22879] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-01-31 Ada Chan <​adachan@apple.com>

Reviewed by Anders.

WebKitWin:

Implement WebView::mainFrameDocument.

  • WebView.cpp: (WebView::mainFrameDocument):


7:30 PM Changeset in webkit [19321] by andersca
  • 2 edits in trunk/WebKitTools
  • DumpRenderTree/ResourceLoadDelegate.m: (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]): Use an NSString here so we can guarantee that -description always returns the same value.
6:14 PM Changeset in webkit [19320] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam.


  • fix sporadic crash
  • wtf/ListHashSet.h: (WTF::::remove): remove before deleting
5:55 PM Changeset in webkit [19319] by adele
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12516
REGRESSION (r19313): All keyboard navigation has stopped working

For non-editable selections, handleKeyPress doesn't need to call _interceptEditingKeyEvent.

  • editing/Editor.cpp: (WebCore::selectionForEvent): Moved this to the top of the file. (WebCore::Editor::handleKeyPress): Do the equivalent of the _canEdit check that used to be in WebKit WebEditorClient::handleKeyPress.
5:33 PM Changeset in webkit [19318] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

Fix run-pageloadtest to actually work again.

  • Misc/WebNSWindowExtras.m: (+[NSWindow _webkit_displayThrottledWindows]):
5:03 PM Changeset in webkit [19317] by ggaren
  • 8 edits in trunk

WebCore:

Reviewed by Darin Adler.

Added a Range counter to detect leaks. Tweaked the Node counter.


Also fixed a TextIterator destructive modification bug that I noticed along the
way. No test case for this bug because no clients have been bitten by it
yet.

  • dom/Node.cpp: Renamed NodeImplCounter to NodeCounter, changed counter to unsigned, fixed formatting to match style guidelines. (WebCore::NodeCounter::~NodeCounter): (WebCore::Node::Node): (WebCore::Node::~Node):
  • dom/Range.cpp: (WebCore::RangeCounter::~RangeCounter): Added. (WebCore::Range::Range): (WebCore::Range::~Range): (WebCore::Range::ownerDocument): New accessor, used by TextIterator to avoid annoying NULL checks.
  • dom/Range.h:
  • editing/TextIterator.cpp: (WebCore::TextIterator::subrange): (1) Don't initialize result with entireRange -- doing so would create a PassRefPtr that pointed to entireRange, so this function would destructively modify the Range you passed it. Initialize it with a new Range instead. (2) Don't use a PassRefPtr as a local variable, because they have sneaky semantics. Use a RefPtr instead. (3) Don't call CharacterIterator::range() willy-nilly, since it does non-trivial work. Use a local variable instead.

WebKitTools:

Reviewed by Darin Adler.

Added Selection::toRange to the leaks -exclude list, since it comes up
as a false positive (Radar 4967949).


Also added RangeCounter to the global initializer exclude list. I added
a RangeCounter since leaks won't detect all Range leaks anymore.

  • Scripts/check-for-global-initializers:
  • Scripts/run-webkit-tests:
4:31 PM Changeset in webkit [19316] by andersca
  • 2 edits in trunk/WebKitTools
  • DumpRenderTree/ResourceLoadDelegate.m: (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]): Don't try to create an identifier if resource loads shouldn't be dumped.
3:00 PM Changeset in webkit [19315] by andersca
  • 4 edits
    2 adds in trunk/WebKitTools

Reviewed by Geoff.

Add dumping of resource loads. This isn't completely tweaked yet since the test results would
rely on resources being delivered in the same order which might not always be true. However, it works good
enough for the simple webarchive tests I want to do right now.


  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController dumpResourceLoadCallbacks]): (runTest):


  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/ResourceLoadDelegate.h: Added.
  • DumpRenderTree/ResourceLoadDelegate.m: Added. Add new resource load delegate.
2:59 PM Changeset in webkit [19314] by zimmermann
  • 2 edits in trunk/WebKit

Reviewed by Maciej.
Fix run-pageloadtest to actually work again.

2:55 PM Changeset in webkit [19313] by adele
  • 17 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/4521461> REGRESSION: when keyPress event changes form focus, inserted key goes to wrong control

  • fast/events/keypress-focus-change-expected.txt: Added.
  • fast/events/keypress-focus-change.html: Added.
  • fast/events/resources/keypress-frame.html: Added.

WebCore:

Reviewed by Darin.

WebCore part of fix for <rdar://problem/4521461> REGRESSION: when keyPress event changes form focus, inserted key goes to wrong control

Test: fast/events/keypress-focus-change.html

  • editing/Editor.cpp: (WebCore::selectionForEvent): Added. This computes a selection that considers the case where an event handler has moved the selection outside of a text control. In that case, we use the target control's selection. (WebCore::Editor::insertText): This gets the selectionForEvent, checks that the selection is editable, and calls TypingCommand::insertText with the correct selection.
  • editing/TypingCommand.h: Added a version of insertText that takes a selection. The old version of insertText will call this, and pass in the frame's selection.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): Added. Uses the passed in selection to set the starting and ending selections correctly so that the editing machinery will insert the text in the correct place.
  • page/Page.h: Added convenience method to get selection from focused or main frame.
  • page/Page.cpp: (WebCore::Page::selection):
  • html/HTMLInputElement.h: Added selection methods to get selection for text controls.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::selection):
  • html/HTMLTextAreaElement.h:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::selection):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::selection):

WebKit:

Reviewed by Darin.

WebKit part of fix for <rdar://problem/4521461> REGRESSION: when keyPress event changes form focus, inserted key goes to wrong control

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyPress): Instead of using the selected frame, use the frame for the target of the keyboard event. Also, don't do the canEdit check here, since the target's frame might not have a selection at this point. Do the canEdit check within Editor::insertText, where we determine which selection to use for inserting text.
  • WebView/WebEditingDelegatePrivate.h: Added forward declaration of DOMHTMLElement. This is needed after reordering includes in WebEditorClient.mm.
2:01 PM Changeset in webkit [19312] by ggaren
  • 2 edits in trunk/WebKitTools

Backing out the CFRunLoopRunSpecific exclude command because it was overly
broad. We'll either need to work around this leak in DRT, or do some
custom grep-based leak ignoring.

  • Scripts/run-webkit-tests:
1:50 PM Changeset in webkit [19311] by brmorris
  • 2 edits in S60/trunk/WebKit

sareen, Reviewed by zalan.

DESC: cache control present in the HTTP header is not properly supported EAMO-6XTJVX
​http://bugs.webkit.org/show_bug.cgi?id=12478

1:49 PM Changeset in webkit [19310] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

sareen, Reviewed by zalan.

DESC: cache control present in the HTTP header is not properly supported EAMO-6XTJVX
​http://bugs.webkit.org/show_bug.cgi?id=12478

1:24 PM Changeset in webkit [19309] by brmorris
  • 7 edits in S60/branches/3.1m

sareen, reviewed by zalan

DESC: Browser fails to load page after selection from drop-down list. (MLEN-6XRDHA)
​http://bugs.webkit.org/show_bug.cgi?id=12427

1:15 PM Changeset in webkit [19308] by aliceli1
  • 3 edits in trunk/WebKit

Reviewed by Tim Hatcher.

Turning an accidental API change to an SPI change

  • WebView/WebEditingDelegate.h:
  • WebView/WebEditingDelegatePrivate.h: move some declarations into private header.
1:11 PM Changeset in webkit [22878] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin
1:10 PM Changeset in webkit [22877] by sfalken
  • 3 edits in branches/WindowsMerge/WebCore

2007-01-31 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.

Fix BString bugs.

  • platform/win/BString.cpp: (WebCore::BString::BString): Call SysAllocString instead of SysAllocStringLen (WebCore::BString::operator=): Add proper null checks (WebCore::operator ==): Add proper null checks
1:04 PM Changeset in webkit [19307] by brmorris
  • 8 edits in S60/trunk

sareen, Reviewed by zalan <​zbujtas@gmail.com>.

DESC: Browser fails to load page after selection from drop-down list MLEN-6XRDHA
​http://bugs.webkit.org/show_bug.cgi?id=12427

8:21 AM Changeset in webkit [19306] by brmorris
  • 2 edits in S60/trunk/WebKit

brmorris, Reviewed by nobody - build fix.

DESC: add widget registry & engine to rom image.

  • rom/webkit.iby:
7:08 AM Changeset in webkit [19305] by darin
  • 2 edits
    2 adds in trunk

WebCore:

  • fix build
  • ForwardingHeaders/wtf/ListHashSet.h: Added.

WebKit:

  • fix build
  • ForwardingHeaders/wtf/ListHashSet.h: Added.
6:08 AM Changeset in webkit [19304] by zack
  • 2 edits in trunk/WebCore

Implement native colors for selections.
r=Lars

5:44 AM Changeset in webkit [19303] by zack
  • 5 edits in trunk/WebKitQt

Expose the fact that the form has been edited
in the public Qt api.

5:43 AM Changeset in webkit [19302] by mjs
  • 7 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Mark with help from Lars.


  • added new ListHashSet class, which combines a hashtable and a linked list to provide a set that keeps elements in inserted order


This is to assist in fixing the following:
<rdar://problem/4751164> REGRESSION: Safari places text on incorrect button when returning to a page via back [10541]
​http://bugs.webkit.org/show_bug.cgi?id=10541

  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/HashTable.h: (WTF::HashTable::find): (WTF::HashTable::contains): (WTF::::find): (WTF::::contains):
  • wtf/ListHashSet.h: Added. (WTF::ListHashSetNode::ListHashSetNode): (WTF::ListHashSetNodeHashFunctions::hash): (WTF::ListHashSetNodeHashFunctions::equal): (WTF::ListHashSetIterator::ListHashSetIterator): (WTF::ListHashSetIterator::get): (WTF::ListHashSetIterator::operator*): (WTF::ListHashSetIterator::operator->): (WTF::ListHashSetIterator::operator++): (WTF::ListHashSetIterator::operator--): (WTF::ListHashSetIterator::operator==): (WTF::ListHashSetIterator::operator!=): (WTF::ListHashSetIterator::operator const_iterator): (WTF::ListHashSetIterator::node): (WTF::ListHashSetConstIterator::ListHashSetConstIterator): (WTF::ListHashSetConstIterator::get): (WTF::ListHashSetConstIterator::operator*): (WTF::ListHashSetConstIterator::operator->): (WTF::ListHashSetConstIterator::operator++): (WTF::ListHashSetConstIterator::operator--): (WTF::ListHashSetConstIterator::operator==): (WTF::ListHashSetConstIterator::operator!=): (WTF::ListHashSetConstIterator::node): (WTF::ListHashSetTranslator::hash): (WTF::ListHashSetTranslator::equal): (WTF::ListHashSetTranslator::translate): (WTF::::ListHashSet): (WTF::::operator): (WTF::::~ListHashSet): (WTF::::size): (WTF::::capacity): (WTF::::isEmpty): (WTF::::begin): (WTF::::end): (WTF::::find): (WTF::::contains): (WTF::::add): (WTF::::remove): (WTF::::clear): (WTF::::unlinkAndDelete): (WTF::::appendNode): (WTF::::deleteAllNodes): (WTF::::makeIterator): (WTF::::makeConstIterator): (WTF::deleteAllValues):

WebCore:

Reviewed by Mark.

  • dom/Document.cpp: (WebCore::Document::formElementsState):
  • dom/Document.h:


I couldn't figure out the back/forward support in the tests enough
to make an automated test, but this maual test reproduces the
problem 100% without this patch:


  • manual-tests/back.html: Added.
  • manual-tests/form-control-madness.html: Added.
4:59 AM Changeset in webkit [19301] by ddkilzer
  • 1 edit in trunk/WebCore/ChangeLog

Added Bugzilla bug number. Thanks Mitz!

4:51 AM Changeset in webkit [19300] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Mitz.

No test cases since there is no change in functionality.

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Simplify canFitOnLine expression.
4:36 AM Changeset in webkit [19299] by zack
  • 3 edits in trunk/WebCore

Adding comments explaining how the focus ring implementation
works on the Qt platform and just move focus ring rendering
related code to the same spot.

4:20 AM Changeset in webkit [19298] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Eric.


  • add back no-op version of silly method so that shipping Safari can still run the PLT
  • Misc/WebNSWindowExtras.m: (-[NSWindow _webkit_displayThrottledWindows]):
4:00 AM Changeset in webkit [19297] by zack
  • 10 edits in trunk

Clean up key event handling on Qt.
r=Lars

12:57 AM Changeset in webkit [19296] by staikos
  • 2 edits in trunk/WebCore

Fix a double delete on cancel as well as a crash with proxy

12:33 AM Changeset in webkit [19295] by bdash
  • 5 edits in trunk/WebKit

2007-01-31 Mark Rowe <​mrowe@apple.com>

More build fixing.

  • Misc/WebKitLogging.h: Use !defined() rather than !.
  • Plugins/WebNetscapePluginStream.h: Remove #if cplusplus as this file is only included from Obj-C++ files.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Use #ifdef rather than #if.
  • WebView/WebView.mm: (-[WebView isGrammarCheckingEnabled]): Ditto.
12:11 AM Changeset in webkit [19294] by bdash
  • 2 edits in trunk/WebKit

2007-01-31 Mark Rowe <​mrowe@apple.com>

Build fix.

  • WebView/WebView.mm: (-[WebView initWithFrame:frameName:groupName:]):
12:10 AM Changeset in webkit [19293] by staikos
  • 7 edits in trunk/WebKitQt

fix a crash on exit
remove focusFrame
add childFrames

Note: See TracTimeline for information about the timeline view.