Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Feb 8, 2007:

10:49 PM Changeset in webkit [19523] by kjk

• 3 edits in trunk/WebCore

Reviewed by Darin.

Linux/gdk build fixes.

• Projects/gdk/webcore-gdk.bkl: Account for file renaming.
• platform/gdk/KeyEventGdk.cpp: Make gdk's tab key recognized as tab so that keyboard link walking works on gdk. (WebCore::keyIdentifierForGdkKeyCode):

10:29 PM Changeset in webkit [19522] by adele

• 5 edits
  2 adds in trunk

LayoutTests:

Reviewed by Brady.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=12599
<rdar://problem/4973507> REGRESSION: When replying in Gmail, the caret disappears when you start to type (12599)

• fast/frames/iframe-window-focus-expected.txt: Added.
• fast/frames/iframe-window-focus.html: Added.

WebCore:

Reviewed by Brady.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12599
<rdar://problem/4973507> REGRESSION: When replying in Gmail, the caret disappears when you start to type (12599)

When a frame's window was focused, the page didn't get updated about the new frame getting focus.
This was causing handleKeyPress to fail because it kept getting a selection for the wrong frame (which wasn't editable).

Test: fast/frames/iframe-window-focus.html

• page/Frame.cpp: (WebCore::Frame::focusWindow): (WebCore::Frame::unfocusWindow):
• page/Frame.h:
• page/mac/FrameMac.mm: (WebCore::FrameMac::focusWindow): (WebCore::FrameMac::unfocusWindow):

10:29 PM Changeset in webkit [22927] by adele

• 3 edits in branches/WindowsMerge/WebCore

Reviewed by Brady.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12599
<rdar://problem/4973507> REGRESSION: When replying in Gmail, the caret disappears when you start to type (12599)

This also fixes a bug where when you called window.focus() on a background window, it did not come to the front.

• bridge/win/FrameWin.h: Removed focusWindow() and unfocusWindow() stubs since there are now implementations in the base class.
• platform/win/TemporaryLinkStubs.cpp:

9:44 PM Changeset in webkit [22926] by aliceli1

• 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

• WebView.cpp: (WebView::searchFor): Ever since 11396, the widget no longer handles frame focus changes. This is now the page's focus controller responsibility

9:43 PM Changeset in webkit [19521] by bdash

• 2 edits in trunk/WebKitSite

2007-02-08 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

• nav.inc: Add link to very work-in-progress DOM documentation.

9:28 PM Changeset in webkit [22925] by beidson

• 6 edits in branches/WindowsMerge/WebKitWin

Initial checkin for resume support (compiles everywhere, needs ToT CFnetwork to actually work)

8:20 PM Changeset in webkit [19520] by adele

• 5 edits
  4 adds in trunk

LayoutTests:

Reviewed by Brady.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=12480
<rdar://problem/4971222> REGRESSION (NativeListBox): Deselecting option causes list to jump to top

• fast/forms/listbox-deselect-scroll-expected.checksum: Added.
• fast/forms/listbox-deselect-scroll-expected.png: Added.
• fast/forms/listbox-deselect-scroll-expected.txt: Added.
• fast/forms/listbox-deselect-scroll.html: Added.

WebCore:

Reviewed by Brady.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12480
<rdar://problem/4971222> REGRESSION (NativeListBox): Deselecting option causes list to jump to top

Test: fast/forms/listbox-deselect-scroll.html

• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::activeSelectionStartListIndex): Added. Returns the index for the active selection. If there is no active selection, it returns the first selected index. (WebCore::HTMLSelectElement::activeSelectionEndListIndex): Added. If there is no active selection, it returns the last selected index.
• html/HTMLSelectElement.h:
• rendering/RenderListBox.cpp: (WebCore::RenderListBox::scrollToRevealSelection): Instead of using the first and last selected indices, use the active selection indices to determine which item to reveal. This way, when you're selecting with the keyboard, or the mouse, no unnecessary scrolling will occur if the end of your active selection is already visible.

7:45 PM Changeset in webkit [19519] by brmorris

• 3 edits in S60/branches/3.1m/WebCore

yaharon, Reviewed by zalan

DESC: crash when selecting the left Soft key Options when the cursor is in textarea field SCHY-6Y7SHD
​http://bugs.webkit.org/show_bug.cgi?id=12706

6:24 PM Changeset in webkit [19518] by adele

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for: <rdar://problem/4963411> Items of SELECT element are incorrectly highlighted when display:block is set

• fast/forms/select-block-background-expected.checksum: Added.
• fast/forms/select-block-background-expected.png: Added.
• fast/forms/select-block-background-expected.txt: Added.
• fast/forms/select-block-background.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/4963411> Items of SELECT element are incorrectly highlighted when display:block is set

Test: fast/forms/select-block-background.html

• rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): Paint the item backgrounds during the PaintPhaseChildBlockBackground or PaintPhaseChildBlockBackgrounds phase.

6:21 PM Changeset in webkit [19517] by bdash

• 7 edits
  4 adds in trunk

2007-02-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11047 REGRESSION: Empty options cause the entire select to collapse

Test: fast/forms/select-empty-option-height.html

• fix ​http://bugs.webkit.org/show_bug.cgi?id=10783 REGRESSION (r16044): Clicking a popup changes layout around it

• rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setText): If the option text is empty, use a RenderBR as inner text, to ensure that the inner div has line height.

2007-02-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=11047 REGRESSION: Empty options cause the entire select to collapse

• updated results for ​http://bugs.webkit.org/show_bug.cgi?id=10783 REGRESSION (r16044): Clicking a popup changes layout around it

• fast/forms/HTMLOptionElement_label07-expected.txt:
• fast/forms/form-element-geometry-expected.txt:
• fast/forms/select-baseline-expected.txt:
• fast/forms/select-empty-option-height-expected.checksum: Added.
• fast/forms/select-empty-option-height-expected.png: Added.
• fast/forms/select-empty-option-height-expected.txt: Added.
• fast/forms/select-empty-option-height.html: Added.
• fast/replaced/three-selects-break-expected.txt:

5:48 PM Changeset in webkit [19516] by ggaren

• 5 edits in trunk

WebCore:

Reviewed by Beth Dakin.

Added a hard counter for SubresourceLoaders because the leaks tool now
ignores them.

• loader/SubresourceLoader.cpp: (WebCore::): (WebCore::SubresourceLoaderCounter::~SubresourceLoaderCounter): (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::~SubresourceLoader):
• page/Frame.cpp: Removed unnecessary #define

WebKitTools:

Reviewed by Beth Dakin.

Ignore another false leak report.

• Scripts/run-webkit-tests:

5:45 PM Changeset in webkit [22924] by andersca

• 5 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

<rdar://problem/4955068>
PluginViewWin leaks memory.

Make streams ref-counted. Remove streams from the hash set once they're done loading.

Don't try to paint if painting is disabled.

• plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::cancelAndDestroyStream): (WebCore::PluginStreamWin::destroyStream):
• plugins/win/PluginStreamWin.h:
• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::paint): (WebCore::PluginViewWin::stop): (WebCore::PluginViewWin::~PluginViewWin): (WebCore::PluginViewWin::disconnectStream):
• plugins/win/PluginViewWin.h:

5:44 PM Changeset in webkit [19515] by ggaren

• 4 edits in trunk

LayoutTests:

Reviewed by Beth Dakin.

Updated results now that we actually return the correct ones.

• fast/css/computed-style-expected.txt:

WebCore:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4982374> CSSComputedStyleDeclaration::getPropertyCSSValue
leak reported by buildbot

The leak was a typo: "new" instead of "return new". I also generously
deployed RefPtr in places that were holding ref-counted objects in
bare pointers.

• css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForShadow): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

4:49 PM Changeset in webkit [22923] by aroben

• 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adele.

Fix scrollbar painting.

3:07 PM Changeset in webkit [19514] by kjk

• 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

Linux/gdk build fixes.

• GdkLauncher/main.cpp: Add -exit-after-loading and -dump-render-tree as debugging aid. (strEq): (main):

3:01 PM Changeset in webkit [19513] by ggaren

• 1 edit in trunk/WebKitTools/Scripts/run-webkit-tests

build fix, oops!

2:59 PM Changeset in webkit [19512] by kjk

• 4 edits
  2 copies in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes.

• platform/gdk/EditorClientGdk.cpp: Added. Based on qt version. (WebCore::EditorClientGdk::shouldDeleteRange): (WebCore::EditorClientGdk::shouldShowDeleteInterface): (WebCore::EditorClientGdk::isContinuousSpellCheckingEnabled): (WebCore::EditorClientGdk::isGrammarCheckingEnabled): (WebCore::EditorClientGdk::spellCheckerDocumentTag): (WebCore::EditorClientGdk::shouldBeginEditing): (WebCore::EditorClientGdk::shouldEndEditing): (WebCore::EditorClientGdk::shouldInsertText): (WebCore::EditorClientGdk::shouldApplyStyle): (WebCore::EditorClientGdk::didBeginEditing): (WebCore::EditorClientGdk::respondToChangedContents): (WebCore::EditorClientGdk::didEndEditing): (WebCore::EditorClientGdk::didWriteSelectionToPasteboard): (WebCore::EditorClientGdk::didSetSelectionTypesForPasteboard): (WebCore::EditorClientGdk::selectWordBeforeMenuEvent): (WebCore::EditorClientGdk::isEditable): (WebCore::EditorClientGdk::registerCommandForUndo): (WebCore::EditorClientGdk::registerCommandForRedo): (WebCore::EditorClientGdk::clearUndoRedoOperations): (WebCore::EditorClientGdk::canUndo): (WebCore::EditorClientGdk::canRedo): (WebCore::EditorClientGdk::undo): (WebCore::EditorClientGdk::redo): (WebCore::EditorClientGdk::shouldInsertNode): (WebCore::EditorClientGdk::pageDestroyed): (WebCore::EditorClientGdk::smartInsertDeleteEnabled): (WebCore::EditorClientGdk::toggleContinuousSpellChecking): (WebCore::EditorClientGdk::toggleGrammarChecking): (WebCore::EditorClientGdk::handleKeyPress): (WebCore::EditorClientGdk::EditorClientGdk): (WebCore::EditorClientGdk::setPage):
• platform/gdk/EditorClientGdk.h: Added. Ditto.
• platform/gdk/FrameGdk.cpp: Add exitAfterLoading and dumpRenderTreeAfterLoading as small debugging features. Remove FrameGdkClient as no other platform has Frame*Client anymore. Adjust for new APIs. (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::onDidFinishLoad): (WebCore::FrameGdk::dumpRenderTree): (WebCore::FrameGdk::keyPress): (WebCore::FrameGdk::handleGdkEvent): (WebCore::FrameGdk::focusWindow): (WebCore::FrameGdk::unfocusWindow): (WebCore::FrameGdk::getObjectInstanceForWidget): (WebCore::FrameGdk::getEmbedInstanceForWidget): (WebCore::FrameGdk::bindingRootObject): (WebCore::FrameGdk::print): (WebCore::FrameGdk::getAppletInstanceForWidget): (WebCore::FrameGdk::issueCutCommand): (WebCore::FrameGdk::issueCopyCommand): (WebCore::FrameGdk::issuePasteCommand): (WebCore::FrameGdk::issueTransposeCommand): (WebCore::FrameGdk::issuePasteAndMatchStyleCommand): (WebCore::FrameGdk::markedTextRange): (WebCore::FrameGdk::shouldChangeSelection): (WebCore::FrameGdk::respondToChangedSelection): (WebCore::FrameGdk::mimeTypeForFileName):
• platform/gdk/FrameGdk.h: Ditto. (WebCore::FrameGdk::setExitAfterLoading): (WebCore::FrameGdk::exitAfterLoading): (WebCore::FrameGdk::setDumpRenderTreeAfterLoading): (WebCore::FrameGdk::dumpRenderTreeAfterLoading): (WebCore::GdkFrame):
• platform/gdk/TemporaryLinkStubs.cpp: Adjust to new APIs. Small cleanups. (FrameView::updateBorder): (Widget::setEnabled): (Widget::isEnabled): (Widget::enableFlushDrawing): (Widget::removeFromParent): (Widget::paint): (Widget::setIsSelected): (Widget::invalidate): (Widget::invalidateRect): (PlatformMouseEvent::PlatformMouseEvent): (WebCore::findWordBoundary): (ChromeClientGdk::chromeDestroyed): (ChromeClientGdk::closeWindowSoon): (ChromeClientGdk::canTakeFocus): (ChromeClientGdk::takeFocus): (ChromeClientGdk::canRunBeforeUnloadConfirmPanel): (ChromeClientGdk::addMessageToConsole): (ChromeClientGdk::runBeforeUnloadConfirmPanel): (ChromeClientGdk::runJavaScriptAlert): (ChromeClientGdk::runJavaScriptConfirm): (ChromeClientGdk::runJavaScriptPrompt): (ChromeClientGdk::setStatusbarText): (ChromeClientGdk::shouldInterruptJavaScript): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::searchableIndexIntroduction): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::refreshPlugins): (SearchPopupMenu::saveRecentSearches): (SearchPopupMenu::loadRecentSearches): (SearchPopupMenu::SearchPopupMenu): (Path::apply): (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::width): (PlatformScrollbar::height): (PlatformScrollbar::setEnabled): (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::setRect): (ResourceHandle::willLoadFromCache): (ResourceHandle::loadsBlocked): (ResourceHandle::loadResourceSynchronously): (PageCache::close): (Editor::ignoreSpelling): (Editor::learnSpelling): (Editor::isSelectionUngrammatical): (Editor::isSelectionMisspelled): (Editor::guessesForMisspelledSelection): (Editor::guessesForUngrammaticalSelection): (Editor::markMisspellingsAfterTypingToPosition): (Editor::newGeneralClipboard): (Pasteboard::generalPasteboard): (Pasteboard::writeSelection): (Pasteboard::writeURL): (Pasteboard::clear): (Pasteboard::canSmartReplace): (Pasteboard::documentFragment): (Pasteboard::plainText): (Pasteboard::Pasteboard): (Pasteboard::~Pasteboard): (ContextMenu::ContextMenu): (ContextMenu::~ContextMenu): (ContextMenu::appendItem): (ContextMenu::setPlatformDescription): (ContextMenu::platformDescription): (ContextMenuItem::ContextMenuItem): (ContextMenuItem::~ContextMenuItem): (ContextMenuItem::releasePlatformDescription): (ContextMenuItem::type): (ContextMenuItem::setType): (ContextMenuItem::action): (ContextMenuItem::setAction): (ContextMenuItem::title): (ContextMenuItem::setTitle): (ContextMenuItem::platformSubMenu): (ContextMenuItem::setSubMenu): (ContextMenuItem::setChecked): (ContextMenuItem::setEnabled): (WebCore::systemBeep): (WebCore::userIdleTime):

2:37 PM Changeset in webkit [22922] by andersca

• 6 edits
  2 adds in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

<rdar://problem/4972772>
Implement IWebResource::Data.

<rdar://problem/4972777>
Implement IWebDataSource::subresourceForURL.

• MemoryStream.cpp: (MemoryStream::MemoryStream): (MemoryStream::createInstance): (MemoryStream::Clone):
• MemoryStream.h: Remove notion of buffer owner, it's not needed now that the buffer itself is reference counted.

• WebDataSource.cpp: (WebDataSource::subresourceForURL): Implement this.

• WebKit.vcproj/WebKit.vcproj: Add WebResource.cpp and WebResource.h

• WebResource.cpp: Added. (WebResource::WebResource): (WebResource::~WebResource): (WebResource::createInstance): (WebResource::QueryInterface): (WebResource::AddRef): (WebResource::Release): (WebResource::initWithData): (WebResource::data): (WebResource::URL): (WebResource::MIMEType): (WebResource::textEncodingName): (WebResource::frameName):
• WebResource.h: Added.

• WebView.cpp: (WebView::formDelegate): Return E_FAIL if there's no form delegate.

2:37 PM Changeset in webkit [19511] by kjk

• 8 edits
  1 delete in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes.

• platform/GlyphPageTreeNode.h: Fix header guard name.
• platform/gdk/ChromeClientGdk.h:
• platform/gdk/CursorGdk.cpp: (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::aliasCursor):
• platform/gdk/MouseEventGdk.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
• platform/gdk/PageGdk.cpp: Removed. No longer used.
• platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::getThemeData): (WebCore::RenderThemeGdk::setCheckboxSize): (WebCore::RenderThemeGdk::paintCheckbox): (WebCore::RenderThemeGdk::setRadioSize): (WebCore::RenderThemeGdk::paintRadio): (WebCore::RenderThemeGdk::paintButton): (WebCore::RenderThemeGdk::adjustTextFieldStyle): (WebCore::RenderThemeGdk::paintTextField): (WebCore::RenderThemeGdk::paintTextArea): (WebCore::RenderThemeGdk::systemFont):
• platform/gdk/RenderThemeGdk.h:
• platform/gdk/ScreenGdk.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):

2:33 PM Changeset in webkit [19510] by ggaren

• 2 edits in trunk/WebKitTools

Minor fixup based on Maciej's review last night.

• Scripts/run-webkit-tests: Use normal "increment at end of loop" behavior, and do a little math to make it work.

2:31 PM Changeset in webkit [22921] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

2:30 PM Changeset in webkit [19509] by sfalken

• 1 copy in tags/Safari-521.34.2b

New tag.

2:15 PM Changeset in webkit [19508] by kjk

• 3 edits in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes for cairo.

• platform/graphics/GraphicsContext.cpp:
• platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::setFocusRingClip): (WebCore::GraphicsContext::clearFocusRingClip): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): (WebCore::GraphicsContext::origin): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setPlatformStrokeThickness): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformFont): (WebCore::GraphicsContext::setURLForRect): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setAlpha): (WebCore::toCairoOperator): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::fillRoundedRect):

2:07 PM Changeset in webkit [19507] by kjk

• 6 edits in trunk

WebCore:

Reviewed by Adam Roben.

Linux/gdk build fixes.

• Projects/gdk/webcore-gdk.bkl:
• WebCoreSources.bkl:
• webcore-base.bkl:

WebKitTools:

Reviewed by Adam Roben..

Linux/gdk build fixes.

• GdkLauncher/gdklauncher.bkl:

1:03 PM Changeset in webkit [22920] by andersca

• 2 edits in branches/WindowsMerge/WebCore

Remove unused stub.

• platform/win/TemporaryLinkStubs.cpp:

1:01 PM Changeset in webkit [19506] by beidson

• 3 edits in trunk/WebCore

Reviewed by Tim Hatcher

Tweaked the thread violation behavior to be disabled by default, and to provide
an easy breakpoint to set.
The possibilities for the "WebCoreThreadCheck" user defaults key are -

• The value "None" disables thread checking
• The value "Log" causes an NSLog on a violation
• The value "Exception" causes exceptions to be raised on a violation

• platform/Logging.h:
• platform/mac/LoggingMac.mm: (WebCore::_WebCoreThreadViolationCheck): (WebCoreReportThreadViolation): In the global namespace, making breakpoints cake!

12:56 PM Changeset in webkit [19505] by ggaren

• 3 edits in trunk/LayoutTests

Reviewed by Adam Roben, Darin Adler.

Updated results for tests that started failing after my run-webkit-tests
check-in.

These failures were not regressions. My check-in just caused the regular
bot to behave more like the leaks bot, so it started reporting the results
that the leaks bot had been reporting all along.

There does seem to be an underlying bug in the way XHTML documents report
line numbers for JavaScript exceptions. I've file that bug along with a
reduction:

​http://bugs.webkit.org/show_bug.cgi?id=12700
JavaScript errors in XML documents have incorrect line numbers

However, that bug is not a regression, so I think we should treat it separately.

• dom/xhtml/level2/html/frame-expected.txt:
• dom/xhtml/level2/html/iframe-expected.txt:

12:45 PM S60Webkit edited by franklin.davis@nokia.com

(diff)

12:42 PM S60Reindeer edited by franklin.davis@nokia.com

(diff)

12:38 PM S60Webkit edited by bradley.morrison@nokia.com

minor update to urls on s60webkit page (diff)

12:23 PM Changeset in webkit [19504] by kmccullo

• 2 edits in trunk/WebKitTools

Reviewed by

• Fix layout test failures.

• Scripts/run-webkit-tests:

11:59 AM Changeset in webkit [22919] by andersca

• 3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

Add shouldInterruptJavaScript to the API.

• Interfaces/IWebUIDelegatePrivate.idl:
• WebChromeClient.cpp: (WebChromeClient::addMessageToConsole): (WebChromeClient::shouldInterruptJavaScript):

11:58 AM Changeset in webkit [19503] by beidson

• 5 edits in trunk/WebCore

Reviewed by Tim Hatcher

<rdar://problem/4983515> Need mechanism to protect against WebKit calls from secondary threads
This initial landing is a conservative move until we can be certain of performance impact.
By writing to the user defaults key @"WebCoreThreadCheck" for the WebKit app you're running -

• The value "None" disables thread checking
• The value "Exception" causes exceptions to be raised on a violation
• The default is to do the check, and NSLog each violation

• bindings/objc/ExceptionHandlers.h: Add a "Is Main Thread" assert macro
• bindings/scripts/CodeGeneratorObjC.pm: Use new mechanism in allocs and deallocs for now

• platform/Logging.h: Added WebCoreThreadViolationCheck macro
• platform/mac/LoggingMac.mm: (WebCore::_WebCoreThreadViolationCheck): Check for main-threadedness, and do some stuff

11:48 AM Changeset in webkit [22918] by andersca

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Brady.

<rdar://problem/4888871>
Need to support synchronous XMLHttpRequest.

• platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::loadResourceSynchronously):

11:19 AM Changeset in webkit [19502] by kmccullo

• 2 edits in trunk/WebKit

Reviewed by

• fixing a build breakage.

• Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement):

10:52 AM Changeset in webkit [19501] by brmorris

• 8 edits in S60/trunk

brmorris <​bradley.morrison@nokia.com>, rs'd by zalan

DESC: merge from s60/branches/3.1m to s60/trunk of r19464, r19466, r19472 & r19499

10:39 AM Changeset in webkit [19500] by kmccullo

• 18 edits
  17 adds in trunk

LayoutTests:

Reviewed by Maciej, Darin and Mark.

rdar://problem/4922454

• No longer allow remote sites to access local resources.

• fast/loader/local-JavaScript-from-local-expected.txt: Added.
• fast/loader/local-JavaScript-from-local.html: Added.
• fast/loader/local-iFrame-source-from-local-expected.txt: Added.
• fast/loader/local-iFrame-source-from-local.html: Added.
• fast/loader/local-image-from-local-expected.txt: Added.
• fast/loader/local-image-from-local.html: Added.
• http/tests/security/local-JavaScript-from-remote-expected.txt: Added.
• http/tests/security/local-JavaScript-from-remote.html: Added.
• http/tests/security/local-iFrame-from-remote-expected.txt: Added.
• http/tests/security/local-iFrame-from-remote.html: Added.
• http/tests/security/local-image-from-remote-expected.txt: Added.
• http/tests/security/local-image-from-remote.html: Added.
• http/tests/security/resources/compass.jpg: Added.
• http/tests/security/resources/localPage.html: Added.
• http/tests/security/resources/localPage.html.orig: Added.
• http/tests/security/resources/localScript.js: Added.

WebCore:

Reviewed by Maciej, Darin, and Mark.

rdar://problem/4922454

• Prevents remote sites from executing local scripts.

• bindings/objc/DOM.mm: - renamed a function that is now in the base class (-[DOMElement image]): (-[DOMElement _imageTIFFRepresentation]):
• dom/XMLTokenizer.cpp: - removed needless asserts (WebCore::XMLTokenizer::notifyFinished):
• html/HTMLImageLoader.cpp: - renamed a function that is now in the base class (WebCore::HTMLImageLoader::dispatchLoadEvent):
• html/HTMLTokenizer.cpp: - removed needless asserts (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::notifyFinished):
• ksvg2/misc/SVGImageLoader.cpp: - renamed a function that is now in the base class (WebCore::SVGImageLoader::dispatchLoadEvent):
• loader/Cache.cpp: - return early if an error occured (WebCore::Cache::requestResource): (WebCore::Cache::remove):
• loader/CachedImage.h: - renamed a function that is now in the base class (WebCore::CachedImage::canRender):
• loader/CachedResource.h: - renamed a function that is now in the base class (WebCore::CachedResource::errorOccurred):
• loader/CachedScript.h: - renamed a function that is now in the base class (WebCore::CachedScript::schedule):
• loader/DocLoader.cpp: - The heart of the fix, prevents resources from being created or retrieved from the cache if a remote site is requesting the local resource. (WebCore::DocLoader::requestResource): (WebCore::DocLoader::setLoadInProgress):
• page/EventHandler.cpp: - renamed a function that is now in the base class (WebCore::selectCursor):
• rendering/HitTestResult.cpp: - renamed a function that is now in the base class (WebCore::HitTestResult::image):
• rendering/RenderImage.cpp: - renamed a function that is now in the base class (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint): (WebCore::RenderImage::layout): (WebCore::RenderImage::calcAspectRatioWidth): (WebCore::RenderImage::calcAspectRatioHeight):
• rendering/RenderImage.h: - renamed a function that is now in the base class (WebCore::RenderImage::errorOccurred):
• rendering/RenderListItem.cpp: - renamed a function that is now in the base class (WebCore::RenderListItem::setStyle):
• rendering/RenderListMarker.cpp: - renamed a function that is now in the base class (WebCore::RenderListMarker::isImage):

10:28 AM Changeset in webkit [19499] by brmorris

• 4 edits in S60/branches/3.1m/WebKit

yaharon, reviewed by yongjun.

DESC: [S60] Daily BAT 3.2: S60NG_Login- Password field is not filled automatically KDEA-6XZEDY
​http://bugs.webkit.org/show_bug.cgi?id=12696

10:19 AM Changeset in webkit [19498] by darin

• 2 edits in trunk/WebKitTools

Reviewed by Anders.

• Scripts/check-for-global-initializers: For speed, only check files that have been modified since the last time we linked. For tidiness, capture stderr from nm, and prevent "nm: no name list" messages from going out.

12:43 AM Changeset in webkit [22917] by hyatt

• 1 edit in branches/WindowsMerge/WebCore/platform/win/FontCacheWin.cpp

Remove my garbled fixme that I didn't intend to leave in. :)

12:42 AM Changeset in webkit [19497] by ggaren

• 2 edits in trunk/WebKitTools

Reviewed by Maciej Stachowiak, Adam Roben.

Added 'nthly' support to run-webkit-tests. It's like 'singly', for an
arbitrary number n.

Plus some renames:

• DumpRenderTree => "dumpTool" (to match abstraction elsewhere)
• checkLeaks => "shouldCheckLeaks" (to match style guidelines)
• tool => dumpTool (to match abstraction elsewhere)
• httpdOpen => isHttpdOpen (to match style guidelines)

Plus a few logic fixups:

• Don't check isDumpToolOpen when we know we've called openDumpTool().
• Use a single code path to decide when to shut down dumpTool and when to check for leaks, since the operations are coincidental.
• Use a single code path for running the leaks tool, since the only thing that varies between configurations is the output file name.
• Increment $count after each test finishes, instead of at the end of the loop, to help with comparing to the length of the array and %-ing by n.
• Use a more robust test inside the loop to determine if we need to close dumpTool, instead of copying the closing code outside the loop.

Layout tests pass.

• Scripts/run-webkit-tests:

12:40 AM Changeset in webkit [22916] by hyatt

• 2 edits in branches/WindowsMerge/WebCore/platform/win

Make Lucida Grande bold work in the engine. Required sick special case hackery for now. Also fix the validity check for initial font construction. r=aroben

Feb 7, 2007:

11:56 PM Changeset in webkit [22915] by aroben

• 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Maciej.

Fix mini search field painting.

10:29 PM Changeset in webkit [19496] by kjk

• 3 edits in trunk/WebCore

Reviewed by Maciej.

Add updateGeometry() to gdk's ScrollView. Needed to fix resizing of the window
in gdk.

• platform/ScrollView.h:
• platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::updateGeometry): (WebCore::ScrollView::setDrawable):

10:25 PM Changeset in webkit [19495] by kjk

• 3 edits
  1 move
  1 delete in trunk/WebCore

Reviewed by Maciej.

Linux/gdk build fixes.

• platform/ContextMenuItem.h:
• platform/PlatformMenuDescription.h:
• platform/gdk/PopupMenuGdk.cpp: Added. Renamed from RenderPopupMenuGdk.cpp for consistency with other platforms. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu):
• platform/gdk/RenderPopupMenuGdk.cpp: Removed.
• platform/gdk/RenderPopupMenuGdk.h: Removed.

10:24 PM Changeset in webkit [22914] by adele

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Draw a single down arrow for styled menu lists.

9:41 PM Changeset in webkit [19494] by aroben

• 2 edits in trunk/WebKit

2007-02-07 Charles Ying <​charles_ying@yahoo.com>

Reviewed by Adam.

Code suggestion by aroben

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12688

REGRESSION (r19469): ASSERT when right clicking on hyperlinks! in TOT webkit

• WebCoreSupport/WebContextMenuClient.mm: (fixMenusReceivedFromOldClients):

• fixMenusReceivedFromOldClients was hitting an ASSERT incorrectly because it could not match [item title] to any of the contentMenuItemTags using pointer comparison ==. Instead, it needs to do a string comparison between [item title] and the various contentMenuItemTags using isEqualToString instead of ==. You would encounter this whenever the context menu was activated, e.g., from a hyperlink right click (or control click).

9:19 PM Changeset in webkit [22913] by beidson

• 2 edits in branches/WindowsMerge/WebCore

rs=adam

9:12 PM Changeset in webkit [19493] by bdash

• 3 edits
  4 adds in trunk

2007-02-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12608 Incorrect min. width calculation of a series of floats with clear:both and white-space:nowrap

Test: fast/block/float/nowrap-clear-min-width.html

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlineMinMaxWidth):

2007-02-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=12608 Incorrect min. width calculation of a series of floats with clear:both and white-space:nowrap

• fast/block/float/nowrap-clear-min-width-expected.checksum: Added.
• fast/block/float/nowrap-clear-min-width-expected.png: Added.
• fast/block/float/nowrap-clear-min-width-expected.txt: Added.
• fast/block/float/nowrap-clear-min-width.html: Added.

9:10 PM Changeset in webkit [19492] by bdash

• 8 edits
  4 adds in trunk

2007-02-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=10522 REGRESSION: Incomplete repaint after table relayout that decreases height

Test: fast/repaint/intermediate-layout-position.html

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Adjust the old bounds by the layout delta, to get the block's absolute bounds as they were before its ancestors moved it during layout. (WebCore::RenderBlock::collapseMargins): Update the layout delta for the child when moving it. (WebCore::RenderBlock::clearFloatsIfNeeded): Ditto. (WebCore::RenderBlock::determineHorizontalPosition): Ditto. (WebCore::RenderBlock::layoutBlockChildren): Ditto.
• rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Adjust the old bounds by the current layout delta.
• rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout): Ditto.
• rendering/RenderImage.cpp: (WebCore::RenderImage::layout): Ditto.
• rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Ditto.
• rendering/RenderView.h: (WebCore::RenderView::layoutDelta): Added. Keeps track of the offset between the position of the object currently being laid out and its position at the end of the last layout. (WebCore::RenderView::addLayoutDelta): Added.

2007-02-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

• repaint test for ​http://bugs.webkit.org/show_bug.cgi?id=10522 REGRESSION: Incomplete repaint after table relayout that decreases height

• fast/repaint/intermediate-layout-position-expected.checksum: Added.
• fast/repaint/intermediate-layout-position-expected.png: Added.
• fast/repaint/intermediate-layout-position-expected.txt: Added.
• fast/repaint/intermediate-layout-position.html: Added.

9:06 PM Changeset in webkit [19491] by bdash

• 2 edits in trunk/WebCore

2007-02-07 Christopher Brichford <​chrisb@adobe.com>

Reviewed by Brady.

​http://bugs.webkit.org/show_bug.cgi?id=6286
Very large (~500MB) images cause reproducible Safari crash

• loader/CachedImage.cpp: (WebCore::CachedImage::bufferData): Detect failure to create a large Vector<> and call error() when that happens.

8:56 PM Changeset in webkit [19490] by bdash

• 25 edits
  6 adds in trunk

2007-02-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=5399 no-repeat on negatively positioned background images are ignored

Test: fast/backgrounds/repeat/negative-offset-repeat.html

• fix ​http://bugs.webkit.org/show_bug.cgi?id=5821 Changing background of <col> doesn't repaint the column

Test: fast/repaint/table-col-background.html

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11720 REGRESSION: large amounts of CPU consumed viewing this site

• rendering/RenderBox.cpp: (WebCore::RenderBox::imageChanged): Added. Finds the border and/or background layer(s) that use the image and invalidates only the rect in which the image actually paints. There are two special cases in this function: 1) for the body element, the background is propagated to the root; 2) inline flows do a full repaint. (WebCore::RenderBox::calculateBackgroundImageGeometry): Added. Factored out, simplified and corrected the calculation of the rectangle into which the background image paints, the tile size and the pattern phase. (WebCore::RenderBox::paintBackgroundExtended):
• rendering/RenderBox.h:
• rendering/RenderObject.cpp:
• rendering/RenderObject.h: (WebCore::RenderObject::imageChanged): Moved the implementation to RenderBox.
• rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::getAbsoluteRepaintRect): Overridden to return the table's repaint rect. (WebCore::RenderTableCol::imageChanged): Overridden to do a full repaint, which currently repaints the entire table.
• rendering/RenderTableCol.h:
• rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::imageChanged): Overridden to do a full repaint of the row, since the backgrounds are painted by the cells.
• rendering/RenderTableRow.h:
• rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::imageChanged): Overridden to do a full repaint of the section, since the backgrounds are painted by the cells.
• rendering/RenderTableSection.h:

2007-02-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

• pixel test and updated results for ​http://bugs.webkit.org/show_bug.cgi?id=5399 no-repeat on negatively positioned background images are ignored

• repaint test for ​http://bugs.webkit.org/show_bug.cgi?id=5821 Changing background of <col> doesn't repaint the column

• fast/backgrounds/repeat/negative-offset-repeat-expected.checksum: Added.
• fast/backgrounds/repeat/negative-offset-repeat-expected.png: Added.
• fast/backgrounds/repeat/negative-offset-repeat-expected.txt: Added.
• fast/backgrounds/repeat/negative-offset-repeat.html: Added. Based on a test by Mark Rowe.
• fast/backgrounds/repeat/resources/gradient.gif: Added.
• fast/repaint/table-col-background-expected.checksum: Added.
• fast/repaint/table-col-background-expected.png: Added.
• fast/repaint/table-col-background-expected.txt: Added.
• fast/repaint/table-col-background.html: Added.
• tables/mozilla/marvin/backgr_position-table-expected.checksum:
• tables/mozilla/marvin/backgr_position-table-expected.png:
• tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.checksum:
• tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
• tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
• tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
• tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
• tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
• tables/mozilla_expected_failures/marvin/backgr_border-table-expected.checksum:
• tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
• tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
• tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
• tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
• tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
• tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
• tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
• tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.checksum:
• tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
• tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
• tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
• tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum:
• tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
• tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum:
• tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
• tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
• tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:

7:58 PM Changeset in webkit [19489] by darin

• 2 edits in trunk/JavaScriptCore

• JavaScriptCore.vcproj/JavaScriptCore.sln: Reenable testkjs.

7:32 PM Changeset in webkit [22912] by aroben

• 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Rubberstamped by Maciej.

Turn on SafariTheme so we can try it out.

• WebCore.vcproj/WebCore.vcproj:

7:22 PM Changeset in webkit [22911] by andersca

• 3 edits in branches/WindowsMerge/WebKitWin

• WebChromeClient.cpp:
• WebChromeClient.h: Build fix.

7:07 PM Changeset in webkit [19488] by andersca

• 3 edits in trunk/WebKitQt

Try fixing the Qt build.

• WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::shouldInterruptJavaScript):
• WebCoreSupport/ChromeClientQt.h:

7:05 PM Changeset in webkit [19487] by andersca

• 14 edits in trunk

WebCore:

Reviewed by Maciej.

Move shouldInterruptJavaScript to the Chrome.

• bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::shouldInterruptScript):
• page/Chrome.cpp: (WebCore::Chrome::shouldInterruptJavaScript):
• page/Chrome.h:
• page/ChromeClient.h:
• page/Frame.h:
• page/mac/FrameMac.h:
• page/mac/FrameMac.mm:
• page/mac/WebCoreFrameBridge.h:
• platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::shouldInterruptJavaScript):

WebKit:

Reviewed by Maciej.

Move shouldInterruptJavaScript to the Chrome.

• WebCoreSupport/WebChromeClient.h:
• WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldInterruptJavaScript):
• WebCoreSupport/WebFrameBridge.mm:

6:46 PM Changeset in webkit [22910] by aroben

• 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adele.

6:20 PM Changeset in webkit [19486] by darin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• <rdar://problem/4826861> WebKit tests show memory leaks in NSHTMLReader, caused by method named "hash"

• bindings/scripts/CodeGeneratorObjC.pm: Added a list of method names we should never use, since they are in base classes WebScriptObject and NSObject. Luckily, only "hash" is causing trouble. Added "hash" to the existing special case for "id". Now "hash" is "hashName" just as "id" is "idName".

5:35 PM Changeset in webkit [19485] by sullivan

• 4 edits in trunk/WebKit

Reviewed by Kevin Decker

• fixed all places in WebKit where _web_userVisibleString was used where _web_originalDataAsString should have been used instead.

• History/WebURLsWithTitles.m: (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): use _web_originalDataAsString when writing since these aren't displayed to the user (+[WebURLsWithTitles URLsFromPasteboard:]): use _web_URLWithDataAsString when reading, to match what we used when writing

• Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writeURL:andTitle:types:]): use _web_originalDataAsString when writing the NSURL type; continue using _web_userVisibleString when writing the plain text type

• WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentWithPaths:]): added comment about why _web_userVisibleString is appropriate here (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): use _web_originalDataAsString when setting the href attribute of an anchor tag

5:29 PM Changeset in webkit [19484] by harrison

• 2 edits in trunk/WebKit

Reviewed by Adam.

<rdar://problem/4943650> REGRESSION: insertion point blink redraws entire web page, making everything slow

Problem is that AppKit recently changed NSControl to trigger a full redraw if the control has a focus ring.
WebHTMLView is a subclass of NSControl, but the focus ring type was the default value, though we actually
draw no focus ring. Fix is to formally set our focus ring type.

• WebView/WebHTMLView.mm: (-[WebHTMLView initWithFrame:]): Send [self setFocusRingType:NSFocusRingTypeNone].

4:49 PM Changeset in webkit [19483] by sullivan

• 2 edits in trunk/WebKit

Undid changes that I hadn't intended to check in

• WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentWithPaths:]): (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]):

4:41 PM Changeset in webkit [19482] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Ollie and Geoff

• fixed <rdar://problem/4982345> KURL::createCFURL leak inside -[WebFrameBridge startDraggingImage...] reported by buildbot

(-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
don't retain the imageURL we pass to the drag controller -- it's just automagically
converted to a KURL anyway

3:09 PM Changeset in webkit [19481] by kjk

• 4 edits in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes for graphics-related stuff.

• platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::checkForSolidColor):
• platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::setData):
• platform/graphics/gdk/ImageGdk.cpp: (WebCore::BitmapImage::initPlatformData): (WebCore::BitmapImage::invalidatePlatformData): (WebCore::Image::loadPlatformResource): (WebCore::Image::drawPattern):

2:54 PM Changeset in webkit [19480] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Darin

• fixed <rdar://problem/4974420> REGRESSION: Dragging a saved image into the browser window displays a error (No File exists at the address "null") (12662)

• WebCoreSupport/WebPasteboardHelper.mm: (WebPasteboardHelper::urlFromPasteboard): use _web_originalDataAsString instead of _web_userVisibleString, since _web_userVisibleString can return a string with non-ASCII characters -- suitable for display but not for code

2:35 PM Changeset in webkit [19479] by kjk

• 5 edits in trunk/WebCore

Reviewed by Maciej.

Linux/gdk build fixes related to networking.

• platform/network/ResourceHandleInternal.h: Add accessor for m_client. (WebCore::ResourceHandleInternal::client):
• platform/network/gdk/ResourceHandleCurl.cpp: Add missing functions and massage for changed APIs. (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::bufferedData): (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::setDefersLoading):
• platform/network/gdk/ResourceHandleManager.cpp: Rename get() to sharedInstance(). Massaged for changed APIs. (WebCore::ResourceHandleManager::sharedInstance): (WebCore::writeCallback): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::remove):
• platform/network/gdk/ResourceHandleManager.h: Ditto.

2:16 PM Changeset in webkit [19478] by kjk

• 2 edits in trunk/WebCore

Reviewed by Maciej.

Mismatched type of alloc/free function crashes gdk build.

• platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::close):

2:11 PM Changeset in webkit [19477] by kjk

• 2 edits
  1 copy in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes - add file based on qt implementation.

• platform/DragData.h:
• platform/gdk/DragDataGdk.cpp: Added.

1:53 PM Changeset in webkit [19476] by kjk

• 1 edit
  2 copies
  1 add in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes - add new files based on qt implementation.

• page/gdk/DragControllerGdk.cpp: Added. (WebCore::DragController::dragOperation):
• page/gdk/EventHandlerGdk.cpp: Added. (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::eventActivatedView):

1:32 PM Changeset in webkit [19475] by kjk

• 1 edit
  3 copies
  1 add in trunk/WebCore

Reviewed by Adam Roben.

Linux/gdk build fixes - add new files based on Qt implementation.

• loader/gdk/DocumentLoaderGdk.cpp: Added. (WebCore::DocumentLoader::getResponseModifiedHeader):
• loader/gdk/FrameLoaderClientGdk.cpp: Added. (WebCore::FrameLoaderClientGdk::FrameLoaderClientGdk): (WebCore::FrameLoaderClientGdk::frame): (WebCore::FrameLoaderClientGdk::userAgent): (WebCore::FrameLoaderClientGdk::createDocumentLoader): (WebCore::FrameLoaderClientGdk::dispatchWillSubmitForm): (WebCore::FrameLoaderClientGdk::committedLoad): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveAuthenticationChallenge): (WebCore::FrameLoaderClientGdk::dispatchDidCancelAuthenticationChallenge): (WebCore::FrameLoaderClientGdk::dispatchWillSendRequest): (WebCore::FrameLoaderClientGdk::assignIdentifierToInitialRequest): (WebCore::FrameLoaderClientGdk::postProgressStartedNotification): (WebCore::FrameLoaderClientGdk::postProgressEstimateChangedNotification): (WebCore::FrameLoaderClientGdk::postProgressFinishedNotification): (WebCore::FrameLoaderClientGdk::frameLoaderDestroyed): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveResponse): (WebCore::FrameLoaderClientGdk::dispatchDecidePolicyForMIMEType): (WebCore::FrameLoaderClientGdk::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientGdk::dispatchDecidePolicyForNavigationAction): (WebCore::FrameLoaderClientGdk::createPlugin): (WebCore::FrameLoaderClientGdk::createFrame): (WebCore::FrameLoaderClientGdk::redirectDataToPlugin): (WebCore::FrameLoaderClientGdk::createJavaAppletWidget): (WebCore::FrameLoaderClientGdk::objectContentType): (WebCore::FrameLoaderClientGdk::overrideMediaType): (WebCore::FrameLoaderClientGdk::windowObjectCleared): (WebCore::FrameLoaderClientGdk::setMainFrameDocumentReady): (WebCore::FrameLoaderClientGdk::hasWebView): (WebCore::FrameLoaderClientGdk::hasFrameView): (WebCore::FrameLoaderClientGdk::dispatchDidFinishLoad): (WebCore::FrameLoaderClientGdk::frameLoadCompleted): (WebCore::FrameLoaderClientGdk::privateBrowsingEnabled): (WebCore::FrameLoaderClientGdk::makeDocumentView): (WebCore::FrameLoaderClientGdk::makeRepresentation): (WebCore::FrameLoaderClientGdk::forceLayout): (WebCore::FrameLoaderClientGdk::forceLayoutForNonHTML): (WebCore::FrameLoaderClientGdk::setCopiesOnScroll): (WebCore::FrameLoaderClientGdk::detachedFromParent1): (WebCore::FrameLoaderClientGdk::detachedFromParent2): (WebCore::FrameLoaderClientGdk::detachedFromParent3): (WebCore::FrameLoaderClientGdk::detachedFromParent4): (WebCore::FrameLoaderClientGdk::loadedFromPageCache): (WebCore::FrameLoaderClientGdk::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientGdk::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientGdk::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientGdk::dispatchWillClose): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientGdk::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientGdk::dispatchDidCommitLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFinishDocumentLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFirstLayout): (WebCore::FrameLoaderClientGdk::dispatchShow): (WebCore::FrameLoaderClientGdk::cancelPolicyCheck): (WebCore::FrameLoaderClientGdk::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientGdk::revertToProvisionalState): (WebCore::FrameLoaderClientGdk::clearUnarchivingState): (WebCore::FrameLoaderClientGdk::willChangeTitle): (WebCore::FrameLoaderClientGdk::didChangeTitle): (WebCore::FrameLoaderClientGdk::finishedLoading): (WebCore::FrameLoaderClientGdk::finalSetupForReplace): (WebCore::FrameLoaderClientGdk::setDefersLoading): (WebCore::FrameLoaderClientGdk::isArchiveLoadPending): (WebCore::FrameLoaderClientGdk::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientGdk::clearArchivedResources): (WebCore::FrameLoaderClientGdk::canHandleRequest): (WebCore::FrameLoaderClientGdk::canShowMIMEType): (WebCore::FrameLoaderClientGdk::representationExistsForURLScheme): (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientGdk::restoreScrollPositionAndViewState): (WebCore::FrameLoaderClientGdk::provisionalLoadStarted): (WebCore::FrameLoaderClientGdk::didFinishLoad): (WebCore::FrameLoaderClientGdk::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientGdk::setTitle): (WebCore::FrameLoaderClientGdk::setDocumentViewFromPageCache): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveContentLength): (WebCore::FrameLoaderClientGdk::dispatchDidFinishLoading): (WebCore::FrameLoaderClientGdk::dispatchDidFailLoading): (WebCore::FrameLoaderClientGdk::dispatchDidLoadResourceFromMemoryCache): (WebCore::FrameLoaderClientGdk::dispatchDidFailProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFailLoad): (WebCore::FrameLoaderClientGdk::download): (WebCore::FrameLoaderClientGdk::cancelledError): (WebCore::FrameLoaderClientGdk::cannotShowURLError): (WebCore::FrameLoaderClientGdk::interruptForPolicyChangeError): (WebCore::FrameLoaderClientGdk::cannotShowMIMETypeError): (WebCore::FrameLoaderClientGdk::fileDoesNotExistError): (WebCore::FrameLoaderClientGdk::shouldFallBack): (WebCore::FrameLoaderClientGdk::willUseArchive): (WebCore::FrameLoaderClientGdk::saveScrollPositionAndViewStateToItem): (WebCore::FrameLoaderClientGdk::saveDocumentViewToPageCache): (WebCore::FrameLoaderClientGdk::canCachePage): (WebCore::FrameLoaderClientGdk::dispatchCreatePage): (WebCore::FrameLoaderClientGdk::dispatchUnableToImplementPolicy): (WebCore::FrameLoaderClientGdk::setMainDocumentError): (WebCore::FrameLoaderClientGdk::startDownload): (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForStandardLoad): (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForReload): (WebCore::FrameLoaderClientGdk::shouldGoToHistoryItem):
• loader/gdk/FrameLoaderClientGdk.h: Added. (WebCore::FrameLoaderClientGdk::~FrameLoaderClientGdk): (WebCore::FrameLoaderClientGdk::setFrame):

12:52 PM Changeset in webkit [19474] by kjk

• 4 edits in trunk/WebCore

Reviewed by Maciej.

Linux/gdk fixes related to fonts.

• platform/gdk/FontDataGdk.cpp: (WebCore::FontData::platformInit): remove a work-around for older cairo versions since Ubuntu 6.10 ships with cairo that is new enough
• platform/gdk/FontGdk.cpp: (WebCore::Font::drawGlyphs):
• platform/gdk/FontPlatformDataGdk.cpp: Remove unused variables. (WebCore::FontPlatformData::FontPlatformData):

12:15 PM Changeset in webkit [19473] by ap

• 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12582
REGRESSION: Unclosed <title> makes the window display garbage or empty title

Automatic testing is not possible, and manual testing probably doesn't make sense.

• loader/DocumentLoader.cpp: (WebCore::canonicalizedTitle): Bail out early if the passed in string is all whitespace.

12:08 PM Changeset in webkit [19472] by brmorris

• 2 edits in S60/branches/3.1m/WebCore

yadavall, Reviewed by Zalan

DESC: Unclosed object tag causing problem MPAK-6XC86M
​http://bugs.webkit.org/show_bug.cgi?id=12680

12:02 PM Changeset in webkit [19471] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

• another build fix; this time for sure

• pcre/pcre_exec.c: (match): The compiler caught an incorrect use of the othercase variable across a call to RMATCH in character repeat processing. Local variables can change in the crazy NO_RECURSE mode that we use, so we instead need the value in othercase to be in one of the special stack frame variables. Added a new stack frame variable for this purpose named repeat_othercase. Also noted a similar error in the non-UTF-16 side of the #ifdef, but didn't try to fix that one. Also removed a SUPPORT_UCP #ifdef from the PCRE_UTF16 side; that code doesn't work without the Unicde properties table, and we don't try to use it that way.

11:49 AM Changeset in webkit [19470] by andersca

• 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/4977952>
REGRESSION: Yahoo Messenger IM is totally blank

• loader/FrameLoader.cpp: (WebCore::FrameLoader::checkContentPolicy): Don't ask the policy delegate for content that has valid substitute data.

(WebCore::FrameLoader::checkNavigationPolicy):
If the loader has substitute data but doesn't have an unreachable URL, let the policy
delegate decide what to do.

11:48 AM Changeset in webkit [19469] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Darin

• added some clarity to some menu-handling shenanigans

• WebCoreSupport/WebContextMenuClient.mm: (fixMenusToSendToOldClients): renamed from fixMenusForOldClients; added comments, FIXME, and assertion (fixMenusReceivedFromOldClients): renamed from fixMenusFromOldClients; added comments, FIXME, and assertion (WebContextMenuClient::getCustomMenuFromDefaultItems): updated for name changes

11:46 AM Changeset in webkit [19468] by ggaren

• 4 edits in trunk/WebCore

Reviewed by Darin Adler.

Restoring some of the functionality I removed in r19445. It's insufficient for
each page to cancel keepAlive only for its child frames, because a frame
can be removed from the page before we get a chance to cancel its keepAlive.
So, the page destructor has to cancel keepAlive for all frames. This is safe
because we prohibit closing a WebView while JavaScript is executing.

• page/Frame.cpp: (WebCore::keepAliveSet): (WebCore::Frame::keepAlive): (WebCore::Frame::cancelAllKeepAlive): (WebCore::Frame::lifeSupportTimerFired):
• page/Frame.h:
• page/Page.cpp: (WebCore::Page::~Page):

10:58 AM Changeset in webkit [19467] by ap

• 5 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12603
A crash when trying to use XPath functions normalize-space(), string-length() and number()

Test: fast/xpath/implicit-node-args.html

• xml/XPathFunctions.cpp: (WebCore::XPath::FunNumber::doEvaluate): Implemented zero parameter case. (WebCore::XPath::FunctionMapping::): Corrected descriptions of these functions, as they do allow zero parameters. (WebCore::XPath::createFunction): Combined the two failure cases to ensure that this function never returns 0.

8:11 AM Changeset in webkit [19466] by brmorris

• 2 edits in S60/branches/3.1m/WebKit

bujtas, reviewed by yngjun.

DESC: Highlighting lost when browser toolbar is dismissed TMCN-6XWLEC

Toolbar consumes the keyrelease event and the webcore gets stuck in a keypressed state.
fix: send keyrelease event to the webcore

​http://bugs.webkit.org/show_bug.cgi?id=12642

8:06 AM Changeset in webkit [19465] by zack

• 2 edits in trunk/WebCore

Fix compilation of the Qt code.

8:04 AM Changeset in webkit [19464] by brmorris

• 2 edits in S60/branches/3.1m/WebKit

rathnasa, reviewed by Zalan Bujtas.

DESC: [S60] EMGH-6XTG9Y: Browser: Bookmarks with an URL containing spaces do not work
​http://bugs.webkit.org/show_bug.cgi?id=12635

Feb 6, 2007:

11:41 PM Changeset in webkit [22909] by aliceli1

• 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Maciej.

Fix for <rdar://4973323> PageUp/PageDown don't move the caret in textareas

• WebView.cpp: (WebView::keyDown): added key entry for function to scroll by page and move caret in scrolling editable regions

11:40 PM Changeset in webkit [19463] by aliceli1

• 2 edits in trunk/WebCore

Reviewed by Maciej.

Added editing command functions for scrolling by page and moving the caret

• editing/Editor.cpp: (WebCore::execMoveUpByPageAndModifyCaret): (WebCore::execMoveDownByPageAndModifyCaret): (WebCore::CommandEntry::):

10:59 PM Changeset in webkit [19462] by ggaren

• 2 edits in trunk/WebKitTools

Reviewed by Beth Dakin, evil twin to Bethany P. Dakin.

Ignore known leaks in CFRunLoop. Exclude THRD leaks by type so that we can
catch all reports of them, not just those inside pthread_create.

Also, use "
" instead of "\" because we need the actual \ to get into the
regexp string if it's going to do any escaping. (Oops!)

• Scripts/run-webkit-tests:

10:18 PM Changeset in webkit [19461] by ggaren

• 2 edits in trunk/WebKitTools

Reviewed by Bethany P. Dakin.

The 's' is optional when the leaks tool reports 'leaks'.

• Scripts/run-leaks:

9:45 PM Changeset in webkit [19460] by ggaren

• 3 edits in trunk/WebKitTools

Reviewed by Bethany P. Dakin.

Hooked up run-webkit-tests to the run-leaks script. No change in behavior yet.

• Scripts/run-webkit-tests: Changed symbol names to valid regular expressions.

8:27 PM Changeset in webkit [19459] by justing

• 1 add
  1 delete in trunk/LayoutTests/fast/forms

Re-enabling this test. It doesn't seem to be failing for me (or the buildbot) afterall.

7:50 PM Changeset in webkit [19458] by kdecker

• 3 edits in trunk/WebKit

Fixed: <rdar://problem/4976681> ASSERTION failure on quit @ talkcrunch.com in _NPN_ReleaseObject

Reviewed by Anders.

• Plugins/WebPluginDatabase.m: (+[WebPluginDatabase sharedDatabase]): Removed NSApplicationWillTerminateNotification observer and thus also removed code that would unload the entire plug-in database when receiving that notification.

The bug here was that this notification callback would happen first before anything else thus unloading
plug-ins and releasing plug-in memory. That was crash prone because the JavaScriptCore collector would at
a later time attempt to release its CInstance references (references that point to plug-in memory)
without knowing WebKit already unloaded the plug-in out from underneath it. The WebPluginDatabase simply
does not have enough context to make this decision.

• WebView/WebView.mm: Added two statics: applicationIsTerminating, pluginDatabaseClientCount. (+[WebView initialize]): Added NSApplicationWillTerminateNotification observer. (+[WebView _applicationWillTerminate]): Added. (-[WebView _close]): WebKit has both a global plug-in database and a separate, per WebView plug-in database. We need to release both sets of plug-ins because Netscape plug-ins have "destructor functions" that should be called when the browser unloads the plug-in. These functions can do important things, such as closing/deleting files so it is important to ensure that they are properly called when the application terminates.

The new change is that on app shutdown, we unload WebKit's global plug-in database if and only if the last WebView
was closed. To do so otherwise would unload plug-ins out from underneath other WebViews.

7:36 PM Changeset in webkit [19457] by brmorris

• 2 edits in S60/trunk/WebCore

yaharon, reviewed by zalan. merged to s60/trunk by brad.

DESC: [S60] BrowserNG: Betsson.com crash (MLIO-6XWP2K)
​http://bugs.webkit.org/show_bug.cgi?id=12641

7:33 PM Changeset in webkit [19456] by brmorris

• 2 edits in S60/branches/3.1m/WebCore

yaharon, reviewed by zalan.

DESC: [S60] BrowserNG: Betsson.com crash (MLIO-6XWP2K)
​http://bugs.webkit.org/show_bug.cgi?id=12641

7:19 PM Changeset in webkit [19455] by brmorris

• 2 edits in S60/trunk/S60Tools

brmorris, reviewed by sasha

DESC: small update to s60tools\prepare-changelog as r19440 accidentally bumped the Perl version :/

• prepare-ChangeLog.bat:

7:12 PM Changeset in webkit [22908] by sfalken

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

7:12 PM Changeset in webkit [19454] by sfalken

• 1 copy in tags/Safari-521.34.1b

New tag.

6:57 PM Changeset in webkit [19453] by justing

• 1 add
  1 delete in trunk/LayoutTests/fast/forms

Disabling this test while I investigate its failure.

6:40 PM Changeset in webkit [19452] by justing

• 22 edits
  4 adds in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4922367>
WebView selectLine: followed by deleteBackward: deletes TABLE element of following line

Added:

• editing/deleting/4922367-expected.checksum: Added.
• editing/deleting/4922367-expected.png: Added.
• editing/deleting/4922367-expected.txt: Added.
• editing/deleting/4922367.html: Added.

Fixed:

• editing/deleting/delete-block-table-expected.txt:
• editing/deleting/delete-select-all-001-expected.txt:
• editing/deleting/delete-to-select-table-expected.txt:
• editing/inserting/insert-paragraph-02-expected.txt:
• editing/pasteboard/4641033-expected.txt:
• editing/pasteboard/paste-table-001-expected.txt:
• editing/pasteboard/select-element-1-expected.txt:
• editing/selection/3690719-expected.txt:
• editing/selection/7152-1-expected.txt:
• editing/selection/7152-2-expected.txt:
• editing/selection/click-before-and-after-table-expected.txt:
• editing/selection/replaced-boundaries-3-expected.txt:
• editing/style/apple-style-editable-mix-expected.txt:
• editing/unsupported-content/table-delete-001-expected.txt:
• editing/unsupported-content/table-type-after-expected.txt:
• editing/unsupported-content/table-type-before-expected.txt:

WebCore:

Reviewed by john

<rdar://problem/4922367>
WebView selectLine: followed by deleteBackward: deletes TABLE element of following line

• editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::doApply): Don't ASSERT when manipulating non-editable content that is embedded in editable content. We'll do this kind of manipulation when removing redundant style spans after pasting content that has non-editable pieces.
• editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply): Ditto.
• editing/htmlediting.cpp: (WebCore::isContentEditable): Added, wrapper for Node::isContentEditable (WebCore::rangeCompliantEquivalent): Although legal, [{table, select, etc.}, {0, numChildren}] don't refer to children of the element, but positions before and after the element. So, rangeCompliantEquivalent is really responsible for converting illegal positions *and* legal positions that have a special meaning internally.
• editing/htmlediting.h:

5:57 PM Changeset in webkit [19451] by andersca

• 2 edits in trunk/WebCore

Reviewed by Brady.

• platform/String.cpp: (WebCore::String::ascii): Fix dumping null Strings.

4:28 PM Changeset in webkit [19450] by andersca

• 2 edits in trunk/WebCore

Reviewed by Geoff.

Fix <rdar://problem/4979484>

• css/CSSPrimitiveValue.cpp: (WebCore::isCSSTokenizerIdentifier): Do the range check before calling isalpha or isalnum.

3:55 PM Changeset in webkit [19449] by darin

• 3 edits in trunk/WebKit

Reviewed by John Sullivan.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11080 <rdar://problem/4826648> REGRESSION: Incorrect vertical positioning of Safari status bar text containing @ character (11080)

• Misc/WebKitNSStringExtras.m: (canUseFastRenderer): Fix code that mistakenly used the slow renderer for strings that have a direction of "other neutral", which includes the "@" character. (-[NSString _web_drawAtPoint:font:textColor:]): Add code to make the baseline of the text in the status bar right. AppKit's rule for rounding is complicated enough that this is obviously not perfectly correct, but it does make both code paths use the same baseline in all the places this is currently used in AppKit.

3:38 PM Changeset in webkit [19448] by weinig

• 2 edits in trunk/LayoutTests

Reviewed by Mark.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12640 run-webkit-tests --pixel hangs because svg/custom/use-elementInstance-event-target-expected.png is a render tree dump instead of an image

• svg/custom/use-elementInstance-event-target-expected.png:

3:35 PM Changeset in webkit [19447] by weinig

• 2 edits in trunk/WebKitTools

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12566
[Drosera] Console history fixups

• Drosera/console.js: assorted cleanups and fixes

3:31 PM Changeset in webkit [19446] by sfalken

• 2 edits in trunk/JavaScriptCore

2007-02-06 Steve Falkenburg <​sfalken@apple.com>

Disable testkjs in sln until we figure out mysterious compiler warning.

• JavaScriptCore.vcproj/JavaScriptCore.sln:

2:57 PM Changeset in webkit [19445] by ggaren

• 4 edits in trunk/WebCore

Reviewed by Darin Adler.

Fixed Frame/RenderObject/Node leak report seen while running SVG image tests.
(We'll need this fix if we ever re-enable SVG image.)

The extra reference belonged to the Frame keepAlive timer (so this was
not a "real" leak, in the end). The Page destructor has code to cancel all
Frame keepAlive timers upon the destruction of the last Page, but an SVG
image puts a Page within a Page, making this condition impossible to meet.

The fix here is to have each individual page cancel the keepAlive timers
belonging to its child frames.

• page/Frame.cpp: Changed the FrameCounter to use WTF logging. (WebCore::): Nixed the lifeSupportSet, since it's no longer used. (WebCore::Frame::cancelKeepAlive): Renamed from "endLifeSupport" to match the name "keepAlive".
• page/Page.cpp: (WebCore::Page::~Page): Made each page cancel its child keepAlive timers and clear its mainFrame, since we may never reach the condition of having 0 Pages.

2:38 PM Changeset in webkit [19444] by sfalken

• 2 edits in trunk/JavaScriptCore

2007-02-06 Steve Falkenburg <​sfalken@apple.com>

Build fix by ggaren

• pcre/pcre_exec.c: (match):

2:36 PM Changeset in webkit [22907] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Brady.

Updated for log channel rename.

• platform/win/GDIObjectCounter.cpp: (WebCore::GDIObjectCounter::~GDIObjectCounter):

2:35 PM Changeset in webkit [19443] by aroben

• 3 edits in trunk/WebCore

Rubberstamped by Brady.

Revert the log channel constants to their old values for all you pretty
people out there who were using the old ones. I also renamed
LogResources to LogPlatformLeaks to be a bit more specific.

• platform/Logging.cpp: (WebCore::):
• platform/Logging.h:

2:28 PM Changeset in webkit [19442] by justing

• 1 edit in trunk/WebCore/editing/htmlediting.cpp

Backing out some changes I accidently checked in.

2:17 PM Changeset in webkit [19441] by justing

• 8 edits
  4 adds in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4959067>
Bullets get erased or moved down to another line
<rdar://problem/4912529>
Seed: Bulleted list in Note in Mail.app does not work with Japanese input mode

• editing/inserting/4959067-expected.checksum: Added.
• editing/inserting/4959067-expected.png: Added.
• editing/inserting/4959067-expected.txt: Added.
• editing/inserting/4959067.html: Added.

WebCore:

Reviewed by john

<rdar://problem/4959067>
Bullets get erased or moved down to another line
<rdar://problem/4912529>
Seed: Bulleted list in Note in Mail.app does not work with Japanese input mode

Do not expand the selection to include fully selected
special elements when insering text over a selection.

• editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteSelection): Pass expandForSpecialElements through to DeleteSelectionCommand's constructor. (WebCore::CompositeEditCommand::moveParagraphs): Use the convenience function.
• editing/CompositeEditCommand.h:
• editing/DeleteSelectionCommand.h:
• editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Do not expand the selection to be deleted for special elements.
• editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Added a FIXME about when we should expand the selection.

2:03 PM Changeset in webkit [19440] by brmorris

• 16 edits in S60/trunk

brmorris <​bradley.morrison@nokia.com>, rs'd by zalan

DESC: merge from s60/branches/3.1m to s60/trunk of r19429, r19430, r19431, r19432 and r19433

2:01 PM Changeset in webkit [19439] by darin

• 2 edits in trunk/WebKit

Spotted by Steve F.

• Misc/WebNSURLExtras.m: (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Fix obvious logic mistake I introduced back in revision 8255. I can't see how to exercise this code path, but I also can't bear to leave this obviously-broken code as-is.

1:55 PM Changeset in webkit [19438] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

• fix <rdar://problem/4979089> PCRE should avoid setjmp/longjmp even when compiler is not GCC

Added a new code path that's slower and way uglier but doesn't rely on GCC's
computed gotos.

• pcre/pcre_exec.c: Added a numeric parameter to the RMATCH function. It must be different at every RMATCH call site. Changed the non-GCC NO_RECURSE version of the macro to use a label incorporating the number. Changed the RRETURN macro to use a goto instead of longjmp. (match): Added a different number at each callsite, using a perl script for the first-time task. Going forward it should be easy to maintain by hand. Added a switch statement at the bottom of the function. We'll get compile time errors if we have anything in the switch statement that's never used in an RMATCH, but errors in the other direction are silent except at runtime.

1:26 PM Changeset in webkit [19437] by ggaren

• 2 edits
  1 move in trunk/LayoutTests

At Darin's request, checked in new (failing) results instead of disabling test.

• fast/images/svg-as-image-expected.txt:

1:21 PM Changeset in webkit [22906] by andersca

• 3 edits in branches/WindowsMerge/WebKitTools

Reviewed by Darin and Geoff.

• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Call OleInitialize.

(runTest):
Use CF for creating the URLs passed in.

(initializePreferences):
Don't autosave the preferences.

(main):

• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Link with CF.

1:14 PM Changeset in webkit [19436] by ggaren

• 3 edits
  1 move in trunk

LayoutTests:

Reviewed by Anders Carlsson.

Disabled support for SVG image because it crashes all the time.

• fast/images/svg-as-image.html: Removed.
• fast/images/svg-as-image.html-disabled: Moved to here.

WebCore:

Reviewed by Anders Carlsson.

Disabled support for SVG image because it crashes all the time.

• loader/CachedImage.cpp: (WebCore::CachedImage::createImage):

12:58 PM Changeset in webkit [22905] by adele

• 4 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adam.

Added support for radio buttons and checkboxes.

12:26 PM Changeset in webkit [19435] by ap

• 3 edits
  2 adds in trunk

2007-02-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12518 Betsson.com crashes browser

Test: fast/layers/generated-layer-scrollbar-crash.html

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Changed element()->document() to document() to work with anonymous objects. (WebCore::RenderLayer::updateOverflowStatus): Ditto.

11:42 AM Changeset in webkit [19434] by darin

• 4 edits
  1 add in trunk/JavaScriptCore

Reviewed by John.

• fix <rdar://problem/4687840> 9A241: JavaScript RegExp 25-30x slower than on 10.4.7

I used Shark to figure out what to do. The test case is now 15% faster than with
stock Safari. Some other regular expression cases might still be a few % slower
than before, but the >10x slowdown is now completely gone.

1) Fix slowness caused by setjmp/longjmp by using computed goto instead.

Use GCC extensions - locally declared labels, labels as values, and computed goto -
instead of using setjmp/longjmp to implemement non-recursive version of the regular
expression system. We could probably make this even faster if we reduced the use
of malloc a bit too.

2) Fix slowness caused by allocating heapframe objects by allocating the first

16 of them from the stack.

3) Speed up use of malloc and free in PCRE by making it use fastMalloc and fastFree.

4) Speed up the test case by adding a special case to a UString function.

5) Made a small improvement to the innermost hottest loop of match by hoisting

the conversion from int to pcre_uchar out of the loop.

• JavaScriptCore.xcodeproj/project.pbxproj: Compile FastMallocPCRE.cpp, and don't compile pcre_globals.c.

• wtf/FastMallocPCRE.cpp: Added. A copy of pcre_globals.c that uses FastMalloc.h. This is better than code that sets the PCRE allocation globals because by doing it this way there's guaranteed to be no problem with order of initialization.

• kjs/ustring.cpp: (KJS::UString::spliceSubstringsWithSeparators): Add a fast special case when this is called for only one subrange and no seaprators. This was happening a lot in the test case and it seems quite reasonable to optimize this.

• pcre/pcre_exec.c: Create a copy of the RMATCH and RRETURN macros that use goto instead of setjmp/longjmp. Change code that calls pcre_stack_malloc to first use storage on the stack inside the match function. (match): Move initialization of utf8 up a couple lines to avoid "possibly used uninitialized" warning. Use a local variable so we compare with pcre_uchar instead of with int inside the inner "find a character" loop.

9:17 AM Changeset in webkit [19433] by brmorris

• 2 edits in S60/branches/3.1m/WebCore

w3liu, Reviewed by Yongjun Zhang <​yongjun.zhang@nokia.com>

DESC: Should check meta for charset if meta exists EHSN-6UQ6CM
​http://bugs.webkit.org/show_bug.cgi?id=12225

8:50 AM Changeset in webkit [19432] by brmorris

• 4 edits in S60/branches/3.1m/WebKit

yaharon, Reviewed by Yongjun.

DESC: [S60] OSS Browser crashes when accessing cnn.com, yahoo.com with Load images & sounds turned off.(SLON-6XY8JM )
​http://bugs.webkit.org/show_bug.cgi?id=12622

8:46 AM Changeset in webkit [19431] by brmorris

• 4 edits in S60/branches/3.1m

yongjzha, Reviewed by Zalan.

DESC: enable drawing 1px transparent image with EGray256 mask
​http://bugs.webkit.org/show_bug.cgi?id=12621

8:41 AM Changeset in webkit [19430] by brmorris

• 7 edits in S60/branches/3.1m

vbradley, reviewed by Yongjun.

DESC: Fixed the stack size and pcre stack overflow ALAA-6XSF7U
Limit the number recursions that are allowed in match().
​http://bugs.webkit.org/show_bug.cgi?id=12611

8:34 AM Changeset in webkit [19429] by brmorris

• 3 edits in S60/branches/3.1m/WebKit

bujtas, reviewed by yongjun.

DESC: closing the window while the page is loading still crashes the browser TMCN-6XRQP2
fix: do not let new transactions get sumbited while cancel is in progress

8:30 AM Changeset in webkit [19428] by brmorris

• 2 edits in S60/branches/3.1m/WebKit

winship, reviewed by yongjun

DESC: MLIO-6XGEMQ BrowserNG: Toolbar positioned out of screen after closing PDA
​http://bugs.webkit.org/show_bug.cgi?id=12544

7:34 AM Changeset in webkit [19427] by eseidel

• 13 edits in trunk

2007-02-06 Eric Seidel <​eric@webkit.org>

Reviewed by mitz.

WebKit ignores floating point values for stroke-miterlimit
​http://bugs.webkit.org/show_bug.cgi?id=12577

Test: svg/W3C-SVG-1.1/painting-stroke-07-t.svg

• ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
• ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
• ksvg2/css/SVGRenderStyle.h:
• ksvg2/css/SVGRenderStyleDefs.h: (WebCore::StyleStrokeData::operator!=):

1:08 AM Changeset in webkit [22904] by aroben

• 5 edits
  2 adds in branches/WindowsMerge

WebCoreWin:

Reviewed by Ada and Oliver.

Add a GDIObjectCounter class that informs us of GDI leaks.

• WebCore.vcproj/WebCore.vcproj: Added new files.
• platform/win/GDIObjectCounter.cpp: Added. (WebCore::GDIObjectCounter::GDIObjectCounter): (WebCore::GDIObjectCounter::init): (WebCore::GDIObjectCounter::~GDIObjectCounter): (WebCore::GDIObjectCounter::currentGDIObjectsInUse):
• platform/win/GDIObjectCounter.h: Added.

WebKitWin:

Reviewed by Ada and Oliver.

Add some GDI object logging to help catch leaks.

• WebFrame.cpp: (WebFrame::layoutIfNeeded):
• WebView.cpp: (WebView::addToDirtyRegion): (WebView::scrollBackingStore): (WebView::updateBackingStore): (WebView::paint): (WebView::paintIntoBackingStore): (WebView::paintIntoWindow):

1:07 AM Changeset in webkit [19426] by aroben

• 3 edits in trunk/WebCore

Reviewed by Ada and Oliver.

Adding a new LogResources channel for tracking platform resource usage.

• platform/Logging.cpp: Added new channel, cleaned up constants to be more readable.
• platform/Logging.h: Declare new channel.

Feb 5, 2007:

11:52 PM Changeset in webkit [22903] by beidson

• 4 edits in branches/WindowsMerge/WebKitWin

Add config.h to some .cpps

9:43 PM Changeset in webkit [19425] by ap

• 4 edits
  2 adds in trunk

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=12619
Non-abbreviated XPaths don't work

Test: fast/xpath/ancestor-axis.html

• xml/XPathParser.cpp: (WebCore::XPath::Parser::lex): Fix axis name parsing to actually work.
• xml/XPathStep.cpp: (WebCore::XPath::Step::nodeTestMatches): Fix "*" node test to actually work.

8:10 PM Changeset in webkit [19424] by brmorris

• 5 edits in S60/trunk/WebKit

bujtas, reviewed by Yongjun.

DESC: PartialImage() can end up in a dialog box which starts up a nested active scheduler JELE-6XSH3P

and since the page still being loaded in the background new image
data could come to the image decoder. that's a fatal re-entry on
the image decoder.

​http://bugs.webkit.org/show_bug.cgi?id=12550

7:55 PM Changeset in webkit [19423] by brmorris

• 5 edits in S60/branches/3.1m/WebKit

bujtas, reviewed by Yongjun.

DESC: PartialImage() can end up in a dialog box which starts up a nested active scheduler JELE-6XSH3P
​http://bugs.webkit.org/show_bug.cgi?id=12550

7:43 PM Changeset in webkit [19422] by ddkilzer

• 5 edits in trunk

LayoutTests:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=7266
Webarchive format saves duplicate WebSubresources to .webarchive file

• webarchive/test-duplicate-resources-expected.txt: Duplicate resources removed.
• webarchive/test-frameset-expected.txt: Ditto.

WebKit:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=7266
Webarchive format saves duplicate WebSubresources to .webarchive file

Tests: webarchive/test-duplicate-resources.html

webarchive/test-frameset.html

• WebView/WebArchiver.mm: (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]): Use an NSMutableSet to prevent duplicate subresources from being added to the webarchive.

6:27 PM Changeset in webkit [19421] by bdash

• 13 edits
  4 deletes in trunk

2007-02-06 Mark Rowe <​mrowe@apple.com>

Roll out incomplete support for font-stretch (r19350) at Dave Hyatt's request.
See ​http://bugs.webkit.org/show_bug.cgi?id=12530#c9 for more info.

• css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
• css/cssparser.cpp: (WebCore::CSSParser::parseValue):
• css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty):
• platform/FontCache.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): (WebCore::FontPlatformDataCacheKey::operator==): (WebCore::computeHash): (WebCore::FontPlatformDataCacheKeyTraits::deletedValue): (WebCore::FontPlatformDataCacheKeyTraits::emptyValue): (WebCore::FontCache::getCachedFontPlatformData):
• platform/FontDescription.h: (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::weight): (WebCore::FontDescription::setWeight): (WebCore::FontDescription::operator==):
• platform/mac/FontCacheMac.mm: (WebCore::FontCache::createFontPlatformData):
• platform/mac/WebFontCache.mm: (acceptableChoice): (betterChoice): (+[WebFontCache fontWithFamily:traits:size:]):

2007-02-06 Mark Rowe <​mrowe@apple.com>

Roll out incomplete support for font-stretch (r19350) at Dave Hyatt's request.
See ​http://bugs.webkit.org/show_bug.cgi?id=12530#c9 for more info.

• WebInspector/webInspector/inspector.js:
• WebView/WebHTMLView.mm: (-[WebHTMLView _addToStyle:fontA:fontB:]):

2007-02-06 Mark Rowe <​mrowe@apple.com>

Roll out incomplete support for font-stretch (r19350) at Dave Hyatt's request.
See ​http://bugs.webkit.org/show_bug.cgi?id=12530#c9 for more info.

• fast/css/computed-style-expected.txt:
• fast/css/font-stretch-expected.checksum: Removed.
• fast/css/font-stretch-expected.png: Removed.
• fast/css/font-stretch-expected.txt: Removed.
• fast/css/font-stretch.html: Removed.

6:12 PM Changeset in webkit [19420] by adele

• 4 edits in trunk/WebCore

Reviewed by Darin.

A few small updates to my bidi patch.

• rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): Moved the declaration of the CharacterBuffer outside the if statement since we use its data outside that scope.
• rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): ditto.
• rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderCharacters): Used a PassRefPtr for the BidiContext.

5:19 PM Changeset in webkit [19419] by justing

• 3 edits in trunk/LayoutTests/editing/selection

Checked in old results. Fixed.

4:36 PM Changeset in webkit [19418] by adele

• 4 edits in trunk/WebCore

Reviewed by Adam.

Fix for assertion failure in fast/events/objc-keyboard-event-creation.html

• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::selectionStart): Check that the selection offsets are not equal to -1 (which is means the selection has never been set) instead of checking for >= 0. (WebCore::HTMLInputElement::selectionEnd): ditto. (WebCore::HTMLInputElement::setValue): ditto. (WebCore::HTMLInputElement::selection): Return an empty selection if the input is not a text field or if no selection has ever been set in the text field.
• html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::selectionStart): Check that the selection offsets are not equal to -1. (WebCore::HTMLTextAreaElement::selectionEnd): ditto. (WebCore::HTMLTextAreaElement::setValue): ditto. (WebCore::HTMLTextAreaElement::selection): Return an empty selection if no selection has ever been set in the textarea.

• dom/Position.cpp: Added FIXMEs that we should catch the negative offset earlier. (WebCore::Position::previous): (WebCore::Position::next):

4:20 PM Changeset in webkit [19417] by justing

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4947387>
REGRESSION: Shift Command Left should only select to the beginning of the line

• editing/selection/4947387-expected.checksum: Added.
• editing/selection/4947387-expected.png: Added.
• editing/selection/4947387-expected.txt: Added.
• editing/selection/4947387.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4947387>
REGRESSION Shift Command Left should only select to the beginning of the line

• editing/Editor.cpp: (WebCore::CommandEntry::): Never copy/paste code.

3:41 PM Changeset in webkit [19416] by darin

• 4 edits
  2 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=11535 <rdar://problem/4946959> REGRESSION: onclick="this.select();" not working on new forms (11535)

• fast/forms/input-select-on-click-expected.txt: Added.
• fast/forms/input-select-on-click.html: Added.

WebCore:

Reviewed by John Sullivan.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11535 <rdar://problem/4946959> REGRESSION: onclick="this.select();" not working on new forms (11535)

Test: fast/forms/input-select-on-click.html

• page/EventHandler.h: Added m_mouseDownWasSingleClickInSelection boolean. Organized other booleans a bit more logically.
• page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): Rearrange order to match EventHandler.h, add m_mouseDownWasSingleClickInSelection initialization. (WebCore::EventHandler::handleMousePressEventSingleClick): Set m_mouseDownWasSingleClickInSelection to true in the appropriate special case. (WebCore::EventHandler::handleMousePressEvent): Set m_mouseDownWasSingleClickInSelection to false. (WebCore::EventHandler::handleMouseReleaseEvent): Change code to clear selection or set to caret to only fire if m_mouseDownWasSingleClickInSelection was true rather than firing for any m_mouseDownMayStartSelect case.

3:39 PM Changeset in webkit [19415] by staikos

• 2 edits in trunk/WebCore

Make http cookies work

3:25 PM Changeset in webkit [19414] by adele

• 7 edits
  8 adds in trunk

LayoutTests:

Reviewed by Mitz and Anders.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=11811
<rdar://problem/4947184> REGRESSION (r11783): Hebrew text in list boxes is reversed

• fast/text/international/bidi-listbox-expected.checksum: Added.
• fast/text/international/bidi-listbox-expected.png: Added.
• fast/text/international/bidi-listbox-expected.txt: Added.
• fast/text/international/bidi-listbox.html: Added.

• fast/text/international/bidi-listbox-atsui-expected.checksum: Added.
• fast/text/international/bidi-listbox-atsui-expected.png: Added.
• fast/text/international/bidi-listbox-atsui-expected.txt: Added.
• fast/text/international/bidi-listbox-atsui.html: Added.

WebCore:

Reviewed by Mitz and Anders.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11811
<rdar://problem/4947184> REGRESSION (r11783): Hebrew text in list boxes is reversed

​http://bugs.webkit.org/show_bug.cgi?id=11812
<rdar://problem/4960269> REGRESSION (Native file upload): Hebrew filenames are reversed

Tests:
fast/text/international/bidi-listbox.html
fast/text/international/bidi-listbox-atsui.html

• rendering/RenderBlock.h: Added static bidiReorderCharacters that will run the bidi algorithm on a character buffer.
• rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderCharacters): Added. Creates an anonymous RenderBlock and RenderText to feed into bidiReorderLines. (WebCore::RenderBlock::constructLine): Uses the new convenience methods on BidiRun.
• rendering/bidi.h: (WebCore::BidiRun::reversed): Added convenience method. (WebCore::BidiRun::dirOverride): ditto.

• rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): Creates a buffer and calls bidiReorderCharacters to get a correctly ordered character buffer for drawText.
• rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): ditto.

3:22 PM Changeset in webkit [22902] by adachan

• 2 edits in branches/WindowsMerge/WebKitWin

2007-02-05 Ada Chan <​adachan@apple.com>

Reviewed by Anders.

<rdar://4945519> Crash when back/forward buttons are clicked several times
Clear loader's previous history item when frame load is completed (got that code from the mac side).

• WebFrame.cpp: (WebFrame::frameLoadCompleted):

3:19 PM Changeset in webkit [19413] by weinig

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Darin.

• repaint test for ​http://bugs.webkit.org/show_bug.cgi?id=12590 REGRESSION: Text selection is weird in textareas in Trac wiki editing pages

• fast/repaint/selection-gap-overflow-scroll-expected.checksum: Added.
• fast/repaint/selection-gap-overflow-scroll-expected.png: Added.
• fast/repaint/selection-gap-overflow-scroll-expected.txt: Added.
• fast/repaint/selection-gap-overflow-scroll.html: Added.

WebCore:

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12590 REGRESSION: Text selection is weird in textareas in Trac wiki editing pages

Test: fast/repaint/selection-gap-overflow-scroll.html

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::selectionGapRects): Adjust for overflow scroll.

3:07 PM Changeset in webkit [19412] by weinig

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Adele.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=11916 REGRESSION (SearchField): RTL search fields are mixed up

• fast/forms/search-rtl-expected.checksum: Added.
• fast/forms/search-rtl-expected.png: Added.
• fast/forms/search-rtl-expected.txt: Added.
• fast/forms/search-rtl.html: Added.

WebCore:

Reviewed by Adele.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11916 REGRESSION (SearchField): RTL search fields are mixed up

Test: fast/forms/search-rtl.html

• rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createInnerBlockStyle): Always make the inner block LTR so that the results button will be on the left and the cancel button will be on the right. (WebCore::RenderTextControl::createInnerTextStyle): Inherit the direction property directly from the control so that it won't be masked by the inner block's LTR override. (WebCore::RenderTextControl::nodeAtPoint): Removed code that swapped the results and cancel buttons for RTL. (WebCore::RenderTextControl::forwardEvent): Ditto. (WebCore::RenderTextControl::clientPaddingLeft): Ditto. (WebCore::RenderTextControl::clientPaddingRight): Ditto.

2:55 PM Changeset in webkit [19411] by weinig

• 4 edits
  2 adds in trunk

LayoutTests:

Reviewed by Adele.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=12618 REGRESSION (SearchField): Dragging across the text and releasing over the clear button clears the field

• fast/forms/search-cancel-button-mouseup-expected.txt: Added.
• fast/forms/search-cancel-button-mouseup.html: Added.

WebCore:

Reviewed by Adele.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12618 REGRESSION (SearchField): Dragging across the text and releasing over the clear button clears the field

Test: fast/forms/search-cancel-button-mouseup.html

Made the cancel button capturing.

• html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLSearchFieldCancelButtonElement::HTMLSearchFieldCancelButtonElement): (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
• html/HTMLTextFieldInnerElement.h:

1:12 PM Changeset in webkit [19410] by ggaren

• 1 edit
  1 add in trunk/WebKitTools

Reviewed by Darin Adler.

New script that allows you to ignore leaks by regular expression.

• Scripts/run-leaks: Added.

1:10 PM Changeset in webkit [19409] by bdakin

• 2 edits in trunk/WebKit

Reviewed by Adam.

Fix for <rdar://problem/4975161> REGRESSION: With BumperCar 2.1.1,
the contextual menu fails to appear when I ctrl-click on page

• WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::getCustomMenuFromDefaultItems): If the delegate does not respond to contextMenuItemsForElement, return the default menu instead of nil.

1:08 PM Changeset in webkit [19408] by ggaren

• 3 edits in trunk/LayoutTests

Reviewed by John Sullivan and Darin Adler.

Focused gc-8.html on the issue it was really trying to test (a crash)
to fix intermittent failures seen on buildbot.

• fast/dom/gc-8.html: Don't test the value of our custom property, which (legitimately) can be cleared by garbage collection.
• fast/dom/gc-8-expected.txt:

10:32 AM Changeset in webkit [19407] by ap

• 4 edits
  1 add in trunk/WebCore

2007-02-05 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=6626 Arabic & Farsi rendered with no shaping (all glyphs separate, unreadable!)

No test possible since Mac OS X only ships with fonts that contain shaping
information.

• icu/unicode/ushape.h: Added from ​http://www.opensource.apple.com/darwinsource/10.4.8.ppc/ICU-6.2.9/icuSources/common/unicode/
• platform/FontData.h: (WebCore::FontData::shapesArabic): Added. Returns whether the font contains shaping information for Arabic or not.
• platform/mac/FontDataMac.mm: (WebCore::FontData::platformInit): (WebCore::FontData::checkShapesArabic): Added. Checks whether the font contains a glyph metamorphosis table. The heuristic is that if a font contains Arabic glyphs and a metamorphosis table, then it includes shaping information for Arabic.
• platform/mac/FontMac.mm: (WebCore::overrideLayoutOperation): Changed to use the same character buffer passed to ATSUI instead of the original character buffer and to give zero-width spaces zero width. (WebCore::isArabicLamWithAlefLigature): Added. Checks if the character is one of the Arabic presentation forms of Lam with Alef. (WebCore::shapeArabic): Added. This is a wrapper around the ICU Arabic shaping routine that replaces each space following a Lam with Alef ligature resulting from shaping with a zero-width space. (WebCore::ATSULayoutParameters::initialize): Changed to allocate the auxiliary buffer lazily for mirroring and Arabic shaping. Added a call to shapeArabic() when required.

9:24 AM Changeset in webkit [19406] by brmorris

• 19 edits in S60/trunk

bujtas, merged of r19405 to s60/trunk by mbradley, reviewed by yongjun.

DESC: browser is crashing if it is closed while a page is loading and closing and opening a new window crashes the browser as well TMCN-6XRQP2
fix:

1. cancel parsing when the document is being closed
2. flush static image decoder queue. remove images associated with the the view being destroyed

​http://bugs.webkit.org/show_bug.cgi?id=12542

9:07 AM Changeset in webkit [19405] by brmorris

• 19 edits in S60/branches/3.1m

bujtas <​zbujtas@gmail.com>, reviewed by Yongjun.

DESC: browser is crashing if it is closed while a page is loading and closing and opening a new window crashes the browser as well TMCN-6XRQP2
fix:

1. change the order of destroying webkit objects.
2. cancel parsing when the document is being closed
3. flush static image decoder queue. remove images associated with the the view being destroyed
4. remove formfill dependency on webkitcontrol. formfill is static object while webkitcontrol is per window.
5. do not create formfill manager unless browser capabilities say so

​http://bugs.webkit.org/show_bug.cgi?id=12542

9:00 AM Changeset in webkit [19404] by brmorris

• 3 edits in S60/branches/3.1m/WebKit

raalexan, Reviewed by Yongjun Zhang.

DESC: Enhanced Input feature not working in 3.1 [TSW TMCN-6XYSLY]
​http://bugs.webkit.org/show_bug.cgi?id=12533

8:51 AM Changeset in webkit [22901] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Build fix.

• WebCore.vcproj/WebCore.vcproj: Add new files.

7:18 AM Changeset in webkit [19403] by ddkilzer

• 1 edit in trunk/WebCore/ChangeLog

Clean up changelog entry. Also testing new svn-co-one-file script.

5:07 AM Changeset in webkit [19402] by eseidel

• 2 edits in trunk/WebCore

2007-02-05 Eric Seidel <​eric@webkit.org>

No review, build fix only.

• ksvg2/svg/SVGStyleElement.cpp: add forgotten header.

4:46 AM Changeset in webkit [19401] by eseidel

• 3 edits in trunk/WebCore

2007-02-05 Eric Seidel <​eric@webkit.org>

Reviewed by bdash.

Fix style name testcase which I broke in my last commit.

• ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::xmlspace): (WebCore::SVGStyleElement::title): override Element::title() (WebCore::SVGStyleElement::parseMappedAttribute):
• ksvg2/svg/SVGStyleElement.h:

3:21 AM Changeset in webkit [19400] by eseidel

• 11 edits
  1 add in trunk/WebCore

2007-02-04 Eric Seidel <​eric@webkit.org>

Reviewed by darin.

Fix hand cursor on link hover for SVG
Fix status text on link hover for SVG
Fix tooltips on link hover for SVG
Fix link dragging for SVG
​http://bugs.webkit.org/show_bug.cgi?id=12575

Test: added manual-tests/svg-links.svg

• dom/Document.cpp: (WebCore::Document::prepareMouseEvent):
• dom/Element.cpp: (WebCore::Element::title):
• dom/Element.h:
• html/HTMLElement.cpp: (WebCore::HTMLElement::setId): (WebCore::HTMLElement::title): (WebCore::HTMLElement::setTitle): (WebCore::HTMLElement::setLang):
• html/HTMLElement.h:
• ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::title): (WebCore::SVGAElement::parseMappedAttribute): (WebCore::SVGAElement::defaultEventHandler):
• ksvg2/svg/SVGAElement.h:
• ksvg2/svg/SVGTitleElement.cpp:
• ksvg2/svg/SVGTitleElement.h:
• manual-tests/svg-links.svg: Added.
• rendering/HitTestResult.cpp: (WebCore::HitTestResult::title): (WebCore::HitTestResult::absoluteImageURL): (WebCore::HitTestResult::absoluteLinkURL): (WebCore::HitTestResult::isLiveLink): (WebCore::HitTestResult::titleDisplayString):

Feb 4, 2007:

10:59 PM Changeset in webkit [22900] by adachan

• 2 edits in branches/WindowsMerge/WebKitWin

2007-02-04 Ada Chan <​adachan@apple.com>

Reviewed by Steve.

WebKitWin:

<rdar://4946475> Private browsing is not working correctly
Implemented FrameLoaderClient::privateBrowsingEnabled().

• WebFrame.cpp: (WebFrame::privateBrowsingEnabled):

10:06 PM Changeset in webkit [19399] by ap

• 3 edits
  2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12602
XPath functions string(), normalize-space() and string-length() don't work
without arguments

Test: fast/xpath/implicit-node-args.html

• xml/XPathFunctions.cpp: (WebCore::XPath::FunString::doEvaluate): (WebCore::XPath::FunStringLength::doEvaluate): (WebCore::XPath::FunNormalizeSpace::doEvaluate): Don't try to pass RefPtr<Node> to the Value ctor.

9:56 PM Changeset in webkit [19398] by ap

• 11 edits
  14 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=8791
XPath should support custom node resolvers

WebCore:

• bindings/js/JSCustomXPathNSResolver.cpp: Added. (WebCore::JSCustomXPathNSResolver::create): (WebCore::JSCustomXPathNSResolver::JSCustomXPathNSResolver): (WebCore::JSCustomXPathNSResolver::~JSCustomXPathNSResolver): (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
• bindings/js/JSCustomXPathNSResolver.h: Added.
• bindings/objc/DOMCustomXPathNSResolver.h: Added.
• bindings/objc/DOMCustomXPathNSResolver.mm: Added. (WebCore::DOMCustomXPathNSResolver::DOMCustomXPathNSResolver): (WebCore::DOMCustomXPathNSResolver::~DOMCustomXPathNSResolver): (WebCore::DOMCustomXPathNSResolver::lookupNamespaceURI): Wrappers for JS/ObjC objects that can be used as resolvers.

• bindings/scripts/CodeGeneratorJS.pm:
• bindings/scripts/CodeGeneratorObjC.pm: Use the above wrappers to support custom resolvers.

• xml/XPathNSResolver.cpp:
• xml/XPathNSResolver.h: Turned this class into an abstract one.

• xml/NativeXPathNSResolver.cpp: Added. (WebCore::NativeXPathNSResolver::NativeXPathNSResolver): (WebCore::NativeXPathNSResolver::~NativeXPathNSResolver): (WebCore::NativeXPathNSResolver::lookupNamespaceURI):
• xml/NativeXPathNSResolver.h: Added. A XPathNSResolver subclass, doing what XPathNSResolver used to do.

• xml/XPathEvaluator.cpp: (WebCore::XPathEvaluator::createNSResolver): Create a NativeXPathNSResolver.

• WebCore.xcodeproj/project.pbxproj: Added new files.

LayoutTests:

• fast/xpath/nsresolver-bad-object-expected.txt: Added.
• fast/xpath/nsresolver-bad-object.xhtml: Added.
• fast/xpath/nsresolver-exception-expected.txt: Added.
• fast/xpath/nsresolver-exception.xhtml: Added.
• fast/xpath/nsresolver-function-expected.txt: Added.
• fast/xpath/nsresolver-function.xhtml: Added.
• fast/xpath/nsresolver-object-expected.txt: Added.
• fast/xpath/nsresolver-object.xhtml: Added.

9:55 PM Changeset in webkit [22899] by aliceli1

• 4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Fix some memory leaks. This fixes WebFrame leak as well.
Can be considered a partial fix for <rdar://4974495> Boomer leaks while running HTML iBench

• WebActionPropertyBag.cpp: (WebActionPropertyBag::WebActionPropertyBag):
• WebDataSource.cpp: (WebDataSource::representation):
• WebURLResponse.cpp: (:m_refCount):

7:52 PM Changeset in webkit [22898] by aroben

• 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Fix <rdar://problem/4972498> REGRESSION: Crash while closing View Source window

• WebView.cpp: (WebView::WebView): Initialize new member. (WebViewWndProc): Set flag when we receive WM_DESTROY, and don't handle WM_SIZE if that flag is true. (WebView::mainFrame): Added argument check.
• WebView.h: (WebView::setIsBeingDestroyed): Added. (WebView::isBeingDestroyed): Added.

6:54 PM Changeset in webkit [19397] by weinig

• 19 edits in trunk/LayoutTests

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12562
Fix test cases that are now spewing console errors that
they are not testing for

• fast/events/iframe-object-onload-expected.txt:
• fast/events/iframe-object-onload.html: Change nil to null.
• fast/forms/display-none-in-onchange-keyboard-expected.txt:
• fast/forms/display-none-in-onchange-keyboard.html: Add missing id to div, change its text, and change the resulting text.
• fast/forms/input-text-click-inside-expected.checksum:
• fast/forms/input-text-click-inside-expected.png:
• fast/forms/input-text-click-inside-expected.txt:
• fast/forms/input-text-click-inside.html: Change moveTo(x,y) to mouseMoveTo(x,y).
• fast/forms/input-text-click-outside-expected.txt:
• fast/forms/input-text-click-outside.html: Ditto.
• fast/js/array-foreach-expected.txt:
• fast/js/array-foreach.html: Add try-catch blocks to catch exceptions and print them and general cleanup.
• fast/js/array-some-expected.txt:
• fast/js/array-some.html: Ditto.
• fast/table/click-near-anonymous-table-expected.checksum:
• fast/table/click-near-anonymous-table-expected.png:
• fast/table/click-near-anonymous-table-expected.txt:
• fast/table/click-near-anonymous-table.html: Change timeForward(ms) to leapForward(ms) and change the amount of time from 500ms to 1000ms to avoid clicking.

6:38 PM Changeset in webkit [22897] by oliver

• 2 edits in branches/WindowsMerge/WebCore

2007-02-04 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Removed unimplemented EventHandler::handleMouseUp,
as a platform independent version is available now.

• page/win/EventHandlerWin.cpp: (WebCore::EventHandler::eventActivatedView): Now we use this method, it needs to be implemented

6:37 PM Changeset in webkit [19396] by oliver

• 6 edits in trunk/WebCore

2007-02-04 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Tidying up EventHandler, and moving more of
EventHandlerMac.mm to EventHandler.cpp

Also added EventHandler::eventLoopHandleMouse[Dragged,Up]
these are basically helper functions to allow correct event
handling on MacOS.

• page/EventHandler.cpp: (WebCore::EventHandler::handleMouseUp): (WebCore::EventHandler::dragSourceMovedTo): (WebCore::EventHandler::dragSourceEndedAt): (WebCore::EventHandler::dispatchDragSrcEvent):

Moved from EventHandlerMac to EventHandler

• page/EventHandler.h: (WebCore::EventHandler::eventLoopHandleMouseUp): (WebCore::EventHandler::eventLoopHandleMouseDragged): Null implementations of two Mac helper functions
• page/mac/EventHandlerMac.mm: (WebCore::EventHandler::eventLoopHandleMouseDragged): (WebCore::EventHandler::handleDrag): Much tidying, reduced nesting, made less dependent on NS types (WebCore::EventHandler::eventLoopHandleMouseDragged): (WebCore::EventHandler::eventLoopHandleMouseUp): Helper functions to let us process events properly on MacOS

• page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):

5:08 PM Changeset in webkit [22896] by aroben

• 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Hyatt.

Fix <rdar://problem/4968183> Cross-window frame targeting doesn't work

• Interfaces/IWebView.idl: Pass RECT by value.
• WebView.cpp: (WebView::initWithFrame): Uses the passed-in RECT for the frame, and sets the frame/group names.
• WebView.h: Updated declaration.

6:15 AM Changeset in webkit [19395] by staikos

• 3 edits in trunk/WebCore

Various Qt related hacks and cleanups to make forms work better