Context Navigation

← Previous Period
Next Period →

Timeline

Feb 27, 2007:

11:55 PM Changeset in webkit [19907] by rwlbuis

3 edits
4 adds in trunk

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=12913
Markers do not render in webkit when it misses markerWidth or markerHeight attribute

Set defaults for markerWidth/markerHeight so markers that do not specify them render.

9:33 PM Changeset in webkit [19906] by ggaren

2 edits in trunk/LayoutTests

Extending the timeout on this test to see if it fixes the buildbot failure.
(I don't get a failure locally.)

fast/leaks/003.html:

9:13 PM Changeset in webkit [23011] by adachan

7 edits
4 adds in branches/WindowsMerge/WebKitWin

6:04 PM Changeset in webkit [23010] by aliceli1

3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve, Adam, Maciej, and their mothers.

This is a general leaks fix but helps the effort towards fixing
<rdar://4974495> Boomer leaks while running HTML iBench
However, this fix doens't close that bug.

WebFrame.cpp: (WebFrame::setTitle):

fix a leak of WebHistory

WebHistory.cpp: (_WebCoreHistoryProvider::containsItemForURLUnicode):

fix a leak of WebHistory

5:17 PM Changeset in webkit [23009] by sfalken

1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

5:16 PM Changeset in webkit [19905] by andersca

2 edits in trunk/WebCore

loader/ResourceLoader.cpp: (WebCore::ResourceLoader::~ResourceLoader): Remove comment.

5:15 PM Changeset in webkit [19904] by sfalken

1 copy in tags/Safari-521.35.3b

New tag.

5:12 PM Changeset in webkit [23008] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders.

Fix <rdar://problem/5004615> View source menu option is always disabled
when Netscape 8 is installed

The bug was caused by Netscape's npTrident.dll plugin, which registers
itself as a handler for text/html and text/xml.

WebFrame.cpp: (WebFrame::canProvideDocumentSource): Explicitly allow viewing the source of HTML and XML documents, rather than disallowing text, image, and plugin documents. Plugins can register themselves as handlers for HTML and XML MIME types, but we still want to display source in those cases.

5:08 PM Changeset in webkit [19903] by justing

4 edits
4 adds in trunk

LayoutTests:

Reviewed by oliver

<rdar://problem/5027300>
REGRESSION: Images inserted with align left/right are lost

editing/inserting/12882-expected.checksum: Added.
editing/inserting/12882-expected.png: Added.
editing/inserting/12882-expected.txt: Added.
editing/inserting/12882.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/5027300>
REGRESSION: Images inserted with align left/right are lost

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMerge): Don't attempt to merge to or from a position before or after a block because it will be a no-op and lead to infinite recursion. In this case it instead resulted in content loss because of bugs in start/endOfParagraph (5027702).
editing/visible_units.cpp: Added two FIXMEs for the problems with start/endOfParagraph.

4:38 PM Changeset in webkit [19902] by andersca

6 edits in trunk/WebCore

Reviewed by Geoff.

Make resource load delegate methods pass the right document loader.

loader/FrameLoader.cpp: (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::didFailToLoad): (WebCore::FrameLoader::didFinishLoad): (WebCore::FrameLoader::didReceiveAuthenticationChallenge): (WebCore::FrameLoader::didCancelAuthenticationChallenge): Use the resource loader's document loader instead of the active one.

loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::receivedError): Make it so we send the frame load delegate method before the resource load delegate method. This was a regression from 2.0 and was caused by the fix to rdar://problem/4609195. Because the way the loader now works, both delegate methods will be called.

loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader):
loader/ResourceLoader.h: (WebCore::ResourceLoader::documentLoader): Add document loader pointer to ResourceLoader.

4:26 PM Changeset in webkit [19901] by ggaren

4 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Follow-up to fixing http://bugs.webkit.org/show_bug.cgi?id=12659 | <rdar://problem/4954306>
JS objects not collected after closing window @ ebay.com/maps.google.com

Changed Interpreter cache of global constructors and prototypes from
ProtectedPtrs to bare, marked pointers. ProtectedPtrs are inefficient,
and they increase the risk of reference cycles. Also, Darin said something
about ProtectedPtrs giving him warts.

Also changed data members to precise types from generic JSObject*'s.

Layout tests and JS tests pass.

kjs/SavedBuiltins.h:
kjs/interpreter.cpp: (KJS::Interpreter::init): (KJS::Interpreter::~Interpreter): (KJS::Interpreter::initGlobalObject): Moved Identifier::init() call to constructor, for clarity. (KJS::Interpreter::mark):
kjs/interpreter.h:

4:21 PM Changeset in webkit [19900] by ggaren

1 edit in trunk/LayoutTests/fast/leaks/003-expected.txt

Oops! Forgot to check in this file.

4:04 PM Changeset in webkit [19899] by weinig

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

repaint test for http://bugs.webkit.org/show_bug.cgi?id=12910 REGRESSION (r18756-r18765): list-bullet doesn't redraw properly when changing the list's content using JavaScript

fast/repaint/list-marker-expected.checksum: Added.
fast/repaint/list-marker-expected.png: Added.
fast/repaint/list-marker-expected.txt: Added.
fast/repaint/list-marker.html: Added.

WebCore:

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=12910 REGRESSION (r18756-r18765): list-bullet doesn't redraw properly when changing the list's content using JavaScript

Test: fast/repaint/list-marker.html

rendering/RenderListItem.cpp: (WebCore::RenderListItem::positionListMarker): Add the marker to the visual overflow of all its ancestor blocks up to the list item. This needs to be done here since the marker is positioned only after those blocks have been laid out.

3:38 PM Changeset in webkit [19898] by bdash

3 edits in trunk/WebKit

2007-02-28 Mark Rowe <mrowe@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/4985524> Problem with Blot and ToT WebKit (decoding WebCoreScrollView)

References to WebCoreScrollView as a subview of a WebHTMLView may be present in some NIB
files, so NSUnarchiver must be still able to look up the WebCoreScrollView class.

WebKit.exp: Export WebCoreScrollView symbol.
WebView/WebHTMLView.mm: Add empty WebCoreScrollView class.

3:27 PM Changeset in webkit [23007] by adachan

1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Oops, ChangeLog wasn't saved last time.

3:24 PM Changeset in webkit [23006] by bdakin

4 edits in branches/WindowsMerge

WebKitWin:

Reviewed by Adam.

Make msimg32.lib available to the engine so that we can use
AlphaBlend.

WebKit.vcproj/WebKit.vcproj:

WebCoreWin:

Reviewed by Adam.

<rdar://problem/4956528> Implement Pasteboard::writeImage for
Boomer context menus

platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage): Copy a bitmap to the clipboard.

3:22 PM Changeset in webkit [23005] by adachan

2 edits in branches/WindowsMerge/WebKitWin

2007-02-27 Ada Chan <adachan@apple.com>

Fix build.

WebFrame.cpp:

3:13 PM Changeset in webkit [19897] by antti

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

test for http://bugs.webkit.org/show_bug.cgi?id=12918 REGRESSION: Google Finance dropdown Flickers <rdar://4988039>

fast/events/mouseout-dead-node-expected.checksum: Added.
fast/events/mouseout-dead-node-expected.png: Added.
fast/events/mouseout-dead-node-expected.txt: Added.
fast/events/mouseout-dead-node.html: Added.

WebCore:

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=12918 REGRESSION: Google Finance dropdown Flickers <rdar://4988039>

If a node dies while mouse is over it, it is still supposed to receive
mouseout event (wasn't case in Tiger webkit). However this event should
not propagate to any other nodes. This patch matches Firefox behavior in
this respect.

dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent):

3:10 PM Changeset in webkit [19896] by ggaren

2 edits in trunk/LayoutTests

Bumped up the wiggle room on this test because it's failing on the buildbot.
(We're still well below the ~100 objects you would see in a real failure.)

fast/leaks/003.html:

3:09 PM Changeset in webkit [19895] by ggaren

1 edit in trunk/LayoutTests/fast/dom/gc-10.html

Oops! Forgot to commit this file

3:03 PM Changeset in webkit [23004] by oliver

4 edits in branches/WindowsMerge

2007-02-27 Oliver Hunt <oliver@apple.com>

Reviewed by Lou and Steve.

WebCoreWin:

Add a store for current Cursor to fix <rdar://problem/4788352>

platform/win/WidgetWin.cpp: (WebCore::Widget::setCursor):

WebKitWin:

<rdar://4983106> Stop/reload button never changes back to
reload when a click on a link spawns a download

WebError.cpp: (WebError::isPolicyChangeError): fixed string comparison
WebFrame.cpp: (WebFrame::interruptForPolicyChangeError): implemented the method

2:28 PM Changeset in webkit [19894] by ggaren

10 edits
2 adds in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.

Fixed http://bugs.webkit.org/show_bug.cgi?id=12659 | <rdar://problem/4954306>
JS objects not collected after closing window @ ebay.com/maps.google.com

Don't GC in the Interpreter destructor. For that to work, the Interpreter
would have to NULL out all of its ProtectedPtrs before calling collect(). But
we've decided that we don't want things to work that way, anyway. We want the
client to be in charge of manual GC so that it can optimize cases when
it will be destroying many interpreters at once
(e.g., http://bugs.webkit.org/show_bug.cgi?id=12900).

Also removed Interpreter::collect() because it was redundant with
Collector::collect().

JavaScriptCore.exp:
kjs/interpreter.cpp: (KJS::Interpreter::~Interpreter):
kjs/testkjs.cpp: (TestFunctionImp::callAsFunction):

LayoutTests:

Reviewed by Maciej Stachowiak.

Test for http://bugs.webkit.org/show_bug.cgi?id=12659 | <rdar://problem/4954306>
JS objects not collected after closing window @ ebay.com/maps.google.com

fast/leaks/003-expected.txt: Added.
fast/leaks/003.html: Added.

fast/dom/gc-10.html: Bumped the wiggle room threshold on this test by 2 because it's failing on my machine with the patch applied but, according to the test notes, we're still well within the margin of error.

WebCore:

Reviewed by Maciej Stachowiak.

Fixed http://bugs.webkit.org/show_bug.cgi?id=12659 | <rdar://problem/4954306>
JS objects not collected after closing window @ ebay.com/maps.google.com

Garbage collect in the KJSProxy destructor, after clearing our reference
to the interpreter, because that's when the interpreter has torn down fully.

(Technically speaking, we can't *prove* that we have the only reference to
our interpreter, but that's how it works in practice, and manual garbage
collection is just an opportunistic optimization, so it's OK for it to
work in practice even if it can't be proven in theory.)

Layout tests pass. No leaks reported.

bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::~KJSProxy):
bindings/js/kjs_proxy.h:
page/Page.cpp: (WebCore::Page::~Page): Merged pageDestroyed() calls. Moved debug-only code to the bottom.
page/Frame.cpp: (WebCore::Frame::~Frame): Don't call getObject() because globalObject() returns a JSObject* already, and the call can leave a pointer to the Window object on the stack. Don't check for NULL because it is an invariant of JavaScriptCore that no JSObject* can be NULL. Do use a volatile pointer for w because the 'w = 0' assignment just screams to the compiler, "Don't generate any code for me!"

2:26 PM Changeset in webkit [23003] by adachan

3 edits in branches/WindowsMerge/WebKitWin

2007-02-27 Ada Chan <adachan@apple.com>

Reviewed by Steve and Anders.

<rdar://4983106> Stop/reload button never changes back to reload when a click on a link spawns a download

WebKitWin:

WebError.cpp: (WebError::isPolicyChangeError): fixed string comparison
WebFrame.cpp: (WebFrame::interruptForPolicyChangeError): implemented the method

12:50 PM Changeset in webkit [19893] by aroben

2 edits in trunk/WebKit

Reviewed by Beth.

Fix <rdar://problem/5011905> REGRESSION: "Open Link" contextual menu
item appears twice

WebCoreSupport/WebContextMenuClient.mm: (fixMenusToSendToOldClients): Remove the "Open Link" item from the default menu items array before sending it off to Tiger Mail. (WebContextMenuClient::getCustomMenuFromDefaultItems): Set the representedObject on every NSMenuItem to match our old (correct) API behavior.

12:31 PM Changeset in webkit [19892] by rwlbuis

3 edits
4 adds in trunk

Reviewed by David Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=4128
!important is ignored in inline styling.

Handle properties with !important flag better in inline
style declarations.

12:13 PM Changeset in webkit [19891] by hyatt

2 edits in trunk/WebCore

Bug 11435. Make sure RenderViews always paintBoxDecorations. They used to before I removed RenderView's
paint method. This fix restores the original behavior.

Reviewed by mitz

rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle):

11:51 AM Changeset in webkit [19890] by hyatt

2 edits in trunk/WebCore

Fix for bug 12094, make sure setMinMaxKnown starts off false for the weird/rare case of empty
plaintext documents (which really are buggy and should be fixed to generate root elements).

Reviewed by mitz

rendering/RenderView.cpp: (WebCore::RenderView::RenderView):

10:45 AM Changeset in webkit [19889] by ap

2 edits in trunk/WebCore

2007-02-27 Dex Deacon <occupant4@gmail.com>

Reviewed by Darin.

Fixed the case where a BackForwardList of capacity==1 would grow without bound.

history/BackForwardList.cpp: (WebCore::BackForwardList::addItem):

10:10 AM Changeset in webkit [19888] by ap

2 edits in trunk/WebCore

2007-02-22 Lars Naesbye Christensen <lars@naesbye.dk>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=12848
Help cursor should have a white outline

Resources/helpCursor.png:

10:00 AM Changeset in webkit [19887] by ap

2 edits in trunk/WebKit

2007-02-27 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12906 REGRESSION: Canvas is pixelated when the page is opened in a background tab

WebCoreSupport/WebChromeClient.mm: (WebChromeClient::scaleFactor): If the view is not in a window, use the main screen's scale factor as a best guess.

9:48 AM Changeset in webkit [19886] by ap

2 edits in trunk/WebCore

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=12594
REGRESSION: Strange highlight in active input area

No automated test possible.

rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): Restore a check lost in r12792.

8:18 AM Changeset in webkit [19885] by ggaren

2 edits in trunk/WebKitTools

Small tweak to run-webkit-tests.

Scripts/run-webkit-tests: Allow people with lots of RAM to run more than 1000 MallocStackLogging tests at a time.

6:08 AM Changeset in webkit [19884] by darin

2 edits in trunk/WebCore

Reviewed by Mitz.

fix http://bugs.webkit.org/show_bug.cgi?id=12908 crash in http/tests/incremental/frame-focus-before-load.html

page/mac/EventHandlerMac.mm: (WebCore::EventHandler::focusDocumentView): Add null checks.

6:05 AM Changeset in webkit [19883] by darin

3 edits in trunk/WebCore

Reviewed by Alexey.

fix http://bugs.webkit.org/show_bug.cgi?id=12909 should use ICU, not TEC, for MacRoman decoding

platform/TextCodecICU.cpp: (WebCore::TextCodecICU::registerEncodingNames): Add "macroman" as an alias for "macintosh". We have seen that in use in mail, although I'm not sure it's used on the web.

platform/mac/mac-encodings.txt: Remove MacRoman line, which was added back as part of the patch for bug 4971226. But by adding it to the this file rather than the ICU codec, we get it only on Mac OS X. And long term we are trying to get rid of the use of TEC entirely, so we want this file to be as empty as possible.

6:05 AM Changeset in webkit [19882] by darin

1 edit
2 adds in trunk/LayoutTests

test for MacRoman encoding name alias

fast/encoding/charset-names-expected.txt: Added.
fast/encoding/charset-names.html: Added.

5:02 AM Changeset in webkit [19881] by darin

2 edits in trunk/LayoutTests

fast/css/computed-style-expected.txt: Updated test result for Hyatt's addition of -webkit-border-fit.

2:12 AM Changeset in webkit [19880] by rwlbuis

7 edits
4 adds in trunk

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=12905
Not all svg shapes should support markers

Restrict marker usage to svg shapes polyline, polygon, line and path.

12:44 AM Changeset in webkit [19879] by adele

6 edits in trunk

LayoutTests:

Reviewed by Lars.

Updated test for http://bugs.webkit.org/show_bug.cgi?id=12902
<rdar://problem/5012679> REGRESSION: Pressing return key doesn't
move caret to next line after applying a font color in GMail

fast/frames/iframe-window-focus-expected.txt:
fast/frames/iframe-window-focus.html: Updated test to include insertion of newlines.

WebCore:

Reviewed by Lars.

Fix for http://bugs.webkit.org/show_bug.cgi?id=12902
<rdar://problem/5012679> REGRESSION: Pressing return key doesn't
move caret to next line after applying a font color in GMail

Test: fast/frames/iframe-window-focus-2.html

page/EventHandler.h: Make focusDocumentView public.
page/Frame.cpp: (WebCore::Frame::focusWindow): Instead of just setting the focused frame, we should set also focus the document view. The bug here was that since the subframe view wasn't the first responder, the key down event was going to the wrong frame.

Feb 26, 2007:

11:54 PM Changeset in webkit [23002] by oliver

2 edits in branches/WindowsMerge/WebCore

2007-02-26 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej.

To stop the drag image for transparent images from looking
ugly (especially fully transparent images) we render the
image to a white background prior to passing the image on to
Windows

<rdar://problem/5015946>

platform/win/DragImageWin.cpp: (WebCore::createDragImageFromImage):

11:19 PM Changeset in webkit [19878] by mjs

3 edits
20 adds in trunk

LayoutTests:

Reviewed by Oliver.

test cases for <rdar://problem/4946881> Recursive loop with <marker> not caught, crashes in WebCore::SVGPaintServer::draw (11244) http://bugs.webkit.org/show_bug.cgi?id=11244

svg/custom/circular-marker-reference-1-expected.checksum: Added.
svg/custom/circular-marker-reference-1-expected.png: Added.
svg/custom/circular-marker-reference-1-expected.txt: Added.
svg/custom/circular-marker-reference-1.svg: Added.
svg/custom/circular-marker-reference-2-expected.checksum: Added.
svg/custom/circular-marker-reference-2-expected.png: Added.
svg/custom/circular-marker-reference-2-expected.txt: Added.
svg/custom/circular-marker-reference-2.svg: Added.
svg/custom/circular-marker-reference-3-expected.checksum: Added.
svg/custom/circular-marker-reference-3-expected.png: Added.
svg/custom/circular-marker-reference-3-expected.txt: Added.
svg/custom/circular-marker-reference-3.svg: Added.
svg/custom/circular-marker-reference-4-expected.checksum: Added.
svg/custom/circular-marker-reference-4-expected.png: Added.
svg/custom/circular-marker-reference-4-expected.txt: Added.
svg/custom/circular-marker-reference-4.svg: Added.
svg/custom/non-circular-marker-reference-expected.checksum: Added.
svg/custom/non-circular-marker-reference-expected.png: Added.
svg/custom/non-circular-marker-reference-expected.txt: Added.
svg/custom/non-circular-marker-reference.svg: Added.

WebCore:

Reviewed by Oliver.

fixed <rdar://problem/4946881> Recursive loop with <marker> not caught, crashes in WebCore::SVGPaintServer::draw (11244) http://bugs.webkit.org/show_bug.cgi?id=11244

platform/graphics/svg/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::draw): Use a HashSet to guard against reference cycles.

9:30 PM Changeset in webkit [19877] by mjs

4 edits in trunk

WebCore:

Reviewed by Kevin McCullough.

fix Qt build for earlier SVG changes.

platform/graphics/svg/qt/SVGResourceFilterQt.cpp:

WebKitQt:

Reviewed by Kevin McCullough.

fix Qt build for earlier SVG changes.

WebCoreSupport/EditCommandQt.cpp:

9:23 PM Changeset in webkit [19876] by oliver

2 edits in trunk/WebCore

2007-02-26 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej.

Fix for <rdar://problem/4827378>: Canvas with large height
uses lots of memory, computer almost stops responding

Put cap on maximum area of canvas, size is similar too the
maximum size allowed by firefox (firefox seems to to cut off
at area == 32767 * 9358).

Also protect renderer against the possibility of a null context
(this was triggering a CG warning)

html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createDrawingContext):

Apply maximum canvas area

(WebCore::HTMLCanvasElement::createPlatformImage):

Protect against null CG Context

9:13 PM Changeset in webkit [19875] by bdash

3 edits
4 adds in trunk

2007-02-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Antti Koivisto.

fix http://bugs.webkit.org/show_bug.cgi?id=12899 Ordered lists not updating dynamically with new styles <rdar://problem/4889356>

Test: fast/lists/list-style-type-dynamic-change.html

rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::setStyle): Made changing the marker type trigger updating of the marker.

2007-02-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Antti Koivisto.

test for http://bugs.webkit.org/show_bug.cgi?id=12899 Ordered lists not updating dynamically with new styles

fast/lists/list-style-type-dynamic-change-expected.checksum: Added.
fast/lists/list-style-type-dynamic-change-expected.png: Added.
fast/lists/list-style-type-dynamic-change-expected.txt: Added.
fast/lists/list-style-type-dynamic-change.html: Added.

8:04 PM Changeset in webkit [19874] by mjs

2 edits in trunk/WebKitTools

Reviewed by Lars.

set ENABLE_XSLT even when compiling without SVG support, since that is no longer hardcoded into config.h.

Scripts/build-webkit:

5:56 PM Changeset in webkit [19873] by kjk

4 edits in trunk

JavaScriptCore:

Reviewed by Adam Roben.

Rename *_SUPPORT defines to ENABLE_*.

jscore.bkl:

WebKitTools:

Reviewed by Adam Roben.

Rename *_SUPPORT defines to ENABLE_*.

GdkLauncher/gdklauncher.bkl:

5:36 PM Changeset in webkit [19872] by adele

5 edits
2 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for <rdar://problem/5012761> REGRESSION: form submit invokes wrong event handler

fast/events/submit-reset-nested-bubble-expected.txt: Added.
fast/events/submit-reset-nested-bubble.html: Added.

WebCore:

Reviewed by Maciej.

Fix for <rdar://problem/5012761> REGRESSION: form submit invokes wrong event handler

Test: fast/events/submit-reset-nested-bubble.html

dom/EventTargetNode.h: Made handleLocalEvents virtual.
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::handleLocalEvents): If we're not in the capture phase, and the target is a different form, and we're handling the submitEvent or the resetEvent, then stop propagation of the event. This matches Firefox behavior. You can only get in this situation if misnested tags cause forms to be nested.
html/HTMLFormElement.h: Added handleLocalEvents.

5:32 PM Changeset in webkit [19871] by darin

2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

<rdar://problem/5021555> TextCodecICU does not use fallback mappings; it should

platform/TextCodecICU.cpp: (WebCore::TextCodecICU::createICUConverter): Added a call to ucnv_setFallback(TRUE).

5:16 PM Changeset in webkit [19870] by oliver

3 edits
4 adds in trunk

2007-02-26 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Fix for rdar://problem/5021127

Need to add null check to node -- original Obj-C didn't need
the null check due to the Obj-C null messaging semantics

editing/Editor.cpp: (WebCore::Editor::shouldInsertFragment):

Layout tests:

Layout test for rdar://problem/5021127

fast/events/standalone-image-drag-to-editable-expected.checksum: Added.
fast/events/standalone-image-drag-to-editable-expected.png: Added.
fast/events/standalone-image-drag-to-editable-expected.txt: Added.
fast/events/standalone-image-drag-to-editable.html: Added.

4:39 PM Changeset in webkit [23001] by aroben

4 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adele.

platform/win/GraphicsContextWin.cpp: Get rid of so-five-hours-ago SVG_SUPPORT.

WebKitWin:

Reviewed by Adele.

Stop bizarre crashes from happening on startup.

WebKit.vcproj/WebKit.vcproj: Use new ENABLE_* macros instead of *_SUPPORT.

4:33 PM Changeset in webkit [19869] by sullivan

2 edits in trunk/WebKit

Reviewed by Darin and Geoff

WebView/WebHTMLView.mm: (coreGraphicsScreenPointForAppKitScreenPoint): This method was copied from WebBrowser, and it was wrong. Fixed it. This only affects the Dictionary pop-up panel.

4:09 PM Changeset in webkit [19868] by hyatt

2 edits in trunk/WebCore

Make text files render using white-space: pre-wrap instead of white-space: pre.

Reviewed by aroben

loader/TextDocument.cpp: (WebCore::TextTokenizer::write):

3:53 PM Changeset in webkit [23000] by hyatt

1 edit in branches/WindowsMerge/WebCore/platform/win/ScrollViewWin.cpp

Fix Boomer.

3:24 PM Changeset in webkit [19867] by hyatt

3 edits in trunk/LayoutTests/fast/overflow

Update expected results for overflow test.

3:22 PM Changeset in webkit [19866] by hyatt

7 edits in trunk/WebCore

Back out the change to add fullyClippedContentRect. The layout test
was actually showing more correct results.

page/Frame.cpp: (WebCore::Frame::visibleSelectionRect): (WebCore::Frame::setIsActive): (WebCore::Frame::markAllMatchesForText):
platform/ScrollView.h:
platform/mac/ScrollViewMac.mm:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):

3:14 PM Changeset in webkit [22999] by aroben

3 edits in branches/WindowsMerge/WebCore

Build fix.

config.h: Remove redundant #define.
WebCore.vcproj/WebCore.vcproj: Update to new macros.

2:55 PM Changeset in webkit [19865] by hyatt

2 edits in trunk/WebKit

Update web inspector to account for border-fit.

Reviewed by darin

WebInspector/webInspector/inspector.js:

2:43 PM Changeset in webkit [19864] by ggaren

4 edits in trunk/WebKit

Reviewed by Darin Adler.

Re-arranged things to put deprecated methods at the bottom.

Misc/WebCoreStatistics.h:
Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptNoGCAllowedObjectsCount]): (+[WebCoreStatistics javaScriptReferencedObjectsCount]): (+[WebCoreStatistics javaScriptRootObjectClasses]):
WebKit.xcodeproj/project.pbxproj:

2:42 PM Changeset in webkit [19863] by hyatt

1 edit
8 adds in trunk/LayoutTests

Land layout test demonstrating border-fit.

Reviewed by darin

fast/borders/border-fit-expected.checksum: Added.
fast/borders/border-fit-expected.png: Added.
fast/borders/border-fit-expected.txt: Added.
fast/borders/border-fit.html: Added.
fast/borders/resources/Balloon_12641896.tiff: Added.
fast/borders/resources/Balloon_8107502.tiff: Added.
fast/borders/resources/largePerson.png: Added.

2:40 PM Changeset in webkit [22998] by aroben

2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Ada.

platform/graphics/svg/cg/SVGResourceFilterCg.cpp: Make #if match the header file.

2:36 PM Changeset in webkit [19862] by hyatt

12 edits in trunk/WebCore

Add support for a new property called -webkit-border-fit. This property
has two values: border and lines. The "border" value means the border and
background paint normally at the border box level. The "lines" value indicates
that the border and background should shrink dynamically to snugly hug the
line boxes of normal flow descendants.

Reviewed by darin

fast/borders/border-fit.html

WebCore.xcodeproj/project.pbxproj:
css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSPropertyNames.in:
css/CSSValueKeywords.in:
css/cssparser.cpp: (WebCore::CSSParser::parseValue):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::adjustForBorderFit): (WebCore::RenderBlock::borderFitAdjust):
rendering/RenderBlock.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations):
rendering/RenderBox.h: (WebCore::RenderBox::borderFitAdjust):
rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::RenderStyle::diff):
rendering/RenderStyle.h: (WebCore::): (WebCore::RenderStyle::borderFit): (WebCore::RenderStyle::setBorderFit): (WebCore::RenderStyle::initialBorderFit):

2:33 PM Changeset in webkit [22997] by aroben

4 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

Build fix.

WebCore.vcproj/build-generated-files.sh: Updated FEATURE_DEFINES.
platform/graphics/svg/cg/SVGResourceFilterCg.cpp: Use shiny new ENABLE(SVG).
platform/graphics/svg/cg/SVGResourceMaskerCg.cpp: Ditto.

2:32 PM Changeset in webkit [19861] by mjs

3 edits in trunk/WebKit

Rubber stamped by Mitz.

fix layout tests by fixing discrepancy in feature macros.

WebInspector/WebInspector.m: (-_highlightNode:):
WebKit.xcodeproj/project.pbxproj:

2:30 PM Changeset in webkit [19860] by aroben

2 edits in trunk/WebCore

Reviewed by Darin.

Build fix.

rendering/RenderTreeAsText.cpp: Can't use #ifndef with ENABLE() macro.

1:49 PM Changeset in webkit [19859] by adele

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Adam.

Test for <rdar://problem/4990700> Safari always crashes when attempting to edit/view
Yahoo pipes in WebCore::HTMLSelectElement::optionToListIndex

fast/forms/select-out-of-bounds-index-expected.txt: Added.
fast/forms/select-out-of-bounds-index.html: Added.

WebCore:

Reviewed by Adam.

Fix for <rdar://problem/4990700> Safari always crashes when attempting to edit/view
Yahoo pipes in WebCore::HTMLSelectElement::optionToListIndex

Test: fast/forms/select-out-of-bounds-index.html

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): If we're about to deselect all options, then set m_lastOnChangeIndex to -1. (WebCore::HTMLSelectElement::optionToListIndex): Moved listSize to a local variable. Rewrote using a simpler for-loop to prevent out-of-bounds errors.

1:11 PM Changeset in webkit [19858] by andersca

2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4816376>
REGRESSION: NetNewsWire 3.0 - Crashes in WebDocumentLoaderMac::attachToFrame() (12674)

loader/FrameLoader.cpp: (WebCore::FrameLoader::reload): Remove call to setPolicyDocumentLoader here, it's set by the ::load function that we end up calling.

12:49 PM Changeset in webkit [19857] by brmorris

2 edits in S60/branches/3.1m/WebCore

vbradley, reviewed by Zalan

DESC: [S60] MLIO-6YCACU: Browser freeze and panic in symbianoggplay.sourceforge.com
http://bugs.webkit.org/show_bug.cgi?id=12831

12:49 PM Changeset in webkit [19856] by brmorris

2 edits in S60/trunk/WebCore

vbradley, reviewed by Zalan

DESC: [S60] MLIO-6YCACU: Browser freeze and panic in symbianoggplay.sourceforge.com
http://bugs.webkit.org/show_bug.cgi?id=12831

11:29 AM Changeset in webkit [19855] by mjs

676 edits in trunk

JavaScriptCore:

Reviewed by Lars.

<rdar://problem/5021698> Disable experimental SVG features (12883)

wtf/Platform.h: Add ENABLE() macro similar to HAVE() and USE(), to allow nicer handling of optional WebKit features.

WebCore:

Reviewed by Lars.

fixed <rdar://problem/5021698> Disable experimental SVG features (12883)

I added an ENABLE_SVG_EXPERIMENTAL_FEATURES define to guard all use of the experimental
features, and used it to guard relevant tag names, elements, JS bindings and renderers.

I also converted all the existing optional feature defines to
ENABLE_FOO instead of FOO_SUPPORT since that is the more standard
way to do it in open source projects and works with the handy new
ENABLE() macro.

CMakeLists.txt:
DerivedSources.make:
Projects/gdk/webcore-gdk.bkl:
WebCore.pro:
WebCore.vcproj/WebCore/WebCore.vcproj:
WebCore.vcproj/WebCore/build-generated-files.sh:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSCustomXPathNSResolver.cpp:
bindings/js/JSCustomXPathNSResolver.h:
bindings/js/JSSVGElementWrapperFactory.cpp:
bindings/js/JSSVGElementWrapperFactory.h:
bindings/js/JSSVGMatrixCustom.cpp:
bindings/js/JSSVGPODTypeWrapper.h:
bindings/js/JSSVGPathSegCustom.cpp:
bindings/js/JSSVGPathSegListCustom.cpp:
bindings/js/JSSVGPointListCustom.cpp:
bindings/js/JSXSLTProcessor.cpp:
bindings/js/JSXSLTProcessor.h:
bindings/js/kjs_binding.cpp: (KJS::setDOMException):
bindings/js/kjs_css.cpp: (KJS::toJS):
bindings/js/kjs_dom.cpp: (KJS::toJS):
bindings/js/kjs_html.cpp: (KJS::HTMLElementFunction::callAsFunction):
bindings/js/kjs_proxy.cpp:
bindings/js/kjs_proxy.h:
bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
bindings/objc/DOM.mm: (WebCore::createElementClassMap): (+[DOMNode _nodeWith:WebCore::]):
bindings/objc/DOMCSS.mm: (+[DOMCSSValue _CSSValueWith:WebCore::]):
bindings/objc/DOMCustomXPathNSResolver.h:
bindings/objc/DOMCustomXPathNSResolver.mm:
bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:WebCore::]):
bindings/objc/DOMInternal.h:
bindings/objc/DOMSVGPathSegInternal.mm:
bindings/objc/DOMXPath.mm:
bindings/objc/ExceptionHandlers.mm: (WebCore::raiseDOMException):
bindings/objc/PublicDOMInterfaces.h:
bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/CodeGeneratorObjC.pm:
config.h:
css/CSSGrammar.y:
css/CSSStyleDeclaration.cpp: (WebCore::propertyID):
css/StyleBase.h:
css/cssparser.cpp: (WebCore::CSSParser::parseValue):
css/cssparser.h:
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::checkPseudoState): (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty):
css/cssstyleselector.h:
dom/DOMImplementation.cpp: (WebCore::DOMImplementation::hasFeature): (WebCore::DOMImplementation::createDocument):
dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::createElement): (WebCore::Document::implicitClose): (WebCore::Document::recalcStyleSelector): (WebCore::Document::createEvent):
dom/Document.h:
dom/Document.idl:
dom/Event.cpp:
dom/Event.h:
dom/EventTarget.cpp:
dom/EventTarget.h:
dom/MappedAttributeEntry.h: (WebCore::):
dom/Node.cpp: (WebCore::Node::createRendererIfNeeded): (WebCore::Node::shadowAncestorNode):
dom/Node.h:
dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::ProcessingInstruction): (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::setCSSStyleSheet):
dom/ProcessingInstruction.h:
dom/Text.cpp: (WebCore::Text::createRenderer):
dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs): (WebCore::XMLTokenizer::endElementNs): (WebCore::XMLTokenizer::processingInstruction): (WebCore::XMLTokenizer::end): (WebCore::XMLTokenizer::insertErrorMessageBlock):
dom/XMLTokenizer.h:
html/HTMLEmbedElement.cpp:
html/HTMLEmbedElement.h:
html/HTMLObjectElement.cpp:
html/HTMLObjectElement.h:
ksvg2/css/SVGCSSParser.cpp:
ksvg2/css/SVGCSSStyleSelector.cpp:
ksvg2/css/SVGRenderStyle.cpp:
ksvg2/css/SVGRenderStyle.h:
ksvg2/css/SVGRenderStyleDefs.cpp:
ksvg2/css/SVGRenderStyleDefs.h:
ksvg2/events/JSSVGLazyEventListener.cpp:
ksvg2/events/JSSVGLazyEventListener.h:
ksvg2/events/SVGZoomEvent.cpp:
ksvg2/events/SVGZoomEvent.h:
ksvg2/misc/KCanvasRenderingStyle.cpp:
ksvg2/misc/KCanvasRenderingStyle.h:
ksvg2/misc/PointerEventsHitRules.cpp:
ksvg2/misc/PointerEventsHitRules.h:
ksvg2/misc/SVGDocumentExtensions.cpp:
ksvg2/misc/SVGDocumentExtensions.h:
ksvg2/misc/SVGImageLoader.cpp:
ksvg2/misc/SVGImageLoader.h:
ksvg2/misc/SVGTimer.cpp:
ksvg2/misc/SVGTimer.h:
ksvg2/misc/TimeScheduler.cpp:
ksvg2/misc/TimeScheduler.h:
ksvg2/scripts/make_names.pl:
ksvg2/svg/ColorDistance.cpp:
ksvg2/svg/ColorDistance.h:
ksvg2/svg/GradientAttributes.h:
ksvg2/svg/LinearGradientAttributes.h:
ksvg2/svg/PatternAttributes.h:
ksvg2/svg/RadialGradientAttributes.h:
ksvg2/svg/SVGAElement.cpp:
ksvg2/svg/SVGAElement.h:
ksvg2/svg/SVGAngle.cpp:
ksvg2/svg/SVGAngle.h:
ksvg2/svg/SVGAnimateColorElement.cpp:
ksvg2/svg/SVGAnimateColorElement.h:
ksvg2/svg/SVGAnimateElement.cpp:
ksvg2/svg/SVGAnimateElement.h:
ksvg2/svg/SVGAnimateElement.idl:
ksvg2/svg/SVGAnimateMotionElement.cpp:
ksvg2/svg/SVGAnimateMotionElement.h:
ksvg2/svg/SVGAnimateTransformElement.cpp:
ksvg2/svg/SVGAnimateTransformElement.h:
ksvg2/svg/SVGAnimateTransformElement.idl:
ksvg2/svg/SVGAnimatedPathData.cpp:
ksvg2/svg/SVGAnimatedPathData.h:
ksvg2/svg/SVGAnimatedPoints.cpp:
ksvg2/svg/SVGAnimatedPoints.h:
ksvg2/svg/SVGAnimatedTemplate.h:
ksvg2/svg/SVGAnimationElement.cpp:
ksvg2/svg/SVGAnimationElement.h:
ksvg2/svg/SVGCircleElement.cpp:
ksvg2/svg/SVGCircleElement.h:
ksvg2/svg/SVGClipPathElement.cpp:
ksvg2/svg/SVGClipPathElement.h:
ksvg2/svg/SVGColor.cpp:
ksvg2/svg/SVGColor.h:
ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
ksvg2/svg/SVGComponentTransferFunctionElement.h:
ksvg2/svg/SVGCursorElement.cpp:
ksvg2/svg/SVGCursorElement.h:
ksvg2/svg/SVGDefsElement.cpp:
ksvg2/svg/SVGDefsElement.h:
ksvg2/svg/SVGDescElement.cpp:
ksvg2/svg/SVGDescElement.h:
ksvg2/svg/SVGDocument.cpp:
ksvg2/svg/SVGDocument.h:
ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::dispatchEvent):
ksvg2/svg/SVGElement.h:
ksvg2/svg/SVGElementInstance.cpp:
ksvg2/svg/SVGElementInstance.h:
ksvg2/svg/SVGElementInstance.idl:
ksvg2/svg/SVGElementInstanceList.cpp:
ksvg2/svg/SVGElementInstanceList.h:
ksvg2/svg/SVGElementInstanceList.idl:
ksvg2/svg/SVGEllipseElement.cpp:
ksvg2/svg/SVGEllipseElement.h:
ksvg2/svg/SVGException.h:
ksvg2/svg/SVGExternalResourcesRequired.cpp:
ksvg2/svg/SVGExternalResourcesRequired.h:
ksvg2/svg/SVGFEBlendElement.cpp:
ksvg2/svg/SVGFEBlendElement.h:
ksvg2/svg/SVGFEBlendElement.idl:
ksvg2/svg/SVGFEColorMatrixElement.cpp:
ksvg2/svg/SVGFEColorMatrixElement.h:
ksvg2/svg/SVGFEColorMatrixElement.idl:
ksvg2/svg/SVGFEComponentTransferElement.cpp:
ksvg2/svg/SVGFEComponentTransferElement.h:
ksvg2/svg/SVGFEComponentTransferElement.idl:
ksvg2/svg/SVGFECompositeElement.cpp:
ksvg2/svg/SVGFECompositeElement.h:
ksvg2/svg/SVGFECompositeElement.idl:
ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
ksvg2/svg/SVGFEDiffuseLightingElement.h:
ksvg2/svg/SVGFEDiffuseLightingElement.idl:
ksvg2/svg/SVGFEDisplacementMapElement.cpp:
ksvg2/svg/SVGFEDisplacementMapElement.h:
ksvg2/svg/SVGFEDisplacementMapElement.idl:
ksvg2/svg/SVGFEDistantLightElement.cpp:
ksvg2/svg/SVGFEDistantLightElement.h:
ksvg2/svg/SVGFEDistantLightElement.idl:
ksvg2/svg/SVGFEFloodElement.cpp:
ksvg2/svg/SVGFEFloodElement.h:
ksvg2/svg/SVGFEFloodElement.idl:
ksvg2/svg/SVGFEFuncAElement.cpp:
ksvg2/svg/SVGFEFuncAElement.h:
ksvg2/svg/SVGFEFuncAElement.idl:
ksvg2/svg/SVGFEFuncBElement.cpp:
ksvg2/svg/SVGFEFuncBElement.h:
ksvg2/svg/SVGFEFuncBElement.idl:
ksvg2/svg/SVGFEFuncGElement.cpp:
ksvg2/svg/SVGFEFuncGElement.h:
ksvg2/svg/SVGFEFuncGElement.idl:
ksvg2/svg/SVGFEFuncRElement.cpp:
ksvg2/svg/SVGFEFuncRElement.h:
ksvg2/svg/SVGFEFuncRElement.idl:
ksvg2/svg/SVGFEGaussianBlurElement.cpp:
ksvg2/svg/SVGFEGaussianBlurElement.h:
ksvg2/svg/SVGFEGaussianBlurElement.idl:
ksvg2/svg/SVGFEImageElement.cpp:
ksvg2/svg/SVGFEImageElement.h:
ksvg2/svg/SVGFEImageElement.idl:
ksvg2/svg/SVGFELightElement.cpp:
ksvg2/svg/SVGFELightElement.h:
ksvg2/svg/SVGFEMergeElement.cpp:
ksvg2/svg/SVGFEMergeElement.h:
ksvg2/svg/SVGFEMergeElement.idl:
ksvg2/svg/SVGFEMergeNodeElement.cpp:
ksvg2/svg/SVGFEMergeNodeElement.h:
ksvg2/svg/SVGFEMergeNodeElement.idl:
ksvg2/svg/SVGFEOffsetElement.cpp:
ksvg2/svg/SVGFEOffsetElement.h:
ksvg2/svg/SVGFEOffsetElement.idl:
ksvg2/svg/SVGFEPointLightElement.cpp:
ksvg2/svg/SVGFEPointLightElement.h:
ksvg2/svg/SVGFEPointLightElement.idl:
ksvg2/svg/SVGFESpecularLightingElement.cpp:
ksvg2/svg/SVGFESpecularLightingElement.h:
ksvg2/svg/SVGFESpecularLightingElement.idl:
ksvg2/svg/SVGFESpotLightElement.cpp:
ksvg2/svg/SVGFESpotLightElement.h:
ksvg2/svg/SVGFESpotLightElement.idl:
ksvg2/svg/SVGFETileElement.cpp:
ksvg2/svg/SVGFETileElement.h:
ksvg2/svg/SVGFETileElement.idl:
ksvg2/svg/SVGFETurbulenceElement.cpp:
ksvg2/svg/SVGFETurbulenceElement.h:
ksvg2/svg/SVGFETurbulenceElement.idl:
ksvg2/svg/SVGFilterElement.cpp:
ksvg2/svg/SVGFilterElement.h:
ksvg2/svg/SVGFilterElement.idl:
ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
ksvg2/svg/SVGFitToViewBox.cpp:
ksvg2/svg/SVGFitToViewBox.h:
ksvg2/svg/SVGForeignObjectElement.cpp:
ksvg2/svg/SVGForeignObjectElement.h:
ksvg2/svg/SVGForeignObjectElement.idl:
ksvg2/svg/SVGGElement.cpp:
ksvg2/svg/SVGGElement.h:
ksvg2/svg/SVGGradientElement.cpp:
ksvg2/svg/SVGGradientElement.h:
ksvg2/svg/SVGImageElement.cpp:
ksvg2/svg/SVGImageElement.h:
ksvg2/svg/SVGLangSpace.cpp:
ksvg2/svg/SVGLangSpace.h:
ksvg2/svg/SVGLength.cpp:
ksvg2/svg/SVGLength.h:
ksvg2/svg/SVGLengthList.cpp:
ksvg2/svg/SVGLengthList.h:
ksvg2/svg/SVGLineElement.cpp:
ksvg2/svg/SVGLineElement.h:
ksvg2/svg/SVGLinearGradientElement.cpp:
ksvg2/svg/SVGLinearGradientElement.h:
ksvg2/svg/SVGList.h:
ksvg2/svg/SVGListTraits.h:
ksvg2/svg/SVGLocatable.cpp: (WebCore::SVGLocatable::nearestViewportElement): (WebCore::SVGLocatable::farthestViewportElement):
ksvg2/svg/SVGLocatable.h:
ksvg2/svg/SVGMPathElement.cpp:
ksvg2/svg/SVGMPathElement.h:
ksvg2/svg/SVGMarkerElement.cpp:
ksvg2/svg/SVGMarkerElement.h:
ksvg2/svg/SVGMaskElement.cpp:
ksvg2/svg/SVGMaskElement.h:
ksvg2/svg/SVGMetadataElement.cpp:
ksvg2/svg/SVGMetadataElement.h:
ksvg2/svg/SVGNumberList.cpp:
ksvg2/svg/SVGNumberList.h:
ksvg2/svg/SVGPaint.cpp:
ksvg2/svg/SVGPaint.h:
ksvg2/svg/SVGParserUtilities.cpp:
ksvg2/svg/SVGParserUtilities.h:
ksvg2/svg/SVGPathElement.cpp:
ksvg2/svg/SVGPathElement.h:
ksvg2/svg/SVGPathSeg.h:
ksvg2/svg/SVGPathSegArc.cpp:
ksvg2/svg/SVGPathSegArc.h:
ksvg2/svg/SVGPathSegClosePath.cpp:
ksvg2/svg/SVGPathSegClosePath.h:
ksvg2/svg/SVGPathSegCurvetoCubic.cpp:
ksvg2/svg/SVGPathSegCurvetoCubic.h:
ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp:
ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp:
ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
ksvg2/svg/SVGPathSegLineto.cpp:
ksvg2/svg/SVGPathSegLineto.h:
ksvg2/svg/SVGPathSegLinetoHorizontal.cpp:
ksvg2/svg/SVGPathSegLinetoHorizontal.h:
ksvg2/svg/SVGPathSegLinetoVertical.cpp:
ksvg2/svg/SVGPathSegLinetoVertical.h:
ksvg2/svg/SVGPathSegList.cpp:
ksvg2/svg/SVGPathSegList.h:
ksvg2/svg/SVGPathSegMoveto.cpp:
ksvg2/svg/SVGPathSegMoveto.h:
ksvg2/svg/SVGPatternElement.cpp:
ksvg2/svg/SVGPatternElement.h:
ksvg2/svg/SVGPointList.cpp:
ksvg2/svg/SVGPointList.h:
ksvg2/svg/SVGPolyElement.cpp:
ksvg2/svg/SVGPolyElement.h:
ksvg2/svg/SVGPolygonElement.cpp:
ksvg2/svg/SVGPolygonElement.h:
ksvg2/svg/SVGPolylineElement.cpp:
ksvg2/svg/SVGPolylineElement.h:
ksvg2/svg/SVGPreserveAspectRatio.cpp:
ksvg2/svg/SVGPreserveAspectRatio.h:
ksvg2/svg/SVGRadialGradientElement.cpp:
ksvg2/svg/SVGRadialGradientElement.h:
ksvg2/svg/SVGRectElement.cpp:
ksvg2/svg/SVGRectElement.h:
ksvg2/svg/SVGRenderingIntent.h:
ksvg2/svg/SVGSVGElement.cpp:
ksvg2/svg/SVGSVGElement.h:
ksvg2/svg/SVGScriptElement.cpp:
ksvg2/svg/SVGScriptElement.h:
ksvg2/svg/SVGSetElement.cpp:
ksvg2/svg/SVGSetElement.h:
ksvg2/svg/SVGStopElement.cpp:
ksvg2/svg/SVGStopElement.h:
ksvg2/svg/SVGStringList.cpp:
ksvg2/svg/SVGStringList.h:
ksvg2/svg/SVGStylable.cpp:
ksvg2/svg/SVGStylable.h:
ksvg2/svg/SVGStyleElement.cpp:
ksvg2/svg/SVGStyleElement.h:
ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::notifyAttributeChange):
ksvg2/svg/SVGStyledElement.h:
ksvg2/svg/SVGStyledLocatableElement.cpp:
ksvg2/svg/SVGStyledLocatableElement.h:
ksvg2/svg/SVGStyledTransformableElement.cpp:
ksvg2/svg/SVGStyledTransformableElement.h:
ksvg2/svg/SVGSwitchElement.cpp:
ksvg2/svg/SVGSwitchElement.h:
ksvg2/svg/SVGSymbolElement.cpp:
ksvg2/svg/SVGSymbolElement.h:
ksvg2/svg/SVGTRefElement.cpp:
ksvg2/svg/SVGTRefElement.h:
ksvg2/svg/SVGTSpanElement.cpp:
ksvg2/svg/SVGTSpanElement.h:
ksvg2/svg/SVGTests.cpp:
ksvg2/svg/SVGTests.h:
ksvg2/svg/SVGTextContentElement.cpp:
ksvg2/svg/SVGTextContentElement.h:
ksvg2/svg/SVGTextElement.cpp:
ksvg2/svg/SVGTextElement.h:
ksvg2/svg/SVGTextPositioningElement.cpp:
ksvg2/svg/SVGTextPositioningElement.h:
ksvg2/svg/SVGTitleElement.cpp:
ksvg2/svg/SVGTitleElement.h:
ksvg2/svg/SVGTransform.cpp:
ksvg2/svg/SVGTransform.h:
ksvg2/svg/SVGTransformDistance.cpp:
ksvg2/svg/SVGTransformDistance.h:
ksvg2/svg/SVGTransformList.cpp:
ksvg2/svg/SVGTransformList.h:
ksvg2/svg/SVGTransformable.cpp:
ksvg2/svg/SVGTransformable.h:
ksvg2/svg/SVGURIReference.cpp:
ksvg2/svg/SVGURIReference.h:
ksvg2/svg/SVGUnitTypes.h:
ksvg2/svg/SVGUseElement.cpp:
ksvg2/svg/SVGUseElement.h:
ksvg2/svg/SVGUseElement.idl:
ksvg2/svg/SVGViewElement.cpp:
ksvg2/svg/SVGViewElement.h:
ksvg2/svg/SVGZoomAndPan.cpp:
ksvg2/svg/SVGZoomAndPan.h:
ksvg2/svg/svgtags.in:
loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::getStatistics):
loader/Cache.h:
loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
loader/CachedResource.h: (WebCore::CachedResource::):
loader/CachedResourceClient.h:
loader/CachedXBLDocument.cpp:
loader/CachedXBLDocument.h:
loader/CachedXSLStyleSheet.cpp:
loader/CachedXSLStyleSheet.h:
loader/DocLoader.cpp:
loader/DocLoader.h:
page/DOMWindow.idl:
page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::selectCursor):
page/Frame.cpp: (WebCore::Frame::Frame):
page/PageState.cpp: (WebCore::PageState::PageState): (WebCore::PageState::restore):
platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedNonImageMimeTypes):
platform/graphics/FloatPoint3D.cpp:
platform/graphics/FloatPoint3D.h:
platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::renderSubtreeToImage):
platform/graphics/svg/SVGImage.cpp:
platform/graphics/svg/SVGImage.h:
platform/graphics/svg/SVGImageEmptyClients.h:
platform/graphics/svg/SVGPaintServer.cpp:
platform/graphics/svg/SVGPaintServer.h:
platform/graphics/svg/SVGPaintServerGradient.cpp:
platform/graphics/svg/SVGPaintServerGradient.h:
platform/graphics/svg/SVGPaintServerLinearGradient.cpp:
platform/graphics/svg/SVGPaintServerLinearGradient.h:
platform/graphics/svg/SVGPaintServerPattern.cpp:
platform/graphics/svg/SVGPaintServerPattern.h:
platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
platform/graphics/svg/SVGPaintServerRadialGradient.h:
platform/graphics/svg/SVGPaintServerSolid.cpp:
platform/graphics/svg/SVGPaintServerSolid.h:
platform/graphics/svg/SVGResource.cpp:
platform/graphics/svg/SVGResource.h:
platform/graphics/svg/SVGResourceClipper.cpp:
platform/graphics/svg/SVGResourceClipper.h:
platform/graphics/svg/SVGResourceFilter.cpp:
platform/graphics/svg/SVGResourceFilter.h:
platform/graphics/svg/SVGResourceMarker.cpp:
platform/graphics/svg/SVGResourceMarker.h:
platform/graphics/svg/SVGResourceMasker.cpp:
platform/graphics/svg/SVGResourceMasker.h:
platform/graphics/svg/cg/CgSupport.cpp:
platform/graphics/svg/cg/CgSupport.h:
platform/graphics/svg/cg/RenderPathCg.cpp:
platform/graphics/svg/cg/SVGPaintServerCg.cpp:
platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp:
platform/graphics/svg/cg/SVGPaintServerSolidCg.cpp:
platform/graphics/svg/cg/SVGResourceClipperCg.cpp:
platform/graphics/svg/cg/SVGResourceFilterCg.mm:
platform/graphics/svg/cg/SVGResourceMaskerCg.mm:
platform/graphics/svg/filters/SVGDistantLightSource.h:
platform/graphics/svg/filters/SVGFEBlend.cpp:
platform/graphics/svg/filters/SVGFEBlend.h:
platform/graphics/svg/filters/SVGFEColorMatrix.cpp:
platform/graphics/svg/filters/SVGFEColorMatrix.h:
platform/graphics/svg/filters/SVGFEComponentTransfer.cpp:
platform/graphics/svg/filters/SVGFEComponentTransfer.h:
platform/graphics/svg/filters/SVGFEComposite.cpp:
platform/graphics/svg/filters/SVGFEComposite.h:
platform/graphics/svg/filters/SVGFEConvolveMatrix.cpp:
platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
platform/graphics/svg/filters/SVGFEDiffuseLighting.cpp:
platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
platform/graphics/svg/filters/SVGFEDisplacementMap.cpp:
platform/graphics/svg/filters/SVGFEDisplacementMap.h:
platform/graphics/svg/filters/SVGFEFlood.cpp:
platform/graphics/svg/filters/SVGFEFlood.h:
platform/graphics/svg/filters/SVGFEGaussianBlur.cpp:
platform/graphics/svg/filters/SVGFEGaussianBlur.h:
platform/graphics/svg/filters/SVGFEImage.cpp:
platform/graphics/svg/filters/SVGFEImage.h:
platform/graphics/svg/filters/SVGFEMerge.cpp:
platform/graphics/svg/filters/SVGFEMerge.h:
platform/graphics/svg/filters/SVGFEMorphology.cpp:
platform/graphics/svg/filters/SVGFEMorphology.h:
platform/graphics/svg/filters/SVGFEOffset.cpp:
platform/graphics/svg/filters/SVGFEOffset.h:
platform/graphics/svg/filters/SVGFESpecularLighting.cpp:
platform/graphics/svg/filters/SVGFESpecularLighting.h:
platform/graphics/svg/filters/SVGFETile.h:
platform/graphics/svg/filters/SVGFETurbulence.cpp:
platform/graphics/svg/filters/SVGFETurbulence.h:
platform/graphics/svg/filters/SVGFilterEffect.cpp:
platform/graphics/svg/filters/SVGFilterEffect.h:
platform/graphics/svg/filters/SVGLightSource.cpp:
platform/graphics/svg/filters/SVGLightSource.h:
platform/graphics/svg/filters/SVGPointLightSource.h:
platform/graphics/svg/filters/SVGSpotLightSource.h:
platform/graphics/svg/filters/cg/SVGFEBlendCg.mm:
platform/graphics/svg/filters/cg/SVGFEColorMatrixCg.mm:
platform/graphics/svg/filters/cg/SVGFEComponentTransferCg.mm:
platform/graphics/svg/filters/cg/SVGFECompositeCg.mm:
platform/graphics/svg/filters/cg/SVGFEDiffuseLightingCg.mm:
platform/graphics/svg/filters/cg/SVGFEDisplacementMapCg.mm:
platform/graphics/svg/filters/cg/SVGFEFloodCg.mm:
platform/graphics/svg/filters/cg/SVGFEGaussianBlurCg.mm:
platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
platform/graphics/svg/filters/cg/SVGFEHelpersCg.mm:
platform/graphics/svg/filters/cg/SVGFEImageCg.mm:
platform/graphics/svg/filters/cg/SVGFEMergeCg.mm:
platform/graphics/svg/filters/cg/SVGFEOffsetCg.mm:
platform/graphics/svg/filters/cg/SVGFESpecularLightingCg.mm:
platform/graphics/svg/filters/cg/SVGFETileCg.mm:
platform/graphics/svg/filters/cg/SVGFilterEffectCg.mm:
platform/graphics/svg/qt/SVGPaintServerGradientQt.cpp:
platform/graphics/svg/qt/SVGPaintServerLinearGradientQt.cpp:
platform/graphics/svg/qt/SVGPaintServerPatternQt.cpp:
platform/graphics/svg/qt/SVGPaintServerQt.cpp:
platform/graphics/svg/qt/SVGPaintServerRadialGradientQt.cpp:
platform/graphics/svg/qt/SVGPaintServerSolidQt.cpp:
platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
platform/graphics/svg/qt/SVGResourceFilterQt.cpp:
platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteImageURL): (WebCore::HitTestResult::absoluteLinkURL): (WebCore::HitTestResult::isLiveLink):
rendering/RenderForeignObject.cpp:
rendering/RenderForeignObject.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::isTransparent):
rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock):
rendering/RenderObject.h:
rendering/RenderPath.cpp:
rendering/RenderPath.h:
rendering/RenderSVGBlock.cpp:
rendering/RenderSVGBlock.h:
rendering/RenderSVGContainer.cpp:
rendering/RenderSVGContainer.h:
rendering/RenderSVGGradientStop.cpp:
rendering/RenderSVGGradientStop.h:
rendering/RenderSVGHiddenContainer.cpp:
rendering/RenderSVGHiddenContainer.h:
rendering/RenderSVGImage.cpp:
rendering/RenderSVGImage.h:
rendering/RenderSVGInline.cpp:
rendering/RenderSVGInline.h:
rendering/RenderSVGInlineText.cpp:
rendering/RenderSVGInlineText.h:
rendering/RenderSVGTSpan.cpp:
rendering/RenderSVGTSpan.h:
rendering/RenderSVGText.cpp:
rendering/RenderSVGText.h:
rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::RenderStyle::RenderStyle): (WebCore::RenderStyle::inheritFrom): (WebCore::RenderStyle::operator==): (WebCore::RenderStyle::inheritedNotEqual): (WebCore::RenderStyle::diff):
rendering/RenderStyle.h:
rendering/RenderText.cpp: (WebCore::RenderText::setStyle): (WebCore::RenderText::setTextInternal):
rendering/RenderTreeAsText.cpp: (WebCore::write): (WebCore::externalRepresentation):
rendering/SVGInlineFlowBox.cpp:
rendering/SVGInlineFlowBox.h:
rendering/SVGRenderTreeAsText.cpp:
rendering/SVGRenderTreeAsText.h:
rendering/SVGRootInlineBox.cpp:
rendering/SVGRootInlineBox.h:
rendering/bidi.cpp: (WebCore::shouldPreserveNewline): (WebCore::RenderBlock::findNextLineBreak):
webcore-base.bkl:
xml/NativeXPathNSResolver.cpp:
xml/NativeXPathNSResolver.h:
xml/XPathEvaluator.cpp:
xml/XPathEvaluator.h:
xml/XPathExpression.cpp:
xml/XPathExpression.h:
xml/XPathExpressionNode.cpp:
xml/XPathExpressionNode.h:
xml/XPathFunctions.cpp:
xml/XPathFunctions.h:
xml/XPathGrammar.y:
xml/XPathNSResolver.cpp:
xml/XPathNSResolver.h:
xml/XPathNamespace.cpp:
xml/XPathNamespace.h:
xml/XPathParser.cpp:
xml/XPathParser.h:
xml/XPathPath.cpp:
xml/XPathPath.h:
xml/XPathPredicate.cpp:
xml/XPathPredicate.h:
xml/XPathResult.cpp:
xml/XPathResult.h:
xml/XPathStep.cpp:
xml/XPathStep.h:
xml/XPathUtil.cpp:
xml/XPathUtil.h:
xml/XPathValue.cpp:
xml/XPathValue.h:
xml/XPathVariableReference.cpp:
xml/XPathVariableReference.h:
xml/XSLImportRule.cpp:
xml/XSLImportRule.h:
xml/XSLStyleSheet.cpp:
xml/XSLStyleSheet.h:
xml/XSLTProcessor.cpp:
xml/XSLTProcessor.h:

11:18 AM Changeset in webkit [19854] by brmorris

2 edits in S60/branches/3.1m/WebKit

spadma, reviewed by Yongjun

DESC: Urls are doubly encoded HIIN-6YMGYV

11:16 AM Changeset in webkit [19853] by brmorris

2 edits in S60/trunk/WebKit

spadma, reviewed by Yongjun

DESC: Urls are doubly encoded HIIN-6YMGYV

Feb 25, 2007:

9:31 PM Changeset in webkit [19852] by bdash

3 edits
4 adds in trunk

2007-02-25 Mitz Pettel <mitz@webkit.org>

Reviewed by David Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=12886 Crash with Scriptalicious javascript library

Test: fast/dynamic/float-withdrawal.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Detect when a child block had intruding floats in a previous layout, and in that case force it to relayout.

2007-02-25 Mitz Pettel <mitz@webkit.org>

Reviewed by David Hyatt.

test for http://bugs.webkit.org/show_bug.cgi?id=12886 Crash with Scriptalicious javascript library

fast/dynamic/float-withdrawal-expected.checksum: Added.
fast/dynamic/float-withdrawal-expected.png: Added.
fast/dynamic/float-withdrawal-expected.txt: Added.
fast/dynamic/float-withdrawal.html: Added.

7:00 PM Changeset in webkit [19851] by hyatt

3 edits in trunk/WebCore

Revert my change to the default fill color. Just set the color to transparent explicitly when
drawing textarea resizer frames.

platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintOverflowControls):

6:28 PM Changeset in webkit [19850] by weinig

2 edits in trunk/WebCore

Update forgotten files.

rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):

6:07 PM Changeset in webkit [19849] by hyatt

1 edit in trunk/WebCore/page/FrameView.cpp

Forgot to land FrameView.cpp in previous commit.

5:29 PM Changeset in webkit [19848] by hyatt

5 edits in trunk/WebCore

Fix for regression caused by changing the containing block of positioned elements with no positioned ancestor
to be the initial containing block (represented in our tree by the RenderView). Rework RenderView's layout
to have very few special cases. Now it will just relayout its children when the width/height of the
view actually changes. Positioned elements no longer get a special additional layout, since width/height
adjustments are caught by the base class already anyway.

Reviewed by mjs, darin

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutVerticalBox):
rendering/RenderView.cpp: (WebCore::RenderView::RenderView): (WebCore::RenderView::layout):
rendering/RenderView.h:

4:47 PM Changeset in webkit [22996] by mjs

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

fixed layout test failure in fast/overflow/scrollRevealButton

I added a new ScrollView method, fullyClippedContentRect, that vies the content rect
as clipped by all ancestor scroll views, not just this one. Currently it only works
correctly on mac however. visibleContentRect, only accounting for the clipping from
this particular scroll view, is sufficient for most purposes.

platform/win/ScrollViewWin.cpp: (WebCore::ScrolView::fullyClippedContentRect):

4:41 PM Changeset in webkit [19847] by mjs

3 edits in trunk/WebCore

Not reviewed, build fix.

fix build breakage

platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::fullyClippedContentRect):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::fullyClippedContentRect):

3:44 PM Changeset in webkit [19846] by mjs

7 edits in trunk/WebCore

Reviewed by Adam.

fixed layout test failure in fast/overflow/scrollRevealButton

I added a new ScrollView method, fullyClippedContentRect, that vies the content rect
as clipped by all ancestor scroll views, not just this one. Currently it only works
correctly on mac however. visibleContentRect, only accounting for the clipping from
this particular scroll view, is sufficient for most purposes.

page/Frame.cpp: (WebCore::Frame::visibleSelectionRect): (WebCore::Frame::setIsActive): (WebCore::Frame::markAllMatchesForText):
platform/ScrollView.h:
platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrolView::fullyClippedContentRect):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::fullyClippedContentRect):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrolView::fullyClippedContentRect):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):

2:23 PM Changeset in webkit [19845] by andersca

2 edits in trunk/WebKitSite

Reviewed by Maciej.

building/checkout.html: Add Trac link to our SVN repository,

Feb 24, 2007:

11:20 PM Changeset in webkit [22995] by aroben

2 edits in branches/WindowsMerge/WebCore

Change #if to #ifdef to match style.

platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show):

11:14 PM Changeset in webkit [22994] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

Fix <rdar://problem/5013502> REGRESSION: <select> menus are not
animating smoothly

This was caused by making the menus partially transparent in r12250.

platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): Disable animations.

11:12 PM Changeset in webkit [19844] by aroben

2 edits in trunk/WebCore

Reviewed by Steve.

"Look Up in Dictionary" context menu item should be Mac-only for now,
since it's only implemented on that platform (<rdar://problem/5021468>)

platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Wrap all instances of the dictionary menu item in #if PLATFORM(MAC).

8:35 PM Changeset in webkit [22993] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

2007-02-24 Steve Falkenburg <sfalken@apple.com>

Pre-emptive build fix.
Removed CGPThreads DLL copy

WebKit.vcproj/WebKit.vcproj:

6:14 PM Changeset in webkit [19843] by ggaren

5 edits
5 adds in trunk

LayoutTests:

Reviewed by Darin Adler.

Layout tests for BidiRun leaks.

fast/leaks/001-expected.txt: Added.
fast/leaks/001.html: Added.
fast/leaks/002-expected.txt: Added.
fast/leaks/002.html: Added.

WebCore:

Reviewed by Darin Adler.

Fixed <rdar://problem/4987649> leaks in BidiRun::operator new seen while
running WebKit unit tests

In bidi.cpp, some functions allocate BidiRuns and put them in a global data
structure, while others uses the BidiRuns in the global data structure.
The caller is responsible for knowing which functions may allocate runs
and which may use them, and calling deleteBidiRuns() at the appropriate time.

The fix is to add some calls to deleteBidiRuns() where they were missing.

I also added a BidiRun counter because these two leaks were introduced by
our two bidi.cpp experts, so the odds that leaks will creep in again
in the future seem pretty high.

rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderCharacters): Added missing call to deleteBidiRuns(). (WebCore::BidiRunCounter::~BidiRunCounter): (WebCore::BidiRun::operator delete): (WebCore::RenderBlock::layoutInlineChildren): Added missing call to deleteBidiRuns(). Moved call to deleteBidiRuns() to same scope as call to bidiReorderLine(), to emphasize that they go together like new/delete. In theory, the old code was just as good, but I didn't want to rely on theory.

WebKitTools:

Reviewed by Darin Adler.

Scripts/run-webkit-tests: Stop ignoring BidiRun leaks, now that they're fixed.

6:35 AM Changeset in webkit [19842] by harrison

2 edits in trunk/WebCore

Reviewed by Kevin.

<rdar://problem/4961431> Image with empty string alt tag should be ignored

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityIsIgnored]): Ignore img element that has an alt attribute, but that string is empty.

5:14 AM Changeset in webkit [19841] by zack

2 edits in trunk/WebKitQt

Adjust the animation a little bit to make it more natural.

3:14 AM Changeset in webkit [19840] by ap

4 edits in trunk/LayoutTests

Reviewed by Anders.

Fix the test not to include any custom content in its auto-generated HTML wrapper.

fast/js/resources/select-options-add.js:
fast/js/select-options-add-expected.txt:
fast/js/select-options-add.html:

12:45 AM Changeset in webkit [19839] by kjk

6 edits in trunk

WebCore:

Reviewed by Adam Roben.

Gdk improvements.

platform/gdk/FrameGdk.cpp: only scroll on keydown, not both keydown and keyup. (WebCore::FrameGdk::keyPress): (WebCore::FrameGdk::handleGdkEvent): (WebCore::Frame::print): (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::dragImageForSelection):
platform/network/gdk/ResourceHandleManager.cpp: don't free memory that doesn't belong to us. (WebCore::ResourceHandleManager::downloadTimerCallback):

WebKitTools:

Reviewed by Adam Roben.

Improve gdklauncher: add text field for entering url.

GdkLauncher/gdklauncher.bkl:
GdkLauncher/main.cpp: (strEmpty): (strEq): (handleGdkEvent): (goToUrlBarText): (goButtonClickedCb): (urlBarEnterCb): (registerRenderingAreaEvents): (frameResizeCb): (frameDestroyCb): (main):

Feb 23, 2007:

11:42 PM Changeset in webkit [19838] by kdecker

3 edits in trunk/WebCore

Reviewed by Anders.

Fixed: <rdar://problem/4971226> REGRESSION: Replying to closed HTML mail message does not quote original body (12503)

There were two problems here:

page/mac/WebCoreFrameBridge.mm: (+[WebCoreFrameBridge stringWithData:textEncodingName:]): The old code said "if there is no text encoding name than assume WindowsLatin1 (iso-8859-1) and try to decode that". That's not sufficient because it doesn't handle the fallback case for unknown encodings. This method will now attempt to decode using WindowsLatin1 for unknown encoding types.
platform/mac/mac-encodings.txt: Added the missing "macroman" encoding type.

8:35 PM Changeset in webkit [22992] by andersca

2 adds in branches/WindowsMerge/LayoutTests

Reviewed by Adam.

<rdar://problem/4516049>
Basic Infrastructure: Get regression tests running.

Make boomer-run-webkit-tests work with our internal setup.

Scripts/boomer-run-webkit-tests:

6:55 PM Changeset in webkit [19837] by weinig

4 edits in trunk

LayoutTests:

Reviewed by Maciej.

updated test result for http://bugs.webkit.org/show_bug.cgi?id=12856 REGRESSION (r13685): Canceling the suggestion popup does not revert the change

editing/deleting/delete-3800834-fix-expected.txt:

WebCore:

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=12856 REGRESSION (r13685): Canceling the suggestion popup does not revert the change

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): If the fragment to be inserted is empty, first delete the selection, and only then bail out.

6:52 PM Changeset in webkit [19836] by andersca

2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5001923>
REGRESSION: Crash when navigating forward from an error page in WebFrameLoaderClient::dispatchDidReceiveContentLength

Fix an error that was introduced in revision r18541. We should check if the provisional document loader
has an unreachable URL, not the actual document loader.

loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForCommit):

6:35 PM Changeset in webkit [19835] by weinig

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Darin.

test for http://bugs.webkit.org/show_bug.cgi?id=12823 REGRESSION(r16968-16977): unable to prevent selection by cancelling "selectstart" event

fast/events/selectstart-during-autoscroll-expected.txt: Added.
fast/events/selectstart-during-autoscroll.html: Added.

WebCore:

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=12823 REGRESSION(r16968-16977): unable to prevent selection by cancelling "selectstart" event

Test: fast/events/selectstart-during-autoscroll.html

rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Invoke the renderer's shouldSelect() -- which dispatches the selection DOM event and gives it a chance to cancel the selection -- before updating the selection during autoscroll.

6:22 PM Changeset in webkit [19834] by weinig

2 edits in trunk/WebKit

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=11573 REGRESSION: pressing option-left arrow while in suggestion popup moves the insertion point to the left

WebView/WebHTMLView.mm: (-[WebTextCompleteController endRevertingChange:moveLeft:]):

6:21 PM Changeset in webkit [22991] by andersca

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4761543>
nike.com doesn't finish loading if Flash plugin is installed.

If a plugin requests a JavaScript URL with a non null frame target, execute the JavaScript expression. If the result
is not "undefined", replace the contents of the frame with the result converted to a string.

plugins/win/PluginViewWin.cpp: (WebCore::getString): (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::requestTimerFired):

5:25 PM Changeset in webkit [19833] by oliver

1 edit in trunk/WebCore/ChangeLog

Correcting ChangeLog

5:22 PM Changeset in webkit [19832] by oliver

2 edits
1 add in trunk/WebCore

2007-02-23 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Fix for http://bugs.webkit.org/show_bug.cgi?id=12870

It turns out short circuiting DragData::containsURL() was bad

ChangeLog:
WebCore.xcodeproj/project.pbxproj:
manual-tests/directory-drop-on-view.html: Added.
platform/mac/DragDataMac.mm: (WebCore::DragData::containsURL):

2:35 PM Changeset in webkit [19831] by brmorris

2 edits in S60/trunk/WebKit

forrest, reviewed by sachin

DESC: re-insert ability to handle EDoNothing case for disposition of downloaded content SXUU-6XZ232

11:13 AM Changeset in webkit [19830] by thatcher

5 edits in trunk/WebKit

Reviewed by Brady.

<rdar://problem/5016395> _recursive_pauseNullEventsForAllNetscapePlugins still gone

WebView/WebFrameInternal.h: Remove _recursive_pauseNullEventsForAllNetscapePlugins
WebView/WebFramePrivate.h: Add _recursive_pauseNullEventsForAllNetscapePlugins
WebView/WebFrame.mm: More _recursive_pauseNullEventsForAllNetscapePlugins

8:43 AM Changeset in webkit [19829] by mjs

1 edit in trunk/WebCore/ChangeLog

Added missing bug numbers.

8:32 AM Changeset in webkit [19828] by mjs

3 edits in trunk/WebCore

Reviewed by Mitz.

12.5% speedup on BenchJS test 6

It turns out that calling documentVisibleRect on an NSScrollView is pretty expensive,
and calling visibleRect even more so. Take measures to call them less often.

platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::visibleContentRect): Use documentVisibleRect when possible. (WebCore::ScrollView::updateContents): Use visibleContentRect to be able to use documentVisibleRect when possible.
rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle): Don't get or intersect with viewRect if we don't have a parent frame, since the ScrollView will do that anyway. Also, don't get contentX and contentY separately since they are in the viewRect already. (WebCore::RenderView::viewRect): Use visibleContentRect instead of getting each coordinate individually, to avoid calling documentVisibleRect repeatedly.

8:25 AM Changeset in webkit [19827] by mjs