Timeline



Mar 9, 2007:

7:23 PM Changeset in webkit [23055] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-03-09 Oliver Hunt <​oliver@apple.com>

Reviewed by John.

Fix the doubled text in the image used to drag a link

  • platform/win/WebCoreTextRenderer.cpp: (WebCore::WebCoreDrawDoubledTextAtPoint):


5:06 PM Changeset in webkit [23054] by andersca
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Implement setting the suggested filename for a response.


  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::filenameFromHTTPContentDisposition): (WebCore::filenameHasSaneExtension): (WebCore::suggestedFilenameForResponse): (WebCore::ResourceResponse::doUpdateResourceResponse):
  • platform/win/MimeTypeRegistryWin.cpp: (WebCore::getMIMETypeForUTI):


(WebCore::mimeTypeForExtension):
Fix two bugs in this function.


(WebCore::MimeTypeRegistry::getPreferredExtensionForMIMEType):

WebKitWin:

Reviewed by Adam.

  • WebURLResponse.cpp: (WebURLResponse::suggestedFilename): Get the suggested filename from the ResourceResponse object.
4:41 PM Changeset in webkit [20095] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

Force diff to treat files that svn-create-patch thinks are text as text.

  • Scripts/svn-create-patch: Added -a switch to diff command.
4:07 PM Changeset in webkit [23053] by andersca
  • 2 edits in branches/WindowsMerge/WebKitTools

WebKitToolsWin:

Reviewed by Adam.

Fix build and do some general cleanup.


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: (WaitUntilDoneDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): (WaitUntilDoneDelegate::didFailProvisionalLoadWithError): (WaitUntilDoneDelegate::didCommitLoadForFrame): (WaitUntilDoneDelegate::didReceiveIcon): (WaitUntilDoneDelegate::didFailLoadWithError): (WaitUntilDoneDelegate::didChangeLocationWithinPageForFrame): (WaitUntilDoneDelegate::willPerformClientRedirectToURL): (WaitUntilDoneDelegate::didCancelClientRedirectForFrame): (WaitUntilDoneDelegate::willCloseFrame): (WaitUntilDoneDelegate::createWebViewWithRequest): (WaitUntilDoneDelegate::webViewShow): (WaitUntilDoneDelegate::webViewClose): (WaitUntilDoneDelegate::webViewFocus): (WaitUntilDoneDelegate::webViewUnfocus): (WaitUntilDoneDelegate::webViewFirstResponder): (WaitUntilDoneDelegate::makeFirstResponder): (WaitUntilDoneDelegate::setStatusText): (WaitUntilDoneDelegate::webViewStatusText): (WaitUntilDoneDelegate::webViewAreToolbarsVisible): (WaitUntilDoneDelegate::setToolbarsVisible): (WaitUntilDoneDelegate::webViewIsStatusBarVisible): (WaitUntilDoneDelegate::setStatusBarVisible): (WaitUntilDoneDelegate::webViewIsResizable): (WaitUntilDoneDelegate::setResizable): (WaitUntilDoneDelegate::setFrame): (WaitUntilDoneDelegate::webViewFrame): (WaitUntilDoneDelegate::setContentRect): (WaitUntilDoneDelegate::webViewContentRect): (WaitUntilDoneDelegate::runJavaScriptConfirmPanelWithMessage): (WaitUntilDoneDelegate::runJavaScriptTextInputPanelWithPrompt): (WaitUntilDoneDelegate::runBeforeUnloadConfirmPanelWithMessage): (WaitUntilDoneDelegate::runOpenPanelForFileButtonWithResultListener): (WaitUntilDoneDelegate::mouseDidMoveOverElement): (WaitUntilDoneDelegate::contextMenuItemsForElement): (WaitUntilDoneDelegate::validateUserInterfaceItem): (WaitUntilDoneDelegate::shouldPerformAction): (WaitUntilDoneDelegate::dragDestinationActionMaskForDraggingInfo): (WaitUntilDoneDelegate::willPerformDragDestinationAction): (WaitUntilDoneDelegate::dragSourceActionMaskForPoint): (WaitUntilDoneDelegate::willPerformDragSourceAction): (WaitUntilDoneDelegate::contextMenuItemSelected): (WaitUntilDoneDelegate::trackCustomPopupMenu): (WaitUntilDoneDelegate::measureCustomMenuItem): (WaitUntilDoneDelegate::drawCustomMenuItem): (WaitUntilDoneDelegate::cleanUpCustomMenuDrawingData): (WaitUntilDoneDelegate::canTakeFocus): (WaitUntilDoneDelegate::takeFocus): (WaitUntilDoneDelegate::registerUndoWithTarget): (WaitUntilDoneDelegate::removeAllActionsWithTarget): (WaitUntilDoneDelegate::setActionTitle): (WaitUntilDoneDelegate::undo): (WaitUntilDoneDelegate::redo): (WaitUntilDoneDelegate::canUndo): (WaitUntilDoneDelegate::canRedo): (WaitUntilDoneDelegate::addCustomMenuDrawingData):
2:58 PM Changeset in webkit [20094] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4976254> Please get off _NSSoftLinkingGetFrameworkFuncPtr

Use dlopen and dlsym to access the DCSShowDictionaryServiceWindow function.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
12:02 PM Changeset in webkit [23052] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Rubberstamped by Steve.

B&I build fix.

  • WebKit.vcproj/WebKit.vcproj: Removed all references to iconv.
11:45 AM Changeset in webkit [20093] by darin
  • 2 edits in trunk/WebKitSite
  • blog/wp-content/themes/webkit/style.css: Removed rule for code since we want it to match pre, and the default font looks fine -- no need to ask for "Courier New" explicitly.
10:54 AM Changeset in webkit [20092] by darin
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Justin.

  • editing/pasteboard/paste-xml-expected.checksum: Added.
  • editing/pasteboard/paste-xml-expected.png: Added.
  • editing/pasteboard/paste-xml-expected.txt: Added.
  • editing/pasteboard/paste-xml.xhtml: Added.

WebCore:

Reviewed by Justin.

Test: editing/pasteboard/paste-xml.xhtml

  • editing/markup.cpp: (WebCore::createFragmentFromMarkup): Added a check for 0 here, since createContextualFragment can return 0 for XML documents that fail to parse. In my testing, callers all seem equipped to handle 0.

WebKit:

Reviewed by Justin.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _hasHTMLDocument]): Added. (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Don't call AppKit's conversion from the DOM to an attributed string if the document is not an HTML document, to work around an AppKit limitation (Radar 5052390).
8:32 AM Changeset in webkit [23051] by andersca
  • 2 edits in branches/WindowsMerge/WebCore
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): Fixup comments and remove an obsolete FIXME.
8:19 AM Changeset in webkit [20091] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
8:05 AM Changeset in webkit [20090] by weinig
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • http/tests/misc/onload-remove-iframe-crash-2-expected.txt: Added.
  • http/tests/misc/onload-remove-iframe-crash-2.html: Added.
  • http/tests/misc/resources/onload-remove-iframe-crash-2.html: Added.
  • http/tests/misc/resources/onload-remove-iframe.html: Added.

WebCore:

Reviewed by Darin.

Test: http/tests/misc/onload-remove-iframe-crash-2.html

The resulted from an iframe's load event handler removing the iframe
from the document.

  • dom/Document.cpp: (WebCore::Document::implicitClose): Bail out early if an event handler removed the frame.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::checkCompleted): Protect the frame from deletion by event handlers. (WebCore::FrameLoader::checkCompletedTimerFired): (WebCore::FrameLoader::scheduleCheckCompleted): (WebCore::FrameLoader::detachFromParent): Schedule a completion check on the parent (in case the child is what has been keeping it from completing).
  • loader/FrameLoader.h:
4:35 AM Changeset in webkit [20089] by rwlbuis
  • 1 edit in trunk/WebCore/ChangeLog

I forgot to commit my ChangeLog as part of r20028, sorry about that.

2:00 AM Changeset in webkit [20088] by bdash
  • 3 edits
    2 deletes in trunk

Roll out r20078 as it's causing a crash during layout tests.

1:23 AM Changeset in webkit [23050] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

1:20 AM Changeset in webkit [20087] by sfalken
  • 1 copy in tags/Safari-521.35.7b

New tag.

1:08 AM Changeset in webkit [23049] by oliver
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Forgot to save changelog with reviewer name, correcting

1:01 AM Changeset in webkit [23048] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-03-09 Oliver Hunt <​oliver@apple.com>

Reviewed by Steve.

Executing a script for a plugin can cause cause this to be deleted
so we take a reference to our parent prior to executing the script

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):

Mar 8, 2007:

11:59 PM Changeset in webkit [23047] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-03-08 Oliver Hunt <​oliver@apple.com>

WebCoreWin:

Allow webloc files to be dropped onto the webview


<rdar://problem/4883564> Regression: cannot open webloc file by dnd to Boomer's window

  • platform/win/DragDataWin.cpp: (WebCore::cfHDropFormat):

Clipboard format for HDROP, non-static as i will need it elsewhere in the future

(WebCore::getWebLocData):

Extract a url from a webloc file

(WebCore::getURL):

Call getWebLocData


11:20 PM Changeset in webkit [23046] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-03-08 Steve Falkenburg <​sfalken@apple.com>

Fix B&I build more

  • WebCore.vcproj/WebCore.vcproj:
10:23 PM Changeset in webkit [20086] by bdash
  • 4 edits in tags/Safari-4522.4

Versioning.

10:18 PM Changeset in webkit [20085] by bdash
  • 1 copy in tags/Safari-4522.4

New tag.

10:05 PM Changeset in webkit [20084] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Beth.

No tests added since LayoutTests/fast/forms/document-write.html was timing out
and causing a layout test failure.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Removed stray code.
9:52 PM Changeset in webkit [23045] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-03-08 Steve Falkenburg <​sfalken@apple.com>

B&I build fix

  • WebCore.vcproj/WebCore.vcproj:
8:55 PM Changeset in webkit [20083] by kjk
  • 2 edits in trunk/WebCore

Not reviewed - gdk build fix.

  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameIsCompleteAtIndex): add empty stub
8:23 PM Changeset in webkit [20082] by bdash
  • 2 edits in trunk/WebKit

2007-03-08 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/5051616> Mouse clicks and movement are ignored in HIWebView on 64-bit

Mouse events are not being handled correctly as GetControlKind is returning an error
on 64-bit. The more modern HIObjectIsOfClass behaves correctly for this use.

  • Carbon/HIWebView.m: (HIWebViewDestructor): (WindowHandler): Use HIObjectIsOfClass in place of GetControlKind. (HIWebViewEventHandler): Don't leak the NSEvent.
8:06 PM Changeset in webkit [20081] by bdash
  • 2 edits in trunk/WebKitTools

2007-03-09 Mark Rowe <​mrowe@apple.com>

Unreviewed. Use the new SVN URL on the buildbot.

  • BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
7:57 PM Changeset in webkit [20080] by bdash
  • 1 edit
    1 add in trunk/WebKitSite

2007-03-09 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Tim Hatcher.

Sexy blog permalinks!

  • blog/.htaccess: Added.
7:11 PM Changeset in webkit [20079] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-03-08 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13018
Bug 13018: allow embedders to override the definition of CRASH.

  • wtf/Assertions.h: make it possible to override CRASH.
7:08 PM Changeset in webkit [20078] by bdash
  • 3 edits
    2 adds in trunk

2007-03-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Brady.

Test: fast/loader/onunload-form-submit-crash-2.html

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::finishedLoading): Added null check.

2007-03-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Brady.

  • fast/loader/onunload-form-submit-crash-2-expected.txt: Added.
  • fast/loader/onunload-form-submit-crash-2.html: Added.
7:02 PM Changeset in webkit [20077] by bdash
  • 2 edits in trunk/WebKit

2007-03-08 Bruce Q Hammond <​bruceq@apple.om>

Reviewed by Darin.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13009
Console spews "CGContextGetType: invalid context" non-stop on web site

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView restorePortState:]):
6:37 PM Changeset in webkit [20076] by bdash
  • 2 edits in trunk/WebKitSite

2007-03-09 Mark Rowe <​mrowe@apple.com>

Reviewed by Adam.

  • building/checkout.html: Update repository URL.
6:37 PM Changeset in webkit [20075] by justing
  • 31 edits in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4903193>
On particular page, Copy is so slow it seems like a hang

Less messy DOM trees:

  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/inserting/insert-3786362-fix-expected.txt:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/pasteboard/display-block-on-spans-expected.txt:
  • editing/pasteboard/paste-4035648-fix-expected.txt:
  • editing/pasteboard/paste-4039777-fix-expected.txt:
  • editing/pasteboard/paste-line-endings-001-expected.txt:
  • editing/pasteboard/paste-line-endings-006-expected.txt:
  • editing/pasteboard/paste-list-001-expected.txt:
  • editing/pasteboard/paste-pre-001-expected.txt:
  • editing/pasteboard/paste-pre-002-expected.txt:
  • editing/pasteboard/paste-table-001-expected.txt:
  • editing/pasteboard/paste-table-002-expected.txt:
  • editing/pasteboard/paste-text-003-expected.txt:
  • editing/pasteboard/paste-text-011-expected.txt:
  • editing/pasteboard/paste-text-015-expected.txt:
  • editing/pasteboard/paste-text-016-expected.txt:
  • editing/pasteboard/paste-text-017-expected.txt:
  • editing/pasteboard/styled-element-markup-expected.txt:
  • editing/pasteboard/testcase-9507-expected.txt:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:
  • fast/lists/drag-into-marker-expected.txt: Styles from style sheets are now inlined:
  • webarchive/test-duplicate-resources-expected.txt:
  • webarchive/test-frameset-expected.txt:
  • webarchive/test-link-href-expected.txt:\ Two levels of nesting are removed, but text nodes are no longer coalesced when they should be, investigating:
  • editing/pasteboard/block-wrappers-necessary-expected.txt:

WebCore:

Reviewed by harrison


<rdar://problem/4903193>
On particular page, Copy is so slow it seems like a hang


~2x speedup copying:
​http://shakespeare.mit.edu/henryviii/full.html
Also produces less bloated markup.

  • editing/markup.cpp: (WebCore::startMarkup): Don't wrap text nodes in style spans. For Elements, don't inline styles inherited from ancestors. (WebCore::createMarkup): No longer necessary to find the root's default style and pass it to startMarkup. Add a wrapper span around the markup with the styles that all nodes in the markup inherit (the inheritable styles from the common ancestor container's computed style). Added a FIXME about unecessary markup for inline ancestors up to the commonAncestorBlock.
6:25 PM Changeset in webkit [20074] by darin
  • 3 edits in trunk/WebCore

Reviewed by Adele.

  • <rdar://problem/4470381> multipart/form-data boundary security vulnerability

By making the form data boundary a string with some random data in it, we reduce
the possibility that anyone could take advantage of it by creating a file that
intentionally has the boundary string in it.

  • html/HTMLFormElement.h: Removed boundary(), setBoundary(), and m_boundary. Marked a lot more stuff private.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): Removed code to initialize m_boundary. (WebCore::randomNumber): Added. Function that returns a random number, including seeding the random number generator the first time it's called. For now, usees the more random function random() on Mac OS X and the more-standard rand() on other platforms. (WebCore::HTMLFormElement::formData): Take a parameter with the form boundary string, and use that instead of m_boundary. (WebCore::getUniqueBoundaryString): Added. Makes a boundary string using random numbers and base 64 encoding. (WebCore::HTMLFormElement::submit): Call getUniqueBoundaryString and pass the boundary string into formData for multipart form posts.
6:15 PM Changeset in webkit [20073] by bdash
  • 7 edits
    1 delete in trunk/WebKit

2007-03-08 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/4561772> HIWebView does not exist for 64-bit

Update HIWebView and friends to work without QuickDraw.

Changes are gleaned from the 64-bit support inside HICocoaView. The main
fact of interest are that all Carbon windows must have compositing enabled
so the code paths that aren't accessible are #ifdef'd out. Conveniently
these are the exact code paths that make use of QuickDraw.

There are currently minor event-handling and invalidation issues running as
64-bit that are not present in 32-bit.

  • Carbon/CarbonUtils.m:
  • Carbon/CarbonWindowAdapter.m:
  • Carbon/CarbonWindowFrame.m:
  • Carbon/HIViewAdapter.m: (SetViewNeedsDisplay):
  • Carbon/HIWebView.m: (Draw): (Click): (SyncFrame): (StartUpdateObserver): (StopUpdateObserver): (UpdateObserver):
  • WebKit.LP64.exp: Removed.
  • WebKit.xcodeproj/project.pbxproj: Always use WebKit.exp.
6:12 PM Changeset in webkit [20072] by mjs
  • 14 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adele.

<rdar://problem/4646563> REGRESSION: Unable to send text message from Verizon text message website: vtext.com (12588)
​http://bugs.webkit.org/show_bug.cgi?id=12588

Carefully revised which focus operations restore previous selection, which clear it, and which
select the whole control contents, these test cases cover every focus call I could find.


  • fast/forms/focus-selection-input-expected.txt: Added.
  • fast/forms/focus-selection-input.html: Added.
  • fast/forms/focus-selection-textarea-expected.txt: Added.
  • fast/forms/focus-selection-textarea.html: Added.
  • fast/forms/onselect-textfield-expected.txt:

WebCore:

Reviewed by Adele.


<rdar://problem/4646563> REGRESSION: Unable to send text message from Verizon text message website: vtext.com (12588)
​http://bugs.webkit.org/show_bug.cgi?id=12588

Carefully revised which focus operations restore previous selection, which clear it, and which
select the whole control contents.


Tests:
fast/forms/focus-selection-input.html
fast/forms/focus-selection-textarea.html


  • dom/Element.cpp: (WebCore::Element::focus):
  • dom/Element.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::focus): (WebCore::HTMLInputElement::accessKeyAction):
  • html/HTMLInputElement.h:
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::focus): (WebCore::HTMLLabelElement::accessKeyAction):
  • html/HTMLLabelElement.h:
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::focus):
  • html/HTMLLegendElement.h:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::focus):
  • html/HTMLTextAreaElement.h:
  • page/FocusController.cpp: (WebCore::FocusController::advanceFocus):
4:33 PM Changeset in webkit [20071] by justing
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by harrison


<​http://bugs.webkit.org/show_bug.cgi?id=12244>
FCKeditor: Find dialog doesn't work

  • editing/execCommand/12244-expected.txt: Added.
  • editing/execCommand/12244.html: Added.
  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by harrison

<​http://bugs.webkit.org/show_bug.cgi?id=12244>
FCKeditor: Find dialog doesn't work

  • bindings/js/kjs_window.cpp: (KJS::Window::find): Added. This function doesn't yet support whole word searches, searching in subframes, or opening the find dialog. (KJS::WindowFunc::callAsFunction):
  • bindings/js/kjs_window.h: (KJS::Window::):
3:58 PM Changeset in webkit [20070] by hyatt
  • 4 edits in trunk/WebCore

Fix regression from throwing away frames of large animated images. Alter
animated images so that they refuse to advance the animation until the
current displayed frame has been fully decoded.

Reviewed by ggaren

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::startAnimation): (WebCore::BitmapImage::advanceAnimation):
  • platform/graphics/ImageSource.h:
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameIsCompleteAtIndex):
3:45 PM Changeset in webkit [23044] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Steve.


Fix <rdar://problem/4969070> Failed error pages show "unknown error"
rather than specific error

Make ResourceError aware of kCFErrorDomainCFNetwork.

  • platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::ResourceError): Added case for kCFErrorDomainCFNetwork.
3:33 PM Changeset in webkit [20069] by hyatt
  • 2 edits in trunk/WebCore

Fix 2% performance regression on the PLT. Increase the large animated
image cutoff from 1MB to 5MB.

In addition when pruning we will aggressively discard image sources.

Reviewed by ggaren

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData):
2:42 PM Changeset in webkit [20068] by justing
  • 1 edit in trunk/LayoutTests/fast/dom/Range/13000-expected.txt
2:16 PM Changeset in webkit [20067] by thatcher
  • 12 edits in trunk

WebCore:

Reviewed by John.

<rdar://problem/4664697> highlighter SPI needs a node parameter to give more context

Pass the RenderObject's node to customHighlightLineRect and paintCustomHighlight.

  • page/Frame.h:
  • page/mac/FrameMac.mm: (WebCore::Frame::customHighlightLineRect): (WebCore::Frame::paintCustomHighlight):
  • page/mac/WebCoreFrameBridge.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintCustomHighlight):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintCustomHighlight):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::addHighlightOverflow): (WebCore::RootInlineBox::paintCustomHighlight):

WebKit:

Reviewed by John.

<rdar://problem/4664697> highlighter SPI needs a node parameter to give more context

Added new methods to the WebHTMLHighlighter protocol that include the DOMNode being painted.

  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge customHighlightRect:forLine:representedNode:WebCore::]): (-[WebFrameBridge paintCustomHighlight:forBox:onLine:behindText:entireLine:representedNode:WebCore::]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLViewPrivate.h:
2:00 PM Changeset in webkit [20066] by justing
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by harrison


<​http://bugs.webkit.org/show_bug.cgi?id=13000>
Range.createContextualFragment is not supported

  • fast/dom/Range/13000-expected.txt: Added.
  • fast/dom/Range/13000.html: Added.

WebCore:

Reviewed by harrison


<​http://bugs.webkit.org/show_bug.cgi?id=13000>
Range.createContextualFragment is not supported

  • dom/Range.cpp: (WebCore::Range::createContextualFragment): The "startContainer" may not be a container, if the range starts inside text. In that case, look to the parent of the start node for an HTMLElement.
12:49 PM Changeset in webkit [20065] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar::/problem/5049671>
Gmail Editor: With linked text, Remove Formatting doesn't always remove underline

  • editing/execCommand/5049671-expected.checksum: Added.
  • editing/execCommand/5049671-expected.png: Added.
  • editing/execCommand/5049671-expected.txt: Added.
  • editing/execCommand/5049671.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/5049671>
Gmail Editor: With linked text, Remove Formatting doesn't always remove underline

  • editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): Clear removed anchors after the deletion.
10:33 AM Changeset in webkit [20064] by thatcher
  • 1 edit in trunk/WebKit/Plugins/WebBaseNetscapePluginView.mm

Attempt to fix the build.

9:47 AM Changeset in webkit [20063] by brmorris
  • 3 edits in S60/trunk/S60Internals

brmorris, reviewed by nobody (bustage fix)

DESC: add some icons to fix build bustage caused by r20034

7:03 AM Changeset in webkit [20062] by ddkilzer
  • 1 edit
    1 add in trunk/WebCore

WebCore:

Reviewed by NOBODY (build fix).

Added missing file for r20059:
<rdar://problem/4708689> -- REGRESSION: Some symbols with 2-byte display as garbage in Hotmail.

File was taken from this svn repository which contained versions of ucnv.h and ucnv_err.h
that were identical to ours:
​http://source.icu-project.org/repos/icu/icu/tags/release-3-2/source/common/unicode/ucnv_cb.h

  • icu/unicode/ucnv_cb.h: Added.
5:57 AM Changeset in webkit [20061] by bdash
  • 2 edits in trunk/WebCore

2007-03-09 Shrikant Gangoda <​shrikant.gangoda@celunite.com>

Gdk build fix.

  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::~ImageSource): (WebCore::ImageSource::clear):
4:09 AM Changeset in webkit [20060] by bdash
  • 2 edits in trunk/WebKitTools

2007-03-08 Mark Rowe <​mrowe@apple.com>

Reviewed by Antti.

Fix compiler warnings when building Drosera as 64-bit.

  • Drosera/DebuggerDocument.m: (-[DebuggerDocument breakpointEditorHTML]): Move away from deprecated NSString method. (-[DebuggerDocument scriptConfirmSheetDidEnd:returnCode:contextInfo:]): Update type. (-[DebuggerDocument webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]): Update type to accommodate constant.
3:08 AM Changeset in webkit [20059] by oliver
  • 6 edits in trunk

2007-03-08 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

WebCore:

To match old TEC behaviour when using ICU we need to use
a few manual fallback encodings for the GBK/EUC-CN charsets

<rdar://problem/4708689> -- REGRESSION: Some symbols with 2-byte display as garbage in Hotmail.

  • platform/TextCodecICU.cpp: (WebCore::TextCodecICU::TextCodecICU): (WebCore::TextCodecICU::createICUConverter): (WebCore::gbkEscapes): (WebCore::gbkCallbackEscape): (WebCore::gbkCallbackSubstitute): (WebCore::TextCodecICU::encode):
  • platform/TextCodecICU.h: (WebCore::TextCodecICU::needsGBKFallbacks): (WebCore::TextCodecICU::setNeedsGBKFallbacks):


LayoutTests:

Adding GBK character encoding tests

  • fast/encoding/char-encoding-expected.txt:
  • fast/encoding/char-encoding.html:


2:00 AM Changeset in webkit [23043] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix.


  • WebView.cpp: (WebView::isLoading):
1:21 AM Changeset in webkit [23042] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

Implement WebView::isLoading.


  • WebView.cpp: (WebView::isLoading):
1:12 AM Changeset in webkit [20058] by andersca
  • 2 edits in trunk/WebKit

Try fixing the buildbot build.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
12:48 AM Changeset in webkit [20057] by ap
  • 5 edits in trunk

WebCore:

Build fix.

  • xml/XPathUtil.cpp: (WebCore::XPath::stringValue):

LayoutTests:

Added a test for attribute node string-value.

  • fast/xpath/string-value-expected.txt:
  • fast/xpath/string-value.html:
12:43 AM Changeset in webkit [20056] by hyatt
  • 4 edits in trunk/WebCore

This patch dramatically reduces the memory consumed by animated images. For large animated GIFs (defined for
now as >1mb in terms of decoded frame buffer size), we will now aggressively flush previous frames of the
animated GIF and just re-decode them on the fly if the animation loops.

Whenever a large animated GIF has its animation reset, we will also just throw out everything and start
the animation over (in order to get rid of any cached detritus held in the ImageSource).

With this patch and the sample GIF used to test, WebKit's memory consumption went from 160MB down to 16MB.

Reviewed by mjs

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData): (WebCore::BitmapImage::resetAnimation): (WebCore::BitmapImage::advanceAnimation):
  • platform/graphics/ImageSource.h:
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::~ImageSource): (WebCore::ImageSource::clear):
12:16 AM Changeset in webkit [20055] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13006
XPath string-value is broken for some node types

Test: fast/xpath/string-value.html

  • xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Fix it :-)
12:02 AM Changeset in webkit [20054] by ddkilzer
  • 1 edit in trunk/WebKit/ChangeLog

Added bug number and fixed email address.

Mar 7, 2007:

11:15 PM Changeset in webkit [20053] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/4981000>
​http://bugs.webkit.org/show_bug.cgi?id=12634
REGRESSION: crash loading web archive (12634)


The reason this bug wasn't always reproducible is that it involved sending an event to a plugin while
the page was loading. Before we send the event to the plugin we defer loads. The problem was that
MainResourceLoader::setDefersLoad would not work with data loads.


  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setRequest): Only set m_committed to false if we also have a valid unreachable URL.


  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::setDefersLoading): Make sure to stop and start data loads.
11:01 PM Changeset in webkit [20052] by kjk
  • 4 edits in trunk/WebCore

Not reviewed.

Gdk build fixes.

  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::handleKeypress): renamed (WebCore::EditorClientGdk::handleInputMethodKeypress): add a stub
  • platform/gdk/EditorClientGdk.h:
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::destroyFrameAtIndex): add a stub
10:52 PM Changeset in webkit [23041] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Rubberstamped by Anders.

Return E_POINTER for null parameters.

  • WebScrollBar.cpp: (WebScrollBar::value): (WebScrollBar::capturingMouse): (WebScrollBar::frameGeometry): (WebScrollBar::width): (WebScrollBar::height): (WebScrollBar::requestedWidth): (WebScrollBar::requestedHeight): (WebScrollBar::windowClipRect):
10:47 PM Changeset in webkit [23040] by aroben
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Oliver.

Added requestedWidth and requestedHeight methods to WebScrollBar.

  • Interfaces/IWebScrollBarPrivate.idl: Added new declarations.
  • WebScrollBar.cpp: (WebScrollBar::requestedWidth): Implemented. (WebScrollBar::requestedHeight): Implemented.
  • WebScrollBar.h: Added method declarations.
9:36 PM Changeset in webkit [23039] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Rubberstamped by Anders.

  • WebFrame.cpp: (WebFrame::cancelledError): Use the WebURLErrorDomain constant. (WebFrame::interruptForPolicyChangeError): Use the WebKitErrorDomain constant.
7:47 PM Changeset in webkit [20051] by weinig
  • 14 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13004
Repeatedly calling XPathExpression.evaluate() causes crashes or memory leaks

  • fast/xpath/evaluate-twice-expected.txt: Added.
  • fast/xpath/evaluate-twice.html: Added.

WebCore:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13004
Repeatedly calling XPathExpression.evaluate() causes crashes or memory leaks

Removed XPath::Expression::optimize() and related methods, since they were buggy and almost useless.
Merged doEvaluate() into evaluate(), since this was all evaluate() was doing after the above changes.

Test: fast/xpath/evaluate-twice.html

  • xml/XPathExpression.cpp: (WebCore::XPathExpression::evaluate):
  • xml/XPathExpressionNode.cpp: (WebCore::XPath::Expression::Expression): (WebCore::XPath::Expression::~Expression):
  • xml/XPathExpressionNode.h:
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunLast::evaluate): (WebCore::XPath::FunPosition::evaluate): (WebCore::XPath::FunId::evaluate): (WebCore::XPath::FunLocalName::evaluate): (WebCore::XPath::FunNamespaceURI::evaluate): (WebCore::XPath::FunName::evaluate): (WebCore::XPath::FunCount::evaluate): (WebCore::XPath::FunString::evaluate): (WebCore::XPath::FunConcat::evaluate): (WebCore::XPath::FunStartsWith::evaluate): (WebCore::XPath::FunContains::evaluate): (WebCore::XPath::FunSubstringBefore::evaluate): (WebCore::XPath::FunSubstringAfter::evaluate): (WebCore::XPath::FunSubstring::evaluate): (WebCore::XPath::FunStringLength::evaluate): (WebCore::XPath::FunNormalizeSpace::evaluate): (WebCore::XPath::FunTranslate::evaluate): (WebCore::XPath::FunBoolean::evaluate): (WebCore::XPath::FunNot::evaluate): (WebCore::XPath::FunTrue::evaluate): (WebCore::XPath::FunLang::evaluate): (WebCore::XPath::FunFalse::evaluate): (WebCore::XPath::FunNumber::evaluate): (WebCore::XPath::FunSum::evaluate): (WebCore::XPath::FunFloor::evaluate): (WebCore::XPath::FunCeiling::evaluate): (WebCore::XPath::FunRound::evaluate):
  • xml/XPathPath.cpp: (WebCore::XPath::Filter::evaluate): (WebCore::XPath::LocationPath::evaluate): (WebCore::XPath::Path::evaluate):
  • xml/XPathPath.h:
  • xml/XPathPredicate.cpp: (WebCore::XPath::Number::evaluate): (WebCore::XPath::StringExpression::evaluate): (WebCore::XPath::Negative::evaluate): (WebCore::XPath::NumericOp::evaluate): (WebCore::XPath::EqTestOp::evaluate): (WebCore::XPath::LogicalOp::evaluate): (WebCore::XPath::Union::evaluate):
  • xml/XPathPredicate.h:
  • xml/XPathStep.cpp:
  • xml/XPathStep.h:
  • xml/XPathVariableReference.cpp: (WebCore::XPath::VariableReference::evaluate):
  • xml/XPathVariableReference.h:
7:31 PM Changeset in webkit [20050] by bdash
  • 1 edit in trunk/WebKit/Plugins/WebBaseNetscapePluginView.mm

The change to go along with Anders' ChangeLog entry.

7:18 PM Changeset in webkit [20049] by andersca
  • 1 edit in trunk/WebKit/ChangeLog

Leopard build fix.


  • Plugins/WebBaseNetscapePluginView.mm:
7:15 PM Changeset in webkit [20048] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Tim H.

Remove unused #import from Objective-C bindings and cleanup the order of #imports.

  • bindings/scripts/CodeGeneratorObjC.pm:
6:43 PM Changeset in webkit [20047] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Tim H.

Make sure the baseURI attribute generates for private Objective-C bindings.

  • dom/Node.idl:
6:35 PM Changeset in webkit [23038] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Rubberstamped by Anders.

Switch the definition of WebURLErrorDomain to "CFURLErrorDomain" so
that we will send the right errors once <rdar://problem/5034136> is
fixed.

  • Interfaces/IWebError.idl: Changed definition.
6:18 PM Changeset in webkit [20046] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/4874059>

REGRESSION: Painter IX:register - Crash in WebCore
ResourceLoader::willSendRequest()

If a load is done from inside of an error delegate method that is called because we cancel another load,
the first load should be ignored since this is what shipping WebKit does.


(Actually, it does load the page in the data source but doesn't do anything with it since the data source
won't have a web frame).


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): Just bail out if m_isStoppingLoad is true.
6:09 PM Changeset in webkit [20045] by hyatt
  • 3 edits in trunk/WebCore

Use CGImageRelease instead of CFRelease.

Reviewed by aroben

  • platform/graphics/cg/ImageCG.cpp: (WebCore::FrameData::clear):
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::destroyFrameAtIndex):
6:00 PM Changeset in webkit [20044] by hyatt
  • 6 edits in trunk/WebCore

Fix a regression where the cache size overflows because of a double
subtraction per resource when they got removed from the cache. Add an
assert to adjustSize to detect this case in the future.

Fix ImageSourceCG so that when we flush decoded data from our cache that
we also flush it from the ImageSource.

Reviewed by mjs

  • loader/Cache.cpp: (WebCore::Cache::adjustSize):
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::~BitmapImage): (WebCore::BitmapImage::destroyDecodedData):
  • platform/graphics/Image.h:
  • platform/graphics/ImageSource.h:
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData): (WebCore::ImageSource::destroyFrameAtIndex):
5:42 PM Changeset in webkit [20043] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-03-07 Anrong Hu <​huanr@yahoo.com>

Reviewed by Maciej.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12535
Bug 12535: Stack-optimizing compilers can trick GC into freeing in-use objects

  • kjs/internal.cpp: (KJS::StringImp::toObject): Copy val onto the stack so it is not subject to garbage collection.
5:34 PM Changeset in webkit [20042] by bdash
  • 2 edits in trunk/WebKit

2007-03-07 Bruce Q Hammond <​bruceq@apple.om>

Reviewed by Darin.

This fixes a problem with Netscape-style Plug-ins which draw through the Quickdraw APIs
being unable to render into offscreen bitmap contexts.

This patches both saveAndSetNewPortStateForUpdate: and restorePortState:
These methods now check the current context and see if appropriate setup/cleanup needs to be done
for offscreen rendering.

  • Plugins/WebBaseNetscapePluginView.mm: (QDPixelFormatFromCGBitmapInfo): (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView restorePortState:]):
5:29 PM Changeset in webkit [20041] by bdash
  • 3 edits
    4 adds in trunk

2007-03-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/repaint/outline-inset.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):

2007-03-07 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/repaint/outline-inset-expected.checksum: Added.
  • fast/repaint/outline-inset-expected.png: Added.
  • fast/repaint/outline-inset-expected.txt: Added.
  • fast/repaint/outline-inset.html: Added.
5:16 PM Changeset in webkit [20040] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Darin.

Use HardRetain/HardRelease.


  • WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::setDataSource): (WebDocumentLoaderMac::attachToFrame): (WebDocumentLoaderMac::detachFromFrame): (WebDocumentLoaderMac::increaseLoadCount): (WebDocumentLoaderMac::decreaseLoadCount):
5:16 PM Changeset in webkit [23037] by adele
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix.

  • WebEditorClient.cpp: (WebEditorClient::handleInputMethodKeypress):
5:09 PM Changeset in webkit [20039] by andersca
  • 4 edits in trunk/WebKit

Reviewed by Maciej.

<rdar://problem/4961259>
REGRESSION: Bumper Car 2.1.1 - Crash at WebCore::FrameLoader::receivedMainResourceError when encountering a invalid URL address


(The crash was already fixed, this actually makes Bumper Car load the error page correctly.)


This adds a "load counter" to the document loader and keeps the data source retained for as long as something is loading.


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillSendRequest): Increase the load counter.


(WebFrameLoaderClient::dispatchDidFinishLoading):
(WebFrameLoaderClient::dispatchDidFailLoading):
Decrease the load counter,


  • WebView/WebDocumentLoaderMac.h:
  • WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::WebDocumentLoaderMac):


(WebDocumentLoaderMac::attachToFrame):
If the document loader has been detached, make sure to retain its data source here.


(WebDocumentLoaderMac::detachFromFrame):
Release the data source.


(WebDocumentLoaderMac::increaseLoadCount):
Retain the data source if load count was 0.


(WebDocumentLoaderMac::decreaseLoadCount):
Release the data source if load count becomes 0

5:07 PM Changeset in webkit [20038] by bdash
  • 2 edits in trunk/WebKitTools

2007-03-07 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

Update check-for-global-initializers to ignore new debug initializers in bidi.o and kjs_events.o.

  • Scripts/check-for-global-initializers:
3:33 PM Changeset in webkit [20037] by thatcher
  • 1 edit in trunk/WebKit/English.lproj/Localizable.strings

Updating the localized strings.

3:32 PM Changeset in webkit [20036] by thatcher
  • 1 edit in trunk/WebCore/html/HTMLAnchorElement.cpp

Fixing a comment.

3:11 PM Changeset in webkit [20035] by brmorris
  • 3 edits in S60/trunk/WebKit

yinxcai, reviewed by Yongjun

DESC: Browser: page info not shown correctly after going back to secure page HMNN-6YNH7J
​http://bugs.webkit.org/show_bug.cgi?id=12989

3:08 PM Changeset in webkit [20034] by brmorris
  • 5 edits in S60/trunk/WebKit

yaharon, reviewed by sachin, brad (for sdk build)

DESC: Take new graphics into use when displaying the url
​http://bugs.webkit.org/show_bug.cgi?id=12977

3:05 PM Changeset in webkit [20033] by brmorris
  • 2 edits in S60/trunk/WebKit

vbradley, reviewed by Sachin

DESC: merge r20032 to s60/trunk. SLON-6VZ8Vu - Web Browser crashes when attempting to view a local file
​http://bugs.webkit.org/show_bug.cgi?id=12927

3:04 PM Changeset in webkit [20032] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

vbradley, reviewed by Sachin

DESC: SLON-6VZ8Vu - Web Browser crashes when attempting to view a local file
​http://bugs.webkit.org/show_bug.cgi?id=12927

3:03 PM Changeset in webkit [20031] by oliver
  • 2 edits in trunk/WebCore

2007-03-07 Oliver Hunt <​oliver@apple.com>

Reviewed by Antti.

Reset mouse down/drag state variables on mouse button release


Fixes <rdar://problem/5044654>: Drag out of some QuickTime plug-ins converting into image drag

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseReleaseEvent):
2:53 PM Changeset in webkit [23036] by adele
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin.

WebKitWin part of fix for:
​http://bugs.webkit.org/show_bug.cgi?id=10871
​http://bugs.webkit.org/show_bug.cgi?id=12677
<rdar://problem/4823129> REGRESSION: IME key events different in nightly
<rdar://problem/4759563> REGRESSION: Return key is always sent when you confirm a clause in kotoeri

  • WebEditorClient.cpp: (WebEditorClient::handleKeypress): Changed handleKeyPress to handleKeypress. (WebEditorClient::handleInputMethodKeypress): Added.
  • WebEditorClient.h:
2:49 PM Changeset in webkit [20030] by adele
  • 16 edits in trunk

WebCore:

Reviewed by Darin.

WebCore part of fix for:
​http://bugs.webkit.org/show_bug.cgi?id=10871
​http://bugs.webkit.org/show_bug.cgi?id=12677
<rdar://problem/4823129> REGRESSION: IME key events different in nightly
<rdar://problem/4759563> REGRESSION: Return key is always sent when you confirm a clause in kotoeri

  • page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): Call handleInputMethodKeypress before actually dispatching the keypress event so that input methods have a chance to handle the event. If the input method handles the event (by marking or unmarking text), then we don't need to send the keypress event. If an input method doesn't handle the event, then we'll save the data we need to perform the correct action (like what text to insert or what selector to use) when we dispatch the keypress event.
  • dom/KeyboardEvent.h: Added Mac-specific KeypressCommand struct, so we can store command info during handleInputMethodKeypress, and use it during handleKeypress. (WebCore::KeyboardEvent::keypressCommand): (WebCore::KeyboardEvent::setKeypressCommand):
  • bridge/EditorClient.h:
  • editing/Editor.cpp: (WebCore::Editor::handleKeypress): Changed handleKeyPress to handleKeypress. (WebCore::Editor::handleInputMethodKeypress): Added.
  • editing/Editor.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::handleKeypress): Changed handleKeyPress to handleKeypress. (WebCore::SVGEmptyEditorClient::handleInputMethodKeypress): Added.

WebKit:

Reviewed by Darin.

WebKit part of fix for:
​http://bugs.webkit.org/show_bug.cgi?id=10871
​http://bugs.webkit.org/show_bug.cgi?id=12677
<rdar://problem/4823129> REGRESSION: IME key events different in nightly
<rdar://problem/4759563> REGRESSION: Return key is always sent when you confirm a clause in kotoeri

  • WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent: shouldSaveCommand:]): Added shouldSaveCommand field to WebHTMLViewInterpretKeyEventsParameters. When shouldSaveCommand is true, we call interpretKeyEvents and in doCommandBySelector and insertText, we just save the information without performing any action. When shouldSaveCommand is false, we used the saved information and call doCommandBySelector and insertText directly. If there's no saved command data in the KeyboardEvent, call interpretKeyEvents, and honor the shouldSaveCommand argument. This allows repeating keypress events to function normally. (-[WebHTMLView doCommandBySelector:]): If the WebHTMLViewInterpretKeyEventsParameters shouldSaveCommand field is set, then just save the selector information in the KeyboardEvent, and don't perform the action. (-[WebHTMLView insertText:]): ditto. insertText can be called from an input method or from normal key event processing If its from an input method, then we should go ahead and insert the text now. The only way we know if its from an input method is to check hasMarkedText. There might be a better way to do this.
  • WebView/WebHTMLViewInternal.h: Added shouldSaveCommand argument.
  • WebView/WebViewInternal.h: ditto.
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeypress): Changed handleKeyPress to handleKeypress. Call _interceptEditingKeyEvent with shouldSaveCommand:NO. (WebEditorClient::handleInputMethodKeypress): Call _interceptEditingKeyEvent with shouldSaveCommand:YES.

WebKitQt:

Reviewed by Darin.

WebKitQT part of fix for:
​http://bugs.webkit.org/show_bug.cgi?id=10871
​http://bugs.webkit.org/show_bug.cgi?id=12677
<rdar://problem/4823129> REGRESSION: IME key events different in nightly
<rdar://problem/4759563> REGRESSION: Return key is always sent when you confirm a clause in kotoeri

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeypress): Changed handleKeyPress to handleKeypress. (WebCore::EditorClientQt::handleInputMethodKeypress): Added.
  • WebCoreSupport/EditorClientQt.h:
2:30 PM Changeset in webkit [20029] by andersca
  • 2 edits in trunk/WebKitTools

Reviewed by Adam.

Add some assertions.

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didStartProvisionalLoadForFrame:]): (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): (-[WaitUntilDoneDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[WaitUntilDoneDelegate webView:didFailLoadWithError:forFrame:]):
2:26 PM Changeset in webkit [23035] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

  • WebFrame.cpp: (WebFrame::makeDocumentView): Assert that frame is not null.
1:25 PM Changeset in webkit [20028] by rwlbuis
  • 21 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12579
WebKit fails SVG xml:base test

Implement DOM3 properties baseURI and documentURI to fix
the testcase in bug 12579.

11:31 AM Changeset in webkit [20027] by andersca
  • 9 edits in trunk

WebCore:

Reviewed by Brady.

Remove some methods in FrameLoader that just calls down to the active document loader. Since each
resource loader now has a pointer to its document loader, we can just call directly to the
document loader.

  • WebCore.exp:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::didReceiveResponse):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
  • loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::didFinishLoading): (WebCore::NetscapePlugInStreamLoader::didFail): (WebCore::NetscapePlugInStreamLoader::didCancel):

WebKit:

Reviewed by Brady.

Update to match WebCore.


  • Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream start]):
11:25 AM Changeset in webkit [20026] by ggaren
  • 2 edits in trunk/JavaScriptCore

Build fix for non-multiple-thread folks.


Use a shared global in the non-multiple-thread case.

  • wtf/FastMalloc.cpp: (WTF::isForbidden): (WTF::fastMallocForbid): (WTF::fastMallocAllow):
11:10 AM Changeset in webkit [20025] by beidson
  • 2 edits in trunk/WebKitSite

Whoops, its actually prepare-ChangeLog

  • coding/contributing.html:
11:09 AM Changeset in webkit [20024] by beidson
  • 2 edits in trunk/WebKitSite

Reviewed by Anders

Explicitly mention the prepare-Changelog step for contributing patches

  • coding/contributing.html:
11:07 AM Changeset in webkit [20023] by darin
  • 7 edits in trunk/LayoutTests

Reviewed by Geoff.

  • change tests that depend on the order of iteration of built-in properties to sort explicitly so they don't depend on the order any more
  • fast/dom/Window/resources/window-appendages-cleared-results.html:
  • fast/dom/Window/window-appendages-cleared-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-properties.html:
  • fast/js/regexp-caching-expected.txt:
  • fast/js/regexp-caching.html:
10:32 AM Changeset in webkit [20022] by ap
  • 1 edit
    9 adds in trunk/LayoutTests

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12953
Import/convert 4XPath test suite

Import the rest of the converted suite. The only remaining failures are due to
incorrect node order, bug 12497.

  • fast/xpath/4XPath/Core/test_literal_expr.html: Added.
  • fast/xpath/4XPath/Core/test_location_path.html: Added.
  • fast/xpath/4XPath/Core/test_node_test.html: Added.
  • fast/xpath/4XPath/Core/test_nodeset_expr.html: Added.
  • fast/xpath/4XPath/Core/test_parser-expected.txt: Added.
  • fast/xpath/4XPath/Core/test_parser.html: Added.
  • fast/xpath/4XPath/Core/test_predicate_list.html: Added.
  • fast/xpath/4XPath/Core/test_step-expected.txt: Added.
  • fast/xpath/4XPath/Core/test_step.html: Added.
8:40 AM Changeset in webkit [20021] by darin
  • 2 edits in trunk/WebKitQt
  • WebCoreSupport/FrameLoaderClientQt.h: Oops, forgot the header.
8:34 AM Changeset in webkit [20020] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.


Fixed ASSERT failure I just introduced.


Made the fastMalloc isForbidden flag per thread. (Oops!) We expect that
other threads will malloc while we're marking -- we just want to prevent
our own marking from malloc'ing.

  • wtf/FastMalloc.cpp: (WTF::initializeIsForbiddenKey): (WTF::isForbidden): (WTF::fastMallocForbid): (WTF::fastMallocAllow): (WTF::fastMalloc): (WTF::fastCalloc): (WTF::fastFree): (WTF::fastRealloc): (WTF::do_malloc):
7:37 AM Changeset in webkit [20019] by ggaren
  • 9 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12997

Wrap pthread-specific assertion in #if USE(MULTIPLE_THREADS).

  • kjs/collector.cpp: (KJS::Collector::markMainThreadOnlyObjects):

WebCore:

Reviewed by Maciej Stachowiak.


Fixed <rdar://problem/4576242> | ​http://bugs.webkit.org/show_bug.cgi?id=12586
PAC file: malloc deadlock sometimes causes a hang @ www.apple.com/pro/profiles/ (12586)


No test because this is very difficult to repro, and the new ASSERTs in
JavaScriptCore catch the underlying cause while running normal layout tests.


This is a modified version of r14752 on the branch.


The fix is to use a bit inside each node, instead of a hash table, to track
which node subtrees are in the process of being marked. This avoids a call
to malloc inside mark().


  • bindings/js/kjs_binding.cpp: (KJS::domObjects): (KJS::domNodesPerDocument):
  • bindings/js/kjs_dom.cpp: (KJS::DOMNode::mark):
  • dom/Node.cpp: (WebCore::Node::Node):
  • dom/Node.h:
7:01 AM Changeset in webkit [20018] by ddkilzer
  • 24 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Tests using both dumpDOMAsWebArchive() and dumpSourceAsWebArchive() were added
for this bug since a similar fix was suggested for the DOM case which was not
needed. The remaining changes are related to renaming dumpAsWebArchive() to
dumpDOMAsWebArchive().

  • webarchive/archive-empty-frame-dom-expected.txt: Added.
  • webarchive/archive-empty-frame-dom.html: Added.
  • webarchive/archive-empty-frame-source-expected.txt: Added.
  • webarchive/archive-empty-frame-source.html: Added.
  • webarchive/resources/dump-webarchive.js: Renamed dumpAsWebArchive() to dumpDOMAsWebArchive().
  • webarchive/test-body-background-expected.txt: Ditto.
  • webarchive/test-body-background.html: Ditto.
  • webarchive/test-duplicate-resources-expected.txt: Ditto.
  • webarchive/test-frameset-expected.txt: Ditto.
  • webarchive/test-frameset.html: Ditto.
  • webarchive/test-img-src-expected.txt: Ditto.
  • webarchive/test-img-src.html: Ditto.
  • webarchive/test-input-src-expected.txt: Ditto.
  • webarchive/test-input-src.html: Ditto.
  • webarchive/test-link-href-expected.txt: Ditto.
  • webarchive/test-link-href.html: Ditto.
  • webarchive/test-object-data-expected.txt: Ditto.
  • webarchive/test-object-data.html: Ditto.
  • webarchive/test-script-src-expected.txt: Ditto.
  • webarchive/test-table-background-expected.txt: Ditto.
  • webarchive/test-table-background.html: Ditto.
  • webarchive/test-td-background-expected.txt: Ditto.
  • webarchive/test-td-background.html: Ditto.

WebKit:

Reviewed by Darin.

When dealing with an iframe element with no src attribute, the element contains
a src attribute in the DOM with a URL of "about:blank" and some HTML to implement
the blank page. In the original page source, however, the iframe element does
not include a src attribute, which caused a nil archive to be returned for the
childFrameArchive and thus caused the bug. The fix is a simple nil check.

Test: webarchive/archive-empty-frame-source.html

  • WebView/WebArchiver.mm: (+ (NSArray *)_subframeArchivesForFrame:(WebFrame *)frame): Don't add childFrameArchive to the subframeArchives array if it is nil.

WebKitTools:

Reviewed by Darin.

The dumpDOMAsWebArchive() test method uses the DOMDocument as a basis for creating
a webarchive while the dumpSourceAsWebArchive() test method uses the original
dataSource (page source) to create a webarchive. Most tests currently use
dumpDOMAsWebArchive() since this is what Safari does when saving a web page as a
webarchive.

  • DumpRenderTree/DumpRenderTree.m: Renamed dumpAsWebArchive to dumpDOMAsWebArchive. Added dumpSourceAsWebArchive. (dump): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController dumpDOMAsWebArchive]): (-[LayoutTestController dumpSourceAsWebArchive]): (runTest):
6:25 AM Changeset in webkit [20017] by ddkilzer
  • 5 edits in trunk/LayoutTests

LayoutTests:

Reviewed by Mitz.

  • svg/custom/struct-use-09-b.svg: Changed to use Helvetica instead of 'Arial Black', Arial.
  • svg/custom/struct-use-09-b-expected.checksum: Update results.
  • svg/custom/struct-use-09-b-expected.png: Ditto.
  • svg/custom/struct-use-09-b-expected.txt: Ditto.
6:18 AM Changeset in webkit [20016] by darin
  • 2 edits in trunk/WebKitQt
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::userAgent): Try to fix the build by correcting the parameter here.
1:46 AM Changeset in webkit [20015] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-03-07 Shrikant Gangoda <​shrikant.gangoda@celunite.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12997

Wrap pthread-specific assertion in #if USE(MULTIPLE_THREADS).

  • kjs/collector.cpp: (KJS::Collector::markMainThreadOnlyObjects):
1:05 AM Changeset in webkit [20014] by justing
  • 4 edits
    1 add
    1 delete in trunk/LayoutTests

Reviewed by mjs

<​http://bugs.webkit.org/show_bug.cgi?id=8592>
Extra line left after deleting whitespace:pre text

Re-enabled the test and removed a FIXME:

  • editing/deleting/merge-whitespace-pre-expected.checksum:
  • editing/deleting/merge-whitespace-pre-expected.png:
  • editing/deleting/merge-whitespace-pre-expected.txt:
  • editing/deleting/merge-whitespace-pre.html: Added.
  • editing/deleting/merge-whitespace-pre.html-disabled: Removed.
12:49 AM Changeset in webkit [20013] by bdash
  • 3 edits in tags/Safari-5522.3

Versioning.

12:43 AM Changeset in webkit [20012] by bdash
  • 2 edits in trunk

Fix an oversight in the spelling over oversight.

12:40 AM Changeset in webkit [20011] by bdash
  • 10 edits in tags/Safari-5522.3/WebCore

Merge in r19977.

2007-03-05 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Mark and Dave H.

  • rdar://problem/5038491 An oversite of the security fix that prevented remote from loading local is that it prevents user style sheets when the site is remote. This fixes that.
  • loader/Cache.cpp: Propogate and check user style sheet flag. (WebCore::createResource): (WebCore::Cache::requestResource):
  • loader/Cache.h: Propogate user style sheet flag.
  • loader/CachedCSSStyleSheet.cpp: Propogate user style sheet flag. (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
  • loader/CachedCSSStyleSheet.h: Propogate user style sheet flag.
  • loader/DocLoader.cpp: Propogate user style sheet flag. (WebCore::DocLoader::requestResource):
  • loader/SubresourceLoader.cpp: Propogate and check user style sheet flag. (WebCore::SubresourceLoader::create):
  • loader/SubresourceLoader.h: Add check for user style sheet flag.
  • loader/loader.cpp: Propogate user style sheet flag. (WebCore::Loader::load): (WebCore::Loader::servePendingRequests):
  • loader/loader.h: Propogate user style sheet flag.
12:34 AM Changeset in webkit [20010] by bdash
  • 1 copy in tags/Safari-5522.3

New tag.

Mar 6, 2007:

11:42 PM Changeset in webkit [20009] by hyatt
  • 17 edits
    1 add
    1 delete in trunk/WebCore

This patch reworks the WebCore memory cache to significantly reduce the amount of memory consumed by
images in the cache and to enhance the accuracy of the cache size as an absolute bound for the objects
contained within it. WebCore's memory use over time should significantly improve as a result of these
changes.

Cached resources now have both an encoded size (the original data stream) and a decoded size (an estimate of
the amount of memory consumed by an expanded version of that resource, e.g., the decoded frames of an image).
Both sizes now count towards the total size of the object and towards the allowed memory cache total.

By including both totals the reported size of resources will now be larger, and the cache will therefore become
much more aggressive about flushing.

Objects are stored in size-adjusted and popularity-aware LRU lists as before, but encoded size is now always
used when determining the correct LRU list.

The flush algorithm for the memory cache has been rewritten to first destroy decoded data before evicting
resources. By being able to compact its resources without evicting them, the memory cache can now hold many more
unique resources (encoded) in the same amount of space. Depending on how much of a hit we want to take from
re-decoding images, the memory cache could in theory have its size significantly reduced now while still holding
more resources than it did at the larger size!

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • loader/Cache.cpp: (WebCore::Cache::requestResource): (WebCore::Cache::prune): (WebCore::Cache::remove): (WebCore::Cache::lruListFor): (WebCore::Cache::adjustSize):
  • loader/Cache.h:
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::data):
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::allReferencesRemoved): (WebCore::CachedImage::clear): (WebCore::CachedImage::data): (WebCore::CachedImage::destroyDecodedData): (WebCore::CachedImage::decodedSize): (WebCore::CachedImage::decodedSizeChanged): (WebCore::CachedImage::shouldPauseAnimation):
  • loader/CachedImage.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::deref): (WebCore::CachedResource::setEncodedSize):
  • loader/CachedResource.h: (WebCore::CachedResource::allReferencesRemoved): (WebCore::CachedResource::size): (WebCore::CachedResource::encodedSize): (WebCore::CachedResource::decodedSize): (WebCore::CachedResource::destroyDecodedData):
  • loader/CachedScript.cpp: (WebCore::CachedScript::data):
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::data):
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::~BitmapImage): (WebCore::BitmapImage::destroyDecodedData): (WebCore::BitmapImage::pruneDecodedDataIfNeeded): (WebCore::BitmapImage::cacheFrame): (WebCore::BitmapImage::setNativeData): (WebCore::BitmapImage::shouldAnimate): (WebCore::BitmapImage::advanceAnimation):
  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::decodedSize):
  • platform/graphics/Image.cpp: (WebCore::Image::Image):
  • platform/graphics/Image.h: (WebCore::Image::destroyDecodedData): (WebCore::Image::decodedSize): (WebCore::Image::imageObserver):
  • platform/graphics/ImageAnimationObserver.h: Removed.
  • platform/graphics/ImageObserver.h: Added. (WebCore::ImageObserver::~ImageObserver):
  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::SVGImage):
  • platform/graphics/svg/SVGImage.h:
10:03 PM Changeset in webkit [20008] by ap
  • 7 edits
    1 add in trunk

Reviewed by Sam Weinig.

​http://bugs.webkit.org/show_bug.cgi?id=12987
Fix and import 4XPath test_numeric_expr.html

  • xml/XPathPredicate.cpp: (WebCore::XPath::Negative::doEvaluate): Convert the argument to number. (WebCore::XPath::NumericOp::doEvaluate): Convert the arguments to numbers. Use a correct operation for mod.
  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Do not append parent node if there is none.
  • xml/XPathValue.cpp: (WebCore::XPath::Value::toNumber): Do not convert to DeprecatedString just to trim whitespace and to convert to double.
  • platform/DeprecatedString.cpp: (WebCore::DeprecatedStringData::makeAscii): Added a FIXME about unreliable makeAscii() behavior.
9:55 PM Changeset in webkit [20007] by bdash
  • 1 edit in trunk/LayoutTests/fast/dom/select-selectedIndex-bug-12942-expected.txt

Fix broken layout test results.

9:36 PM Changeset in webkit [20006] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Adele.

<rdar://problem/4619663> REGRESSION (NativePopup): Popup menu doesn't draw at the correct vertical position (9816)


  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Make a temporary dummy view with the passed in rect, since AppKit will use the view bounds to determine what area to exclude when popping up a menu moved to the top of the screen.
9:25 PM Changeset in webkit [20005] by bdash
  • 2 edits in trunk/WebKitLibraries

2007-03-07 Mark Rowe <​mrowe@apple.com>

Build fix. Rebuild against 10.4 SDK.

  • libWebKitSystemInterface.a:
8:25 PM Changeset in webkit [20004] by ggaren
  • 33 edits in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.


Fixed all known crashers exposed by run-webkit-tests --threaded. This covers:

<rdar://problem/4565394> | ​http://bugs.webkit.org/show_bug.cgi?id=12585

PAC file: after closing a window that contains macworld.com, new window
crashes (KJS::PropertyMap::mark()) (12585)

<rdar://problem/4571215> | ​http://bugs.webkit.org/show_bug.cgi?id=9211

PAC file: Crash occurs when clicking on the navigation tabs at ​http://www.businessweek.com/ (9211)

<rdar://problem/4557926>

PAC file: Crash occurs when attempting to view image in slideshow mode
at ​http://d.smugmug.com/gallery/581716 ( KJS::IfNode::execute (KJS::
ExecState*) + 312) if you use a PAC file

(1) Added some missing JSLocks, along with related ASSERTs.


(2) Fully implemented support for objects that can only be garbage collected
on the main thread. So far, only WebCore uses this. We can add it to API
later if we learn that it's needed.


The implementation uses a "main thread only" flag inside each object. When
collecting on a secondary thread, the Collector does an extra pass through
the heap to mark all flagged objects before sweeping. This solution makes
the common case -- flag lots of objects, but never collect on a secondary
thread -- very fast, even though the uncommon case of garbage collecting
on a secondary thread isn't as fast as it could be. I left some notes
about how to speed it up, if we ever care.


For posterity, here are some things I learned about GC while investigating:


  • Each collect must either mark or delete every heap object. "Zombie" objects, which are neither marked nor deleted, raise these issues:
  • On the next pass, the conservative marking algorithm might mark a zombie, causing it to mark freed objects.
  • The client might try to use a zombie, which would seem live because its finalizer had not yet run.
  • A collect on the main thread is free to delete any object. Presumably, objects allocated on secondary threads have thread-safe finalizers.
  • A collect on a secondary thread must not delete thread-unsafe objects.
  • The mark function must be thread-safe.


Line by line comments:

  • API/JSObjectRef.h: Added comment specifying that the finalize callback may run on any thread.
  • bindings/npruntime.cpp: (_NPN_GetStringIdentifier): Added JSLock.
  • bindings/objc/objc_instance.h:
  • bindings/objc/objc_instance.mm: (ObjcInstance::~ObjcInstance): Use an autorelease pool. The other callers to CFRelease needed one, too, but they were dead code, so I removed them instead. (This fixes a leak seen while running run-webkit-tests --threaded, although I don't think it's specifically a threading issue.)


  • kjs/collector.cpp: (KJS::Collector::collectOnMainThreadOnly): New function. Tells the collector to collect a value only if it's collecting on the main thread. (KJS::Collector::markMainThreadOnlyObjects): New function. Scans the heap for "main thread only" objects and marks them.
  • kjs/date_object.cpp: (KJS::DateObjectImp::DateObjectImp): To make the new ASSERTs happy, allocate our globals on the heap, avoiding a seemingly unsafe destructor call at program exit time.
  • kjs/function_object.cpp: (FunctionPrototype::FunctionPrototype): ditto
  • kjs/interpreter.cpp: (KJS::Interpreter::mark): Removed boolean parameter, which was an incomplete and arguably hackish way to implement markMainThreadOnlyObjects() inside WebCore.
  • kjs/interpreter.h:
  • kjs/identifier.cpp: (KJS::identifierTable): Added some ASSERTs to check for thread safety problems.
  • kjs/list.cpp: Added some ASSERTs to check for thread safety problems. (KJS::allocateListImp): (KJS::List::release): (KJS::List::append): (KJS::List::empty): Make the new ASSERTs happy.
  • kjs/object.h: (KJS::JSObject::JSObject): "m_destructorIsThreadSafe" => "m_collectOnMainThreadOnly". I removed the constructor parameter because m_collectOnMainThreadOnly, like m_marked, is a Collector bit, so only the Collector should set or get it.
  • kjs/object_object.cpp: (ObjectPrototype::ObjectPrototype): Make the ASSERTs happy.
  • kjs/regexp_object.cpp: (RegExpPrototype::RegExpPrototype): ditto
  • kjs/ustring.cpp: Added some ASSERTs to check for thread safety problems. (KJS::UCharReference::ref): (KJS::UString::Rep::createCopying): (KJS::UString::Rep::create): (KJS::UString::Rep::destroy): (KJS::UString::null): Make the new ASSERTs happy.
  • kjs/ustring.h: (KJS::UString::Rep::ref): Added some ASSERTs to check for thread safety problems. (KJS::UString::Rep::deref):
  • kjs/value.h: (KJS::JSCell::JSCell):

JavaScriptGlue:

Reviewed by Maciej Stachowiak.

Fixed all known crashers exposed by run-webkit-tests --threaded while using
a PAC file (for maximum carnage). See JavaScriptCore ChangeLog for
more details.

  • JSBase.cpp: (JSBase::Release): Lock when deleting, because we may be deleting an object (like a JSRun) that holds thread-unsafe data.
  • JSUtils.cpp: (CFStringToUString): Don't lock, because our caller locks. Also, locking inside a function that returns thread-unsafe data by copy will only mask threading problems.
  • JavaScriptGlue.cpp: (JSRunEvaluate): Added missing JSLock. (JSRunCheckSyntax): Converted to JSLock.
  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Maciej Stachowiak.

Fixed all known crashers exposed by run-webkit-tests --threaded [*]. See
JavaScriptCore ChangeLog for more details.

  • bindings/js/kjs_binding.cpp: (KJS::domNodesPerDocument): Added thread safety ASSERT. (KJS::ScriptInterpreter::mark): Removed obsolete logic for marking unsafe objects when collecting on a secondary thread. The Collector takes care of this now.
  • bindings/js/kjs_binding.h: (KJS::DOMObject::DOMObject): Used new API for specifying that WebCore objects should be garbage collected on the main thread only.
  • bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute): Moved JSLock to cover implementedsCall() call, which, for some subclasses, ends up allocating garbage collected objects. (This fix was speculative. I didn't actually see a crash from this.) (KJS::Window::timerFired): Added JSLock around ScheduleAction destruction, since it destroys a KJS::List.
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject setException:]): Added JSLock. (This fix was speculative. I didn't actually see a crash from this.)
  • bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]): Added JSLock. (This fix was speculative. I didn't actually see a crash from this.)
  • dom/Document.cpp: (WebCore::Document::~Document): Added JSLock around modification to domNodesPerDocument(), which can be accessed concurrently during garbage collection.
  • dom/Node.cpp: (WebCore::Node::setDocument): ditto.


[*] fast/js/toString-stack-overflow.html is an exception. --threaded mode
crashes this test because it causes the garbage collector to run frequently,
and this test crashes if you happen to garbage collect while it's running.
This is a known issue with stack overflow during the mark phase. It's
not related to threading.

8:18 PM Changeset in webkit [20003] by kdecker
  • 2 edits in trunk/WebKitLibraries

Reviewed by Brady

Fixed: <rdar://problem/4126976> private keys imported by WebKit should not be accessible by all applications

  • libWebKitSystemInterface.a:
8:16 PM Changeset in webkit [20002] by bdash
  • 2 edits in trunk/LayoutTests

2007-03-07 Mark Rowe <​mrowe@apple.com>

Add dumpAsText to test to match expected results.

  • fast/dom/Window/window-location-replace-functions.html:
8:07 PM Changeset in webkit [20001] by bdash
  • 4 edits
    2 adds in trunk

2007-03-06 Mark Rowe <​mrowe@apple.com>

Reviewed by Sam Weinig.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12942
Bug 12942: ASSERTION FAILURE: qantas.com.au changing selected item in <select> via JS

Test: fast/dom/select-selectedIndex-bug-12942.html.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcListItems): Reset m_lastOnChangeIndex when recalculating list items.
  • html/HTMLSelectElement.h:

2007-03-06 Mark Rowe <​mrowe@apple.com>

Reviewed by Sam Weinig.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=12942
Bug 12942: ASSERTION FAILURE: qantas.com.au changing selected item in <select> via JS

  • fast/dom/select-selectedIndex-bug-12942-expected.txt: Added.
  • fast/dom/select-selectedIndex-bug-12942.html: Added.
8:05 PM Changeset in webkit [20000] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

Rubberstamped by Kevin Decker

20,000!

  • ChangeLog: Point out revision 20,000
8:04 PM Changeset in webkit [19999] by kjk
  • 3 edits in trunk/WebCore

Not reviewed.

Gdk build fix.

  • loader/gdk/FrameLoaderClientGdk.cpp: update userAgent() signature. (WebCore::FrameLoaderClientGdk::userAgent):
  • loader/gdk/FrameLoaderClientGdk.h: ditto.
7:40 PM Changeset in webkit [19998] by bdash
  • 3 edits
    4 adds in trunk

2007-03-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.

Test: fast/forms/select-change-listbox-size.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): Reattach on list box size change.

2007-03-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.

  • fast/forms/select-change-listbox-size-expected.checksum: Added.
  • fast/forms/select-change-listbox-size-expected.png: Added.
  • fast/forms/select-change-listbox-size-expected.txt: Added.
  • fast/forms/select-change-listbox-size.html: Added.
7:35 PM Changeset in webkit [19997] by bdash
  • 37 edits
    8 adds in trunk

2007-03-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Tests: fast/repaint/content-into-overflow.html

fast/repaint/overflow-into-content.html

Changed repaintAfterLayoutIfNeeded() to take, in addition to the clipped overflow
rect, the unclipped border box plus outline, and to repaint any areas that
were added or removed from that box, in addition to any areas added or removed
from the clipped overflow rect.

  • platform/graphics/svg/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::draw):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteClippedOverflowRect): Renamed getAbsoluteRepaintRect() to this.
  • rendering/RenderBox.h:
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect):
  • rendering/RenderFlow.h:
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::layout):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::checkForRepaintOnResize): (WebCore::RenderLayer::updateLayerPositions):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaint): (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline): (WebCore::RenderObject::absoluteClippedOverflowRect): (WebCore::RenderObject::absoluteOutlineBox):
  • rendering/RenderObject.h:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout): (WebCore::RenderPath::absoluteClippedOverflowRect): (WebCore::RenderPath::absoluteRects): (WebCore::RenderPath::drawMarkersIfNeeded):
  • rendering/RenderPath.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): (WebCore::RenderSVGContainer::absoluteClippedOverflowRect): (WebCore::RenderSVGContainer::absoluteRects):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::absoluteClippedOverflowRect):
  • rendering/RenderSVGHiddenContainer.h:
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::imageChanged): (WebCore::RenderSVGImage::absoluteClippedOverflowRect): (WebCore::RenderSVGImage::absoluteRects):
  • rendering/RenderSVGImage.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteClippedOverflowRect): (WebCore::RenderSVGText::layout): (WebCore::RenderSVGText::absoluteRects):
  • rendering/RenderSVGText.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::absoluteClippedOverflowRect):
  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::absoluteClippedOverflowRect):
  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::absoluteClippedOverflowRect):
  • rendering/RenderTableRow.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteClippedOverflowRect):
  • rendering/RenderText.h:

2007-03-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/repaint/bugzilla-6278-expected.checksum:
  • fast/repaint/bugzilla-6278-expected.png:
  • fast/repaint/content-into-overflow-expected.checksum: Added.
  • fast/repaint/content-into-overflow-expected.png: Added.
  • fast/repaint/content-into-overflow-expected.txt: Added.
  • fast/repaint/content-into-overflow.html: Added.
  • fast/repaint/overflow-into-content-expected.checksum: Added.
  • fast/repaint/overflow-into-content-expected.png: Added.
  • fast/repaint/overflow-into-content-expected.txt: Added.
  • fast/repaint/overflow-into-content.html: Added.
7:30 PM Changeset in webkit [19996] by bdash
  • 1 edit
    2 adds in trunk/LayoutTests

2007-03-06 Ian Eng <​ian.eng.webkit@gmail.com>

Reviewed by Maciej.

  • fast/dom/Window/window-location-replace-functions-expected.txt: Added.
  • fast/dom/Window/window-location-replace-functions.html: Added.
7:15 PM Changeset in webkit [19995] by bdash
  • 2 edits in trunk/WebCore

2007-03-06 Ian Eng <​ian.eng.webkit@gmail.com>

Reviewed by Maciej.

  • bindings/js/kjs_window.cpp: Disallow replacing functions in LocationTable, and return early without updating URL.
6:27 PM Changeset in webkit [19994] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.


2% speedup on super accurate JS iBench.

(KJS::Collector::collect): Removed anti-optimization to call
pthread_is_threaded_np() before calling pthread_main_np(). Almost all
apps have more than one thread, so the extra call is actually worse.
Interestingly, even the single-threaded testkjs shows a speed gain
from removing the pthread_is_threaded_np() short-circuit. Not sure why.

6:22 PM Changeset in webkit [19993] by kmccullo
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

<​http://bugs.webkit.org/show_bug.cgi?id=12686>
REGRESSION: Bloglines.com Feeds tab cannot expand folders in TOT

  • Now all class constructors implement implementsHasInstance.
  • fast/dom/dom-instanceof-expected.txt: Added.
  • fast/dom/dom-instanceof.html: Added.

WebCore:

Reviewed by Darin.

<​http://bugs.webkit.org/show_bug.cgi?id=12686>
REGRESSION: Bloglines.com Feeds tab cannot expand folders in TOT

  • Now all class constructors implement implementsHasInstance.
  • bindings/scripts/CodeGeneratorJS.pm:
4:51 PM Changeset in webkit [23034] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

  • WebFrame.cpp: (WebFrame::makeDocumentView): Call resetMultipleFormSubmissionProtection() so that submitting the same form from separate loads works.
4:36 PM Changeset in webkit [23033] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam

Adapt to an API change in CFURLDownload


  • WebDownload.cpp: (WebDownload::init):
4:35 PM Changeset in webkit [23032] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Fixing the build while semi-blind is fun.

  • platform/win/TemporaryLinkStubs.cpp: (WebCore::supportedKeySizes): Need a namespace. (WebCore::signedPublicKeyAndChallengeString): Ditto.
4:27 PM Changeset in webkit [19992] by zimmermann
  • 9 edits in trunk/WebCore

Reviewed by Rob & Oliver.

Preparations for the new SVG text engine.

Handle baseline-shift / kerning css values correctly.
Recognize missing svg presentation attribute "font-size-adjust".
Add all missing svg<->css property mappings in mapToEntry().

Doesn't affect any layout test (as these properties are not used w/o my text patch).
While I'm at it, unify the macro names (RS_ -> SVG_RS_) & cleanup style a bit.

4:19 PM Changeset in webkit [23031] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

It works better if you use valid C++ syntax.

  • platform/win/TemporaryLinkStubs.cpp:
4:19 PM Changeset in webkit [23030] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • platform/win/TemporaryLinkStubs.cpp: Added missing stubs.
4:11 PM Changeset in webkit [19991] by justing
  • 17 edits
    8 adds in trunk

LayoutTests:

Reviewed by kevin


<​http://bugs.webkit.org/show_bug.cgi?id=12245>
FCKeditor: Remove Format sometimes doesn't work
<rdar://problem/4786404>
Underline style is not removed from selection after performing Remove Format

Added:

  • editing/execCommand/4786404-1-expected.checksum: Added.
  • editing/execCommand/4786404-1-expected.png: Added.
  • editing/execCommand/4786404-1-expected.txt: Added.
  • editing/execCommand/4786404-1.html: Added.
  • editing/execCommand/4786404-2-expected.checksum: Added.
  • editing/execCommand/4786404-2-expected.png: Added.
  • editing/execCommand/4786404-2-expected.txt: Added.
  • editing/execCommand/4786404-2.html: Added. Demonstrate fixes:
  • editing/execCommand/4920488-expected.checksum:
  • editing/execCommand/4920488-expected.png:
  • editing/execCommand/4920488-expected.txt:
  • editing/execCommand/4920742-1-expected.checksum:
  • editing/execCommand/4920742-1-expected.png:
  • editing/execCommand/4920742-1-expected.txt:
  • editing/execCommand/remove-formatting-2-expected.checksum:
  • editing/execCommand/remove-formatting-2-expected.png:
  • editing/execCommand/remove-formatting-2-expected.txt: Ditto, also added a FIXME:
  • editing/execCommand/remove-formatting-expected.checksum:
  • editing/execCommand/remove-formatting-expected.png:
  • editing/execCommand/remove-formatting-expected.txt:
  • editing/execCommand/remove-formatting.html:

WebCore:

Reviewed by kevin


<​http://bugs.webkit.org/show_bug.cgi?id=12245>
FCKeditor: Remove Format sometimes doesn't work
<rdar://problem/4786404>
Underline style is not removed from selection after performing Remove Format

  • editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): Re-wrote this.
3:45 PM Changeset in webkit [19990] by zimmermann
  • 1 edit
    8 adds in trunk/LayoutTests

Reviewed by Oliver.

Add new <use> layout tests. (forgot in last commit)

3:40 PM Changeset in webkit [19989] by zimmermann
  • 3 edits in trunk/WebCore

Reviewed by Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12979
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12981

Guard against registering pending resources with empty id.
Be careful with calling recalcStyle() in SVGUseElement, when change is "Detach" we
have to use special code, as calling attach() on the shadow tree root element will crash,
because it has no (direct) parent node, only a shadow parent node element.

2:38 PM Changeset in webkit [19988] by kdecker
  • 6 edits
    2 adds in trunk

Reviewed by Adele.

Fixed: <rdar://problem/5041660> REGRESSION: <keygen> element broken, prevents users from signing up for Thawte email certs


  • bindings/objc/DOM.mm: (WebCore::createElementClassMap): Added <keygen> to the DOM bindings so it can be accessed from Objective-C.
  • css/html4.css: Apply the look of the <select> element to <keygen>.
  • html/HTMLElementFactory.cpp: (WebCore::keygenConstructor): Added. (WebCore::createFunctionMap): Added keygen.
  • html/HTMLSelectElement.cpp: Made const typeAheadTimeout variable static const. (WebCore::HTMLSelectElement::HTMLSelectElement): Fix both HTMLSelectElement constructors to initialize the same number of member variables. The fact that some fields were not initialized could (and would) crash the keygen element when selecting different items. Also removed m_typedString(String()) from the constructor initialization because this is not needed.
1:48 PM Changeset in webkit [19987] by zimmermann
  • 3 edits in trunk/LayoutTests

Reviewed by Mitz.
Remove an alert() which got accidently added in my last commit.

11:35 AM Changeset in webkit [19986] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Darin


Made WebAuthenticationHandler.h SPI so Safari can call it directly.

  • WebKit.exp: added .objc_class_name_WebPanelAuthenticationHandler
  • WebKit.xcodeproj/project.pbxproj: changed status of WebAuthenticationHandler.h from "project" to "private"
11:29 AM Changeset in webkit [19985] by kmccullo
  • 3 edits in trunk/WebKit

Reviewed by Darin.

  • Rename a function to clarify its purpose.
  • WebView/WebView.mm: (+[WebView registerURLSchemeAsLocal:]):
  • WebView/WebViewPrivate.h:
11:28 AM Changeset in webkit [19984] by kmccullo
  • 4 edits in trunk/WebCore

Reviewed by Darin.

  • Rename a function to clarify its purpose.
  • WebCore.exp:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::registerURLSchemeAsLocal):
  • loader/FrameLoader.h:
9:05 AM Changeset in webkit [23029] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

9:02 AM Changeset in webkit [19983] by sfalken
  • 1 copy in tags/Safari-521.35.6b

New tag.

8:17 AM Changeset in webkit [19982] by brmorris
  • 3 edits in S60/trunk/WebKit

yinxcai, reviewed by <Sachin>

DESC: ASOG-6YTLNA -- Remove BROWSER_OSS_ENGINE flag from webkit.iby and webkitresources.iby
​http://bugs.webkit.org/show_bug.cgi?id=12935

3:08 AM Changeset in webkit [23028] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-03-06 Steve Falkenburg <​sfalken@apple.com>

Rubber-stamped by Adam.


Fix disney.com more. Disney redirects to disney.go.com.

  • WebView.cpp: (WebView::userAgentForKURL): Added disney.go.com
2:27 AM Changeset in webkit [19981] by aroben
  • 2 edits in trunk/WebCore

Build fix.

  • WebCore.exp: Updated symbols.
2:02 AM Changeset in webkit [23027] by aroben
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Anders.

Always keep rounding hacks on.

  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::basenameForWidth): Tell StringTruncator to keep rounding hacks on.
  • platform/win/WebCoreTextRenderer.cpp: (WebCore::WebCoreTextFloatWidth): Ditto.

WebKitWin:

Reviewed by Anders.

Always keep rounding hacks on to be consistent.

  • WebDragClient.cpp: (createDragImageForLink): Tell StringTruncator to keep rounding hacks on.
  • WebKitGraphics.cpp: (CenterTruncateStringToWidth): Ditto. (RightTruncateStringToWidth): Ditto.
1:57 AM Changeset in webkit [19980] by aroben
  • 4 edits in trunk/WebCore

Reviewed by Anders.

Added a parameter to all StringTruncator methods to specify whether
rounding hacks should be on or off.

No layout test possible.

  • platform/StringTruncator.cpp: (WebCore::stringWidth): Added disableRoundingHacks parameter. (WebCore::truncateString): Ditto. (WebCore::StringTruncator::centerTruncate): Ditto. (WebCore::StringTruncator::rightTruncate): Ditto. (WebCore::StringTruncator::width): Ditto.
  • platform/StringTruncator.h: Ditto.
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth): Pass in false to centerTruncate so that the truncation matches the way the text will be rendered.
1:32 AM Changeset in webkit [23026] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-03-06 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.


Allow custom user agents per site.


This fixes:


​http://www.disney.com
​http://www.yahoo.com
​http://mail.google.com
iTunes store links (w/ latest unsubmitted CFNetwork from our root share)

  • WebView.cpp: (WebView::userAgentForKURL): Check URL host against a list of known offenders, return them what they're looking for.
1:05 AM Changeset in webkit [19979] by andersca
  • 8 edits in trunk

LayoutTests:

Reviewed by Maciej.

<rdar://problem/5035045>
REGRESSION: WebKit browser doesn't display image at ​http://www.metoffice.gov.uk/weather/satellite/index.html


Add some tests where image elements have id _and_ name elements.


  • fast/dom/HTMLDocument/document-special-properties-expected.txt:
  • fast/dom/HTMLDocument/document-special-properties.html:

WebCore:

Reviewed by Maciej.

<rdar://problem/5035045>
REGRESSION: WebKit browser doesn't display image at ​http://www.metoffice.gov.uk/weather/satellite/index.html


It turns out WinIE does allow you to access images by their id as special document properties. However, this is only
allowed when the element also has a name attribute. The value of the name attribute is ignored and can even be empty!


  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::namedItemGetter): Return jsUndefined() if the collection is empty.


  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): (WebCore::HTMLImageElement::insertedIntoDocument): (WebCore::HTMLImageElement::removedFromDocument):
  • html/HTMLImageElement.h: Add the id attribute value to the extra named item map.


  • html/HTMLNameCollection.cpp: (WebCore::HTMLNameCollection::traverseNextItem): Check for images with name attributes that match, as well as elements with id attributes that match where the element also has a name attribute.
12:50 AM Changeset in webkit [23025] by andersca
  • 5 edits in branches/WindowsMerge

WebKitWin:

Reviewed by Adam.


Pass the user agent on.


  • WebFrame.cpp: (WebFrame::userAgent):
  • WebFrame.h:
12:37 AM Changeset in webkit [19978] by andersca
  • 10 edits in trunk

WebCore:

Reviewed by Adam.

WebCore part of patch to make it possible to have different user agents for different URLs.

  • bindings/js/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScriptIfNeeded):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setLoading):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::userAgent): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::applyUserAgent):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::userAgent):

WebKit:

Reviewed by Adam.

Update for WebCore changes.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::userAgent):

Mar 5, 2007:

11:04 PM Changeset in webkit [19977] by kmccullo
  • 13 edits
    2 adds in trunk

LayoutTests:

Reviewed by Mark and Dave H.

  • rdar://problem/5038491 An oversite of the security fix that prevented remote from loading local is that it prevents user style sheets when the site is remote. This fixes that.
  • http/tests/security/local-user-CSS-from-remote-expected.txt: Added.
  • http/tests/security/local-user-CSS-from-remote.html: Added.

WebCore:

Reviewed by Mark and Dave H.

  • rdar://problem/5038491 An oversite of the security fix that prevented remote from loading local is that it prevents user style sheets when the site is remote. This fixes that.
  • loader/Cache.cpp: Propogate and check user style sheet flag. (WebCore::createResource): (WebCore::Cache::requestResource):
  • loader/Cache.h: Propogate user style sheet flag.
  • loader/CachedCSSStyleSheet.cpp: Propogate user style sheet flag. (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
  • loader/CachedCSSStyleSheet.h: Propogate user style sheet flag.
  • loader/DocLoader.cpp: Propogate user style sheet flag. (WebCore::DocLoader::requestResource):
  • loader/SubresourceLoader.cpp: Propogate and check user style sheet flag. (WebCore::SubresourceLoader::create):
  • loader/SubresourceLoader.h: Add check for user style sheet flag.
  • loader/loader.cpp: Propogate user style sheet flag. (WebCore::Loader::load): (WebCore::Loader::servePendingRequests):
  • loader/loader.h: Propogate user style sheet flag.

WebKitTools:

Reviewed by Mark and Dave H.

  • rdar://problem/4922454
  • This fixes a security issue by making remote referrers not able to access local resources, unless they register their schemes to be treated as local. The result is that those schemes can access local resources and cannot be accessed by remote referrers. Because this behavior is new a link-on-or-after check is made to determine if the app should use the older, less safe, behavior.
  • DumpRenderTree/DumpRenderTree.m: Add ability to set user style sheet to DRT. (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setUserStyleSheetLocation:]): (-[LayoutTestController setUserStyleSheetEnabled:]):
10:33 PM Changeset in webkit [23024] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/5041348>
Can't watch videos at cnn.com


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::cancelAndDestroyStream): Change this function back to call call stop() after destroyStream(). Also, make sure to protect the stream since destroyStream can eventually, well, destroy it.
9:41 PM Changeset in webkit [19976] by bdash
  • 1 edit in tags/Safari-5522.2/WebKit/Info.plist

Versioning.

9:40 PM Changeset in webkit [19975] by bdash
  • 3 edits in tags/Safari-5522.2/WebKit

Merge in r19929.

2007-03-01 Justin Garcia <​justin.garcia@apple.com>

Reviewed by harrison


<rdar://problem/4838199>
Integrate Mail and WebKit paste operations


Provide subresources used to create the fragment as a
convenience.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): Update the calls to the changed method. (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Give the caller the subresources in the WebArchive and RTF cases.
  • WebView/WebHTMLViewPrivate.h:
9:36 PM Changeset in webkit [19974] by bdash
  • 1 copy in tags/Safari-5522.2/WebKit

New tag (part 2).

9:35 PM Changeset in webkit [19973] by bdash
  • 1 add in tags/Safari-5522.2

New tag (part 1).

5:35 PM Changeset in webkit [19972] by zimmermann
  • 142 edits
    10 adds in trunk

Reviewed by Darin.

Fix all (except one) known <use> bug. The remaining bug (12630) is not crucical at all.
Enable <use> again as default SVG feature, as discussed on webkit-dev.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12936 (Master bug used to track all current use problems.)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12926 (transform attribute not respected in nested <use> elements)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12267 (getElementById broken for <use>)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12916 (use instance in symbol definition does not work)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12917 (mouseout event does not occur after scaling use instance)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12838 (SVG <use> DOM broken for script)

Added test: svg/custom/use-nested-transform.svg
Added test: svg/custom/struct-use-09-b.svg (not yet official W3C-SVG-1.1 testcase)
Fixes test: svg/custom/use-elementInstance-event-target.svg (rectangle now turns green on first click)

5:11 PM Changeset in webkit [19971] by beidson
  • 3 edits in trunk/WebCore

Reviewed by John

Fixes <rdar://problem/4974258>
Adds some key null checking

  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::implementsCall): Null check doc/frame
  • bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]): Null check doc/frame
4:05 PM Changeset in webkit [19970] by zimmermann
  • 5 edits
    4 adds in trunk

Reviewed by Darin.

Path::normalAngleAtLength() / Path::pointAtLength() don't work correctly.
pointAtLength() was not implemented, basically and normalAngleAtLength()
had a bug in the tangent slope calculation.

The normalAngleAtLength() stuff can only be tested with my local textPath support.
New LayoutTest: svg/custom/path-textPath-simulation.svg

3:02 PM Changeset in webkit [19969] by oliver
  • 1 edit
    2 moves
    2 adds in trunk/LayoutTests

2007-03-05 Darin Adler <Darin Adler>

Reviewed by Oliver.

Text encoding test case

  • fast/encoding/char-encoding-expected.txt: Added.
  • fast/encoding/char-encoding.html: Added.
  • fast/encoding/charset-names-expected.txt: Moved.
  • fast/encoding/charset-names.html: Moved.
1:09 PM Changeset in webkit [23023] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4987743>
Regression: java content is represented as broken images on pages


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load): Make sure to set the size of the NPPluginFuncs struct correctly.
12:39 PM Changeset in webkit [19968] by ap
  • 5 edits
    1 copy
    1 add in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12970
Fix and import 4XPath test_core_functions.html test

WebCore:

  • xml/XPathExpression.cpp: (WebCore::XPathExpression::evaluate): Fully initialize the evaluation context.
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunSubstring::doEvaluate): Fixed handling of edge cases. (WebCore::XPath::FunRound::round): Reimplemented to match the spec; exposed FunRound::round() to be used in other functions.

LayoutTests:

  • fast/xpath/4XPath/Core/test_core_functions-expected.txt: Added.
  • fast/xpath/4XPath/Core/test_core_functions.html: Added. The remaining failures with id() are caused by an XML DOM problem - ID attributes declared in an internal subset are not treated as such.
  • fast/xpath/4XPath/Core/test.js: Common data for XPath tests.
12:29 PM Changeset in webkit [19967] by andersca
  • 2 edits in trunk/LayoutTests
  • plugins/get-url-with-blank-target-expected.txt: Update test result.
11:38 AM Changeset in webkit [23022] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Added line spacing querying to FontMetrics to support line wrapping.

11:31 AM Changeset in webkit [19966] by andersca
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adam, Darin.

<rdar://problem/5025212>
In Mail, a crash occurs at WebCore::Frame::tree() when clicking on embedded flash object

  • plugins/get-url-with-blank-target-expected.txt: Added.
  • plugins/get-url-with-blank-target.html: Added.

WebKit:

Reviewed by Adam, Darin.


<rdar://problem/5025212>
In Mail, a crash occurs at WebCore::Frame::tree() when clicking on embedded flash object

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadPluginRequest:]): Handle the case where the web view returned from the delegate method is null. Also, send out an error notification in that case so we can catch it.

WebKitTools:

Reviewed by Adam, Darin.

<rdar://problem/5025212>
In Mail, a crash occurs at WebCore::Frame::tree() when clicking on embedded flash object


Add a "getURLNotify" method to the plugin object. This lets you pass a URL, a target and a callback function
to be run when the URL has finished (or failed) loading.


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke): (handleCallback):
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_URLNotify):
10:37 AM Changeset in webkit [19965] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin and Kevin D

  • fixed <rdar://problem/5038087> Header and footer on printed page are too large after certain steps
  • WebView/WebView.mm: (-[WebView _adjustPrintingMarginsForHeaderAndFooter]): This method was modifying the margins in the NSPrintInfo object without any sort of check whether this had already been done. In some cases this can be called multiple times with the same NSPrintInfo, so now we stash information in the NSPrintInfo's dictionary such that we always start with a fresh copy of the original margins.
10:25 AM Changeset in webkit [19964] by ap
  • 12 deletes in trunk/LayoutTests/fast/xpath/4XPath/Core

Remove accidentally committed tests.

9:36 AM Changeset in webkit [19963] by ap
  • 6 edits
    2 moves
    36 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12954
XPath relative operations are implemented incorrectly

WebCore:

  • xml/XPathPredicate.cpp: (WebCore::XPath::NumericOp::doEvaluate): (WebCore::XPath::EqTestOp::compare): (WebCore::XPath::EqTestOp::doEvaluate): Reimplemented relative equality operations to match the spec.
  • xml/XPathPredicate.h: (WebCore::XPath::NumericOp::): (WebCore::XPath::EqTestOp::): Moved relative operations to EqTestOp.
  • xml/XPathGrammar.y:
  • xml/XPathParser.cpp: (WebCore::XPath::Parser::nextTokenInternal): (WebCore::XPath::Parser::lex): Adapted for the above changes.

LayoutTests:

  • fast/xpath/4XPath/Core/test_boolean_expr-expected.txt: Added.
  • fast/xpath/4XPath/Core/test_boolean_expr.html: Added.
  • fast/xpath/4XPath/Borrowed/cz_20030217-expected.txt: Added.
  • fast/xpath/4XPath/Borrowed/cz_20030217.html: Added.
  • fast/xpath/4XPath/Borrowed/kd_20010423-expected.txt: Added.
  • fast/xpath/4XPath/Borrowed/kd_20010423.html: Added.
  • fast/xpath/4XPath/Borrowed/od_20000608-expected.txt: Added.
  • fast/xpath/4XPath/Borrowed/od_20000608.html: Added.
  • fast/xpath/4XPath/Borrowed/resources/od_20000608.xml: Added.
  • fast/xpath/4XPath/Borrowed/rs_20010831-expected.txt: Added.
  • fast/xpath/4XPath/Borrowed/rs_20010831.html: Added.
  • fast/xpath/4XPath/Borrowed/sr_20021217-expected.txt: Added.
  • fast/xpath/4XPath/Borrowed/sr_20021217.html: Added. Added a bunch of XPath tests that already passed.
  • fast/xpath/4XPath/Borrowed/namespace-nodes-expected.txt: Added.
  • fast/xpath/4XPath/Borrowed/namespace-nodes.html: Added.
  • fast/xpath/namespace-nodes-expected.txt: Removed.
  • fast/xpath/namespace-nodes.html: Removed. Moved a previously imported 4XPath test.
1:41 AM Changeset in webkit [19962] by bdash
  • 1 edit in trunk/WebCore/ChangeLog

Pesky apostrophe.

1:39 AM Changeset in webkit [19961] by bdash
  • 2 edits in trunk/WebCore

2007-03-05 Mark Rowe <​mrowe@apple.com>

Reviewed by Lars.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12947
Bug 12947: REGRESSION: ASSERTION FAILED: maxWidth >= 0 in StringTruncator.cpp:109 in WebCore::truncateString()

Handle nil window correctly in toUserSpace and toDeviceSpace. On Intel Mac's a message to nil that returns a
float will return 0.0. We use this as the divisor in calculating a scale factor, which results in NaN being
introduced into our rect.

  • platform/mac/ScreenMac.mm: (WebCore::toUserSpace): (WebCore::toDeviceSpace):
1:07 AM Changeset in webkit [19960] by rwlbuis
  • 3 edits
    5 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12868
parts of the CSS classes in this simple SVG example are not applied

Make sure the xml stylesheets are parsed in strict mode.

1:00 AM Changeset in webkit [23021] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-03-05 Steve Falkenburg <​sfalken@apple.com>

Fix build

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::stop): Call cancel() instead of stopLoading(), since the latter was removed.
Note: See TracTimeline for information about the timeline view.