Timeline



Mar 26, 2007:

9:45 PM Changeset in webkit [23196] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Ada

This one didn't actually have any leaks, but I just felt like doing the
same style cleanup as the others :)


  • WebPreferences.cpp: (WebPreferences::stringValueForKey): (WebPreferences::integerValueForKey): (WebPreferences::floatValueForKey): (WebPreferences::setStringValue): (WebPreferences::setIntegerValue): (WebPreferences::save): (WebPreferences::load):
8:49 PM Changeset in webkit [20505] by ddkilzer
  • 2 edits in trunk

Added Radar references.

7:46 PM Changeset in webkit [20504] by ggaren
  • 1 edit in trunk/WebCore/ChangeLog

fixed up order of ChangeLog entries

7:36 PM Changeset in webkit [20503] by ggaren
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin Adler.


Layout tests for <rdar://problem/5088234> REGRESSION: Crash occurs at
WebCore::Node::createRendererIfNeeded() when changing map views with MS
Virtual Earth (​http://www.ziprealty.com/)

  • fast/dom/mutation-event-remove-inserted-node-expected.txt: Added.
  • fast/dom/mutation-event-remove-inserted-node.html: Added.
  • fast/dom/script-element-remove-self-expected.txt: Added.
  • fast/dom/script-element-remove-self.html: Added.

WebCore:

Reviewed by Darin, landed by Anders.

Manual test case for ​http://bugs.webkit.org/show_bug.cgi?id=13142

  • manual-tests/liveconnect-applet-get-boolean.html: Added.
  • manual-tests/resources/CheckerApplet.class: Added.
  • manual-tests/resources/CheckerApplet.java: Added.
7:33 PM Changeset in webkit [23195] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Ada

<rdar://5090412> - Plug CFNumberRef leaks in WebCache


  • WebCache.cpp: (WebCache::statistics):
6:57 PM Changeset in webkit [20502] by andersca
  • 4 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Darin, landed by Anders.

Fix for: ​http://bugs.webkit.org/show_bug.cgi?id=13142

The previous fix ​http://bugs.webkit.org/show_bug.cgi?id=12636
introduced new JNIType to enum in jni_utility.h This is a
problem on the Mac as it seems that the JNIType enum is also
used in the JVM, it is used to specify the return type in
jni_objc.mm
Corrected the fix by moving type to the end, and changing
jni_objc.mm to convert the new type to an old compatible
type.

  • bindings/jni/jni_objc.mm: (KJS::Bindings::dispatchJNICall):
  • bindings/jni/jni_utility.h:

WebCore:

Reviewed by Darin, landed by Anders.

Manual test case for ​http://bugs.webkit.org/show_bug.cgi?id=13142

  • manual-tests/liveconnect-applet-get-boolean.html: Added.
  • manual-tests/resources/CheckerApplet.class: Added.
  • manual-tests/resources/CheckerApplet.java: Added.
6:11 PM Changeset in webkit [20501] by aroben
  • 5 edits in trunk/JavaScriptCore

Reviewed/landed by Adam.

Bug 13198: Move build settings from project file to xcconfig file for apollo
port JSCore
​http://bugs.webkit.org/show_bug.cgi?id=13198

  • Moving build settings from xcode project file to xcconfig files.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Debug.xcconfig:
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Release.xcconfig:
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig:
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
5:12 PM Changeset in webkit [23194] by bdakin
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Geoff.

Fix build without breaking anything.

  • WebHistory.cpp: (releaseUserInfo): Added silly void statement for now.
4:55 PM Changeset in webkit [23193] by bdakin
  • 2 edits in branches/WindowsMerge/WebKitWin

Rubber-stamped by Brady.

Build fix for release build.

  • WebHistory.cpp: (releaseUserInfo): Do not store userInfo->Release() in a local variable since it is only used for an ASSERT.
4:52 PM Changeset in webkit [20500] by beidson
  • 3 edits in trunk/JavaScriptCore

Rubberstamped by Anders and Maciej aand Geoff (oh my!)


Since CFTypeRef is really void*, a RetainPtr couldn't be used.
RefType was "void", which doesn't actually exist as a type.
Since RefType only existed for operator*(), and since that operator
doesn't make any sense for RetainPtr, I removed them!

  • kjs/nodes.cpp: Touch this to force a rebuild and (hopefully) help the compiler with dependencies
  • wtf/RetainPtr.h: Nuke RefType and operator*()
4:46 PM Changeset in webkit [20499] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

  • fast/replaced/selection-rect-in-table-cell-expected.checksum: Added.
  • fast/replaced/selection-rect-in-table-cell-expected.png: Added.
  • fast/replaced/selection-rect-in-table-cell-expected.txt: Added.
  • fast/replaced/selection-rect-in-table-cell.html: Added.

WebCore:

Reviewed and landed by Darin.

Test: fast/replaced/selection-rect-in-table-cell.html

  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::selectionRect):
3:09 PM Changeset in webkit [20498] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Dave Harrison


  • fixed <rdar://problem/4769772> Problem with Find on certain PDF page
  • WebView/WebPDFView.mm: (-[WebPDFView _scaledAttributedString:]): We were hitting an exception trying to set the font attribute to nil, which was happening because the result of -[PDFSelection attributedString] had no attributes. That PDFSelection bug is now filed separately, but this works around the exception.
1:55 PM Changeset in webkit [23192] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-03-26 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou.


<rdar://problem/5088764> Move the "Icon.db" file under "Local Settings"

  • WebIconDatabase.cpp: (userIconDatabasePath): Move icon database to non-roaming location
1:32 PM Changeset in webkit [20497] by ggaren
  • 2 edits in trunk/JavaScriptCore

Touched a file to (hopefully) help the compiler with RetainPtr dependencies.

  • kjs/nodes.cpp: (Node::deref):
1:31 PM Changeset in webkit [20496] by ggaren
  • 9 edits in trunk/WebCore

Removed now-stale #includes of <assert.h>.


  • WebCorePrefix.h:
  • config.h:
  • css/CSSGrammar.y:
  • platform/Arena.cpp:
  • platform/KURL.cpp:
  • platform/SegmentedString.h:
  • rendering/DataRef.h:
  • rendering/RenderArena.cpp:
1:08 PM Changeset in webkit [20495] by ggaren
  • 56 edits in trunk/WebCore

Reviewed by Kevin McCulough.

Global replace of "assert(" with "ASSERT(" to assist debugging. Removed
one instance of commented-out code containing "assert(" instead of replacing it.

1:00 PM Changeset in webkit [23191] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Fix for <rdar://problem/5088844> Popup menu is not positioned correctly on a yahoo comics page


Fixes test: fast/forms/control-restrict-line-height.html


This change was made in RenderThemeMac a while ago, and will fix the line height for aqua popup buttons,
buttons and search fields.


9:57 AM Changeset in webkit [20494] by darin
  • 2 edits in trunk/WebKitSite
  • coding/coding-style.html: Let's misquote George Orwell: "Wrong is right. Right is wrong."

Mar 25, 2007:

9:10 PM Changeset in webkit [20493] by darin
  • 2 edits in trunk/WebKitSite
  • coding/coding-style.html: Put !important on right/wrong colors so they override the green color that comes from the green.css stylesheet.
9:07 PM Changeset in webkit [20492] by darin
  • 2 edits in trunk/WebKitSite
  • coding/RefPtr.html: A couple minor wording tweaks.
9:05 PM Changeset in webkit [20491] by darin
  • 2 edits in trunk/WebKitSite
  • coding/RefPtr.html: Put the operator name "new" in the oblique style as with other identifiers.
8:54 PM Changeset in webkit [23190] by beidson
  • 8 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Oliver

<rdar://problem/5086888> - WebHistory(Item) Leak

  • platform/win/COMPtr.h: (COMPtr::COMPtr): An an adoptRef constructor


WebKitWin:

Reviewed by Oliver


<rdar://problem/5086888> - WebHistory(Item) Leak


This is a pretty thourough touchup up style and correctness that
plugs at least 1 definite leak and many potential leaks with
extensive use of RetainPtr and COMPtr.


This should result in no change in behavior

  • MarshallingHelpers.cpp: Add kIUnknownDictionaryValueCallBacks
  • MarshallingHelpers.h: Ditto


  • WebHistory.cpp: (createUserInfoFromArray): (createUserInfoFromHistoryItem): (releaseUserInfo): (WebHistory::WebHistory): (WebHistory::~WebHistory): (WebHistory::loadFromURL): (createHistoryListFromStream): Split of the Structured Exception Handling to a seperate function to cooperate with C++ (WebHistory::loadHistoryGutsFromURL): (WebHistory::saveToURL): (WebHistory::saveHistoryGuts): (WebHistory::datesArray): (WebHistory::addItems): (WebHistory::removeItems): (WebHistory::removeAllItems): (WebHistory::orderedLastVisitedDays): (WebHistory::orderedItemsLastVisitedOnDay): (WebHistory::removeItem): (WebHistory::addItem): (WebHistory::addItemForURL): (WebHistory::itemForURLString): (WebHistory::itemForURL): (WebHistory::containsItemForURLString): (WebHistory::removeItemForURLString): (WebHistory::addItemToDateCaches): (WebHistory::removeItemFromDateCaches): (WebHistory::findIndex): (WebHistory::insertItem): (WebHistory::ageLimitDate):
  • WebHistory.h:


  • WebHistoryItem.cpp: (WebHistoryItem::dictionaryRepresentation): (WebHistoryItem::mergeAutoCompleteHints):
4:45 PM Changeset in webkit [23189] by aroben
  • 2 edits
    4 adds in branches/WindowsMerge/LayoutTests

LayoutTestsWin:

Reviewed by Anders.

Fix <rdar://problem/5066290> boomer-run-webkit-tests doesn't support
http tests

  • Skipped: Removed http tests from the skipped list.
  • http/conf/cygwin-httpd.conf: Added.
  • http/conf/libphp4.dll: Added.
3:42 PM Changeset in webkit [20490] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adam.


Test for <rdar://problem/5049842>
Gmail Editor: Dragging message text in the message body results in a crash at WebCore::Frame::eventHandler()

  • editing/pasteboard/drag-drop-dead-frame-expected.checksum: Added.
  • editing/pasteboard/drag-drop-dead-frame-expected.png: Added.
  • editing/pasteboard/drag-drop-dead-frame-expected.txt: Added.
  • editing/pasteboard/drag-drop-dead-frame.html: Added.

WebCore:

Reviewed by Adam.

Fix <rdar://problem/5049842>
Gmail Editor: Dragging message text in the message body results in a crash at WebCore::Frame::eventHandler()

Null check frame in m_dragTarget, it might be gone already.

  • page/EventHandler.cpp: (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::cancelDragAndDrop): (WebCore::EventHandler::performDragAndDrop):
1:14 PM Changeset in webkit [23188] by aroben
  • 11 edits
    4 adds in branches/WindowsMerge

LayoutTestsWin:

Reviewed by Oliver.

  • Skipped: Added two more crashers for when we enable http tests.

WebKitToolsWin:

Reviewed by Oliver.

Fix <rdar://problem/5086934> DumpRenderTree doesn't support
layoutTestController.queueLoad

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Ported Mac code to check the MIME type before dumping. (runTest): Clear the work queue before each test.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added new files.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (notifyDoneCallback): Only dump if the work queue is empty. (jsValueToCString): Added. (queueLoadCallback): Added. (queueReloadCallback): Added. (queueScriptCallback): Added. (queueBackNavigationCallback): Added. (queueForwardNavigationCallback): Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::processWork): Added. (processWorkTimer): Added. (WaitUntilDoneDelegate::locationChangeDone): Changed to match Mac.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Added declaration.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Added. (WorkQueue::shared): (WorkQueue::WorkQueue): (WorkQueue::queue): (WorkQueue::dequeue): (WorkQueue::count): (WorkQueue::clear):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Added. (WorkQueue::setFrozen):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Added. (LoadItem::invoke): (ReloadItem::invoke): (ScriptItem::invoke): (BackForwardItem::invoke):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Added. (LoadItem::LoadItem): (LoadItem::url): (LoadItem::target): (ScriptItem::ScriptItem): (ScriptItem::script): (BackItem::BackItem): (ForwardItem::ForwardItem):

WebKitWin:

Reviewed by Oliver.

WebKit part of <rdar://problem/5086934> DumpRenderTree doesn't support
layoutTestController.queueLoad

  • WebFrame.cpp: (WebFrame::findFrameNamed): Implemented.
  • WebHistoryItem.cpp: (WebHistoryItem::children): Don't increment i twice per loop!
8:10 AM Changeset in webkit [20489] by bdash
  • 2 edits in trunk/WebKitTools

2007-03-26 Mark Rowe <​mrowe@apple.com>

Reviewed by Sam Weinig.

Upload crash logs from DumpRenderTree as part of the test results to ease debugging
of hard-to-reproduce crashes.

  • BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
3:33 AM Changeset in webkit [20488] by bdash
  • 2 edits in trunk/WebKitSite

2007-03-25 Mark Rowe <​mrowe@apple.com>

Fix grammar error that Mitz pointed out. Replace raw ampersands in hyperlink URL with named entity.

  • coding/RefPtr.html:
3:25 AM Changeset in webkit [23187] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix.

  • WebDownload.h: Include RetainPtr from WTF.
1:39 AM Changeset in webkit [20487] by ap
  • 6 edits in trunk/WebCore

Reviewed by Darin.

A partial fix for ​http://bugs.webkit.org/show_bug.cgi?id=13021
XPath can be very slow

  • xml/XPathExpression.cpp: (WebCore::XPathExpression::evaluate): Reset a reference to the context node, as this may prevent the whole document from being destroyed in time.
  • dom/Attr.cpp: (WebCore::Attr::createTextChild): Instead of calling appendChild(), just do the few operations it really needs to perform.
  • dom/ContainerNode.h: (WebCore::ContainerNode::fastSetFirstChild): (WebCore::ContainerNode::fastSetLastChild): Added operations that let Attr hack internal ContainerNode data (evil, but fast!).
  • xml/XPathStep.cpp: (WebCore::XPath::Step::evaluate): (WebCore::XPath::Step::nodesInAxis): (WebCore::XPath::Step::nodeMatches):
  • xml/XPathStep.h: Merged node testing into axis enumeration. This saves a lot of Vector resizing and passing, and is necessary for future optimizations (sometimes, we can just pick the single result node instead of enumerating and filtering the whole axis).
12:43 AM Changeset in webkit [20486] by darin
  • 2 edits in trunk/WebKitSite
  • coding/RefPtr.html: A couple wording tweaks.
12:11 AM Changeset in webkit [20485] by darin
  • 2 edits in trunk/WebKitSite
  • coding/RefPtr.html: More formatting tweaks. Added a possible new topic for the document, suggested by Anders.

Mar 24, 2007:

11:52 PM Changeset in webkit [20484] by darin
  • 2 edits in trunk/WebKitSite
  • css/main.css: Try tighter spacing for code examples.
11:48 PM Changeset in webkit [20483] by darin
  • 2 edits in trunk/WebKitSite
  • coding/RefPtr.html: <span> -> </span>
11:44 PM Changeset in webkit [20482] by darin
  • 2 edits in trunk/WebKitSite
  • coding/RefPtr.html: "smart pointer" -> "smart pointers"
11:38 PM Changeset in webkit [20481] by darin
  • 17 edits
    1 add in trunk/WebKitSite
  • coding/RefPtr.html: Added. First draft of a document about RefPtr.

Also tweaked the MIME types of a few files and removed a stray executable bit.

11:37 PM Changeset in webkit [20480] by hyatt
  • 2 edits in trunk/WebKit

Amend the statistics reporting for the WebCore cache to include XSL and to report live/decoded sizes.

  • Misc/WebCache.mm: (+[WebCache statistics]):
11:28 PM Changeset in webkit [20479] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/text/midword-break-after-breakable-char-expected.checksum: Added.
  • fast/text/midword-break-after-breakable-char-expected.png: Added.
  • fast/text/midword-break-after-breakable-char-expected.txt: Added.
  • fast/text/midword-break-after-breakable-char.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/text/midword-break-after-breakable-char.html

Breaking in the middle of the word
is allowed only if no breaking opportunity between words has occurred yet. The
first position on the line should not be considered "between words" even if
it is a breaking opportunity.


  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Changed according to the above. Also cleaned up a couple of lines.
10:53 PM Changeset in webkit [20478] by hyatt
  • 13 edits in trunk/WebCore

Fix for bugzilla bug 13187, place a hard limit on the amount of decoded data that WebCore will keep
around even on live pages (pages being displayed in tabs/windows or in the back/forward cache).
Images will decode to paint and once the decoded data exceeds the cache size, the decoded data will be
tossed.

Refine the flushing algorithm to apply the two-pass decode/evict model to each LRU-SP queue individually, rather
than to all the lists at once. This allows the cache to evict large encoded resources before flushing small
or frequently accessed decoded onces.

Added information on live/decoded data to the cache statistics.

Reviewed by darin

  • loader/Cache.cpp: (WebCore::Cache::Cache): (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneAllResources): (WebCore::Cache::setMaximumSize): (WebCore::Cache::remove): (WebCore::Cache::lruListFor): (WebCore::Cache::removeFromLRUList): (WebCore::Cache::insertInLRUList): (WebCore::Cache::liveLRUListFor): (WebCore::Cache::removeFromLiveResourcesList): (WebCore::Cache::insertInLiveResourcesList): (WebCore::Cache::addToLiveResourcesSize): (WebCore::Cache::removeFromLiveResourcesSize): (WebCore::Cache::adjustSize): (WebCore::Cache::getStatistics):
  • loader/Cache.h: (WebCore::Cache::TypeStatistic::TypeStatistic):
  • loader/CachedImage.cpp: (WebCore::CachedImage::decodedSizeWillChange): (WebCore::CachedImage::decodedSizeChanged):
  • loader/CachedImage.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::ref): (WebCore::CachedResource::deref): (WebCore::CachedResource::setEncodedSize): (WebCore::CachedResource::liveResourceAccessed):
  • loader/CachedResource.h: (WebCore::CachedResource::liveAccessCount): (WebCore::CachedResource::resetLiveAccessCount): (WebCore::CachedResource::increaseLiveAccessCount):
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData): (WebCore::BitmapImage::cacheFrame):
  • platform/graphics/ImageObserver.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintBorderImage):
10:14 PM Changeset in webkit [23186] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-03-24 Steve Falkenburg <​sfalken@apple.com>

Build fix.

  • WebDownload.h: Remove WebCore namespace
9:31 PM Changeset in webkit [23185] by aroben
  • 9 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Oliver.

Fix <rdar://problem/5086932> DumpRenderTree doesn't support
layoutTestController.dumpBackForwardList

Unfortunately the ported code is mostly untested due to
<rdar://problem/5086934>.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (compareHistoryItems): Ported from Mac. (dumpHistoryItem): Ditto. (dumpBackForwardList): Ditto. (dump): Dump the back-forward list if requested. (runTest): Initialize new globals.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added extern declaration.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (dumpBackForwardListCallback): Implemented.

WebKitWin:

Reviewed by Oliver.

WebKit part of <rdar://problem/5086932> DumpRenderTree doesn't support
layoutTestController.dumpBackForwardList

  • Interfaces/IWebHistoryItemPrivate.idl: Added declarations.
  • WebFrame.cpp: (WebFrame::childFrames): Removed unused variable.
  • WebHistoryItem.cpp: (WebHistoryItem::target): Implemented. (WebHistoryItem::isTargetItem): Implemented. (WebHistoryItem::children): Implemented.
  • WebHistoryItem.h: Added declarations.
7:48 PM Changeset in webkit [20477] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Mitz.

  • fast/css/css-selector-text-expected.txt: Added.
  • fast/css/css-selector-text.html: Added.

WebCore:

Reviewed by Mitz.

Test: fast/css/css-selector-text.html

  • css/CSSSelector.cpp: (WebCore::CSSSelector::selectorText): Add the namespace prefix for tag or attribute names, the sub-selector for :not, and the argument for :lang.
6:27 PM Changeset in webkit [23184] by aroben
  • 4 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Fix <rdar://problem/5076610> Crash in PluginViewWin::updateWindow when
loading a PDF page for the first time after installing Acrobat Reader

Don't call PluginPackageWin::load() until the PluginViewWin has been
inserted into the Widget tree. load() can result in arbitrary code
execution (in this case, a EULA window appears which takes focus from
the WebView, causing Frame::setIsActive(false) to be called), and we
don't want to be in a transitional state when that happens.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::createPluginView): Call PluginViewWin's one and only constructor.
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setParent): Call init() after inserting ourselves into the Widget tree. (WebCore::PluginViewWin::PluginViewWin): Defer all real work until init() is called. (WebCore::PluginViewWin::init): Added. Calls m_plugin->load(), then does the rest of the work that was once done by the constructor.
  • plugins/win/PluginViewWin.h: Removed createNullPlugin and simplified constructor, added setParent override and new init method.
6:22 PM Changeset in webkit [20476] by beidson
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Adam

Whoops, RetainPtr should be in the WTF namespace

  • wtf/RetainPtr.h:

WebKit:

Reviewed by Adam

RetainPtr is no longer in the WebCore namespace

  • History/WebBackForwardList.mm:
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebView/WebDocumentLoaderMac.h:
4:27 PM Changeset in webkit [23183] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam

<rdar://problem/5086210> - Move RetainPtr to WTF for WebKitWin and the App

  • WebCore.vcproj/WebCore.vcproj: Add the ForwardingHeader to the vcprojs
4:21 PM Changeset in webkit [20475] by beidson
  • 30 edits
    1 move
    2 adds in trunk

JavaScriptCore:

Reviewed by Adam


<rdar://problem/5086210> - Move RetainPtr to WTF

WebCore:

Reviewed by Adam

<rdar://problem/5086210> - Move RetainPtr to WTF

  • ForwardingHeaders/wtf/RetainPtr.h: Added.
  • WebCore.xcodeproj/project.pbxproj: Removed WebCore/RetainPtr.h


  • history/HistoryItem.h: Changed #include to <wtf/RetainPtr.h>
  • history/PageCache.h: Ditto
  • page/mac/WebCoreFrameBridge.mm: Ditto
  • platform/ContextMenu.h: Ditto
  • platform/ContextMenuItem.h: Ditto
  • platform/DragImage.h: Ditto
  • platform/FileChooser.h: Ditto
  • platform/PlatformKeyboardEvent.h: Ditto
  • platform/PopupMenu.h: Ditto
  • platform/SharedBuffer.h: Ditto
  • platform/cf/RetainPtr.h: Removed.
  • platform/graphics/Icon.h: Changed #include
  • platform/mac/ClipboardMac.h: Ditto
  • platform/mac/PasteboardMac.mm: Ditto
  • platform/mac/WidgetMac.mm: Ditto
  • platform/network/AuthenticationChallenge.h: Ditto
  • platform/network/ResourceError.h: Ditto
  • platform/network/ResourceHandle.h: Ditto
  • platform/network/ResourceRequest.h: Ditto
  • platform/network/ResourceResponse.h: Ditto
  • rendering/RenderThemeMac.mm: Ditto

WebKit:

Reviewed by Adam

<rdar://problem/5086210> - Move RetainPtr to WTF


  • ForwardingHeaders/wtf/RetainPtr.h: Added.
  • History/WebBackForwardList.mm: Changed #import to <wtf/RetainPtr.h>
  • WebCoreSupport/WebEditorClient.h: Ditto
  • WebCoreSupport/WebFrameLoaderClient.h: Ditto
  • WebView/WebDocumentLoaderMac.h: Ditto
4:15 PM Changeset in webkit [20474] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5086797>, layoutPending is now reporting incorrect results, which will lead
to all sorts of layout issues. This is in bugzilla as 13179.

Reviewed by hyatt

Moved the root->needsLayout() check from layoutPending() to needsLayout()
to restore the behavior before r20324.

  • page/FrameView.cpp: (WebCore::FrameView::layoutPending): (WebCore::FrameView::needsLayout):
3:13 PM Changeset in webkit [20473] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Adele.

<rdar://problem/5084478>

Another debug build crash from ASSERTION FAILED: !needsLayout()

No test possible because updateRendering() is always called after script
execution.

  • page/FrameView.cpp: (WebCore::FrameView::layout): Get the layout root after calling recalcStyle() since a style recalc may result in needing to do start layout at the root.
2:53 PM Changeset in webkit [20472] by zimmermann
  • 2 edits in trunk/WebCore

Not reviewed. Build fix.
Fix FloatRect vs. IntRect confusion.

10:25 AM Changeset in webkit [20471] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Adele

  • fixed <rdar://problem/5084872> Need to add flickr to spoof list in WebKit
  • only do site-specific spoofing if a preference is set
  • WebView/WebPreferenceKeysPrivate.h: added WebKitUseSiteSpecificSpoofingPreferenceKey


  • WebView/WebPreferences.m: (+[WebPreferences initialize]): initialize WebKitUseSiteSpecificSpoofingPreferenceKey to false (-[WebPreferences _useSiteSpecificSpoofing]): get value of WebKitUseSiteSpecificSpoofingPreferenceKey (-[WebPreferences _setUseSiteSpecificSpoofing:]): set value of WebKitUseSiteSpecificSpoofingPreferenceKey


  • WebView/WebPreferencesPrivate.h: declare _useSiteSpecificSpoofing and _setUseSiteSpecificSpoofing


  • WebView/WebView.mm: cache the value of WebKitUseSiteSpecificSpoofingPreferenceKey in a bool in _private (-[WebView _preferencesChangedNotification:]): update the cached value (-[WebView setPreferences:]): ditto (-[WebView WebCore::_userAgentForURL:WebCore::]): Only spoof here if the new site-specific spoofing preference is enabled. If it is, pass Safari 2.0.4's user agent string for flickr.com. We can remove this case when 5081617 is addressed.
6:26 AM Changeset in webkit [20470] by bdash
  • 2 edits in trunk/WebCore

Fix incorrect radar number.

5:27 AM Changeset in webkit [20469] by zimmermann
  • 3 edits
    4 adds in trunk

Reviewed by Oliver.

Fix all known RenderSVGImage problems.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12126 (RenderSVGImage seems to suffer from integer overflow)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12442 (raster images disappearing during script execution (SVG))
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12572 (WebKit does not properly invalidate image region after image load)

Added test: svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html

3:25 AM Changeset in webkit [20468] by bdash
  • 2 edits in trunk/WebCore

2007-03-24 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • platform/mac/FontMac.mm: (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize):
3:16 AM Changeset in webkit [20467] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5086400>, images scrolled offscreen continue to animate. Safari 2 would
halt animations when images were no longer visible.

Reviewed by mjs, olliej

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::advanceAnimation):
2:24 AM Changeset in webkit [20466] by bdash
  • 1 edit in tags/Safari-4522.5.2/JavaScriptGlue/Configurations/Version.xcconfig

Versioning.

2:24 AM Changeset in webkit [20465] by bdash
  • 2 edits in tags/Safari-4522.5.2/JavaScriptGlue

Merge in r20461.

2:22 AM Changeset in webkit [20464] by bdash
  • 1 copy in tags/Safari-4522.5.2/JavaScriptGlue

New tag (part 2).

2:21 AM Changeset in webkit [20463] by bdash
  • 1 add in tags/Safari-4522.5.2

New tag (part 1).

2:20 AM Changeset in webkit [20462] by bdash
  • 2 edits in trunk/JavaScriptGlue

2007-03-24 Mark Rowe <​mrowe@apple.com>

Reviewed by Dave Hyatt.

  • JavaScriptGlue.xcodeproj/project.pbxproj: Use GCC 4.0 for testjsglue.
12:07 AM Changeset in webkit [20461] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/508328>, sluggish text entry in search field. Make sure
our size actually changed before we decide to do a full repaint because of background/border
complexities.

Reviewed by aroben

  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):

Mar 23, 2007:

11:24 PM Changeset in webkit [20460] by hyatt
  • 4 edits in trunk/WebCore

Fix Gmail spurious glyphs issue.

9:38 PM Changeset in webkit [20459] by adele
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adele.

  • editing/selection/doubleclick-crash-expected.checksum:
  • editing/selection/doubleclick-crash-expected.png:
  • fast/text/selection-hard-linebreak-expected.checksum: Added.
  • fast/text/selection-hard-linebreak-expected.png: Added.
  • fast/text/selection-hard-linebreak-expected.txt: Added.
  • fast/text/selection-hard-linebreak.html: Added.

WebCore:

Reviewed by Adele.

  • fix a bug where selecting across a soft line break did not highlight to the end of the first line if it contained skipped whitespace

Test: fast/text/selection-hard-linebreak.html

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionState): Changed to treat a selection that ends on the end of a hard line break as if it ends after the line break. Fixed the case of a selection that starts and ends in the same text object as the box but does not intersect it to return SelectionNone instead of selectionBoth.
9:05 PM Changeset in webkit [20458] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/frames/hover-timer-crash-expected.txt: Added.
  • fast/frames/hover-timer-crash.html: Added.

WebCore:

Reviewed by Adele.

Test: fast/frames/hover-timer-crash.html

  • page/Frame.cpp: (WebCore::Frame::setView): Added a call to EventHandler::clear().
8:56 PM Changeset in webkit [23182] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam


<rdar://5086194> - WebHistory overreleases a CFNumber


  • WebHistory.cpp: (WebHistory::loadHistoryGutsFromURL): Don't CFRelease what we didn't legitimately get a ref for!
6:41 PM Changeset in webkit [23181] by aroben
  • 4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin.

WebKit part of <rdar://problem/5084881> Add a "turn of site-specific
hacks" menu item to the Debug menu

Added new IWebPrivate::setAllowSiteSpecificHacks SPI.

  • Interfaces/IWebViewPrivate.idl: Added declaration.
  • WebView.cpp: (WebView::userAgentForKURL): Only give a site-specific UA if site-specific hacks are turned on. (WebView::setAllowSiteSpecificHacks): Added.
  • WebView.h: (WebView::allowSiteSpecificHacks): Added.
6:18 PM Changeset in webkit [20457] by justing
  • 1 edit in trunk/WebCore/editing/ReplaceSelectionCommand.cpp

Forgot to include these nil checks in my previous checkin.

5:58 PM Changeset in webkit [20456] by justing
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by adele

<rdar://problem/5078739>
Crash in in ReplaceSelectionCommand if the fragment contains only a style span

  • editing/pasteboard/5078739-expected.txt: Added.
  • editing/pasteboard/5078739.html: Added.

WebCore:

Reviewed by adele

<rdar://problem/5078739>
Crash in in ReplaceSelectionCommand if the fragment contains only a style span

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Check for an empty fragment after removing a redundant style span instead of before.
3:54 PM Changeset in webkit [23180] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/5083928> In editable webviews, caps lock key is ignored

  • platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Removed code to store lowercase characters in m_text. Now that we use the character code to create m_text this is already taken care of. This does mean that m_unmodifiedText is not right. This is used for accesskeys, which don't work yet, so that is covered in rdar://5085596. This also fixes line endings in this file.
3:32 PM Changeset in webkit [23179] by bdakin
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Hyatt.

Fix for <rdar://problem/5083914> Cursor is wrong for all context
menus

  • WebView.cpp: (WebView::handleContextMenuEvent): Set the cursor to the pointer cursor.
3:26 PM Changeset in webkit [20455] by aroben
  • 3 edits
    2 adds in trunk/JavaScriptCore

Reviewed/landed by Adam.

Bug 13175: Make apollo mac project files for JavaScriptCore actually
build something
​http://bugs.webkit.org/show_bug.cgi?id=13175

  • JavaScriptCore.apolloproj/ForwardingSources/grammar.cpp: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig:
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
2:48 PM Changeset in webkit [20454] by hyatt
  • 2 edits in trunk/WebCore

<rdar://problem/5085063>

Fix non-looping animation on cuteoverload.com. Just always flush
decoded data for large animated images to avoid our cache getting
out of sync with the image source.

Reviewed by ggaren

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::advanceAnimation):
2:09 PM Changeset in webkit [20453] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5061024> REGRESSION: Returning false from onkeypress event on Input is ignored when key is Tab
​http://bugs.webkit.org/show_bug.cgi?id= 13020

No known way to add a layout test for this. We would need a way to know exactly how the event was consumed.

  • page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): If the keypress event has its default behavior prevented, then we should consider the keydown event handled.
1:53 PM Changeset in webkit [20452] by brmorris
  • 2 edits in S60/trunk/WebCore

rathnasa, reviewed by zalan

DESC: [S60] ESMS-6YDMWP: TRUE - GSM - broswer crashes on certain web pages
Quick fix to validate null pointers
​http://bugs.webkit.org/show_bug.cgi?id=13074

1:53 PM Changeset in webkit [23178] by aroben
  • 2 edits in branches/WindowsMerge

Being a Boy Scout.

1:50 PM Changeset in webkit [23177] by aliceli1
  • 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Reviewed by Adam.

Fixed <rdar://5084888> need to add flickr to spoof list in Boomer WebKit

  • WebView.cpp: (WebView::userAgentForKURL): added flickr spoof
1:49 PM Changeset in webkit [23176] by aliceli1
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by NOBODY (OOPS!).

Fixed <rdar://5084888> need to add flickr to spoof list in Boomer WebKit

  • WebView.cpp: (WebView::userAgentForKURL): added flickr spoof
1:48 PM Changeset in webkit [20451] by zbujtas
  • 2 edits in S60/trunk/WebCore

2007-03-23 bujtas <​zbujtas@gmail.com>

Reviewed by Sachin.
DESC: onFocus/onClick could destroy the node (and the associated rendered) under the cursor. fix to check
if the renderer is still valid.
​http://bugs.webkit.org/show_bug.cgi?id=13172

  • kwq/KWQKHTMLPart.cpp:
1:43 PM Changeset in webkit [20450] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2007-03-23 bujtas <​zbujtas@gmail.com>

Reviewed by Sachin.
DESC: onFocus/onClick could destroy the node (and the associated rendered) under the cursor. fix to check
if the renderer is still valid.
​http://bugs.webkit.org/show_bug.cgi?id=13172

  • kwq/KWQKHTMLPart.cpp:
1:42 PM Changeset in webkit [20449] by justing
  • 7 edits
    8 adds in trunk

LayoutTests:

Reviewed by darin

Fixed (was missing a newline):

  • editing/execCommand/4917055-expected.txt: Tests setting a caet before the image and changing its alignment:
  • editing/execCommand/5080333-1-expected.checksum: Added.
  • editing/execCommand/5080333-1-expected.png: Added.
  • editing/execCommand/5080333-1-expected.txt: Added.
  • editing/execCommand/5080333-1.html: Added. Tests selecting the image and changing its alignment:
  • editing/execCommand/5080333-2-expected.checksum: Added.
  • editing/execCommand/5080333-2-expected.png: Added.
  • editing/execCommand/5080333-2-expected.txt: Added.
  • editing/execCommand/5080333-2.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5080333>
REGRESSION: Selection changes when changing the alignment of an image


Regression occurred when we started using moveParagraphs
to move content in applyBlockStyle. moveParagraphs
moves by copying, deleting and reinserting content, and
so must be accompanied by selection preservation code.
That code uses rangeFromLocationAndLength and rangeLength,
which use TextIterators, which don't emit anything for images
and other replaced elements, causing this bug.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Ask rangeLength and rangeFromLocationAndLength to request that their TextIterators emit spaces for replaced elements. Use rangeCompliantEquivalent()s when creating a Range from VisiblePositions, since some VisiblePositions have illegal deepEquivalent()s.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Ditto.
  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): (WebCore::TextIterator::handleReplacedElement): Emit a space if requested. (WebCore::TextIterator::representNodeOffsetZero): Emit ranges before m_node, not around m_lastTextNode. These ranges should represent the part of the document associated with the emitted character. (WebCore::TextIterator::rangeLength): Take in the new bool. (WebCore::TextIterator::rangeFromLocationAndLength): Ditto. Also, don't loop an extra time after finding the end of the range when we're looking for zero length ranges. This appeared to be a workaround for the bugs fixed in representNodeOffsetZero in this patch.
  • editing/TextIterator.h:
1:05 PM Changeset in webkit [20448] by bdash
  • 4 edits in tags/Safari-4522.5.1

Versioning.

1:03 PM Changeset in webkit [20447] by bdash
  • 8 edits in tags/Safari-4522.5.1

Merge in r20445.

12:58 PM Changeset in webkit [20446] by bdash
  • 1 copy in tags/Safari-4522.5.1

New tag.

12:51 PM Changeset in webkit [20445] by bdash
  • 8 edits in trunk

2007-03-24 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Darin.

  • Configurations/JavaScriptCore.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.

2007-03-24 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Darin.

  • Configurations/JavaScriptGlue.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.

2007-03-24 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Darin.

  • Configurations/WebCore.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.

2007-03-24 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Darin.

  • Configurations/WebKit.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.
12:13 PM Changeset in webkit [20444] by zbujtas
  • 2 edits in S60/trunk/WebCore

yadavall, reviewed by <​zbujtas@gmail.com>

DESC: Fix NULL pointer check for CacheImage
​http://bugs.webkit.org/show_bug.cgi?id=13094

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::NavigableNodeUnderCursor):
11:39 AM Changeset in webkit [20443] by darin
  • 2 edits in trunk/WebCore
  • html/HTMLBodyElement.cpp: Fix comment typo.
11:38 AM Changeset in webkit [20442] by staikos
  • 2 edits in trunk/WebCore

Patch from Adam Treat to make the Qt build work without SVG and XSLT as well as
with.

11:25 AM Changeset in webkit [20441] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • <rdar://problem/5074439> handle margins on frame and iframe elements without involving FrameView, FrameLoader, etc.
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::insertedIntoDocument): Grab the margin from the frame directly here. There was no real benefit to doing this via FrameView. Later we can delete quite a bit of unneeded code here and in WebKit that exists only to set up the margin values in FrameView, which are now unused.
11:24 AM Changeset in webkit [20440] by adele
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

Tests for <rdar://problem/5080428> REGRESSION: getting value for hidden input element fails after the fix for Bug 11866
​http://bugs.webkit.org/show_bug.cgi?id=13121

  • fast/dom/HTMLInputElement/input-hidden-value-expected.txt: Added.
  • fast/dom/HTMLInputElement/input-hidden-value.html: Added.
  • fast/forms/input-value-expected.txt:

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5080428> REGRESSION: getting value for hidden input element fails after the fix for Bug 11866
​http://bugs.webkit.org/show_bug.cgi?id=13121

Rolled out the change for 11866 that made hidden input elements store the value separately from the value attribute.
Added an m_originalValue field that gets set when the element is done being parsed (in closeRenderer). In reset,
use the m_originalValue for hidden input elements.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::closeRenderer): (WebCore::HTMLInputElement::reset): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):
  • html/HTMLInputElement.h:
11:01 AM Changeset in webkit [20439] by staikos
  • 2 edits in trunk/WebKitTools

Patch by Adam Treat. Removes hardcoded path to .pro file.

10:48 AM Changeset in webkit [20438] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-03-22 spadma <​sachin.padma@nokia.com>

Reviewed by Yongjun.
DESC: When leaving a secure web page, the query "Leaving a secure web page. Continue?" is shown twice
​http://bugs.webkit.org/show_bug.cgi?id=13160
TSW ID: PNIO-6T5GMC

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):
10:45 AM Changeset in webkit [20437] by spadma
  • 2 edits in S60/trunk/WebKit

2007-03-22 spadma <​sachin.padma@nokia.com>

Reviewed by Yongjun.
DESC: When leaving a secure web page, the query "Leaving a secure web page. Continue?" is shown twice
​http://bugs.webkit.org/show_bug.cgi?id=13160
TSW ID: PNIO-6T5GMC

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):
8:08 AM Changeset in webkit [20436] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-03-20 spadma <​sachin.padma@nokia.com>

Reviewed by Yongjun.
DESC: Browser closes when clicked RSS20 feed icons on motime web
​http://bugs.webkit.org/show_bug.cgi?id=13131
TSW ID: AKKO-6Z3AM2


  • ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::HandleError):
8:07 AM Changeset in webkit [20435] by spadma
  • 2 edits in S60/trunk/WebKit

2007-03-20 spadma <​sachin.padma@nokia.com>

Reviewed by Yongjun.
DESC: Browser closes when clicked RSS20 feed icons on motime web
​http://bugs.webkit.org/show_bug.cgi?id=13131
TSW ID: AKKO-6Z3AM2


  • ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::HandleError):
8:05 AM Changeset in webkit [20434] by spadma
  • 4 edits in S60/trunk

2007-03-20 sareen

Reviewed by Zalan/Sachin.
DESC: Pointer cannot be moved after opening flash to player and returning to page ( MLIO-6YEGYC )
​http://bugs.webkit.org/show_bug.cgi?id=13014

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::NodeTypeB):
8:02 AM Changeset in webkit [20433] by spadma
  • 4 edits in S60/branches/3.1m

2007-03-20 sareen

Reviewed by Zalan/Sachin.
DESC: Pointer cannot be moved after opening flash to player and returning to page ( MLIO-6YEGYC )
​http://bugs.webkit.org/show_bug.cgi?id=13014

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::NodeTypeB):
7:57 AM Changeset in webkit [20432] by spadma
  • 2 edits in S60/trunk/WebKit

2007-03-22 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by ​zbujtas@gmail.com
DESC: [S60] Some images crash when browsing some wap page - TKWG-6Z59YX in 3.1m branch
Fix: Remove extra image content-type strings added by the server before passing it to the image decoder.
​http://bugs.webkit.org/show_bug.cgi?id=13151

  • BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::ConstructL):
7:56 AM Changeset in webkit [20431] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-03-22 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by ​zbujtas@gmail.com
DESC: [S60] Some images crash when browsing some wap page - TKWG-6Z59YX in 3.1m branch
Fix: Remove extra image content-type strings added by the server before passing it to the image decoder.
​http://bugs.webkit.org/show_bug.cgi?id=13151

  • BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::ConstructL):
4:47 AM Changeset in webkit [23175] by aroben
  • 9 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Oliver.

Implemented dumping of frame scroll positions.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dumpFrameScrollPosition): Ported from Mac. (dump): Added call to dumpFrameScrollPosition. (runTest): Initialize new global.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added extern declaration.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (dumpChildFrameScrollPositionsCallback): Implemented.

WebKitWin:

Reviewed by Oliver.

Implemented some WebFrame methods to support dumping frame scroll
offsets in DRT.

  • Interfaces/IWebFrame.idl: Changed signature of IWebFrame::childFrames.
  • Interfaces/IWebFramePrivate.idl: Added scrollOffset declaration.
  • WebFrame.cpp: (WebFrame::name): Implemented. (WebFrame::childFrames): Implemented. (WebFrame::scrollOffset): Implemented.
  • WebFrame.h: Updated/added declarations.
4:41 AM Changeset in webkit [20430] by bdash
  • 1 edit in trunk/WebCore/ChangeLog

Add radar reference.

4:37 AM Changeset in webkit [20429] by bdash
  • 3 edits
    4 adds in trunk

2007-03-23 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/lists/marker-image-error.html

  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::imageChanged): Mark ourselves for relayout if the image failed to load, since that means we will use a bullet instead.

2007-03-23 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/lists/marker-image-error-expected.checksum: Added.
  • fast/lists/marker-image-error-expected.png: Added.
  • fast/lists/marker-image-error-expected.txt: Added.
  • fast/lists/marker-image-error.html: Added.
4:23 AM Changeset in webkit [20428] by zack
  • 2 edits in trunk/WebCore

Fix the compile

2:25 AM Changeset in webkit [20427] by bdash
  • 3 edits in trunk/WebKit

2007-03-23 Mark Rowe <​mrowe@apple.com>

Build fix for when BUILDING_ON_TIGER is not defined.

  • Misc/WebTypesInternal.h:
  • WebView/WebHTMLView.mm:
1:32 AM Changeset in webkit [23174] by aroben
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Oliver.

WebKit part of fix for <rdar://problem/4990740>.

Added IWebDataSourcePrivate::mainDocumentError.

  • Interfaces/IWebDataSource.idl: Added method declaration and updated copyrights.
  • WebDataSource.cpp: (WebDataSource::mainDocumentError): Implemented.
  • WebDataSource.h: Added declaration.
12:29 AM Changeset in webkit [23173] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-03-23 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.


<rdar://problem/5083645> Spoofed UA for gmail doesn't work - should be removed

  • WebView.cpp: (WebView::userAgentForKURL): Remove gmail spoof
12:24 AM Changeset in webkit [20426] by andersca
  • 5 edits in trunk/LayoutTests

Reviewed by Adam.

Make script-add.html more deterministic.


  • fast/dom/resources/script3.js:
  • fast/dom/resources/script4.js:
  • fast/dom/resources/script5.js:
  • fast/dom/script-add.html:

Mar 22, 2007:

11:14 PM Changeset in webkit [23172] by hyatt
  • 3 edits in branches/WindowsMerge/WebKitWin

Fix for print stylesheets not being honored.

11:07 PM Changeset in webkit [20425] by hyatt
  • 4 edits in trunk/WebCore

printing changes

10:59 PM Changeset in webkit [23171] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam Roben.


Fixed <rdar://problem/5082985> Select menus are too see-through

Upped alpha value from 90 to 95. Menus will still seem a little
more see-through than on the mac, since their backgrounds are
white, not grey, but white matches other Windows browsers.


  • ChangeLog:
  • platform/win/PopupMenuWin.cpp:
10:58 PM Changeset in webkit [20424] by bdash
  • 4 edits in tags/Safari-4522.5

Versioning.

10:55 PM Changeset in webkit [20423] by sfalken
  • 1 copy in tags/Safari-522.4.2b

New tag.

10:55 PM Changeset in webkit [20422] by aroben
  • 1 edit
    8 adds in trunk/JavaScriptCore

Reviewed/landed by Adam.

  • Adding mac project files for apollo port of JavaScriptCore. Currently project just builds dftables.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Debug.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Release.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: Added.
10:50 PM Changeset in webkit [20421] by bdash
  • 2 edits in tags/Safari-4522.5/WebCore

Merge in r20390.

10:47 PM Changeset in webkit [20420] by bdash
  • 1 copy in tags/Safari-4522.5

New tag.

10:00 PM Changeset in webkit [20419] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Ada.

<rdar://problem/5074974>
CrashTracer: [USER] repro crash in Safari at com.apple.WebCore: WebCore::FrameLoader::activeDocumentLoader const + 6


  • loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): Don't use ResourceResponse:isHTTP here since that only looks at the protocol instead of if the response came from a HTTP server (and not a web archive).
9:41 PM Changeset in webkit [20418] by sfalken
  • 2 edits in branches/Safari-522/WebCore

Merged 20416 from TOT

9:07 PM Changeset in webkit [20417] by kjk
  • 2 edits in trunk/WebCore

Not reviewed - gdk build fix.

  • platform/graphics/cairo/ImageSourceCairo.cpp:
8:36 PM Changeset in webkit [20416] by hyatt
  • 2 edits in trunk/WebCore

Fix wheeling issue on gamespot.com

8:33 PM Changeset in webkit [20415] by thatcher
  • 1 copy in branches/Safari-522

New branch.

8:33 PM Changeset in webkit [20414] by thatcher
  • 1 delete in branches/Safari-522

Removing this branch.

6:43 PM Changeset in webkit [23170] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

<rdar://problem/5081539>
QT content is dupped on a page, if page is being previewed or printed.


Don't update the frame geometry if the document is in printing mode.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setFrameGeometry):
6:26 PM Changeset in webkit [23169] by andersca
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Maciej.

<rdar://problem/5082270>
Crash in windows media player at MTV.COM


Ignore any WM_PAINT events we get while painting.


  • WebView.cpp: (WebView::WebView): (WebView::updateBackingStore): (WebView::paint): (WebViewWndProc):
  • WebView.h: (WebView::isPainting):
5:32 PM Writing Layout Tests for DumpRenderTree edited by mitz@webkit.org
Removed mouseClick() since it's been removed in r20407. (diff)
5:25 PM Changeset in webkit [20413] by justing
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by kevin


<rdar://problem/5081257>
REGRESSION: New Mail signatures start out empty


  • editing/selection/5081257-1-expected.checksum: Added.
  • editing/selection/5081257-1-expected.png: Added.
  • editing/selection/5081257-1-expected.txt: Added.
  • editing/selection/5081257-1.html: Added.
  • editing/selection/5081257-2-expected.checksum: Added.
  • editing/selection/5081257-2-expected.png: Added.
  • editing/selection/5081257-2-expected.txt: Added.
  • editing/selection/5081257-2.html: Added.

WebCore:

Reviewed by kevin

<rdar://problem/5081257>
REGRESSION: New Mail signatures start out empty

  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition): Allow descent from positions inside the document into an editable body.
5:16 PM Changeset in webkit [23168] by bdakin
  • 2 edits in branches/WindowsMerge/WebCore

Fix by Hyatt, reviewed and committed by me.

Fix for <rdar://problem/5082360> Incomplete frame paint when
shrinking window @ google.com

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::setFrameGeometry): Wrong order!
5:15 PM Changeset in webkit [20412] by ddkilzer
  • 3 edits in trunk/WebKit

WebKit:

Reviewed by Darin.

Use BUILDING_ON_TIGER from WebKitPrefix.h instead of local
MAC_OS_X_VERSION_MAX_ALLOWED <= MAC_OS_X_VERSION_10_4 tests.

  • Misc/WebTypesInternal.h:
  • WebView/WebHTMLView.mm:
4:57 PM Changeset in webkit [20411] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Adele and John

<rdar://5043528> - Prepare for new API


  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::clearAuthentication): Clear CF type
4:26 PM Changeset in webkit [23167] by aroben
  • 5 edits in branches/WindowsMerge/WebKitTools

Reviewed by Adele.

Implemented layoutTestController.dumpTitleChanges.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (runTest): Initialize new global.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added extern declaration.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (dumpTitleChangesCallback): Implemented.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::didReceiveTitle): Implemented.
3:14 PM Changeset in webkit [20410] by bdakin
  • 2 edits in trunk/WebCore

Patch by Hyatt, reviewed and committed by me.

Does not reproduce consistently, so a layout test does not seem
possible.

Fix for <rdar://problem/5082421> Constantly hitting ASSERT(!
needsLayout()) in RenderView::paint()

  • page/FrameView.cpp: (WebCore::FrameView::layoutPending): It is not enough to ask if the layout timer is active. There may be times that we don't have a body yet so we cannot schedule layout yet, but the root still needs layout.
3:08 PM Changeset in webkit [20409] by spadma
  • 7 edits in S60/branches/3.1m

2007-03-22 spadma

Reviewed by Zalan.
DESC: TMCN-6Z8J7S Opening a web bank application crashes the browser
​http://bugs.webkit.org/show_bug.cgi?id=13162

  • BrowserView/inc/WebKitLoader.h:
  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::~CWebKitLoader): (CWebKitLoader::SetPageUrlL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::SaveFormData):
3:08 PM Changeset in webkit [20408] by spadma
  • 7 edits in S60/trunk

2007-03-22 spadma

Reviewed by Zalan.
DESC: TMCN-6Z8J7S Opening a web bank application crashes the browser
​http://bugs.webkit.org/show_bug.cgi?id=13162

  • BrowserView/inc/WebKitLoader.h:
  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::~CWebKitLoader): (CWebKitLoader::SetPageUrlL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::SaveFormData):
2:58 PM Changeset in webkit [23166] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

Rubberstamped by Geoff.

Removed eventSender.mouseClick now that it isn't used.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp:
2:53 PM Changeset in webkit [20407] by aroben
  • 8 edits
    2 deletes in trunk

LayoutTests:

Reviewed by Geoff.

Replaced all calls to eventSender.mouseClick with paired calls to
mouseDown/mouseUp.

  • fast/events/click-count.html:
  • fast/events/event-sender-mouse-click-expected.txt: Removed.
  • fast/events/event-sender-mouse-click.html: Removed.
  • fast/events/frame-click-focus.html:
  • fast/events/objc-event-api.html:
  • fast/forms/focus-selection-input.html:
  • fast/forms/focus-selection-textarea.html:

WebKitTools:

Reviewed by Geoff.

Removed eventSender.mouseClick because it was only useful for AppKit
controls, which we don't use anymore.

  • DumpRenderTree/EventSendingController.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): Removed mouseClick.
2:52 PM Changeset in webkit [23165] by adele
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Anders.

Fix for <rdar://problem/5071358> window.open won't work with empty urls (24fun test)

  • Interfaces/IWebURLRequest.idl:
  • WebMutableURLRequest.cpp: (WebMutableURLRequest::isEmpty): Added. Checks whether the ResourceRequest is empty. On the mac, NSURLRequests created from empty ResourceRequests are nil. We may want to consider that in the future, but there were too many places in the app that expected the IWebURLRequest to be non-null.
  • WebMutableURLRequest.h:
2:52 PM Changeset in webkit [20406] by spadma
  • 2 edits in S60/trunk/WebKit

2007-03-21 vbradley <​vincent.bradley@nokia.com>

Reviewed by Sachin.
DESC: ASAA-6X5DX8 : NewsTicker SVG icon doesn't display
​http://bugs.webkit.org/show_bug.cgi?id=13144

  • Plugin/src/PluginWin.cpp: (CPluginWin::WriteStreamToFileL):
2:50 PM Changeset in webkit [20405] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-03-21 vbradley <​vincent.bradley@nokia.com>

Reviewed by Sachin.
DESC: ASAA-6X5DX8 : NewsTicker SVG icon doesn't display
​http://bugs.webkit.org/show_bug.cgi?id=13144

  • Plugin/src/PluginWin.cpp: (CPluginWin::WriteStreamToFileL):
2:20 PM Changeset in webkit [20404] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin


Followup for recent fix to 5079700, found by assertion added to Safari.

  • page/mac/FrameMac.mm: (WebCore::Frame::searchForLabelsBeforeElement): Fixed another place in this method where an empty NSString was being returned instead of nil. Cleaned up the style a little too.
2:03 PM Changeset in webkit [20403] by thatcher
  • 1 edit in tags/JavaScriptCore-5522.4.1/JavaScriptCore/Info.plist

Versioning

2:03 PM Changeset in webkit [20402] by thatcher
  • 2 edits in tags/JavaScriptCore-5522.4.1/JavaScriptCore

Merging fix from r20368.

2:00 PM Changeset in webkit [20401] by thatcher
  • 1 copy in tags/JavaScriptCore-5522.4.1/JavaScriptCore

New tag (part 2.)

2:00 PM Changeset in webkit [20400] by thatcher
  • 1 delete in tags/JavaScriptCore-5522.4.1/JavaScriptCore

Removing bad tag.

1:59 PM Changeset in webkit [20399] by thatcher
  • 1 copy in tags/JavaScriptCore-5522.4.1/JavaScriptCore

New tag (part 2.)

1:58 PM Changeset in webkit [20398] by thatcher
  • 1 add in tags/JavaScriptCore-5522.4.1

New tag (part 1.)

1:56 PM Changeset in webkit [20397] by thatcher
  • 1 move in tags/WebCore-5522.4.1

Move this tag.

1:53 PM Changeset in webkit [20396] by thatcher
  • 1 edit in tags/Safari-5522.4.1/WebCore/Info.plist

Versiong.

1:52 PM Changeset in webkit [20395] by thatcher
  • 5 edits in tags/Safari-5522.4.1/WebCore

Merging fix from r20381.

1:51 PM Changeset in webkit [20394] by thatcher
  • 1 copy in tags/Safari-5522.4.1/WebCore

New tag (part 2.)

1:50 PM Changeset in webkit [20393] by thatcher
  • 1 add in tags/Safari-5522.4.1

New tag (part 1.)

1:45 PM Changeset in webkit [20392] by hyatt
  • 4 edits in trunk/WebCore

Remove unnecessary destroyFrameAtIndex call. Now that we throw away
the image source, it is no longer needed.

Reviewed by beth

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData):
12:28 PM Changeset in webkit [20391] by brmorris
  • 2 edits in S60/trunk/WebKit

borges, reviewed by bradley

DESC: minor fix to renderer.mmpi for new build system
​http://bugs.webkit.org/show_bug.cgi?id=13027

  • group/renderer.mmpi:
12:09 PM Changeset in webkit [20390] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Geoff, Darin.

<rdar://problem/5077892> In RapidWeaver 3.5.1, a crash occurs when attempting to load Safari Bookmarks in iMedia Browser


  • platform/mac/ThreadCheck.mm: (WebCore::_WebCoreThreadViolationCheck): Change default on Tiger to NSLog rather than raise an exception.
11:22 AM Changeset in webkit [20389] by darin
  • 2 edits in trunk/WebCore

Reviewed by Brady.

  • use binary_search instead of hash table; slightly better performance and less memory use
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::portAllowed): Use binary_search.
11:17 AM Changeset in webkit [20388] by darin
  • 4 edits in trunk

WebCore:

Reviewed by Adele.

  • fix <rdar://problem/5074630> detachChildren call should move from WebKit to WebCore
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::setDocumentLoader): Add a call to detachChildren() after the call to prepareForDataSourceReplacement(). There was no reason for this crucial loading step to be left to the client.

WebKit:

Reviewed by Adele.

  • fix <rdar://problem/5074630> detachChildren call should move from WebKit to WebCore
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::prepareForDataSourceReplacement): Remove call to detachChildren. This should be a WebCore responsibility.
3:55 AM Changeset in webkit [23164] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Fix crasher in RenderTableSection::paint

3:55 AM Changeset in webkit [23163] by hyatt
  • 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Fix crasher in RenderTableSection::paint

3:55 AM Changeset in webkit [23162] by hyatt
  • 4 edits in branches/WindowsMerge/WebKitWin

Fix crasher in RenderTableSection::paint

3:47 AM Changeset in webkit [20387] by hyatt
  • 1 edit in trunk/WebCore/platform/ScrollView.h


2:21 AM Changeset in webkit [20386] by aroben
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Ada.

Added a new test to make sure that eventSender.mouseClick works
correctly.

  • fast/events/click-count-expected.txt: Added.
  • fast/events/click-count.html: Added.

Updated results for some tests that depended on the broken version of
eventSender.mouseClick.

  • fast/events/objc-event-api-expected.txt:
  • fast/forms/focus-selection-input-expected.txt:
  • fast/forms/focus-selection-textarea-expected.txt:

WebKitTools:

Reviewed by Ada.

Make eventSender.mouseClick actually send a mouse up event.

  • DumpRenderTree/EventSendingController.m: (-[EventSendingController mouseClick]):
2:13 AM Changeset in webkit [20385] by hyatt
  • 5 edits in trunk/WebCore

Minor refactoring and cleanup of the bridge calls that want to control layout settings on the RenderView.
Have the bridge talk through the FrameView instead of just asking for the RenderView directly.

Add an assert to help catch situations where the RenderView needs layout at paint time, since this is a known
catastrophic scenario that will (much of the time) result in a crash in RenderTableSection::paint.

Reviewed by aroben

  • page/FrameView.cpp: (WebCore::FrameView::adjustViewSize): (WebCore::FrameView::needsLayout): (WebCore::FrameView::setNeedsLayout):
  • page/FrameView.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge needsLayout]): (-[WebCoreFrameBridge setNeedsLayout]):
  • rendering/RenderView.cpp: (WebCore::RenderView::paint):
1:51 AM Changeset in webkit [23161] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-03-22 Ada Chan <​adachan@apple.com>

WebKitWin:

Reviewed by Hyatt and Alice.


Changed the mouse event processing in the WebView wndproc so we actually
allow a mouse event with click count > 3, which matches the mac safari behavior.


Set globalPrevButton and globalPrevPoint also in mouse down.

  • WebView.cpp: (WebView::handleMouseEvent):
12:04 AM Changeset in webkit [23160] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Fix wheel events.

Note: See TracTimeline for information about the timeline view.