Timeline



Apr 28, 2007:

11:42 PM Changeset in webkit [21178] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-04-28 Jungshik Shin <​jungshik.shin@gmail.com>

Reviewed by Sam Weinig.

  • bindings/npruntime.h:
10:32 PM Changeset in webkit [21177] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Added test to cover updated fix for <rdar://problem/5152299>

  • fast/events/no-blur-on-enter-button-expected.txt: Added.
  • fast/events/no-blur-on-enter-button.html: Added.

WebCore:

RS by Darin.

Update to fix for <rdar://problem/5152299>

Test: fast/events/no-blur-on-enter-button.html

  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler): Don't blur the button when handling the enter key. This matches our new behavior for input elements.
9:35 PM Changeset in webkit [21176] by darin
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Improved the ChangeLog comment. Maybe the code needs a comment like this too.

9:25 PM Changeset in webkit [21175] by darin
  • 3 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

  • fix <rdar://problem/5154144> Hamachi test fails: assertion failure in ListHashSet

Test: fast/forms/add-remove-form-elements-stress-test.html

  • wtf/ListHashSet.h: (WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator): Initialize m_isDoneWithInitialFreeList to false. (WTF::ListHashSetNodeAllocator::allocate): Added assertions based on a debug-only m_isAllocated flag that make sure we don't allocate a block that's already allocated. These assertions helped pinpoint the bug. Set m_isDoneWithInitialFreeList when we allocate the last block of the initial free list. Once we're done with the initial free list, turn off the rule that says that the next node in the pool after the last node in the free list is also free. This rule works because any free nodes are added to the head of the free list, so a node that hasn't been allocated even once is always at the tail of the free list. But it doesn't work any longer once the entire pool has been used at least once. (WTF::ListHashSetNodeAllocator::deallocate): Set the node's m_isAllocated to false. (WTF::ListHashSetNodeAllocator::pastPool): Added. Used above. (WTF::ListHashSetNodeAllocator::inPool): Changed to use the pastPool function. (WTF::ListHashSetNode::ListHashSetNode): Initialize m_isAllocated to true. (WTF::ListHashSetNode::operator new): Removed variable name for unused size parameter. (WTF::ListHashSetNode::destroy): Changed to call the destructor rather than delete -- this gets rid of the need to define an operator delete.

LayoutTests:

Reviewed by Maciej.

  • test for <rdar://problem/5154144> Hamachi test fails: assertion failure in ListHashSet
  • fast/forms/add-remove-form-elements-stress-test-expected.txt: Added.
  • fast/forms/add-remove-form-elements-stress-test.html: Added.
9:09 PM Changeset in webkit [21174] by adele
  • 4 edits
    4 adds in trunk

LayoutTests:

Tests for <rdar://problem/5152299> REGRESSION: <button> elements do not respond to space and return key as similar <input> elements do

  • fast/forms/button-enter-click-expected.txt: Added.
  • fast/forms/button-enter-click.html: Added.
  • fast/forms/button-spacebar-click-expected.txt: Added.
  • fast/forms/button-spacebar-click.html: Added.

WebCore:

Fix by Darin, reviewed by me.

Fix for <rdar://problem/5152299> REGRESSION: <button> elements do not respond to space and return key as similar <input> elements do

Tests:
fast/forms/button-spacebar-click.html
fast/forms/button-enter-click.html

  • html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::): Made type enum private. Removed unnecessary m_value and m_currValue, and unused m_dirty.
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::HTMLButtonElement): Removed initialization of m_dirty. (WebCore::HTMLButtonElement::parseMappedAttribute): Removed case to parse value and accesskey attributes, which don't do anything. (WebCore::HTMLButtonElement::defaultEventHandler): Removed unnecessary check for button type. Added cases to handle spacebar and enter keys in the same way that they're handled for <input type=button/reset/submit> buttons. (WebCore::HTMLButtonElement::isSuccessfulSubmitButton): Shortened comment. (WebCore::HTMLButtonElement::appendFormData): Use value() instead of m_currValue. Renamed encoding argument to formData.
6:36 PM Changeset in webkit [21173] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dynamic/anonymous-block-layer-lost-expected.checksum: Added.
  • fast/dynamic/anonymous-block-layer-lost-expected.png: Added.
  • fast/dynamic/anonymous-block-layer-lost-expected.txt: Added.
  • fast/dynamic/anonymous-block-layer-lost.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/dynamic/anonymous-block-layer-lost.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild): Avoid cutting off layers when removing the anonymous block.
6:34 PM Changeset in webkit [21172] by darin
  • 3 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Replaced direct access to Frame's d->m_doc with a call to Frame::setDocument. (WebCore::FrameLoader::begin): Ditto. (WebCore::FrameLoader::open): Ditto. (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady): Ditto. (WebCore::FrameLoader::canCachePage): Added a comment.
  • manual-tests/secure-keyboard-enabled-after-submit.html: Added.
  • page/Frame.cpp: (WebCore::Frame::setDocument): Reset secure keyboard entry, in case the old document's focused node has set it.
6:30 PM Changeset in webkit [21171] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Adele.

  • manual-tests/update-empty-popup.html: Added.
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added a call to the client's hidePopup() callback before returning in the case that the menu is empty. Otherwise the client thinks that the menu stayed open.
12:00 PM Changeset in webkit [21170] by adele
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/4806988> REGRESSION: history.go(0) doesn't reload page (affects buttons at facebook.com)

  • fast/history/history_reload-expected.txt: Added.
  • fast/history/history_reload.html: Added.
  • fast/history/resources/history_reload_window.html: Added.

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/4806988> REGRESSION: history.go(0) doesn't reload page (affects buttons at facebook.com)

Test: fast/history/history_reload.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::scheduleHistoryNavigation): We avoid doing a redirection when going to the same url in a history navigation, but we have to still schedule a redirection when the number of steps is zero so we can force a reload.
11:29 AM Changeset in webkit [21169] by ap
  • 5 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13514
REGRESSION (r20997-21003): Crash in WebCore::Node::document

Test: fast/dom/NodeList/childNodes-reset-cache.html

  • dom/Node.cpp: (WebCore::Node::notifyLocalNodeListsChildrenChanged): Reset the common caches for child node lists. We cannot rely on notifications, since there may be no list objects left around.
  • dom/ChildNodeList.cpp: (WebCore::ChildNodeList::rootNodeChildrenChanged):
  • dom/ChildNodeList.h: Override rootNodeChildrenChanged() with an empty implementation, now that caches are reset in Node::notifyLocalNodeListsChildrenChanged().
4:36 AM Changeset in webkit [21168] by bdash
  • 2 edits in trunk/WebCore

2007-04-28 Mark Rowe <​mrowe@apple.com>

Build fix. Change use of nil to 0 in C++ source file.

  • editing/Editor.cpp: (WebCore::Editor::increaseSelectionListLevel): (WebCore::Editor::increaseSelectionListLevelOrdered): (WebCore::Editor::increaseSelectionListLevelUnordered):
1:11 AM Changeset in webkit [21167] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/dom/namespaces-1-expected.txt: Added.
  • fast/dom/namespaces-1.html: Added.

WebCore:

Reviewed by Adele.

  • dom/Node.cpp: (WebCore::TagNodeList::TagNodeList): Changed parameter to PassRefPtr, tweaked formatting. (WebCore::TagNodeList::item): Tweaked formatting. (WebCore::TagNodeList::nodeMatches): Tweaked formatting. (WebCore::Node::setPrefix): Tweaked formatting. (WebCore::Node::getElementsByTagNameNS): Added special case to turn empty namespaces into null namespaces.
1:07 AM Changeset in webkit [21166] by darin
  • 4 edits in trunk

LayoutTests:

Reviewed by Kevin Decker.

  • update test result for fix for <rdar://problem/5148271> Chinese numbers are incorrect in numbered lists (including pasting from TextEdit to Mail)
  • fast/lists/w3-list-styles-expected.txt: Updated. The new test results match the behavior of Firefox.

WebCore:

Reviewed by Kevin Decker.

  • fix <rdar://problem/5148271> Chinese numbers are incorrect in numbered lists (including pasting from TextEdit to Mail)

Covered by an existing regression test, which had wrong results checked in.

Hyatt told me not to use the algorithm in the CSS 3 specification, but I didn't listen!
This corrects mistakes there and makes our results match current Firefox.

  • rendering/RenderListMarker.cpp: (WebCore::toCJKIdeographic): Added code to strip off trailing zero digits. Added special case for zero, since that's the one case where we don't want to strip off trailing zero digits. Fixed mixed-up logic that would put the digits in each group backwards. (WebCore::listMarkerText): Corrected character values for the CJK_IDEOGRAPHIC case.
1:02 AM Changeset in webkit [21165] by darin
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

  • fix <rdar://problem/5138250> REGRESSION (r18245): Changing any one aspect of a font applies all the aspects to selected text

Since this bug is only visible with the font panel, I don't
think there's any way to make a DumpRenderTree-driven test.

  • editing/Editor.cpp: (WebCore::Editor::fontForSelection): Set hasMultipleFonts properly. The old code had an early exit that was left over from when hasMultipleFonts was a pointer.

Apr 27, 2007:

11:57 PM Changeset in webkit [21164] by aroben
  • 2 edits in trunk/WebKitTools

Reviewed by Maciej.

Cleaned up prepare-ChangeLog

  • Scripts/prepare-ChangeLog: No code changes, but style now matches the prevalent style of our perl scripts.
11:48 PM Changeset in webkit [21163] by bdash
  • 5 edits in trunk/LayoutTests

2007-04-27 Mitz Pettel <​mitz@webkit.org>

Reviewed by Antti.

  • fast/css/percentage-non-integer-expected.checksum:
  • fast/css/percentage-non-integer-expected.png:
  • fast/css/percentage-non-integer-expected.txt:
  • fast/css/percentage-non-integer.html:
11:40 PM Changeset in webkit [21162] by bdash
  • 3 edits in trunk/WebCore

2007-04-27 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

No test possible as there is no change to functionality.

No test possible since text fields are no longer implemented as flexboxes.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::scheduleRelayout): Added a check that the subtree root is in the tree and not free-floating.
  • rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderCharacters): Changed addChild and removeChild to appendChildNode and removeChildNode to save some unnecessary overhead. These calls still mark the tree for relayout, but the change in scheduleRelayout ensures that a layout won't be scheduled.
10:04 PM Changeset in webkit [21161] by thatcher
  • 1 edit in trunk/WebKit/WebKit.xcodeproj/project.pbxproj

Add back in WebInspectorPanel.

9:54 PM Changeset in webkit [21160] by thatcher
  • 2 edits in trunk/WebKit

Revert some unintended changes and fix the build.

9:48 PM Changeset in webkit [21159] by thatcher
  • 8 edits
    2 deletes in trunk/WebKit

2007-04-27 Timothy Hatcher <​timothy@apple.com>

Reviewed by Darin.

There were only a couple calls to ResourceLoadDelegate forwarder left,
this removed the calls and added a new cached method for didFailLoad.

  • WebKit/DefaultDelegates/WebDefaultResourceLoadDelegate.h: Removed.
  • WebKit/DefaultDelegates/WebDefaultResourceLoadDelegate.m: Removed.
  • WebKit/Plugins/WebNullPluginView.mm: Call the resource load delegate directly.
  • WebKit/WebCoreSupport/WebFrameLoaderClient.mm: Call the cached didFailLoad delegate function.
  • WebKit/WebKit.xcodeproj/project.pbxproj: Remove WebDefaultResourceLoadDelegate.
  • WebKit/WebView/WebDataSource.mm: Remove the #import for WebDefaultResourceLoadDelegate.h
  • WebKit/WebView/WebView.mm: Remove the ResourceLoadDelegate forwarder, and remove a method that isn't used.
  • WebKit/WebView/WebViewInternal.h: Ditto.
  • WebKit/WebView/WebViewPrivate.h: Remove a method that is no longer used.
6:41 PM Changeset in webkit [21158] by pyeh
  • 2 edits in trunk/WebCore

<rdar://problem/5153017> REPRODUCIBLE ASSERT: range != nil in WebViewFactory.mm:415 -[WebViewFactory startOfTextMarkerRange:] (13354)

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject textMarkerRangeForRange:]): Fix the range length check. It was incorrectly assuming that the max range requested cannot be equal to the length of the string. Since NSRange location is index based, it's perfectly valid to have the max range equal to the the text length.
6:04 PM Changeset in webkit [21157] by harrison
  • 14 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5160627> Export JS list creation support as ObjC SPI for Mail

  • WebCore.exp:
  • editing/Editor.h:
  • editing/Editor.cpp: (WebCore::Editor::insertOrderedList): (WebCore::Editor::insertUnorderedList): (WebCore::Editor::canIncreaseSelectionListLevel): (WebCore::Editor::canDecreaseSelectionListLevel): (WebCore::Editor::increaseSelectionListLevel): (WebCore::Editor::increaseSelectionListLevelOrdered): (WebCore::Editor::increaseSelectionListLevelUnordered): (WebCore::Editor::decreaseSelectionListLevel): Add insertOrderedList() and insertUnorderedList(). Move existing list management functions from WebCoreFrameBridge. The level increasing functions now return a PassRefPtr<Node> instead of Node. Add check for canEditRichly.


  • in many other functions, condense the check for nil client().


  • editing/InsertListCommand.h:
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::insertList): (WebCore::InsertListCommand::fixOrphanedListChild): (WebCore::InsertListCommand::doApply): Add insertList(), which returns the new list element. Don't set the list element's ID if the specified ID was an empty string.


  • editing/ModifySelectionListLevel.h:
  • editing/ModifySelectionListLevel.cpp: (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelWithType): (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevel): (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelOrdered): (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelUnordered): Return PassRefPtr<Node> instead of Node.
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: Move list management functions to Editor.h and Editor.cpp.

WebKit:

Reviewed by Darin.

<rdar://problem/5160627> Export JS list creation support as ObjC SPI for Mail

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.mm: (-[WebHTMLView _selectedRange]): (-[WebHTMLView _shouldDeleteRange:]): (-[WebHTMLView _canEdit]): (-[WebHTMLView _canEditRichly]): (-[WebHTMLView _hasSelection]): (-[WebHTMLView _hasSelectionOrInsertionPoint]): (-[WebHTMLView _hasInsertionPoint]): (-[WebHTMLView _isEditable]): Condense the check for nil [self frame]. Remove canEditRichly checks and rely on the editor to do the check instead.


(-[WebHTMLView _insertOrderedList]):
(-[WebHTMLView _insertUnorderedList]):
New.


(-[WebHTMLView _canIncreaseSelectionListLevel]):
(-[WebHTMLView _canDecreaseSelectionListLevel]):
(-[WebHTMLView _increaseSelectionListLevel]):
(-[WebHTMLView _increaseSelectionListLevelOrdered]):
(-[WebHTMLView _increaseSelectionListLevelUnordered]):
(-[WebHTMLView _decreaseSelectionListLevel]):
Moved from bridge to frame editor.

  • WebView/WebHTMLViewPrivate.h: Add _insertOrderedList and _insertUnorderedList to WebHTMLView(WebPrivate)
5:48 PM Changeset in webkit [21156] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5134254>, toolbar buttons don't work in gmail after double-click. Make sure
to clear out the capturing frame, since you don't get a second up when a double-click happens.

Reviewed by mjs

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDoubleClickEvent):
2:59 PM Changeset in webkit [21155] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by oliver


<rdar://problem/5164796>
Enable execCommand("CreateLink", ...) for caret selections

  • editing/execCommand/5164796-expected.checksum: Added.
  • editing/execCommand/5164796-expected.png: Added.
  • editing/execCommand/5164796-expected.txt: Added.
  • editing/execCommand/5164796.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/5164796>
Enable execCommand("CreateLink", ...) for caret selections

  • editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply): For a caret selection, insert a link at the caret position with the url as the link text.
  • editing/JSEditor.cpp: Enable CreateLink for caret selections.
1:03 PM Changeset in webkit [21154] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

hongzhao <​hong.a.zhao@nokia.com>

Reviewed by Yongjun.
DESC: To add .lib for linking problems in 3.1m.
​http://bugs.webkit.org/show_bug.cgi?id=13523

12:58 PM Changeset in webkit [21153] by zbujtas
  • 2 edits in S60/trunk/WebCore

2007-04-27 w3liu <​wei.liu@nokia.com>

reviewed by Zalan <​zbujtas@gmail.com>
DESC: handle codebase in HTMLImageLoader
​http://bugs.webkit.org/show_bug.cgi?id=13491

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/html/html_imageimpl.cpp: (HTMLImageLoader::updateFromElement):
12:56 PM Changeset in webkit [21152] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2007-04-27 w3liu <​wei.liu@nokia.com>

reviewed by Zalan <​zbujtas@gmail.com>
DESC: handle codebase in HTMLImageLoader
​http://bugs.webkit.org/show_bug.cgi?id=13491

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/html/html_imageimpl.cpp: (HTMLImageLoader::updateFromElement):
12:48 PM Changeset in webkit [21151] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2007-04-27 w3liu <​wei.liu@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: NUPA-729B2V: WCSS dotted HORIZONTAL RULES not displaying at all
​http://bugs.webkit.org/show_bug.cgi?id=13524

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/rendering/render_object.cpp: (RenderObject::drawBorder):
12:23 PM Changeset in webkit [21150] by zbujtas
  • 9 edits in S60/trunk

rathnasa, reviewed by zbujtas

DESC: Widget Menu API
​http://bugs.webkit.org/show_bug.cgi?id=13494

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/ecma/kjs_window.cpp: (Window::get):
10:02 AM Changeset in webkit [21149] by beidson
  • 2 edits in trunk/WebKit

Rubberstamped by Mark

Remove default implementation of UIDelegate method that was removed

I have also been instructed to give Tim a hard time about this one - apparently
it was his job to clean it out and he failed... failed miserably.

:)

  • DefaultDelegates/WebDefaultUIDelegate.m: Removed webViewPrint:
7:55 AM Changeset in webkit [21148] by bdash
  • 2 edits in trunk/WebKitTools

2007-04-27 Nazar Kulyk <​schamane@myeburg.net>

Reviewed by Mark Rowe.

Basic auto-correction of user-entered URLs.

  • GdkLauncher/main.cpp: (autocorrectURL): (goToURLBarText): (main):
6:08 AM Changeset in webkit [21147] by antti
  • 1 edit
    1 add in trunk/LayoutTests

Forgot this png from previous commit.

  • fast/table/empty-cells-expected.png: Added.
5:36 AM Changeset in webkit [21146] by bdash
  • 2 edits in trunk/WebKitTools

2007-04-28 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Anders.

Rename some methods and variables to match the style guidelines.

  • GdkLauncher/main.cpp: (stringIsEmpty): (stringIsEqual): (goToURLBarText): (goButtonClickedCallback): (urlBarEnterCallback): (frameResizeCallback): (frameDestroyCallback): (menuMainBackCallback): (menuMainForwardCallback): (menuMainQuitCallback): (main):
4:32 AM Changeset in webkit [21145] by antti
  • 38 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin, Hyatt.


Test for ​http://bugs.webkit.org/show_bug.cgi?id=13081
Empty table cells not handled correctly
<rdar://problem/5067926>


Added test case and checked in updated results for others. Changes represent
progressions or are not visible in rendering output.

  • fast/block/positioning/negative-right-pos-expected.txt:
  • fast/css/acid2-expected.txt:
  • fast/css/acid2-pixel-expected.txt:
  • fast/css/percentage-non-integer-expected.checksum:
  • fast/css/percentage-non-integer-expected.png:
  • fast/css/percentage-non-integer-expected.txt:
  • fast/repaint/table-cell-move-expected.checksum:
  • fast/repaint/table-cell-move-expected.png:
  • fast/repaint/table-cell-move-expected.txt:
  • fast/table/012-expected.txt:
  • fast/table/032-expected.txt:
  • fast/table/empty-cells-expected.checksum: Added.
  • fast/table/empty-cells-expected.txt: Added.
  • fast/table/empty-cells.html: Added.
  • fast/table/empty-section-crash-expected.txt:
  • http/tests/misc/acid2-expected.txt:
  • http/tests/misc/acid2-pixel-expected.txt:
  • tables/mozilla/bugs/bug100334-expected.txt:
  • tables/mozilla/bugs/bug1188-expected.txt:
  • tables/mozilla/bugs/bug16012-expected.checksum:
  • tables/mozilla/bugs/bug16012-expected.png:
  • tables/mozilla/bugs/bug16012-expected.txt:
  • tables/mozilla/bugs/bug1818-6-expected.txt:
  • tables/mozilla/bugs/bug222336-expected.txt:
  • tables/mozilla/bugs/bug222467-expected.txt:
  • tables/mozilla/bugs/bug78162-expected.txt:
  • tables/mozilla/core/misc-expected.checksum:
  • tables/mozilla/core/misc-expected.png:
  • tables/mozilla/core/misc-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug14007-1-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
  • tables/mozilla_expected_failures/bugs/bug14007-1-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug72393-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug72393-expected.png:
  • tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
  • tables/mozilla_expected_failures/other/empty_cells-expected.txt:

WebCore:

Reviewed by Darin, Hyatt.


Fix ​http://bugs.webkit.org/show_bug.cgi?id=13081
Empty table cells not handled correctly
<rdar://problem/5067926>


To match Firefox and IE, empty table cells with variable width need to be
treated as special case. They generally get zero width.

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):
  • rendering/AutoTableLayout.h: (WebCore::AutoTableLayout::Layout::Layout):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::hasPadding):
4:20 AM Changeset in webkit [21144] by rwlbuis
  • 4 edits
    4 adds in trunk

Reviewed by Oliver.

​http://bugs.webkit.org/show_bug.cgi?id=13052
Text not rendered in a second inline SVG element

Correct the rendering of svg text when embedded in non-svg container.

1:43 AM Changeset in webkit [21143] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Mark.


<rdar://problem/5154113> Repro ASSERT (would be crash) in KJS::GCLock::GCLock (13462)
​http://bugs.webkit.org/show_bug.cgi?id=13462

  • WebInspector/WebInspector.m: (-[WebInspectorPrivate dealloc]): Delay release of WebView to avoid GC re-entrancy.
1:40 AM Changeset in webkit [21142] by bdash
  • 2 edits in trunk/WebCore

2007-04-27 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

  • WebCore.pro: Remove non-existent paths from qmake files.
1:10 AM Changeset in webkit [21141] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Mitz.

<rdar://problem/5165755>
View Source is broken; empty window is shown


Return YES for applewebdata URLs.


  • WebView/WebView.mm: (+[WebView _canHandleRequest:]):
12:52 AM Changeset in webkit [21140] by bdash
  • 5 edits in trunk/WebCore

2007-04-25 Lars Naesbye Christensen <​lars@naesbye.dk>

Reviewed by Timothy Hatcher.

​http://bugs.webkit.org/show_bug.cgi?id=13477
Bug 13477: Help and context menu cursors need dropshadows.

  • Resources/cellCursor.png:
  • Resources/contextMenuCursor.png:
  • Resources/helpCursor.png:
  • platform/mac/CursorMac.mm: (WebCore::contextMenuCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::noDropCursor):
12:44 AM Changeset in webkit [21139] by bdash
  • 1 edit
    3 copies
    2 adds
    1 delete in trunk/JavaScriptCore

2007-04-27 Christopher Brichford <​chrisb@adobe.com>

Reviewed by Timothy Hatcher.

Fix for: Bug 13211: Move JavaScriptCore mac project files for apollo port
​http://bugs.webkit.org/show_bug.cgi?id=13211

  • JavaScriptCore.apolloproj/mac/JavaScriptCore.Debug.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore.Release.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore.xcodeproj/project.pbxproj: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Debug.xcconfig: Removed.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Release.xcconfig: Removed.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig: Removed.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: Removed.
12:37 AM Changeset in webkit [21138] by bdash
  • 7 edits
    7 deletes in trunk

2007-04-27 Holger Freyther <​freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

  • CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <​freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

  • CMakeLists.txt: Removed.
  • pcre/CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <​freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

  • CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <​freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

  • QtLauncher/CMakeLists.txt: Removed.
  • WebKitPart/CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <​freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

  • DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Removed.
  • Scripts/build-webkit: Remove references to CMake.
  • Scripts/webkitdirs.pm: Remove references to CMake.

Apr 26, 2007:

11:03 PM Changeset in webkit [21137] by bdash
  • 4 edits in trunk

2007-04-27 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver.

  • JavaScriptCore.xcodeproj/project.pbxproj: Improve dependencies in Xcode project by marking dftables as a dependency of Generate Derived Sources rather than of JavaScriptCore itself.

2007-04-27 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver.

  • JavaScriptGlue.xcodeproj/project.pbxproj: Improve dependencies in Xcode project by marking JavaScriptGlue as a dependency of testjsglue.
10:48 PM Changeset in webkit [21136] by bdash
  • 2 edits in trunk/WebCore

2007-04-26 Matt Perry <​mpComplete@gmail.com>

Reviewed by Maciej.

Added a version check to hackAroundLibXMLEntityBug, since that bug has
been fixed in recent versions of libxml2.

  • dom/XMLTokenizer.cpp: (WebCore::hackAroundLibXMLEntityBug):
10:36 PM Changeset in webkit [21135] by bdash
  • 1 edit
    7 adds in trunk/WebCore

2007-04-26 Christopher Brichford <​chrisb@adobe.com>

Reviewed by Timothy Hatcher.

  • WebCore.apolloproj/mac/WebCore.Debug.xcconfig: Added.
  • WebCore.apolloproj/mac/WebCore.Release.xcconfig: Added.
  • WebCore.apolloproj/mac/WebCore.xcconfig: Added.
  • WebCore.apolloproj/mac/WebCore.xcodeproj/project.pbxproj: Added.
10:11 PM Changeset in webkit [21134] by bdash
  • 2 edits in trunk/WebCore

2007-04-26 Alp Toker <​alp@atoker.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=13505
Cast loses precision on x86_64

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): Use a stack of opacity values instead of Cairo user data.
10:09 PM Changeset in webkit [21133] by bdash
  • 2 edits in trunk/WebKitTools

2007-04-26 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

  • GdkLauncher/main.cpp: (main): Avoid use of deprecated API.
10:00 PM Changeset in webkit [21132] by bdash
  • 3 edits
    4 adds in trunk

2007-04-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/forms/listbox-scrollbar-incremental-load.html

The scroller position was not updated correctly during insertion, since
scrollbar proportions are updated only during layout

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::selectionChanged): Delay scrolling to reveal the selection until after layout if m_optionsChanged is set. Layout is guaranteed to happen soon when the flag is set.

2007-04-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/forms/listbox-scrollbar-incremental-load-expected.checksum: Added.
  • fast/forms/listbox-scrollbar-incremental-load-expected.png: Added.
  • fast/forms/listbox-scrollbar-incremental-load-expected.txt: Added.
  • fast/forms/listbox-scrollbar-incremental-load.html: Added.
6:41 PM Changeset in webkit [21131] by ggaren
  • 5 edits in trunk/JavaScriptCore

Build fix -- added #includes that we used to get implicitly through
JSStringRef.h.

  • API/JSNode.c:
  • API/JSNodeList.c:
  • API/minidom.c:
  • API/testapi.c:
6:15 PM Changeset in webkit [21130] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak, Adam Roben.


Fixed
<rdar://problem/4885130> Remove #include of JSStringRefCF.h from JSStringRef.h
<rdar://problem/4885123> JavaScriptCore is not cross-platform -- JSStringRef.h references CF datatypes

  • API/JSStringRef.h: Removed #include -- no clients need it anymore.
5:36 PM Changeset in webkit [21129] by hyatt
  • 1 edit in trunk/LayoutTests/fast/dom/Range/surroundContents-1-expected.txt

Fix layout test results jnow that we no longer make empty render texts.

5:35 PM Changeset in webkit [21128] by hyatt
  • 1 edit in trunk/LayoutTests/fast/dom/delete-contents-expected.txt

Fix layout test results jnow that we no longer make empty render texts.

5:34 PM Changeset in webkit [21127] by hyatt
  • 3 edits in trunk/LayoutTests/editing/execCommand

Fix layout test results jnow that we no longer make empty render texts.

5:33 PM Changeset in webkit [21126] by hyatt
  • 3 edits in trunk/LayoutTests/editing/deleting

Fix layout test results jnow that we no longer make empty render texts.

5:30 PM Changeset in webkit [21125] by hyatt
  • 4 edits in trunk/WebCore

Fix for 13511, crash on a counters page. Make sure that RenderTexts
never get a null StringImpl. I would have added an assert that the length
had to be nonzero also, but unfortunately editing creates empty RenderTexts
because of its EditingText DOM subclass that always forces renderers to be
made. I suppose there is a good reason for this...

Reviewed by aroben

  • dom/CharacterData.cpp: (WebCore::CharacterData::setData): (WebCore::CharacterData::appendData): (WebCore::CharacterData::insertData): (WebCore::CharacterData::deleteData): (WebCore::CharacterData::replaceData):
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::RenderCounter):
  • rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::trimmedPrefWidths): (WebCore::RenderText::setTextWithOffset): (WebCore::RenderText::setTextInternal): (WebCore::RenderText::setText):
4:21 PM Changeset in webkit [21124] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

  • editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): adding null check
2:53 PM Changeset in webkit [21123] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by oliver


<rdar://problem/5120591> Crash when creating a link in Leopard wiki server

  • editing/execCommand/5120591-expected.checksum: Added.
  • editing/execCommand/5120591-expected.png: Added.
  • editing/execCommand/5120591-expected.txt: Added.
  • editing/execCommand/5120591.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/5120591>
Crash when creating a link in Leopard wiki server

  • editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply): Use a RefPtr, setting the anchor's href can destroy it if there is an ancestor with a subtree modified event listener.
2:15 PM Changeset in webkit [21122] by ddkilzer
  • 2 edits in trunk/JavaScriptCore

2007-04-25 David Kilzer <​ddkilzer@apple.com>

Reviewed by Maciej.

Add assertions for debug builds.

  • kjs/JSLock.cpp: (KJS::JSLock::lock): Assert the return value of pthread_mutex_lock() in debug builds. (KJS::JSLock::unlock): Assert the return value of pthread_mutex_unlock() in debug builds.
1:37 PM Changeset in webkit [21121] by kmccullo
  • 2 edits in trunk/WebKitTools
  • Changed debugging statements for more information.
  • Scripts/run-webkit-tests:
12:51 PM Changeset in webkit [21120] by hyatt
  • 7 edits in trunk/WebCore

Reviewed by hyatt

No tests added since there is no change to functionality. Several
tests in fast/repaint test repainting of objects that move during layout.

  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Removed an early setNeedsLayout(false). Resetting the bit here prevents the full repaint that we rely on when we decide not to repaint children that move.
  • rendering/RenderBlock.h:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setCellWidths): Replaced the call to repaintObjectsBeforeLayout() if the cell didn't need layout with an unconditional repaint(). We don't bother with repainting only the delta between the old and new widths, since by marking the cell for layout results in a full repaint with the new width anyway.
12:24 PM Changeset in webkit [21119] by hyatt
  • 2 edits in trunk/WebCore

Fix for 13509. Don't recur to parent inline flows if they have been
marked as needing layout themselves.

Reviewed by adele

  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::dirtyLinesFromChangedChild):
12:21 PM Changeset in webkit [21118] by ap
  • 3 edits
    3 adds in trunk

2007-04-26 Matt Perry <​mpComplete@gmail.com>

Reviewed and landed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=13495
Crash when referencing an undefined entity in an XHTML document

Test: fast/parser/badentity.xhtml

  • dom/XMLTokenizer.cpp: (WebCore::getEntityHandler): Check for a NULL returned from getXHTMLEntity
11:37 AM Changeset in webkit [21117] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

<rdar://problem/4851944>
REGRESSION: With TOT, BMP images can no longer be opened in the browser window


On Tiger, the MIME type for the com.microsoft.bmp UTI isn't in the registry, so add it manually.


  • platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):
11:30 AM Changeset in webkit [21116] by hyatt
  • 4 edits in trunk/WebCore

Fix for bug 13503, invalidateContainingBlockPrefWidths is 15% of the
nesting PLT. Avoid O(n2) behavior by including inlines in the minmax
dirty chain.

Reviewed by kevin

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setPrefWidthsDirty): (WebCore::RenderObject::invalidateContainerPrefWidths):
  • rendering/RenderObject.h:
11:11 AM Changeset in webkit [21115] by kmccullo
  • 2 edits in trunk/WebKitTools
  • Adding debugging statements to see why these tests fail. These will be removed.
  • Scripts/run-webkit-tests:
10:37 AM Changeset in webkit [21114] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5067925>
Reproducible crash (infinite recursion) with a layout test that submits on unload (13078)


Ask the document loader whether it's loading the main resource, since there are cases where the frame
loader's variable isn't updated correctly.


In the distant future, the frame loader shouldn't have an instance variable but this is the least intrusive fix for now.


I couldn't come up with a good test case for this since it requires running three tests in a row and scheduleLoad didn't work. Also,
calling submit in the onunload prevents any new tests from loading!


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::isLoading):
8:52 AM BuildingGdk edited by alp@atoker.com
(diff)
5:48 AM Changeset in webkit [21113] by zbujtas
  • 2 edits in S60/trunk/WebKit

yadavall, reviewed by <​zbujtas@gmail.com>

DESC: Fix build break
​http://bugs.webkit.org/show_bug.cgi?id=13497


  • group/EABI/browserengineU.def:
3:10 AM Changeset in webkit [21112] by bdash
  • 5 edits in tags/WebKit-419.1/WebKit

Merge r10259 and r15845.

2:41 AM Changeset in webkit [21111] by bdash
  • 3 edits in tags/WebKit-419.1/WebKit

Merge r20042 and follow-ups from r20050, r20058, r20064, r20077 and r20668.

2:20 AM Changeset in webkit [21110] by oliver
  • 2 edits in trunk/WebKit

2007-04-26 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fix <rdar://problem/5061252> REGRESSION: In Gmail, image fails
to be inserted into message field after dragging

Don't try to create <img> tags for local image files as it results
in the potential to submit forms that look like they have an image,
when in reality they don't.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentWithPaths:]):
2:19 AM Changeset in webkit [21109] by bdash
  • 1 copy in tags/WebKit-419.1

New tag.

12:09 AM Changeset in webkit [21108] by andersca
  • 2 edits in trunk/WebCore

... and fix the build.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueAfterNavigationPolicy):
12:06 AM Changeset in webkit [21107] by andersca
  • 2 edits in trunk/WebCore

Revert the previous change - activeDocumentLoader never returns the policy document loader.
Instead, add a null check for the policy document loader.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueAfterNavigationPolicy):
12:02 AM Changeset in webkit [21106] by andersca
  • 2 edits in trunk/WebCore

Use the active document loader instead of the policy document loader.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueAfterNavigationPolicy):

Apr 25, 2007:

11:46 PM Changeset in webkit [21105] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Anders.


  • fix build problems
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable warning that gives often downright incorrect results based on guessing what will happen in 64-bit.
11:37 PM Changeset in webkit [21104] by andersca
  • 4 edits in trunk

WebCore:

Reviewed by Maciej.

<rdar://problem/5049099> documents no longer have a default base URL

Don't call canHandleRequest if we have valid substitute data and the protocol is "applewebdata".


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueAfterNavigationPolicy):

WebKit:

Reviewed by Maciej.

<rdar://problem/5049099> documents no longer have a default base URL


If the base URL is nil, then create a unique applewebdata URL to match what Tiger WebKit does.


  • WebView/WebFrame.mm: (createUniqueWebDataURL): (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
7:10 PM Changeset in webkit [21103] by slewis
  • 2 edits in trunk/WebCore

Fix the build for platforms which overload the abs function

5:26 PM Changeset in webkit [21102] by oliver
  • 2 edits in trunk/WebKit

2007-04-25 Oliver Hunt <​oliver@apple.com>

Rubber stamped by Adele.

Roll out WebKit changes from from r21052 to fix regression noted in
<rdar://problem/5159556> REGRESSION: In Mail, pressing option-command- ' doesn't decrease block quote in selection

  • WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): (-[WebHTMLView doCommandBySelector:]):
5:24 PM Changeset in webkit [21101] by zbujtas
  • 18 edits in S60/trunk

rathnasa, reviewed by zbujtas

DESC: widet menu api implementation
​http://bugs.webkit.org/show_bug.cgi?id=13494

4:39 PM Changeset in webkit [23334] by sfalken
  • 5 edits in branches/WindowsMerge

Build fix

4:23 PM BuildingOnWindows edited by pkasting@google.com
(diff)
3:04 PM Changeset in webkit [21100] by hyatt
  • 4 adds in trunk/LayoutTests/fast/block/float

Add another test case that is fixed by the new lazy minmax width code.

2:46 PM Changeset in webkit [21099] by hyatt
  • 3 edits in trunk/WebCore

Fix for bug 13373, make sure to invalidate the pref widths for objects
with percentage padding.

Reviewed by beth

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::layoutPositionedObjects):
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
2:44 PM Changeset in webkit [21098] by hyatt
  • 4 adds in trunk/LayoutTests/fast/block/positioning

Add padding percent test.

2:36 PM Changeset in webkit [21097] by harrison
  • 2 edits in trunk/WebCore

Comment change. Correct the header name in the endif comment.


  • editing/FormatBlockCommand.h: Change InsertListCommand_h to FormatBlockCommand_h.
1:25 PM Changeset in webkit [21096] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

  • tweak the allocator for a small speedup -- Shark showed this was a win, but I can't measure an improvement right now, but it's also clear these changes do no harm
  • wtf/FastMalloc.cpp: (WTF::LgFloor): Use ALWAYS_INLINE here; in testing I did a while back this was necessary to get this single-instruction function to be inlined. (WTF::SizeClass): Use ALWAYS_INLINE here too for the same reason. Also change the special case for a size of 0 to work without a branch for a bit of extra speed. (WTF::ByteSizeForClass): Use ALWAYS_INLINE here too for the same reason.
1:02 PM Changeset in webkit [21095] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • platform/AtomicString.cpp: (WebCore::AtomicString::add): Removed unnecessary use of strlen to check if a string is empty.
12:59 PM Changeset in webkit [21094] by ddkilzer
  • 2 edits in trunk/WebCore

2007-04-25 Mitz Pettel <​mitz@webkit.org>

Build fix.

  • rendering/RenderListMarker.h: Undeleted the m_text member.
12:24 PM GtkAPIProposal edited by Kimmo Kinnunen
(diff)
12:10 PM Changeset in webkit [21093] by hyatt
  • 40 edits in trunk/WebCore

Rearchitect calcPrefWidths. The calculation is now done lazily only when minPrefWidth
or maxPrefWidth are asked for. The result of the calculation is cached.

The new invalidation scheme for pref width invalidation follows the
containing block hierarchy and knows to halt at positioned objects, since
they cannot influence the size of their containers.

Reviewed by darin

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::initForStyleResolve):
  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::layout):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::makeChildrenNonInline): (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::layout): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::calcPrefWidths): (WebCore::InlineMinMaxIterator::endOfInline): (WebCore::shouldGrowTableCellForImage): (WebCore::RenderBlock::calcInlinePrefWidths): (WebCore::RenderBlock::calcBlockPrefWidths):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::minPrefWidth): (WebCore::RenderBox::maxPrefWidth): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues):
  • rendering/RenderBox.h:
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode): (WebCore::RenderContainer::layout):
  • rendering/RenderContainer.h: (WebCore::RenderContainer::moveChildNode):
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::dirtyLineBoxes): (WebCore::RenderCounter::calcPrefWidths):
  • rendering/RenderCounter.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::calcPrefWidths):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths): (WebCore::RenderFlexibleBox::calcVerticalPrefWidths): (WebCore::RenderFlexibleBox::calcPrefWidths): (WebCore::RenderFlexibleBox::layoutBlock):
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::layout):
  • rendering/RenderInline.cpp:
  • rendering/RenderInline.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::calcPrefWidths):
  • rendering/RenderListItem.cpp: (WebCore::firstNonMarkerChild): (WebCore::RenderListItem::updateMarkerLocation): (WebCore::RenderListItem::calcPrefWidths): (WebCore::RenderListItem::layout):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::layout): (WebCore::RenderListMarker::calcPrefWidths): (WebCore::RenderListMarker::updateMargins):
  • rendering/RenderListMarker.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::removeChildNode): (WebCore::RenderObject::moveChildNode): (WebCore::RenderObject::appendChildNode): (WebCore::RenderObject::insertChildNode): (WebCore::RenderObject::setPrefWidthsDirty): (WebCore::RenderObject::invalidateContainingBlockPrefWidths): (WebCore::RenderObject::information): (WebCore::RenderObject::setStyle):
  • rendering/RenderObject.h: (WebCore::RenderObject::layer): (WebCore::RenderObject::hasLayer): (WebCore::RenderObject::prefWidthsDirty): (WebCore::RenderObject::setNeedsLayoutAndPrefWidthsRecalc): (WebCore::RenderObject::setHasLayer):
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::layout):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGHiddenContainer.cpp:
  • rendering/RenderSVGHiddenContainer.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout): (WebCore::RenderTable::removeChildNode):
  • rendering/RenderTable.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::removeChildNode):
  • rendering/RenderTableSection.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::trimmedPrefWidths): (WebCore::isSpaceAccordingToStyle): (WebCore::RenderText::minPrefWidth): (WebCore::RenderText::maxPrefWidth): (WebCore::RenderText::calcPrefWidths): (WebCore::RenderText::width):
  • rendering/RenderText.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::RenderView): (WebCore::RenderView::calcPrefWidths): (WebCore::RenderView::layout):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::layout):
12:01 PM Changeset in webkit [21092] by sfalken
  • 10 edits in trunk

2007-04-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Mac callbacks for new spelling methods in WebEditorClient.
Not used yet.

  • WebCoreSupport/WebEditorClient.h: (WebEditorClient::ignoreWordInSpellDocument): (WebEditorClient::learnWord): (WebEditorClient::checkSpellingOfString): (WebEditorClient::checkGrammarOfString): (WebEditorClient::updateSpellingUIWithGrammarString): (WebEditorClient::updateSpellingUIWithMisspelledWord): (WebEditorClient::showSpellingUI): (WebEditorClient::spellingUIIsShowing): (WebEditorClient::getGuessesForWord):

2007-04-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Fix spelling error in spelling method name.
Expose new spelling callback methods to all platforms.

  • bridge/EditorClient.h:
  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::updateSpellingUIWithGrammarString):
  • platform/gdk/EditorClientGdk.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::updateSpellingUIWithGrammarString): (WebCore::SVGEmptyEditorClient::getGuessesForWord):

2007-04-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.


Fix spelling error in spelling method name.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::updateSpellingUIWithGrammarString):
  • WebCoreSupport/EditorClientQt.h:
11:42 AM Changeset in webkit [21091] by ggaren
  • 10 edits in trunk

WebCore:

Reviewed by Darin Adler, Tim Hatcher.

Fixed a few NSAutoreleasePool issues I noticed while reviewing Brady's patch.

  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::setCompositeOperation): Call -drain instead of -release, since -release is a no-op in a GC world.

WebKit:

Reviewed by Darin Adler, Tim Hatcher.

Fixed a few NSAutoreleasePool issues I noticed while reviewing Brady's patch.

  • Carbon/CarbonUtils.m: (PoolCleaner): Call -drain instead of -release, since -release is a no-op in a GC world.
  • Misc/WebKitErrors.m: (registerErrors): Condensed onto one line.
  • Plugins/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): Call -drain instead of -release, since -release is a no-op in a GC world.
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::setStatusbarText):
  • WebInspector/WebNodeHighlightView.m: (-[WebNodeHighlightView initWithHighlight:andRects:forView:]): Don't drain and then release because drain deallocates the receiver, so the release is an over-release.
  • WebView/WebView.mm: (-[WebView rectsForTextMatches]): Re-allocate the pool after draining it, because drain deallocates the receiver, so the drain would leave you without any autorelease pool, causing a leak and then an over-release at the bottom of the loop.
11:21 AM Changeset in webkit [21090] by ap
  • 3 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13445
NodeList access by index is slow

  • dom/ChildNodeList.cpp: (WebCore::ChildNodeList::item): Support iterating backwards from the last accessed node or from the last child.
  • dom/NodeList.h: Make cachedLength unsigned.
11:10 AM BuildingOnWindows edited by pkasting@google.com
(diff)
10:34 AM Changeset in webkit [21089] by bdash
  • 1 edit in trunk/WebCore/platform/gdk/TemporaryLinkStubs.cpp

Don't try and return a value from a stub function with return type of void.

10:32 AM Changeset in webkit [21088] by bdash
  • 2 edits in trunk/WebCore

2007-04-26 Mark Rowe <​mrowe@apple.com>

Gdk build fix. Add missing stub.

  • platform/gdk/TemporaryLinkStubs.cpp: (Editor::advanceToNextMisspelling):
10:21 AM Changeset in webkit [21087] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12163
SVG text does not appear in a scrolling <div>

Make sure SVG text is painted when scrolling by taking into account the

relative offset of the non-SVG parent in the paintInfo rect.

10:08 AM Changeset in webkit [21086] by bdash
  • 5 edits in trunk/WebCore

2007-04-26 Mark Rowe <​mrowe@apple.com>

Fix non-Mac builds after r21081.

Stub out new Editor methods for Qt and Gdk, and new SVGEmptyEditorClient methods
for all non-Mac builds.

  • editing/qt/EditorQt.cpp: (WebCore::Editor::showSpellingGuessPanel): (WebCore::Editor::spellingPanelIsShowing):
  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::passMousePressEventToScrollbar):
  • platform/gdk/TemporaryLinkStubs.cpp: (Editor::showSpellingGuessPanel): (Editor::spellingPanelIsShowing):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::ignoreWordInSpellDocument): (WebCore::SVGEmptyEditorClient::learnWord): (WebCore::SVGEmptyEditorClient::checkSpellingOfString): (WebCore::SVGEmptyEditorClient::checkGrammarOfString): (WebCore::SVGEmptyEditorClient::udpateSpellingUIWithGrammarString): (WebCore::SVGEmptyEditorClient::updateSpellingUIWithMisspelledWord): (WebCore::SVGEmptyEditorClient::showSpellingUI): (WebCore::SVGEmptyEditorClient::spellingUIIsShowing): (WebCore::SVGEmptyEditorClient::getGuessesForWord):
9:35 AM Changeset in webkit [21085] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Ada.

<rdar://problem/5122153>
Crash occurs at WebCore::Frame::loader() when switching to Bookmarks view while loading standalone image

Don't call writeRawData if the data length is 0. (This is checked by the decoder for the non-raw case).

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::write):
6:57 AM Changeset in webkit [21084] by bdash
  • 2 edits in trunk/WebCore

2007-04-26 Mark Rowe <​mrowe@apple.com>

Gdk build fix courtesy of Alp Toker.

  • make-generated-sources.sh: Remove conditional logic to ensure the script exits with the correct exit code.
5:28 AM BuildingGdk edited by alp@atoker.com
List of build dependencies (diff)
12:47 AM Changeset in webkit [21083] by andersca
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Mitz.

<rdar://problem/4869095>
default content type for XMLHttpRequest POSTs changed (breaks Flickrator 0.1 widget)

  • http/tests/xmlhttprequest/default-content-type-dashboard-expected.txt: Added.
  • http/tests/xmlhttprequest/default-content-type-dashboard.html: Added.

WebCore:

Reviewed by Mitz.

<rdar://problem/4869095>
default content type for XMLHttpRequest POSTs changed (breaks Flickrator 0.1 widget)


Use the right MIME type.


  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):

WebKitTools:

Reviewed by Mitz.

Add a setUseDashboardCompatibilityMode method to LayoutTestController which is used to toggle
the dashboard compatibility mode.


  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setUseDashboardCompatibilityMode:]): (runTest):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Apr 24, 2007:

11:49 PM Changeset in webkit [21082] by darin
  • 20 edits in trunk/WebCore

Reviewed by Maciej.

These are small changes that are either safe to do first, or unrelated to the main
change in Hyatt's patch.

  • Preallocate 4 entries each in m_layoutStruct and m_spanCells to save allocation in AutoTableLayout.
  • Add an early exit to RenderFlow::dirtyLinesFromChangedChild.
  • Change InlineBox::hasTextChildren() to use a bit directly and never a virtual function.
  • Save a virtual function call by using a local bool variable for isTableCell().
  • Fix containingBlock() so it returns 0 for table cells with no parent.
  • Change all callers who are getting at layer() as a boolean to use hasLayer().
  • Change if statements to max() function calls (only the ones Hyatt had in his patch).
  • Remove some old kdDebug calls.
  • Tweak formatting of some code.
  • Add const in one place.
  • bindings/js/kjs_html.cpp: (KJS::HTMLElementFunction::callAsFunction):
  • page/EventHandler.cpp: (WebCore::EventHandler::eventMayStartDrag):
  • page/Frame.cpp: (WebCore::Frame::clearTimers):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn):
  • rendering/AutoTableLayout.h:
  • rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::hasTextChildren):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint):
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::InlineFlowBox):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::repaintOverhangingFloats): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::fillBlockSelectionGaps): (WebCore::RenderBlock::insertFloatingObject): (WebCore::RenderBlock::floatRect): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::addOverhangingFloats): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestContents): (WebCore::RenderBlock::calcPrefWidths): (WebCore::InlineMinMaxIterator::next): (WebCore::getBorderPaddingMargin): (WebCore::RenderBlock::calcInlinePrefWidths): (WebCore::RenderBlock::calcBlockPrefWidths):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths): (WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::dirtyLinesFromChangedChild):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateVisibilityStatus): (WebCore::RenderLayer::updateLayerPosition):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint): (WebCore::RenderTableRow::paint):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint):
  • rendering/RenderTreeAsText.cpp: (WebCore::write):
9:35 PM Changeset in webkit [23333] by sfalken
  • 18 edits in branches/WindowsMerge

2007-04-24 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin, Oliver.


Checkpoint:
<rdar://problem/4602372> Spelling
<rdar://problem/4769763> Spell checking engine support

  • WebEditorClient.cpp: (WebEditorClient::isContinuousSpellCheckingEnabled): (WebEditorClient::toggleContinuousSpellChecking): (WebEditorClient::isGrammarCheckingEnabled): (WebEditorClient::toggleGrammarChecking): (initViewSpecificSpelling): (WebEditorClient::spellCheckerDocumentTag): (WebEditorClient::ignoreWordInSpellDocument): (WebEditorClient::learnWord): (WebEditorClient::checkSpellingOfString): (WebEditorClient::checkGrammarOfString): (WebEditorClient::udpateSpellingUIWithGrammarString): (WebEditorClient::updateSpellingUIWithMisspelledWord): (WebEditorClient::showSpellingUI): (WebEditorClient::spellingUIIsShowing): (WebEditorClient::getGuessesForWord):
  • WebPreferences.h:

2007-04-24 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin, Oliver.

Checkpoint:
<rdar://problem/4602372> Spelling
<rdar://problem/4769763> Spell checking engine support


Ported code from EditorMac.mm into EditorWin.cpp.
Once this works, I'll move this code into Editor.cpp and remove it
form EditorMac.mm.

  • platform/win/EditorWin.cpp: (WebCore::Editor::ignoreSpelling): (WebCore::Editor::learnSpelling): (WebCore::findFirstMisspellingInRange): (WebCore::paragraphAlignedRangeForRange): (WebCore::findFirstGrammarDetailInRange): (WebCore::findFirstBadGrammarInRange): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::isSelectionMisspelled): (WebCore::isRangeUngrammatical): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::guessesForMisspelledSelection): (WebCore::Editor::showSpellingGuessPanel): (WebCore::Editor::spellingPanelIsShowing): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::markAllMisspellingsInRange): (WebCore::markAllBadGrammarInRange): (WebCore::markMisspellingsOrBadGrammar): (WebCore::Editor::markMisspellings): (WebCore::Editor::markBadGrammar):
  • platform/win/TemporaryLinkStubs.cpp:

2007-04-24 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin, Oliver.

Add spelling related delegate methods to EditingDelegate.
They are all unimplemented. Necesarry to match the new interfaces.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: (EditingDelegate::ignoreWordInSpellDocument): (EditingDelegate::learnWord): (EditingDelegate::checkSpellingOfString): (EditingDelegate::checkGrammarOfString): (EditingDelegate::udpateSpellingUIWithGrammarString): (EditingDelegate::updateSpellingUIWithMisspelledWord): (EditingDelegate::showSpellingUI): (EditingDelegate::spellingUIIsShowing): (EditingDelegate::guessesForWord): (EditingDelegate::closeSpellDocument): (EditingDelegate::sharedSpellCheckerExists): (EditingDelegate::preflightChosenSpellServer): (EditingDelegate::updateGrammar):
9:22 PM Changeset in webkit [21081] by sfalken
  • 9 edits in trunk

2007-04-24 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin, Oliver.

Refactor spelling codepaths

  • bridge/EditorClient.h:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::ignoreWordInSpellDocument): (WebCore::EditorClientGdk::learnWord): (WebCore::EditorClientGdk::checkSpellingOfString): (WebCore::EditorClientGdk::checkGrammarOfString): (WebCore::EditorClientGdk::udpateSpellingUIWithGrammarString): (WebCore::EditorClientGdk::updateSpellingUIWithMisspelledWord): (WebCore::EditorClientGdk::showSpellingUI): (WebCore::EditorClientGdk::spellingUIIsShowing): (WebCore::EditorClientGdk::getGuessesForWord):
  • platform/gdk/EditorClientGdk.h:

2007-04-24 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Oliver.


Spelling and grammar stubs

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::ignoreWordInSpellDocument): (WebCore::EditorClientQt::learnWord): (WebCore::EditorClientQt::checkSpellingOfString): (WebCore::EditorClientQt::checkGrammarOfString): (WebCore::EditorClientQt::udpateSpellingUIWithGrammarString): (WebCore::EditorClientQt::updateSpellingUIWithMisspelledWord): (WebCore::EditorClientQt::showSpellingUI): (WebCore::EditorClientQt::spellingUIIsShowing): (WebCore::EditorClientQt::getGuessesForWord):
  • WebCoreSupport/EditorClientQt.h:
7:11 PM Changeset in webkit [21080] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Oliver.


  • use custom calling convention for everything in nodes.cpp on intel gcc for 1.5% speed boost

Nearly all functions in nodes.cpp were marked up to use the
regparm(3) calling convention under GCC for x86, since this is
faster and they are all guaranteed to be called only internally to
kjs.


The only exception is destructors, since delete doesn't know how to use a custom calling convention.


  • kjs/nodes.cpp: (dotExprDoesNotAllowCallsString):
  • kjs/nodes.h: (KJS::Node::): (KJS::StatementNode::): (KJS::NullNode::): (KJS::BooleanNode::): (KJS::NumberNode::): (KJS::StringNode::): (KJS::RegExpNode::): (KJS::ThisNode::): (KJS::ResolveNode::): (KJS::GroupNode::): (KJS::ElementNode::): (KJS::ArrayNode::): (KJS::PropertyNameNode::): (KJS::PropertyNode::): (KJS::PropertyListNode::): (KJS::ObjectLiteralNode::): (KJS::BracketAccessorNode::): (KJS::DotAccessorNode::): (KJS::ArgumentListNode::): (KJS::ArgumentsNode::): (KJS::NewExprNode::): (KJS::FunctionCallValueNode::): (KJS::FunctionCallResolveNode::): (KJS::FunctionCallBracketNode::): (KJS::FunctionCallParenBracketNode::): (KJS::FunctionCallDotNode::): (KJS::FunctionCallParenDotNode::): (KJS::PostfixResolveNode::): (KJS::PostfixBracketNode::): (KJS::PostfixDotNode::): (KJS::PostfixErrorNode::): (KJS::DeleteResolveNode::): (KJS::DeleteBracketNode::): (KJS::DeleteDotNode::): (KJS::DeleteValueNode::): (KJS::VoidNode::): (KJS::TypeOfResolveNode::): (KJS::TypeOfValueNode::): (KJS::PrefixResolveNode::): (KJS::PrefixBracketNode::): (KJS::PrefixDotNode::): (KJS::PrefixErrorNode::): (KJS::UnaryPlusNode::): (KJS::NegateNode::): (KJS::BitwiseNotNode::): (KJS::LogicalNotNode::): (KJS::MultNode::): (KJS::AddNode::): (KJS::ShiftNode::): (KJS::RelationalNode::): (KJS::EqualNode::): (KJS::BitOperNode::): (KJS::BinaryLogicalNode::): (KJS::ConditionalNode::): (KJS::AssignResolveNode::): (KJS::AssignBracketNode::): (KJS::AssignDotNode::): (KJS::AssignErrorNode::): (KJS::CommaNode::): (KJS::AssignExprNode::): (KJS::VarDeclListNode::): (KJS::VarStatementNode::): (KJS::EmptyStatementNode::): (KJS::ExprStatementNode::): (KJS::IfNode::): (KJS::DoWhileNode::): (KJS::WhileNode::): (KJS::ForNode::): (KJS::ContinueNode::): (KJS::BreakNode::): (KJS::ReturnNode::): (KJS::WithNode::): (KJS::LabelNode::): (KJS::ThrowNode::): (KJS::TryNode::): (KJS::ParameterNode::): (KJS::Parameter::): (KJS::FunctionBodyNode::): (KJS::FuncExprNode::): (KJS::FuncDeclNode::): (KJS::SourceElementsNode::): (KJS::CaseClauseNode::): (KJS::ClauseListNode::): (KJS::SwitchNode::):
6:14 PM Changeset in webkit [21079] by darin
  • 71 edits in trunk/WebCore

Reviewed by Adele.

This patch limits itself to renaming and making other super-simple
changes so that the above change will be smaller and easier to review
and understand.

Rename:

calcHorizontalMinMaxWidth -> calcHorizontalPrefWidths
calcMinMaxWidth -> calcPrefWidths
calcMinMaxWidthInternal -> calcPrefWidthsInternal
calcVerticalMinMaxWidth -> calcVerticalPrefWidths
setNeedsLayoutAndMinMaxRecalc -> setNeedsLayoutAndPrefWidthsRecalc
trimmedMinMaxWidth -> trimmedPrefWidths

RenderObject::m_maxWidth -> RenderObject::m_maxPrefWidth
RenderObject::m_minWidth -> RenderObject::m_minPrefWidth
RenderObject::maxWidth() -> RenderObject::maxPrefWidth()
RenderObject::minWidth() -> RenderObject::minPrefWidth()

Replace m_minMaxKnown, minMaxKnown(), and setMinMaxKnown() with
m_prefWidthsDirty, prefWidthsDirty(), and setPrefWidthsDirty(),
a boolean with the opposite sense.

Convert some uses of if statements into "max".

Change many uses of layer() to hasLayer(). For now it's just a boolean
version of layer(), but Hyatt's patch makes it faster by using a bit.

Added a guard to use of axObjectCache() to make RenderObject destruction
a little faster for the normal case.

Removed some assertions that will be removed in Hyatt's patch.

Made some functions const that will be const in Hyatt's patch.

Put in some revised comments from Hyatt's patch.

Removed an unneeded nil check from RenderListMarker::setStyle.

Moved RootInlineBox::setHorizontalOverflowPositions and
RootInlineBox::setVerticalSelectionPositions to the RootInlineBox.h
header and marked them inline.

  • dom/Document.cpp: (WebCore::Document::updateStyleSelector):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
  • page/Frame.cpp: (WebCore::Frame::forceLayoutWithPageWidthRange):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcPrefWidths): (WebCore::AutoTableLayout::calcEffectiveWidth):
  • rendering/AutoTableLayout.h:
  • rendering/CounterNode.cpp: (WebCore::CounterNode::recount):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcPrefWidths):
  • rendering/FixedTableLayout.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint):
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::layout):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::handleCompactChild): (WebCore::RenderBlock::getClearDelta): (WebCore::RenderBlock::calcPrefWidths): (WebCore::RenderBlock::calcInlinePrefWidths): (WebCore::RenderBlock::calcBlockPrefWidths):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): (WebCore::RenderBox::nodeAtPoint): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues):
  • rendering/RenderBox.h: (WebCore::RenderBox::minPrefWidth): (WebCore::RenderBox::maxPrefWidth):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode): (WebCore::RenderContainer::layout):
  • rendering/RenderContainer.h: (WebCore::RenderContainer::calcPrefWidths):
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::calcPrefWidths):
  • rendering/RenderCounter.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::calcPrefWidths):
  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::calcPrefWidths):
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths): (WebCore::RenderFlexibleBox::calcVerticalPrefWidths): (WebCore::RenderFlexibleBox::calcPrefWidths): (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::allowedChildFlex):
  • rendering/RenderFlexibleBox.h: (WebCore::RenderFlexibleBox::hasMultipleLines): (WebCore::RenderFlexibleBox::isVertical): (WebCore::RenderFlexibleBox::isHorizontal):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect):
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::layout): (WebCore::RenderImage::calcPrefWidths):
  • rendering/RenderImage.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::addChildToFlow): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::calcPrefWidths):
  • rendering/RenderInline.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::calcPrefWidths):
  • rendering/RenderListBox.h:
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::updateValue): (WebCore::RenderListItem::updateMarkerLocation): (WebCore::RenderListItem::calcPrefWidths): (WebCore::RenderListItem::layout): (WebCore::RenderListItem::explicitValueChanged):
  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::setStyle): (WebCore::RenderListMarker::layout): (WebCore::RenderListMarker::imageChanged): (WebCore::RenderListMarker::calcPrefWidths): (WebCore::RenderListMarker::calcWidth):
  • rendering/RenderListMarker.h:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateOptionsWidth): (WebCore::RenderMenuList::calcPrefWidths):
  • rendering/RenderMenuList.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::addLayers): (WebCore::RenderObject::removeLayers): (WebCore::RenderObject::moveLayers): (WebCore::RenderObject::addAbsoluteRectForLayer): (WebCore::RenderObject::checkForRepaintDuringLayout): (WebCore::RenderObject::dump): (WebCore::RenderObject::setStyle): (WebCore::RenderObject::destroy): (WebCore::RenderObject::recalcMinMaxWidths):
  • rendering/RenderObject.h: (WebCore::RenderObject::hasLayer): (WebCore::RenderObject::prefWidthsDirty): (WebCore::RenderObject::setPrefWidthsDirty): (WebCore::RenderObject::setNeedsLayoutAndPrefWidthsRecalc): (WebCore::RenderObject::calcPrefWidths): (WebCore::RenderObject::minPrefWidth): (WebCore::RenderObject::maxPrefWidth):
  • rendering/RenderPart.cpp: (WebCore::RenderPart::setWidget):
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): (WebCore::RenderPartObject::layout):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::calcPrefWidths):
  • rendering/RenderReplaced.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::calcPrefWidths): (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::calcPrefWidths):
  • rendering/RenderSVGHiddenContainer.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::calcPrefWidths):
  • rendering/RenderSlider.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout): (WebCore::RenderTable::calcPrefWidths): (WebCore::RenderTable::splitColumn): (WebCore::RenderTable::appendColumn):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::updateFromElement): (WebCore::RenderTableCell::styleOrColWidth): (WebCore::RenderTableCell::calcPrefWidths):
  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::updateFromElement):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):
  • rendering/RenderText.cpp: (WebCore::RenderText::trimmedPrefWidths): (WebCore::RenderText::calcPrefWidths): (WebCore::RenderText::calcPrefWidthsInternal): (WebCore::RenderText::setText):
  • rendering/RenderText.h: (WebCore::RenderText::minPrefWidth): (WebCore::RenderText::maxPrefWidth):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcPrefWidths):
  • rendering/RenderTextControl.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::RenderView): (WebCore::RenderView::calcPrefWidths): (WebCore::RenderView::layout):
  • rendering/RenderView.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::layout):
  • rendering/RootInlineBox.cpp:
  • rendering/RootInlineBox.h: (WebCore::RootInlineBox::setHorizontalOverflowPositions): (WebCore::RootInlineBox::setVerticalSelectionPositions):
  • rendering/TableLayout.h:
5:51 PM Changeset in webkit [23332] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Ada.

<rdar://problem/5061022>
REGRESSION: Acrobat 8 plug-in fails to scroll with trackpad two-finger scroll or mouse wheel (12995)


  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passWheelEventToWidget): Get rid of passWheelEventToSubframe and pass wheel events to all widgets.
4:50 PM Changeset in webkit [21078] by justing
  • 4 edits
    8 adds in trunk

LayoutTests:

Reviewed by oliver


<rdar://problem/5156401>
Crash when dragging text into a link inside a table cell

Test for the crash:

  • editing/pasteboard/5156401-1-expected.checksum: Added.
  • editing/pasteboard/5156401-1-expected.png: Added.
  • editing/pasteboard/5156401-1-expected.txt: Added.
  • editing/pasteboard/5156401-1.html: Added.


Test inserting at the end of a link where we would previously
insert in the wrong paragraph:

  • editing/inserting/5156401-2-expected.checksum: Added.
  • editing/inserting/5156401-2-expected.png: Added.
  • editing/inserting/5156401-2-expected.txt: Added.
  • editing/inserting/5156401-2.html: Added.

WebCore:

Reviewed by oliver


<rdar://problem/5156401>
Crash when dragging text into a link inside a table cell

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary): Don't avoid the anchor if doing so would skip over a line break, that would put content in the wrong paragraph, which can throw ReplaceSelectionCommand, which relies on moveParagraphs into infinite recursion. Renamed the input position. Don't need to re-fetch the enclosing anchor when preparing to push it down, since it hasn't changed since the top of the function.
3:59 PM Changeset in webkit [21077] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5133011> 64-bit: Attempting to paste copied text in a input field results in a crash at WebCore::Range::startPosition()

Change a couple incorrect uses of LONG_MAX to INT_MAX to match the variable type they are used in.
The LONG_MAX on 64-bit was overflowing the int variables, causing this crash on paste.

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject value]):
  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::handleTextBox):
2:06 PM Changeset in webkit [21076] by oliver
  • 2 edits in trunk/JavaScriptCore

GTK Build fix, ::findEntry->KJS::findEntry

  • kjs/lookup.cpp: (KJS::Lookup::findEntry): (KJS::Lookup::find):
1:37 PM Changeset in webkit [21075] by spadma
  • 6 edits in S60/trunk/WebKit

yadavall, reviewed by <​sachin.padma@nokia.com>

DESC: Windowless plugin support
​http://bugs.webkit.org/show_bug.cgi?id=13451

  • BrowserView/src/PluginContentPlayer.cpp: (CPluginContentPlayer::CPluginContentPlayer): (CPluginContentPlayer::CountComponentControls): (CPluginContentPlayer::Start):
  • Plugin/inc/PluginWin.h: (CPluginWin::IsPluginWindowed): (CPluginWin::SetWindowedPlugin):
  • Plugin/src/NpnImplementation.cpp: (NpnGetValue): (NpnSetValue): (NpnInvalidateRect): (NpnForceRedraw):
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::Draw):
  • Plugin/src/PluginWin.cpp: (CPluginWin::CPluginWin): (CPluginWin::ConstructL): (CPluginWin::~CPluginWin): (CPluginWin::NewL): (CPluginWin::SizeChanged): (CPluginWin::OfferKeyEventL): (CPluginWin::CreateStreamL): (CPluginWin::WriteStreamToFileL): (CPluginWin::ProcessEventL): (CPluginWin::RefreshPlugin): (CPluginWin::MakeVisible): (CPluginWin::HandleControlEventL): (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground): (CPluginWin::PluginScriptableObject): (CPluginWin::ForceRedraw): (CPluginWin::IsContentInteractive):
1:28 PM Changeset in webkit [21074] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/4966982> 64-bit: In a unordered list, TYPE=DISC and TYPE=CIRCLE attribute values are ignored

We need to draw our full-circle arcs counter-clockwise, since a clockwise arc from 0 to 2π is no arc at all!
This only worked on 32-bit due to a rounding error in CoreGraphics, causing it to draw a full circle anyway.

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawEllipse):
1:21 PM Changeset in webkit [21073] by beidson
  • 8 edits in trunk

WebCore:

Reviewed by Beth, Hyatt, Ada, and Darin

<rdar://problem/5011477> and <rdar://problem/5011514>
Provide support for the icon.db to be moved to a different directory from the old WebKit-style
icons, and remove the old directory if that is the case

Support for this starts in WebCore, where we can use the metadata table in the icon.db to track
whether or not we've ever done the import

  • WebCore.exp:
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultDatabaseFilename): Changed to "Icons.db" (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::deleteAllPreparedStatements): Delete the new statements added (WebCore::IconDatabase::imported): Grab this flag from the DB or return the cached flag (WebCore::IconDatabase::setImported): Store this flag into the DB (WebCore::IconDatabase::importedQuery): Actually do the DB query for this save (WebCore::IconDatabase::setImportedQuery): Actually do the DB query for this retrieval
  • loader/icon/IconDatabase.h:

WebKit:

Reviewed by Beth, Hyatt, Ada, and Darin

<rdar://problem/5011477> and <rdar://problem/5011514>
Provide support for the icon.db to be moved to a different directory from the old WebKit-style
icons, and remove the old directory if that is the case

  • Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): (-[WebIconDatabase _importToWebCoreFormat]): Check "imported()" to determine if a conversion is needed
    • Look for WebIconDatabaseImportDirectoryDefaultsKey for the source location for the conversion
    • Set "imported" to true in the Icons.db
    • If the new Icons.db isn't in the same patch as the old icons, delete the entire directory when finished
    • Move old icon.db to Icons.db to reflect rename
  • Misc/WebIconDatabasePrivate.h: Add WebIconDatabaseImportDirectoryDefaultsKey so a WebKit client can tell WebKit where to look for the old icons if their location is different from the icon.db
  • WebKit.exp:
11:12 AM Changeset in webkit [21072] by thatcher
  • 3 edits in trunk/WebKitTools

Setting the valid architectures to 32-bit only, so these projects
will ignore requests to build them 64-bit. Once they can be built 64-bit,
the valid architectures can be updated.

  • Drosera/Drosera.xcodeproj/project.pbxproj:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
10:37 AM Changeset in webkit [21071] by darin
  • 7 edits
    24 adds in trunk

LayoutTests:

Reviewed by Justin.

  • test for <rdar://problem/4356361> Selection after multiple delete keypresses and undo selects only the last deleted character
  • editing/undo/undo-combined-delete-boundary-expected.checksum: Added.
  • editing/undo/undo-combined-delete-boundary-expected.png: Added.
  • editing/undo/undo-combined-delete-boundary-expected.txt: Added.
  • editing/undo/undo-combined-delete-boundary.html: Added.
  • editing/undo/undo-combined-delete-expected.checksum: Added.
  • editing/undo/undo-combined-delete-expected.png: Added.
  • editing/undo/undo-combined-delete-expected.txt: Added.
  • editing/undo/undo-combined-delete.html: Added.
  • editing/undo/undo-delete-boundary-expected.checksum: Added.
  • editing/undo/undo-delete-boundary-expected.png: Added.
  • editing/undo/undo-delete-boundary-expected.txt: Added.
  • editing/undo/undo-delete-boundary.html: Added.
  • editing/undo/undo-delete-expected.checksum: Added.
  • editing/undo/undo-delete-expected.png: Added.
  • editing/undo/undo-delete-expected.txt: Added.
  • editing/undo/undo-delete.html: Added.
  • editing/undo/undo-forward-delete-boundary-expected.checksum: Added.
  • editing/undo/undo-forward-delete-boundary-expected.png: Added.
  • editing/undo/undo-forward-delete-boundary-expected.txt: Added.
  • editing/undo/undo-forward-delete-boundary.html: Added.
  • editing/undo/undo-forward-delete-expected.checksum: Added.
  • editing/undo/undo-forward-delete-expected.png: Added.
  • editing/undo/undo-forward-delete-expected.txt: Added.
  • editing/undo/undo-forward-delete.html: Added.
  • editing/deleting/delete-and-undo-expected.txt: One of the delegate callbacks has changed in this test's result, because it reflects the selection after undoing a sequence of deletions.

WebCore:

Reviewed by Justin.

  • fix <rdar://problem/4356361> Selection after multiple delete keypresses and undo selects only the last deleted character

Test: editing/undo/undo-combined-delete-boundary.html
Test: editing/undo/undo-combined-delete.html
Test: editing/undo/undo-delete-boundary.html
Test: editing/undo/undo-delete.html
Test: editing/undo/undo-forward-delete-boundary.html
Test: editing/undo/undo-forward-delete.html

  • editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): Fix obviously-wrong code where there were missing braces. I couldn't find any real symptom of this, but I think the fix should go in anyway. All layout tests still pass. (WebCore::TypingCommand::deleteKeyPressed): Added code to compute a selection that goes back to the beginning of the composite editing operation. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
  • editing/Selection.h:
  • editing/Selection.cpp: (WebCore::Selection::setWithoutValidation): Added. Back door to allow setting the ends of a selection without revalidating, because we need to use it on a selection where the endpoints may no longer be valid due to mutations done by earlier pieces of the editing operation.
  • editing/EditCommand.h: (WebCore::EditCommand::startingSelection): Return a const& for speed. (WebCore::EditCommand::endingSelection): Ditto.
8:06 AM Changeset in webkit [21070] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Mitz.

  • fast/forms/input-null-expected.txt: Added.
  • fast/forms/input-null.html: Added.

WebCore:

Reviewed by Mitz.

Test: fast/forms/input-null.html

  • html/HTMLInputElement.idl: Convert JS null to the empty string on setting DOMString attributes.
5:29 AM Changeset in webkit [21069] by bdash
  • 4 edits
    4 adds in trunk

2007-04-24 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/forms/control-clip.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): Apply the clip in all phases that paint children. Split PaintPhaseOutline and PaintPhaseChildBlockBackground into two phases each, applying the clip only to the children.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): Treat the scrollbar as part of the background rather than as a child's background, now that children are clipped out.

2007-04-24 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/forms/control-clip-expected.checksum: Added.
  • fast/forms/control-clip-expected.png: Added.
  • fast/forms/control-clip-expected.txt: Added.
  • fast/forms/control-clip.html: Added.
5:27 AM Changeset in webkit [21068] by bdash
  • 2 edits in trunk/WebKit

2007-04-24 Mitz Pettel <​mitz@webkit.org>

Reviewed by Oliver Hunt.

Changed an apostrophe (') into a right single quotation mark (U+2019).

5:25 AM Changeset in webkit [21067] by bdash
  • 2 edits in trunk/WebKit

2007-04-24 Mitz Pettel <​mitz@webkit.org>

Reviewed by Timothy Hatcher.

  • WebInspector/webInspector/inspector.js: Added a check that the rule is mapped from an attribute.
4:51 AM Changeset in webkit [21066] by bdash
  • 2 edits in trunk/WebCore

2007-04-24 Benjamin Otte <​otte@gnome.org>

Reviewed by Mark Rowe.

Gdk build system improvements.

  • make-generated-sources.sh: Exit with failure status if make fails.
4:49 AM Changeset in webkit [21065] by bdash
  • 2 edits in trunk/WebCore

2007-04-24 Benjamin Otte <​otte@gnome.org>

Reviewed by Mark Rowe.

Gdk build system improvements.

  • Projects/gdk/webcore-gdk.bkl: fail if running any of the commands failed. In particular make-generated-sources.sh
1:44 AM Changeset in webkit [21064] by mjs
  • 4 edits
    1 add in trunk/JavaScriptCore

Reviewed by Geoff.


  • compile most of JavaScriptCore as one file for 4% JS iBench speed improvement
  • JavaScriptCore.xcodeproj/project.pbxproj: Add AllInOneFile.cpp, and remove files it includes from the build.
  • kjs/AllInOneFile.cpp: Added.
  • kjs/dtoa.cpp: Renamed CONST to CONST_ to avoid conflict. (Bigint::): (Bigint::nrv_alloc):
  • kjs/lookup.cpp: Use "namspace KJS { ... }" instead of "using namespace KJS;"
Note: See TracTimeline for information about the timeline view.