Timeline



May 10, 2007:

10:36 PM Changeset in webkit [21392] by justing
  • 1 edit in trunk/LayoutTests/editing/selection/5195166-1.html

This tests behaves differently when it isn't run by itself because
of a bug. Filed it (13673) and added a workaround.


10:17 PM Changeset in webkit [21391] by hyatt
  • 2 edits in trunk/WebCore

<rdar://problem/5015522> Bounds rectangle of unloaded images is
drawn briefly while loading


When the image is null and has no size, don't draw the grey
rectangles or alt text any more. Wait for an actual error to
occur with the image before we start showing alt text and borders.

(Images with no source set at all will continue to show alt text and
borders immediately.)

Reviewed by bradee-oh

  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
9:49 PM Changeset in webkit [21390] by thatcher
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/repaint/layer-full-repaint-expected.checksum: Added.
  • fast/repaint/layer-full-repaint-expected.png: Added.
  • fast/repaint/layer-full-repaint-expected.txt: Added.
  • fast/repaint/layer-full-repaint.html: Added.
  • fast/repaint/repaint-resized-overflow-expected.checksum:
  • fast/repaint/repaint-resized-overflow-expected.png:

WebCore:

Reviewed by Darin.

Test: fast/repaint/layer-full-repaint.html

Removed custom repaint logic from RenderLayer. repaintAfterLayoutIfNeeded()
knows how to do everything we need now. The only catch is that we cannot
rely on its "do a full repaint if the object needs layout" behavior, since
by the time we call it, the needs layout flag has been reset. The solution
is to cache the need for a full repaint in the layer.

  • page/FrameView.cpp: (WebCore::FrameView::layout): Removed call to checkForRepaintOnResize().
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::checkForRepaintOnResize): Removed. (WebCore::RenderLayer::RenderLayer): Replaced the m_repaintOverflowOnResize flag with a m_needsFullRepaint flag, which indicates that the layer needs to do a full repaint in the next call to updateLayerPositions(). (WebCore::RenderLayer::updateLayerPositions): Simplified the repaint logic. Either call repaintAfterLayoutIfNeeded() or do a full repaint, depending on m_needsFullRepaint.
  • rendering/RenderLayer.h: (WebCore::RenderLayer::setNeedsFullRepaint):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setNeedsLayout): Mark the layer for full repaint.
8:51 PM Changeset in webkit [21389] by justing
  • 5 edits
    8 adds in trunk

LayoutTests:

Reviewed by ggaren

<rdar://problem/5195166> Incorrect proposedRange DOMRange passed to WebViewEditing delegate

  • editing/selection/5195166-1-expected.checksum: Added.
  • editing/selection/5195166-1-expected.png: Added.
  • editing/selection/5195166-1-expected.txt: Added.
  • editing/selection/5195166-1.html: Added.
  • editing/selection/5195166-2-expected.checksum: Added.
  • editing/selection/5195166-2-expected.png: Added.
  • editing/selection/5195166-2-expected.txt: Added.
  • editing/selection/5195166-2.html: Added.

WebCore:

Reviewed by ggaren

<rdar://problem/5195166> Incorrect proposedRange DOMRange passed to WebViewEditing delegate


In setModifyBias, we must cache the start and the end
because the calls to setBase and setExtent can modify
them (added a testcase).
The temporary SelectionController that we use in modify() to
produce the proposed range that will be passed to
shouldChangeSelectedDOMRange must have the same m_modifyBias
as the original SelectionController, or else when the
modification is performed, setModifyBias can swap the base
and the extent incorrectly (added a testcase).
Renamed m_modifyBias to m_lastChangeWasHorizontalExtension.
Renamed setModifyBias to willBeModified.

  • editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::willBeModified): (WebCore::SelectionController::modify):
  • editing/SelectionController.h: (WebCore::SelectionController::setLastChangeWasHorizontalExtension):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::updateSelectionForMouseDragOverPosition):
7:09 PM Changeset in webkit [23354] by ggaren
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin Adler.


"IconDatabase::sharedIconDatabase()" => "iconDatabase()" for terseness.

7:01 PM Changeset in webkit [21388] by ggaren
  • 11 edits in trunk

WebCore:

Reviewed by Darin Adler.

"IconDatabase::sharedIconDatabase()" => "iconDatabase()" for terseness,
in the style of WebCore::cache().

  • WebCore.exp:
  • history/HistoryItem.cpp: Removed retainIconInDatabase because calling "retain" in order to release something is really confusing and, now that iconDatabase() is more terse, we don't need this helper to shorten the syntax. (The isEmpty() check is also done by the database, so we don't need it either.)

(WebCore::IconDatabase::~IconDatabase): ASSERT that our destructor isn't
called. We're a singleton, so it's confusing to have tear-down code.

WebKit:

Reviewed by Darin Adler.


"IconDatabase::sharedIconDatabase()" => "iconDatabase()" for terseness.

5:39 PM Changeset in webkit [23353] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Hyatt.

  • bridge/win/FrameWin.cpp: (WebCore::imageFromSelection): Updated to use selectionRect instead of visibleSelectionRect
5:26 PM Changeset in webkit [21387] by adele
  • 24 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/4100616> Doing a "find" in RSS doesn't scroll to result

  • fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum: Added.
  • fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png: Added.
  • fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt: Added.
  • fast/overflow/scroll-nested-positioned-layer-in-overflow.html: Added.

WebCore:

Reviewed by Hyatt.

WebCore part of fix for <rdar://problem/4100616> Doing a "find" in RSS doesn't scroll to result

Test: fast/overflow/scroll-nested-positioned-layer-in-overflow.html

Merged visibleSelectionRect into selectionRect. selectionRect() now takes an argument to determine
whether or not to return a rect that clips to the visible content. This change makes all of the implementations of selectionRect
consistent by having them all consider the repaint rect when clipping to visible content.

  • page/Frame.cpp: (WebCore::Frame::revealSelection): Call selectionRect with clipToVisibleContent = false, so we can get a rect that's not visible to reveal. (WebCore::Frame::selectionRect): Added clipToVisibleContent argument, and merged visibleSelectionRect into this method. (WebCore::Frame::setIsActive): Use selectionRect instead of visibleSelectionRect.
  • page/Frame.h:
  • page/mac/FrameMac.mm: (WebCore::Frame::selectionImage): Update layout before creating the image. Use selectionRect instead of visibleSelectionRect.
  • page/DragController.cpp: (WebCore::dragLocForSelectionDrag): Use selectionRect instead of visibleSelectionRect.
  • rendering/RenderBR.h: (WebCore::RenderBR::selectionRect): Updated argument.
  • rendering/RenderBlock.h: (WebCore::RenderBlock::selectionRect): ditto.
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::selectionRect): ditto.
  • rendering/RenderSVGInlineText.h: ditto.
  • rendering/RenderObject.h: (WebCore::RenderObject::selectionRect): ditto. (WebCore::RenderObject::SelectionInfo::SelectionInfo): ditto.
  • rendering/RenderView.cpp: (WebCore::RenderView::selectionRect): ditto. (WebCore::RenderView::setSelection): ditto.
  • rendering/RenderView.h:
  • rendering/RenderText.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::selectionRect): Only call computeAbsoluteRepaintRect when clipping to visible content. Otherwise, just adjust the rect to the correct position.
  • rendering/RenderListMarker.h:
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::selectionRect): To match what we do in RenderText, if we're trying to clip to visible content, just call computeAbsoluteRepaintRect.
  • rendering/RenderReplaced.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::selectionRect): ditto.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Check for a parent layer at the beginning, so we can try to scroll all of our parent layers first, before trying to scroll the top level view. Also, don't try to scroll overflow layers that have -webkit-line-clamp restricting the height. This will prevent us from revealing text hidden by the slider in Safari RSS.
  • WebCore.exp: Update symbols for WebKit.

WebKit:

Reviewed by Hyatt.

WebKit part of fix for <rdar://problem/4100616> Doing a "find" in RSS doesn't scroll to result

Updated to use selectionRect instead of visibleSelectionRect. selectionRect() now returns the visible rect by default.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): (-[WebHTMLView selectionImageRect]):
4:10 PM Changeset in webkit [21386] by hyatt
  • 2 edits in trunk/LayoutTests/fast/inline

Land updated continuations outline test.

3:59 PM Changeset in webkit [21385] by hyatt
  • 2 edits in trunk/WebCore

Fix for:

<rdar://problem/5195272> REGRESSION: broke outline rings for continuations
with empty inline containers


​http://bugs.webkit.org/show_bug.cgi?id=13667

Make sure to only include collapsed top/bottom margins of the block portion
of the continuation if we know for sure that we have inline line boxes before
and after that would prevent the collapse from going further.

In plain English: the focus rings were too tall. :)

Reviewed by beth

  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::addFocusRingRects):
3:08 PM Changeset in webkit [21384] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderText.cpp

Back out tweak to add PRE_LINE. Was not part of bug fix and is actually wrong.

3:07 PM Changeset in webkit [21383] by hyatt
  • 155 edits
    4 adds in trunk/LayoutTests/fast/text/whitespace

Add layout test for pre-wrap minwidth when a newline is present.

3:02 PM Changeset in webkit [21382] by spadma
  • 6 edits in S60/trunk/WebKit

naguo, reviewed by sachin

DESC: BrowserNG - Find phonenumber doesn't make a call
​http://bugs.webkit.org/show_bug.cgi?id=13614

TSW ID : ISHG-6YFNME

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL):
  • BrowserView/inc/SmartLinkHandler.h:
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
  • BrowserView/src/SmartLinkHandler.cpp: (CSmartLinkHandler::HandleMakeCallL):
  • group/webkit.mmp:
2:55 PM Changeset in webkit [21381] by hyatt
  • 2 edits in trunk/WebCore

Fix for:

<rdar://problem/5067235> REGRESSION: Excessively wide table, impossible to resize

The table used white-space: pre-wrap, which is supported only by WebKit. There
was a bug with the computation of min pref width for pre-wrap text.

Reviewed by mitzpettel

fast/text/white-space/pre-wrap-line-test.html

  • rendering/RenderText.cpp: (WebCore::RenderText::calcPrefWidths):
2:37 PM Changeset in webkit [21380] by beidson
  • 5 edits in trunk/WebCore

Reviewed by Oliver

Cleanup from my earlier Java Applet patch. We should keep a central location to query if
a mime type counts as a Java Applet

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::containsJavaApplet): Query MimeTypeRegistry on the type
  • platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isSupportedImageMIMEType): Update style (WebCore::MimeTypeRegistry::isSupportedImageResourceMIMEType): Ditto (WebCore::MimeTypeRegistry::isSupportedNonImageMIMEType): Ditto (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Perform the Java Applet check
  • platform/MimeTypeRegistry.h:
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Query MimeTypeRegistry on the type
1:58 PM Changeset in webkit [21379] by spadma
  • 2 edits in S60/trunk/WebKit

2007-05-09 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: Added a CancelResetEntryPositionL to the history provider to handle cancelled requests
​http://bugs.webkit.org/show_bug.cgi?id=13651

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::SyncCancelL):
1:58 PM Changeset in webkit [21378] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-05-09 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: Added a CancelResetEntryPositionL to the history provider to handle cancelled requests
​http://bugs.webkit.org/show_bug.cgi?id=13651

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::SyncCancelL):
12:17 PM Changeset in webkit [21377] by bdakin
  • 2 edits in trunk/WebKit

Reviewed by Darin.

Fix for <rdar://problem/5191941> Leopard: Adobe Acrobat 8:
Distiller 8 needs same check fix as 4992521

  • WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]): Adobe Distiller needs the same quirk.
11:57 AM Changeset in webkit [21376] by pyeh
  • 3 adds in trunk/LayoutTests/editing/selection

<rdar://problem/4720109> Sentence textMarker methods do not work well with empty lines
Add expected result for move-by-sentence-linebreak test case.

11:54 AM Changeset in webkit [21375] by pyeh
  • 1 add in trunk/LayoutTests/editing/selection/move-by-sentence-linebreak.html

<rdar://problem/4720109> Sentence textMarker methods do not work well with empty lines
Add a testcase to exercise moving insertion point forward by sentence across lines of text that
includes empty lines.

11:50 AM Changeset in webkit [21374] by pyeh
  • 3 edits in trunk/WebCore

<rdar://problem/4720109> Sentence textMarker methods do not work well with empty lines

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]): (-[WebCoreAXObject doAXPreviousSentenceStartTextMarkerForTextMarker:]): When a marker position is given, the sentence ax methods automatically shift position by one to make sure not to ask for the current sentence again. This is generally fine except when the position shift over an empty line break, which is should be considered a separate sentence. In this case, if we used the shifted position to ask for sentence boundary, ICU parser is not given the text data containing the newline to correctly determine the sentence boundary. Since the ax sentence method is explicitly shifting the position to ask for sentence boundary, it should make sure not to skip over important character that can be a standalone sentence.
  • editing/visible_units.cpp: (WebCore::nextBoundary): When determining boundary, don't stop on a collapsed range, such as newline. Just pick the next valid position to use as boundary.
7:54 AM Changeset in webkit [21373] by zbujtas
  • 3 edits in S60/trunk/JavaScriptCore

2007-05-09 bujtas <​zbujtas@gmail.com>

Reviewed by Sriram
DESC: stack overflow while destroying a huge array. remove ElementNode recursive destruction.
​http://bugs.webkit.org/show_bug.cgi?id=13649

  • kjs/nodes.cpp: (ElementNode::~ElementNode):
  • kjs/nodes.h:
7:42 AM Changeset in webkit [21372] by zbujtas
  • 3 edits in S60/branches/3.1m/JavaScriptCore

2007-05-09 bujtas <​zbujtas@gmail.com>

Reviewed by Sriram
DESC: stack overflow while destroying a huge array. remove ElementNode recursive destruction.
​http://bugs.webkit.org/show_bug.cgi?id=13649

  • kjs/nodes.cpp: (ElementNode::~ElementNode):
  • kjs/nodes.h:
7:36 AM Changeset in webkit [21371] by lars
  • 2 edits in trunk/JavaScriptCore

Reviewed by Zack

Fix our last three test failures in the JavaScript
tests.

Without change 21367 we would have been at 0 failures
in javascript and layout tests now... ;-)

7:16 AM Changeset in webkit [21370] by spadma
  • 3 edits in S60/branches/3.1m/WebKit

vbradley, reviewed by Zalan

DESC: MLIO-6ZGAN6 - Browser doesn't update loading status
​http://bugs.webkit.org/show_bug.cgi?id=13346

  • BrowserView/inc/WebKitControl.h:
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::ProgressCompleted): (CWebKitControl::IncrementProgressForMoreData): (CWebKitControl::IncrementProgressForLoadComplete): (CWebKitControl::ResetProgress): (CWebKitControl::FinalProgressComplete): (CWebKitControl::ProgressUpdate):
7:16 AM Changeset in webkit [21369] by spadma
  • 3 edits in S60/trunk/WebKit

vbradley, reviewed by Zalan

DESC: MLIO-6ZGAN6 - Browser doesn't update loading status
​http://bugs.webkit.org/show_bug.cgi?id=13346

  • BrowserView/inc/WebKitControl.h:
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::ProgressCompleted): (CWebKitControl::IncrementProgressForMoreData): (CWebKitControl::IncrementProgressForLoadComplete): (CWebKitControl::ResetProgress): (CWebKitControl::FinalProgressComplete): (CWebKitControl::ProgressUpdate):
5:48 AM Changeset in webkit [21368] by eseidel
  • 3 edits
    4 adds in branches/feature-branch

2007-05-10 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

​http://bugs.webkit.org/show_bug.cgi?id=11931
PathCG fails to hit on unclosed sub-paths

Test: svg/custom/hit-test-unclosed-subpaths.svg

  • platform/graphics/cg/PathCG.cpp: (WebCore::copyClosingSubpathsApplierFunction): (WebCore::copyCGPathClosingSubpaths): (WebCore::Path::contains): use new copy & close function
5:31 AM Changeset in webkit [21367] by mjs
  • 41 edits
    4 adds in trunk

LayoutTests:

Reviewed by Oliver.


  • new test case for: <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load) <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)

(The test case covers both scenarios.)

  • http/tests/misc/frame-access-during-load-expected.checksum: Added.
  • http/tests/misc/frame-access-during-load-expected.png: Added.
  • http/tests/misc/frame-access-during-load-expected.txt: Added.
  • http/tests/misc/frame-access-during-load.html: Added.
  • test results beneficially or harmlessly changed as a result of the above fixes
  • css2.1/t0801-c412-hz-box-00-b-a-expected.checksum:
  • css2.1/t0801-c412-hz-box-00-b-a-expected.png:
  • css2.1/t0801-c412-hz-box-00-b-a-expected.txt: This reflects an <object> containing an image now creating an image renderer.
  • dom/xhtml/level2/html/HTMLIFrameElement11-expected.txt: This is updated to a slightly less bad failure for access to a frame that's not loaded yet.

The following test results now reflect the frame removal that the test was testing:


  • fast/dom/clientWidthAfterDocumentIsRemoved-expected.checksum:
  • fast/dom/clientWidthAfterDocumentIsRemoved-expected.png:
  • fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt:
  • fast/dom/replaceChild-expected.checksum:
  • fast/dom/replaceChild-expected.png:
  • fast/dom/replaceChild-expected.txt:

The following tests results now reflect empty document content for iframes that never load anything:


  • fast/events/focusingUnloadedFrame-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt:

WebCore:

Reviewed by Oliver.

  • WebCore part of fix for: <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load) <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)

The basic approach is to have Frames start out containing an empty document instead of absolutely nothing,
so there is no need to initialize them on demand. Various side effects of that cause both of these bugs.


However, this caused many regressions so I had to fix the fallout.


  • WebCore.exp: fix symbol exports
  • bindings/js/kjs_window.cpp: (KJS::createNewWindow): useless "created" bool (we don't need it here) (KJS::WindowFunc::callAsFunction): detect if we created a new frame, because if so, we need to initialize the domain (can't count on it not having a document), also don't try to make a new document for it. Also, stop properly.
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): don't count on document having a view here
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::isImageType): Ask client, to match how other <object> renderer decisions are made.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): Initialize new data members (WebCore::FrameLoader::init): Do the slightly tricky sequence of steps to properly make an empty document with everything hooked up. (WebCore::FrameLoader::createWindow): Added "created" bool. (WebCore::FrameLoader::stopLoading): (whitespace change) (WebCore::FrameLoader::begin): Don't try to create an empty document. (WebCore::FrameLoader::finishedParsing): If creating an initial empty document, don't do any of this work. (WebCore::FrameLoader::checkCompleted): Do checkLoadComplete() as well. (WebCore::FrameLoader::baseURL): don't check for null document (WebCore::FrameLoader::baseTarget): ditto (WebCore::FrameLoader::completeURL): ditto (WebCore::FrameLoader::didTellBridgeAboutLoad): ditto (WebCore::FrameLoader::scheduleLocationChange): determine duringLoad differently; doc won't be null. (WebCore::FrameLoader::gotoAnchor): don't check for null document (WebCore::FrameLoader::canTarget): don't check for null document (WebCore::FrameLoader::stopForUserCancel): new method for explicit stops like window.stop(). (WebCore::FrameLoader::transitionToCommitted): check for pre-loaded state properly (WebCore::FrameLoader::createEmptyDocument): removed (WebCore::FrameLoader::checkLoadCompleteForThisFrame): don't send delegate callbacks when making initial doc. (WebCore::FrameLoader::tokenizerProcessedData): Assume document; just checkCompleted now that it does checkLoadComplete. (WebCore::FrameLoader::receivedMainResourceError): assume document (WebCore::FrameLoader::saveDocumentState): Assume there's a document except during initial load (WebCore::FrameLoader::mainReceivedCompleteError): do checkCompleted, not checkLoadComplete (WebCore::FrameLoader::continueLoadWithData): assume document
  • loader/FrameLoader.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::receivedError): Add more ref protection and do things in a slightly different order.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::document): don't force document creation, just assert there is one.
  • page/Frame.cpp: (WebCore::Frame::init): Added init method. (WebCore::Frame::pageDestroyed): when a frame is removed, make sure to check if the parent is done loading.
  • page/Frame.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): No need to force document. (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]): ditto
  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::dataChanged): init the frame
  • rendering/RenderPart.cpp: (WebCore::RenderPart::updateWidgetPosition): If a subframe needs layout, then lay it out even if the bounds did not change; the content size might be wrong.
  • rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation): Don't crash if the frame lacks a view.

WebKit:

Reviewed by Oliver.

  • WebKit part of fix for: <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load) <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)

The basic approach is to have Frames start out containing an empty document instead of absolutely nothing,
so there is no need to initialize them on demand. Various side effects of that cause both of these bugs.


However, this caused many regressions so I had to fix the fallout.

  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::takeFocus): Avoid focus cycle problems (can happen in DumpRenderTree with initial empty document now).
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge finishInitializingWithPage:frameName:frameView:ownerElement:]): init the frame. (-[WebFrameBridge determineObjectFromMIMEType:URL:]): return image type when appropriate
  • WebView/WebFrame.mm: (-[WebFrame stopLoading]): use stopForUserCancel().
  • WebView/WebFrameView.mm: (-[WebFrameView _makeDocumentViewForDataSource:]): assume html when no mime type available.
  • WebView/WebView.mm: (-[WebView becomeFirstResponder]): Track whether we are becoming first responder from outside the view. (-[WebView _becomingFirstResponderFromOutside]): Return this value.
  • WebView/WebViewInternal.h:

WebKitTools:

Reviewed by Oliver.


  • don't clear events whenever an EventSendingController goes away, only do it at predictable times, since destroying a subframe can make one go away


(Discovered while fixing:


<rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load)
<rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)

  • DumpRenderTree/DumpRenderTree.m: (runTest): explicitly clear saved events after every page load
  • DumpRenderTree/EventSendingController.h:
  • DumpRenderTree/EventSendingController.m: (-[EventSendingController dealloc]): don't clear saved events here... (+[EventSendingController clearSavedEvents]): do it here
  • Scripts/check-for-global-initializers:
5:08 AM Changeset in webkit [21366] by hyatt
  • 4 adds in trunk/LayoutTests/fast/text/whitespace

Add layout test for 13654.

5:08 AM Changeset in webkit [23352] by mjs
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Oliver.

  • WebKitWin part of fix for: <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load) <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)

The basic approach is to have Frames start out containing an empty document instead of absolutely nothing,
so there is no need to initialize them on demand. Various side effects of that cause both of these bugs.


However, this caused many regressions so I had to fix the fallout.

  • WebFrame.cpp: (WebFrame::createFrame): init frame
  • WebView.cpp: (WebView::initWithFrame): init frame (WebView::stringByEvaluatingJavaScriptFromString): don't create empty document
5:06 AM Changeset in webkit [21365] by hyatt
  • 2 edits in trunk/WebCore

Fix for:

<rdar://problem/5146757> REGRESSION: div that wrapped to screen width in
tiger no longer wraps


​http://bugs.webkit.org/show_bug.cgi?id=13654

Reviewed by mitz

fast/text/whitespace/normal-after-nowrap-breaking.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths):
3:48 AM Changeset in webkit [21364] by bdash
  • 2 edits in trunk/WebKitTools

2007-05-10 Mark Rowe <​mrowe@apple.com>

Build fix for DumpRenderTree. Enable Objective-C exceptions in Release configuration.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3:14 AM Changeset in webkit [21363] by hyatt
  • 3 edits in trunk/WebCore

Fix for:

<rdar://problem/4778099> Links with nested continuations fail to
paint their outlines (11255)


​http://bugs.webkit.org/show_bug.cgi?id=11255

Fix multiple bugs with outline painting of continuations to ensure that
all combos work (empty/full inline - block with/without margins -
empty/full inline).

Reviewed by mitz

fast/inline/continuation-outlines.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::addFocusRingRects):
3:13 AM Changeset in webkit [21362] by hyatt
  • 4 adds in trunk/LayoutTests/fast/inline

Add continuation outline drawing test.

2:29 AM Changeset in webkit [21361] by hyatt
  • 4 adds in trunk/LayoutTests/fast/overflow

Add layout test to cover RTL overflow issue.

2:28 AM Changeset in webkit [21360] by hyatt
  • 2 edits in trunk/WebCore

Fix for:

<rdar://problem/5193529> REGRESSION: RTL Overflows scrollbar not showing
when they should be


Fallout from fix for bug 11926. Make sure to restrict the fix to the
RenderView for now, since the full-blown overflow case is pretty involved.

Reviewed by mitzpettel

fast/overflow/unreachable-content-bug-rtl.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition):
1:55 AM Changeset in webkit [21359] by beidson
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Oliver

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13636 and <rdar://problem/5190816>

When creating the applets collection, be sure to only count Objects if they contain
a java applet

  • dom/html/level2/html/AppletsCollection-expected.txt: Added.
  • dom/html/level2/html/AppletsCollection.html: Added.

WebCore:

Reviewed by Oliver

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13636 and <rdar://problem/5190816>

When creating the applets collection, be sure to only count Objects if they contain
a java applet

  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::traverseNextItem): Add the qualifier for Objects that containsJavaApplet() must be true
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::containsJavaApplet): Check this Object element and inner nodes for any Java applets
  • html/HTMLObjectElement.h:
1:52 AM Changeset in webkit [21358] by hyatt
  • 2 edits in trunk/WebCore

Fix for:

<rdar://problem/4694859> SAP: HTML tags with overflow:hidden consume
space on page, do not consume space in Firefox (11926)

​http://bugs.webkit.org/show_bug.cgi?id=11926

Make sure that unreachable objects along one axis (e.g., top/left) do not
contribute to the scrollable area in the opposite axis (e.g., right/bottom).

Reviewed by olliej

fast/overflow/unreachable-content-test.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition):
1:50 AM Changeset in webkit [21357] by hyatt
  • 4 adds in trunk/LayoutTests/fast/overflow

Add layout test for bug 11926.

1:09 AM Changeset in webkit [21356] by hyatt
  • 150 edits
    4 adds in trunk/LayoutTests/fast/text

Add layout test for opacity/letter-spacing bug.

1:09 AM Changeset in webkit [21355] by hyatt
  • 2 edits in trunk/WebCore

Fix for:

<rdar://problem/4656825> REGRESSION: Japanese TV time table widget:
part of the number in background has been cut off.

Now that opacity uses a tight bounding box to clip, we need to make sure
to factor spillout caused by negative letter spacing into our right
overflow. Latch on to the code that does this already for text-stroke
and text-shadow.

Reviewed by olliej

fast/text/letter-spacing-negative-opacity.html

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally):
1:00 AM Changeset in webkit [21354] by ggaren
  • 11 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej Stachowiak.


Tests for more fix-ups to the WebScriptObject/WebScripting APIs, related to
<rdar://problem/5140447> API for fetching JSGlobalContextRef from WebView
or WebFrame

  • fast/dom/wrapper-classes-expected.txt:
  • fast/dom/wrapper-classes.html: Added cases to test the wrapper classes for different data types sent across the JS/ObjC bridge.
  • fast/dom/wrapper-round-tripping-expected.txt: Added.
  • fast/dom/wrapper-round-tripping.html: Added. New test to verify that you can round-trip between a JSObjectRef and a WebScriptObject.

WebCore:

Reviewed by Maciej Stachowiak.


More fix-ups to the WebScriptObject/WebScripting APIs, related to
<rdar://problem/5140447> API for fetching JSGlobalContextRef from WebView
or WebFrame

  • bindings/objc/WebScriptObject.h: Fully specified the surprising rules for type conversion between JavaScript and ObjC.
  • bindings/objc/WebScriptObject.mm: Added up-call accessor to WebFrame. This is kind of stinky, but I'm OK with it because eventually all of this code should move up into WebKit. (+[WebScriptObject scriptObjectForJSObject:frame:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject JSObject]):
    • Added _rootObject check because if _rootObject returns NULL it means that _imp is no longer GC protected, so it's not safe to use.
    • Added _isSafeScript check because that's what WebScriptObject methods typically do, even though the value of doing so isn't clear to me.
  • bindings/objc/WebScriptObjectPendingPublic.h: Added WebFrame* parameter to -scriptObjectForJSObject:. This is required to wrap JS objects that are not already in the wrapper cache. It would be nice to remove this limitation of WebScriptObject some day.
  • page/mac/FrameMac.mm: (WebCore::Frame::cleanupPlatformScriptObjects): Force removal of m_windowScriptObject from the cache, to avoid retrieving the m_windowScriptObject from the previous page on a new page load. (It would be non-functional in that case.)

WebKitTools:

Reviewed by Maciej Stachowiak.


Added support for testing ObjC/JS type bridging.


Added ASSERT that -JSObject returns nil when the underlying JSObject
is no longer GC protected.

  • DumpRenderTree/DumpRenderTree.m: (returnThisCallback): (returnThisClass): (-[WaitUntilDoneDelegate webView:didClearWindowObject:forFrame:]): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController accessStoredWebScriptObject]): (-[LayoutTestController testWrapperRoundTripping]): (-[LayoutTestController objCClassNameOf:]): (-[LayoutTestController objCObjectOfClass:]):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
12:50 AM Changeset in webkit [21353] by lars
  • 1 edit
    1 add in trunk/LayoutTestResults

Add missing test result.

12:34 AM Changeset in webkit [21352] by hyatt
  • 4 adds in trunk/LayoutTests/fast/inline-block

Add vertical align layout test for inline blocks.

12:33 AM Changeset in webkit [21351] by lars
  • 2 edits in trunk/WebKitTools

Reviewed by Simon

Move setting of the DPI value a few lines up. Should fix
the last two remaining failures in the layout tests.

12:32 AM Changeset in webkit [21350] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5183697>.

​http://bugs.webkit.org/show_bug.cgi?id=13576

Make sure verticalPositionHint is not called on an inline-block from
content inside the inline-block (like text).

Reviewed by olliej

fast/inline-block/inline-block-vertical-align.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::verticalPositionHint):
  • rendering/RenderText.cpp: (WebCore::RenderText::verticalPositionHint):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::setFontFromControlSize):

May 9, 2007:

9:53 PM Changeset in webkit [21349] by oliver
  • 2 edits in trunk/WebKit

2007-05-09 Oliver Hunt <​oliver@apple.com>

rs=Adele.

The previous patch (r21346) broke editing, rolling out

  • WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): (-[WebHTMLView doCommandBySelector:]):
7:32 PM Changeset in webkit [21348] by bdash
  • 1 edit in tags/WebKit-419.2/WebKit/Info.plist

Versioning.

7:30 PM Changeset in webkit [21347] by bdash
  • 2 edits in tags/WebKit-419.2/WebKit

Merge r21322.

7:28 PM Changeset in webkit [21346] by oliver
  • 2 edits in trunk/WebKit

2007-05-09 Adele Peterson <​adele@apple.com>

Reviewed by Oliver.


Re-applying fix for <rdar://problem/5107538> REGRESSION: Page scroll when selecting characters from inline input candidate window by arrow buttons
​http://bugs.webkit.org/show_bug.cgi?id=13263


We don't need to call interpretKeyEvents for cmd-key events as
they events will be interpreted by performKeyEquivalent.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): (-[WebHTMLView doCommandBySelector:]):
7:26 PM Changeset in webkit [21345] by bdash
  • 1 copy in tags/WebKit-419.2

New tag.

7:11 PM Changeset in webkit [21344] by oliver
  • 1 edit in trunk/LayoutTests/ChangeLog

Remove random characters from changelog

7:08 PM Changeset in webkit [21343] by oliver
  • 2 edits in trunk/LayoutTests

Reviewed by Adam.


Workaround for rdar://problem/5114296 need to allow for
download occuring, and thus not triggering subframeLoaded()

  • fast/encoding/char-encoding.html:
3:16 PM Changeset in webkit [21342] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.


Fixed #includes of JSStringRefCF.h and use of CF datatypes. I think I
misunderstood this issue before.

  • API/JavaScriptCore.h: #include JSStringRefCF.h. Platforms that don't want this behavior can just #include individual headers, instead of the umbrella framework header. But we definitely want Mac OS X clients to get the #include of JSStringRefCF.h "for free."
  • API/minidom.c: Don't #include JSStringRefCF.h. (Don't need to #include JavaScriptCore.h, either.)
  • API/testapi.c: Don't #include JSStringRefCF.h. Do use CF datatypes regardless of whether APPLE is defined. Platforms that don't support CF just shouldn't compile this file. (main):
3:04 PM Changeset in webkit [21341] by bdash
  • 1 copy in branches/feature-branch

Branch for feature development.

2:42 PM Changeset in webkit [21340] by bdash
  • 4 edits
    1 add in trunk

2007-05-09 Holger Freyther <​zecke@selfish.org>

Reviewed by Mark Rowe.

Gdk build fix with SVG enabled. Stub out ImageBufferCairo.

  • WebCore.pro: Build ImageBufferCairo.cpp
  • platform/graphics/cairo/ImageBufferCairo.cpp: Added. (WebCore::ImageBuffer::create): (WebCore::ImageBuffer::~ImageBuffer): (WebCore::ImageBuffer::context):

2007-05-09 Holger Freyther <​zecke@selfish.org>

Reviewed by Mark Rowe.

  • GdkLauncher/main.cpp: Always include config.h.
1:37 PM BuildBot edited by bdash@webkit.org
(diff)
1:22 PM Changeset in webkit [21339] by zbujtas
  • 2 edits in S60/trunk/WebCore

yadavall, reviewed by <​zbujtas@gmail.com>

DESC: Web Browser crashes when trying to browse to Hertz.com
​http://bugs.webkit.org/show_bug.cgi?id=13616

12:59 PM Changeset in webkit [21338] by justing
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5017613> Style changes don't effect fully selected ToDo content

Demonstrates the bug:

  • editing/style/5017613-1-expected.checksum: Added.
  • editing/style/5017613-1-expected.png: Added.
  • editing/style/5017613-1-expected.txt: Added.
  • editing/style/5017613-1.html: Added.


Tests to make sure that a plaintext-only region
will only be styled if it is fully selected:

  • editing/style/5017613-2-expected.checksum: Added.
  • editing/style/5017613-2-expected.png: Added.
  • editing/style/5017613-2-expected.txt: Added.
  • editing/style/5017613-2.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/5017613> Style changes don't effect fully selected ToDo content

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): Use a for loop instead of while(1). Simplify loop termination using Range::pastEndNode. Don't handle the start.node() == end.node() case specially, it's unnecessary. Apply the style change to fully selected plaintext-only regions, not with wrapper spans inside the region, but by changing the element's inline style declaration. Don't descend into nodes whose children we should ignore.
11:45 AM Changeset in webkit [21337] by adele
  • 7 edits in trunk

LayoutTests:

Reviewed by Hyatt.

Updated results for <rdar://problem/5113578> REGRESSION: textfields that set the height but not the font
look different from IE & FF because the font is small

  • fast/block/float/032-expected.txt:
  • fast/forms/input-text-word-wrap-expected.checksum:
  • fast/forms/input-text-word-wrap-expected.png:
  • fast/forms/input-text-word-wrap-expected.txt:

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5113578> REGRESSION: textfields that set the height but not the font
look different from IE & FF because the font is small

For plain text fields, don't stretch the inner text box. Center it vertically in the field.

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::layout):
7:57 AM Changeset in webkit [21336] by darin
  • 1 edit
    1 add in trunk/LayoutTests
  • checked in a file that was accidentally left out of the last check-in
  • fast/js/cyclic-prototypes-expected.txt: Added.
7:39 AM Changeset in webkit [21335] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-05-08 ligman <​joseph.ligman@nokia.com>

Reviewed by sachin.
DESC: Check for NULL cursor prior getting it's position. This can happen when switching between tabbed and cursor navigations.
​http://bugs.webkit.org/show_bug.cgi?id=13627

  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL):
7:36 AM Changeset in webkit [21334] by spadma
  • 2 edits in S60/trunk/WebKit

2007-05-08 ligman <​joseph.ligman@nokia.com>

Reviewed by sachin.
DESC: Check for NULL cursor prior getting it's position. This can happen when switching between tabbed and cursor navigations.
​http://bugs.webkit.org/show_bug.cgi?id=13627

  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL):
7:00 AM Changeset in webkit [21333] by yongjzha
  • 2 edits in S60/branches/3.1m/WebKit

2007-05-07 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Browser back goes to the beginning of the previous page
​http://bugs.webkit.org/show_bug.cgi?id=13394
TSW ID : TMCN-6YDJDU

  • BrowserView/src/LoadListeners.cpp: (CPageLoadListener::HeadersL):
3:36 AM Changeset in webkit [21332] by eseidel
  • 3 edits
    2 adds in trunk

2007-05-09 Eric Seidel <​eric@webkit.org>

Reviewed by mjs.


​http://bugs.webkit.org/show_bug.cgi?id=6985
Cyclic proto values cause WebKit to hang

  • kjs/object.cpp: (KJS::JSObject::put): do a cycle check before setting proto
3:35 AM Changeset in webkit [21331] by bdash
  • 2 edits in trunk/WebCore

2007-05-09 Atul Mehrotra <​atul.mehrotra@celunite.com>

Gdk build fix.

  • platform/gdk/TemporaryLinkStubs.cpp: (Editor::newGeneralClipboard):
1:20 AM Changeset in webkit [21330] by bdash
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merge r21322.

12:52 AM Changeset in webkit [21329] by bdash
  • 3 edits in trunk/WebCore

2007-05-09 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Moved initialization of m_slowRepaintObjectCount here. (WebCore::FrameViewPrivate::reset): Do not reset the slow repaint object count here. (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::addSlowRepaintObject): (WebCore::FrameView::removeSlowRepaintObject): Added an assertion that the object count is positive.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Corrected a mix up between old and new style, which caused the object count to be decremented when it was supposed to be incremented and vice versa.
12:48 AM Changeset in webkit [21328] by bdash
  • 2 edits in trunk/WebCore

2007-05-09 Peter Müller <​pm@one.com>

Reviewed by Dave Hyatt.

Changed the hardcoded colors that are used for CSS 2.1 system colors.
Previous colors had numerous conflicts in semantic pairs, which
made text invisible in highlight, info and menu colored areas.
The new hardcoded colors are inspired by Aqua.

Ideally these colors should be fetched through AppKit instead,
though I am not sure if it is possible to make a 1:1 mapping
between CSS2.1 system colors and Mac OS X.

  • css/cssstyleselector.cpp: (WebCore::):
12:32 AM Changeset in webkit [23351] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebCoreLocalizedStrings.cpp

Fix build.

12:16 AM Changeset in webkit [21327] by lars
  • 2 edits in trunk/WebCore

Fix the Qt build.

May 8, 2007:

11:04 PM Changeset in webkit [21326] by bdash
  • 2 edits in branches/Safari-522/WebKit

Merge r21322 and 21323.

10:59 PM Changeset in webkit [21325] by bdash
  • 3 edits in branches/Safari-522/WebKit

Merge r20668.

10:28 PM Changeset in webkit [21324] by ggaren
  • 9 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin Adler.

Added test to verify that you get back the same JS/ObjC wrapper when
you access the same object twice.

  • fast/dom/wrapper-identity-expected.txt: Added.
  • fast/dom/wrapper-identity.html: Added.

WebCore:

Reviewed by Darin Adler.


More fix-ups to the WebScriptObject/WebScripting APIs, related to
<rdar://problem/5140447> API for fetching JSGlobalContextRef from WebView
or WebFrame


  1. Added -scriptObjectForJSObject: SPI so you can bridge back from JavaScriptCore to WebScriptObject.


  1. Fixed WebScriptObject bridging so that you always get the same WebScriptObject for a JSObject (like in the DOM). This makes -scriptObjectForJSObject: a lot more coherent as an API.
  • bindings/objc/DOMInternal.mm: Renamed wrapperCache to DOMWrapperCache to distinguish from the JSWrapperCache. Added typedef for readability. (WebCore::getDOMWrapper): (WebCore::addDOMWrapper): (WebCore::removeDOMWrapper):
  • bindings/objc/WebScriptObject.mm: Added JSWrapperCache, which works just like the DOMWrapperCache. (WebCore::getJSWrapper): (WebCore::addJSWrapper): (WebCore::removeJSWrapper): (WebCore::createJSWrapper): (+[WebScriptObject scriptObjectForJSObject:]): This is the new API. It attempts to return a specific DOM wrapper object, or, barring that, it returns a generic WebScriptObject. (+[WebScriptObject scriptObjectForJSObject:originRootObject:rootObject:]): Added this method to support our old WebScriptObject security and leak checking model, even though it doesn't work very well. (-[WebScriptObject _setImp:originRootObject:rootObject:]): (-[WebScriptObject dealloc]): (-[WebScriptObject finalize]): (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
  • bindings/objc/WebScriptObjectPendingPublic.h:
  • bindings/objc/WebScriptObjectPrivate.h:
  • page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject): Changed to use the new API. This fixes a bug where the object sent to -windowScriptObjectAvailable: and returned from -windowScriptObject could not be round-tripped.

WebKitTools:

Reviewed by Darin Adler.


Added support for testing ObjC object identity.


Added ASSERT to verify that you can round-trip the object passed to you
in -didClearWindowObject:forFrame:.

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didClearWindowObject:forFrame:]): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController accessStoredWebScriptObject]): (-[LayoutTestController objCIdentityIsEqual::]):
10:15 PM Changeset in webkit [21323] by bdash
  • 2 edits in trunk/WebKit

2007-05-09 Mark Rowe <​mrowe@apple.com>

Build fix to keep the buildbot happy.

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
9:09 PM Changeset in webkit [21322] by bdash
  • 2 edits in trunk/WebKit

2007-05-08 Bruce Q Hammond <​bruceq@apple.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13578
Bug 13578: When QD plugins draw to an offscreen bitmap the origin is not correct

Now we have correct handling of the origin when QD plugins draw to
offscreen bitmaps.
Also the clipping code for this path was doing unnecessary work which
caused incorrect results; it has been removed.


This change should not affect Safari and in general will only affect
plugins (e.g. Flash) drawing to a CGBitmapContext.

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
9:07 PM Changeset in webkit [21321] by bdash
  • 2 edits in trunk/WebCore

2007-05-09 Mark Rowe <​mrowe@apple.com>

Build fix.

  • editing/Editor.cpp: (WebCore::findFirstGrammarDetailInRange): Use unsigned rather than int. (WebCore::findFirstBadGrammarInRange): Cast to unsigned in assertion. (WebCore::isRangeUngrammatical): Remove unused variables.
8:11 PM Changeset in webkit [21320] by eseidel
  • 3 edits
    3 adds in trunk

2007-05-08 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by darin. Landed by eseidel.

  • ​http://bugs.webkit.org/show_bug.cgi?id=10880 (Do..while loop gains a semicolon each time it is toStringed) Grammar in Ecma-66262, 12.6: "do Statement while ( Expression );" EmptyStatement was created after every do..while(expr) which had semicolon at the end.
  • kjs/grammar.y: Require semicolon at the end of do..while
6:45 PM Changeset in webkit [21319] by kevino
  • 10 edits in branches/wx-port-alpha/trunk

Get WEBKITOUTPUTDIR working for the wx port and use it to store build files. Also add a way to specify custom args to make, and have the build script point users to the demo and JSCore tests upon completion.

6:14 PM Changeset in webkit [23350] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-05-08 Steve Falkenburg <​sfalken@apple.com>

Rubber-stamped by Geoff.

Moved shared EditorWin code to Editor.cpp in open source.

  • platform/win/EditorWin.cpp: Deleted (moved) most of this file.
6:02 PM Changeset in webkit [21318] by sfalken
  • 6 edits in trunk

Reviewed by Darin.

Implemented spelling/grammar related WebEditorClient methods.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::ignoreWordInSpellDocument): Added. Call through to NSSpellChecker. (WebEditorClient::learnWord): Added. Call through to NSSpellChecker. (WebEditorClient::checkSpellingOfString): Added. Call through to NSSpellChecker. (WebEditorClient::checkGrammarOfString): Added. Call through to NSSpellChecker. (WebEditorClient::updateSpellingUIWithGrammarString): Added. Call through to NSSpellChecker. (WebEditorClient::updateSpellingUIWithMisspelledWord): Added. Call through to NSSpellChecker. (WebEditorClient::showSpellingUI): Added. Call through to NSSpellChecker. (WebEditorClient::spellingUIIsShowing): Added. Call through to NSSpellChecker. (WebEditorClient::getGuessesForWord): Added. Call through to NSSpellChecker.

Reviewed by Darin.

Moved most spelling/grammar logic to C++. Now calls through to
WebKit to actually invoke NSSpellChecker.

  • editing/Editor.cpp: (WebCore::Editor::ignoreSpelling): Added (ported from EditorMac). (WebCore::Editor::learnSpelling): Added (ported from EditorMac). (WebCore::findFirstMisspellingInRange): Added (ported from EditorMac). (WebCore::paragraphAlignedRangeForRange): Added (ported from EditorMac). (WebCore::findFirstGrammarDetailInRange): Added (ported from EditorMac). (WebCore::findFirstBadGrammarInRange): Added (ported from EditorMac). (WebCore::Editor::advanceToNextMisspelling): Added (ported from EditorMac). (WebCore::Editor::isSelectionMisspelled): Added (ported from EditorMac). (WebCore::isRangeUngrammatical): Added (ported from EditorMac). (WebCore::Editor::isSelectionUngrammatical): Added (ported from EditorMac). (WebCore::Editor::guessesForUngrammaticalSelection): Added (ported from EditorMac). (WebCore::Editor::guessesForMisspelledSelection): Added (ported from EditorMac). (WebCore::Editor::showSpellingGuessPanel): Added (ported from EditorMac). (WebCore::Editor::spellingPanelIsShowing): Added (ported from EditorMac). (WebCore::Editor::markMisspellingsAfterTypingToPosition): Added (ported from EditorMac). (WebCore::markAllMisspellingsInRange): Added (ported from EditorMac). (WebCore::markAllBadGrammarInRange): Added (ported from EditorMac). (WebCore::markMisspellingsOrBadGrammar): Added (ported from EditorMac). (WebCore::Editor::markMisspellings): Added (ported from EditorMac). (WebCore::Editor::markBadGrammar): Added (ported from EditorMac).
  • editing/mac/EditorMac.mm: Removed Objective C version of spelling/grammar calls.
5:44 PM Changeset in webkit [21317] by kevino
  • 2 edits in branches/wx-port-alpha/trunk/WebKit/wx

Update code to work with WebKit changes in the last update.

5:42 PM Changeset in webkit [23349] by sfalken
  • 6 edits
    1 add in branches/WindowsMerge

2007-05-08 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin, Oliver.


Added UI_STRING versions of localized WebCore strings.

2007-05-08 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin, Oliver.

Removed localized string stubs.

  • platform/win/TemporaryLinkStubs.cpp:
4:14 PM Changeset in webkit [21316] by oliver
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by darin.

Test for <rdar://problem/5188938> arc method on
Canvas causes hang or crash work around.

  • fast/canvas/arc-crash-expected.txt: Added.
  • fast/canvas/arc-crash.html: Added.

WebCore:

Reviewed by Darin.


Fix <rdar://problem/5188938> arc method on Canvas causes hang or crash


Workaround bad behaviour of CGPathAddArc when passed inf as start or
end angles.

  • platform/graphics/cg/PathCG.cpp: (WebCore::Path::addArc):
3:51 PM Changeset in webkit [21315] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt and Hatcher.

  • fix auto-activation code path so Tiger and Leopard aren't different
  • platform/mac/WebFontCache.mm: (+[WebFontCache fontWithFamily:traits:size:]): Do the auto-activation dance first before doing anything else, and ignore the font that it returns.
3:43 PM Changeset in webkit [21314] by brmorris
  • 2 edits in S60/trunk/WebKit

bradley, reviewed by nobody

DESC: fix bustage by wrapping EAknEditorFlagDeliverVirtualKeyEv

  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp
2:58 PM Changeset in webkit [21313] by spadma
  • 3 edits in S60/trunk/WebKit

2007-05-08 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: recogniser enhancement.
​http://bugs.webkit.org/show_bug.cgi?id=13628

  • BrowserRecognizers/inc/BrowserRec.h:
  • BrowserRecognizers/src/BrowserRec.cpp: (:CApaDataRecognizerType): (CBrowserRecognizer::PreferredBufSize): (CBrowserRecognizer::SupportedDataTypeL): (CBrowserRecognizer::DoRecognizeL): (CBrowserRecognizer::CheckForOPML): (CBrowserRecognizer::CreateRecognizerL):
1:11 PM Changeset in webkit [21312] by yongjzha
  • 3 edits in S60/branches/3.1m/JavaScriptCore

2007-05-08 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by yongjun.
DESC: TSW ID : EWGO-6YVB4L: Web application jams and closed when browsing.

​http://bugs.webkit.org/show_bug.cgi?id=13361

  • pcre/pcre-config.h:
  • pcre/pcre.c: (compile_branch): (pcre_compile):
12:41 PM Changeset in webkit [23348] by sfalken
  • 8 edits in branches/WindowsMerge

2007-05-08 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.


Update editing delegate

  • Interfaces/IWebEditingDelegate.idl:
  • WebEditorClient.cpp: (WebEditorClient::updateSpellingUIWithGrammarString):
  • WebEditorClient.h:

2007-05-08 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.

Updated for new editor interface.

  • platform/win/EditorWin.cpp: (WebCore::Editor::advanceToNextMisspelling): (WebCore::isRangeUngrammatical):

2007-05-08 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.


Update to new editing delegate interface.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: (EditingDelegate::updateSpellingUIWithGrammarString):
12:27 PM Changeset in webkit [21311] by sfalken
  • 10 edits in trunk

2007-05-08 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.

Slight modification to last editor method fix.

  • WebCoreSupport/WebEditorClient.h: (WebEditorClient::updateSpellingUIWithGrammarString):

2007-05-08 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.

Slight modification to last editor method fix.

  • bridge/EditorClient.h:
  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::updateSpellingUIWithGrammarString):
  • platform/gdk/EditorClientGdk.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::updateSpellingUIWithGrammarString):

2007-05-08 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.


Slight modification to last editor method fix.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::updateSpellingUIWithGrammarString):
  • WebCoreSupport/EditorClientQt.h:
11:31 AM Changeset in webkit [21310] by ggaren
  • 2 edits in trunk/JavaScriptCore

Build fix -- this time for sure.


APICast.h, being private, ends up in a different folder than JSValueRef.h,
so we can't include one from the other using "". Instead, just forward
declare the relevant data types.

  • API/APICast.h:
10:54 AM Changeset in webkit [21309] by ggaren
  • 2 edits in trunk/JavaScriptCore

Build fix: export APICast.h for WebCore and WebKit.

10:41 AM Changeset in webkit [21308] by ap
  • 15 edits
    2 adds in trunk

Reviewed by Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=13480
window.Attr is undefined

Test: fast/dom/Window/attr-constructor.html

  • dom/Attr.idl:
  • dom/CDATASection.idl:
  • dom/CharacterData.idl:
  • dom/Comment.idl:
  • dom/DOMImplementation.idl:
  • dom/DocumentType.idl:
  • dom/Entity.idl:
  • dom/EntityReference.idl:
  • dom/Notation.idl:
  • dom/ProcessingInstruction.idl:
  • dom/Text.idl: Added GenerateConstructor.
  • page/DOMWindow.idl: Added constructor properties for DOM interfaces.
10:34 AM Changeset in webkit [21307] by ggaren
  • 13 edits
    1 add in trunk

WebCore:

Reviewed by Maciej Stachowiak.

Fixed <rdar://problem/5140447> API for fetching JSGlobalContextRef from
WebView or WebFrame


Added support for new -[WebScriptObject JSObject] and -[WebFrame globalContext]
APIs.


Also fixed some more cases of <rdar://problem/4395622> API:
WebScriptObject.h incorrectly reports that -isSelectorExcludedFromWebScript
returns NO by default, and generally cleaned up that documentation.

  • WebCore.exp: A lot of the diff here is from sorting.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/WebScriptObject.h:
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject JSObject]):
  • bindings/objc/WebScriptObjectPendingPublic.h: Added.

WebKit:

Reviewed by Maciej Stachowiak.


Fixed <rdar://problem/5140447> API for fetching JSGlobalContextRef from
WebView or WebFrame


Added -[WebFrame windowObject] and -[WebFrame globalContext], along with
a new frame load delegate method, - (void)webView:(WebView *)webView
didClearWindowObject:(WebScriptObject *)windowObject forFrame:(WebFrame *)frame.
This is all to support briding between the WebScriptObject and JavaScriptCore
APIs.

Also fixed more of <rdar://problem/4395622> API: WebScriptObject.h incorrectly
reports that -isSelectorExcludedFromWebScript returns NO by default, and
generally cleaned up the WebScriptObject headerdoc.

  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge windowObjectCleared]):
  • WebView/WebFrame.mm: (-[WebFrame windowObject]): (-[WebFrame globalContext]):
  • WebView/WebFramePrivate.h:
  • WebView/WebViewPrivate.h:

WebKitTools:

Reviewed by Maciej Stachowiak.


Added tests for new APIs: -[WebFrame windowObject], -[WebFrame globalContext],
and - (void)webView:(WebView *)webView didClearWindowObject:(WebScriptObject *)windowObject
forFrame:(WebFrame *)frame, in the form of ASSERTs.


  • DumpRenderTree/DumpRenderTree.m: (runJavaScriptThread): Fixed quote mismatch that prepare-changelog likes to complain about.

(-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]):
(-[WaitUntilDoneDelegate webView:didClearWindowObject:forFrame:]):

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
9:40 AM Changeset in webkit [21306] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5180384> webView:validateUserInterfaceItem:defaultValidation: does not get called on WebUIDelegates

Call the delegate when the one of our views gets a validateUserInterfaceItem: call.

  • WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Validate without the delegate. (-[WebHTMLView validateUserInterfaceItem:]): Call the delegate with the result of validateUserInterfaceItemWithoutDelegate:.
  • WebView/WebPDFView.mm: (-[WebPDFView validateUserInterfaceItemWithoutDelegate:]): Validate without the delegate. (-[WebPDFView validateUserInterfaceItem:]): Call the delegate with the result of validateUserInterfaceItemWithoutDelegate:.
  • WebView/WebView.mm: (-[WebView _responderValidateUserInterfaceItem:]): Call validateUserInterfaceItemWithoutDelegate: to prevent asking the delegate twice. (-[WebView validateUserInterfaceItemWithoutDelegate:]): Validate without the delegate. (-[WebView validateUserInterfaceItem:]): Call the delegate with the result of validateUserInterfaceItemWithoutDelegate:.
7:47 AM Changeset in webkit [21305] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2007-05-07 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Web Browser crashes when trying to browse to Hertz.com
​http://bugs.webkit.org/show_bug.cgi?id=13616

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::NodeTypeB):
7:35 AM Changeset in webkit [21304] by spadma
  • 2 edits in S60/trunk/WebKit

winship, reviewed by <reviewer>

DESC: KPOY-72NW5X - Memory Testing: Phone resets while running

browser memory testing. Return from foreground event
without processing if in performance mode

​http://bugs.webkit.org/show_bug.cgi?id=13589

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::ForegroundEvent):
7:31 AM Changeset in webkit [21303] by spadma
  • 10 edits
    2 adds in S60/trunk/WebKit

yaharon, reviewed by <reviewer>

DESC: S60 3.2 Touch: Scrolling initial implementatoin
​http://bugs.webkit.org/show_bug.cgi?id=13561

  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::ConstructTextEditorL):
  • BrowserView/inc/PointerEventHandler.h:
  • BrowserView/inc/ScrollingIndicatorDrawer.h: Added.
  • BrowserView/inc/WebKitView.h:
  • BrowserView/src/PointerEventHandler.cpp: (ContentScrollCallback): (CPointerEventHandler::~CPointerEventHandler): (CPointerEventHandler::HandlePointerEventL): (CPointerEventHandler::CheckSmartTextEntry): (CPointerEventHandler::GetFrameAt): (CPointerEventHandler::HandleScrollingPointerEventL): (CPointerEventHandler::HandleShouldStartScrollingL): (CPointerEventHandler::HandleDragL): (CPointerEventHandler::HandleContentScroll): (CPointerEventHandler::UpdateCursor):
  • BrowserView/src/ScrollingIndicatorDrawer.cpp: Added. (CScrollingIndicatorDrawer::NewL): (CScrollingIndicatorDrawer::CScrollingIndicatorDrawer): (CScrollingIndicatorDrawer::~CScrollingIndicatorDrawer): (CScrollingIndicatorDrawer::ConstructSprite): (CScrollingIndicatorDrawerEdge::CScrollingIndicatorDrawerEdge): (CScrollingIndicatorDrawerEdge::ConstructL): (CScrollingIndicatorDrawerEdge::~CScrollingIndicatorDrawerEdge): (CScrollingIndicatorDrawerEdge::UpdateBitmapPositionL): (CScrollingIndicatorDrawerEdge::CreateBitmapAndContextL): (CScrollingIndicatorDrawerEdge::UpdateMaskL): (CScrollingIndicatorDrawerAccelerated::CScrollingIndicatorDrawerAccelerated): (CScrollingIndicatorDrawerAccelerated::ConstructL): (CScrollingIndicatorDrawerAccelerated::~CScrollingIndicatorDrawerAccelerated): (CScrollingIndicatorDrawerAccelerated::UpdateBitmapPositionL): (CScrollingIndicatorDrawerAccelerated::CheckNeedRefrech): (CScrollingIndicatorDrawerAccelerated::CreateBitmapAndContextL): (CScrollingIndicatorDrawerAccelerated::UpdateMaskL): (CScrollingIndicatorDrawerAccelerated::UpdateMaskExL):
  • BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CursorUpdate):
  • BrowserView/src/WebKitView.cpp: (CWebKitView::ContentIsScrolling):
  • ChangeLog:
  • Plugin/inc/PluginWin.h:
  • Plugin/src/PluginWin.cpp: (CPluginWin::PluginConstructedL): (CPluginWin::ForceRedraw): (CPluginWin::HitRegionContains):
  • group/BrowserView.mmp:
7:05 AM Changeset in webkit [21302] by lars
  • 14 edits in trunk

Reviewed by Zack.

Adjust tests that have console output, now that it's added by
DumpRenderTree.

Dump JavaScript console messages as well. Also requires a slight
change in run-webkit-tests, so we still correctly differentiate
between text only and rendertree tests.

4:40 AM Changeset in webkit [21301] by lars
  • 15 edits
    5 adds in trunk/LayoutTestResults

Update the baseline for traversal/ and add a few missing results in
tables/

3:57 AM Applications using WebKit edited by joe@funkeemonk.com
Added listing to FunkeeStory (diff)
3:26 AM Changeset in webkit [21300] by lars
  • 3 edits in trunk/WebKitTools

Reviewed by Zack

Specify what the serif, sans-serif and monospace aliases
should map to and explicitly select the Gui style of
DRT to be plastique.

Fixes most of the test failures still seen on the build bot.

1:29 AM Changeset in webkit [21299] by lars
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix valgrind reported uninitialized memory read.

1:22 AM Changeset in webkit [21298] by justing
  • 3 edits
    12 adds in trunk

LayoutTests:

Reviewed by oliver


<rdar://problem/4895428> Can't drag selected ToDo

This tests to see that the focus of a focusable node
inside an already focused node is delayed until mouse up:

  • editing/selection/4895428-2-expected.checksum: Added.
  • editing/selection/4895428-2-expected.png: Added.
  • editing/selection/4895428-2-expected.txt: Added.
  • editing/selection/4895428-2.html: Added.


We delay focus until mouse up, but only if that node is
inside an already focused node:

  • editing/selection/4895428-3-expected.checksum: Added.
  • editing/selection/4895428-3-expected.png: Added.
  • editing/selection/4895428-3-expected.txt: Added.
  • editing/selection/4895428-3.html: Added.


This demonstrates the bug:

  • editing/selection/4895428-4-expected.checksum: Added.
  • editing/selection/4895428-4-expected.png: Added.
  • editing/selection/4895428-4-expected.txt: Added.
  • editing/selection/4895428-4.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/4895428> Can't drag selected ToDo


The user tries to drag a selection by mousing down
on the editable part of a ToDo, which is focusable,
since it is an editable node within non-editable
content. But we focus focusable elements on mouse
down, and focusing the editable piece blows away
the selection and prevents the drag. This is how
IE behaves, but content seems generally difficult
to drag in IE, so this doesn't make it any worse.


Since focus doesn't appear to be cancelable, either
with a DOM event or an editing delegate, I fixed this
by delaying the focus of focusable nodes that are
selected and inside an already focused node. The
node will be focused if the user mouses up without
doing any dragging because the mouse up sets a
selection, which calls setFocusNodeIfNeeded.

  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent):
1:07 AM Changeset in webkit [21297] by bdash
  • 4 edits in trunk

Versioning.

1:03 AM Changeset in webkit [21296] by bdash
  • 1 copy in tags/Safari-5522.7

New tag.

May 7, 2007:

10:41 PM Changeset in webkit [21295] by oliver
  • 2 edits in trunk/WebCore

2007-05-07 Atul Mehrotra <​atul.mehrotra@celunite.com>

Reviewed by Maciej.

GDK Build fix

  • platform/gdk/TemporaryLinkStubs.cpp:
9:59 PM Changeset in webkit [21294] by oliver
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test the behaviour of canvas methods called with inf/nan parameters

  • fast/canvas/canvas-with-incorrect-args-expected.txt: Added.
  • fast/canvas/canvas-with-incorrect-args.html: Added.

WebCore:

Reviewed by Maciej.

Correcting comparisons to handle NaN in the same manner
as other Canvas methods.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arcTo): (WebCore::CanvasRenderingContext2D::arc): Correcting arc/arcTo to match the WHAT WG draft. (WebCore::CanvasRenderingContext2D::rect): (WebCore::CanvasRenderingContext2D::clearRect): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::strokeRect):
5:57 PM Changeset in webkit [21293] by hyatt
  • 4 edits in trunk/WebCore

Add some comments to the glyph/font code (patch from MarvinD, tweaked by
me to correct a few bits and to make it forward-compatible with the work
going on in 3315.

Reviewed by me

  • ChangeLog:
  • platform/Font.cpp: (WebCore::Font::glyphDataForCharacter):
  • platform/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage):
  • platform/GlyphPageTreeNode.h:
4:55 PM Changeset in webkit [21292] by justing
  • 2 edits in trunk/WebCore

Fix layout test failures.

  • editing/SelectionController.cpp: (WebCore::SelectionController::contains): Use comparePositions instead of Range::comparePoint, because comparePositions can handle positions inside shadow trees.
4:37 PM Changeset in webkit [23347] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-05-07 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.

Fix typo in prefs code.

  • WebPreferences.cpp: (WebPreferences::preferencesPath): Fix typo in error handling.
4:01 PM Changeset in webkit [23346] by aliceli1
  • 5 edits
    2 adds in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fixed <rdar://5087119> Paste fidelity isn't as good as it is on the mac
and <rdar://5087118> Plain text copy/paste yields bad line endings on Boomer
and re-organized standalone functions in DragDataWin.cpp and PasteboardWin.cpp
into ClipboardUtilitiesWin.h/cpp.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/ClipboardUtilitiesWin.cpp: Added. (WebCore::cfHDropFormat): (WebCore::getWebLocData): (WebCore::extractURL): (WebCore::texthtmlFormat): (WebCore::createGlobalData): (WebCore::markupToCF_HTML): (WebCore::urlToMarkup): (WebCore::replaceNewlinesWithWindowsStyleNewlines): (WebCore::replaceNBSPWithSpace): (WebCore::urlWFormat): (WebCore::urlFormat): (WebCore::plainTextFormat): (WebCore::plainTextWFormat): (WebCore::filenameWFormat): (WebCore::filenameFormat): (WebCore::htmlFormat): (WebCore::getURL): (WebCore::getPlainText): (WebCore::fragmentFromFilenames): (WebCore::containsFilenames): (WebCore::fragmentFromCF_HTML): (WebCore::fragmentFromHTML): (WebCore::containsHTML):
  • platform/win/ClipboardUtilitiesWin.h: Added.
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::writeRange):
  • platform/win/DragDataWin.cpp:
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::documentFragment):
3:15 PM Changeset in webkit [21291] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/4895428> Can't drag selected To Do if it is not showing a due date

  • editing/selection/4895428-1-expected.checksum: Added.
  • editing/selection/4895428-1-expected.png: Added.
  • editing/selection/4895428-1-expected.txt: Added.
  • editing/selection/4895428-1.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/4895428> Can't drag selected To Do if it is not showing a due date


The code in SelectionController::contains returned false
incorrectly if the selection end just after a table
and the position was inside that table.

  • editing/SelectionController.cpp: (WebCore::SelectionController::contains): Compare the position with the ends of the selection and then use Range::comparePoint.
3:09 PM Changeset in webkit [21290] by beidson
  • 2 edits in trunk/WebKit

Actually finish the code move from my last checkin

  • History/WebHistoryItem.mm: (-[WebHistoryItem _transientPropertyForKey:]): (-[WebHistoryItem _setTransientProperty:forKey:]):
2:57 PM Changeset in webkit [21289] by beidson
  • 4 edits in trunk/WebKit

Rubberstamped by Kevin (Sarge)

Make _transientPropertyForKey: and _setTransientProperty:forKey: SPI

  • History/WebHistoryItemInternal.h:
  • History/WebHistoryItemPrivate.h:
1:23 PM Changeset in webkit [23345] by sfalken
  • 1 add in branches/WindowsMerge/WebCore/platform/win/TextBreakIteratorInternalICUWin.cpp

Forgot to check in this file.

10:25 AM Changeset in webkit [21288] by darin
  • 2 deletes in trunk/LayoutTests/fast/dom/HTMLElement

Removed files. Not sure why they didn't get removed before.

9:25 AM Changeset in webkit [21287] by darin
  • 4 edits in trunk

LayoutTests:

  • rolling out setInnerHTML optimization until I can figure out why tests are failing

WebCore:

  • rolling out setInnerHTML optimization until I can figure out why tests are failing
8:34 AM Changeset in webkit [21286] by brmorris
  • 1 edit
    1 delete in S60/trunk/LayoutTests

brmorris, reviewed by nobody

DESC: This is actually a resource file, not a test case.

  • fast/js/new-location.html: Removed.
8:04 AM Changeset in webkit [21285] by lars
  • 912 edits in trunk/LayoutTestResults

Reviewed by Zack.

New baseline for the table tests.
Skip the fast tests for now.

7:45 AM Changeset in webkit [21284] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/dom/HTMLElement/set-inner-outer-optimization-expected.txt: Added.
  • fast/dom/HTMLElement/set-inner-outer-optimization.html: Added.

WebCore:

Reviewed by Hyatt.

Optimize setInnerHTML, setOuterHTML, and setInnerText so they don't change the DOM at all
if they don't need to.

Test: fast/dom/HTMLElement/set-inner-outer-optimization.html

  • html/HTMLElement.cpp: (WebCore::equal): Added. Helper function that compares two Text nodes or two NamedAttrMap attribute maps. (WebCore::shallowEqual): Added. Helper function that compares two Element nodes or two arbitrary nodes. (WebCore::replaceChildrenWithFragment): Added. Helper function used by setInnerHTML and setInnerText. Optimizes the cases where all the nodes are the same, where both the current and the new content are single text nodes, and where the current content is a single node that can be replaced with replaceChild. (WebCore::replaceChildrenWithText): Added. Helper function used by setInnerText. Optimizes the case where the current content is a single text node or a single node that can be replaced with replaceChild. (WebCore::HTMLElement::setInnerHTML): Changed to call replaceChildrenWithFragment. (WebCore::HTMLElement::setOuterHTML): Added special case to optimize when the new content exactly matches the current node. (WebCore::HTMLElement::setInnerText): Changed to call replaceChildrenWithText in a few cases instead of doing removeChildren/appendChild. Changed code that was using DeprecatedString to instead use String. Changed general case to use a document fragment and replaceChildrenWithFragment.
  • dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent): Fixed bug where we would not dispatch the DOMSubtreeModified event unless someone was registered for the DOMCharacterDataModified event. Caused trouble in the test.
6:56 AM Changeset in webkit [21283] by lars
  • 8 edits
    6 adds in trunk

Change 5 results in css2.1 that were wrong due to a Qt bug.
Add css3 baseline.

Fix the default font in DRT to 9pt Sans Serif.

12:07 AM Changeset in webkit [21282] by lars
  • 486 edits in trunk/LayoutTestResults

New baseline for the css2.1 tests.

May 6, 2007:

8:07 PM Changeset in webkit [21281] by darin
  • 2 edits in trunk/WebCore
  • blind try at fixing the Qt build
  • platform/qt/TextBreakIteratorQt.cpp: (WebCore::sentenceBreakIterator): Added a placeholder.
8:03 PM Changeset in webkit [21280] by darin
  • 5 edits
    2 deletes in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/canvas/drawImage-with-invalid-args.html: Changed to a dumpAsText test. Added logging and a negative-size test.
  • fast/canvas/drawImage-with-invalid-args-expected.txt: Updated.
  • fast/canvas/drawImage-with-invalid-args-expected.checksum: Removed.
  • fast/canvas/drawImage-with-invalid-args-expected.png: Removed.

WebCore:

Reviewed by Hyatt.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): Don't raise an exception if the source or destination rectangle is empty.
7:57 PM Changeset in webkit [21279] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • fix <rdar://problem/4585593> REGRESSION: Some 2-byte characters in printed page header are drawn with too-large font and clipped

Doesn't affect text within web pages, so no layout test.

  • platform/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): Base the substitute font on the FontPlatformData rather than the FontDescription. Before, it was a mix of both. This works properly for fonts where we have no FontDescription and is also more internally consistent.
7:56 PM Changeset in webkit [21278] by darin
  • 12 edits in trunk/WebCore

Reviewed by Hyatt.

  • dom/Node.h: Made first/lastChild be inline functions that call virtual functions. This lets us hide the functions with another inline function in a derived class, yet still override the behavior here in the base class by overriding the virtual functions too.
  • dom/Node.cpp: (WebCore::Node::virtualFirstChild): Renamed virtual functions. There are now non-virtual inline functions that call these virtual functions. (WebCore::Node::virtualLastChild): Ditto.
  • dom/ContainerNode.h: Added non-virtual first/lastChild functions that hide the ones inherited from the Node class; these also replace the fastFirst/LastChild functions, and transparently give callers the faster form if they have a pointer of the right type. But still override the virtual functions named virtualFirst/LastChild, because those can still be called through a Node*. Removed the "fast" from the names of fastSetFirst/LastChild.
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::virtualFirstChild): Renamed virtual functions. There are now also non-virtual inline versions. (WebCore::ContainerNode::virtualLastChild): Ditto.
  • dom/CharacterData.cpp: Removed implementations of data and length functons.
  • dom/CharacterData.h: Made data, setData, length, substringData, appendData, insertData, deleteData, and replaceData all non-virtual, and made data and length both be inline.
  • dom/NamedAttrMap.h: (WebCore::NamedAttrMap::attributeItem): Removed a null check from this function. If the length of the map is known to be greater than 0, then the null check isn't needed. But if the length of the map hasn't been checked at all, then it's unsafe to call this function since it doesn't range check the array index. Thus the null check is never needed. I also looked at all callers.
  • dom/Attr.cpp: (WebCore::Attr::createTextChild):
  • dom/Document.cpp: (WebCore::Document::recalcStyle):
  • dom/Element.cpp: (WebCore::Element::recalcStyle):
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::haveLoadedRequiredResources): Removed "fast" prefix from calls to fastFirst/LastChild and fastSetFirst/LastChlld. It's not needed any more -- you still get fast behavior if the pointer has a type that's ContainerNode or derived from it.
7:36 PM Changeset in webkit [21277] by bdash
  • 3 edits in trunk

2007-05-06 Erik Bunce <​kde@bunce.us>

Reviewed by Mark Rowe.

  • WebKit.pri: Removed unnecessary dependency on MacPorts (/opt/local)

2007-05-06 Erik Bunce <​kde@bunce.us>

Reviewed by Mark Rowe.

  • WebCore.pro: Removed unnecessary dependency on MacPorts (/opt/local)
9:42 AM Changeset in webkit [21276] by ap
  • 4 edits
    4 adds in trunk

2007-05-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Test: fast/css-generated-content/positioned-background-hit-test-crash.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::enclosingElement): Added. Factored out of hitTestLayer(). (WebCore::RenderLayer::hitTestLayer): Implemented the fix for <rdar://problem/3552346> from r6106 to the self hit test as well, namely: return the enclosing element for generated positioned content.
  • rendering/RenderLayer.h:
9:05 AM Changeset in webkit [21275] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13584
<script> code wrongly assumes requests can't fail

Test: fast/loader/unloadable-script.html

  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::parseMappedAttribute): (WebCore::HTMLScriptElement::insertedIntoDocument): Check the return value of requestScript().
Note: See TracTimeline for information about the timeline view.