Timeline
Jun 29, 2007:
- 8:37 PM Changeset in webkit [23896] by
-
- 4 edits6 adds in branches/wx-port-alpha/trunk
Adding wxPython bindings for wxWebKit.
- 8:35 PM Changeset in webkit [23895] by
-
- 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.make
Build fix.
- 2:56 PM Changeset in webkit [23894] by
-
- 7 edits1 add1 delete in trunk
LayoutTests:
Reviewed by Harrison.
<rdar://problem/5299513> REGRESSION: In Mail, a crash occurs when attempting to undo a newly created To Do
Backing out a change made in r23787.
- editing/deleting/4845371-expected.txt:
- editing/deleting/4845371.html:
- editing/deleting/5126166-expected.txt:
- editing/deleting/5290534.html: Removed.
- editing/deleting/5290534.html-disabled: Added.
WebCore:
Reviewed by Harrison.
<rdar://problem/5299513> REGRESSION: In Mail, a crash occurs when attempting to undo a newly created To Do
Rolled out a change made in r23787.
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete):
- 2:45 PM Changeset in webkit [23893] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by Darin Adler, Anders Carlsson.
Test for <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML
returns NULL if response MIME type is not XML -- breaks Wikipedia widget
- fast/loader/xmlhttprequest-bad-mimetype-expected.txt: Added.
- fast/loader/xmlhttprequest-bad-mimetype.html: Added.
WebCore:
Reviewed by Darin Adler, Anders Carlsson.
Fixed <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML
returns NULL if response MIME type is not XML -- breaks Wikipedia widget
The spec says that responseXML must return null for any HTTP response
with a non-XML MIME type. Technically, that leaves non-HTTP responses
free to do whatever they want.
- xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseXML): Only return null for non-XML MIME types if the response was HTTP.
- 2:36 PM Changeset in webkit [23892] by
-
- 12 edits in trunk
Reviewed by Darin.
Second pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/5292262>
- Add a toFloat() method to JSValue for float conversion.
- JavaScriptCore.exp:
- kjs/value.cpp: (KJS::JSValue::toFloat):
- kjs/value.h:
WebCore:
Reviewed by Darin.
Second pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/5292262>
- Use new JSValue::toFloat() method instead of toNumber() where appropriate.
- bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::setFillColor): (WebCore::JSCanvasRenderingContext2D::setStrokeColor): (WebCore::JSCanvasRenderingContext2D::strokeRect): (WebCore::JSCanvasRenderingContext2D::drawImage): (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): (WebCore::JSCanvasRenderingContext2D::setShadow):
- bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::remove):
- bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::rotateFromVector):
- bindings/js/kjs_events.cpp: (KJS::JSClipboardPrototypeFunction::callAsFunction):
- bindings/scripts/CodeGeneratorJS.pm:
- ksvg2/svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::executeScript):
- 2:29 PM Changeset in webkit [23891] by
-
- 4 edits8 deletes in trunk
LayoutTests:
Rolling out tests for <rdar://problem/5301322>.
- fast/forms/input-readonly-select-all-expected.checksum: Removed.
- fast/forms/input-readonly-select-all-expected.png: Removed.
- fast/forms/input-readonly-select-all-expected.txt: Removed.
- fast/forms/input-readonly-select-all.html: Removed..
- fast/forms/textarea-readonly-select-all-expected.checksum: Removed.
- fast/forms/textarea-readonly-select-all-expected.png: Removed.
- fast/forms/textarea-readonly-select-all-expected.txt: Removed.
- fast/forms/textarea-readonly-select-all.html: Removed.
WebCore:
Rolling out fix for <rdar://problem/5301322> since it broke layout tests.
- html/HTMLInputElement.h:
- html/HTMLTextAreaElement.h:
- 1:51 PM Changeset in webkit [23890] by
-
- 2 edits3 adds in S60/branches/3.1m/WebKit
brad, reviewed by sachin
DESC: merge of r23888 to 3.1 (generate browserversiongenerated.bat + about:version )
This is part of IAD.
- ResourceLoader/src/AboutTransaction.cpp: (CAboutTransaction::DoSubmitL):
- data/version.txt: Added.
- group/version.mk: Added.
- group/versiontext.bat: Added.
- 1:37 PM Changeset in webkit [23889] by
-
- 4 edits2 adds in trunk
LayoutTests:
Reviewed by Oliver Hunt.
Layout tests for <rdar://problem/4962298> REGRESSION: Synchronous XHR for
missing local file throws exception -- breaks Wikipedia widget
- fast/loader/xmlhttprequest-missing-file-exception-expected.txt: Added.
- fast/loader/xmlhttprequest-missing-file-exception.html: Added.
WebCore:
Reviewed by Oliver Hunt.
Fixed <rdar://problem/4962298> REGRESSION: Synchronous XHR for missing
local file throws exception -- breaks Wikipedia widget
- WebCore.xcodeproj/project.pbxproj:
- xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): Don't throw exceptions for local files.
- 1:35 PM Changeset in webkit [23888] by
-
- 3 edits3 adds in S60/trunk/WebKit
brad, reviewed by sachin
DESC: generate browserversiongenerated.bat + about:version
- ResourceLoader/src/AboutTransaction.cpp: (CAboutTransaction::DoSubmitL):
- data/version.txt: Added.
- group/bld.inf:
- group/version.mk: Added.
- group/versiontext.bat: Added.
- 1:28 PM Changeset in webkit [23887] by
-
- 2 edits in S60/trunk/WebKit
2007-06-29 Vikram Malaiya, reviewed by Sachin
DESC: YDAI-73QAL9 - Browser does not render any content from a data:URL.
http://bugs.webkit.org/show_bug.cgi?id=14436
- ResourceLoader/src/DataTransaction.cpp: (CDataTransaction::CreateHeaderResponseLC):
- 12:38 PM Changeset in webkit [23886] by
-
- 2 edits in S60/branches/3.1m/WebKit
ligman, reviewed by <reviewer>
DESC: The pluginloader does not handle top level loads correctly when the plugin is in an iframe. Always load page from the MainFrame.
http://bugs.webkit.org/show_bug.cgi?id=14447
- Plugin/src/PluginLoader.cpp: (CPluginLoader::LoadPluginContentL):
- 12:29 PM Changeset in webkit [23885] by
-
- 3 edits in S60/branches/3.1m/MemoryManager
2007-06-29 yongjzha <yongjun.zhang@nokia.com>
Reviewed by Zalan.
DESC: implement mmanp & munmap in Symbian OS.
http://bugs.webkit.org/show_bug.cgi?id=14461
- Group/MemMan.mmp:
- Src/fast_malloc.cpp: (fast_set_rescue_buffer_size): (release_rescue_buffer): (alloc_rescue_buffer): (chunkMoreCore): (symbian_mmap): (symbian_munmap): (log_abort): (fast_pre_check): (fast_post_check):
- 12:27 PM Changeset in webkit [23884] by
-
- 7 edits in S60/trunk
hongzhao, reviewed by <Yongjun.zhang@nokia.com>
DESC: Video continue to play after closing the page view.
http://bugs.webkit.org/show_bug.cgi?id=14434
- WebKit/BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
- WebKit/BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL):
- WebKit/BrowserView/inc/WebKitFrame.h:
- WebKit/BrowserView/src/WebKitFrame.cpp: (CWebKitFrame::RemovePluginWin):
- WebKit/Plugin/inc/PluginSkin.h:
- WebKit/Plugin/src/PluginSkin.cpp: (CPluginSkin::RemovePluginWin):
- 12:22 PM Changeset in webkit [23883] by
-
- 2 edits in trunk/WebCore
2007-06-29 Ada Chan <adachan@apple.com>
Reviewed by Adam.
Fixed a previous fix to a signed/unsigned mismatch.
- plugins/win/PluginPackageWin.cpp: (WebCore::splitString):
- 12:22 PM Changeset in webkit [23882] by
-
- 18 edits in S60/trunk
yongjzha, reviewed by Zalan
DESC: Implement Linux-like mmap and munmap in Symbian OS
http://bugs.webkit.org/show_bug.cgi?id=14461
- Group/MemMan.mmp:
- Src/fast_malloc.cpp: (free_memory): (fast_set_rescue_buffer_size): (release_rescue_buffer): (alloc_rescue_buffer): (chunkMoreCore): (symbian_mmap): (symbian_munmap): (log_abort): (fast_pre_check): (fast_post_check):
- 11:15 AM Changeset in webkit [23881] by
-
- 4 edits8 adds in trunk
LayoutTests:
Reviewed by Ada and Kevin McCullough.
Test for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas
- fast/forms/input-readonly-select-all-expected.checksum: Added.
- fast/forms/input-readonly-select-all-expected.png: Added.
- fast/forms/input-readonly-select-all-expected.txt: Added.
- fast/forms/input-readonly-select-all.html: Added.
- fast/forms/textarea-readonly-select-all-expected.checksum: Added.
- fast/forms/textarea-readonly-select-all-expected.png: Added.
- fast/forms/textarea-readonly-select-all-expected.txt: Added.
- fast/forms/textarea-readonly-select-all.html: Added.
WebCore:
Reviewed by Ada and Kevin McCullough.
Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas
Implemented canSelectAll and selectAll for text fields and textareas, since they're special cases even when they're not editable.
Tests:
fast/forms/input-readonly-select-all.html
fast/forms/textarea-readonly-select-all.html
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::canSelectAll): (WebCore::HTMLInputElement::selectAll):
- html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::canSelectAll): (WebCore::HTMLTextAreaElement::selectAll):
- 10:58 AM Changeset in webkit [23880] by
-
- 2 edits in trunk/WebCore
Build fix
This is what happens when you test your patch on two OSs and then
commit from the wrong one.
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::valueChanged):
(WebCore::RenderTextControl::itemText):
(WebCore::RenderTextControl::itemIsSeparator):
- 10:50 AM Changeset in webkit [23879] by
-
- 2 edits in trunk/WebCore
Start compiling WebCore with /W3 under MSVC
One warning was globally disabled: implicit conversion of int to bool.
Reviewed by Darin.
- WebCore.vcproj/WebCore.vcproj:
- 10:50 AM Changeset in webkit [23878] by
-
- 3 edits in trunk/WebCore
Turn DeprecatedStringData's copy constructor into a static method to appease MSVC /W3
DeprecatedStringData now has no public copy constructor. The single
call to the old one has been replaced with a call to the new
DeprecatedStringData::createAndAdopt static method.
Reviewed by Darin.
All regression tests pass.
- platform/DeprecatedString.cpp:
(WebCore::DeprecatedStringData::createAndAdopt):
(WebCore::DeprecatedStringData::adopt):
(WebCore::DeprecatedString::detachIfInternal):
- platform/DeprecatedString.h:
- 10:50 AM Changeset in webkit [23877] by
-
- 9 edits in trunk/WebCore
Fix more signed/unsigned mismatches uncovered by MSVC /W3
Reviewed by John.
No regression tests possible.
- platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::filenameHasSaneExtension):
- platform/win/FontDataWin.cpp:
(WebCore::FontData::containsCharacters):
- platform/win/PlatformScrollBarSafari.cpp:
(WebCore::):
- platform/win/UniscribeController.cpp:
(WebCore::UniscribeController::advance):
(WebCore::UniscribeController::shapeAndPlaceItem):
- platform/win/WebCoreTextRenderer.cpp:
(WebCore::doDrawTextAtPoint):
- plugins/win/PluginDatabaseWin.cpp:
(WebCore::parseVersionString):
- plugins/win/PluginPackageWin.cpp:
(WebCore::splitString):
- plugins/win/PluginViewWin.cpp:
(WebCore::freeStringArray):
(WebCore::PluginViewWin::invalidateTimerFired):
- 10:50 AM Changeset in webkit [23876] by
-
- 8 edits in trunk/WebCore
Change PopupMenuClient::listSize to return an int to appease warnings from MSVC /W3
Reviewed by John.
No regression test possible.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
- platform/PopupMenuClient.h:
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::calculatePositionAndSize):
(WebCore::PopupMenu::focusFirst):
(WebCore::PopupMenu::focusLast):
(WebCore::PopupMenu::down):
(WebCore::PopupMenu::up):
(WebCore::PopupMenu::paint):
- rendering/RenderMenuList.cpp:
- rendering/RenderMenuList.h:
- rendering/RenderTextControl.cpp:
- rendering/RenderTextControl.h:
- 10:50 AM Changeset in webkit [23875] by
-
- 3 edits in trunk/WebCore
Fix two typos spotted by MSVC /W3
Both typos were a semicolon following the condition of an if. This
would cause the intended body of the if to always execute.
Unfortunately neither of these fixes are testable.
BackForwardList::goForward is only called from WebBackForwardList, and
the createDragImageFromImage bug would only manifest itself when
CreateCompatibleDC failed.
Reviewed by Mark.
- history/BackForwardList.cpp:
(WebCore::BackForwardList::goForward):
- platform/win/DragImageWin.cpp:
(WebCore::createDragImageFromImage):
- 7:19 AM Changeset in webkit [23874] by
-
- 2 edits in trunk/WebCore
Patch from Adam Treat to improve scroll wheel support for Qt.
- 6:28 AM Changeset in webkit [23873] by
-
- 2 edits in branches/feature-branch/WebKitTools
Add VIDEO build flag
- 6:26 AM Changeset in webkit [23872] by
-
- 2 edits85 adds in branches/feature-branch/LayoutTests
Basic tests for <video> and <audio>
- 6:25 AM Changeset in webkit [23871] by
-
- 32 edits9 copies22 adds in branches/feature-branch/WebCore
Support for HTML5 <video> and <audio> elements
- 6:25 AM Changeset in webkit [23870] by
-
- 6 edits in branches/feature-branch
Squashed commit of the following:
commit 0116a51745ee1ebe9a03ac3101f4c19f77e7459c
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 15:30:25 2007 +0300
delete video/
commit a31e7f20d0d6859853d414ddbeaf687f646768eb
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 15:21:12 2007 +0300
update ChangeLog
commit a918e88bf5b4b335d391975ff623e4b2d7981378
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 15:17:36 2007 +0300
move layout tests to media directory
commit 18d7cc5037909ded7f886fff4dde1d07e442120b
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 15:08:16 2007 +0300
add new window properties to test case
commit 59d0817997df6997a58ae807385c3cf107933025
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 15:06:43 2007 +0300
Implement review comments
commit 5fc7dcc6e943ae71f49ae5b9604094fa1b63036d
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 14:10:32 2007 +0300
Squashed commit of the following:
commit 3e7ca5b62c8106a3e5585e8f6a8bbb8a680f7b58
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:12:20 2007 +0300
use WebCoreSystemInterface for SPIs
random fixes
commit e32105832dbe42f1f5b7f173906fd7ee40c2cc79
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:11:34 2007 +0300
update ChangeLog
commit 621efda557bdaf8c670c60b2678ba205daab5d16
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:09:14 2007 +0300
SPIs
commit 9b2f4e7f72c3ca3e407d1cf7e3888a05e4abd418
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:21:50 2007 +0300
merge
commit 18d2a487635dae8bc61afe86e4520368074dd7f4
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 28 23:36:56 2007 +0300
Update ChangeLog
commit 919dc27a8de220ba934c4e2df88c4aa0ea621b10
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 28 23:35:59 2007 +0300
Use +/-inf for empty and deleted float hash keys
commit 109e1820d84d005c7d16bcbe15ed16ea720a7d27
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 17:53:11 2007 -0700
use SPI instead of private QTKit headers
commit 1987e31a5782f53b553a7c93f3c35048d85152f5
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 17:52:07 2007 -0700
- add test video without audio track
- more tolerant test cases
commit 51f34157309633502e76f157e374599313e4eb3f
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 15:25:37 2007 -0700
looser timing for test
commit 2735133a86c81cf71c67f293e7a1764ee3663f24
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 14:49:10 2007 -0700
fix int->float time conversion bug
fix cue point at 0
commit e6fd255201421644296841457c23ac023f03c262
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 13:28:56 2007 -0700
Update tests
commit 89cedff67fc5306980913b2f4cc321e8e6361ada
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 00:46:32 2007 -0700
update test files
commit 7d8923712a21ce09fb01806ceb333966c74565fb
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 00:35:59 2007 -0700
new test files
commit f1650455847033298087c2752288fb8843eda6e0
Author: Antti Koivisto <Antti Koivisto>
Date: Wed Jun 20 17:58:36 2007 -0700
fix float hash
commit 88ca8d32e2268342ad62611a4ed8c7a52dfbf65a
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 21:50:51 2007 -0700
don't crash with empty idl interfaces
commit cc54f83f5da73cd3ac04990cb5d310c5fa685074
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 21:48:42 2007 -0700
add test video
commit 478d0bc891a69d8862cdd79cadbe596bc39c1999
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 17:21:18 2007 -0700
tests
commit f647bef8037665128ed8985e6b9d12578ec8e7a6
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 16:53:29 2007 -0700
Some more files
commit 0fc70d1b08149d695b95ed3069a8774140308ddc
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 16:52:18 2007 -0700
Import video to feature branch
commit 3e7ca5b62c8106a3e5585e8f6a8bbb8a680f7b58
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:12:20 2007 +0300
use WebCoreSystemInterface for SPIs
random fixes
commit e32105832dbe42f1f5b7f173906fd7ee40c2cc79
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:11:34 2007 +0300
update ChangeLog
commit 621efda557bdaf8c670c60b2678ba205daab5d16
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:09:14 2007 +0300
SPIs
commit 9b2f4e7f72c3ca3e407d1cf7e3888a05e4abd418
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:21:50 2007 +0300
merge
commit 18d2a487635dae8bc61afe86e4520368074dd7f4
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 28 23:36:56 2007 +0300
Update ChangeLog
commit 919dc27a8de220ba934c4e2df88c4aa0ea621b10
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 28 23:35:59 2007 +0300
Use +/-inf for empty and deleted float hash keys
commit 109e1820d84d005c7d16bcbe15ed16ea720a7d27
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 17:53:11 2007 -0700
use SPI instead of private QTKit headers
commit 1987e31a5782f53b553a7c93f3c35048d85152f5
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 17:52:07 2007 -0700
- add test video without audio track
- more tolerant test cases
commit 51f34157309633502e76f157e374599313e4eb3f
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 15:25:37 2007 -0700
looser timing for test
commit 2735133a86c81cf71c67f293e7a1764ee3663f24
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 14:49:10 2007 -0700
fix int->float time conversion bug
fix cue point at 0
commit e6fd255201421644296841457c23ac023f03c262
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 13:28:56 2007 -0700
Update tests
commit 89cedff67fc5306980913b2f4cc321e8e6361ada
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 00:46:32 2007 -0700
update test files
commit 7d8923712a21ce09fb01806ceb333966c74565fb
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 00:35:59 2007 -0700
new test files
commit f1650455847033298087c2752288fb8843eda6e0
Author: Antti Koivisto <Antti Koivisto>
Date: Wed Jun 20 17:58:36 2007 -0700
fix float hash
commit 88ca8d32e2268342ad62611a4ed8c7a52dfbf65a
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 21:50:51 2007 -0700
don't crash with empty idl interfaces
commit cc54f83f5da73cd3ac04990cb5d310c5fa685074
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 21:48:42 2007 -0700
add test video
commit 478d0bc891a69d8862cdd79cadbe596bc39c1999
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 17:21:18 2007 -0700
tests
commit f647bef8037665128ed8985e6b9d12578ec8e7a6
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 16:53:29 2007 -0700
Some more files
commit 0fc70d1b08149d695b95ed3069a8774140308ddc
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 16:52:18 2007 -0700
Import video to feature branch
- 1:18 AM Changeset in webkit [23869] by
-
- 3 edits in trunk/WebKitLibraries
Reviewed by Maciej.
Added WKQTMovieDataRate and WKQTMovieMaxTimeLoaded
- WebKitSystemInterface.h:
- libWebKitSystemInterface.a:
Jun 28, 2007:
- 10:49 PM Changeset in webkit [23868] by
-
- 7 edits in trunk/WebCore
Get WebCore compiling with /W2 on Windows
Reviewed by Steve.
No regression tests affected.
- WebCore.vcproj/WebCore.vcproj: Turn the warning level up to 2, and
disable two warnings: implicit int <=> float conversion, and class vs.
struct inconsistency.
- dom/CharacterData.cpp:
(WebCore::CharacterData::deleteData): Cast to int before negating.
- loader/Cache.cpp:
(WebCore::Cache::remove): Ditto.
- platform/graphics/Path.cpp:
(WebCore::pathLengthApplierFunction): Consistently use floats.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawEllipse): Ditto.
- platform/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Ditto.
- 9:16 PM Changeset in webkit [23867] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej Stachowiak.
Fixed <rdar://problem/5299005> DOM timers fire without a local autorelease
pool => pathologically high high water mark
I couldn't measure any performance problems with iBench HTML or PLT.
- WebCore.xcodeproj/project.pbxproj: Changed .cpp file to be ObjC++.
- platform/mac/SharedTimerMac.cpp: (WebCore::timerFired): Added autorelease pool.
- 7:46 PM Changeset in webkit [23866] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by Beth.
- test for http://bugs.webkit.org/show_bug.cgi?id=14118 ASSERTION FAILED: !needsLayout() seen again
- fast/dynamic/recursive-layout-expected.txt: Added.
- fast/dynamic/recursive-layout.html: Added.
WebCore:
Reviewed by Beth.
- fix http://bugs.webkit.org/show_bug.cgi?id=14118 ASSERTION FAILED: !needsLayout() seen again
Test: fast/dynamic/recursive-layout.html
- page/FrameView.cpp: (WebCore::FrameView::layout): Removed the midLayout guards around the calls to invalidateSelection() and updateWidgetPositions(). Those calls may dirty the layout, but in that case they also update it, so they should be allowed to do it. Added an ASSERT to make sure that when they return, the root is not marked for layout.
- 6:05 PM Changeset in webkit [23865] by
-
- 4 edits in trunk/WebKitTools
Reviewed by Adam,
Allow tests to use pre-built roots instead of building the tests.
- Scripts/run-javascriptcore-tests: added --root option
- Scripts/run-webkit-tests: added --root option
- Scripts/webkitdirs.pm: added support for using a root
- 5:06 PM Changeset in webkit [23864] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin.
<rdar://problem/5287569> WEBVIEW: Creating a webview in IB 3.0 (v2.0) NIB later crashes Interface Builder 2.5.4 on Tiger
Prevent encoding any of the WebView subviews. The subviews are ignored by -[WebView initWithCoder:] and will be recreated.
The Tiger 2.0 code crashed when the WebView released the subviews in initWithCoder:, so now there are no subviews to release.
This never happened before because the Tiger 2.0 code and IB wouldn't encode a WebView that has a WebHTMLView.
- WebView/WebView.mm: (-[WebView encodeWithCoder:]):
- 4:02 PM Changeset in webkit [23863] by
-
- 3 edits4 deletes in trunk
LayoutTests:
Rubberstamped by Adam Roben.
Roll out r23861. It caused the buildbot to fail on intel.
- http/tests/navigation/goBack-blank-tab-page-expected.txt: Removed.
- http/tests/navigation/goBack-blank-tab-page.html: Removed.
- http/tests/navigation/resources/before-go-back.html: Removed.
- http/tests/navigation/resources/will-go-back.html: Removed.
WebCore:
Rubberstamped by Adam Roben.
Roll out r23861. It caused the buildbot to fail on intel.
- page/Page.cpp: (WebCore::Page::goToItem):
- 2:57 PM Changeset in webkit [23862] by
-
- 3 edits in branches/feature-branch/JavaScriptCore
Reviewed by Maciej.
Use intHash to hash floats and doubles too.
- ChangeLog:
- wtf/HashFunctions.h: (WTF::FloatHash::hash): (WTF::FloatHash::equal): (WTF::):
- wtf/HashTraits.h: (WTF::FloatHashTraits::emptyValue): (WTF::FloatHashTraits::deletedValue): (WTF::):
- 2:08 PM Changeset in webkit [23861] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Geoff.
Tests for http://bugs.webkit.org/show_bug.cgi?id=13038
ASSERTION FAILED: item->target().isEmpty() m_mainFrame->tree()->find(item->target()) == m_mainFrame Although the test works with the script, it can't detect an eventually
error automatically since the first link must be opened in a new tab with
a _blank target to reproduce the crash. So it should be launched manually
following the steps decribed in there, then it's effective.
- http/tests/navigation/goBack-blank-tab-page-expected.txt: Added.
- http/tests/navigation/goBack-blank-tab-page.html: Added.
- http/tests/navigation/resources/before-go-back.html: Added.
- http/tests/navigation/resources/will-go-back.html: Added.
WebCore:
Reviewed by Geoff.
Patch for http://bugs.webkit.org/show_bug.cgi?id=13038
ASSERTION FAILED: item->target().isEmpty() m_mainFrame->tree()->find(item->target()) == m_mainFrame Modification of an ASSERT on goToItem related to go back/forward in
history.Don't need to check the frameset if the target is _blank.
- page/Page.cpp: (WebCore::Page::goToItem):
- 1:16 PM Changeset in webkit [23860] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Tabs are bad
- 1:13 PM Changeset in webkit [23859] by
-
- 2 edits in trunk/LayoutTests
Remove tests that don't need to be skipped anymore.
- win/Skipped:
- 1:05 PM Changeset in webkit [23858] by
-
- 2 edits in S60/trunk/WebKit
ligman, reviewed by <reviewer>
DESC: The pluginloader does not handle top level loads correctly when the plugin is in an iframe. Always load page from the MainFrame.
http://bugs.webkit.org/show_bug.cgi?id=14447
- Plugin/src/PluginLoader.cpp: (CPluginLoader::LoadPluginContentL):
- 12:46 PM Changeset in webkit [23857] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver.
<rdar://problem/5234139>
<object> with PNG src rendered as image document.
Complete the URL before passing it to the frame loader client.
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::isImageType):
- 11:48 AM Changeset in webkit [23856] by
-
- 7 edits in S60/trunk
2007-06-27 Prashanth Narayanaswamy <prashanth.narayanaswamy@nokia.com>
Reviewed by Sachin Padma.
DESC: SKWK-745NC7 - On going download files from Browser can be seen in Music Shop
- WebKit\ResourceLoader\inc\LoaderContainer.h: (CLoaderContainer::SetDownloadAppClientUID): new function for storing App UID in LoaderContainer (CLoaderContainer::DownloadAppClientUID): new function for retrieving App UID from LoaderContainer (CLoaderContainer::iDownloadClientAppUID): TUid instance for storing App Uid
- WebKit\ResourceLoader\src\LoaderContainer.cpp: (CLoaderContainer::ConstructL): initialized iDownloadClientAppUID with default browser Uid - KCRUidBrowser
- WebKit\ResourceLoader\src\HttpDownloadObserver.cpp: (CHttpDownloadObserver::InitDownloadMgrL): while connecting to download manager server, use the application Uid which is passed by the client, instead of always using Browser's App Uid
- WebKit\BrowserView\src\WebKitControl.cpp (CWebKitControl::SetBrowserSettingL): Store the Application Uid in LoaderContainer
- 9:59 AM Changeset in webkit [23855] by
-
- 5 edits in trunk/LayoutTests
Forgot committing this change in my previous commit.
- 9:00 AM Changeset in webkit [23854] by
-
- 11 edits4 adds in trunk
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=14373
CSS1: selectors (classes and IDs) cannot start with a dash or with a digit
Make sure the id selector validates against the CSS2.1 identfier
definition, not the hexcolor/HASH definition.
- 7:44 AM Changeset in webkit [23853] by
-
- 3 edits in trunk/WebKitQt
Propagate mouse double click events from Qt to WebCore.
- 7:16 AM Changeset in webkit [23852] by
-
- 4 edits in trunk/WebKitQt
Implemented clipboard functions in QWebPage, in particular can(Cut|Copy|Paste), cut/copy/paste as slot as well as a selectionChanged() signal.
- 7:16 AM Changeset in webkit [23851] by
-
- 2 edits in trunk/WebCore
Implemented PasteboardQt::writeSelection to copy the selected text into the Clipboard as well as PasteboardQt::plainText to retrieve plain text from the clipboard for pasting for example into form fields.
- 6:54 AM Changeset in webkit [23850] by
-
- 15 edits in trunk
LayoutTests:
Reviewed by Mitz.
Test changes for http://bugs.webkit.org/show_bug.cgi?id=14332
Bug 14332: REGRESSION (r21145): <td> width ignored
<rdar://problem/5290123>
- expand empty-cells.html to cover non-zero cellpadding case too
- update other related tests (none of these affect pixel results)
- fast/css/acid2-expected.txt:
- fast/css/acid2-pixel-expected.txt:
- fast/table/032-expected.txt:
- fast/table/empty-cells-expected.checksum:
- fast/table/empty-cells-expected.png:
- fast/table/empty-cells-expected.txt:
- fast/table/empty-cells.html:
- fast/table/empty-section-crash-expected.txt:
- http/tests/misc/acid2-expected.txt:
- http/tests/misc/acid2-pixel-expected.txt:
- tables/mozilla/bugs/bug222467-expected.txt:
- tables/mozilla/bugs/bug78162-expected.txt:
WebCore:
Reviewed by Mitz.
Fix http://bugs.webkit.org/show_bug.cgi?id=14332
Bug 14332: REGRESSION (r21145): <td> width ignored
<rdar://problem/5290123>
Cells in table with non-zero cellpadding are not considered empty.
- rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn):
- 1:58 AM Changeset in webkit [23849] by
-
- 4 edits4 adds in branches/feature-branch
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=14241
SVG <image> with height or width less than 1 fails to render image
Keep extra member vars to get width/height as floats for accurate
calculations.
- 12:48 AM Changeset in webkit [23848] by
-
- 2 edits in trunk/WebCore
Fix <rdar://problem/5300455> Prefast: typo in RenderBlock::paintObject
Reviewed by Hyatt.
No layout test possible, as this bug didn't have any effect since
"bool & bool" has the same value as "bool && bool"
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject): Changed & to &&.
- 12:30 AM Changeset in webkit [23847] by
-
- 3 edits2 adds in trunk
Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value
WebCore:
Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value
The bug was caused by two typos found by prefast.
Reviewed by Hyatt.
- css/cssparser.cpp: (WebCore::CSSParser::parseValue): Fixed typos.
LayoutTests:
New test for <rdar://problem/5300443> word-break and -webkit-user-modify allow any value
Reviewed by Hyatt.
- fast/css/word-break-user-modify-allowed-values-expected.txt: Added.
- fast/css/word-break-user-modify-allowed-values.html: Added.
Jun 27, 2007:
- 11:53 PM Changeset in webkit [23846] by
-
- 4 edits3 adds in trunk
Reviewed by Darin.
- <rdar://problem/5271937> REGRESSION: Apparent WebKit JavaScript memory smasher when submitting comment to iWeb site (crashes in kjs_pcre_compile2)
- Correctly evaluate the return value of _pcre_ucp_findchar.
- pcre/pcre_compile.c: (compile_branch):
- pcre/pcre_exec.c: (match):
LayoutTests:
Reviewed by Darin.
- <rdar://problem/5271937> REGRESSION: Apparent WebKit JavaScript memory smasher when submitting comment to iWeb site (crashes in kjs_pcre_compile2)
- Correctly evaluate the return value of _pcre_ucp_findchar.
- fast/js/regexp-unicode-overflow-expected.txt: Added.
- fast/js/regexp-unicode-overflow.html: Added.
- fast/js/resources/regexp-unicode-overflow.js: Added.
- 11:18 PM Changeset in webkit [23845] by
-
- 2 edits in trunk/WebCore
2007-06-20 Matt Perry <mpComplete@gmail.com>
Reviewed by Adam.
- Fix http://bugs.webkit.org/show_bug.cgi?id=14251: onchange handler for select controls doesn't fire when changing via keyboard
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Got rid of a call to saveLastSelection in the "Enter" key handler for select controls that was preventing onchange from firing.
- 11:01 PM Changeset in webkit [23844] by
-
- 1 edit in trunk/WebCore/page/DOMSelection.cpp
Yet another build fix :(
- 10:32 PM Changeset in webkit [23843] by
-
- 3 edits in trunk/WebCore
Fix Gdk, Qt, and Win32 builds.
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- 10:25 PM Changeset in webkit [23842] by
-
- 12 edits3 adds in trunk
LayoutTests:
Reviewed by Geoff.
Update tests for http://bugs.webkit.org/show_bug.cgi?id=14319
Move the Selection object out of the JS bindings
- fast/dom/Window/window-properties-expected.txt:
- fast/js/toString-and-valueOf-override-expected.txt:
- http/tests/security/cross-frame-access-expected.txt:
WebCore:
Reviewed by Geoff.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14319
Move the Selection object out of the JS bindings
- Renames JS Object Selection to DOMSelection to avoid a name conflict.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::mark): (KJS::Window::clearHelperObjectProperties): (KJS::WindowFunc::callAsFunction): (KJS::Window::disconnectFrame):
- bindings/js/kjs_window.h: (KJS::Window::):
- page/DOMSelection.cpp: Added. (WebCore::DOMSelection::DOMSelection): (WebCore::DOMSelection::frame): (WebCore::DOMSelection::disconnectFrame): (WebCore::DOMSelection::anchorNode): (WebCore::DOMSelection::baseNode): (WebCore::DOMSelection::anchorOffset): (WebCore::DOMSelection::baseOffset): (WebCore::DOMSelection::focusNode): (WebCore::DOMSelection::extentNode): (WebCore::DOMSelection::focusOffset): (WebCore::DOMSelection::extentOffset): (WebCore::DOMSelection::isCollapsed): (WebCore::DOMSelection::type): (WebCore::DOMSelection::rangeCount): (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::collapseToEnd): (WebCore::DOMSelection::collapseToStart): (WebCore::DOMSelection::empty): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::modify): (WebCore::DOMSelection::getRangeAt): (WebCore::DOMSelection::removeAllRanges): (WebCore::DOMSelection::addRange): (WebCore::DOMSelection::toString):
- page/DOMSelection.h: Added.
- page/DOMSelection.idl: Added.
- page/DOMWindow.cpp: (WebCore::DOMWindow::disconnectFrame): (WebCore::DOMWindow::getSelection):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- 8:34 PM Changeset in webkit [23841] by
-
- 5 edits in trunk/WebCore
Reviewed by Maciej.
2nd patch for http://bugs.webkit.org/show_bug.cgi?id=14111
Autogenerate Event JS binding
- Cleanup kjs_events
- bindings/js/kjs_events.cpp: (WebCore::JSAbstractEventListener::JSAbstractEventListener): (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSAbstractEventListener::isHTMLEventListener): (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener): (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener): (WebCore::JSUnprotectedEventListener::listenerObj): (WebCore::JSUnprotectedEventListener::windowObj): (WebCore::JSUnprotectedEventListener::clearWindowObj): (WebCore::JSUnprotectedEventListener::mark): (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::~JSEventListener): (WebCore::JSEventListener::listenerObj): (WebCore::JSEventListener::windowObj): (WebCore::JSEventListener::clearWindowObj): (WebCore::JSLazyEventListener::JSLazyEventListener): (WebCore::JSLazyEventListener::listenerObj): (WebCore::JSLazyEventListener::parseCode): (WebCore::getNodeEventListener): (WebCore::JSClipboard::JSClipboard): (WebCore::JSClipboard::getValueProperty): (WebCore::JSClipboard::putValueProperty): (WebCore::JSClipboardPrototypeFunction::callAsFunction): (WebCore::toJS): (WebCore::toClipboard):
- bindings/js/kjs_events.h: (WebCore::JSClipboard::classInfo): (WebCore::JSClipboard::impl):
- bindings/js/kjs_window.h:
- ksvg2/events/JSSVGLazyEventListener.h:
- 8:19 PM Changeset in webkit [23840] by
-
- 7 edits8 adds in trunk
LayoutTests:
Reviewed by Adam Roben.
Tests for http://bugs.webkit.org/show_bug.cgi?id=12045
Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
<rdar://problem/5286670>
- fast/forms/thumbslider-crash-expected.checksum: Added.
- fast/forms/thumbslider-crash-expected.png: Added.
- fast/forms/thumbslider-crash-expected.txt: Added.
- fast/forms/thumbslider-crash.html: Added.
- fast/forms/thumbslider-no-parent-slider-expected.checksum: Added.
- fast/forms/thumbslider-no-parent-slider-expected.png: Added.
- fast/forms/thumbslider-no-parent-slider-expected.txt: Added.
- fast/forms/thumbslider-no-parent-slider.html: Added.
WebCore:
Reviewed by Adam Roben.
Patch for http://bugs.webkit.org/show_bug.cgi?id=12045
Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
<rdar://problem/5286670>
Test: fast/forms/thumbslider-no-parent-slider.html
Test: fast/forms/thumbslider-crash.html
- rendering/RenderObject.h: (WebCore::RenderObject::isSlider):
- rendering/RenderSlider.h: (WebCore::RenderSlider::isSlider):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): Only paint thumbslider if the parent renderer is a RenderSlider.
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderThumb):
- rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintSliderThumb):
- 6:50 PM Changeset in webkit [23839] by
-
- 1 edit in trunk/WebKitQt/QtLauncher/main.cpp
Missed this file as part of #23832
- 6:36 PM Changeset in webkit [23838] by
-
- 2 edits in trunk/WebCore
Make Qt builds link when XSLT is disabled
- 5:23 PM Changeset in webkit [23837] by
-
- 2 edits in trunk/WebCore
Turn on static code analysis (Windows only).
Affects only folks that have Visual Studio Team Suite installed,
or who have replaced their compiler with the version shipping in the
Vista SDK.
Reviewed by Oliver.
- WebCore.vcproj/WebCore.vcproj:
- 5:04 PM Changeset in webkit [23836] by
-
- 2 edits in trunk/WebCore
Remove files that no longer exist (were commented out)
- 4:14 PM Changeset in webkit [23835] by
-
- 5 edits in trunk/WebCore
revert IDL change until the code generator is fixed
- 4:08 PM Changeset in webkit [23834] by
-
- 10 edits4 adds in trunk
LayoutTests:
Reviewed by John.
<rdar://problem/5247341> REGRESSION: Pasting sometimes loses trailing newline
Demonstrates the bug:
- editing/pasteboard/5247341-expected.checksum: Added.
- editing/pasteboard/5247341-expected.png: Added.
- editing/pasteboard/5247341-expected.txt: Added.
- editing/pasteboard/5247341.html: Added.
The changes in this patch exposed three bugs (5296964, 5296977, and 5299425).
Added FIXMES for them. Also removed tabs in them:
- editing/pasteboard/paste-table-003-expected.checksum:
- editing/pasteboard/paste-table-003-expected.png:
- editing/pasteboard/paste-table-003-expected.txt:
- editing/pasteboard/paste-table-003.html:
- fast/forms/textarea-paste-newline.html:
Equivalent trees:
- editing/pasteboard/paste-text-016-expected.txt:
- editing/pasteboard/paste-text-017-expected.txt:
WebCore:
Reviewed by John.
<rdar://problem/5247341> REGRESSION: Pasting sometimes leaves out trailing newline
Pasting with a trailing interchange newline doesn't work when pasting
into an empty line. Code that handles removing brs at the insertion
position tries to also handle trailing interchange newlines by re-using
those brs and fails. Removed that code and handle all interchange
newlines with code later in doApply().
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Don't try to re-use the endBR when there's a trailing interchange newline.
- 3:21 PM Changeset in webkit [23833] by
-
- 5 edits in trunk/WebCore
Use the proper macros so that it builds with !SVG and !XPATH
- 3:06 PM Changeset in webkit [23832] by
-
- 6 edits in trunk/WebKitQt
Fix compilation with various Qt configurations
- 3:05 PM Changeset in webkit [23831] by
-
- 1 edit in trunk/WebKit/win/ChangeLog
Fix ChangeLog.
- 3:01 PM Changeset in webkit [23830] by
-
- 3 edits1 add in trunk/WebKit/win
Turn on static code analysis.
Reviewed by Oliver.
Effects only folks that have Visual Studio Team Suite installed,
or who have replaced their compiler with the version shipping in the
Vista SDK.
- CodeAnalysisConfig.h: Added.
- WebKit.vcproj/WebKit.vcproj:
- WebLocalizableStrings.cpp: (createWebKitBundle):
- 2:55 PM Changeset in webkit [23829] by
-
- 3 edits in trunk/WebKit/win
Prefast: Remove variable redefinitions in inner scopes.
Reviewed by Ada.
- WebDownload.cpp: (WebDownload::didFinish):
- WebNotificationCenter.cpp: (WebNotificationCenter::postNotificationInternal): (WebNotificationCenter::removeObserver):
- 2:28 PM Changeset in webkit [23828] by
-
- 2 edits in trunk/WebKit/win
Remove SEH block from around history plist read, since the underlying bug has been fixed.
Reviewed by Darin.
- WebHistory.cpp: (createHistoryListFromStream):
- 2:27 PM Changeset in webkit [23827] by
-
- 4 edits in trunk/WebCore
Reviewed by Oliver.
<rdar://problem/5253950>
When Shockwave plugin has been loaded, exiting crashes Safari
Add a "load count" for plugin packages. When the load count is zero, unload the plugin.
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::PluginPackageWin): (WebCore::PluginPackageWin::load): (WebCore::PluginPackageWin::unload): (WebCore::PluginPackageWin::unloadWithoutShutdown):
- plugins/win/PluginPackageWin.h:
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::~PluginViewWin): Make sure to unload the plugin package and clear any references to plugin script objects.
- 1:45 PM Changeset in webkit [23826] by
-
- 2 edits in trunk/WebCore
We were compiling purely out of luck, but if qmake sets up the build order
slightly differently it fails. This forces a dependency to generate HTMLNames.h
in time.
- 1:13 PM Changeset in webkit [23825] by
-
- 2 edits in trunk/WebKitQt
Patch from Eli Fidler to compile when QT_NO_IMAGE_TEXT is defined.
- 1:06 PM Changeset in webkit [23824] by
-
- 2 edits in trunk/WebKitQt
Patch from Eli Fidler to remove QT3_SUPPORT dependency in ICO handler.
- 1:04 PM Changeset in webkit [23823] by
-
- 3 edits8 adds in trunk
LayoutTests:
Reviewed by John.
<rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list
Splits a quoted list w/o splitting a list item:
- editing/execCommand/4580583-1-expected.checksum: Added.
- editing/execCommand/4580583-1-expected.png: Added.
- editing/execCommand/4580583-1-expected.txt: Added.
- editing/execCommand/4580583-1.html: Added.
Split a quoted list item:
- editing/execCommand/4580583-2-expected.checksum: Added.
- editing/execCommand/4580583-2-expected.png: Added.
- editing/execCommand/4580583-2-expected.txt: Added.
- editing/execCommand/4580583-2.html: Added.
WebCore:
Reviewed by John.
<rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list
When a quoted numbered list is broken in half, it's cloned
to make the second list. That second list needs its start attribute
set so that the numbers of the list items in it will be preserved.
- editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): Set the start attribute of a cloned list to be the original number of the first list item in it.
- 10:28 AM Changeset in webkit [23822] by
-
- 2 edits in trunk/WebKit/win
Prefast: Fix misplaced parenthesis.
Reviewed by Darin.
- WebView.cpp: (core):
- 10:21 AM Changeset in webkit [23821] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff.
http://bugs.webkit.org/show_bug.cgi?id=14413
GIF animation throttling is different from MSIE
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameDurationAtIndex): Change the cut-off value to 50ms to match MSIE.
- 10:15 AM Changeset in webkit [23820] by
-
- 3 edits in trunk/WebKit
Reviewed by Darin
- WebKit support for displaying multiple text matches in PDF views (<rdar://problem/4601967>)
- WebView/WebPDFView.h: new ivars textMatches and lastScrollPosition; now conforms to WebMultipleTextMatches protocol
- WebView/WebPDFView.mm: (-[WebPDFView dealloc]): release textMatches (-[WebPDFView viewDidMoveToWindow]): start observing bounds changes in the PDF document's enclosing clip view, so we can notice when scrolling takes place (-[WebPDFView viewWillMoveToWindow:]): stop observing bounds changes in the PDF document's enclosing clip view (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]): most of the code here has been moved into the new method _nextMatchFor::::, which this now calls (-[WebPDFView setMarkedTextMatchesAreHighlighted:]): implementation of WebMultipleTextMatches protocol method, does nothing useful here because we don't support inline highlighting of matches in PDF documents (-[WebPDFView markedTextMatchesAreHighlighted]): implementation of WebMultipleTextMatches protocol method (-[WebPDFView markAllMatchesForText:caseSensitive:limit:]): implementation of WebMultipleTextMatches protocol method; calls _nextMatchFor:::: in a loop until entire document is searched or limit is hit; records results by saving PDFSelections in textMatches ivar (-[WebPDFView unmarkAllTextMatches]): implementation of WebMultipleTextMatches protocol method; clears saved textMatches (-[WebPDFView rectsForTextMatches]): implementation of WebMultipleTextMatches protocol method; converts saved PDFSelections into NSValue objects that represent NSRects (-[WebPDFView _clipViewForPDFDocumentView]): new helper method to find the clip view whose bounds determine the current scroll position (-[WebPDFView _nextMatchFor:direction:caseSensitive:wrap:fromSelection:startInSelection:]): new helper method, extracted from searchFor::::: (-[WebPDFView _PDFDocumentViewMightHaveScrolled:]): new notification callback; tells webView's delegate when document has scrolled (-[WebPDFView _setTextMatches:]): new helper method, stores value in ivar
- 10:13 AM Changeset in webkit [23819] by
-
- 2 edits in trunk/WebKit/win
Prefast: Add null check prior to writing into allocated BSTR.
Reviewed by Darin.
- MarshallingHelpers.cpp: (MarshallingHelpers::CFStringRefToBSTR):
- 9:53 AM Changeset in webkit [23818] by
-
- 2 edits in trunk/WebKit/win
Prefast: Add error handling for SysAllocStringLen where the string length is determined by website content.
Reviewed by Sam, Darin.
Allocation failure will result in a null dereference in this case,
so it isn't exploitable.
- DefaultDownloadDelegate.cpp: (DefaultDownloadDelegate::decideDestinationWithSuggestedFilename):
- 9:47 AM Changeset in webkit [23817] by
-
- 1 add in trunk/LayoutTests/fast/dom/resources/1251.html
Forgot to commit this file with r23815.
- 9:43 AM Changeset in webkit [23816] by
-
- 29 edits in trunk
Reviewed by Darin.
First pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/5292262>
- Add 'f' suffix where necessary.
- kjs/testkjs.cpp: (StopWatch::getElapsedMS):
WebCore:
Reviewed by Darin.
First pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/5292262>
- Add 'f' suffix where necessary.
- bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
- css/csshelper.h:
- css/cssstyleselector.cpp: (WebCore::): (WebCore::CSSStyleSelector::largerFontSize): (WebCore::CSSStyleSelector::smallerFontSize):
- html/CanvasGradient.cpp: (WebCore::CanvasGradient::addColorStop):
- html/CanvasPattern.cpp: (WebCore::CanvasPattern::createPattern):
- ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
- ksvg2/css/SVGRenderStyle.h:
- ksvg2/events/SVGZoomEvent.cpp: (WebCore::SVGZoomEvent::SVGZoomEvent):
- ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::SVGLength): (WebCore::SVGLength::value): (WebCore::SVGLength::setValue): (WebCore::SVGLength::valueAsPercentage): (WebCore::SVGLength::PercentageOfViewport):
- ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::pixelUnitToMillimeterX): (WebCore::SVGSVGElement::pixelUnitToMillimeterY): (WebCore::SVGSVGElement::getScreenCTM):
- ksvg2/svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::getComputedTextLength): (WebCore::SVGTextContentElement::getSubStringLength): (WebCore::SVGTextContentElement::getRotationOfChar):
- ksvg2/svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::SVGTransformDistance): (WebCore::SVGTransformDistance::distance):
- page/InspectorController.cpp: (WebCore::InspectorResource::InspectorResource):
- platform/graphics/FloatPoint3D.cpp: (WebCore::FloatPoint3D::normalize):
- platform/graphics/Path.cpp: (WebCore::pathLengthApplierFunction): (WebCore::Path::createRoundedRectangle):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc):
- platform/graphics/cg/ImageCG.cpp: (WebCore::FrameData::clear):
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameDurationAtIndex):
- platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::setCurrentPage):
- platform/graphics/svg/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::externalRepresentation):
- platform/graphics/svg/SVGPaintServerRadialGradient.cpp: (WebCore::SVGPaintServerRadialGradient::SVGPaintServerRadialGradient):
- platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::cgGradientCallback): (WebCore::CGShadingRefForRadialGradient): (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
- platform/mac/FontDataMac.mm: (WebCore::webFallbackFontFamily):
- platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally):
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::setValueForPosition): (WebCore::RenderSlider::setPositionFromValue):
- 9:36 AM Changeset in webkit [23815] by
-
- 5 edits2 adds in trunk
Reviewed by Geoff.
http://bugs.webkit.org/show_bug.cgi?id=14288
XMLHttpRequest doesn't use a correct content type for file:// URLs
Test: fast/dom/xmlhttprequest-html-response-encoding.html
- xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::responseMIMEType): Use MIME type provided by the network layer, since it provides it even for non-HTTP responses.
- 8:00 AM Changeset in webkit [23814] by
-
- 5 edits in S60/trunk/WebKit
rathnasa, reviewed by <zbujtas@gmail.com>
DESC: Widget Menu API needs refinement
http://bugs.webkit.org/show_bug.cgi?id=14389
- 6:27 AM BuildingQtOnLinux edited by
- (diff)
- 6:27 AM BuildingQtOnLinux edited by
- add heading (diff)
- 6:21 AM BuildingQtOnLinux edited by
- Don't focus on one or two distros and update minimum version of Qt. (diff)
- 1:19 AM Changeset in webkit [23813] by
-
- 3 edits in trunk/WebKit
Reviewed by Maciej.
Hopefully fix remainder of the IME issues on Mac.
We now assume that the IME silently consumes any event given
to it during text composition, and only override this assumption
if the NSTextInput or NSResponder callbacks are made.
This prevents us from treating those events that the IME has
consumed internally (eg. candidate window navigation) as unhandled
events that should be bubbled.
This fixes:
<rdar://problem/5107538> Major problems handling key press event with non-english Input Methods
<rdar://problem/4196249> REGRESSION: Mail: Inputting space (U+0020) with IM deletes subsequent line breaks on Mail.app
<rdar://problem/5015544> REGRESSION: Reverse conversion keyboard command does not work in Safari.
<rdar://problem/5045121> REGRESSION: Inline is confirmed after press left/right arrow keys, happens in Mail but not in TextEdit.
<rdar://problem/5076807> REGRESSION: Can't undo conversion of inline text (by hitting ESC)
<rdar://problem/5085781> REGRESSION: Active input area lost "selected" highlight
<rdar://problem/5094200> space key pressed to close the associated words candidate window gets inserted as text
<rdar://problem/5228294> Candidate item for character matrix is sometimes skipped
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebHTMLView.mm: (-[WebHTMLView launchKeyEvent:]): (-[WebHTMLView keyDown:]): (-[WebHTMLView keyUp:]): (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): (-[WebHTMLView unmarkText]): (-[WebHTMLView setMarkedText:selectedRange:]): (-[WebHTMLView doCommandBySelector:]): (-[WebHTMLView insertText:]):
Jun 26, 2007:
- 10:45 PM Changeset in webkit [23812] by
-
- 2 edits in trunk/WebCore
2007-06-26 Alp Toker <alp.toker@collabora.co.uk>
Reviewed by Sam Weinig.
http://bugs.webkit.org/show_bug.cgi?id=14061
Implement more of FrameLoaderClientGdk
Make FrameLoaderClientGdk work properly when the MIME type is set.
- loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::objectContentType): (WebCore::FrameLoaderClientGdk::canShowMIMEType):
- 10:44 PM Changeset in webkit [23811] by
-
- 6 edits in trunk/WebCore
2007-06-26 Alp Toker <alp.toker@collabora.co.uk>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=14058
Gdk font backend cleanup
- platform/FontData.h: Remove obsolete function.
- platform/gdk/FontDataGdk.cpp: (WebCore::FontData::containsCharacters): Lock/unlock only once. (WebCore::FontData::platformWidthForGlyph): Remove needless cast.
- platform/gdk/FontPlatformData.h: Remove obsolete function.
- platform/gdk/FontPlatformDataGdk.cpp: (WebCore::FontPlatformData::FontPlatformData): Pass the actual size, not the pixel size. (WebCore::FontPlatformData::~FontPlatformData): Free m_fontMatrix.
- platform/gdk/GlyphPageTreeNodeGdk.cpp: (WebCore::GlyphPage::fill): Lock/unlock only once.
- 10:33 PM Changeset in webkit [23810] by
-
- 5 edits2 moves6 adds6 deletes in trunk
2007-06-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=14406 <colgroup>'s borders are ignored when it has <col> children
Covered by existing tests.
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedLeftBorder): (WebCore::RenderTableCell::collapsedRightBorder): (WebCore::RenderTableCell::collapsedTopBorder): (WebCore::RenderTableCell::collapsedBottomBorder):
2007-06-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Hyatt.
- updated results for http://bugs.webkit.org/show_bug.cgi?id=14406 <colgroup>'s borders are ignored when it has <col> children
- tables/mozilla/core/table_rules-expected.checksum: Added.
- tables/mozilla/core/table_rules-expected.png: Added.
- tables/mozilla/core/table_rules-expected.txt: Added.
- tables/mozilla/core/table_rules.html: Copied from LayoutTests/tables/mozilla_expected_failures/core/table_rules.html.
- tables/mozilla/marvin/x_table_rules_groups-expected.checksum: Added.
- tables/mozilla/marvin/x_table_rules_groups-expected.png: Added.
- tables/mozilla/marvin/x_table_rules_groups-expected.txt: Added.
- tables/mozilla/marvin/x_table_rules_groups.xml: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/x_table_rules_groups.xml.
- tables/mozilla_expected_failures/core/table_rules-expected.checksum: Removed.
- tables/mozilla_expected_failures/core/table_rules-expected.png: Removed.
- tables/mozilla_expected_failures/core/table_rules-expected.txt: Removed.
- tables/mozilla_expected_failures/core/table_rules.html: Removed.
- tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
- tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
- tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.checksum: Removed.
- tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.png: Removed.
- tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.txt: Removed.
- tables/mozilla_expected_failures/marvin/x_table_rules_groups.xml: Removed.
- 9:46 PM Changeset in webkit [23809] by
-
- 4 edits5 adds in trunk
2007-06-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Oliver.
- fix http://bugs.webkit.org/show_bug.cgi?id=14329 REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/
Test: fast/repaint/text-selection-rect-in-overflow-2.html
- rendering/RenderObject.cpp: (WebCore::RenderObject::computeAbsoluteRepaintRect): Added code to account for overflow scroll and columns.
- rendering/RenderText.cpp: (WebCore::RenderText::selectionRect): Adjust for columns only in the non-clipped case, since RenderObject::absolutePosition() does not.
2007-06-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Oliver.
- repaint test for http://bugs.webkit.org/show_bug.cgi?id=14329 REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/
- fast/repaint/resources/text-selection-rect-in-overflow-frame.html: Added.
- fast/repaint/text-selection-rect-in-overflow-2-expected.checksum: Added.
- fast/repaint/text-selection-rect-in-overflow-2-expected.png: Added.
- fast/repaint/text-selection-rect-in-overflow-2-expected.txt: Added.
- fast/repaint/text-selection-rect-in-overflow-2.html: Added.
- 9:43 PM Changeset in webkit [23808] by
-
- 2 edits in trunk/WebCore
2007-06-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Sam.
- http://bugs.webkit.org/show_bug.cgi?id=14415 Remove the unused method RenderObject::setTable()
- rendering/RenderObject.h:
- 9:07 PM Changeset in webkit [23807] by
-
- 1 edit in trunk/WebCore/config.h
Touching config.h to force WebCore to rebuild after r23806
- 8:16 PM Changeset in webkit [23806] by
-
- 5 edits6 adds2 deletes in trunk/WebCore
2007-06-26 MorganL <morganl.webkit@yahoo.com>
Reviewed by Maciej.
Implement http://bugs.webkit.org/show_bug.cgi?id=14225
Bug 14225: Make it possible to define platform-specific ResourceRequest without #ifdefs
This change moves the bulk of ResourceRequest into a base class named
ResourceRequestBase with all platform-specific bits pushed into
ResourceRequest. This allows ports to easily add new members to a
ResourceRequest without having to #ifdef the code that is shared
between ports.
- WebCore.exp:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/network/ResourceRequest.cpp: Removed.
- platform/network/ResourceRequest.h: Removed.
- platform/network/ResourceRequestBase.cpp: Added. (WebCore::ResourceRequestBase::asResourceRequest): (WebCore::ResourceRequestBase::isEmpty): (WebCore::ResourceRequestBase::isNull): (WebCore::ResourceRequestBase::url): (WebCore::ResourceRequestBase::setURL): (WebCore::ResourceRequestBase::cachePolicy): (WebCore::ResourceRequestBase::setCachePolicy): (WebCore::ResourceRequestBase::timeoutInterval): (WebCore::ResourceRequestBase::setTimeoutInterval): (WebCore::ResourceRequestBase::mainDocumentURL): (WebCore::ResourceRequestBase::setMainDocumentURL): (WebCore::ResourceRequestBase::httpMethod): (WebCore::ResourceRequestBase::setHTTPMethod): (WebCore::ResourceRequestBase::httpHeaderFields): (WebCore::ResourceRequestBase::httpHeaderField): (WebCore::ResourceRequestBase::setHTTPHeaderField): (WebCore::ResourceRequestBase::httpBody): (WebCore::ResourceRequestBase::setHTTPBody): (WebCore::ResourceRequestBase::allowHTTPCookies): (WebCore::ResourceRequestBase::setAllowHTTPCookies): (WebCore::ResourceRequestBase::addHTTPHeaderField): (WebCore::ResourceRequestBase::addHTTPHeaderFields): (WebCore::operator==): (WebCore::ResourceRequestBase::isConditional): (WebCore::ResourceRequestBase::updatePlatformRequest): (WebCore::ResourceRequestBase::updateResourceRequest):
- platform/network/ResourceRequestBase.h: Added. (WebCore::): (WebCore::ResourceRequestBase::httpContentType): (WebCore::ResourceRequestBase::setHTTPContentType): (WebCore::ResourceRequestBase::httpReferrer): (WebCore::ResourceRequestBase::setHTTPReferrer): (WebCore::ResourceRequestBase::clearHTTPReferrer): (WebCore::ResourceRequestBase::httpUserAgent): (WebCore::ResourceRequestBase::setHTTPUserAgent): (WebCore::ResourceRequestBase::httpAccept): (WebCore::ResourceRequestBase::setHTTPAccept): (WebCore::ResourceRequestBase::ResourceRequestBase): (WebCore::operator!=):
- platform/network/cf/ResourceRequest.h: Added. (WebCore::ResourceRequest::ResourceRequest):
- platform/network/curl/ResourceRequest.h: Added. (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):
- platform/network/mac/ResourceRequest.h: Added. (WebCore::ResourceRequest::ResourceRequest):
- platform/network/qt/ResourceRequest.h: Added. (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):
- 8:13 PM Changeset in webkit [23805] by
-
- 2 edits in trunk/WebKit
2007-06-26 Jim Correia <jim.correia@pobox.com>
Reviewed by Darin.
Fix http://bugs.webkit.org/show_bug.cgi?id=14411
Bug 14411: WebNetscapePluginPackage overagressively sets CurApRefNum, which affects shipping versions of BBEdit.
<rdar://problem/5297268>
- Plugins/WebNetscapePluginPackage.m: (+[WebNetscapePluginPackage initialize]): Force the Resource Manager to lazy initialize, and only set CurApRefNum to the system file if CurApRefNum is still -1 after that forced lazy initialization.
- 7:13 PM Changeset in webkit [23804] by
-
- 1 edit in trunk/WebCore/ChangeLog
Add ChangeLog entries from the Windows merge.
Reviewed by Maciej.
- ChangeLog:
- 6:44 PM Changeset in webkit [23803] by
-
- 7 edits2 adds in trunk
LayoutTests:
Reviewed by Maciej.
Make sure not to enumerate the toString() function.
<rdar://problem/5297118>
- fast/dom/Window/window-appendages-cleared-expected.txt:
- fast/dom/Window/window-properties-expected.txt:
- fast/js/toString-dontEnum-expected.txt: Added.
- fast/js/toString-dontEnum.html: Added.
WebCore:
Reviewed by Maciej.
Make sure not to enumerate the toString() function.
<rdar://problem/5297118>
- bindings/js/kjs_window.cpp:
- bindings/scripts/CodeGeneratorJS.pm: Add support for [DontEnum].
- html/HTMLAnchorElement.idl:
- 4:26 PM Changeset in webkit [23802] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Maciej Stachowiak.
Fixed <rdar://problem/5296627> JSGarbageCollect headerdoc suggests that
using JavaScriptCore requires leaking memory
- API/JSBase.h: Changed documentation to explain that you can pass NULL to JSGarbageCollect.
- 4:07 PM Changeset in webkit [23801] by
-
- 2 edits in trunk/WebCore
Reviewed by Mitz, landed by Anders.
http://bugs.webkit.org/show_bug.cgi?id=14421
Implement GraphicsContext::clearRect()
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clearRect):
- 4:05 PM Changeset in webkit [23800] by
-
- 2 edits in trunk/WebCore
Reviewed and landed by Anders.
http://bugs.webkit.org/show_bug.cgi?id=14416
Content does not render fully in some cases
Fix mismatched calls to cairo_save/restore due to an early method return.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLine):
- 2:31 PM Changeset in webkit [23799] by
-
- 3 edits in trunk/WebCore
Reviewed by John Sullivan.
Added two accessor functions for <rdar://problem/4119138>
- bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isEdited]): (-[DOMHTMLTextAreaElement _isEdited]): Added an accessor to the isEdited value of a DOM node's render object
- bindings/objc/DOMPrivate.h: Added header definitions for _isEdited
- 1:17 PM Changeset in webkit [23798] by
-
- 2 edits in S60/trunk/WebCore
spadma, reviewed by zalan
DESC: Fix build bustage
- kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::activateNodeAtPoint):
- 1:07 PM Changeset in webkit [23797] by
-
- 2 edits in trunk/WebCore
Fix Win32 build.
- WebCore.vcproj/WebCore.vcproj:
- 1:05 PM Changeset in webkit [23796] by
-
- 2 edits in trunk/WebCore
Fix Qt and Gdk builds.
- WebCore.pro:
- 12:55 PM Changeset in webkit [23795] by
-
- 15 edits1 add in trunk
LayoutTests:
Reviewed by Geoff.
Update tests for http://bugs.webkit.org/show_bug.cgi?id=14111
Autogenerate Event JS binding
- fast/dom/prototype-chain-expected.txt: DOMEventPrototype is no longer in the prototype chain.
- fast/dom/xmlhttprequest-get-expected.txt:
WebCore:
Reviewed by Geoff.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14111
Autogenerate Event JS binding
- Moves the dataTransfer method into MouseEvent where it should be.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSEventCustom.cpp: Added. (WebCore::JSEvent::clipboardData): (WebCore::toJS):
- bindings/js/JSEventTargetNode.cpp:
- bindings/js/JSXMLHttpRequest.cpp:
- bindings/js/kjs_events.cpp:
- bindings/js/kjs_events.h:
- bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Event.h: (WebCore::Event::returnValue): (WebCore::Event::setReturnValue): (WebCore::Event::clipboardData):
- dom/Event.idl:
- dom/MouseEvent.h: (WebCore::MouseEvent::dataTransfer):
- dom/MouseEvent.idl:
- 7:47 AM Changeset in webkit [23794] by
-
- 6 edits in S60/trunk/WebKit
winship, reviewed by <reviewer>
DESC: SYAI-73ARXK - Widget UI must not have scrollbars, always ON status pane & fullscreen mode
http://bugs.webkit.org/show_bug.cgi?id=14384
- BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
- BrowserControl/inc/BrCtlInterface.h:
- BrowserView/inc/WidgetExtension.h:
- BrowserView/src/WebKitControl.cpp: (CWebKitControl::ForegroundEvent):
- BrowserView/src/WidgetExtension.cpp: (CWidgetExtension::SetRightSoftKeyLabel): (CWidgetExtension::HideSoftkeys): (CWidgetExtension::ShowSoftkeys): (CWidgetExtension::SetDisplayLandscape): (CWidgetExtension::SetDisplayPortrait):
- 7:44 AM Changeset in webkit [23793] by
-
- 3 edits in S60/trunk/WebKit
2007-06-25 Vikram Malaiya, reviewed by Sachin
DESC: YDAI-73QAL9 - Cursor is invisible on second created browser control.
http://bugs.webkit.org/show_bug.cgi?id=14285
- BrowserView/inc/WebKitCursor.h:
- BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CWebKitCursor): (CWebKitCursor::ConstructL): (CWebKitCursor::SetCurrentView): (CWebKitCursor::ConstructSprite): (CWebKitCursor::CursorUpdate):
- 7:41 AM Changeset in webkit [23792] by
-
- 2 edits in S60/trunk/WebCore
spadma, reviewed by zalan
DESC: [S60] Pointer event in a blank browser window causes crash
http://bugs.webkit.org/show_bug.cgi?id=14387
TSW ID : YDAI-73V998
WARNING: NO TEST CASES ADDED OR CHANGED
- kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::activateNodeAtPoint):
- 7:40 AM Changeset in webkit [23791] by
-
- 1 add in trunk/WebCore/loader/icon/IconDatabaseNone.cpp
Missed checking in this file when checking in icon database patch from Adam Treat. Unused on all platforms presently.
- 5:51 AM Web Inspector edited by
- (diff)
- 5:28 AM Changeset in webkit [23790] by
-
- 2 edits in trunk/WebCore
Reviewed by Mark Rowe.
Follow up fix for: Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
http://bugs.webkit.org/show_bug.cgi?id=14385
Correctly remember the "Show implicit properties" setting as you switch nodes.
- page/inspector/ResourcePanel.js:
- 1:55 AM Changeset in webkit [23789] by
-
- 4 edits1 move3 adds3 deletes in branches/feature-branch
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=9976
Fix negative width issue in Hixie's test
Refuse to render zero or negative width/height.
- 12:47 AM Changeset in webkit [23788] by
-
- 14 edits8 adds in branches/feature-branch
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=12062
WebCore does not handle CSS-specified fill fallback correctly
Implement fallback for fill and stroke.
Jun 25, 2007:
- 11:52 PM Changeset in webkit [23787] by
-
- 8 edits2 adds in trunk
LayoutTests:
Reviewed by John.
<rdar://problem/5290534> Crash RenderTextControl::calcHeight() after deleting text in a search field
Demonstrates the bug:
- editing/deleting/5290534-expected.txt: Added.
- editing/deleting/5290534.html: Added.
Fixed a bug (an extra br was inserted) and removed a FIXME:
- editing/deleting/4845371-expected.checksum:
- editing/deleting/4845371-expected.png:
- editing/deleting/4845371-expected.txt:
- editing/deleting/4845371.html:
Removed an unrendered br that was being incorrectly inserted:
- editing/deleting/5126166-expected.txt:
WebCore:
Reviewed by John.
<rdar://problem/5290534> Crash at RenderTextControl::calcHeight() after deleting text in a search field
Editing removed a node that was part of a search field's internal
structure that should not be removed.
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): If the selection to delete ends at [container, x], where x is the number of children in container, don't remove container. Special case code elsewhere in this function will remove it if necessary.
- 11:34 PM Changeset in webkit [23786] by
-
- 4 edits3 adds in trunk
LayoutTests:
Reviewed by Maciej.
Test for http://bugs.webkit.org/show_bug.cgi?id=11315
Mutating document.constructor.prototype mutates Object.prototype
- fast/js/constructor-expected.txt: Added.
- fast/js/constructor.html: Added.
- fast/js/resources/constructor.js: Added.
WebCore:
Reviewed by Maciej.
Patch for http://bugs.webkit.org/show_bug.cgi?id=11315
Mutating document.constructor.prototype mutates Object.prototype
Test: fast/js/constructor.html
- bindings/scripts/CodeGeneratorJS.pm: add constructor attribute to classes with constructors. It is an non-enumeratable, non-deletable, readonly attribute.
- 10:23 PM Changeset in webkit [23785] by
-
- 2 edits in trunk/WebCore
Repair the OS X build.
- 10:12 PM Changeset in webkit [23784] by
-
- 1 edit1 delete in trunk
Really remove LayoutTestResults.
- LayoutTestResults: Removed.
- 10:00 PM Changeset in webkit [23783] by
-
- 3 edits297 copies2455 moves105 adds297 deletes in trunk
Fix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt
Top Level:
Fix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt
http://bugs.webkit.org/show_bug.cgi?id=14405
Reviewed by Anders.
- LayoutTestResults: Removed.
WebKitTools:
Fix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt
http://bugs.webkit.org/show_bug.cgi?id=14405
Reviewed by Anders.
- Scripts/run-webkit-tests:
- 9:56 PM Changeset in webkit [23782] by
-
- 5 edits in trunk
Patch from Adam Treat to make the SQLite icon database optional.
- 9:38 PM Changeset in webkit [23781] by
-
- 2 edits in trunk/WebKitTools
Enable running the regression tests on Windows.
These changes were developed alongside the Windows WebKit port and
have been well tested.
Rubberstamped by Sam.
- Scripts/run-webkit-tests:
- 9:18 PM Changeset in webkit [23780] by
-
- 6 edits in trunk/WebCore
Reviewed by Adam Roben.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14369
HTML syntax highlighting colors and DOM tree colors should be the same
- css/view-source.css:
- page/inspector/ResourcePanel.js:
- page/inspector/inspector.css:
- page/inspector/inspector.js:
- page/inspector/utilities.js:
- 8:18 PM Changeset in webkit [23779] by
-
- 2 edits in trunk/WebCore
Fix Bug 14402: Main resource of http://www.apple.com/safari/ is called "www.apple.com" instead of "safari"
The solution was to make KURL::lastPathComponent ignore trailing
slashes, which is what -[NSURL lastPathComponent] does, too.
Reviewed by Oliver.
- platform/KURL.cpp:
(WebCore::KURL::lastPathComponent):
- 8:09 PM Changeset in webkit [23778] by
-
- 2 edits in trunk/WebKitTools
Fix Bug 14403: prepare-ChangeLog --git-commit doesn't support --diff
http://bugs.webkit.org/show_bug.cgi?id=14403
Reviewed by Mark Rowe.
- Scripts/prepare-ChangeLog: Don't spew to stdout, use stderr instead.
(sub createPatchCommand): Generate a correct diff in the $gitCommit
case.
- 5:56 PM Changeset in webkit [23777] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin.
<rdar://problem/5294036> -[WebView customTextEncodingName] API may return empty string instead of nil
- WebView/WebView.mm: (-[WebView _mainFrameOverrideEncoding]): Addded the nsStringNilIfEmpty() inline to the data being returned because our API says "The custom text encoding name or nil if no custom text encoding name has been set." I also verified the standing Tiger WebKit behavior for this method and it does indeed return nil if a custom encoding wasn't set.
- 5:51 PM Changeset in webkit [23776] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14257
Web Inspector lists favicon.ico as "other" instead of "image"
- page/InspectorController.cpp: (WebCore::InspectorResource::type):
- 5:43 PM Changeset in webkit [23775] by
-
- 2 edits13 adds in trunk/WebKitTools
Land pdevenv and supporting scripts/programs
pdevenv is a script that will open an instance of Visual Studio that
can compile multiple files in parallel, similar to make -jN. It uses
the following scripts/programs to accomplish this:
CLWrapper: Compiles to vcbin/cl.exe. Calls Scripts/parallelcl.
parallelcl: Actually performs the parallel compilation by forking
multiple instances of the Microsoft-supplied cl.exe.
MIDLWrapper: Compiles to vcbin/midl.exe. Calls through to the
Microsoft-supplied midl.exe. This avoids having to invoke perl for
every invocation of midl.exe, which would be quite slow.
Rubberstamped by Sam.
- CLWrapper/CLWrapper.cpp: Added.
(wmain):
- CLWrapper/CLWrapper.sln: Added.
- CLWrapper/CLWrapper.vcproj: Added.
- MIDLWrapper/MIDLWrapper.cpp: Added.
(wmain):
- MIDLWrapper/MIDLWrapper.sln: Added.
- MIDLWrapper/MIDLWrapper.vcproj: Added.
- Scripts/parallelcl: Added.
- Scripts/pdevenv: Added.
- vcbin/cl.exe: Added.
- vcbin/midl.exe: Added.
- 5:30 PM Changeset in webkit [23774] by
-
- 6 edits in trunk/WebKit
Reviewed by Darin
- WebKit part of <rdar://problem/5293820>, needed to support multiple matches in PDFs
- WebView/WebDocumentInternal.h: Added WebMultipleTextMatches protocol, containing five methods that were formerly implemented in WebHTMLView
- WebView/WebHTMLViewPrivate.h: Removed declarations for the methods that are now in WebMultipleTextMatches protocol
- WebView/WebHTMLView.mm: (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): moved this method into the WebDocumentInternalProtocols portion of the file (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): ditto (-[WebHTMLView markedTextMatchesAreHighlighted]): ditto (-[WebHTMLView unmarkAllTextMatches]): ditto (-[WebHTMLView rectsForTextMatches]): ditto
- WebView/WebView.mm: (-[WebView canMarkAllTextMatches]): new method, returns YES only if the documentView of every frame implements WebMultipleTextMatches (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): check for WebMultipleTextMatches protocol instead of checking for WebHTMLView class (-[WebView unmarkAllTextMatches]): ditto (-[WebView rectsForTextMatches]): ditto
- WebView/WebViewPrivate.h: declared new method canMarkAllTextMatches
- 5:07 PM Changeset in webkit [23773] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Hyatt.
Test for: <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
http://bugs.webkit.org/show_bug.cgi?id=14297
- fast/overflow/hidden-scrollbar-resize-expected.checksum: Added.
- fast/overflow/hidden-scrollbar-resize-expected.png: Added.
- fast/overflow/hidden-scrollbar-resize-expected.txt: Added.
- fast/overflow/hidden-scrollbar-resize.html: Added.
WebCore:
Reviewed by Hyatt.
Fix for <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
http://bugs.webkit.org/show_bug.cgi?id=14297
Test: fast/overflow/hidden-scrollbar-resize.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Updated our shouldPaint check to consider visibility.
- 3:59 PM Changeset in webkit [23772] by
-
- 2 edits1 add in trunk/WebCore
Reviewed by Darin.
<rdar://problem/5293444> REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info
Fixing logic error in DragController
- manual-tests/drop-text-acquires-style.html: Added.
- page/DragController.cpp: (WebCore::documentFragmentFromDragData):
- 2:36 PM Changeset in webkit [23771] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
Annotate prototypes by adding "Prototype" subtitle.
- page/inspector/ResourcePanel.js:
- 2:29 PM Changeset in webkit [23770] by
-
- 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj
Build fix.
- 11:20 AM Changeset in webkit [23769] by
-
- 10 edits in trunk
Some work on adding HTTP proxy and SSL errors to WebKitQt, as well as preparing
for upcoming patches to do authentication.
- 10:48 AM Changeset in webkit [23768] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin
Fixed <rdar://problem/5292259> Find on Page doesn't work (throws exception) on page that includes PDF in a subframe
- WebView/WebView.mm: (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): We were testing whether the view was an HTMLView, but then running code that assumed it was an HTMLView outside of that test. That's a bad idea.
- 9:04 AM Changeset in webkit [23767] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=14386
Gdk build fix
- WebCore.pro: Fix gtk/gdk typo.
- 8:44 AM Changeset in webkit [23766] by
-
- 3 edits in S60/trunk/WebCore
2007-06-22 hongzhao <hong.a.zhao@nokia.com>
Reviewed by Zalan (zbujtas@gmail.com).
DESC: Bug 14214: [S60] Dropdown not opened if it has size defined in 3.1m.
http://bugs.webkit.org/show_bug.cgi?id=14214
- 8:41 AM Changeset in webkit [23765] by
-
- 3 edits in S60/branches/3.1m/WebCore
2007-06-22 hongzhao <hong.a.zhao@nokia.com>
Reviewed by Zalan (zbujtas@gmail.com).
DESC: Bug 14214: [S60] Dropdown not opened if it has size defined in 3.1m.
http://bugs.webkit.org/show_bug.cgi?id=14214
- 7:51 AM Changeset in webkit [23764] by
-
- 5 edits in trunk/WebCore
Reviewed by Anders.
Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
http://bugs.webkit.org/show_bug.cgi?id=14385
Add a toggle to show implict computed properties.
- page/inspector/ResourcePanel.js:
- page/inspector/inspector.css:
- page/inspector/inspector.js:
- 5:57 AM Changeset in webkit [23763] by
-
- 4 edits62 deletes in trunk
2007-06-25 Alp Toker <alp.toker@collabora.co.uk>
Reviewed by Mark.
http://bugs.webkit.org/show_bug.cgi?id=13975
Use system-provided libjpeg and libpng
- WebKit.pri: Link against external libjpeg and libpng.
2007-06-25 Alp Toker <alp.toker@collabora.co.uk>
Reviewed by Mark.
http://bugs.webkit.org/show_bug.cgi?id=13975
Use system-provided libjpeg and libpng
- WebCore.pro: Remove bundled libjpeg and libpng sources.
- platform/image-decoders/jpeg: Remove sources.
- platform/image-decoders/png: Remove sources.
- 3:31 AM Changeset in webkit [23762] by
-
- 24 edits4 adds in trunk
2007-06-25 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=14202 Table caption renders too narrow sometimes
Test: fast/table/caption-relayout.html
- rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Mark the caption for layout if the table width changed.
2007-06-25 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- test and updated results for http://bugs.webkit.org/show_bug.cgi?id=14202 Table caption renders too narrow sometimes
- fast/table/caption-relayout-expected.checksum: Added.
- fast/table/caption-relayout-expected.png: Added.
- fast/table/caption-relayout-expected.txt: Added.
- fast/table/caption-relayout.html: Added.
- tables/mozilla/marvin/x_caption_class-expected.checksum:
- tables/mozilla/marvin/x_caption_class-expected.png:
- tables/mozilla/marvin/x_caption_class-expected.txt:
- tables/mozilla/marvin/x_caption_id-expected.checksum:
- tables/mozilla/marvin/x_caption_id-expected.png:
- tables/mozilla/marvin/x_caption_id-expected.txt:
- tables/mozilla/marvin/x_caption_style-expected.checksum:
- tables/mozilla/marvin/x_caption_style-expected.png:
- tables/mozilla/marvin/x_caption_style-expected.txt:
- tables/mozilla_expected_failures/bugs/bug29058-2-expected.checksum:
- tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
- tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
- tables/mozilla_expected_failures/bugs/bug3166-5-expected.checksum:
- tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
- tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt:
- tables/mozilla_expected_failures/bugs/bug3166-6-expected.checksum:
- tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
- tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt:
- tables/mozilla_expected_failures/bugs/bug3166-9-expected.checksum:
- tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
- tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt:
- 3:29 AM Changeset in webkit [23761] by
-
- 3 edits4 adds in trunk
2007-06-25 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=14245 Underline painted under <br>, not repainted properly
Test: fast/inline/br-text-decoration.html
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLineForText): Added an early return if the line width is zero. Also changed the line stroke to a rect fill, so that lines with length shorter than their thickness paint correctly.
2007-06-25 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- pixel test for http://bugs.webkit.org/show_bug.cgi?id=14245 Underline painted under <br>, not repainted properly
- fast/inline/br-text-decoration-expected.checksum: Added.
- fast/inline/br-text-decoration-expected.png: Added.
- fast/inline/br-text-decoration-expected.txt: Added.
- fast/inline/br-text-decoration.html: Added.
- 3:27 AM Changeset in webkit [23760] by
-
- 5 edits in trunk/LayoutTests
2007-06-25 Matt Perry <mpComplete@gmail.com>
Reviewed by Sam Weinig.
Modify test to wait until the second frame loads, and update its expected output to match.
- fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.checksum:
- fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.png:
- fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt:
- fast/dom/HTMLDocument/frameless-location-bugzilla10837.html:
- 3:23 AM Changeset in webkit [23759] by
-
- 6 edits2 moves6 adds6 deletes in trunk
2007-06-25 Mitz Pettel <mitz@webkit.org>
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=14341 rules="none" ignored in certain cases
Covered by existing tests.
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::getSharedCellDecl):
2007-06-25 Mitz Pettel <mitz@webkit.org>
Reviewed by Maciej.
- updated results for http://bugs.webkit.org/show_bug.cgi?id=14341 rules="none" ignored in certain cases
- tables/mozilla/marvin/table_rules_none-expected.checksum: Added.
- tables/mozilla/marvin/table_rules_none-expected.png: Added.
- tables/mozilla/marvin/table_rules_none-expected.txt: Added.
- tables/mozilla/marvin/table_rules_none.html: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/table_rules_none.html.
- tables/mozilla/marvin/x_table_rules_none-expected.checksum: Added.
- tables/mozilla/marvin/x_table_rules_none-expected.png: Added.
- tables/mozilla/marvin/x_table_rules_none-expected.txt: Added.
- tables/mozilla/marvin/x_table_rules_none.xml: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/x_table_rules_none.xml.
- tables/mozilla_expected_failures/core/table_rules-expected.checksum:
- tables/mozilla_expected_failures/core/table_rules-expected.png:
- tables/mozilla_expected_failures/core/table_rules-expected.txt:
- tables/mozilla_expected_failures/marvin/table_rules_none-expected.checksum: Removed.
- tables/mozilla_expected_failures/marvin/table_rules_none-expected.png: Removed.
- tables/mozilla_expected_failures/marvin/table_rules_none-expected.txt: Removed.
- tables/mozilla_expected_failures/marvin/table_rules_none.html: Removed.
- tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.checksum: Removed.
- tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.png: Removed.
- tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.txt: Removed.
- tables/mozilla_expected_failures/marvin/x_table_rules_none.xml: Removed.
- 12:10 AM Changeset in webkit [23758] by
-
- 2 edits in trunk/WebCore
Reviewed by Mitz.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14379
Anchor elements show up as their href in the properties pane, not HTMLAnchorElement
- page/inspector/ResourcePanel.js: make sure not to call an overriden toString() by using Object.prototype.toString.call().
