Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Jul 10, 2007:

11:20 PM Changeset in webkit [24183] by ggaren

• 4 edits in trunk/WebKit

Reviewed by Maciej Stachowiak.

• Fixed <rdar://problem/5049509> REGRESSION(10.4.9-9A377a): REAP Suite installer shows empty modal alert window (hangs) if user cancels during "installing shared components" phase

Added Adobe installers to the family of apps that need a data load
loading quirk.

Added a linked-on-or-after check because this code is no longer
Tiger-only.

I tested this code on Tiger and Leopard.

• Misc/WebKitVersionChecks.h:
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebDocumentLoaderMac.mm: (needsDataLoadWorkaround): (WebDocumentLoaderMac::setDataSource):

10:10 PM Changeset in webkit [24182] by weinig

• 9 edits
  2 adds in trunk

LayoutTests:

Reviewed by Oliver.

• fast/dom/Window/get-set-properties-expected.txt: Added.
• fast/dom/Window/get-set-properties.html: Added.

WebCore:

Reviewed by Oliver.

Move more attributes from the pure JS bindings in KJS::Window
to the implementation in DOMWindow and autogenerate the new bindings

Test: fast/dom/Window/get-set-properties.html

• bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): Change to use propHashTable in JSDOMWindow instead of KJS::Window
• bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put):
• bindings/js/kjs_window.h: (KJS::Window::):
• bindings/scripts/CodeGeneratorJS.pm: Cleanup getValueProperty and put generation to reduce code duplication.
• page/DOMWindow.cpp: (WebCore::DOMWindow::closed): (WebCore::DOMWindow::length): (WebCore::DOMWindow::name): (WebCore::DOMWindow::setName): (WebCore::DOMWindow::status): (WebCore::DOMWindow::setStatus): (WebCore::DOMWindow::defaultStatus): (WebCore::DOMWindow::setDefaultStatus):
• page/DOMWindow.h: (WebCore::DOMWindow::defaultstatus): (WebCore::DOMWindow::setDefaultstatus):
• page/DOMWindow.idl:

8:46 PM Changeset in webkit [24181] by weinig

• 4 edits
  3 adds in trunk

LayoutTests:

Reviewed by Geoff.

Tests for <rdar://problem/5326791>

• http/tests/security/cross-frame-access-expected.txt:
• http/tests/security/cross-frame-access-put-expected.txt: Added.
• http/tests/security/cross-frame-access-put.html: Added.
• http/tests/security/resources/cross-frame-iframe-for-put-test.html: Added.

WebCore:

Reviewed by Geoff.

Fix for <rdar://problem/5326791> XSS vulnerability: ability to set window.defaultStatus,
window.defaultstatus and window.status cross domains

Test: http/tests/security/cross-frame-access-put.html

• bindings/js/kjs_window.cpp: (KJS::Window::put): Adds isSafeScript check for defaultStatus, defaultstatus and status cases.

8:11 PM Changeset in webkit [24180] by darin

• 2 edits in trunk/WebKitTools

• Scripts/run-webkit-tests: Add an ignore item for a leak in Tiger's Foundation's multipart/mixed-replace support -- I already verified that the bug has been fixed.

7:13 PM Changeset in webkit [24179] by aliceli1

• 2 edits in trunk/WebKitTools

rubber stamped by Maciej.

fixed <rdar://5137972> editing/selection/editable-links.html fails on Windows

• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initializePreferences): set editable link behavior to match Mac DRT.

6:42 PM Changeset in webkit [24178] by weinig

• 2 edits in trunk/WebCore

Fix build for BuildBot.

• page/DOMWindow.cpp: (WebCore::DOMWindow::outerHeight): (WebCore::DOMWindow::outerWidth): (WebCore::DOMWindow::screenX): (WebCore::DOMWindow::screenY):

6:38 PM Changeset in webkit [24177] by beidson

• 2 edits in trunk/WebCore

Reviewed by Sam

<rdar://problem/5326653> - REGRESSION: [WebBackForwardList forwardListCount] might return incorrect result

No layout test because this is an API issue that can't be tested in DRT or the browser

• history/BackForwardList.cpp: (WebCore::BackForwardList::forwardListCount): If the index is NoCurrentItemIndex, return 0

5:28 PM Changeset in webkit [24176] by weinig

• 6 edits in trunk/WebCore

Reviewed by Darin.

Move more readonly attributes from pure JS bindings in KJS::Window
to the implementation in DOMWindow and autogenerate the new bindings.

• bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): Sort the hashmap comment into categories to make further migration easier.
• bindings/js/kjs_window.h: Sort the enum into categories to make further migration easier. (KJS::Window::):
• page/DOMWindow.cpp: Add new methods. (WebCore::DOMWindow::focus): (WebCore::DOMWindow::blur): (WebCore::DOMWindow::offscreenBuffering): (WebCore::DOMWindow::outerHeight): (WebCore::DOMWindow::outerWidth): (WebCore::DOMWindow::innerHeight): (WebCore::DOMWindow::innerWidth): (WebCore::DOMWindow::screenX): (WebCore::DOMWindow::screenY): (WebCore::DOMWindow::scrollX): (WebCore::DOMWindow::scrollY): (WebCore::DOMWindow::getComputedStyle): (WebCore::DOMWindow::getMatchedCSSRules): Add null Document assertion. (WebCore::DOMWindow::devicePixelRatio): Add null Frame and Page checks.
• page/DOMWindow.h: (WebCore::DOMWindow::screenLeft): (WebCore::DOMWindow::screenTop): (WebCore::DOMWindow::pageXOffset): (WebCore::DOMWindow::pageYOffset):
• page/DOMWindow.idl:

5:23 PM Changeset in webkit [24175] by oliver

• 3 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/5326417> Editor::unmarkText needs to be crossplatform

Missed this in earlier patch to make text marking platform independent.

• editing/Editor.cpp: (WebCore::Editor::unmarkText):

Add platform independent impl

• editing/mac/EditorMac.mm:

Remove the old mac path.

4:52 PM Changeset in webkit [24174] by ggaren

• 4 edits in trunk

WebCore:

Reviewed by Tim Hatcher.

Added a Page counter. This helped me while investigating
<rdar://problem/5314463> 40MB of WebKit memory still allocated after
closing large email in Mail

• WebCore.xcodeproj/project.pbxproj:
• page/Page.cpp: (WebCore::): (WebCore::PageCounter::~PageCounter): (WebCore::Page::Page): (WebCore::Page::~Page):

WebKitTools:

Reviewed by Tim Hatcher.

Ignore Page.o in debug builds because it now has a static PageCounter
object.

• Scripts/check-for-global-initializers:

4:44 PM Changeset in webkit [24173] by thatcher

• 4 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5326126> InspectorResource holds onto more data than it needs

Reduces the fixed size of InspectorResource from 630 bytes to 224 bytes. Now
selectively pick out parts of the ResourceRequest and ResourceResponse objects
for the info needed and store that directly in InspectorResource.

The ResourceRequest and ResourceResponse objects hold a reference to the original
NSURL object, so almost double the data was being kept around. So the struct size
reduction is just the tip of the ice burg on what this really saves.

In a test of 100,000 XMLHTTPRequests using a 85 byte long data URL, I see ~21 MB less
RSIZE compared to Safari running without this change.

• page/InspectorController.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::type): (WebCore::addSourceToFrame): (WebCore::scriptObjectForRequest): (WebCore::scriptObjectForResponse): (WebCore::InspectorController::addScriptResource): (WebCore::InspectorController::addAndUpdateScriptResource): (WebCore::updateResourceRequest): (WebCore::updateResourceResponse): (WebCore::InspectorController::updateScriptResourceRequest): (WebCore::InspectorController::updateScriptResourceResponse): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
• page/InspectorController.h:

3:42 PM Changeset in webkit [24172] by zimmermann

• 3 edits in branches/feature-branch/WebCore

Forgot to commit the ChangeLog and two files in my last commit!

3:37 PM Changeset in webkit [24171] by darin

• 2 edits in trunk/WebCore

Reviewed by Brady.

• fix crash introduced by my patch for 5318732, only seen in release builds

• page/Page.cpp: (WebCore::Page::~Page): Added a missing null check.

3:30 PM Changeset in webkit [24170] by staikos

• 2 edits in trunk/WebCore

Patch from Andrea Cavalli to fix sunken state of text fields.
Bug #14576

3:29 PM Changeset in webkit [24169] by zimmermann

• 17 edits
  5 adds in branches/feature-branch

Reviewed by Sam.

Recognizee <textPath> in SVG JS bindings.
Add JSSVGTextPathElement to JSSVGElementWrapperFactory.

Add SVGException.idl just for the JS generation.
Turn on all SVG JS constructors and add them to DOMWindow.idl.

Testcase added: LayoutTests/svg/custom/js-svg-constructors.svg

3:13 PM Changeset in webkit [24168] by staikos

• 3 edits in trunk/WebCore

Patch from Qing Zhao to draw focus rects on non-QStyle rendered nodes. Needs a
bit more work once we figure out how to use QPainterPathStroker in a more
sophisticated manner.

3:10 PM Changeset in webkit [24167] by brmorris

• 2 edits in S60/trunk/WebKit

brmorris, reviewed by johnshi

DESC: remove generated header from releasables list.

Turns out some build systems delete the releasables list after the
makmake phase but before the compilation, and hence the generated
header was not found at compile time.

3:04 PM BuildingGdk edited by zecke@selfish.org

(diff)

3:04 PM BuildingGdk edited by zecke@selfish.org

(diff)

2:53 PM Changeset in webkit [24166] by adachan

• 2 edits in trunk/WebKit/win

2007-07-10 Ada Chan <​adachan@apple.com>

Fixed build.

• WebView.cpp:

2:46 PM Changeset in webkit [24165] by zimmermann

• 2 edits in trunk/WebCore

Reviewed by Geoff.

Fix 'unsigned int' overflow in CodeGeneratorJS.pm.
This fixes hashing of "SVG_FEBLEND_MODE_NORMAL". Its hashvalue exceeded 2^{32, which
is no problem in perl but in the cpp code. Emulate C/C++ behaviour by using "% 2}32" in
the perl code. Testcase available in feature-branch soon (js-svg-constructors.svg).

2:45 PM Changeset in webkit [24164] by ggaren

• 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

Disabled Arena recycling in RenderArena. PLT shows no regression
(possibly a small speedup), and this can reduce allocated memory in
WebKit clients by about 120K (4K per Arena * 30 Arenas).

I happened upon this optimization while investigating
<rdar://problem/5314463> WebKit hangs on to 40MB RAM after closing
large email in Mail (appears to be render tree arena allocator),
although I don't think it will come close to fixing that bug
completely.

• rendering/RenderArena.cpp: (WebCore::RenderArena::~RenderArena): Use FinishArenaPool, which frees the ArenaPool's Arenas immediately.

2:37 PM Changeset in webkit [24163] by weinig

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=14449 REGRESSION (r14345-r14375): Absolutely positioned image does not scale to containing element's height

• fast/replaced/absolute-position-percentage-height-expected.checksum: Added.
• fast/replaced/absolute-position-percentage-height-expected.png: Added.
• fast/replaced/absolute-position-percentage-height-expected.txt: Added.
• fast/replaced/absolute-position-percentage-height.html: Added.

WebCore:

Reviewed by Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=14449 REGRESSION (r14345-r14375): Absolutely positioned image does not scale to containing element's height

Test: fast/replaced/absolute-position-percentage-height.html

• rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedHeightUsing): For positioned elements, evaluate the percentage with respect to the container's final height.

1:21 PM Changeset in webkit [24162] by thatcher

• 1 edit in trunk/WebCore/platform/DeprecatedString.cpp

Build fix.

1:13 PM Changeset in webkit [24161] by beidson

• 1 edit in trunk/WebCore/platform/DeprecatedString.cpp

Correctness fix

1:08 PM Changeset in webkit [24160] by zbujtas

• 7 edits in S60/branches/3.1m/WebKit

2007-07-03 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by ​zbujtas@gmail.com.
DESC: merge fixes SYAI-73AS6K and SYAI-73ARXK from 3.2
​http://bugs.webkit.org/show_bug.cgi?id=14389

1:03 PM Changeset in webkit [24159] by darin

• 2 edits in trunk/WebKit

• fix build

• WebView/WebHTMLView.mm: Add include of ContextMenu.h.

12:54 PM Changeset in webkit [24158] by beidson

• 7 edits in trunk/WebCore

Reviewed by Mark Rowe

Add 64-bit integer converters to our string classes for future work

• platform/DeprecatedString.cpp: (WebCore::DeprecatedString::toInt64): (WebCore::DeprecatedString::toUInt64):
• platform/DeprecatedString.h:

• platform/PlatformString.h:
• platform/String.cpp: (WebCore::String::toInt64): (WebCore::String::toUInt64):

• platform/StringImpl.cpp: (WebCore::StringImpl::toInt64): (WebCore::StringImpl::toUInt64):
• platform/StringImpl.h:

12:45 PM Changeset in webkit [24157] by aliceli1

• 2 edits in trunk/LayoutTests

• win/Skipped: removing tests that were blocked on lack of support for smart pasting and DOM Paste API

12:21 PM Changeset in webkit [24156] by darin

• 9 edits in trunk/WebCore

Reviewed by Anders.

• fix <rdar://problem/5318732> REGRESSION: In Mail, a crash occurs when attempting to send a HTML based message (nytimes.com, washingtonpost.com, latimes.com)

Did an audit of calls to get the inspector and most other uses of Page* and added null
checks since Frame* can outlast its Page*.

• loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): Added null check. (WebCore::FrameLoader::loadSubframe): Ditto. (WebCore::FrameLoader::load): Ditto. (WebCore::FrameLoader::transitionToCommitted): Ditto. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto. (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): Ditto. (WebCore::FrameLoader::addExtraFieldsToRequest): Ditto. (WebCore::FrameLoader::loadResourceSynchronously): Ditto. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Ditto. (WebCore::FrameLoader::requestFromDelegate): Ditto. (WebCore::FrameLoader::canGoBackOrForward): Ditto. (WebCore::FrameLoader::getHistoryLength): Ditto. (WebCore::FrameLoader::historyURL): Ditto. (WebCore::FrameLoader::cachePageForHistoryItem): Ditto. (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): Ditto. (WebCore::FrameLoader::goToItem): Ditto. (WebCore::FrameLoader::dispatchWindowObjectAvailable): Ditto. (WebCore::FrameLoader::dispatchDidCommitLoad): Ditto. (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest): Ditto. (WebCore::FrameLoader::dispatchWillSendRequest): Ditto. (WebCore::FrameLoader::dispatchDidReceiveResponse): Ditto. (WebCore::FrameLoader::dispatchDidReceiveContentLength): Ditto. (WebCore::FrameLoader::dispatchDidFinishLoading): Ditto. (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache): Ditto.

• page/ContextMenuController.h:
• page/ContextMenuController.cpp: (WebCore::ContextMenuController::ContextMenuController): Removed unneeded and unused Page* parameter. (WebCore::openNewWindow): Added null check. (WebCore::ContextMenuController::contextMenuItemSelected): Ditto.

• page/InspectorController.h: (WebCore::InspectorController::pageDestroyed): Added. Since this object is owned by the Page and has a back-pointer to it, it needs an explicit disconnect. There's already a higher-level one, but this is more reliable than that.
• page/InspectorController.cpp: (WebCore::InspectorController::windowScriptObjectAvailable): Added null check. (WebCore::InspectorController::windowUnloading): Ditto.

• page/Page.cpp: (WebCore::Page::Page): Updated for change in parameters of ContextMenuController constructor. (WebCore::Page::~Page): Added call to InspectorController pageDestroyed().

• page/Chrome.cpp: Updated includes.
• page/DragController.cpp: Ditto.

11:47 AM Changeset in webkit [24155] by darin

• 2 edits in trunk/WebKit

Reviewed by John Sullivan.

• <rdar://problem/5321953> remove workaround for fixed AppKit mouse moved bug

• WebView/WebHTMLView.mm: Put the workaround for bug 3429631 inside an ifdef BUILDING_ON_TIGER.

10:44 AM Changeset in webkit [24154] by bdash

• 1 copy in tags/WebKit-419.3/WebKit

New tag (part 2).

10:43 AM Changeset in webkit [24153] by bdash

• 1 add in tags/WebKit-419.3

New tag (part 1).

10:42 AM Changeset in webkit [24152] by bdash

• 1 copy in tags/WebCore-418.23/WebCore

New tag (part 2).

10:42 AM Changeset in webkit [24151] by bdash

• 1 add in tags/WebCore-418.23

New tag (part 1).

10:39 AM Changeset in webkit [24150] by bdash

• 4 edits in branches/Safari-2.0-system

Versioning.

9:39 AM Changeset in webkit [24149] by staikos

• 2 edits in trunk/WebCore

Patch from Adam Treat to make the scroll wheel behave sanely

9:25 AM Changeset in webkit [24148] by ggaren

• 4 edits
  5 adds in trunk

LayoutTests:

Reviewed by Maciej Stachowiak.

• fast/events/onload-after-document-close-no-subresource-expected.txt: Added.
• fast/events/onload-after-document-close-no-subresource.html: Added.
• fast/events/onload-after-document-close-with-subresource-expected.txt: Added.
• fast/events/onload-after-document-close-with-subresource.html: Added.
• fast/events/resources/onload-image.png: Added.

WebCore:

Reviewed by Maciej Stachowiak.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=13241 | <rdar://problem/5126396>
onload fires before content is finished loading (woot.com)

• dom/Document.cpp: (WebCore::Document::close): Try to go through the normal "Am I done loading?" machinery before dispatching the load event. As the comment indicates, we can't do this in all cases, so the fix isn't perfect. However, a perfect solution would require much riskier sweeping changes to the loader, which are best left for later, I think.

• xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Removed a slightly worse solution to the same problem.

3:25 AM Changeset in webkit [24147] by bdash

• 2 edits in trunk/WebKitQt

2007-07-10 Mark Rowe <​mrowe@apple.com>

Qt build fix after r24126.

• Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript):

2:21 AM Changeset in webkit [24146] by rwlbuis

• 28 edits
  6 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=8007
createElement() and XHTML (A dynamically created table not rendered as such)

Follow the HTML5 rules of making the name lowercase and then
creating the element in the xhtml namespace.

1:20 AM Changeset in webkit [24145] by bdash

• 2 edits in branches/Safari-2.0-dashboard/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23529 from ToT to Safari-2.0-dashboard.

2007-06-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>

• loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.

• platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.

1:20 AM Changeset in webkit [24144] by bdash

• 2 edits in branches/Safari-2.0-dashboard/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r18365 from ToT to Safari-2.0-dashboard.

2006-12-20 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

Fixed <rdar://problem/4809825>. We need to check isSafeScript when converting
a Location to string.

It's really a bug, and poor design, for objects to override toString.
Subclasses that want custom toString implementations should add a toString
function to their prototypes instead of overriding the JavaScript ToString
operation. Following this design pattern would have avoided this bug in the
first place.

• bindings/js/kjs_window.cpp: (KJS::Location::toString):

1:20 AM Changeset in webkit [24143] by bdash

• 3 edits in branches/Safari-2.0-dashboard/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19551 from ToT to Safari-2.0-dashboard.

2007-02-10 Maciej Stachowiak <​mjs@apple.com>

Reviewed by me, patch from Ian Eng (cleaned up by me some).

• fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)

Test case: fast/dom/Window/window-appendages-cleared.html

• bindings/js/kjs_window.cpp: (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear):
• bindings/js/kjs_window.h:

1:20 AM Changeset in webkit [24142] by bdash

• 2 edits in branches/Safari-2.0-dashboard/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19126 from ToT to Safari-2.0-dashboard.

2007-01-25 Dirk Mueller <​mueller@kde.org>

Reviewed and merged by Beth.

Fix for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)

This is equivalent to commit 626791 in the KDE tree. Basically, the
patch allows comment parsing in titles to avoid capturing a
<script> tag by accident.

• html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment):

1:20 AM Changeset in webkit [24141] by bdash

• 2 edits in branches/Safari-2.0-dashboard/WebKit

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23963 from ToT to Safari-2.0-dashboard.

2007-07-03 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

• Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: ​http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):

1:10 AM Changeset in webkit [24140] by bdash

• 2 edits in branches/Safari-1-3-branch/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23529 from ToT to Safari-1-3-branch.

2007-06-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>

• loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.

• platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.

1:10 AM Changeset in webkit [24139] by bdash

• 3 edits in branches/Safari-1-3-branch/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19551 from ToT to Safari-1-3-branch.

2007-02-10 Maciej Stachowiak <​mjs@apple.com>

Reviewed by me, patch from Ian Eng (cleaned up by me some).

• fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)

Test case: fast/dom/Window/window-appendages-cleared.html

• bindings/js/kjs_window.cpp: (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear):
• bindings/js/kjs_window.h:

1:10 AM Changeset in webkit [24138] by bdash

• 2 edits in branches/Safari-1-3-branch/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19126 from ToT to Safari-1-3-branch.

2007-01-25 Dirk Mueller <​mueller@kde.org>

Reviewed and merged by Beth.

Fix for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)

This is equivalent to commit 626791 in the KDE tree. Basically, the
patch allows comment parsing in titles to avoid capturing a
<script> tag by accident.

• html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment):

1:10 AM Changeset in webkit [24137] by bdash

• 2 edits in branches/Safari-1-3-branch/WebKit

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23963 from ToT to Safari-1-3-branch.

2007-07-03 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

• Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: ​http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):

1:08 AM Changeset in webkit [24136] by bdash

• 2 edits in branches/Safari-2.0-system/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23529 from ToT to Safari-2.0-system.

2007-06-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>

• loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.

• platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.

1:08 AM Changeset in webkit [24135] by bdash

• 2 edits in branches/Safari-2.0-system/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r18365 from ToT to Safari-2.0-system.

2006-12-20 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

Fixed <rdar://problem/4809825>. We need to check isSafeScript when converting
a Location to string.

It's really a bug, and poor design, for objects to override toString.
Subclasses that want custom toString implementations should add a toString
function to their prototypes instead of overriding the JavaScript ToString
operation. Following this design pattern would have avoided this bug in the
first place.

• bindings/js/kjs_window.cpp: (KJS::Location::toString):

1:08 AM Changeset in webkit [24134] by bdash

• 3 edits in branches/Safari-2.0-system/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19551 from ToT to Safari-2.0-system.

2007-02-10 Maciej Stachowiak <​mjs@apple.com>

Reviewed by me, patch from Ian Eng (cleaned up by me some).

• fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)

Test case: fast/dom/Window/window-appendages-cleared.html

• bindings/js/kjs_window.cpp: (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear):
• bindings/js/kjs_window.h:

1:08 AM Changeset in webkit [24133] by bdash

• 2 edits in branches/Safari-2.0-system/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19126 from ToT to Safari-2.0-system.

2007-01-25 Dirk Mueller <​mueller@kde.org>

Reviewed and merged by Beth.

Fix for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)

This is equivalent to commit 626791 in the KDE tree. Basically, the
patch allows comment parsing in titles to avoid capturing a
<script> tag by accident.

• html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment):

1:08 AM Changeset in webkit [24132] by bdash

• 2 edits in branches/Safari-2.0-system/WebKit

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23963 from ToT to Safari-2.0-system.

2007-07-03 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

• Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: ​http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):

Jul 9, 2007:

6:43 PM Changeset in webkit [24131] by staikos

• 6 edits
  1 add in trunk/WebCore

Patch from Qing Zhao to add context menu support for Qt.

4:38 PM Changeset in webkit [24130] by darin

• 2 edits in trunk/WebKitTools

• Scripts/run-webkit-tests: Moved leaks from Tiger that are marked as fixed in Leopard to a Tiger-only section.

4:23 PM Changeset in webkit [24129] by aliceli1

• 10 edits in trunk

LayoutTests:

• win/Skipped: removed one test from skipped list to see whether it will pass with the new DOM Paste API change that is being added simultaneously.

WebKitTools:

Reviewed by Adam Roben.

setting DOM Paste Allowed Pref

• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initializePreferences):

win:

Reviewed by Adam Roben.

Adding DOM Paste Allowed preference, setters and getters
for the purpose of layout tests.

• Interfaces/IWebPreferences.idl:
• WebPreferenceKeysPrivate.h:
• WebPreferences.cpp: (WebPreferences::isDOMPasteAllowed): (WebPreferences::setDOMPasteAllowed):
• WebPreferences.h:
• WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences):

4:19 PM Changeset in webkit [24128] by andersca

• 2 edits in trunk/WebKit/win

Build fix.

• WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString):

4:18 PM Changeset in webkit [24127] by andersca

• 2 edits in trunk/WebCore

Build fix.

• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):

3:10 PM Changeset in webkit [24126] by andersca

• 10 edits in trunk/WebCore

Reviewed by Geoff.

Get rid of the node argument in our various script execution functions.

• bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate):
• bindings/js/kjs_proxy.h:
• bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute):
• dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): (WebCore::XMLTokenizer::notifyFinished):
• html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::evaluateScript):
• html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
• loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::replaceContentsWithScriptResult): (WebCore::FrameLoader::executeScript):
• loader/FrameLoader.h:
• page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):

3:06 PM Changeset in webkit [24125] by kmccullo

• 1 edit
  20 adds in trunk/WebKitTools

Reviewed by Adam, Sam, and Ada.

• Inital checkin of Drosera for Win. This isn't pretty and doesn't connect to Safari but debug builds and runs.

• Drosera/Images/Drosera.ico: Added.
• Drosera/Images/small.ico: Added.
• Drosera/win: Added.
• Drosera/win/BaseDelegate.h: Added. (BaseDelegate::QueryInterface): (BaseDelegate::didFinishLoadForFrame): (BaseDelegate::windowScriptObjectAvailable): (BaseDelegate::didStartProvisionalLoadForFrame): (BaseDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): (BaseDelegate::didFailProvisionalLoadWithError): (BaseDelegate::didCommitLoadForFrame): (BaseDelegate::didReceiveTitle): (BaseDelegate::didReceiveIcon): (BaseDelegate::didFailLoadWithError): (BaseDelegate::didChangeLocationWithinPageForFrame): (BaseDelegate::willPerformClientRedirectToURL): (BaseDelegate::didCancelClientRedirectForFrame): (BaseDelegate::willCloseFrame): (BaseDelegate::createWebViewWithRequest): (BaseDelegate::webViewShow): (BaseDelegate::webViewClose): (BaseDelegate::webViewFocus): (BaseDelegate::webViewUnfocus): (BaseDelegate::webViewFirstResponder): (BaseDelegate::makeFirstResponder): (BaseDelegate::setStatusText): (BaseDelegate::webViewStatusText): (BaseDelegate::webViewAreToolbarsVisible): (BaseDelegate::setToolbarsVisible): (BaseDelegate::webViewIsStatusBarVisible): (BaseDelegate::setStatusBarVisible): (BaseDelegate::webViewIsResizable): (BaseDelegate::setResizable): (BaseDelegate::setFrame): (BaseDelegate::webViewFrame): (BaseDelegate::setContentRect): (BaseDelegate::webViewContentRect): (BaseDelegate::runJavaScriptAlertPanelWithMessage): (BaseDelegate::runJavaScriptConfirmPanelWithMessage): (BaseDelegate::runJavaScriptTextInputPanelWithPrompt): (BaseDelegate::runBeforeUnloadConfirmPanelWithMessage): (BaseDelegate::runOpenPanelForFileButtonWithResultListener): (BaseDelegate::mouseDidMoveOverElement): (BaseDelegate::contextMenuItemsForElement): (BaseDelegate::validateUserInterfaceItem): (BaseDelegate::shouldPerformAction): (BaseDelegate::dragDestinationActionMaskForDraggingInfo): (BaseDelegate::willPerformDragDestinationAction): (BaseDelegate::dragSourceActionMaskForPoint): (BaseDelegate::willPerformDragSourceAction): (BaseDelegate::contextMenuItemSelected): (BaseDelegate::hasCustomMenuImplementation): (BaseDelegate::trackCustomPopupMenu): (BaseDelegate::measureCustomMenuItem): (BaseDelegate::drawCustomMenuItem): (BaseDelegate::addCustomMenuDrawingData): (BaseDelegate::cleanUpCustomMenuDrawingData): (BaseDelegate::canTakeFocus): (BaseDelegate::takeFocus): (BaseDelegate::registerUndoWithTarget): (BaseDelegate::removeAllActionsWithTarget): (BaseDelegate::setActionTitle): (BaseDelegate::undo): (BaseDelegate::redo): (BaseDelegate::canUndo): (BaseDelegate::canRedo):
• Drosera/win/DebuggerApplication.cpp: Added. (DebuggerApplication::serverLoaded): (DebuggerApplication::serverUnloaded): (DebuggerApplication::attach): (DebuggerApplication::numberOfRowsInTableView): (DebuggerApplication::tableView):
• Drosera/win/DebuggerApplication.h: Added. (DebuggerApplication::DebuggerApplication): (DebuggerApplication::knownServers):
• Drosera/win/DebuggerObjectCallbacks.cpp: Added. (breakpointEditorHTMLCallback): (currentFunctionStackCallback): (doubleClickMillisecondsCallback): (evaluateScript_inCallFrame_Callback): (isPausedCallback): (localScopeVariableNamesForCallFrame_Callback): (pauseCallback): (resumeCallback): (stepIntoCallback): (valueForScopeVariableNamed_inCallFrame_Callback): (staticFunctions):
• Drosera/win/DebuggerObjectCallbacks.h: Added.
• Drosera/win/Drosera.cpp: Added. (_tWinMain): (RegisterDroseraClass): (DroseraWndProc): (About): (Attach): (Drosera::Drosera): (Drosera::initUI): (Drosera::QueryInterface): (Drosera::AddRef): (Drosera::Release): (Drosera::didFinishLoadForFrame): (getDroseraJSClass): (Drosera::windowScriptObjectAvailable): (Drosera::webViewClose): (Drosera::validateUserInterfaceItem): (Drosera::runJavaScriptAlertPanelWithMessage): (Drosera::onSize):
• Drosera/win/Drosera.h: Added. (Drosera::webViewLoaded):
• Drosera/win/Drosera.vcproj: Added.
• Drosera/win/Drosera.vcproj/Drosera.rc: Added.
• Drosera/win/Drosera.vcproj/Drosera.vcproj: Added.
• Drosera/win/Drosera.vcproj/debug.vsprops: Added.
• Drosera/win/Drosera.vcproj/release.vsprops: Added.
• Drosera/win/HelperFunctions.h: Added. (CFStringToBSTR):
• Drosera/win/Info.plist: Added.
• Drosera/win/resource.h: Added.
• Drosera/win/stdafx.cpp: Added.
• Drosera/win/stdafx.h: Added.

2:25 PM Changeset in webkit [24124] by staikos

• 2 edits in trunk/WebKitQt

Patch from Eli Fidler to properly decode data: urls.

2:23 PM Changeset in webkit [24123] by justing

• 7 edits
  1 add
  1 delete in trunk

LayoutTests:

Rolling the fix for 5310404 back in now that 5310404 has been fixed in Mail.

• editing/deleting/4845371-expected.checksum:
• editing/deleting/4845371-expected.txt:
• editing/deleting/4845371.html:
• editing/deleting/5126166-expected.txt:
• editing/deleting/5290534.html: Added.
• editing/deleting/5290534.html-disabled: Removed.

WebCore:

Rolling the fix for 5290534 back in now that 5310404 has been fixed in Mail.

• editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete):

2:08 PM Changeset in webkit [24122] by ggaren

• 4 edits in trunk/WebCore

Reviewed by Anders Carlsson.

A little more FrameLoader cleanup while working on <rdar://problem/5126396>.

Rename: "checkEmitLoadEvent" => "checkCallImplicitClose" because the function
doesn't emit the load event; it just calls implicitClose.

Rename: "m_wasLoadEventEmitted" => "m_didCallImplicitClose" because the variable
tracks whether implicitClose was called.

• dom/Document.cpp: (WebCore::Document::implicitClose): Turned 12 lines of code into 6, adding ASSERT.
• loader/FrameLoader.h: Removed bogus declaration of non-existent emitLoadEvent().

2:06 PM Changeset in webkit [24121] by brmorris

• 2 edits in S60/trunk/WebKit

brmorris, rs'd by sachin

DESC: remove a compile warning by generating version info earlier

in the build process.

1:27 PM Changeset in webkit [24120] by justing

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by John.

<rdar://problem/5156801> REGRESSION: Crash when deleting table content in Leopard Mail

• editing/deleting/5156801-expected.checksum: Added.
• editing/deleting/5156801-expected.png: Added.
• editing/deleting/5156801-expected.txt: Added.
• editing/deleting/5156801.html: Added.

WebCore:

Reviewed by John.

REGRESSION: Crash when deleting table content in Leopard Mail

• editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): Use a RefPtr for the next node to delete, in case it is destroyed when the current node is deleted. In the crash reported in the radar, we crash because the next node is the div that holds the delete button and it's destroyed when the node that contains the selection is removed.

12:41 PM Changeset in webkit [24119] by staikos

• 18 edits in trunk

Patch from Adam Treat to convert QWebFrame from QFrame to QObject. Fixes many
regressions from the previous patch.

11:28 AM Changeset in webkit [24118] by andersca

• 11 edits
  2 adds in trunk

LayoutTests:

Reviewed by Oliver.

<rdar://problem/4954319>
Acrobat 7 / Safari crash: CrashTracer: 99 crashes in Safari at
com.apple.WebCore: WebCore::NetscapePlugInStreamLoader::isDone const + 0

Add tests.

• plugins/return-error-from-new-stream-callback-in-full-frame-plugin-expected.txt: Added.
• plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html: Added.

WebCore:

Reviewed by Oliver.

Add DocumentLoader::isLoadingMainResource.

• WebCore.exp:

WebKit:

Reviewed by Oliver.

<rdar://problem/4954319>
Acrobat 7 / Safari crash: CrashTracer: 99 crashes in Safari at
com.apple.WebCore: WebCore::NetscapePlugInStreamLoader::isDone const + 0

Add a new initWithFrameLoader: method to WebNetscapePluginStream which is to be used when
the stream is a "fake" stream for full frame plug-ins.

• Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedResponse:]):
• Plugins/WebNetscapePluginStream.h:
• Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream initWithFrameLoader:]): (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream cancelLoadWithError:]): (-[WebNetscapePluginStream stop]):
• WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createFrame):

WebKitTools:

Reviewed by Oliver.

<rdar://problem/4954319>
Acrobat 7 / Safari crash: CrashTracer: 99 crashes in Safari at
com.apple.WebCore: WebCore::NetscapePlugInStreamLoader::isDone const + 0

If the src url is "data:application/x-webkit-test-netscape,returnerrorfromnewstream",
return an error from NPP_NewStream.

• DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginAllocate):
• DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
• DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_New): (NPP_NewStream):

10:45 AM Changeset in webkit [24117] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Darin

• fixed <rdar://problem/5320208> WebKit should prevent Time Machine from backing up WebKit clients' icon databases

• Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): Re-added the code to exclude the icon database from backups. We now do this at the same time we (try to) import the old icon database format, which happens only once per icon database's lifetime. (-[WebIconDatabase _importToWebCoreFormat]): Assert that we haven't imported yet rather than bailing out. It's now the caller's responsibility to check whether we've imported yet.

10:44 AM Changeset in webkit [24116] by sullivan

• 1 edit in trunk/WebCore/ChangeLog

added missing Reviewer to previous checkin

10:43 AM Changeset in webkit [24115] by sullivan

• 2 edits in trunk/WebCore

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj: exported String::createCFString, needed for <rdar://problem/5320208>

10:21 AM Changeset in webkit [24114] by staikos

• 2 edits in trunk/WebKitQt

Fix a minor memory leak in the loader

9:52 AM Changeset in webkit [24113] by staikos

• 2 edits in trunk/WebKitQt

Fix a massive memory leak in the loader.

8:04 AM Changeset in webkit [24112] by yongjzha

• 2 edits in S60/branches/3.1m/JavaScriptCore

ligman, reviewed by Yongjun Zhang

DESC: Character class array is defined to 32. If we don't limit characters to 255 an overflow occurs.
​http://bugs.webkit.org/show_bug.cgi?id=14435

• pcre/pcre.c: (compile_branch): (match):

8:01 AM Changeset in webkit [24111] by yongjzha

• 2 edits in S60/trunk/JavaScriptCore

ligman, reviewed by Yongjun Zhang

DESC: Character class array is defined to 32. If we don't limit characters to 255 an overflow occurs.
​http://bugs.webkit.org/show_bug.cgi?id=14435

• pcre/pcre.c: (compile_branch): (match):

7:54 AM Changeset in webkit [24110] by yongjzha

• 4 edits in S60/branches/3.1m/WebCore

2007-06-29 bujtas <​zbujtas@gmail.com>

Reviewed by Yongjun
DESC: ref images right before switching to the final document,
so they dont get deleted.
​http://bugs.webkit.org/show_bug.cgi?id=14464

WARNING: NO TEST CASES ADDED OR CHANGED

• khtml/khtml_part.cpp: (KHTMLPart::switchToFinalDoc):
• khtml/misc/loader.h: (khtml::):
• khtml/misc/loader_client.h: (khtml::DummyCachedObjectClient::~DummyCachedObjectClient): (khtml::DummyCachedObjectClient::setPixmap): (khtml::DummyCachedObjectClient::setStyleSheet): (khtml::DummyCachedObjectClient::setXBLDocument): (khtml::DummyCachedObjectClient::notifyFinished):

7:53 AM Changeset in webkit [24109] by yongjzha

• 4 edits in S60/trunk/WebCore

2007-06-29 bujtas <​zbujtas@gmail.com>

Reviewed by Yongjun
DESC: ref images right before switching to the final document,
so they dont get deleted.
​http://bugs.webkit.org/show_bug.cgi?id=14464

WARNING: NO TEST CASES ADDED OR CHANGED

• khtml/khtml_part.cpp: (KHTMLPart::switchToFinalDoc):
• khtml/misc/loader.h: (khtml::):
• khtml/misc/loader_client.h: (khtml::DummyCachedObjectClient::~DummyCachedObjectClient): (khtml::DummyCachedObjectClient::setPixmap): (khtml::DummyCachedObjectClient::setStyleSheet): (khtml::DummyCachedObjectClient::setXBLDocument): (khtml::DummyCachedObjectClient::notifyFinished):

7:50 AM Changeset in webkit [24108] by staikos

• 4 edits in trunk/WebKitQt

Rework much of WebCoreHttp to make it more stable and support Proxy and SSL.

12:57 AM Changeset in webkit [24107] by mjs

• 1 edit
  1 add in trunk/WebCore

Reviewed by Maciej.

Test case for the bug below, which is ​http://bugs.webkit.org/show_bug.cgi?id=14207

• manual-tests/flash-unload-tab.html: Added.

12:39 AM Changeset in webkit [24106] by mjs

• 4 edits in trunk

JavaScriptCore:

Reviewed by Oliver.

• JavaScriptCore part of fix for: <rdar://problem/5295734> Repro crash closing tab/window @ maps.google.com in WTF::HashSet<KJS::RuntimeObjectImp*, WTF::PtrHash<KJS::RuntimeObjectImp*>, WTF::HashTraits<KJS::RuntimeObjectImp*> >::add + 11

• JavaScriptCore.exp: Added needed export.

WebCore:

Reviewed by Oliver.

<rdar://problem/5295734> Repro crash closing tab/window @ maps.google.com in WTF::HashSet<KJS::RuntimeObjectImp*, WTF::PtrHash<KJS::RuntimeObjectImp*>, WTF::HashTraits<KJS::RuntimeObjectImp*> >::add + 11

Automated test case is not possible. Did not bother with manual test this time.

• bindings/js/kjs_dom.cpp: (WebCore::getRuntimeObject): Check that runtime root isn't null, as well as instance; this should cover the case where the plugin is already shut down and onunload time.

Jul 8, 2007:

11:29 PM Changeset in webkit [24105] by mjs

• 5 edits
  1 add in trunk/WebCore

Reviewed by Sam.

• fixed <rdar://problem/5220706> REGRESSION (TOT): repro crash in -[WebView(WebViewInternal) _addObject:forIdentifier:] [14425] ​http://bugs.webkit.org/show_bug.cgi?id=14425

• bindings/js/kjs_window.cpp: (KJS::createWindow): No longer take an immediate argument - always do immediate loads on a newly created Window. Also, do a load of "" to make sure that the right info makes it to the app. (KJS::showModalDialog): Updated for above. (KJS::WindowFunc::callAsFunction): Updated for above.
• dom/Document.cpp: (WebCore::Document::shouldBeAllowedToLoadLocalResources): If our URL is about:blank, we're allowed if our opener is (since the opener must have written the contents).
• loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): Add a variant which takes a KURL, which it expects to be pre-completed. This is to avoid completing "" to the opener URL. (WebCore::FrameLoader::urlSelected): Allow loading empty URLs.
• loader/FrameLoader.h:

Test case is manual only, since it takes particular app behavior to reproduce:

• manual-tests/new-window-subresource-crash.html: Added.

3:43 PM Changeset in webkit [24104] by kevino

• 2 edits in branches/wx-port-alpha/trunk/WebKit/wx/bindings/python

Expose WebView events to the Python bindings.

2:02 PM Changeset in webkit [24103] by bdash

• 2 edits in trunk/WebCore

2007-07-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

• fix leaks introduced in r24099

• dom/Element.cpp: (WebCore::Element::~Element): Do not delete the cached computed style here. (WebCore::Element::detach): Delete the computed style here instead. (WebCore::Element::computedStyle): Removed a redundant ref() which was causing the leak. Changed to return 0 if the element is not attached, because in that case there is currently no way to tell when to delete the computed style.

12:36 PM Changeset in webkit [24102] by bdash

• 2 edits in trunk/WebKitTools

2007-07-08 Mark Rowe <​mrowe@apple.com>

Change name from WebKit/Qt to WebKit.

• CodeCoverage/regenerate-coverage-display:

11:55 AM Changeset in webkit [24101] by sullivan

• 2 edits in trunk/WebKit

• Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): Removed the code to exclude the icon database from backups. We still want to do this, but in a way that only runs once ever, instead of once per launch, due to performance concerns.

11:47 AM Changeset in webkit [24100] by bdash

• 3 edits in trunk/WebKitTools

Mark code coverage scripts as executable.

10:51 AM Changeset in webkit [24099] by weinig

• 7 edits
  2 adds in trunk

LayoutTests:

Reviewed by Darin.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=12384 getComputedStyle with td.style.display='none' reports for all properties except display

• fast/css/computed-style-without-renderer-expected.txt: Added.
• fast/css/computed-style-without-renderer.html: Added.

WebCore:

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12384 getComputedStyle with td.style.display='none' reports for all properties except display

Test: fast/css/computed-style-without-renderer.html

Implement rich computed style for elements that do not have a renderer.

• css/CSSComputedStyleDeclaration.cpp: (WebCore::getPositionOffsetValue): Changed to take a RenderStyle instead of a RenderObject. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed to use the computed style returned by the node instead of going through the renderer. Changed properties that compute by measuring the renderer to fall back on returning the length from the RenderStyle if a renderer does not exist. (WebCore::CSSComputedStyleDeclaration::length): Changed to return the number of properties we can compute even if the element has no renderer. (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties): Changed to use the computed style returned by the node instead of going through the renderer.
• dom/Element.cpp: (WebCore::ElementRareData::ElementRareData): Added a computed style member, used to cache computed style for elements that do not have a renderer. (WebCore::ElementRareData::resetComputedStyle): Added. (WebCore::Element::~Element): Delete the cached computed style. (WebCore::Element::recalcStyle): Added code to delete the cached computed style when necessary. (WebCore::Element::computedStyle): Added. Returns the style used in rendering the element, if available. Otherwise uses the style selector to compute style for the element.
• dom/Element.h:
• dom/Node.cpp: (WebCore::Node::computedStyle): Added. This method returns either the style used in rendering the node, or the style that would be used if the node had a renderer.
• dom/Node.h:

10:40 AM Changeset in webkit [24098] by bdash

• 2 edits in trunk/WebCore

2007-07-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=14544 Scroll wheel events are ignored when the cursor is over an iframe's border

• page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passWheelEventToWidget): Changed to return false if the event coordinates are not inside the widget's NSView hierarchy.

8:37 AM Changeset in webkit [24097] by rwlbuis

• 10 edits
  4 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=10752
The inspector should not respond to Make Text Smaller/Bigger commands

Use the -webkit-text-size-adjust property to ignore text sizing
and do not take the zoom factor into account for line height when
-webkit-text-size-adjust is set to none.

4:49 AM Changeset in webkit [24096] by darin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• fix <rdar://problem/5318994> Integer overflow in WebCore's Base64.cpp:base64Encode

• platform/Base64.cpp: (WebCore::base64Encode): Check against a maximum size. (WebCore::base64Decode): Ditto.

4:47 AM Changeset in webkit [24095] by darin

• 8 edits in trunk

WebCore:

Reviewed by Maciej.

• fix <rdar://problem/5124665> WebCore secondary-thread assertion should use linked-on-or-after check instead of building on Tiger check

• platform/ThreadCheck.h: Renamed _WebCoreThreadViolationCheck to reportThreadViolation since it's in the WebCore namespace and also we shouldn't use leading underscores since those are reserved for the compiler and standard library. Added a new function named setDefaultThreadViolationBehavior and an enum for the parameter. Removed the threadViolationIsException parameter from WebCoreReportThreadViolation since we use a global variable for it now. Got rid of the unnecessary use of do while (0) in the WebCoreThreadViolationCheck macro -- since it's only a single function call it's already a statement and doesn't need to be turned into one with the do while (0) trick.

• platform/mac/ThreadCheck.mm: (WebCore::readThreadViolationBehaviorFromUserDefaults): Moved the code to read from NSUserDefaults into this helper function. Changed it to use stringForKey instead of objectForKey so we don't get a "method not found" if someone puts something other than a string in there. Updated to use the new globals. (WebCore::setDefaultThreadViolationBehavior): Added. (WebCore::reportThreadViolation): Simplified, now that most of the work is in the readThreadViolationBehaviorFromUserDefaults function. (WebCoreReportThreadViolation): Changed to use a global variable instead of parameter to determine how to report a violation. Added LogOnFirstThreadViolation, which will log only once for each function that violates.

• WebCore.exp: Updated for above changes.

WebKit:

Reviewed by Maciej.

• fix <rdar://problem/5124665> WebCore secondary-thread assertion should use linked-on-or-after check instead of building on Tiger check

• Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITH_MAIN_THREAD_EXCEPTIONS.

• WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): In first-time initialization block, check for binaries linked against older versions of WebKit, and set the default thread violation behavior to LogOnFirstThreadViolation.

• WebView/WebView.mm: (+[WebView initialize]): Improved comments.

2:54 AM Changeset in webkit [24094] by bdash

• 3 edits
  4 adds in trunk

2007-07-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=14221 Repro crash (ASSERTION FAILED: oldText in RenderBlock::updateFirstLetter() during relayout of :before content with first-letter style)

Test: fast/css-generated-content/before-with-first-letter.html

• rendering/RenderContainer.cpp: (WebCore::RenderContainer::updateBeforeAfterContentForContainer): If a child of the existing 'before' container is not text, do not assume that it is an image, since it can also be an inline wrapping a first-letter. In that case, do not update its style (so in particular, keep it a FIRST_LETTER type style) and leave it to updateFirstLetter() to take care of.

2007-07-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=14221 Repro crash (ASSERTION FAILED: oldText in RenderBlock::updateFirstLetter() during relayout of :before content with first-letter style)

• fast/css-generated-content/before-with-first-letter-expected.checksum: Added.
• fast/css-generated-content/before-with-first-letter-expected.png: Added.
• fast/css-generated-content/before-with-first-letter-expected.txt: Added.
• fast/css-generated-content/before-with-first-letter.html: Added.

Jul 7, 2007:

6:40 PM Changeset in webkit [24093] by weinig

• 4 edits in trunk

LayoutTests:

Reviewed by Oliver Hunt.

• update results after removing extraneous calls to isSafeScript for readonly attributes.

• http/tests/security/cross-frame-access-expected.txt:

WebCore:

Reviewed by Oliver Hunt.

Bailout early in Window::put() if attribute is readonly to avoid
extra calls to isSafeScript().

• bindings/js/kjs_window.cpp: (KJS::Window::put):

2:35 PM Changeset in webkit [24092] by darin

• 4 edits in trunk/LayoutTests

• updated results (I changed the test at the last minute, but didn't regenerate results)

• fast/canvas/fill-stroke-clip-reset-path-expected.checksum: Updated.
• fast/canvas/fill-stroke-clip-reset-path-expected.png: Updated.
• fast/canvas/fill-stroke-clip-reset-path-expected.txt: Updated.

1:42 PM Changeset in webkit [24091] by darin

• 4 edits
  4 adds in trunk

LayoutTests:

• test for <rdar://problem/5292364> REGRESSION: ZX Spectrum 3.0 widget - graphic anomalies in widget window frame

• fast/canvas/fill-stroke-clip-reset-path-expected.checksum: Added.
• fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
• fast/canvas/fill-stroke-clip-reset-path-expected.txt: Added.
• fast/canvas/fill-stroke-clip-reset-path.html: Added.

WebCore:

Reviewed by Oliver Hunt.

• fix <rdar://problem/5292364> REGRESSION: ZX Spectrum 3.0 widget - graphic anomalies in widget window frame

Updated Dashboard quirk so it affects fill, stroke, and clip, rather than just stroke.

Test: fast/canvas/fill-stroke-clip-reset-path.html

• html/CanvasRenderingContext2D.h: Added clearPathForDashboardBackwardCompatibilityMode.
• html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::clearPathForDashboardBackwardCompatibilityMode): Added. (WebCore::CanvasRenderingContext2D::fill): Call the new function. (WebCore::CanvasRenderingContext2D::stroke): Replaced in-line code with a call to the new function. (WebCore::CanvasRenderingContext2D::clip): Call the new function.

1:14 PM Changeset in webkit [24090] by darin

• 4 edits
  4 adds in trunk

LayoutTests:

Reviewed by Darin.

Testcase for:
​http://bugs.webkit.org/show_bug.cgi?id=8994
Canvas doesn't reset on resize

• fast/canvas/canvas-resize-reset-expected.checksum: Added.
• fast/canvas/canvas-resize-reset-expected.png: Added.
• fast/canvas/canvas-resize-reset-expected.txt: Added.
• fast/canvas/canvas-resize-reset.html: Added.

WebCore:

Reviewed and tweaked by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=8994
Canvas doesn't reset on resize

Also reset the rendering context when resetting the canvas.

• html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::reset): (WebCore::HTMLCanvasElement::drawingContext):

3:11 AM Changeset in webkit [24089] by ap

• 2 edits in trunk/LayoutTests

Fixed a mismatch between test output and expected results (a typo that was only fixed in the former).

• fast/loader/early-load-cancel-expected.txt:

3:00 AM Changeset in webkit [24088] by ap

• 7 edits
  5 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14525
Support exslt:node-set()

Test: fast/xsl/exslt-node-set.xml

• xml/XSLTExtensions.cpp: Added. (WebCore::exsltNodeSetFunction): A copy of exslt:node-set() implementation from libexslt 1.1.11 (shipped with Tiger). (WebCore::registerXSLTExtensions): This function registers any WebCore-provided extensions on a context. Currently, the only extension is exslt:node-set().
• xml/XSLTExtensions.h: Added.

• xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::transformToString): Register extensions when creating a context.

• WebCore.pro:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• WebCoreSources.bkl: Add XSLTExtensions.{h,cpp} to projects.

Jul 6, 2007:

11:29 PM Changeset in webkit [24087] by mjs

• 3 edits
  3 adds in trunk

LayoutTests:

Reviewed by Oliver.

• test case for <rdar://problem/5133420> ASSERT in WebDocumentLoaderMac::decreaseLoadCount() un-discarding Gmail message

• fast/loader/early-load-cancel-expected.txt: Added.
• fast/loader/early-load-cancel.html: Added.
• fast/loader/resources/early-load-cancel-inner.html: Added.

WebCore:

Reviewed by Oliver.

• fixed <rdar://problem/5133420> ASSERT in WebDocumentLoaderMac::decreaseLoadCount() un-discarding Gmail message

test case: fast/loader/early-load-cancel.html

• loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didCancel): Don't send cancel-related client callbacks if we never even sent willSendRequest because we were deferred.

9:28 PM Changeset in webkit [24086] by bdash

• 2 edits in trunk/WebKitTools

2007-07-07 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver.

• DumpRenderTree/DumpRenderTree.m: (convertWebResourceResponseToDictionary): Fix leak of two NSMutableString's introduced in r24076.

9:01 PM Changeset in webkit [24085] by oliver

• 13 edits in trunk

WebCore:

Reviewed by Maciej.

Pulled a number of methods from WebKit and WebCoreFrameBridge into
C++ objects.

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:
• editing/Editor.cpp: (WebCore::Editor::replaceMarkedText):

From -[WebCoreFrameBridge replaceMarkedTextWithText:]

• editing/Editor.h:
• page/Frame.cpp: (WebCore::Frame::setMarkedTextRange):

Pulled platform independent logic from Mac specific implementation

(WebCore::Frame::selectRangeInMarkedText):

Converted from -[WebHTMLView _selectRangeInMarkedText:]

• page/Frame.h:
• page/mac/FrameMac.mm: (WebCore::Frame::setMarkedTextRange):

Now only does Mac specific logic when manipulating initial
NSAttributedString

• page/mac/WebCoreFrameBridge.h:
• page/mac/WebCoreFrameBridge.mm:

Removed -[WebCoreFrameBridge replaceMarkedTextWithText:]

WebKit:

Reviewed by Maciej.

<rdar://problem/5318756> Need to refactor IM/Marked text code to share logic with windows.

Moved a number of methods from WebHTMLView into WebCore.
Replaced bridge methods with calls directly into WebCore objects.

• WebKit.xcodeproj/project.pbxproj:
• WebView/WebHTMLView.mm: (-[WebHTMLView setMarkedText:selectedRange:]): Now calls WebCore object methods directly, rather than calling via the bridge.

7:37 PM Changeset in webkit [24084] by bdash

• 7 edits
  4 adds in trunk

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=14545 REGRESSION (r21854-r21869): Repro crash in RenderBlock::updateFirstLetter @ nola.com/rose/

Test: fast/css/first-letter-capitalized.html

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter): Moved the call to setFirstLetter further down so that the first letter is not destroyed if a text transform is applied to the remaining text fragment when it is add to the render tree.
• rendering/RenderText.cpp: (WebCore::RenderText::previousCharacter): Factored out of setTextInternal. (WebCore::RenderText::setTextInternal): Changed to call previousCharacter().
• rendering/RenderText.h:
• rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::previousCharacter): Override to return the character in the original string before the start of the fragment.
• rendering/RenderTextFragment.h:

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=14545 REGRESSION (r21854-r21869): Repro crash in RenderBlock::updateFirstLetter @ nola.com/rose/

• fast/css/first-letter-capitalized-expected.checksum: Added.
• fast/css/first-letter-capitalized-expected.png: Added.
• fast/css/first-letter-capitalized-expected.txt: Added.
• fast/css/first-letter-capitalized.html: Added.

7:35 PM Changeset in webkit [24083] by bdash

• 2 edits in trunk/WebCore

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Beth.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=14536 Unnecessary layout done when mousing down in text field

No test possible because there is no change in functionality.

• rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setStyle): Reset the height and the width in the old style to avoid getting a layout hint as a result of having mutated the old style during layout. (WebCore::RenderTextControl::layout): Update children's layout if an inner block's dimensions should change. This need for layout was previously masked by the bug.

6:02 PM Changeset in webkit [24082] by darin

• 2 edits in trunk/LayoutTests

• mac/leopard/Skipped: Updated bug numbers for some bugs that were duplicates.

5:27 PM Changeset in webkit [24081] by beidson

• 2 edits in trunk/WebCore

Fix builds that use IconDatabaseNone.cpp - better, this time

• loader/icon/IconDatabaseNone.cpp: (WebCore::IconDatabase::isOpen):

5:20 PM Changeset in webkit [24080] by beidson

• 2 edits in trunk/WebCore

Fix builds that use IconDatabaseNone.cpp

• loader/icon/IconDatabaseNone.cpp: (WebCore::IconDatabase::databasePath):

4:48 PM Changeset in webkit [24079] by thatcher

• 3 edits in trunk/LayoutTests

Reviewed by Adam.

<rdar://problem/5313506> Some attributed string layout tests have an extra space character on Leopard

Leopard serializes empty attribute dictionaries as "{ }", turn these into "{}" to match Tiger.

• fast/text/attributed-substring-from-range-001.html:
• mac/leopard/Skipped: Don't skip this test anymore.

4:44 PM Changeset in webkit [24078] by thatcher

• 1 edit in trunk/WebKitTools/ChangeLog

Fix typo.

4:43 PM Changeset in webkit [24077] by sullivan

• 8 edits in trunk

WebCore:

Reviewed by Brady

• WebCore part of fix for: <rdar://problem/5310739> Time Machine shouldn't back up WebKit's icon database files

• loader/icon/IconDatabase.h:
• loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::isOpen): made this method const (necessary to make IconDatabase::databasePath const) (WebCore::IconDatabase::databasePath): new method, returns SQLDatabase's path if open, otherwise empty string

• loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::open): don't append a null character to the m_path ivar. The appended null character was making the path() method return a String with a trailing null, which is bad. However, there were no callers to the path() method until now. Instead of appending a null character to the ivar, use charactersWithNullTermination() instead of characters() when opening the database.

• loader/icon/SQLDatabase.h: (WebCore::SQLDatabase::isOpen): made this method const (necessary to make IconDatabase::databasePath const) (WebCore::SQLDatabase::path): made this method const (not required for these changes, but seemed worth doing at the same time)

• WebCore.exp: added symbol for IconDatabase::databasePath

WebKit:

Reviewed by Brady

• WebKit part of fix for: <rdar://problem/5310739> Time Machine shouldn't back up WebKit's icon database files

• Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): Use CSBackupSetItemExcluded to tell Time Machine not to back up the icon database file

4:40 PM Changeset in webkit [24076] by andersca

• 15 edits in trunk

LayoutTests:

Reviewed by David Kilzer.

<rdar://problem/5313502>
Many webarchive tests fail due to different NSURLResponse serialization on Leopard

• mac/leopard/Skipped:
• webarchive/archive-with-unencoded-url-expected.txt:
• webarchive/test-body-background-expected.txt:
• webarchive/test-duplicate-resources-expected.txt:
• webarchive/test-frameset-expected.txt:
• webarchive/test-img-src-expected.txt:
• webarchive/test-input-src-expected.txt:
• webarchive/test-link-href-expected.txt:
• webarchive/test-object-data-expected.txt:
• webarchive/test-script-src-expected.txt:
• webarchive/test-table-background-expected.txt:
• webarchive/test-td-background-expected.txt:

WebKitTools:

Reviewed by David Kilzer.

<rdar://problem/5313502>
Many webarchive tests fail due to different NSURLResponse serialization on Leopard

Don't dump the serialized form of NSURLResponse. Instead, create a dictionary with the
response's attributes. Also change the JavaScript MIME type to be "text/javascript".

• DumpRenderTree/DumpRenderTree.m: (convertMIMEType): (convertWebResourceDataToString): (convertWebResourceResponseToDictionary): (serializeWebArchiveToXML):

4:22 PM Changeset in webkit [24075] by thatcher

• 5 edits in trunk

LayoutTests:

Reviewed by Oliver.

<rdar://problem/5313506> Some attributed string layout tests have an extra space character on Leopard

Don't dump the attributed string's description, this isn't helpfull for the test. Just log
the attribute names at index 0, which we expect to be nothing, to make sure the string
has no attributes.

• fast/forms/attributed-strings-expected.txt:
• fast/forms/attributed-strings.html:

WebKitTools:

Reviewed by Oliver.

Initlize the NSMutableAttributedString directly instead of creating
a NSAttributedString first.

• DumpRenderTree/TextInputController.m: (-[TextInputController attributedStringWithString:]):

3:44 PM Changeset in webkit [24074] by staikos

• 1 edit in trunk/WebCore/WebCore.pro

missed in previous checkin

3:36 PM Changeset in webkit [24073] by staikos

• 2 edits
  1 add in trunk/WebCore

Move locatizations into another file.

2:54 PM Changeset in webkit [24072] by ggaren

• 3 edits in trunk/WebCore

Reviewed by Anders Carlsson.

A little more FrameLoader cleanup while working on <rdar://problem/5126396>.

Moved url() and URL() methods next to each other to highlight their subtlety.

• loader/FrameLoader.cpp: (WebCore::FrameLoader::url):
• loader/FrameLoader.h:

2:37 PM Changeset in webkit [24071] by andersca

• 16 edits in trunk

LayoutTests:

Reviewed by David Kilzer.

Update tests.

• webarchive/archive-empty-frame-dom-expected.txt:
• webarchive/archive-empty-frame-source-expected.txt:
• webarchive/archive-with-unencoded-url-expected.txt:
• webarchive/test-body-background-expected.txt:
• webarchive/test-duplicate-resources-expected.txt:
• webarchive/test-frameset-expected.txt:
• webarchive/test-img-src-expected.txt:
• webarchive/test-input-src-expected.txt:
• webarchive/test-link-href-expected.txt:
• webarchive/test-object-data-expected.txt:
• webarchive/test-script-src-expected.txt:
• webarchive/test-table-background-expected.txt:
• webarchive/test-td-background-expected.txt:

WebKitTools:

Reviewed by David Kilzer.

Replace "Apple Computer" with "Apple" in the DTD declaration.

• DumpRenderTree/DumpRenderTree.m: (serializeWebArchiveToXML):

2:30 PM Changeset in webkit [24070] by ggaren

• 4 edits in trunk/WebCore

Reviewed by Anders Carlsson.

A little FrameLoader cleanup while working on <rdar://problem/5126396>.

Renamed endIfNotLoading() to endIfNotLoadingMainResource() because "loading"
and "loadingMainResource" have distinct meanings and this function
honors the latter.

(WebCore::FrameLoader::endIfNotLoadingMainResource): Protect after the
early return to avoid ref count churn.

• loader/FrameLoader.h: (WebCore::FrameLoader::isLoadingMainResource): Inlined this function.

2:06 PM Changeset in webkit [24069] by staikos

• 15 edits in trunk

Patch from Adam Treat to convert QWebFrame to a QFrame from a QAbstractScrollArea.

1:52 PM Changeset in webkit [24068] by andersca

• 3 edits
  2 adds in trunk

LayoutTests:

Reviewed by Mitz.

<rdar://problem/5280532>
REGRESSION: Can't access nested embed by document.name if object is not immediate parent

• plugins/embed-inside-object-expected.txt: Added.
• plugins/embed-inside-object.html: Added.

WebCore:

Reviewed by Mitz.

<rdar://problem/5280532>
REGRESSION: Can't access nested embed by document.name if object is not immediate parent

Traverse up the tree looking for an object element.

• html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::getInstance):

1:29 PM Changeset in webkit [24067] by aroben

• 2 edits in trunk/LayoutTests

Add another Leopard failure

• mac/leopard/Skipped:

11:11 AM Changeset in webkit [24066] by aroben

• 2 edits in trunk/LayoutTests

Add another crasher to the Skipped file

Also moved a test that had a bug filed about it out of the section of
unfiled failures.

• win/Skipped:

11:00 AM Changeset in webkit [24065] by andersca

• 4 edits in trunk/LayoutTests

Reviewed by Alexey.

<rdar://problem/5313518> fast/events/iframe-object-onload.html shows events out of order on Leopard

Fix test so that it doesn't matter in what order the frames/objects are loaded. This is done by keeping
the load logs in an array and sort it before dumping it.

• fast/events/iframe-object-onload-expected.txt:
• fast/events/iframe-object-onload.html:
• mac/leopard/Skipped:

10:28 AM Changeset in webkit [24064] by staikos

• 2 edits in trunk/WebCore

Don't clobber variables that are already set, resulting in a broken build.

10:08 AM Changeset in webkit [24063] by andersca

• 6 edits
  4 deletes in trunk/LayoutTests

Reviewed by Alexey.

<rdar://problem/5313512> fast/frames/frame-set-same-{location,src}.html sometimes hang on Leopard

Make these tests more robust against frames loading in a different order. Also, turn the tests
into text tests and remove them from the Leopard skipped list.

• fast/frames/frame-set-same-location-expected.checksum: Removed.
• fast/frames/frame-set-same-location-expected.png: Removed.
• fast/frames/frame-set-same-location-expected.txt:
• fast/frames/frame-set-same-location.html:
• fast/frames/frame-set-same-src-expected.checksum: Removed.
• fast/frames/frame-set-same-src-expected.png: Removed.
• fast/frames/frame-set-same-src-expected.txt:
• fast/frames/frame-set-same-src.html:
• mac/leopard/Skipped:

9:54 AM Changeset in webkit [24062] by staikos

• 2 edits in trunk/WebKitTools

Add --qmakearg=foo to make it possible to configure the build without editing
the .pro files each time.

7:56 AM Changeset in webkit [24061] by bdash

• 2 edits in trunk/WebKit

2007-07-07 Mark Rowe <​mrowe@apple.com>

Build fix. Update WebDynamicScrollBarsView.h to include methods added and used in r24060.

• WebView/WebDynamicScrollBarsView.h:

7:40 AM Changeset in webkit [24060] by thatcher

• 3 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/5236277> REGRESSION-9A458: SPI for setting scroll bar behavior doesn't work

Calling setHorizontalScrollingMode: calls updateScrollers before returning, this will cause
WebCore to reset the scrolling mode based on the CSS overflow rules. So the setAlwaysShowHorizontalScroller:
and setAlwaysShowVerticalScroller: methods needed a way to lock the scrolling mode before
calling updateScrollers.

• WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): (-[WebDynamicScrollBarsView setScrollingMode:]): (-[WebDynamicScrollBarsView setScrollingMode:andLock:]):
• WebView/WebView.mm: (-[WebView setAlwaysShowVerticalScroller:]): (-[WebView setAlwaysShowHorizontalScroller:]):

5:09 AM Changeset in webkit [24059] by mjs

• 12 edits in trunk

JavaScriptCore:

Reviewed by Antti.

• <rdar://problem/5311093> JavaScriptCore fails to build with strict-aliasing warnings

• Configurations/Base.xcconfig: Re-enable -Wstrict-aliasing
• bindings/jni/jni_utility.cpp: (KJS::Bindings::getJNIEnv): Type-pun via a union instead of a pointer cast.
• wtf/HashMap.h: (WTF::): Instead of doing type-punned assignments via pointer cast, do one of three things: (1) assign directly w/o cast if storage type matches real type; (2) assign using cast via union if type does not need reffing; (3) copy with memcpy and ref/deref manually if type needs reffing. This is ok peref-wise because memcpy of a constant length gets optomized. HashTraits are now expected to make ref()/deref() take the storage type, not the true type.
• wtf/HashSet.h: (WTF::): Same basic idea.
• wtf/HashTable.h: (WTF::): Added Assigner template for use by HashMap/HashSet. Change RefCounter to call ref() and deref() via storage type, avoiding the need to type-pun. (WTF::RefCounter::ref): ditto (WTF::RefCounter::deref): ditto
• wtf/HashTraits.h: (WTF::): Change ref() and deref() for RefPtr HashTraits to take the storage type; cast via union to pointer type.
• wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::init): Changed from constructor to init function so this can go in a union. (WTF::): redefine pageheap macro in terms of getPageHeap(). (WTF::getPageHeap): new inline function, helper for pageheap macro. This hides the cast in a union. (WTF::TCMalloc_ThreadCache::InitModule): Call init() instead of using placement new to initialize page heap.
• wtf/TCPageMap.h: (TCMalloc_PageMap1::init): Changed from constructor to init function. (TCMalloc_PageMap2::init): ditto (TCMalloc_PageMap3::init): ditto

WebCore:

Reviewed by Antti.

• <rdar://problem/5311093> JavaScriptCore fails to build with strict-aliasing warnings

• platform/StringHash.h: (WTF::): Adapt to newer way to do storage types.

4:42 AM Changeset in webkit [24058] by bdash

• 2 edits in trunk/WebCore

2007-07-06 Bernhard Rosenkraenzer <​bero@arklinux.org>

Reviewed by Sam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13985
Bug 13985: WebCore/rendering/RenderTable.cpp fails to compile with gcc 4.2.x

• rendering/RenderTable.cpp: (WebKit::RenderTable::calcBorderLeft) (WebKit::RenderTable::calcBorderRight)

3:31 AM Changeset in webkit [24057] by bdash

• 2 edits
  3 adds in trunk/WebCore

2007-07-06 Maxime Britto <​mbritto@pleyo.com>

Reviewed by Maciej.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=13038

Bug 13038: ASSERTION FAILED: item->target().isEmpty()

m_mainFrame->tree()->find(item->target()) == m_mainFrame

Modify an ASSERT in goToItem related to going back/forward in history. We don't need to check the frameset if the target is _blank.
The attached test case is a manual one since it relies on having pages opened in tabs in Safari.

• manual-tests/goBack-blank-tab-page.html: Added.
• manual-tests/resources/before-go-back.html: Added.
• manual-tests/resources/will-go-back.html: Added.
• page/Page.cpp: (WebCore::Page::goToItem):

3:21 AM Changeset in webkit [24056] by bdash

• 5 edits in trunk/LayoutTests

2007-07-06 Mark Rowe <​mrowe@apple.com>

Unreviewed. Update test results.

• fast/encoding/utf-32-big-endian-bom-expected.txt:
• fast/encoding/utf-32-big-endian-nobom-expected.txt:
• fast/encoding/utf-32-little-endian-bom-expected.txt:
• fast/encoding/utf-32-little-endian-nobom-expected.txt:

3:06 AM Changeset in webkit [24055] by bdash

• 4 edits
  2 adds in trunk

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=14400 Assertion failure (SHOULD NEVER BE REACHED) going back on YouTube

Test: fast/forms/button-state-restore.html

• dom/Document.h: (WebCore::Document::isFormElementRegistered): Added.
• html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::closeRenderer): Restore saved form element state only if the element is registered with the document to have its state saved.

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=14400 Assertion failure (SHOULD NEVER BE REACHED) going back on YouTube

• fast/forms/button-state-restore-expected.txt: Added.
• fast/forms/button-state-restore.html: Added.

3:05 AM Changeset in webkit [24054] by bdash

• 3 edits
  4 adds in trunk

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=14487 Incomplete repaint of background and border of boxes with -webkit-border-fit:lines

Test: fast/repaint/border-fit-lines.html

• rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Do a full repaint if -webkit-border-fit:lines was specified.

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

• repaint test for ​http://bugs.webkit.org/show_bug.cgi?id=14487 Incomplete repaint of background and border of boxes with -webkit-border-fit:lines

• fast/repaint/border-fit-lines-expected.checksum: Added.
• fast/repaint/border-fit-lines-expected.png: Added.
• fast/repaint/border-fit-lines-expected.txt: Added.
• fast/repaint/border-fit-lines.html: Added.

3:03 AM Changeset in webkit [24053] by bdash

• 3 edits
  3 adds in trunk

2007-07-06 Tony Chang <​idealisms@gmail.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14516
Bug 14516: crash loading multipart/x-mixed-replace data on windows safari

NULL check m_resourceData to prevent a crash in Safari on Windows.

• loader/ResourceLoader.cpp: (WebCore::ResourceLoader::clearResourceData):

2007-07-06 Tony Chang <​idealisms@gmail.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14516
Bug 14516: crash loading multipart/x-mixed-replace data on windows safari

• http/tests/multipart/resources/multipart-nodashes.php: Added.
• http/tests/multipart/win-boundary-crash-expected.txt: Added.
• http/tests/multipart/win-boundary-crash.html: Added.

3:00 AM Changeset in webkit [24052] by bdash

• 7 edits
  8 adds in trunk

2007-07-06 Jungshik Shin <​jungshik.shin@gmail.com>

Reviewed by Alexey.

• Add UTF-32 encoding support ​http://bugs.webkit.org/show_bug.cgi?id=13415

Test:

• fast/encoding/utf-32-big-endian-bom.html
• fast/encoding/utf-32-big-endian-nobom.xml
• fast/encoding/utf-32-little-endian-bom.html
• fast/encoding/utf-32-little-endian-nobom.xml

• loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForBOM): (WebCore::TextResourceDecoder::checkForHeadCharset):
• platform/TextDecoder.cpp: (WebCore::TextDecoder::checkForBOM):
• platform/TextDecoder.h:
• platform/TextEncoding.cpp: (WebCore::UTF32BigEndianEncoding): (WebCore::UTF32LittleEndianEncoding):
• platform/TextEncoding.h:

2007-07-06 Jungshik Shin <​jungshik.shin@gmail.com>

Reviewed by Alexey.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=13415

• fast/encoding/utf-32-big-endian-bom-expected.txt: Added.
• fast/encoding/utf-32-big-endian-bom.html: Added.
• fast/encoding/utf-32-big-endian-nobom-expected.txt: Added.
• fast/encoding/utf-32-big-endian-nobom.xml: Added.
• fast/encoding/utf-32-little-endian-bom-expected.txt: Added.
• fast/encoding/utf-32-little-endian-bom.html: Added.
• fast/encoding/utf-32-little-endian-nobom-expected.txt: Added.
• fast/encoding/utf-32-little-endian-nobom.xml: Added.

2:56 AM Changeset in webkit [24051] by bdash

• 3 edits in trunk/WebCore

2007-07-06 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Maciej.

Start implementening RenderThemeGdk/Gtk using GtkStyle. The approach is
to allocate one native control for each widget type. And use margins, spacing,
style properties from the Widget. And for drawing use GtkStyle on the rect supplied.

This should allow nice integration and be relative resource friendly. Mozilla is using
a similiar approach. They seem to share the GdkPixmap among several operations and this
will be an obvious candidate for improvements. Create a normally big enough GdkPixmap and
use that for drawing and then set clip regions for cairo to make sure to not go beyond the
width and height.

The next steps will be to introduce states for the widgets, add more widgets, handle focus,
and various other style attributes, honor the size and margin and use that to propagate this
back to RenderStyle*.

• platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::RenderThemeGdk): (WebCore::RenderThemeGdk::setCheckboxSize): (WebCore::RenderThemeGdk::paintCheckbox): (WebCore::RenderThemeGdk::setRadioSize): (WebCore::RenderThemeGdk::paintRadio): (WebCore::RenderThemeGdk::paintButton): (WebCore::RenderThemeGdk::copyToContext): (WebCore::RenderThemeGdk::gtkButton): (WebCore::RenderThemeGdk::gtkCheckbox): (WebCore::RenderThemeGdk::gtkRadioButton): (WebCore::RenderThemeGdk::gtkWindowContainer):
• platform/gdk/RenderThemeGdk.h:

2:52 AM Changeset in webkit [24050] by bdash

• 2 edits in trunk/WebKit

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=10267 Can't scroll page downwards with scroll wheel, when pointer is on top of non-scrolling iframe

• WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView scrollWheel:]): Override the superclass implementation to forward the wheel event to the next responder if this view does not allow scrolling in the event's direction.

2:11 AM Changeset in webkit [24049] by rwlbuis

• 1 edit in trunk/WebCore/html/CanvasGradient.cpp

Fix build.

2:00 AM Changeset in webkit [24048] by rwlbuis

• 3 edits
  4 adds in trunk

Reviewed by Adam.

​http://bugs.webkit.org/show_bug.cgi?id=14442
Adding a stop with value 1.0 to a gradient that has already been used has no effect

Implement start and end stop handling differently so they are not
in the color stop array.

1:44 AM Changeset in webkit [24047] by aroben

• 7 edits in trunk

Fix <rdar://problem/5301994> Garbled text still showing on some sites

WebCore:

Fix <rdar://problem/5301994> Garbled text still showing on some sites

Replace calls to GetGlyphIndices with wkGetGlyphs.

Reviewed by Alice.

• platform/win/GlyphPageTreeNodeWin.cpp: (WebCore::GlyphPage::fill): Use wkGetGlyphs.
• platform/win/FontDataWin.cpp: (WebCore::FontData::containsCharacters):

WebKitLibraries:

Update WebKitSystemInterface.{h,lib} for <rdar://problem/5301994>

Reviewed by Alice.

• win/include/WebKitSystemInterface/WebKitSystemInterface.h:
• win/lib/WebKitSystemInterface.lib:
• win/lib/WebKitSystemInterface_debug.lib:

12:41 AM Changeset in webkit [24046] by pewtermoose

• 1 edit in trunk/WebKitSite/ChangeLog

Forgot ChangeLog description

12:37 AM Changeset in webkit [24045] by pewtermoose

• 2 edits in trunk/WebKitSite

Reviewed by Adam Roben.

• building/build.html:

12:01 AM Changeset in webkit [24044] by pewtermoose

• 2 edits in trunk/WebCore

Not reviewed - Windows build fix.

• bridge/win/FrameWin.cpp: (WebCore::imageFromSelection):