Timeline
Jul 13, 2007:
- 11:40 PM Changeset in webkit [24284] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Mark.
Correct expected pixel results
- fast/forms/input-appearance-readonly-expected.checksum:
- fast/forms/input-appearance-readonly-expected.png:
- 11:03 PM Changeset in webkit [24283] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
Fix for
<rdar://problem/5335265> REGRESSION: WebCore::DragController crashes if WebDragSourceActionDHTML cleared
http://bugs.webkit.org/show_bug.cgi?id=13652
Reorder logic for drag initiation: we can always preflight the clipboard, regardless as to whether
we are performing any dhtml drag handling
- page/EventHandler.cpp: (WebCore::EventHandler::handleDrag):
- 9:51 PM Changeset in webkit [24282] by
-
- 2 edits in trunk/WebCore
Reviewed by Tim Hatcher.
Bug 14401: Semi-regression: Can no longer copy anything from the inspector
http://bugs.webkit.org/show_bug.cgi?id=14401
- page/inspector/inspector.css:
- 6:49 PM Changeset in webkit [24281] by
-
- 2 edits in trunk/WebKit
Reviewed by Maciej.
<rdar://problem/5290103> Assert failure when loading page with multipart resource
Don't try to call the delegate method if the resource object doesn't exist in the
identifier map. When a multipart resource has finished loading one part, it is removed from the
web view identifier map.
This is not an ideal fix, a better fix would be to special-case multipart resources and not remove
them when the first part has finished loading. I've filed <rdar://problem/5335034> to track doing that.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::willCacheResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading):
- 5:20 PM Changeset in webkit [24280] by
-
- 2 edits in trunk/LayoutTests
Fix results.
- fast/text/word-break-run-rounding-expected.txt:
- 4:07 PM Changeset in webkit [24279] by
-
- 23 edits in trunk/WebCore
Reviewed by Hyatt.
Fix for <rdar://problem/5304742> A hang occurs when attempting to
display web clip banner at http://www.signonsandiego.com/sports/
chargers/index.html
Here is the actual fix.
- rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects): Set topLevel to false when we recurse to get our children's absoluteRects.
- rendering/RenderInline.h: New boolean parameter topLevel that defaults to true.
- rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteRects):
- rendering/RenderObject.h:
And these are just other implementations/declarations of this
(virtual) function that have to add the parameter. No behavior
change here.
- rendering/RenderPath.cpp: (WebCore::RenderPath::absoluteRects):
- rendering/RenderPath.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::absoluteRects):
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::absoluteRects):
- rendering/RenderSVGHiddenContainer.h:
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::absoluteRects):
- rendering/RenderSVGImage.h:
- rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::absoluteRects):
- rendering/RenderSVGInlineText.h:
- rendering/RenderSVGTSpan.cpp: (WebCore::RenderSVGTSpan::absoluteRects):
- rendering/RenderSVGTSpan.h:
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteRects):
- rendering/RenderSVGText.h:
- rendering/RenderText.cpp: (WebCore::RenderText::absoluteRects):
- rendering/RenderText.h:
- rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects):
- rendering/RenderView.h:
- 3:45 PM Changeset in webkit [24278] by
-
- 4 edits4 adds in trunk
LayoutTests:
Reviewed by Hyatt.
- test for http://bugs.webkit.org/show_bug.cgi?id=13438 <rdar://problem/5153030>
Run rounding makes word-break:break-all/word not functional
- fast/text/word-break-run-rounding-expected.checksum: Added.
- fast/text/word-break-run-rounding-expected.png: Added.
- fast/text/word-break-run-rounding-expected.txt: Added.
- fast/text/word-break-run-rounding.html: Added.
WebCore:
Reviewed by Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=13438 <rdar://problem/5153030>
Run rounding makes word-break:break-all/word not functional
Test: fast/text/word-break-run-rounding.html
- rendering/RenderText.cpp: (WebCore::RenderText::calcPrefWidths): Update the maximum width only on word boundaries to avoid rounding errors.
- rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Integrated breakAll with the midWordBreak/wrapW mechanism. Also made the wrapW upper bound more accurate by resetting it when tmpW is committed.
- 3:37 PM Changeset in webkit [24277] by
-
- 14 edits8 adds in trunk
LayoutTests:
Reviewed by Geoff Garen.
Tests for <rdar://problem/5318394>
http site can read/write content of https site in same domain
Adds ssl configuration information and tests.
- http/conf/apache2-httpd.conf:
- http/conf/cygwin-httpd.conf:
- http/conf/httpd.conf:
- http/conf/webkit-httpd.pem: Added.
- http/tests/security/cross-frame-access-expected.txt:
- http/tests/security/cross-frame-access-first-time-expected.txt:
- http/tests/security/cross-frame-access-protocol-expected.txt: Added.
- http/tests/security/cross-frame-access-protocol.html: Added.
- http/tests/security/cross-frame-access-put-expected.txt:
- http/tests/ssl: Added.
- http/tests/ssl/resources: Added.
- http/tests/ssl/resources/cross-frame-access-protocol-iframe.html: Added.
- http/tests/ssl/verify-ssl-enabled-expected.txt: Added.
- http/tests/ssl/verify-ssl-enabled.php: Added.
WebCore:
Reviewed by Geoff Garen.
Patch for <rdar://problem/5318394>
http site can read/write content of https site in same domain
Add protocol and port checks in isSafeScript.
- bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
WebKitTools:
Reviewed by Geoff Garen.
Add support for running SSL tests over HTTPS.
- DumpRenderTree/DumpRenderTree.m: (runTest):
- DumpRenderTree/FrameLoadDelegate.m: (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
- Scripts/run-webkit-httpd:
- Scripts/run-webkit-tests:
- 3:20 PM Changeset in webkit [24276] by
-
- 3 edits1 add in trunk/WebCore
Reviewed by Mitz Pettel.
<rdar://problem/5298870>
REGRESSION: In Yahoo Mail modal dialog, OK and Cancel buttons do not work, and descriptive text is missing (14327)
http://bugs.webkit.org/show_bug.cgi?id=14327
REGRESSION (r21367): dialogArguments not set in window generated by showModalDialog
When creating popup windows/dialogs, prevent the window properties from being cleared by the initial frame load.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::open):
- loader/FrameLoader.h: (WebCore::FrameLoader::setShouldClearWindowProperties):
- manual-tests/modal-dialog-arguments.html: Added.
- 2:45 PM Changeset in webkit [24275] by
-
- 2 edits in trunk/WebKit
Reviewed by Oliver Hunt.
<rdar://problem/5333766> Can't include WebEditingDelegatePrivate.h
- WebView/WebEditingDelegatePrivate.h: Changed the include to be a framework include, so other projects can use this header.
- 2:37 PM Changeset in webkit [24274] by
-
- 1 edit in branches/wx-port-alpha/trunk/WebKitTools/Scripts/webkitdirs.pm
The isGdk function got lost during merges. This restores scripts and such that expect this to be defined.
- 2:29 PM Changeset in webkit [24273] by
-
- 1 copy in tags/Safari-522.14.2b
New tag.
- 2:29 PM Changeset in webkit [24272] by
-
- 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION
Bump version for submit
- 1:26 PM Changeset in webkit [24271] by
-
- 3 edits in S60/branches/3.1m/JavaScriptCore
ligman, reviewed by Yongjun
DESC: stop the recursion in ArgumentListNode's destructor.
http://bugs.webkit.org/show_bug.cgi?id=14578
- kjs/nodes.cpp: (ArgumentListNode::~ArgumentListNode):
- kjs/nodes.h:
- 1:24 PM Changeset in webkit [24270] by
-
- 3 edits in S60/trunk/JavaScriptCore
ligman, reviewed by Yongjun
DESC: stop the recursion in ArgumentListNode's destructor.
http://bugs.webkit.org/show_bug.cgi?id=14578
- kjs/nodes.cpp: (ArgumentListNode::~ArgumentListNode):
- kjs/nodes.h:
- 1:17 PM Changeset in webkit [24269] by
-
- 3 edits in trunk/WebCore
Update ResourceError related code to account for changes in CF interfaces.
Reviewed by Darin, Ada.
- platform/network/ResourceError.h: Change Mac conditionals to CF to share more code.
- platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::ResourceError): Modified based on CFErrorRef changes (WebCore::ResourceError::unpackPlatformError): Ported from ResourceErrorMac.mm. (WebCore::ResourceError::operator CFErrorRef): Ported from ResourceErrorMac.mm. (WebCore::ResourceError::operator CFStreamError): Modified based on CFErrorRef changes.
- 12:06 PM Changeset in webkit [24268] by
-
- 3 edits in trunk/WebKit
Reviewed by Darin and Maciej.
<rdar://problem/5271096> panic after Safari stress test, caused by port leak
Replace uses of -[NSObject performSelector:withObject:afterDelay:] with CFRunLoopTimer. performSelector
causes the target (the WebHTMLView in this case) to be retained until the timer fires. Furthermore, when
running the PLT or iBench, the timers will not fire until the main loop is entered (usually after running all tests).
This means that the timers and ports will not be released until after the test has finished running.
- WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLView _cancelUpdateMouseoverTimer]): (-[WebHTMLView _updateMouseoverWithFakeEvent]): (-[WebHTMLView _updateMouseoverTimerCallback:]): (-[WebHTMLView _frameOrBoundsChanged]): (-[WebHTMLView _updateActiveState]): (-[WebHTMLView _updateActiveStateTimerCallback:]): (-[WebHTMLView viewWillMoveToWindow:]): (-[WebHTMLView viewDidMoveToWindow]): (-[WebHTMLView mouseDown:]): (-[WebTextCompleteController dealloc]):
- WebView/WebHTMLViewInternal.h:
- 11:55 AM Changeset in webkit [24267] by
-
- 5 edits2 adds in trunk
LayoutTests:
Reviewed by Adele.
Test for <rdar://problem/5192256>
click() in onchange handler causes another change event (causes hang at http://forums.whirlpool.net.au/)
- fast/events/onchange-click-hang-expected.txt: Added.
- fast/events/onchange-click-hang.html: Added.
WebCore:
Reviewed by Adele.
Fix <rdar://problem/5192256>
click() in onchange handler causes another change event (causes hang at http://forums.whirlpool.net.au/)
Guard against generating a simulated event from within a simulated event in the same node. Try to
match Firefox behavior.
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchSimulatedMouseEvent): (WebCore::EventTargetNode::dispatchSimulatedClick):
- dom/Node.cpp: (WebCore::Node::Node):
- dom/Node.h:
- 11:29 AM Changeset in webkit [24266] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by Darin.
Test for x <rdar://problem/5333387>
Combination of selection and click() on checkbox crashes
- fast/dynamic/checkbox-selection-crash-expected.txt: Added.
- fast/dynamic/checkbox-selection-crash.html: Added.
WebCore:
Reviewed by Darin.
Fix <rdar://problem/5333387>
Combination of selection and click() on checkbox crashes
Ensure there is no pending style update before doing synchronous paint. Under certain
circumstances this ends up doing style recalc in middle of paint() which may
for example tear down the rendering tree being painted, with bad results.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::setActive):
- 11:16 AM Changeset in webkit [24265] by
-
- 2 edits in trunk/WebKitTools
2007-07-13 David Kilzer <ddkilzer@apple.com>
Reviewed by Darin.
Added support for -hhelp argument and verify that all command line arguments parse correctly.
- Scripts/run-webkit-httpd:
- 11:13 AM Changeset in webkit [24264] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Fixed comment.
- 11:11 AM Changeset in webkit [24263] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by Adele.
Test for <rdar://problem/5333365>
Calling click() is very slow
- fast/forms/slow-click-expected.txt: Added.
- fast/forms/slow-click.html: Added.
WebCore:
Reviewed by Adele.
Fix <rdar://problem/5333365>
Calling click() is very slow
There is a 100ms delay in ContainerNode::setActive() to do an activation effect. It is used for
simulated mouse activations (using keyboard for example). However, it shouldn't be done when calling from javascript
(through click() interface) since it hangs script execution.
- html/HTMLElement.cpp: (WebCore::HTMLElement::click):
- 10:21 AM Changeset in webkit [24262] by
-
- 4 edits in trunk
Update versioning of trunk.
- 9:34 AM Changeset in webkit [24261] by
-
- 3 edits in trunk/LayoutTests
2007-07-14 Mark Rowe <mrowe@apple.com>
Reviewed by Sam.
Apply the change to Apache 2 configuration from r24204 to the other two Apache configuration files.
- http/conf/cygwin-httpd.conf:
- http/conf/httpd.conf:
- 7:16 AM Changeset in webkit [24260] by
-
- 2 edits in branches/Safari-2.0-dashboard
Versioning.
- 7:10 AM Changeset in webkit [24259] by
-
- 2 edits in branches/Safari-522
Versioning.
- 7:10 AM Changeset in webkit [24258] by
-
- 2 edits in branches/Safari-522/WebKit
Merge r23963.
Reviewed by Darin.
Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters
- Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):
- 7:10 AM Changeset in webkit [24257] by
-
- 4 edits in branches/Safari-522/WebCore
Merge r23529.
Reviewed by Geoff.
<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.
- platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.
- 5:00 AM Changeset in webkit [24256] by
-
- 15 edits in trunk
2007-07-13 Mitz Pettel <mitz@webkit.org>
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=13873 Incomplete repaint of replaced element's box shadow
Tests: fast/repaint/box-shadow-h.html
fast/repaint/box-shadow-v.html
- rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout): Added a call to adjustOverflowForBoxShadow().
- rendering/RenderImage.cpp: (WebCore::RenderImage::layout): Ditto.
- rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::layout): Ditto.
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::RenderReplaced): Initialize m_hasOverflow. (WebCore::RenderReplaced::~RenderReplaced): Added. Removes this object from the overflow rect map if it has overflow. (WebCore::RenderReplaced::shouldPaint): Account for overflow. (WebCore::RenderReplaced::adjustOverflowForBoxShadow): Added. Creates or removes an entry for this object in the global overflow rect map. (WebCore::RenderReplaced::overflowHeight): Added. (WebCore::RenderReplaced::overflowWidth): Added. (WebCore::RenderReplaced::overflowLeft): Added. (WebCore::RenderReplaced::overflowTop): Added. (WebCore::RenderReplaced::overflowRect): Added.
- rendering/RenderReplaced.h:
2007-07-13 Mitz Pettel <mitz@webkit.org>
Reviewed by Dave Hyatt.
- updated tests and results for http://bugs.webkit.org/show_bug.cgi?id=13873 Incomplete repaint of replaced element's box shadow
- fast/repaint/box-shadow-h-expected.checksum:
- fast/repaint/box-shadow-h-expected.png:
- fast/repaint/box-shadow-h-expected.txt:
- fast/repaint/box-shadow-h.html:
- fast/repaint/box-shadow-v-expected.checksum:
- fast/repaint/box-shadow-v-expected.png:
- fast/repaint/box-shadow-v-expected.txt:
- fast/repaint/box-shadow-v.html:
- 4:51 AM Changeset in webkit [24255] by
-
- 8 edits4 adds in trunk
2007-07-13 Mitz Pettel <mitz@webkit.org>
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=14395 When a <p> is inside <li> two <BR>s are rendered
Test: fast/lists/marker-before-empty-inline.html
- rendering/RenderBlock.h:
- rendering/RenderListItem.cpp: (WebCore::getParentOfFirstLineBox): Changed to skip empty inline flows that do not actually generate any line boxes. Limited the nested lists quirk to the case where the list is a child of the list item, to match Firefox.
- rendering/bidi.cpp: (WebCore::requiresLineBox): Added. Factored out of skipWhitespace. (WebCore::RenderBlock::generatesLineBoxesForInlineChild): Added. Checkes whether the child or any of its siblings following it will generate a line box in the flow. (WebCore::RenderBlock::skipWhitespace):
2007-07-13 Mitz Pettel <mitz@webkit.org>
Reviewed by Dave Hyatt.
- test and updated results for http://bugs.webkit.org/show_bug.cgi?id=14395 When a <p> is inside <li> two <BR>s are rendered
- editing/pasteboard/4861080-expected.checksum:
- editing/pasteboard/4861080-expected.png:
- editing/pasteboard/4861080-expected.txt:
- fast/lists/marker-before-empty-inline-expected.checksum: Added.
- fast/lists/marker-before-empty-inline-expected.png: Added.
- fast/lists/marker-before-empty-inline-expected.txt: Added.
- fast/lists/marker-before-empty-inline.html: Added.
- 4:47 AM Changeset in webkit [24254] by
-
- 5 edits in trunk/WebCore
2007-07-13 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Alexey.
Move HTTP methods to parse Content-Type from xmlhttprequest.cpp
which is LGPL to HTTPParsers.cpp. As both files were written by the
same author and the advice to move them came from him I think this move
is what is meant to be done.
Move filenameFromHTTPContentDisposition to HTTPParsers as well. This parse
function uses Vector<String>::split and doesn't honor quoting. This needs
to be fixed in later versions.
http://bugs.webkit.org/show_bug.cgi?id=5954 and http://bugs.webkit.org/show_bug.cgi?id=14059
benefit from this change.
- platform/network/HTTPParsers.cpp: (WebCore::filenameFromHTTPContentDisposition): (WebCore::extractMIMETypeFromMediaType): (WebCore::extractCharsetFromMediaType):
- platform/network/HTTPParsers.h:
- platform/network/cf/ResourceResponseCFNet.cpp:
- xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::responseMIMEType): (WebCore::XMLHttpRequest::didReceiveResponse):
Jul 12, 2007:
- 10:46 PM Changeset in webkit [24253] by
-
- 10 edits in trunk
2007-07-13 Mark Rowe <mrowe@apple.com>
Reviewed by Mitz.
Build fix. Stub out ChromeClientGdk::print and SVGEmptyChromeClient::print.
- platform/gdk/ChromeClientGdk.h:
- platform/gdk/TemporaryLinkStubs.cpp: (ChromeClientGdk::print):
- platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::print):
2007-07-13 Mark Rowe <mrowe@apple.com>
Reviewed by Mitz.
Build fix. Stub out WebChromeClient::print.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::print):
2007-07-13 Mark Rowe <mrowe@apple.com>
Reviewed by Mitz.
Build fix. Stub out ChromeClientQt::print.
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::print):
- WebCoreSupport/ChromeClientQt.h:
- 10:00 PM Changeset in webkit [24252] by
-
- 10 edits in trunk
WebCore:
Reviewed by Maciej and Steve.
fixed <rdar://4982432> window.print() needs to be implemented
- bridge/win/FrameWin.cpp: (WebCore::Frame::print):
- page/Chrome.cpp: (WebCore::Chrome::print):
- page/Chrome.h:
- page/ChromeClient.h:
- platform/win/TemporaryLinkStubs.cpp:
win:
Reviewed by Maciej and Steve.
fixed <rdar://4982432> window.print() needs to be implemented
- Interfaces/IWebUIDelegate.idl:
- WebChromeClient.cpp: (WebChromeClient::print):
- WebChromeClient.h:
- 8:16 PM Changeset in webkit [24251] by
-
- 2 edits in trunk/LayoutTests
2007-07-12 George Staikos <staikos@kde.org>
Reviewed by NOBODY.
Backed out previous change. This worked fine with Safari, but not so much with DumpRenderTree.
- http/tests/security/cross-frame-access-put.html:
- 7:53 PM Changeset in webkit [24250] by
-
- 2 edits in trunk/LayoutTests
2007-07-12 David Kilzer <ddkilzer@apple.com>
Reviewed by NOBODY.
Don't hard code the hostname to make it work with run-webkit-httpd on other interfaces.
- http/tests/security/cross-frame-access-put.html:
- 1:04 PM Changeset in webkit [24249] by
-
- 1 edit in tags/Safari-5522.11.2/WebCore/Configurations/Version.xcconfig
Versioning.
- 1:02 PM Changeset in webkit [24248] by
-
- 3 edits4 adds in tags/Safari-5522.11.2
Merge r24245.
- 12:42 PM Changeset in webkit [24247] by
-
- 1 copy in tags/Safari-5522.11.2
New tag.
- 12:41 PM Changeset in webkit [24246] by
-
- 1 delete in tags/Safari-5522.11.1/Safari-5522.11
Remove broken tag.
- 12:26 PM Changeset in webkit [24245] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Harrison.
<rdar://problem/5300379> Mail hung on option-delete
- editing/deleting/5300379-expected.checksum: Added.
- editing/deleting/5300379-expected.png: Added.
- editing/deleting/5300379-expected.txt: Added.
- editing/deleting/5300379.html: Added.
WebCore:
Reviewed by Harrison.
<rdar://problem/5300379> Mail hung on option-delete
We were starting backward iteration at [container, 0] and
emitting for container over and over.
- editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::advance): Don't emit characters for a node if we're starting iteration at [container, 0]. Don't emit characters for exiting containers if we've already done so.
- 12:14 PM Changeset in webkit [24244] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=14596
Fix JSC compilation with KJS_VERBOSE.
- kjs/function.cpp: (KJS::FunctionImp::passInParameters):
- 11:46 AM Changeset in webkit [24243] by
-
- 1 copy in tags/Safari-5522.11.1/Safari-5522.11
New tag.
- 10:37 AM Changeset in webkit [24242] by
-
- 2 edits in trunk/WebCore
Reviewed by Mark Rowe.
<rdar://problem/5039463> find a good gray that works well for full frame plug-ins; consistent look for plugins
- loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): Changed values to a darker gray, per request from the HI team.
- 9:34 AM Changeset in webkit [24241] by
-
- 9 edits2 adds in trunk
LayoutTests:
Reviewed by Maciej.
Test for <rdar://problem/5329841>
Calling window.closed on a closed window causes Safari to crash
- fast/dom/Window/window-closed-crash-expected.txt: Added.
- fast/dom/Window/window-closed-crash.html: Added.
WebCore:
Reviewed by Maciej.
Patch for <rdar://problem/5329841>
Calling window.closed on a closed window causes Safari to crash
- Replaces the Frame member variable in KJS::Window for more appropriate DOMWindow
- Adds additional new null checks as necessary
- Removes bogus toBoolean method
- Removes unused scheduleClose method
Test: fast/dom/Window/window-closed-crash.html
- bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::create):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): (WebCore::JSDOMWindow::customPut):
- bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
- bindings/js/kjs_events.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSLazyEventListener::parseCode):
- bindings/js/kjs_window.cpp: (KJS::Window::Window): (KJS::Window::impl): (KJS::Window::interpreter): (KJS::Window::location): (KJS::Window::find): (KJS::allowPopUp): (KJS::createWindow): (KJS::canShowModalDialog): (KJS::canShowModalDialogNow): (KJS::showModalDialog): (KJS::Window::getValueProperty): (KJS::Window::childFrameGetter): (KJS::Window::indexGetter): (KJS::Window::namedItemGetter): (KJS::Window::getOwnPropertySlot): (KJS::Window::put): (KJS::Window::isSafeScript): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::Window::clear): (KJS::WindowFunc::callAsFunction): (KJS::Window::updateLayout): (KJS::ScheduledAction::execute): (KJS::Window::disconnectFrame): (KJS::Location::put): (KJS::LocationFunc::callAsFunction):
- bindings/js/kjs_window.h:
- page/mac/WebCoreFrameBridge.mm: (updateRenderingForBindings):
- 9:24 AM Changeset in webkit [24240] by
-
- 2 edits in trunk/LayoutTests
2007-07-12 Mitz Pettel <mitz@webkit.org>
Reviewed by Mark Rowe.
- try to fix hang seen on buildbot after the last fix
- fast/history/resources/history_reload_window.html:
- 8:15 AM Changeset in webkit [24239] by
-
- 2 edits in trunk/LayoutTests
2007-07-12 Mitz Pettel <mitz@webkit.org>
Reviewed by Mark Rowe.
- fix an assertion failure in DumpRenderTree when running fast/history/resources/history_reload_window.html
- fast/history/resources/history_reload_window.html: Delay notifyDone() until after the window actually closes.
- 7:47 AM BuildingQtOnLinux edited by
- (diff)
- 7:47 AM BuildingQtOnLinux edited by
- (diff)
- 7:01 AM Changeset in webkit [24238] by
-
- 5 edits in trunk
2007-07-12 Mark Rowe <mrowe@apple.com>
Reviewed by Ada.
<rdar://problem/5329877> REGRESSION: Document::setTransformSource leaks an xmlDocPtr if called more than once per document
- dom/Document.cpp: (WebCore::Document::setTransformSource): Free any existing m_transformSource before overwriting it, rather than simply leaking it.
- dom/Document.h:
2007-07-12 Mark Rowe <mrowe@apple.com>
Reviewed by Ada.
Remove leak suppression for xmlDocPtrForString now that <rdar://problem/5329877> is fixed.
- Scripts/run-webkit-tests:
- 4:18 AM Changeset in webkit [24237] by
-
- 3 edits in trunk/LayoutTests
2007-07-12 Maxime Britto <mbritto@pleyo.com>
Reviewed by Mark Rowe.
Update the expected results now that they match what the test describes as the correct rendering.
- svg/custom/invalid-fill-hex-expected.txt:
- svg/custom/invalid-fill-hex-expected.png:
- 3:49 AM Changeset in webkit [24236] by
-
- 2 edits in trunk/WebCore
2007-07-12 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Mark Rowe.
Fix compilation of the CURL backend after the removing of accessors from ResourceHandle in r24202
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPOST): (WebCore::ResourceHandleManager::startJob):
- 1:15 AM Changeset in webkit [24235] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Oliver Hunt.
Made the leaks tests pass on Leopard.
- Scripts/run-webkit-tests: Added some leaks to exclude on Leopard.
- Scripts/run-leaks: Updated parser for slight change in text output.
- 12:21 AM Changeset in webkit [24234] by
-
- 2 edits in trunk/WebCore
2007-07-12 Mark Rowe <mrowe@apple.com>
Reviewed by Darin.
<rdar://problem/5327189> Logic error in DeprecatedString::to{,U}Int{,64} can lead to reading past end of buffer
The fix for reading past the end of the buffer is to verify we are not at the end of the string before checking
for a leading '+' character. Rather than fixing the logic error in four nearly-identical functions I chose to
extract the common functionality into the toIntegralType helper function which the four functions call through to.
- platform/DeprecatedString.cpp: (WebCore::isCharacterAllowedInBase): (WebCore::toIntegralType): (WebCore::DeprecatedString::toInt): (WebCore::DeprecatedString::toInt64): (WebCore::DeprecatedString::toUInt): (WebCore::DeprecatedString::toUInt64):
Jul 11, 2007:
- 11:23 PM Changeset in webkit [24233] by
-
- 1 copy in tags/Safari-522.14.1b
New tag.
- 11:23 PM Changeset in webkit [24232] by
-
- 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION
Bump version for submit
- 11:21 PM Changeset in webkit [24231] by
-
- 1 delete in tags/Safari-522.14.1b
Remove unneeded tag.
- 11:15 PM Changeset in webkit [24230] by
-
- 1 copy in tags/Safari-522.14.1b
New tag.
- 10:06 PM Changeset in webkit [24229] by
-
- 3 edits in trunk/WebCore
remove two unused variables and fix combobox rendering
- 9:34 PM Changeset in webkit [24228] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej
Fix for <rdar://problem/5329712> GMail crash when trying to compose new message
- platform/win/FontDataWin.cpp: (WebCore::FontData::containsCharacters):
- 9:17 PM Changeset in webkit [24227] by
-
- 6 edits1 move4 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=14584
XMLHttpRequest treats null login/password incorrectly
Test: http/tests/xmlhttprequest/null-auth.php
- xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::open):
- xml/xmlhttprequest.h: Split the open() method into three to distinguish between missing and null credentials.
- bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction): Call the appropriate open().
- 8:04 PM Changeset in webkit [24226] by
-
- 2 edits in trunk
Fix build in debug mode
- 7:48 PM Changeset in webkit [24225] by
-
- 2 edits in trunk/WebKitTools
2007-07-11 David Kilzer <ddkilzer@apple.com>
Reviewed by Maciej.
Update the iExploder list of CSS properties after box-sizing was renamed to
-webkit-box-sizing in r21026 to fix <rdar://problem/4667227>.
- iExploder/htdocs/cssproperties.in: Added -webkit-box-sizing. Both box-sizing and -moz-box-sizing remain.
- 7:22 PM Changeset in webkit [24224] by
-
- 1 edit11 adds in trunk/JavaScriptCore
Make it compile
- 7:07 PM Changeset in webkit [24223] by
-
- 2 edits in trunk/WebCore
Build fix for windows
- page/Frame.cpp: (WebCore::Frame::firstRectForRange):
- 6:20 PM Changeset in webkit [24222] by
-
- 5 edits in trunk/WebCore
Reviewed by Maciej.
Fix <rdar://problem/5329481> Character range rect code for IME support needs to be crossplatform
Move -[WebCoreFrameBridge firstRectForDOMRange:] to Frame::firstRectForRange
- page/Frame.cpp: (WebCore::Frame::firstRectForRange):
- page/Frame.h:
- page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge firstRectForDOMRange:]):
- 5:27 PM Changeset in webkit [24221] by
-
- 3 edits in tags
Versioning
- 5:26 PM Changeset in webkit [24220] by
-
- 3 edits in tags
Turn off -Wshorten-64-to-32 for now.
- 5:23 PM Changeset in webkit [24219] by
-
- 1 copy in tags/Safari-5522.11.1
New tag.
- 4:47 PM Changeset in webkit [24218] by
-
- 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp
Make sure we got a result before trying to convert it.
- 4:46 PM Changeset in webkit [24217] by
-
- 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebFrame.cpp
Don't automatically load an URL.
- 4:17 PM Changeset in webkit [24216] by
-
- 2 edits in trunk/WebKit
Reviewed by Oliver.
<rdar://problem/5108789> WEBVIEW: Drawing artifacts when dragging in IB
Interface Builder 3 is relying on KVO notifications for frameOrigin and frameSize,
among other standard NSView keys. Change automaticallyNotifiesObserversForKey to
return NO only for keys WebView manually fires notifications for.
- WebView/WebView.mm: (+[WebView automaticallyNotifiesObserversForKey:]): Selectivly return NO for keys we manually fire. (-[WebView _declaredKeys]): Code clean up.
- 3:49 PM Changeset in webkit [24215] by
-
- 2 edits in trunk/WebKit/win
Static analysis build fix.
Only specify /analyze (PREfast) if it is available.
Prevents entire project from rebuilding each time.
Reviewed by Hyatt.
- WebKit.vcproj/WebKit.vcproj:
- 3:49 PM Changeset in webkit [24214] by
-
- 2 edits in trunk/WebCore
Static analysis build fix.
Only specify /analyze (PREfast) if it is available.
Prevents entire project from rebuilding each time.
Reviewed by Hyatt.
- WebCore.vcproj/WebCore.vcproj:
- 3:01 PM Changeset in webkit [24213] by
-
- 3 edits in trunk/WebCore
Make comboboxes update when the current item is changed.
- 12:59 PM Changeset in webkit [24212] by
-
- 2 edits in trunk/WebCore
Add a destructor to cleanup the SQL handle (presently unused, but will be soon).
- 12:29 PM Changeset in webkit [24211] by
-
- 2 edits in trunk/WebKitQt
Fix build with assertions.
- 12:24 PM Changeset in webkit [24210] by
-
- 5 edits1 delete in trunk
top level:
Reviewed by Darin.
As of http://bugs.webkit.org/show_bug.cgi?id=14527 move the
WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore
- WebKit.pri: Adjust INCLUDEPATH
Reviewed by Darin.
As of http://bugs.webkit.org/show_bug.cgi?id=14527 move the
WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore
- ForwardingHeaders: Added.
- ForwardingHeaders/JavaScriptCore: Copied from WebCore/ForwardingHeaders/JavaScriptCore.
WebCore:
Reviewed by Darin.
As of http://bugs.webkit.org/show_bug.cgi?id=14527 move the
WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore
- ForwardingHeaders/JavaScriptCore: Removed.
- ForwardingHeaders/JavaScriptCore/APICast.h: Removed.
- ForwardingHeaders/JavaScriptCore/JSBase.h: Removed.
- ForwardingHeaders/JavaScriptCore/JSContextRef.h: Removed.
- ForwardingHeaders/JavaScriptCore/JSLock.h: Removed.
- ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Removed.
- ForwardingHeaders/JavaScriptCore/JSStringRef.h: Removed.
- ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Removed.
- ForwardingHeaders/JavaScriptCore/JSValueRef.h: Removed.
- ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Removed.
- 12:22 PM Changeset in webkit [24209] by
-
- 2 edits in trunk/WebCore
Fix build.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::didReceiveChallenge):
- 12:20 PM Changeset in webkit [24208] by
-
- 2 edits in trunk/WebKitQt
Another build fix.
- 12:16 PM Changeset in webkit [24207] by
-
- 2 edits in trunk/WebCore
Repair the build.
- 12:09 PM Changeset in webkit [24206] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
Fix for <rdar://problem/5230188> REGRESSION: Active/inactive marked text is not distinguished in textfields and textareas
We were previously trying to leave room for 1px of space between the text and the underline.
This change removes that requirement so that if we don't have room for the extra space, we still draw the thick underline
touching the text.
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintMarkedTextUnderline):
- 11:47 AM Changeset in webkit [24205] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin and Geoff.
<rdar://problem/5313508>
REGRESSION (Leopard): http/tests/xmlhttprequest/basic-auth.html hangs
Leopard Foundation now ignores credentials passed in as part of the URL so we need to pass them ourselves.
For the asynchronous case, we simply keep track of the URL and if it has a user name and password, we
pass those if we're asked to authenticate.
For the synchronous case, implement a new connection delegate and run it in a separate mode so
no other sources will fire.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::loadResourceSynchronously): (-[WebCoreResourceHandleAsDelegate dealloc]): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreSynchronousLoader _isDone]): (-[WebCoreSynchronousLoader dealloc]): (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): (-[WebCoreSynchronousLoader connection:didReceiveResponse:]): (-[WebCoreSynchronousLoader connection:didReceiveData:]): (-[WebCoreSynchronousLoader connectionDidFinishLoading:]): (-[WebCoreSynchronousLoader connection:didFailWithError:]): (-[WebCoreSynchronousLoader _data]): (-[WebCoreSynchronousLoader _response]): (-[WebCoreSynchronousLoader _error]): (+[WebCoreSynchronousLoader loadRequest:returningResponse:error:]):
- 11:21 AM Changeset in webkit [24204] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Geoff.
Create the lock file in a writable directory.
- http/conf/apache2-httpd.conf:
- 11:11 AM Changeset in webkit [24203] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
- fix <rdar://problem/5315265> REGRESSION: Leopard launch time - there are about 190 stats of icudt36b files during launch
- platform/TextEncodingRegistry.cpp: (WebCore::atomicCanonicalTextEncodingName): Add a special case for the empty string so we don't load the extended text encodings just so we can return 0 for that case.
- 10:12 AM Changeset in webkit [24202] by
-
- 5 edits in trunk/WebCore
Reviewed by Darin.
Remove a bunch of unneeded accessors from ResourceHandle.
- loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse): (WebCore::IconLoader::didFail): (WebCore::IconLoader::didFinishLoading):
- platform/network/ResourceHandle.cpp:
- platform/network/ResourceHandle.h:
- 6:26 AM Changeset in webkit [24201] by
-
- 4 edits in tags/Safari-5522.11
Versioning.
- 6:14 AM Changeset in webkit [24200] by
-
- 9 deletes in tags/Safari-5522.11/WebCore/ForwardingHeaders/JavaScriptCore
Remove WebCore/ForwardingHeaders/JavaScriptCore to prevent the WebCore build from failing.
- 6:12 AM Changeset in webkit [24199] by
-
- 11 edits in tags/Safari-5522.11
- 5:56 AM Changeset in webkit [24198] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Mark.
Forwardport the hash table fix from CodeGeneratorJS.pm to create_hash_table.
Reran run-jsc-tests, couldn't find any regressions. Suggested by Darin.
- 5:49 AM Changeset in webkit [24197] by
-
- 1 copy in tags/Safari-5522.11
New tag.
- 5:46 AM Changeset in webkit [24196] by
-
- 2 edits in branches/feature-branch/JavaScriptCore
Reviewed by Mark.
Forwardport the hash table fix from CodeGeneratorJS.pm to create_hash_table.
Reran run-jsc-tests, couldn't find any regressions. Suggested by Darin.
- 5:00 AM Changeset in webkit [24195] by
-
- 88 edits in branches/feature-branch
Rubber stamped by Mark.
WebKitTools:
Enable svg experimental features as default here in feature-branch.
LayoutTests:
Land new test results with experimental features on by default.
Files showing regressions have NOT been updated, of course.
- 4:31 AM Changeset in webkit [24194] by
-
- 33 edits in branches/feature-branch
WebCore:
Reviewed by Sam.
Remove all "SVGElement* m_context" parameters spread over SVG primitives
(like SVGAngle, SVGPreserveAspectRatio, SVGTransformList, ...)
This is all handled by the JS generation in the bindings now, leading
to a faster static rendering codepaths, and easier handling of the dynamic
parts like JS scripting. Remove the mystified genericContext() concept alltogether.
Add bug number reference missing in the last ChangeLog entry.
LayoutTests:
Reviewed by Sam.
Check in correct results, now that the hashing bug is fixed here as well.
- 3:36 AM Changeset in webkit [24193] by
-
- 1 copy in tags/WebKit-312.9/WebKit
New tag (part 2).
- 3:36 AM Changeset in webkit [24192] by
-
- 1 copy in tags/WebCore-315.15/WebCore
New tag (part 2).
- 3:35 AM Changeset in webkit [24191] by
-
- 1 add in tags/WebKit-312.9
New tag (part 1).
- 3:34 AM Changeset in webkit [24190] by
-
- 1 add in tags/WebCore-315.15
New tag (part 1).
- 3:34 AM Changeset in webkit [24189] by
-
- 4 edits in branches/Safari-1-3-branch
Versioning.
- 3:34 AM Changeset in webkit [24188] by
-
- 2 edits in branches/Safari-1-3-branch/WebCore
2007-07-09 Mark Rowe <mrowe@apple.com>
Merge r18365 from ToT to Safari-1-3-branch.
2006-12-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Fixed <rdar://problem/4809825>. We need to check isSafeScript when converting
a Location to string.
It's really a bug, and poor design, for objects to override toString.
Subclasses that want custom toString implementations should add a toString
function to their prototypes instead of overriding the JavaScript ToString
operation. Following this design pattern would have avoided this bug in the
first place.
- bindings/js/kjs_window.cpp: (KJS::Location::toString):
- 3:21 AM Changeset in webkit [24187] by
-
- 4 edits8 adds in trunk
LayoutTests:
Reviewed by Darin.
<rdar://problem/5234383> REGRESSION: Sentence breaker method returning entire document length
- editing/selection/5234383-1-expected.checksum: Added.
- editing/selection/5234383-1-expected.png: Added.
- editing/selection/5234383-1-expected.txt: Added.
- editing/selection/5234383-1.html: Added.
- editing/selection/5234383-2-expected.checksum: Added.
- editing/selection/5234383-2-expected.png: Added.
- editing/selection/5234383-2-expected.txt: Added.
- editing/selection/5234383-2.html: Added.
WebCore:
Reviewed by Darin.
<rdar://problem/5234383> REGRESSION: Sentence breaker method returning entire document length
The functions for moving the caret to the next/previous sentence boundary
were in many cases moving to the beginning/end of the document. The functions that
should move the caret to an equivalent position in the next/previous sentence behaved
like the aforementioned functions ought to. Put the code from the second two functions
in the first and made sure that the second two are properly FIXMEd. They're rarely
used (filed 5323691).
- editing/SelectionController.cpp: (WebCore::SelectionController::modify): Added an option for sentenceBoundary granularity, so that we can test the functions that were broken from JS.
- editing/visible_units.cpp: (WebCore::startOfSentence): Removed the FIXME about 5234383. (WebCore::endSentenceBoundary): Make this function do what nextSentencePositionBoundary current does. (WebCore::endOfSentence): Removed the FIXME about 5234383. (WebCore::previousSentencePosition): Removed an incorrect FIXME. (WebCore::nextSentencePositionBoundary): Tweaked FIXME. This function is identical, not close to endSentenceBoundary. (WebCore::nextSentencePosition): Removed an incorrect FIXME.
- 1:10 AM Changeset in webkit [24186] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
Fix <rdar://problem/4570550>
Hang in layout/layoutBlock/layoutBlockChildren preparing to print certain Mail messages
When printing from Mail, WebHTMLView is a subview of the view that is actually printed and does not
receive calls that would set it to printing mode. Method adjustPageHeightNew is called repeatedly (for each page) during
printing and it enables printing mode temporarily for each call. This triggers two full style recalcs and layouts
each time making printing at least O(n2).
Instead of enabling printing mode and resetting it back immediatly do the resetting asynchronously, after
all adjustPageHeightNew calls are done. Normal Safari printing is not affected as adjustPageHeightNew is only
called in case WebHTMLView is embedded in the view that is being printed.
No automatic test possible, requires printing and non-Safari client.
- WebView/WebHTMLView.mm: (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
- 12:40 AM Changeset in webkit [24185] by
-
- 5 edits4 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=14453
REGRESSION: www.nzherald.co.nz almost all the formating is gone
Be less strict for the hex color definition.
- 12:34 AM Changeset in webkit [24184] by
-
- 3 edits in trunk/WebCore
Reviewed by Oliver.
Forgot to commit this as part of commit r24146. Now we are sure
createElement creates elements in the xhtml namespace only.
Jul 10, 2007:
- 11:20 PM Changeset in webkit [24183] by
-
- 4 edits in trunk/WebKit
Reviewed by Maciej Stachowiak.
- Fixed <rdar://problem/5049509> REGRESSION(10.4.9-9A377a): REAP Suite installer shows empty modal alert window (hangs) if user cancels during "installing shared components" phase
Added Adobe installers to the family of apps that need a data load
loading quirk.
Added a linked-on-or-after check because this code is no longer
Tiger-only.
I tested this code on Tiger and Leopard.
- Misc/WebKitVersionChecks.h:
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebDocumentLoaderMac.mm: (needsDataLoadWorkaround): (WebDocumentLoaderMac::setDataSource):
- 10:10 PM Changeset in webkit [24182] by
-
- 9 edits2 adds in trunk
LayoutTests:
Reviewed by Oliver.
- fast/dom/Window/get-set-properties-expected.txt: Added.
- fast/dom/Window/get-set-properties.html: Added.
WebCore:
Reviewed by Oliver.
Move more attributes from the pure JS bindings in KJS::Window
to the implementation in DOMWindow and autogenerate the new bindings
Test: fast/dom/Window/get-set-properties.html
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): Change to use propHashTable in JSDOMWindow instead of KJS::Window
- bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put):
- bindings/js/kjs_window.h: (KJS::Window::):
- bindings/scripts/CodeGeneratorJS.pm: Cleanup getValueProperty and put generation to reduce code duplication.
- page/DOMWindow.cpp: (WebCore::DOMWindow::closed): (WebCore::DOMWindow::length): (WebCore::DOMWindow::name): (WebCore::DOMWindow::setName): (WebCore::DOMWindow::status): (WebCore::DOMWindow::setStatus): (WebCore::DOMWindow::defaultStatus): (WebCore::DOMWindow::setDefaultStatus):
- page/DOMWindow.h: (WebCore::DOMWindow::defaultstatus): (WebCore::DOMWindow::setDefaultstatus):
- page/DOMWindow.idl:
- 8:46 PM Changeset in webkit [24181] by
-
- 4 edits3 adds in trunk
LayoutTests:
Reviewed by Geoff.
Tests for <rdar://problem/5326791>
- http/tests/security/cross-frame-access-expected.txt:
- http/tests/security/cross-frame-access-put-expected.txt: Added.
- http/tests/security/cross-frame-access-put.html: Added.
- http/tests/security/resources/cross-frame-iframe-for-put-test.html: Added.
WebCore:
Reviewed by Geoff.
Fix for <rdar://problem/5326791> XSS vulnerability: ability to set window.defaultStatus,
window.defaultstatus and window.status cross domains
Test: http/tests/security/cross-frame-access-put.html
- bindings/js/kjs_window.cpp: (KJS::Window::put): Adds isSafeScript check for defaultStatus, defaultstatus and status cases.
- 8:11 PM Changeset in webkit [24180] by
-
- 2 edits in trunk/WebKitTools
- Scripts/run-webkit-tests: Add an ignore item for a leak in Tiger's Foundation's multipart/mixed-replace support -- I already verified that the bug has been fixed.
- 7:13 PM Changeset in webkit [24179] by
-
- 2 edits in trunk/WebKitTools
rubber stamped by Maciej.
fixed <rdar://5137972> editing/selection/editable-links.html fails on Windows
- DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initializePreferences): set editable link behavior to match Mac DRT.
- 6:42 PM Changeset in webkit [24178] by
-
- 2 edits in trunk/WebCore
Fix build for BuildBot.
- page/DOMWindow.cpp: (WebCore::DOMWindow::outerHeight): (WebCore::DOMWindow::outerWidth): (WebCore::DOMWindow::screenX): (WebCore::DOMWindow::screenY):
- 6:38 PM Changeset in webkit [24177] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam
<rdar://problem/5326653> - REGRESSION: [WebBackForwardList forwardListCount] might return incorrect result
No layout test because this is an API issue that can't be tested in DRT or the browser
- history/BackForwardList.cpp: (WebCore::BackForwardList::forwardListCount): If the index is NoCurrentItemIndex, return 0
- 5:28 PM Changeset in webkit [24176] by
-
- 6 edits in trunk/WebCore
Reviewed by Darin.
Move more readonly attributes from pure JS bindings in KJS::Window
to the implementation in DOMWindow and autogenerate the new bindings.
- bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): Sort the hashmap comment into categories to make further migration easier.
- bindings/js/kjs_window.h: Sort the enum into categories to make further migration easier. (KJS::Window::):
- page/DOMWindow.cpp: Add new methods. (WebCore::DOMWindow::focus): (WebCore::DOMWindow::blur): (WebCore::DOMWindow::offscreenBuffering): (WebCore::DOMWindow::outerHeight): (WebCore::DOMWindow::outerWidth): (WebCore::DOMWindow::innerHeight): (WebCore::DOMWindow::innerWidth): (WebCore::DOMWindow::screenX): (WebCore::DOMWindow::screenY): (WebCore::DOMWindow::scrollX): (WebCore::DOMWindow::scrollY): (WebCore::DOMWindow::getComputedStyle): (WebCore::DOMWindow::getMatchedCSSRules): Add null Document assertion. (WebCore::DOMWindow::devicePixelRatio): Add null Frame and Page checks.
- page/DOMWindow.h: (WebCore::DOMWindow::screenLeft): (WebCore::DOMWindow::screenTop): (WebCore::DOMWindow::pageXOffset): (WebCore::DOMWindow::pageYOffset):
- page/DOMWindow.idl:
- 5:23 PM Changeset in webkit [24175] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej.
Fix for <rdar://problem/5326417> Editor::unmarkText needs to be crossplatform
Missed this in earlier patch to make text marking platform independent.
- editing/Editor.cpp: (WebCore::Editor::unmarkText):
Add platform independent impl
- editing/mac/EditorMac.mm:
Remove the old mac path.
- 4:52 PM Changeset in webkit [24174] by
-
- 4 edits in trunk
WebCore:
Reviewed by Tim Hatcher.
Added a Page counter. This helped me while investigating
<rdar://problem/5314463> 40MB of WebKit memory still allocated after
closing large email in Mail
- WebCore.xcodeproj/project.pbxproj:
- page/Page.cpp: (WebCore::): (WebCore::PageCounter::~PageCounter): (WebCore::Page::Page): (WebCore::Page::~Page):
WebKitTools:
Reviewed by Tim Hatcher.
Ignore Page.o in debug builds because it now has a static PageCounter
object.
- Scripts/check-for-global-initializers:
- 4:44 PM Changeset in webkit [24173] by
-
- 4 edits in trunk/WebCore
Reviewed by Geoff.
<rdar://problem/5326126> InspectorResource holds onto more data than it needs
Reduces the fixed size of InspectorResource from 630 bytes to 224 bytes. Now
selectively pick out parts of the ResourceRequest and ResourceResponse objects
for the info needed and store that directly in InspectorResource.
The ResourceRequest and ResourceResponse objects hold a reference to the original
NSURL object, so almost double the data was being kept around. So the struct size
reduction is just the tip of the ice burg on what this really saves.
In a test of 100,000 XMLHTTPRequests using a 85 byte long data URL, I see ~21 MB less
RSIZE compared to Safari running without this change.
- page/InspectorController.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::type): (WebCore::addSourceToFrame): (WebCore::scriptObjectForRequest): (WebCore::scriptObjectForResponse): (WebCore::InspectorController::addScriptResource): (WebCore::InspectorController::addAndUpdateScriptResource): (WebCore::updateResourceRequest): (WebCore::updateResourceResponse): (WebCore::InspectorController::updateScriptResourceRequest): (WebCore::InspectorController::updateScriptResourceResponse): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
- page/InspectorController.h:
- 3:42 PM Changeset in webkit [24172] by
-
- 3 edits in branches/feature-branch/WebCore
Forgot to commit the ChangeLog and two files in my last commit!
- 3:37 PM Changeset in webkit [24171] by
-
- 2 edits in trunk/WebCore
Reviewed by Brady.
- fix crash introduced by my patch for 5318732, only seen in release builds
- page/Page.cpp: (WebCore::Page::~Page): Added a missing null check.
- 3:30 PM Changeset in webkit [24170] by
-
- 2 edits in trunk/WebCore
Patch from Andrea Cavalli to fix sunken state of text fields.
Bug #14576
- 3:29 PM Changeset in webkit [24169] by
-
- 17 edits5 adds in branches/feature-branch
Reviewed by Sam.
Recognizee <textPath> in SVG JS bindings.
Add JSSVGTextPathElement to JSSVGElementWrapperFactory.
Add SVGException.idl just for the JS generation.
Turn on all SVG JS constructors and add them to DOMWindow.idl.
Testcase added: LayoutTests/svg/custom/js-svg-constructors.svg
- 3:13 PM Changeset in webkit [24168] by
-
- 3 edits in trunk/WebCore
Patch from Qing Zhao to draw focus rects on non-QStyle rendered nodes. Needs a
bit more work once we figure out how to use QPainterPathStroker in a more
sophisticated manner.
- 3:10 PM Changeset in webkit [24167] by
-
- 2 edits in S60/trunk/WebKit
brmorris, reviewed by johnshi
DESC: remove generated header from releasables list.
Turns out some build systems delete the releasables list after the
makmake phase but before the compilation, and hence the generated
header was not found at compile time.
- 3:04 PM BuildingGdk edited by
- (diff)
- 3:04 PM BuildingGdk edited by
- (diff)
- 2:53 PM Changeset in webkit [24166] by
-
- 2 edits in trunk/WebKit/win
2007-07-10 Ada Chan <adachan@apple.com>
Fixed build.
- WebView.cpp:
- 2:46 PM Changeset in webkit [24165] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff.
Fix 'unsigned int' overflow in CodeGeneratorJS.pm.
This fixes hashing of "SVG_FEBLEND_MODE_NORMAL". Its hashvalue exceeded 232, which
is no problem in perl but in the cpp code. Emulate C/C++ behaviour by using "% 232" in
the perl code. Testcase available in feature-branch soon (js-svg-constructors.svg).
- 2:45 PM Changeset in webkit [24164] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej Stachowiak.
Disabled Arena recycling in RenderArena. PLT shows no regression
(possibly a small speedup), and this can reduce allocated memory in
WebKit clients by about 120K (4K per Arena * 30 Arenas).
I happened upon this optimization while investigating
<rdar://problem/5314463> WebKit hangs on to 40MB RAM after closing
large email in Mail (appears to be render tree arena allocator),
although I don't think it will come close to fixing that bug
completely.
- rendering/RenderArena.cpp: (WebCore::RenderArena::~RenderArena): Use FinishArenaPool, which frees the ArenaPool's Arenas immediately.
- 2:37 PM Changeset in webkit [24163] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Hyatt.
- test for http://bugs.webkit.org/show_bug.cgi?id=14449 REGRESSION (r14345-r14375): Absolutely positioned image does not scale to containing element's height
- fast/replaced/absolute-position-percentage-height-expected.checksum: Added.
- fast/replaced/absolute-position-percentage-height-expected.png: Added.
- fast/replaced/absolute-position-percentage-height-expected.txt: Added.
- fast/replaced/absolute-position-percentage-height.html: Added.
WebCore:
Reviewed by Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=14449 REGRESSION (r14345-r14375): Absolutely positioned image does not scale to containing element's height
Test: fast/replaced/absolute-position-percentage-height.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedHeightUsing): For positioned elements, evaluate the percentage with respect to the container's final height.
- 1:21 PM Changeset in webkit [24162] by
-
- 1 edit in trunk/WebCore/platform/DeprecatedString.cpp
Build fix.
- 1:13 PM Changeset in webkit [24161] by
-
- 1 edit in trunk/WebCore/platform/DeprecatedString.cpp
Correctness fix
- 1:08 PM Changeset in webkit [24160] by
-
- 7 edits in S60/branches/3.1m/WebKit
2007-07-03 rathnasa <sornalatha.rathnasamy@nokia.com>
Reviewed by zbujtas@gmail.com.
DESC: merge fixes SYAI-73AS6K and SYAI-73ARXK from 3.2
http://bugs.webkit.org/show_bug.cgi?id=14389
- 1:03 PM Changeset in webkit [24159] by
-
- 2 edits in trunk/WebKit
- fix build
- WebView/WebHTMLView.mm: Add include of ContextMenu.h.
- 12:54 PM Changeset in webkit [24158] by
-
- 7 edits in trunk/WebCore
Reviewed by Mark Rowe
Add 64-bit integer converters to our string classes for future work
- platform/DeprecatedString.cpp: (WebCore::DeprecatedString::toInt64): (WebCore::DeprecatedString::toUInt64):
- platform/DeprecatedString.h:
- platform/PlatformString.h:
- platform/String.cpp: (WebCore::String::toInt64): (WebCore::String::toUInt64):
- platform/StringImpl.cpp: (WebCore::StringImpl::toInt64): (WebCore::StringImpl::toUInt64):
- platform/StringImpl.h:
- 12:45 PM Changeset in webkit [24157] by
-
- 2 edits in trunk/LayoutTests
- win/Skipped: removing tests that were blocked on lack of support for smart pasting and DOM Paste API
- 12:21 PM Changeset in webkit [24156] by
-
- 9 edits in trunk/WebCore
Reviewed by Anders.
- fix <rdar://problem/5318732> REGRESSION: In Mail, a crash occurs when attempting to send a HTML based message (nytimes.com, washingtonpost.com, latimes.com)
Did an audit of calls to get the inspector and most other uses of Page* and added null
checks since Frame* can outlast its Page*.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): Added null check. (WebCore::FrameLoader::loadSubframe): Ditto. (WebCore::FrameLoader::load): Ditto. (WebCore::FrameLoader::transitionToCommitted): Ditto. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto. (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): Ditto. (WebCore::FrameLoader::addExtraFieldsToRequest): Ditto. (WebCore::FrameLoader::loadResourceSynchronously): Ditto. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Ditto. (WebCore::FrameLoader::requestFromDelegate): Ditto. (WebCore::FrameLoader::canGoBackOrForward): Ditto. (WebCore::FrameLoader::getHistoryLength): Ditto. (WebCore::FrameLoader::historyURL): Ditto. (WebCore::FrameLoader::cachePageForHistoryItem): Ditto. (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): Ditto. (WebCore::FrameLoader::goToItem): Ditto. (WebCore::FrameLoader::dispatchWindowObjectAvailable): Ditto. (WebCore::FrameLoader::dispatchDidCommitLoad): Ditto. (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest): Ditto. (WebCore::FrameLoader::dispatchWillSendRequest): Ditto. (WebCore::FrameLoader::dispatchDidReceiveResponse): Ditto. (WebCore::FrameLoader::dispatchDidReceiveContentLength): Ditto. (WebCore::FrameLoader::dispatchDidFinishLoading): Ditto. (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache): Ditto.
- page/ContextMenuController.h:
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::ContextMenuController): Removed unneeded and unused Page* parameter. (WebCore::openNewWindow): Added null check. (WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
- page/InspectorController.h: (WebCore::InspectorController::pageDestroyed): Added. Since this object is owned by the Page and has a back-pointer to it, it needs an explicit disconnect. There's already a higher-level one, but this is more reliable than that.
- page/InspectorController.cpp: (WebCore::InspectorController::windowScriptObjectAvailable): Added null check. (WebCore::InspectorController::windowUnloading): Ditto.
- page/Page.cpp: (WebCore::Page::Page): Updated for change in parameters of ContextMenuController constructor. (WebCore::Page::~Page): Added call to InspectorController pageDestroyed().
- page/Chrome.cpp: Updated includes.
- page/DragController.cpp: Ditto.
- 11:47 AM Changeset in webkit [24155] by
-
- 2 edits in trunk/WebKit
Reviewed by John Sullivan.
- <rdar://problem/5321953> remove workaround for fixed AppKit mouse moved bug
- WebView/WebHTMLView.mm: Put the workaround for bug 3429631 inside an ifdef BUILDING_ON_TIGER.
- 10:44 AM Changeset in webkit [24154] by
-
- 1 copy in tags/WebKit-419.3/WebKit
New tag (part 2).
- 10:43 AM Changeset in webkit [24153] by
-
- 1 add in tags/WebKit-419.3
New tag (part 1).
- 10:42 AM Changeset in webkit [24152] by
-
- 1 copy in tags/WebCore-418.23/WebCore
New tag (part 2).
- 10:42 AM Changeset in webkit [24151] by
-
- 1 add in tags/WebCore-418.23
New tag (part 1).
- 10:39 AM Changeset in webkit [24150] by
-
- 4 edits in branches/Safari-2.0-system
Versioning.
- 9:39 AM Changeset in webkit [24149] by
-
- 2 edits in trunk/WebCore
Patch from Adam Treat to make the scroll wheel behave sanely
- 9:25 AM Changeset in webkit [24148] by
-
- 4 edits5 adds in trunk
LayoutTests:
Reviewed by Maciej Stachowiak.
- fast/events/onload-after-document-close-no-subresource-expected.txt: Added.
- fast/events/onload-after-document-close-no-subresource.html: Added.
- fast/events/onload-after-document-close-with-subresource-expected.txt: Added.
- fast/events/onload-after-document-close-with-subresource.html: Added.
- fast/events/resources/onload-image.png: Added.
WebCore:
Reviewed by Maciej Stachowiak.
Fixed http://bugs.webkit.org/show_bug.cgi?id=13241 | <rdar://problem/5126396>
onload fires before content is finished loading (woot.com)
- dom/Document.cpp: (WebCore::Document::close): Try to go through the normal "Am I done loading?" machinery before dispatching the load event. As the comment indicates, we can't do this in all cases, so the fix isn't perfect. However, a perfect solution would require much riskier sweeping changes to the loader, which are best left for later, I think.
- xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Removed a slightly worse solution to the same problem.
- 3:25 AM Changeset in webkit [24147] by
-
- 2 edits in trunk/WebKitQt
2007-07-10 Mark Rowe <mrowe@apple.com>
Qt build fix after r24126.
- Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript):
- 2:21 AM Changeset in webkit [24146] by
-
- 28 edits6 adds in trunk
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=8007
createElement() and XHTML (A dynamically created table not rendered as such)
Follow the HTML5 rules of making the name lowercase and then
creating the element in the xhtml namespace.
- 1:20 AM Changeset in webkit [24145] by
-
- 2 edits in branches/Safari-2.0-dashboard/WebCore
2007-07-09 Mark Rowe <mrowe@apple.com>
Merge r23529 from ToT to Safari-2.0-dashboard.
2007-06-14 Anders Carlsson <andersca@apple.com>
Reviewed by Geoff.
<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.
- platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.
- 1:20 AM Changeset in webkit [24144] by
-
- 2 edits in branches/Safari-2.0-dashboard/WebCore
2007-07-09 Mark Rowe <mrowe@apple.com>
Merge r18365 from ToT to Safari-2.0-dashboard.
2006-12-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Fixed <rdar://problem/4809825>. We need to check isSafeScript when converting
a Location to string.
It's really a bug, and poor design, for objects to override toString.
Subclasses that want custom toString implementations should add a toString
function to their prototypes instead of overriding the JavaScript ToString
operation. Following this design pattern would have avoided this bug in the
first place.
- bindings/js/kjs_window.cpp: (KJS::Location::toString):
- 1:20 AM Changeset in webkit [24143] by
-
- 3 edits in branches/Safari-2.0-dashboard/WebCore
2007-07-09 Mark Rowe <mrowe@apple.com>
Merge r19551 from ToT to Safari-2.0-dashboard.
2007-02-10 Maciej Stachowiak <mjs@apple.com>
Reviewed by me, patch from Ian Eng (cleaned up by me some).
- fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)
Test case: fast/dom/Window/window-appendages-cleared.html
- bindings/js/kjs_window.cpp: (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear):
- bindings/js/kjs_window.h:
- 1:20 AM Changeset in webkit [24142] by
-
- 2 edits in branches/Safari-2.0-dashboard/WebCore
2007-07-09 Mark Rowe <mrowe@apple.com>
Merge r19126 from ToT to Safari-2.0-dashboard.
2007-01-25 Dirk Mueller <mueller@kde.org>
Reviewed and merged by Beth.
Fix for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)
This is equivalent to commit 626791 in the KDE tree. Basically, the
patch allows comment parsing in titles to avoid capturing a
<script> tag by accident.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment):
- 1:20 AM Changeset in webkit [24141] by
-
- 2 edits in branches/Safari-2.0-dashboard/WebKit
2007-07-09 Mark Rowe <mrowe@apple.com>
Merge r23963 from ToT to Safari-2.0-dashboard.
2007-07-03 Adele Peterson <adele@apple.com>
Reviewed by Darin.
Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters
- Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):
- 1:10 AM Changeset in webkit [24140] by
-
- 2 edits in branches/Safari-1-3-branch/WebCore
2007-07-09 Mark Rowe <mrowe@apple.com>
Merge r23529 from ToT to Safari-1-3-branch.
2007-06-14 Anders Carlsson <andersca@apple.com>
Reviewed by Geoff.
<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.
- platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.
- 1:10 AM Changeset in webkit [24139] by
-
- 3 edits in branches/Safari-1-3-branch/WebCore
2007-07-09 Mark Rowe <mrowe@apple.com>
Merge r19551 from ToT to Safari-1-3-branch.
2007-02-10 Maciej Stachowiak <mjs@apple.com>
Reviewed by me, patch from Ian Eng (cleaned up by me some).
- fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)
Test case: fast/dom/Window/window-appendages-cleared.html
- bindings/js/kjs_window.cpp: (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear):
- bindings/js/kjs_window.h:
- 1:10 AM Changeset in webkit [24138] by
-
- 2 edits in branches/Safari-1-3-branch/WebCore
2007-07-09 Mark Rowe <mrowe@apple.com>
Merge r19126 from ToT to Safari-1-3-branch.
2007-01-25 Dirk Mueller <mueller@kde.org>
Reviewed and merged by Beth.
Fix for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)
This is equivalent to commit 626791 in the KDE tree. Basically, the
patch allows comment parsing in titles to avoid capturing a
<script> tag by accident.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment):
- 1:10 AM Changeset in webkit [24137] by
-
- 2 edits in branches/Safari-1-3-branch/WebKit
2007-07-09 Mark Rowe <mrowe@apple.com>
Merge r23963 from ToT to Safari-1-3-branch.
2007-07-03 Adele Peterson <adele@apple.com>
Reviewed by Darin.
Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters
- Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):
- 1:08 AM Changeset in webkit [24136] by
-
- 2 edits in branches/Safari-2.0-system/WebCore
2007-07-09 Mark Rowe <mrowe@apple.com>
Merge r23529 from ToT to Safari-2.0-system.
2007-06-14 Anders Carlsson <andersca@apple.com>
Reviewed by Geoff.
<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.
- platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.
- 1:08 AM Changeset in webkit [24135] by
-
- 2 edits in branches/Safari-2.0-system/WebCore
2007-07-09 Mark Rowe <mrowe@apple.com>
Merge r18365 from ToT to Safari-2.0-system.
2006-12-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Fixed <rdar://problem/4809825>. We need to check isSafeScript when converting
a Location to string.
It's really a bug, and poor design, for objects to override toString.
Subclasses that want custom toString implementations should add a toString
function to their prototypes instead of overriding the JavaScript ToString
operation. Following this design pattern would have avoided this bug in the
first place.
- bindings/js/kjs_window.cpp: (KJS::Location::toString):
- 1:08 AM Changeset in webkit [24134] by
-
- 3 edits in branches/Safari-2.0-system/WebCore
2007-07-09 Mark Rowe <mrowe@apple.com>
Merge r19551 from ToT to Safari-2.0-system.
2007-02-10 Maciej Stachowiak <mjs@apple.com>
Reviewed by me, patch from Ian Eng (cleaned up by me some).
- fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)
Test case: fast/dom/Window/window-appendages-cleared.html
- bindings/js/kjs_window.cpp: (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear):
- bindings/js/kjs_window.h:
- 1:08 AM Changeset in webkit [24133] by
-
- 2 edits in branches/Safari-2.0-system/WebCore
2007-07-09 Mark Rowe <mrowe@apple.com>
Merge r19126 from ToT to Safari-2.0-system.
2007-01-25 Dirk Mueller <mueller@kde.org>
Reviewed and merged by Beth.
Fix for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)
This is equivalent to commit 626791 in the KDE tree. Basically, the
patch allows comment parsing in titles to avoid capturing a
<script> tag by accident.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment):
- 1:08 AM Changeset in webkit [24132] by
-
- 2 edits in branches/Safari-2.0-system/WebKit
2007-07-09 Mark Rowe <mrowe@apple.com>
Merge r23963 from ToT to Safari-2.0-system.
2007-07-03 Adele Peterson <adele@apple.com>
Reviewed by Darin.
Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters
- Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):
Jul 9, 2007:
- 6:43 PM Changeset in webkit [24131] by
-
- 6 edits1 add in trunk/WebCore
Patch from Qing Zhao to add context menu support for Qt.
- 4:38 PM Changeset in webkit [24130] by
-
- 2 edits in trunk/WebKitTools
- Scripts/run-webkit-tests: Moved leaks from Tiger that are marked as fixed in Leopard to a Tiger-only section.
- 4:23 PM Changeset in webkit [24129] by
-
- 10 edits in trunk
LayoutTests:
- win/Skipped: removed one test from skipped list to see whether it will pass with the new DOM Paste API change that is being added simultaneously.
WebKitTools:
Reviewed by Adam Roben.
setting DOM Paste Allowed Pref
- DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initializePreferences):
win:
Reviewed by Adam Roben.
Adding DOM Paste Allowed preference, setters and getters
for the purpose of layout tests.
- Interfaces/IWebPreferences.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::isDOMPasteAllowed): (WebPreferences::setDOMPasteAllowed):
- WebPreferences.h:
- WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences):
- 4:19 PM Changeset in webkit [24128] by
-
- 2 edits in trunk/WebKit/win
Build fix.
- WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString):
- 4:18 PM Changeset in webkit [24127] by
-
- 2 edits in trunk/WebCore
Build fix.
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
- 3:10 PM Changeset in webkit [24126] by
-
- 10 edits in trunk/WebCore
Reviewed by Geoff.
Get rid of the node argument in our various script execution functions.
- bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate):
- bindings/js/kjs_proxy.h:
- bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute):
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): (WebCore::XMLTokenizer::notifyFinished):
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::evaluateScript):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::replaceContentsWithScriptResult): (WebCore::FrameLoader::executeScript):
- loader/FrameLoader.h:
- page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
- 3:06 PM Changeset in webkit [24125] by
-
- 1 edit20 adds in trunk/WebKitTools
Reviewed by Adam, Sam, and Ada.
- Inital checkin of Drosera for Win. This isn't pretty and doesn't connect to Safari but debug builds and runs.
- Drosera/Images/Drosera.ico: Added.
- Drosera/Images/small.ico: Added.
- Drosera/win: Added.
- Drosera/win/BaseDelegate.h: Added. (BaseDelegate::QueryInterface): (BaseDelegate::didFinishLoadForFrame): (BaseDelegate::windowScriptObjectAvailable): (BaseDelegate::didStartProvisionalLoadForFrame): (BaseDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): (BaseDelegate::didFailProvisionalLoadWithError): (BaseDelegate::didCommitLoadForFrame): (BaseDelegate::didReceiveTitle): (BaseDelegate::didReceiveIcon): (BaseDelegate::didFailLoadWithError): (BaseDelegate::didChangeLocationWithinPageForFrame): (BaseDelegate::willPerformClientRedirectToURL): (BaseDelegate::didCancelClientRedirectForFrame): (BaseDelegate::willCloseFrame): (BaseDelegate::createWebViewWithRequest): (BaseDelegate::webViewShow): (BaseDelegate::webViewClose): (BaseDelegate::webViewFocus): (BaseDelegate::webViewUnfocus): (BaseDelegate::webViewFirstResponder): (BaseDelegate::makeFirstResponder): (BaseDelegate::setStatusText): (BaseDelegate::webViewStatusText): (BaseDelegate::webViewAreToolbarsVisible): (BaseDelegate::setToolbarsVisible): (BaseDelegate::webViewIsStatusBarVisible): (BaseDelegate::setStatusBarVisible): (BaseDelegate::webViewIsResizable): (BaseDelegate::setResizable): (BaseDelegate::setFrame): (BaseDelegate::webViewFrame): (BaseDelegate::setContentRect): (BaseDelegate::webViewContentRect): (BaseDelegate::runJavaScriptAlertPanelWithMessage): (BaseDelegate::runJavaScriptConfirmPanelWithMessage): (BaseDelegate::runJavaScriptTextInputPanelWithPrompt): (BaseDelegate::runBeforeUnloadConfirmPanelWithMessage): (BaseDelegate::runOpenPanelForFileButtonWithResultListener): (BaseDelegate::mouseDidMoveOverElement): (BaseDelegate::contextMenuItemsForElement): (BaseDelegate::validateUserInterfaceItem): (BaseDelegate::shouldPerformAction): (BaseDelegate::dragDestinationActionMaskForDraggingInfo): (BaseDelegate::willPerformDragDestinationAction): (BaseDelegate::dragSourceActionMaskForPoint): (BaseDelegate::willPerformDragSourceAction): (BaseDelegate::contextMenuItemSelected): (BaseDelegate::hasCustomMenuImplementation): (BaseDelegate::trackCustomPopupMenu): (BaseDelegate::measureCustomMenuItem): (BaseDelegate::drawCustomMenuItem): (BaseDelegate::addCustomMenuDrawingData): (BaseDelegate::cleanUpCustomMenuDrawingData): (BaseDelegate::canTakeFocus): (BaseDelegate::takeFocus): (BaseDelegate::registerUndoWithTarget): (BaseDelegate::removeAllActionsWithTarget): (BaseDelegate::setActionTitle): (BaseDelegate::undo): (BaseDelegate::redo): (BaseDelegate::canUndo): (BaseDelegate::canRedo):
- Drosera/win/DebuggerApplication.cpp: Added. (DebuggerApplication::serverLoaded): (DebuggerApplication::serverUnloaded): (DebuggerApplication::attach): (DebuggerApplication::numberOfRowsInTableView): (DebuggerApplication::tableView):
- Drosera/win/DebuggerApplication.h: Added. (DebuggerApplication::DebuggerApplication): (DebuggerApplication::knownServers):
- Drosera/win/DebuggerObjectCallbacks.cpp: Added. (breakpointEditorHTMLCallback): (currentFunctionStackCallback): (doubleClickMillisecondsCallback): (evaluateScript_inCallFrame_Callback): (isPausedCallback): (localScopeVariableNamesForCallFrame_Callback): (pauseCallback): (resumeCallback): (stepIntoCallback): (valueForScopeVariableNamed_inCallFrame_Callback): (staticFunctions):
- Drosera/win/DebuggerObjectCallbacks.h: Added.
- Drosera/win/Drosera.cpp: Added. (_tWinMain): (RegisterDroseraClass): (DroseraWndProc): (About): (Attach): (Drosera::Drosera): (Drosera::initUI): (Drosera::QueryInterface): (Drosera::AddRef): (Drosera::Release): (Drosera::didFinishLoadForFrame): (getDroseraJSClass): (Drosera::windowScriptObjectAvailable): (Drosera::webViewClose): (Drosera::validateUserInterfaceItem): (Drosera::runJavaScriptAlertPanelWithMessage): (Drosera::onSize):
- Drosera/win/Drosera.h: Added. (Drosera::webViewLoaded):
- Drosera/win/Drosera.vcproj: Added.
- Drosera/win/Drosera.vcproj/Drosera.rc: Added.
- Drosera/win/Drosera.vcproj/Drosera.vcproj: Added.
- Drosera/win/Drosera.vcproj/debug.vsprops: Added.
- Drosera/win/Drosera.vcproj/release.vsprops: Added.
- Drosera/win/HelperFunctions.h: Added. (CFStringToBSTR):
- Drosera/win/Info.plist: Added.
- Drosera/win/resource.h: Added.
- Drosera/win/stdafx.cpp: Added.
- Drosera/win/stdafx.h: Added.
- 2:25 PM Changeset in webkit [24124] by
-
- 2 edits in trunk/WebKitQt
Patch from Eli Fidler to properly decode data: urls.
- 2:23 PM Changeset in webkit [24123] by
-
- 7 edits1 add1 delete in trunk
LayoutTests:
Rolling the fix for 5310404 back in now that 5310404 has been fixed in Mail.
- editing/deleting/4845371-expected.checksum:
- editing/deleting/4845371-expected.txt:
- editing/deleting/4845371.html:
- editing/deleting/5126166-expected.txt:
- editing/deleting/5290534.html: Added.
- editing/deleting/5290534.html-disabled: Removed.
WebCore:
Rolling the fix for 5290534 back in now that 5310404 has been fixed in Mail.
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete):
- 2:08 PM Changeset in webkit [24122] by
-
- 4 edits in trunk/WebCore
Reviewed by Anders Carlsson.
A little more FrameLoader cleanup while working on <rdar://problem/5126396>.
Rename: "checkEmitLoadEvent" => "checkCallImplicitClose" because the function
doesn't emit the load event; it just calls implicitClose.
Rename: "m_wasLoadEventEmitted" => "m_didCallImplicitClose" because the variable
tracks whether implicitClose was called.
- dom/Document.cpp: (WebCore::Document::implicitClose): Turned 12 lines of code into 6, adding ASSERT.
- loader/FrameLoader.h: Removed bogus declaration of non-existent emitLoadEvent().
- 2:06 PM Changeset in webkit [24121] by
-
- 2 edits in S60/trunk/WebKit
brmorris, rs'd by sachin
DESC: remove a compile warning by generating version info earlier
in the build process.
- 1:27 PM Changeset in webkit [24120] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by John.
<rdar://problem/5156801> REGRESSION: Crash when deleting table content in Leopard Mail
- editing/deleting/5156801-expected.checksum: Added.
- editing/deleting/5156801-expected.png: Added.
- editing/deleting/5156801-expected.txt: Added.
- editing/deleting/5156801.html: Added.
WebCore:
Reviewed by John.
REGRESSION: Crash when deleting table content in Leopard Mail
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): Use a RefPtr for the next node to delete, in case it is destroyed when the current node is deleted. In the crash reported in the radar, we crash because the next node is the div that holds the delete button and it's destroyed when the node that contains the selection is removed.
- 12:41 PM Changeset in webkit [24119] by
-
- 18 edits in trunk
Patch from Adam Treat to convert QWebFrame from QFrame to QObject. Fixes many
regressions from the previous patch.
- 11:28 AM Changeset in webkit [24118] by
-
- 11 edits2 adds in trunk
LayoutTests:
Reviewed by Oliver.
<rdar://problem/4954319>
Acrobat 7 / Safari crash: CrashTracer: 99 crashes in Safari at
com.apple.WebCore: WebCore::NetscapePlugInStreamLoader::isDone const + 0
Add tests.
- plugins/return-error-from-new-stream-callback-in-full-frame-plugin-expected.txt: Added.
- plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html: Added.
WebCore:
Reviewed by Oliver.
Add DocumentLoader::isLoadingMainResource.
- WebCore.exp:
WebKit:
Reviewed by Oliver.
<rdar://problem/4954319>
Acrobat 7 / Safari crash: CrashTracer: 99 crashes in Safari at
com.apple.WebCore: WebCore::NetscapePlugInStreamLoader::isDone const + 0
Add a new initWithFrameLoader: method to WebNetscapePluginStream which is to be used when
the stream is a "fake" stream for full frame plug-ins.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedResponse:]):
- Plugins/WebNetscapePluginStream.h:
- Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream initWithFrameLoader:]): (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream cancelLoadWithError:]): (-[WebNetscapePluginStream stop]):
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createFrame):
WebKitTools:
Reviewed by Oliver.
<rdar://problem/4954319>
Acrobat 7 / Safari crash: CrashTracer: 99 crashes in Safari at
com.apple.WebCore: WebCore::NetscapePlugInStreamLoader::isDone const + 0
If the src url is "data:application/x-webkit-test-netscape,returnerrorfromnewstream",
return an error from NPP_NewStream.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginAllocate):
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
- DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_New): (NPP_NewStream):
- 10:45 AM Changeset in webkit [24117] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin
- fixed <rdar://problem/5320208> WebKit should prevent Time Machine from backing up WebKit clients' icon databases
- Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): Re-added the code to exclude the icon database from backups. We now do this at the same time we (try to) import the old icon database format, which happens only once per icon database's lifetime. (-[WebIconDatabase _importToWebCoreFormat]): Assert that we haven't imported yet rather than bailing out. It's now the caller's responsibility to check whether we've imported yet.
- 10:44 AM Changeset in webkit [24116] by
-
- 1 edit in trunk/WebCore/ChangeLog
added missing Reviewer to previous checkin
- 10:43 AM Changeset in webkit [24115] by
-
- 2 edits in trunk/WebCore
- WebCore.exp:
- WebCore.xcodeproj/project.pbxproj: exported String::createCFString, needed for <rdar://problem/5320208>
- 10:21 AM Changeset in webkit [24114] by
-
- 2 edits in trunk/WebKitQt
Fix a minor memory leak in the loader
- 9:52 AM Changeset in webkit [24113] by
-
- 2 edits in trunk/WebKitQt
Fix a massive memory leak in the loader.
- 8:04 AM Changeset in webkit [24112] by
-
- 2 edits in S60/branches/3.1m/JavaScriptCore
ligman, reviewed by Yongjun Zhang
DESC: Character class array is defined to 32. If we don't limit characters to 255 an overflow occurs.
http://bugs.webkit.org/show_bug.cgi?id=14435
- pcre/pcre.c: (compile_branch): (match):
- 8:01 AM Changeset in webkit [24111] by
-
- 2 edits in S60/trunk/JavaScriptCore
ligman, reviewed by Yongjun Zhang
DESC: Character class array is defined to 32. If we don't limit characters to 255 an overflow occurs.
http://bugs.webkit.org/show_bug.cgi?id=14435
- pcre/pcre.c: (compile_branch): (match):
- 7:54 AM Changeset in webkit [24110] by
-
- 4 edits in S60/branches/3.1m/WebCore
2007-06-29 bujtas <zbujtas@gmail.com>
Reviewed by Yongjun
DESC: ref images right before switching to the final document,
so they dont get deleted.
http://bugs.webkit.org/show_bug.cgi?id=14464
WARNING: NO TEST CASES ADDED OR CHANGED
- khtml/khtml_part.cpp: (KHTMLPart::switchToFinalDoc):
- khtml/misc/loader.h: (khtml::):
- khtml/misc/loader_client.h: (khtml::DummyCachedObjectClient::~DummyCachedObjectClient): (khtml::DummyCachedObjectClient::setPixmap): (khtml::DummyCachedObjectClient::setStyleSheet): (khtml::DummyCachedObjectClient::setXBLDocument): (khtml::DummyCachedObjectClient::notifyFinished):
- 7:53 AM Changeset in webkit [24109] by
-
- 4 edits in S60/trunk/WebCore
2007-06-29 bujtas <zbujtas@gmail.com>
Reviewed by Yongjun
DESC: ref images right before switching to the final document,
so they dont get deleted.
http://bugs.webkit.org/show_bug.cgi?id=14464
WARNING: NO TEST CASES ADDED OR CHANGED
- khtml/khtml_part.cpp: (KHTMLPart::switchToFinalDoc):
- khtml/misc/loader.h: (khtml::):
- khtml/misc/loader_client.h: (khtml::DummyCachedObjectClient::~DummyCachedObjectClient): (khtml::DummyCachedObjectClient::setPixmap): (khtml::DummyCachedObjectClient::setStyleSheet): (khtml::DummyCachedObjectClient::setXBLDocument): (khtml::DummyCachedObjectClient::notifyFinished):
- 7:50 AM Changeset in webkit [24108] by
-
- 4 edits in trunk/WebKitQt
Rework much of WebCoreHttp to make it more stable and support Proxy and SSL.
- 12:57 AM Changeset in webkit [24107] by
-
- 1 edit1 add in trunk/WebCore
Reviewed by Maciej.
Test case for the bug below, which is http://bugs.webkit.org/show_bug.cgi?id=14207
- manual-tests/flash-unload-tab.html: Added.
- 12:39 AM Changeset in webkit [24106] by
-
- 4 edits in trunk
Reviewed by Oliver.
- JavaScriptCore part of fix for: <rdar://problem/5295734> Repro crash closing tab/window @ maps.google.com in WTF::HashSet<KJS::RuntimeObjectImp*, WTF::PtrHash<KJS::RuntimeObjectImp*>, WTF::HashTraits<KJS::RuntimeObjectImp*> >::add + 11
- JavaScriptCore.exp: Added needed export.
WebCore:
Reviewed by Oliver.
<rdar://problem/5295734> Repro crash closing tab/window @ maps.google.com in WTF::HashSet<KJS::RuntimeObjectImp*, WTF::PtrHash<KJS::RuntimeObjectImp*>, WTF::HashTraits<KJS::RuntimeObjectImp*> >::add + 11
Automated test case is not possible. Did not bother with manual test this time.
- bindings/js/kjs_dom.cpp: (WebCore::getRuntimeObject): Check that runtime root isn't null, as well as instance; this should cover the case where the plugin is already shut down and onunload time.
