Timeline



Sep 24, 2007:

5:53 PM Changeset in webkit [25720] by sfalken
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • fix <rdar://problem/5502513>
  • platform/win/FontCacheWin.cpp: (WebCore::FontCache::getFontLinkInterface): Roll back this file; the old code leaked a global COM object, but that's no big deal and the new code caused a crash on quit.
5:01 PM Changeset in webkit [25719] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5494608>
Seed: Safari will follow links in Flash movies without clicking.

Make sure to handle mouseover and mouseout so the plug-in can track when the mouse is over it.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent):
4:37 PM Changeset in webkit [25718] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5498016> Photoshop CS3: Adobe Help Viewer 1.1 crashes in 9A553

WebKit started calling the mouseDidMoveOverElement delegate method with a nil dictionary in r14982.
We originally intended to call this delegate method sometimes with a nil dictionary, but due to
a bug dating back to WebKit 1.0 this delegate was never called with nil! Unfortunately we can't
start calling this with nil since it will break Adobe Help Viewer, and possibly other clients.

  • WebView/WebView.mm: (-[WebView _mouseDidMoveOverElement:modifierFlags:]):
3:45 PM Changeset in webkit [25717] by weinig
  • 2 edits in trunk/LayoutTests

Reviewed by Adam Roben.

  • platform/win/Skipped: Comment out currently disabled tests.
2:36 PM Changeset in webkit [25716] by darin
  • 8 edits in trunk/WebKit/win

Reviewed by Steve.

  • fix <rdar://problem/5095701> Download requring HTTP auth fails (progress bar forever)

The functions in WebDownload relating to authentication challenges needed
to be implemented.

  • WebDownload.cpp: (WebDownload::cancelAuthenticationChallenge): Implement. (WebDownload::continueWithoutCredentialForAuthenticationChallenge): Ditto. (WebDownload::useCredential): Ditto. (WebDownload::willSendRequest): Fix storage leak by adopting request and response after creating them. Also retain the result before returning it, since that's the API contract with CFNetwork. (WebDownload::didReceiveAuthenticationChallenge): Implement. (WebDownload::didReceiveResponse): Fix storage leak by adopting response. (WebDownload::willResumeWithResponse): Ditto. (WebDownload::didFail): Ditto.
  • WebURLAuthenticationChallenge.h: Get rid of the IID #define, instead using declspec(uuid). Added a sender parameter to the create function and an m_sender data member.
  • WebURLAuthenticationChallenge.cpp: (WebURLAuthenticationChallenge::WebURLAuthenticationChallenge): Added an explicit sender parameter so this can be used with a WebDownload, which does not involve a ResourceHandle. Later we should clean this up and not involve WebCore or ResourceHandle directly even for the non-download case. (WebURLAuthenticationChallenge::createInstance): Added an overload for the case with an explicit sender parameter. (WebURLAuthenticationChallenge::QueryInterface): Use uuidof for the ID of this class. In general, we should move to uuidof as much as possible and keep the separate macros to a minimum -- but we should do this for all uses of each class at one time to make sure we don't run into problems with two different UUIDs for the same class. This patch does it for three classes. (WebURLAuthenticationChallenge::initWithProtectionSpace): Use the query constructor instead of an explicit QueryInterface for WebURLCredential. This is another class where I'm switching from CLSID/IID macros to the use of uuidof, but in this case the use of uuidof is implicit. (WebURLAuthenticationChallenge::initWithAuthenticationChallenge): Ditto, but for WebURLAuthenticationChallenge and WebURLAuthenticationChallengeSender. (WebURLAuthenticationChallenge::sender): Use the new m_sender member to cache the sender object and also use the one that was passed into the constructor, if any.
  • WebURLAuthenticationChallengeSender.h: Get rid of the IID #define, instead using declspec(uuid). Also minimize includes and make data members private instead of protected.
  • WebURLAuthenticationChallengeSender.cpp: (WebURLAuthenticationChallengeSender::QueryInterface): Use uuidof instead of IID macro. (WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge): Use query constructor instead of QueryInterface. (WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge): Ditto. (WebURLAuthenticationChallengeSender::useCredential): Ditto.
  • WebURLCredential.cpp: (WebURLCredential::QueryInterface): Use uuidof instead of CLSID_WebURLCredential.
  • tangentially-related cleanup
  • WebFrame.cpp: (WebFrame::dispatchDidReceiveAuthenticationChallenge): Use the adopt constructor instead of a separate adoptRef call. (WebFrame::dispatchDidCancelAuthenticationChallenge): Ditto.
1:58 PM Changeset in webkit [25715] by kmccullo
  • 1 edit
    1 delete in trunk/WebKitTools
  • Reverted an accidentally checked in file.
  • Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
1:10 PM Changeset in webkit [25714] by kmccullo
  • 3 edits in trunk/JavaScriptCore

Reviewed by Sam.

  • Continued to update project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
11:25 AM Changeset in webkit [25713] by staikos
  • 5 edits in trunk/WebCore

2007-09-24 Mike Fenton <​mike@staikos.net>

Reviewed by George Staikos.

Switch to using a QImage instead of a QPixmap to make transparency work.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint): (WebCore::HTMLCanvasElement::createDrawingContext): (WebCore::HTMLCanvasElement::createPlatformImage):
  • html/HTMLCanvasElement.h:
10:04 AM Changeset in webkit [25712] by kmccullo
  • 8 edits
    1 add in trunk

JavaScriptCore:

Reviewed by Sam.

  • Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.

WebCore:

Reviewed by Sam.

  • Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
  • WebCore.vcproj/WebCore.vcproj:

WebKitTools:

Reviewed by Sam.

  • Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
9:59 AM Changeset in webkit [25711] by kmccullo
  • 2 edits in trunk/LayoutTests

Reviewed by Sam.

  • Added a new test that will not pass until DRT supports new windows.
  • platform/win/Skipped:
9:34 AM Changeset in webkit [25710] by beidson
  • 4 edits in trunk

WebKit/win:

Reviewed by John Sullivan

Fix for <rdar://5493371> - Crash in Icon Database on Windows


  • WebIconDatabase.cpp: (WebIconDatabase::iconForURL): If the URL is NULL, fallback to the default icon without asking WebCore

WebCore:

Reviewed by John Sullivan

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::iconForPageURL): Assert the page url is non-null
9:26 AM Changeset in webkit [25709] by aroben
  • 2 edits in trunk/WebKit/win

Fix <rdar://5499507> FrameView will always have size (0,0) if its parent WebView is never resized

Reviewed by Darin.

  • WebView.cpp: (WebView::initWithFrame): Set the main FrameView's size to the size of the WebView.

Sep 23, 2007:

6:23 PM Changeset in webkit [25708] by mjs
  • 9 edits in trunk/WebKitSite

Reviewed by Mark Rowe.


  • Limit custom list bullets to ordered lists only
  • css/blue.css:
  • css/gray.css:
  • css/green.css:
  • css/ie.css:
  • css/main.css:
  • css/pink.css:
  • css/purple.css:
  • css/yellow.css:
5:21 PM Changeset in webkit [25707] by bdash
  • 4 edits in trunk

Versioning.

5:21 PM Changeset in webkit [25706] by bdash
  • 1 copy in tags/Safari-4523.8

New tag.

5:20 PM Changeset in webkit [25705] by bdash
  • 1 copy in tags/Safari-5523.8

New tag.

11:24 AM BuildingGtk edited by freyther@gmit-gmbh.de
(diff)
9:38 AM Changeset in webkit [25704] by ddkilzer
  • 2 edits in trunk/WebKitSite

WebKitSite:

Reviewed by Adam.

  • coding/coding-style.html:
    • in section Other Punctuation
      • syntax instead of synatax
      • fix sample code alignment
8:11 AM BuildingOnLinux edited by freyther@gmit-gmbh.de
(diff)
8:10 AM WikiStart edited by freyther@gmit-gmbh.de
(diff)
8:09 AM BuildingGdk edited by freyther@gmit-gmbh.de
(diff)
8:05 AM BuildingGtk created by freyther@gmit-gmbh.de
2:50 AM Changeset in webkit [25703] by zecke
  • 37 edits
    38 copies
    5 moves
    38 deletes in trunk

/:
2007-09-20 Holger Hans Peter Freyther <​zecke@selfish.org>

Rubber stamped by Adam.

Renamed files from *Gdk to *Gtk (see #14732) using the
work of Juan A. Suarez Romero as a base.

GDK -> GTK

  • WebKit.pri:
  • WebKit.pro:

JavaScriptCore:
2007-09-20 Holger Hans Peter Freyther <​zecke@selfish.org>

Rubber stamped by Adam.

Renamed files from *Gdk to *Gtk (see #14732) using the
work of Juan A. Suarez Romero as a base.

GDK -> GTK

  • JavaScriptCore.pri:
  • kjs/testkjs.pro:
  • pcre/dftables.pro:
  • wtf/Platform.h: PLATFORM(GDK) to PLATFORM(GTK)

WebCore:
2007-09-20 Holger Hans Peter Freyther <​zecke@selfish.org>

Rubber stamped by Adam.

Renamed files from *Gdk to *Gtk (see #14732) using the
work of Juan A. Suarez Romero as a base.

GDK -> GTK

  • Projects/gdk/webcore-gdk.bkl:
  • WebCore.pro:
  • WebCoreSources.bkl:
  • loader/gdk: Removed.
  • loader/gdk/DocumentLoaderGdk.cpp: Removed.
  • loader/gtk: Added.
  • loader/gtk/DocumentLoaderGdk.cpp: Removed.
  • loader/gtk/DocumentLoaderGtk.cpp: Added.
  • page/FrameView.cpp:
  • page/FrameView.h:
  • page/gdk: Removed.
  • page/gdk/DragControllerGdk.cpp: Removed.
  • page/gdk/EventHandlerGdk.cpp: Removed.
  • page/gdk/FrameGdk.cpp: Removed.
  • page/gtk: Added.
  • page/gtk/DragControllerGdk.cpp: Removed.
  • page/gtk/DragControllerGtk.cpp: Added.
  • page/gtk/EventHandlerGdk.cpp: Removed.
  • page/gtk/EventHandlerGtk.cpp: Added. (WebCore::EventHandler::createDraggingClipboard):
  • page/gtk/FrameGdk.cpp: Removed.
  • page/gtk/FrameGtk.cpp: Added.
  • platform/ContextMenuItem.h:
  • platform/Cursor.h:
  • platform/DragData.h:
  • platform/DragImage.h:
  • platform/FontData.h:
  • platform/NotImplemented.h:
  • platform/PlatformKeyboardEvent.h:
  • platform/PlatformMenuDescription.h:
  • platform/PlatformMouseEvent.h:
  • platform/PlatformWheelEvent.h:
  • platform/ScrollView.h:
  • platform/Widget.h:
  • platform/gdk: Removed.
  • platform/gdk/ClipboardGdk.cpp: Removed.
  • platform/gdk/ClipboardGdk.h: Removed.
  • platform/gdk/ContextMenuGdk.cpp: Removed.
  • platform/gdk/ContextMenuItemGdk.cpp: Removed.
  • platform/gdk/CookieJarGdk.cpp: Removed.
  • platform/gdk/CursorGdk.cpp: Removed.
  • platform/gdk/DragDataGdk.cpp: Removed.
  • platform/gdk/DragImageGdk.cpp: Removed.
  • platform/gdk/FileChooserGdk.cpp: Removed.
  • platform/gdk/FileSystemGdk.cpp: Removed.
  • platform/gdk/FontCacheGdk.cpp: Removed.
  • platform/gdk/FontDataGdk.cpp: Removed.
  • platform/gdk/FontGdk.cpp: Removed.
  • platform/gdk/FontPlatformData.h: Removed.
  • platform/gdk/FontPlatformDataGdk.cpp: Removed.
  • platform/gdk/GlyphPageTreeNodeGdk.cpp: Removed.
  • platform/gdk/KeyEventGdk.cpp: Removed.
  • platform/gdk/KeyboardCodes.h: Removed.
  • platform/gdk/LocalizedStringsGdk.cpp: Removed.
  • platform/gdk/LoggingGdk.cpp: Removed.
  • platform/gdk/MIMETypeRegistryGdk.cpp: Removed.
  • platform/gdk/MouseEventGdk.cpp: Removed.
  • platform/gdk/PasteboardGdk.cpp: Removed.
  • platform/gdk/PlatformScreenGdk.cpp: Removed.
  • platform/gdk/PlatformScrollBar.h: Removed.
  • platform/gdk/PlatformScrollBarGdk.cpp: Removed.
  • platform/gdk/PopupMenuGdk.cpp: Removed.
  • platform/gdk/RenderThemeGdk.cpp: Removed.
  • platform/gdk/RenderThemeGdk.h: Removed.
  • platform/gdk/ScrollViewGdk.cpp: Removed.
  • platform/gdk/SearchPopupMenuGdk.cpp: Removed.
  • platform/gdk/SharedTimerLinux.cpp: Removed.
  • platform/gdk/SoundGdk.cpp: Removed.
  • platform/gdk/SystemTimeLinux.cpp: Removed.
  • platform/gdk/TemporaryLinkStubs.cpp: Removed.
  • platform/gdk/WheelEventGdk.cpp: Removed.
  • platform/gdk/WidgetGdk.cpp: Removed.
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::setPlatformFont):
  • platform/graphics/gdk: Removed.
  • platform/graphics/gdk/IconGdk.cpp: Removed.
  • platform/graphics/gdk/ImageGdk.cpp: Removed.
  • platform/graphics/gtk: Added.
  • platform/graphics/gtk/IconGdk.cpp: Removed.
  • platform/graphics/gtk/IconGtk.cpp: Added.
  • platform/graphics/gtk/ImageGdk.cpp: Removed.
  • platform/graphics/gtk/ImageGtk.cpp: Added.
  • platform/gtk: Added.
  • platform/gtk/ClipboardGdk.cpp: Removed.
  • platform/gtk/ClipboardGdk.h: Removed.
  • platform/gtk/ClipboardGtk.cpp: Added. (WebCore::ClipboardGtk::ClipboardGtk): (WebCore::ClipboardGtk::~ClipboardGtk): (WebCore::ClipboardGtk::clearData): (WebCore::ClipboardGtk::clearAllData): (WebCore::ClipboardGtk::getData): (WebCore::ClipboardGtk::setData): (WebCore::ClipboardGtk::types): (WebCore::ClipboardGtk::dragLocation): (WebCore::ClipboardGtk::dragImage): (WebCore::ClipboardGtk::setDragImage): (WebCore::ClipboardGtk::dragImageElement): (WebCore::ClipboardGtk::setDragImageElement): (WebCore::ClipboardGtk::createDragImage): (WebCore::ClipboardGtk::declareAndWriteDragImage): (WebCore::ClipboardGtk::writeURL): (WebCore::ClipboardGtk::writeRange): (WebCore::ClipboardGtk::hasData):
  • platform/gtk/ClipboardGtk.h: Added.
  • platform/gtk/ContextMenuGdk.cpp: Removed.
  • platform/gtk/ContextMenuGtk.cpp: Added.
  • platform/gtk/ContextMenuItemGdk.cpp: Removed.
  • platform/gtk/ContextMenuItemGtk.cpp: Added.
  • platform/gtk/CookieJarGdk.cpp: Removed.
  • platform/gtk/CookieJarGtk.cpp: Added.
  • platform/gtk/CursorGdk.cpp: Removed.
  • platform/gtk/CursorGtk.cpp: Added.
  • platform/gtk/DragDataGdk.cpp: Removed.
  • platform/gtk/DragDataGtk.cpp: Added.
  • platform/gtk/DragImageGdk.cpp: Removed.
  • platform/gtk/DragImageGtk.cpp: Added.
  • platform/gtk/FileChooserGdk.cpp: Removed.
  • platform/gtk/FileChooserGtk.cpp: Added.
  • platform/gtk/FileSystemGdk.cpp: Removed.
  • platform/gtk/FileSystemGtk.cpp: Added.
  • platform/gtk/FontCacheGdk.cpp: Removed.
  • platform/gtk/FontCacheGtk.cpp: Added.
  • platform/gtk/FontDataGdk.cpp: Removed.
  • platform/gtk/FontDataGtk.cpp: Added.
  • platform/gtk/FontGdk.cpp: Removed.
  • platform/gtk/FontGtk.cpp: Added.
  • platform/gtk/FontPlatformDataGdk.cpp: Removed.
  • platform/gtk/FontPlatformDataGtk.cpp: Added.
  • platform/gtk/GlyphPageTreeNodeGdk.cpp: Removed.
  • platform/gtk/GlyphPageTreeNodeGtk.cpp: Added.
  • platform/gtk/KeyEventGdk.cpp: Removed.
  • platform/gtk/KeyEventGtk.cpp: Added.
  • platform/gtk/LocalizedStringsGdk.cpp: Removed.
  • platform/gtk/LocalizedStringsGtk.cpp: Added.
  • platform/gtk/LoggingGdk.cpp: Removed.
  • platform/gtk/LoggingGtk.cpp: Added.
  • platform/gtk/MIMETypeRegistryGdk.cpp: Removed.
  • platform/gtk/MIMETypeRegistryGtk.cpp: Added.
  • platform/gtk/MouseEventGdk.cpp: Removed.
  • platform/gtk/MouseEventGtk.cpp: Added.
  • platform/gtk/PasteboardGdk.cpp: Removed.
  • platform/gtk/PasteboardGtk.cpp: Added.
  • platform/gtk/PlatformScreenGdk.cpp: Removed.
  • platform/gtk/PlatformScreenGtk.cpp: Added.
  • platform/gtk/PlatformScrollBarGdk.cpp: Removed.
  • platform/gtk/PlatformScrollBarGtk.cpp: Added.
  • platform/gtk/PopupMenuGdk.cpp: Removed.
  • platform/gtk/PopupMenuGtk.cpp: Added.
  • platform/gtk/RenderThemeGdk.cpp: Removed.
  • platform/gtk/RenderThemeGdk.h: Removed.
  • platform/gtk/RenderThemeGtk.cpp: Added. (WebCore::theme): (WebCore::RenderThemeGtk::RenderThemeGtk): (WebCore::RenderThemeGtk::close): (WebCore::RenderThemeGtk::addIntrinsicMargins): (WebCore::RenderThemeGtk::supportsFocus): (WebCore::RenderThemeGtk::determineState): (WebCore::RenderThemeGtk::determineShadow): (WebCore::RenderThemeGtk::getThemeData): (WebCore::RenderThemeGtk::setCheckboxSize): (WebCore::RenderThemeGtk::paintCheckbox): (WebCore::RenderThemeGtk::setRadioSize): (WebCore::RenderThemeGtk::paintRadio): (WebCore::RenderThemeGtk::paintButton): (WebCore::RenderThemeGtk::adjustTextFieldStyle): (WebCore::RenderThemeGtk::paintTextField): (WebCore::RenderThemeGtk::paintTextArea): (WebCore::RenderThemeGtk::adjustButtonStyle): (WebCore::RenderThemeGtk::systemFont): (WebCore::RenderThemeGtk::gtkButton): (WebCore::RenderThemeGtk::gtkCheckbox): (WebCore::RenderThemeGtk::gtkRadioButton): (WebCore::RenderThemeGtk::gtkWindowContainer):
  • platform/gtk/RenderThemeGtk.h: Added.
  • platform/gtk/ScrollViewGdk.cpp: Removed.
  • platform/gtk/ScrollViewGtk.cpp: Added.
  • platform/gtk/SearchPopupMenuGdk.cpp: Removed.
  • platform/gtk/SearchPopupMenuGtk.cpp: Added.
  • platform/gtk/SoundGdk.cpp: Removed.
  • platform/gtk/SoundGtk.cpp: Added.
  • platform/gtk/WheelEventGdk.cpp: Removed.
  • platform/gtk/WheelEventGtk.cpp: Added.
  • platform/gtk/WidgetGdk.cpp: Removed.
  • platform/gtk/WidgetGtk.cpp: Added.
  • platform/network/ResourceHandle.h:

WebKitTools:
2007-09-20 Holger Hans Peter Freyther <​zecke@selfish.org>

Rubber stamped by Adam.

  • GdkLauncher: Removed.
  • GdkLauncher/Bakefiles.bkgen: Removed.
  • GdkLauncher/ENV: Removed.
  • GdkLauncher/GdkLauncher.pro: Removed.
  • GdkLauncher/gdklauncher.bkl: Removed.
  • GdkLauncher/main.cpp: Removed.
  • GdkLauncher/mk: Removed.
  • GdkLauncher/simple.svg: Removed.
  • GdkLauncher/text.html: Removed.
  • GtkLauncher: Added.
  • GtkLauncher/GdkLauncher.pro: Removed.
  • GtkLauncher/GtkLauncher.pro: Added.
  • GtkLauncher/main.cpp: (updateWindowTitle): (main):
  • Scripts/build-webkit:
  • Scripts/regenerate-makefiles:
  • Scripts/run-javascriptcore-tests:
  • Scripts/run-launcher:
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
1:55 AM Changeset in webkit [25702] by rwlbuis
  • 4 edits
    4 adds in trunk

Reviewed by Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=15025
Background repeat css property is not inherited from parent if unspecified

Don't let invalid url specification in background shorthand make
the entire shorthand invalid.

Sep 22, 2007:

9:03 PM Changeset in webkit [25701] by aroben
  • 3 edits
    2 adds in trunk

Fix Bug 15251: REGRESSION: <input type=range> doesn't respond to form.reset() or setting input.value

WebCore:

Fix Bug 15251: REGRESSION: <input type=range> doesn't respond to form.reset() or setting input.value

​http://bugs.webkit.org/show_bug.cgi?id=15251
<rdar://5498169>

Reviewed by Maciej.

Test: fast/forms/range-reset.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): <input type=range> should be storing its value separately from the value attribute, as do all of our variable-input input types.

LayoutTests:

Test for Bug 15251: REGRESSION: <input type=range> doesn't respond to form.reset() or setting input.value

​http://bugs.webkit.org/show_bug.cgi?id=15251
<rdar://5498169>

Reviewed by Maciej.

  • fast/forms/range-reset-expected.txt: Added.
  • fast/forms/range-reset.html: Added.
2:21 PM Changeset in webkit [25700] by oliver
  • 3 edits in branches/feature-branch/WebCore

Reviewed by NOBODY (Build fix).

  • platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::SVGPaintServerGradient::teardown): (WebCore::SVGPaintServerGradient::renderPath):
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback):

Sep 21, 2007:

9:20 PM Changeset in webkit [25699] by bdash
  • 5 edits in trunk/WebCore

2007-09-21 Mark Rowe <​mrowe@apple.com>

Build fix for non-Mac platforms after r25697.

Rename Frame::cleanupPlatformScriptObjects to Frame::clearPlatformScriptObjects.

  • bridge/win/FrameWin.cpp:
  • page/gdk/FrameGdk.cpp:
  • page/qt/FrameQt.cpp:
  • platform/wx/TemporaryLinkStubs.cpp:
8:56 PM Changeset in webkit [25698] by adele
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Sam.

Fix for <rdar://problem/5497357> REGRESSION: Safari doesn't show the month days on AirFrance reservation page

Test: fast/dom/HTMLSelectElement/options-collection-set-string-length.html

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::setLength): Convert the value to a number. We already have code here to check if the value is not a number. This matches other browsers, which allow a string value to be used to set the length.

LayoutTests:

Reviewed by Sam.

Test for <rdar://problem/5497357> REGRESSION: Safari doesn't show the month days on AirFrance reservation page

  • fast/dom/HTMLSelectElement/options-collection-set-string-length-expected.txt: Added.
  • fast/dom/HTMLSelectElement/options-collection-set-string-length.html: Added.
5:49 PM Changeset in webkit [25697] by thatcher
  • 12 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded

Calling -[WebView windowScriptObject] before the page loads would give you nil. This behavior didn't match Tiger.
The API behavior in Tiger let you get the window script object once and keep ahold of it as long as you needed it.
The window object would remain valid even after page loads. This change restores the Tiger behavior.

<rdar://problem/5495790> NULL dereference crash beneath Bindings::RootObject::interpreter when saving Dashcode document

The changes to WebScriptObject's _isSafeScript call also fixed the crash in Dashcode.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject _setOriginRootObject:andRootObject:]): New method used to update the the root objects, so the WebScriptObject can still be used after a page load. (-[WebScriptObject _isSafeScript]): Call [self _rootObject] instead of accessing the data member directly. DOMNode has an override for the _rootObject method, and it can return 0 when _private->_rootObject is non-zero. We would return YES here when it wasn't safe and later crash with my modified layout tests. Checking _rootObject first prevents other calls sites from needing to check for a valid root object, this fixed the Dashcode crash. (-[WebScriptObject _imp]): Ditto.
  • bindings/objc/WebScriptObjectPrivate.h: Add _setOriginRootObject:andRootObject:.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Call the renamed clearScriptObjects function. (WebCore::FrameLoader::dispatchWindowObjectAvailable): Some gratuitous code cleanup.
  • page/Frame.cpp: (WebCore::Frame::clearScriptObjects): Renamed cleanupScriptObject to clearScriptObjects. Call clearPlatformScriptObjects last so m_bindingRootObject is already NULL. (WebCore::Frame::windowScriptNPObject): Hold a JSLock before accessing the window. This change is unrelated to the bug, but should be fixed.
  • page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject): Return a script object even if the interpreter is NULL. This resotres the Tiger behavior of always being able to access the window object. (WebCore::Frame::clearPlatformScriptObjects): Keep the window script object around, and update the root objects for the window script object.
  • page/Frame.h: Rename cleanupScriptObject to clearScriptObjects.
  • page/FramePrivate.h: Use a RetainPtr for m_windowScriptObject.

WebKitTools:

Reviewed by Darin.

<rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)

Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
This is tested by plugins/root-object-premature-delete-crash.html.

  • DumpRenderTree/mac/ObjCController.m: (-[ObjCController accessStoredWebScriptObject]):

LayoutTests:

Reviewed by Darin.

<rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)

Updated results to show the didClearWindowScriptObject delegate call. Tweaked plugins/root-object-premature-delete-crash.html
to test a non-window script object half the time. This change works with a change to DumpRenderTree.

  • http/tests/loading/empty-subframe-expected.txt:
  • http/tests/loading/simple-subframe-expected.txt:
  • plugins/root-object-premature-delete-crash.html:
  • webarchive/loading/test-loading-archive-expected.txt:
5:30 PM Changeset in webkit [25696] by staikos
  • 2 edits in trunk/WebCore

2007-09-21 Mike Fenton <​mike@staikos.net>

Reviewed by George Staikos.

Fix styled pen support by not clobbering QPen properties.

  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
5:00 PM Changeset in webkit [25695] by oliver
  • 1 edit in trunk/WebCore/ChangeLog

Darin reviewed as well, and pointed out mistake in ChangeLog

4:51 PM Changeset in webkit [25694] by oliver
  • 2 edits in trunk/WebCore

Reviewed by Tristan.

​http://bugs.webkit.org/show_bug.cgi?id=15239
<rdar://problem/5491955> REGRESSION (r25547): With Hanin IME, one cannot input characters into forms (15239)


This problem was caused by the setComposition method failing to clearing
the composition markers in the presence of an empty string. This would
result in the caret being locked within the 0 length bounds of the "composition"
and so preventing basic keyboard interaction.

  • editing/Editor.cpp: (WebCore::Editor::setComposition):
4:29 PM Changeset in webkit [25693] by adele
  • 3 edits in trunk/WebCore

Reviewed by Tristan.

Fix for <rdar://problem/5497346> "Check spelling when I click Send" crashes on stationery messages every time

No test. I wasn't able to find a way to get this to occur with Safari or DumpRenderTree.

  • editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling): Updated comment.
  • editing/htmlediting.cpp: (WebCore::firstEditablePositionAfterPositionInRoot): Only return the root position if its editable. (WebCore::maxDeepOffset): Added nil check & assert.
4:18 PM Changeset in webkit [25692] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Steve.

<rdar://problem/5404339>
Site redirects continuosly, starving UI thread, causing app to hang.


Use GetQueueStatus to see if there are input messages in the queue that aren't being processed.
If so, use a low-priority timer instead of PostMessage.


  • platform/win/SharedTimerWin.cpp: (WebCore::setSharedTimerFireTime):
4:11 PM Changeset in webkit [25691] by tristan
  • 8 edits in branches/Safari-2.0-dashboard/WebCore

Merge r24938 and r24946 from ToT to Safari-2.0-dashboard.


2007-08-08 Sam Weinig <​sam@webkit.org>


Reviewed by Geoff Garen.

Fix for <rdar://problem/5354635>

Match Firefox's model for data: URLs by not allowing them script access
to any frames other then itself.

  • bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
  • dom/Document.cpp: (WebCore::Document::initSecurityPolicyURL):


2007-08-08 Sam Weinig <​sam@webkit.org>

Reviewed by Brady.

Make protocol and host compares case-insensitive.

  • bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
  • dom/Document.cpp: (WebCore::Document::initSecurityPolicyURL):
  • platform/DeprecatedString.cpp: (WebCore::equalIgnoringCase):
  • platform/DeprecatedString.h: (WebCore::equalIgnoringCase):
3:47 PM Changeset in webkit [25690] by darin
  • 4 edits in trunk/WebCore

Reviewed by Anders.

  • add QueryInterface capabilities to COMPtr
  • platform/win/COMPtr.h: (COMPtr::COMPtr): Added constructor that takes a Query tag and does an appropriate QueryInterface. (COMPtr::query): Added function to do a queryInterface. (COMPtr::copyQueryInterfaceRef): Added private helper used by both of the above. Note that when the query fails you get a 0, which is the same thing you get if a 0 pointer is passed in.
  • platform/win/FontCacheWin.cpp: (WebCore::FontCache::getFontLinkInterface): Convert to using the new query as a test case. Also eliminate the unnecessary second global variable and use COMPtr objects rather than just leaking references.
  • platform/win/WCDataObject.h: Removed unneeded include and using statements.
2:58 PM Changeset in webkit [25689] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5494790>
clicking any link in the Flash regions at bananarepublic.com results in bad page

Don't replace the frame contents, the Mac version doesn't do this.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
1:15 PM Changeset in webkit [25688] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5496700>
Repro crash loading ​http://www.tivo.com/whatistivo/tivohd/index.html

Don't continue if the plug-in cancelled the stream.


  • loader/win/NetscapePlugInStreamLoaderWin.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
1:12 PM Changeset in webkit [25687] by kmccullo
  • 2 edits in trunk/WebKitTools

Reviewed by Oliver.

  • We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
  • DumpRenderTree/win/FrameLoaderDelegate.cpp: (FrameLoadDelegate::FrameLoadDelegate):
12:48 PM Changeset in webkit [25686] by kdecker
  • 2 edits in trunk/WebKit
  • Plugins/WebBaseNetscapePluginView.mm: Build fix. The first argument of aglChoosePixelFormat() has changed from const AGLDevice *gdevs on Tiger to const void *gdevs on Leopard.
12:15 PM Changeset in webkit [25685] by kdecker
  • 3 edits in trunk/WebKit

Reviewed by Darin Adler.

<rdar://problem/5493093>

Reduced launch time by lazily linking both the AGL and OpenGL frameworks until they are really needed.

  • Plugins/WebBaseNetscapePluginView.mm: Soft link all AGL and OpenGL functions used by WebBaseNetscapePluginView.
  • WebKit.xcodeproj/project.pbxproj: Removed AGL and OpenGL from the project.
12:14 PM Changeset in webkit [25684] by kdecker
  • 2 edits in trunk/WebCore
  • platform/mac/SoftLinking.h: Build fix; added necessary #imports.
12:06 PM Changeset in webkit [25683] by kdecker
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj: Added SoftLinking.h to the project.
  • platform/mac/SoftLinking.h: Contains a new macro; useful in helping to lazily load frameworks.
10:15 AM Changeset in webkit [25682] by kmccullo
  • 2 edits in trunk/WebKit/win
  • Fixed a syntax guideline mistake.
  • WebChromeClient.cpp: (WebChromeClient::scrollbarsVisible):
4:06 AM Changeset in webkit [25681] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-09-21 Mark Rowe <​mrowe@apple.com>

Reviewed by Antti Koivisto.

​http://bugs.webkit.org/show_bug.cgi?id=15250
<rdar://problem/5496942> REGRESSION: Reproducible crash in Safari when evaluating script in Drosera console (15250)

  • kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction): Null-check thisObj before passing it to interpreterForGlobalObject.
12:02 AM Changeset in webkit [25680] by oliver
  • 3 edits in trunk/WebKit/win

2007-09-20 Oliver Hunt <​oliver@apple.com>

Reviewed by Steve.

<rdar://problem/5487153> Korean characters are displayed as garbage with default encoding in some Korean web sites

Adding support for per-localisation default character encodings on
windows.

  • English.lproj/Localizable.strings:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):

Sep 20, 2007:

5:48 PM Changeset in webkit [25679] by kmccullo
  • 2 edits in trunk/WebKit/win

Reviewed by Oliver.

  • Added the ability to ask if scrollbars are visible
  • <rdar://problem/5496211> scrollbarsVisible in WebChromeClient is not implemented
  • WebChromeClient.cpp: (WebChromeClient::scrollbarsVisible):
5:28 PM Changeset in webkit [25678] by darin
  • 1 edit in trunk/WebKitLibraries/win/lib

Ignore WebKitAuxiliaryLibraries files put here by update-webkit.

5:27 PM Changeset in webkit [25677] by darin
  • 1 edit in trunk/WebKitLibraries/win/include

Ignore WebKitAuxiliaryLibraries files put here by the update-webkit script.

5:19 PM Changeset in webkit [25676] by adachan
  • 6 edits in trunk

<rdar://problem/5477240> Regression: Footer is too high in print preview


Reviewed by Steve.

WebCore:

Make computePageRectsForFrame() return the height of the page adjusted for margins.

  • bridge/win/FrameWin.cpp: (WebCore::computePageRectsForFrame):
  • bridge/win/FrameWin.h:


WebKit/win:

  • WebFrame.cpp: (WebFrame::WebFrame): initialize new data member m_pageHeight, which is the height of the page adjusted for margins. (WebFrame::computePageRects): get the height of the page adjusted for margins by passing m_pageHeight to computePageRectsForFrame(). (WebFrame::spoolPages): footer rect's top is the max of the bottom of the page content and the bottom of the page minus footer height.
  • WebFrame.h:
4:26 PM Changeset in webkit [25675] by kmccullo
  • 8 edits in trunk

WebCore:

Reviewed by Hyatt.

  • <rdar://problem/5101991> Avril Lavigne music player comes up in a window with scrollbars
  • Implementing missing scrollbar functionality to allow turning off scrollbars correctly.
  • platform/ScrollView.h:
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::setAllowsScrolling): (WebCore::ScrollView::ScrollViewPrivate::allowsScrolling): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::setAllowsScrolling): (WebCore::ScrollView::allowsScrolling):

win:

Reviewed by Hyatt.

  • <rdar://problem/5101991> Avril Lavigne music player comes up in a window with scrollbars
  • Implementing missing scrollbar functionality to allow turning off scrollbars correctly.
  • Interfaces/IWebFrame.idl:
  • Interfaces/IWebFrameView.idl:
  • WebChromeClient.cpp: (WebChromeClient::setScrollbarsVisible):
  • WebFrame.cpp: (WebFrame::setAllowsScrolling): (WebFrame::allowsScrolling): (WebFrame::frameView):
  • WebFrame.h:
4:13 PM Changeset in webkit [25674] by beidson
  • 6 edits in trunk

WebCore:

Reviewed by Dave Hyatt

<rdar://problem/5245981> - No favicon shows up for cnet.com


CNet's favicon has two images in it - a 32x32 white square, and a 16x16 image that is their actual icon
Till now on Windows we've always gone straight for the first image in an icon for the favicon, now we
actually do proper size matching

  • platform/graphics/BitmapImage.h:
  • platform/graphics/Image.h: (WebCore::Image::getHBITMAPOfSize): (WebCore::Image::drawFrameMatchingSourceSize): Search through the frames of the image for the correct size
  • platform/graphics/win/ImageWin.cpp: (WebCore::BitmapImage::getHBITMAP): (WebCore::BitmapImage::getHBITMAPOfSize): (WebCore::BitmapImage::drawFrameMatchingSourceSize):

WebKit/win:

Reviewed by Dave Hyatt

<rdar://problem/5245981> - No favicon shows up for cnet.com


  • WebIconDatabase.cpp: (WebIconDatabase::iconForURL): Call getHBITMAPOfSize (WebIconDatabase::getOrCreateDefaultIconBitmap): Ditto
2:58 PM Changeset in webkit [25673] by sfalken
  • 2 edits in trunk/WebCore

Reviewed by Brady.

Call ascii() instead of utf8() from debug logging code to avoid threading
issues associated w/ converting to UTF8.

11:53 AM Changeset in webkit [25672] by staikos
  • 4 edits in trunk/WebCore

2007-09-20 Mike Fenton <​mike@staikos.net>

Reviewed by George Staikos.

Implement gradients and more of canvas for Qt. Style changes and some
of the stroking fixes by George.

  • html/CanvasGradient.cpp: (WebCore::CanvasGradient::CanvasGradient): (WebCore::CanvasGradient::~CanvasGradient): (WebCore::CanvasGradient::addColorStop): (WebCore::CanvasGradient::platformShading):
  • html/CanvasGradient.h:
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::applyFillPattern):
10:26 AM Changeset in webkit [25671] by sullivan
  • 2 edits in trunk/WebKit

Build fix for stoooopid old PPC gcc compiler

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::checkSpellingOfString): replace perfectly valid ?: syntax with if/else
4:05 AM Changeset in webkit [25670] by ddkilzer
  • 3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Adam.

Fix: ​http://bugs.webkit.org/show_bug.cgi?id=15223
webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt

Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
Now isQt() and isGdk() use global variables that are only set once.

An array of all the parameters is now given to build-dumprender which includes
the platform on linux.

  • Scripts/build-dumprendertree:
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
3:53 AM Changeset in webkit [25669] by ddkilzer
  • 1 edit in trunk/WebCore/ChangeLog

Added radar.

1:52 AM Changeset in webkit [25668] by rwlbuis
  • 3 edits
    2 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=15235
Options can not be removed from a Select element with OptGroup's using JavaScript

Remove HTMLOptionElement children against the proper parent node.

Note: See TracTimeline for information about the timeline view.