Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Oct 26, 2007:

9:42 PM Changeset in webkit [27141] by weinig

• 5 edits in trunk/WebCore

Enable dragging the left sidebar using the separator.

Reviewed by Anders (unless Mitz says otherwise).

• page/inspector/DocumentPanel.js:
• page/inspector/inspector.css:
• page/inspector/inspector.html:
• page/inspector/inspector.js:

8:40 PM Changeset in webkit [27140] by weinig

• 2 edits in trunk/WebCore

Fix an off by one error when resizing the Inspector find window.

Reviewed by Hyatt.

• page/inspector/inspector.js:

7:56 PM Changeset in webkit [27139] by honeycutt

• 2 edits in trunk/WebCore

2007-10-26 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Adam.

Fix fallout from r26072, which leads to all plugin streams for local
resources being cancelled

• loader/win/NetscapePlugInStreamLoaderWin.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): Ensure this is an HTTP response before checking the HTTP response code

7:50 PM Changeset in webkit [27138] by hyatt

• 2 edits
  4 adds in trunk

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=15719, transformed box doesn't repaint properly
when only translation changes.

Move the updating of the transform to in between the old repaint and the new repaint.

Reviewed by mitz

fast/repaint/transform-translate.html

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):

6:45 PM Changeset in webkit [27137] by kmccullo

• 2 edits
  2 moves in trunk/JavaScriptCore

Rubber stamp by Adam.

• Renamed JSStringRefCOM to JSStringRefBSTR since it he only thing the files contain are functions that operate on BSTRs.

• API/JSStringRefBSTR.cpp: Copied from API/JSStringRefCOM.cpp.
• API/JSStringRefBSTR.h: Copied from API/JSStringRefCOM.h.
• API/JSStringRefCOM.cpp: Removed.
• API/JSStringRefCOM.h: Removed.
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

6:38 PM Changeset in webkit [27136] by kmccullo

• 3 edits in trunk/WebKitTools

Reviewed by Adam.

• Implemented the WebScriptDebugListener functions now that the WebScriptDebugServer exists

• Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener functions. (ServerConnection::currentFrame): (ServerConnection::didLoadMainResourceForDataSource): (ServerConnection::didParseSource): (ServerConnection::failedToParseSource): (ServerConnection::didEnterCallFrame): (ServerConnection::willExecuteStatement): (ServerConnection::willLeaveCallFrame): (ServerConnection::exceptionWasRaised):
• Drosera/win/ServerConnection.h: Removed unused arguments from the members arguments list.

6:37 PM Changeset in webkit [27135] by kmccullo

• 2 edits in trunk/JavaScriptCore

Reviewed by Adam.

• Made JSStringCreateWithBSTR capable of handling null BSTRs.

• API/JSStringRefCOM.cpp: (JSStringCreateWithBSTR):

6:01 PM Changeset in webkit [27134] by weinig

• 3 edits in trunk/JavaScriptCore

Windows build fix.

• kjs/SymbolTable.h: Add header gaurd.
• kjs/nodes.h: #include "SymbolTable.h"

4:33 PM Changeset in webkit [27133] by ggaren

• 2 edits in trunk/JavaScriptCore

Suggested by Anders Carlsson.

Fixed tyop.

• kjs/function.cpp: (KJS::ActivationImp::getOwnPropertySlot):

4:31 PM Changeset in webkit [27132] by ggaren

• 2 edits in trunk/JavaScriptCore

Suggested by Darin Adler.

Use computedHash(), which is safer than just directly accessing _hash.

• kjs/lookup.cpp: (KJS::Lookup::findEntry): (KJS::Lookup::find):

4:07 PM Changeset in webkit [27131] by honeycutt

• 5 edits in trunk/WebCore

2007-10-26 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

<rdar://5557379> Crash in Silverlight when opening microsoft.com

The crash is within Silverlight, and the latest version of the plugin
does not exhibit this crash, so just avoid loading this version of the
plugin.

• plugins/win/PluginDatabaseWin.cpp: Added isPluginBlacklisted() and constants silverlightPluginMinRequiredVersionMSDWORD and silverlightPluginMinRequiredVersionLSDWORD. Their values are taken from the version info of Silverlight 1.0.20926.0, which is a version known not to exhibit this crash (WebCore::PluginDatabaseWin::isPluginBlacklisted): Determine whether this plugin is blacklisted
• plugins/win/PluginDatabaseWin.h:
• plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::PluginPackageWin): Initialize m_fileVersion* (WebCore::PluginPackageWin::getFileVersion): (WebCore::PluginPackageWin::storeFileVersion): Read version info for the plugin, and store the file version (WebCore::PluginPackageWin::fetchInfo): After determining the name, description, and file version, determine whether this plug-in is blacklisted. If so, return false so this plug-in isn't loaded
• plugins/win/PluginPackageWin.h:

3:59 PM Changeset in webkit [27130] by ggaren

• 1 edit
  1 add in trunk/JavaScriptCore

Build fix: svn add SymbolTable.h

• kjs/SymbolTable.h: Added. (KJS::SymbolTable::set): (KJS::SymbolTable::get):

3:54 PM Changeset in webkit [27129] by ggaren

• 2 edits in trunk/JavaScriptCore

Build fix: export SymbolTable.h to WebCore.

• JavaScriptCore.xcodeproj/project.pbxproj:

3:47 PM Changeset in webkit [27128] by ggaren

• 2 edits in trunk/JavaScriptCore

Comment tweak suggested by Maciej.

• kjs/function.cpp: (KJS::ActivationImp::getOwnPropertySlot):

3:45 PM Changeset in webkit [27127] by ggaren

• 3 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.

Tweaked property maps to remove 2 branches. 2.5% speedup on SunSpider.

• kjs/property_map.cpp: Use a special no branch accessor to the UString's hash value. Also, return immediately instead of branching to the end of the loop if the value is not found. (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::remove): (KJS::PropertyMap::checkConsistency):

• kjs/ustring.h: (KJS::UString::Rep::computedHash): Special no branch accessor to the UString's hash value. Used when the caller knows that the hash value has already been computed. (For example, if the caller got the UString from an Identifier.)

3:43 PM Changeset in webkit [27126] by ggaren

• 8 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.

Switched ActivationImp to using a symbol table. For now, though, all
clients take the slow path.

Net .6% speedup on SunSpider.

Slowdowns:

• ActivationImp now mallocs in its constructor
• Local variable hits use an extra level of indirection to retrieve data
• Local variable misses do two lookups

Speedups:

• Fast initialization of local variables upon function entry

• JavaScriptCore.xcodeproj/project.pbxproj: Added SymbolTable.h

• kjs/function.cpp: (KJS::ActivationImp::ActivationImp): Malloc a private structure to hold data that won't fit in a JSCell. (KJS::ActivationImp::argumentsGetter): Use slow symbol table path for lookup. (KJS::ActivationImp::getOwnPropertySlot): ditto (KJS::ActivationImp::deleteProperty): ditto (KJS::ActivationImp::put): ditto (KJS::ActivationImp::createArgumentsObject): ditto

(KJS::ActivationImp::mark): Call JSObject::mark first so that one of
our properties doesn't try to recursively mark us. (This caused a crash
in earlier testing. Not sure why we haven't run into it before.)

• kjs/nodes.cpp: Functions now build a symbol table the first time they're called. (KJS::VarDeclNode::evaluate): (KJS::FunctionBodyNode::FunctionBodyNode): (KJS::FunctionBodyNode::initializeSymbolTable): (KJS::FunctionBodyNode::processDeclarations): (KJS::FunctionBodyNode::processDeclarationsForFunctionCode): (KJS::FunctionBodyNode::processDeclarationsForProgramCode):

• kjs/nodes.h: (KJS::FunctionBodyNode::symbolTable):

• wtf/Forward.h: Added Vector.

2:44 PM Changeset in webkit [27125] by weinig

• 8 edits in trunk/WebCore

Reviewed by Adele Peterson.

Fix for <rdar://problem/5421754>
m_frameName member variable in HTMLPlugInElement unnecessary

• Refactor the willRemove() method down into HTMLFrameOwnerElement now that we no longer need to use the m_frameName variable.

• html/HTMLFrameElementBase.cpp:
• html/HTMLFrameElementBase.h:
• html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::willRemove):
• html/HTMLFrameOwnerElement.h:
• html/HTMLPlugInElement.cpp:
• html/HTMLPlugInElement.h:
• loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject):

2:28 PM Changeset in webkit [27124] by kmccullo

• 1 edit in trunk/JavaScriptCore/ChangeLog

• Corrected function name mistake in this changelog.

2:19 PM Changeset in webkit [27123] by kmccullo

• 6 edits
  2 adds in trunk

JavaScriptCore:

Reviewed by Sam and Steve.

• Added convenience methods for converting between BSTR and JSStringRefs

• API/JSStringRefCOM.cpp: Added. (JSStringCreateWithCFString): (JSStringCopyCFString):
• API/JSStringRefCOM.h: Added.
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

win:

Reviewed by Sam and Steve.

• Added convenience methods for converting between BSTR and JSSTringRefs
• Added WebKit_debug.def to the project.

• WebKit.vcproj/WebKit.def:
• WebKit.vcproj/WebKit.vcproj:
• WebKit.vcproj/WebKit_debug.def:

2:03 PM Changeset in webkit [27122] by adele

• 1 edit in trunk/WebCore/WebCore.base.exp

Reverting an unintentional added symbol

1:55 PM Changeset in webkit [27121] by adele

• 2 edits in trunk/WebCore

Export _wkDrawCapsLockIndicator.

• WebCore.base.exp:

1:28 PM Changeset in webkit [27120] by adele

• 2 edits in trunk/WebKitLibraries

Reviewed by Tim Hatcher.

Updating header too for WKDrawCapsLockIndicator.

• WebKitSystemInterface.h:

12:52 PM Changeset in webkit [27119] by adele

• 8 edits in trunk

WebCore:

Reviewed by Oliver.

Adding WebKitSystemInterface support for the caps lock indicator

• platform/mac/WebCoreSystemInterface.h:
• platform/mac/WebCoreSystemInterface.mm:

WebKit:

Reviewed by Oliver.

Adding WebKitSystemInterface support for the caps lock indicator

• WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

Reviewed by Oliver.

Adding wkDrawCapsLockIndicator in preparation for fixing the caps lock indicator.

• libWebKitSystemInterfaceLeopard.a:
• libWebKitSystemInterfaceTiger.a:

12:22 PM Changeset in webkit [27118] by tristan

• 3 edits
  2 adds in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/5555053> REGRESSION:9A581: Window disappears when opening ​http://research.microsoft.com/users/darkok/
The problem was caused by checkin r24654. This change moved explicit bounds checking into adjustWindowRect
but failed to account for bounds checking (instead replaced with bounds clipping). This caused issues
when NaN was used. This patch goes one step further and does NaN checking to prevent the possibility of
setting window bounds to NaN before an update occurs.

Test: fast/dom/Window/window-resize-nan.html

• bindings/js/kjs_window.cpp: (KJS::adjustWindowRect): Added a new parameter, pendingChanges, which takes pending changes to the window rect, and if they are valid (not NaN) sets them on window.

(KJS::WindowFunc::callAsFunction):
Adjusted uses of adjustWindowRect to take new update parameter.

LayoutTests:

Reviewed by Darin Adler.

Added new test cases to handle non-number input to window adjusting
functions like resizeTo, resizeBy, moveTo, and moveBy for
<rdar://problem/5555053>.

• fast/dom/Window/window-resize-nan-expected.txt: Added.
• fast/dom/Window/window-resize-nan.html: Added.

11:39 AM Changeset in webkit [27117] by weinig

• 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=15175
Cannot copy text of errors from Web Inspector from Console view

• page/inspector/inspector.css: add -webkit-user-select: text for console messages.

11:17 AM Changeset in webkit [27116] by weinig

• 4 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=15446
Web Inspector find window is not resizable

• Adds ability to resize the find window.
• Fixes bug that messed up the find window when resizing the left sidebar.

• page/inspector/inspector.css:
• page/inspector/inspector.html:
• page/inspector/inspector.js:

10:15 AM Changeset in webkit [27115] by sfalken

• 1 copy in tags/Safari-523.12.9b

New tag.

10:15 AM Changeset in webkit [27114] by sfalken

• 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

9:34 AM Changeset in webkit [27113] by adachan

• 2 edits in trunk/WebCore

Update m_current index after we've removed an item:

• if item removed is before m_current, decrement m_current
• if the current item is removed, make sure m_current is within bounds.

Reviewed by Darin.

• history/BackForwardList.cpp: (WebCore::BackForwardList::removeItem):

8:38 AM Changeset in webkit [27112] by ddkilzer

• 3 edits
  1 add in trunk/WebKitTools

prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
<​http://bugs.webkit.org/show_bug.cgi?id=15600>

Reviewed by Darin.

The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
a patch of the local changes and applying it with a fuzz level of 3 to the new file.
If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
file. Note that it may also be used as a stand-alone script.

• Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
• Scripts/resolve-ChangeLogs: Added.
• Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.

6:34 AM Changeset in webkit [27111] by mrowe@apple.com

• 1 edit in trunk/JavaScriptCore/kjs/collector.cpp

Restore the semicolon.

6:31 AM Changeset in webkit [27110] by mrowe@apple.com

• 2 edits in trunk/JavaScriptCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Windows build fix.

• kjs/collector.cpp: (KJS::Collector::collect):

5:22 AM Changeset in webkit [27109] by mrowe@apple.com

• 2 edits in trunk/WebKit/qt

2007-10-26 Mark Rowe <​mrowe@apple.com>

Build fix. Add missing #include of Platform.h.

• Api/qwebhistoryinterface.cpp:

5:07 AM Changeset in webkit [27108] by mrowe@apple.com

• 2 edits in trunk/WebCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Debug build fix.

• bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::~KJSProxy):

5:06 AM Changeset in webkit [27107] by oliver

• 6 edits in trunk/JavaScriptCore

Make the JSC GC use a separate heap for JSNumbers to get a 0.7-1.4% progression in SunSpider.

Reviewed by Maciej

• kjs/CollectorHeapIntrospector.cpp: (KJS::CollectorHeapIntrospector::init): (KJS::CollectorHeapIntrospector::enumerate):
• kjs/CollectorHeapIntrospector.h:
• kjs/collector.cpp: (KJS::Collector::recordExtraCost): (KJS::Collector::heapAllocate): (KJS::Collector::allocate): (KJS::Collector::allocateNumber): (KJS::Collector::registerThread): (KJS::Collector::markStackObjectsConservatively): (KJS::Collector::markMainThreadOnlyObjects): (KJS::Collector::sweep): (KJS::Collector::collect):
• kjs/collector.h:
• kjs/internal.h: (KJS::NumberImp::operator new): Force numbers to be allocated in the secondary heap.

4:53 AM Changeset in webkit [27106] by mjs

• 2 edits in trunk/WebCore

No review, build fix.

• bindings/objc/WebScriptObject.mm: (+[WebScriptObject throwException:]): (-[WebScriptObject setException:]):

4:50 AM Changeset in webkit [27105] by mjs

• 1 edit in trunk/WebCore/ChangeLog

Rubber Stamped by Mark.

• fix build

• bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame evaluateWebScript:]):

4:48 AM Changeset in webkit [27104] by mjs

• 2 edits in trunk/WebCore

Rubber Stamped by Oliver.

• fix build

• bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame evaluateWebScript:]):

4:46 AM Changeset in webkit [27103] by mjs

• 4 edits in trunk/JavaScriptCore

Reviewed by Oliver.

• encourage GCC a little harder to inline a few hot functions for 1.5% improvement on SunSpider.

• kjs/value.h: (KJS::JSValue::getUInt32): (KJS::JSValue::getTruncatedInt32): (KJS::JSValue::toNumber):
• wtf/PassRefPtr.h: (WTF::PassRefPtr::~PassRefPtr):
• wtf/RefPtr.h: (WTF::RefPtr::operator->):

3:45 AM Changeset in webkit [27102] by mrowe@apple.com

• 1 edit in trunk/JavaScriptCore/ChangeLog

Fix ChangeLog ordering.

3:44 AM Changeset in webkit [27101] by mrowe@apple.com

• 2 edits in trunk/JavaScriptCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

• kjs/ExecState.h:

3:36 AM Changeset in webkit [27100] by mjs

• 8 edits in trunk/JavaScriptCore

Windows build fix.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

2:38 AM Changeset in webkit [27099] by mrowe@apple.com

• 2 edits in trunk/JavaScriptCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Windows build fix.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

2:38 AM Changeset in webkit [27098] by mrowe@apple.com

• 3 edits in trunk/JavaScriptCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

• JavaScriptCore.pri:
• kjs/ExecState.cpp:

1:32 AM Changeset in webkit [27097] by mjs

• 17 edits
  1 add
  2 deletes in trunk

JavaScriptCore:

Reviewed by Oliver.

• moved Context class into ExecState.{h,cpp} in preparation for merging ExecState and Context classes.

• kjs/ExecState.h: Moved CodeType enum and Context class here in preparation for merging ExecState and Context.
• kjs/ExecState.cpp: Moved Context class here from Context.cpp. (KJS::Context::Context): (KJS::Context::~Context): (KJS::Context::mark):
• kjs/context.h: Removed.
• kjs/Context.cpp: Removed.
• kjs/function.h: Removed CodeType enum.
• kjs/LabelStack.h: Added. Pulled LabelStack class out of internal.h.
• kjs/internal.h: Removed LabelStack.
• JavaScriptCore.xcodeproj/project.pbxproj: Added new file, removed ones that are gone.
• kjs/collector.cpp: Fixed includes.
• kjs/function.cpp: ditto
• kjs/internal.cpp: ditto
• kjs/interpreter.cpp: ditto
• kjs/lookup.h: ditto
• kjs/nodes.cpp: ditto

WebCore:

Reviewed by Oliver.

• update for JavaScriptCore header changes

• bindings/objc/WebScriptObject.mm:
• bridge/mac/WebCoreScriptDebugger.mm:

1:13 AM Changeset in webkit [27096] by mrowe@apple.com

• 2 edits in trunk/JavaScriptCore

2007-10-26 Mark Rowe <​mrowe@apple.com>

Windows build fix.

• kjs/string_object.cpp: (KJS::StringObjectFuncImp::callAsFunction):

12:51 AM Changeset in webkit [27095] by darin

• 14 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

• ​http://bugs.webkit.org/show_bug.cgi?id=15703 fix numeric functions -- improve correctness and speed

Gives about 1% gain on SunSpider.

• kjs/value.h: Added toIntegerPreserveNan, removed toUInt16. (KJS::JSValue::toInt32): Changed to call getTruncatedInt32 in a way that works with both immediate and number values. (KJS::JSValue::toUInt32): Ditto.
• kjs/value.cpp: (KJS::JSValue::toInteger): Moved the logic from roundValue here, with a couple differences. One is that it now correctly returns 0 for NaN, and another is that there's no special case for 0 or infinity, since the general case already handles those correctly. (KJS::JSValue::toIntegerPreserveNaN): Added. Like toInteger, but without the check for NaN. (KJS::JSValue::toInt32SlowCase): Call toNumber instead of roundValue. The truncation done by the typecast already does the necessary truncation that roundValue was doing. (KJS::JSValue::toUInt32SlowCase): Ditto. (KJS::JSValue::toUInt16): Removed.

• kjs/internal.h: Removed roundValue.
• kjs/internal.cpp: Ditto.

• kjs/array_object.cpp: (KJS::ArrayProtoFunc::callAsFunction): Remove unneeded code to handle NaN in Array.slice; toInteger now never returns NaN as specified.

• kjs/date_object.cpp: (KJS::fillStructuresUsingTimeArgs): Replaced call to roundValue with a call to toNumber as specified. (KJS::DateProtoFunc::callAsFunction): In SetTime case, replaced call to roundValue with a call to toNumber and timeClip as specified. (KJS::DateObjectImp::construct): Removed unnecessary checks of numArgs in cases where the default behavior of toInt32 (returning 0) was already correct. Replaced call to roundValue with a call to toNumber as specified. (KJS::DateObjectFuncImp::callAsFunction): Ditto.

• kjs/math_object.cpp: (MathFuncImp::callAsFunction): Removed unnecessary special cases for the pow function that the library already handles correctly.

• kjs/number_object.cpp: (NumberProtoFunc::callAsFunction): Changed ToString to call toIntegerPreserveNaN, so we can continue to handle the NaN case differently. The real toInteger now returns 0 for NaN. Took out unneeded special case in ToFixed for undefined; was only needed because our toInteger was wrong. Same thing in ToExponential. Changed ToPrecision to call toIntegerPreserveNaN.

• kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction): Took out CharAt and CharCodeAt special cases for undefined that were only needed because toInteger was wrong. Same in IndexOf, and was able to remove some special cases. In LastIndexOf, used toIntegerPreserveNaN, but was able to remove some special cases there too. Changed Substr implementation to preserve correct behavior with the change to toInteger and match the specification. Also made sure we weren't converting an out of range double to an int. (KJS::StringObjectFuncImp::callAsFunction): Changed constructor to just use toUInt32, because truncating toUInt32 to 16 bits is the same thing and there's no reason to have toUInt16 as a second, less-optimized function that's only called at this one call site.

• wtf/MathExtras.h: Added trunc function for Windows.

LayoutTests:

Reviewed by Maciej.

• test changes for ​http://bugs.webkit.org/show_bug.cgi?id=15703 fix numeric functions -- improve correctness and speed

• fast/js/resources/char-at.js: Updated test to expect that we get the first character if we pass NaN to charAt and charCodeAt; it's what the specification asks for and matches other browsers too.
• fast/js/char-at-expected.txt: Updated.

Oct 25, 2007:

11:58 PM Changeset in webkit [27094] by mrowe@apple.com

• 2 edits in trunk/LayoutTests

2007-10-26 Mark Rowe <​mrowe@apple.com>

Update expected results.

• platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt:

11:55 PM Changeset in webkit [27093] by ggaren

• 3 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.

Tweaked the inner hashtable lookup loop to remove a branch in the "not
found" case. .5% speedup on SunSpider.

• JavaScriptCore.xcodeproj/project.pbxproj:
• wtf/HashTable.h: (WTF::::lookup):

11:55 PM Changeset in webkit [27092] by mrowe@apple.com

• 2 edits in trunk/WebKitTools

2007-10-26 Mark Rowe <​mrowe@apple.com>

Qt build fix. r27084 added a destructor implementation for LayoutTestController
to the Qt port on the assumption that it was an implementation of the cross-platform
LayoutTestController class. It is not, so it did not need to be changed.

• DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.

11:36 PM Changeset in webkit [27091] by mrowe@apple.com

• 2 edits in trunk/WebKitTools

2007-10-25 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

Fix builds with code coverage enabled.

• Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.

11:19 PM Changeset in webkit [27090] by darin

• 3 edits in trunk/WebKitTools

Reviewed by Mark Rowe.

• Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
• Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.

11:09 PM Changeset in webkit [27089] by mrowe@apple.com

• 2 moves in releases/Apple

Rename 10.4 and 10.5 release tags.

10:25 PM Changeset in webkit [27088] by mrowe@apple.com

• 4 copies
  2 adds in releases/Apple/Leopard

Release tags for Mac OS X 10.5.

10:01 PM Changeset in webkit [27087] by slewis

• 2 edits in trunk/WebKitTools

build Fix

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

9:10 PM JavaScript performance improvement ideas edited by oliver@apple.com

(diff)

9:06 PM JavaScript performance improvement ideas edited by mjs@apple.com

(diff)

8:58 PM Changeset in webkit [27086] by mjs

• 8 edits in trunk/JavaScriptCore

Reviewed by Oliver.

• fold together toPrimitive() and toNumber() conversions for 0.5% gain on SunSpider

• kjs/nodes.cpp: (KJS::SubNode::evaluate): Subtract directly, since toPrimitive() is not adding any value over toNumber() here. (KJS::valueForReadModifyAssignment): Ditto. (KJS::lessThan): Use new getPrimitiveNumber() method to avoid some virtual calls and branches. (KJS::lessThanEq): Ditto.
• JavaScriptCore.exp: Export new functions as needed.
• kjs/value.h: (KJS::JSValue::toPrimitive): Fixed formatting. (KJS::JSValue::getPrimitiveNumber): New method - this simultaneously converts to number and tells you whether a toPrimitive() conversion with a Number hint would have given a string.
• kjs/internal.cpp: (KJS::StringImp::getPrimitiveNumber): Implemented. (KJS::NumberImp::getPrimitiveNumber): ditto (KJS::GetterSetterImp::getPrimitiveNumber): ditto (KJS::StringImp::toPrimitive): Fixed formatting. (KJS::NumberImp::toPrimitive): ditto (KJS::GetterSetterImp::toPrimitive): ditto
• kjs/internal.h:
• kjs/object.cpp: (KJS::JSObject::getPrimitiveNumber): Implemented.
• kjs/object.h:

8:42 PM Changeset in webkit [27085] by slewis

• 2 edits in trunk/WebKitTools

Weak link against WebCore so DumpRenderTree can be bundled with production roots.

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

8:09 PM Changeset in webkit [27084] by aliceli1

• 7 edits in trunk/WebKitTools

Reviewed by Adam.

Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows

Moving destructor into platform-specific files

• DumpRenderTree/LayoutTestController.cpp:
• DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::~LayoutTestController):
• DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::~LayoutTestController):

LayoutTestController wasn't being destroyed

• DumpRenderTree/win/DumpRenderTree.cpp: (runTest):

Added declspec

• DumpRenderTree/win/EditingDelegate.h:

Reset certain values on the webview (or related delegate) that might
have changed while running a test

• DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::~LayoutTestController):

7:46 PM Changeset in webkit [27083] by alp

• 2 edits in trunk/WebCore

2007-10-26 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=15693
[GTK] Paging does not work when widget is added to a GtkScrolledWindow

Eliminate MagicGtkScrollConstant in favour of the same calculations as
GtkTextView for step and page increments. This also makes paging work,
as the page increment was previously always 0.

• platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::updateScrollbars):

6:44 PM Changeset in webkit [27082] by weinig

• 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj

Fix the windows build for real

6:11 PM Changeset in webkit [27081] by weinig

• 2 edits in trunk/WebKit/win

Reviewed by Adam Roben.

Make debug builds run again.

• WebView.cpp: (WebView::notifyPreferencesChanged):

6:09 PM Changeset in webkit [27080] by aroben

• 4 edits in trunk/WebKitLibraries

Add wkSetPatternBaseCTM.

Reviewed by NOBODY.

• win/include/WebKitSystemInterface/WebKitSystemInterface.h:
• win/lib/WebKitSystemInterface.lib:
• win/lib/WebKitSystemInterface_debug.lib:

6:09 PM Changeset in webkit [27079] by weinig

• 4 edits in trunk

JavaScriptCore:

Reviewed by Adam Roben.

Remove JSStringRefCFHack from windows as it is no longer needed.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

win:

Reviewed by Adam Roben.

Remove JSStringRefCFHack.

• WebKit.vcproj/WebKit.vcproj:

5:10 PM Changeset in webkit [27078] by weinig

• 10 edits
  2 adds in trunk/WebKit/win

Reviewed by Steve Falkenburg.

Fix for <rdar://problem/5463608>
Port WebKit cache model code (Windows needs a big disk cache, smarter memory cache)

• Interfaces/IWebPreferences.idl: Deprecate pageCacheSize and objectCacheSize and add cacheModel/setCacheModel.

• Interfaces/IWebPreferencesPrivate.idl: Add automaticallyDetectsCacheModel/setAutomaticallyDetectsCacheModel

• WebFrame.cpp: (WebFrame::didPerformFirstNavigation): Implement based on the mac version.

• WebKit.vcproj/WebKit.vcproj:
• WebKitSystemBits.cpp: Added. (WebMemorySize): Moved and renamed from WebPreferences.cpp (WebVolumeFreeSize): Added.
• WebKitSystemBits.h: Added.
• WebPreferenceKeysPrivate.h: Added WebKitCacheModelPreferenceKey.

• WebPreferences.cpp: (WebPreferences::sharedStandardPreferences): (WebPreferences::WebPreferences): (WebPreferences::initializeDefaultSettings): Added default for cacheModel. (WebPreferences::webPreferencesChangedNotification): (WebPreferences::webPreferencesRemovedNotification): (WebPreferences::initWithIdentifier): Post a preferences change notification. (WebPreferences::pageCacheSize): Deprecated. (WebPreferences::objectCacheSize): Deprecated. (WebPreferences::cacheModel): Added. (WebPreferences::setCacheModel): Added. (WebPreferences::setAutomaticallyDetectsCacheModel): Added. (WebPreferences::automaticallyDetectsCacheModel): Added. (WebPreferences::willAddToWebView): Added. (WebPreferences::didRemoveFromWebView): Added.
• WebPreferences.h:

• WebView.cpp: (PreferencesChangedOrRemovedObserver::PreferencesChangedOrRemovedObserver): (PreferencesChangedOrRemovedObserver::~PreferencesChangedOrRemovedObserver): (PreferencesChangedOrRemovedObserver::QueryInterface): (PreferencesChangedOrRemovedObserver::AddRef): (PreferencesChangedOrRemovedObserver::Release): (PreferencesChangedOrRemovedObserver::sharedInstance): (PreferencesChangedOrRemovedObserver::onNotify): (PreferencesChangedOrRemovedObserver::notifyPreferencesChanged): (PreferencesChangedOrRemovedObserver::notifyPreferencesRemoved): This singleton class updates static properties for all webviews when preferenceChange or preferenceRemoved notifications are fired for any WebPreference. (WebView::WebView): (WebView::~WebView): (initializeStaticObservers): (allWebViewsSet): (WebView::addToAllWebViewsSet): (WebView::removeFromAllWebViewsSet): (WebView::setCacheModel): (WebView::cacheModel): (WebView::didSetCacheModel): (WebView::maxCacheModelInAnyInstance): (WebView::close): (WebViewWndProc): (WebView::developerExtrasEnabled): (WebView::initWithFrame): (WebView::setPreferences): (WebView::preferences): (WebView::onNotify): (WebView::notifyPreferencesChanged): (updateSharedSettingsFromPreferencesIfNeeded):
• WebView.h: Match the macs behavior by using explicit postings of notifications to update the preferences.

4:38 PM Changeset in webkit [27077] by aroben

• 2 edits in trunk/WebKitTools

Make sunspider-compare-results work with relative paths

Reviewed by Sam.

• Scripts/sunspider-compare-results: Convert arguments to absolute paths before we chdir.

4:33 PM Changeset in webkit [27076] by hyatt

• 1 edit in trunk/WebCore/platform/graphics/cg/ImageCG.cpp

Fix unbalanced save/restore on Leopard only.

4:23 PM Changeset in webkit [27075] by aroben

• 2 edits in trunk/SunSpider

Strip carriage returns from results

Carriage returns were screwing up sunspider-compare-results on
Windows.

Rubberstamped by Oliver.

• sunspider:

4:17 PM Changeset in webkit [27074] by mitz

• 2 edits in trunk/WebCore

Reviewed by Dave Hyatt and Sam Weinig.

Build fix

• platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):

4:16 PM Changeset in webkit [27073] by weinig

• 3 edits in trunk/WebKitLibraries

Fix the windows build.

• win/lib/WebKitSystemInterface.lib:
• win/lib/WebKitSystemInterface_debug.lib:

3:29 PM Changeset in webkit [27072] by ggaren

• 5 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.

Rolled out my last patch. It turns out that I needed 2 words, not 1,
so it didn't help.

3:23 PM Changeset in webkit [27071] by thatcher

• 4 edits in trunk/WebKitLibraries

Add WKSetPatternBaseCTM.

• WebKitSystemInterface.h:
• libWebKitSystemInterfaceLeopard.a:
• libWebKitSystemInterfaceTiger.a:

3:13 PM Changeset in webkit [27070] by thatcher

• 1 delete in trunk/WebKitQt

Remove the empty WebKitQt folders.

2:56 PM Changeset in webkit [27069] by alp

• 2 edits in trunk/WebCore

2007-10-23 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Reviewed by Alp.

​http://bugs.webkit.org/show_bug.cgi?id=15656
[GTK] Implement WebCore::Widget::isEnabled/setEnabled

• platform/gtk/WidgetGtk.cpp: (WebCore::Widget::isEnabled): (WebCore::Widget::setEnabled): Implemented.

2:37 PM Changeset in webkit [27068] by ggaren

• 5 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=15694
Shrink the size of an activation object by 1 word

This is in preparation for adding a symbol table to the activation
object.

The basic strategy here is to rely on the mutual exclusion between
the arguments object pointer and the function pointer (you only need
the latter in order to create the former), and store them in the same
place. The LazyArgumentsObject class encapsulates this strategy.

Also inlined the ArgumentsImp constructor, for good measure.

SunSpider reports no regression. Regression tests pass.

• JavaScriptCore.xcodeproj/project.pbxproj:
• kjs/Context.cpp: (KJS::Context::~Context):
• kjs/function.cpp: (KJS::ActivationImp::LazyArgumentsObject::createArgumentsObject): (KJS::ActivationImp::LazyArgumentsObject::mark): (KJS::): (KJS::ActivationImp::argumentsGetter): (KJS::ActivationImp::mark):
• kjs/function.h: (KJS::ActivationImp::LazyArgumentsObject::LazyArgumentsObject): (KJS::ActivationImp::LazyArgumentsObject::getOrCreate): (KJS::ActivationImp::LazyArgumentsObject::resetArguments): (KJS::ActivationImp::LazyArgumentsObject::setArgumentsObject): (KJS::ActivationImp::LazyArgumentsObject::argumentsObject): (KJS::ActivationImp::LazyArgumentsObject::setFunction): (KJS::ActivationImp::LazyArgumentsObject::function): (KJS::ActivationImp::LazyArgumentsObject::createdArgumentsObject): (KJS::ActivationImp::LazyArgumentsObject::): (KJS::ActivationImp::ActivationImp::ActivationImp): (KJS::ActivationImp::resetArguments):

2:32 PM Changeset in webkit [27067] by beidson

• 1 edit in trunk/WebCore/ChangeLog

Weinig also reviewed this patch, and wanted Changelog credit for it

2:26 PM Changeset in webkit [27066] by kmccullo

• 4 edits in trunk/WebKitTools

Reviewed by Sam.

• Implemented server calls now the WebScriptDebugServer exists.
• Also removed no longer needed call to initialize CG.

• Drosera/win/Drosera.cpp: No longer initializes CG because this happens automatically now. (_tWinMain):
• Drosera/win/ServerConnection.cpp: Now uses the COM class. (ServerConnection::ServerConnection): (ServerConnection::~ServerConnection): (ServerConnection::pause): (ServerConnection::resume): (ServerConnection::stepInto): (ServerConnection::applicationTerminating): (ServerConnection::serverConnectionDidDie):
• Drosera/win/ServerConnection.h: Now uses the COM class.

2:12 PM Changeset in webkit [27065] by hyatt

• 3 adds in trunk/LayoutTests/platform/mac/fast/borders

Add border image transforms test.

2:11 PM Changeset in webkit [27064] by hyatt

• 1 add in trunk/LayoutTests/fast/borders/border-image-scale-transform.html

Add border image transforms test.

2:09 PM Changeset in webkit [27063] by hyatt

• 3 adds in trunk/LayoutTests/platform/mac/fast/backgrounds/repeat

Add background transform test.

2:08 PM Changeset in webkit [27062] by hyatt

• 1 add in trunk/LayoutTests/fast/backgrounds/repeat/negative-offset-repeat-transformed.html

Add background transform test.

2:03 PM Changeset in webkit [27061] by aroben

• 9 edits
  1 delete in trunk

Fix some JavaScriptCore build issues

JavaScriptCore:

Change JavaScriptCore.vcproj to use DerivedSources.make

We were trying to emulate the logic of make in
build-generated-files.sh, but we got it wrong. We now use a
build-generated-files very much like the one that WebCore uses to
invoke make.

We also now only have a Debug configuration of dftables which we build
even when doing a Release build of JavaScriptCore. dftables also no
longer has the "_debug" name suffix.

Changes mostly made by Darin, reviewed by me.

• DerivedSources.make: Add a variable to set the extension used for the dftables executable.
• JavaScriptCore.vcproj/JavaScriptCore.sln: Updated to use Debug dftables in Release configurations.
• JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Ditto.
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • Updated include path to point to the new location of the derived sources.
  • Modified pre-build event to pass the right arguments to build-generated-files.sh and not call dftables directly.
  • Added the derived source files to the project.
  • Removed grammarWrapper.cpp, which isn't needed now that we're compiling grammar.cpp directly.
• JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Slightly modified from the WebCore version.
• JavaScriptCore.vcproj/JavaScriptCore/grammarWrapper.cpp: Removed.
• JavaScriptCore.vcproj/dftables/dftables.vcproj:
  • Changed the output location to match Mac.
  • Removed the Release configuration.
  • Removed the _debug suffix.

win:

Update WebKit.sln for the removal of Release dftables

Reviewed by NOBODY.

• WebKit.vcproj/WebKit.sln:

2:03 PM Changeset in webkit [27060] by hyatt

• 9 edits in trunk

WebCore:

Fix for bug 15672, background images don't tile properly inside transforms. This patch fixes background
tiling to work in the presence of transforms and fixes bugs in both SVG and CSS transforms.

Reviewed by aroben and mitz

• WebCore.base.exp:
• platform/graphics/Image.cpp: (WebCore::Image::setData):
• platform/graphics/cg/ImageCG.cpp: (WebCore::ImageInfo::ImageInfo): (WebCore::Image::drawPatternCallback): (WebCore::Image::drawPattern):
• platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
• platform/mac/WebCoreSystemInterface.h:
• platform/mac/WebCoreSystemInterface.mm:

WebKit:

Fix for bug 15672, backgrounds don't tile properly inside transforms. This patch fixes tiling
of backgrounds inside CSS transforms and also of HTML content with background images inside SVG
transforms.

Reviewed by aroben and mmitz

• WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
• WebKit.xcodeproj/project.pbxproj:

1:46 PM Changeset in webkit [27059] by sullivan

• 5 edits in trunk/WebKit

Reviewed by Tim Hatcher

Removed the support for toggling whether WebKit uses the 10.5 PDFKit improvements. Now it
always does, when available.

• WebView/WebPreferencesPrivate.h: removed _usePDFPreviewView and _setUsePDFPreviewView:. Note that these were guarded with a comment that says that they can be removed when no longer needed. That time is now.

• WebView/WebPreferences.m: (+[WebPreferences initialize]): removed WebKitUsePDFPreviewViewPreferenceKey (-[WebPreferences _usePDFPreviewView]): removed (-[WebPreferences _setUsePDFPreviewView:]): removed

• WebView/WebPDFView.mm: (-[WebPDFView initWithFrame:]): don't check _usePDFPreviewView

• WebView/WebPreferenceKeysPrivate.h: removed WebKitUsePDFPreviewViewPreferenceKey

1:37 PM Changeset in webkit [27058] by kmccullo

• 4 edits in trunk/WebKit/win

Rubber stamped by Geoff.

• Stubbed out the WebScriptDebugServer methods to give Drosera something to connect to and now the signature of the interface matches the mac.

• Interfaces/IWebScriptDebugServer.idl:
• WebScriptDebugServer.cpp: (WebScriptDebugServer::addListener): (WebScriptDebugServer::removeListener): (WebScriptDebugServer::step): (WebScriptDebugServer::pause): (WebScriptDebugServer::resume): (WebScriptDebugServer::isPaused):
• WebScriptDebugServer.h:

1:17 PM Changeset in webkit [27057] by thatcher

• 2 edits in trunk/WebKitLibraries

Reviewed by Adam.

Update the Leopard WebKitSystemInterface to be 4-way univeral to include 64-bit.

• libWebKitSystemInterfaceLeopard.a:

12:37 PM Changeset in webkit [27056] by beidson

• 2 edits in trunk/WebCore

Blind build fix attempt

• WebCore.pro:

12:26 PM Changeset in webkit [27055] by weinig

• 4 edits in trunk/WebKitLibraries

Added wrapper for getting the foundation cache directory.

Reviewed by Adam Roben.

• win/include/WebKitSystemInterface/WebKitSystemInterface.h:
• win/lib/WebKitSystemInterface.lib:
• win/lib/WebKitSystemInterface_debug.lib:

12:26 PM Changeset in webkit [27054] by beidson

• 11 edits
  8 moves in trunk/WebCore

Reviewed by Anders

Bulk rename of platform/sql/SQL* to platform/sql/SQLite*

This is more accurate in that there is no realistic "SQL" abstraction, the classes are obviously
tied extremely close to SQLite, and is necessitated by the introduction of "SQLTransaction" in
the HTML5 database API which we are adopting.

11:47 AM Changeset in webkit [27053] by kmccullo

• 9 edits
  3 moves in trunk/WebKit/win

Reviewed by Darin.

• Renamed WebDebugProgram to WebScriptDebugServer to match the naming scheme on the mac.

• Interfaces/IWebDebugProgram.idl: Removed.
• Interfaces/IWebScriptDebugServer.idl: Copied from win/Interfaces/IWebDebugProgram.idl.
• Interfaces/WebKit.idl:
• WebDebugProgram.cpp: Removed.
• WebDebugProgram.h: Removed.
• WebKit.vcproj/Interfaces.vcproj:
• WebKit.vcproj/WebKit.vcproj:
• WebKit.vcproj/WebKitGUID.vcproj:
• WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance):
• WebKitDLL.cpp: (RunAsLocalServer):
• WebScriptDebugServer.cpp: Copied from win/WebDebugProgram.cpp. (WebScriptDebugServer::WebScriptDebugServer): (WebScriptDebugServer::~WebScriptDebugServer): (WebScriptDebugServer::createInstance): (WebScriptDebugServer::QueryInterface): (WebScriptDebugServer::AddRef): (WebScriptDebugServer::Release): (WebScriptDebugServer::viewAdded): (WebScriptDebugServer::viewRemoved): (WebScriptDebugServer::attach): (WebScriptDebugServer::detach): (WebScriptDebugServer::statistics): (WebScriptDebugServer::webViews):
• WebScriptDebugServer.h: Copied from win/WebDebugProgram.h.
• WebView.cpp: (WebView::WebView): (WebView::~WebView):

11:31 AM Changeset in webkit [27052] by ap

• 4 edits
  4 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15650
XML attribute nodes are not importable

Tests: fast/dom/import-attribute-node.html

fast/dom/import-document-fragment.html

• dom/Document.cpp: (WebCore::Document::importNode): Implemented for Attribute and DocumentFragment nodes.

11:23 AM Changeset in webkit [27051] by mitz

• 3 edits
  4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=15362 <rdar://problem/5558715> Safari Crashes when opening a JS TreeGrid widget

Test: fast/dynamic/insert-before-table-part-in-continuation.html

• rendering/RenderFlow.cpp: (WebCore::RenderFlow::addChildWithContinuation): If beforeChild's parent is an anonymous table part, let the table figure out where to insert the new child.

LayoutTests:

Reviewed by Dave Hyatt.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=15362 <rdar://problem/5558715> Safari Crashes when opening a JS TreeGrid widget

• fast/dynamic/insert-before-table-part-in-continuation.html: Added.
• platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.checksum: Added.
• platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Added.
• platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Added.

11:21 AM Changeset in webkit [27050] by alp

• 4 edits in trunk

2007-10-25 Alp Toker <​alp@atoker.com>

Reviewed by Brady.

​http://bugs.webkit.org/show_bug.cgi?id=15686
GtkLauncher aborts on launch due to uninitialized threading subsystem

Re-enable database support in the GTK+ port, with a fix.

Initialize GLib threading as early as possible.

10:51 AM Changeset in webkit [27049] by sfalken

• 5 edits in branches/Safari-3-branch/WebCore

Merged fix from r27048.

10:35 AM Changeset in webkit [27048] by honeycutt

• 5 edits in trunk/WebCore

2007-10-25 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Steve.

<rdar://5548217>: [NTS] Java 6 update 3 crashes Safari when loading a
java page

Previous patch erroneously compared a path and a
path-including-filename. This corrects that. It also caches the result
of safariPluginsPath() and uses shell API funcs for determining filename
and parent directory from a full path.

• ChangeLog:
• plugins/win/PluginDatabaseWin.cpp: (WebCore::safariPluginsPath): Cache return value. Use API functions to build the path (WebCore::PluginDatabaseWin::pluginForMIMEType): Compare again plugin's parent directory, not full path (WebCore::PluginDatabaseWin::pluginForExtension): Same
• plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::PluginPackageWin): Store parent directory
• plugins/win/PluginPackageWin.h: (WebCore::PluginPackageWin::parentDirectory):
• plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didReceiveData):

8:00 AM Changeset in webkit [27047] by alp

• 4 edits in trunk

2007-10-25 Alp Toker <​alp@atoker.com>

Unreviewed fix to make the GTK+ port run.

​http://bugs.webkit.org/show_bug.cgi?id=15686
GtkLauncher aborts on launch due to uninitialized threading subsystem

​http://bugs.webkit.org/show_bug.cgi?id=15688
[GTK] Make it possible to disable database support

Disable database support until #15686 is fixed.

6:44 AM Changeset in webkit [27046] by hausmann

• 2 edits in trunk/WebCore

Fixed a crash in the Qt 4.4 based text iterators when they're called with a null string.

6:41 AM Changeset in webkit [27045] by hausmann

• 7 edits in trunk

• We need to set a != 0 status code for the fast/loader/xmlhttprequest-missing-file-exception.html
• libxml2 has the semantic that when writing an empty string and finishing it will report an error. For QXmlStreamReader this is valid.
• This is causing some regressions...

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:41 AM Changeset in webkit [27044] by hausmann

• 4 edits
  1 delete in trunk

• Make fast/loader/xmlhttprequest-bad-mimetype.html pass. We use QHttp to download local files but we may not set the HTTP result code on the ResourceResponse.
• We can use the cross-platform result now. QWebNetworkInterface/Manager behaves the same as mac for local files.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:41 AM Changeset in webkit [27043] by hausmann

• 6 edits in trunk

• fast/dom/onerror-img.html regressed due checking the JobStates because in case of error (e.g. not being able to connect) the job will no be started.
• Use the error message from Qt. It might or might not be translated.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:41 AM Changeset in webkit [27042] by hausmann

• 2 edits in trunk/WebKit/qt

• Use the JobStatus to make sure to not deliver finished/data before the job has started. This is the case with the fast/dom/onerror-img.html test case.
• We have no idea if any data will come so we can still finish and then get pending data. This luckily can't happen for the local file case.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:41 AM Changeset in webkit [27041] by hausmann

• 4 edits in trunk/WebKit/qt

• No need to initialize values in the QWebNetworkJob c'tor
• Add a JobStatus to QWebNetworkJob and verify that the jobs are handled in the way we expect them to be handled. This means no data after the job has finished, not finishing a job before it has been started.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:41 AM Changeset in webkit [27040] by hausmann

• 2 edits in trunk/WebKit/qt

• Consistency: Always name the jobs job.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:40 AM Changeset in webkit [27039] by hausmann

• 8 edits in trunk

• Implement our own queuing of network jobs to allow special handling of synchronous jobs. This makes us pass the fast/dom/xmlhttprequest-html-response-encoding.html test without a crash. Sync jobs will get a special treatment over the normals ones and in theory more than one sync job is supported.
• This should be thread-safe besides QWebNetworkJob::{ref,deref}

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

6:40 AM Changeset in webkit [27038] by hausmann

• 4 edits in trunk

• Do the percent replacement only when we are not base64. With base64 we should not have any % in it anyway.
• Have a custom decodePercentEncoding method that works without doing any charset conversion. With converting back to latin1() we lost some information.
• We pass the char-decoding.html test now

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

5:36 AM Changeset in webkit [27037] by alp

• 3 edits in trunk/WebCore

2007-10-25 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Add support for list box theme colors and styled menu list buttons.

Remove obsolete FIXMEs.

• platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): (WebCore::RenderThemeGtk::paintCheckbox): (WebCore::RenderThemeGtk::paintRadio): (WebCore::RenderThemeGtk::paintButton): (WebCore::RenderThemeGtk::adjustMenuListStyle): (WebCore::RenderThemeGtk::paintMenuList): (WebCore::RenderThemeGtk::activeListBoxSelectionBackgroundColor): (WebCore::RenderThemeGtk::inactiveListBoxSelectionBackgroundColor): (WebCore::RenderThemeGtk::activeListBoxSelectionForegroundColor): (WebCore::RenderThemeGtk::inactiveListBoxSelectionForegroundColor): (WebCore::RenderThemeGtk::gtkTreeView):
• platform/gtk/RenderThemeGtk.h:

4:55 AM Changeset in webkit [27036] by ap

• 1 edit in trunk/WebKitSite/ChangeLog

Corrected ChangeLog entry.

4:53 AM Changeset in webkit [27035] by ap

• 2 edits in trunk/WebKitSite

Rubber-stamped by Mark Rowe.

• images/download.png: Updated to say "Nightly builds" instead of

"Nightly (6 MB)" - the Mac version is ~17 MB now, and this isn't a direct
download link anyway.

4:36 AM Changeset in webkit [27034] by mrowe@apple.com

• 2 edits in trunk/JavaScriptCore

Roll out r27033 as it broke the JavaScriptCore tests.

2:59 AM Changeset in webkit [27033] by eseidel

• 2 edits in trunk/JavaScriptCore

HackTop [30311:JavaScriptCore]% less ChangeLog Stuff/Projects/WebKit/JavaScriptCore
2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Roben.

Start work on long-running-mode from the perl-script side of things.
jsDriver.pl will likely be removed (and replaced by something better)
But for now, I'm just hacking it down to something smaller.

• tests/mozilla/jsDriver.pl: Remove lots of unused code.

2:25 AM Changeset in webkit [27032] by ggaren

• 2 edits in trunk/JavaScriptCore

Reviewed by Eric Seidel.

Slightly elaborated the differences between declaration procesing in
Function Code and Program Code.

.3% speedup on SunSpider.

• kjs/nodes.cpp: (KJS::FunctionBodyNode::processDeclarationsFunctionCode): (KJS::FunctionBodyNode::processDeclarationsProgramCode): Store a minimum set of attributes instead of recomputing all the time. Also, ignore m_parameters, since programs don't have arguments.

2:08 AM Changeset in webkit [27031] by eseidel

• 3 edits in trunk/JavaScriptCore

2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.

More preparation work before adding long-running mode to testkjs.

• kjs/testkjs.cpp: (TestFunctionImp::callAsFunction): (prettyPrintScript): (runWithScripts): (parseArguments): (kjsmain): (fillBufferWithContentsOfFile):

1:53 AM Changeset in webkit [27030] by aroben

• 1 add in trunk/WebKit/win/Interfaces/IWebTextRenderer.idl

Forgot to check in this file in r27019

1:37 AM Changeset in webkit [27029] by eseidel

• 2 edits in trunk/JavaScriptCore

2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.

Bring testkjs code out of the dark ages in preparation for more
radical improvements (like long-running testing support!)

• kjs/testkjs.cpp: (TestFunctionImp::callAsFunction): (setupInterpreter): (doIt): (fillBufferWithContentsOfFile):

1:11 AM Changeset in webkit [27028] by ggaren

• 4 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.

Make a fast path for declaration processing inside Function Code.

Lifted declaration processing code up from individual declaration nodes
and into processDeclarations.

Broke out processDeclarations into two cases, depending on the type of
code. This eliminates 2 branches, and facilitates more radical
divergeance in the future.

2.5% SunSpider speedup.

• JavaScriptCore.xcodeproj/project.pbxproj:
• kjs/nodes.cpp: (KJS::FunctionBodyNode::initializeDeclarationStacks): (KJS::FunctionBodyNode::processDeclarationsFunctionCode): (KJS::FunctionBodyNode::processDeclarationsProgramCode): (KJS::FunctionBodyNode::execute): (KJS::FuncDeclNode::makeFunction):
• kjs/nodes.h: (KJS::):

12:26 AM JavaScript performance improvement ideas edited by eric@webkit.org

(diff)

12:16 AM Changeset in webkit [27027] by mjs

• 8 edits in trunk/JavaScriptCore

Reviewed by Adam.

• add header includes needed on platforms that don't use AllInOneFile.cpp

• API/JSCallbackObject.cpp:
• kjs/Context.cpp:
• kjs/ExecState.cpp:
• kjs/array_instance.cpp:
• kjs/function_object.cpp:
• kjs/interpreter.cpp:
• kjs/nodes.cpp:

12:14 AM Changeset in webkit [27026] by eseidel

• 2 edits in trunk/JavaScriptCore

2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Geoff.

• JavaScriptCore.xcodeproj/project.pbxproj: re-mark JSGlobalObject.h as private

12:09 AM Changeset in webkit [27025] by ggaren

• 6 edits
  4 adds in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=15683
Re-order declaration initialization to avoid calling hasProperty inside
VarDeclNode::processDeclaration

.7% speedup on SunSpider.

• kjs/function.h:
• kjs/function.cpp: Merged parameter processing into FunctionBodyNode's other processing of declared symbols, so the order of execution could change.

• kjs/nodes.cpp: (KJS::VarDeclNode::getDeclarations): Added special case for the "arguments" property name, explained in the comment.

(KJS::VarDeclNode::processDeclaration): Removed call to hasProperty
in the case of function code, since we know the declared symbol
management will resolve conflicts between symbols. Yay!

(KJS::VarDeclListNode::getDeclarations): Now that VarDeclNode's
implementation of getDeclarations is non-trivial, we can't take a
short-cut here any longer -- we need to put the VarDecl node on the
stack so it gets processed normally.

(KJS::FunctionBodyNode::processDeclarations): Changed the order of
processing to enforce mutual exclusion rules.

• kjs/nodes.h: (KJS::DeclarationStacks::DeclarationStacks): Structure includes an ExecState now, for fast access to the "arguments" property name.

LayoutTests:

Layout tests for bugs that might result from changes like
​http://bugs.webkit.org/show_bug.cgi?id=15683

• fast/js/vardecl-preserve-parameters-expected.txt: Added.
• fast/js/vardecl-preserve-parameters.html: Added.
• fast/js/vardecl-preserve-vardecl-expected.txt: Added.
• fast/js/vardecl-preserve-vardecl.html: Added.

12:08 AM Changeset in webkit [27024] by eseidel

• 2 edits in trunk/WebCore

2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Geoff.

• bindings/js/kjs_window.h: fix bogus comment, s/DOMNode/DOMObject/

12:07 AM Changeset in webkit [27023] by eseidel

• 4 edits in trunk/JavaScriptGlue

2007-10-25 Eric Seidel <​eric@webkit.org>

Reviewed by Geoff.

Make JSG build again after JSGlobalObject change.

• JSRun.cpp: (JSRun::JSRun): (JSRun::GlobalObject):
• JSRun.h: (JSInterpreter::JSInterpreter):
• JSUtils.h:

Oct 24, 2007:

11:38 PM Changeset in webkit [27022] by eseidel

• 31 edits
  1 copy
  1 add in trunk

2007-10-24 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.

Add a JSGlobalObject class and remove the InterpreterMap
​http://bugs.webkit.org/show_bug.cgi?id=15681

This required making JSCallbackObject a template class to allow for
JSGlobalObjects with JSCallbackObject functionality.

SunSpider claims this was a 0.5% speedup.

• API/JSCallbackObject.cpp: (KJS::):
• API/JSCallbackObject.h:
• API/JSCallbackObjectFunctions.h: Copied from API/JSCallbackObject.cpp. (KJS::::JSCallbackObject): (KJS::::init): (KJS::::~JSCallbackObject): (KJS::::initializeIfNeeded): (KJS::::className): (KJS::::getOwnPropertySlot): (KJS::::put): (KJS::::deleteProperty): (KJS::::implementsConstruct): (KJS::::construct): (KJS::::implementsHasInstance): (KJS::::hasInstance): (KJS::::implementsCall): (KJS::::callAsFunction): (KJS::::getPropertyNames): (KJS::::toNumber): (KJS::::toString): (KJS::::setPrivate): (KJS::::getPrivate): (KJS::::inherits): (KJS::::cachedValueGetter): (KJS::::staticValueGetter): (KJS::::staticFunctionGetter): (KJS::::callbackGetter):
• API/JSClassRef.cpp: (OpaqueJSClass::prototype):
• API/JSContextRef.cpp: (JSGlobalContextCreate):
• API/JSObjectRef.cpp: (JSObjectMake): (JSObjectGetPrivate): (JSObjectSetPrivate):
• API/JSValueRef.cpp: (JSValueIsObjectOfClass):
• JavaScriptCore.exp:
• JavaScriptCore.xcodeproj/project.pbxproj:
• bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant):
• bindings/jni/jni_jsobject.cpp:
• bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue):
• kjs/Context.cpp: (KJS::Context::Context):
• kjs/ExecState.cpp: (KJS::ExecState::lexicalInterpreter):
• kjs/JSGlobalObject.h: Added. (KJS::JSGlobalObject::JSGlobalObject): (KJS::JSGlobalObject::isGlobalObject): (KJS::JSGlobalObject::interpreter): (KJS::JSGlobalObject::setInterpreter):
• kjs/array_instance.cpp:
• kjs/context.h:
• kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::GlobalFuncImp::callAsFunction):
• kjs/interpreter.cpp: (KJS::Interpreter::Interpreter): (KJS::Interpreter::init): (KJS::Interpreter::~Interpreter): (KJS::Interpreter::globalObject): (KJS::Interpreter::initGlobalObject): (KJS::Interpreter::evaluate):
• kjs/interpreter.h:
• kjs/lookup.h: (KJS::cacheGlobalObject):
• kjs/object.h: (KJS::JSObject::isGlobalObject):
• kjs/testkjs.cpp:

11:26 PM JavaScript performance improvement ideas edited by eric@webkit.org

(diff)

10:38 PM JavaScript performance improvement ideas edited by eric@webkit.org

(diff)

10:33 PM Changeset in webkit [27021] by staikos

• 2 edits in trunk/WebKitTools

unbreak Qt build

10:23 PM Changeset in webkit [27020] by aroben

• 7 edits
  2 adds in trunk

Fix <rdar://5549919> Add font database initialization code to WebCore and call it from WebKit

WebCore:

Add font database initialization code to WebCore

Reviewed by Ada.

• WebCore.vcproj/WebCore.vcproj: Added FontDatabase.{cpp,h}.
• platform/win/FontDatabase.cpp: Added. (WebCore::systemFontsDirectory): (WebCore::fontsPlistPath): (WebCore::systemHasFontsNewerThanFontsPlist): (WebCore::readFontPlist): (WebCore::populateFontDatabaseFromPlist): (WebCore::populateFontDatabaseFromFileSystem): (WebCore::writeFontDatabaseToPlist): (WebCore::populateFontDatabase): This is the only function callable from outside this file. It populates the font database once, either from the fonts plist, or from the filesystem (and then saves a new fonts plist).
• platform/win/FontDatabase.h: Added.

WebKitTools:

Remove now-unnecessary call to InitializeCoreGraphics

WebKit takes care of this now.

Reviewed by Ada.

• DumpRenderTree/win/DumpRenderTree.cpp: (initialize):

WebKit/win:

Fix <rdar://5549919> Initialize the font database before any font code is invoked

We initialize the database in two places:

1. When instantiating WebKitClassFactory, which is guaranteed to happen before any WebView is instantiated.
2. When making a WebCore::Font in WebKitGraphics.

This ensures that the font database will be populated before any font
code is invoked. We rely on WebCore to only populate the database
once.

Reviewed by Ada.

• WebKitClassFactory.cpp: (WebKitClassFactory::WebKitClassFactory): Populate the font database.
• WebKitGraphics.cpp: (makeFont): Ditto.

10:22 PM Changeset in webkit [27019] by aroben

• 9 edits
  2 copies in trunk

Add [I]WebTextRenderer

WebKitTools:

Use WebTextRenderer in DRT

Reviewed by Ada.

• DumpRenderTree/win/DumpRenderTree.cpp: (initialize): Use WebTextRenderer instead of using InitializeCoreGraphics/AddFontResourceEx.

WebKit/win:

Add [I]WebTextRenderer

Right now this class can only be used to add private fonts for use by
the running process, but will eventually be the home of the
WebKitGraphics functions.

Reviewed by Ada.

• ForEachCoClass.h: Added WebTextRenderer.
• Interfaces/WebKit.idl: Ditto.
• WebKit.vcproj/Interfaces.vcproj: Ditto.
• WebKit.vcproj/WebKit.vcproj: Ditto.
• WebKit.vcproj/WebKitGUID.vcproj: Ditto.
• WebKitClassFactory.cpp: Ditto.
• WebTextRenderer.cpp: Added. (WebTextRenderer::createInstance): (WebTextRenderer::WebTextRenderer): (WebTextRenderer::~WebTextRenderer): (WebTextRenderer::QueryInterface): (WebTextRenderer::AddRef): (WebTextRenderer::Release): (WebTextRenderer::registerPrivateFont):
• WebTextRenderer.h: Added.

10:22 PM Changeset in webkit [27018] by aroben

• 4 edits in trunk/WebKit/win

Use FOR_EACH_COCLASS in WebKitClassFactory

Reviewed by Ada.

• WebError.cpp: (WebError::createInstance): Added an overload that takes no arguments to make the macro used in WebKitClassFactory work.
• WebError.h:
• WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance): Use FOR_EACH_COCLASS.

10:22 PM Changeset in webkit [27017] by aroben

• 3 edits
  1 add in trunk/WebKit/win

Put FOR_EACH_COCLASS macro into its own file and export it

The macro used to be called FOR_EACH_CLASS and lived in WebKitDLL.cpp.
This way we will be able to use the macro in more places that care
about all WebKit's COM classes.

Reviewed by Ada.

• ForEachCoClass.h: Added.
• WebKit.vcproj/WebKit.vcproj: Copy ForEachCoClass.h to WebKitOutputDir, and added it to the project.
• WebKitDLL.cpp: Updated for macro rename, and changed to #undef the macros we pass to FOR_EACH_COCLASS after we're done with them.

10:20 PM Changeset in webkit [27016] by aroben

• 4 edits in trunk/WebKitLibraries

Added some font-related functions needed for <rdar://5549919>

Reviewed by Ada.

• win/include/WebKitSystemInterface/WebKitSystemInterface.h:
• win/lib/WebKitSystemInterface.lib:
• win/lib/WebKitSystemInterface_debug.lib:

10:01 PM Changeset in webkit [27015] by mrowe@apple.com

• 3 edits in trunk/WebKitTools

2007-10-24 Sven Herzberg <​sven@imendio.com>

Reviewed by Mark Rowe.

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=15614
Bug 15614: [GTK] qmake based backends don't build on OS X

• Scripts/build-webkit: set QMAKESPEC correctly if building the QT or GTK backend on a Mac
• Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into isDarwin() to make it reusable in other places (like the workaround- for-prebuilt-qmake in build-webkit)

8:51 PM Changeset in webkit [27014] by ddkilzer

• 2 edits in trunk/WebKitTools

Refurbish update-webkit script.

Reviewed by Adam.

Scripts/update-webkit: Add -hhelp switch and usage statement. Check result of

GetOptions() call. Fix -qquiet switch to be passed to svn command properly. Use

multi-argument version of system() for flexibility and security. Check for existence
of Internal directory using -d test instead of -x.

8:50 PM Changeset in webkit [27013] by ddkilzer

• 2 edits in trunk/WebKitTools

Minor clean-up of prepare-ChangeLog script.

Reviewed by Adam.

• Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead of a string. Use multi-argument versions of open() and system() for flexibility and security.

7:40 PM Changeset in webkit [27012] by adachan

• 2 edits in trunk/WebKit/win

<rdar://problem/5552221> REGRESSION(310A24-ToT): Shortcut key disable. (15604)

Reviewed by Adam.

• WebView.cpp: (WebView::handleEditingKeyboardEvent): don't handle system key events as text input (WebView::keyDown): only remove WM_SYSCHAR message from the queue if we handle it. For WM_SYSCHAR message that we don't handle, let it stay in the queue and return false to let windows handle it.

6:19 PM Changeset in webkit [27011] by aroben

• 15 edits in trunk

Touch all files that include *.lut.h to fix Windows builds

6:16 PM Changeset in webkit [27010] by bdash

• 2 edits in trunk/WebKit/gtk

2007-10-24 Mark Rowe <​mrowe@apple.com>

Gtk build fix. Track WebCore changes in r27004.

• Api/webkitgtkglobal.cpp:

5:58 PM Changeset in webkit [27009] by justing

• 6 edits in trunk

WebCore:

Reviewed by Darin Adler.

Correcting the fix for:
<rdar://problem/5544856>
REGRESSION: After typing 2-byte text, undo only undoes one keystroke at a time

Made removal of the previous composition part of the current Undo step in the
case where the new composition is the empty string, too.

• editing/Editor.cpp: (WebCore::Editor::confirmComposition): Call the new TypingCommand::deleteSelection, which either has the currently open typing command delete the current selection, or opens a new typing command (of type DeleteSelection) if one is not already open. (WebCore::Editor::setComposition): Ditto.
• editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteSelection): Added. (WebCore::TypingCommand::doApply): Handle DeleteSelection. (WebCore::TypingCommand::deleteKeyPressed): Clarified which deleteSelection is called. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto. (WebCore::TypingCommand::preservesTypingStyle): Handle DeleteSelection.
• editing/TypingCommand.h:

LayoutTests:

Reviewed by Darin.

<rdar://problem/5544856>
REGRESSION: After typing 2-byte text, undo only undoes one keystroke at a time

• platform/mac/editing/input/text-input-controller-expected.txt: The delete we were using previously to remove the old composition makes fewer calls to the editing delegate.

5:30 PM Changeset in webkit [27008] by weinig

• 2 edits in trunk/WebCore

Build fix.

• WebCore.vcproj/WebCore.vcproj:

5:10 PM Changeset in webkit [27007] by thatcher

• 1 edit in trunk/WebKitTools/Scripts/build-webkit

Build fix.

4:55 PM Changeset in webkit [27006] by thatcher

• 4 edits
  2 adds
  1 delete in trunk

WebKit:

Reviewed by Mark Rowe.

<rdar://problem/5069711> OpenSource version of libWebKitSystemInterface.a is Tiger only, causes issues if used on Leopard

Use the WebKitSystemInterface that matches the system version.

• Configurations/DebugRelease.xcconfig:
• WebKit.xcodeproj/project.pbxproj:

WebKitLibraries:

Reviewed by Mark Rowe.

<rdar://problem/5069711> OpenSource version of libWebKitSystemInterface.a is Tiger only, causes issues if used on Leopard

Add system specific versions of WebKitSystemInterface.

• libWebKitSystemInterface.a: Removed.
• libWebKitSystemInterfaceLeopard.a: Added.
• libWebKitSystemInterfaceTiger.a: Added.

4:29 PM Changeset in webkit [27005] by aliceli1

• 7 edits in trunk

WebCore:

Reviewed by Oliver.

Fix <rdar://5410959> editing/selection/drag-to-contenteditable-iframe.html fails on Windows

• page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passMouseMoveEventToSubframe): Some mouse move events are actually drags, which on mac return early from this function. Adding the same logic to its Windows equivalent.

WebKitTools:

Reviewed by Oliver.

Fix <rdar://5410959> editing/selection/drag-to-contenteditable-iframe.html fails on Windows

Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
replay the saved events when we're still processing the mousedown that starts the drag

• DumpRenderTree/win/EventSender.cpp: (doMouseMove):
• DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::doDragDrop):

LayoutTests:

Removing fixed test

• platform/win/Skipped:

4:02 PM Changeset in webkit [27004] by beidson

• 10 edits
  2 adds in trunk

WebCore:

Reviewed by Anders

<rdar://5554130> DatabaseTracker.o has a global initializer

Since DatabaseTracker is a singleton, it makes much more sense to keep the database path as a member variable.
Now constructing the shared DatabaseTracker no longer implicitly opens it - It is only opened when the databases
path is set.

• WebCore.vcproj/WebCore.vcproj: Copy WebCore/storage headers for WebKit build

• storage/Database.cpp: (WebCore::Database::~Database): Remove bogus assertion

• storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::DatabaseTracker): Does nothing now! Move this code to openTrackerDatabase (WebCore::DatabaseTracker::setDatabasePath): Set the member variable, also closing/opening the database if needed (WebCore::DatabaseTracker::databasePath): (WebCore::DatabaseTracker::openTrackerDatabase): To open and validate the Databases db, moved from the c'tor (WebCore::DatabaseTracker::fullPathForDatabase): Return the member variable
• storage/DatabaseTracker.h:

WebKit/win:

Reviewed by Anders

Windows portion of <rdar://5554130>

Slowly introduce Windows WebKit portion of the Database API that sets the
on-disk location for databases

• WebDatabaseManager.cpp: Added. (WebKitSetWebDatabasesPathIfNecessary):
• WebDatabaseManager.h: Added.

• WebKit.vcproj/WebKit.vcproj:

• WebView.cpp: (WebView::initWithFrame): Call WebKitSetWebDatabasesPathIfNecessary()

WebKit:

Reviewed by Anders

<rdar://problem/5554130> DatabaseTracker.o has a global initializer

• Misc/WebDatabaseManager.mm: (WebKitSetWebDatabasesPathIfNecessary): Call the member function instead of a static one

4:00 PM Changeset in webkit [27003] by kmccullo

• 11 edits
  2 adds in trunk

WebKitTools:

Reviewed by Sam, Steve and Darin.

• Stubbed out the WebScriptDebugListener functionality in the Server Connection class to prepare it for receiving those callbacks.
• Also I changed the instantiation of DebuggerClient, DebuggerDocument and the ServerConnection to not need to be initialized with a server name, since that is not the way we connect to the WebKit server.

• Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging no exception. Now it only loggs when there is an exception (DebuggerDocument::willExecuteStatement): (DebuggerDocument::didEnterCallFrame): (DebuggerDocument::willLeaveCallFrame): (DebuggerDocument::windowScriptObjectAvailable): (DebuggerDocument::callFunctionOnObject):
• Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection to be instantiated with a server's name. (DebuggerClient::DebuggerClient): (DebuggerClient::didFinishLoadForFrame):
• Drosera/win/DebuggerClient.h: Removed unsued variable.
• Drosera/win/Drosera.cpp: Client no longer needs to be initialized with a server name. (Drosera::init): (Drosera::initServer):
• Drosera/win/Drosera.h: No longer need the ServerConnection to be instantiated with a server's name.
• Drosera/win/ServerConnection.cpp: (ServerConnection::ServerConnection): No longer needs a server name (ServerConnection::~ServerConnection): Only release the global context if there is one. (ServerConnection::serverConnectionDidDie): Stub for IWebScriptDebugListener (ServerConnection::QueryInterface): ditto (ServerConnection::AddRef): ditto (ServerConnection::Release): ditto (ServerConnection::didLoadMainResourceForDataSource): ditto (ServerConnection::didParseSource): ditto (ServerConnection::failedToParseSource): ditto (ServerConnection::didEnterCallFrame): ditto (ServerConnection::willExecuteStatement): ditto (ServerConnection::willLeaveCallFrame): ditto (ServerConnection::exceptionWasRaised): ditto
• Drosera/win/ServerConnection.h: Stubbed out the IWebScriptDebugListener functions, and this class no longer needs to be instantiated with a server name.

win:

Reviewed by Sam, Steve and Darin.

• Added stubs for what will be neede to let Drosera attach to the WebKit process and debug it.

• Interfaces/IWebScriptCallFrame.idl: Added.
• Interfaces/IWebScriptDebugListener.idl: Added.
• Interfaces/WebKit.idl:
• WebKit.vcproj/Interfaces.vcproj:
• WebKit.vcproj/WebKitGUID.vcproj:

3:10 PM Changeset in webkit [27002] by eseidel

• 2 edits in trunk/JavaScriptCore

2007-10-24 Eric Seidel <​eric@webkit.org>

Build fix for Gtk, no review.

• kjs/collector.cpp: #include "context.h"

2:31 PM Changeset in webkit [27001] by eseidel

• 5 edits
  2 adds in trunk

2007-10-24 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.

Stop checking isOutOfMemory after every allocation, instead let the collector
notify all ExecStates if we ever hit this rare condition.

SunSpider claims this was a 2.2% speedup.

• kjs/collector.cpp: (KJS::Collector::collect): (KJS::Collector::reportOutOfMemoryToAllInterpreters):
• kjs/collector.h:
• kjs/nodes.cpp: (KJS::TryNode::execute):

1:33 PM Changeset in webkit [27000] by hyatt

• 3 edits in trunk/WebCore

Don't try to gap fill transformed selections. Fix the invalidation of selection to use the clip to visible content
code path so that it works with multi-column layouts and transforms.

Reviewed by aroben

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelectionRoot): (WebCore::RenderBlock::fillSelectionGaps):
• rendering/RenderView.cpp: (WebCore::RenderView::setSelection):

1:25 PM Changeset in webkit [26999] by eseidel

• 3 edits in trunk/WebCore

2007-10-24 Eric Seidel <​eric@webkit.org>

No review, I want to tickle the CIA bot to test changes,
and took this as an opportunity to clean up some old change logs.

• ChangeLog-2005-08-23: update email address
• ChangeLog-2006-12-31: fix spelling mistakes

11:45 AM Changeset in webkit [26998] by mitz

• 140 edits in trunk

WebCore:

Reviewed by Oliver Hunt.

• add "(anonymous)" to the renderName of anonymous table cells, rows and sections

• rendering/RenderTableCell.h: (WebCore::RenderTableCell::renderName):
• rendering/RenderTableRow.h: (WebCore::RenderTableRow::renderName):
• rendering/RenderTableSection.h: (WebCore::RenderTableSection::renderName):

LayoutTests:

Reviewed by Oliver Hunt.

• updated results to reflect which table parts are anonymous

11:41 AM Changeset in webkit [26997] by thatcher

• 3 edits in trunk/WebCore

Reviewed by Adam.

Bug 15476: DOM tree fully expands some elements when arrowing up
​http://bugs.webkit.org/show_bug.cgi?id=15476

Add a new expandTreeElementsWhenArrowing option to TreeOutline. This option
is used only for the sidebar and search results.

• page/inspector/inspector.js: Opt-in for the sidebar and search results.
• page/inspector/treeoutline.js: Add expandTreeElementsWhenArrowing and pass this option to traverseNextTreeElement and traversePreviousTreeElement.

11:30 AM Changeset in webkit [26996] by bdash

• 2 edits in trunk/JavaScriptCore

2007-10-24 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

• kjs/identifier.h: Remove extra qualification.

11:04 AM Changeset in webkit [26995] by ggaren

• 3 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.

Disable ALWAYS_INLINE in debug builds, since it drives the debugger
crazy.

• wtf/AlwaysInline.h:

11:02 AM Changeset in webkit [26994] by ggaren

• 4 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.

Inlined the fast path for creating an Identifier from an Identifier.

This is a .4% speedup on SunSpider overall, but as big as a 2.5%
speedup on certain individual tests. 65% of the Identifiers creating
by SunSpider are already Identifiers.

(The main reason I'm making this change is that it resolves a large
regression in a patch I haven't checked in yet.)

• JavaScriptCore.exp:
• kjs/identifier.cpp: (KJS::Identifier::addSlowCase):
• kjs/identifier.h: (KJS::Identifier::Identifier::add):

10:58 AM Changeset in webkit [26993] by andersca

• 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog.

10:56 AM Changeset in webkit [26992] by andersca

• 6 edits in trunk/WebCore

Reviewed by Geoff and Mitz.

<rdar://problem/5493833>
REGRESSION: ~5MB of image data leaked @ cuteoverload.com (often seen while browsing other sites, too)

• WebCore.xcodeproj/project.pbxproj:
• bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::markDOMNodesForDocument): If an image element that is currently loading an image is not in the document, it should still be marked.

• bindings/js/kjs_html.cpp: (WebCore::ImageConstructorImp::construct): Force the document wrapper to be created.

• html/HTMLImageElement.h: (WebCore::HTMLImageElement::haveFiredLoadEvent): New method which calls down to the image loader.

• html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::HTMLImageLoader): (WebCore::HTMLImageLoader::~HTMLImageLoader): (WebCore::HTMLImageLoader::setLoadingImage): (WebCore::HTMLImageLoader::dispatchLoadEvent): Remove code that's not needed anymore.

• html/HTMLImageLoader.h: (WebCore::HTMLImageLoader::haveFiredLoadEvent): Make this public.

10:27 AM Changeset in webkit [26991] by aroben

• 6 edits in trunk

Move Windows safe file creation code into WebCore from WebPreferences

WebCore:

Move Windows safe file creation code into WebCore from WebPreferences

Reviewed by Brady.

• platform/FileSystem.h:
• platform/win/FileSystemWin.cpp: (WebCore::safeCreateFile): Moved here from WebKit/win/WebPreferences.cpp.

WebKit/win:

Move safe file creation code to WebCore

Reviewed by Brady.

• WebPreferences.cpp: (preferencesPath): Made into a static helper function. (WebPreferences::save): Now calls WebCore's safeCreateFile function. (WebPreferences::load): Uses String/CString to handle the UTF-8 conversion.
• WebPreferences.h: Removed preferencesPath and safeCreateFileWithData.

10:27 AM Changeset in webkit [26990] by aroben

• 6 edits in trunk

Reduce code duplication by using WebCore's FileSystem functions

WebCore:

Add methods to FileSystemWin to get some user profile directories

These directories are used to hold things like preferences, caches,
etc.

Reviewed by Brady.

• platform/FileSystem.h: Added new method declarations for Windows only.
• platform/win/FileSystemWin.cpp: (WebCore::bundleName): Added. (WebCore::storageDirectory): Added. (WebCore::cachedStorageDirectory): Added. (WebCore::localUserSpecificStorageDirectory): Added. Returns the directory where WebKit should store any user-specific data that should stay local to the current machine (i.e., shouldn't be stored in a roaming profile). (WebCore::roamingUserSpecificStorageDirectory): Added. Returns the directory where WebKit should store any user-specific data that should move with the user from machine to machine (i.e., should be stored in a roaming profile).

WebKit/win:

Reduce code duplication by using WebCore's FileSystem functions

Reviewed by Brady.

• WebIconDatabase.cpp: Removed a now-unused function and a fixed FIXME. (WebIconDatabase::init): Changed to use FileSystem functions.
• WebPreferences.cpp: (WebPreferences::preferencesPath): Ditto.

6:28 AM Changeset in webkit [26989] by bdash

• 3 edits in trunk/LayoutTests

2007-10-24 Mark Rowe <​mrowe@apple.com>

Fix incorrect test results landed with r26986.

• http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders-expected.txt:
• http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader-expected.txt:

6:21 AM Changeset in webkit [26988] by lars

• 13 edits
  18 adds in trunk/LayoutTests

update some test results for the Qt port.

6:06 AM Changeset in webkit [26987] by alp

• 2 edits in trunk/WebCore

2007-10-24 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=15659
InlineTextBox does not setStrokeStyle() as needed

GraphicsContextCairo workaround to support a GraphicsContextCG quirk:

Save and restore the StrokeStyle manually.

• platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForText):

5:49 AM Changeset in webkit [26986] by bdash

• 5 edits
  6 adds in trunk

2007-10-24 Julien Chaffraix <​julien.chaffraix@gmail.com>

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=15356
Bug 15356: getResponseHeader and getAllResponseHeaders do not throw exceptions

• getAllResponseHeaders and getResponseHeader throws INVALID_STATE_ERR exception as specified in the specification

• Add the check to field-name production in getResponseHeader (call to isValidToken) and returns an empty string if the header is not valid (Opera and IE behaviour)

• Updated XMLHttpRequest::responseMIMEType() to keep its behaviour

Tests: http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders.html

http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader.html
http/tests/xmlhttprequest/xmlhttprequest-invalidHeader-getRequestHeader.html

• bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
• xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): (WebCore::XMLHttpRequest::responseMIMEType):
• xml/XMLHttpRequest.h:

2007-10-24 Julien Chaffraix <​julien.chaffraix@gmail.com>

Reviewed by Darin.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=15356
getResponseHeader and getAllResponseHeaders do not throw exceptions

• http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders-expected.txt: Added.
• http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders.html: Added.
• http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader-expected.txt: Added.
• http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader.html: Added.
• http/tests/xmlhttprequest/xmlhttprequest-invalidHeader-getRequestHeader-expected.txt: Added.
• http/tests/xmlhttprequest/xmlhttprequest-invalidHeader-getRequestHeader.html: Added.

5:33 AM Changeset in webkit [26985] by lars

• 2 edits
  3 adds in trunk/LayoutTests

these tests don't crash anymore :)

5:33 AM Changeset in webkit [26984] by lars

• 2 edits in trunk/WebKit/qt

• Stop crashing on fast/events/frame-tab-focus.html the keyEvent can be 0.

Signed-off-by: Lars Knoll <​lars@trolltech.com>

5:33 AM Changeset in webkit [26983] by lars

• 2 edits in trunk/WebCore

implement most of DragData.

5:33 AM Changeset in webkit [26982] by lars

• 4 edits in trunk

add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.

5:33 AM Changeset in webkit [26981] by lars

• 2 edits
  511 adds in trunk/LayoutTests

we're passing most editing tests now. Commit them.

5:33 AM Changeset in webkit [26980] by lars

• 2 edits in trunk/WebKitTools

add another command.

5:32 AM Changeset in webkit [26979] by lars

• 2 edits
  1 add
  3 deletes in trunk/LayoutTests

convert the text to be text only, and fix it up a little so it doesn't depend on specific font metrics anymore.

5:32 AM Changeset in webkit [26978] by lars

• 2 edits in trunk/WebKit/qt

remove some notImplemented() warnings.

5:32 AM Changeset in webkit [26977] by lars

• 3 edits in trunk/WebKitTools

add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.

5:32 AM Changeset in webkit [26976] by lars

• 2 edits in trunk/WebCore

remove a stupid notImplemented() warning and implement PasteBoad::clear().

5:32 AM Changeset in webkit [26975] by lars

• 2 edits in trunk/WebKit/qt

allow paste from DOM so we pass more test cases.

5:32 AM Changeset in webkit [26974] by lars

• 2 edits in trunk/WebCore

implement Pasteboard::documentFragment(), and fix a mem leak.

5:32 AM Changeset in webkit [26973] by lars

• 2 edits in trunk/WebKitTools

implement eventSender.keyDown().

5:32 AM Changeset in webkit [26972] by lars

• 3 edits in trunk/JavaScriptCore

some changes to the way JS values are converted to Qt values in the script bindings. Added support for converting JS arrays into QStringList's.

5:32 AM Changeset in webkit [26971] by lars

• 5 edits in trunk

Simplify the PlatformKeyEvent constructor. No need to have an extra boolean for isKeyUp in there, as the QKeyEvent has the information.

5:32 AM Changeset in webkit [26970] by lars

• 5 edits in trunk

some smaller fixes to the editing support in DRT. Makes another few tests pass.

5:32 AM Changeset in webkit [26969] by lars

• 2 edits in trunk/LayoutTests

explicitly add some tests that currently cause DRT to hang.

5:32 AM Changeset in webkit [26968] by lars

• 5 edits in trunk/WebKitTools

first bit of implementation for the textinputcontroller.

5:32 AM Changeset in webkit [26967] by lars

• 2 edits in trunk/WebKit/qt

implemented support for most editing shortcuts to make contentEditable usable.

5:32 AM Changeset in webkit [26966] by lars

• 2 edits in trunk/WebKit/qt

no need to call setIsActive ourselves on the frame, as the focus controller does it for us.

5:32 AM Changeset in webkit [26965] by lars

• 2 edits in trunk/WebKitTools

make the man webpage believe it has focus, so the editing tests work correctly.

5:32 AM Changeset in webkit [26964] by lars

• 3 edits in trunk/WebKitTools

implement layoutTestController.dumpEditingCallbacks() correctly.

5:32 AM Changeset in webkit [26963] by lars

• 3 edits in trunk/WebCore

use the new QTextBoundaryFinder class in Qt.

5:32 AM Changeset in webkit [26962] by lars

• 4 edits in trunk

Implement support for testing editing.

1:53 AM Changeset in webkit [26961] by oliver

• 4 edits in trunk/JavaScriptCore

Remove old relation method, replace with specialised LessThan and lessThenEq functions for a 0.5-0.6% improvement in SunSpider

Reviewed by Darin

1:50 AM Changeset in webkit [26960] by eseidel

• 2 edits in trunk/JavaScriptCore

2007-10-24 Eric Seidel <​eric@webkit.org>

Reviewed by darin.

• kjs/nodes.h: (KJS::ImmediateNumberNode::): Fix ASSERT correctness (and debug build!)

1:21 AM Changeset in webkit [26959] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by Eric.

• kjs/object.cpp: (KJS::JSObject::defaultValue): Get rid of a little Identifier ref/deref for what SunSpider claims is a 0.4% speedup.

1:14 AM Changeset in webkit [26958] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

• separate out the code to create a hash table the first time from the code to rehash

SunSpider claims this was a 0.7% speedup.

• kjs/property_map.cpp: (KJS::PropertyMap::expand): Changed to call either createTable or rehash. (KJS::PropertyMap::createTable): Added. For the case where we had no table. (KJS::PropertyMap::rehash): Removed code needed only in the case where we had no table.
• kjs/property_map.h: Added createTable.

1:06 AM Changeset in webkit [26957] by eseidel

• 5 edits in trunk/JavaScriptCore

2007-10-24 Eric Seidel <​eric@webkit.org>

Reviewed by darin.

Add ImmediateNumberNode to hold a JSValue* instead of a double for numbers
which can be represented by JSImmediate.

• kjs/grammar.y:
• kjs/nodes.cpp: (KJS::NumberNode::evaluate): (KJS::ImmediateNumberNode::evaluate):
• kjs/nodes.h: (KJS::Node::): (KJS::ImmediateNumberNode::):
• kjs/nodes2string.cpp: (ImmediateNumberNode::streamTo):

1:03 AM Changeset in webkit [26956] by darin

• 6 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

• ​http://bugs.webkit.org/show_bug.cgi?id=15657 change static hash tables to use powers of two for speed

Seems to give 0.7% SunSpider speedup.

• kjs/create_hash_table: Updated to generate new format.
• kjs/lookup.cpp: (KJS::keysMatch): Took out unneeded typecast. (KJS::findEntry): Updated to expect table type 3 -- changed the printf to a plain old assert. Replaced the modulus with a bit mask. (KJS::Lookup::findEntry): Get the hash directly, since we know identifiers already have computed their hash -- saves a branch. (KJS::Lookup::find): Ditto.
• kjs/lookup.h: Changed attr from 2-byte value to one-byte value. Replaced hashSize with hashSizeMask.

WebCore:

Reviewed by Maciej.

• ​http://bugs.webkit.org/show_bug.cgi?id=15657 change static hash tables to use powers of two for speed

• bindings/scripts/CodeGeneratorJS.pm: Updated to generate new format.

12:59 AM Changeset in webkit [26955] by mjs

• 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

• remove KJS_CHECKEXCEPTIONs in places where exceptions can't happen for 0.6% SunSpider speedup

• kjs/nodes.cpp: (KJS::DoWhileNode::execute): (KJS::WhileNode::execute): (KJS::ForNode::execute): (KJS::ForInNode::execute): (KJS::SourceElementsNode::execute):

12:41 AM Changeset in webkit [26954] by darin

• 3 edits in trunk/SunSpider

Reviewed by Eric.

• sunspider: Open the profile in shark after completing a run.
• sunspider-compare-results: Tiny perl tweaks.

12:40 AM Changeset in webkit [26953] by hausmann

• 2 edits in trunk/WebCore

Fix pathByAppendingComponent for the Qt port.

Oct 23, 2007:

11:52 PM Changeset in webkit [26952] by hyatt

• 2 edits in trunk/WebCore

Make repainting work with transforms.

Reviewed by John Sullivan

• rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):

11:41 PM Changeset in webkit [26951] by darin

• 1 edit in trunk/SunSpider/hosted

Ignore files generated by the make-hosted script.

11:19 PM Changeset in webkit [26950] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

• kjs/JSImmediate.h: (KJS::JSImmediate::getUInt32): Changed an && to an & for a 1% gain in SunSpider.

9:40 PM Changeset in webkit [26949] by alp

• 4 edits in trunk/WebCore

2007-10-23 Alp Toker <​alp@atoker.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14412
[GDK] Clipboard support

Initial clipboard implementation for the GTK+ port.

• platform/gtk/ClipboardGtk.cpp: (WebCore::Editor::newGeneralClipboard):
• platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::generalPasteboard): (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::~Pasteboard): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::plainText):
• platform/gtk/TemporaryLinkStubs.cpp:

9:35 PM Changeset in webkit [26948] by thatcher

• 3 edits in trunk/WebCore

Reviewed by Adam.

Fixes the Network panel so that it refreshes as needed.

• page/inspector/ConsolePanel.js: Call the base class show() and hide() first.
• page/inspector/NetworkPanel.js: Add refreshNeeded and refreshIfNeeded back. Ditto.

8:47 PM Changeset in webkit [26947] by weinig

• 2 edits in trunk/WebKitTools

Check for null BSTR that can be passed to the UIDelegate methods
from javascript null and undefined. Fixes a failing test case on
Windows (fast/dom/Window/alert-undefined.html)

Reviewed by Eric Seidel.

• DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::runJavaScriptAlertPanelWithMessage): (UIDelegate::runJavaScriptConfirmPanelWithMessage): (UIDelegate::runJavaScriptTextInputPanelWithPrompt): (UIDelegate::webViewAddMessageToConsole):

7:15 PM Changeset in webkit [26946] by mitz

• 6 edits in trunk/WebCore

Rolled out r26941 because it of layout test failures.

7:01 PM Changeset in webkit [26945] by oliver

• 4 edits in trunk/JavaScriptCore

Reduce branching in implementations of some operator implementations, yielding 1.3% boost to SunSpider.

Reviewed by Maciej

• kjs/nodes.cpp: (KJS::MultNode::evaluate): (KJS::DivNode::evaluate): (KJS::ModNode::evaluate): (KJS::add): (KJS::sub): (KJS::AddNode::evaluate): (KJS::SubNode::evaluate): (KJS::valueForReadModifyAssignment):
• kjs/operations.cpp:
• kjs/operations.h:

6:59 PM Changeset in webkit [26944] by justing

• 4 edits in trunk/LayoutTests

Fixing an accidental change made in r25484.

• editing/pasteboard/quirks-mode-br-1.html:
• platform/mac/editing/pasteboard/quirks-mode-br-1-expected.checksum:
• platform/mac/editing/pasteboard/quirks-mode-br-1-expected.txt:

6:56 PM Changeset in webkit [26943] by justing

• 4 edits in trunk/LayoutTests

Reviewed by Oliver Hunt.

<rdar://problem/5544856>
REGRESSION: After typing 2-byte text, undo only undoes one keystroke at a time

• platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt:
• platform/mac/editing/input/text-input-controller-expected.txt:
• platform/mac/editing/input/wrapped-line-char-rect-expected.txt:

6:53 PM Changeset in webkit [26942] by justing

• 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

<rdar://problem/5544856>
REGRESSION: After typing 2-byte text, undo only undoes one keystroke at a time

No layout test for now because I'm having trouble getting Undo during a layout
test to only undo the last Undo step, and I want to write a test that fails
without the code change.

• editing/Editor.cpp: (WebCore::Editor::confirmComposition): When we replace the previous composition, delete it with a sub-command of the command used to insert the new composition, instead of with a separate command. No new code was added because insertText already deletes the current selection. (WebCore::Editor::setComposition): Ditto.

6:51 PM Changeset in webkit [26941] by mitz

• 5 edits
  1 add in trunk/WebCore

Reviewed by Eric Seidel.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=15405 ASSERTION FAILED: d->m_view && !d->m_view->needsLayout() in Frame::Paint

Calling updateWidget() during attach() led to arbitrary (plugin and resource load delegate)
code execution under attach(). The fix is to use the mechanism that's already in place for
deferring updateWidget() until after layout.

• html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::attach): Replaced call to updateWidget() with call to updateWidgetSoon()
• html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::attach): Ditto.
• manual-tests/paint-during-plugin-attach.html: Added.
• rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidgetSoon): Added this function that schedules the updateWidget() call for after the next layout.
• rendering/RenderPartObject.h:

6:36 PM Changeset in webkit [26940] by weinig

• 3 edits in trunk/WebKit/win

Make the WebNotificationCenter work with null (wildcard) and specific
observed objects, matching NSNotificationCenter.

• Removes the ObserverKey, ObserverHash, and ObserverKeyTraits as we now hash against the notification name only and check the object on notification posting.
• Use OwnPtr for the WebNotificationCenterPrivate member variable.

Reviewed by Adam Roben.

• WebNotificationCenter.cpp: (WebNotificationCenter::WebNotificationCenter): (WebNotificationCenter::~WebNotificationCenter): (WebNotificationCenter::postNotificationInternal): (WebNotificationCenter::addObserver): (WebNotificationCenter::postNotification): (WebNotificationCenter::postNotificationName): (WebNotificationCenter::removeObserver):
• WebNotificationCenter.h:

6:33 PM Changeset in webkit [26939] by sfalken

• 1 copy in tags/Safari-523.12.8b

New tag.

6:33 PM Changeset in webkit [26938] by sfalken

• 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

6:30 PM Changeset in webkit [26937] by aroben

• 2 edits in trunk/WebCore

Fix the behavior of pathByAppendingComponent when path is empty

We now use the Windows Shell API function PathAppendW instead of
rolling our own broken implementation.

Reviewed by Anders.

• platform/win/FileSystemWin.cpp: (WebCore::pathByAppendingComponent):

5:56 PM Changeset in webkit [26936] by mjs

• 2 edits in trunk/WebKitTools

Reviewed by Darin.

Don't print a massive pile of setenvs from tools that automatically build testkjs.

• Scripts/build-testkjs:

5:40 PM Changeset in webkit [26935] by mjs

• 3 edits
  1 add in trunk

SunSpider:

Reviewed by Darin.

• Don't hardcode my path to testkjs

• sunspider-compare-results:

WebKitTools:

Reviewed by Darin.

• add wrapper that finds the right copy of testkjs

• Scripts/sunspider-compare-results: Added.

5:12 PM Changeset in webkit [26934] by adele

• 3 edits
  2 adds in trunk

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5543228> CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::HTMLInputElement::defaultEventHandler + 872

Test: fast/forms/textfield-onchange-deletion.html

• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Refetch the renderer since arbitrary JS code run during onchange can do anything, including destroying it.

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/5543228> CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::HTMLInputElement::defaultEventHandler + 872

• fast/forms/textfield-onchange-deletion-expected.txt: Added.
• fast/forms/textfield-onchange-deletion.html: Added.

5:08 PM Changeset in webkit [26933] by thatcher

• 8 edits
  7 adds in trunk/WebCore

Reviewed by Sam Weinig.

• Made seperate files for the various classes in ResourcePanel.js.
• Broke up ResourcePanel.js and created seperate panel classes for different resource types.
• Moved View code down to the Panel base-class.
• Reduced code duplication in DatabasePanel.js by sub-classing from the new ResourcePanel.

• page/inspector/DatabasePanel.js:
• page/inspector/DocumentPanel.js: Added.
• page/inspector/FontPanel.js: Added.
• page/inspector/ImagePanel.js: Added.
• page/inspector/Panel.js: Added.
• page/inspector/PropertiesSection.js: Added.
• page/inspector/Resource.js:
• page/inspector/ResourcePanel.js:
• page/inspector/SidebarPane.js: Added.
• page/inspector/SourcePanel.js: Added.
• page/inspector/inspector.css:
• page/inspector/inspector.html:
• page/inspector/inspector.js:

4:47 PM Changeset in webkit [26932] by andersca

• 2 edits in trunk/WebCore

Correct the version #if check.

• platform/sql/SQLDatabase.cpp: (WebCore::SQLDatabase::authorizerFunction):

4:40 PM Changeset in webkit [26931] by sfalken

• 3 edits in branches/Safari-3-branch/WebCore

Reviewed by Anders.

<rdar://5548217>: [NTS] Java 6 update 3 crashes Safari when loading a
java page

It is possible to load Mozilla's Java plugin instead of our own, which
can lead to a crash. The fix is to prefer plugins in our own Plugins
directory when searching for a plugin.

• plugins/win/PluginDatabaseWin.cpp: (WebCore::safariPluginsPath): Return the path to our own Plugins directory (WebCore::PluginDatabaseWin::defaultPluginPaths): Use new method safariPluginsPath() (WebCore::PluginDatabaseWin::pluginForMIMEType): If the plugin's path is our Plugins path, return this plugin. Otherwise, continue scanning the list of plugins (WebCore::PluginDatabaseWin::pluginForExtension): Same
• plugins/win/PluginPackageWin.h: (WebCore::PluginPackageWin::path): Return this plugin's path

4:30 PM Changeset in webkit [26930] by sfalken

• 2 edits in branches/Safari-3-branch/WebCore

Fix build.

• plugins/win/PluginViewWin.cpp:

4:16 PM Changeset in webkit [26929] by honeycutt

• 3 edits in trunk/WebCore

2007-10-23 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Anders.

<rdar://5548217>: [NTS] Java 6 update 3 crashes Safari when loading a
java page

It is possible to load Mozilla's Java plugin instead of our own, which
can lead to a crash. The fix is to prefer plugins in our own Plugins
directory when searching for a plugin.

• plugins/win/PluginDatabaseWin.cpp: (WebCore::safariPluginsPath): Return the path to our own Plugins directory (WebCore::PluginDatabaseWin::defaultPluginPaths): Use new method safariPluginsPath() (WebCore::PluginDatabaseWin::pluginForMIMEType): If the plugin's path is our Plugins path, return this plugin. Otherwise, continue scanning the list of plugins (WebCore::PluginDatabaseWin::pluginForExtension): Same
• plugins/win/PluginPackageWin.h: (WebCore::PluginPackageWin::path): Return this plugin's path

4:14 PM Changeset in webkit [26928] by adachan

• 5 edits in trunk/WebKit/win

<rdar://problem/5244261> SafariWin ignores cookie policy setting "never" in the preferences
Custom WebPreferences (not the shared WebPreferences) could override the cookie accept
policy setting on the default cookie storage. To fix that, I added a new method in
WebView called updateGlobalSettingsFromPreferences() to handle updating the global pref
options such as cookie accept policy, and it's only called to update changes from
the shared WebPreferences.

Use CLSID_WebPreferences and remove IID_WebPreferences.

Reviewed by Darin and Adam.

• WebPreferences.cpp: (WebPreferences::QueryInterface):
• WebPreferences.h:
• WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences): (WebView::updateGlobalSettingsFromPreferences): (WebView::updateSettingsFromPreferences): (WebView::developerExtrasEnabled): (WebView::initWithFrame): (WebView::onNotify):
• WebView.h:

4:11 PM Changeset in webkit [26927] by kmccullo

• 6 edits in trunk/WebKitTools

Reviewed by Sam.

• After talking with Steve I now see that the WebKit server must be running for DCOM to create the distributed objects, which makes sense and currently WebKit only allows one instance to be running at a time which avoids accidentally connecting to the wrong server
• In light of this I have removed the code for the attach box and NotificationServer and known server names, since they are all extranious now.

• Drosera/win/Drosera.cpp: Removed notification classes and known server names. (_tWinMain): Uses init instead of initUI. (droseraWndProc): No longer creats an attach dialog box. (Drosera::Drosera): Does the OleInitialize so COM is ready to go and it's not manditory to call init before doing COM stuff. (Drosera::init): calls initUI and will call attach when the functionality exists. (Drosera::initUI): Has changed very little. (Drosera::attach): Changed the signature to reflect that we no longer need the dictionary of known server names.
• Drosera/win/Drosera.h: Removed notification classes and known server names. Also renamed and moved some functions.
• Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
• Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the headers to the resources folder.
• Drosera/win/resource.h: Removed the Attach box.

3:27 PM Changeset in webkit [26926] by mjs

• 2 edits
  2 adds in trunk/SunSpider

Reviewed by Darin.

• Add a compare script to compare results, and improve formatting of standard results a bit.

• resources/sunspider-analyze-results.js:
• resources/sunspider-compare-results.js: Added.
• sunspider-compare-results: Added.

2:25 PM Changeset in webkit [26925] by oliver

• 6 edits in trunk/JavaScriptCore

Separating all of the simple binary expression nodes into multiple classes

Reviewed by Maciej

Separating all of the simple (eg. non-read-modify-write) binary operators into separate classes in preparation for further JS optimisations.

Happily this produces a 0.8% to 1.0% performance increase in SunSpider with no further work.

12:29 PM Changeset in webkit [26924] by alp

• 2 edits in trunk/WebCore

2007-10-23 Jasper Bryant-Greene <​m@ni.ac.nz>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15058
Precedence fault in KeyEventGdk causes shift, control, alt etc to work incorrectly

Corrected precendence fault which was causing Shift, Alt, Control and
Meta to behave incorrectly on GTK.

Coding style fix by Alp.

• platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

12:05 PM BuildingGtk edited by iwkse@claws-mail.org

(diff)

11:25 AM Changeset in webkit [26923] by aroben

• 2 edits in trunk/LayoutTests

Add some SVG tests to the Windows Skipped file

Reviewed by Oliver.

• platform/win/Skipped:

11:11 AM Changeset in webkit [26922] by weinig

• 5 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Add resizing of the DOM view right sidebar. This allows us to actually see the values now.

• page/inspector/ResourcePanel.js:
• page/inspector/inspector.css:
• page/inspector/inspector.js:
• page/inspector/utilities.js:

8:52 AM Changeset in webkit [26921] by hyatt

• 9 edits in trunk/WebCore

Get basic hit testing right for transforms.

Reviewed by ollliej

• platform/graphics/AffineTransform.cpp: (WebCore::AffineTransform::mapPoint):
• platform/graphics/AffineTransform.h:
• rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint):
• rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint):
• rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTest): (WebCore::RenderLayer::hitTestLayer):
• rendering/RenderLayer.h:
• rendering/RenderObject.cpp: (WebCore::RenderObject::hitTest):
• rendering/RenderObject.h:

8:49 AM Changeset in webkit [26920] by darin

• 3 edits in trunk/LayoutTests

• removed numeric results so the test is more platform-independent

• fast/js/math-expected.txt: Updated.
• fast/js/resources/math.js: Updated.

7:12 AM Changeset in webkit [26919] by darin

• 3 edits
  3 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=15639 fix Math.abs(0), Math.ceil(-0), and Math.floor(-0)

Test: fast/js/math.html

• kjs/math_object.cpp: (MathFuncImp::callAsFunction): Fix abs to look at the sign bit. Add a special case for values in the range between -0 and -1 and a special case for ceil and for -0 for floor.

LayoutTests:

Reviewed by Maciej.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=15639 Math functions

• fast/js/math-expected.txt: Added.
• fast/js/math.html: Added.
• fast/js/resources/math.js: Added.

5:11 AM Changeset in webkit [26918] by bdash

• 2 edits in trunk/WebKit

2007-10-23 Mark Rowe <​mrowe@apple.com>

Build fix for Eric's build fix in r26916.

• MigrateHeaders.make:

2:44 AM Changeset in webkit [26917] by eseidel

• 2 edits in trunk/WebCore

2007-10-23 Eric Seidel <​eric@webkit.org>

Reviewed by Mark Rowe.

Fix leaks seen on TOT from new font-face code.

• ksvg2/svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::rebuildFontFace): use a stack allocated CSSProperty instead of mallocing

1:33 AM Changeset in webkit [26916] by eseidel

• 3 edits in trunk/WebCore

2007-10-23 Eric Seidel <​eric@webkit.org>

Build fix only, no review.

Sacrifice three virgin hours upon the altar of the heathen XCode gods
and pray that our build troubles are finally over. :(

• DerivedSources.make: add DOMSVGException.h
• WebCore.xcodeproj/project.pbxproj: Remove DOMSVG*Interal.h files from "Copy Generated Headers" phase. Why? Who knows.

12:07 AM Changeset in webkit [26915] by mjs

• 3 edits in trunk/SunSpider

Reviewed by Darin.

• resources/sunspider-analyze-results.js: Do the error range properly, using the t-distribution instead of 1.96 (which was based on the normal distribution).

• sunspider: Print results in a way that will be friendlier to the soon-to-come compare mode.

12:00 AM Changeset in webkit [26914] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Eric.

• streamline exception handling code for a >1% speed-up of SunSpider

• kjs/nodes.cpp: Changed macros to use functions for everything that's not part of normal execution. We'll take function call overhead when propagating an exception or out of memory. (KJS::createOutOfMemoryCompletion): Added. (KJS::substitute): Use append instead of the relatively inefficient + operator. (KJS::Node::rethrowException): Added.
• kjs/nodes.h: Added rethrowException.

Oct 22, 2007:

11:45 PM Changeset in webkit [26913] by sfalken

• 2 edits in trunk/WebCore

Fix build.

• plugins/win/PluginViewWin.cpp:

11:44 PM Changeset in webkit [26912] by darin

• 7 edits in trunk/JavaScriptCore

Reviewed by Maciej.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=15636 some JavaScriptCore regression tests are failing due to numeric conversion

This should restore correctness and make speed better too, restoring some
of the optimization we lost in my last check-in.

• kjs/JSImmediate.h: (KJS::JSImmediate::getTruncatedInt32): Added. Uses the range checking idiom I used in my patch yesterday. (KJS::JSImmediate::getTruncatedUInt32): Ditto.

• kjs/internal.h: Removed getInt32 and added getTruncatedInt/UInt32.
• kjs/internal.cpp: (KJS::NumberImp::getUInt32): Changed to always use double, since I can't find a way to write this more efficiently for float. (KJS::NumberImp::getTruncatedInt32): Added. (KJS::NumberImp::getTruncatedUInt32): Added.

• kjs/value.h: Removed getInt32 and added getTruncatedInt/UInt32. (KJS::JSValue::getUInt32): (KJS::JSValue::getTruncatedInt32): Added. (KJS::JSValue::getTruncatedUInt32): Added. (KJS::JSValue::toInt32): Changed getInt32 call to getTruncatedInt32. (KJS::JSValue::toUInt32): Changed getUInt32 call to getTruncatedUInt32.
• kjs/value.cpp: (KJS::JSCell::getTruncatedInt32): Added. (KJS::JSCell::getTruncatedUInt32): Added. (KJS::JSValue::toInteger): Changed getUInt32 call to getTruncatedInt32. (KJS::JSValue::toInt32SlowCase): Removed extra getInt32 call I accidentally had left in here. (KJS::JSValue::toUInt32SlowCase): Ditto. (KJS::JSValue::toUInt16): Changed getUInt32 call to getTruncatedUInt32.

• JavaScriptCore.exp: Updated.

11:28 PM Changeset in webkit [26911] by eseidel

• 2 edits in trunk/WebCore

2007-10-22 Eric Seidel <​eric@webkit.org>

Build fix only, no review.

• WebCore.xcodeproj/project.pbxproj: re-add all DOMSVG headers to copy-files phase to make sure.

11:22 PM Changeset in webkit [26910] by eseidel

• 2 edits in trunk/WebCore

2007-10-22 Eric Seidel <​eric@webkit.org>

Build fix only, no review.

• WebCore.xcodeproj/project.pbxproj: make sure DOMSVGAnimateElement.h is copied into headers.

11:07 PM Changeset in webkit [26909] by eseidel

• 1 edit in trunk/WebCore/ksvg2/svg/SVGAnimateElement.idl

Touch SVGAnimateElement.idl to force to bots to rebuild *SVGAnimateElement.*

9:19 PM Changeset in webkit [26908] by mjs

• 2 edits
  7 adds in trunk/SunSpider

Reviewed by Review.

• add more tests (probably the final set for now)

Already balanced. Added date, regexp, control flow, and a few
more string and object/array access tests.

• tests/LIST:
• tests/access-fannkuch.js: Added.
• tests/access-nbody.js: Added.
• tests/controlflow-recursive.js: Added.
• tests/date-format-tofte.js: Added.
• tests/date-format-xparb.js: Added.
• tests/regexp-dna.js: Added.
• tests/string-validate-input.js: Added.

8:49 PM Changeset in webkit [26907] by eseidel

• 12 edits
  2 adds in trunk

2007-10-22 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.

Fix build by properly exposing SVG font-face dom bindings.

• DerivedSources.make:
• WebCore.vcproj/WebCore.vcproj: add font-face files to build
• WebCore.xcodeproj/project.pbxproj: add missing DOM bindings files
• bindings/js/JSSVGElementWrapperFactory.cpp:
• bindings/objc/DOM.mm: (WebCore::createElementClassMap):
• bindings/objc/DOMSVG.h:
• ksvg2/svg/SVGDefinitionSrcElement.idl: inherit from SVGElement

7:44 PM Changeset in webkit [26906] by bdash

• 2 edits in trunk/WebCore

2007-10-22 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

• WebCore.pro:

7:30 PM Changeset in webkit [26905] by darin

• 3 edits in trunk/WebCore

• a first cut at fixing the Qt and GTK builds

• WebCore.pro: Add new .idl and .cpp files.
• DerivedSources.make: Re-sorted.

6:02 PM JavaScript performance improvement ideas edited by mjs@apple.com

(diff)

5:50 PM JavaScript performance improvement ideas edited by ggaren@apple.com

(diff)

5:38 PM Changeset in webkit [26904] by eseidel

• 15 edits
  28 adds in trunk

2007-10-22 Eric Seidel <​eric@webkit.org>

Reviewed by hyatt.

Implement <font-face> and friends for SVG.
​http://bugs.webkit.org/show_bug.cgi?id=10652

• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSSVGElementWrapperFactory.cpp:
• dom/Document.cpp: (WebCore::Document::mappedElementSheet): (WebCore::Document::recalcStyleSelector):
• dom/Document.h:
• ksvg2/scripts/make_names.pl:
• ksvg2/svg/SVGDefinitionSrcElement.cpp: Added. (WebCore::SVGDefinitionSrcElement::SVGDefinitionSrcElement): (WebCore::SVGDefinitionSrcElement::~SVGDefinitionSrcElement): (WebCore::SVGDefinitionSrcElement::childrenChanged):
• ksvg2/svg/SVGDefinitionSrcElement.h: Added.
• ksvg2/svg/SVGDefinitionSrcElement.idl: Added.
• ksvg2/svg/SVGFontFaceElement.cpp: Added. (WebCore::SVGFontFaceElement::SVGFontFaceElement): (WebCore::SVGFontFaceElement::~SVGFontFaceElement): (WebCore::cssPropertyIdForName): (WebCore::mapAttributeToCSSProperty): (WebCore::cssPropertyIdForSVGAttributeName): (WebCore::SVGFontFaceElement::parseMappedAttribute): (WebCore::SVGFontFaceElement::rebuildFontFace): (WebCore::SVGFontFaceElement::childrenChanged):
• ksvg2/svg/SVGFontFaceElement.h: Added.
• ksvg2/svg/SVGFontFaceElement.idl: Added.
• ksvg2/svg/SVGFontFaceFormatElement.cpp: Added. (WebCore::SVGFontFaceFormatElement::SVGFontFaceFormatElement): (WebCore::SVGFontFaceFormatElement::~SVGFontFaceFormatElement): (WebCore::SVGFontFaceFormatElement::childrenChanged):
• ksvg2/svg/SVGFontFaceFormatElement.h: Added.
• ksvg2/svg/SVGFontFaceFormatElement.idl: Added.
• ksvg2/svg/SVGFontFaceNameElement.cpp: Added. (WebCore::SVGFontFaceNameElement::SVGFontFaceNameElement): (WebCore::SVGFontFaceNameElement::~SVGFontFaceNameElement): (WebCore::SVGFontFaceNameElement::srcValue):
• ksvg2/svg/SVGFontFaceNameElement.h: Added.
• ksvg2/svg/SVGFontFaceNameElement.idl: Added.
• ksvg2/svg/SVGFontFaceSrcElement.cpp: Added. (WebCore::SVGFontFaceSrcElement::SVGFontFaceSrcElement): (WebCore::SVGFontFaceSrcElement::~SVGFontFaceSrcElement): (WebCore::SVGFontFaceSrcElement::srcValue): (WebCore::SVGFontFaceSrcElement::childrenChanged):
• ksvg2/svg/SVGFontFaceSrcElement.h: Added.
• ksvg2/svg/SVGFontFaceSrcElement.idl: Added.
• ksvg2/svg/SVGFontFaceUriElement.cpp: Added. (WebCore::SVGFontFaceUriElement::SVGFontFaceUriElement): (WebCore::SVGFontFaceUriElement::~SVGFontFaceUriElement): (WebCore::SVGFontFaceUriElement::srcValue): (WebCore::SVGFontFaceUriElement::childrenChanged):
• ksvg2/svg/SVGFontFaceUriElement.h: Added.
• ksvg2/svg/SVGFontFaceUriElement.idl: Added.
• ksvg2/svg/svgtags.in:

5:33 PM Changeset in webkit [26903] by aroben

• 2 edits in trunk/WebKitTools

Windows build fix

Reviewed by NOBODY.

• Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.

5:28 PM Changeset in webkit [26902] by sfalken

• 1 copy in tags/Safari-523.12.7b

New tag.

5:28 PM Changeset in webkit [26901] by sfalken

• 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

5:26 PM Changeset in webkit [26900] by sfalken

• 2 edits in branches/Safari-3-branch/WebCore

Merged fix from r26898.

4:36 PM Changeset in webkit [26899] by darin

• 7 edits in trunk

JavaScriptCore:

Reviewed by Geoff.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=15632 js1_5/Array/array-001.js test failing

One of the JavaScriptCore tests was failing; it failed because of
my change to NumberImp::getUInt32. The incorrect code I copied was
from JSImmediate::getUInt32, and was a pre-existing bug.

This patch fixes correctness, but will surely slow down SunSpider.
We may be able to code this tighter and get the speed back.

• kjs/JSImmediate.h: (KJS::JSImmediate::getInt32): Renamed from toInt32 to more accurately reflect the fact that this function only returns true if the value is accurate (no fractional part, etc.). Changed code so that it returns false when the value has a fraction. (KJS::JSImmediate::getUInt32): Ditto.

• kjs/internal.cpp: (KJS::NumberImp::getInt32): Changed code so that it returns false when the value has a fraction. Restores the old behavior. (KJS::NumberImp::getUInt32): Ditto.

• kjs/value.h: (KJS::JSValue::getInt32): Updated for name change. (KJS::JSValue::getUInt32): Ditto. (KJS::JSValue::toInt32): Ditto. (KJS::JSValue::toUInt32): Ditto.

LayoutTests:

Reviewed by Geoff.

• tests for ​http://bugs.webkit.org/show_bug.cgi?id=15632

Added tests for cases where you use something that looks like an array
index, but it has a fractional part.

• fast/js/kde/resources/Array.js: Added tests.
• fast/js/kde/Array-expected.txt: Updated.

4:29 PM Changeset in webkit [26898] by honeycutt

• 2 edits in trunk/WebCore

2007-10-22 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Anders.

<rdar://5548217>: [NTS] Java 6 update 3 crashes Safari when loading a
java page

We purposefully do not destroy our Java VM when its reference count
reaches 0, but we were unloading our JavaPlugin.dll when its reference
count reached 0, which lost the reference to the VM. This led to our
process trying to create a new VM the next time a page using Java was
loaded, and the JNI spec states that a single process is not allowed to
create more than one VM. The fix is to avoid unloading the Java plugin
via our PluginQuirkDontUnloadPlugin.

• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::determineQuirks):

3:18 PM Changeset in webkit [26897] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by Brady.

• fix crash seen when running JavaScriptCore tests

• kjs/array_instance.cpp: (KJS::ArrayInstance::mark): Copy and paste error: I accidentally had code here that was making a copy of the HashMap -- that's illegal inside a mark function and was unnecessary. The other callsite was modifying the map as it iterated it, but this function is not.

2:32 PM Changeset in webkit [26896] by hyatt

• 6 adds in trunk/LayoutTests/platform/mac/fast/transforms

Add results for new layout tests for transforms.

2:32 PM Changeset in webkit [26895] by hyatt

• 2 adds in trunk/LayoutTests/fast/transforms

Add two new layout tests for transforms.

2:29 PM Changeset in webkit [26894] by hyatt

• 4 edits in trunk/WebCore

Fix for bug 15624, make transforms work properly with opacity.

Make sure a unitless 0 is allowed as an angle argument to rotation/skew.

Reviewed by Mitz Pettel

fast/transforms/transforms-with-opacity.html
fast/transforms/skew-with-unitless-zero.html

• css/CSSParser.cpp: (WebCore::CSSParser::validUnit):
• rendering/RenderLayer.cpp: (WebCore::transparencyClipBox): (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::calculateClipRects):
• rendering/RenderLayer.h: (WebCore::RenderLayer::transform):

2:26 PM Changeset in webkit [26893] by mjs

• 2 edits in trunk/JavaScriptCore

Reviewed by Oliver.

• Avoid moving floats into integer registers in jsNumber() for 3% speedup on SunSpider ​http://bugs.webkit.org/show_bug.cgi?id=15627

• kjs/JSImmediate.h: (KJS::JSImmediate::fromDouble): Avoid moving floats to integer registers since this is very slow.

11:39 AM Changeset in webkit [26892] by darin

• 7 edits in trunk/JavaScriptCore

Reviewed by Eric Seidel.

• ​http://bugs.webkit.org/show_bug.cgi?id=15617 improve speed of integer conversions

Makes SunSpider 6% faster.

• kjs/JSImmediate.h: Added toInt32 and toUInt32, with separate versions for 32-bit and 64-bit.
• kjs/value.h: (KJS::JSValue::getUInt32): Call JSImmediate::toUInt32.

• kjs/internal.h: Added getInt32.
• kjs/internal.cpp: (KJS::NumberImp::getInt32): Added. (KJS::NumberImp::getUInt32): Replaced with more-optimal implementation stolen from JSValue.

• kjs/value.h: (KJS::jsNumber): Marked ALWAYS_INLINE, because this wasn't getting inlined. (KJS::JSValue::getInt32): Added. (KJS::JSValue::getUInt32): Changed to call the new JSImmediate::toUInt32 to avoid converting from float to double. (KJS::JSValue::toInt32): Made inline, separated out the slow case. (KJS::JSValue::toUInt32): Ditto.
• kjs/value.cpp: (KJS::JSCell::getInt32): Added. (KJS::JSValue::toInt32SlowCase): Renamed from toInt32. Changed to use the new getInt32. Added a faster case for in-range numbers. (KJS::JSValue::toUInt32SlowCase): Ditto. (KJS::JSValue::toUInt16): Added a faster case for in-range numbers.

• JavaScriptCore.exp: Updated for changes.

11:02 AM Changeset in webkit [26891] by kmccullo

• 2 edits in trunk/WebKitTools

• Removed a leak that was fixed.

• Scripts/run-webkit-tests:

10:48 AM Changeset in webkit [26890] by kmccullo

• 6 edits in trunk/WebKitTools

Reviewed by Darin.

• Changed the Client so that the DebuggerDocument now own the ServerConnection. This simplifies ownership and cleanup.

• Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the ServerConnection. (DebuggerClient::initWithServerName): (DebuggerClient::didFinishLoadForFrame):
• Drosera/win/DebuggerClient.h: DebuggerDocument now owns the ServerConnection.
• Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to until after we have a server which we are attached to. (Drosera::initUI): (Drosera::attach):
• Drosera/win/Drosera.h: Removed two needless pointers I forgot to take out previously.

10:43 AM Changeset in webkit [26889] by aroben

• 5 edits in trunk

Windows build fix

JavaScriptCore:

Windows build fix

Reviewed by NOBODY.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Turn off warning about implicit conversion to bool.

WebCore:

Windows build fix

Reviewed by NOBODY.

• WebCore.vcproj/WebCore.vcproj: Copy header files from platform/sql.
• page/Page.cpp: Touched to force the header files to be copied.

10:14 AM Changeset in webkit [26888] by zimmermann

• 4 edits in trunk/WebCore

Reviewed by Simon.

Move textPath related SVGChar data in it's own structure SVGCharOnPath.
Store a pointer to that datastructure inside SVGChar, instead of 4 floats & one bool.

Saves space for the common case. And allows me to add more data (another float) to support
glyph-orientation-* on textPath later on...

9:29 AM QtWebKit edited by Simon Hausmann

(diff)

9:21 AM BuildingQtOnWindows edited by Simon Hausmann

(diff)

9:01 AM Changeset in webkit [26887] by hausmann

• 2 edits in trunk/WebKitTools

When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.

8:06 AM Changeset in webkit [26886] by alp

• 6 edits in trunk/WebCore

2007-10-22 Alp Toker <​alp@atoker.com>

Reviewed by Nikolas Zimmermann.

Implement more GraphicsContextCairo stubs.

Remove a hack "to work around no current point bug" that was breaking
canvas tests.

Fix warnings.

• platform/graphics/cairo/CairoPath.h: (WebCore::CairoPath::CairoPath):
• platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::strokeRect):
• platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::isEmpty):
• platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp: (WebCore::SVGPaintServerGradient::setup):
• platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp: (WebCore::SVGPaintServerSolid::setup):

7:54 AM Changeset in webkit [26885] by hausmann

• 9 edits in trunk/WebKitTools

Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.

7:53 AM Changeset in webkit [26884] by hausmann

• 3 edits in trunk/WebCore

Fix compilation from a clean build with the database feature disabled.
JSCustomVersionChangeCallback.cpp doesn't actually need the SQL header file, just ScriptInterpreter.

6:56 AM Changeset in webkit [26883] by bdash

• 2 edits in trunk/JavaScriptCore

2007-10-22 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

• kjs/array_instance.cpp:

6:46 AM Changeset in webkit [26882] by darin

• 1 edit in trunk/LayoutTests/ChangeLog

• fast/js/kde/resources/Array.js: Added tests to cover missing value behavior (not the same as undefined values in arrays). This matches the ECMA JavaScript specification, but doesn't exactly match Firefox, because Firefox incorrectly inserts undefined values rather than missing values in array literals with extra commas.
• fast/js/kde/Array-expected.txt: Updated with results.

6:35 AM Changeset in webkit [26881] by darin

• 11 edits
  1 copy in trunk

JavaScriptCore:

Reviewed by Maciej.

• ​http://bugs.webkit.org/show_bug.cgi?id=15606 make cut-off for sparse vs. dense arrays smarter for speed with large arrays

Makes the morph test in SunSpider 26% faster, and the overall
benchmark 3% faster.

This also fixes some small problems we had with the distinction
between nonexistent and undefined values in arrays.

• kjs/array_instance.h: Tweaked formatting and naming.
• kjs/array_instance.cpp: Copied from kjs/array_object.cpp. (KJS::storageSize): Added. Computes the size of the storage given a vector length. (KJS::increasedVectorLength): Added. Implements the rule for resizing the vector. (KJS::isDenseEnoughForVector): Added. (KJS::ArrayInstance::ArrayInstance): Initialize the new fields. (KJS::ArrayInstance::~ArrayInstance): Since m_storage is now never 0, delete it. (KJS::ArrayInstance::getItem): Updated for name changes. (KJS::ArrayInstance::lengthGetter): Ditto. (KJS::ArrayInstance::inlineGetOwnPropertySlot): Added. Allows both versions of getOwnPropertySlot to share more code. (KJS::ArrayInstance::getOwnPropertySlot): Just refactored, no code change. (KJS::ArrayInstance::put): Added logic for extending the vector as long as the array is dense enough. Also keep m_numValuesInVector up to date. (KJS::ArrayInstance::deleteProperty): Added code to keep m_numValuesInVector up to date. (KJS::ArrayInstance::getPropertyNames): Fixed bug where this would omit names for array indices with undefined values. (KJS::ArrayInstance::increaseVectorLength): Renamed from resizeStorage. Also simplified to only handle getting larger. (KJS::ArrayInstance::setLength): Added code to update m_numValuesInVector, to zero out the unused part of the vector and to delete the map if it's no longer needed. (KJS::ArrayInstance::mark): Tweaked formatting. (KJS::compareByStringForQSort): Ditto. (KJS::ArrayInstance::sort): Ditto. (KJS::CompareWithCompareFunctionArguments::CompareWithCompareFunctionArguments): Ditto. (KJS::compareWithCompareFunctionForQSort): Ditto. (KJS::ArrayInstance::compactForSorting): Fixed bug where this would turn undefined values into nonexistent values in some cases.

• kjs/array_object.h: Removed MAX_ARRAY_INDEX.
• kjs/array_object.cpp: Removed ArrayInstance. Moved to a separate file.

• JavaScriptCore.pri: Added array_instance.cpp.
• JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
• kjs/AllInOneFile.cpp: Ditto.

LayoutTests:

• fast/js/kde/resources/Array.js: Added tests to cover missing value behavior (not the same as undefined values in arrays). This matches the ECMA JavaScript specification, but doesn't exactly match Firefox.
• fast/js/kde/Array-expected.txt: Updated with results.

5:56 AM Changeset in webkit [26880] by andrew

• 10 edits in trunk

JavaScriptCore:

Reviewed by Mark Rowe.

Fix for local database support after r26879
Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set

• Configurations/JavaScriptCore.xcconfig:

WebCore:

Reviewed by Mark Rowe.

Fix for local database support after r26879
Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set

• Configurations/WebCore.xcconfig:
• WebCore.pro:
• WebCore.vcproj/build-generated-files.sh:

WebKit:

Reviewed by Mark Rowe.

Fix for local database support after r26879
Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set

• Configurations/WebKit.xcconfig:

WebKitTools:

Reviewed by Mark Rowe.

Fix for local database support after r26879
Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set

• Scripts/build-webkit:

4:39 AM Changeset in webkit [26879] by hausmann

• 2 edits in trunk/JavaScriptCore

Build fix for the non-qmake builds.

4:28 AM Changeset in webkit [26878] by hausmann

• 2 edits in trunk/WebCore

Disable the database feature in the qmake build for now.

4:22 AM Changeset in webkit [26877] by hausmann

• 9 edits in trunk/WebCore

Make disabling the database feature (ENABLE_DATABASE=0) work by
placing various #ifdefs into the code and making the compilation of
some files optional.

3:41 AM Changeset in webkit [26876] by alp

• 6 edits in trunk

2007-10-22 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=15611
[GTK] Text selection behaviour different in Debug and Release builds

​http://bugs.webkit.org/show_bug.cgi?id=15578
[GTK] Text editor caret does not blink

Never allow control to reach the end of non-void functions.

Return more sensible values, or in some cases, nulls.

2:35 AM Changeset in webkit [26875] by hausmann

• 2 edits in trunk/WebCore

Implement ResourceHandle::loadResourceSynchronously using ResourceHandle and a special ResourceHandleClient. This approach has the possible danger of reentrancy.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

2:33 AM Changeset in webkit [26874] by hausmann

• 5 edits in trunk

• Do not build testkjs as an application bundle. This is

needed for run-javascriptcore-tests on OSX.

• Also, based on r26633, allow to test the WebKit/Qt port on OSX.
• Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set

as we do not have -rpath on OSX.

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

2:24 AM Changeset in webkit [26873] by hausmann

• 2 edits in trunk/WebCore

2007-10-15 Holger Hans Peter Freyther <​zecke@selfish.org>

Style fix. It is allowed to attempt to delete 0.

Signed-off-by: Lars Knoll <​lars@trolltech.com>

2:24 AM Changeset in webkit [26872] by hausmann

• 2 edits in trunk/WebCore

2007-10-15 Holger Hans Peter Freyther <​zecke@selfish.org>

Make it actually localizable....

Signed-off-by: Lars Knoll <​lars@trolltech.com>

2:24 AM Changeset in webkit [26871] by hausmann

• 2 edits in trunk/WebCore

2007-10-15 Holger Hans Peter Freyther <​zecke@selfish.org>

Adjust the code to obey the Coding Style.

Signed-off-by: Lars Knoll <​lars@trolltech.com>

2:24 AM Changeset in webkit [26870] by hausmann

• 2 edits in trunk/WebCore

2007-10-15 Holger Hans Peter Freyther <​zecke@selfish.org>

Return a non empty string in more functions.

Signed-off-by: Lars Knoll <​lars@trolltech.com>

2:24 AM Changeset in webkit [26869] by hausmann

• 3 edits in trunk/WebCore

2007-10-15 Holger Hans Peter Freyther <​zecke@selfish.org>

Shrink the TemporaryLinkStubs and move the
Frame::setNeedsReapplyStyles stub to FrameQt.cpp

Signed-off-by: Lars Knoll <​lars@trolltech.com>

2:18 AM Changeset in webkit [26868] by hausmann

• 3 edits in trunk/WebCore

2007-10-15 Holger Hans Peter Freyther <​zecke@selfish.org>

Implement the WebCore::fileSize function. The
implementation assumes that QFileInfo will cache
the result of the stat so that info.size() and
info.exists() use the same stat result.

Signed-off-by: Lars Knoll <​lars@trolltech.com>

2:15 AM Changeset in webkit [26867] by alp

• 3 edits
  1 move
  1 add in trunk/WebCore

2007-10-21 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Use the portable GLib time function.

Use event timestamps rather than the current time where available.

Rename SharedTimerLinux.cpp since it isn't Linux-specific.

• WebCore.pro:
• platform/gtk/MouseEventGtk.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
• platform/gtk/SystemTimeGtk.cpp: Added. (WebCore::currentTime):
• platform/gtk/SharedTimerGtk.cpp: Copied from platform/gtk/SharedTimerLinux.cpp.
• platform/gtk/SharedTimerLinux.cpp: Removed.

1:42 AM Changeset in webkit [26866] by hausmann

• 2 edits in trunk/WebKitTools

Fix support for Signed-off-by detection in prepare-ChangeLog
--git-commit. The Signed-off-by tag does not appear in the header
but usually at the end.

12:31 AM Changeset in webkit [26865] by hyatt

• 2 edits in trunk/WebCore

Fix for 15596, regression from my transform changes. Preserve null checks on the clip rects calls for parent(),
since the method is called on orphaned layers. This is not very well understood.

Reviewed by eric

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects):