Timeline
Dec 25, 2007:
- 11:25 PM Changeset in webkit [28990] by
-
- 9 edits in trunk/WebCore
Reviewed by Eric Seidel.
Clean up the files relating to NodeLists.
- dom/ChildNodeList.cpp: (WebCore::ChildNodeList::ChildNodeList): (WebCore::ChildNodeList::length): (WebCore::ChildNodeList::item): (WebCore::ChildNodeList::nodeMatches):
- dom/ChildNodeList.h:
- dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::itemForwardsFromCurrent): (WebCore::DynamicNodeList::itemBackwardsFromCurrent): (WebCore::DynamicNodeList::itemWithName):
- dom/DynamicNodeList.h: (WebCore::DynamicNodeList::needsNotifications):
- dom/NameNodeList.cpp: (WebCore::NameNodeList::NameNodeList): (WebCore::NameNodeList::rootNodeAttributeChanged): (WebCore::NameNodeList::nodeMatches):
- dom/NameNodeList.h:
- dom/NodeList.h:
- dom/SelectorNodeList.h:
- 10:44 PM Changeset in webkit [28989] by
-
- 4 edits in trunk/WebCore
Fix non-mac builds.
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCoreSources.bkl:
- 10:33 PM Changeset in webkit [28988] by
-
- 3 edits2 copies in trunk/WebCore
Rubber stamped by Eric Seidel.
Move TagNodeList into its own file.
- WebCore.xcodeproj/project.pbxproj:
- dom/Node.cpp:
- dom/TagNodeList.cpp: Copied from dom/Node.cpp. (WebCore::TagNodeList::TagNodeList):
- dom/TagNodeList.h: Copied from dom/Node.cpp.
- 10:18 PM Changeset in webkit [28987] by
-
- 8 edits in trunk/WebCore
Reviewed by Eric Seidel.
Simplify the NodeList architecture.
- Rename recursiveItem() to item(), since it is not recursive.
- Make recursiveLength() iterative and rename to length().
- Remove now unneeded overrides of item() and length() that used to call the recursive variants.
- dom/ClassNodeList.cpp:
- dom/ClassNodeList.h:
- dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::length): (WebCore::DynamicNodeList::item): (WebCore::DynamicNodeList::rootNodeAttributeChanged): Move implementation into the .cpp file since virtual methods can't be inlined.
- dom/DynamicNodeList.h:
- dom/NameNodeList.cpp:
- dom/NameNodeList.h:
- dom/Node.cpp:
- 6:55 PM Changeset in webkit [28986] by
-
- 4 edits in trunk/WebCore
2007-12-25 Alp Toker <alp@atoker.com>
More complete GTK+/Qt/Wx/Win build fixes for breakage introduced in
r28981.
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCoreSources.bkl:
- 6:33 PM Changeset in webkit [28985] by
-
- 2 edits in trunk/WebCore
2007-12-25 Alp Toker <alp@atoker.com>
Win build fix for breakage introduced in r28981.
- WebCore.vcproj/WebCore.vcproj:
- 6:30 PM Changeset in webkit [28984] by
-
- 2 edits in trunk/WebCore
2007-12-25 Alp Toker <alp@atoker.com>
Wx build fix for breakage introduced in r28981.
- WebCoreSources.bkl:
- 6:28 PM Changeset in webkit [28983] by
-
- 2 edits in trunk/WebCore
2007-12-25 Alp Toker <alp@atoker.com>
GTK+/Qt build fix for breakage introduced in r28981.
- WebCore.pro:
- 5:05 PM Changeset in webkit [28982] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Oliver Hunt.
- fix an assertion failure when pressing the num lock key
- WebView/WebHTMLView.mm: (-[WebHTMLView flagsChanged:]): Avoid passing key code 10 down to WebCore.
- 4:46 PM Changeset in webkit [28981] by
-
- 18 edits2 copies1 move4 adds30 deletes in trunk
WebCore:
Reviewed by Oliver.
- http://bugs.webkit.org/show_bug.cgi?id=16587 Implement the most useful part of the W3C Selectors API.
- WebCore.xcodeproj/project.pbxproj:
- css/CSSStyleSelector.h: Make Node a friend of CSSStyleSelector so it can use checkSelector()
- dom/ChildNodeList.cpp: (WebCore::ChildNodeList::ChildNodeList): Change to being a DynamicNodeList
- dom/ChildNodeList.h:
- dom/ClassNodeList.cpp: (WebCore::ClassNodeList::ClassNodeList): Change to being a DynamicNodeList
- dom/ClassNodeList.h:
- dom/Document.idl: Add the new functions
- dom/DynamicNodeList.cpp: Copied from WebCore/dom/NodeList.cpp. (WebCore::DynamicNodeList::DynamicNodeList): Rename NodeList to DynamicNodeList, to differentiate it from the new StaticNodeList (WebCore::DynamicNodeList::~DynamicNodeList): (WebCore::DynamicNodeList::recursiveLength): (WebCore::DynamicNodeList::itemForwardsFromCurrent): (WebCore::DynamicNodeList::itemBackwardsFromCurrent): (WebCore::DynamicNodeList::recursiveItem): (WebCore::DynamicNodeList::itemWithName): (WebCore::DynamicNodeList::rootNodeChildrenChanged): (WebCore::DynamicNodeList::Caches::Caches): (WebCore::DynamicNodeList::Caches::reset):
- dom/DynamicNodeList.h: Copied from WebCore/dom/NodeList.h. (WebCore::DynamicNodeList::rootNodeAttributeChanged):
- dom/Element.idl: Add the new functions
- dom/NameNodeList.cpp: Change to being a DynamicNodeList (WebCore::NameNodeList::NameNodeList):
- dom/NameNodeList.h: (WebCore::NameNodeList::rootNodeAttributeChanged):
- dom/Node.cpp: (WebCore::TagNodeList::TagNodeList): Change to being a DynamicNodeList (WebCore::Node::registerDynamicNodeList): (WebCore::Node::unregisterDynamicNodeList): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName): (WebCore::Node::querySelector): new (WebCore::Node::querySelectorAll): new
- dom/Node.h:
- dom/NodeList.cpp: Removed.
- dom/NodeList.h: This is now an abstract superclass of DynamicNodeList and StaticNodeList (WebCore::NodeList::NodeList): (WebCore::NodeList::~NodeList):
- dom/SelectorNodeList.cpp: Added. (WebCore::SelectorNodeList::SelectorNodeList): New StaticNodeList subclass that filters elements by CSS selector
- dom/SelectorNodeList.h: Added.
- dom/StaticNodeList.cpp: Added. (WebCore::StaticNodeList::length): (WebCore::StaticNodeList::item): (WebCore::StaticNodeList::itemWithName):
- dom/StaticNodeList.h: Added. (WebCore::StaticNodeList::StaticNodeList): (WebCore::StaticNodeList::~StaticNodeList):
LayoutTests:
Reviewed by Oliver.
- http://bugs.webkit.org/show_bug.cgi?id=16587 Implement the most useful part of the W3C Selectors API.
- fast/dom/SelectorAPI: Copied from LayoutTests/fast/dom/getElementsByClassName.
- fast/dom/SelectorAPI/dumpNodeList-expected.txt:
- fast/dom/SelectorAPI/dumpNodeList.html: Modified to test querySelector and querySelectorAll instead of getElementsByClassName
- fast/dom/Window/window-properties-expected.txt: Added querySelector and querySelectorAll
- 2:54 PM Changeset in webkit [28980] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Oliver.
- Remove unnecessary redundant check from property setting http://bugs.webkit.org/show_bug.cgi?id=16602
1.3% speedup on SunSpider.
- kjs/object.cpp: (KJS::JSObject::put): Don't do canPut check when not needed; let the PropertyMap handle it. (KJS::JSObject::canPut): Don't check the static property table. lookupPut does that already.
Dec 24, 2007:
- 10:55 PM Changeset in webkit [28979] by
-
- 2 edits in trunk/WebCore
Fix Bug 16596: ThreadSafeShared should be lock-free where possible.
Reviewed by Sam Weinig.
Implement a lock-free ThreadSafeShared for i386, x86_64, ppc and ppc64.
This is a 1.7x as fast as the lock-based implementation on x86 for a single-threaded use
of ThreadSafeShared but is closer to 280x as fast when there is heavy concurrent multi-threaded
access to a single ThreadSafeShared object.
The atomic operations are based on those used by the Boost C++ library's shared_ptr implementation.
- 10:00 PM Changeset in webkit [28978] by
-
- 3 edits in trunk/WebKit/gtk
2007-12-24 Christian Dywan <christian@twotoasts.de>
Reviewed by Alp Toker.
http://bugs.webkit.org/attachment.cgi?id=18099
There are no NULL checks for strings in public api
Add missing NULL checks for string parameters.
Provide sensible defaults when NULL is passed for the optional
parameters in webkit_web_view_load_string(). UTF-8 is the default
encoding used by GLib and text/html is a reasonable default content
type.
- WebView/webkitnetworkrequest.cpp:
- WebView/webkitwebview.cpp:
- 5:05 PM Changeset in webkit [28977] by
-
- 3 edits in trunk/WebCore
- platform/text/PlatformString.h: Removed now-incorrect comment. Added a comment about copy().
- platform/text/StringImpl.h: Added a comment about copy().
- 5:02 PM Changeset in webkit [28976] by
-
- 13 edits in trunk/WebCore
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=16550 make StringImpl immutable
I tried to keep the changes to a minimum. In some cases there is
room for optimization -- I didn't try to add in the "single ref count"
optimizations and there might be a tiny bit more string copying than
we had before.
- WebCore.base.exp: Updated.
- dom/CharacterData.cpp: (WebCore::CharacterData::appendData): Changed to use String since StringImpl doesn't have mutating functions any more. (WebCore::CharacterData::insertData): Ditto. (WebCore::CharacterData::deleteData): Ditto. (WebCore::CharacterData::replaceData): Ditto.
- dom/Text.cpp: (WebCore::Text::splitText): Changed to use substring instead of remove since StringImpl does't have mutating functions any more.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteInsignificantText): Changed to use String instead of StringImpl so we can use remove.
- platform/text/PlatformString.h: Removed newUninitialized. Added append that takes a character pointer and length.
- platform/text/String.cpp: (WebCore::String::insert): Added an implementation that does not rely on an underlying StringImpl function. (WebCore::String::append): Ditto. (WebCore::String::truncate): Ditto. (WebCore::String::remove): Ditto. (WebCore::String::charactersWithNullTermination): Added an implementation that uses the new StringImpl null termination feature, which does not require modifying a string.
- platform/text/StringImpl.cpp: (WebCore::isSpace): Fix comment. (WebCore::StringImpl::StringImpl): Added a new constructor that makes a string with a trailing null character. (WebCore::StringImpl::substring): Marked const. (WebCore::StringImpl::replace): Marked const; had to add quite a few const_cast. Also rewrote one of these to work without modifying the existing string.
- platform/text/StringImpl.h: Fixed a mistake where the empty string had m_hasTerminatingNullCharacter uninitialized. Added a type and constructor for creating strings that have a trailing null character. Added a hasTerminatingNullCharacter function. Removed newUninitialized, charactersWithNullTermination, append, insert, truncate, and remove. Marked lots of other functions const.
- platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::decode): Rewrote to use a Vector instead of newUninitialized.
- platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::decode): Ditto.
- platform/text/TextCodecUserDefined.cpp: (WebCore::TextCodecUserDefined::decode): Ditto.
- rendering/RenderStyle.cpp: (WebCore::RenderStyle::setContent): Changed to use String since StringImpl doesn't have mutating functions any more.
- 10:31 AM Changeset in webkit [28975] by
-
- 2 edits in trunk/JavaScriptCore
2007-12-24 Alp Toker <alp@atoker.com>
Fix builds that don't use AllInOneFile.cpp following breakage
introduced in r28973.
- kjs/grammar.y:
- 4:16 AM Changeset in webkit [28974] by
-
- 4 edits in trunk
Reviewed by Oliver.
Fix fast/events/arrow-keys-on-body.html, failing on Windows.
- DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count of 1, even though WebKit currently ignores it.
- 2:13 AM Changeset in webkit [28973] by
-
- 7 edits in trunk/JavaScriptCore
Reviewed by Eric.
- Optimize variable declarations http://bugs.webkit.org/show_bug.cgi?id=16585
3.5% speedup on SunSpider.
var statements now result in either assignments or empty statements.
This allows a couple of optimization opportunities:
- No need to branch at runtime to check if there is an initializer
- EmptyStatementNodes can be removed entirely (also done in this patch)
- Assignment expressions get properly optimized for local variables
This patch also includes some code cleanup:
- Most of the old VarStatement/VarDecl logic is now only used for const declarations, thus it is renamed appropriately
- AssignExprNode is gone
- JavaScriptCore.exp:
- kjs/NodeInfo.h:
- kjs/grammar.y:
- kjs/nodes.cpp: (KJS::SourceElements::append): (KJS::ConstDeclNode::ConstDeclNode): (KJS::ConstDeclNode::optimizeVariableAccess): (KJS::ConstDeclNode::handleSlowCase): (KJS::ConstDeclNode::evaluateSingle): (KJS::ConstDeclNode::evaluate): (KJS::ConstStatementNode::optimizeVariableAccess): (KJS::ConstStatementNode::execute): (KJS::VarStatementNode::optimizeVariableAccess): (KJS::VarStatementNode::execute): (KJS::ForInNode::ForInNode): (KJS::ForInNode::optimizeVariableAccess): (KJS::ForInNode::execute): (KJS::FunctionBodyNode::initializeSymbolTable): (KJS::ProgramNode::initializeSymbolTable): (KJS::FunctionBodyNode::processDeclarations): (KJS::ProgramNode::processDeclarations): (KJS::EvalNode::processDeclarations):
- kjs/nodes.h: (KJS::DeclarationStacks::): (KJS::StatementNode::): (KJS::ConstDeclNode::): (KJS::ConstStatementNode::): (KJS::EmptyStatementNode::): (KJS::VarStatementNode::): (KJS::ForNode::):
- kjs/nodes2string.cpp: (KJS::ConstDeclNode::streamTo): (KJS::ConstStatementNode::streamTo): (KJS::ScopeNode::streamTo): (KJS::VarStatementNode::streamTo): (KJS::ForNode::streamTo): (KJS::ForInNode::streamTo):
Dec 23, 2007:
- 10:39 PM Changeset in webkit [28972] by
-
- 5 edits in trunk/WebCore
Fix Debug and Release QTMovieWin bulds.
- WebCore.vcproj/QTMovieWin.vcproj:
- WebCore.vcproj/debug.vsprops:
- WebCore.vcproj/debug_internal.vsprops:
- WebCore.vcproj/release.vsprops: Use LibraryConfigSuffix instead of WebKitConfigSuffix for pthreadVC2. Build release import lib into \lib, not \bin.
- 7:04 PM Changeset in webkit [28971] by
-
- 5 edits in trunk/WebCore
2007-12-23 Alp Toker <alp@atoker.com>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=15382
[CAIRO] Canvas pattern support
http://bugs.webkit.org/show_bug.cgi?id=16577
Merge Cairo enhancements from Apollo project
Add support for canvas patterns.
Make Image::nativeImageForCurrentFrame() public.
Fix some typos along the way.
The globalAlpha canvas fixes are not included in this patch as
they're slightly more intrusive and may conflict conceptually with
GraphicsContext::setAlpha().
- html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern): (WebCore::CanvasPattern::~CanvasPattern): (WebCore::CanvasPattern::createPattern):
- html/CanvasPattern.h: (WebCore::CanvasPattern::platformImage):
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::applyShadow): (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::createPattern): (WebCore::CanvasRenderingContext2D::applyStrokePattern): (WebCore::CanvasRenderingContext2D::applyFillPattern):
- platform/graphics/Image.h: (WebCore::Image::nativeImageForCurrentFrame):
- 6:09 PM Changeset in webkit [28970] by
-
- 4 edits in trunk/WebCore
Remove getWxBitmap as we have nativeImageForCurrentFrame now, and don't draw a border in fillRect.
- 4:47 PM Changeset in webkit [28969] by
-
- 3 edits in trunk/WebCore
2007-12-23 Alp Toker <alp@atoker.com>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=16577
Merge Cairo enhancements from Apollo project
This patch is based on initial merging work by Brent Fulgham. Adobe's
code has been modified in a few places to better suit the existing
coding style.
Implement more clipping and drawing functions.
Save and restore the fill rule manually when clipping.
Avoid image surface creation when the image buffer has height zero.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::fillRoundedRect):
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::createFrameAtIndex):
- 3:40 PM Changeset in webkit [28968] by
-
- 4 edits in trunk/LayoutTests
- updated results (character used for controls changed in r28945)
- platform/mac/media/audio-controls-rendering-expected.txt: Regenerated.
- platform/mac/media/video-controls-rendering-expected.txt: Regenerated.
- platform/mac/media/video-display-toggle-expected.txt: Regenerated.
- 9:50 AM Changeset in webkit [28967] by
-
- 2 edits in trunk/WebKitTools
wx buildbot fix. Update libpng dl script to the latest version.
- 4:30 AM Changeset in webkit [28966] by
-
- 2 edits in trunk/WebCore
Reviewed by Mark.
Fix wrong placed ifdef - wrapping SVGDefsElement, instead of SVGDefinitionSrcElement in SVG_FONTS block.
- 2:00 AM BuildingQtOnLinux edited by
- Remove info about applying a patch that has since been landed (diff)
Dec 22, 2007:
- 6:18 PM Changeset in webkit [28965] by
-
- 4 edits in trunk/WebKit/gtk
2007-12-22 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
Use webView, web_view, etc for variable names instead of page, which
was left over from the old API.
- 3:54 PM Changeset in webkit [28964] by
-
- 4 edits in trunk
2007-12-22 Alp Toker <alp@atoker.com>
GTK+ build fix
GTK_TARGET_OTHER_APP is not available in older GTK+ versions. Pass
empty target flags for now.
Check GTK+, not GLib versions, since they are different.
- 3:12 PM Changeset in webkit [28963] by
-
- 9 edits3 adds in trunk
2007-12-22 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16311
[Gtk] Copy rich text to clipboard as text/plain and text/html.
Add copy and paste targets for WebView and implement
WebCore::PasteboardHelper.
- 1:39 PM Changeset in webkit [28962] by
-
- 6 edits4 adds in trunk
Reviewed by Oliver.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=15966 (Crash in SVGRootInlineBox::walkTextChunks() on mouse hover)
Add new isSVGRootInlineBox() function to InlineBox to be able to differentiate between RootInlineBox/SVGRootInlineBox.
SVG assumed it's root inline box (for <text> elements) is always of type SVGRootInlineBox, which is not the case
for HTML text in <foreignObject>. Text selection doesn't work so far as line box offsets are wrong - which is visible
in Web Inspector.
- 1:04 PM Changeset in webkit [28961] by
-
- 2 edits in trunk/WebKitTools
Fix a typo.
- 12:03 PM Changeset in webkit [28960] by
-
- 2 edits in trunk/WebCore
2007-12-22 Alp Toker <alp@atoker.com>
LOW_BANDWIDTH_DISPLAY build fix
Track recent KURL DeprecatedString changes.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
- 8:48 AM Changeset in webkit [28959] by
-
- 2 edits in trunk/WebCore
- Windows build fix
- WebCore.vcproj/WebCore.vcproj:
- 8:35 AM Changeset in webkit [28958] by
-
- 2 edits in trunk/WebKit/gtk
2007-12-22 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
Follow up to http://bugs.webkit.org/show_bug.cgi?id=16144
- WebView/webkitwebview.cpp: Fix signal id arguments for g_signal_emit in clipboard functions.
- 8:34 AM Changeset in webkit [28957] by
-
- 2 edits in trunk/WebCore
2007-12-22 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
Add missing return 0 to fix a compile warning.
- page/gtk/FrameGtk.cpp: (WebCore::Frame::createScriptInstanceForWidget):
Dec 21, 2007:
- 11:26 PM Changeset in webkit [28956] by
-
- 2 edits in trunk/WebKitSite
At bdash's suggestion, display a message if someone attempts to run the 'native' version of the getElementsByClassName benchmark in a browser that doesn't support that.
- blog-files/gebcnspeedtest.html:
- 11:02 PM Changeset in webkit [28955] by
-
- 1 edit2 adds in trunk/WebKitSite
Add the benchmark from the previous commit as well.
- blog-files/gebcnspeedtest.html: Added.
- blog-files/prototype-for-gebcn-test.js: Added.
- 10:45 PM Changeset in webkit [28954] by
-
- 1 edit1 add in trunk/WebKitSite
Add a graph of benchmark results for an upcoming blog post.
- blog-files/gebcnwebkitonly.png: Added.
- 10:12 PM Changeset in webkit [28953] by
-
- 4 edits in trunk
Versioning.
- 10:11 PM Changeset in webkit [28952] by
-
- 1 copy in tags/Safari-5525.2
New tag.
- 10:11 PM Changeset in webkit [28951] by
-
- 1 copy in tags/Safari-4525.2
New tag.
- 9:54 PM Changeset in webkit [28950] by
-
- 2 edits in trunk/JavaScriptCore
2007-12-21 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
- JavaScriptCore.exp: Remove unused symbol to prevent a weak external symbol being generated in JavaScriptCore.framework.
- 8:40 PM Changeset in webkit [28949] by
-
- 2 edits in trunk/WebKitLibraries
Fix http://bugs.webkit.org/show_bug.cgi?id=16549 (WebKit nightly build failing to launch on PowerPC G3s).
Rubber-stamped by Dan Bernstein.
- libWebKitSystemInterfaceTiger.a: Update to a G3-friendly version.
- 8:18 PM Changeset in webkit [28948] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Mark Rowe.
- Disable the back/forward cache using the new WebPreferences API instead of through the BackForwardList. This makes us match what we do on Windows.
- DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): (setDefaultsToConsistentValuesForTesting):
- 5:39 PM Changeset in webkit [28947] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Mark Rowe.
- disable the back/forward cache in Windows DumpRenderTree. It is already disabled in Mac DumpRenderTree.
- DumpRenderTree/win/DumpRenderTree.cpp: (initializePreferences):
- 5:09 PM Changeset in webkit [28946] by
-
- 2 edits in trunk/WebKitSite
Reviewed by Darin and Steve.
Add instructions to install the QuickTime SDK for Windows.
- 5:07 PM Changeset in webkit [28945] by
-
- 12 edits7 adds in trunk
Reviewed by Darin, Adam and Steve.
Add media playback support for Windows.
The implementation uses low level QuickTime API. DLL is
needed to work around CF use in both WebKit and QuickTime.
This makes Windows build depend on the QuickTime SDK
but not QuickTime itself.
QTMovieWinTimer contains some copy code from SharedTimerWin. It
is used in the QuickTime access DLL which can't use WebCore
SharedTimer due to dependency problems.
- 5:01 PM Changeset in webkit [28944] by
-
- 5 edits in trunk/WebCore
2007-12-21 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16558
Cairo WebCore Rendering Fails on arc drawing
Fix for bug reported (and patched) by Apollo team in which
arcs were draw in reverse (resulting in inverted images).
Review of the source found that the 'clockwise' term was
actually meant to mean 'anticlockwise' so the IDL and
supporting classes have been changed to match this.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arc):
- html/CanvasRenderingContext2D.idl:
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::addArc): (WebCore::Path::addEllipse):
- platform/graphics/Path.h:
- 4:41 PM Changeset in webkit [28943] by
-
- 2 edits in trunk/WebKit/gtk
2007-12-21 Alp Toker <alp@atoker.com>
Documentation typo fix: s/wether/whether
- WebView/webkitwebview.cpp:
- 4:36 PM Changeset in webkit [28942] by
-
- 4 edits in trunk/WebKit/gtk
2007-12-21 Christian Dywan <christian@twotoasts.de>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16144
[GTK] Clipboard/ selection handling functions
- WebView/webkitprivate.h:
- WebView/webkitwebview.cpp:
- WebView/webkitwebview.h:
- 4:35 PM Changeset in webkit [28941] by
-
- 4 edits in trunk/LayoutTests
Reviewed by Adele.
Fix another mistaken duplication, this time in cross-frame-access-parent-explicit-domain.html,
that was causing intermittent failures.
- http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:
- http/tests/security/cross-frame-access-parent-explicit-domain.html:
- http/tests/security/cross-frame-access-port-explicit-domain-expected.txt:
- 4:01 PM Changeset in webkit [28940] by
-
- 4 edits in trunk/LayoutTests
Reviewed by Dan Bernstein.
Fix mistaken duplication in cross-frame-access-child-explicit-domain.html that was causing
intermittent failures.
- http/tests/security/cross-frame-access-child-explicit-domain-expected.txt:
- http/tests/security/cross-frame-access-child-explicit-domain.html:
- http/tests/security/cross-frame-access-custom-expected.txt:
- 3:15 PM Changeset in webkit [28939] by
-
- 2 edits in trunk/WebKit/win
Implemented DOMDocument::getElementById().
Reviewed by Darin.
- DOMCoreClasses.cpp: (DOMDocument::getElementById):
- 2:02 PM Changeset in webkit [28938] by
-
- 2 edits in trunk/JavaScriptCore
Requested by Maciej.
- kjs/nodes.h: Use the new NEVER_INLINE here and eliminate the old KJS_NO_INLINE. We don't want to have two, and we figured it was better to keep the one that's in WTF.
- 1:54 PM Changeset in webkit [28937] by
-
- 12 edits in trunk/JavaScriptCore
Reviewed by Eric.
- http://bugs.webkit.org/show_bug.cgi?id=16561 remove debugger overhead from non-debugged JavaScript execution
1.022x as fast on SunSpider.
- JavaScriptCore.exp: Updated.
- kjs/NodeInfo.h: Renamed SourceElementsStub to SourceElements, since that more accurately describes the role of this object, which is a reference-counted wrapper for a Vector.
- kjs/Parser.cpp: (KJS::Parser::didFinishParsing): Changed parameter type to SourceElements, and use plain assignment instead of set.
- kjs/Parser.h: Changed parameter type of didFinishParsing to a SourceElements. Also changed m_sourceElements; we now use a RefPtr instead of an OwnPtr as well.
- kjs/grammar.y: Got rid of all the calls to release() on SourceElements. That's now handed inside the constructors for various node types, since we now use vector swapping instead.
- kjs/nodes.cpp: (KJS::Node::rethrowException): Added NEVER_INLINE, because this was getting inlined and we want exception handling out of the normal code flow. (KJS::SourceElements::append): Moved here from the header. This now handles creating a BreakpointCheckStatement for each statement in the debugger case. That way we can get breakpoint handling without having it in every execute function. (KJS::BreakpointCheckStatement::BreakpointCheckStatement): Added. (KJS::BreakpointCheckStatement::execute): Added. Contains the code that was formerly in the StatementNode::hitStatement function and the KJS_BREAKPOINT macro. (KJS::BreakpointCheckStatement::streamTo): Added. (KJS::ArgumentListNode::evaluateList): Use KJS_CHECKEXCEPTIONVOID since the return type is void. (KJS::VarStatementNode::execute): Removed KJS_BREAKPOINT. (KJS::BlockNode::BlockNode): Changed parameter type to SourceElements. Changed code to use release since the class now contains a vector rather than a vector point. (KJS::BlockNode::optimizeVariableAccess): Updated since member is now a vector rather than a vector pointer. (KJS::BlockNode::execute): Ditto. (KJS::ExprStatementNode::execute): Removed KJS_BREAKPOINT. (KJS::IfNode::execute): Ditto. (KJS::IfElseNode::execute): Ditto. (KJS::DoWhileNode::execute): Ditto. (KJS::WhileNode::execute): Ditto. (KJS::ContinueNode::execute): Ditto. (KJS::BreakNode::execute): Ditto. (KJS::ReturnNode::execute): Ditto. (KJS::WithNode::execute): Ditto. (KJS::CaseClauseNode::optimizeVariableAccess): Updated since member is now a vector rather than a vector pointer. (KJS::CaseClauseNode::executeStatements): Ditto. (KJS::SwitchNode::execute): Removed KJS_BREAKPOINT. (KJS::ThrowNode::execute): Ditto. (KJS::TryNode::execute): Ditto. (KJS::ScopeNode::ScopeNode): Changed parameter type to SourceElements. (KJS::ProgramNode::ProgramNode): Ditto. (KJS::EvalNode::EvalNode): Ditto. (KJS::FunctionBodyNode::FunctionBodyNode): Ditto. (KJS::ScopeNode::optimizeVariableAccess): Updated since member is now a vector rather than a vector pointer.
- kjs/nodes.h: Removed hitStatement. Renamed SourceElements to StatementVector. Renamed SourceElementsStub to SourceElements and made it derive from ParserRefCounted rather than from Node, hold a vector rather than a pointer to a vector, and changed the release function to swap with another vector rather than the pointer idiom. Updated BlockNode and CaseClauseNode to hold actual vectors instead of pointers to vectors. Added BreakpointCheckStatement.
- kjs/nodes2string.cpp: (KJS::statementListStreamTo): Changed to work on a vector instead of a pointer to a vector. (KJS::BlockNode::streamTo): Ditto. (KJS::CaseClauseNode::streamTo): Ditto.
- wtf/AlwaysInline.h: Added NEVER_INLINE.
- wtf/PassRefPtr.h: Tweaked formatting. Added clear() function that matches the ones in OwnPtr and auto_ptr.
- wtf/RefPtr.h: Ditto.
- 12:17 PM Changeset in webkit [28936] by
-
- 2 edits in trunk/WebKit/win
Reviewed by Steve and Darin.
<rdar://problem/5497037> Win32: Accelerator keys (ctrl-x,c,v,w,q,etc) only fire keyUp,
keyDown/Press consumed by accelerator table (14104)
<rdar://problem/5346299> preventing default behavior for key down does not block accelerators like Ctrl+N
This is WebKit part of a fix, most of which will be in Safari.
- WebView.cpp: (WebViewWndProc): Return our result for WM_(SYS)KEYDOWN to let the client know whether further procesing is desired.
- 7:36 AM Changeset in webkit [28935] by
-
- 2 edits in trunk/JavaScriptCore
- fix broken regression tests
The broken tests were fast/js/do-while-expression-value.html and
fast/js/while-expression-value.html.
- kjs/nodes.cpp: Check in the correct version of this file. I had accidentally landed an old version of my patch for bug 16471. (KJS::statementListExecute): The logic here was backwards. Have to set the value even for non-normal execution results.
- 3:00 AM Changeset in webkit [28934] by
-
- 5 edits1 add in trunk
Reviewed by Oliver.
<rdar://problem/5629995> Incorrect display of Danish characters on web site.
Test: http/tests/xmlhttprequest/response-encoding.html
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didReceiveData): Default to UTF-8 for HTML, too. It's unfortunate that we have to use different rules for main content and XHR responses, but this matches both IE and Firefox.
- 2:57 AM Changeset in webkit [28933] by
-
- 1 edit in trunk/WebKit/win/ChangeLog
Correct ChangeLog spelling.
- 2:55 AM Changeset in webkit [28932] by
-
- 2 edits in trunk/WebKit/win
Build fix: cannot use framework-style include for ProgIDMacros.h,
because the file is only created on a leter step.
- ForEachCoClass.h:
- 1:09 AM Changeset in webkit [28931] by
-
- 2 edits in trunk/WebKitTools
Buildbot fix for wx port.
