Timeline
Jan 8, 2008:
- 8:49 PM Changeset in webkit [29335] by
-
- 2 edits in trunk/WebCore
Reviewed by Brady.
Bug 16678: Unreproducible crash in KJS::JSObject::inherits() after using Web Inspector
http://bugs.webkit.org/show_bug.cgi?id=16678
Add a NULL check for controller before calling JSObjectSetPrivate.
- page/InspectorController.cpp: (WebCore::InspectorController::~InspectorController):
- 8:45 PM Changeset in webkit [29334] by
-
- 2 edits in trunk/WebCore
2008-01-08 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=15610
[GTK] Text rendering using Pango
Use Pango to render Complex path text.
- platform/graphics/gtk/FontGtk.cpp: (WebCore::utf16_to_utf8): (WebCore::convertUniCharToUTF8): (WebCore::setPangoAttributes): (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
- 8:35 PM Changeset in webkit [29333] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
<rdar://problem/5665860> With the web inspector displayed, a crash occurs
at WebCore::Frame::document() when navigating back to previous page
This fixes the crash, but the inspector was totally broken with back/forward.
So this also fixes back/forward navigation so the right main resource shows
up in the inspector.
- page/InspectorController.cpp: (WebCore::addSourceToFrame): Add some null checks for the frame when getting the textEncoding. This was the crash. (WebCore::InspectorController::addScriptResource): Create a script object only if needed, and always add it by calling addResource. (WebCore::InspectorController::didCommitLoad): Check if the loader is loading from the page cache, and clear m_mainResource. If the load is normal, then call addAndUpdateScriptResource with the main resource. (WebCore::InspectorController::identifierForInitialRequest): If the load is from the page cache and the resource is the main resource call addAndUpdateScriptResource since didCommitLoad did not do it.
- 8:15 PM Changeset in webkit [29332] by
-
- 2 edits in trunk/WebCore
2008-01-08 Alp Toker <alp@atoker.com>
Back out VIDEO by default in the GTK+ qmake build. The build bot
doesn't have the necessary libraries installed.
- WebCore.pro:
- 7:41 PM Changeset in webkit [29331] by
-
- 2 edits in trunk/WebCore
2008-01-08 Alp Toker <alp@atoker.com>
Win build fix for breakage introduced in r29328.
- WebCore.vcproj/WebCore.vcproj:
- 7:37 PM Changeset in webkit [29330] by
-
- 2 edits in trunk/WebCore
2008-01-08 Alp Toker <alp@atoker.com>
Rubber-stamped by Mark Rowe.
Enable VIDEO by default in the GTK+ qmake build.
- WebCore.pro:
- 7:13 PM Changeset in webkit [29329] by
-
- 3 edits in trunk/WebCore
2008-01-08 Alp Toker <alp@atoker.com>
GTK+ VIDEO build fix for breakage introduced in r29328.
Issue noticed by Ori_B.
- GNUmakefile.am:
- WebCore.pro:
- 5:41 PM Changeset in webkit [29328] by
-
- 5 edits2 moves2 adds in trunk
WebCore:
Reviewed by Darin.
HTMLAudioElement needs generated constructor. Otherwise video instanceof HTMLAudioElement is true which is
bit strange.
Renamed custom constructor JSHTMLAudioElementConstructor to JSAudioConstructor to avoid name clashes.
Test: media/constructors.html
- ChangeLog:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSAudioConstructor.cpp: Copied from WebCore/bindings/js/JSHTMLAudioElementConstructor.cpp. (WebCore::JSAudioConstructor::JSAudioConstructor): (WebCore::JSAudioConstructor::implementsConstruct): (WebCore::JSAudioConstructor::construct):
- bindings/js/JSAudioConstructor.h: Copied from WebCore/bindings/js/JSHTMLAudioElementConstructor.h.
- bindings/js/JSHTMLAudioElementConstructor.cpp: Removed.
- bindings/js/JSHTMLAudioElementConstructor.h: Removed.
- bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
- html/HTMLAudioElement.idl:
LayoutTests:
Reviewed by Darin.
Test that media element constructors behave consistently.
- media/constructors-expected.txt: Added.
- media/constructors.html: Added.
- 4:45 PM Changeset in webkit [29327] by
-
- 2 edits in trunk/WebCore
Reviewed by Mitz.
Don't add the applet widget to the view, that's done later by RenderApplet.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::createJavaAppletWidget):
- 4:35 PM Changeset in webkit [29326] by
-
- 1 edit1 move in trunk/LayoutTests
- fast/replaced/image-map.html: Disabled this until bug 16782 is fixed.
- 4:35 PM Changeset in webkit [29325] by
-
- 3 edits1 delete in trunk
Fix fast/dom/Window/window-properties.html on Windows
WebCore:
- bindings/scripts/CodeGeneratorJS.pm: Touch this so the bindings will rebuild on Windows now that the media elements are enabled.
LayoutTests:
Fix fast/dom/Window/window-properties.html on Windows
Windows now has the same results as other platforms.
- platform/win/fast/dom/Window/window-properties-expected.txt: Removed.
- 4:17 PM Changeset in webkit [29324] by
-
- 2 edits in trunk/LayoutTests
- remove a test from the skipped list
- platform/win/Skipped:
- 4:12 PM Changeset in webkit [29323] by
-
- 5 edits in trunk
WebCore:
Reviewed by Weinig.
Add security check for Audio constructor.
- bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
LayoutTests:
Reviewed by Weinig.
Test cross-frame access to media properties.
- http/tests/security/cross-frame-access-get-expected.txt:
- http/tests/security/cross-frame-access-get.html:
- 3:51 PM Changeset in webkit [29322] by
-
- 5 edits in trunk/WebCore
Reviewed by Adam Roben.
<rdar://problem/5676515> List of scripts and images missing when opening Web Inspector from new window (16567)
InspectorController::didLoadResourceFromMemoryCache was not being called for
resources that loaded from the memory cache that the FrameLoader's client
has already been notified about. This fix always calls the InspectorController
when loading a memory cached resource. No test possible for the Web Inspector.
- loader/DocLoader.cpp: (WebCore::DocLoader::checkCacheObjectStatus): Moved most of the logic to FrameLoader::loadedResourceFromMemoryCache so the InspectorController can always be notified.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::didTellClientAboutLoad): Renamed from didTellBridgeAboutLoad. (WebCore::FrameLoader::haveToldClientAboutLoad): Renamed from haveToldBridgeAboutLoad. (WebCore::FrameLoader::loadResourceSynchronously): Call the renamed didTellClientAboutLoad. (WebCore::FrameLoader::loadedResourceFromMemoryCache): Only takes a CachedResource now. Always call InspectorController. If the resource's sendResourceLoadCallbacks is false or didTellClientAboutLoad is true, do an early return. Otherwise call the client and call didTellClientAboutLoad. (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache): Removed, work now done in FrameLoader::loadedResourceFromMemoryCache.
- loader/FrameLoader.h: Renamed {didTell,haveTold}BridgeAboutLoad to {didTell,haveTold}ClientAboutLoad. Made loadedResourceFromMemoryCache only take a CachedResource. Renamed m_urlsBridgeKnowsAbout to m_urlsClientKnowsAbout.
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::load): Call the renamed didTellClientAboutLoad.
- 2:11 PM Changeset in webkit [29321] by
-
- 2 edits5 adds in trunk/LayoutTests
Rubber stamped by Darin.
Enable media tests on Windows.
- 1:47 PM Changeset in webkit [29320] by
-
- 5 edits in trunk/WebCore
Rubber-stamped by Sam Weinig.
- prefix all member variables in CSSStyleSelector with m_
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::setEncodedURL): (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::matchRules): (WebCore::CSSStyleSelector::matchRulesForList): (WebCore::CSSStyleSelector::initElementAndPseudoState): (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::locateSharedStyle): (WebCore::CSSStyleSelector::matchUARules): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::CSSStyleSelector::updateFont): (WebCore::CSSStyleSelector::cacheBorderAndBackground): (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSStyleSelector::checkOneSelector): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundImage): (WebCore::CSSStyleSelector::mapBackgroundSize): (WebCore::CSSStyleSelector::mapBackgroundXPosition): (WebCore::CSSStyleSelector::mapBackgroundYPosition): (WebCore::CSSStyleSelector::checkForTextSizeAdjust): (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
- css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::): (WebCore::CSSRuleData::CSSRuleData): (WebCore::CSSRuleDataList::CSSRuleDataList): (WebCore::CSSRuleDataList::append):
- css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
- rendering/RenderStyle.cpp: (WebCore::RenderStyle::isStyleAvailable):
- 1:43 PM Changeset in webkit [29319] by
-
- 2 edits in trunk/WebCore
Removed unnecessary files from Copy Bundle Resources build phase.
Reviewed by Sam.
- WebCore.xcodeproj/project.pbxproj: Files removed from build phase: DOMCoreException.idl EventException.idl MessageEvent.idl SVGAElement.idl SVGAngle.idl SVGAnimateColorElement.idl SVGAnimateElement.idl SVGAnimateTransformElement.idl SVGAnimatedAngle.idl SVGAnimatedBoolean.idl SVGAnimatedEnumeration.idl SVGAnimatedInteger.idl SVGAnimatedLength.idl SVGAnimatedLengthList.idl SVGAnimatedNumber.idl SVGAnimatedNumberList.idl SVGAnimatedPathData.idl SVGAnimatedPoints.idl SVGAnimatedPreserveAspectRatio.idl SVGAnimatedRect.idl SVGAnimatedString.idl SVGAnimatedTransformList.idl SVGAnimationElement.idl SVGCSSPropertyNames.in SVGCSSValueKeywords.in SVGCircleElement.idl SVGClipPathElement.idl SVGColor.idl SVGComponentTransferFunctionElement.idl SVGCursorElement.idl SVGDefinitionSrcElement.idl SVGDefsElement.idl SVGDescElement.idl SVGDocument.idl SVGElement.idl SVGElementInstance.idl SVGElementInstanceList.idl SVGEllipseElement.idl SVGException.idl SVGExternalResourcesRequired.idl SVGFEBlendElement.idl SVGFEColorMatrixElement.idl SVGFEComponentTransferElement.idl SVGFECompositeElement.idl SVGFEDiffuseLightingElement.idl SVGFEDisplacementMapElement.idl SVGFEDistantLightElement.idl SVGFEFloodElement.idl SVGFEFuncAElement.idl SVGFEFuncBElement.idl SVGFEFuncGElement.idl SVGFEFuncRElement.idl SVGFEGaussianBlurElement.idl SVGFEImageElement.idl SVGFEMergeElement.idl SVGFEMergeNodeElement.idl SVGFEOffsetElement.idl SVGFEPointLightElement.idl SVGFESpecularLightingElement.idl SVGFESpotLightElement.idl SVGFETileElement.idl SVGFETurbulenceElement.idl SVGFilterElement.idl SVGFilterPrimitiveStandardAttributes.idl SVGFitToViewBox.idl SVGFontElement.idl SVGFontFaceElement.idl SVGFontFaceFormatElement.idl SVGFontFaceNameElement.idl SVGFontFaceSrcElement.idl SVGFontFaceUriElement.idl SVGForeignObjectElement.idl SVGGElement.idl SVGGlyphElement.idl SVGGradientElement.idl SVGImageElement.idl SVGLangSpace.idl SVGLength.idl SVGLengthList.idl SVGLineElement.idl SVGLinearGradientElement.idl SVGLocatable.idl SVGMarkerElement.idl SVGMaskElement.idl SVGMatrix.idl SVGMetadataElement.idl SVGMissingGlyphElement.idl SVGNumber.idl SVGNumberList.idl SVGPaint.idl SVGPathElement.idl SVGPathSeg.idl SVGPathSegArcAbs.idl SVGPathSegArcRel.idl SVGPathSegClosePath.idl SVGPathSegCurvetoCubicAbs.idl SVGPathSegCurvetoCubicRel.idl SVGPathSegCurvetoCubicSmoothAbs.idl SVGPathSegCurvetoCubicSmoothRel.idl SVGPathSegCurvetoQuadraticAbs.idl SVGPathSegCurvetoQuadraticRel.idl SVGPathSegCurvetoQuadraticSmoothAbs.idl SVGPathSegCurvetoQuadraticSmoothRel.idl SVGPathSegLinetoAbs.idl SVGPathSegLinetoHorizontalAbs.idl SVGPathSegLinetoHorizontalRel.idl SVGPathSegLinetoRel.idl SVGPathSegLinetoVerticalAbs.idl SVGPathSegLinetoVerticalRel.idl SVGPathSegList.idl SVGPathSegMovetoAbs.idl SVGPathSegMovetoRel.idl SVGPatternElement.idl SVGPoint.idl SVGPointList.idl SVGPolygonElement.idl SVGPolylineElement.idl SVGPreserveAspectRatio.idl SVGRadialGradientElement.idl SVGRect.idl SVGRectElement.idl SVGRenderingIntent.idl SVGSVGElement.idl SVGScriptElement.idl SVGSetElement.idl SVGStopElement.idl SVGStringList.idl SVGStylable.idl SVGStyleElement.idl SVGSwitchElement.idl SVGSymbolElement.idl SVGTRefElement.idl SVGTSpanElement.idl SVGTests.idl SVGTextContentElement.idl SVGTextElement.idl SVGTextPathElement.idl SVGTextPositioningElement.idl SVGTitleElement.idl SVGTransform.idl SVGTransformList.idl SVGTransformable.idl SVGURIReference.idl SVGUnitTypes.idl SVGUseElement.idl SVGViewElement.idl SVGViewSpec.idl SVGZoomAndPan.idl SVGZoomEvent.idl XMLHttpRequestException.idl XPathException.idl character-sets.txt mac-encodings.txt make-charset-table.pl svgattrs.in svgtags.in xlinkattrs.in
- 1:34 PM Changeset in webkit [29318] by
-
- 2 edits in trunk/WebCore
2008-01-08 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
Support copying the selected URL to the clipboard.
- platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeURL): implemented
- 1:27 PM Changeset in webkit [29317] by
-
- 6 edits in trunk/WebCore
Renamed CharacterData::m_str to m_data
Rubber-stamped by Adam again.
No test cases added since there is no change in behavior.
- dom/CDATASection.cpp:
- dom/CharacterData.cpp: (WebCore::CharacterData::CharacterData): (WebCore::CharacterData::setData): (WebCore::CharacterData::substringData): (WebCore::CharacterData::appendData): (WebCore::CharacterData::insertData): (WebCore::CharacterData::deleteData): (WebCore::CharacterData::replaceData): (WebCore::CharacterData::nodeValue): (WebCore::CharacterData::containsOnlyWhitespace): (WebCore::CharacterData::dispatchModifiedEvent): (WebCore::CharacterData::checkCharDataOperation): (WebCore::CharacterData::dump):
- dom/CharacterData.h:
- dom/Comment.cpp:
- dom/Text.cpp: (WebCore::Text::splitText): (WebCore::Text::createRenderer): (WebCore::Text::recalcStyle):
- 12:52 PM Changeset in webkit [29316] by
-
- 3 edits in trunk/WebCore
Fix a couple of compiler warnings.
Reviewed by Mitz.
- platform/win/ThreadingWin.cpp:
- platform/win/UniscribeController.cpp: Remove unused function. (WebCore::UniscribeController::advance): Fix bogus warning about un-initialized variable.
- 12:50 PM Changeset in webkit [29315] by
-
- 5 edits in trunk
WebCore:
Reviewed by Darin.
Fix for <rdar://problem/5674667> fast/forms/slider-mouse-events.html is broken by media control checkin 29257
- rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler): After fixing a bug in EventHandler to make sure events always go to the capturing node, this bug was exposed. MouseMove and MouseUp events were going to the thumb element, but not to the slider input element. This change makes the input element the capturing node, and then the input element forwards the mouse events to the thumb element. I also added a missing call to setDefaultHandled for the mousemove event.
LayoutTests:
Reviewed by Darin.
Updated test for:
<rdar://problem/5674667> fast/forms/slider-mouse-events.html is broken by media control checkin 29257
- fast/forms/slider-mouse-events-expected.txt:
- fast/forms/slider-mouse-events.html: Now tests mousemove events too.
- 12:27 PM Changeset in webkit [29314] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam.
- rendering/RenderThemeSafari.cpp: Use the SafariTheme version number to decide whether or not to paint the media controls in RenderThemeSafari.
- 12:25 PM Changeset in webkit [29313] by
-
- 2 edits in trunk/WebCore
Fix <rdar://problem/5652740> Crash occurs at WebCore::Widget::getView() after dragging file into window that contains web page ( http://www.econocraft.com/flood_arch.htm )
Reviewed by Adele and John.
We hit this crash if the page reloads between DragController::dragUpdated
and DragController::performDrag, meaning that m_document starts pointing to
a now viewless document. This is picked up by an assertion in performDrag
which I have now replaced with an assignment given that the assertion is
invalid -- it is possible for m_document to be changed between dragUpdated
performDrag
- 11:55 AM Changeset in webkit [29312] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fixing spaces in ChangeLog.
- 11:52 AM Changeset in webkit [29311] by
-
- 3 edits2 adds in trunk
Reviewed by Darin.
<rdar://problem/5659812> CrashTracer: 462 crashes in Safari at com.apple.WebCore:
WebCore::Node::setChanged + 96
Test: fast/dom/cssTarget-crash.html
- dom/Node.cpp: (WebCore::Node::removedFromDocument): Check to see if the node being removed is currently set as the Document's cssTarget.
Ê Ê Ê Ê If it is, clear the cssTarget to prevent a hanging reference to it.
- 11:42 AM Changeset in webkit [29310] by
-
- 2 edits in trunk/WebCore
- svg/svgtags.in: Touch this again for the sake of the Windows bots.
- 11:40 AM Changeset in webkit [29309] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
Use JSRetainPtr in the Web Inspector everywhere we own a JSStringRef.
Also added some #pragma marks to help find places in the file.
- page/InspectorController.cpp: (WebCore::callSimpleFunction): Use JSRetainPtr<JSStringRef>. And return the result of JSObjectCallAsFunction. (WebCore::search): Use JSRetainPtr<JSStringRef>. (WebCore::databaseTableNames): Ditto. (WebCore::localizedStrings): Ditto. (WebCore::InspectorController::~InspectorController): Ditto. (WebCore::InspectorController::focusNode): Ditto. (WebCore::InspectorController::windowScriptObjectAvailable): Ditto. (WebCore::InspectorController::scriptObjectReady): Ditto. (WebCore::addHeaders): Ditto. (WebCore::InspectorController::addScriptResource): Ditto. (WebCore::InspectorController::removeScriptResource): Ditto. (WebCore::InspectorController::updateScriptResourceRequest): Ditto. (WebCore::InspectorController::updateScriptResourceResponse): Ditto. (WebCore::InspectorController::updateScriptResource): Ditto. (WebCore::InspectorController::addDatabaseScriptResource): Ditto. (WebCore::InspectorController::removeDatabaseScriptResource): Ditto. (WebCore::InspectorController::addScriptConsoleMessage): Ditto.
- 11:14 AM Changeset in webkit [29308] by
-
- 9 edits2 moves in trunk/WebCore
Rubber-stamped by Sam Weinig.
- rename FontDataBaseClass.{cpp,h} back to FontData.{cpp,h}
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- editing/Editor.cpp:
- platform/graphics/FontData.cpp: Copied from WebCore/platform/graphics/FontDataBaseClass.cpp.
- platform/graphics/FontData.h: Copied from WebCore/platform/graphics/FontDataBaseClass.h.
- platform/graphics/FontDataBaseClass.cpp: Removed.
- platform/graphics/FontDataBaseClass.h: Removed.
- platform/graphics/SegmentedFontData.h:
- platform/graphics/SimpleFontData.h:
- 10:51 AM Changeset in webkit [29307] by
-
- 2 edits in trunk/WebKit/win
Fix build.
- DOMCoreClasses.cpp:
- 10:32 AM Changeset in webkit [29306] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Mitz.
<rdar://problem/5667286>
plugins/createScriptableObject-before-start.html is failing due to denied cross-frame access
Use our own test plug-in instead of the Flash plug-in. The Flash plug-in tries to get the URL of the top frame
which will cause a security exception.
- platform/win/Skipped:
- plugins/createScriptableObject-before-start.html:
- 9:56 AM Changeset in webkit [29305] by
-
- 2 edits in trunk/WebCore
Fix a Wx build error.
- platform/graphics/wx/GlyphMapWx.cpp: (WebCore::GlyphPage::fill):
- 9:48 AM Changeset in webkit [29304] by
-
- 2 edits in trunk/WebCore
Fix a Qt build error.
- platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::fontDataForCharacter): (WebCore::SimpleFontData::isSegmented):
- 9:43 AM Changeset in webkit [29303] by
-
- 2 edits in trunk/WebCore
Windows build fix.
Touch config.h to force a rebuild (apparently changing preprocessor
definitions in the .vcproj doesn't force a rebuild).
- config.h:
- 9:31 AM Changeset in webkit [29302] by
-
- 2 edits in trunk/WebCore
Fix a Wx build failure.
- webcore-wx.bkl:
- 9:27 AM Changeset in webkit [29301] by
-
- 2 edits in trunk/WebCore
Fix a Qt build failure.
- WebCore.pro:
- 9:21 AM Changeset in webkit [29300] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben
- fixed <rdar://problem/5671668> REGRESSION (r28711-r28730): With caret in an empty form field, Delete menu item is enabled but shouldn't be
The enabled logic was incorrect for the Delete menu item. To fix this, I added an EditorCommandSource
parameter to the enabled functions so that they can have parallel logic to the execute functions.
- editing/EditorCommand.cpp: added EditorCommandSource parameter to isEnabled function prototype (WebCore::enabled): added unused EditorCommandSource parameter to these isEnabled functions: (WebCore::enabledAnySelection): (WebCore::enabledAnySelectionAndMark): (WebCore::enableCaretInEditableText): (WebCore::enabledCopy): (WebCore::enabledCut):
(WebCore::enabledDelete):
new function, uses logic previously used by Delete command for DOM sources; uses logic in enabledCut
for menu source
added unused EditorCommandSource parameter to these isEnabled functions:
(WebCore::enabledInEditableText):
(WebCore::enabledInRichlyEditableText):
(WebCore::enabledPaste):
(WebCore::enabledRangeInEditableText):
(WebCore::enabledRangeInRichlyEditableText):
(WebCore::enabledRedo):
(WebCore::enabledUndo):
(WebCore::CommandEntry::):
wire up new enabledDelete function as delete function for Delete command
(WebCore::Editor::Command::isEnabled):
pass EditorCommandSource parameter to isEnabled function
- 9:10 AM Changeset in webkit [29299] by
-
- 2 edits in trunk/WebCore
Visual C++ Express build fix
- WebCore.vcproj/QTMovieWin.vcproj: Explicitly link against user32.lib and advapi32.lib. VS implicitly links against these, VC++ Express doesn't.
- 8:45 AM Changeset in webkit [29298] by
-
- 2 edits in trunk/WebCore
- add bug number
- platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData):
- 7:34 AM Changeset in webkit [29297] by
-
- 2 edits in trunk/WebCore
Try to fix the Qt build.
- WebCore.pro:
- 7:07 AM Changeset in webkit [29296] by
-
- 2 edits in trunk/WebCore
Not reviewed. Try to fix Qt builds after Timothy's inspector changes.
- 5:31 AM Changeset in webkit [29295] by
-
- 3 edits in trunk/WebCore
Reviewed by Mark.
- remove duplicate definition of getElementById from HTMLDocument IDL (and ObjC bindings)
- bindings/objc/PublicDOMInterfaces.h:
- html/HTMLDocument.idl:
- 5:02 AM Changeset in webkit [29294] by
-
- 6 edits in trunk/WebCore
Renamed CharacterData::str to m_str to match coding style
Rubber-stamped by Adam.
No test cases added since there is no change in behavior.
- dom/CDATASection.cpp:
- dom/CharacterData.cpp: (WebCore::CharacterData::CharacterData): (WebCore::CharacterData::setData): (WebCore::CharacterData::substringData): (WebCore::CharacterData::appendData): (WebCore::CharacterData::insertData): (WebCore::CharacterData::deleteData): (WebCore::CharacterData::replaceData): (WebCore::CharacterData::nodeValue): (WebCore::CharacterData::containsOnlyWhitespace): (WebCore::CharacterData::dispatchModifiedEvent): (WebCore::CharacterData::checkCharDataOperation): (WebCore::CharacterData::dump):
- dom/CharacterData.h:
- dom/Comment.cpp:
- dom/Text.cpp: (WebCore::Text::splitText): (WebCore::Text::createRenderer): (WebCore::Text::recalcStyle):
- 3:33 AM Changeset in webkit [29293] by
-
- 3 edits in trunk/JavaScriptCore
Turn testIsInteger assertions into compile-time asserts and move them into HashTraits.h where possible.
Reviewed by Maciej Stachowiak.
- kjs/testkjs.cpp:
- wtf/HashTraits.h:
- 1:25 AM Changeset in webkit [29292] by
-
- 2 edits in trunk/WebCore
Set the ENABLE_SVG_FONTS flag in Windows build, now builds.
I'm not sure if it just caused the right files to regenerate,
or if there's some configuration weirdness in the non-SVG-fonts
build.
- 1:11 AM Changeset in webkit [29291] by
-
- 5 edits in trunk/WebCore
Reviewed by Brady.
- fixed <rdar://problem/5644300> Back/Forward Cache should not include pages with databases
Track whether a document has ever opened a database; if so, exclude it from b/f caching (for now)
- dom/Document.cpp: (WebCore::Document::Document):
- dom/Document.h: (WebCore::Document::setHasOpenDatabases): (WebCore::Document::hasOpenDatabases):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePage):
- storage/Database.cpp: (WebCore::Database::openDatabase):
- 12:04 AM Changeset in webkit [29290] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver Hunt.
- fix leaks seen on the build bot
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Avoid creating a CSSFontFaceSource for SVG font-face elements going into an SVGCSSFontFace because it just leaks them. Avoid adding SVG font- face elements to a CSSFontFace because it will not work as expected.
Jan 7, 2008:
- 11:32 PM Changeset in webkit [29289] by
-
- 2 edits in trunk/WebKitSite
Reviewed by Mark Rowe.
- projects/svg/status.xml: remove fixed bugs.
- 11:27 PM Changeset in webkit [29288] by
-
- 2 edits in trunk/WebKit/win
Try to fix the Windows build.
- 8:13 PM Changeset in webkit [29287] by
-
- 2 edits in trunk/WebCore
Tiger build fix.
- 8:07 PM Changeset in webkit [29286] by
-
- 6 edits in trunk
Reviewed by Steve.
Re-enable media support in Windows build.
- 7:56 PM Changeset in webkit [29285] by
-
- 2 edits3 copies1 add in trunk/WebCore
2008-01-07 Steve Falkenburg <sfalken@apple.com>
Add version resource to QTMovieWin.dll
Reviewed by Adam.
- WebCore.vcproj/PRODUCTVERSION: Copied from ../WebKit/win/WebKit.vcproj/PRODUCTVERSION.
- WebCore.vcproj/QTMovieWin.rc: Added.
- WebCore.vcproj/QTMovieWin.vcproj:
- WebCore.vcproj/VERSION: Copied from ../WebKit/win/WebKit.vcproj/VERSION.
- WebCore.vcproj/auto-version.sh: Copied from ../WebKit/win/WebKit.vcproj/auto-version.sh.
- 7:56 PM Changeset in webkit [29284] by
-
- 5 edits in tags/Safari-5525.2/WebCore
Merged r28972.
- 7:48 PM Changeset in webkit [29283] by
-
- 4 edits in trunk/WebCore
Build fix.
- platform/graphics/qt/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Added. Calls QFontDatabase::removeApplicationFont().
- platform/graphics/qt/FontCustomPlatformData.h:
- platform/graphics/qt/GlyphPageTreeNodeQt.cpp: (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData): Removed the implementation because Qt does not use the WebCore glyph cache.
- 7:38 PM Changeset in webkit [29282] by
-
- 3 edits in trunk/WebCore
Reviewed by Oliver Hunt.
- fix an assertion failure in svg/W3C-SVG-1.1/fonts-elem-03-b.svg on Tiger and multiple SVG layout test failures on Leopard.
- css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::getFontData): Avoid returning an empty SegmentedFontData.
- platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Avoid creating a font that contains no glyphs. On Leopard, ATS might create such a font given data in an unsupported format (such as SVG).
- 6:38 PM Changeset in webkit [29281] by
-
- 1 edit in tags/Safari-5525.2/WebCore/WebCore.vcproj/WebCore.make
Merged r29280.
- 6:37 PM Changeset in webkit [29280] by
-
- 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.make
Build fix.
- 6:32 PM Changeset in webkit [29279] by
-
- 3 edits in tags/Safari-5525.2/WebCore
Merged r29278.
- 6:29 PM Changeset in webkit [29278] by
-
- 3 edits in trunk/WebCore
Build fix.
- WebCore.vcproj/WebCore.sln:
- WebCore.vcproj/WebCore.submit.sln:
- 6:26 PM Changeset in webkit [29277] by
-
- 2 edits in trunk/LayoutTests
- platform/win/Skipped: removing fixed test
- 6:23 PM Changeset in webkit [29276] by
-
- 2 edits in trunk/LayoutTests
Temporary results until I fix:
<rdar://problem/5674667> fast/forms/slider-mouse-events.html is broken by media control checkin 29257
- fast/forms/slider-mouse-events-expected.txt:
- 6:20 PM Changeset in webkit [29275] by
-
- 15 edits4 adds in trunk
Fix painting of SVG <image> when the image must be scaled to retain aspect ratio
Reviewed by Niko
Also added new layout test for this bug, and corrected old expected output
- 5:53 PM Changeset in webkit [29274] by
-
- 2 edits in tags/Safari-5525.2/WebKit/win
Merge r29272.
- 5:53 PM Changeset in webkit [29273] by
-
- 2 edits in trunk/WebCore
Build fix.
- platform/graphics/qt/GlyphPageTreeNodeQt.cpp: (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData):
- 5:49 PM Changeset in webkit [29272] by
-
- 2 edits in trunk/WebKit/win
Build fix.
- WebKit.vcproj/InterfacesGenerated.vcproj:
- 5:49 PM Changeset in webkit [29271] by
-
- 2 edits in trunk/WebCore
Add missing newline.
- rendering/MediaControlElements.cpp:
- 5:37 PM Changeset in webkit [29270] by
-
- 4 edits in trunk/WebCore
2008-01-07 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Hyatt.
<rdar://problem/5673489> Safari does not render windowless plugins in an
iframe when opacity < 1.0
Plugins in transparency layers handle their own world transforms, so
only apply the horizontal/vertical transform if we are not in a
transparency layer.
- platform/graphics/GraphicsContext.h: Add a Windows-platform-only inTransparencyLayer() function
- platform/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::getWindowsContext): Use inTransparencyLayer() (WebCore::GraphicsContext::inTransparencyLayer): (WebCore::GraphicsContext::releaseWindowsContext): Use inTransparencyLayer()
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::paint): When retrieving the HDC, use the rect relative to the window. Pass m_isTransparent to get/releaseWindowsContext(). Only set the world transform if we are not in a transparency layer.
- 5:35 PM Changeset in webkit [29269] by
-
- 3 edits in trunk/WebCore
Build fix. Need to wrap these classes in #if ENABLE(VIDEO)
- rendering/MediaControlElements.cpp:
- rendering/MediaControlElements.h:
- 5:34 PM Changeset in webkit [29268] by
-
- 7 edits in trunk
Reviewed by Mark.
Enable SVG_FONTS by default.
- 5:32 PM Changeset in webkit [29267] by
-
- 2 edits in trunk/WebCore
Build fix.
- platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::SimpleFontData): (WebCore::SimpleFontData::~SimpleFontData):
- 5:30 PM Changeset in webkit [29266] by
-
- 9 edits11 adds in trunk
WebCore:
Reviewed by Sam Weinig
Fixes: http://bugs.webkit.org/show_bug.cgi?id=16523
<rdar://problem/5657447>
When a frame is created with the URL "about:blank" or "", it should
inherit its SecurityOrigin from its opener. However, once it has
decided on that SecurityOrigin, it should not change its mind.
Prior to this patch, several events could induce the frame to change
its SecurityOrigin, permitting an attacker to inject script into an
arbitrary SecurityOrigin.
This patch makes several changes:
1) Documents refuse to change from one SecurityOrigin to another
unless explicitly instructed to do so.
2) Navigating to a JavaScript URL that produces a value
preserves the current SecurityOrigin explicitly instead of
relying on the URL to preserve the origin (which fails for
about:blank URLs and SecurityOrigins with document.domain set).
Ideally, we should not preserve the URL at all. Instead, the
frame's URL should be the JavaScript URL, as in Firefox, but this
would require changes that are too risky for this patch. I'll
file this as a separate issue.
3) Various methods of navigating to JavaScript URLs were not
properly handling JavaScript that returned a value (and should
therefore replace the current document). This patch unifies
those code paths with the path that works.
There are still a handful of bugs relating to the handling of
JavaScript URLs, but I'll file those as separate issues.
Tests: http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write.html
http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url.html
http/tests/security/aboutBlank/xss-DENIED-set-opener.html
- dom/Document.cpp: (WebCore::Document::initSecurityOrigin):
- dom/Document.h: (WebCore::Document::setSecurityOrigin):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::executeIfJavaScriptURL): (WebCore::FrameLoader::begin):
- loader/FrameLoader.h:
- platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::setForURL): (WebCore::SecurityOrigin::createForFrame):
- platform/SecurityOrigin.h:
LayoutTests:
Reviewed by Sam Weinig.
Adds new LayoutTests for scripting from about:blank windows. These
windows should inherit its SecurityOrigin from its opener and should
refuse to change their origins when their opener changes exogenously
(the navigate-opener tests) or explicitly (the set-opener test).
- http/tests/security/aboutBlank: Added.
- http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Added.
- http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write.html: Added.
- http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Added.
- http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url.html: Added.
- http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Added.
- http/tests/security/aboutBlank/xss-DENIED-set-opener.html: Added.
- http/tests/security/resources/innocent-victim-with-notify.html: Added.
- http/tests/security/resources/innocent-victim.html: Added.
- http/tests/security/resources/libwrapjs.js: Added.
- http/tests/security/resources/open-window.html: Added.
- 5:21 PM Changeset in webkit [29265] by
-
- 2 edits in trunk/WebCore
Forgot to check in these changes in my last checkin.
- rendering/RenderThemeSafari.cpp:
- 5:19 PM Changeset in webkit [29264] by
-
- 3 edits in trunk/WebCore
Build fixes.
- WebCore.pro:
- platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontCache::getCachedFontData):
- 4:51 PM Changeset in webkit [29263] by
-
- 2 edits in trunk/WebKitLibraries
Update Tiger library to a G3-friendly version.
- 4:48 PM Changeset in webkit [29262] by
-
- 6 edits39 adds16 deletes in trunk/WebCore
Reviewed by John Sullivan.
<rdar://problem/5674119> Make the Web Inspector toolbar the normal size when not docked
- page/inspector/inspector.css: Changed CSS rules to have the toolbar and buttons be normal height when not docked, and small when docked. Also added some cursor properties prevent showing the text cursor over areas that are not selectable.
- page/inspector/Images: A few images added and old ones removed or renamed.
- 4:42 PM Changeset in webkit [29261] by
-
- 3 edits in trunk/WebCore
2008-01-07 Alp Toker <alp@atoker.com>
Prospective GTK+ autotools/qmake VIDEO build fix for breakage
introduced in r29257.
- GNUmakefile.am:
- WebCore.pro:
- 4:41 PM Changeset in webkit [29260] by
-
- 2 edits in tags/Safari-5525.2/WebCore
Merged r28959.
- 4:40 PM Changeset in webkit [29259] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix reviwer of my last commit. It was the other Mark after all.
- 4:37 PM Changeset in webkit [29258] by
-
- 7 edits in trunk/WebCore
Reviewed by Mark.
Build fix affecting all builds - again related to the unicode-range addition.
Note: There is still a crasher (svg/W3C-SVG-1.1/fonts-elem-03-b.svg) that Dan is about to fix.
- 4:28 PM Changeset in webkit [29257] by
-
- 42 edits2 adds in trunk
WebCore:
Reviewed by Antti, Adam, and Mitz.
WebCore part of fix for
<rdar://problem/5619073> Updated look for <video> controls
<rdar://problem/5619057> Add volume control to video controls
- WebCore.base.exp: Added symbols for WebKitSystemInterface drawing methods.
- WebCore.xcodeproj/project.pbxproj: Added MediaControlElements.h/cpp
- WebCore.vcproj/WebCore.vcproj: ditto.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added cases for new appearances.
- css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added cases for new types.
- css/CSSSelector.h: (WebCore::CSSSelector::): Added new pseudo elements.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): ditto.
- css/CSSValueKeywords.in: Added keywords for new control appearance styles.
- css/html4.css: Added new styles for new controls.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::canPlay): Added. Takes loading state into account.
- html/HTMLMediaElement.h:
- page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode): Make sure the events always go to the capturing node, if there is one.
- platform/mac/WebCoreSystemInterface.h: Added drawing methods for controls.
- platform/mac/WebCoreSystemInterface.mm: ditto.
- rendering/MediaControlElements.cpp: Added. (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement): Moved from RenderMedia. Made this relatively positioned, instead of absolute. (WebCore::MediaControlInputElement::MediaControlInputElement): Moved from RenderMedia. Removed call to updateFromElement, since its too early to do this here, and causes crashes for the slider. (WebCore::MediaControlInputElement::attachToParent): Moved from RenderMedia. (WebCore::MediaControlInputElement::update): ditto. (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): Added. (WebCore::MediaControlMuteButtonElement::defaultEventHandler): ditto. (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): Moved from RenderMedia. (WebCore::MediaControlPlayButtonElement::defaultEventHandler): ditto. (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): Added. (WebCore::MediaControlSeekButtonElement::defaultEventHandler): ditto. (WebCore::MediaControlSeekButtonElement::seekTimerFired): ditto. (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Moved from RenderMedia. (WebCore::MediaControlTimelineElement::defaultEventHandler): ditto. (WebCore::MediaControlTimelineElement::update): ditto. (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): Added. (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): ditto.
- rendering/MediaControlElements.h: Added. Moved from RenderMedia. (WebCore::MediaControlShadowRootElement::isShadowNode): (WebCore::MediaControlShadowRootElement::shadowParentNode): (WebCore::RenderMediaControlShadowRoot::RenderMediaControlShadowRoot): (WebCore::RenderMediaControlShadowRoot::setParent):
- rendering/RenderMedia.cpp: Moved control element classes to MediaControlElements files. (WebCore::RenderMedia::RenderMedia): No need to initialize RefPtrs. (WebCore::RenderMedia::layout): Set the position for the controlsRenderer. (WebCore::RenderMedia::createPanel): Added nil check for the renderer. (WebCore::RenderMedia::createMuteButton): Added. (WebCore::RenderMedia::createSeekBackButton): ditto. (WebCore::RenderMedia::createSeekForwardButton): ditto. (WebCore::RenderMedia::createTimeDisplay): Added nil check for the renderer. (WebCore::RenderMedia::createFullscreenButton): Added. (WebCore::RenderMedia::updateControls): Create, delete, and update new controls when appropriate. (WebCore::RenderMedia::updateControlVisibility): Don't fade controls for audio controls. (WebCore::RenderMedia::forwardEvent): Forward events for new controls.
- rendering/RenderMedia.h: Added new methods for creating new controls.
- rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock): Updated special case for media elements, which are replaced elements, but also can contain children (the controls' container) that may need to look for the containing block.
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::createThumbStyle): Added case for MediaSliderAppearance.
- rendering/RenderStyle.h: Added appearance constants and pseudo ids for new controls. (WebCore::): (WebCore::RenderStyle::):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): Added cases for new appearances. (WebCore::RenderTheme::paint): ditto.
- rendering/RenderTheme.h: Added new methods for painting new appearances. (WebCore::RenderTheme::paintMediaBackground): (WebCore::RenderTheme::paintMediaFullscreenButton): (WebCore::RenderTheme::paintMediaPlayButton): (WebCore::RenderTheme::paintMediaMuteButton): (WebCore::RenderTheme::paintMediaSeekBackButton): (WebCore::RenderTheme::paintMediaSeekForwardButton): (WebCore::RenderTheme::paintMediaSliderThumb):
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::RenderThemeMac): Initialize m_mediaControlBackgroundImage. (WebCore::RenderThemeMac::~RenderThemeMac): Delete m_mediaControlBackgroundImage. (WebCore::RenderThemeMac::paintCapsLockIndicator): Use LocalCurrentGraphicsContext here too, since we use it in all other painting methods. (WebCore::RenderThemeMac::paintSliderTrack): Added case for MediaSliderAppearance. (WebCore::RenderThemeMac::adjustSliderThumbSize): Added case for MediaSliderThumbAppearance. (WebCore::RenderThemeMac::paintMediaBackground): Draws the new artwork for the controls. (WebCore::RenderThemeMac::paintMediaFullscreenButton): ditto. (WebCore::RenderThemeMac::paintMediaMuteButton): ditto. (WebCore::RenderThemeMac::paintMediaPlayButton): ditto. (WebCore::RenderThemeMac::paintMediaSeekBackButton): ditto. (WebCore::RenderThemeMac::paintMediaSeekForwardButton): ditto. (WebCore::RenderThemeMac::paintMediaSliderThumb): ditto.
- rendering/RenderThemeSafari.cpp: Draws the new artwork on Windows. (WebCore::RenderThemeSafari::paintSliderTrack): (WebCore::RenderThemeSafari::adjustSliderThumbSize): (WebCore::RenderThemeSafari::paintMediaBackground): (WebCore::RenderThemeSafari::paintMediaFullscreenButton): (WebCore::RenderThemeSafari::paintMediaMuteButton): (WebCore::RenderThemeSafari::paintMediaPlayButton): (WebCore::RenderThemeSafari::paintMediaSeekBackButton): (WebCore::RenderThemeSafari::paintMediaSeekForwardButton): (WebCore::RenderThemeSafari::paintMediaSliderThumb):
- rendering/RenderThemeSafari.h:
WebKit/mac:
Reviewed by Antti, Adam, and Mitz.
WebKit part of fix for
<rdar://problem/5619073> Updated look for <video> controls
<rdar://problem/5619057> Add volume control to video controls
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
WebKitLibraries:
Reviewed by Antti, Adam, and Mitz.
WebKitLibraries part of fix for
<rdar://problem/5619073> Updated look for <video> controls
<rdar://problem/5619057> Add volume control to video controls
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
LayoutTests:
Reviewed by Antti, Adam, and Mitz.
Updated results for:
<rdar://problem/5619073> Updated look for <video> controls
<rdar://problem/5619057> Add volume control to video controls
- platform/mac/media/audio-controls-rendering-expected.checksum:
- platform/mac/media/audio-controls-rendering-expected.png:
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/video-controls-rendering-expected.checksum:
- platform/mac/media/video-controls-rendering-expected.png:
- platform/mac/media/video-controls-rendering-expected.txt:
- platform/mac/media/video-display-toggle-expected.checksum:
- platform/mac/media/video-display-toggle-expected.png:
- platform/mac/media/video-display-toggle-expected.txt:
- 4:12 PM Changeset in webkit [29256] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
Fix ASSERTION FAILED: dstOffset + srcSegmentLength == static_cast<int>(data.size())
when the replacment string is a different length.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::replace): Move the parenthesis to be around only the subtraction in the Vector size calculation, correcting the order of math operations.
- 4:04 PM Changeset in webkit [29255] by
-
- 2 edits in trunk/WebCore
Reviewed by Eric. Hopefully fix build with mac tiger after the unicode-range addition. NSInteger not available there.
- 4:03 PM Changeset in webkit [29254] by
-
- 2 edits1 add in trunk/LayoutTests
Reviewed by Sam.
checking in platform-specific results. addresses <rdar://5137719>
- platform/win/Skipped:
- platform/win/fast/dom/Window/window-screen-properties-expected.txt: Added.
- 3:54 PM Changeset in webkit [29253] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver. Fix build error introduced by Dan's unicode-range support patch & enabling SVG_FONTS by default.
- 3:46 PM Changeset in webkit [29252] by
-
- 4 edits in trunk/WebCore
Not reviewed. Next try to fix wx/mac leopard build.
- 3:36 PM Changeset in webkit [29251] by
-
- 4 edits in trunk/LayoutTests
Reviewed by Adele.
- <rdar://problem/5667022> fast/events/mousemove-after-drag-over-scrollbar.html failing (missing a mousemove event)
- Updated test to reflect it's original intention and filed a different bug about the issue that caused the test to fail on Windows.
- fast/events/mousemove-after-drag-over-scrollbar-expected.txt:
- fast/events/mousemove-after-drag-over-scrollbar.html:
- platform/win/Skipped:
- 3:32 PM Changeset in webkit [29250] by
-
- 65 edits7 moves8 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- <rdar://problem/5665216> Support the unicode-range property in @font-face rules
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/objc/DOM.mm:
- bridge/mac/WebCoreAXObject.mm:
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSFontFace.cpp: (WebCore::CSSFontFace::fontLoaded): Changed to call the owning segmented font face. (WebCore::CSSFontFace::getFontData):
- css/CSSFontFace.h: (WebCore::CSSFontFace::CSSFontFace): (WebCore::CSSFontFace::setSegmentedFontFace):
- css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::pruneTable): Removed the calls to GlyphPageTreeNode::pruneTreeCustomFontData because the fonts in the font table are not exposed in the glyph page tree. Only the segmented font is, and that is taken care of by the segmented font face. (WebCore::CSSFontFaceSource::getFontData):
- css/CSSFontFaceSource.h:
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Changed to collect @font-face rules with the same family and traits into a single segmented font face, instead of just retaining the most recent one. (WebCore::CSSFontSelector::fontLoaded): (WebCore::CSSFontSelector::getFontData):
- css/CSSFontSelector.h:
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFontFaceUnicodeRange): Added. Parses a unicode range value.
- css/CSSParser.h:
- css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::):
- css/CSSPropertyNames.in:
- css/CSSSegmentedFontFace.cpp: Added. (WebCore::CSSSegmentedFontFace::CSSSegmentedFontFace): (WebCore::CSSSegmentedFontFace::~CSSSegmentedFontFace): (WebCore::CSSSegmentedFontFace::pruneTable): (WebCore::CSSSegmentedFontFace::isLoaded): (WebCore::CSSSegmentedFontFace::isValid): (WebCore::CSSSegmentedFontFace::fontLoaded): (WebCore::CSSSegmentedFontFace::overlayRange): (WebCore::CSSSegmentedFontFace::getFontData):
- css/CSSSegmentedFontFace.h: Added. (WebCore::FontFaceRange::FontFaceRange): (WebCore::FontFaceRange::from): (WebCore::FontFaceRange::to): (WebCore::FontFaceRange::fontFace): (WebCore::CSSSegmentedFontFace::fontSelector):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- css/CSSUnicodeRangeValue.cpp: Added. (WebCore::CSSUnicodeRangeValue::~CSSUnicodeRangeValue): (WebCore::CSSUnicodeRangeValue::cssText):
- css/CSSUnicodeRangeValue.h: Added. (WebCore::CSSUnicodeRangeValue::CSSUnicodeRangeValue): (WebCore::CSSUnicodeRangeValue::from): (WebCore::CSSUnicodeRangeValue::to):
- css/SVGCSSFontFace.cpp: (WebCore::SVGCSSFontFace::getFontData):
- css/SVGCSSFontFace.h:
- editing/Editor.cpp: (WebCore::Editor::fontForSelection):
- editing/Editor.h:
- page/mac/FrameMac.mm:
- page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge fontForSelection:]):
- platform/graphics/Font.cpp: (WebCore::WidthIterator::advance): (WebCore::Font::glyphDataForCharacter): (WebCore::Font::primaryFont): Changed to return the simple font data used for the space character. (WebCore::Font::fontDataAt): (WebCore::Font::fontDataForCharacters): (WebCore::Font::drawGlyphBuffer):
- platform/graphics/Font.h:
- platform/graphics/FontCache.cpp: (WebCore::FontCache::getCachedFontData): (WebCore::FontCache::getFontData):
- platform/graphics/FontCache.h:
- platform/graphics/FontData.cpp: Renamed to SimpleFontData.cpp
- platform/graphics/FontData.h: Renamed to SimpleFontData.cpp.
- platform/graphics/FontDataBaseClass.cpp: Added. This will be renamed FontData.cpp. (WebCore::FontData::~FontData):
- platform/graphics/FontDataBaseClass.h: Added. This will be renamed FontData.h.
- platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::determinePitch): (WebCore::FontFallbackList::fontDataAt): (WebCore::FontFallbackList::fontDataForCharacters):
- platform/graphics/FontFallbackList.h: (WebCore::FontFallbackList::primaryFont):
- platform/graphics/FontSelector.h:
- platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::fontDataAt): (WebCore::GlyphBuffer::swap): (WebCore::GlyphBuffer::add):
- platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData): (WebCore::GlyphPageTreeNode::initializePage): Added code to initialize pages for segmented font data. (WebCore::GlyphPageTreeNode::getChild): (WebCore::GlyphPageTreeNode::pruneCustomFontData):
- platform/graphics/GlyphPageTreeNode.h: (WebCore::GlyphPage::setGlyphDataForCharacter): (WebCore::GlyphPage::setGlyphDataForIndex): (WebCore::GlyphPageTreeNode::getRootChild):
- platform/graphics/SegmentedFontData.cpp: Added. (WebCore::SegmentedFontData::~SegmentedFontData): (WebCore::SegmentedFontData::fontDataForCharacter): (WebCore::SegmentedFontData::containsCharacters): (WebCore::SegmentedFontData::isCustomFont): (WebCore::SegmentedFontData::isLoading): (WebCore::SegmentedFontData::isSegmented):
- platform/graphics/SegmentedFontData.h: Added. (WebCore::FontDataRange::FontDataRange): (WebCore::FontDataRange::from): (WebCore::FontDataRange::to): (WebCore::FontDataRange::fontData): (WebCore::SegmentedFontData::appendRange): (WebCore::SegmentedFontData::numRanges): (WebCore::SegmentedFontData::rangeAt):
- platform/graphics/SimpleFontData.cpp: Copied from WebCore/platform/graphics/FontData.cpp. (WebCore::SimpleFontData::SimpleFontData): (WebCore::SimpleFontData::~SimpleFontData): (WebCore::SimpleFontData::ascent): (WebCore::SimpleFontData::descent): (WebCore::SimpleFontData::widthForGlyph): (WebCore::SimpleFontData::fontDataForCharacter): (WebCore::SimpleFontData::isSegmented):
- platform/graphics/SimpleFontData.h: Copied from WebCore/platform/graphics/FontData.h. (WebCore::SimpleFontData::isCustomFont): (WebCore::SimpleFontData::isLoading):
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setPlatformFont):
- platform/graphics/gtk/FontCacheGtk.cpp: (WebCore::FontCache::getFontDataForCharacters):
- platform/graphics/gtk/FontDataGtk.cpp: Renamed to SimpleFontDataGtk.cpp.
- platform/graphics/gtk/FontGtk.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp: (WebCore::GlyphPage::fill):
- platform/graphics/gtk/SimpleFontDataGtk.cpp: Copied from WebCore/platform/graphics/gtk/FontDataGtk.cpp. (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph): (WebCore::SimpleFontData::setFont):
- platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters):
- platform/graphics/mac/FontDataMac.mm: Renamed to SimpleFontDataMac.mm.
- platform/graphics/mac/FontMac.mm: (WebCore::initializeATSUStyle): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::drawGlyphs):
- platform/graphics/mac/GlyphPageTreeNodeMac.cpp: (WebCore::GlyphPage::fill):
- platform/graphics/mac/SimpleFontDataMac.mm: Copied from WebCore/platform/graphics/mac/FontDataMac.mm. (WebCore::initFontData): (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph): (WebCore::SimpleFontData::checkShapesArabic):
- platform/graphics/qt/FontDataQt.cpp: Renamed to SimpleFontDataQt.cpp.
- platform/graphics/qt/GlyphPageTreeNodeQt.cpp: (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData):
- platform/graphics/qt/SimpleFontDataQt.cpp: Copied from WebCore/platform/graphics/qt/FontDataQt.cpp.
- platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getFontDataForCharacters):
- platform/graphics/win/FontDataWin.cpp: Renamed to SimpleFontDataWin.cpp.
- platform/graphics/win/FontWin.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/win/GlyphPageTreeNodeWin.cpp: (WebCore::GlyphPage::fill):
- platform/graphics/win/SimpleFontDataWin.cpp: Copied from WebCore/platform/graphics/win/FontDataWin.cpp. (WebCore::SimpleFontData::setShouldApplyMacAscentHack): (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph): (WebCore::SimpleFontData::scriptFontProperties):
- platform/graphics/wx/FontCacheWx.cpp: (WebCore::FontCache::getFontDataForCharacters):
- platform/graphics/wx/FontDataWx.cpp: Renamed to SimpleFontDataWx.cpp.
- platform/graphics/wx/FontWx.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/wx/GlyphMapWx.cpp: (WebCore::GlyphPage::fill):
- platform/graphics/wx/SimpleFontDataWx.cpp: Copied from WebCore/platform/graphics/wx/FontDataWx.cpp. (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph):
- platform/mac/FileChooserMac.mm:
- platform/mac/PopupMenuMac.mm:
- platform/mac/WebCoreTextRenderer.mm:
- platform/win/PopupMenuWin.cpp:
- platform/win/UniscribeController.cpp: (WebCore::UniscribeController::advance): (WebCore::UniscribeController::itemizeShapeAndPlace): (WebCore::UniscribeController::shapeAndPlaceItem): (WebCore::UniscribeController::shape):
- platform/win/UniscribeController.h:
- svg/SVGFont.cpp: (WebCore::Font::drawGlyphsWithSVGFont):
- svg/SVGFontElement.cpp: (WebCore::SVGFontElement::collectGlyphs):
- svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::createFontData):
- svg/SVGFontFaceElement.h:
- svg/SVGGlyphElement.cpp:
WebKit/mac:
Reviewed by Dave Hyatt.
- <rdar://problem/5665216> Support the unicode-range property in @font-face rules
- Misc/WebNSAttributedStringExtras.mm:
WebKit/win:
Reviewed by Dave Hyatt.
- <rdar://problem/5665216> Support the unicode-range property in @font-face rules
- WebView.cpp: (WebView::setShouldApplyMacFontAscentHack):
- 3:15 PM Changeset in webkit [29249] by
-
- 2 edits in trunk/WebCore
Not reviewed. Try to fix mac build by forcing SVGNames regeneration.
- 3:10 PM Changeset in webkit [29248] by
-
- 2 edits in trunk/WebCore
Not reviewed. Proposed build fix for wx.
- 3:03 PM Changeset in webkit [29247] by
-
- 2 edits in trunk/WebCore
64-bit build fix
- platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData): Have to use a cast here since FMGetFontFromATSFontRef() is not available on 64-bit.
- 2:56 PM Changeset in webkit [29246] by
-
- 187 edits1 add in trunk
Reviewed by Oliver. Parts reviewed by Eric, David Hyatt & Dan & Alexey.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=15741 (REGRESSION: svg/W3C-SVG-1.1/fonts-elem-03-b.svg shows worse behavior on TOT)
Display SVG Fonts, fill svg/SVGFont.cpp with life by adding all needed code to
measure & render glyphs contained in SVG Fonts, including ligature lookup support.
Fixes dozens of testcases, see ChangeLog for details.
- 2:10 PM Changeset in webkit [29245] by
-
- 6 edits1 delete in trunk/JavaScriptCore
Rubber stamped by David Kilzer.
- get rid of empty fpconst.cpp
- GNUmakefile.am: Remove fpconst.cpp.
- JavaScriptCore.pri: Ditto.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
- JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
- JavaScriptCoreSources.bkl: Ditto.
- kjs/fpconst.cpp: Removed.
- 2:01 PM Changeset in webkit [29244] by
-
- 4 edits271 moves63 adds12 deletes in trunk/LayoutTests
Rubberstamped by Oliver.
Fix all SVG layout tests now that DRT works again reliable for SVG pixel tests.
Move all *-expected.txt files into platform/mac (as most contain text, and other measured values)
Leave only -expected.txt files there which dump as text.
- 1:50 PM Changeset in webkit [29243] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by David Kilzer.
- fix alignment problem with NaN and Inf globals
- kjs/fpconst.cpp: Move the contents of this file from here back to value.cpp. The reason this was in a separate file is that the DARWIN version of this used a declaration of the globals with a different type to avoid creating "init routines". That's no longer necessary for DARWIN and was never necessary for the non-DARWIN code path. To make this patch easy to merge, I didn't actually delete this file yet. We'll do that in a separate changeset.
- kjs/value.cpp: If C99's NAN and INFINITY are present, then use them, othrewise use the union trick from fpconst.cpp. I think it would be better to eliminate KJS::NaN and KJS::Inf and just use NAN and INFINITY directly or std::numeric_limits<double>::quiet_nan() and std::numeric_limits<double>::infinity(). But when I tried that, it slowed down SunSpider. Someone else could do that cleanup if they could do it without slowing down the engine.
- 1:46 PM Changeset in webkit [29242] by
-
- 2 edits in trunk/LayoutTests
- Updated to run a test whose failure was only a build bot state issue.
- platform/win/Skipped:
- 1:15 PM Changeset in webkit [29241] by
-
- 3 edits in trunk/WebCore
Fix for bug 13095, CSS3 multiple backgrounds don't work on table cells.
Reviewed by Dan
- rendering/RenderBox.h:
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell):
- 12:50 PM Changeset in webkit [29240] by
-
- 2 edits in trunk/LayoutTests
- platform/win/Skipped: Skip the culprit, not the victim.
- 12:43 PM Changeset in webkit [29239] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added JavaScript.h to the project.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Copy JavaScript.h to WEBKITOUTPUTDIR.
- 12:37 PM Changeset in webkit [29238] by
-
- 9 edits in trunk/JavaScriptCore
Reviewed by Darin.
Fix Mac build.
- API/JSNode.c:
- API/JSNode.h:
- API/JSNodeList.c:
- API/JSNodeList.h:
- API/JavaScript.h:
- API/JavaScriptCore.h:
- API/minidom.c:
- JavaScriptCore.xcodeproj/project.pbxproj:
- 12:22 PM Changeset in webkit [29237] by
-
- 2 edits in trunk/LayoutTests
- platform/win/Skipped: Added a few more failures.
- 12:02 PM Changeset in webkit [29236] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove a now incorrect Windows-specific result
This should have been done as part of r29187
- platform/win/fast/dom/wrapper-classes-expected.txt: Removed.
- 11:58 AM Changeset in webkit [29235] by
-
- 2 edits in trunk/WebKitTools
Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
DRT doesn't handle platform specific pixel test results correctly.
<test>-expected.txt files and <test>-expected.png files may now live
in different directories (ie. a cross-platform <test>-expected.txt file
and a platform-specific <test>-expected.png file).
- 11:30 AM Changeset in webkit [29234] by
-
- 6 edits2 adds in trunk/JavaScriptCore
2008-01-07 Alp Toker <alp@atoker.com>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16029
JavaScriptCore.h is not suitable for platforms other than Mac OS X
Introduce a new JavaScriptCore/JavaScript.h public API header. This
should be used by all new portable code using the JavaScriptCore API.
JavaScriptCore/JavaScriptCore.h will remain for compatibility with
existing applications that depend on it including JSStringRefCF.h
which isn't portable.
Also add minidom to the GTK+/autotools build since we can now support
it on all platforms.
- API/JSNode.h:
- API/JSNodeList.h:
- API/JavaScript.h: Added.
- API/JavaScriptCore.h:
- ForwardingHeaders/JavaScriptCore/JavaScript.h: Added.
- GNUmakefile.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- 11:16 AM Changeset in webkit [29233] by
-
- 2 edits in trunk/WebCore
- Fix indention
- 11:15 AM Changeset in webkit [29232] by
-
- 2 edits in trunk/WebCore
- The ContextMenuController is going to live longer than the ContextMenu. It is going to live as long as the WebCore::Page is around where the ContextMenu, specially in the case of a SubMenu, is gone before we popup the menu.
- 11:15 AM Changeset in webkit [29231] by
-
- 3 edits in trunk/WebCore
- Fix SubMenu handling
- Do not connect to the activated signal if we are a separator or submenu
- Change our type from ActionType to SubMenuType when we have a submenu
- Initialize the SubMenu
- 11:14 AM Changeset in webkit [29230] by
-
- 9 edits in trunk
- Qt and Gtk must know if a ContextMenuItem is checkable. Add a new ContextMenuItemType for checkable actions.
- Use this information in the Gtk platform to create a GtkCheckMenuItem when needed.
- Update the ContextMenuController to accept CheckableActionTypes as well.
- Change ContextMenu.cpp to use the CheckableActionType. The information if a item is checkable was extracted from ContextMenu::checkOrEnableIfNeeded.
- Update the Qt and Windows port.
- 10:04 AM Changeset in webkit [29229] by
-
- 4 edits in trunk
WebKitTools:
Reviewed by Darin.
- <rdar://problem/5666914> fast/regex/test{1,4}.html are failing DRT did not correctly handle printing the '\0' char. Now it does.
- DumpRenderTree/win/DumpRenderTree.cpp: (dumpFramesAsText): (dump):
LayoutTests:
Reviewed by Darin.
- <rdar://problem/5666914> fast/regex/test{1,4}.html are failing. Since they pass now, the two tests are removed from the Skipped list.
- platform/win/Skipped:
- 8:23 AM Changeset in webkit [29228] by
-
- 2 edits in trunk/WebCore
2008-01-07 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16745
[GTK] Context menu doesn't feel or look native - no icons
Use GTK+ stock icons for menu items where possible.
- platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction): (WebCore::ContextMenuItem::createNativeMenuItem): (WebCore::ContextMenuItem::setAction):
- 7:16 AM Changeset in webkit [29227] by
-
- 3 edits in trunk/WebCore
Reviewed by John Sullivan.
- make the ATSUI code path work with custom fonts rather than crash
- platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/mac/FontMac.mm: (WebCore::initializeATSUStyle):
- 5:29 AM Changeset in webkit [29226] by
-
- 2 edits in trunk/WebKit/qt
Build fix for the Windows build. MSVC wants to see the full
declaration of arguments even when just passing them through.
- 3:38 AM Changeset in webkit [29225] by
-
- 5 edits in trunk/WebKit/qt
Added the missing parameters to make it possible to do POST operations from the public API.
This is ugly though as it also requires including qnetworkaccessmanager.h. It would be nicer if the
two extra arguments were in QNetworkRequest :-/
Signed-off-by: Lars
- 3:36 AM Changeset in webkit [29224] by
-
- 2 edits in trunk/WebCore
abort() now emits the signals, so disconnect them before you abort()
Signed-off-by: Simon
- 3:36 AM Changeset in webkit [29223] by
-
- 2 edits in trunk/WebCore
Use a faster and safer way of flattening the form data.
Signed-off-by: Lars
- 3:35 AM Changeset in webkit [29222] by
-
- 28 edits3 adds in trunk
Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
Signed-off-by: Lars
- 2:46 AM Changeset in webkit [29221] by
-
- 2 edits in trunk/WebCore
- Remove m_dirtyRegion as it is not used as we pass every dirty region directly to the ChromeClient
Signed-off-by: Lars
- 2:46 AM Changeset in webkit [29220] by
-
- 2 edits in trunk/WebKit/qt
- Move the QWebPagePrivate methods up to the other private ones
Signed-off-by: Simon
- 2:46 AM Changeset in webkit [29219] by
-
- 3 edits in trunk/WebKit/qt
- Add reimplemented comments for the methods reimplemented in QWebView and QWebPage.
Signed-off-by: Simon
- 2:45 AM Changeset in webkit [29218] by
-
- 2 edits in trunk/WebKit/qt
- This layout is not needed anymore as Widget::invalidateRect will not draw anymore.
Signed-off-by: Lars
Jan 6, 2008:
- 10:06 PM Changeset in webkit [29217] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Sam.
Abstract all DateObject.set* functions in preparation for fixing:
http://bugs.webkit.org/show_bug.cgi?id=16753
SunSpider had random changes here and there but was overall a wash.
- kjs/date_object.cpp: (KJS::fillStructuresUsingTimeArgs): (KJS::setNewValueFromTimeArgs): (KJS::setNewValueFromDateArgs): (KJS::DateProtoFuncSetMilliSeconds::callAsFunction): (KJS::DateProtoFuncSetUTCMilliseconds::callAsFunction): (KJS::DateProtoFuncSetSeconds::callAsFunction): (KJS::DateProtoFuncSetUTCSeconds::callAsFunction): (KJS::DateProtoFuncSetMinutes::callAsFunction): (KJS::DateProtoFuncSetUTCMinutes::callAsFunction): (KJS::DateProtoFuncSetHours::callAsFunction): (KJS::DateProtoFuncSetUTCHours::callAsFunction): (KJS::DateProtoFuncSetDate::callAsFunction): (KJS::DateProtoFuncSetUTCDate::callAsFunction): (KJS::DateProtoFuncSetMonth::callAsFunction): (KJS::DateProtoFuncSetUTCMonth::callAsFunction): (KJS::DateProtoFuncSetFullYear::callAsFunction): (KJS::DateProtoFuncSetUTCFullYear::callAsFunction):
- 2:52 PM Changeset in webkit [29216] by
-
- 7 edits in trunk/WebCore
Reviewed by Oliver.
Small CG paint server cleanups - use more GraphicsContext method where possible.p
- 2:43 PM Changeset in webkit [29215] by
-
- 5 edits in trunk
Reviewed by Dan.
Add new helper function isArabicChar - SVG Fonts support needs it.
- 2:33 PM Changeset in webkit [29214] by
-
- 3 edits3 adds in trunk
WebCore:
Reviewed by Darin.
DOMRange doesn't correctly re-size when inserting items (Acid3)
http://bugs.webkit.org/show_bug.cgi?id=16764
Update the offset for the range when inserting items into the range.
Test: fast/dom/Range/range-modifycontents.html
- dom/Range.cpp: (WebCore::Range::insertNode):
LayoutTests:
Reviewed by Darin.
DOMRange doesn't correctly re-size when inserting items (Acid3)
http://bugs.webkit.org/show_bug.cgi?id=16764
Update the offset for the range when inserting items into the range.
- fast/dom/Range/range-modifycontents-expected.txt: Added.
- fast/dom/Range/range-modifycontents.html: Added.
- fast/dom/Range/resources/range-modifycontents.js: Added.
- 2:25 PM Changeset in webkit [29213] by
-
- 1 edit1 add in trunk/LayoutTests
Add missing expected result.
- fast/dom/TreeWalker/TreeWalker-currentNode-expected.txt: Added.
- 12:35 PM Changeset in webkit [29212] by
-
- 3 edits3 adds in trunk
Reviewed by darin.
Make attr selectors case-insensitive for certain HTML attributes
http://bugs.webkit.org/show_bug.cgi?id=15470
Test: fast/css/html-attr-case-sensitivity.html
- css/CSSStyleSelector.cpp: (WebCore::addLocalNameToSet): (WebCore::createHtmlCaseInsensitiveAttributesSet): (WebCore::htmlAttributeHasCaseInsensitiveValue): (WebCore::CSSStyleSelector::checkOneSelector):
- 11:35 AM Changeset in webkit [29211] by
-
- 3 edits2 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16731
Incorrect node type for whitespace when setting innerHTML in an XHTML document
Test: fast/dom/xhtml-fragment-whitespace.xhtml
- dom/XMLTokenizer.cpp: (WebCore::parseXMLDocumentFragment): Use balancedCharactersHandler for ignorable whitespace.
- 11:33 AM Changeset in webkit [29210] by
-
- 3 edits3 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16701
<rdar://problem/5666580> REGRESSION: URL-encoded space (%20) in livejournal url
causes page load error
Test: http/tests/misc/location-with-space.php
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): Do update its URL, too.
- 11:10 AM Changeset in webkit [29209] by
-
- 2 edits in trunk/JavaScriptCore
2008-01-06 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Use $(EXEEXT) to account for the .exe extension in the GTK+ Windows
build. (This is already done correctly in DerivedSources.make.) Issue
noticed by Mikkel when building in Cygwin.
Add a missing slash. This was a hack from the qmake build system that
isn't necessary with autotools.
- GNUmakefile.am:
- 3:35 AM Changeset in webkit [29208] by
-
- 3 edits in trunk/WebKitTools
Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
Reviewed by Alp Toker.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(processWork): Process pending work.
(webViewLoadFinished): Schedule processing of pending work.
- DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
- 3:27 AM Changeset in webkit [29207] by
-
- 3 edits3 adds in trunk
WebCore:
Reviewed by Darin.
DOMRange.cloneContents does not work (Acid3 bug)
http://bugs.webkit.org/show_bug.cgi?id=16748
When cloning an empty range, return an empty DocmentFragment instead of
null or undefined.
Test: fast/dom/Range/range-clone-empty.html
- dom/Range.cpp: (WebCore::Range::processContents):
LayoutTests:
Reviewed by Darin.
DOMRange.cloneContents does not work (Acid3 bug)
http://bugs.webkit.org/show_bug.cgi?id=16748
When cloning an empty range, return an empty DocmentFragment instead of
null or undefined.
- fast/dom/Range/range-clone-empty-expected.txt: Added.
- fast/dom/Range/range-clone-empty.html: Added.
- fast/dom/Range/resources/range-clone-empty.js: Added.
- 2:57 AM Changeset in webkit [29206] by
-
- 2 edits in trunk/WebCore
2008-01-06 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
Remove curl handles immediately if the timer is not running.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::cancel):
- 12:48 AM Changeset in webkit [29205] by
-
- 2 edits in trunk/WebCore
2008-01-06 Alp Toker <alp@atoker.com>
Reviewed by Eric.
Cairo canvas refcounting fix. Reference the surface in the constructor
to match its destruction in the destructor.
Fixes a crash triggered by leaving this page:
http://philip.html5.org/tests/canvas/misc/globalalpha-pattern.html
- html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern):
- 12:13 AM Changeset in webkit [29204] by
-
- 3 edits4 adds in trunk
Reviewed by Sam.
Fix :checked matching type='text' and add test case
http://bugs.webkit.org/show_bug.cgi?id=16750
Test: fast/dom/HTMLInputElement/checked-pseudo-selector.html
- html/HTMLInputElement.h: isChecked() can only be true for RADIO or CHECKBOX
Jan 5, 2008:
- 6:36 PM Changeset in webkit [29203] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Eric Seidel.
Patch for http://bugs.webkit.org/show_bug.cgi?id=16758
ASSERT when using TreeWalker methods for a current node outside of the root (Acid3)
- Ensure that returned nodes are within the root node, or return 0, in adherence with the spec.
Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
- dom/TreeWalker.cpp: (WebCore::TreeWalker::parentNode): (WebCore::TreeWalker::firstChild): (WebCore::TreeWalker::lastChild): (WebCore::TreeWalker::previousSibling): (WebCore::TreeWalker::nextSibling): (WebCore::TreeWalker::previousNode): (WebCore::TreeWalker::nextNode):
LayoutTests:
Reviewed by Eric Seidel.
Test for http://bugs.webkit.org/show_bug.cgi?id=16758
ASSERT when using TreeWalker methods for a current node outside of the root (Acid3)
- fast/dom/TreeWalker: Added.
- fast/dom/TreeWalker/TreeWalker-currentNode.html: Added.
- fast/dom/TreeWalker/resources: Added.
- fast/dom/TreeWalker/resources/TreeWalker-currentNode.js: Added.
- 6:24 PM Changeset in webkit [29202] by
-
- 2 edits in trunk/WebKitTools
- Scripts/do-webcore-rename: Some more renaming plans.
- 6:16 PM Changeset in webkit [29201] by
-
- 2 edits in trunk/JavaScriptCore
- API/JSRetainPtr.h: One more file that needed the change below.
- 6:14 PM Changeset in webkit [29200] by
-
- 2 edits in trunk/JavaScriptCore
- wtf/OwnPtr.h: OwnPtr needs the same fix as RefPtr below.
- 6:12 PM Changeset in webkit [29199] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
Reviewed by Maciej.
- wtf/RetainPtr.h: Use PtrType instead of T* because of the RemovePointer magic.
- 2:46 PM Changeset in webkit [29198] by
-
- 6 edits in trunk/JavaScriptCore
Rubber stamped by Maciej Stachowiak.
- cut down own PIC branches by using a pointer-to-member-data instead of a pointer-to-member-function in WTF smart pointers
- wtf/OwnArrayPtr.h:
- wtf/OwnPtr.h:
- wtf/PassRefPtr.h:
- wtf/RefPtr.h:
- wtf/RetainPtr.h: Use a pointer to the m_ptr member instead of the get member. The GCC compiler generates better code for this idiom.
- 3:44 AM Changeset in webkit [29197] by
-
- 2 edits in trunk
2008-01-05 Alp Toker <alp@atoker.com>
Rubber-stamped by Mark Rowe.
Fix configure script output with correct descriptions of the default
configuration options.
- 2:23 AM Changeset in webkit [29196] by
-
- 2 edits in trunk
2008-01-05 Sylvain Pasche <sylvain.pasche@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16736
Allow autogen.sh invocation from a separate build directory.
- autogen.sh:
- 12:26 AM Changeset in webkit [29195] by
-
- 2 edits in trunk/JavaScriptCore
2008-01-05 Henry Mason <hmason@mac.com>
Reviewed by Maciej Stachowiak.
http://bugs.webkit.org/show_bug.cgi?id=16738
Bug 16738: Collector block offset could be stored as an cell offset instead of a byte offset
Gives a 0.4% SunSpider boost and prettier code.
- kjs/collector.cpp: Switched to cell offsets from byte offsets (KJS::Collector::heapAllocate): (KJS::Collector::sweep):
- 12:02 AM Changeset in webkit [29194] by
-
- 3 edits in trunk/JavaScriptCore
Have the two malloc zones print useful diagnostics if their free method are unexpectedly invoked.
Due to <rdar://problem/5671357> this can happen if an application attempts to free a pointer that
was not allocated by any registered malloc zone on the system.
Reviewed by Maciej Stachowiak.
Jan 4, 2008:
- 9:45 PM Changeset in webkit [29193] by
-
- 2 edits in trunk/LayoutTests
- update the list of tests failing on Windows because of font differences and uncomment a test that has been re-enabled on Mac.
- platform/win/Skipped:
- 9:20 PM Changeset in webkit [29192] by
-
- 5 edits in trunk
Fix bounds computation bugs responsible for http://bugs.webkit.org/show_bug.cgi?id=16015
and other image repaint bugs.
Reviewed by Beth Dakin.
We now cache the full local bounds for the <image> element, as otherwise certain
combinations of attribute changes could result in incorrect dirty rects.
Additionally we no longer use any of the integer bounds fields on RenderObject for
determining repaint bounds (this was the principle cause of bug #16015).
I also removed the outline painting code as it was both wrong, and not correctly
repainted. I feel safe doing this as no other browser or viewer supports outline
properties on svg elements.
I was unable to make a testcase for this unfortunately, despite seemingly deterministic
behaviour :(
- 9:13 PM Changeset in webkit [29191] by
-
- 5 edits2 adds in trunk
WebCore:
Reviewed by Oliver.
Fix for http://bugs.webkit.org/show_bug.cgi?id=16704 input with
type="hidden" matches :enabled/:disabled (Acid3 bug)
Prevent :enabled and :disabled from applying to input type="hidden"
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Rather than allowing :enabled and :disabled to apply to all controls, only allow it to apply to non-"hidden" controls
- dom/Element.h: (WebCore::Element::isInputTypeHidden):
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::isInputTypeHidden):
LayoutTests:
Reviewed by Oliver.
Test for http://bugs.webkit.org/show_bug.cgi?id=16704 input with
type="hidden" matches :enabled/:disabled (Acid3 bug)
- fast/forms/hidden-input-not-enabled-expected.txt: Added.
- fast/forms/hidden-input-not-enabled.html: Added.
- 8:05 PM Changeset in webkit [29190] by
-
- 1 edit1 add in trunk/LayoutTests
Add missing expected result.
- fast/images/border-expected.txt: Added.
- 8:04 PM Changeset in webkit [29189] by
-
- 10 edits3 adds in trunk
WebCore:
Reviewed by Oliver Hunt.
- Match the spec when calling getFloatValue, getStringValue, getCounterValue, getRectValue and getRGBColorValue of CSSPrimitiveValue by throwing exceptions if the type of the CSSPrimitiveValue is not the same as the type requested.
- Fix the intermittent assertion failure seen in svg/css/glyph-orientation-rounding-test.xhtml
Test: fast/css/CSSPrimitiveValue-exceptions.html
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::getDoubleValue): (WebCore::CSSPrimitiveValue::getStringValue): (WebCore::CSSPrimitiveValue::getCounterValue): (WebCore::CSSPrimitiveValue::getRectValue): (WebCore::CSSPrimitiveValue::getRGBColorValue): (WebCore::CSSPrimitiveValue::getPairValue):
- css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getFloatValue): (WebCore::CSSPrimitiveValue::getIntValue): (WebCore::CSSPrimitiveValue::getCounterValue): (WebCore::CSSPrimitiveValue::getRectValue): (WebCore::CSSPrimitiveValue::getDashboardRegionValue):
- css/CSSPrimitiveValue.idl:
LayoutTests:
Reviewed by Oliver Hunt.
Throw exceptions for the CSSPrimitiveValue getters, matching the spec.
- fast/css/CSSPrimitiveValue-exceptions-expected.txt: Added.
- fast/css/CSSPrimitiveValue-exceptions.html: Added.
- fast/css/resources/CSSPrimitiveValue-exceptions.js: Added.
- fast/dom/prototypes.html:
- fast/dom/wrapper-classes.html:
- platform/mac/fast/dom/wrapper-classes-objc.html:
- svg/css/glyph-orientation-rounding-test-expected.txt:
- svg/css/glyph-orientation-rounding-test.xhtml: Pass in a unit so this doesn't throw. This patch also fixes the associated intermittent failure seen in this test.
- 6:32 PM Changeset in webkit [29188] by
-
- 6 edits in trunk/WebCore
Reviewed by Darin.
Windows part of <rdar://problem/5647034>
Media tests crash if an old version of QuickTime is installed
Check QuickTime version on Windows too.
- 5:51 PM Changeset in webkit [29187] by
-
- 4 edits1 copy1 add in trunk/LayoutTests
Reviewed by Kevin McCullough.
- Splits Objective-C tests out of wrapper-classes.html and into platform specific test.
- Adds tests for .proto and .constructor to JS wrapper tests.
- fast/dom/wrapper-classes.html:
- platform/mac/fast/dom/wrapper-classes-expected.txt:
- platform/mac/fast/dom/wrapper-classes-objc-expected.txt: Added.
- platform/mac/fast/dom/wrapper-classes-objc.html: Copied from fast/dom/wrapper-classes.html.
- platform/win/Skipped:
- 5:45 PM Changeset in webkit [29186] by
-
- 2 edits in trunk/LayoutTests
Move svg/batik/text/smallFonts.svg
to skip list since it is still failing on tiger.
- platform/mac-tiger/Skipped:
- 5:11 PM Changeset in webkit [29185] by
-
- 3 edits1 copy2 adds in trunk
WebCore:
Reviewed by Maciej and Alice.
- fix <rdar://problem/4404302> Borders where there should be none (canadasmountains.com)
Test: fast/images/border.html
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Change the code that handles cases where the border value is not a number to use the value "0" for the border width instead of not setting the border width and style at all. This matches other browsers, and makes more sense.
LayoutTests:
Reviewed by Maciej and Alice.
- test for <rdar://problem/4404302> Borders where there should be none (canadasmountains.com)
- fast/images/border.html: Added.
- fast/images/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
- fast/images/resources/border.js: Added.
- 4:32 PM Changeset in webkit [29184] by
-
- 6 edits in trunk
WebKitTools:
Reviewed by Alexey and Darin.
Adding "home" and "end" to DRT's keydown since
DOM key events can't handle keyIdentifiers at this point.
- DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:]):
- DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
LayoutTests:
Reviewed by Alexey and Darin.
- editing/selection/move-begin-end.html: add a codepath that will test the same kind of functionality for home and end keys
- platform/win/Skipped: removing section of tests that have been resolved
- 4:28 PM Changeset in webkit [29183] by
-
- 2 edits in trunk/WebCore
Try to fix 64-bit build
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::isAvailable):
- 4:15 PM Changeset in webkit [29182] by
-
- 2 edits in trunk/WebCore
Fix another stringImpl leak.
- platform/text/StringImpl.cpp: remove an extra allocation (WebCore::StringImpl::StringImpl):
- 3:34 PM Changeset in webkit [29181] by
-
- 2 edits in trunk/WebCore
Reviewed by Mitz.
- platform/graphics/win/FontCacheWin.cpp: fix loop condition that was causing crash
- 2:56 PM Changeset in webkit [29180] by
-
- 1 edit1 move4 adds2 deletes in trunk/LayoutTests
Update tiger layout test results for svg/batik/text/smallFonts, and move to mac-tiger platform
RS=Adam
- 2:43 PM Changeset in webkit [29179] by
-
- 4 edits in trunk/WebCore
Reviewed by Adam Roben.
<rdar://problem/5671059> Always show the Timeline and Console buttons in the Inspector
- page/inspector/inspector.css: Remove styles related to the toggle button and make the area always visible.
- page/inspector/inspector.html: Remove the toggle button.
- page/inspector/inspector.js: Remove code to toggle the status area.
- 2:35 PM Changeset in webkit [29178] by
-
- 4 edits in trunk
Reviewed by Adam Roben.
Restore compatibility with shipping Safari beta.
WebKit:
http://bugs.webkit.org/show_bug.cgi?id=16733
REGRESSION: Crash on Safari Start
- Interfaces/IWebViewPrivate.idl: Should have added a new method at the end.
WebCore:
Temporarily restore BackwardDelete for Windows nightlies to work correctly.
- editing/EditorCommand.cpp: (WebCore::CommandEntry::):
- 2:27 PM Changeset in webkit [29177] by
-
- 8 edits in trunk
Reviewed by Darin.
<rdar://problem/5611712> xsl:sort does not use a case folding sort, and the 'case-order' attribute is ignored (16077)
Enable the fix on Windows.
- 2:08 PM Changeset in webkit [29176] by
-
- 2 edits in trunk/WebCore
Fix build.
- bindings/js/JSHTMLElementWrapperFactory.cpp:
- 1:44 PM Changeset in webkit [29175] by
-
- 8 edits in trunk/WebCore
Reviewed by Darin.
Partial fix for <rdar://problem/5647034>
Media tests crash if an old version of QuickTime is installed
Disable media support if QuickTime is not current enough (>=7.3).
Windows patch coming soon.
- bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
- bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
- html/HTMLElementFactory.cpp: (WebCore::audioConstructor): (WebCore::videoConstructor): (WebCore::sourceConstructor):
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::isAvailable):
- platform/graphics/MediaPlayer.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::isAvailable):
- 1:02 PM Changeset in webkit [29174] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
<rdar://problem/5604409> JavaScript privilege escalation when Web Inspector accesses page unsafely (16011)
Check if the property is a getter before asking for the value.
If the property is a getter, we no longer show the value.
- page/inspector/PropertiesSidebarPane.js:
- page/inspector/inspector.css:
- 12:54 PM Changeset in webkit [29173] by
-
- 2 edits in trunk
2008-01-04 Alp Toker <alp@atoker.com>
Rubber-stamped by Mark Rowe.
Remove AM_MAINTAINER_MODE, as recommended by the automake manual. The
"rebuild rules" will now be enabled by default.
This obviates the need to pass '--enable-maintainer-mode' to
configure.
- configure.ac:
- 11:31 AM Changeset in webkit [29172] by
-
- 3 edits4 adds in trunk
Fix <rdar://4968855> Shift-PageUp/Shift-PageDown only select one line of text
WebKit/win:
Fix <rdar://4968855> Shift-PageUp/Shift-PageDown only select one line of text
Test: platform/win/editing/selection/shift-page-down-up.html
Reviewed by Oliver.
- WebView.cpp: Correct the commands associated with Shift-PageUp/Shift-PageDown.
LayoutTests:
Added a test for <rdar://4968855> Shift-PageUp/Shift-PageDown only select one line of text
Reviewed by Oliver.
- platform/win/editing/selection/shift-page-up-down-expected.txt: Added.
- platform/win/editing/selection/shift-page-up-down.html: Added.
- 11:25 AM Changeset in webkit [29171] by
-
- 2 edits1 move in trunk/LayoutTests
<rdar://problem/5646437> REGRESSION (r28015): svg/batik/text/smallFonts fails
Reviewed by Darin
Regenerated expected output as filter elements are no longer generated in a default
build. This wasn't done when filters were turned off earlier due to other (now gone)
layout failures i didn't want to put in the expected output.
- 11:23 AM Changeset in webkit [29170] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
- fix synthetic bold and italic on Windows
Covered by an existing test.
- platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData):
- 9:18 AM Changeset in webkit [29169] by
-
- 2 edits in trunk/LayoutTests
- platform/win/Skipped: Added some more failures.
- 6:52 AM Changeset in webkit [29168] by
-
- 4 edits in trunk
2008-01-04 Alp Toker <alp@atoker.com>
GTK+ autotools build fix. Terminate empty rules.
- 6:49 AM Changeset in webkit [29167] by
-
- 2 edits in trunk/WebKitTools
fix DRT after the changes to QWebPage.
The great thing is that we actually don't have
any regressions from the QWebPage change :)
Signed-off-by: Simon
- 6:49 AM Changeset in webkit [29166] by
-
- 10 edits in trunk
Remove most dependencies of Widget/ScrollView onto native QWidgets.
This also brings the code closer in line with the Windows code. Seems
to work nicely on first try :)
Signed-off-by: Simon
- 6:48 AM Changeset in webkit [29165] by
-
- 3 edits in trunk/WebKit/qt
- Remove the todo from QWebPage and move the code to QWebView.
Signed-off-by: Simon
- 6:48 AM Changeset in webkit [29164] by
-
- 4 edits in trunk/WebKit/qt
- Move the various event methods to QWebPagePrivate. This is similar to QTextControl as well.
Signed-off-by: Simon
- 6:48 AM Changeset in webkit [29163] by
-
- 5 edits in trunk/WebKit/qt
- Forward the event from QWebView to QWebPage through QObject::event. This is similar to the way QTextControl is working.
Signed-off-by: Simon
- 6:47 AM Changeset in webkit [29162] by
-
- 16 edits in trunk
make QWebPage a QObject and get things to compile.
Nothing works currently though.
Signed-off-by: Simon
- 4:47 AM QtWebKitGitInstructions edited by
- Joe Doe needs quotes otherwise the name is Joe (diff)
- 4:26 AM Changeset in webkit [29161] by
-
- 3 edits in trunk/WebKit/qt
Added some preliminary class documentation for QWebView, fixed a missing const() and some missing Q_PROPERTYs
Signed-off-by: Lars
- 4:25 AM Changeset in webkit [29160] by
-
- 3 edits in trunk/WebKit/qt
add a viewportSize to QWebPage.
This is required to eventually make it a QObject only.
Signed-off-by: Simon
- 4:25 AM Changeset in webkit [29159] by
-
- 5 edits in trunk
take a QString as identifier in QWebFrame::addToJSWindowObject.
Signed-off-by: Simon
- 4:24 AM Changeset in webkit [29158] by
-
- 2 edits in trunk/WebKit/qt
Call the frame arguments for the javascript callbacks "originatingFrame"
Signed-off-by: Lars
- 4:24 AM Changeset in webkit [29157] by
-
- 4 edits in trunk/WebKit/qt
Moved the QWebPage::addToHistory signal into QWebHistoryInterface
Signed-off-by: Lars
- 4:23 AM Changeset in webkit [29156] by
-
- 7 edits in trunk/WebKit/qt
moved title(), url(), icon() and initialLayoutComplete() from QWebPage to QWebFrame
Signed-off-by: Simon
- 4:19 AM Changeset in webkit [29155] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix bug URL in ChangeLog entry
- 4:18 AM Changeset in webkit [29154] by
-
- 2 edits in trunk/WebCore
2008-01-04 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/attachment.cgi?bugid=16667&action=enter
make -j is failing with the autotools based system
Support parallel code generation. Nearly every use of explicit
multiple targets was a potential concurrency bug, though in practice
the bison rules were the first to be noticed because they took longer
to complete and broke the build immediately.
- GNUmakefile.am:
- 2:44 AM Changeset in webkit [29153] by
-
- 2 edits in trunk/WebCore
2008-01-04 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Re-use a single static dummy surface rather than creating and
destroying a surface for each CairoPath.
- platform/graphics/cairo/CairoPath.h: (WebCore::CairoPath::CairoPath):
- 12:16 AM Changeset in webkit [29152] by
-
- 2 edits in trunk/WebCore
Tiger build fix.
- platform/Threading.h: The OSAtomic functions take non-volatile pointers on Tiger.
- 12:05 AM Changeset in webkit [29151] by
-
- 2 edits in trunk/WebKitTools
2008-01-04 Alp Toker <alp@atoker.com>
GTK+ DRT build fix for breakage introduced in r29149.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::execCommand):
