Timeline



Jan 13, 2008:

10:05 PM Changeset in webkit [29458] by sfalken@apple.com
  • 19 edits
    1 move
    4 adds
    23 deletes in trunk

JavaScriptCore:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Reviewed by Adam Roben.

WebCore:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.

Reviewed by Adam Roben.

  • WebCore.vcproj/PRODUCTVERSION: Removed.
  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/VERSION: Removed.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/auto-version.sh: Removed.
  • WebCore.vcproj/debug.vsprops: Removed.
  • WebCore.vcproj/debug_internal.vsprops: Removed.
  • WebCore.vcproj/release.vsprops: Removed.

WebKit/win:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.

Reviewed by Adam Roben.

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/PRODUCTVERSION: Removed.
  • WebKit.vcproj/VERSION: Removed.
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
  • WebKit.vcproj/auto-version.sh: Removed.
  • WebKit.vcproj/debug.vsprops: Removed.
  • WebKit.vcproj/debug_internal.vsprops: Removed.
  • WebKit.vcproj/release.vsprops: Removed.

WebKitLibraries:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Moved auto-version.sh, VERSION, PRODUCTVERSION to tools.

Reviewed by Adam Roben.

  • win/tools/WinTools.make:
  • win/tools/scripts: Added.
  • win/tools/scripts/PRODUCTVERSION: Added.
  • win/tools/scripts/VERSION: Added.
  • win/tools/scripts/auto-version.sh: Copied from WebCore/WebCore.vcproj/auto-version.sh.
  • win/tools/vsprops/debug.vsprops:
  • win/tools/vsprops/debug_internal.vsprops: Added.
  • win/tools/vsprops/release.vsprops:

WebKitTools:

Share common files across projects.


Unify vsprops files
Debug: common.vsprops, debug.vsprops
Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
Release: common.vsprops, release.vsprops


Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.

Reviewed by Adam Roben.

  • Drosera/win/Drosera.vcproj/Drosera.vcproj:
  • Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
  • Drosera/win/Drosera.vcproj/VERSION: Removed.
  • Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
  • Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
  • Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
  • Drosera/win/Drosera.vcproj/release.vsprops: Removed.
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
  • DumpRenderTree/win/debug.vsprops: Removed.
  • DumpRenderTree/win/debug_internal.vsprops: Removed.
  • DumpRenderTree/win/release.vsprops: Removed.
8:40 PM Changeset in webkit [29457] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::destroy): Removed the call to RenderLayer::destroy() from here, because ~RenderLayer() calls RenderObject() methods.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Added the call to RenderLayer::destroy() here.
5:35 PM Changeset in webkit [29456] by eric@webkit.org
  • 3 edits
    6 adds in trunk

Reviewed by darin.

Range.insertNode does not update endContainer endIndex correctly
in the case where it had to split a text node.
​http://bugs.webkit.org/show_bug.cgi?id=16765

Darin pointed out during review that we still don't handle the dynamic
range case (where the dom tree changes not using range methods)
Thus this code will get ripped out when we add that. The test cases
are still valid and useful however, so I'm landing this as-is.

Tests: fast/dom/Range/range-insertNode-separate-endContainer.html

fast/dom/Range/range-insertNode-splittext.html

  • dom/Range.cpp: (WebCore::Range::insertNode): handle the splitText case correctly.
11:54 AM Changeset in webkit [29455] by Darin Adler
  • 2 edits
    3 adds in trunk/WebKitTools

Reviewed by Maciej.

  • Scripts/gdb-drosera: Added.
  • Scripts/run-drosera: Added.
  • Scripts/run-drosera-nightly.cmd: Added.
  • Scripts/webkitdirs.pm: Added runDrosera function.
11:47 AM Changeset in webkit [29454] by Darin Adler
  • 5 edits in trunk/JavaScriptCore

Contributions and review by Adriaan de Groot,
Simon Hausmann, Eric Seidel, and Darin Adler.

  • kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime): Use the WIN_OS code path for SOLARIS too, presumably because Solaris also lacks the tm_gtoff and tm_zone fields. (KJS::GregorianDateTime::operator tm): Ditto.
  • kjs/collector.cpp: (KJS::currentThreadStackBase): Use thr_stksegment on Solaris.
  • wtf/MathExtras.h: (isfinite): Implement for Solaris. (isinf): Ditto. (signbit): Ditto. But this one is wrong, so I added a FIXME.
  • wtf/Platform.h: Define PLATFORM(SOLARIS) when "sun" or "sun" is defined.
11:34 AM Changeset in webkit [29453] by kevino@webkit.org
  • 8 edits in trunk/WebKit/wx

wxWebKit API changes in preparation for DRT implementation.

Reviewed by Darin Adler.

11:19 AM Changeset in webkit [29452] by Darin Adler
  • 10 edits in trunk/WebCore

Reviewed by Eric.

  • dom/Document.cpp: (WebCore::Document::setDomain): Removed unneeded call to copy. (WebCore::Document::parseQualifiedName): Removed unneeded call to copy, and unneeded length argument to substring, which stops at the end of the string if you don't specify a length. (WebCore::Document::createAttributeNS): Replaced code that was calling copy with more-efficient code using the substring function.
  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor): Removed unneeded call to copy.
  • editing/InsertIntoTextNodeCommand.cpp: (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand): Removed unneeded copy and also initialized text instead of assigning to it. (WebCore::InsertIntoTextNodeCommand::doApply): Removed redundant assertions. (WebCore::InsertIntoTextNodeCommand::doUnapply): Ditto.
  • editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): Removed unneeded call to copy. This one was particularly bad since we just turned around and copied it again!
  • editing/markup.cpp: (WebCore::stringValueForRange): Removed unneeded call to copy.
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::performOpenInitialization): Changed logging code to not get the path from the database object. This was the only reason the database had to keep its path around.
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::open): Use a local variable instead of a data member to convert the string to a null-terminated one. (WebCore::SQLiteDatabase::close): Removed the code to clear out m_path.
  • platform/sql/SQLiteDatabase.h: Removed the m_path data member and the path functio member. Also tweaked formatting and comments a bit. Removed the unused escapeSQLString function.
  • platform/text/String.cpp: (WebCore::operator+): Removed uneeded calls to copy.
9:24 AM Changeset in webkit [29451] by mitz@apple.com
  • 2 edits in trunk/WebKitTools
  • fix breakage due to last-minute change
  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Declare the loop variable.
9:15 AM Changeset in webkit [29450] by mitz@apple.com
  • 8 edits in trunk

WebKitTools:

Reviewed by Adam Roben.

  • fix <rdar://problem/5132009> Windows DRT does not support multiple windows
  • DumpRenderTree/win/DumpRenderTree.cpp: (DumpRenderTreeWndProc): (initialize): (dumpBackForwardList): (dumpBackForwardListForAllWindows): (dump): (resetWebViewToConsistentStateBeforeTesting): Factored out of runTest(). (runTest): (allWindows): Added. Returns a vector of all open windows. (windowToWebViewMap): Added. Returns a map from open windows to their WebViews. (createWebViewAndOffscreenWindow): Factored out of main() to be reusable for creating extra windows. (main):
  • DumpRenderTree/win/DumpRenderTreeWin.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::windowCount): Implemented.
  • DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::createWebViewWithRequest): Implemented. (UIDelegate::webViewClose): Implemented.
  • DumpRenderTree/win/UIDelegate.h:

LayoutTests:

Reviewed by Adam Roben.

  • enable tests affected by <rdar://problem/5132009> Windows DRT does not support multiple windows
  • platform/win/Skipped:
5:20 AM Changeset in webkit [29449] by oliver@apple.com
  • 2 edits in trunk/WebCore

Attempt to fix QT build

5:09 AM Changeset in webkit [29448] by oliver@apple.com
  • 3 edits in trunk/WebCore

Avoid repainting the entire canvas element when possible.

Reviewed by Mark Rowe.

We now only register the dirty regions of a canvas for repainting, rather
than the entire element (though repaint coalescing may choose to combine
these regions). This doesn't cause a measurable regression in the worst
case (clearing the canvas repeatedly), but is a moderate-large win if only
a minor update has occurred. If there is any CSS scaling applied to the
canvas almost any update short of clearing the entire element is substantially
faster.

3:08 AM Changeset in webkit [29447] by mrowe@apple.com
  • 13 edits in trunk

2008-01-13 Michael Goddard <​michael.goddard@trolltech.com>

Reviewed by Anders Carlsson.

Add binding language type to Instance.
Allows runtime determination of the type of an
Instance, to allow safe casting. Doesn't actually
add any safe casting yet, though.

Add a helper function to get an Instance from a JSObject*.
Given an object and the expected binding language, see if
the JSObject actually wraps an Instance of the given type
and return it. Otherwise return 0.

Move RuntimeObjectImp creations into Instance.
Make the ctor protected, and Instance a friend class, so
that all creation of RuntimeObjectImps goes through
one place.

Remove copy ctor/assignment operator for QtInstance.
Instance itself is Noncopyable, so QtInstance doesn't
need to have these.

Add caching for QtInstance and associated RuntimeObjectImps.
Push any dealings with QtLanguage bindings into QtInstance,
and cache them there, rather than in the Instance layer. Add
a QtRuntimeObjectImp to help with caching.

  • JavaScriptCore.exp:
  • bindings/c/c_instance.h:
  • bindings/jni/jni_instance.h:
  • bindings/objc/objc_instance.h:
  • bindings/qt/qt_instance.cpp: (KJS::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp): (KJS::Bindings::QtRuntimeObjectImp::~QtRuntimeObjectImp): (KJS::Bindings::QtRuntimeObjectImp::invalidate): (KJS::Bindings::QtRuntimeObjectImp::removeFromCache): (KJS::Bindings::QtInstance::QtInstance): (KJS::Bindings::QtInstance::~QtInstance): (KJS::Bindings::QtInstance::getQtInstance): (KJS::Bindings::QtInstance::getRuntimeObject):
  • bindings/qt/qt_instance.h: (KJS::Bindings::QtInstance::getBindingLanguage):
  • bindings/runtime.cpp: (KJS::Bindings::Instance::createBindingForLanguageInstance): (KJS::Bindings::Instance::createRuntimeObject): (KJS::Bindings::Instance::getInstance):
  • bindings/runtime.h:
  • bindings/runtime_object.h: (KJS::RuntimeObjectImp::getInternalInstance):

2008-01-13 Michael Goddard <​michael.goddard@trolltech.com>

Reviewed by Anders Carlsson.

Move RuntimeObjectImp creations into Instance.
Make the ctor protected, and Instance a friend class, so
that all creation of RuntimeObjectImps goes through
one place.

  • bindings/js/kjs_dom.cpp: (WebCore::getRuntimeObject):
2:20 AM BuildingGtk edited by lethalman88@gmail.com
Gentoo overlay for WebKit (diff)
12:51 AM Changeset in webkit [29446] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Change test to match the results landed in r29424. The test changes were
omitted in that check-in.

  • editing/pasteboard/paste-RTFD.html:

Jan 12, 2008:

11:33 PM Changeset in webkit [29445] by alp@webkit.org
  • 6 edits in trunk

2008-01-12 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Hide non-public symbols in GTK+/autotools release builds.

10:54 PM Changeset in webkit [29444] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx build fix. Add WebCore/icu/include for Mac builds using only stock ICU.

8:52 PM Changeset in webkit [29443] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-01-12 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Mark Rowe.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=16852
Fixes leaking of ActivationStackNode objects.

  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::deleteActivationStack): (KJS::JSGlobalObject::~JSGlobalObject): (KJS::JSGlobalObject::init): (KJS::JSGlobalObject::reset):
  • kjs/JSGlobalObject.h:
1:23 PM QtWebKitContrib edited by staikos@webkit.org
(diff)
11:25 AM Changeset in webkit [29442] by mrowe@apple.com
  • 5 edits in trunk/WebCore

2008-01-12 Rodney Dawes <​dobey@wayofthemonkey.com>

Gtk debug build fix. Reviewed by Mark Rowe.

Add plugin logging channel, and use it rather than Win32-specific debugging methods _RPTF1 _RPTF2 and _CRT_WARN.

  • WebCore.pro: Add plugins directory to DEPENDPATH so dependencies are correctly tracked.
  • platform/Logging.cpp:
  • platform/Logging.h:
  • plugins/PluginDebug.h:
10:35 AM Changeset in webkit [29441] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Update expected results for fast/replaced/image-map-expected after
r29432 disabled document replacement by the JavaScript result in this
case.

  • fast/replaced/image-map-expected.txt:
10:19 AM Changeset in webkit [29440] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • try to fix Qt Windows build
  • pcre/dftables: Remove reliance on the list form of Perl pipes.
10:05 AM Changeset in webkit [29439] by Darin Adler
  • 3 edits in trunk/JavaScriptCore
  • try to fix Qt build
  • kjs/function.cpp: Added include of scope_chain_mark.h.
  • kjs/scope_chain_mark.h: Added multiple-include guards.
7:43 AM Changeset in webkit [29438] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Roll out r29435 as it introduces many, many crashes.

6:25 AM Changeset in webkit [29437] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-01-12 Mark Rowe <​mrowe@apple.com>

Another Windows build fix.

  • kjs/Activation.h:
6:12 AM Changeset in webkit [29436] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-01-12 Mark Rowe <​mrowe@apple.com>

Attempted Windows build fix. Use struct consistently when forward-declaring
ActivationStackNode and StackActivation.

  • kjs/Activation.h:
  • kjs/JSGlobalObject.h:
6:06 AM Changeset in webkit [29435] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-01-12 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Mark Rowe.

Fixes leaking of ActivationStackNode objects.

  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::deleteActivationStack): (KJS::JSGlobalObject::~JSGlobalObject): (KJS::JSGlobalObject::init): (KJS::JSGlobalObject::reset):
  • kjs/JSGlobalObject.h:
5:48 AM Changeset in webkit [29434] by zecke@webkit.org
  • 5 edits
    1 add in trunk
  • Make launching of the WebKit httpd work on GNU/Debian/Linux

The configuration of Apache2 and installation does not depend on
the kernel but on the distribution policy. Make launching of httpd
work for Debian derived distributions.

5:19 AM Changeset in webkit [29433] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.

Reviewed by Maciej Stachowiak.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to

match the callers expectations that it can take ownership of the string.

4:03 AM Changeset in webkit [29432] by mjs@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Maciej (and also tweaked a little bit).

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::executeIfJavaScriptURL):
  • loader/FrameLoader.h:
3:03 AM Changeset in webkit [29431] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Fixes a problem with the ActivationImp tear-off patch (r29425) where
some of the calls to JSGlobalObject::tearOffActivation() were using
the wrong test to determine whether it should leave a relic behind.

  • kjs/function.cpp: (KJS::FunctionImp::argumentsGetter): (KJS::ActivationImp::getOwnPropertySlot):
12:37 AM Changeset in webkit [29430] by mjs@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • fixed <rdar://problem/5556374> REGRESSION: cross-domain error when one URL uses an explicit port number and another doesn't


  • platform/SecurityOrigin.cpp: (WebCore::isDefaultPortForProtocol): (WebCore::SecurityOrigin::SecurityOrigin):

Jan 11, 2008:

11:40 PM Changeset in webkit [29429] by alp@webkit.org
  • 3 edits in trunk

2008-01-11 Alp Toker <​alp@atoker.com>

Reviewed by Oliver Hunt.

Enable FastMalloc by default in GTK+/autotools and add a configure
switch.

  • GNUmakefile.am:
  • configure.ac:
11:19 PM Changeset in webkit [29428] by ggaren@apple.com
  • 19 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Oliver Hunt.


Fixed <rdar://problem/5665251> REGRESSION (r28880-r28886): Global
variable access (16644)


This bug was caused by var declarations shadowing built-in properties of
the global object.


To match Firefox, we've decided that var declarations will never shadow
built-in properties of the global object or its prototypes. We used to
behave more like IE, which allows shadowing, but walking that line got
us into trouble with websites that sent us down the Firefox codepath.

  • kjs/JSVariableObject.h: (KJS::JSVariableObject::symbolTableGet): New code to support calling hasProperty before the variable object is fully initialized (so you can call it during initialization).
  • kjs/nodes.cpp:. (KJS::ProgramNode::initializeSymbolTable): Always do a full hasProperty check when looking for duplicates, not getDirect, since it only checks the property map, and not hasOwnProperty, since it doesn't check prototypes. (KJS::EvalNode::processDeclarations): ditto
  • kjs/property_slot.h: (KJS::PropertySlot::ungettableGetter): Best function name evar.

WebCore:

Reviewed by Oliver Hunt.


Fixed <rdar://problem/5665251> REGRESSION (r28880-r28886): Global
variable access (16644)


Removed the ReadOnly bit from some properties, to match Firefox. Also
removed status-related setters, to allow using their names as variable
names.


  • bindings/scripts/CodeGeneratorJS.pm: Added support for properties that are one-way across domain boundaries, to match Firefox.
  • bindings/js/kjs_window.cpp: Changed ReadOnly declarations to match FF.
  • bindings/scripts/CodeGeneratorJS.pm: Don't use JSObject:: because we don't know that JSObject is our base class.
  • page/DOMWindow.idl: Replaced lots of readonly declarations with [Replaceable] declarations.
  • page/DOMWindow.h: Removed interfaces for setting status text via the DOM. (They were getting in the way of, e.g., "var status" declarations.) By default, IE 7 and FF disable these interfaces in order to defend against phishing attacks that try to spoof domain names in the statusbar.
  • page/DOMWindow.cpp:

LayoutTests:

Reviewed by Oliver Hunt.


Fixed <rdar://problem/5665251> REGRESSION (r28880-r28886): Global
variable access (16644)


Added a test. Updated other tests to match new behavior.


  • fast/js/var-declarations-shadowing-expected.txt: Added.
  • fast/js/var-declarations-shadowing.html: Added.
  • fast/dom/HTMLScriptElement/script-load-events.html: Changed this test a bit because the original design made it hard to understand why it was failing.
  • fast/dom/HTMLScriptElement/script-load-events-expected.txt:


  • fast/dom/Window/get-set-properties.html: Changed this test to expect our new behavior, which matches Firefox.
  • fast/dom/Window/get-set-properties-expected.txt:
  • fast/dom/Window/window-property-shadowing.html: Removed some cases that differed from Firefox.
  • fast/dom/Window/window-property-shadowing-expected.txt:
  • http/tests/security/cross-frame-access-put-expected.txt: This test emits more "Unsafe JavaScript attempt" messages now because property sets that used to be prohibited (somewhat accidentally) by the ReadOnly attribute are now prohibited by security checks.
9:50 PM Changeset in webkit [29427] by mitz@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

2008-01-11 Anyang Ren <​anyang.ren@gmail.com>

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=15960
The view source mode should skip an empty attribute value only if
the attribute name is not followed by an equal sign (=).

Test: fast/frames/viewsource-empty-attribute-value.html

  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):

LayoutTests:

2008-01-11 Anyang Ren <​anyang.ren@gmail.com>

Reviewed by Darin Adler.

Add a new regression test for
​http://bugs.webkit.org/show_bug.cgi?id=15960
The view source mode should skip an empty attribute value only if
the attribute name is not followed by an equal sign (=).

  • fast/frames/resources/viewsource-frame-1.html: Added.
  • fast/frames/viewsource-empty-attribute-value-expected.txt: Added.
  • fast/frames/viewsource-empty-attribute-value.html: Added.
6:22 PM Changeset in webkit [29426] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-11 Sylvain Pasche <​sylvain.pasche@gmail.com>

Reviewed by Alp Toker.

[Gtk] Uneven glyph spacing with subpixel antialiasing
​http://bugs.webkit.org/show_bug.cgi?id=16715

Use cairo font options from the default GDK screen when creating a
scaled font.

  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData):
6:08 PM Changeset in webkit [29425] by mjs@apple.com
  • 16 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

Optimized ActivationImp allocation, so that activation records are now
first allocated on an explicitly managed stack and only heap allocated
when necessary. Roughly a 5% improvement on SunSpider, and a larger
improvement on benchmarks that use more function calls.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/Activation.h: Added. (KJS::ActivationImp::ActivationData::ActivationData): (KJS::ActivationImp::ActivationImp): (KJS::ActivationImp::classInfo): (KJS::ActivationImp::isActivationObject): (KJS::ActivationImp::isOnStack): (KJS::ActivationImp::d): (KJS::StackActivation::StackActivation):
  • kjs/ExecState.cpp: (KJS::ExecState::ExecState): (KJS::ExecState::~ExecState):
  • kjs/ExecState.h: (KJS::ExecState::replaceScopeChainTop): (KJS::ExecState::setActivationObject): (KJS::ExecState::setLocalStorage):
  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset): (KJS::JSGlobalObject::pushActivation): (KJS::JSGlobalObject::checkActivationCount): (KJS::JSGlobalObject::popActivationHelper): (KJS::JSGlobalObject::popActivation): (KJS::JSGlobalObject::tearOffActivation):
  • kjs/JSGlobalObject.h:
  • kjs/JSVariableObject.h: (KJS::JSVariableObject::JSVariableObjectData::JSVariableObjectData): (KJS::JSVariableObject::JSVariableObject):
  • kjs/function.cpp: (KJS::FunctionImp::argumentsGetter): (KJS::ActivationImp::ActivationImp): (KJS::ActivationImp::~ActivationImp): (KJS::ActivationImp::init): (KJS::ActivationImp::getOwnPropertySlot): (KJS::ActivationImp::markHelper): (KJS::ActivationImp::mark): (KJS::ActivationImp::ActivationData::ActivationData): (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function.h:
  • kjs/nodes.cpp: (KJS::PostIncResolveNode::evaluate): (KJS::PostDecResolveNode::evaluate): (KJS::PreIncResolveNode::evaluate): (KJS::PreDecResolveNode::evaluate): (KJS::ReadModifyResolveNode::evaluate): (KJS::AssignResolveNode::evaluate): (KJS::WithNode::execute): (KJS::TryNode::execute): (KJS::FunctionBodyNode::processDeclarations): (KJS::FuncExprNode::evaluate):
  • kjs/object.h:
  • kjs/scope_chain.h: (KJS::ScopeChain::replace):
  • kjs/scope_chain_mark.h: Added. (KJS::ScopeChain::mark):

WebCore:

Reviewed by Maciej.

Added a new forwarding header, because Activation.h has been separated
from function.h

  • ForwardingHeaders/kjs/Activation.h: Added.

LayoutTests:

Reviewed by Maciej.

Added a test case that came up when developing the ActivationImp tear-off.

  • fast/js/resources/vardecl-preserve-arguments.js:
  • fast/js/vardecl-preserve-arguments-expected.txt:
5:52 PM Changeset in webkit [29424] by justin.garcia@apple.com
  • 5 edits
    2 adds in trunk/LayoutTests

<rdar://problem/5541054> editing/pasteboard/paste-RTFD.html failing on Tiger

  • editing/pasteboard/paste-RTFD.html: Mention the Tiger bug that this demonstrates.
  • platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.checksum: Added.
  • platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.png: Added.
  • platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt: Updated expected results to reflect the new info included in the test.
  • platform/mac/editing/pasteboard/paste-RTFD-expected.checksum: Ditto.
  • platform/mac/editing/pasteboard/paste-RTFD-expected.png:
  • platform/mac/editing/pasteboard/paste-RTFD-expected.txt:
5:36 PM Changeset in webkit [29423] by alp@webkit.org
  • 5 edits in trunk/WebCore

2008-01-11 Luca Bruno <​lethalman88@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16729
[cURL] Allow multiple files for upload

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::readCallback): added (WebCore::ResourceHandleManager::setupPOST): setup for streaming the POST (WebCore::ResourceHandleManager::startJob): (WebCore::ResourceHandleManager::cancel): revert the previous patch for regression
  • platform/network/curl/ResourceHandleManager.h:
4:25 PM Changeset in webkit [29422] by alp@webkit.org
  • 3 edits in trunk/WebCore

2008-01-11 Christian Dywan <​christian@imendio.com>

Reviewed by Alp Toker.

[Gtk] Menu items need underscores
​http://bugs.webkit.org/show_bug.cgi?id=16817

Add underscores to appropriate menu labels.
Also adjust strings slightly.

  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::createNativeMenuItem):
  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::searchableIndexIntroduction): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagInspectElement): (WebCore::searchMenuClearRecentSearchesText):
3:56 PM Changeset in webkit [29421] by adachan@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/5681557> On Windows Safari, mouse events are ignored after clicking on link that triggers download
Moved the call to cache page from provisionalLoadStarted() to commitProvisionalLoad(), since
provisionalLoadStarted() can be called for cases that do not result in a page navigation, for example,
when a link to download a file has been clicked.

Reviewed by John and Anders.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::commitProvisionalLoad):
2:42 PM Changeset in webkit [29420] by jhoneycutt@apple.com
  • 2 edits in trunk/LayoutTests

2008-01-11 Jon Honeycutt <​jhoneycutt@apple.com>

  • platform/win/Skipped: Remove a test that was fixed in r29419.
2:38 PM Changeset in webkit [29419] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2008-01-11 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Anders.

<rdar://problem/5683529> plugins/embed-inside-object.html is timing
out/failing

Revert to using FrameTree::find() so that frame aliases like "_self" and
"_current" are interpreted properly

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::load):
1:58 PM Changeset in webkit [29418] by alp@webkit.org
  • 7 edits
    2 adds in trunk/WebCore

2008-01-11 Alp Toker <​alp@atoker.com>

Reviewed by Dave Hyatt and Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=16089
[GTK] Support custom fonts, CachedFont::platformDataFromCustomData()

Add support for CSS2 @font-face custom/downloadable fonts to the GTK+
port.

  • GNUmakefile.am:
  • WebCore.pro:
  • loader/CachedFont.cpp: (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::platformDataFromCustomData): (WebCore::CachedFont::allReferencesRemoved):
  • platform/graphics/gtk/FontCustomPlatformData.cpp: Added. (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::releaseData): (WebCore::createFontCustomPlatformData):
  • platform/graphics/gtk/FontCustomPlatformData.h: Added. (WebCore::FontCustomPlatformData::FontCustomPlatformData):
  • platform/graphics/gtk/FontPlatformData.h:
  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::init): (WebCore::FontPlatformData::isFixedPitch):
  • platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformDestroy):
1:04 PM Changeset in webkit [29417] by ap@webkit.org
  • 4 edits in trunk

Reviewed by Adam Roben.

<rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing

  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events, as these are only posted because the test window is not a normal visible one, and they confuse drag&drop machinery.
12:51 PM Changeset in webkit [29416] by Adam Roben
  • 2 edits in trunk/WebCore

Remove FrameLoader::committedFirstRealDocumentLoad

This method no longer has any callers.

Reviewed by Hyatt.

  • loader/FrameLoader.h:
12:50 PM Changeset in webkit [29415] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix Bug 16828: WebView never paints if first page load is canceled after being committed but before layout

<​http://bugs.webkit.org/show_bug.cgi?id=16828>
<rdar://5682402>

Now that we have 1) a real loader and 2) multiple FrameViews per
Frame, we no longer need the hackery we had in our WM_PAINT handler
that decided whether or not to paint. We now always want to paint,
letting the swapping of FrameViews that happens in
transitionToCommittedForNewPage handle which document gets painted.

Reviewed by Hyatt.

  • WebView.cpp: (WebViewWndProc): Removed hackery that decided sometimes not to paint.
12:19 PM Changeset in webkit [29414] by Antti Koivisto
  • 1 edit
    2 adds in trunk/WebCore

Add a standalone version of the blog post video player as a manual test.

  • manual-tests/resources/touch-poster.png: Added.
  • manual-tests/video-player.html: Added.
12:07 PM Changeset in webkit [29413] by alice.liu@apple.com
  • 1 edit in trunk/LayoutTests/platform/win/Skipped

test is failing on trunk-win-release, so putting it back to make it green

11:47 AM Changeset in webkit [29412] by sfalken@apple.com
  • 1 edit
    6 adds in trunk/WebKitLibraries

Add shared vsprops to help unify our Windows tools settings.

Reviewed by Hyatt.

  • win/tools: Added.
  • win/tools/WinTools.make: Added.
  • win/tools/vsprops: Added.
  • win/tools/vsprops/common.vsprops: Added.
  • win/tools/vsprops/debug.vsprops: Added.
  • win/tools/vsprops/release.vsprops: Added.
11:29 AM Changeset in webkit [29411] by alice.liu@apple.com
  • 1 edit in trunk/LayoutTests/platform/win/Skipped

removing test that doesn't fail

11:19 AM Changeset in webkit [29410] by Antti Koivisto
  • 3 edits in trunk/WebCore

Reviewed by Adam.

Fix <rdar://problem/5682767>
Video does not show up in ​http://webkit.org/blog/140/html5-media-support/ on Windows


Take care that GWorld is created and deletes when needed as size or visibility changes.

10:33 AM Mobile created by alp@atoker.com
Add a page on WebKit for mobile devices
10:27 AM Changeset in webkit [29409] by hyatt@apple.com
  • 3 edits in trunk/WebCore

Fix for bug 11188, setting hspace on a table overrides align=center. Fix align=center to be done using
mapped attributes so that it does not get overridden by hspace all the time.

Reviewed by mitz

Added fast/table/table-hspace-align-center.html

  • css/html4.css:
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute):
10:25 AM Changeset in webkit [29408] by hyatt@apple.com
  • 4 adds in trunk/LayoutTests

Add layout test for table bug.

10:15 AM Changeset in webkit [29407] by alice.liu@apple.com
  • 1 edit in trunk/LayoutTests/platform/win/Skipped

moved couple of tests to a better category

10:14 AM Changeset in webkit [29406] by Adam Roben
  • 3 edits in trunk/WebKitTools

Fix a crash when pathToLocalResource fails and a leak

Reviewed by Darin.

  • DumpRenderTree/LayoutTestController.cpp: (pathToLocalResourceCallback): Dont leak the JSStringRef, and make sure not to pass null to JSValueMakeString.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pathToLocalResource): Print an error message if the conversion fails so it's clear what happened.
8:32 AM Changeset in webkit [29405] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added some new failures.
8:31 AM Changeset in webkit [29404] by alp@webkit.org
  • 2 edits in trunk

2008-01-11 Luca Bruno <​lethalman88@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16838
[GTK] Bad autotools debug and video options

Fix some configure options.

  • configure.ac:
4:40 AM Changeset in webkit [29403] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Qt build fix.

4:26 AM Changeset in webkit [29402] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

Fix the (clean) qmake build. For generating chartables.c we don't
depend on a separate input source file anymore, the dftables perl
script is enough. So use that instead as value for the .input
variable, to ensure that qmake also generates a rule to call dftables.

3:56 AM Changeset in webkit [29401] by mrowe@apple.com
  • 2 edits in trunk/WebKit/win

Windows build fix. Update to match method name in WebCore.

3:53 AM Changeset in webkit [29400] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Qt build fix. Add link stubs for the new FileSystem.h functions introduced in r29399.

3:32 AM Changeset in webkit [29399] by mrowe@apple.com
  • 9 edits
    4 moves in trunk/WebCore

2008-01-11 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Anders Carlsson.

Bug 16779: Make the PluginStream implementation be shared across platforms
​http://bugs.webkit.org/show_bug.cgi?id=16779

Add the new shared PluginStream files to the GTK+ and Win32 builds.
Add PluginStreamClient class for the streamDidFinishLoading method.
Add open/close/write methods to FileSystem for temporary file handling.
Add PluginDebug.h and npfunctions.h for shared PluginStream.
Add shared PluginStream.
Remove PluginStreamWin.
Update PluginViewWin to use shared PluginStream and PluginStreamClass.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/FileSystem.h:
  • platform/gtk/FileSystemGtk.cpp:
  • platform/win/FileSystemWin.cpp:
  • plugins/PluginDebug.h:
  • plugins/PluginStream.cpp:
  • plugins/PluginStream.h:
  • plugins/npfunctions.h:
  • plugins/win/PluginDebug: Moved to PluginDebug.h.
  • plugins/win/PluginStreamWin.cpp: Moved to PluginStream.cpp.
  • plugins/win/PluginStreamWin.h: Moved to PluginStream.h
  • plugins/win/PluginViewWin.cpp:
  • plugins/win/PluginViewWin.h:
  • plugins/win/npfunctions.h: Moved to npfunctions.h
2:09 AM Changeset in webkit [29398] by ggaren@apple.com
  • 2 edits in trunk/WebCore

Try to fix Mac build: Edit the right .exp file.

  • WebCore.base.exp:
2:03 AM Changeset in webkit [29397] by ggaren@apple.com
  • 2 edits in trunk/WebCore

Try to fix Qt build: don't use pthreads if they're not available.

  • bindings/js/GCController.cpp:
1:52 AM Changeset in webkit [29396] by ggaren@apple.com
  • 18 edits
    2 deletes in trunk

JavaScriptCore:

Reviewed by John Sullivan.

Fixed some world leak reports:

  • <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript Interpreter after running cvs-base suite
  • <rdar://problem/5669423> PLT complains about world leak if browser window is open when PLT starts


  • kjs/collector.h: Added the ability to distinguish between global objects and GC-protected global objects, since we only consider the latter to be world leaks.
  • kjs/collector.cpp:

WebCore:

Reviewed by John Sullivan.

Fixed some world leak reports:

  • <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript Interpreter after running cvs-base suite
  • <rdar://problem/5669423> PLT complains about world leak if browser window is open when PLT starts


These were both bugs in the reporting mechanism, so I took the
opportunity to do some house cleaning there.

Stupid class, I kill you:

  • bridge/JavaScriptStatistics.cpp: Removed.
  • bridge/JavaScriptStatistics.h: Removed.
  • bindings/js/GCController.h: Adopted the only useful features of JavaScriptStatistics, since they were GC-related.
  • bindings/js/GCController.cpp:

WebKit/mac:

Reviewed by John Sullivan.

Fixed some world leak reports:

  • <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript Interpreter after running cvs-base suite
  • <rdar://problem/5669423> PLT complains about world leak if browser window is open when PLT starts


These were both bugs in the reporting mechanism, so I took the
opportunity to do some house cleaning there.

  • Misc/WebCoreStatistics.h: Did a little renaming, to match JavaScriptCore better. I kept the methods with the old names around, though, because old versions of Safari need them.
  • Misc/WebCoreStatistics.mm: Removed dependence on WebCore::JavaScriptStatistics, which is gone now.


These two methods are now distinct, for the sake of world leak reporting:
(+[WebCoreStatistics javaScriptGlobalObjectsCount]):
(+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):

WebKit/win:

Reviewed by John Sullivan.

Updated for transition away from JavaScriptStatistics, which is gone now.

  • WebJavaScriptCollector.cpp: (WebJavaScriptCollector::collect): (WebJavaScriptCollector::collectOnAlternateThread): (WebJavaScriptCollector::objectCount):

WebKitTools:

Reviewed by John Sullivan.

  • DumpRenderTree/mac/GCControllerMac.mm: (GCController::collectOnAlternateThread): Updated for name change.
12:22 AM Changeset in webkit [29395] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Silence qmake warning about ctgen lacking input. Rubber-stamped by Alp Toker.

12:04 AM Changeset in webkit [29394] by mrowe@apple.com
  • 2 edits in trunk

Attempt to fix the GTK+ and Qt builds.

Jan 10, 2008:

11:50 PM Changeset in webkit [29393] by mjs@apple.com
  • 3 edits in trunk/WebKit/win

Not reviewed, build fix.


  • more build fixing
  • WebDatabaseManager.cpp:
  • WebSecurityOrigin.h:
11:30 PM Changeset in webkit [29392] by mjs@apple.com
  • 3 edits in trunk/WebKit/win

Not reviewed, build fix.


  • try to fix build
  • WebDatabaseManager.cpp: (WebDatabaseManager::databasesWithOrigin):
  • WebSecurityOrigin.h:
9:29 PM Changeset in webkit [29391] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wx build fix. Don't build dftables any longer since it's now a Perl script.

9:12 PM Changeset in webkit [29390] by eric@webkit.org
  • 1 edit in trunk/WebCore/css/CSSGrammar.y

Add FIXME for replacing YYPARSE_PARAM with %parse-param to CSSGrammar.y

8:42 PM Changeset in webkit [29389] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Adele.

No functional changes, only code cleanup.

  • css/MediaQueryEvaluator.cpp: (WebCore::compareValue): renamed from cmpvalue (WebCore::colorMediaFeatureEval): (WebCore::device_aspect_ratioMediaFeatureEval): (WebCore::device_pixel_ratioMediaFeatureEval): (WebCore::gridMediaFeatureEval): (WebCore::device_heightMediaFeatureEval): (WebCore::device_widthMediaFeatureEval): (WebCore::heightMediaFeatureEval): (WebCore::widthMediaFeatureEval):
8:19 PM Changeset in webkit [29388] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

  • fix a crash when calling alert() from a repeating timer

On non-Mac platforms, the PageGroupLoadDeferrer pauses DOM timers during
alert() and other similar functions, which deletes the actual
DOMWindowTimer objects and replaces them with new objects when resuming.

  • bindings/js/kjs_window.cpp: (KJS::Window::timerFired): Re-fetch the timer object from the map in case it has been deleted or replaced.
7:51 PM Changeset in webkit [29387] by mjs@apple.com
  • 2 edits in trunk/WebKit/mac

Not reviewed. Build fix.


  • Attempt to fix mac build.
  • Storage/WebDatabaseManager.mm:
7:36 PM Changeset in webkit [29386] by mjs@apple.com
  • 45 edits
    2 deletes in trunk

WebCore:

Reviewed by Sam.

  • remove SecurityOriginData and fold its functionality into SecurityOrigin
  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::postMessage):
  • dom/Document.cpp: (WebCore::Document::domain):
  • page/Chrome.cpp: (WebCore::Chrome::requestQuotaIncreaseForNewDatabase): (WebCore::Chrome::requestQuotaIncreaseForDatabaseOperation):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::copy): (WebCore::SecurityOrigin::createFromIdentifier): (WebCore::SecurityOrigin::stringIdentifier):
  • platform/SecurityOrigin.h: (WebCore::SecurityOrigin::host): (WebCore::SecurityOrigin::protocol): (WebCore::SecurityOrigin::port): (WebCore::SecurityOrigin::equal):
  • platform/SecurityOriginData.cpp: Removed.
  • platform/SecurityOriginData.h: Removed.
  • storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::securityOriginCopy):
  • storage/Database.h:
  • storage/DatabaseTracker.cpp: (WebCore::SecurityOriginHash::hash): (WebCore::SecurityOriginHash::equal): (WebCore::SecurityOriginTraits::deletedValue): (WebCore::SecurityOriginTraits::emptyValue): (WebCore::DatabaseTracker::canEstablishDatabase): (WebCore::DatabaseTracker::hasEntryForOrigin): (WebCore::DatabaseTracker::hasEntryForDatabase): (WebCore::DatabaseTracker::establishEntryForOrigin): (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::populateOrigins): (WebCore::DatabaseTracker::origins): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::detailsForNameAndOrigin): (WebCore::DatabaseTracker::setDatabaseDetails): (WebCore::DatabaseTracker::usageForDatabase): (WebCore::DatabaseTracker::usageForOrigin): (WebCore::DatabaseTracker::quotaForOrigin): (WebCore::DatabaseTracker::setQuota): (WebCore::DatabaseTracker::addDatabase): (WebCore::DatabaseTracker::deleteAllDatabases): (WebCore::DatabaseTracker::deleteDatabasesWithOrigin): (WebCore::DatabaseTracker::deleteDatabase): (WebCore::DatabaseTracker::deleteDatabaseFile): (WebCore::notificationQueue): (WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged): (WebCore::DatabaseTracker::notifyDatabasesChanged):
  • storage/DatabaseTracker.h:
  • storage/DatabaseTrackerClient.h:
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::openTransactionAndPreflight): (WebCore::SQLTransaction::runStatements): (WebCore::SQLTransaction::deliverQuotaIncreaseCallback): (WebCore::SQLTransaction::postflightAndCommit): (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
  • svg/graphics/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::requestQuotaIncreaseForNewDatabase): (WebCore::SVGEmptyChromeClient::requestQuotaIncreaseForDatabaseOperation):

WebKit/gtk:

Reviewed by Sam.

  • remove SecurityOriginData and fold its functionality into SecurityOrigin
  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::requestQuotaIncreaseForNewDatabase): (WebKit::ChromeClient::requestQuotaIncreaseForDatabaseOperation):
  • WebCoreSupport/ChromeClientGtk.h:

WebKit/mac:

Reviewed by Sam.

  • remove SecurityOriginData and fold its functionality into SecurityOrigin
  • Storage/WebDatabaseManager.mm: (-[WebDatabaseManager origins]): (-[WebDatabaseManager databasesWithOrigin:]): (-[WebDatabaseManager detailsForDatabase:withOrigin:]): (-[WebDatabaseManager deleteDatabasesWithOrigin:]): (-[WebDatabaseManager deleteDatabase:withOrigin:]):
  • Storage/WebDatabaseTrackerClient.h:
  • Storage/WebDatabaseTrackerClient.mm: (WebDatabaseTrackerClient::dispatchDidModifyOrigin): (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
  • Storage/WebSecurityOrigin.mm: (-[WebSecurityOrigin initWithProtocol:domain:port:]): (-[WebSecurityOrigin protocol]): (-[WebSecurityOrigin domain]): (-[WebSecurityOrigin port]): (-[WebSecurityOrigin usage]): (-[WebSecurityOrigin quota]): (-[WebSecurityOrigin setQuota:]): (-[WebSecurityOrigin isEqual:]): (-[WebSecurityOrigin dealloc]): (-[WebSecurityOrigin finalize]): (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]): (-[WebSecurityOrigin _core]):
  • Storage/WebSecurityOriginInternal.h:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::requestQuotaIncreaseForNewDatabase): (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):

WebKit/qt:

Reviewed by Sam.

  • remove SecurityOriginData and fold its functionality into SecurityOrigin
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::requestQuotaIncreaseForNewDatabase): (WebCore::ChromeClientQt::requestQuotaIncreaseForDatabaseOperation):
  • WebCoreSupport/ChromeClientQt.h:

WebKit/win:

Reviewed by Sam.

  • remove SecurityOriginData and fold its functionality into SecurityOrigin
  • WebChromeClient.cpp: (WebChromeClient::requestQuotaIncreaseForNewDatabase): (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
  • WebChromeClient.h:
  • WebDatabaseManager.cpp: (WebDatabaseManager::origins): (WebDatabaseManager::databasesWithOrigin): (WebDatabaseManager::detailsForDatabaseWithOrigin): (WebDatabaseManager::deleteDatabasesWithOrigin): (WebDatabaseManager::deleteDatabaseWithOrigin): (WebDatabaseManager::dispatchDidModifyOrigin): (WebDatabaseManager::dispatchDidModifyDatabase):
  • WebDatabaseManager.h:
  • WebSecurityOrigin.cpp: (WebSecurityOrigin::createInstance): (WebSecurityOrigin::WebSecurityOrigin): (WebSecurityOrigin::protocol): (WebSecurityOrigin::domain): (WebSecurityOrigin::port): (WebSecurityOrigin::usage): (WebSecurityOrigin::quota): (WebSecurityOrigin::setQuota):
  • WebSecurityOrigin.h:

WebKit/wx:

Reviewed by Sam.

  • remove SecurityOriginData and fold its functionality into SecurityOrigin
  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::requestQuotaIncreaseForNewDatabase): (WebCore::ChromeClientWx::requestQuotaIncreaseForDatabaseOperation):
  • WebKitSupport/ChromeClientWx.h:
6:48 PM Changeset in webkit [29385] by Stephanie Lewis
  • 3 edits in trunk/LayoutTests

2008-01-10 Stephanie <Stephanie Lewis>

RS=Oliver.

Move svg/batik/text/smallfonts.svg to the right skip list.

  • platform/mac-tiger/Skipped:
  • platform/mac/Skipped:
6:09 PM Changeset in webkit [29384] by andersca@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam.

Use the correct frame loader load method. Using the old method would not cause a
new window to be open if the frame navigation was not allowed.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
4:55 PM Changeset in webkit [29383] by alp@webkit.org
  • 4 edits in trunk

2008-01-10 Alp Toker <​alp@atoker.com>

SVG font build fix for GTK+/autotools.

4:41 PM Changeset in webkit [29382] by ddkilzer@apple.com
  • 1 edit in trunk/JavaScriptCore/pcre/dftables

BUILD FIX: Make dftables executable.

4:35 PM Changeset in webkit [29381] by ddkilzer@apple.com
  • 10 edits
    1 move
    2 deletes in trunk

JavaScriptCore:

dftables should be rewritten as a script

<​http://bugs.webkit.org/show_bug.cgi?id=16818>
<rdar://problem/5681463>

Reviewed by Darin.

Rewrote the dftables utility in Perl. Attempted to switch all
build systems to call the script directly instead of building
a binary first. Only the Xcode build was able to be tested.

  • DerivedSources.make: Added pcre directory to VPATH and changed to invoke dftables directly.
  • GNUmakefile.am: Removed build information and changed to invoke dftables directly.
  • JavaScriptCore.vcproj/JavaScriptCore.sln: Removed reference to dftables project.
  • JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Ditto.
  • JavaScriptCore.vcproj/dftables: Removed.
  • JavaScriptCore.vcproj/dftables/dftables.vcproj: Removed.
  • JavaScriptCore.xcodeproj/project.pbxproj: Removed dftables target.
  • jscore.bkl: Removed dftables executable definition.
  • pcre/dftables: Copied from JavaScriptCore/pcre/dftables.cpp.
  • pcre/dftables.cpp: Removed.
  • pcre/dftables.pro: Removed.
  • pcre/pcre.pri: Removed references to dftables.cpp and changed to invoke dftables directly.

WebKit/win:

dftables should be rewritten as a script

<​http://bugs.webkit.org/show_bug.cgi?id=16818>
<rdar://problem/5681463>

Reviewed by Darin.

  • WebKit.vcproj/WebKit.sln: Removed reference to dftables project.
4:23 PM Changeset in webkit [29380] by weinig@apple.com
  • 15 edits
    7 adds in trunk

WebCore:

Reviewed by Sam Weinig and Anders Carlsson.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=16522
<rdar://problem/5657355>

This patch makes two changes:

1) Java calls FrameLoader::load in a slightly different way than

JavaScript, which previously let a malicious web site bypass the
shouldAllowNavigation check. This patch adds that check to that
code path.

2) FrameLoader now wraps calls to m_frame->tree()->find(name) with

findFrameForNavigation, which calls shouldAllowNavigation. This
treats disallowed frame navigations as if the named frame did not
exist, resulting in a popup window when appropriate.

Tests: http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html

http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html

  • WebCore.base.exp:
  • bindings/js/kjs_window.cpp: (KJS::WindowProtoFuncOpen::callAsFunction):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::load): (WebCore::FrameLoader::post): (WebCore::FrameLoader::findFrameForNavigation):
  • loader/FrameLoader.h:

WebKit/mac:

Reviewed by Anders Carlsson.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=16522
<rdar://problem/5657355>

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadPluginRequest:]): call findFrameForNavigation to ensure the shouldAllowNavigation check is made.

WebKitTools:

Reviewed by Anders Carlsson.

Make DRT track open windows instead of allocated windows so that
we can avoid ASSERTION due to late deallocs out of our control.

  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpBackForwardListForAllWindows): (runTest):
  • DumpRenderTree/mac/DumpRenderTreeMac.h:
  • DumpRenderTree/mac/DumpRenderTreeWindow.h:
  • DumpRenderTree/mac/DumpRenderTreeWindow.mm: (+[DumpRenderTreeWindow openWindows]): (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): (-[DumpRenderTreeWindow close]):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::windowCount):

LayoutTests:

Reviewed by Anders Carlsson.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=16522
<rdar://problem/5657355>

  • http/tests/security/frameNavigation/resources/frame-with-link-to-navigate.html: Added.
  • http/tests/security/frameNavigation/resources/frame-with-plugin-to-navigate.html: Added.
  • http/tests/security/frameNavigation/resources/navigation-happened.html: Added.
  • http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Added.
  • http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html: Added.
  • http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation-expected.txt: Added.
  • http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html: Added.
  • platform/win/Skipped:
4:10 PM Changeset in webkit [29379] by sullivan@apple.com
  • 2 edits in trunk/WebCore

Written by Hyatt, reviewed by me


  • fixed <rdar://problem/5654297> Mail crashes occurs at WebCore::FontFallbackList::fontDataAt() when attempting to display a <video> element that uses controls attribute
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement): force the render style to inherit from the media element's style; Hyatt filed 5682383 to cover cleaning up this architecture, but this one-line fix will prevent the crash in the meantime
4:02 PM Changeset in webkit [29378] by andersca@apple.com
  • 1 edit in trunk/WebCore/plugins/win/PluginViewWin.cpp

Whoops, did not mean to commit that.

4:00 PM Changeset in webkit [29377] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix fast/forms/input-radio-checked-tab.html
Meta key is not the same as Alt key on windows.

Reviewed by Darin.

  • platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
3:11 PM Changeset in webkit [29376] by adachan@apple.com
  • 2 edits in trunk/WebKitTools

Meta key is not the same as Alt key on windows.

Reviewed by Darin.

  • DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3:11 PM Changeset in webkit [29375] by adachan@apple.com
  • 2 edits in trunk/WebCore

Fix fast/forms/input-radio-checked-tab.html
Meta key is not the same as Alt key on windows.

Reviewed by Darin.

  • platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
2:17 PM Changeset in webkit [29374] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Removed a test that was fixed in r26826.
2:14 PM Changeset in webkit [29373] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Removed a test that was fixed in r28372.
1:51 PM Changeset in webkit [29372] by andersca@apple.com
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/5455889>
REGRESSION: BumperCar crashes when attempting to load a long invalid URL


Make sure to call FrameLoader::receivedMainResourceError before calling
FrameLoader::didFailToLoad. The call to receivedMainResourceError takes care of
clearing out the provisional document loader so that we won't call the didFail
ResourceLoadDelegate method twice. This also makes us call the FrameLoadDelegate method
didFailPrivisionalLoad before calling the ResourceLoadDelegate method, which Safari 2.0 does.


  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::receivedError):
1:48 PM Changeset in webkit [29371] by Antti Koivisto
  • 4 edits in trunk/WebCore

Reviewed by Adele.

Fix <rdar://problem/5658048>
After <video> has finished playing, dragging the scroller on different location of controller starts to play movie


  • Move to paused state if the playback had ended and the controller is used to seek to earlier time
  • Pause video playback during drag so the knob does not constantly try to escape from the mouse pointer
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::updateMediaPlayer): (WebCore::HTMLMediaElement::setPausedInternal):
  • html/HTMLMediaElement.h:
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler):
1:33 PM Changeset in webkit [29370] by ap@webkit.org
  • 4 edits in trunk

Reviewed by Adam Roben.

<rdar://problem/5667003> fast/dom/xmlhttprequest-html-response-encoding.html is failing

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): Do not disable sniffing for ​file:// requests, as CFNetwork doesn't perform extension to MIME type mapping then.
1:23 PM Changeset in webkit [29369] by Adam Roben
  • 9 edits in trunk

Fix many bugs by giving Windows one FrameView per page load

WebCore:

Fixes to allow multiple FrameViews on Windows

Reviewed by Hyatt.

  • page/FrameView.cpp: (WebCore::FrameView::FrameView): Added a new constructor that takes an IntSize to specify the FrameView's initial size. (WebCore::FrameView::scheduleRelayout): Added an assertion that our Document is not in the page cache.
  • page/FrameView.h:
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::~Widget): Add a warm, fuzzy ASSERT.
  • platform/qt/WidgetQt.cpp: (WebCore::Widget::~Widget): Ditto.
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::setWidget): Make sure to remove any existing Widget from the Widget hierarchy before deleting it. One instance where this is needed is when setWidget is called during FrameView creation on Windows.

WebKit/win:

Fix many bugs by giving Windows one FrameView per page load

Bugs include:

<rdar://5659200>

Windows back/forward cache causes crashes in the layout tests

<rdar://5659355>
<​http://bugs.webkit.org/show_bug.cgi?id=16808>

REGRESSION: PLT broken on Windows due to back/forward cache

<rdar://5663654>
<​http://bugs.webkit.org/show_bug.cgi?id=16607>

Random crashes in FrameView::scheduleRelayout while surfing
Thinkgeek

On Windows until now we've only had one FrameView per Frame. Once the
back/forward cache was turned on this started causing assertions to
fail and crashes to occur due to a single FrameView being both in the
back/forward cache (possibly multiple times!) and used by a live
document. We now create a new FrameView for each page load, just as
Mac does.

This has the side-effect of plugging some of the world leaks seen at
the end of the PLT.

Reviewed by Hyatt.

  • WebFrame.cpp: (WebFrame::initWithWebFrameView): Don't create the FrameView right away -- it'll be created when the load is committed. (WebFrame::transitionToCommittedFromCachedPage): Match the Mac by no longer calling resetMultipleFormSubmissionProtection here. (WebFrame::transitionToCommittedForNewPage): Ported code from -[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:], -[WebCoreFrameBridge installInFrame:], and moved code here from WebFrame::initWithWebFrameView and WebView::initWithFrame. WebCore takes care of resetMultipleFormSubmissionProtection, just like it does on the Mac.
  • WebView.cpp: (WebView::initWithFrame): Moved FrameView initialization code to WebFrame::transitionToCommittedForNewPage.
1:10 PM Changeset in webkit [29368] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-10 Alp Toker <​alp@atoker.com>

Include math.h to get ceilf(). Part of the SVG font GTK+ build fix.

  • svg/SVGFontFaceElement.cpp:
12:40 PM Changeset in webkit [29367] by justin.garcia@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Alice Liu.

<rdar://problem/5658603> Crash in InsertNodeBefore::doUnapply() on Undo in Yahoo Mail
<rdar://problem/5658709> Crash in RenderView::setSelection on Undo in Yahoo Mail


Make sure we have an updated layout before we perform any editing work.

  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): (WebCore::EditCommand::unapply): (WebCore::EditCommand::reapply):
12:29 PM Changeset in webkit [29366] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-10 Luca Bruno <​lethalman88@gmail.com>

Reviewed by Alp Toker.

Back out r29206 which was causing regressions in curl http job
cancellation.

  • platform/network/curl/ResourceHandleManager.cpp (ResourceHandleManager::cancel):
11:33 AM Changeset in webkit [29365] by kmccullough@apple.com
  • 11 edits
    4 adds in trunk

WebCore:

Reviewed by Darin, Sam, and Adam.

  • <rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
  • link in gmail message displays JavaScript alert falsely complaining about pop-up blocking
  • When trying to open a new window, we now see if the user gesture occurred in the global dynamic object instead of the frame since that is the only place an event can occur.
  • bindings/js/kjs_window.cpp: - Check the dynamic global object instead of the frame. (KJS::allowPopUp): (KJS::showModalDialog): (KJS::WindowProtoFuncOpen::callAsFunction):

WebKitTools:

Reviewed by Darin, Sam and Adam.

-<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
link in gmail message displays JavaScript alert falsely complaining
about pop-up blocking.

  • Added the ability to enable the pop-up blocker via the LayoutTestController.
  • DumpRenderTree/LayoutTestController.cpp: (setPopupBlockingEnabledCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setPopupBlockingEnabled):

LayoutTests:

Reviewed by Darin, Sam, and Adam.

-<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
link in gmail message displays JavaScript alert falsely complaining
about pop-up blocking

  • When trying to open a new window, we now see if the user gesture occurred in the global dynamic object instead of the frame since that is the only place an event can occur.
  • fast/events/open-window-from-another-frame-expected.txt: Added.
  • fast/events/open-window-from-another-frame.html: Added.
  • fast/events/resources/open-window-from-another-frame-otherFrame.html: Added.
  • fast/events/resources/window-opened.html: Added.
  • platform/win/Skipped:
11:29 AM Changeset in webkit [29364] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix for bug 16247, visibility:hidden not honored when hit testing inline replaced elements.

Reviewed by adele

Added fast/css/visibility-hit-test.html test case.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint):
11:28 AM Changeset in webkit [29363] by hyatt@apple.com
  • 4 adds in trunk/LayoutTests

Add new layout test for visibility bug.

9:39 AM Changeset in webkit [29362] by mitz@apple.com
  • 5 edits
    1 move in trunk

JavaScriptCore:

Reviewed by Darin Adler.

The crash resulted from a native object (DumpRenderTree's
EventSender) causing its wrapper to be invalidated (by clicking a
link that replaced the document in the window) and consequently
deallocated. The fix is to use RefPtrs to protect the native object
from deletion by self-invalidation.

  • bindings/runtime_method.cpp: (RuntimeMethod::callAsFunction):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter): (RuntimeObjectImp::put): (RuntimeObjectImp::defaultValue): (RuntimeObjectImp::callAsFunction):

LayoutTests:

Reviewed by Darin Adler.

  • fast/replaced/image-map-expected.txt: Updated results for the new behavior, which is to replace the document with the success message.
  • fast/replaced/image-map.html: Copied from LayoutTests/fast/replaced/image-map.html-disabled.
  • fast/replaced/image-map.html-disabled: Removed.
8:47 AM Changeset in webkit [29361] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

document QWebHistory

8:47 AM Changeset in webkit [29360] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Make the reset() functions not do anything on the default QWebSettings object.

8:47 AM Changeset in webkit [29359] by Simon Hausmann
  • 10 edits
    3 moves in trunk

rename QWebPageHistory to QWebHistory.

8:39 AM Changeset in webkit [29358] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Documentation for QWebSettings

8:38 AM Changeset in webkit [29357] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Document QWebHistoryInterface.

8:38 AM Changeset in webkit [29356] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

Documentation for QWebFrame.

8:19 AM Changeset in webkit [29355] by Simon Hausmann
  • 7 edits in trunk

fix the drawing errors that where introduced due to refactoring.

Correctly clip to the rectangle we want to draw in ScrollView::paint().

Signed-off-by: Simon

8:19 AM Changeset in webkit [29354] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Added a whole bunch of docs for QWebPage and fixed some minor doc glitches in QWebView.

Signed-off-by: Lars

8:19 AM Changeset in webkit [29353] by Simon Hausmann
  • 2 edits in trunk/WebCore

Temporarily disable gzip decompression in qhttp due to a bug.

Signed-off-by: Lars

7:28 AM Changeset in webkit [29352] by Simon Hausmann
  • 7 edits in trunk/WebCore

​http://bugs.webkit.org/show_bug.cgi?id=16588

Added a (last) Frame argument to ResourceHandle::loadResourceSynchronously.
This allows implementing the synchronous loading correctly for the Qt port where the networking
backend is bound to the page.

Signed-off-by: Lars

7:22 AM Changeset in webkit [29351] by mitz@apple.com
  • 5 edits in trunk/LayoutTests

Reviewed by John Sullivan.

  • make more tests pass on Windows by forcing font fallback to match Mac OS X.
  • fast/css/beforeSelectorOnCodeElement.html:
  • fast/css/rtl-ordering.html:
  • fast/css/text-security.html:
  • platform/win/Skipped:
12:49 AM Changeset in webkit [29350] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix for changes in r29328

Jan 9, 2008:

7:48 PM Changeset in webkit [29349] by mjs@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Sam.

  • refactor SecurityOrigin in preparation for merging with SecurityOriginData
  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::create): (WebCore::SecurityOrigin::createForFrame):
  • platform/SecurityOrigin.h:
7:03 PM Changeset in webkit [29348] by adachan@apple.com
  • 6 edits
    1 copy
    1 add in trunk

WebCore:

Tabs with ctrl, meta, or altgraph modifier key down should not advance focus.

Reviewed by Darin.

Test: fast/forms/tabs-with-modifiers.html

  • page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): (WebCore::EventHandler::defaultTabEventHandler): bail if ctrl, meta, or altgraph key is down. Clean up the code a bit.
  • page/EventHandler.h:
  • page/FocusController.cpp: Remove the advanceFocus() that takes in a KeyboardEvent. It was only called in EventHandler::defaultTabEventHandler() but we have cleaned up the code there and no longer needs it.
  • page/FocusController.h:


LayoutTests:

Tests tabbing with different combinations of modifiers keys, where some
should advance focus and some should not.

Reviewed by Darin.

  • fast/forms/tabs-with-modifiers-expected.txt: Added.
  • fast/forms/tabs-with-modifiers.html: Copied from fast/forms/focus2.html.


6:57 PM Changeset in webkit [29347] by adachan@apple.com
  • 2 edits in trunk/WebKit/win

Fix crash that could happen if the key we are passing to the HashMap is 0 in WebView::interpretKeyEvent().

Reviewed by Darin.

  • WebView.cpp: (WebView::interpretKeyEvent):
6:51 PM Changeset in webkit [29346] by mjs@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.


  • add some more renames, adjust some
  • Scripts/do-webcore-rename:
5:41 PM Changeset in webkit [29345] by Antti Koivisto
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=16376
<rdar://problem/5665206>
<video> element fails to play frames when navigating back to page (16376)


Don't make MediaPlayer visible when it is actually in page cache.

  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::updatePlayer):
5:38 PM Changeset in webkit [29344] by andersca@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5532361>
CrashTracer: 9840 crashes in Safari at com.apple.JavaScriptCore: KJS::Bindings::CInstance::~CInstance [in-charge deleting] + 35


Clear the frame's plugin root objects so that they don't outlive the plugin bundle.


  • page/Frame.cpp: (WebCore::Frame::pageDestroyed):
5:37 PM Changeset in webkit [29343] by mitz@apple.com
  • 2 edits
    4 moves
    1 delete in trunk/LayoutTests

Reviewed by Darin Adler.

  • move a WebKit test which was inadvertently added to a test suite directory into a custom test directory and change it to give the same results on Windows.
  • css1/text_properties/text-transCapitalize.html: Removed.
  • fast/text/capitalize-boundaries.html: Copied from LayoutTests/css1/text_properties/text-transCapitalize.html, updated the Bugzilla URL and added @font-face rules to make Windows results match Mac OS X.
  • platform/mac/css1/text_properties/text-transCapitalize-expected.checksum: Removed.
  • platform/mac/css1/text_properties/text-transCapitalize-expected.png: Removed.
  • platform/mac/css1/text_properties/text-transCapitalize-expected.txt: Removed.
  • platform/mac/fast/text/capitalize-boundaries-expected.checksum: Copied from LayoutTests/platform/mac/css1/text_properties/text-transCapitalize-expected.checksum.
  • platform/mac/fast/text/capitalize-boundaries-expected.png: Copied from LayoutTests/platform/mac/css1/text_properties/text-transCapitalize-expected.png.
  • platform/mac/fast/text/capitalize-boundaries-expected.txt: Copied from LayoutTests/platform/mac/css1/text_properties/text-transCapitalize-expected.txt.
  • platform/qt/css1/text_properties/text-transCapitalize-expected.txt: Removed.
  • platform/win/Skipped: Removed css1/text_properties/text-transCapitalize.html.
3:02 PM Changeset in webkit [29342] by sullivan@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben and Anders Carlsson


  • fixed <rdar://problem/5469398> Repro assertion failure in context menu code due to missing-but-expected Reload item
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): use isLoadingInAPISense when deciding whether to include Stop or Reload in context menu, to match the WebKit API
12:26 PM Changeset in webkit [29341] by alp@webkit.org
  • 4 edits in trunk/WebKit/gtk

2008-01-09 Luca Bruno <​lethalman88@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16802
[GTK] Missing gtk properties


Add missing properties to WebKitViewFrame and WebKitWebView.


  • WebView/webkitprivate.h: add some useful defines for param specs
  • WebView/webkitwebframe.cpp: (webkit_web_frame_get_property): added (webkit_web_frame_class_init): add name, title and uri read-only properties
  • WebView/webkitwebview.cpp: (webkit_web_view_get_property): add editable property read (webkit_web_view_set_property): added for editable property write (webkit_web_view_class_init): add read-write editable property
12:13 PM Changeset in webkit [29340] by ap@webkit.org
  • 3 edits in trunk/LayoutTests

Reviewed by Adam Roben.

<rdar://problem/5673716> fast/loader/opaque-base-url.html is failing
<rdar://problem/5670275> fast/loader/onunload-form-submit-crash.html is failing
<rdar://problem/5667277> fast/loader/onunload-form-submit-crash-2.html is failing

  • fast/loader/meta-refresh-vs-open.html: Changed to be more DRT-friendly.
  • platform/win/Skipped: Removed tests that were victims of the above.
12:10 PM Changeset in webkit [29339] by ap@webkit.org
  • 4 edits in trunk/LayoutTests

Reviewed by Adam Roben.

Fix fast/encoding/frame-default-enc.html, which is failing on buildbot.

Internal frame names for this test are changing for no apparent reason (see r25269).
Make the test independent of the names.

  • fast/encoding/frame-default-enc-expected.txt:
  • fast/encoding/frame-default-enc.html:
  • fast/encoding/resources/frame-default-enc-frame.html:
10:03 AM Changeset in webkit [29338] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix Windows debug build for opensource developers.

  • WebCore.vcproj/QTMovieWin.vcproj: Use the correct library suffix.
10:01 AM Changeset in webkit [29337] by Adam Roben
  • 6 edits in trunk/LayoutTests

Update some test results

Reviewed by Anders.

  • fast/dom/Window/window-properties-expected.txt: Updated after r29328.
  • platform/win/media/audio-controls-rendering-expected.txt: Regenerated results with the correct fonts.
  • platform/win/media/video-aspect-ratio-expected.txt: Ditto.
  • platform/win/media/video-controls-rendering-expected.txt: Ditto.
  • platform/win/media/video-transformed-expected.txt: Ditto.
8:32 AM ApplicationsGtk edited by alp@atoker.com
Add a mail client (diff)
1:23 AM Changeset in webkit [29336] by eric@webkit.org
  • 8 edits
    16 adds in trunk

Reworked by Eric, Reviewed by Hyatt.

Tests: fast/selectors/lang-inheritance.html

fast/selectors/lang-inheritance2.html
fast/selectors/lang-vs-xml-lang.html
fast/selectors/lang-vs-xml-lang-xhtml.xhtml

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): Do not share style between elements with different LANG-attribute. (WebCore::CSSStyleSelector::checkOneSelector): Change :lang() to recursively check the LANG attribute for all the elements parents and the content-language of the document.
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): Parse MIME Content-Language
  • dom/Document.h: (WebCore::Document::contentLanguage): (WebCore::Document::setContentLanguage):
Note: See TracTimeline for information about the timeline view.