Timeline



Jan 26, 2008:

8:21 PM Changeset in webkit [29815] by Darin Adler
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Oliver.

Test: fast/js/function-toString-parentheses.html

The problem here was that a NumberNode with a negative number in it had the wrong
precedence. It's not a primary expression, it's a unary operator with a primary
expression after it.

Once the precedence of NumberNode was fixed, the cases from bug 17020 were also
fixed without trying to treat bracket nodes like dot nodes. That wasn't needed.
The reason we handle numbers before dot nodes specially is that the dot is a
legal character in a number. The same is not true of a bracket. Eventually we
could get smarter, and only add the parentheses when there is actual ambiguity.
There is none if the string form of the number already has a dot in it, or if
it's a number with a alphabetic name like infinity or NAN.

  • kjs/nodes.h: Renamed back from ObjectAccess to DotExpr. (KJS::NumberNode::precedence): Return PrecUnary for negative numbers, since they serialize as a unary operator, not a primary expression.
  • kjs/nodes2string.cpp: (KJS::SourceStream::operator<<): Clear m_numberNeedsParens if this adds parens; one set is enough. (KJS::bracketNodeStreamTo): Remove unneeded special flag here. Normal operator precedence suffices. (KJS::NewExprNode::streamTo): Ditto.

LayoutTests:

Reviewed by Oliver.

  • fast/js/function-toString-parentheses-expected.txt: Updated.
  • fast/js/resources/function-toString-parentheses.js: More test cases.
8:10 PM Changeset in webkit [29814] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix leaks seen after loading <​http://www.funnyordie.com/videos/d70b5a11cb>.

Reviewed by Darin Adler.

  • Misc/WebNSDataExtras.m:

(-[NSString _web_capitalizeRFC822HeaderFieldName]): Transfer ownerhip of the allocated buffers
to the new CFString so that they will be freed when no longer needed.

6:16 PM Changeset in webkit [29813] by oliver@apple.com
  • 5 edits in trunk

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=17020
Function.toString does not parenthesise numbers for the bracket accessor

Reviewed by Maciej and Darin.

It turns out that logic was there for all of the dot accessor nodes to make numbers be
parenthesised properly, so it was a trivial extension to extend that to the bracket nodes.
I renamed the enum type to reflect the fact that it is now used for both dot and bracket
accessors.

4:40 PM Changeset in webkit [29812] by oliver@apple.com
  • 5 edits in trunk

Fix Bug 17018: Incorrect code generated from Function.toString for get/setters in object literals

Reviewed by Darin.

Don't quote getter and setter names during output, as that is simply wrong.

4:17 PM Changeset in webkit [29811] by ddkilzer@apple.com
  • 4 edits
    1 delete in trunk/WebKit

WebKit:

<rdar://problem/5708388> WebDashboardRegion.h duplicated between WebCore / WebKit

Reviewed by Darin.

  • WebKit.xcodeproj/project.pbxproj: Removed WebDashboardRegion.h.

WebKit/mac:

<rdar://problem/5708388> WebDashboardRegion.h duplicated between WebCore / WebKit

Reviewed by Darin.

  • WebCoreSupport/WebDashboardRegion.h: Removed.
  • WebView/WebView.mm: Updated #import to use copy of WebDashboardRegion.h from WebCore.
10:55 AM Changeset in webkit [29810] by Darin Adler
  • 10 edits in trunk/JavaScriptCore

Reviewed by Eric Seidel.

  • JavaScriptCore.exp: Export the GlobalExecState constructor instead of the global flavor of the ExecState constructor. It'd probably be cleaner to not export either one, but JSGlobalObject inlines the code that constructs the ExecState. If we changed that, we could remove this export.
  • JavaScriptCore.xcodeproj/project.pbxproj: Re-sorted a few things and put the new source files into the kjs group rather than at the top level.
  • kjs/ExecState.cpp: (KJS::ExecState::ExecState): Marked inline and updated for data member name changes. This is now only for use for the derived classes. Also removed code that sets the unused m_savedExec data member for the global case. That data member is only used for the other two types. (KJS::ExecState::~ExecState): Marked inline and removed all the code. The derived class destructors now inclde the appropriate code. (KJS::ExecState::lexicalGlobalObject): Removed unneeded special case for an empty scope chain. The bottom function already returns 0 for that case, so the general case code handles it fine. Also changed to use data members directly rather than calling functions. (KJS::GlobalExecState::GlobalExecState): Added. Calls through to the base class constructor. (KJS::GlobalExecState::~GlobalExecState): Added. (KJS::InterpreterExecState::InterpreterExecState): Added. Moved code to manipulate activeExecStates here since we don't want to have to check for the special case of globalExec. (KJS::InterpreterExecState::~InterpreterExecState): Added. (KJS::EvalExecState::EvalExecState): Added. (KJS::EvalExecState::~EvalExecState): Added. (KJS::FunctionExecState::FunctionExecState): Added. (KJS::FunctionExecState::~FunctionExecState): Added.
  • kjs/ExecState.h: Tweaked the header, includes, and declarations a bit. Made ExecState inherit from Noncopyable. Reformatted some comments and made them a bit more brief. Rearranged declarations a little bit and removed unused savedExec function. Changed seenLabels function to return a reference rather than a pointer. Made constructors and destructor protected, and also did the same with all data members. Renamed m_thisVal to m_thisValue and ls to m_labelStack. Added three new derived classes for each of the types of ExecState. The primary goal here was to remove a branch from the code in the destructor, but it's also clearer than overloading the arguments to the ExecState constructor.
  • kjs/JSGlobalObject.cpp: (KJS::getCurrentTime): Fixed formatting. (KJS::JSGlobalObject::pushActivation): Removed parentheses that don't make the expression clearer -- other similar sites didn't have these parentheses, even the one a couple lines earlier that sets stackEntry. (KJS::JSGlobalObject::tearOffActivation): Got rid of unneeded static_cast (I think I mentioned this during patch review) and used an early exit so that the entire contents of the function aren't nested inside an if statement. Also removed the check of codeType, instead checking Activation for 0. For now, I kept the codeType check, but inside an assertion.
  • kjs/JSGlobalObject.h: Changed type of globalExec to GlobalExecState.
  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): Changed type to FunctionExecState. (KJS::GlobalFuncImp::callAsFunction): Changed type to EvalExecState.
  • kjs/interpreter.cpp: (KJS::Interpreter::evaluate): Changed type to GlobalExecState.
  • kjs/nodes.cpp: (KJS::ContinueNode::execute): Changed code since seenLabels() returns a reference now instead of a pointer. (KJS::BreakNode::execute): Ditto. (KJS::LabelNode::execute): Ditto.
10:27 AM Changeset in webkit [29809] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

Cleanup node2string a little.

  • Remove some unnecessary branching.
  • Factor out bracket and dot streaming into static inline functions.
  • kjs/nodes.h:
  • kjs/nodes2string.cpp: (KJS::bracketNodeStreamTo): (KJS::dotNodeStreamTo): (KJS::FunctionCallBracketNode::streamTo): (KJS::FunctionCallDotNode::streamTo): (KJS::PostIncBracketNode::streamTo): (KJS::PostDecBracketNode::streamTo): (KJS::PostIncDotNode::streamTo): (KJS::PostDecDotNode::streamTo): (KJS::DeleteBracketNode::streamTo): (KJS::DeleteDotNode::streamTo): (KJS::PreIncBracketNode::streamTo): (KJS::PreDecBracketNode::streamTo): (KJS::PreIncDotNode::streamTo): (KJS::PreDecDotNode::streamTo): (KJS::ReadModifyBracketNode::streamTo): (KJS::AssignBracketNode::streamTo): (KJS::ReadModifyDotNode::streamTo): (KJS::AssignDotNode::streamTo): (KJS::WhileNode::streamTo):
9:58 AM Changeset in webkit [29808] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

<rdar://problem/5707607> REGRESSION: I hear a beep when selecting Alt-enter in address or search fields


Reviewed by Oliver.

  • WebView.cpp: (WebView::keyDown): Allow alt-return to be marked as handled by WebKit.
4:32 AM Changeset in webkit [29807] by mrowe@apple.com
  • 2 edits in trunk

Fix ​http://bugs.webkit.org/show_bug.cgi?id=17007 ([GTK] autogen.sh attempts to use "libtoolize" on the Mac).

Reviewed by Alp Toker.

libtoolize is installed as glibtoolize on Mac OS X to avoid naming conflicts
with other system commands. Check for the presence of glibtoolize if libtoolize
cannot be found.

  • autogen.sh:
2:01 AM Changeset in webkit [29806] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix ​http://bugs.webkit.org/show_bug.cgi?id=17001 (Build error with Gtk port on Mac OS X).

Reviewed by Darin Adler.

If both XP_MACOSX and XP_UNIX are defined then X11.h and Carbon.h will both be included.
These provide conflicting definitions for a type named 'Cursor'. As XP_UNIX is set by
the build system when targeting X11, it doesn't make sense for XP_MACOSX to also be set
in this instance.

  • bindings/npapi.h: Don't define XP_MACOSX if XP_UNIX is defined.
1:42 AM Changeset in webkit [29805] by eric@webkit.org
  • 23 edits in trunk/WebCore

Reviewed by Sam and Darin.

Fire a warning shot in DeprecatedChar's direction.

Remove DeprecatedChar::isSpace() usage, in preparation for removing DeprecatedChar
Remove a needless String -> DeprecatedString -> String conversion for <script> tags

  • css/MediaQueryEvaluator.cpp: (WebCore::parseAspectRatio):
  • css/SVGCSSParser.cpp:
  • dom/Position.cpp: (WebCore::Position::leadingWhitespacePosition): (WebCore::Position::trailingWhitespacePosition):
  • editing/TextIterator.cpp: (WebCore::WordAwareIterator::advance):
  • html/HTMLFontElement.cpp: (WebCore::parseFontSizeNumber):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::notifyFinished):
  • html/HTMLTokenizer.h:
  • loader/CachedCSSStyleSheet.cpp:
  • loader/TextResourceDecoder.cpp:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::getData):
  • platform/network/HTTPParsers.cpp: (WebCore::extractMIMETypeFromMediaType):
  • platform/text/PlatformString.h:
  • platform/text/StringImpl.cpp: (WebCore::parseLength): (WebCore::StringImpl::stripWhiteSpace): (WebCore::StringImpl::simplifyWhiteSpace): (WebCore::StringImpl::toInt): (WebCore::StringImpl::toInt64): (WebCore::StringImpl::toUInt64):
  • platform/text/StringImpl.h: (WebCore::isSpaceOrNewline):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
  • rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine):
  • svg/SVGFontFaceElement.cpp: (WebCore::mapAttributeToCSSProperty):
  • svg/SVGLength.cpp:
  • svg/SVGStyledElement.cpp: (WebCore::mapAttributeToCSSProperty):
  • xml/XPathParser.cpp:
1:01 AM Changeset in webkit [29804] by Darin Adler
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Oliver.

Test: fast/js/toString-for-var-decl.html

  • kjs/nodes.h: Added PlaceholderTrueNode so we can put nodes into for loops without injecting the word "true" into them (nice, but not the bug fix). Fixed ForNode constructor so expr1WasVarDecl is set only when there is an expression, since it's common for the actual variable declaration to be moved by the parser.
  • kjs/nodes2string.cpp: (KJS::PlaceholderTrueNode::streamTo): Added. Empty.

LayoutTests:

Reviewed by Oliver.

  • fast/js/resources/toString-for-var-decl.js: Streamlined the test a bit, with more of the execution within shouldBe so that exceptions are caught for us. Added a new test case reflecting the just-fixed bug.
  • fast/js/toString-for-var-decl-expected.txt: Updated.

Jan 25, 2008:

11:58 PM Changeset in webkit [29803] by oliver@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix typo in changelog

11:54 PM Changeset in webkit [29802] by oliver@apple.com
  • 6 edits in trunk

Fix for bug 17012: REGRESSION: JSC can't round trip an object literal

Reviewed by Maciej.

Add logic to ensure that object literals and function expressions get
parenthesis when necessary.

5:16 PM Changeset in webkit [29801] by Stephanie Lewis
  • 1 edit in trunk/WebCore/ChangeLog

fix changelog

5:09 PM Changeset in webkit [29800] by Stephanie Lewis
  • 2 edits in trunk/WebCore

2008-01-25 U-SLEWIS-WIN\Stephanie <Stephanie Lewis>

Reviewed by Tim.

expand workaround for <rdar://5695848> to include js files so that the
web inspector can work

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse):
5:03 PM Changeset in webkit [29799] by Antti Koivisto
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by Adele.


(this is for r29798, my commit failed to include the log)


Windows fix to match r29773
If the media is playing and the load stalls the playback wont restart by seeking backwards.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::updateStates):
3:41 PM Changeset in webkit [29798] by Antti Koivisto
  • 1 edit in trunk/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp

Reviewed by Adele.


Windows fix to match r29773
If the media is playing and the load stalls the playback wont restart by seeking backwards.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::updateStates):
3:40 PM Changeset in webkit [29797] by Darin Adler
  • 12 edits
    2 adds in trunk

WebCore:

Reviewed by Anders.

  • fix <rdar://problem/5691072> ASSERTION FAILED: isPrepared() when executing an empty statement

For empty statements, SQLite returns 0 for the statement. We have to cope with that.

Test: storage/empty-statement.html

  • platform/sql/SQLiteStatement.cpp: (WebCore::sqlite3_prepare16_v2): Added overload so we don't need an #if inside the prepare function. (WebCore::SQLiteStatement::SQLiteStatement): Initialize the m_isPrepared boolean. Removed the code to add a null character to the end of the string; instead we will use charactersWithNullTermination. (WebCore::SQLiteStatement::prepare): Set m_isPrepared based on the error value returned. Use the error value from sqlite3_prepare16_v2, not from lastError(). (WebCore::SQLiteStatement::step): Assert that the statement is prepared rather than checking it at runtime. However, in the case where this is called with m_statement of 0, return success rather than an error. That's needed for empty statements. (WebCore::SQLiteStatement::finalize): Use early return idiom for clarity. When there is no statement, return SQLITE_OK instead of calling lastError(). (WebCore::SQLiteStatement::reset): Use early return idiom for clarity. When there is no statement, return SQLITE_OK rather than SQLITE_ERROR, but assert the statement is prepared. (WebCore::SQLiteStatement::executeCommand): Adjust the code that does a prepare so that it will work for empty statements. Do we really need to allow calling this without prepare? It would be simpler to just be able to assert that it's prepared. (WebCore::SQLiteStatement::returnsAtLeastOneResult): Ditto. (WebCore::SQLiteStatement::bindBlob): Added some assertions. Return SQLITE_ERROR if this is called with m_statement of 0 (should not be possible without assertions firing first). Return the actual error code rather than lastError(). (WebCore::SQLiteStatement::bindText): Ditto. Also simplified the special case for empty strings, since it requires any non-null pointer, not a pointer to a global zero character. (WebCore::SQLiteStatement::bindInt64): Ditto. (WebCore::SQLiteStatement::bindDouble): Ditto. (WebCore::SQLiteStatement::bindNull): Ditto. (WebCore::SQLiteStatement::bindValue): Moved default case out of the switch to take advantage of the gcc compiler warning for unhandled enum values in a switch. (WebCore::SQLiteStatement::bindParameterCount): Added assertion and code to handle the empty statement case. (WebCore::SQLiteStatement::columnCount): Added assertion and changed the code to use the early-return idiom. (WebCore::SQLiteStatement::getColumnName): Removed getColumnName16 -- we always use 16-bit characters and have no reason to ever use the 8-bit function. Added assertions about the passed-in column number. It's a little strange that this function checks the column number for too-large column numbers, but not for negative ones. I didn't change that for now. (WebCore::SQLiteStatement::getColumnText): Ditto. (WebCore::SQLiteStatement::getColumnDouble): Ditto. (WebCore::SQLiteStatement::getColumnInt): Ditto. (WebCore::SQLiteStatement::getColumnInt64): Ditto. (WebCore::SQLiteStatement::getColumnBlobAsVector): Ditto. (WebCore::SQLiteStatement::getColumnBlob): Tightened up function a bit, including use of the early-return idiom and replacing the multiple "size = 0" with a single one at the start of the function. (WebCore::SQLiteStatement::returnTextResults): Added a failure case when the prepare call doesn't work. Cleared the vector earlier to make the failure code simpler. Moved the declaration of the result boolean down lower to make it clearer what it's for. Changed use of lastError() to call on the database, to make it clearer that there's no per-statement last error kept around. It'd be even better to not use lastError() here. (WebCore::SQLiteStatement::returnIntResults): Ditto. (WebCore::SQLiteStatement::returnInt64Results): Ditto. (WebCore::SQLiteStatement::returnDoubleResults): Ditto.
(WebCore::SQLiteStatement::isExpired): Changed to use
rather than ?: because I think

it's slightly easier to read that way.

  • platform/sql/SQLiteStatement.h: Removed unneeded includes and forward declarations. Also removed unnneeded functions isPrepared, getColumnName16, getColumnText16, returnTextResults16, lastError, and lastErrorMsg. Changed prepareAndStep so that it checks the result of prepare before callling step. Added a debug-only m_isPrepared boolean.
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::checkIntegrity): Remove 16 suffix from text-related function names. (WebCore::IconDatabase::performURLImport): Ditto. (WebCore::IconDatabase::pruneUnretainedIcons): Ditto.
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::clearAllTables): Ditto.
  • storage/Database.cpp: (WebCore::retrieveTextResultFromDatabase): Ditto. (WebCore::Database::performGetTableNames): Ditto.
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabase): Ditto. (WebCore::DatabaseTracker::populateOrigins): Ditto. (WebCore::DatabaseTracker::databaseNamesForOrigin): Ditto. (WebCore::DatabaseTracker::addDatabase): Ditto.
  • storage/SQLStatement.cpp: (WebCore::SQLStatement::execute): Ditto.
  • platform/sql/SQLiteDatabase.h: Removed unneeded includes.
  • storage/SQLResultSet.h: Ditto.
  • storage/SQLResultSetRowList.h: Ditto.

LayoutTests:

Reviewed by Anders.

  • test for <rdar://problem/5691072> ASSERTION FAILED: isPrepared() when executing an empty statement
  • storage/empty-statement-expected.txt: Added.
  • storage/empty-statement.html: Added.
3:07 PM Changeset in webkit [29796] by Antti Koivisto
  • 7 edits in trunk/LayoutTests

Reviewed by Darin.


Fix <rdar://problem/5674282>
Some media tests fail on Windows


  • fix the script to exit cleanly
  • slightly increase the amount of data to hand out before stalling, apparently QT on Windows needs more to start playback
2:28 PM Changeset in webkit [29795] by adele@apple.com
  • 89 edits
    4 adds in trunk

WebCore:

Reviewed by Sam.

Fix for <rdar://problem/5679452> Finish tweaking layout/alignment of media controls slider to match QuickTime plug-in

  • css/html4.css: Add horizontal padding to the media slider.
  • rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler): Replace use of absoluteBoundingBox() with width() and height() (WebCore::RenderSlider::positionForOffset): ditto. Also, use the trackSize() for the maximum offset. (WebCore::RenderSlider::layout): Use contentWidth() and contentHeight() to take padding into account. (WebCore::RenderSlider::trackSize): ditto.

LayoutTests:

Reviewed by Sam.

Adding new test and updated results for:
<rdar://problem/5679452> Finish tweaking layout/alignment of media controls slider to match QuickTime plug-in

  • fast/forms/slider-padding.html: Added.
  • platform/mac/fast/forms/slider-padding-expected.checksum: Added.
  • platform/mac/fast/forms/slider-padding-expected.png: Added.
  • platform/mac/fast/forms/slider-padding-expected.txt: Added.
  • platform/mac/media/audio-controls-rendering-expected.checksum:
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/broken-video-expected.checksum:
  • platform/mac/media/broken-video-expected.png:
  • platform/mac/media/progress-event-expected.checksum:
  • platform/mac/media/progress-event-expected.png:
  • platform/mac/media/unsupported-rtsp-expected.checksum:
  • platform/mac/media/unsupported-rtsp-expected.png:
  • platform/mac/media/unsupported-tracks-expected.checksum:
  • platform/mac/media/unsupported-tracks-expected.png:
  • platform/mac/media/video-append-source-expected.checksum:
  • platform/mac/media/video-append-source-expected.png:
  • platform/mac/media/video-autoplay-expected.checksum:
  • platform/mac/media/video-autoplay-expected.png:
  • platform/mac/media/video-buffered-expected.checksum:
  • platform/mac/media/video-buffered-expected.png:
  • platform/mac/media/video-controls-expected.checksum:
  • platform/mac/media/video-controls-expected.png:
  • platform/mac/media/video-controls-rendering-expected.checksum:
  • platform/mac/media/video-controls-rendering-expected.png:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-currentTime-set2-expected.checksum:
  • platform/mac/media/video-currentTime-set2-expected.png:
  • platform/mac/media/video-display-toggle-expected.checksum:
  • platform/mac/media/video-display-toggle-expected.png:
  • platform/mac/media/video-display-toggle-expected.txt:
  • platform/mac/media/video-dom-autoplay-expected.checksum:
  • platform/mac/media/video-dom-autoplay-expected.png:
  • platform/mac/media/video-dom-src-expected.checksum:
  • platform/mac/media/video-dom-src-expected.png:
  • platform/mac/media/video-dom-start-expected.checksum:
  • platform/mac/media/video-dom-start-expected.png:
  • platform/mac/media/video-error-abort-expected.checksum:
  • platform/mac/media/video-error-abort-expected.png:
  • platform/mac/media/video-error-does-not-exist-expected.checksum:
  • platform/mac/media/video-error-does-not-exist-expected.png:
  • platform/mac/media/video-load-networkState-expected.checksum:
  • platform/mac/media/video-load-networkState-expected.png:
  • platform/mac/media/video-load-readyState-expected.checksum:
  • platform/mac/media/video-load-readyState-expected.png:
  • platform/mac/media/video-muted-expected.checksum:
  • platform/mac/media/video-muted-expected.png:
  • platform/mac/media/video-no-autoplay-expected.checksum:
  • platform/mac/media/video-no-autoplay-expected.png:
  • platform/mac/media/video-pause-empty-events-expected.checksum:
  • platform/mac/media/video-pause-empty-events-expected.png:
  • platform/mac/media/video-play-empty-events-expected.checksum:
  • platform/mac/media/video-play-empty-events-expected.png:
  • platform/mac/media/video-play-pause-events-expected.checksum:
  • platform/mac/media/video-play-pause-events-expected.png:
  • platform/mac/media/video-play-pause-exception-expected.checksum:
  • platform/mac/media/video-play-pause-exception-expected.png:
  • platform/mac/media/video-seek-past-end-paused-expected.checksum:
  • platform/mac/media/video-seek-past-end-paused-expected.png:
  • platform/mac/media/video-seek-past-end-playing-expected.checksum:
  • platform/mac/media/video-seek-past-end-playing-expected.png:
  • platform/mac/media/video-seekable-expected.checksum:
  • platform/mac/media/video-seekable-expected.png:
  • platform/mac/media/video-seeking-expected.checksum:
  • platform/mac/media/video-seeking-expected.png:
  • platform/mac/media/video-size-expected.checksum:
  • platform/mac/media/video-size-expected.png:
  • platform/mac/media/video-source-expected.checksum:
  • platform/mac/media/video-source-expected.png:
  • platform/mac/media/video-source-media-expected.checksum:
  • platform/mac/media/video-source-media-expected.png:
  • platform/mac/media/video-source-type-expected.checksum:
  • platform/mac/media/video-source-type-expected.png:
  • platform/mac/media/video-src-change-expected.checksum:
  • platform/mac/media/video-src-change-expected.png:
  • platform/mac/media/video-src-expected.checksum:
  • platform/mac/media/video-src-expected.png:
  • platform/mac/media/video-src-remove-expected.checksum:
  • platform/mac/media/video-src-remove-expected.png:
  • platform/mac/media/video-src-set-expected.checksum:
  • platform/mac/media/video-src-set-expected.png:
  • platform/mac/media/video-src-source-expected.checksum:
  • platform/mac/media/video-src-source-expected.png:
  • platform/mac/media/video-start-expected.checksum:
  • platform/mac/media/video-start-expected.png:
  • platform/mac/media/video-volume-expected.checksum:
  • platform/mac/media/video-volume-expected.png:
  • platform/mac/media/video-width-height-expected.checksum:
  • platform/mac/media/video-width-height-expected.png:
1:38 PM Changeset in webkit [29794] by Antti Koivisto
  • 3 edits in trunk/LayoutTests

<rdar://problem/5674277>
Test media/video-display-toggle.html crashes on Windows


Appears to be some problem in DRT when test ends with layout pending.
Fixed by forcing layout, this improves test coverage too.

  • media/video-display-toggle.html:
  • platform/win/Skipped:
10:31 AM Changeset in webkit [29793] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-01-25 Ori Bernstein <​ori@eigenstate.org>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=16795
WebKitGtk crashes when there is no focused Frame

Add a null check. focusedFrame() isn't used directly anywhere else so
this is the only case that needs to be fixed.

  • WebView/webkitwebview.cpp:
7:01 AM Changeset in webkit [29792] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

<rdar://problem/5706788> http/tests/security/cross-frame-access-port-explicit-domain.html fails on Windows

  • platform/win/Skipped:
6:42 AM Changeset in webkit [29791] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

http/tests/xmlhttprequest/readystatechange.html fails on buildbot.

  • platform/win/Skipped:
3:45 AM Changeset in webkit [29790] by ap@webkit.org
  • 3 edits in trunk/WebKitTools

Reviewed by Mark Rowe.

<rdar://problem/5699933> http/tests/security/cross-frame-access-get.html is still failing

  • DumpRenderTree/win/DumpRenderTree.cpp: (main): Clear HTTP cache to ensure consistent test environment (matching Mac DRT).
  • DumpRenderTree/win/DumpRenderTree.vcproj: Link to CFNetwork.
1:14 AM S60IDE edited by mgroeber@gmx.net
Adding info about missing variant.cfg update (diff)

Jan 24, 2008:

5:50 PM Changeset in webkit [29789] by sfalken@apple.com
  • 3 edits in tags/Safari-5525.6.1/WebKit/win

Merged r29785

5:49 PM Changeset in webkit [29788] by sfalken@apple.com
  • 2 edits in tags/Safari-5525.6.1/JavaScriptCore

Merged r29784

5:46 PM Changeset in webkit [29787] by sfalken@apple.com
  • 2 edits in tags/Safari-5525.6.1/JavaScriptCore

Merged r29783

5:16 PM Changeset in webkit [29786] by sfalken@apple.com
  • 1 copy in tags/Safari-5525.6.1

New tag.

5:13 PM Changeset in webkit [29785] by sfalken@apple.com
  • 3 edits in trunk/WebKit/win

Build fix

  • WebKit.vcproj/WebKit.sln:
  • WebKit.vcproj/WebKit.submit.sln:
5:08 PM Changeset in webkit [29784] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix.

5:07 PM Changeset in webkit [29783] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix.

4:51 PM Changeset in webkit [29782] by weinig@apple.com
  • 6 edits in trunk

WebKitTools:

Reviewed by Ada Chan.

Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo

  • Adds simplified UndoManager to windows DRT to allow testing the undo/redo code paths in WebCore and WebKit. This is a temporary solution to an issue that should eventually be solved by having a shared UndoManager in WebKit.
  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest):
  • DumpRenderTree/win/UIDelegate.cpp: (DRTUndoObject::DRTUndoObject): (DRTUndoObject::invoke): (DRTUndoStack::~DRTUndoStack): (DRTUndoStack::isEmpty): (DRTUndoStack::clear): (DRTUndoStack::push): (DRTUndoStack::pop): (DRTUndoManager::canRedo): (DRTUndoManager::canUndo): (DRTUndoManager::DRTUndoManager): (DRTUndoManager::removeAllActions): (DRTUndoManager::registerUndoWithTarget): (DRTUndoManager::redo): (DRTUndoManager::undo): (UIDelegate::UIDelegate): (UIDelegate::resetUndoManager): (UIDelegate::registerUndoWithTarget): (UIDelegate::removeAllActionsWithTarget): (UIDelegate::setActionTitle): (UIDelegate::undo): (UIDelegate::redo): (UIDelegate::canUndo): (UIDelegate::canRedo):
  • DumpRenderTree/win/UIDelegate.h:

LayoutTests:

Reviewed by Ada Chan.

<rdar://5131975> DumpRenderTree doesn't support undo/redo

  • platform/win/Skipped: With undo/redo support enabled, we can now remove the undo tests from the Skipped list.
3:50 PM Changeset in webkit [29781] by Adam Roben
  • 6 edits in trunk/WebCore

Better fix for Bug 16996

Rubberstamped by Mitz.

  • loader/CachedFont.cpp: (WebCore::CachedFont::ensureCustomFontData): Don't call createFontCustomPlatformData if m_data is null.
  • platform/graphics/gtk/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Added an assertion.
  • platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Ditto.
  • platform/graphics/qt/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Ditto.
  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Ditto.
3:13 PM Changeset in webkit [29780] by Adam Roben
  • 3 edits
    2 adds in trunk

Fix Bug 16996: Crash in createFontCustomPlatformData when loading 0-byte font via @font-face

WebCore:

Fix Bug 16996: Crash in createFontCustomPlatformData when loading
0-byte font via @font-face

<​http://bugs.webkit.org/show_bug.cgi?id=16996>

Reviewed by Hyatt.

Test: fast/loader/font-face-empty.html

  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData): Null-check the buffer parameter.

LayoutTests:

Test for Bug 16996: Crash in createFontCustomPlatformData when loading
0-byte font via @font-face

<​http://bugs.webkit.org/show_bug.cgi?id=16996>

Reviewed by Hyatt.

  • fast/loader/font-face-empty-expected.txt: Added.
  • fast/loader/font-face-empty.html: Added.
2:02 PM Changeset in webkit [29779] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/editing/selection/end-of-document-expected.txt

Update results for an editing test that changed from Acid3 fix.

1:53 PM Changeset in webkit [29778] by jhoneycutt@apple.com
  • 6 edits
    1 add in trunk/WebCore

2008-01-24 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Anders.

<rdar://problem/5588807> Crash in Flash when destroying plug-in (found
using yahoo beta mail)

Flash can dereference NULL in the call to NPP_URLNotify if a request
made with NPN_PostURLNotify fails before NPP_NewStream is called.

Work around this by creating a quirk, PluginQuirkFlashURLNotifyBug, and
checking for this quirk before calling NPP_URLNotify for any request
made with NPN_PostURLNotify. If the quirk is present, call NPP_NewStream
and NPP_DestroyStream before calling NPP_URLNotify.

  • WebCore.vcproj/WebCore.vcproj:
  • plugins/PluginQuirkSet.h: Added. Moved quirks out of PluginViewWin so PluginViewWin and PluginStream could share it. Created a class, PluginQuirkSet, to store plug-in quirks (WebCore::): (WebCore::PluginQuirkSet::PluginQuirkSet): (WebCore::PluginQuirkSet::add): (WebCore::PluginQuirkSet::contains):
  • plugins/PluginStream.cpp: (WebCore::PluginStream::PluginStream): Copy the PluginQuirkSet for this plug-in (WebCore::PluginStream::destroyStream): Check for the FlashURLNotifyBug quirk
  • plugins/PluginStream.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): Pass the quirks when creating the PluginStream (WebCore::PluginViewWin::didReceiveResponse): Same (WebCore::PluginViewWin::wndProc): Use add / contains instead of bit ops (WebCore::PluginViewWin::userAgent): Same (WebCore::PluginViewWin::invalidateRect): Same (WebCore::PluginViewWin::~PluginViewWin): Same (WebCore::PluginViewWin::determineQuirks): Same (WebCore::PluginViewWin::setParameters): Same (WebCore::PluginViewWin::PluginViewWin): Same (WebCore::PluginViewWin::init): Same (WebCore::PluginViewWin::setCallingPlugin): Same
  • plugins/win/PluginViewWin.h:
1:52 PM Changeset in webkit [29777] by hyatt@apple.com
  • 3 adds in trunk/LayoutTests/platform/mac/fast/parser

Add test results for Acid3 buckets parsing issue.

1:51 PM Changeset in webkit [29776] by hyatt@apple.com
  • 1 add in trunk/LayoutTests/fast/parser/style-script-head-test.html

Add test of Acid3 buckets parsing issue.

1:49 PM Changeset in webkit [29775] by hyatt@apple.com
  • 2 edits in trunk/WebCore

​http://bugs.webkit.org/show_bug.cgi?id=16982

Make sure to make <head> the current block if it is created before a <body> already exists.

Reviewed by Dan

  • html/HTMLParser.cpp: (WebCore::HTMLParser::createHead):
11:40 AM Changeset in webkit [29774] by ap@webkit.org
  • 4 edits
    2 deletes in trunk

​http://bugs.webkit.org/show_bug.cgi?id=16993
<rdar://problem/5704331> REGRESSION: Loading page leads to many unexpected redirections

Rolled out r29590, which was not a correct fix for <rdar://problem/5692566>.

10:24 AM Changeset in webkit [29773] by Antti Koivisto
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Adam.


If the media is playing and the load stalls the playback wont restart by seeking backwards.


We should be in CAN_PLAY state if the current time is less than the maximum loaded time. Rate
tricks were for streaming case and are not necessary now since that is now disabled.


Windows patch coming separately.

Test: http/tests/media/video-play-stall-seek.html

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates):

LayoutTests:

Reviewed by Adam.


Test that playback can be resumed by seeking backwards after a stall.

  • http/tests/media/video-play-stall-seek-expected.txt: Added.
  • http/tests/media/video-play-stall-seek.html: Added.
  • platform/win/Skipped:
10:18 AM Changeset in webkit [29772] by Antti Koivisto
  • 11 edits in trunk/WebCore

Reviewed by Adam.

Fix <rdar://problem/5684815>
After navigating back to the page that contains a <audio> that has been muted, the audio is still heard


  • get rid of the separate muted state in MediaPlayer, maintain the state in the cross platform code only
  • remove volumeChanged() callbacks from HTMLMediaElement and OS X MediaPlayer, they were not used for anything
  • rename updateMediaPlayer -> updatePlayState which tells more about what it actually does
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::play): (WebCore::HTMLMediaElement::pause): (WebCore::HTMLMediaElement::setVolume): (WebCore::HTMLMediaElement::setMuted): (WebCore::HTMLMediaElement::checkIfSeekNeeded): (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): (WebCore::HTMLMediaElement::updateVolume): (WebCore::HTMLMediaElement::updatePlayState): (WebCore::HTMLMediaElement::setPausedInternal):
  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer):
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  • platform/graphics/win/QTMovieWin.cpp:
  • platform/graphics/win/QTMovieWin.h:
9:38 AM Changeset in webkit [29771] by Adam Roben
  • 2 edits in trunk/WebKit/win

Build fix

  • WebView.cpp: Added a comma.
9:27 AM Changeset in webkit [29770] by Adam Roben
  • 2 edits in trunk/WebKitTools

Allow directories containing ChangeLogs to be passed to resolve-ChangeLogs

Reviewed by David Kilzer.

  • Scripts/resolve-ChangeLogs: (sub findChangeLog): Return a ChangeLog contained within the specified directory if one exists.
8:36 AM Changeset in webkit [29769] by ap@webkit.org
  • 2 edits in trunk/WebKit/win

Reviewed by Adam Roben.

<rdar://problem/5702734> REGRESSION(r28936/r15890): Shift+del does not work in win Safari

  • WebView.cpp: Fixed keyDownEntries to list this shortcut (and related ones, for consistency).
6:52 AM Changeset in webkit [29768] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Fix "QObject::startTimer: QTimer can only be used with threads started with QThread"
  • The JSC GCController gets automatically destructed on application exit, it will stop its timer and we try to schedule the next timer. Now the GCController can get destructed after our QApplication is gone. This will trigger the above warning, we can avoid this by checking if our qApp is still around.
6:27 AM Changeset in webkit [29767] by Simon Hausmann
  • 2 edits in trunk/WebCore

Morten Johan Sørvig <​msorvig@trolltech.com>

Qt/Mac: Make sure the scrollbars does not overlap the grow box.

When showing only one scrollbar we need to move it so it doesn't overlap the
grow box. This is similar to the code in QAbstractScrollArea.

6:24 AM Changeset in webkit [29766] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

David Boddie <​dboddie@trolltech.com>

Documentation tidying.

6:23 AM Changeset in webkit [29765] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Jarek Kobus <​jkobus@trolltech.com>

Text for translations were used wrongly as comments

6:18 AM Changeset in webkit [29764] by Simon Hausmann
  • 3 edits
    2 adds in trunk

Michael Goddard <​michael.goddard@trolltech.com>

​http://bugs.webkit.org/show_bug.cgi?id=16888

Fix for CSS crash in -webkit-border-image.
Reviewed by Darin.

While parsing -webkit-border-image, store
the border widths as naked pointers rather
than as OwnPtrs, since they point to the
middle of an array.

Test: fast/css/border-image-crash.html

6:13 AM Changeset in webkit [29763] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • We have a KURL->QUrl conversion on KURL itself, make use of it.
  • This conversion is supposed to be loss-free
6:08 AM Changeset in webkit [29762] by Simon Hausmann
  • 3 edits in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Attempt to fix showing of popup again after a popup has been shown but the user did not select any item (e.g. clicked outside of the popup)
  • Keep track of the popup status using the virtuals showPopup and hidePopup and do not go into recursion when hiding a popup.
6:01 AM Changeset in webkit [29761] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Assert the presence of the PopupMenuClient
5:56 AM Changeset in webkit [29760] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Michael Goddard <​michael.goddard@trolltech.com>

Fix QDateTime to JS Date conversion.
Several conversion errors (some UTC related, some month
offset related) and the conversion distance for Date
to DateTime conversion weights were fixed (it should never
be better to convert a JS Number into a Date rather than
an int).

5:51 AM Changeset in webkit [29759] by Simon Hausmann
  • 6 edits in trunk/JavaScriptCore

Michael Goddard <​michael.goddard@trolltech.com>

Add support for calling QObjects.
Add support for invokeDefaultMethod (via a call to
a specific slot), and also allow using it as a
constructor, like QtScript.

5:44 AM Changeset in webkit [29758] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Michael Goddard <​michael.goddard@trolltech.com>

Code style cleanups.
Add spaces before/after braces in inline function.

5:41 AM Changeset in webkit [29757] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Michael Goddard <​michael.goddard@trolltech.com>

Code style cleanups.
Remove spaces and unneeded declared parameter names.

5:37 AM Changeset in webkit [29756] by Simon Hausmann
  • 4 edits in trunk/JavaScriptCore

Michael Goddard <​michael.goddard@trolltech.com>

Clear stale RuntimeObjectImps.
Since other objects can have refs to the QtInstance,
we can't rely on the QtInstance being deleted when the
RuntimeObjectImp is invalidate or deleted. This
could result in a stale JSObject being returned for
a valid Instance.

Jan 23, 2008:

11:44 PM Changeset in webkit [29755] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

11:42 PM Changeset in webkit [29754] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.6

New tag.

4:47 PM Changeset in webkit [29753] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/5702947> WebCore: CGContextDrawPDFDocument will be deprecated

Reviewed by Darin.

No test cases added since there is no change in behavior.

  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::draw): Replace CGContextDrawPDFDocument() with calls to CG methods that perform the equivalent work.
3:08 PM Changeset in webkit [29752] by Antti Koivisto
  • 4 edits in trunk/WebCore

Reviewed by Hyatt, Adele.

Timers for media controls keep running when the page is in the page cache.


Stop timers in RenderMedia and get rid of the controls tree when the page goes to the cache.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::willSaveToCache): (WebCore::HTMLMediaElement::didRestoreFromCache):
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::inPageCache):
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):
2:26 PM Changeset in webkit [29751] by Antti Koivisto
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Video that had already played to the end would start playing (from beginning) on back/forward navigation.


Use setPausedInternal() instead of pause(). This avoid generating pause/play events and matches specification text.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::willSaveToCache):
2:20 PM Changeset in webkit [29750] by ap@webkit.org
  • 5 edits
    6 adds in trunk

Reviewed by Darin.

<rdar://problem/4200075> Missing support for accented chars in mailto forms

With some combinations of form parameters, this was resulting in regressed behavior.

Tests: fast/forms/mailto/get-non-ascii-text-plain-latin-1.html

fast/forms/mailto/post-text-plain-with-accept-charset.html
fast/forms/mailto/post-text-plain.html

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): Ignore accept-charset for mailto forms, which are always encoded as UTF-8. (WebCore::HTMLFormElement::isMailtoForm): Added. (WebCore::HTMLFormElement::dataEncoding): Added (factored out from formData). (WebCore::HTMLFormElement::submit): When round-tripping in text/plain case, use utf-8 encoding.
  • html/HTMLFormElement.h: Added a isMailtoForm() function. It may be a bit unfortunate that its result is calculated repeatedly, but this doesn't seem to be anywhere near hot code.
2:04 PM Changeset in webkit [29749] by sfalken@apple.com
  • 7 edits in trunk

WebCore:

Reviewed by Alice Liu.

<rdar://problem/5658727> Undo/redo for pasted or typed text in yahoo mail becomes disabled after one round of being selected

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::updateFromElement): If value == text() and m_innerText is empty, then value and text() are "". In that case both DOM mutations are no-ops and there is no reason to clear the Undo stack.

WebKit/win:

<rdar://problem/5698732> Copyright strings should include 2008


Reviewed by Sam.

  • WebKit.vcproj/WebKit.rc:

WebKitTools:

<rdar://problem/5698732> Copyright strings should include 2008

Reviewed by Sam.

  • Drosera/win/Drosera.vcproj/Drosera.rc:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
1:51 PM Changeset in webkit [29748] by justin.garcia@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Alice Liu.

<rdar://problem/5658727> Undo/redo for pasted or typed text in yahoo mail becomes disabled after one round of being selected

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::updateFromElement): If value == text() and m_innerText is empty, then value and text() are "". In that case both DOM mutations are no-ops and there is no reason to clear the Undo stack.

LayoutTests:

Reviewed by Alice Liu.


<rdar://problem/5658727> Undo/redo for pasted or typed text in yahoo mail becomes disabled after one round of being selected

  • editing/undo/5658727-expected.txt: Added.
  • editing/undo/5658727.html: Added.
1:08 PM Changeset in webkit [29747] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix <rdar://5698502> Inspector window reverts to default position/size unexpectedly

Reviewed by Hyatt.

  • WebInspectorClient.cpp: (defaultWindowRect): Added. (WebInspectorClient::createPage):
    • Use defaultWindowRect() to set the initial size/position of the Inspector window.
    • Pass the Inspector window's client rect to IWebView::initWithFrame so that the WebView will be initially sized to fill the window.

(WebInspectorClient::showWindow): Don't move/resize the window back to
the defaults every time this method is called.

1:07 PM Changeset in webkit [29746] by Adam Roben
  • 3 edits
    2 adds in trunk

Fix <rdar://5700620> REGRESSION (r28190): "Open frame in new tab" instead of "Open link in new tab" @ digg.com

WebKit/win:

Fix <rdar://5700620> REGRESSION (r28190): "Open frame in new tab" instead of "Open link in new tab" @ digg.com

Test: fast/events/contextmenu-scrolled-page-with-frame.html

Reviewed by Dan.

  • WebView.cpp: (WebView::handleContextMenuEvent): Translate the mouse coordinates into document coordinates before performing the hit-test. This is what EventHandler does internally.

LayoutTests:

Add a test for <rdar://5700620> REGRESSION (r28190): "Open frame in
new tab" instead of "Open link in new tab" @ digg.com

Reviewed by Dan.

  • fast/events/contextmenu-scrolled-page-with-frame-expected.txt: Added.
  • fast/events/contextmenu-scrolled-page-with-frame.html: Added.
11:43 AM Changeset in webkit [29745] by sfalken@apple.com
  • 9 edits in trunk

WebCore:

<rdar://problem/5699509> Allow file upload dialog to be localized.

Reviewed by Darin.

  • platform/LocalizedStrings.h:
  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::openFileChooser):

WebKit:

Update localization exceptions.


Reviewed by Darin.

  • English.lproj/Localizable.strings:
  • StringsNotToBeLocalized.txt:

WebKit/win:

<rdar://problem/5699509> Allow file upload dialog to be localized.


Reviewed by Darin.

  • English.lproj/Localizable.strings: Updated.
  • WebCoreLocalizedStrings.cpp: (WebCore::uploadFileText): Added. (WebCore::allFilesText): Added.
9:49 AM Changeset in webkit [29744] by dsmith@webkit.org
  • 1 edit
    19 adds in trunk/WebKitSite

Reviewed by Darin.


Added a modified version of the MooTools SlickSpeed Selector Test/Benchmark to show off querySelectorAll. MIT licensed.

  • perf/slickspeed: Added.
  • perf/slickspeed/config.ini: Added.
  • perf/slickspeed/footer.html: Added.
  • perf/slickspeed/frameworks: Added.
  • perf/slickspeed/frameworks/DomQuery.js: Added.
  • perf/slickspeed/frameworks/dummy.js: Added.
  • perf/slickspeed/frameworks/jquery-1.2.1.js: Added.
  • perf/slickspeed/frameworks/prototype.js: Added.
  • perf/slickspeed/header.html: Added.
  • perf/slickspeed/index.php: Added.
  • perf/slickspeed/instructions.txt: Added.
  • perf/slickspeed/logo.png: Added.
  • perf/slickspeed/selectors.list: Added.
  • perf/slickspeed/style.css: Added.
  • perf/slickspeed/system: Added.
  • perf/slickspeed/system/index.php: Added.
  • perf/slickspeed/system/slickspeed.js: Added.
  • perf/slickspeed/system/template.php: Added.
  • perf/slickspeed/template.html: Added.
9:38 AM Changeset in webkit [29743] by Adam Roben
  • 2 edits in trunk/WebCore

Fix behavior of type-to-select in <select> menus

In r27825 we started posting both a WM_KEYDOWN and WM_CHAR message
whenever a key was pressed in the dropdown menu. However, since posted
messages go through TranslateMessage, the WM_KEYDOWN was generating
another WM_CHAR message, so two WM_CHAR messages in a row would reach
the WebView. This caused the searching to happen twice for each key,
so typing "dog" would search for "ddoogg".

Reviewed by Darin.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc): Repost the WM_KEYDOWN message to the WebView. This is will generate a WM_CHAR message which will trigger the type-to-select behavior. This is very similar to our behavior prior to r27825, except that we're now calling PostMessage instead of SendMessage.
8:18 AM Changeset in webkit [29742] by mitz@apple.com
  • 4 edits in trunk/LayoutTests
  • platform/mac/fast/frames/viewsource-attribute-expected.checksum:
  • platform/mac/fast/frames/viewsource-attribute-expected.png:
  • platform/mac/fast/frames/viewsource-attribute-expected.txt:
7:55 AM Changeset in webkit [29741] by alp@webkit.org
  • 8 edits in trunk

2008-01-23 Alp Toker <​alp@atoker.com>

Rubber-stamped by Mark Rowe.

Remove whitespace after -I in automake include lists.

3:16 AM Changeset in webkit [29740] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Fix leaking of sub frames (WebCore::Frame). We keep one reference too many. This was found while working on the page-cache, other ports are not affected.
  • Rubber stamped by Simon
3:14 AM Changeset in webkit [29739] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Load images incrementally. This will show warnings on the console and we want to fix them for Qt4.4. If that happens we have to remove the comment from the enum inside the ImageDecoderQt.cpp
  • Rubber stamped by Simon
3:11 AM Changeset in webkit [29738] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Rohan McGovern <​rohan.mcgovern@trolltech.com>

Fix Qtopia compilation with QT_NO_TOOLTIP

3:11 AM Changeset in webkit [29737] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Geir Vattekar <​gvatteka@trolltech.com>

Doc: Replaced \code with snippets in the docs

3:10 AM Changeset in webkit [29736] by Simon Hausmann
  • 2 edits in trunk/WebCore

Lars Knoll <​lars@trolltech.com>

Fix rendering of the Scrollbar as well as mouse handling for some styles.

The QStyle expects that that painter is set up to clip to the scrollbar bounds
and some of the styles seem to paint somewhat outside of these bounds. Clipping to
the scrollbar bounds before drawing removes some artifacts.

Also set m_opt.rect.topLeft to (0/0) in the mouse handlers. Fixes some issues with
the oxygen style.

1:55 AM Changeset in webkit [29735] by Simon Hausmann
  • 3 edits in trunk/WebCore

Michael Brasser <​michael.brasser@trolltech.com>

Rendering fixes for Qtopia.

Make the focus ring work with line breaks (until we have QPainterPath::simplify) and
call QStyle with better arguments when painting themed elements.

1:55 AM Changeset in webkit [29734] by Simon Hausmann
  • 3 edits in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • FormData::flatten does not include to be uploaded files. Create our own QIODevice for the QNetworkAccessManager and feed the complete content of the FormData* to the (HTTP) backend.
  • Try to optimize the ::readData implementation to fill the buffer as best as possible
1:55 AM Changeset in webkit [29733] by Simon Hausmann
  • 2 edits in trunk/WebCore

Holger Hans Peter Freyther <​holger.freyther@trolltech.com>

  • Coding-Style fixes
1:48 AM Changeset in webkit [29732] by Simon Hausmann
  • 2 edits in trunk/WebCore

Michael Brasser <​michael.brasser@trolltech.com>

use PopupClient's font for popup menu. Otherwise, in Qtopia, the popup's font is much bigger (QApplication::font()?) and the text doesn't fit.

1:44 AM Changeset in webkit [29731] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Benjamin Meyer <​bmeyer@trolltech.com>

Tweak key presses even to match commonly expected behavior

  • space key == page down
  • page down moved down not a page, but slightly less then a page so you don't loose your spot when reading.
  • Use font height rather then a hard coded "10" for left, right, up, down
  • Ctrl-Up moves to the top of the page
  • Ctrl-Down move to the bottom of the page
  • Backspace == GoBack
  • Shift-Backspace == GoForward
1:43 AM Changeset in webkit [29730] by Simon Hausmann
  • 7 edits in trunk

Implemented FrameLoaderClient::startDownload() and FrameLoaderClient::download().

Added two signals to QWebPage to handle downloading of links and handling of
unsupported content.

1:39 AM Changeset in webkit [29729] by Simon Hausmann
  • 12 edits in trunk

Michael Goddard <​michael.goddard@trolltech.com>

Reworked the JavaScriptCore Qt bindings:

  • Add initial support for string and variant arrays, as well as sub QObjects in the JS bindings.
  • Don't expose fields marked as not scriptable by moc.
  • Add support for dynamic properties and accessing named QObject children of an object (like QtScript and older IE DOM style JS).
  • Add support for custom toString methods.
  • Fine tune some bindings to be closer to QtScript. Make void functions return undefined, and empty/ null QStrings return a zero length string.
  • Create framework for allowing more direct method calls. Since RuntimeMethod doesn't allow us to add additional methods/properties to a function, add these classes. Start prototyping object.signal.connect(...).
  • Add signal support to the Qt bindings. Allow connecting to signals (object.signal.connect(slot)), disconnecting, and emitting signals. Currently chooses the first signal that matches the name, so this will need improvement.
  • Add property names, and resolve signals closer to use. Enumerating properties now returns some of the Qt properties and signals. Slots and methods aren't quite present. Also, resolve signal connections etc. closer to the time of use, so we can do more dynamic resolution based on argument type etc. Still picks the first one with the same name, at the moment.
  • Make signature comparison code consistent. Use the same code for checking meta signatures in the method and fallback getters, and avoid a QByteArray construction when we can.
  • Fix minor memory leak, and handle pointers better. Delete the private object in the dtors, and use RefPtrs for holding Instances etc.
  • Handle method lookup better. Allow invocation time method lookup based on the arguments, which is closer to QtScript behaviour. Also, cache the method lists and delete them in the QtClass dtor (stops a memory leak).
  • Improve JS to Qt data type conversions. Add some support for Date & RegExp JS objects, and provide some metrics on the quality of the conversion.
  • A couple of fixes for autotest failures. Better support for converting lists, read/write only QMetaProperty support, modified slot search order...)
  • Update JS DRT controller for Qt JS binding changes. There were two functions that needed some changes so that the layout tests would work, so this makes a few tests pass again.
  • Bump the timeout for layout tests up to 11s. At least some tests have an internal timeout of 10 seconds, so make the waitUntilDone approach wait at least 11s. fast/dom/open-and-close-by-DOM.html is one of these - now the failure message is more accurate.

Jan 22, 2008:

8:01 PM Changeset in webkit [29728] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adele Peterson.

The regression test for this is fast/css/css2-system-color.html which
is currently disabled.

  • rendering/RenderThemeMac.mm: (WebCore::menuBackgroundColor): Added. Uses HIThemeDrawMenuBackground to draw the menu item background into a bitmap graphics context and returns the color of the pixel at (0, 0). (WebCore::RenderThemeMac::systemColor): Changed to call menuBackgroundColor for the CSS2 menu color.
4:29 PM Changeset in webkit [29727] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

  • turn full repainting back on for <canvas> until we get incremental repaint working properly

Ollie and I came up with a plan for testing this, but for now we should
just fall back on the "repaint everything" behavior we have always had.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::willDraw): Just call repaint.
3:16 PM Changeset in webkit [29726] by andersca@apple.com
  • 5 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Darin and Adam.

<rdar://problem/5688975>
div element on microsoft site has wrong left offset.


Return true even if NPN_GetProperty returns null or undefined. This matches Firefox
(and is what the Silverlight plug-in expects).


  • bindings/NP_jsobject.cpp: (_NPN_GetProperty):

WebKitTools:

Reviewed by Darin and Adam.

<rdar://problem/5688975>
div element on microsoft site has wrong left offset.


Add new method for testing the return vale of NPN_GetProperty.


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginInvoke):

LayoutTests:

Reviewed by Darin and Adam.

<rdar://problem/5688975>
div element on microsoft site has wrong left offset.


Add test.


  • plugins/netscape-get-property-return-value-expected.txt: Added.
  • plugins/netscape-get-property-return-value.html: Added.
1:23 PM Changeset in webkit [29725] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-01-22 Alp Toker <​alp@atoker.com>

GTK+/qmake build fix.

  • WebCore.pro:
12:46 PM Changeset in webkit [29724] by ap@webkit.org
  • 4 edits in trunk

Reviewed by Adam Roben.

<rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail

  • DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.
12:45 PM Changeset in webkit [29723] by alp@webkit.org
  • 9 edits
    2 adds
    2 deletes in trunk

2008-01-22 Christian Dywan <​christian@imendio.com>

Reviewed by Alp Toker.

[GTK] API: WebKitWebSettings is not usable
​http://bugs.webkit.org/show_bug.cgi?id=16219

Implement WebKitWebSettings.

11:33 AM Changeset in webkit [29722] by Adam Roben
  • 6 edits
    9 adds in trunk

Fix <rdar://5693599> REGRESSION (r29369): scroll bars are drawing when they shouldn't be on an ad on cnn.com

WebCore:

Add HTMLFrameOwnerElement::scrollingMode

This new virtual method is overridden by HTMLFrameElementBase to
provide the scrolling mode set on the frame or iframe element. Object
elements always have scrolling=auto, so there's no need to override
this method for HTMLPlugInElement.

Reviewed by Hyatt.

  • html/HTMLFrameElementBase.h: Declare scrollingMode as virtual.
  • html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::scrollingMode): Added.

WebKit/win:

Fix <rdar://5693599> REGRESSION (r29369): scroll bars are drawing when they shouldn't be on an ad on cnn.com

Now that we have multiple FrameViews per Frame on Windows, we need to
make sure each FrameView gets its scrolling mode set correctly. On Mac
this works because WebFrameView holds the scrolling mode and a single
WebFrameView is shared by many FrameViews. On Windows, we have no such
shared object, so we just ask the Frame's owner element for the
scrolling mode.

Tests: fast/frames/frame-scrolling-attribute.html

fast/frames/iframe-scrolling-attribute.html

Reviewed by Hyatt.

  • WebFrame.cpp: (WebFrame::transitionToCommittedForNewPage): Set the scrolling mode on the FrameView based on the scrolling mode of the Frame's owner element.

LayoutTests:

Tests for <rdar://5693599> REGRESSION (r29369): scroll bars are drawing when they shouldn't be on an ad on cnn.com

Reviewed by Hyatt.

  • fast/frames/frame-scrolling-attribute.html: Added.
  • fast/frames/iframe-scrolling-attribute.html: Added.
  • platform/mac/fast/frames/frame-scrolling-attribute-expected.checksum: Added.
  • platform/mac/fast/frames/frame-scrolling-attribute-expected.png: Added.
  • platform/mac/fast/frames/frame-scrolling-attribute-expected.txt: Added.
  • platform/mac/fast/frames/iframe-scrolling-attribute-expected.checksum: Added.
  • platform/mac/fast/frames/iframe-scrolling-attribute-expected.png: Added.
  • platform/mac/fast/frames/iframe-scrolling-attribute-expected.txt: Added.
9:36 AM Changeset in webkit [29721] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5698481> REGRESSION: Web Inspector source view gutter double divider and no padding

Now that cellpadding cascades properly on <td>s, we need to make the view source padding rules in the user
agent sheet have !important in order to override author settings.

Reviewed by Tim

  • css/view-source.css:
8:09 AM Changeset in webkit [29720] by Nikolas Zimmermann
  • 5 edits in trunk/WebCore

Reviewed by Alp.
Allow to use SVGPaintServerSolid without RenderObject/RenderStyle. Used later to draw SVG Fonts in HTML.

6:57 AM Changeset in webkit [29719] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Reviewed by Alp.

Initialize missing variables, m_lineGap / m_lineSpacing.
Only noticeable when trying to render HTML text using SVG Fonts (which is not possible with trunk, but with my local version).

5:53 AM Changeset in webkit [29718] by alp@webkit.org
  • 4 edits in trunk/WebCore

2008-01-22 Alp Toker <​alp@atoker.com>

Reviewed by Nikolas.

Fix Cairo SVG fonts following changes in r29700.

Set the font description's details as needed in FontPlatformData and
eliminate GraphicsContext::setPlatformFont() since it was redundant
and assumed all fonts were Cairo fonts.

  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData):
3:10 AM Changeset in webkit [29717] by Nikolas Zimmermann
  • 3 edits
    4 adds in trunk

Reviewed by Eric.

<rdar://problem/5699344> Reproducible crash when navigating back to a page using SVG fonts

Test: svg/custom/font-platformDestroy-crash.svg

2:03 AM Changeset in webkit [29716] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Lars Knoll <​lars@trolltech.com>

setup a family for cursive and fantasy fonts as well.

2:03 AM Changeset in webkit [29715] by Simon Hausmann
  • 2 edits in trunk/WebCore

Lars Knoll <​lars@trolltech.com>

cleanup the CookieJarQt implementation and implement cookiesEnabled.

2:03 AM Changeset in webkit [29714] by Simon Hausmann
  • 2 edits in trunk

Simon Hausmann <Simon Hausmann>

Don't compile the ICO plugin when building against Qt >= 4.4

2:03 AM Changeset in webkit [29713] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

Benjamin Meyer <​bmeyer@trolltech.com>

Implement ChromeClientQt::setToolTip
Implement ChromeClientQt::mouseDidMoveOverElement

12:38 AM Changeset in webkit [29712] by Simon Hausmann
  • 19 edits
    1 add in trunk

Lars Knoll <​lars@trolltech.com>

Ported the font implementation to use the new QFont features of Qt 4.4.

Note: See TracTimeline for information about the timeline view.