Timeline
Mar 30, 2008:
- 11:49 PM Changeset in webkit [31453] by
-
- 6 edits2 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15595
marker property doesn't show up correctly as "shorthand" in inspector
Make sure parsing the marker property sets the individual
marker properties as implicit with marker as shorthand.
Also let CSSStyleDecleration::getPropertyValue return
the correct value for the marker property.
- 11:48 PM Changeset in webkit [31452] by
-
- 27 edits5 copies2 adds in branches/squirrelfish
2008-03-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Implemented native function calls. (Re-entering from native code back
to JS doesn't work yet, though.)
0.2% speedup overall, due to some inlining tweaks. 3.6% regression on
function-empty.js, since we're making a new virtual call and taking a
new branch inside every op_call.
I adjusted the JavaScriptCore calling convention to minimize overhead,
like so:
The machine calls a single virtual function, "getCallData", to get all
the data it needs for a function call. Native code still uses the old
"isObject()" check followed by an "implementsCall()" check, which
aliases to "getCallData". (We can optimize native code to use getCallData
at our leisure.)
To supply a list of arguments, the machine calls a new List constructor
that just takes a pointer and a length, without copying. Native code
still appends to the list one argument at a time. (We can optimize
native code to use the new List constructor at our leisure.)
- VM/Machine.cpp: (KJS::Machine::privateExecute): Changed resize() call to grow() call, to encourage the compiler to inline the Vector code.
- kjs/CallData.h: Added. (KJS::): CallData is a union because eventually native calls will stuff a function pointer into it, to eliminate the callAsFunction virtual call.
- kjs/function.cpp: (KJS::FunctionImp::callAsFunction): Changed this to an ASSERT since it's not implemented yet.
- kjs/list.h: Made the List class two-faced, to support the old way and the new way during this transition phase: lists can be made read-only with just a pointer and a legnth, or you can append to them one item at a time.
- kjs/value.h: (KJS::jsUndefined): Marked this function ALWAYS_INLINE for the benefit of a certain compiler that doesn't know what's best for it.
JavaScriptGlue:
2008-03-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Build fix.
- ForwardingHeaders/wtf/UnusedParam.h: Copied from ForwardingHeaders/wtf/OwnPtr.h.
WebCore:
2008-03-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Adjusted WebCore JS functions to the new "getCallData" calling convention.
WebKit/mac:
2008-03-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Build fix.
- 11:13 PM Changeset in webkit [31451] by
-
- 21 edits in trunk/WebCore
Reviewed by Oliver.
Make AMatthews life easier -- fix the SVG_FILTERS build
Build fix only, no tests.
- svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
- svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
- svg/SVGFEDiffuseLightingElement.cpp:
- svg/SVGFEGaussianBlurElement.cpp:
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::SVGFEImageElement):
- svg/SVGFESpecularLightingElement.cpp:
- svg/SVGFETurbulenceElement.cpp:
- svg/SVGFilterElement.cpp:
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
- svg/graphics/filters/SVGFEBlend.cpp:
- svg/graphics/filters/SVGFEComponentTransfer.cpp:
- svg/graphics/filters/SVGFEComposite.cpp:
- svg/graphics/filters/SVGFEDiffuseLighting.cpp:
- svg/graphics/filters/SVGFEGaussianBlur.cpp:
- svg/graphics/filters/SVGFEImage.cpp:
- svg/graphics/filters/SVGFEMerge.cpp:
- svg/graphics/filters/SVGFEMorphology.cpp:
- svg/graphics/filters/SVGFEOffset.cpp:
- svg/graphics/filters/SVGFESpecularLighting.cpp:
- svg/graphics/filters/SVGFETurbulence.cpp:
- 10:49 PM squirrelfish edited by
- (diff)
- 10:32 PM Changeset in webkit [31450] by
-
- 2 edits in branches/squirrelfish/JavaScriptCore
2008-03-30 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver.
Dump code that codegen can't handle yet, so it's easier to prioritize missing nodes.
- kjs/nodes.h: (KJS::Node::emitCode):
- 9:39 PM Changeset in webkit [31449] by
-
- 3 edits in branches/squirrelfish/JavaScriptCore
2008-03-30 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver.
Improve dumping of bytecode and fix coding style accordingly.
Registers are printed as lr1 for locals, tr1 for temp registers. Identifiers print as
foobar(@id0) and constants print as "foo"(@k1) or 312.4(@k2) or the like. Constant and
identifier tables are dumped for reference.
- VM/CodeBlock.cpp: (KJS::escapeQuotes): (KJS::valueToSourceString): (KJS::registerName): (KJS::constantName): (KJS::idName): (KJS::printUnaryOp): (KJS::printBinaryOp): (KJS::CodeBlock::dump):
- VM/Machine.cpp: (KJS::resolve): (KJS::resolveBase): (KJS::Machine::privateExecute):
- 7:46 PM squirrelfish edited by
- (diff)
- 6:11 PM Changeset in webkit [31448] by
-
- 3 edits in branches/squirrelfish/JavaScriptCore
2008-03-30 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver.
Implement StringNode and VoidNode (both pretty trivial).
- kjs/nodes.cpp: (KJS::StringNode::emitCode): (KJS::VoidNode::emitCode):
- kjs/nodes.h:
- 3:35 PM Changeset in webkit [31447] by
-
- 3 edits in branches/squirrelfish/JavaScriptCore
2008-03-30 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam.
Implement CommaNode.
- kjs/nodes.cpp: (KJS::CommaNode::emitCode):
- kjs/nodes.h:
- 2:52 PM Changeset in webkit [31446] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Sam Weinig.
- fix http://bugs.webkit.org/show_bug.cgi?id=18115 REGRESSION (r31250): Incomplete repaint of GoogleReader sidebar while reading unread posts
Test: fast/repaint/lines-with-layout-delta.html
- rendering/RenderObject.cpp: (WebCore::RenderObject::repaintRectangle): Made this method take layout delta into account.
LayoutTests:
Reviewed by Sam Weinig.
- repaint test for http://bugs.webkit.org/show_bug.cgi?id=18115 REGRESSION (r31250): Incomplete repaint of GoogleReader sidebar while reading unread posts
- fast/repaint/lines-with-layout-delta.html: Added.
- platform/mac/fast/repaint/lines-with-layout-delta-expected.checksum: Added.
- platform/mac/fast/repaint/lines-with-layout-delta-expected.png: Added.
- platform/mac/fast/repaint/lines-with-layout-delta-expected.txt: Added.
- 2:41 PM squirrelfish edited by
- (diff)
- 2:40 PM squirrelfish edited by
- (diff)
- 2:29 PM Changeset in webkit [31445] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Maciej Stachowiak.
- fix assertion failure in CSSParser.cpp's equalIgnoringCase() when parsing certain transforms.
Test: fast/css/transform-function-lowercase-assert.html
- css/CSSParser.cpp: (WebCore::TransformOperationInfo::TransformOperationInfo): Changed to always pass a lowercase string as the second argument of equalIgnoringCase().
LayoutTests:
Reviewed by Maciej Stachowiak.
- test for an assertion failure in CSSParser.cpp's equalIgnoringCase() when parsing certain transforms.
- fast/css/transform-function-lowercase-assert-expected.txt: Added.
- fast/css/transform-function-lowercase-assert.html: Added.
- 2:11 PM Changeset in webkit [31444] by
-
- 2 edits in trunk/WebCore
ARM build fix.
- 2:02 PM Changeset in webkit [31443] by
-
- 8 edits in branches/squirrelfish/JavaScriptCore
2008-03-30 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej.
Adds support for dot notation and object literals.
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitNewObject):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- VM/Opcode.h:
- kjs/nodes.cpp: (KJS::ObjectLiteralNode::emitCode): (KJS::PropertyListNode::emitCode): (KJS::DotAccessorNode::emitCode): (KJS::AssignDotNode::emitCode):
- kjs/nodes.h:
- 10:25 AM Changeset in webkit [31442] by
-
- 2 edits in trunk/WebCore
2008-03-30 Hiroyuki Ikezoe <poincare@ikezoe.net>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=18036
Rendering invalid japanese characters with pango backend.
- platform/graphics/gtk/FontPlatformDataPango.cpp: (FontPlatformData::FontPlatformData): Set PangoFontDescription for PangoContext explicitly to use proper font.
- 10:09 AM Changeset in webkit [31441] by
-
- 8 edits2 adds in trunk
Reviewed by Oliver.
http://bugs.webkit.org/show_bug.cgi?id=17633
SVG: modifying x & y attribute of text element from JS fails
Make SVG text relayout when x, y attribute is changed from js.
- 8:25 AM Changeset in webkit [31440] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Adam Roben.
Fix wrong id.
Mar 29, 2008:
- 9:58 PM Changeset in webkit [31439] by
-
- 8 edits in trunk/WebCore
2008-03-28 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver.
- yet still more bindings speedup
Make AtomicString straight from UString in handcoded bindings
- bindings/js/JSElementCustom.cpp: (WebCore::JSElement::setAttribute): (WebCore::JSElement::setAttributeNS):
- dom/Document.cpp: (WebCore::Document::createElement):
- dom/Document.h:
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::createElement):
- html/HTMLDocument.h:
- 7:21 PM Changeset in webkit [31438] by
-
- 10 edits in trunk/WebCore
2008-03-29 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Fix for <rdar://problem/5828873>
Since NSURL is allowing invalid urls to be loaded, we need to
check the URL validity at the ResourceHandle level and fire off
a cannotShowURL error.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::cannotShowURLError):
- loader/FrameLoader.h:
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::cannotShowURLError): (WebCore::ResourceLoader::wasBlocked): (WebCore::ResourceLoader::cannotShowURL):
- loader/ResourceLoader.h:
- platform/KURL.h: (WebCore::KURL::isValid):
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::create): (WebCore::ResourceHandle::scheduleFailure): (WebCore::ResourceHandle::fireFailure): (WebCore::portAllowed):
- platform/network/ResourceHandle.h: (WebCore::ResourceHandle::):
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::cannotShowURL):
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- 6:47 PM Changeset in webkit [31437] by
-
- 3 edits in trunk/WebCore
2008-03-29 Darin Adler <Darin Adler>
Reviewed by Mitz.
- more bindings speedup
When I changed the temporary variables to be UString that means that the
valueToString functions also need to return UString to avoid converting
from UString to String twice.
- bindings/js/kjs_binding.cpp: (WebCore::valueToStringWithNullCheck): Changed return value to UString. (WebCore::valueToStringWithUndefinedOrNullCheck): Ditto.
- bindings/js/kjs_binding.h: Ditto.
- 10:52 AM Changeset in webkit [31436] by
-
- 2 edits in trunk/WebCore
2008-03-29 Darin Adler <Darin Adler>
Reviewed by Sam.
- DerivedSources.make: Removed temporary remove-stray-JSRGBColor build rule.
- 10:51 AM Changeset in webkit [31435] by
-
- 21 edits in trunk/WebCore
2008-03-29 Darin Adler <Darin Adler>
Reviewed by Sam.
- tweak handling of the class attribute to speed up code that sets it but never needs to parse it
6% speedup of Acid3 test 26
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules): Change to use non-virtual classNames function since the hasClass bit can only be set for a StyledElement. (WebCore::CSSStyleSelector::checkOneSelector): Ditto. Also streamlined the code a bit for the tag matching as well.
- dom/ClassNames.cpp: (WebCore::hasNonASCIIOrUpper): Added. This function does what other callers seem to want isLower() to do. We should merge this with isLower() in a subsequent cleanup pass. (WebCore::ClassNamesData::createVector): Renamed from parseClassAttribute. Turns the string into a vector. (WebCore::ClassNamesData::containsAll): Added. Used by getElementsByClassName.
- dom/ClassNames.h: Added a separate ClassNameData class so we could hold the string and case folding flag as well as the vector. Changed ClassNames to have a set function rather than a parseClassAttribute function. Removed the "static" from isClassWhitespace. There's no reason to ask for internal linkage.
- dom/ClassNodeList.cpp: (WebCore::ClassNodeList::ClassNodeList): Use constructor instead of the parseClassAttribute function. (WebCore::ClassNodeList::nodeMatches): Get rid of unnneeded isElementNode check, since hasClass will only be true for StyledElement nodes. Use the new containsAll function in ClassNames instead of having a loop here.
- dom/ClassNodeList.h: Removed unneeded forward declaration.
- dom/Document.cpp: Removed unneeded include.
- dom/Element.cpp: (WebCore::Element::cloneNode): Changed code to copy attributes to use a function call instead of the assignment operator. This paves the way to making the function more efficient, using a virtual function. (WebCore::Element::setAttributeMap): Updated for PassRefPtr and for name change (element -> m_element). (WebCore::Element::createAttributeMap): Changed to use create function instead of calling the constructor directly.
- dom/Element.h: Removed unneeded virtual getClassNames function. Changed the argument to setAttributeMap to be a PassRefPtr.
- dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::NamedAttrMap): Updated for name change (element -> m_element). (WebCore::NamedAttrMap::getNamedItem): Ditto. (WebCore::NamedAttrMap::removeNamedItem): Ditto. (WebCore::NamedAttrMap::setNamedItem): Ditto. (WebCore::NamedAttrMap::item): Ditto. (WebCore::NamedAttrMap::detachFromElement): Ditto. (WebCore::NamedAttrMap::setAttributes): Renamed this from the assignment operator. (WebCore::NamedAttrMap::addAttribute): Ditto. (WebCore::NamedAttrMap::removeAttribute): Ditto. (WebCore::NamedAttrMap::isReadOnlyNode): Ditto.
- dom/NamedAttrMap.h: Removed the copy constructor and assignment operator and added a new function, setAttributes, possibly to be made virtual in the future. Made isReadOnlyNode non-virtual. Renamed element -> m_element. Made constructor protected and added a create function.
- dom/NamedMappedAttrMap.cpp: (WebCore::NamedMappedAttrMap::NamedMappedAttrMap): Changed constructor parameter to take a StyledElement. (WebCore::NamedMappedAttrMap::setClass): Changed to use the new set function.
- dom/NamedMappedAttrMap.h: Made constructor private and added a create function. Replaced theparseClassAttribute function with clearClass and setClass functions. Replaced the getClassNames function with a classNames function returning a reference instead of a pointer.
- dom/NamedNodeMap.h: Changed to start refcount at 1 instead of 0. Removed unneeded virtual function isReadOnlyNode.
- dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute): Rewrote class attribute handling to use new function names and took out uneeded special case for null attribute. (WebCore::StyledElement::createAttributeMap): Changed to use create function instead of a direct call to new.
- dom/StyledElement.h: Replaced the virtual getClassNames function with a non-virtual inline classNames function.
- html/HTMLElement.cpp: (WebCore::HTMLElement::cloneNode): Changed code to copy attributes to use a function call instead of the assignment operator.
- html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute): Use create function instead of a a direct call to new.
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): Use RefPtr and the new create function. (WebCore::HTMLViewSourceDocument::addViewSourceToken): Ditto. (WebCore::HTMLViewSourceDocument::addSpanWithClassName): Ditto. (WebCore::HTMLViewSourceDocument::addLine): Ditto. (WebCore::HTMLViewSourceDocument::addText): Ditto. (WebCore::HTMLViewSourceDocument::addLink): Ditto.
- html/HTMLViewSourceDocument.h: Ditto.
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::expandSymbolElementsInShadowTree): Changed code to copy attributes to use a function call instead of the assignment operator. (WebCore::SVGUseElement::transferUseAttributesToReplacedElement): Ditto.
- 8:17 AM Changeset in webkit [31434] by
-
- 4 edits2 adds in trunk
WebCore:
2008-03-29 Sam Weinig <sam@webkit.org>
Reviewed by Brady Eidson.
Fix crash when canceling a resource load while port blocked failure
timer is going.
Test: fast/loader/cancel-load-during-port-block-timer.html
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::scheduleBlockedFailure): (WebCore::ResourceHandle::fireBlockedFailure):
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Make the Timer a member variable of ResourceHandleInternal so that it can be canceled if the ResourceHandle is destroyed.
LayoutTests:
2008-03-29 Sam Weinig <sam@webkit.org>
Reviewed by Brady Eidson.
Test for crash when canceling a resource load while port blocked failure
timer is going
- fast/loader/cancel-load-during-port-block-timer-expected.txt: Added.
- fast/loader/cancel-load-during-port-block-timer.html: Added.
- 1:18 AM Changeset in webkit [31433] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Oliver Hunt.
<rdar://problem/5829556> REGRESSION: Leak in KJS::initializeThreading()
- kjs/InitializeThreading.cpp: (KJS::initializeThreading): There is no guarantee that initializeThreading() is called only once; check that the mutex hasn't been already allocated.
- 1:15 AM squirrelfish edited by
- (diff)
- 1:13 AM Changeset in webkit [31432] by
-
- 7 edits in branches/squirrelfish/JavaScriptCore
2008-03-29 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Mark the register file.
It's a conservative mark for now, but once registers are typed, we can
do an exact mark.
1.4% regression regardless of whether we actually do the marking.
GCC is is worth every penny.
- VM/Machine.cpp: (KJS::Machine::privateExecute): Most of the changes here are just for the fact that "registers" is a pointer now.
- kjs/JSGlobalObject.cpp: The global object owns the register file now.
- 12:25 AM Changeset in webkit [31431] by
-
- 5 edits in trunk
Bug 17924: Crash in KJS::ConstDeclNode::evaluate with |with| and |const|
<http://bugs.webkit.org/show_bug.cgi?id=17924>
<rdar://problem/5806933>
Reviewed by Geoff.
It turns out this is trivially avoidable if we just match firefox's
semantics and ensure that an assignment in a const declaration always
writes to the variable object.
Mar 28, 2008:
- 11:46 PM squirrelfish edited by
- (diff)
- 11:45 PM squirrelfish edited by
- (diff)
- 9:29 PM Changeset in webkit [31430] by
-
- 7 edits in branches/squirrelfish/JavaScriptCore
Bug 18204: SquirrelFish: continue/break do not correctly handle scope popping
<http://bugs.webkit.org/show_bug.cgi?id=18204>
Reviewed by Maciej.
We now track the scope depth as part of a loop context, and add an
extra instruction op_jump_scopes that is used to perform a jump across
dynamic scope boundaries.
- 8:38 PM Changeset in webkit [31429] by
-
- 3 edits in trunk/WebCore
2008-03-28 Stephanie <Stephanie Lewis>
Fix 64bit build
- WebCore.LP64.exp:
- loader/archive/cf/LegacyWebArchiveMac.mm: (WebCore::createResourceResponseFromMacArchivedData):
- 8:31 PM Changeset in webkit [31428] by
-
- 3 edits in branches/squirrelfish/JavaScriptCore
2008-03-28 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Add emitCode support for ConditionalNode.
- kjs/nodes.cpp: (KJS::ConditionalNode::emitCode):
- kjs/nodes.h:
- 8:28 PM Changeset in webkit [31427] by
-
- 2 edits in trunk/WebCore
2008-03-28 Steve Falkenburg <sfalken@apple.com>
Enabled LTCG on files within "page".
Rubber stamped by Oliver.
- WebCore.vcproj/WebCore.vcproj:
- 8:07 PM Changeset in webkit [31426] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix a percentage background position regression from r31389
Test: fast/backgrounds/background-position-1.html
- rendering/Length.h: (WebCore::Length::calcValue): Divide by 100. (WebCore::Length::calcMinValue): Ditto.
LayoutTests:
Reviewed by Dave Hyatt.
- pixel test for a percentage background position regression from r31389
- fast/backgrounds/background-position-1.html: Added.
- platform/mac/fast/backgrounds/background-position-1-expected.checksum: Added.
- platform/mac/fast/backgrounds/background-position-1-expected.png: Added.
- platform/mac/fast/backgrounds/background-position-1-expected.txt: Added.
- 7:21 PM Changeset in webkit [31425] by
-
- 1 edit in trunk/WebCore/rendering/RenderBlock.cpp
Oops. Back out unintentional change to RenderBlock.cpp
- 7:21 PM Changeset in webkit [31424] by
-
- 7 edits in trunk/WebCore
2008-03-28 David Hyatt <hyatt@apple.com>
Back out the Ahem font antialiasing hack, since it is now no longer required for LCD antialiased text
to match the reference rendering on Acid 3.
- platform/graphics/SimpleFontData.h:
- platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
- platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit):
- platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformInit):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionNewFloats):
- 5:51 PM Changeset in webkit [31423] by
-
- 8 edits2 deletes in trunk/WebKit
WebKit:
2008-03-28 Brady Eidson <beidson@apple.com>
Rubberstamped by Darin Adler
Remove WebArchiver.h/mm
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2008-03-28 Brady Eidson <beidson@apple.com>
Rubberstamped by Darin Adler
Remove WebArchiver.h/mm
- WebView/WebArchiver.h: Removed.
- WebView/WebArchiver.mm: Removed.
- DOM/WebDOMOperations.mm:
- WebCoreSupport/WebDragClient.mm:
- WebCoreSupport/WebEditorClient.mm:
- WebView/WebDataSource.mm:
- WebView/WebHTMLView.mm:
- 5:49 PM Changeset in webkit [31422] by
-
- 2 edits in branches/Safari-3-1-branch/WebKitLibraries
Merged fix from r31420.
- 5:40 PM Changeset in webkit [31421] by
-
- 5 edits in trunk/WebKit/mac
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
Now that WebCore can create archives from a frame selection directly, we don't need it in WebArchiver anymore
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::dataForArchivedSelection):
- WebView/WebArchiver.h: Nuke archiveSelectionInFrame, as there are no remaining users
- WebView/WebArchiver.mm: Ditto
- WebView/WebHTMLView.mm: (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
- 5:35 PM Changeset in webkit [31420] by
-
- 2 edits in trunk/WebKitLibraries
Versioning.
- 5:18 PM Changeset in webkit [31419] by
-
- 6 edits in trunk
WebCore:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
More Kit->Core WebArchive changes.
Create an archive from the current selection in a frame
- WebCore.base.exp:
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::createFromSelection):
- loader/archive/cf/LegacyWebArchive.h:
WebKit/mac:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
More Kit->Core WebArchive changes.
Create an archive from the current selection in a frame
- WebView/WebArchiver.mm: Remove one more *undeclared* method, the last method will drop off easily in a followup
- 5:14 PM Changeset in webkit [31418] by
-
- 2 edits in trunk/WebCore
2008-03-28 Kevin McCullough <kmccullough@apple.com>
- Somehow managed to duplicate code :(
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
- 5:04 PM Changeset in webkit [31417] by
-
- 7 edits in branches/squirrelfish/JavaScriptCore
2008-03-28 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Responding to feedback, added some comments, fixed up a few names, and
clarified that "locals" always means all local variables, functions,
and parameters.
- 5:01 PM Changeset in webkit [31416] by
-
- 9 edits in branches/squirrelfish/JavaScriptCore
2008-03-28 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Added support for "this".
Supply an implicit "this" value as the first argument to every function.
Alias the "this" keyword to that argument.
1% regression overall, 2.5% regression on empty function calls. Seems
like a reasonable cost for now, since we're doing more work.
(Eventually, we might decide to create a version of op_call specialized
for a known null "this" value.)
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitCall):
- VM/CodeGenerator.h: (KJS::CodeGenerator::CodeGenerator):
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- kjs/CommonIdentifiers.cpp: (KJS::CommonIdentifiers::CommonIdentifiers):
- kjs/CommonIdentifiers.h:
- kjs/nodes.cpp: (KJS::ThisNode::emitCode): (KJS::FunctionCallResolveNode::emitCode):
- kjs/nodes.h:
- 4:50 PM Changeset in webkit [31415] by
-
- 2 edits in trunk/WebCore
2008-03-28 Kevin McCullough <kmccullough@apple.com>
- Missed some changes in previous checkin.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): Get identifier from synchronous loader. (WebCore::XMLHttpRequest::didFinishLoading):
- 4:28 PM Changeset in webkit [31414] by
-
- 7 edits in trunk/WebCore
2008-03-28 Kevin McCullough <kmccullough@apple.com>
Reviewed by Adam.
-<rdar://problem/5712804> XMLHttpRequests do not show response contents, preview images (14313)
-<rdar://problem/5712931> XMLHttpRequests should be shown separately and grouped (14315)
-<rdar://problem/5732836> XMLHttpRequest: Inspector should show network activity/XHR in Console (17233)
- Send the XMLHttpRequest data to the Inspector Controller.
- loader/FrameLoader.cpp: Return the identifier for this resource since we need it in the XHR case. (WebCore::FrameLoader::loadResourceSynchronously):
- loader/FrameLoader.h: Ditto.
- page/InspectorController.cpp: (WebCore::XMLHttpRequestResource::XMLHttpRequestResource): We only need the data since the type will be XHR and the encoding is not used (we decoded earlier). (WebCore::XMLHttpRequestResource::~XMLHttpRequestResource): Locking is necessary when setting and clearing the KJS::UString::Rep. (WebCore::InspectorResource::setXMLHttpRequestProperties): (WebCore::InspectorResource::sourceString): Return the decoded source. (WebCore::addSourceToFrame): No longer do the decoding here, it has been encapsulated in the InspectorResource. (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
- page/InspectorController.h: Pass a UString instead of copying to a WebCore::String. In case we never ask for the string's contents this will save us an extra copy.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): In the synchronous load case we normally do not keep the identifier but we need it to find the InspectorResource in order to tell it that it was loaded via XHR. (WebCore::XMLHttpRequest::didFinishLoading): Tell the InspectorController that its resource was loaded via XHR.
- xml/XMLHttpRequest.h: Ditto.
- 4:28 PM Changeset in webkit [31413] by
-
- 2 edits in trunk/LayoutTests
2008-03-28 Stephanie Lewis <Stephanie Lewis>
Update Windows Skipped list. Bugs filed.
- platform/win/Skipped:
- 4:11 PM Changeset in webkit [31412] by
-
- 10 edits in trunk
WebCore:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
WebArchive saga continues - Can now make archives from ranges in WebCore
Again, previous layout test coverage exercised this code
- WebCore.base.exp:
- editing/markup.cpp: (WebCore::createFullMarkup): Added a "markup from range" variant that copies the previous WebKit implementation
- editing/markup.h:
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create):
- loader/archive/cf/LegacyWebArchive.h:
WebKit/mac:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
WebArchive saga continues - Can now make archives from ranges in WebCore
- DOM/WebDOMOperations.mm: (-[DOMRange webArchive]): (-[DOMRange markupString]):
- WebView/WebArchiver.h: Remove newly obsolete [WebArchiver archiveRange:]
- WebView/WebArchiver.mm:
- 3:39 PM Changeset in webkit [31411] by
-
- 5 edits in branches/squirrelfish/JavaScriptCore
Bug 18192: Squirrelfish needs support for break and continue
<http://bugs.webkit.org/show_bug.cgi?id=18192>
Reviewed by Geoff
Added a loop context stack to the code generator to provide the
correct jump labels for continue and goto. Added logic to the
currently implemented loop constructs to manage entry and exit
from the loop contexts. Finally, implemented codegen for break
and continue (and a pass through for LabelNode)
- 3:09 PM Changeset in webkit [31410] by
-
- 2 edits in trunk/WebCore
2008-03-28 Stephanie Lewis <Stephanie Lewis>
windows build fix.
- platform/win/MainThreadWin.cpp: (WebCore::initializeThreadingAndMainThread):
- 2:29 PM Changeset in webkit [31409] by
-
- 8 edits in trunk
WebCore:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
More Kit->Core webarchive code movement
- WebCore.base.exp:
- editing/markup.cpp: (WebCore::createFullMarkup): Replacement for [DOMNode markupString], creating full markup at this node including the document type string, which the WebKit implementation did indirectly
- editing/markup.h:
WebKit/mac:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
More Kit->Core webarchive code movement
- DOM/WebDOMOperations.mm: (-[DOMNode markupString]): Call createFullMarkup() instead
- WebView/WebFrame.mm: Remove obsolete _markupStringFromNode
- WebView/WebFrameInternal.h: Ditto
- 2:01 PM Changeset in webkit [31408] by
-
- 5 edits2 adds in branches/Safari-3-1-branch
Merge r31071.
- 2:01 PM Changeset in webkit [31407] by
-
- 2 edits2 adds in branches/Safari-3-1-branch/WebCore
Merge r31358.
- 2:00 PM Changeset in webkit [31406] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r31336.
- 1:56 PM Changeset in webkit [31405] by
-
- 10 edits in trunk/WebCore
2008-03-28 Darin Adler <Darin Adler>
Reviewed by Maciej.
- cut down on copying and refcount churn a little by using references a bit more for KURL and String
- bindings/js/JSXMLHttpRequest.cpp: (WebCore::jsXMLHttpRequestPrototypeFunctionOpen): Use const KURL& instead of KURL.
- css/StyleSheet.h: (WebCore::StyleSheet::href): Return const String& instead of String. (WebCore::StyleSheet::title): Ditto.
- dom/Document.cpp: (WebCore::Document::completeURL): Use const KURL* for a local variable instead of KURL to avoid copying the KURL.
- dom/Element.cpp: (WebCore::Element::baseURI): Use const KURL& instead of KURL.
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::hostname): Ditto.
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed): Ditto.
- html/HTMLKeygenElement.cpp: Removed unneeded include of KURL.
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Get rid of temporary KURL.
- platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::createForFrame): Use const KURL& instead of KURL.
- 1:21 PM Changeset in webkit [31404] by
-
- 14 edits3 adds in trunk
Reviewed by Sam Weinig.
Fix a dtoa thread safety issue.
WebCore can call kjs_strtod without holding JS lock, but we didn't have thread safety
compiled in for dtoa.
This is a 0.5% regression on SunSpider, which Sam Weinig has volunteered to cover with
his recent improvement.
- kjs/dtoa.cpp: (Bigint::Balloc): (Bigint::Bfree): Changed to use fastMalloc/fastDelete - they are much faster than the dtoa custom version was in the presence of locking (but somewhat slower in single-threaded case). (Bigint::pow5mult): Got rid of the dreaded double-checked locking anti-pattern (had to restructure the code to avoid significant performance implications). (Bigint::lshift): Rewrote to avoid an allocation, if possible.
(Bigint::rv_alloc):
(Bigint::kjs_freedtoa):
(Bigint::kjs_dtoa):
Check for USE(MULTIPLE_THREADS), not dtoa legacy MULTIPLE_THREADS.
- kjs/InitializeThreading.cpp: Added. (KJS::initializeThreading):
- kjs/InitializeThreading.h: Added. Initialize threading at KJS level, if enabled.
- kjs/dtoa.h: Expose dtoa mutex for KJS::initializeThreading.
- kjs/testkjs.cpp: (kjsmain): Call initializeThreading.
- JavaScriptCore.exp: Export KJS::initializeThreading.
- GNUmakefile.am:
- JavaScriptCore.exp:
- JavaScriptCore.pri:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCoreSources.bkl:
- JavaScriptCore.xcodeproj/project.pbxproj: Added InitializeThreading.{h,cpp}.
- wtf/Threading.h: Removed a using directive for WTF::initializeThreading - it is only to be called from KJS::initializeThreading, and having it in the global namespace is useless.
- 1:02 PM Changeset in webkit [31403] by
-
- 2 edits in trunk/WebCore
2008-03-28 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Maciej, landed by Brady
Correct build regression (http://bugs.webkit.org/show_bug.cgi?id=18148)
- platform/graphics/win/GraphicsContextCairoWin.cpp: (WebCore::GraphicsContext::getWindowsContext): (WebCore::GraphicsContext::releaseWindowsContext):
- 1:01 PM Changeset in webkit [31402] by
-
- 4 edits in trunk/WebKit/mac
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
Fold [WebArchiver archiveFrame:] into WebDataSource - the last remaining caller
- WebView/WebArchiver.h:
- WebView/WebArchiver.mm:
- WebView/WebDataSource.mm: (-[WebDataSource webArchive]):
- 12:57 PM Changeset in webkit [31401] by
-
- 3 edits in trunk/WebKit/mac
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
Remove unused [WebArchiver archiveNode:], made obsolete in r31400
- WebView/WebArchiver.h:
- WebView/WebArchiver.mm:
- 12:47 PM Changeset in webkit [31400] by
-
- 7 edits in trunk
WebCore:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin
"Yet another transitional step" to empty out WebKit-based code for archiving.
With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
entirely within WebCore, and opens the door to saving WebArchives on Windows.
This is another "zero behavior change" patch, and current editing/ and webarchive/ layout tests
covered the relevant code
- WebCore.base.exp:
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create):
- loader/archive/cf/LegacyWebArchive.h:
WebKit/mac:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin
"Yet another transitional step" to empty out WebKit-based code for archiving.
With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
entirely within WebCore, and opens the door to saving WebArchives on Windows.
- DOM/WebDOMOperations.mm:
- WebView/WebArchiver.mm: (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
- 11:26 AM Changeset in webkit [31399] by
-
- 2 edits in trunk/WebCore
2008-03-28 Jasper Bryant-Greene <jasper@unix.geek.nz>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=18061
PlatformScrollBarGtk attempts to allocate negative width and/or height for widgets
Missing clampNegativeToZero() call meant that we tried to allocate widgets with negative width and/or height.
- platform/gtk/PlatformScrollBarGtk.cpp: (PlatformScrollbar::geometryChanged):
- 10:53 AM Changeset in webkit [31398] by
-
- 6 edits1 add in trunk
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin
Export Unicode/UTF8.h and convertUTF16ToUTF8() for more flexible conversion in WebCore
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
WebCore:
2008-03-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin
Using convertUTF16ToUTF8() from WTF, add a helper function that gives you a UTF8 SharedBuffer
created from a String.
- ForwardingHeaders/wtf/unicode/UTF8.h: Added.
- platform/text/PlatformString.h:
- platform/text/String.cpp: (WebCore::utf8Buffer):
- 10:37 AM Changeset in webkit [31397] by
-
- 3 edits in trunk/WebCore
2008-03-28 Darin Adler <Darin Adler>
Reviewed by Adam.
- eliminate a tiny bit of unnecessary refcount churn
- bindings/js/JSEventTargetBase.cpp: (WebCore::eventNameForPropertyToken): Return const AtomicString&.
- bindings/js/JSEventTargetBase.h: (WebCore::JSEventTargetBase::getValueProperty): Update for above change. (WebCore::JSEventTargetBase::putValueProperty): Ditto.
- 10:03 AM Changeset in webkit [31396] by
-
- 3 edits in trunk/LayoutTests
2008-03-28 Darin Adler <Darin Adler>
Reviewed by Sam.
- fast/encoding/invalid-xml-expected.txt: Update to reflect a true success.
- fast/encoding/resources/invalid-xml.js: Eliminate race condition by not ending the test until the js-test-post.js script has loaded.
- 9:26 AM Changeset in webkit [31395] by
-
- 3 edits in trunk/LayoutTests
Rubber-stamped by Brady.
Enable server-side includes via AddHandler, hopefully making Apache 1.3 happy.
- http/tests/misc/.htaccess:
- http/tests/misc/resources/acid3/.htaccess:
- 9:16 AM Changeset in webkit [31394] by
-
- 3 edits in trunk/WebKitSite
2008-03-28 Darin Adler <Darin Adler>
- building/build.html: Add another mention of using the Cygwin shell.
- building/tools.html: Fix a typo on the name Cygwin.
- 7:15 AM Changeset in webkit [31393] by
-
- 1 edit1 add in trunk/LayoutTests
Not reviewed.
Enable mod_include for acid3.html - the previous check-in only had it in resources
subdirectory.
- http/tests/misc/.htaccess: Added.
- 2:44 AM Changeset in webkit [31392] by
-
- 2 edits in trunk/WebCore
Fix the Qt build.
- rendering/Length.h: Include wtf/MathExtras.h for round().
- 2:23 AM Changeset in webkit [31391] by
-
- 1 edit23 adds in trunk/LayoutTests
Reviewed by mjs.
Add Acid3 test as an http test
http://bugs.webkit.org/show_bug.cgi?id=18176
- http/tests/misc/acid3-expected.checksum: Added.
- http/tests/misc/acid3-expected.png: Added.
- http/tests/misc/acid3-expected.txt: Added.
- http/tests/misc/acid3.html: Added.
- http/tests/misc/resources/acid3/.htaccess: Added.
- http/tests/misc/resources/acid3/empty.css: Added.
- http/tests/misc/resources/acid3/empty.html: Added.
- http/tests/misc/resources/acid3/empty.png: Added.
- http/tests/misc/resources/acid3/empty.txt: Added.
- http/tests/misc/resources/acid3/empty.xml: Added.
- http/tests/misc/resources/acid3/font.svg: Added.
- http/tests/misc/resources/acid3/font.ttf: Added.
- http/tests/misc/resources/acid3/instructions.inc: Added.
- http/tests/misc/resources/acid3/reference.html: Added.
- http/tests/misc/resources/acid3/reference.png: Added.
- http/tests/misc/resources/acid3/support-a.png.404: Added.
- http/tests/misc/resources/acid3/support-b.png: Added.
- http/tests/misc/resources/acid3/support-c.png: Added.
- http/tests/misc/resources/acid3/svg.xml: Added.
- http/tests/misc/resources/acid3/xhtml.1: Added.
- http/tests/misc/resources/acid3/xhtml.2: Added.
- http/tests/misc/resources/acid3/xhtml.3: Added.
- 1:54 AM Changeset in webkit [31390] by
-
- 5 adds in trunk/LayoutTests
Add layout tests for background position rounding.
- 1:53 AM Changeset in webkit [31389] by
-
- 3 edits in trunk/WebCore
2008-03-28 David Hyatt <hyatt@apple.com>
Fix a bug where background-position truncates instead of rounding when it evaluates to fractional
pixel values. This matches other browsers.
Reviewed by maciej
Added fast/backgrounds/background-position-rounding.html
- rendering/Length.h: (WebCore::Length::calcValue): (WebCore::Length::calcMinValue):
- rendering/RenderBox.cpp: (WebCore::RenderBox::calculateBackgroundImageGeometry):
Mar 27, 2008:
- 11:41 PM Changeset in webkit [31388] by
-
- 5 edits in trunk
2008-03-27 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
<rdar://problem/5826236> Regular expressions with large nested repetition counts can have their
compiled length calculated incorrectly.
- pcre/pcre_compile.cpp: (multiplyWithOverflowCheck): (calculateCompiledPatternLength): Check for overflow when dealing with nested repetition counts and bail with an error rather than returning incorrect results.
2008-03-27 Mark Rowe <mrowe@apple.com>
Reviewed by Adam Roben.
Tests for <rdar://problem/5826236> Regular expressions with large nested repetition counts can have their
compiled length calculated incorrectly.
- fast/js/regexp-overflow-expected.txt:
- fast/js/resources/regexp-overflow.js:
- 10:49 PM Changeset in webkit [31387] by
-
- 2 edits in trunk/WebCore
wx build fix. Return a default value for operator == when !USE(WXGC) (not implemented in that case).
- 10:42 PM Changeset in webkit [31386] by
-
- 2 edits in trunk/WebCore
2008-03-27 Maciej Stachowiak <mjs@apple.com>
- fix build
- svg/SVGGlyphMap.h: (WebCore::GlyphMapNode::create):
- 10:37 PM Changeset in webkit [31385] by
-
- 2 edits in trunk/WebCore
2008-03-27 Brady Eidson <beidson@apple.com>
Forgot a small requested change before committing
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::mainResource):
- 10:33 PM Changeset in webkit [31384] by
-
- 10 edits in trunk
WebCore:
2008-03-27 Brady Eidson <beidson@apple.com>
Reviewed by Adam Roben
Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
as the push to core-ify WebArchives continues.
This patch also introduces a behavior change. WebCore allows ArchiveResources with null or empty data.
WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.
Since WebResource is API, I decided to leave it be to avoid a behavior change. But internally created resources
(as in "while archiving a page") are accepting of null or empty data.
This actually fixes a bug where not all subframes are archived, and resulted in a layout test change.
- WebCore.base.exp:
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::archiveResourceForURL): Make this const (WebCore::DocumentLoader::mainResource): (WebCore::DocumentLoader::subresource): Make this const and relocate (WebCore::DocumentLoader::getSubresources):
- loader/DocumentLoader.h:
WebKit/mac:
2008-03-27 Brady Eidson <beidson@apple.com>
Reviewed by Adam Roben
Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
as the push to core-ify WebArchives continues.
This patch also introduces a behavior change. WebCore allows ArchiveResources with null or empty data.
WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.
Since WebResource is API, I decided to leave it be to avoid a behavior change. But internally created resources
(as in "while archiving a page") are accepting of null or empty data.
This actually fixes a bug where not all subframes are archived, and resulted in a layout test change.
- WebView/WebDataSource.mm: (-[WebDataSource mainResource]): Call DocumentLoader implementation (-[WebDataSource subresources]): Ditto
- WebView/WebFrame.mm: Remove [WebFrame _getAllResourceDatas:andResponses:] as its only caller is obsolete
- WebView/WebFrameInternal.h:
LayoutTests:
2008-03-27 Brady Eidson <beidson@apple.com>
Reviewed by Adam Roben
Updated results, as we now more consistently archive empty frames/empty resources
- webarchive/archive-empty-frame-source-expected.txt:
- 10:25 PM Changeset in webkit [31383] by
-
- 2 edits in trunk/WebCore
2008-03-27 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
- fixed many buildbot leaks in glyph map code
- svg/SVGGlyphMap.h: (WebCore::GlyphMapNode::create): Use explicit create pattern, to avoid overreffing and therefore leaking these objects. (WebCore::SVGGlyphMap::add): Call create instead of using new.
- 8:39 PM Changeset in webkit [31382] by
-
- 8 edits in branches/squirrelfish/JavaScriptCore
2008-03-27 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Add emitCode support for UnaryPlusNode, NegateNode, BitwiseNotNode and LogicalNotNode.
- VM/CodeBlock.cpp: (KJS::printUnaryOp): (KJS::CodeBlock::dump):
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitToJSNumber): (KJS::CodeGenerator::emitNegate): (KJS::CodeGenerator::emitBitNot): (KJS::CodeGenerator::emitNot):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- VM/Opcode.h:
- kjs/nodes.cpp: (KJS::UnaryPlusNode::emitCode): (KJS::NegateNode::emitCode): (KJS::BitwiseNotNode::emitCode): (KJS::LogicalNotNode::emitCode):
- kjs/nodes.h:
- 8:37 PM Changeset in webkit [31381] by
-
- 2 edits in trunk/WebCore
2008-03-27 Maciej Stachowiak <mjs@apple.com>
Rubber stamped by Oliver.
- re-fix Acid3, some code was incorrectly moved when fixing the Qt build
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
- 8:06 PM Changeset in webkit [31380] by
-
- 3 edits in branches/squirrelfish/JavaScriptCore
2008-03-27 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Add support for LogicalAndNode and LogicalOrNode.
- kjs/nodes.cpp: (KJS::LogicalAndNode::emitCode): (KJS::LogicalOrNode::emitCode):
- kjs/nodes.h:
- 8:02 PM squirrelfish edited by
- (diff)
- 8:01 PM squirrelfish edited by
- (diff)
- 7:52 PM Changeset in webkit [31379] by
-
- 3 edits in branches/squirrelfish/JavaScriptCore
2008-03-27 Sam Weinig <sam@webkit.org>
Clean up code and debug output.
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- 7:09 PM Changeset in webkit [31378] by
-
- 2 edits in branches/squirrelfish/JavaScriptCore
2008-03-27 Geoffrey Garen <ggaren@apple.com>
Moved an ASSERT to a more logical place.
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- 6:10 PM Changeset in webkit [31377] by
-
- 3 edits in trunk/WebKit/mac
2008-03-27 Brady Eidson <beidson@apple.com>
Reviewed by Adam
Change the "init from WebCore resource" version of WebResource to take PassRefPtr
(more efficient)
- WebView/WebResource.mm: (-[WebResource _initWithCoreResource:]):
- WebView/WebResourceInternal.h:
- 3:14 PM Changeset in webkit [31376] by
-
- 3 edits in trunk/WebCore
Fix compilation against Qt 4.4 and one missing SVG_FONTS #ifdef.
- 2:44 PM Changeset in webkit [31375] by
-
- 8 edits in branches/squirrelfish/JavaScriptCore
2008-03-27 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Add emitCode support for InstanceOfNode.
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitInstanceOf):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- VM/Opcode.h:
- kjs/nodes.cpp: (KJS::InstanceOfNode::emitCode):
- kjs/nodes.h:
- 2:37 PM Changeset in webkit [31374] by
-
- 11 edits in trunk/WebCore
Fix the Qt build and the build without ENABLE(SVG_FONTS)
- 1:58 PM Changeset in webkit [31373] by
-
- 9 edits in branches/squirrelfish/JavaScriptCore
Bug 18142: squirrelfish needs to support dynamic scoping/with
<http://bugs.webkit.org/show_bug.cgi?id=18142>
Reviewed by Maciej
Add support for dynamic scoping and add code to handle 'with'
statements.
- 12:37 PM Changeset in webkit [31372] by
-
- 8 edits in branches/squirrelfish/JavaScriptCore
2008-03-27 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Add emitCode support for NullNode, FalseNode, TrueNode, IfNode, IfElseNode, DoWhileNode and WhileNode
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump): Dump op_jfalse opcode.
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitJumpIfFalse): Identical to emitJumpIfTrue except it emits the op_jfalse opcode. (KJS::CodeGenerator::emitLoad): Add and emitLoad override for booleans.
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::Machine::privateExecute): Adds execution of op_jfalse. It is identical to op_jtrue, except the the condition is reversed.
- VM/Opcode.h: Add op_jfalse.
- kjs/nodes.cpp: (KJS::NullNode::emitCode): Added. (KJS::FalseNode::emitCode): Added. (KJS::TrueNode::emitCode): Added. (KJS::IfNode::emitCode): Added. (KJS::IfElseNode::emitCode): Added. (KJS::DoWhileNode::emitCode): Added. (KJS::WhileNode::emitCode): Added.
- kjs/nodes.h:
- 3:56 AM Changeset in webkit [31371] by
-
- 1 edit in trunk/WebCore/WebCore.base.exp
Removed whitespace that crept in from r31357.
- 12:12 AM Changeset in webkit [31370] by
-
- 4 edits7 moves in trunk/WebCore
2008-03-26 Timothy Hatcher <timothy@apple.com>
Rename some Inspector files to facilitate the up-coming UI refresh changes.
Rubber-stamped by Adam Roben.
- WebCore.vcproj/WebCore.vcproj:
- page/inspector/Console.js: Copied from page/inspector/ConsolePanel.js.
- page/inspector/ConsolePanel.js: Removed.
- page/inspector/DocumentPanel.js: Removed.
- page/inspector/ElementsPanel.js: Copied from page/inspector/DocumentPanel.js.
- page/inspector/FontPanel.js: Removed.
- page/inspector/FontView.js: Copied from page/inspector/FontPanel.js.
- page/inspector/ImagePanel.js: Removed.
- page/inspector/ImageView.js: Copied from page/inspector/ImagePanel.js.
- page/inspector/NetworkPanel.js: Removed.
- page/inspector/ResourcePanel.js: Removed.
- page/inspector/ResourceView.js: Copied from page/inspector/ResourcePanel.js.
- page/inspector/ResourcesPanel.js: Copied from page/inspector/NetworkPanel.js.
- page/inspector/SourcePanel.js: Removed.
- page/inspector/SourceView.js: Copied from page/inspector/SourcePanel.js.
- page/inspector/WebKit.qrc:
- page/inspector/inspector.html:
Mar 26, 2008:
- 11:44 PM Changeset in webkit [31369] by
-
- 2 edits in trunk/WebCore
2008-03-26 Steve Falkenburg <sfalken@apple.com>
Enable LTCG on css, dom files in WebCore
Reviewed by Stephanie.
- WebCore.vcproj/WebCore.vcproj:
- 11:39 PM squirrelfish edited by
- (diff)
- 11:24 PM Changeset in webkit [31368] by
-
- 2 edits in trunk/WebCore
2008-03-26 Stephanie Lewis <Stephanie Lewis>
Fix Windows Build
- WebCore.vcproj/WebCore.vcproj:
- 11:14 PM Changeset in webkit [31367] by
-
- 2 edits in branches/squirrelfish/JavaScriptCore
2008-03-26 Geoffrey Garen <ggaren@apple.com>
Nixed an unused List.
The calm before my stormy war against the List class.
- kjs/function_object.cpp: (KJS::FunctionObjectImp::construct):
- 11:01 PM Changeset in webkit [31366] by
-
- 2 edits in trunk/WebCore
Speculative GTK build fix.
- 10:16 PM Changeset in webkit [31365] by
-
- 2 edits in trunk/WebKit/mac
2008-03-26 Brady Eidson <beidson@apple.com>
Build fix - accidentally checked in this change which was work in progress
- DOM/WebDOMOperations.mm:
- 10:00 PM Changeset in webkit [31364] by
-
- 5 edits9 adds in branches/squirrelfish
SunSpider:
2008-03-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
--squirrelfish mode: pared down tests for squirrelfish to chew on.
- sunspider:
- tests/LIST:
- tests/squirrelfish: Added.
- tests/squirrelfish/function-closure.js: Added.
- tests/squirrelfish/function-empty.js: Added.
- tests/squirrelfish/function-missing-args.js: Added.
- tests/squirrelfish/function-sum.js: Added.
- tests/squirrelfish/loop-empty-resolve.js: Added.
- tests/squirrelfish/loop-empty.js: Added.
- tests/squirrelfish/loop-resolve.js: Added.
- tests/squirrelfish/loop-sum.js: Added.
WebKitTools:
2008-03-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
--squirrelfish mode: pared down tests for squirrelfish to chew on.
- Scripts/run-sunspider:
- 9:59 PM Changeset in webkit [31363] by
-
- 2 edits in trunk/WebCore
Mac build fix.
- 9:42 PM Changeset in webkit [31362] by
-
- 9 edits in branches/squirrelfish/JavaScriptCore
2008-03-26 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Geoffrey Garen.
Adds support for EqualNode, NotEqualNode, StrictEqualNode, NotStrictEqualNode,
LessEqNode, GreaterNode, GreaterEqNode, MultNode, DivNode, ModNode, SubNode,
LeftShiftNode, RightShiftNode, UnsignedRightShiftNode, BitAndNode, BitXOrNode,
and BitOrNode.
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitEqual): (KJS::CodeGenerator::emitNotEqual): (KJS::CodeGenerator::emitStrictEqual): (KJS::CodeGenerator::emitNotStrictEqual): (KJS::CodeGenerator::emitLessEq): (KJS::CodeGenerator::emitMult): (KJS::CodeGenerator::emitDiv): (KJS::CodeGenerator::emitMod): (KJS::CodeGenerator::emitSub): (KJS::CodeGenerator::emitLeftShift): (KJS::CodeGenerator::emitRightShift): (KJS::CodeGenerator::emitUnsignedRightShift): (KJS::CodeGenerator::emitBitAnd): (KJS::CodeGenerator::emitBitXOr): (KJS::CodeGenerator::emitBitOr):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::jsLessEq): (KJS::Machine::privateExecute):
- VM/Opcode.h:
- kjs/nodes.cpp: (KJS::MultNode::emitCode): (KJS::DivNode::emitCode): (KJS::ModNode::emitCode): (KJS::SubNode::emitCode): (KJS::LeftShiftNode::emitCode): (KJS::RightShiftNode::emitCode): (KJS::UnsignedRightShiftNode::emitCode): (KJS::GreaterNode::emitCode): (KJS::LessEqNode::emitCode): (KJS::GreaterEqNode::emitCode): (KJS::EqualNode::emitCode): (KJS::NotEqualNode::emitCode): (KJS::StrictEqualNode::emitCode): (KJS::NotStrictEqualNode::emitCode): (KJS::BitAndNode::emitCode): (KJS::BitXOrNode::emitCode): (KJS::BitOrNode::emitCode):
- kjs/nodes.h:
- 9:36 PM Changeset in webkit [31361] by
-
- 3 edits in branches/squirrelfish/JavaScriptCore
2008-03-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Only print debug dumps in debug builds.
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::generate):
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- 9:36 PM Changeset in webkit [31360] by
-
- 1 edit2 adds in trunk/WebKitSite
2008-03-26 Maciej Stachowiak <mjs@apple.com>
More screenshots for teh blog.
- blog-files/acid3-full-rendering-pass.png: Added.
- blog-files/acid3-rendering-reference.png: Added.
- 9:33 PM Changeset in webkit [31359] by
-
- 2 edits in trunk/WebCore
2008-03-26 Sam Weinig <sam@webkit.org>
Try and fix Gtk+ again.
- GNUmakefile.am:
- 9:13 PM Changeset in webkit [31358] by
-
- 2 edits2 adds in trunk/WebCore
Reviewed by Dave Hyatt.
- fix <rdar://problem/5816522> REGRESSION (r30111-30112): Tahoe web cam website has some text in Chinese or japanese
- html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): Added call to beginParsingChildren() on the new node. (WebCore::HTMLParser::handleError): Ditto. (WebCore::HTMLParser::reopenResidualStyleTags): Ditto. (WebCore::HTMLParser::pushBlock): Removed incorrect call to beginParsingChildren() on the current node.
- manual-tests/applet-finish-parsing-children.html: Added.
- manual-tests/resources/DrawMessage.class: Added.
- 9:08 PM Changeset in webkit [31357] by
-
- 37 edits in trunk
WebCore:
2008-03-26 Brady Eidson <beidson@apple.com>
Reviewed by Darin
When we create a WebArchive, we walk every node from some starting point, asking each node
along the way "What are your subresource URLs?"
That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
WebCore::Node
- WebCore.base.exp:
- dom/Node.cpp: (WebCore::Node::getSubresourceURLs): (WebCore::Node::getSubresourceAttributeStrings): Virtual and empty. Subclasses of Node that have subresources will override it.
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::getSubresourceAttributeStrings):
- dom/ProcessingInstruction.h:
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::getSubresourceAttributeStrings):
- html/HTMLBodyElement.h:
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::getSubresourceAttributeStrings):
- html/HTMLEmbedElement.h:
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::getSubresourceAttributeStrings):
- html/HTMLImageElement.h:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::getSubresourceAttributeStrings):
- html/HTMLInputElement.h:
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::getSubresourceAttributeStrings):
- html/HTMLLinkElement.h:
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::getSubresourceAttributeStrings):
- html/HTMLObjectElement.h:
- html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::getSubresourceAttributeStrings):
- html/HTMLParamElement.h:
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::getSubresourceAttributeStrings):
- html/HTMLScriptElement.h:
- html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::getSubresourceAttributeStrings):
- html/HTMLTableCellElement.h:
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::getSubresourceAttributeStrings):
- html/HTMLTableElement.h:
- svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::getSubresourceAttributeStrings):
- svg/SVGCursorElement.h:
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::getSubresourceAttributeStrings):
- svg/SVGFEImageElement.h:
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::getSubresourceAttributeStrings):
- svg/SVGImageElement.h:
- svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::getSubresourceAttributeStrings):
- svg/SVGScriptElement.h:
WebKit/mac:
2008-03-26 Brady Eidson <beidson@apple.com>
Reviewed by Darin
When we create a WebArchive, we walk every node from some starting point, asking each node
along the way "What are your subresource URLs?"
That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
WebCore::Node
- DOM/WebDOMOperations.mm: (-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by calling into individual WebCore::Node implementations
- DOM/WebDOMOperationsPrivate.h:
- 9:02 PM Changeset in webkit [31356] by
-
- 3 edits in trunk/WebCore
Reviewed by Dave Hyatt.
- maintain subpixel-antialiasing when drawing text with a simple shadow
- platform/graphics/mac/FontMac.mm: (WebCore::Font::drawComplexText): If the shadow has a zero blur radius, draw the shadow by drawing the text at an offset instead of relying on Core Graphics shadows. (WebCore::Font::drawGlyphs): Ditto.
- platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs): Ditto.
- 8:58 PM Changeset in webkit [31355] by
-
- 10 edits in trunk
WebCore:
2008-03-26 Brady Eidson <beidson@apple.com>
Reviewed by Mark Rowe
Part of the continued push to move WebArchive-related code down to WebCore, this
moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()
- WebCore.base.exp:
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): Create an ArchiveResource from a CachedResource if it exists Otherwise, fallback to an ArchiveResource from the current Archive if any. Otherwise, return null
- loader/DocumentLoader.h:
- loader/archive/ArchiveResource.cpp: (WebCore::ArchiveResource::create): (WebCore::ArchiveResource::ArchiveResource):
- loader/archive/ArchiveResource.h:
WebKit/mac:
2008-03-26 Brady Eidson <beidson@apple.com>
Reviewed by Mark Rowe
Part of the continued push to move WebArchive-related code down to WebCore, this
moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()
- WebView/WebDataSource.mm: (-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader
- WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use has now been ported down to WebCore
- WebView/WebFrameInternal.h:
- 8:54 PM Changeset in webkit [31354] by
-
- 2 edits in trunk/WebCore
2008-03-26 Sam Weinig <sam@webkit.org>
Fix Gtk+ build.
- GNUmakefile.am:
- 8:48 PM Changeset in webkit [31353] by
-
- 6 edits in trunk
Update FEATURE_DEFINES to be consistent with the other locations in which it is defined.
Rubber-stamped by Brady Eidson.
- Configurations/JavaScriptCore.xcconfig:
- Configurations/WebCore.xcconfig:
- Configurations/WebKit.xcconfig:
- 8:43 PM Changeset in webkit [31352] by
-
- 4 edits in trunk
WebCore:
2008-03-26 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
Add necessary files and build commands to vcproj files to
build a Curl-based Windows WebKit. For details, see
http://bugs.webkit.org/show_bug.cgi?id=17985
- WebCore.vcproj/WebCore.vcproj:
WebKit/win:
2008-03-26 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
Add necessary files and build commands to vcproj files to
build a Curl-based Windows WebKit. For details, see
http://bugs.webkit.org/show_bug.cgi?id=17985
- WebKit.vcproj/WebKit.vcproj:
- 8:38 PM Changeset in webkit [31351] by
-
- 3 edits in trunk/WebCore
Record JS exceptions triggered by the Inspector's use of JSC
We now dump all exceptions returned from JavaScriptCore into the
Inspector's console.
The HANDLE_EXCEPTION macro records the line on which the exception was
returned. It calls a new private handleException method on
InspectorController.
Reviewed by Kevin McCullough.
- page/InspectorController.cpp: (WebCore::InspectorController::callSimpleFunction): Made this be a member of InspectorController so that it can call handleException. (WebCore::addSourceToFrame): Pass the exception pointer on to inner JSC calls, and check it after those calls return. (WebCore::getResourceDocumentNode): Ditto. (WebCore::search): Ditto. Also changed the name/type of an existing exception variable to ExceptionCode ec. (WebCore::databaseTableNames): Ditto. (WebCore::moveByUnrestricted): Ditto. (WebCore::InspectorController::~InspectorController): Check for and record exceptions as we call JSC. (WebCore::InspectorController::focusNode): Ditto. (WebCore::InspectorController::scriptObjectReady): Ditto. (WebCore::addHeaders): Added an exception parameter. (WebCore::scriptObjectForRequest): Ditto. (WebCore::scriptObjectForResponse): Ditto. (WebCore::InspectorController::addScriptResource): Check for and record exceptions as we call JSC. (WebCore::InspectorController::addAndUpdateScriptResource): Ditto. (WebCore::InspectorController::removeScriptResource): Ditto. Also moved the call to setScriptObject to before the JSC calls so that it will always be called even if we return early if JSC throws an exception. (WebCore::InspectorController::updateScriptResourceRequest): Check for and record exceptions as we call JSC. (WebCore::InspectorController::updateScriptResourceResponse): Ditto. (WebCore::InspectorController::updateScriptResource): Ditto. (WebCore::InspectorController::addDatabaseScriptResource): Ditto. (WebCore::InspectorController::removeDatabaseScriptResource): Ditto. Also moved the call to setScriptObject to before the JSC calls so that it will always be called even if we return early if JSC throws an exception. (WebCore::InspectorController::addScriptConsoleMessage): Check for and record exceptions as we call JSC. (WebCore::InspectorController::handleException): Added.
- page/InspectorController.h:
- 8:35 PM Changeset in webkit [31350] by
-
- 4 edits in trunk/JavaScriptCore
Fix Bug 18060: Assertion failure (JSLock not held) beneath JSCallbackObject<Base>::toString
Reviewed by Geoff Garen.
Bug fix:
- API/JSCallbackObjectFunctions.h: (KJS::JSCallbackObject<Base>::toString): Make the DropAllLocks instance only be in scope while calling convertToType.
Test:
- API/testapi.c: (MyObject_convertToType): Implement type conversion to string.
- API/testapi.js: Add a test for type conversion to string.
- 8:14 PM Changeset in webkit [31349] by
-
- 3 edits in trunk/WebCore
2008-03-26 Darin Adler <Darin Adler>
Rubber stamped by Maciej.
- removed a couple log messages in error cases that are handled internally
- platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::decode): Removed the LOG_ERROR.
- platform/text/mac/TextCodecMac.cpp: (WebCore::TextCodecMac::decode): Ditto.
- 8:11 PM Changeset in webkit [31348] by
-
- 4 edits in trunk/WebKitLibraries
Windows build fix after r31322
- win/include/WebKitSystemInterface/WebKitSystemInterface.h: Updated.
- win/lib/WebKitSystemInterface.lib: Updated.
- win/lib/WebKitSystemInterface_debug.lib: Updated.
- 7:56 PM Changeset in webkit [31347] by
-
- 2 edits in trunk/WebCore
2008-03-26 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
- page/Location.idl: Don't enumerate toString.
- 7:53 PM Changeset in webkit [31346] by
-
- 2 edits in trunk/LayoutTests
2008-03-26 Sam Weinig <sam@webkit.org>
Rubber-stamped by Adam Roben.
Update test result.
- fast/dom/Window/window-special-properties-expected.txt:
- 7:45 PM Changeset in webkit [31345] by
-
- 1 edit1 add in trunk/WebKitSite
2008-03-26 Maciej Stachowiak <mjs@apple.com>
Screenshot for blog post.
- blog-files/acid3-100.png: Added.
- 7:41 PM Changeset in webkit [31344] by
-
- 2 edits in trunk/WebCore
Release build fix.
- 7:34 PM Changeset in webkit [31343] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix
- kjs/array_instance.cpp: Touched this.
- wtf/HashFunctions.h: (WTF::intHash): Added 8- and 16-bit versions of intHash.
- 7:34 PM Changeset in webkit [31342] by
-
- 22 edits5 adds in trunk
WebCore:
2008-03-26 Maciej Stachowiak <mjs@apple.com>
Reviewed by Hyatt and Adam.
Coded by me and Darin.
- SVG kerning support (horizontal kerning only for now since we don't do vertical text layout right yet)
Acid3 100/100
- DerivedSources.make:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/Font.cpp: (WebCore::Font::floatWidth): (WebCore::Font::isSVGFont):
- platform/graphics/Font.h:
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::calculateGlyphWidth): (WebCore::SVGInlineTextBox::calculateGlyphBoundaries):
- rendering/SVGInlineTextBox.h:
- rendering/SVGRootInlineBox.cpp: (WebCore::cummulatedWidthOrHeightOfTextChunk): (WebCore::SVGRootInlineBox::buildLayoutInformation): (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
- rendering/SVGRootInlineBox.h: (WebCore::LastGlyphInfo::LastGlyphInfo):
- svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk): (WebCore::Font::svgFont): (WebCore::floatWidthOfSubStringUsingSVGFont): (WebCore::Font::floatWidthUsingSVGFont): (WebCore::Font::drawTextUsingSVGFont): (WebCore::Font::selectionRectForTextUsingSVGFont):
- svg/SVGFontElement.cpp: (WebCore::SVGFontElement::invalidateGlyphCache): (WebCore::SVGFontElement::ensureGlyphCache): (WebCore::parseUnicodeRange): (WebCore::parseUnicodeRangeList): (WebCore::stringMatchesUnicodeRange): (WebCore::matches): (WebCore::SVGFontElement::getHorizontalKerningPairForStringsAndGlyphs):
- svg/SVGFontElement.h:
- svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::insertedIntoDocument): (WebCore::SVGGlyphElement::removedFromDocument):
- svg/SVGHKernElement.cpp: Added. (WebCore::SVGHKernElement::SVGHKernElement): (WebCore::SVGHKernElement::~SVGHKernElement): (WebCore::SVGHKernElement::insertedIntoDocument): (WebCore::SVGHKernElement::removedFromDocument): (WebCore::SVGHKernElement::buildHorizontalKerningPair):
- svg/SVGHKernElement.h: Added. (WebCore::SVGHorizontalKerningPair::SVGHorizontalKerningPair): (WebCore::SVGHKernElement::rendererIsNeeded):
- svg/SVGHKernElement.idl: Added.
- svg/SVGTextContentElement.cpp: (WebCore::cummulatedCharacterRangeLength): (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback):
- svg/svgtags.in:
LayoutTests:
2008-03-26 Maciej Stachowiak <mjs@apple.com>
Reviewed by Hyatt and Adam.
- new test case and test fixes for SVG text kerning
- svg/text/kerning.svg: Added.
- platform/mac/svg/text/kerning-expected.txt: Added.
- platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
- platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- 7:21 PM Changeset in webkit [31341] by
-
- 16 edits4 adds2 deletes in trunk/WebCore
2008-03-26 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
Autogenerate JSLocation.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl: Add files.
- DerivedSources.make: Add Location, remove JSLocation.lut.h
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBasePrivate::JSDOMWindowBasePrivate): (WebCore::JSDOMWindowBase::getValueProperty): (WebCore::JSDOMWindowBase::put): (WebCore::JSDOMWindowBase::clearHelperObjectProperties): (WebCore::JSDOMWindowBase::disconnectFrame):
- bindings/js/JSDOMWindowBase.h: Remove manuel management of the Location object.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::mark): Add marking of JSLocation. (WebCore::JSDOMWindow::setLocation): Add custom setLocation as we only want to do this when safe and we need to keep Dashboard quirks.
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): Fetch the location object using the normal toJS route.
- bindings/js/JSLocation.cpp: Removed.
- bindings/js/JSLocation.h: Removed.
- bindings/js/JSLocationCustom.cpp: Added. (WebCore::JSLocation::customGetOwnPropertySlot): (WebCore::JSLocation::customPut): (WebCore::JSLocation::deleteProperty): (WebCore::JSLocation::customGetPropertyNames): (WebCore::navigateIfAllowed): (WebCore::JSLocation::setHref): (WebCore::JSLocation::setProtocol): (WebCore::JSLocation::setHost): (WebCore::JSLocation::setHostname): (WebCore::JSLocation::setPort): (WebCore::JSLocation::setPathname): (WebCore::JSLocation::setSearch): (WebCore::JSLocation::setHash): (WebCore::JSLocation::replace): (WebCore::JSLocation::reload): (WebCore::JSLocation::assign): (WebCore::JSLocation::toString): Setter and Functions need custom implementations as they rely on the dynamic global object for determining the behavior of the navigation.
- history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::restore): (WebCore::CachedPage::clear):
- history/CachedPage.h: Removed all the special casing for location as it should be treated like all the other objects hanging off the window.
- page/DOMWindow.cpp: (WebCore::DOMWindow::clear): (WebCore::DOMWindow::location):
- page/DOMWindow.h: (WebCore::DOMWindow::optionalLocation):
- page/DOMWindow.idl: Add Location accessor and pointer getter for marking.
- page/Location.cpp: Added. (WebCore::Location::Location): (WebCore::Location::disconnectFrame): (WebCore::Location::url): (WebCore::Location::href): (WebCore::Location::protocol): (WebCore::Location::host): (WebCore::Location::hostname): (WebCore::Location::port): (WebCore::Location::pathname): (WebCore::Location::search): (WebCore::Location::hash): (WebCore::Location::toString):
- page/Location.h: Added. (WebCore::Location::create): (WebCore::Location::frame):
- page/Location.idl: Added.
- 6:53 PM Changeset in webkit [31340] by
-
- 3 adds in trunk/LayoutTests/platform/mac/svg/custom
Add layout test results for altGlyph.
- 6:53 PM Changeset in webkit [31339] by
-
- 1 add in trunk/LayoutTests/svg/custom/altglyph.svg
Add layout test for altGlyph.
- 6:52 PM Changeset in webkit [31338] by
-
- 6 edits in trunk/WebCore
2008-03-26 David Hyatt <hyatt@apple.com>
Add support for the rendering and measurement of the <altGlyph> element in SVG. This patch brings
is half of what's needed to reach 100/100 on Acid3 and pass the test. Maciej has coded up the other half. :)
Reviewed by mjs
Added svg/custom/altGlyph.svg
- svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::childShouldCreateRenderer): (WebCore::SVGAltGlyphElement::glyphElement):
- svg/SVGAltGlyphElement.h:
- svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk):
- svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::insertedIntoDocument):
- svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::insertedIntoDocument): (WebCore::SVGGlyphElement::removedFromDocument):
- 6:43 PM Changeset in webkit [31337] by
-
- 8 edits in trunk
Turn on SVG animation on Windows
Force JSC headers to be copied by touching a file
- kjs/array_instance.cpp: (KJS::ArrayInstance::getPropertyNames):
WebCore:
Turn on SVG animation on Windows
Also touched some files to force things to rebuild/regenerate.
- WebCore.vcproj/WebCore.vcproj: Added ENABLE_SVG_ANIMATION.
- WebCore.vcproj/build-generated-files.sh: Ditto.
- bindings/scripts/CodeGenerator.pm: Touched.
- config.h: Touched.
- svg/svgtags.in: Touched.
- 6:10 PM Changeset in webkit [31336] by
-
- 2 edits in trunk/WebCore
2008-03-26 Justin Garcia <justin.garcia@apple.com>
Reviewed by Harrison.
<rdar://problem/5820749> REGRESSION (Safari 3.1): Mail's plain text reply omits blank line following the attribution
- editing/markup.cpp: (WebCore::createFragmentFromText): When asked to create a fragment from "Attribution:\n" with a context from [html, 0] to [html, 0], we'd return "<html>Attribution</html><br>". Don't enclose paragraphs in clones of the context's enclosing block if that block is the html or body element. Currently no way to test [DOMHTMLElement createFragmentFromText:].
- 5:58 PM Changeset in webkit [31335] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix after r31324
Written with Darin.
Added HashTable plumbing to support using wchar_t as a key type.
- wtf/HashFunctions.h:
- wtf/HashTraits.h: (WTF::):
- 5:21 PM Changeset in webkit [31334] by
-
- 6 edits in trunk
WebCore:
2008-03-26 Antti Koivisto <Antti Koivisto>
Reviewed by Anders.
http://bugs.webkit.org/show_bug.cgi?id=17077
Bug 17077: SVG SMIL animation is currently broken (and turned off) (affects Acid3 tests 75 and 76)
- enable SVG animation support.
- basic implementation of beginElement()/endElement().
Animation definitely will need more work than this, but it is a start!
- Configurations/WebCore.xcconfig:
- svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::SVGAnimationElement): (WebCore::SVGAnimationElement::updateAnimatedValueForElapsedSeconds): (WebCore::SVGAnimationElement::beginElement): (WebCore::SVGAnimationElement::beginElementAt): (WebCore::SVGAnimationElement::endElement): (WebCore::SVGAnimationElement::endElementAt):
- svg/SVGAnimationElement.h:
WebKitTools:
2008-03-26 Antti Koivisto <Antti Koivisto>
Reviewed by Anders.
Enable SVG animation support by default.
- Scripts/build-webkit:
- 4:34 PM Changeset in webkit [31333] by
-
- 10 edits in trunk
2008-03-26 Mark Rowe <mrowe@apple.com>
Reviewed by David Hyatt.
Make the Ahem font antialias correctly on Acid3 on Tiger.
- WebCore.Tiger.exp:
- platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
2008-03-26 Mark Rowe <mrowe@apple.com>
Reviewed by David Hyatt.
Make the Ahem font antialias correctly on Acid3 on Tiger.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceTiger.a:
2008-03-26 Mark Rowe <mrowe@apple.com>
Reviewed by David Hyatt.
Make the Ahem font antialias correctly on Acid3 on Tiger.
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
- 4:03 PM squirrelfish edited by
- (diff)
- 4:02 PM Changeset in webkit [31332] by
-
- 3 edits in trunk/WebCore
Attempt to fix the Qt build.
- 3:56 PM Changeset in webkit [31331] by
-
- 2 edits in trunk/LayoutTests
2008-03-26 Stephanie Lewis <Stephanie Lewis>
Not Reviewed.
Move storage tests to Skipped list since they hang 80% of the time. See <rdar://problem/5787763>.
- platform/win/Skipped:
- 3:54 PM Changeset in webkit [31330] by
-
- 2 edits in branches/squirrelfish/JavaScriptCore
2008-03-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Moved a few files around in the XCode project.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 3:50 PM Changeset in webkit [31329] by
-
- 11 edits2 adds in branches/squirrelfish/JavaScriptCore
2008-03-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Made closures work.
An activation object aliases to the register file until its associated
function returns, at which point it copies the registers for locals and
parameters into an independent storage buffer.
- 3:49 PM squirrelfish edited by
- (diff)
- 1:53 PM Changeset in webkit [31328] by
-
- 2 edits in trunk/WebCore
2008-03-26 Dan Bernstein <mitz@apple.com>
Reviewed by Anders Carlsson.
- fix http://bugs.webkit.org/show_bug.cgi?id=18104 REGRESSION: LEAK: 2 InlineBox in editing/inserting/12882.html
- rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): When deciding to ditch old clean lines (due to changed or newly-added floats), keep the reference to those lines so they can be properly deleted in the end, and use a separate flag to signal that no matching should be attempted.
- 1:21 PM Changeset in webkit [31327] by
-
- 2 edits in trunk/WebCore
Speculative Windows build fix.
- 1:04 PM squirrelfish edited by
- Note that Sam is working on implementing more code emitters (diff)
- 1:01 PM squirrelfish edited by
- (diff)
- 12:59 PM Changeset in webkit [31326] by
-
- 2 edits in trunk/WebCore
2008-03-25 Steve Falkenburg <sfalken@apple.com>
Turn on link-time-codegen in html and rendering related files.
Reviewed by Oliver.
- WebCore.vcproj/WebCore.vcproj:
- 12:26 PM Changeset in webkit [31325] by
-
- 3 edits in trunk/JavaScriptCore
2008-03-26 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
- JSC part of fix for "SVG multichar glyph matching matches longest instead of first (affects Acid3 test 79)" http://bugs.webkit.org/show_bug.cgi?id=18118
- wtf/HashFunctions.h: (WTF::):
- wtf/HashTraits.h: (WTF::):
- 12:22 PM Changeset in webkit [31324] by
-
- 8 edits1 add in trunk
WebCore:
2008-03-26 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
- fixed "SVG multichar glyph matching matches longest instead of first (affects Acid3 test 79)" http://bugs.webkit.org/show_bug.cgi?id=18118
- svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk):
- svg/SVGFontElement.cpp: (WebCore::SVGFontElement::SVGFontElement): (WebCore::SVGFontElement::addGlyphToCache): (WebCore::SVGFontElement::removeGlyphFromCache): (WebCore::SVGFontElement::ensureGlyphCache): (WebCore::SVGFontElement::getGlyphIdentifiersForString):
- svg/SVGFontElement.h:
- svg/SVGGlyphElement.h: (WebCore::SVGGlyphIdentifier::SVGGlyphIdentifier):
- svg/SVGGlyphMap.h: Added. New radix tree based glyph map. (WebCore::GlyphMapNode::GlyphMapNode): (WebCore::SVGGlyphMap::SVGGlyphMap): (WebCore::SVGGlyphMap::add): (WebCore::SVGGlyphMap::compareGlyphPriority): (WebCore::SVGGlyphMap::get): (WebCore::SVGGlyphMap::clear):
LayoutTests:
2008-03-26 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
- test updates for "SVG multichar glyph matching matches longest instead of first (affects Acid3 test 79)" http://bugs.webkit.org/show_bug.cgi?id=18118
These test cases were already checking for this exact bug and now
render correctly.
- platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
- 12:12 PM Changeset in webkit [31323] by
-
- 3 edits in trunk/WebCore
2008-03-26 David Hyatt <hyatt@apple.com>
Fix build bustage on Tiger. Tiger will not have the bug fix.
- platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit):
- platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformInit):
- 12:01 PM Changeset in webkit [31322] by
-
- 6 edits in trunk/WebCore
2008-03-26 David Hyatt <hyatt@apple.com>
Make the Ahem font antialias correctly on Acid3.
Reviewed by Dan
- platform/graphics/SimpleFontData.h:
- platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
- platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit):
- platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformInit):
- 11:04 AM Changeset in webkit [31321] by
-
- 4 edits in trunk
Fix the Mac build.
- 10:49 AM Changeset in webkit [31320] by
-
- 2 edits in trunk/WebCore
Fix Bug 17768: REGRESSION (r30146): Inspector no longer shows elements properties
We were throwing an exception from Object.describe because of some
undefined variables.
Reviewed by Tim Hatcher.
- page/inspector/utilities.js: (Object.describe): Reinstate the type1 and type2 variables that were removed in r30146. They're still used when formatting a function.
- 10:44 AM Changeset in webkit [31319] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Darin.
Cache C string identifiers by address, not value, assuming that C strings can only
be literals.
1% speedup on Acid3 test 26.
- kjs/identifier.cpp: (KJS::literalIdentifierTable): (KJS::Identifier::add): Added a new table to cache UString::Reps created from C strings by address. Elements are never removed from this cache, as only predefined identifiers can get there.
- kjs/identifier.h: (KJS::Identifier::Identifier): Added a warning.
- 10:29 AM Changeset in webkit [31318] by
-
- 2 edits in trunk/JavaScriptCore
Rubber-stamped by Maciej.
An assertion was failing in function-toString-object-literals.html when parsing 1e-500.
The condition existed before, and got uncovered by turning compiled-out dtoa checks into
ASSERTs.
The assertion was verifying that the caller wasn't constructing a Bigint from 0.
This might have had some reason behind it originally, but I couldn't find any,
and this doesn't look like a reasonable requirement.
- kjs/dtoa.cpp: (d2b): Removed the assertion (two copies in different code paths).
- 10:27 AM Changeset in webkit [31317] by
-
- 2 edits in trunk/WebCore
Reviewed by darin.
Forgot to add braces darin asked for during review.
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::write):
- 10:19 AM Changeset in webkit [31316] by
-
- 22 edits7 adds in trunk
Reviewed by darin.
Fix, makes us pass Test 70
XML documents should be strict about encoding checks
http://bugs.webkit.org/show_bug.cgi?id=17079
Test: fast/encoding/invalid-xml.html
- WebCore.base.exp:
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::write):
- loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
- loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::TextResourceDecoder): (WebCore::TextResourceDecoder::decode):
- loader/TextResourceDecoder.h:
- platform/text/TextCodec.h: (WebCore::TextCodec::decode):
- platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::decodeToBuffer): (WebCore::ErrorCallbackSetter::ErrorCallbackSetter): (WebCore::ErrorCallbackSetter::~ErrorCallbackSetter): (WebCore::TextCodecICU::decode):
- platform/text/TextCodecICU.h:
- platform/text/TextCodecLatin1.cpp:
- platform/text/TextCodecLatin1.h:
- platform/text/TextCodecUTF16.cpp:
- platform/text/TextCodecUTF16.h:
- platform/text/TextCodecUserDefined.cpp:
- platform/text/TextCodecUserDefined.h:
- platform/text/TextDecoder.cpp: (WebCore::TextDecoder::checkForBOM):
- platform/text/TextDecoder.h: (WebCore::TextDecoder::decode):
- platform/text/TextEncoding.cpp: (WebCore::TextEncoding::decode):
- platform/text/TextEncoding.h: (WebCore::TextEncoding::decode):
- platform/text/mac/TextCodecMac.cpp: (WebCore::TextCodecMac::decode):
- platform/text/mac/TextCodecMac.h:
- 9:59 AM Changeset in webkit [31315] by
-
- 9 edits2 adds in trunk/WebCore
2008-03-26 Antti Koivisto <Antti Koivisto>
Reviewed by Adam.
Add ElementTimeControl interface to SVGAnimationElement.
Passes Acid3 test 75.
- DerivedSources.make:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGeneratorObjC.pm:
- svg/ElementTimeControl.h: Added. (WebCore::ElementTimeControl::~ElementTimeControl):
- svg/ElementTimeControl.idl: Added.
- svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::beginElement): (WebCore::SVGAnimationElement::beginElementAt): (WebCore::SVGAnimationElement::endElement): (WebCore::SVGAnimationElement::endElementAt):
- svg/SVGAnimationElement.h:
- svg/SVGAnimationElement.idl:
- 9:22 AM Changeset in webkit [31314] by
-
- 2 edits in trunk/WebCore
2008-03-26 Kevin McCullough <kmccullough@apple.com>
- LayoutTest fix. Null check.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):
- 7:33 AM Changeset in webkit [31313] by
-
- 5 edits12 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=17994 REGRESSION (523-525+) View not updated when changing CSS size via JavaScript
- fix http://bugs.webkit.org/show_bug.cgi?id=18063 REGRESSION (r31250): Small bug that just cropped up in WebKit r31275
Tests: fast/repaint/subtree-root-clip.html
fast/repaint/subtree-root-clip-2.html
fast/repaint/subtree-root-clip-3.html
- rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState): Changed to not set an initial clip. Since the root is clipping, there is no need to set a clip, and setting the clip based on the container was wrong because often the root was not included in the container's overflow rect because it had its own layer.
- rendering/RenderBox.cpp: (WebCore::RenderBox::absolutePosition): Removed code that added table cell's extra top offset only in the slow (recursive) code path.
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::absolutePosition): Added code to add the extra top offset in both code paths.
LayoutTests:
Reviewed by Darin Adler.
- tests for http://bugs.webkit.org/show_bug.cgi?id=17994 REGRESSION (523-525+) View not updated when changing CSS size via JavaScript
- and http://bugs.webkit.org/show_bug.cgi?id=18063 REGRESSION (r31250): Small bug that just cropped up in WebKit r31275
- fast/repaint/subtree-root-clip-2.html: Added.
- fast/repaint/subtree-root-clip-3.html: Added.
- fast/repaint/subtree-root-clip.html: Added.
- platform/mac/fast/repaint/subtree-root-clip-2-expected.checksum: Added.
- platform/mac/fast/repaint/subtree-root-clip-2-expected.png: Added.
- platform/mac/fast/repaint/subtree-root-clip-2-expected.txt: Added.
- platform/mac/fast/repaint/subtree-root-clip-3-expected.checksum: Added.
- platform/mac/fast/repaint/subtree-root-clip-3-expected.png: Added.
- platform/mac/fast/repaint/subtree-root-clip-3-expected.txt: Added.
- platform/mac/fast/repaint/subtree-root-clip-expected.checksum: Added.
- platform/mac/fast/repaint/subtree-root-clip-expected.png: Added.
- platform/mac/fast/repaint/subtree-root-clip-expected.txt: Added.
- 6:00 AM Changeset in webkit [31312] by
-
- 2 edits in trunk/WebCore
Fix the Qt build.
- 3:18 AM Changeset in webkit [31311] by
-
- 2 edits in trunk
Fixed reviewer in WebCore/ChangeLog and LayoutTests/ChangeLog
- 3:10 AM Changeset in webkit [31310] by
-
- 15 edits2 adds in trunk
WebCore:
2008-03-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by Maciej.
- fixed "SVGTextElement.getStartPositionOfChar does not correctly account for multichar glyphs" http://bugs.webkit.org/show_bug.cgi?id=18046
- platform/graphics/Font.cpp: (WebCore::Font::floatWidth): Allow expressing a run that has extra "context" characters beyond the end, and reporting of how many characters were actually consumed, to support multichar glyphs in SVG fonts.
- platform/graphics/Font.h:
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::calculateGlyphWidth): Pass along extra chars in argument and chars consumed out argument. (WebCore::SVGInlineTextBox::calculateGlyphHeight): Pass along extra chars in argument. (WebCore::SVGInlineTextBox::calculateGlyphBoundaries): Add boilerplate; may not handle multichar glyphs right but I don't know what effects this would have.
- rendering/SVGInlineTextBox.h:
- rendering/SVGRootInlineBox.cpp: (WebCore::cummulatedWidthOrHeightOfTextChunk): Add boilerplate; may not handle multichar glyphs right but again I am not sure what effect this would have. (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox): Account for multichar glyphs - let glyph selection consider extra chars, and account for the fact that a glyph may have consumed multiple chars.
- rendering/SVGRootInlineBox.h:
- svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk): This is the place where glyph selection happens, so this is where we accout for multichar glyphs (both looking at extra chars past the end of the run, and reporting how many chars were consumed). (WebCore::floatWidthOfSubStringUsingSVGFont): Pass aforementioned info through the layers. (WebCore::Font::floatWidthUsingSVGFont): ditto (WebCore::Font::drawTextUsingSVGFont): ditto (WebCore::Font::selectionRectForTextUsingSVGFont): ditto
- svg/SVGTextContentElement.cpp: (WebCore::cummulatedCharacterRangeLength): ditto (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback): ditto
LayoutTests:
2008-03-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by Maciej.
- test case and new results for "SVGTextElement.getStartPositionOfChar does not correctly account for multichar glyphs" http://bugs.webkit.org/show_bug.cgi?id=18046
- svg/text/multichar-glyph.svg: Added. New test case for both rendering and getStartPositionOfChar access of multichar glyphs.
- platform/mac/svg/text/multichar-glyph-expected.txt: Added.
The following test results changed, all appear to be improvements.
- platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
- platform/mac/svg/text/text-altglyph-01-b-expected.txt:
- platform/mac/svg/text/text-text-06-t-expected.txt:
