Timeline
Apr 5, 2008:
- 11:50 PM squirrelfish edited by
- Remove InNode (diff)
- 11:50 PM Changeset in webkit [31669] by
-
- 1 edit in branches/squirrelfish/JavaScriptCore/ChangeLog
Fix ChangeLog
- 11:48 PM Changeset in webkit [31668] by
-
- 8 edits in branches/squirrelfish/JavaScriptCore
2008-04-05 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implement codegen for ForInNode.
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitIn):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- VM/Opcode.h:
- kjs/nodes.cpp: (KJS::InNode::emitCode):
- kjs/nodes.h:
- 5:56 PM Changeset in webkit [31667] by
-
- 2 edits in trunk/WebKit/wx
Rubber stamped by Mark Rowe.
Don't assume wxWebKit to be part of the wx package. This allows us to run it from any directory on the PYTHONPATH rather than having to copy files into the wxPython directory.
- 5:38 PM Changeset in webkit [31666] by
-
- 3 edits in trunk/WebCore
Reviewed by Mark Rowe.
Add CSS to the MIMETypeRegistry, which ensures CSS files get the right MIMEType when loaded from disk.
- 4:17 PM squirrelfish edited by
- DeleteNodes now work (diff)
- 3:58 PM Changeset in webkit [31665] by
-
- 8 edits in branches/squirrelfish/JavaScriptCore
2008-04-05 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
- Implement codegen for DeleteResolveNode, DeleteBracketNode, DeleteDotNode and DeleteValueNode.
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitGetPropId): (KJS::CodeGenerator::emitPutPropId): (KJS::CodeGenerator::emitDeletePropId): (KJS::CodeGenerator::emitDeletePropVal): (KJS::CodeGenerator::emitPutPropIndex):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- VM/Opcode.h:
- kjs/nodes.cpp: (KJS::DeleteResolveNode::emitCode): (KJS::DeleteBracketNode::emitCode): (KJS::DeleteDotNode::emitCode): (KJS::DeleteValueNode::emitCode):
- kjs/nodes.h:
- 1:43 PM Changeset in webkit [31664] by
-
- 4 edits4 adds in trunk
Reviewed by Eric.
http://bugs.webkit.org/show_bug.cgi?id=17129
Incorrect style resolution in CSS styled SVG, with multiple style sheets
Fix the style resolution on the svg by ensuring xml-stylesheet pseudo
attributes title and alternate are transferred to the stylesheet
created from the ProcessingInstruction.
- 9:05 AM Changeset in webkit [31663] by
-
- 5 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/5843719> Excessive repainting of cells in tables with non-auto height
Test: fast/repaint/table-two-pass-layout-overpaint.html
- rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Changed the first pass over the sections to only call calcRowHeight() and recalcOuterBorder() but not layoutRows(), because the section's final height is unknown yet. Removed caching of m_height before the call to calcHeight(), because for non-positioned tables, calcHeight() only calculates the vertical margins and does not change m_height. Added a second pass over the sections, after the table height is known, to call layoutRows() on each section, with additional height if needed. Did minimal cleanup including caching the value of collapseBorders() in a local variable and changing a while loop into a for loop.
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::calcRowHeight): Changed to return the height of the section based on row height calculations. (WebCore::RenderTableSection::layoutRows): Removed a call to recalcOuterBorder(), which is now done by RenderTable::layout().
- rendering/RenderTableSection.h: Changed calcRowHeight() to have a return value.
LayoutTests:
Reviewed by Darin Adler.
- repaint test for <rdar://problem/5843719> Excessive repainting of cells in tables with non-auto height
- fast/repaint/table-two-pass-layout-overpaint.html: Added.
- platform/mac/fast/repaint/table-two-pass-layout-overpaint-expected.checksum: Added.
- platform/mac/fast/repaint/table-two-pass-layout-overpaint-expected.png: Added.
- platform/mac/fast/repaint/table-two-pass-layout-overpaint-expected.txt: Added.
- 5:33 AM Changeset in webkit [31662] by
-
- 3 edits in trunk/WebCore
Simon Hausmann <shausman@trolltech.com>
Fixes: Disable "unimplemented" warnings when building WebKit inside Qt.
- 5:24 AM Changeset in webkit [31661] by
-
- 2 edits in trunk/WebKit/qt
Olivier Goffart <ogoffart@trolltech.com>
Fixes: Right clicking an image and choosing "copy image" doesnt put anything in the clipboard.
- 5:24 AM Changeset in webkit [31660] by
-
- 2 edits in trunk/WebKit/qt
Olivier Goffart <ogoffart@trolltech.com>
Fixes: Right click, and "Open image" open the link instead of the image.
- 5:23 AM Changeset in webkit [31659] by
-
- 2 edits in trunk/WebCore
Simon Hausmann <Simon Hausmann>
Rubber-stamped by Holger
Revert "* Load images incrementally. This will show warnings on the console"
This rolls out -r29739.
This unfortunately caused some crashes and drawing errors. Backing out for now.
- 5:01 AM QtWebKitContrib edited by
- (diff)
- 4:56 AM Changeset in webkit [31658] by
-
- 2 edits in trunk/WebKit/qt
Benjamin Meyer <bmeyer@trolltech.com>
Added doc stub for QWebSettings so class docs are generated
- 4:56 AM Changeset in webkit [31657] by
-
- 4 edits in trunk/WebKit/qt
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
- Propose the addition of updateRequest and scrollRequest to the QWebPage.
- The question is if these signals belong to QWebPage or QWebFrame.
-It is more easy to have them in QWebPage because ScrollView is invoking
the ChromeClient with the right coordinates
-On the other hand someone wants to render frames separately. But this is partly
doomed as you can have overlapping frames and what you paint would not relate to
what you normally see on webpages.
Apr 4, 2008:
- 11:34 PM Changeset in webkit [31656] by
-
- 3 edits in trunk/WebKit/win
Only delete the backing store of background windows.
Reviewed by Ada Chan.
- WebView.cpp: (WebView::WebView): (WebView::deleteBackingStore): (WebView::paint): Added active check. (WebView::deleteBackingStoreSoon): (WebView::cancelDeleteBackingStoreSoon): Added. (WebView::active): Added. (WebView::updateActiveState): Moved active check code from here to active().
- WebView.h:
- 10:50 PM Changeset in webkit [31655] by
-
- 2 edits in trunk/WebKit/win
Fix tooltip window leak.
Explicitly call DestroyWindow on the tooltip.
Destroying its parent won't destroy the tooltip, since it not a WS_CHILD style window.
Reviewed by Ada Chan.
- WebView.cpp: (WebView::~WebView):
- 10:17 PM Changeset in webkit [31654] by
-
- 2 edits in trunk/WebCore
Add GradientWx.cpp to the wx build process.
- 9:54 PM Changeset in webkit [31653] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
- speed up CSSFontSelector::getFontData()
- css/CSSFontSelector.cpp: (WebCore::fontDataForGenericFamily): Factored out of getFontData(). (WebCore::CSSFontSelector::getFontData): Changed to call fontDataForGenericFamily() directly if the map is empty.
- 9:02 PM Changeset in webkit [31652] by
-
- 5 edits in trunk/WebCore
2008-04-04 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Oliver.
Replace AccessibilityObject::isRenderImage() with a virtual
RenderObject::isRenderImage().
- page/AccessibilityObject.cpp: (WebCore::AccessibilityObject::accessibilityIsIgnored): (WebCore::AccessibilityObject::addChildren):
- page/AccessibilityObject.h: (WebCore::AccessibilityObject::isDetached):
- rendering/RenderImage.h: (WebCore::RenderImage::isRenderImage):
- rendering/RenderObject.h: (WebCore::RenderObject::isRenderImage):
- 7:14 PM Changeset in webkit [31651] by
-
- 3 edits in trunk/WebKit/win
Delete backing store after we go 5 seconds without a paint.
Timer will be reset if a paint occurs, so this won't negatively impact performance.
Reviewed by Ada Chan.
- WebView.cpp: (WebView::paint): Call deleteBackingStoreSoon after paint. (WebViewWndProc): Add DeleteBackingStoreTimer. (WebView::deleteBackingStoreSoon): Added.
- WebView.h: Add deleteBackingStoreSoon.
- 5:13 PM Changeset in webkit [31650] by
-
- 2 edits in trunk/WebCore
- try to fix the wx build
- platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::fontWeightToWxFontWeight): (WebCore::FontPlatformData::FontPlatformData):
- 5:05 PM Changeset in webkit [31649] by
-
- 4 edits in trunk/WebCore
2008-04-04 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Beth.
Some more clean-up of AccessibilityObject:
- Rearranged/grouped methods.
- Marked many methods const.
- Changed many methods to take args by const ref instead of by val.
- Made headingLevel() static.
- Renamed detached() to isDetached(), loaded() to isLoaded(), documentLinks to getDocumentLinks().
- Made clearChildren(), removeAXObjectID(), isDetached() private.
- Added notImplemented() calls for unimplemented methods.
- Replaced stringForReplacedNode method with static function.
- 3:32 PM squirrelfish edited by
- Remove some implemented Nodes from un-implemented opcode list (diff)
- 2:13 PM Changeset in webkit [31648] by
-
- 2 edits in trunk/WebCore
Restore the user entered text when clearing the auto-completion.
This is important when the user typed text that is a different
case than the completion. This has no affect on the Console, since
it matches completions case-sensitively. This is used in the up-coming
Database Query view for words like "SELECT" and "INSERT".
Reviewed by Adam Roben.
- page/inspector/TextPrompt.js:
(WebInspector.TextPrompt.prototype.clearAutoComplete): Restore the user typed
text in the original DOM range that complete() saved away.
(WebInspector.TextPrompt.prototype.complete): Store away the fullWordRange
and it's text content so clearAutoComplete can restore it.
- 2:11 PM Changeset in webkit [31647] by
-
- 5 edits in branches/squirrelfish/JavaScriptCore
2008-04-04 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
- Implement codegen for Switch statements.
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::pushJumpContext): (KJS::CodeGenerator::popJumpContext): (KJS::CodeGenerator::jumpContextForLabel):
- VM/CodeGenerator.h: Rename LoopContext to JumpContext now that it used of Switch statements in addition to loops.
- kjs/nodes.cpp: (KJS::DoWhileNode::emitCode): (KJS::WhileNode::emitCode): (KJS::ForNode::emitCode): (KJS::ForInNode::emitCode): (KJS::ContinueNode::emitCode): (KJS::BreakNode::emitCode): (KJS::CaseBlockNode::emitCodeForBlock): (KJS::SwitchNode::emitCode):
- kjs/nodes.h: (KJS::CaseClauseNode::expr): (KJS::CaseClauseNode::children): (KJS::CaseBlockNode::):
- 1:58 PM Changeset in webkit [31646] by
-
- 2 edits in trunk/WebCore
Don't trim whitespace when looking for the current match, this prevents tabbing through matches in the up-coming Database Query view.
Reviewed by Adam Roben.
- page/inspector/TextPrompt.js: Removed a trimTrailingWhitespace() call.
- 1:50 PM Changeset in webkit [31645] by
-
- 5 edits1 add in trunk/WebCore
Factor out the Console text completion and command history into
a new TextPrompt object. This TextPrompt object will be used later
other parts of the Inspector that need text completion and history.
Not functionality changed, just moved code around.
Reviewed by Adam Roben.
- WebCore.vcproj/WebCore.vcproj: Add TextPrompt.js.
- page/inspector/Console.js: Call the new prompt object and delete all the code that moved.
- page/inspector/TextPrompt.js: Added. Moved code from Console.js.
- page/inspector/WebKit.qrc: Add TextPrompt.js.
- page/inspector/inspector.html: Add TextPrompt.js.
- 1:29 PM Changeset in webkit [31644] by
-
- 2 edits in trunk/WebCore
Makes setting shouldRefreshChildren on a TreeElement perform the refresh
immediately if the element is already expanded.
Reviewed by Adam Roben.
- page/inspector/treeoutline.js:
(TreeElement.prototype.get shouldRefreshChildren): Return this._shouldRefreshChildren.
(TreeElement.prototype.set shouldRefreshChildren): If changing to true, and
already expanded,
call expand again to trigger the refresh. Sets this._shouldRefreshChildren.
(TreeElement.prototype._attach): Check for this._shouldRefreshChildren.
(TreeElement.prototype.expand): Ditto.
- 1:21 PM ApplicationsGtk edited by
- Epiphany is now WebKit-only (diff)
- 1:17 PM Changeset in webkit [31643] by
-
- 3 edits in trunk/WebCore
2008-04-04 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Beth.
Some clean up of AccessibilityObject:
- Use existing isImage() in more places.
- Use existing isTextControl() in more places.
- Added isRenderImage(). Check this before casting to RenderImage, since other, non-RenderImage derived RenderObjects (e.g. RenderListMarker) can return true for isImage().
- Fix two copy/paste errors with improper semicolons.
- page/AccessibilityObject.cpp: (WebCore::AccessibilityObject::isImageButton): Use isImage(). (WebCore::AccessibilityObject::isRenderImage): Added. (WebCore::AccessibilityObject::isAnchor): Use isImage(). (WebCore::AccessibilityObject::isAttachment): Same. (WebCore::AccessibilityObject::accessibilityDescription): Same. (WebCore::AccessibilityObject::accessibilityIsIgnored): Use isRenderImage() instead of isImage(). (WebCore::AccessibilityObject::url): Use isImage(). (WebCore::AccessibilityObject::textControl): Remove improper semicolon, and use isTextControl(). (WebCore::AccessibilityObject::textMarkerForIndex): Same. (WebCore::AccessibilityObject::indexForTextMarker): Use isTextControl(). (WebCore::AccessibilityObject::doAXRangeForLine): Same. (WebCore::AccessibilityObject::doAXRangeForIndex): Same (WebCore::AccessibilityObject::doAXStringForRange): Same. (WebCore::AccessibilityObject::roleValue): Use isImage(). (WebCore::AccessibilityObject::addChildren): Use isRenderImage().
- page/AccessibilityObject.h:
- 1:13 PM Changeset in webkit [31642] by
-
- 2 edits in trunk/WebCore
Fixes a null exception when hovering in some areas of the DOM tree.
Reviewed by Adam Roben.
- page/inspector/treeoutline.js:
(TreeOutline.prototype.treeElementFromPoint): Check listNode for null/undefined
before accessing any properties. Return null if listNode is null.
- 1:05 PM Changeset in webkit [31641] by
-
- 2 edits in trunk/WebCore
Changing WebInspector.currentFocusElement to/from an input element
does not change the actual focus of that input element. You see this
in the search field.
Reviewed by Adam Roben.
- page/inspector/inspector.js:
(WebInspector.set currentFocusElement): Call blur and focus if the
node implements them.
- 12:18 PM Changeset in webkit [31640] by
-
- 2 edits in trunk/WebCore
2008-04-04 David Hyatt <hyatt@apple.com>
Improve the background size heuristic for SVGs used as background images with no intrinsic size specified.
Treat them as having a background-size of 100%. This means their maximal size will be the box established
by background-origin.
Reviewed by Beth
- rendering/RenderBox.cpp: (WebCore::RenderBox::calculateBackgroundSize):
- 12:16 PM Changeset in webkit [31639] by
-
- 5 edits in trunk/WebCore
Correctly show DOCTYPE in the breadcrumbs and match the CSS rules
from view-source.css for the DOCTYPE in the DOM tree.
Reviewed by Adam Roben.
- css/view-source.css: Add and correct comments about keeping
in-sync with inspector.css.
- page/inspector/ElementsPanel.js:
(WebInspector.DocumentPanel.prototype.updateBreadcrumb):
Add a case for Node.DOCUMENT_TYPE_NODE.
- page/inspector/inspector.css: Add a rule for .webkit-html-doctype.
- page/inspector/utilities.js:
(nodeTitleInfo): Use the webkit-html-doctype class for nodes
with Node.DOCUMENT_TYPE_NODE.
- 12:02 PM Changeset in webkit [31638] by
-
- 1 edit1 copy in trunk/WebCore
- try to fix the Tiger build
- icu/unicode/uscript.h: Copied from WebKit/mac/icu/unicode/uscript.h.
- 11:17 AM Changeset in webkit [31637] by
-
- 4 edits in trunk
Make WebKit use WebCore's copy of the ICU headers
WebCore:
Copy icu/ to PrivateHeaders for WebKit's benefit
Rubberstamped by Tim Hatcher.
- WebCore.xcodeproj/project.pbxproj: Renamed the Copy Forwarding Headers build phase to Copy Forwarding and ICU Headers, and added the icu/ directory to it.
WebKit/mac:
Use WebCore's ICU headers instead of our own copy
Rubberstamped by Tim Hatcher.
- Configurations/WebKit.xcconfig: Pick up ICU headers from WebCore's PrivateHeaders.
- 10:47 AM Changeset in webkit [31636] by
-
- 4 edits in trunk
Fix <rdar://problem/5804776> Would like to use WebCore's ForwardingHeaders in WebKit without manually creating copies
WebCore:
Fix <rdar://problem/5804776> Would like to use WebCore's
ForwardingHeaders in WebKit without manually creating copies
Patch by Tim Hatcher, typed by me.
- WebCore.xcodeproj/project.pbxproj: Added a new build phase, Copy Forwarding Headers, that copies the ForwardingHeaders directory to WebCore's PrivateHeaders directory.
WebKit/mac:
Fix <rdar://problem/5804776> Would like to use WebCore's
ForwardingHeaders in WebKit without manually creating copies
Patch by Tim Hatcher, typed by me.
- Configurations/WebKit.xcconfig: Use the copy of ForwardingHeaders in WebCore's PrivateHeaders instead of our own copy.
- 10:21 AM Changeset in webkit [31635] by
-
- 7 edits in trunk
WebCore:
Changed the signature of imageTitleForFilename so we can pass in the width
and height as integers.
Reviewed by Dan.
- page/mac/WebCoreViewFactory.h:
- platform/mac/LocalizedStringsMac.mm: (WebCore::imageTitle):
WebKit:
Updated the format string for window title for a standalone image to take integers.
Reviewed by Dan.
- English.lproj/Localizable.strings:
WebKit/mac:
Now we pass width and height directly as integers to format
the window title for a standalone image.
Reviewed by Dan.
- WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory imageTitleForFilename:width:height:]):
- 8:57 AM Changeset in webkit [31634] by
-
- 3 edits in trunk/WebKit/win
<rdar://problem/5830598> Image file opened in the browser window shows "Localized String Not Found' in window's title bar instead file name
Save WebCoreLocalizedStrings.cpp with UTF8 encoding.
Changed the format string to take in integers.
Reviewed by Dan.
- English.lproj/Localizable.strings: Updated.
- WebCoreLocalizedStrings.cpp: (WebCore::imageTitle):
- 12:54 AM squirrelfish edited by
- (diff)
- 12:52 AM QtWebKitContrib edited by
- (diff)
- 12:42 AM squirrelfish edited by
- (diff)
Apr 3, 2008:
- 11:38 PM Changeset in webkit [31633] by
-
- 2 edits in branches/squirrelfish/JavaScriptCore
2008-04-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam.
- fix crash in codegen from new nodes
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitConstruct):
- kjs/nodes.h:
- 11:38 PM Changeset in webkit [31632] by
-
- 1 edit in branches/squirrelfish/JavaScriptCore/kjs/nodes.h
File I forgot in my last commit.
- 11:34 PM Changeset in webkit [31631] by
-
- 2 edits in branches/squirrelfish/JavaScriptCore
2008-04-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Geoff.
- kjs/nodes.cpp: (KJS::ReadModifyResolveNode::emitCode): (KJS::ReadModifyBracketNode::emitCode):
- kjs/nodes.h:
- 10:28 PM Changeset in webkit [31630] by
-
- 1 edit in trunk/WebCore/platform/graphics/win/FontCacheWin.cpp
Forgot to save after the last change...
- 10:20 PM Changeset in webkit [31629] by
-
- 2 edits in trunk/WebCore
- Windows build fix
- platform/graphics/win/FontCacheWin.cpp: (WebCore::matchImprovingEnumProc):
- 10:08 PM Changeset in webkit [31628] by
-
- 2 edits in trunk/WebCore
Fix PlatformGradient so that it's a pointer on all platforms.
- 9:47 PM Changeset in webkit [31627] by
-
- 2 edits in trunk/WebCore
- 64-bit build fix
- platform/mac/WebFontCache.mm: (+[WebFontCache internalFontWithFamily:traits:weight:size:]):
- 9:34 PM Changeset in webkit [31626] by
-
- 1 edit1 add in trunk/WebCore
wx build fix. Add stubs for gradient class platform functions.
- 9:32 PM Changeset in webkit [31625] by
-
- 2 edits in trunk/WebCore
Reviewed by Dan Bernstein.
Refactor Gradient.h to have the same API on platforms without a gradient class.
- 9:13 PM Changeset in webkit [31624] by
-
- 2 edits in trunk/WebCore
- Qt build fix
- platform/graphics/qt/FontQt.cpp: (WebCore::Font::Font):
- 9:07 PM Changeset in webkit [31623] by
-
- 3 edits in trunk/WebCore
- Tiger build fix
- platform/mac/WebFontCache.mm:
- rendering/RenderThemeMac.mm:
- 9:04 PM Changeset in webkit [31622] by
-
- 4 edits in trunk/WebCore
- Gtk build fix
- platform/graphics/gtk/FontPlatformData.h: (WebCore::FontPlatformData::size):
- platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData):
- platform/graphics/gtk/FontPlatformDataPango.cpp: (WebCore::FontPlatformData::FontPlatformData):
- 8:51 PM Changeset in webkit [31621] by
-
- 4 edits in trunk/WebCore
- project file updates in preparation for build fixes
- GNUmakefile.am:
- WebCore.pro:
- WebCoreSources.bkl:
- 8:46 PM Changeset in webkit [31620] by
-
- 29 edits1 add in trunk
WebCore:
2008-04-03 Nicholas Shanks <webkit@nickshanks.com>
Updated by Dan Bernstein. Reviewed by Dave Hyatt.
- WebCore part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484 font-weight does not properly support graded weights
Tests to come: <http://bugs.webkit.org/show_bug.cgi?id=18306>
Build fixes for platforms other than Mac and Windows to come.
- WebCore.vcproj/WebCore.vcproj: Added FontDescription.cpp.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed to return additional weight value keywords 100, 200, 300, 500, 600, 800 and 900.
- css/CSSFontSelector.cpp: (WebCore::hashForFont): Changed the bold parameter into a weight parameter and added the weight to the string to be hashed. (WebCore::CSSFontSelector::addFontFaceRule): Changed to apply all CSS weight values to the font description. (WebCore::CSSFontSelector::getFontData): Updated the fallback logic to go through all weights equal or lighter from the desired weight. For SVG, to also consider heavier weights.
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Cleaned up parsing of the font-weight property.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Changed to apply all CSS weight values to the font description.
- platform/graphics/Font.h: (WebCore::Font::weight): Updated for the change to FontDescription::weight().
- platform/graphics/FontCache.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): Replaced the bold component of the key with a weight component. (WebCore::FontPlatformDataCacheKey::operator==): Updated for the above. (WebCore::computeHash): Ditto. (WebCore::FontPlatformDataCacheKeyTraits::deletedValue): Removed unnecessary parameters. (WebCore::FontPlatformDataCacheKeyTraits::emptyValue): Ditto. (WebCore::FontCache::getCachedFontPlatformData): Updated for the change in FontPlatformDataCacheKey.
- platform/graphics/FontDescription.cpp: Added. (WebCore::FontDescription::lighterWeight): Added. Returns a lighter CSS font-weight value if there is one, or the lightest value. (WebCore::FontDescription::bolderWeight): Added. Returns a heavier CSS font-weight value if there is one, or the heaviest value.
- platform/graphics/FontDescription.h: (WebCore::FontWeight): Added this enumeration. (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::bold): Removed. (WebCore::FontDescription::weight): Changed to return a FontWeight. (WebCore::FontDescription::setBold): Removed. (WebCore::FontDescription::setWeight): Changed to take a FontWeight.
- platform/graphics/mac/FontCacheMac.mm: (WebCore::toAppKitFontWeight): Added. Maps a FontWeight to the AppKit font weight scale of 0-15. (WebCore::isAppKitFontWeightBold): Added. (WebCore::FontCache::getFontDataForCharacters): Changed to use a weight instead of the bold trait for custom fonts, and to decide whether to synthesize bold based on the weights rather than the bold trait. (WebCore::FontCache::fontExists): Updated for the change in WebFontCache . (WebCore::FontCache::createFontPlatformData): Ditto. Also changed to decide whether to synthesize bold based on the weights rather than on the bold trait.
- platform/graphics/win/FontCacheWin.cpp: (WebCore::toGDIFontWeight): Added. Maps a FontWeight to a GDI font weight constant. (WebCore::isGDIFontWeightBold): Added. (WebCore::adjustedGDIFontWeight): Added. (WebCore::MatchImprovingProcData::MatchImprovingProcData): Added this data structure for use by the following callback. (WebCore::matchImprovingEnumProc): Added. The logic of this method is a simplification of the betterChoice() predicate in WebFontCache.mm, which considers only the italic trait and the weight. (WebCore::createGDIFont): Added. Similarly to +[WebFontCache fontWithFamily:traits:weight:size:], this function finds the closest match in the family for the desired italic bit and weight. (WebCore::FontCache::fontExists): Changed to call createGDIFont(). (WebCore::FontCache::createFontPlatformData): Ditto. Also changed to compute the synthetic bold and synthetic italic flags based on weights and italic bits and pass them to the FontPlatformData constructor.
- platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData): Changed the bold and oblique parameters to mean whether these should be synthesized and removed the font enumeration code that used to decide that.
- platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::smallCapsFontData): Changed to pass the synthetic bold and oblique flags from the full-size FontPlatformData to the FontPlatformData constructor for the small caps font.
- platform/mac/WebCoreTextRenderer.h:
- platform/mac/WebCoreTextRenderer.mm: (WebCoreFindFont): Added a weight parameter, which is passed to +[WebFontCache fontWithFamily:traits:weight:size:].
- platform/mac/WebFontCache.h:
- platform/mac/WebFontCache.mm: (acceptableChoice): (betterChoice): Changed to ignore the bold trait. Changed the logic for deciding based on weights to prefer the font whose weight is closer to the desired one, or, if both candidates' weights are the same distance from the desired weight, the one that is more "off-center". (+[WebFontCache internalFontWithFamily:traits:weight:size:]): Changed to check for weight when matching by full name. Changed to pass the actual desired weight instead of the constant 5 to acceptableChoice() and betterChoice(). Changed to use weights to decide whether to synthesize bold. (+[WebFontCache fontWithFamily:traits:weight:size:]): Added a weight parameter, which is passed to the internal method.
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint): Updated for the change to FontDescription.
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): Ditto. (WebCore::RenderListBox::paintItemForeground): Ditto.
- rendering/RenderThemeMac.mm: (WebCore::toFontWeight): Added. Maps the AppKit font weight range of 0-15 to the FontWeight range. (WebCore::RenderThemeMac::systemFont): Updated for the change to FontDescription.
- rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::systemFont): Ditto.
WebKit/mac:
2008-04-03 Nicholas Shanks <webkit@nickshanks.com>
Updated by Dan Bernstein. Reviewed by Dave Hyatt.
- WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484 font-weight does not properly support graded weights
- WebView/WebHTMLView.mm: (-[WebHTMLView _styleFromFontAttributes:]): (-[WebHTMLView _originalFontB]): (-[WebHTMLView _addToStyle:fontA:fontB:]):
WebKit/win:
2008-04-03 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
- WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484 font-weight does not properly support graded weights
- DOMCoreClasses.cpp: (DOMElement::font): Updated for the change to FontDescription.
- WebCoreSupport/WebDragClient.cpp: (dragLabelFont): Ditto.
- WebKitGraphics.cpp: (makeFont): Ditto.
- WebKitGraphics.h: Added a FIXME.
- 8:10 PM Changeset in webkit [31619] by
-
- 2 edits in trunk/WebCore
- another Gtk build fix attempt
- platform/graphics/cairo/GradientCairo.cpp: (WebCore::Gradient::platformDestroy):
- 7:25 PM Changeset in webkit [31618] by
-
- 4 edits in tags/Safari-5525.18.1
Versioning.
- 7:18 PM Changeset in webkit [31617] by
-
- 1 copy in tags/Safari-5525.18.1
New tag.
- 7:17 PM Changeset in webkit [31616] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
2008-04-03 Anders Carlsson <andersca@apple.com>
Reviewed by Sam.
<rdar://problem/5832603> REGRESSION: Adding an image to the header image well causes Journal page to incorrectly draw
- dom/Document.cpp: (WebCore::Document::childrenChanged): Make sure to chain up to ContainerNode::childrenChanged.
- 7:05 PM Changeset in webkit [31615] by
-
- 2 edits in trunk/WebCore
- attempted Gtk build fix
- GNUmakefile.am:
- 6:02 PM Changeset in webkit [31614] by
-
- 2 edits in trunk/WebCore
- attempted Qt build fix
- platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformDestroy):
- 5:43 PM Changeset in webkit [31613] by
-
- 2 edits in trunk/WebCore
- attempted Gtk build fix
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::stroke):
- 5:40 PM Changeset in webkit [31612] by
-
- 2 edits in trunk/WebCore
- attempted Qt build fix
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::stroke):
- 4:13 PM Changeset in webkit [31611] by
-
- 3 edits in trunk/WebKit/win
<rdar://problem/5835382> Calling window.open immediately after window.close can sometimes result in no window being created
Group name tracking needs to happen using code in WebCore::Page, since it is more involved than
just setting a string.
Reviewed by Adam Roben.
- WebView.cpp: (WebView::close): Add null check (found via code inspection). (WebView::initWithFrame): Store the group name directly in Page. (WebView::setGroupName): Store the group name directly in Page. (WebView::groupName): Retrieve the group name directly from Page.
- WebView.h: Removed m_groupName
- 4:08 PM Changeset in webkit [31610] by
-
- 2 edits in trunk/WebCore
2008-04-03 Beth Dakin <Beth Dakin>
Reviewed by Alice.
Build fix for non-Macs.
- page/AXObjectCache.h: (WebCore::AXObjectCache::isIDinUse):
- 3:48 PM Changeset in webkit [31609] by
-
- 2 edits in trunk/WebCore
2008-04-03 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Darin.
Correct build error due to incomplete merging of changes to project
files from Issue 17985. This small project file patch corrects
the build issue (see http://bugs.webkit.org/show_bug.cgi?id=18195).
- WebCore.vcproj/WebCore.vcproj:
- 3:02 PM Changeset in webkit [31608] by
-
- 12 edits1 delete in trunk/WebCore
2008-04-02 Beth Dakin <Beth Dakin>
Reviewed by Hyatt.
This patch eliminates AccessibilityObjectMac. All of the platform-
specific code is now in AccessibilityObjectWrapper.
- WebCore.xcodeproj/project.pbxproj:
- dom/Element.h: (WebCore::Element::isPasswordField):
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::isPasswordField):
- page/AXObjectCache.h: (WebCore::AXObjectCache::isIDinUse):
- page/AccessibilityObject.cpp: (WebCore::AccessibilityObject::isPasswordField): (WebCore::AccessibilityObject::press): (WebCore::AccessibilityObject::widgetForAttachmentView): (WebCore::AccessibilityObject::doAXBoundsForTextMarkerRange): (WebCore::AccessibilityObject::doAXTextMarkerForPosition):
- page/AccessibilityObject.h: (WebCore::AccessibilityObject::areaElement): (WebCore::AccessibilityObject::setWrapper):
- page/mac/AXObjectCacheMac.mm:
- page/mac/AccessibilityObjectMac.mm: Removed.
- page/mac/AccessibilityObjectWrapper.h:
- page/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper attachmentView]): (textMarkerForVisiblePosition): (visiblePositionForTextMarker): (visiblePositionForStartOfTextMarkerRange): (visiblePositionForEndOfTextMarkerRange): (textMarkerRangeFromMarkers): (AXAttributeStringSetFont): (CreateCGColorIfDifferent): (AXAttributeStringSetColor): (AXAttributeStringSetNumber): (AXAttributeStringSetStyle): (blockquoteLevel): (AXAttributeStringSetBlockquoteLevel): (AXAttributeStringSetSpelling): (AXAttributeStringSetHeadingLevel): (AXLinkElementForNode): (AXAttributeStringSetElement): (AXAttributedStringAppendText): (nsStringForReplacedNode): (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]): (textMarkerRangeFromVisiblePositions): (-[AccessibilityObjectWrapper accessibilityActionNames]): (-[AccessibilityObjectWrapper accessibilityAttributeNames]): (-[AccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]): (-[AccessibilityObjectWrapper textMarkerRangeForSelection]): (-[AccessibilityObjectWrapper position]): (createAccessibilityRoleMap): (RoleEntry::): (roleValueToNSString): (-[AccessibilityObjectWrapper role]): (-[AccessibilityObjectWrapper subrole]): (-[AccessibilityObjectWrapper roleDescription]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]): (-[AccessibilityObjectWrapper accessibilityIsIgnored]): (-[AccessibilityObjectWrapper accessibilityPerformAction:]): (-[AccessibilityObjectWrapper doAXAttributedStringForRange:]): (-[AccessibilityObjectWrapper doAXRTFForRange:]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]): (-[AccessibilityObjectWrapper accessibilityShouldUseUniqueId]):
- platform/ScrollView.h:
- platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::viewRectToScreen): (WebCore::ScrollView::absolutePointToView):
- 2:57 PM Changeset in webkit [31607] by
-
- 10 edits5 adds in trunk/WebCore
2008-04-03 David Hyatt <hyatt@apple.com>
Create a new cross-platform Gradient abstraction and make CanvasGradient wrap it. This first
step just cleans up CanvasGradient. The code that calls it remains ifdef'd however.
Reviewed by olliej
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::toJS):
- html/CanvasGradient.cpp: (WebCore::CanvasGradient::CanvasGradient):
- html/CanvasGradient.h: (WebCore::CanvasGradient::gradient): (WebCore::CanvasGradient::addColorStop): (WebCore::CanvasGradient::getColor):
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::fillRect):
- html/CanvasStyle.h: (WebCore::CanvasStyle::canvasGradient):
- platform/graphics/Gradient.cpp: Added. (WebCore::Gradient::Gradient): (WebCore::Gradient::~Gradient): (WebCore::Gradient::addColorStop): (WebCore::compareStops): (WebCore::Gradient::getColor): (WebCore::Gradient::findStop):
- platform/graphics/Gradient.h: Added. (WebCore::Gradient::ColorStop::ColorStop): (WebCore::Gradient::platformInit):
- platform/graphics/cairo/GradientCairo.cpp: Added. (WebCore::Gradient::platformDestroy): (WebCore::Gradient::platformGradient):
- platform/graphics/cg/GradientCG.cpp: Added. (WebCore::Gradient::platformDestroy): (WebCore::gradientCallback): (WebCore::Gradient::platformGradient):
- platform/graphics/qt/GradientQt.cpp: Added. (WebCore::Gradient::platformDestroy): (WebCore::Gradient::platformGradient):
- 2:47 PM Changeset in webkit [31606] by
-
- 11 edits in trunk
Roll out r31599 and r31605 again after discussion with Mark Rowe.
- 2:25 PM Changeset in webkit [31605] by
-
- 2 edits in trunk/WebKit/win
Attempted build fix
- 2:14 PM Changeset in webkit [31604] by
-
- 2 edits in trunk/WebCore
2008-04-03 David Hyatt <hyatt@apple.com>
Fix for bug 18194, resizable text fields get messed up when resizing in the presence of zoom.
Reviewed by adele
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize):
- 1:49 PM Changeset in webkit [31603] by
-
- 4 edits in branches/Safari-3-1-branch
Versioning.
- 1:48 PM Changeset in webkit [31602] by
-
- 1 copy in tags/Safari-5525.18
New tag.
- 1:47 PM Changeset in webkit [31601] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r31320.
- 1:30 PM Changeset in webkit [31600] by
-
- 227 edits13 deletes in trunk
Rollout r31566 as there were a few issues i missed during review (thanks to antti for pointing them out)
- 1:17 PM Changeset in webkit [31599] by
-
- 9 edits in trunk
2008-04-03 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Simon.
- Change IconDatabase::iconForPageURL to return more information. E.g. if an image has been found, or if the loading of an image has been scheduled.
- Update FrameLoader to use another method to trigger reading from disk
- Update the QWebFrame and QWebSettings
- 12:22 PM Changeset in webkit [31598] by
-
- 3 edits in trunk/WebKit/qt
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
- Safari is using the IconDatabase the following way (assumption). Before they call iconDatabase()->open they "retain" all URLs they are interested in, these could come from the history.
- When opening the iconDatabase() a thread will be started that is going to import the URLs, all none manually retained URLs are scheduled for removal. The removal is going to happen when the next icon gets stored in the database.
- We do not have any IconDatabase code, we can not retain the URLs before opening the database. To disable the automatic pruning of the icons we will ask the IconDatabase to delay this operation. This means our IconDatabase, when used, will grow, so we should try to have a IconDatabase class in 4.4.
- The only way to counter the growth is a call to QWebSettings::clearIconDatabase
- 12:01 PM Changeset in webkit [31597] by
-
- 1 edit in trunk/WebKit/qt/Api/qwebsettings.cpp
Oops, fixed previous commit/merge error that caused build failure in Qt.
- 12:00 PM Changeset in webkit [31596] by
-
- 8 edits in trunk/WebKit/win
Allow WebArchive to be created via COM.
Replaced IID_DOMNode with uuidof(DOMNode).
Reviewed by Adam and Steve.
- DOMCoreClasses.cpp: (DOMNode::QueryInterface): (DOMNode::isSameNode):
- DOMCoreClasses.h:
- ForEachCoClass.h:
- Interfaces/WebKit.idl:
- WebArchive.cpp: (WebArchive::createInstance):
- WebArchive.h:
- WebKitClassFactory.cpp:
- 11:59 AM Changeset in webkit [31595] by
-
- 3 edits in trunk/WebKit/qt
Benjamin Meyer <bmeyer@trolltech.com>
Add a way to get the site icon for a url
static QPixmap iconForUrl(const QUrl &url);
- 11:46 AM Changeset in webkit [31594] by
-
- 3 edits in trunk/WebKit/qt
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
- Update the Copyright info in QWebSettings
- 11:46 AM Changeset in webkit [31593] by
-
- 2 edits in trunk/WebKit/qt
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
- The isEmpty check is not needed anymore with the earlier backport
- 10:49 AM squirrelfish edited by
- (diff)
- 9:50 AM Changeset in webkit [31592] by
-
- 2 edits in trunk/LayoutTests
2008-04-03 Brady Eidson <beidson@apple.com>
Fix a tab into 4-spaces instead
- webarchive/test-css-import-expected.txt:
- 9:20 AM Changeset in webkit [31591] by
-
- 2 edits in trunk/WebCore
- Mac build fix
- WebCore.base.exp:
- 6:21 AM Changeset in webkit [31590] by
-
- 2 edits in trunk/WebCore
Fix the build when building without icondatabase.
- 5:27 AM Changeset in webkit [31589] by
-
- 3 edits in trunk/WebCore
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
- Remove the unused 'cache' parameter
- 5:04 AM Changeset in webkit [31588] by
-
- 2 edits in trunk/WebCore
2008-04-03 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Simon.
- Add WebCore/loader/icon to the DEPENDPATH as well
- 4:40 AM Changeset in webkit [31587] by
-
- 1 edit1 add in trunk/LayoutTests
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
- Add a Qt specific result for bad-scheme-subframe-expected.txt
- To match the mac-port we would have to return IgnoreNavigationRequest for schemes/URLs not supported by the QNetworkAccessManager in QWebPage::navigationRequested but we can't do that because QNetworkAccessManager does not expose a list of supported schemes and operations. So in contrast to the mac we will try to load the frame and fail.
- 4:40 AM Changeset in webkit [31586] by
-
- 1 edit4 adds in trunk/LayoutTests
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
- Fix http/tests/loading/simple-subframe.html by adding a test result. The result is quite similar to the one of the mac port.
- 3:31 AM Changeset in webkit [31585] by
-
- 2 edits in trunk/WebKitTools
2008-04-03 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Simon.
- Enable running http tests for Qt again. Failing tests can be put into the skipped list.
- Running these tests on windows and other platforms might need some work.
- 3:31 AM Changeset in webkit [31584] by
-
- 4 edits in trunk
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
- For the http tests we need the output of the FrameLoaderClient. The QtWebKit API is not exporting enough to create the output in DRT itself. Settle with the approach Lars has taken for the Editing support and add branches to our FrameLoaderClient code.
- run-webkit-tests http/tests(/loading) can now be executed.
- For tests in loading/ directories we are going to throw away the dirty QWebPage to start with something clean.
- 3:30 AM Changeset in webkit [31583] by
-
- 3 edits in trunk/WebKitTools
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
- Treat http and https as special URLs as well. Change the main.cpp and DumpRenderTree.cpp to handle http and https URIs as input.
- I'm not doing the clean up and merging of these two checks now.
- 3:30 AM Changeset in webkit [31582] by
-
- 4 edits in trunk
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
- Remove dumpFrameLoadCallbacks from simple-subframe.html because it is located in a directory with the name "loading". And this will autoamtically enable dumping.
- Remove this method from the LayoutTestController as it is unused now and this avoids adding it to the DRT of the Qt port.
Apr 2, 2008:
- 11:21 PM Changeset in webkit [31581] by
-
- 2 edits in branches/squirrelfish/JavaScriptCore
2008-04-02 Maciej Stachowiak <mjs@apple.com>
Reviewed by Geoff.
- take a shot at marking constant pools for global and eval code
Geoff says this won't really work in all cases but is an ok stopgap.
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::mark):
- 11:19 PM Changeset in webkit [31580] by
-
- 2 edits in branches/squirrelfish/JavaScriptCore
2008-04-02 Maciej Stachowiak <mjs@apple.com>
Reviewed by Geoff.
- fix 2x perf regression in 3d-morph
- VM/Machine.cpp: (KJS::Machine::privateExecute): If we subbed in null for the global object, don't toObject it, since that will throw an exception (very slowly).
- 11:12 PM Changeset in webkit [31579] by
-
- 2 edits in branches/squirrelfish/JavaScriptCore
2008-04-02 Maciej Stachowiak <mjs@apple.com>
Rubber stamped by Geoff
- fix Release build
- kjs/nodes.cpp: (KJS::getNonLocalSymbol):
- 10:56 PM Changeset in webkit [31578] by
-
- 8 edits6 adds in trunk
WebCore:
2008-04-02 Brady Eidson <beidson@apple.com>
Reviewed by Mitz Pettel
<rdar://problem/5838347> and http://bugs.webkit.org/show_bug.cgi?id=11839
Webarchive fails to save CSS files in @import statements
- css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addSubresourceURLStrings): Recursively add the URL each @import rule under the current style sheet.
- css/CSSStyleSheet.h:
- css/StyleSheet.h: (WebCore::StyleSheet::addSubresourceURLStrings):
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::getSubresourceAttributeStrings): Add the linked URL as well as all @import rules rooted at the linked stylesheet.
- html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::getSubresourceAttributeStrings): Walk all @import rules rooted at this stylesheet to add to the list.
- html/HTMLStyleElement.h:
LayoutTests:
2008-04-02 Brady Eidson <beidson@apple.com>
Written by David Kilzer, tweaked by Brady, Reviewed by Mitz Pettel
- test for http://bugs.webkit.org/show_bug.cgi?id=11839 Webarchive fails to save CSS files in @import statements
The idea is to <link> to a CSS file which @imports another CSS file,
and also @import a CSS file inside a <style> element, which also @imports another CSS file
Then make sure all 4 of the css files are in the resulting webarchive
- webarchive/resources/test-css-import-recurse.css: Added.
- webarchive/resources/test-css-import.css: Added.
- webarchive/resources/test-css-link-recurse.css: Added.
- webarchive/resources/test-css-link.css: Added.
- webarchive/test-css-import-expected.txt: Added.
- webarchive/test-css-import.html: Added.
- 10:11 PM Changeset in webkit [31577] by
-
- 8 edits in trunk
Ensure that debug symbols are generated for x86_64 and ppc64 builds.
Reviewed by Oliver Hunt.
- 9:37 PM Changeset in webkit [31576] by
-
- 10 edits in branches/squirrelfish/JavaScriptCore
2008-04-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed the last vestiges of LocalStorage from JSVariableObject and
JSGlobalObject.
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::saveLocalStorage): Save and restore from/to registers. Use stub isReadOnly and isDontEnum methods for now, until we really implement attributes in the symbol table. (KJS::JSGlobalObject::restoreLocalStorage): (KJS::JSGlobalObject::reset):
- kjs/JSVariableObject.cpp: (KJS::JSVariableObject::getPropertyNames): Use stub isDontEnum method for now, as above. (KJS::JSVariableObject::getPropertyAttributes): ditto
- kjs/JSVariableObject.h: Removed LocalStorage from JSVariableObjectData. Removed mark method, because subclasses implement different strategies for marking registers. (KJS::JSVariableObject::isReadOnly): Stub method (KJS::JSVariableObject::isDontEnum): ditto
Changed the code below to ASSERT_NOT_REACHED() and return 0, since it
can no longer retrieve LocalStorage from the ExecState. (Eventually,
we'll just remove this code and all its friends, but that's a task for
later.)
- kjs/ExecState.cpp: (KJS::ExecState::ExecState):
- kjs/function.cpp: (KJS::ActivationImp::markChildren):
- kjs/function.h:
- kjs/nodes.cpp: (KJS::getNonLocalSymbol): (KJS::ScopeNode::optimizeVariableAccess): (KJS::ProgramNode::processDeclarations):
- 5:24 PM Changeset in webkit [31575] by
-
- 4 edits in trunk
Build fix for GCC 4.3.
- 4:30 PM Applications using WebKit edited by
- Link to ApplicationsGtk (diff)
- 3:49 PM Changeset in webkit [31574] by
-
- 2 edits in trunk/WebCore
2008-04-02 Christian Persch <chpe@gnome.org>
Reviewed by Alp Toker.
GTK+/Pango font backend build fix.
- platform/graphics/gtk/FontCustomPlatformDataPango.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
- 2:48 PM Changeset in webkit [31573] by
-
- 3 edits in trunk/LayoutTests/svg/dynamic-updates/resources
Not reviewed. Speculative fix for hanging tests on buildbot (Tiger). Click events may have wrong origins.
- 11:41 AM Changeset in webkit [31572] by
-
- 2 edits in trunk/WebCore
No review, build fix only.
Speculative build fix for no-svg build.
Use #if ENABLE(SVG) instead of #if ENABLE_SVG
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
- 11:12 AM Changeset in webkit [31571] by
-
- 2 edits in trunk/WebCore
Rename instances of ExecState from "state" to "exec" in JavaScriptDebugServer
Rename requested by Darin Adler.
- page/JavaScriptDebugServer.cpp:
- 10:59 AM Changeset in webkit [31570] by
-
- 3 edits in trunk/WebCore
Make it possible for JavaScriptDebugListeners to listen to specific Pages
JavaScriptDebugServer now has overloads of its
addListener/removeListener methods that take a Page* to indicate for
which Page the JavaScriptDebugListener wishes to receive messages.
Reviewed by Darin.
- page/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::~JavaScriptDebugServer): Delete all ListenerSets being held in m_pageListenersMap. (WebCore::JavaScriptDebugServer::addListener): Changed to call hasListeners(). (WebCore::JavaScriptDebugServer::removeListener): Ditto. (WebCore::JavaScriptDebugServer::addListener): Added. This overload takes a Page* and puts the listener in the appropriate ListenerSet within m_pageListenersMap. The ListenerSet is allocated and added to m_pageListenersMap when its first listener is added. (WebCore::JavaScriptDebugServer::removeListener): Added. This overload takes a Page* and removes the listener from the appropriate ListenerSet in m_pageListenersMap. The ListenerSet is deleted and removed from m_pageListenersMap when its last listener is removed. (WebCore::toPage): Added. Retrieves the parent Page from an ExecState. (WebCore::JavaScriptDebugServer::sourceParsed): Changed to call dispatchDidParseSource/dispatchDidFailToParseSource for both the global listeners and the Page listeners. (WebCore::dispatchFunctionToListeners): Added. This code was extracted from the JavaScriptDebugServer method of the same name. (WebCore::JavaScriptDebugServer::dispatchFunctionToListeners): Call dispatchFunctionToListeners for both the global listeners and the Page listeners.
- page/JavaScriptDebugServer.h:
- Added declarations for new methods.
- Made JavaScriptExecutionCallback typedef public so that it could be used by a helper method.
- Added new m_pageListenersMap member.
- 6:50 AM Changeset in webkit [31569] by
-
- 4 edits in trunk/WebKit/qt
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
- Export the PageCache and Cache capacity call one to one. This is only there to allow the QtLauncher to play with caching.
- TODO: make API decisions and consider following the windows Api to set a WebCacheModel and determine certain values automatically.
- 6:50 AM Changeset in webkit [31568] by
-
- 5 edits in trunk/WebKit/qt
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Prepapre everything for enabling the PageCache for the Qt Platform:
- Claim that we can cache pages
- Create the FrameView FrameLoaderClientQt::transitionToCommittedForNewPage using the initial size of the viewport and stop creating it in the QWebFramePrivate::init
Differences to the Windows port:
- attachToWindow/detachFromWindow is not called and is not (yet) part of Widget/ScrollView of the Qt platform. We might need that for plugin support in the future.
- We store the margin's and scrolling flag inside QWebFrame and use it when creating the FrameView.
What is missing:
- API to call pageCache()->setCapacity(XYZ);
- 6:49 AM Changeset in webkit [31567] by
-
- 2 edits in trunk/WebCore
Fix compilation on case-sensitive file systems.
- 5:55 AM Changeset in webkit [31566] by
-
- 227 edits15 adds in trunk
Reviewed by Oliver.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=17779 (SVG 1.1 Errata demands "SVG JavaScript Liveness" support)
SVG Errata states: "All SVG DOM objects that directly correspond to an
attribute, e.g. the SVGAnimatedLength 'ry' in an SVGRectElement, are live. This
means that any changes made to the attribute are immediately reflected in the
corresponding SVG DOM object." (see linked URL on bug report)
Until now only XML -> SVG DOM changes took affect, aka. changing the 'rx' attribute of a <rect>
element resuted in changes when accessing 'rx' through SVG DOM (rx.baseVal.value).
Add a new synchronization layer to handle SVG DOM -> XML changes.
Added Test: svg/custom/svg-xml-dom-sync.html
- 5:00 AM Changeset in webkit [31565] by
-
- 3 edits in trunk/WebKit/qt
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
- For the PageCache support we do not want to create a FrameView in the constructor of QWebFrame. In QWegPage::viewportSize() we currently call mainFrame() and that will create a QWebFrame if no mainFrame is present and this gets called when we try to create a FrameView...
- Keep a copy of the initial viewportSize around and use it if we do not have a Frame or FrameView.
- 5:00 AM Changeset in webkit [31564] by
-
- 2 edits in trunk/WebKit/qt
2008-04-02 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Simon.
- Always return true in FrameLoaderClientQt::shouldGoToHistoryItem, like the windows port
- 5:00 AM Changeset in webkit [31563] by
-
- 2 edits in trunk/WebKit/qt
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
- Attempt to make the m_webFrame null pointer checking consistent. Always check for m_webFrame. It should get set by the QWebFrame with the FramerLoaderClientQt::setFrame call and should stay valid until the destruction of the QWebFrame.
- Currently the same checking is not needed for m_frame as it will only set to 0 in FrameLoaderClientQt::frameLoaderDestroyed and should be not 0 because of the setFrame initialisation.
- 4:54 AM Changeset in webkit [31562] by
-
- 2 edits in trunk/WebCore
2008-04-02 Darin Adler <Darin Adler>
Reviewed by Alexey.
- fix storage leak seen on buildbot
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::utiFromMIMEType): Put the result of createCFString() into a RetainPtr. Changed result to be a RetainPtr. (WebCore::ImageBuffer::toDataURL): Tweak a little bit, removing one local variable and some unneeded explicit conversions.
Apr 1, 2008:
- 11:50 PM Changeset in webkit [31561] by
-
- 2 edits in trunk/JavaScriptCore
Rubber-stamped by Darin.
Turn off using 64-bit arithmetic on 32-bit hardware, as dtoa own code is faster than
compiler-provided emulation.
1% speedup on Acid3 test 26.
- kjs/dtoa.cpp:
- 11:38 PM Changeset in webkit [31560] by
-
- 7 edits in trunk/JavaScriptCore
Reviewed by Darin.
Make MathExtras.h thread safe.
- kjs/math_object.cpp: (KJS::mathProtoFuncRandom): If threading is enabled, rely on initializeThreading to call wtf_random_init().
- wtf/Threading.h:
- wtf/ThreadingGtk.cpp: (WTF::initializeThreading):
- wtf/ThreadingNone.cpp: (WTF::initializeThreading):
- wtf/ThreadingPthreads.cpp: (WTF::initializeThreading):
- wtf/ThreadingWin.cpp: (WTF::initializeThreading): Call wtf_random_init(); made the function non-inline to avoid having to include too many headers in Threading.h.
- 9:56 PM Changeset in webkit [31559] by
-
- 1 edit in branches/squirrelfish/JavaScriptCore/ChangeLog
reverse order of last two ChangeLog entries (oops)
- 9:49 PM Changeset in webkit [31558] by
-
- 6 edits in branches/squirrelfish/JavaScriptCore
2008-04-01 Maciej Stachowiak <mjs@apple.com>
Reviewed by Geoff.
- mark the constant pool (at least for function code blocks)
- VM/CodeBlock.cpp: (KJS::CodeBlock::mark):
- VM/CodeBlock.h:
- kjs/function.cpp: (KJS::FunctionImp::mark):
- kjs/nodes.cpp: (KJS::ScopeNode::mark):
- kjs/nodes.h: (KJS::FuncExprNode::body): (KJS::FuncDeclNode::body):
- 9:47 PM squirrelfish edited by
- (diff)
- 9:47 PM Changeset in webkit [31557] by
-
- 6 edits in branches/squirrelfish/JavaScriptCore
2008-04-01 Maciej Stachowiak <mjs@apple.com>
Reviewed by Geoff.
- mark the constant pool (at least for function code blocks)
- VM/CodeBlock.cpp: (KJS::CodeBlock::mark):
- VM/CodeBlock.h:
- kjs/function.cpp: (KJS::FunctionImp::mark):
- kjs/nodes.cpp: (KJS::ScopeNode::mark):
- kjs/nodes.h: (KJS::FuncExprNode::body): (KJS::FuncDeclNode::body):
- 9:41 PM squirrelfish edited by
- (diff)
- 9:08 PM Changeset in webkit [31556] by
-
- 8 edits in branches/squirrelfish/JavaScriptCore
2008-04-01 Geoffrey Garen <ggaren@apple.com>
Reviewed by Beth Dakin.
Cleaned up a few loose ends.
- JavaScriptCore.exp: Export dumpRegisters, so it's visible to gdb even if we don't explicitly call it in the source text.
- VM/Machine.cpp: (KJS::Machine::privateExecute): No need to call dumpRegisters anymore, since that was just a hack for gdb's sake.
- kjs/JSActivation.h: Removed obsolete comment.
- VM/CodeGenerator.cpp: Added ASSERTs to verify that the localCount we're given matches the number of locals actually allocated.
- VM/CodeGenerator.h: (KJS::CodeGenerator::CodeGenerator): Changed "localCount" to include the parameter count, since we're using the word "local" to mean parameter, var, function, or "this". Renamed "m_nextLocal" to "m_nextVar", since "m_nextLocal" doesn't contrast well with "m_nextParameter".
Also moved tracking of implicit "this" parameter from here...
- kjs/nodes.cpp: (KJS::FunctionBodyNode::generateCode): ... to here (KJS::ProgramNode::generateCode): ... and here
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump): Added missing "\n".
- 7:57 PM Changeset in webkit [31555] by
-
- 2 edits in branches/squirrelfish/JavaScriptCore
2008-04-01 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver.
Bug 18274: ResolveNode::emitCode() doesn't make a new temporary when dst
is 0, leading to incorrect codegen
- 7:05 PM Changeset in webkit [31554] by
-
- 2 edits in branches/squirrelfish/JavaScriptCore
2008-04-01 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver.
- fix bug in for..in codegen (gotta use ident, not m_ident)
- kjs/nodes.cpp: (KJS::ForInNode::emitCode):
- 6:52 PM Changeset in webkit [31553] by
-
- 9 edits in branches/squirrelfish/JavaScriptCore
2008-04-01 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver.
- Add suport for regexp literals
- VM/CodeBlock.cpp: (KJS::regexpToSourceString): (KJS::regexpName): (KJS::CodeBlock::dump):
- VM/CodeBlock.h:
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::addRegExp): (KJS::CodeGenerator::emitNewRegExp):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- VM/Opcode.h:
- kjs/nodes.cpp: (KJS::RegExpNode::emitCode):
- kjs/nodes.h:
- 6:00 PM Changeset in webkit [31552] by
-
- 12 edits1 copy1 add in branches/squirrelfish/JavaScriptCore
Add support for for..in nodes
Reviewed by Geoff
Added two new opcodes to get_pnames and next_pname to handle iterating
over the set of properties on an object. This iterator is explicitly
invalidated and the property name array is released on standard exit
from the loop, otherwise we rely on GC to do the clean up for us.
- 5:40 PM Changeset in webkit [31551] by
-
- 3 edits in branches/squirrelfish/JavaScriptCore
2008-04-01 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej.
Change CodeGenerator::emitCall() so it increments the reference count of
registers passed to it, and change its callers so they don't needlessly
increment the reference count of the registers they are passing.
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitCall):
- kjs/nodes.cpp: (KJS::FunctionCallResolveNode::emitCode): (KJS::FunctionCallDotNode::emitCode):
- 5:39 PM squirrelfish edited by
- (diff)
- 5:30 PM Changeset in webkit [31550] by
-
- 2 edits in trunk/WebCore
2008-04-01 Darin Adler <Darin Adler>
- WebCore.vcproj/WebCore.vcproj: Added RangeBoundaryPoint.h -- not required, but convenient.
- 5:28 PM Changeset in webkit [31549] by
-
- 8 edits1 add2 deletes in trunk/WebCore
2008-04-01 Darin Adler <Darin Adler>
Reviewed by Sam and Antti.
- fix <rdar://problem/5829565> paste performance slowed down with the Range Acid3 changes
Added a new class, RangeBoundaryPoint, to use for range boundary points. The "truth" of
the offset is now stored as a node pointer, and the offset is computed as and when needed.
This allows us to efficiently update when the DOM tree is changed -- computation of the
node offsets is deferred until the Range is used later.
- WebCore.base.exp: Export nodeIndex().
- WebCore.xcodeproj/project.pbxproj: Added RangeBoundaryPoint.h, removed NodeWithIndexBefore.h and NodeWIthIndexAfter.h. Also let Xcode tweak the file formatting.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::childrenChanged): Pass fewer arguments to Document.
- dom/Document.cpp: (WebCore::Document::nodeChildrenChanged): Pass fewer arguments to Range. (WebCore::Document::nodeWillBeRemoved): Pass node to range as a raw node pointer; no need for the index.
- dom/Document.h: Take fewer arguments.
- dom/NodeWithIndexAfter.h: Removed.
- dom/NodeWithIndexBefore.h: Removed.
- dom/Range.cpp: (WebCore::Range::Range): Changed to use the new RangeBoundaryPoint constructor. (WebCore::Range::create): Updated to use RangeBoundaryPoint instead of Position. (WebCore::Range::~Range): Ditto. (WebCore::Range::startContainer): Ditto. (WebCore::Range::startOffset): Ditto. (WebCore::Range::endContainer): Ditto. (WebCore::Range::endOffset): Ditto. (WebCore::Range::commonAncestorContainer): Ditto. (WebCore::Range::collapsed): Ditto. (WebCore::Range::setStart): Ditto. (WebCore::Range::setEnd): Ditto. (WebCore::Range::collapse): Ditto. (WebCore::Range::isPointInRange): Ditto. (WebCore::Range::comparePoint): Ditto. (WebCore::Range::compareNode): Ditto. (WebCore::Range::compareBoundaryPoints): Ditto. (WebCore::Range::boundaryPointsValid): Ditto. (WebCore::Range::intersectsNode): Ditto. (WebCore::Range::processContents): Ditto. (WebCore::Range::cloneContents): Ditto. (WebCore::Range::insertNode): Updated to use RangeBoundaryPoint. Also simplified the code at the end that updates the range -- not all of it is needed now since most of the fixup is done automatically by the range document mutation machinery. The one bit that remains is arguably a bug, but we need to keep it to keep passing Acid3 until we get clarification that it is indeed a bug (and then Acid3 will probably have to change). (WebCore::Range::toString): Update to use RangeBoundaryPoint instead of Position. (WebCore::Range::text): Ditto. (WebCore::Range::createContextualFragment): Ditto. (WebCore::Range::detach): Ditto. (WebCore::Range::checkNodeWOffset): Changed case where the offset is a node offset to be more efficient by using childNode instead of childNodeCount, and also return the node before which is needed to set the value of a RangeBoundaryPoint. (WebCore::Range::cloneRange): Ditto. (WebCore::Range::setStartAfter): Ditto. (WebCore::Range::setEndBefore): Ditto. (WebCore::Range::setEndAfter): Ditto. (WebCore::Range::selectNode): Ditto. (WebCore::Range::selectNodeContents): Ditto. (WebCore::Range::surroundContents): Ditto. (WebCore::Range::setStartBefore): Ditto. (WebCore::Range::checkDeleteExtract): Ditto. (WebCore::Range::containedByReadOnly): Ditto. (WebCore::Range::firstNode): Ditto. (WebCore::Range::editingStartPosition): Ditto. (WebCore::Range::pastLastNode): Ditto. (WebCore::Range::addLineBoxRects): Ditto. (WebCore::Range::formatForDebugger): Ditto. (WebCore::Range::maxStartOffset): Ditto. (WebCore::Range::maxEndOffset): Ditto. (WebCore::boundaryNodeChildrenChanged): Updated to use RangeBoundaryPoint instead of Position. Also changed name and changed to just call invalidateOffset. (WebCore::Range::nodeChildrenChanged): Changed to take just a container node. (WebCore::boundaryNodeWillBeRemoved): Updated to use RangeBoundaryPoint instead of Position. Also changed name and changed to update childBefore. (WebCore::Range::nodeWillBeRemoved): Changed to just take a Node*. (WebCore::boundaryTextInserted): Updated to use RangeBoundaryPoint instead of Position. Also changed name. (WebCore::Range::textInserted): Ditto. (WebCore::boundaryTextRemoved): Ditto. (WebCore::Range::textRemoved): Ditto. (WebCore::boundaryTextNodesMerged): Ditto. (WebCore::Range::textNodesMerged): Ditto. (WebCore::boundaryTextNodesSplit): Ditto. (WebCore::Range::textNodeSplit): Ditto.
- dom/Range.h: Updated to use RangeBoundaryPoint instead of Position.
- dom/RangeBoundaryPoint.h: Added.
- 5:23 PM Changeset in webkit [31548] by
-
- 3 edits in branches/squirrelfish/JavaScriptCore
2008-04-01 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver.
- generate call for PostIncDotNode
- kjs/nodes.cpp: (KJS::PostIncDotNode::emitCode):
- kjs/nodes.h:
- 5:22 PM Changeset in webkit [31547] by
-
- 1 edit1 delete in trunk/WebCore
2008-04-01 Anders Carlsson <andersca@apple.com>
Reviewed by Sam.
Get rid of old "bindings" forwarding headers.
- ForwardingHeaders/bindings: Removed.
- ForwardingHeaders/bindings/NP_jsobject.h: Removed.
- ForwardingHeaders/bindings/npruntime.h: Removed.
- ForwardingHeaders/bindings/npruntime_impl.h: Removed.
- ForwardingHeaders/bindings/npruntime_internal.h: Removed.
- ForwardingHeaders/bindings/runtime.h: Removed.
- ForwardingHeaders/bindings/runtime_object.h: Removed.
- ForwardingHeaders/bindings/runtime_root.h: Removed.
- 5:18 PM Changeset in webkit [31546] by
-
- 2 edits in branches/squirrelfish/JavaScriptCore
2008-04-01 Maciej Stachowiak <mjs@apple.com>
Build fix.
- fix build (not sure how this ever worked?)
- kjs/nodes.cpp: (KJS::FunctionCallBracketNode::emitCode):
- 4:45 PM Changeset in webkit [31545] by
-
- 3 edits in branches/squirrelfish/JavaScriptCore
2008-04-01 Maciej Stachowiak <mjs@apple.com>
Reviewed by Geoff.
- generate code for FunctionCallBracketNode
- kjs/nodes.cpp: (KJS::FunctionCallBracketNode::emitCode):
- kjs/nodes.h:
- 4:11 PM Changeset in webkit [31544] by
-
- 5 edits in trunk/WebKit/win
WebKit/win:
Reviewed by Jon Honeycutt and Cake
Hookup WebArchive API enough to be able to save the archive of a DOMNode
- DOMCoreClasses.h: Add a GUID for DOMNode
- Interfaces/IWebArchive.idl: Add initWithNode()
- WebArchive.cpp: (WebArchive::initWithNode): (WebArchive::data): Actually return LegacyWebArchive-style data
- WebArchive.h:
- 3:44 PM Changeset in webkit [31543] by
-
- 4 edits1 move in trunk/WebCore
2008-04-01 Timothy Hatcher <timothy@apple.com>
Rename DatabasePanel.js to DatabasesPanel.js to facilitate the up-coming UI refresh changes.
Rubber-stamped by Brady Eidson.
- WebCore.vcproj/WebCore.vcproj: Reference DatabasesPanel.js.
- page/inspector/DatabasePanel.js: Removed.
- page/inspector/DatabasesPanel.js: Copied from page/inspector/DatabasePanel.js.
- page/inspector/WebKit.qrc: Reference DatabasesPanel.js.
- page/inspector/inspector.html: Reference DatabasesPanel.js.
- 3:37 PM Changeset in webkit [31542] by
-
- 4 edits in tags/Safari-5525.17.1
Versioning.
- 3:31 PM Changeset in webkit [31541] by
-
- 2 edits in trunk/WebCore
2008-04-01 Brady Eidson <beidson@apple.com>
Touch a file to get Windows to rebuild WebCore
- platform/ContextMenu.cpp: Alphabetize headers
- 3:30 PM Changeset in webkit [31540] by
-
- 1 copy in tags/Safari-5525.17.1
New tag.
- 3:15 PM Changeset in webkit [31539] by
-
- 1 edit in branches/Safari-3-1-branch/WebKit/win/ChangeLog
Fix up ChangeLog merge header.
- 2:28 PM Changeset in webkit [31538] by
-
- 3 edits in branches/squirrelfish/JavaScriptCore
2008-04-01 Maciej Stachowiak <mjs@apple.com>
Reviewed by Geoff.
- Fix two crashing SunSpider tests
- VM/Machine.cpp: (KJS::Machine::privateExecute): set up 'this' properly for native calls.
- kjs/list.h: (KJS::List::List): Fix intialization of buffer and size from vector, the initialization order was wrong.
- 1:44 PM Applications using WebKit edited by
- Fix Adium naming/credits (diff)
- 1:38 PM Changeset in webkit [31537] by
-
- 3 edits in branches/squirrelfish/JavaScriptCore
2008-04-01 Geoffrey Garen <ggaren@apple.com>
Build fix: marked ASSERT-only variables as UNUSED_PARAMs.
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- kjs/JSVariableObject.h: (KJS::JSVariableObject::symbolTableInitializeVariable):
- 1:30 PM Changeset in webkit [31536] by
-
- 3 edits in branches/squirrelfish/JavaScriptCore
2008-04-01 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Next step toward global code: Moved get, put, and initializeVariable
functionality up into JSVariableObject, and changed JSActivation to
rely on it.
- kjs/JSActivation.cpp: (KJS::JSActivation::JSActivation): (KJS::JSActivation::getOwnPropertySlot): (KJS::JSActivation::put): (KJS::JSActivation::initializeVariable):
- kjs/JSVariableObject.h: (KJS::JSVariableObject::valueAt): (KJS::JSVariableObject::isReadOnly): (KJS::JSVariableObject::symbolTableGet): (KJS::JSVariableObject::symbolTablePut): (KJS::JSVariableObject::symbolTableInitializeVariable):
- 1:26 PM Changeset in webkit [31535] by
-
- 4 edits2 adds in trunk
WebCore:
Reviewed by Adam Roben
Export loader/archive and loader/archive/cf headers for WebKitWin to use
- WebCore.vcproj/WebCore.vcproj:
WebKit/win:
Reviewed by Adam Roben
Add empty implementations of WebArchive for future work
- WebArchive.cpp: Added. (WebArchive::createInstance): (WebArchive::WebArchive): (WebArchive::~WebArchive): (WebArchive::QueryInterface): (WebArchive::AddRef): (WebArchive::Release): (WebArchive::initWithMainResource): (WebArchive::initWithData): (WebArchive::mainResource): (WebArchive::subResources): (WebArchive::subframeArchives): (WebArchive::data):
- WebArchive.h: Added.
- WebKit.vcproj/WebKit.vcproj:
- 1:22 PM Changeset in webkit [31534] by
-
- 2 edits in branches/Safari-3-1-branch/WebKit/win
Merge r31015 to Safari-3-1-branch.
- 12:45 PM Changeset in webkit [31533] by
-
- 2 edits in trunk/WebCore
WebCore:
Reviewed by Darin
WebArchives need to load on Windows the same way as on Mac, and this change in the
finished-loading code path was a big part of that
- loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument): Only call the client's finishedLoading() for non-archive loads
- 10:47 AM Changeset in webkit [31532] by
-
- 2 edits in trunk/WebCore
- Mac build fix
- WebCore.xcodeproj/project.pbxproj: Made FontRenderingMode.h private.
- 9:41 AM Changeset in webkit [31531] by
-
- 9 edits1 add in trunk/WebCore
Reviewed by Darin Adler.
- move the FontRenderingMode enumeration into its own header file
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- loader/CachedFont.h:
- platform/graphics/FontDescription.h:
- platform/graphics/FontRenderingMode.h: Added. (WebCore::):
- platform/graphics/gtk/FontCustomPlatformData.h:
- platform/graphics/mac/FontCustomPlatformData.h:
- platform/graphics/qt/FontCustomPlatformData.h:
- platform/graphics/win/FontCustomPlatformData.h:
- 9:36 AM Changeset in webkit [31530] by
-
- 3 edits in trunk/WebCore
2008-04-01 Darin Adler <Darin Adler>
Reviewed by Mitz.
- fix <rdar://problem/5833351> REGRESSION: Leak in JSCustomXPathNSResolver::create
- fix <rdar://problem/5833216> REGRESSION: Leak in CSSStyleSelector::addViewportDependentMediaQueryResult
- bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::create): Added a missing adoptRef.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::~CSSStyleSelector): Added a missing call to deleteAllValues.
- 9:30 AM Changeset in webkit [31529] by
-
- 3 edits in branches/squirrelfish/JavaScriptCore
2008-04-01 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam.
- fix HashTable assertion on some SunSpider tests
Don't use -1 as the deleted value for JSValue*-keyed hashtables,
since it is a valid value (it's the immediate for -1).
- VM/CodeGenerator.h: (KJS::CodeGenerator::JSValueHashTraits::emptyValue): (KJS::CodeGenerator::JSValueHashTraits::deletedValue):
- kjs/JSImmediate.h: (KJS::JSImmediate::impossibleValue):
- 9:19 AM Changeset in webkit [31528] by
-
- 1 edit in trunk/WebCore/dom/Clipboard.cpp
Clear stray executable bit.
- 9:04 AM Changeset in webkit [31527] by
-
- 1 edit in trunk/WebCore/page/mac/AccessibilityObjectMac.mm
tiger build fix
- 8:44 AM Changeset in webkit [31526] by
-
- 7 edits in trunk/WebCore
2008-04-01 Darin Adler <Darin Adler>
Reviewed by Sam.
- speed up hasChildNodes, which does not need to be virtual
- dom/ContainerNode.cpp: Removed hasChildNodes.
- dom/ContainerNode.h: Added non-virtual inline hasChildNodes.
- dom/Node.cpp: Removed hasChildNodes.
- dom/Node.h: Added non-vritual inline hasChildNodes.
- 8:43 AM Changeset in webkit [31525] by
-
- 8 edits in branches/squirrelfish/JavaScriptCore
2008-04-01 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Add support for calling Native constructors like new Array().
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitConstruct):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- VM/Opcode.h:
- kjs/nodes.cpp: (KJS::NewExprNode::emitCode):
- kjs/nodes.h:
- 8:42 AM Changeset in webkit [31524] by
-
- 2 edits in branches/squirrelfish/JavaScriptCore
2008-04-01 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam.
- add some missing toOpbject calls to avoid crashing when calling methods on primitives
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- 8:08 AM Changeset in webkit [31523] by
-
- 2 edits in trunk/WebKitTools
Fix Qt DRT run by also printing EOF on stderr, as expected by
run-webkit-tests.
- 7:22 AM squirrelfish edited by
- (diff)
- 3:27 AM Changeset in webkit [31522] by
-
- 3 edits in trunk/WebCore
Fix the non-mac build.
- 1:47 AM Changeset in webkit [31521] by
-
- 4 edits in trunk/WebKit/qt
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
- Get the RefCounting of WebCore::Frame right and make sure that both QWebFrame and WebCore::Frame get destroyed if we leave site with subframes and on the end of the application.
- Use adoptRef in FrameLoaderClientQt::createFrame to get the refs right for subframes. We do not want to add an extra reference. Without this we are leaking subframes.
- Assume that the lifetime of a Frame and FrameLoader are the same, when the Frame is gone we want to destroy the QWebFrame (e.g. on a page with subframes). Add delete m_webFrame in the frameLoaderDestroyed method to do that.
- If we happen to delete the QWebFrame before the FrameLoaderClientQt we set m_webFrame to zero in the FrameLoaderClientQt to avoid bad things.
- 1:46 AM Changeset in webkit [31520] by
-
- 4 edits in trunk/WebKit/qt
2008-04-01 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Simon.
- Do not save a RefPtr to the frame. The FrameLoaderClient, Frame and QWebFrame should have the same lifetime everything else is a leak or issue.
- 1:46 AM Changeset in webkit [31519] by
-
- 6 edits in trunk
2008-04-01 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Simon.
- Do not store the QWebFrame associated with a ScrollView/FrameView in the WebCore::Widget.
- Instead of asking the Widget for the QWebFrame use the QWebFramePrivate::core and QWebFramePrivate::kit function to convert from and to QWebFrame.
- 1:44 AM Changeset in webkit [31518] by
-
- 5 edits in trunk/WebKit/qt
Holger Hans Peter Freyther <holger.freyther@trolltech.com>
- Do not store the FrameView in the QWebFrame and cope with the situation when a WebCore::Frame has no WebCore::FrameView.
- 1:40 AM Changeset in webkit [31517] by
-
- 8 edits5 adds2 deletes in trunk
WebCore:
2008-04-01 Alice Liu <alice.liu@apple.com>
Patch by Beth Dakin <Beth Dakin> and Alice Liu
Reviewed by Darin.
Refactored WebCore Accessibility code. Prior to this patch, WebCore
accessibility was implemented in an ObjC class named WebCoreAXObject,
with much of the "guts" in C++. This patch the next natural step of
factoring out the C++ code into a class named AccessibilityObject, and
in order to maintain the required ObjC object ties, also implements an
ObjC class named AccessibilityObjectWrapper as a thin wrapper around the
C++ object. Internally within WebCore we operate on the C++ object as
much as possible, and the ObjC object gets used mostly when we need to
return something to AppKit or call something implemented on NSObject.
The AXObjectCache still keeps one HashMap, now of RenderObjects to
AccessibilityObjects instead of WebCoreAXObjects, and the
AccessibilityObject keeps track of its ObjC wrapper.
- WebCore.xcodeproj/project.pbxproj:
- page/AXObjectCache.h: (WebCore::AXObjectCache::get): (WebCore::AXObjectCache::removeAXID):
- page/AccessibilityObject.cpp: Added. (WebCore::AccessibilityObject::AccessibilityObject): (WebCore::AccessibilityObject::~AccessibilityObject): (WebCore::AccessibilityObject::create): (WebCore::AccessibilityObject::detach): (WebCore::AccessibilityObject::firstChild): (WebCore::AccessibilityObject::lastChild): (WebCore::AccessibilityObject::previousSibling): (WebCore::AccessibilityObject::nextSibling): (WebCore::AccessibilityObject::parentObject): (WebCore::AccessibilityObject::parentObjectUnignored): (WebCore::AccessibilityObject::isWebArea): (WebCore::AccessibilityObject::isImageButton): (WebCore::AccessibilityObject::isAnchor): (WebCore::AccessibilityObject::isTextControl): (WebCore::AccessibilityObject::isImage): (WebCore::AccessibilityObject::isAttachment): (WebCore::isPasswordFieldElement): (WebCore::AccessibilityObject::isPasswordField): (WebCore::AccessibilityObject::headingLevel): (WebCore::AccessibilityObject::isHeading): (WebCore::AccessibilityObject::anchorElement): (WebCore::isCheckboxOrRadio): (WebCore::AccessibilityObject::actionElement): (WebCore::AccessibilityObject::mouseButtonListener): (WebCore::AccessibilityObject::helpText): (WebCore::AccessibilityObject::textUnderElement): (WebCore::AccessibilityObject::hasIntValue): (WebCore::AccessibilityObject::intValue): (WebCore::AccessibilityObject::stringValue): (WebCore::labelForElement): (WebCore::AccessibilityObject::title): (WebCore::AccessibilityObject::accessibilityDescription): (WebCore::AccessibilityObject::boundingBoxRect): (WebCore::AccessibilityObject::size): (WebCore::AccessibilityObject::linkedUIElement): (WebCore::AccessibilityObject::accessibilityShouldUseUniqueId): (WebCore::AccessibilityObject::accessibilityIsIgnored): (WebCore::AccessibilityObject::loaded): (WebCore::AccessibilityObject::layoutCount): (WebCore::AccessibilityObject::textLength): (WebCore::AccessibilityObject::selectedText): (WebCore::AccessibilityObject::selection): (WebCore::AccessibilityObject::selectedTextRange): (WebCore::AccessibilityObject::setSelectedText): (WebCore::AccessibilityObject::setSelectedTextRange): (WebCore::AccessibilityObject::makeRangeVisible): (WebCore::AccessibilityObject::url): (WebCore::AccessibilityObject::isVisited): (WebCore::AccessibilityObject::isFocused): (WebCore::AccessibilityObject::setFocused): (WebCore::AccessibilityObject::setValue): (WebCore::AccessibilityObject::isEnabled): (WebCore::AccessibilityObject::press): (WebCore::AccessibilityObject::topRenderer): (WebCore::AccessibilityObject::textControl): (WebCore::AccessibilityObject::widget): (WebCore::AccessibilityObject::axObjectCache): (WebCore::AccessibilityObject::documentLinks): (WebCore::AccessibilityObject::documentFrameView): (WebCore::AccessibilityObject::frameViewIfRenderView): (WebCore::AccessibilityObject::visiblePositionRange): (WebCore::AccessibilityObject::doAXTextMarkerRangeForLine): (WebCore::AccessibilityObject::doAXTextMarkerRangeForUnorderedTextMarkers): (WebCore::AccessibilityObject::doAXLeftWordTextMarkerRangeForTextMarker): (WebCore::AccessibilityObject::doAXRightWordTextMarkerRangeForTextMarker): (WebCore::updateAXLineStartForVisiblePosition): (WebCore::AccessibilityObject::doAXLeftLineTextMarkerRangeForTextMarker): (WebCore::AccessibilityObject::doAXRightLineTextMarkerRangeForTextMarker): (WebCore::AccessibilityObject::doAXSentenceTextMarkerRangeForTextMarker): (WebCore::AccessibilityObject::doAXParagraphTextMarkerRangeForTextMarker): (WebCore::startOfStyleRange): (WebCore::endOfStyleRange): (WebCore::AccessibilityObject::doAXStyleTextMarkerRangeForTextMarker): (WebCore::AccessibilityObject::textMarkerRangeForRange): (WebCore::AccessibilityObject::stringForReplacedNode): (WebCore::AccessibilityObject::doAXStringForTextMarkerRange): (WebCore::AccessibilityObject::doAXBoundsForTextMarkerRange): (WebCore::AccessibilityObject::doAXLengthForTextMarkerRange): (WebCore::AccessibilityObject::doSetAXSelectedTextMarkerRange): (WebCore::AccessibilityObject::doAXTextMarkerForPosition): (WebCore::AccessibilityObject::doAXNextTextMarkerForTextMarker): (WebCore::AccessibilityObject::doAXPreviousTextMarkerForTextMarker): (WebCore::AccessibilityObject::doAXNextWordEndTextMarkerForTextMarker): (WebCore::AccessibilityObject::doAXPreviousWordStartTextMarkerForTextMarker): (WebCore::AccessibilityObject::doAXNextLineEndTextMarkerForTextMarker): (WebCore::AccessibilityObject::doAXPreviousLineStartTextMarkerForTextMarker): (WebCore::AccessibilityObject::doAXNextSentenceEndTextMarkerForTextMarker): (WebCore::AccessibilityObject::doAXPreviousSentenceStartTextMarkerForTextMarker): (WebCore::AccessibilityObject::doAXNextParagraphEndTextMarkerForTextMarker): (WebCore::AccessibilityObject::doAXPreviousParagraphStartTextMarkerForTextMarker): (WebCore::AccessibilityObject::textMarkerForIndex): (WebCore::AccessibilityObject::doAXUIElementForTextMarker): (WebCore::AccessibilityObject::doAXLineForTextMarker): (WebCore::AccessibilityObject::rangeForTextMarkerRange): (WebCore::AccessibilityObject::indexForTextMarker): (WebCore::AccessibilityObject::doAXRangeForLine): (WebCore::AccessibilityObject::doAXRangeForPosition): (WebCore::AccessibilityObject::doAXRangeForIndex): (WebCore::AccessibilityObject::doAXStyleRangeForIndex): (WebCore::AccessibilityObject::doAXStringForRange): (WebCore::AccessibilityObject::doAXBoundsForRange): (WebCore::AccessibilityObject::doAXLineForIndex): (WebCore::AccessibilityObject::doAccessibilityHitTest): (WebCore::AccessibilityObject::focusedUIElement): (WebCore::AccessibilityObject::observableObject): (WebCore::AccessibilityObject::roleValue): (WebCore::AccessibilityObject::canSetFocusAttribute): (WebCore::AccessibilityObject::canSetValueAttribute): (WebCore::AccessibilityObject::canSetTextRangeAttributes): (WebCore::AccessibilityObject::childrenChanged): (WebCore::AccessibilityObject::clearChildren): (WebCore::AccessibilityObject::hasChildren): (WebCore::AccessibilityObject::addChildren): (WebCore::AccessibilityObject::axObjectID): (WebCore::AccessibilityObject::setAXObjectID): (WebCore::AccessibilityObject::removeAXObjectID):
- page/AccessibilityObject.h: Added. (WebCore::): (WebCore::VisiblePositionRange::VisiblePositionRange): (WebCore::VisiblePositionRange::isNull): (WebCore::AccessibilityObject::detached): (WebCore::AccessibilityObject::PlainTextRange::PlainTextRange): (WebCore::AccessibilityObject::PlainTextRange::isNull): (WebCore::AccessibilityObject::renderer): (WebCore::AccessibilityObject::children): (WebCore::AccessibilityObject::wrapper): (WebCore::AccessibilityObject::setWrapper):
- page/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::~AXObjectCache): (WebCore::AXObjectCache::get): (WebCore::AXObjectCache::remove): (WebCore::AXObjectCache::getAXID): (WebCore::AXObjectCache::removeAXID): (WebCore::AXObjectCache::textMarkerForVisiblePosition): (WebCore::AXObjectCache::childrenChanged): (WebCore::AXObjectCache::postNotification): (WebCore::AXObjectCache::postNotificationToElement):
- page/mac/AccessibilityObjectMac.mm: Added. (createAccessibilityRoleMap): (RoleEntry::): (roleValueToNSString): (AccessibilityObject::attachmentView): (AccessibilityObject::performPressActionForAttachment): (AccessibilityObject::textMarkerRange): (AccessibilityObject::textMarkerForVisiblePosition): (AccessibilityObject::startTextMarker): (AccessibilityObject::visiblePositionForTextMarker): (AccessibilityObject::visiblePositionForStartOfTextMarkerRange): (AccessibilityObject::visiblePositionForEndOfTextMarkerRange): (AccessibilityObject::textMarkerRangeFromVisiblePositions): (AccessibilityObject::textMarkerRangeForSelection): (AccessibilityObject::textMarkerRangeFromMarkers): (AccessibilityObject::convertViewRectToScreenCoords): (AccessibilityObject::convertAbsolutePointToViewCoords): (AccessibilityObject::convertWidgetChildrenToNSArray): (AccessibilityObject::position): (AccessibilityObject::role): (AccessibilityObject::subrole): (AccessibilityObject::roleDescription): (blockquoteLevel): (AccessibilityObject::AXAttributeStringSetElement): (AXAttributeStringSetBlockquoteLevel): (CreateCGColorIfDifferent): (AXAttributeStringSetColor): (AXAttributeStringSetNumber): (AXAttributeStringSetFont): (AXAttributeStringSetStyle): (AccessibilityObject::AXAttributeStringSetHeadingLevel): (AccessibilityObject::AXLinkElementForNode): (AXAttributeStringSetSpelling): (AccessibilityObject::AXAttributedStringAppendText): (nsStringForReplacedNode): (AccessibilityObject::doAXAttributedStringForTextMarkerRange): (AccessibilityObject::doAXAttributedStringForRange): (AccessibilityObject::doAXRTFForRange):
- page/mac/AccessibilityObjectWrapper.h: Added.
- page/mac/AccessibilityObjectWrapper.mm: Added. (-[AccessibilityObjectWrapper initWithAccessibilityObject:]): (-[AccessibilityObjectWrapper unregisterUniqueIdForUIElement]): (-[AccessibilityObjectWrapper detach]): (-[AccessibilityObjectWrapper accessibilityObject]): (-[AccessibilityObjectWrapper accessibilityActionNames]): (-[AccessibilityObjectWrapper accessibilityAttributeNames]): (-[AccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]): (-[AccessibilityObjectWrapper renderWidgetChildren]): (convertToNSArray): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]): (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]): (-[AccessibilityObjectWrapper accessibilityHitTest:]): (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]): (-[AccessibilityObjectWrapper accessibilityIsIgnored]): (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]): (-[AccessibilityObjectWrapper accessibilityPerformAction:]): (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]): (rendererForView): (-[AccessibilityObjectWrapper _accessibilityParentForSubview:]): (-[AccessibilityObjectWrapper accessibilityActionDescription:]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]): (-[AccessibilityObjectWrapper accessibilityShouldUseUniqueId]):
- page/mac/WebCoreAXObject.h: Removed.
- page/mac/WebCoreAXObject.mm: Removed.
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::selectElement):
- rendering/RenderMenuList.h:
WebKit/mac:
2008-03-31 Alice Liu <alice.liu@apple.com>
Reviewed by Darin.
- WebView/WebFrame.mm: (-[WebFrame _accessibilityTree]): The syntax for fetching an object from the AXObjectCache changed slightly
- 1:24 AM Changeset in webkit [31516] by
-
- 2 edits in trunk/WebKit/qt
2008-04-01 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Simon.
- Change the order of the methods to match with the FrameLoaderClient.h to ease removing methods in the future.
- 1:24 AM Changeset in webkit [31515] by
-
- 3 edits in trunk/WebKit/qt
2008-04-01 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Simon.
- Remove virtuals in the FrameLoaderClientQt that don't exist in the base class.
- 12:32 AM Changeset in webkit [31514] by
-
- 3 edits in branches/squirrelfish/JavaScriptCore
2008-04-01 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Changed Machine::dumpRegisters to take a pointer instead of a reference,
so gdb understands how to call it.
- VM/Machine.cpp: (KJS::Machine::dumpRegisters): (KJS::Machine::privateExecute):
- VM/Machine.h:
