Timeline



May 29, 2008:

11:05 PM Changeset in webkit [34254] by Chris Fleizach
  • 6 edits in trunk/WebCore

<rdar://problem/5091386> Seed: VO reads form labels twice in Safari
<rdar://problem/4783102> Radio button/checkbox embedded with <label> tag should combine the text and the label as a single element

10:50 PM Changeset in webkit [34253] by mrowe@apple.com
  • 4 edits in branches/WWDC-2008-branch

Versioning.

10:50 PM Changeset in webkit [34252] by mrowe@apple.com
  • 1 copy in tags/Safari-6526.9

New tag.

10:49 PM Changeset in webkit [34251] by mrowe@apple.com
  • 5 edits
    2 adds in branches/WWDC-2008-branch

Merge r34250.

10:45 PM Changeset in webkit [34250] by mjs@apple.com
  • 5 edits
    2 adds in trunk

JavaScriptCore:

2008-05-29 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.

  • fixed <rdar://problem/5972943> REGRESSION(r33979): Flash clips do not play on cnn.com


Finally blocks could clobber registers that had to remain live
until they returned. This patch takes a conservative approach and
makes sure that finally blocks do not reuse any registers that
were previously allocated for the function. In the future this
could probably be tightened up to be less profligate with the
register allocation.


  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::highestUsedRegister):
  • VM/CodeGenerator.h:
  • kjs/nodes.cpp: (KJS::TryNode::emitCode):

LayoutTests:

2008-05-29 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver. Test by Geoff Garen.


  • fixed <rdar://problem/5972943> REGRESSION(r33979): Flash clips do not play on cnn.com
  • fast/js/finally-codegen-failure-expected.txt: Added.
  • fast/js/finally-codegen-failure.html: Added.
8:44 PM Changeset in webkit [34249] by alp@webkit.org
  • 5 edits in trunk/WebKit/gtk

2008-05-29 Marco Barisione <​marco@collabora.co.uk>

Reviewed (and tweaked) by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=18281
[GTK] add functions to set/get the zoom level

  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
  • webkit/webkitwebview.cpp: Add functions to get and set the zoom level.
  • webkit/webkitwebview.h: Ditto.
  • webkit/webkitprivate.h:
4:51 PM Changeset in webkit [34248] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

4:27 PM Changeset in webkit [34247] by mrowe@apple.com
  • 4 edits in branches/WWDC-2008-branch/WebKit

Merge r34208.

4:27 PM Changeset in webkit [34246] by mrowe@apple.com
  • 4 edits in branches/WWDC-2008-branch

Merge r34207.

4:26 PM Changeset in webkit [34245] by mrowe@apple.com
  • 2 edits in branches/WWDC-2008-branch/WebKit/mac

Merge r34203.

4:26 PM Changeset in webkit [34244] by mrowe@apple.com
  • 6 edits in branches/WWDC-2008-branch/JavaScriptGlue

Merge r34191.

4:26 PM Changeset in webkit [34243] by mrowe@apple.com
  • 2 edits in branches/WWDC-2008-branch/WebCore

Merge r34190.

4:26 PM Changeset in webkit [34242] by mrowe@apple.com
  • 2 edits in branches/WWDC-2008-branch/WebCore

Merge r34188.

4:26 PM Changeset in webkit [34241] by mrowe@apple.com
  • 4 edits in branches/WWDC-2008-branch/WebCore

Merge r34186.

4:26 PM Changeset in webkit [34240] by mrowe@apple.com
  • 13 edits in branches/WWDC-2008-branch

Merge r34182.

4:26 PM Changeset in webkit [34239] by mrowe@apple.com
  • 4 edits in branches/WWDC-2008-branch/WebCore

Merge r34179.

4:26 PM Changeset in webkit [34238] by mrowe@apple.com
  • 3 edits
    3 adds in branches/WWDC-2008-branch

Merge r34177.

4:26 PM Changeset in webkit [34237] by mrowe@apple.com
  • 6 edits in branches/WWDC-2008-branch

Merge r34166.

4:26 PM Changeset in webkit [34236] by mrowe@apple.com
  • 2 edits in branches/WWDC-2008-branch/WebCore

Merge r34162.

4:26 PM Changeset in webkit [34235] by mrowe@apple.com
  • 3 edits in branches/WWDC-2008-branch/WebCore

Merge r34161.

4:26 PM Changeset in webkit [34234] by mrowe@apple.com
  • 3 edits in branches/WWDC-2008-branch/WebCore

Merge r34158.

4:26 PM Changeset in webkit [34233] by mrowe@apple.com
  • 2 edits in branches/WWDC-2008-branch/WebCore

Merge r34155.

4:26 PM Changeset in webkit [34232] by mrowe@apple.com
  • 2 edits in branches/WWDC-2008-branch/WebKit/mac

Merge r34154.

4:26 PM Changeset in webkit [34231] by mrowe@apple.com
  • 1 edit in branches/WWDC-2008-branch/JavaScriptCore/ChangeLog

Merge r34136.

4:25 PM Changeset in webkit [34230] by mrowe@apple.com
  • 2 edits in branches/WWDC-2008-branch/JavaScriptCore

Merge r34135.

4:25 PM Changeset in webkit [34229] by mrowe@apple.com
  • 3 edits in branches/WWDC-2008-branch/LayoutTests

Merge r34134.

4:25 PM Changeset in webkit [34228] by mrowe@apple.com
  • 4 edits in branches/WWDC-2008-branch/WebKit/mac

Merge r34130.

4:25 PM Changeset in webkit [34227] by mrowe@apple.com
  • 3 edits
    4 adds in branches/WWDC-2008-branch

Merge r34127.

4:25 PM Changeset in webkit [34226] by mrowe@apple.com
  • 2 edits in branches/WWDC-2008-branch/WebCore

Merge r34115.

4:25 PM Changeset in webkit [34225] by mrowe@apple.com
  • 3 edits in branches/WWDC-2008-branch/WebCore

Merge r34109.

4:25 PM Changeset in webkit [34224] by mrowe@apple.com
  • 8 edits
    4 deletes in branches/WWDC-2008-branch/WebCore

Merge r34107.

4:25 PM Changeset in webkit [34223] by mrowe@apple.com
  • 2 edits in branches/WWDC-2008-branch/WebCore

Merge r34104.

4:25 PM Changeset in webkit [34222] by mrowe@apple.com
  • 3 edits in branches/WWDC-2008-branch/WebCore

Merge r34102.

4:25 PM Changeset in webkit [34221] by mrowe@apple.com
  • 2 edits in branches/WWDC-2008-branch/LayoutTests/editing/execCommand

Merge r34098.

4:25 PM Changeset in webkit [34220] by mrowe@apple.com
  • 4 edits
    1 add in branches/WWDC-2008-branch/WebCore

Merge r34096.

4:25 PM Changeset in webkit [34219] by mrowe@apple.com
  • 5 edits in branches/WWDC-2008-branch/JavaScriptCore

Merge r34095.

4:25 PM Changeset in webkit [34218] by mrowe@apple.com
  • 3 edits in branches/WWDC-2008-branch/LayoutTests

Merge r34093.

4:25 PM Changeset in webkit [34217] by mrowe@apple.com
  • 3 edits in branches/WWDC-2008-branch/JavaScriptCore

Merge r34092.

4:25 PM Changeset in webkit [34216] by mrowe@apple.com
  • 4 edits in branches/WWDC-2008-branch

Versioning.

4:10 PM Changeset in webkit [34215] by mrowe@apple.com
  • 1 copy in branches/WWDC-2008-branch

New branch.

3:06 PM Changeset in webkit [34214] by Adam Roben
  • 2 edits in trunk/BugsSite

Update PrettyPatch directory list

  • PrettyPatch/PrettyPatch.rb:
3:03 PM Changeset in webkit [34213] by timothy@apple.com
  • 4 edits in trunk/WebCore

Removes a use of the internal _childrenListNode property by adding
a getter/setter for smallChildren to SidebarSectionTreeElement.

Reviewed by Adam Roben.

  • page/inspector/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._toggleLargerResources): Toggle smallChildren on the resourcesTreeElement instead of setting the style class directly.
  • page/inspector/SidebarTreeElement.js: (WebInspector.SidebarSectionTreeElement.prototype.smallChildren): Sets or removes the small class on the _childrenListNode.
2:35 PM Changeset in webkit [34212] by ggaren@apple.com
  • 2 edits in trunk/WebKitTools

Geoffrey Garen <​ggaren@apple.com>

Reviewed by Adam Roben.

Fixed VCSUtils.pm to work with git repositories inside symlinks.

  • Scripts/VCSUtils.pm: Compute a relative path from the git repository root, instead of the root of the filesystem, to work around a bug in abs2rel when traversing symlinked home directories.
2:25 PM Changeset in webkit [34211] by timothy@apple.com
  • 3 edits in trunk/WebCore

Fixes a bug where the className would be reset for Resource
tree elements and the selected state would be lost. This could
happen when sorting the resources.

​https://bugs.webkit.org/show_bug.cgi?id=19211

Reviewed by Adam Roben.

  • page/inspector/ResourcesPanel.js:

(WebInspector.ResourceSidebarTreeElement.prototype.refresh): Call
removeMatchingStyleClasses to remove previous category classes instead
of setting the whole className directly.

  • page/inspector/utilities.js:

(Element.prototype.removeStyleClass): Moved code to
removeMatchingStyleClasses and call removeMatchingStyleClasses.
(Element.prototype.removeMatchingStyleClasses): Added. Code moved from
removeStyleClass and don't escape the string.

2:05 PM Changeset in webkit [34210] by hyatt@apple.com
  • 7 edits in trunk/WebCore

2008-05-29 David Hyatt <​hyatt@apple.com>

Improve the performance of the GUIMark benchmark by 2x in the CoreGraphics code path.

Whenever a foreground image changes size rapidly, we will now dynamically shift into rendering it
using low quality scaling. Once the animation completes, the image will repaint at high quality.
Scaled images will still render at high quality by default, only shifting into low quality if
the scale factor is rapidly changing. This change raises GUIMark from 21fps to 34fps on my machine.

Rewrite the Image draw method to avoid the use of throwaway CG subimages. Instead the entire image is
always drawn (with the appropriate clip and scale set up to make sure the correct subimage portion shows up
in the destination rect). This change raises GUIMark from 34fps to 43fps on my machine.

Reviewed by Darin

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):
  • rendering/RenderImage.cpp: (WebCore::RenderImageScaleData::RenderImageScaleData): (WebCore::RenderImageScaleData::~RenderImageScaleData): (WebCore::RenderImageScaleData::size): (WebCore::RenderImageScaleData::time): (WebCore::RenderImageScaleData::useLowQualityScale): (WebCore::RenderImageScaleData::hiqhQualityRepaintTimer): (WebCore::RenderImageScaleData::setSize): (WebCore::RenderImageScaleData::setTime): (WebCore::RenderImageScaleData::setUseLowQualityScale): (WebCore::RenderImageScaleObserver::shouldImagePaintAtLowQuality): (WebCore::RenderImageScaleObserver::imageDestroyed): (WebCore::RenderImageScaleObserver::highQualityRepaintTimerFired): (WebCore::RenderImage::highQualityRepaintTimerFired): (WebCore::RenderImage::~RenderImage): (WebCore::RenderImage::paintReplaced):
  • rendering/RenderImage.h:
1:37 PM Changeset in webkit [34209] by justin.garcia@apple.com
  • 6 edits
    4 adds in trunk

WebCore:

2008-05-29 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Eric.

<rdar://problem/5847330> REGRESSION CrashTracer: [USER] 536 crashes at WebCore::highestAncestor

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Don't break out of an empty list item if its parent is non-editable, since doing so will move into non-editable content.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): We want to prevent merges from table cells even if those table cells are non-editable.
  • editing/htmlediting.cpp: (WebCore::enclosingNodeOfType): Can now return non-editable nodes, for cases where the caller isn't going to do editing in the returned node.
  • editing/htmlediting.h:

LayoutTests:

2008-05-28 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Eric.


<rdar://problem/5847330> REGRESSION CrashTracer: [USER] 536 crashes at WebCore::highestAncestor

  • editing/deleting/5847330-1-expected.txt: Added.
  • editing/deleting/5847330-1.html: Added.
  • editing/deleting/5847330-2-expected.txt: Added.
  • editing/deleting/5847330-2.html: Added.
12:22 PM Changeset in webkit [34208] by andersca@apple.com
  • 4 edits in trunk/WebKit

../mac:

2008-05-29 Anders Carlsson <​andersca@apple.com>

Reviewed by Brady.

<rdar://problem/5970312>
icon file specified for stand alone web app causes crash if the icon can't be found


Handle the case where iconData is null.


  • Misc/WebIconFetcher.mm: (WebIconFetcherClient::finishedFetchingIcon):

../win:

2008-05-29 Anders Carlsson <​andersca@apple.com>

Reviewed by Brady.

<rdar://problem/5970312>
icon file specified for stand alone web app causes crash if the icon can't be found


Handle the case where iconData is null.

  • WebIconFetcher.cpp: (WebIconFetcherClient::finishedFetchingIcon):
11:57 AM Changeset in webkit [34207] by andersca@apple.com
  • 4 edits in trunk

WebCore:

2008-05-29 Anders Carlsson <​andersca@apple.com>

Reviewed by Mitz.

<rdar://problem/5971845>
​https://bugs.webkit.org/show_bug.cgi?id=19313
Add version member to NPCocoaEvent


  • bridge/npapi.h:

WebKit/mac:

2008-05-29 Anders Carlsson <​andersca@apple.com>

Reviewed by Mitz.

<rdar://problem/5971845>
​https://bugs.webkit.org/show_bug.cgi?id=19313
Add version member to NPCocoaEvent

Initialize the version member to 0 for all events.


  • Plugins/WebNetscapePluginEventHandlerCocoa.mm: (initializeEvent): (WebNetscapePluginEventHandlerCocoa::drawRect): (WebNetscapePluginEventHandlerCocoa::sendMouseEvent): (WebNetscapePluginEventHandlerCocoa::flagsChanged): (WebNetscapePluginEventHandlerCocoa::sendKeyEvent): (WebNetscapePluginEventHandlerCocoa::windowFocusChanged): (WebNetscapePluginEventHandlerCocoa::focusChanged):
11:02 AM Changeset in webkit [34206] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

Reviewed by Darin Adler.

Restore original behavior of isOSX() referring to the Mac port, not the OS itself.

​https://bugs.webkit.org/show_bug.cgi?id=19311

10:31 AM Changeset in webkit [34205] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-05-29 Steve Falkenburg <​sfalken@apple.com>

Build fix.

  • kjs/array_instance.cpp:
10:14 AM Changeset in webkit [34204] by ap@webkit.org
  • 3 edits
    3 adds in trunk

Reviewed by Darin.

​https://bugs.webkit.org/show_bug.cgi?id=19294
<rdar://problem/5969062> A crash when iterating over a sparse array backwards.

  • kjs/array_instance.cpp: Turned sparseArrayCutoff into a macro, so that using max() on it doesn't cause a PIC branch. (KJS::ArrayInstance::increaseVectorLength): Added a comment about this function not preserving class invariants. (KJS::ArrayInstance::put): Update m_storage after reallocation. Move values that fit to the vector from the map in all code paths.
9:08 AM Changeset in webkit [34203] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Jessica Kahn.

  • fix <rdar://problem/5965013> Page 2 does not print correctly

When printing, _recursiveDisplayRectIfNeededIgnoringOpacity:... and
_recursiveDisplayAllDirtyWithLockFocus:... can be invoked without
-viewWillDraw being sent first, which could lead to painting without
valid layout. The fix is to ensure up-to-date layout in those methods
when printing.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
8:05 AM Changeset in webkit [34202] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

<rdar://problem/5960682> REGRESSION(r30535): Crashes on iExploder in checkForHeadCharset().

I don't see how to make a reliable test, but iExploder catches this quickly.

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Correct the length passed to findIgnoringCase().
6:42 AM Changeset in webkit [34201] by ap@webkit.org
  • 3 edits in trunk/WebKitTools

Reviewed by Adam Roben.

Fix run-iexploder-tests and run-mangleme-tests to work with updated shared scripts and
configuration files.

  • Scripts/run-iexploder-tests:
  • Scripts/run-mangleme-tests: Renamed runSafari to not conflict with the one in webkitdirs. Added SSLCertificateFile option for httpd, as now needed.
5:53 AM Changeset in webkit [34200] by alp@webkit.org
  • 4 edits in trunk/WebCore

2008-05-29 Peter Kasting <​zerodpx@gmail.com>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=19273
Handle looping GIFs correctly (at least in the open source GIF decoder) even when
the loop count doesn't appear in the initial data packets.

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::cacheFrame): (WebCore::BitmapImage::startAnimation): (WebCore::BitmapImage::advanceAnimation):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::GIFImageDecoder): (WebCore::GIFImageDecoder::repetitionCount): (WebCore::GIFImageDecoder::gifComplete):
  • platform/image-decoders/gif/GIFImageDecoder.h:
4:28 AM Changeset in webkit [34199] by alp@webkit.org
  • 8 edits in trunk/WebCore

2008-05-29 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=19284
Correct Windows (Cairo) Build Regressions

Correct small Windows (Cairo) build regressions in recent updates.

  • platform/graphics/SimpleFontData.h: Correct build regression due to r32781 (additional use of m_syntheticBoldOffset in GDI code).
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Correct build regression due to r31830 (change of clip signature to use FloatRect rather than IntRect).
  • platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit): Initialize m_syntheticBoldOffset
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::JPEGImageReader): Work around build error due to warnings about _setjmp treated as errors.
  • platform/image-decoders/png/PNGImageDecoder.cpp: Work around build error due to warnings about _setjmp treated as errors.
  • platform/network/curl/ResourceHandleCurl.cpp: Correct build error due to different order (and content) of include files when building with CoreFoundation (but not CoreGraphics).
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPOST): Correct build error due to Visual Studio compiler bug.
3:16 AM Changeset in webkit [34198] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-05-29 Thiago Macieira <​tjmaciei@trolltech.com>

Reviewed by Simon.

Fix compilation in Solaris with Sun CC

Lots of WebKit code uses C99 functions that, strict as it
is, the Solaris system doesn't provide in C++. So we must define them
for both GCC and the Sun CC.

2:43 AM Changeset in webkit [34197] by ap@webkit.org
  • 12 edits
    2 adds in trunk

Reviewed by Darin.

​https://bugs.webkit.org/show_bug.cgi?id=19215
REGRESSION: transformToDocument fails when xsl includes &#160;

Test: fast/xsl/nbsp-in-stylesheet.html

  • editing/markup.cpp: (WebCore::appendAttributeValue): (WebCore::appendEscapedContent): (WebCore::escapeContentText): (WebCore::appendQuotedURLAttributeValue): (WebCore::appendNamespace): (WebCore::appendStartMarkup): (WebCore::appendDocumentType): (WebCore::createMarkup): Only escape non-breaking spaces in HTML documents. In Firefox, this behavior is also limited to innerHTML, but we don't have a separate code path for it, and do not necessarily want to.
  • page/Frame.cpp: (WebCore::Frame::documentTypeString):
  • dom/CDATASection.cpp:
  • dom/CDATASection.h:
  • dom/Comment.cpp:
  • dom/Comment.h:
  • dom/DocumentType.cpp:
  • dom/DocumentType.h:
  • dom/ProcessingInstruction.cpp:
  • dom/ProcessingInstruction.h: While at it, I also wanted to fix escaping for these nodes, but it turned out that FIXMEs were incorrect. So, I just moved their serialization to markup.cpp for consistency.
2:37 AM Changeset in webkit [34196] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Kavindra Devi Palaraja <​kdpalara@trolltech.com>

Doc: Mention the requirement of a QApplication with QtWebKit

2:37 AM Changeset in webkit [34195] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

David Boddie <​dboddie@trolltech.com>

Some clarifications for the documentation.

1:11 AM Changeset in webkit [34194] by mjs@apple.com
  • 2 edits in trunk

Fix ChangeLog typos.

1:05 AM Changeset in webkit [34193] by mjs@apple.com
  • 23 edits in trunk

WebCore:

2008-05-29 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dave Hyatt.

  • speed up DHTML using lazy style resolution and rendere creation

This change introduces the concept of "lazy attach" - when a node
is lazy attached, then instead of resolving style and creating a
renderer right away, we just mark it as needing a style recalc.


The patch makes use of this mechanism when inserting nodes directly
using DOM APIs from script. For now this is only done for the
JavaScript language binding but could also be done for other
bindings in the future.


Lazy attach helps some common DHTML patterns - when a node is
added to the DOM, and then subsequently changed in a
style-affecting way, this causes an extra style recalc. This is a
fairly common pattern so it is better to be lazy.


  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::insertBefore): Request lazy attach. (WebCore::JSNode::replaceChild): ditto (WebCore::JSNode::appendChild): ditto
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): Support lazy attach. (WebCore::ContainerNode::replaceChild): ditto (WebCore::ContainerNode::appendChild): ditto (WebCore::ContainerNode::detach): Clear "changed child" bit if still set.
  • dom/ContainerNode.h:
  • dom/Element.cpp: (WebCore::Element::recalcStyle): Adjusted to properly reattach a lazy-attached node.
  • dom/Node.cpp: (WebCore::Node::insertBefore): Extra parameter for lazy attach (still doesn't do anything). (WebCore::Node::replaceChild): ditto (WebCore::Node::appendChild): ditto (WebCore::Node::setChanged): Unrelated but obvious optimization - stop marking ancestor as having a changed child once we already reach an ancestor so marked. (WebCore::outermostLazyAttachedAncestor): Helper function for lazyAttach. (WebCore::Node::lazyAttach): Implement lazy attach. (WebCore::Node::canLazyAttach): Virtual method - true for most nodes.
  • dom/Node.h:
  • dom/Text.cpp: (WebCore::Text::recalcStyle): Properly handle the case of a reattached node.
  • html/HTMLEmbedElement.h: (WebCore::HTMLEmbedElement::canLazyAttach): Refuse lazy attach, since plugins and frames do important work at rederer creation time.
  • html/HTMLFrameElementBase.h: (WebCore::HTMLFrameElementBase::canLazyAttach): Refuse lazy attach, since plugins and frames do important work at rederer creation time.
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::recalcStyle): Change order so that reattach works properly.
  • html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::canLazyAttach): Refuse lazy attach, since plugins and frames do important work at rederer creation time.
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::insertBefore): Pass along extra param. (WebCore::HTMLOptGroupElement::replaceChild): ditto (WebCore::HTMLOptGroupElement::appendChild): ditto
  • html/HTMLOptGroupElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::insertBefore): Pass along extra param. (WebCore::HTMLSelectElement::replaceChild): ditto (WebCore::HTMLSelectElement::appendChild): ditto
  • html/HTMLSelectElement.h:
  • svg/SVGLocatable.cpp: (WebCore::SVGLocatable::getBBox): Add missing updateLayout call.
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::getNumberOfChars): ditto (WebCore::SVGTextContentElement::getComputedTextLength): ditto (WebCore::SVGTextContentElement::getSubStringLength): ditto (WebCore::SVGTextContentElement::getStartPositionOfChar): ditto (WebCore::SVGTextContentElement::getEndPositionOfChar): ditto (WebCore::SVGTextContentElement::getExtentOfChar): ditto (WebCore::SVGTextContentElement::getRotationOfChar): ditto (WebCore::SVGTextContentElement::getCharNumAtPosition): ditto

LayoutTests:

2008-05-29 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dave Hyatt.

  • Test cases for this change: "speed up DHTML using lazy style resolution and rendere creation"
  • http/tests/misc/acid3-expected.txt:
  • platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.checksum:
  • platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
  • platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:

May 28, 2008:

9:15 PM Changeset in webkit [34192] by oliver@apple.com
  • 5 edits in trunk

Fix codegen for assignment being used as a function.

Reviewed by Anders.

FunctionCallValueNode::emitCode failed to account for the
potential of the function expression to allocate arbitrary
registers.

7:11 PM Changeset in webkit [34191] by Beth Dakin
  • 6 edits in trunk/JavaScriptGlue

2008-05-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Fixed total destruction in Software Update.app.


Updated JavaScriptGlue to honor squirrelfish's new getCallData mechanism for
indicating that an object can be called as a function.

5:51 PM Changeset in webkit [34190] by adachan@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/5957036> REGRESSION (r31960): 20-30% slowdown in i-Bench JavaScript test on XP Home
Conditionalize the timer latency change (r31960) only for vista since it does not
help xp anyway.

Reviewed by Steve Falkenburg.

  • platform/win/SharedTimerWin.cpp: (WebCore::isRunningOnVistaOrLater): (WebCore::TimerWindowWndProc): (WebCore::setSharedTimerFireTime):
5:44 PM Changeset in webkit [34189] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-05-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Jon.

Remove workaround, this is no longer a problem.


  • WebView/WebView.mm: (-[WebView _removeObjectForIdentifier:]):
4:20 PM Changeset in webkit [34188] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-05-28 Anders Carlsson <​andersca@apple.com>

Build fix.


  • storage/LocalStorage.cpp: (WebCore::LocalStorage::scheduleImport):
3:50 PM Changeset in webkit [34187] by andersca@apple.com
  • 4 edits in trunk/WebCore

2008-05-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Tim.

<rdar://problem/5965960>
CrashTracer: [USER] 4 crashes in Safari at libxml2.2.dylib: xmlGenericErrorDefaultFunc + 76


Turns out that while libxml has two different error callbacks, they both use the same context, so we need to
set both error callbacks to prevent one of the error callbacks from using the context as a FILE pointer.


  • xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::parseString):
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::genericErrorFunc): (WebCore::docLoaderFunc):
  • xml/XSLTProcessor.h:
3:45 PM Changeset in webkit [34186] by beidson@apple.com
  • 4 edits in trunk/WebCore

2008-05-28 Brady Eidson <​beidson@apple.com>

Reviewed by Adam

Fix hang I introduced to WebKit clients without their LocalStorage paths set
Such as DRT...

  • storage/LocalStorage.cpp: (WebCore::LocalStorage::scheduleImport): Return a bool, namely to signify whether or not there is a LocalStorageThread to schedule the import on.
  • storage/LocalStorage.h:
  • storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::LocalStorageArea): If the scheduleImport failed, mark the imported flag as true so the LocalStorageArea doesn't wait around locking the main thread.
3:25 PM Changeset in webkit [34185] by pewtermoose@webkit.org
  • 3 edits in trunk/WebCore

2008-05-28 Anthony Ricaud <​rik24d@gmail.com>

User stylesheets are now non-editable and displayed as user-stylesheets

<​https://bugs.webkit.org/show_bug.cgi?id=17602>
<rdar://problem/5967637>

Reviewed by Tim Hatcher.

  • English.lproj/localizedStrings.js: Added a string
  • page/inspector/StylesSidebarPane.js:
2:48 PM Drosera edited by pewtermoose@webkit.org
Add note about Drosera going to the giant debugger in the sky (diff)
2:00 PM Changeset in webkit [34184] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-05-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Mitz.

<rdar://problem/5819989>
Crash in WebKit!KJS::Window::printErrorMessage quitting Safari after pop up window on uk.real.com was closed

Add null check for Frame::settings().


  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::printErrorMessage):
1:57 PM Changeset in webkit [34183] by kevino@webkit.org
  • 5 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

This patch adds a new wx event type and code to send it when a new title is set by the page being loaded.

​https://bugs.webkit.org/show_bug.cgi?id=19067

1:47 PM Changeset in webkit [34182] by ggaren@apple.com
  • 13 edits in trunk

JavaScriptCore:

2008-05-27 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Tim Hatcher.

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=19183
REGRESSION (r33979): Crash in DebuggerCallFrame::functionName when
clicking button in returnEvent-crash.html

Added two new debugger hooks, willExecuteProgram and didExecuteProgram,
along with code to generate them, code to invoke them when unwinding
due to an exception, and code to dump them.


SunSpider reports no change.

  • VM/CodeBlock.cpp: (KJS::debugHookName): I had to mark this function NEVER_INLINE to avoid a .4% performance regression. The mind boggles.

WebCore:

2008-05-27 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Tim Hatcher.

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=19183
REGRESSION (r33979): Crash in DebuggerCallFrame::functionName when
clicking button in returnEvent-crash.html


Added implementations for willExecuteProgram and didExecuteProgram. They
take care to update our call frame when entering and exiting programs,
preventing us from keeping around a stale global frame after executing
a program.


eval programs now show up as "anonymous function" in a new scope. This
is slightly better than what they used to do -- overwriting the current
scope -- but obviously we can do better.

WebKit/mac:

2008-05-27 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Tim Hatcher.


Fixed ​https://bugs.webkit.org/show_bug.cgi?id=19183
REGRESSION (r33979): Crash in DebuggerCallFrame::functionName when
clicking button in returnEvent-crash.html


Added implementations for willExecuteProgram and didExecuteProgram, which
take care of making sure we're not hanging on to stale data.

1:28 PM Changeset in webkit [34181] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

This patch tweaks the wxWebView class to make it conform to normal wx patterns for widget classes. It adds a default ctor and the Create method so it can use the 2-phase create pattern, adds wxRTTI macros which is important for wxPython and XRC, and fixes the LoadURL method to pass a wxString reference to save a copy.

​https://bugs.webkit.org/show_bug.cgi?id=19068

1:13 PM Changeset in webkit [34180] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Fix JavaScriptCore tests on OS X

We were quoting the path to testkjs too late, after it had already
been combined with spaces and other options.

  • tests/mozilla/jsDriver.pl: (top level): Move path quoting from here... (sub get_kjs_engine_command): ...to here.
11:55 AM Changeset in webkit [34179] by beidson@apple.com
  • 4 edits in trunk/WebCore

2008-05-28 Brady Eidson <​beidson@apple.com>

Reviewed by Dan Bernstein

<rdar://problem/5946834> - LocalStorage threads appearing in apps that don't want them.

Decided to fix this bug from a few different avenues to make sure we only create LocalStorage resources
when we *really* want them.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::localStorage): Account for the possibility that the LocalStorage object might be null.
  • storage/LocalStorage.cpp: (WebCore::LocalStorage::LocalStorage): Don't create the thread if there is no path name - we know we'll never be needing it when there is no file backing us on disk. (WebCore::LocalStorage::scheduleImport): Null check the thread, as it might not exist. (WebCore::LocalStorage::scheduleSync): Ditto
  • storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::localStorageThread): Clear the threadID after termination - clear way to signify that this thread is truly done. (WebCore::LocalStorageThread::scheduleImport): ASSERT that the queue is live, and the threadID exists (WebCore::LocalStorageThread::scheduleSync): Ditto (WebCore::LocalStorageThread::terminate): Don't schedule termination and wait for it to complete if the thread isn't live.
11:36 AM Changeset in webkit [34178] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Rescale image to fit the destination rect so that we don't get a crash when drawing in a destination rect that's bigger than the image rect. Also adds an optimization for drawing an image that is a solid color.

​https://bugs.webkit.org/show_bug.cgi?id=18465

11:13 AM Changeset in webkit [34177] by andersca@apple.com
  • 3 edits
    3 adds in trunk

JavaScriptCore:

2008-05-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Oliver.

<rdar://problem/5968071> "const f" crashes in JavaScriptCore


Make sure to null check the initializer.


  • kjs/nodes.cpp: (KJS::ConstDeclNode::emitCodeSingle):

LayoutTests:

2008-05-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Oliver.

<rdar://problem/5968071> "const f" crashes in JavaScriptCore

  • fast/js/const-without-initializer-expected.txt: Added.
  • fast/js/const-without-initializer.html: Added.
  • fast/js/resources/const-without-initializer.js: Added.
11:04 AM Changeset in webkit [34176] by alp@webkit.org
  • 3 edits in trunk/WebKit/gtk

2008-05-28 Alp Toker <​alp@nuanti.com>

Reviewed by Alexey Proskuryakov.

​http://bugs.webkit.org/show_bug.cgi?id=18704
[gtk] cannot type letters with dead keys in textarea

​http://bugs.webkit.org/show_bug.cgi?id=14120
[GDK] Support input methods

Add support for input method composition.

Remove some old hacks so we handle input method events more
consistently.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::imContextCommitted): (WebKit::imContextPreeditChanged): (WebKit::EditorClient::setInputMethodState): (WebKit::EditorClient::respondToChangedSelection): (WebKit::EditorClient::handleInputMethodKeydown): (WebKit::EditorClient::EditorClient): (WebKit::EditorClient::~EditorClient): (WebKit::EditorClient::textFieldDidBeginEditing): (WebKit::EditorClient::textFieldDidEndEditing): (WebKit::EditorClient::textDidChangeInTextField): (WebKit::EditorClient::doTextFieldCommandFromEvent):
  • webkit/webkitwebview.cpp:
10:31 AM Changeset in webkit [34175] by Adam Roben
  • 2 edits in trunk/BugsSite

Make PrettyPatch able to handle diffs taken from outside the WebKit source tree

Part of Bug 19290: More patches not handled by PrettyPatch.rb
<​https://bugs.webkit.org/show_bug.cgi?id=19290>

Reviewed by David Kilzer.

  • PrettyPatch/PrettyPatch.rb: (PrettyPatch.find_url_and_path): Added. Searches the file path from the bottom up looking for a directory that exists in the source tree. (PrettyPatch.linkifyFilename): Changed to call find_url_and_path.
10:31 AM Changeset in webkit [34174] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Make run-javascriptcore-tests work with a space in the path to testkjs

Reviewed by Alexey Proskuryakov.

  • tests/mozilla/jsDriver.pl: Quote the path to the engine so that spaces will be interpreted correctly.
8:46 AM Changeset in webkit [34173] by Adam Roben
  • 3 edits in trunk/BugsSite

Print exceptions from PrettyPatch to stdout

This will make it much easier to debug problems with PrettyPatch,
since we'll be able to see the exceptions in the browser.

Reviewed by Sam Weinig.

  • PrettyPatch/prettify.rb: Added a --html-exceptions option, which will print exceptions to stdout as HTML.
  • attachment.cgi: Changed to pass --html-exceptions to prettify.rb.
5:36 AM Changeset in webkit [34172] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Fixed a misguiding comment - my measurement for negative numbers only included cases
where both operands were negative, which is not very interesting.

  • VM/Machine.cpp:
3:48 AM Changeset in webkit [34171] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Based on a patch by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=19180
speed up SunSpider by optimizing immediate number cases

1.4% speedup on SunSpider.

  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • kjs/JSImmediate.h: (KJS::JSImmediate::incImmediateNumber): (KJS::JSImmediate::decImmediateNumber): Added fast paths for ++ and --.

(KJS::JSImmediate::canDoFastAdditiveOperations): Corrected a comment.

2:47 AM Changeset in webkit [34170] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

​https://bugs.webkit.org/show_bug.cgi?id=19180
speed up SunSpider by optimizing immediate number cases

2% speedup overall, maximum 10% on controlflow-recursive and bitops-3bit-bits-in-byte,
but a 4% regression on bitops-bits-in-byte and bitops-bitwise-and.

  • kjs/JSImmediate.h: (KJS::JSImmediate::canDoFastAdditiveOperations): (KJS::JSImmediate::addImmediateNumbers): (KJS::JSImmediate::subImmediateNumbers): Added fast cases that work with positive values less than 230.
  • VM/Machine.cpp: (KJS::Machine::privateExecute): Use the above operations. Also updated SunSpider frequencies with my results (looks like tag values have changed, not sure what caused the minor variation in actual frequencies).
12:44 AM Changeset in webkit [34169] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-05-27 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon

Close the video widget explicitly so we don't hang
when exiting the application.

May 27, 2008:

9:31 PM Changeset in webkit [34168] by mrowe@apple.com
  • 3 edits in tags/Safari-6526.8.1/JavaScriptCore

Merge r34165.

9:28 PM Changeset in webkit [34167] by mrowe@apple.com
  • 1 copy in tags/Safari-6526.8.1

New tag.

9:20 PM Changeset in webkit [34166] by justin.garcia@apple.com
  • 6 edits in trunk

WebCore:

2008-05-27 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Oliver.

<rdar://problem/5803706> Pressing return at the end of a header doesn't break out of header (17460)


It wasn't enough to break out of the header, to match other browsers we
also need to not preserve the typing style.

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/InsertParagraphSeparatorCommand.h:

LayoutTests:

2008-05-27 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Oliver.


<rdar://problem/5803706> Pressing return at the end of a header doesn't break out of header (17460)

  • editing/inserting/5803706-1-expected.txt: Adjust this already checked-in test to reflect the new expected behavior.
  • editing/inserting/5803706-1.html:
8:54 PM Changeset in webkit [34165] by Adam Roben
  • 3 edits in trunk/JavaScriptCore

Windows build fix

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Remove code that appended Cygwin's /bin directory to PATH.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Prepend Cygwin's /bin directory to PATH. We prepend instead of append so that Cygwin's utilities will win out over Win32 versions of the same utilities (particularly perl). We do the prepend here instead of in the Makefile because nmake doesn't seem to like prepending to PATH inside the Makefile. This also matches the way WebCoreGenerated works.
8:54 PM Changeset in webkit [34164] by Adam Roben
  • 3 edits in trunk/JavaScriptCore

Roll out r34163

A better fix is on the way.

  • DerivedSources.make:
  • JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
8:31 PM Changeset in webkit [34163] by Adam Roben
  • 3 edits in trunk/JavaScriptCore

Windows build fix

  • DerivedSources.make: Don't generate the bytecode docs if OMIT_BYTECODE_DOCS is set to 1.
  • JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Set OMIT_BYTECODE_DOCS for production builds.
7:45 PM Changeset in webkit [34162] by timothy@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/5966961> REGRESSION: Font previews in the Web
Inspector always show in Lucida Grande (not the real font)

Reviewed by Adam Roben.

  • page/inspector/FontView.js: Add a style element that loads the

@font-face rule that is excepted by the preview element.

7:45 PM Changeset in webkit [34161] by timothy@apple.com
  • 3 edits in trunk/WebCore

Fixes a regression where the Image and Font preview views do not
size correctly.

<rdar://problem/5966723> REGRESSION (r33991): Image and font previews
are shrunken and can't be made larger (19281)

Reviewed by Adam Roben.

  • page/inspector/FontView.js: Adjust the font size based only on the

container width minus padding.

  • page/inspector/inspector.css: Updated styles for the image and

font views.

5:44 PM Changeset in webkit [34160] by andersca@apple.com
  • 3 edits
    3 adds in trunk

JavaScriptCore:

2008-05-27 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoff and Maciej.

<rdar://problem/5806428>
​https://bugs.webkit.org/show_bug.cgi?id=17925
Crash in KJS::JSObject::put after setting this.proto

Set slotIsWriteable to false for proto, we want setting proto to go through JSObject::put instead.


  • kjs/object.h: (KJS::JSObject::getOwnPropertySlotForWrite):

LayoutTests:

2008-05-27 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoff and Maciej.

<rdar://problem/5806428>
​https://bugs.webkit.org/show_bug.cgi?id=17925
Crash in KJS::JSObject::put after setting this.proto

  • fast/js/resources/this-non-object-proto.js: Added.
  • fast/js/this-non-object-proto-expected.txt: Added.
  • fast/js/this-non-object-proto.html: Added.
4:38 PM Changeset in webkit [34159] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/html/HTMLTokenizer.h

Fix typo in comment.

4:33 PM Changeset in webkit [34158] by Adam Roben
  • 3 edits in trunk/WebCore

Fix Bug 19276: XHR resources are classified as "Other" until Inspector is closed and reopened

<​https://bugs.webkit.org/show_bug.cgi?id=19276>
<rdar://problem/5965742>

Reviewed by Tim Hatcher.

  • page/InspectorController.cpp: (WebCore::InspectorController::updateScriptResourceResponse): Moved code that updates the resource's type from here... (WebCore::InspectorController::updateScriptResourceType): ...to here. (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): Call updateScriptResourceType now that we know this resource was retrieved via an XHR.
  • page/InspectorController.h:
4:25 PM Changeset in webkit [34157] by Adam Roben
  • 1 edit in trunk/JavaScriptCore/VM/CodeBlock.cpp

Roll out r34156, which was accidentally checked in

4:22 PM Changeset in webkit [34156] by Adam Roben
  • 1 edit in trunk/JavaScriptCore/VM/CodeBlock.cpp

add printInstruction

2:50 PM Changeset in webkit [34155] by timothy@apple.com
  • 2 edits in trunk/WebCore

Removes a redundant call to InspectorController::stopDebugging().

Rubber-stamped by Adam Roben.

  • page/InspectorController.cpp:

(WebCore::InspectorController::showWindow):

1:44 PM Changeset in webkit [34154] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Fixes a bug where unplugging the monitor from a video card and
moving it to another video card would no longer show OpenGL plugins
until you relaunched Safari.

<rdar://problem/5790983> Add AllowOfflineDisplays pixel format
attribute to OpenGL contexts

Reviewed by Kevin Decker.

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView _createWindowedAGLContext]): Added
AGL_ALLOW_OFFLINE_RENDERERS for non-Tiger builds.
(-[WebBaseNetscapePluginView _createWindowlessAGLContext]): Ditto.

11:46 AM Changeset in webkit [34153] by kmccullough@apple.com
  • 4 edits
    2 adds in trunk/WebCore

2008-05-27 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

  • Added and updated some manual test for the profiler.
  • manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html:
  • manual-tests/inspector/profiler-test-apply.html:
  • manual-tests/inspector/profiler-test-call.html:
  • manual-tests/inspector/profiler-test-deep-recursion.html: Added.
  • manual-tests/inspector/profiler-test-simple-event-call.html: Added.
10:49 AM Changeset in webkit [34152] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wx build fix. Update the sample app after wxWebFrame->wxWebBrowserShell rename.

9:29 AM Changeset in webkit [34151] by kevino@webkit.org
  • 4 edits in trunk

wx build fix. Accidently left a couple fixes out of the previous commit.

9:12 AM Changeset in webkit [34150] by kevino@webkit.org
  • 6 edits in trunk

wx build fixes after introduction of SquirrelFish and other updates.

7:43 AM Changeset in webkit [34149] by Darin Adler
  • 3 edits in trunk/JavaScriptCore

2008-05-27 Darin Adler <Darin Adler>

Reviewed by Tim Hatcher.

Add immediate number cases for the &, |, and operators.
Makes standalone SunSpider 1.010x faster.

  • VM/Machine.cpp: (KJS::Machine::privateExecute): Add areBothImmediateNumbers special cases for the &, |, and operators.
  • kjs/JSImmediate.h: (KJS::JSImmediate::xorImmediateNumbers): Added. (KJS::JSImmediate::orImmediateNumbers): Added.
3:31 AM Changeset in webkit [34148] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-05-27 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Fix linking error (missing gdi32 and user32 libraries).

  • WebCore.pro:
2:49 AM Changeset in webkit [34147] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-05-27 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Fix web inspector does not returns its state properly after its window is minimized.

As hinted by Holger, InspectorClientView::hideEvent is not needed.
This fixes bug ​https://bugs.webkit.org/show_bug.cgi?id=18967

2:02 AM Changeset in webkit [34146] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-05-27 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Update the WebKit.qrc so that Web Inspector is functional again.

  • page/inspector/WebKit.qrc:

May 26, 2008:

10:04 PM Changeset in webkit [34145] by Stephanie Lewis
  • 2 edits in trunk/JavaScriptCore

2008-05-26 Stephanie Lewis <Stephanie Lewis>

Windows build fix.

  • kjs/testkjs.cpp:
7:48 PM Changeset in webkit [34144] by alp@webkit.org
  • 3 edits in trunk/WebCore

2008-05-26 Alp Toker <​alp@nuanti.com>

Reviewed by Anders.

​http://bugs.webkit.org/show_bug.cgi?id=16495
[GTK] Accessibility support with ATK/AT-SPI

Implement basic action, text and editable text accessibility.

Provide utility functions to simplify const string return and casting
and add some more stubs.

It's now possible to navigate and manipulate forms and text using
assistive technologies.

  • page/gtk/AccessibilityObjectWrapperAtk.cpp: (returnString): (core):
  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::AXButtonActionVerb): (WebCore::AXRadioButtonActionVerb): (WebCore::AXTextFieldActionVerb): (WebCore::AXCheckedCheckBoxActionVerb): (WebCore::AXUncheckedCheckBoxActionVerb): (WebCore::AXLinkActionVerb): (WebCore::imageTitle):
7:10 PM Changeset in webkit [34143] by mjs@apple.com
  • 14 edits in trunk

JavaScriptCore:

2008-05-26 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Anders.


  • make addStaticGlobals protected instead of private so subclasses can use it

WebCore:

2008-05-25 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Anders.

  • bind the window's "document" and "window" properties to static slots 1.7% speedup on Acid3 test 26


Only the "document" part matters for Acid3, but since I was doing
this anyway, "window" also seemed like a good one to optimize.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase): Allocate variable slots for document and window; but just put null in the document slot for now. (WebCore::JSDOMWindowBase::updateDocument): Fill in the document slot. (WebCore::JSDOMWindowBase::~JSDOMWindowBase): Make our shell stop tracking us.
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): Allocate HashSet for our still-not-dead inner windows. (WebCore::JSDOMWindowShell::updateDocument): Update all our inner windows ever (to make sure the update to the document property shows up everywhere).
  • bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::setWindow): Update our hash. (WebCore::JSDOMWindowShell::clearFormerWindow): Ditto.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): Don't set self as a property map property of the window, this is no longer necessary.
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScript): Update document for the newly created window.
  • bindings/js/kjs_proxy.h:
  • page/Frame.cpp: (WebCore::Frame::setDocument): If the document is not null, update our window.

LayoutTests:

2008-05-26 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Anders.


  • update test result for document/window being allocated to var slots
  • http/tests/security/cross-frame-access-put-expected.txt:
4:49 PM Changeset in webkit [34142] by collinj@webkit.org
  • 13 edits in trunk/LayoutTests

2008-05-26 James Ren <​jamesjren@gmail.com>

Reviewed by Sam Weinig, landed by Collin Jackson.

​http://bugs.webkit.org/show_bug.cgi?id=19163

Modified some http/security layout tests to allow them to run in Firefox.

  • http/tests/security/aboutBlank/xss-DENIED-set-opener.html:
  • http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change.html:
  • http/tests/security/resources/localhost-accesssor.html: Added a workaround for ​https://bugzilla.mozilla.org/show_bug.cgi?id=434912
  • http/tests/security/resources/cross-frame-access.js: Changed shouldBe to also gracefully handle exceptions


  • http/tests/security/resources/foreign-domain-iframe-for-selection-test.html: Added feature detection for setBaseAndExtent and selectAllChildren
  • http/tests/security/cross-frame-access-enumeration-expected.txt:
  • http/tests/security/cross-frame-access-enumeration.html: Fixed typo (missing '.html')
  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
  • http/tests/security/cross-frame-access-first-time.html:
  • http/tests/security/cross-frame-access-put.html:
  • http/tests/security/cross-frame-access-selection.html: Caught exceptions that Firefox throws, to allow the test to run to completion.
2:13 PM Changeset in webkit [34141] by andersca@apple.com
  • 7 edits
    1 add in trunk/WebCore

2008-05-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam.

This patch does two things:


  • It adds a toJSNewlyCreated function for creating JS wrappers for nodes where we know that the node doesn't have a wrapper. This avoids a hash lookup.


  • It adds toJSNewlyCreated methods for JSElement and JSText.


All in all this is a 4.3% speedup on Acid 3 test 26.


  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSElementCustom.cpp: (WebCore::toJSNewlyCreated):
  • bindings/js/JSNodeCustom.cpp: (WebCore::createWrapper): (WebCore::toJSNewlyCreated): (WebCore::toJS):
  • bindings/js/JSTextCustom.cpp: Added. (WebCore::toJSNewlyCreated):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Document.idl:
1:53 PM Changeset in webkit [34140] by Darin Adler
  • 1 edit in trunk/WebCore/ChangeLog

Fixed date of ChangeLog entry.

1:41 PM Changeset in webkit [34139] by weinig@apple.com
  • 7 edits in trunk/WebCore

2008-05-26 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Inline the getOwnPropertySlot for JSNode, JSEventTargetNode, JSElement,
and JSDocument for a 1-2% speedup on Acide 3 test 26.

  • bindings/js/JSEventTargetNode.cpp:
  • bindings/js/JSEventTargetNode.h: (WebCore::JSEventTargetNode::getOwnPropertySlot): (WebCore::JSEventTargetNode::getValueProperty): (WebCore::JSEventTargetNode::put): (WebCore::JSEventTargetNode::putValueProperty):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Node.idl:
1:07 PM Changeset in webkit [34138] by Darin Adler
  • 16 edits in trunk/WebCore

2008-05-25 Darin Adler <Darin Adler>

Reviewed by Maciej.

Removed code that would only useful if if there was any way to create an Entity
node or if we populated EntityReference nodes. It's likely that we'll remove
these node types entirely in some future version of WebKit, depending in part
on what happens with these in HTML 5.

1.8% speedup of Acid3 test 26.

The only read-only nodes we ever create are EntityReference nodes.
These are only created by explicit calls to the Document.createEntityReference
function. Since the created nodes are read-only, there can be no children of
these nodes, so no other types of nodes can be read-only despite the rule that
makes descendants of Entity and EntityReference nodes read-only.

  • bindings/objc/DOM.mm: Removed unneeded include.
  • dom/Attr.cpp: (WebCore::Attr::setValue): Removed unnecessary isReadOnlyNode check. (WebCore::Attr::setNodeValue): Ditto.
  • dom/CharacterData.cpp: (WebCore::CharacterData::setData): Removed unnecessary isReadOnlyNode check. (WebCore::CharacterData::substringData): Don't initialize the ec variable before calling checkCharDataOperation, since that function already does it. (WebCore::CharacterData::appendData): Removed unnecessary isReadOnlyNode check. (WebCore::CharacterData::insertData): Don't initialize ec. (WebCore::CharacterData::deleteData): Ditto. (WebCore::CharacterData::replaceData): Ditto. (WebCore::CharacterData::setNodeValue): Removed now-misleading comment. (WebCore::CharacterData::checkCharDataOperation): Removed unnecessary isReadOnlyNode check.
  • dom/CharacterData.h: Made checkCharDataOperation private and non-virtual since it's never used or defined in any other class.
  • dom/Element.cpp: (WebCore::Element::setAttribute): Removed unneeded isReadOnlyNode check.
  • dom/Entity.cpp: Removed the entire contents of this file.
  • dom/Entity.h: Replaced the class with a stub -- just enough to keep the public bindings (JavaScript and Objective-C compiling), but the class is abstract and can't be instantianted.
  • dom/EntityReference.cpp: Removed unused constructor. (WebCore::EntityReference::cloneNode): Removed unneeded code and comments to clone nonexistent child nodes.
  • dom/EntityReference.h: Removed unused constructor and unnecessary override of childTypeAllowed, since no children are allowed at all.
  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::setNamedItem): Removed unneeded isReadOnlyNode check. (WebCore::NamedAttrMap::removeNamedItem): Ditto.
  • dom/NamedAttrMap.h: Removed isReadOnlyNode function.
  • dom/Node.cpp: Removed the old isReadOnlyNode function. It made lots of virtual nodeType function calls.
  • dom/Node.h: (WebCore::Node::isReadOnlyNode): Replaced the old virtual isReadOnlyNode function with a new simple non-virtual one.
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::setData): Removed unneeded isReadOnlyNode check.
  • dom/Text.cpp: (WebCore::Text::splitText): Removed unneeded isReadOnlyNode check. (WebCore::Text::replaceWholeText): Removed unnecessary isReadOnlyNode assertion. There is no reason for this function to go out of its way to mention the read-only node issue when none of the other DOM mutation functions do.
12:38 PM Changeset in webkit [34137] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2008-05-26 Adam Barth <​abarth@webkit.org>

Reviewed by Sam.

Cleanup SecurityOrigin::canAccess. Removed comment referring to an
old version of the code. Removed some useless code.

  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canAccess):
11:57 AM Changeset in webkit [34136] by ggaren@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

ChangeLog fixup: 'prevent subtle errors' is a little more reassuring than 'lead to subtle errors'

11:50 AM Changeset in webkit [34135] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-05-26 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.


Fixed <rdar://problem/5960859> After an eval of a non-string or a syntax
error, all profile stack frames are incorrect


SunSpider reports a .3% speedup, possibly because eval of a string is a
little more efficient now.

  • VM/Machine.cpp: (KJS::callEval): Make sure to call didExecute when returning early. I simplified this function to remove one early return, making the job of adding special code to early returns easier.

(KJS::Machine::execute): Use the new function ExecState when notifying
the profiler. (This doesn't change behavior now, but it might lead to
subtle errors in the future.)

11:43 AM Changeset in webkit [34134] by andersca@apple.com
  • 3 edits in trunk/LayoutTests

2008-05-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam.

Add a name to the source frame.


  • fast/frames/viewsource-empty-attribute-value-expected.txt:
  • fast/frames/viewsource-empty-attribute-value.html:
5:45 AM Changeset in webkit [34133] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-05-26 Gwenole Beauchesne <​gbeauchesne@splitted-desktop.org>

Reviewed by Alp Toker.

  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::contextMenuItemTagSelectAll): Fix GTK+ version check.
5:29 AM Changeset in webkit [34132] by Simon Hausmann
  • 4 edits in trunk

JavaScriptCore:

2008-05-23 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Fixed toLower and toUpper implementations to allow being called
with a null result pointer and resultLength, to determine the
number of characters needed for the case conversion.

LayoutTests:

008-05-23 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Added a comment to the skipping of fast/css/case-transform.html that
mentions the reason of failure being a Qt bug.

4:39 AM Changeset in webkit [34131] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

2008-05-26 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon

Update QtWebkit layout-tests in accordance with bug 18976

​https://bugs.webkit.org/show_bug.cgi?id=18976

The test fast/xsl/xslt-text.xml is on our skipped list due to
missing XSLT support in Qt.

May 25, 2008:

7:57 PM ApplicationsGtk edited by alp@atoker.com
Update an entry (diff)
7:29 PM Changeset in webkit [34130] by mrowe@apple.com
  • 4 edits in trunk/WebKit/mac

<rdar://problem/5840884> _recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined

Follow-up for r33052. _recursive_resumeNullEventsForAllNetscapePlugins and _recursive_pauseNullEventsForAllNetscapePlugins
need to be declared in WebFramePrivate.h rather than WebFrameInternal.h so they can be used from outside of WebKit.

Reviewed by Darin Adler.

  • WebView/WebFrame.mm:

(-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
(-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):

  • WebView/WebFrameInternal.h:
  • WebView/WebFramePrivate.h:
4:55 PM Changeset in webkit [34129] by Chris Fleizach
  • 5 edits in trunk/WebCore

<rdar://problem/3582905> elements on separate pages need to be distinct

4:23 PM Changeset in webkit [34128] by mjs@apple.com
  • 4 edits in trunk/WebCore

2008-05-25 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • don't repaint nodes that are removed before layout 4.3% speedup on Acid3 test 26

Mitz points out the new flag can also be used to optimize other
cases of needless repaint such as
<​https://bugs.webkit.org/show_bug.cgi?id=15129>.


  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): If the child has never had a layout, don't bother to repaint it, since there's nothing to dirty.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): Initialize m_everHadLayout to false. (WebCore::RenderObject::setNeedsLayout): Set m_everHadLayout to true if we are being marked as not needing layout.
  • rendering/RenderObject.h:
1:13 PM Changeset in webkit [34127] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/repaint/caret-outside-block.html

  • editing/SelectionController.cpp: (WebCore::repaintRectForCaret): Restored this function which was removed in r28523, but changed it to inflate only the width. (WebCore::SelectionController::caretRepaintRect): Changed back to use repaintRectForCaret(). (WebCore::SelectionController::recomputeCaretRect): Ditto.

LayoutTests:

Reviewed by Darin Adler.

  • fast/repaint/caret-outside-block.html: Added.
  • platform/mac/fast/repaint/caret-outside-block-expected.checksum: Added.
  • platform/mac/fast/repaint/caret-outside-block-expected.png: Added.
  • platform/mac/fast/repaint/caret-outside-block-expected.txt: Added.
7:36 AM Changeset in webkit [34126] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-05-25 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=18940
[CURL] Allow \n as line terminator for headers

The line terminator for message-header fields should be CRLF. However,
it is recommended to recognise as a line terminator also a single LF.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::headerCallback): Allow headers to be terminated by "\n" and not just by "\r\n".
7:14 AM Changeset in webkit [34125] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-05-25 Alp Toker <​alp@nuanti.com>

Reviewed by Niko.

Drop WebView focus when the widget is focused out.

  • webkit/webkitwebview.cpp:
4:30 AM Changeset in webkit [34124] by rwlbuis@webkit.org
  • 2 edits in trunk/LayoutTests

Reviewed by Alexey.

Fix the test.

4:15 AM Changeset in webkit [34123] by jmalonzo@webkit.org
  • 4 edits in trunk

2008-05-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=19142
[Gtk] Remove build options --svg-experimental and --cross-document-messaging

  • configure.ac
  • WebCore/GNUmakefile.am:
3:41 AM Changeset in webkit [34122] by rwlbuis@webkit.org
  • 12 edits in trunk/LayoutTests

RS=Oliver

Fix SVG test results for tiger buildbot.

2:55 AM Changeset in webkit [34121] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-05-25 Sriram Neelakandan <​sriram.neelakandan@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=18935
[Gtk] Plugin Load crashes with NP_FULL mode

Fix crash due to uninitialized variable.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient):
12:46 AM Changeset in webkit [34120] by oliver@apple.com
  • 12 edits in trunk/LayoutTests

Fix leopard results following changes to SVG path dumping.

RS=Alexey

12:35 AM Changeset in webkit [34119] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Fixing a typo in the previous commit made as a last minute change.

  • kjs/regexp_object.cpp:
12:15 AM Changeset in webkit [34118] by ap@webkit.org
  • 4 edits in trunk/JavaScriptCore

Reviewed by Darin.

Changed regular expression matching result array to be lazily filled, because many callers
only care about it being non-null.

2% improvement on Acid3 test 26.

  • kjs/array_instance.cpp: Added a void* member to ArrayStorage for ArrayInstance subclasses to use.
  • kjs/array_instance.h: (KJS::ArrayInstance::lazyCreationData): (KJS::ArrayInstance::setLazyCreationData): Added methods to access it from subclasses.
  • kjs/regexp_object.cpp: (KJS::RegExpMatchesArray::RegExpMatchesArray): (KJS::RegExpMatchesArray::getOwnPropertySlot): (KJS::RegExpMatchesArray::put): (KJS::RegExpMatchesArray::deleteProperty): (KJS::RegExpMatchesArray::getPropertyNames): (KJS::RegExpMatchesArray::fillArrayInstanceIfNeeded): (KJS::RegExpMatchesArray::~RegExpMatchesArray): (KJS::RegExpObjectImp::arrayOfMatches): RegExpMatchesArray is a subclass of ArrayInstance that isn't filled until accessed for the first time.
12:11 AM Changeset in webkit [34117] by rwlbuis@webkit.org
  • 595 edits in trunk

Reviewed by Eric.

​https://bugs.webkit.org/show_bug.cgi?id=18927
Unify path data debug output

Implement unified path data output for Mac svg tests.

Note: See TracTimeline for information about the timeline view.