Timeline
Sep 18, 2008:
- 11:49 PM Changeset in webkit [36662] by
-
- 37 edits in trunk
2008-09-18 Darin Adler <Darin Adler>
Reviewed by Maciej Stachowiak.
- part 1 of https://bugs.webkit.org/show_bug.cgi?id=20858 make each distinct C++ class get a distinct JSC::Structure
- kjs/lookup.h: Removed things here that were used only in WebCore: cacheGlobalObject, JSC_DEFINE_PROTOTYPE, JSC_DEFINE_PROTOTYPE_WITH_PROTOTYPE, and JSC_IMPLEMENT_PROTOTYPE.
WebCore:
2008-09-18 Darin Adler <Darin Adler>
Reviewed by Maciej Stachowiak.
- part 1 of https://bugs.webkit.org/show_bug.cgi?id=20858 make each distinct C++ class get a distinct JSC::Structure
- bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::customPut): Use setDOMException instead of DOMExceptionTranslator.
- bindings/js/JSDOMBinding.cpp: (WebCore::getCachedDOMObjectWrapper): Updated function name. (WebCore::cacheDOMObjectWrapper): Ditto. (WebCore::forgetDOMObject): Ditto. (WebCore::getCachedDOMNodeWrapper): Ditto. (WebCore::forgetDOMNode): Ditto. (WebCore::cacheDOMNodeWrapper): Ditto. (WebCore::forgetAllDOMNodesForDocument): Ditto. (WebCore::markDOMNodesForDocument): Ditto. (WebCore::updateDOMNodeDocument): Ditto. (WebCore::getCachedDOMStructure): Added. (WebCore::createDOMStructure): Ditto.
- bindings/js/JSDOMBinding.h: Get rid of the ScriptInterpreter class and replace the static member functions with non-member functions. Added many other functions for getting at structures, prototypes, wrappers, and creating them. Also moved the cacheGlobalObject function here from JavaScriptCore; eventually I'll remove that once I get rid of the remaining callers. Also removed the DOMExceptionTranslator class.
- bindings/js/JSDOMWindowBase.h: Added JSDOMStructureMap type, and put one of those maps in each window.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::markDOMObjectWrapper): Updated for function name change. (WebCore::JSDOMWindow::mark): Added code to mark all the structures in the structure map.
- bindings/js/JSEventTargetNode.cpp: (WebCore::JSEventTargetNode::JSEventTargetNode): Changed to take a structure instead of a prototype.
- bindings/js/JSEventTargetNode.h: Ditto.
- bindings/js/JSHTMLAllCollection.h: (WebCore::JSHTMLAllCollection::JSHTMLAllCollection): Ditto.
- bindings/js/JSHTMLInputElementBase.cpp: (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): Removed use of the JSC_IMPLEMENT_PROTOTYPE macro, and changed to take a structure instead of a prototype.
- bindings/js/JSHTMLInputElementBase.h: Removed use of the JSC_DEFINE_PROTOTYPE_WITH_PROTOTYPE macro, and changed constructor to take a structure instead of a prototype. Created a dummy prototype class that causes the HTMLInputElement prototype to have the HTMLElement prototype.
- bindings/scripts/CodeGeneratorJS.pm: Change constructors to take structures instead of prototypes. Changed the prototype self function to use the getDOMPrototype function -- later we can eliminate it and have callers invoke getDOMPrototype directly instead. Updated other functions that have name changes. Added code to generate the createPrototype member function. Changed use of cacheGlobalObject to get it from the WebCore namespace instead of the JSC namespace. Changed cacheDOMObject calls to use getDOMObjectWrapper instead.
- dom/Document.cpp: (WebCore::Document::~Document): Updated for name change and also removed unnecessary JSLock use -- there's no need to lock around this.
- dom/Node.cpp: (WebCore::Node::setDocument): Ditto.
- dom/make_names.pl: Changed to use CREATE_DOM_NODE_WRAPPER macro instead of calling new directly.
- bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS): Updated for function name changes and used the CREATE_DOM_OBJECT_WRAPPER macro.
- bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS): Ditto.
- bindings/js/JSCanvasPixelArrayCustom.cpp: (WebCore::toJS): Ditto.
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark): Ditto. (WebCore::toJS): Ditto.
- bindings/js/JSElementCustom.cpp: (WebCore::toJSNewlyCreated): Ditto.
- bindings/js/JSEventCustom.cpp: (WebCore::toJS): Ditto.
- bindings/js/JSEventTargetBase.cpp: (WebCore::jsEventTargetDispatchEvent): Use setDOMException instead of DOMExceptionTranslator. (WebCore::toJS): Updated for function name changes and used the CREATE_DOM_OBJECT_WRAPPER macro.
- bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS): Ditto.
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::mark): Ditto. (WebCore::createWrapper): Ditto. (WebCore::toJS): Ditto.
- bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS): Ditto.
- bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS): Ditto. (WebCore::JSStyleSheet::mark): Ditto.
- bindings/js/JSTextCustom.cpp: (WebCore::toJSNewlyCreated): Ditto.
- bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::constructXMLHttpRequest): Ditto.
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::mark): Ditto.
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::mark): Ditto.
- bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::constructXSLTProcessor): Ditto.
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::finishedWithEvent): Ditto.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously): Ditto. (WebCore::XMLHttpRequest::dropProtection): Ditto.
LayoutTests:
2008-09-18 Darin Adler <Darin Adler>
Reviewed by Maciej Stachowiak.
- platform/mac/fast/dom/wrapper-classes-expected.txt: Update results to reflect correct prototype for CSSStyleRule.
- 11:48 PM Changeset in webkit [36661] by
-
- 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj
Fix conflict inXCode file.
- 11:32 PM Changeset in webkit [36660] by
-
- 8 edits in trunk/JavaScriptCore
2008-09-18 Darin Adler <Darin Adler>
Reviewed by Maciej Stachowiak.
- https://bugs.webkit.org/show_bug.cgi?id=20927 simplify/streamline the code to turn strings into identifiers while parsing
- kjs/grammar.y: Get rid of string from the union, and use ident for STRING as well as for IDENT.
- kjs/lexer.cpp: (JSC::Lexer::lex): Use makeIdentifier instead of makeUString for String.
- kjs/lexer.h: Remove makeUString.
- kjs/nodes.h: Changed StringNode to hold an Identifier instead of UString.
- VM/CodeGenerator.cpp: (JSC::keyForCharacterSwitch): Updated since StringNode now holds an Identifier. (JSC::prepareJumpTableForStringSwitch): Ditto.
- kjs/nodes.cpp: (JSC::StringNode::emitCode): Ditto. The comment from here is now in the lexer. (JSC::processClauseList): Ditto.
- kjs/nodes2string.cpp: (JSC::StringNode::streamTo): Ditto.
- 11:30 PM Changeset in webkit [36659] by
-
- 8 edits in trunk/WebCore
2008-09-18 David Hyatt <hyatt@apple.com>
This patch gets a viewless scrollbar working on Mac. It is turned off
by default. Hit testing works. For now the scrollbar just paints ugly
debug rects in the place of the buttons, track and thumb. It does match
Aqua metrics though.
Reviewed by Sam Weinig
- WebCore.xcodeproj/project.pbxproj:
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMousePressEventToScrollbar):
- platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint): (WebCore::ScrollbarThemeComposite::trackPosition):
- platform/ScrollbarThemeComposite.h:
- platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::addChild):
- platform/mac/ScrollbarThemeMac.cpp: (WebCore::): (WebCore::ScrollbarThemeMac::hasButtons): (WebCore::ScrollbarThemeMac::hasThumb): (WebCore::buttonRepaintRect): (WebCore::ScrollbarThemeMac::backButtonRect): (WebCore::ScrollbarThemeMac::forwardButtonRect): (WebCore::trackRepaintRect): (WebCore::ScrollbarThemeMac::trackRect): (WebCore::ScrollbarThemeMac::minimumThumbLength): (WebCore::ScrollbarThemeMac::shouldCenterOnThumb): (WebCore::ScrollbarThemeMac::paintTrack): (WebCore::ScrollbarThemeMac::paintButton): (WebCore::ScrollbarThemeMac::paintThumb):
- platform/mac/ScrollbarThemeMac.h: (WebCore::ScrollbarThemeMac::supportsControlTints):
- platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::trackPosition):
- 11:13 PM Changeset in webkit [36658] by
-
- 2 edits in trunk/WebCore
2008-09-18 Collin Jackson <collinj@webkit.org>
Build fix; added missing header file to GNUmakefile.am
- GNUmakefile.am:
- 10:54 PM Changeset in webkit [36657] by
-
- 1 edit in trunk/WebCore/platform/mac/ScrollViewMac.mm
Fix Mac release build bustage.
- 10:53 PM Changeset in webkit [36656] by
-
- 1 edit in trunk/WebCore/platform/mac/ScrollViewMac.mm
Fix Mac release build bustage.
- 10:52 PM Changeset in webkit [36655] by
-
- 2 edits in trunk/WebKitTools
2008-09-18 Darin Adler <Darin Adler>
- Scripts/do-webcore-rename: More renaming plans.
- 10:24 PM Changeset in webkit [36654] by
-
- 2 edits in trunk/LayoutTests
2008-09-18 Collin Jackson <collinj@webkit.org>
Reviewed by Antti Koivisto and Mark Rowe.
This is correct expected output for the DNS prefetch control
layout test I just checked in.
- http/tests/misc/dns-prefetch-control-expected.txt:
- 9:56 PM Changeset in webkit [36653] by
-
- 5 edits5 moves in trunk/WebCore
2008-09-18 Sam Weinig <sam@webkit.org>
Reviewed by David "the Hair" Hyatt.
Move DataRef, SVGRenderStyle and SVGRenderStyleDefs in render/style.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/DataRef.h: Removed.
- rendering/SVGRenderStyle.cpp: Removed.
- rendering/SVGRenderStyle.h: Removed.
- rendering/SVGRenderStyleDefs.cpp: Removed.
- rendering/SVGRenderStyleDefs.h: Removed.
- rendering/style/DataRef.h: Copied from rendering/DataRef.h.
- rendering/style/SVGRenderStyle.cpp: Copied from rendering/SVGRenderStyle.cpp.
- rendering/style/SVGRenderStyle.h: Copied from rendering/SVGRenderStyle.h.
- rendering/style/SVGRenderStyleDefs.cpp: Copied from rendering/SVGRenderStyleDefs.cpp.
- rendering/style/SVGRenderStyleDefs.h: Copied from rendering/SVGRenderStyleDefs.h.
- 9:47 PM Changeset in webkit [36652] by
-
- 21 edits in trunk
Clear the main frame's name between tests to get more consistent test results
when running the WebKit tests with --nthly.
Reviewed by Dan Bernstein.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):
Add SPI to WebView to allow DRT to clear the main frame's name between tests.
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp:
(WebView::clearMainFrameName):
- WebView.h:
Add SPI to WebView to allow DRT to clear the main frame's name between tests.
- WebView/WebView.mm:
(-[WebView _clearMainFrameName]):
- WebView/WebViewPrivate.h:
Add a means of clearing a FrameTree's name.
- WebCore.base.exp:
- page/FrameTree.cpp:
(WebCore::FrameTree::clearName):
- page/FrameTree.h:
Update test results now that frame tree names are cleared between tests.
- fast/events/onunload-clears-onbeforeunload-expected.txt:
- fast/events/onunload-expected.txt:
- fast/events/onunload-not-on-body-expected.txt:
- fast/events/onunload-window-property-expected.txt:
- fast/forms/button-state-restore-expected.txt:
- fast/forms/form-and-frame-interaction-retains-values-expected.txt:
- 9:30 PM Changeset in webkit [36651] by
-
- 4 edits in trunk/WebCore
2008-09-18 David Hyatt <hyatt@apple.com>
Eliminate addToSuperview from Widget, since it was only called
by ScrollViewMac's addChild method. Just shift the original body
of addToSuperView into addChild.
Reviewed by Sam Weinig
- platform/Widget.h:
- platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::addChild):
- platform/mac/WidgetMac.mm:
- 9:15 PM Changeset in webkit [36650] by
-
- 14 edits5 adds in trunk
- 9:01 PM Changeset in webkit [36649] by
-
- 4 edits in trunk/WebCore
2008-09-18 David Hyatt <hyatt@apple.com>
Eliminate the convertToScreenCoordinate method on Widget, since
ScrollView has redundant methods that already do the same thing.
Reviewed by Sam Weinig
- editing/mac/SelectionControllerMac.mm: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- platform/Widget.h:
- platform/mac/WidgetMac.mm: (WebCore::Widget::containingWindow):
- 8:18 PM Changeset in webkit [36648] by
-
- 1 edit in trunk/WebCore/platform/Scrollbar.cpp
Fix Qt warning.
- 8:16 PM Changeset in webkit [36647] by
-
- 9 edits in trunk/WebCore
2008-09-18 David Hyatt <hyatt@apple.com>
Move to only one constructor for Widgets. Rename data to m_data and make
it have an #ifdef only for platforms that have platform-specific data (Mac
and Gtk).
Reviewed by Sam Weinig
- WebCore.base.exp:
- platform/Widget.cpp: (WebCore::Widget::init):
- platform/Widget.h:
- platform/gtk/WidgetGtk.cpp: (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::cursor): (WebCore::Widget::setCursor):
- platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::addToSuperview): (WebCore::Widget::removeFromSuperview): (WebCore::Widget::beforeMouseDown): (WebCore::Widget::afterMouseDown):
- platform/qt/WidgetQt.cpp: (WebCore::Widget::Widget):
- platform/win/WidgetWin.cpp: (WebCore::Widget::Widget):
- platform/wx/WidgetWx.cpp: (WebCore::Widget::Widget):
- 8:04 PM Changeset in webkit [36646] by
-
- 1 edit in trunk/WebCore/platform/Widget.cpp
Fix Qt/Win/Gtk bustage.
- 8:01 PM Changeset in webkit [36645] by
-
- 8 edits in trunk/WebCore
2008-09-18 David Hyatt <hyatt@apple.com>
Move Qt's isNPAPIPlugin boolean from Widget down to PluginView, since there
was no reason for it to be on Widget. This change eliminates Qt ifdefs
from Widget.
Reviewed by Sam Weinig
- bindings/js/ScriptControllerQt.cpp: (WebCore::ScriptController::createScriptInstanceForWidget):
- platform/qt/WidgetQt.cpp: (WebCore::WidgetPrivate::WidgetPrivate): (WebCore::WidgetPrivate::~WidgetPrivate): (WebCore::Widget::Widget): (WebCore::Widget::~Widget):
- plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
- plugins/PluginView.h: (WebCore::PluginView::isNPAPIPlugin): (WebCore::PluginView::setIsNPAPIPlugin):
- 7:53 PM Changeset in webkit [36644] by
-
- 1 edit1 add in trunk/WebKitSite
2008-09-18 Maciej Stachowiak <mjs@apple.com>
Not reviewed.
- blog-files/animation-demo.svg: Added.
- 7:36 PM Changeset in webkit [36643] by
-
- 4 edits in trunk/WebCore
2008-09-18 David Hyatt <hyatt@apple.com>
Make geometryChanged() cross-platform on Widget. GTK and WIN platform
ifdefs are now gone from Widget!
Reviewed by Sam Weinig
- platform/Widget.h: (WebCore::Widget::geometryChanged):
- platform/gtk/WidgetGtk.cpp:
- platform/qt/WidgetQt.cpp:
- 7:29 PM Changeset in webkit [36642] by
-
- 12 edits in trunk/WebCore
2008-09-18 David Hyatt <hyatt@apple.com>
Consolidate convertTo/FromContainingWindow methods so that all platforms
but Mac share the same code.
Move convertSelfToChild and convertChildToSelf to ScrollView, since
Widget should know nothing about children. Make the methods cross-platform
on ScrollView.
Reviewed by Sam Weinig
- platform/ScrollView.h: (WebCore::ScrollView::convertChildToSelf): (WebCore::ScrollView::convertSelfToChild):
- platform/Widget.cpp: (WebCore::Widget::convertToContainingWindow): (WebCore::Widget::convertFromContainingWindow):
- platform/Widget.h: (WebCore::Widget::geometryChanged):
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::isScrollViewScrollbar):
- platform/gtk/WidgetGtk.cpp:
- platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::isScrollViewScrollbar):
- platform/mac/WidgetMac.mm:
- platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::isScrollViewScrollbar):
- platform/qt/WidgetQt.cpp:
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::isScrollViewScrollbar):
- platform/win/WidgetWin.cpp:
- 6:51 PM Changeset in webkit [36641] by
-
- 1 edit1 add in trunk/WebKitSite
2008-09-18 Maciej Stachowiak <mjs@apple.com>
Not reviewed.
- blog-files/sfx-perf.png: Added.
- 6:34 PM Changeset in webkit [36640] by
-
- 2 edits in trunk/JavaScriptCore
2008-09-18 Sam Weinig <sam@webkit.org>
Fix style.
- VM/Instruction.h: (JSC::Instruction::Instruction):
- 6:00 PM Changeset in webkit [36639] by
-
- 2 edits in trunk/WebCore
[qt] Build fixes after the Widget/ScrollView cleanup
topLevel() is now root()
- 5:51 PM Changeset in webkit [36638] by
-
- 2 edits in trunk/WebCore/platform
Fix WIndows bustage.
- 5:46 PM Changeset in webkit [36637] by
-
- 2 edits in trunk/JavaScriptCore
Bug 20911: REGRESSION(r36480?): Reproducible assertion failure below derefStructureIDs 64-bit JavaScriptCore
<https://bugs.webkit.org/show_bug.cgi?id=20911>
Reviewed by Maciej Stachowiak.
The problem was simply caused by the int constructor for Instruction
failing to initialise the full struct in 64bit builds.
- 5:39 PM Changeset in webkit [36636] by
-
- 4 edits in trunk/WebCore
2008-09-18 David Hyatt <hyatt@apple.com>
Make the conversion methods that go to and from some containingWindow
cross-platform. Implement them on Mac.
Reviewed by Sam Weinig
- platform/Widget.h: (WebCore::Widget::setContainingWindow):
- platform/mac/WidgetMac.mm: (WebCore::Widget::convertFromContainingWindow): (WebCore::Widget::convertToContainingWindow):
- 5:28 PM Changeset in webkit [36635] by
-
- 5 edits in trunk/WebCore
2008-09-18 Sam Weinig <sam@webkit.org>
Rubber-stamped by David "Yeah-yeah" Hyatt.
Cleanup RenderStyle.
- WebCore.xcodeproj/project.pbxproj:
- rendering/style/CounterContent.h:
- rendering/style/RenderStyle.cpp:
- rendering/style/RenderStyle.h:
- 5:01 PM Changeset in webkit [36634] by
-
- 15 edits in trunk/WebCore
2008-09-18 Chris Marrin <cmarrin@apple.com>
Reviewed by Sam Weinig
Fixed https://bugs.webkit.org/show_bug.cgi?id=20908
Now TransformOperations and AnimationList no longer
inherit from Vector<> but rather have API to access.
- css/CSSComputedStyleDeclaration.cpp:
- css/CSSStyleSelector.cpp:
- page/animation/AnimationBase.cpp:
- page/animation/CompositeAnimation.cpp:
- page/animation/ImplicitAnimation.cpp:
- page/animation/KeyframeAnimation.cpp:
- rendering/RenderLayer.cpp:
- rendering/style/AnimationList.cpp:
- rendering/style/AnimationList.h:
- rendering/style/RenderStyle.cpp:
- rendering/style/RenderStyle.h:
- rendering/style/TransformOperations.cpp:
- rendering/style/TransformOperations.h:
- 4:47 PM Changeset in webkit [36633] by
-
- 2 edits in trunk/JavaScriptCore
2008-09-18 Darin Adler <Darin Adler>
- fix release build
- wtf/RefCountedLeakCounter.cpp: Removed stray "static".
- 4:34 PM Changeset in webkit [36632] by
-
- 2 edits in trunk/JavaScriptCore
2008-09-18 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
- kjs/JSGlobalObject.h: Tiny style guideline tweak.
- 4:30 PM Changeset in webkit [36631] by
-
- 7 edits in trunk
2008-09-18 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
- fix https://bugs.webkit.org/show_bug.cgi?id=20925 LEAK messages appear every time I quit
- JavaScriptCore.exp: Updated, and also added an export needed for future WebCore use of JSC::StructureID.
- wtf/RefCountedLeakCounter.cpp: (WTF::RefCountedLeakCounter::suppressMessages): Added. (WTF::RefCountedLeakCounter::cancelMessageSuppression): Added. (WTF::RefCountedLeakCounter::RefCountedLeakCounter): Tweaked a bit. (WTF::RefCountedLeakCounter::~RefCountedLeakCounter): Added code to log the reason there was no leak checking done. (WTF::RefCountedLeakCounter::increment): Tweaked a bit. (WTF::RefCountedLeakCounter::decrement): Ditto.
- wtf/RefCountedLeakCounter.h: Replaced setLogLeakMessages with two new functions, suppressMessages and cancelMessageSuppression. Also added m_ prefixes to the data member names.
2008-09-18 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
- fix https://bugs.webkit.org/show_bug.cgi?id=20925 LEAK messages appear every time I quit
- WebView/WebPreferences.mm: (-[WebPreferences setFullDocumentTeardownEnabled:]): Removed unneeded call to setLogLeakMessages.
- WebView/WebView.mm: (-[WebView _closeWithFastTeardown]): Call RefCountedLeakCounter::suppressMessages, telling it that we can't track leaks because at least one WebView was closed with fast teardown. (-[WebView _close]): Removed unneeded call to setLogLeakMessages. Added a call to cancelMessageSuppression since the WebView is no longer open. Added an explicit garbage collect to help with the case where we're closing during the quit process -- the garbageCollectSoon() calls done inside WebCore won't help us in that case. (-[WebView initWithFrame:frameName:groupName:]): Call RefCountedLeakCounter::suppressMessages telling it that we can't track leaks because at least one WebView is currently open.
- 4:28 PM Changeset in webkit [36630] by
-
- 10 edits2 copies in trunk
JavaScriptCore
2008-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Mark Rowe.
Add a proper #define to define which XML Parser implementation to use. Client
code can use #if USE(QXMLSTREAM) to decide if the Qt XML StreamReader
implementation is going to be used.
- wtf/Platform.h:
WebCore
2008-09-18 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Mark Rowe.
XMLTokenizer.cpp used to contain two different implementations. One was using
libxml2 and the other was using the Qt XML StreamReader. Clean up the code by
separating the two implementations from each other.
Common code and some small bits are kept inside the XMLTokenizer.cpp, the Qt code
was moved to XMLTokenizerQt.cpp and the Libxml2 based code was moved to
XMLTokenizerLibxml2.cpp. There should be no functional changes.
Attempt to add XMLTokenizerLibxml2.cpp to every buildsystem so the build continues
to work.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- dom/XMLTokenizer.cpp: (WebCore::isScriptElement): (WebCore::castToScriptElement): (WebCore::XMLTokenizer::setCurrentNode): (WebCore::XMLTokenizer::write): (WebCore::XMLTokenizer::eventuallyMarkAsParserCreated): (WebCore::XMLTokenizer::enterText): (WebCore::toString): (WebCore::XMLTokenizer::exitText): (WebCore::XMLTokenizer::end): (WebCore::XMLTokenizer::insertErrorMessageBlock):
- dom/XMLTokenizer.h: (WebCore::XMLTokenizer::wellFormed):
- dom/XMLTokenizerLibxml2.cpp: Copied from WebCore/dom/XMLTokenizer.cpp. (WebCore::createMemoryParser): (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::XMLTokenizer::~XMLTokenizer): (WebCore::XMLTokenizer::doWrite): (WebCore::ignorableWhitespaceHandler): (WebCore::XMLTokenizer::initializeParserContext): (WebCore::XMLTokenizer::doEnd): (WebCore::XMLTokenizer::lineNumber): (WebCore::XMLTokenizer::columnNumber): (WebCore::XMLTokenizer::stopParsing): (WebCore::XMLTokenizer::resumeParsing): (WebCore::parseXMLDocumentFragment): (WebCore::attributesStartElementNsHandler): (WebCore::parseAttributes):
- dom/XMLTokenizerQt.cpp: Copied from WebCore/dom/XMLTokenizer.cpp. (WebCore::EntityResolver::resolveUndeclaredEntity): (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::XMLTokenizer::~XMLTokenizer): (WebCore::XMLTokenizer::doWrite): (WebCore::XMLTokenizer::initializeParserContext): (WebCore::XMLTokenizer::doEnd): (WebCore::XMLTokenizer::lineNumber): (WebCore::XMLTokenizer::columnNumber): (WebCore::XMLTokenizer::stopParsing): (WebCore::XMLTokenizer::resumeParsing): (WebCore::parseXMLDocumentFragment): (WebCore::attributesStartElementNsHandler): (WebCore::parseAttributes): (WebCore::):
- 4:08 PM Changeset in webkit [36629] by
-
- 2 edits in trunk/WebCore
2008-09-18 Beth Dakin <Beth Dakin>
Reviewed by Geoff Garen.
Build fix for non-Mac builds.
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
- 4:07 PM Changeset in webkit [36628] by
-
- 7 edits in trunk/WebCore
2008-09-18 Peter Kasting <pkasting@google.com>
Reviewed by hyatt. Landed by eseidel.
https://bugs.webkit.org/show_bug.cgi?id=20745
Animated GIFs do not animate properly with (at least) CG.
- WebCore\platform\graphics\BitmapImage.cpp:
- WebCore\platform\graphics\BitmapImage.h:
- WebCore\platform\graphics\cairo\ImageCairo.cpp:
- WebCore\platform\graphics\cg\ImageCG.cpp:
- WebCore\platform\graphics\qt\ImageQt.cpp:
- WebCore\platform\graphics\wx\ImageWx.cpp:
- 3:54 PM Changeset in webkit [36627] by
-
- 11 edits3 adds in trunk
<rdar://problem/6224222> AX: should not expose a <table> as an AXTable if ARIA role specifies otherwise
If a <table> tag has an aria role, it should not appear as an AXTable
Likewise, it's rows and cells should not appear as AXRow or AXCell
- 3:29 PM Changeset in webkit [36626] by
-
- 2 edits in trunk/WebCore
Use higher-resolution timers on all variants of Windows.
Reviewed by Darin Adler.
- platform/win/SharedTimerWin.cpp: (WebCore::setSharedTimerFireTime):
- 3:21 PM Changeset in webkit [36625] by
-
- 8 edits in trunk/WebCore
2008-09-18 David Hyatt <hyatt@apple.com>
Make containingWindow() and setContainingWindow() cross-platform.
Add a root() function cross-platform so Qt doesn't have to
define its own.
Reviewed by Darin Adler
- platform/Widget.cpp: (WebCore::Widget::root):
- platform/Widget.h: (WebCore::Widget::setContainingWindow):
- platform/gtk/WidgetGtk.cpp: (WebCore::Widget::Widget): (WebCore::Widget::containingWindow):
- platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild):
- platform/mac/WidgetMac.mm: (WebCore::Widget::containingWindow):
- platform/qt/WidgetQt.cpp: (WebCore::Widget::invalidateRect): (WebCore::Widget::containingWindow):
- platform/win/WidgetWin.cpp: (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::containingWindow):
- 3:18 PM Changeset in webkit [36624] by
-
- 5 edits2 adds in trunk
WebCore:
2008-09-18 Beth Dakin <Beth Dakin>
Reviewed by Dave Hyatt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=20515 Crash upon
parsing CSS: unicode-range: searchfield-cancel-buttonpt=-webkit-
dashboard-region=
and corresponding: <rdar://problem/6174100>
This patch makes CSSParserValue::createCSSValue handle unknown
identifiers.
- css/CSSParserValues.cpp: (WebCore::CSSParserValue::createCSSValue): If we have an identifier with no id (an unknown identifier) create a CSSPrimitiveValue of type CSS_PARSER_IDENTIFIER
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText): (WebCore::CSSPrimitiveValue::parserValue):
- css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::):
LayoutTests:
2008-09-18 Beth Dakin <Beth Dakin>
Reviewed by Dave Hyatt.
Test for https://bugs.webkit.org/show_bug.cgi?id=20515 Crash upon
parsing CSS: unicode-range: searchfield-cancel-buttonpt=-webkit-
dashboard-region=
and corresponding: <rdar://problem/6174100>
- fast/css/variables/invalid-identifier-expected.txt: Added.
- fast/css/variables/invalid-identifier.html: Added.
- 2:46 PM Changeset in webkit [36623] by
-
- 8 edits9 copies in trunk/WebCore
2008-09-18 Sam Weinig <sam@webkit.org>
Rubber-stamped by David "I'd prefer not" Hyatt.
More the remaining class out of RenderStyle.h/cpp
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- rendering/style/CursorData.h: Copied from rendering/style/RenderStyle.h. (WebCore::CursorData::CursorData): (WebCore::CursorData::operator==): (WebCore::CursorData::operator!=):
- rendering/style/CursorList.h: Copied from rendering/style/RenderStyle.h. (WebCore::CursorList::operator[]): (WebCore::CursorList::CursorList):
- rendering/style/RenderStyle.cpp:
- rendering/style/RenderStyle.h: (WebCore::RenderStyle::deref): (WebCore::RenderStyle::hasOneRef): (WebCore::RenderStyle::InheritedFlags::operator!=): (WebCore::RenderStyle::NonInheritedFlags::operator!=): (WebCore::RenderStyle::hasBackground): (WebCore::RenderStyle::outlineWidth): (WebCore::RenderStyle::autoWrap): (WebCore::RenderStyle::preserveNewline): (WebCore::RenderStyle::collapseWhiteSpace): (WebCore::RenderStyle::isCollapsibleWhiteSpace): (WebCore::RenderStyle::breakOnlyAfterWhiteSpace): (WebCore::RenderStyle::breakWords): (WebCore::RenderStyle::outlineOffset): (WebCore::RenderStyle::setLeft): (WebCore::RenderStyle::setRight): (WebCore::RenderStyle::setTop): (WebCore::RenderStyle::setBottom): (WebCore::RenderStyle::setDashboardRegion): (WebCore::RenderStyle::setBackgroundColor): (WebCore::RenderStyle::setBorderImage): (WebCore::RenderStyle::setBorderRadius): (WebCore::RenderStyle::setFontDescription): (WebCore::RenderStyle::adjustBackgroundLayers): (WebCore::RenderStyle::adjustMaskLayers): (WebCore::RenderStyle::deleteBindingURIs): (WebCore::RenderStyle::inheritBindingURIs): (WebCore::RenderStyle::isDisplayReplacedType): (WebCore::RenderStyle::isDisplayInlineType): (WebCore::RenderStyle::isOriginalDisplayInlineType):
- rendering/style/StyleInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/StyleInheritedData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleInheritedData::operator!=):
- rendering/style/StyleRareInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/StyleRareInheritedData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleRareInheritedData::operator!=):
- rendering/style/StyleRareNonInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/StyleRareNonInheritedData.h: Copied from rendering/style/RenderStyle.h.
- rendering/style/StyleReflection.h: Copied from rendering/style/RenderStyle.h.
- 2:29 PM Changeset in webkit [36622] by
-
- 1 edit in trunk/WebCore/platform/Scrollbar.cpp
Fix Mac bustage.
- 1:24 PM Changeset in webkit [36621] by
-
- 7 edits in trunk/WebCore
2008-09-18 David Hyatt <hyatt@apple.com>
Move the concept of suppression invalidation on Widgets to Scrollbar
instead. Since this is only used by Scrollbars, there is no need for
it to be on Widget.
Reviewed by Sam Weinig
- platform/Scrollbar.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::invalidateRect):
- platform/Scrollbar.h: (WebCore::Scrollbar::suppressInvalidation): (WebCore::Scrollbar::setSuppressInvalidation):
- platform/Widget.h:
- platform/gtk/WidgetGtk.cpp: (WebCore::Widget::Widget): (WebCore::Widget::invalidateRect):
- platform/qt/WidgetQt.cpp: (WebCore::WidgetPrivate::WidgetPrivate): (WebCore::Widget::invalidateRect):
- platform/win/WidgetWin.cpp: (WebCore::Widget::Widget): (WebCore::Widget::invalidateRect):
- 1:09 PM Changeset in webkit [36620] by
-
- 8 edits in trunk/WebCore
2008-09-18 David Hyatt <hyatt@apple.com>
Make invalidate() on Widget non-virtual and make it just call
invalidateRect() on the boundsGeometry() of the Widget.
Reviewed by Dan Bernstein
- platform/Widget.h: (WebCore::Widget::boundsGeometry): (WebCore::Widget::invalidate):
- platform/gtk/WidgetGtk.cpp:
- platform/mac/WidgetMac.mm:
- platform/qt/WidgetQt.cpp:
- platform/win/WidgetWin.cpp:
- platform/wx/WidgetWx.cpp:
- 12:40 PM Changeset in webkit [36619] by
-
- 14 edits18 copies in trunk/WebCore
2008-09-18 Sam Weinig <sam@webkit.org>
Rubber-stamped in exile by David Hyatt.
Split Animation, AnimationList, BindingURI, ContentData, CounterContent,
KeyframeList, ShadowData, StyleFlexibleBoxData and TimingFunction out of
RenderStyle.h/cpp
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- css/CSSStyleSelector.cpp:
- css/CSSStyleSelector.h:
- page/animation/CompositeAnimation.cpp:
- page/animation/KeyframeAnimation.cpp:
- page/animation/KeyframeAnimation.h:
- rendering/RenderCounter.h:
- rendering/style/Animation.cpp: Copied from rendering/style/RenderStyle.cpp. (WebCore::Animation::~Animation): (WebCore::Animation::animationsMatch): (WebCore::Animation::keyframeList): (WebCore::Animation::setAnimationKeyframe):
- rendering/style/Animation.h: Copied from rendering/style/RenderStyle.h.
- rendering/style/AnimationList.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/AnimationList.h: Copied from rendering/style/RenderStyle.h.
- rendering/style/BindingURI.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/BindingURI.h: Copied from rendering/style/RenderStyle.h. (WebCore::BindingURI::operator!=):
- rendering/style/ContentData.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/ContentData.h: Copied from rendering/style/RenderStyle.h. (WebCore::ContentData::ContentData): (WebCore::ContentData::~ContentData):
- rendering/style/CounterContent.h: Copied from rendering/style/RenderStyle.h. (WebCore::CounterContent::CounterContent):
- rendering/style/CounterDirectives.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/CounterDirectives.h: Copied from rendering/style/RenderStyle.h. (WebCore::CounterDirectives::CounterDirectives):
- rendering/style/KeyframeList.cpp: Copied from rendering/style/RenderStyle.cpp. (WebCore::KeyframeList::insert):
- rendering/style/KeyframeList.h: Copied from rendering/style/RenderStyle.h. (WebCore::KeyframeValue::KeyframeValue): (WebCore::KeyframeList::create): (WebCore::KeyframeList::KeyframeList):
- rendering/style/RenderStyle.cpp:
- rendering/style/RenderStyle.h:
- rendering/style/ShadowData.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/ShadowData.h: Copied from rendering/style/RenderStyle.h. (WebCore::ShadowData::ShadowData): (WebCore::ShadowData::~ShadowData): (WebCore::ShadowData::operator!=):
- rendering/style/StyleFlexibleBoxData.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/StyleFlexibleBoxData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleFlexibleBoxData::operator!=):
- rendering/style/TimingFunction.h: Copied from rendering/style/RenderStyle.h. (WebCore::TimingFunction::TimingFunction): (WebCore::TimingFunction::operator==):
- 11:49 AM Changeset in webkit [36618] by
-
- 2 edits in trunk/WebCore
2008-09-18 Adele Peterson <adele@apple.com>
Reviewed by Dan Bernstein.
Fix RenderStyle leaks.
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createSubtreeIfNeeded):
- 11:30 AM Changeset in webkit [36617] by
-
- 3 edits in trunk/WebKit/mac
2008-09-18 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Move the remainder of the stream ivars to the C++ object.
- Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::WebNetscapePluginStream):
- Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream _pluginCancelledConnectionError]): (-[WebBaseNetscapePluginStream initWithFrameLoader:]): (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]): (-[WebBaseNetscapePluginStream setPlugin:]): (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): (-[WebBaseNetscapePluginStream start]): (-[WebBaseNetscapePluginStream stop]): (-[WebBaseNetscapePluginStream wantsAllStreams]): (-[WebBaseNetscapePluginStream _destroyStream]): (-[WebBaseNetscapePluginStream _destroyStreamWithReason:]): (-[WebBaseNetscapePluginStream cancelLoadWithError:]): (-[WebBaseNetscapePluginStream _deliverData]):
- 11:03 AM Changeset in webkit [36616] by
-
- 2 edits in trunk/WebCore
2008-09-18 Kevin McCullough <kmccullough@apple.com>
Accidentally checked in code.
- html/HTMLElementFactory.cpp: (WebCore::frameConstructor): (WebCore::iframeConstructor):
- 10:21 AM Changeset in webkit [36615] by
-
- 4 edits1 add in trunk/WebCore
2008-09-18 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/5722310> gracefully handle too many console messages
(20904)
- Keep track of the most previous message and then compare it to the subsequent messages as they come in. If there are multiple of the same message create a count that indicates the current number.
- manual-tests/inspector/multiple-console-messages.html: Added.
- page/inspector/Console.js:
- page/inspector/inspector.css:
- 9:00 AM ProposedWebInspectorRearchitecting edited by
- WebKit -> WebCore rename (diff)
- 4:50 AM Changeset in webkit [36614] by
-
- 3 edits in trunk/WebCore
2008-09-18 Jonathon Jongsma <jonathon@quotidian.org>
Reviewed by Alp Toker
https://bugs.webkit.org/show_bug.cgi?id=20830
[GTK] Don't use deprecated pango API
Replace deprecated pango functions with non-deprecated ones for newer
versions of pango
- platform/graphics/gtk/FontGtk.cpp: (WebCore::getDefaultPangoLayout):
- platform/graphics/gtk/FontPlatformDataPango.cpp: (WebCore::FontPlatformData::FontPlatformData):
- 2:39 AM Changeset in webkit [36613] by
-
- 2 edits in trunk/WebKitTools
2008-09-18 Stephanie Lewis <Stephanie Lewis>
Really fix tiger jsc tests.
- Scripts/run-javascriptcore-tests:
- 2:35 AM Changeset in webkit [36612] by
-
- 3 edits in trunk/JavaScriptCore
2008-09-18 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Make a Unicode non-breaking space count as a whitespace character in
PCRE. This change was already made in WREC, and it fixes one of the
Mozilla JS tests. Since it is now fixed in PCRE as well, we can check
in a new set of expected test results.
- pcre/pcre_internal.h: (isSpaceChar):
- tests/mozilla/expected.html:
- 2:13 AM Changeset in webkit [36611] by
-
- 3 edits in trunk/WebKitTools
2008-09-18 Stephanie Lewis <Stephanie Lewis>
Reviewed by Maciej Stachowiak.
Fix jsc tests on Tiger. Make jsc tests smarter about when to use the arch flag.
- Scripts/run-javascriptcore-tests:
- Scripts/webkitdirs.pm:
- 1:10 AM Changeset in webkit [36610] by
-
- 2 edits in trunk/WebCore
2008-09-18 Alp Toker <alp@nuanti.com>
Build fix for r36587. Add new sources (and sort the lists).
- GNUmakefile.am:
- 12:48 AM Changeset in webkit [36609] by
-
- 2 edits in trunk/WebKitTools
Print warning to stdout rather than stderr when a test attempts to access a remote resource.
This should make it more obvious when a test does this, as stderr output tends to be obscured
by noise in the test results.
Also fixes some coding style issues in ResourceLoadDelegate.mm.
Rubber-stamped by Sam Weinig.
- DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[NSError _drt_descriptionSuitableForTestResult]):
(-[NSURL _drt_descriptionSuitableForTestResult]):
(-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
(-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
(-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
(-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
(-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
(-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
- 12:48 AM Changeset in webkit [36608] by
-
- 2 edits in trunk/LayoutTests
Change test to not attempt to access a remote host. This stops
DRT from printing a warning to stderr while running this test.
Rubber-stamped by Sam Weinig.
- fast/loader/cancel-load-during-port-block-timer.html:
- 12:43 AM Changeset in webkit [36607] by
-
- 4 edits in trunk
2008-09-18 Stephanie Lewis <Stephanie Lewis>
Reviewed by Mark Rowe and Maciej Stachowiak.
add an option use arch to specify which architecture to run.
- tests/mozilla/jsDriver.pl:
add a --64-bit option and specify which architecture to run on Mac.
- Scripts/run-javascriptcore-tests:
- 12:09 AM Changeset in webkit [36606] by
-
- 6 edits1 add in trunk/WebKitTools
Fix a crash seen running DumpRenderTree on fast/dom/null-document-window-open-crash.html under guard malloc.
Reviewed by Sam Weinig.
The JS wrapper for LayoutTestController could outlive the wrapped instance, and would crash when
attempting to access the wrapped instance within layoutTestControllerObjectFinalize. We fix this by making
LayoutTestController ref-counted to ensure that it is not outlived by the JS wrapper.
- DumpRenderTree/ForwardingHeaders/wtf/RefCounted.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefCounted.h.
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(notifyDoneCallback): Remove code that is no longer needed now that we must always have a wrapped instance.
(layoutTestControllerObjectFinalize): Deref the wrapped object.
(LayoutTestController::makeWindowObject): Ref the wrapped object.
- DumpRenderTree/LayoutTestController.h: Make LayoutTestController RefCounted.
- DumpRenderTree/mac/DumpRenderTree.mm:
(runTest): Deref the LayoutTestController object rather than explicitly deleting it.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: Remove code that is no longer needed.
- DumpRenderTree/win/DumpRenderTree.cpp:
(runTest): Deref the LayoutTestController object rather than explicitly deleting it.
Sep 17, 2008:
- 11:45 PM Changeset in webkit [36605] by
-
- 2 edits in trunk/JavaScriptCore
2008-09-17 Oliver Hunt <oliver@apple.com>
Correctly restore argument reference prior to SFX runtime calls.
Reviewed by Steve Falkenburg.
- VM/CTI.cpp: (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile):
- 11:20 PM Changeset in webkit [36604] by
-
- 8 edits in trunk/JavaScriptCore
2008-09-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20876: REGRESSION (r36417, r36427): fast/js/exception-expression-offset.html fails
<https://bugs.webkit.org/show_bug.cgi?id=20876>
r36417 and r36427 caused an get_by_id opcode to be emitted before the
instanceof and construct opcodes, in order to enable inline caching of
the prototype property. Unfortunately, this regressed some tests dealing
with exceptions thrown by 'instanceof' and the 'new' operator. We fix
these problems by detecting whether an "is not an object" exception is
thrown before op_instanceof or op_construct, and emit the proper
exception in those cases.
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitConstruct):
- VM/CodeGenerator.h:
- VM/ExceptionHelpers.cpp: (JSC::createInvalidParamError): (JSC::createNotAConstructorError): (JSC::createNotAnObjectError):
- VM/ExceptionHelpers.h:
- VM/Machine.cpp: (JSC::Machine::getOpcode): (JSC::Machine::privateExecute):
- VM/Machine.h:
- kjs/nodes.cpp: (JSC::NewExprNode::emitCode): (JSC::InstanceOfNode::emitCode):
- 10:51 PM Changeset in webkit [36603] by
-
- 2 edits in trunk/WebCore
2008-09-17 Sam Weinig <sam@webkit.org>
Fix Windows build.
- WebCore.vcproj/WebCore.vcproj:
- 10:28 PM Changeset in webkit [36602] by
-
- 1 edit in trunk/WebCore/WebCore.base.exp
Fix mysterious Mac bustage.
- 10:10 PM Changeset in webkit [36601] by
-
- 14 edits in trunk/WebCore
2008-09-17 David Hyatt <hyatt@apple.com>
Switch back to having frameGeometry be virtual in order to keep Mac
the way it used to be.
Reviewed by Sam Weinig
- WebCore.base.exp:
- platform/Widget.cpp: (WebCore::Widget::setParent):
- platform/Widget.h:
- platform/gtk/WidgetGtk.cpp: (WebCore::Widget::frameGeometry): (WebCore::Widget::setFrameGeometry):
- platform/mac/WidgetMac.mm: (WebCore::Widget::frameGeometry): (WebCore::Widget::setFrameGeometry):
- platform/qt/WidgetQt.cpp: (WebCore::Widget::frameGeometry): (WebCore::Widget::setFrameGeometry):
- platform/win/WidgetWin.cpp: (WebCore::Widget::frameGeometry): (WebCore::Widget::setFrameGeometry):
- platform/wx/WidgetWx.cpp: (WebCore::Widget::frameGeometry): (WebCore::Widget::setFrameGeometry):
- plugins/PluginView.cpp: (WebCore::PluginView::setFrameGeometry): (WebCore::PluginView::geometryChanged):
- plugins/PluginView.h:
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePluginWidget):
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::updatePluginWidget):
- 10:03 PM Changeset in webkit [36600] by
-
- 2 edits in trunk/WebCore
2008-09-17 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Fix assertion in DOMWindow::adjustWindowRect where we were passing
in garbage values and were getting lucky that they were a not Nan.
- bindings/js/JSDOMWindowBase.cpp: (WebCore::windowProtoFuncOpen):
- 9:28 PM Changeset in webkit [36599] by
-
- 2 edits in trunk/WebCore
2008-09-17 Sam Weinig <sam@webkit.org>
Fix gtk build.
- rendering/style/MatrixTransformOperation.cpp:
- 8:36 PM Changeset in webkit [36598] by
-
- 1 edit in trunk/WebCore/WebCore.base.exp
Fix Mac bustage.
- 8:34 PM Changeset in webkit [36597] by
-
- 1 copy in tags/Safari-5525.25.1
New tag.
- 8:32 PM Changeset in webkit [36596] by
-
- 4 edits in trunk/WebCore/platform
Fix build bustage on Qt, Gtk, Win.
- 8:32 PM Changeset in webkit [36595] by
-
- 1 copy in tags/Safari-5525.25
New tag.
- 8:28 PM Changeset in webkit [36594] by
-
- 6 edits in trunk/WebCore
Fix build bustage on Qt, Gtk, Win.
- 8:23 PM Changeset in webkit [36593] by
-
- 11 edits16 copies in trunk/WebCore
2008-09-17 Sam Weinig <sam@webkit.org>
Rubber-stamped with love by David Hyatt.
Split IdentityTransformOperation, MatrixTransformOperation, RotateTransformOperation,
ScaleTransformOperation, SkewTransformOperation, StyleTransformData, TransformOperation,
TransformOperations and TranslateTransformOperation out of RenderStyle.h/cpp
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- css/CSSStyleSelector.cpp:
- page/animation/AnimationBase.cpp: (WebCore::solveEpsilon):
- rendering/RenderLayer.cpp:
- rendering/style/IdentityTransformOperation.h: Copied from rendering/style/RenderStyle.h.
- rendering/style/MatrixTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/MatrixTransformOperation.h: Copied from rendering/style/RenderStyle.h. (WebCore::MatrixTransformOperation::MatrixTransformOperation):
- rendering/style/RenderStyle.cpp:
- rendering/style/RenderStyle.h:
- rendering/style/RotateTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/RotateTransformOperation.h: Copied from rendering/style/RenderStyle.h. (WebCore::RotateTransformOperation::RotateTransformOperation):
- rendering/style/ScaleTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/ScaleTransformOperation.h: Copied from rendering/style/RenderStyle.h. (WebCore::ScaleTransformOperation::ScaleTransformOperation):
- rendering/style/SkewTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/SkewTransformOperation.h: Copied from rendering/style/RenderStyle.h. (WebCore::SkewTransformOperation::SkewTransformOperation):
- rendering/style/StyleTransformData.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/StyleTransformData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleTransformData::operator!=):
- rendering/style/TransformOperation.h: Copied from rendering/style/RenderStyle.h. (WebCore::TransformOperation::):
- rendering/style/TransformOperations.cpp: Copied from rendering/style/RenderStyle.cpp. (WebCore::TransformOperations::TransformOperations):
- rendering/style/TransformOperations.h: Copied from rendering/style/RenderStyle.h. (WebCore::TransformOperations::operator!=):
- rendering/style/TranslateTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/TranslateTransformOperation.h: Copied from rendering/style/RenderStyle.h. (WebCore::TranslateTransformOperation::TranslateTransformOperation):
- 8:06 PM Changeset in webkit [36592] by
-
- 1 edit in trunk/WebCore/WebCore.base.exp
Fix Mac bustage.
- 8:00 PM Changeset in webkit [36591] by
-
- 1 edit in trunk/WebCore/platform/qt/WidgetQt.cpp
Fix Qt bustage.
- 7:59 PM Changeset in webkit [36590] by
-
- 2 edits in trunk/WebCore
Build fix.
- 7:48 PM Changeset in webkit [36589] by
-
- 12 edits in trunk/WebCore
2008-09-17 David Hyatt <hyatt@apple.com>
(1) Inline a bunch of methods for accessing frame geometry.
(2) Make sure frameGeometry() works even when you have no underlying
native widget.
(3) Cache a frame geometry rect cross-platform (even for widgets that
have underlying native widgets.
(4) PluginView's updateWindow call is now a virtual function on Widget.
Reviewed by Sam Weinig
- ChangeLog:
- WebCore.base.exp:
- platform/Widget.cpp: (WebCore::Widget::setFrameGeometry):
- platform/Widget.h: (WebCore::Widget::x): (WebCore::Widget::y): (WebCore::Widget::width): (WebCore::Widget::height): (WebCore::Widget::size): (WebCore::Widget::pos): (WebCore::Widget::frameGeometry): (WebCore::Widget::resize): (WebCore::Widget::move): (WebCore::Widget::isFrameView): (WebCore::Widget::windowClipRect):
- platform/mac/WidgetMac.mm: (WebCore::Widget::~Widget): (WebCore::Widget::updatePlatformWidgetFrameGeometry):
- platform/win/WidgetWin.cpp: (WebCore::Widget::updatePlatformWidgetFrameGeometry):
- plugins/PluginView.cpp: (WebCore::PluginView::setFrameGeometry): (WebCore::PluginView::geometryChanged):
- plugins/PluginView.h:
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
- plugins/wx/PluginViewWx.cpp:
- 7:47 PM Changeset in webkit [36588] by
-
- 2 edits in trunk/WebCore
2008-09-17 Sam Weinig <sam@webkit.org>
Reviewed by David "Waterman" Hyatt.
Fix a leak of NSViews in WidgetMac.mm.
- platform/mac/WidgetMac.mm: (WebCore::Widget::~Widget):
- 6:46 PM Changeset in webkit [36587] by
-
- 8 edits13 copies in trunk/WebCore
2008-09-17 Sam Weinig <sam@webkit.org>
Rubber-stamped by David Waterman Hyatt.
Split FillLayer, StyleBackgroundData, StyleBoxData, StyleDashboardRegion, StyleMarqueeData
StyleMultiColData and StyleVisualData out of RenderStyle.h/cpp
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- rendering/style/FillLayer.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/FillLayer.h: Copied from rendering/style/RenderStyle.h. (WebCore::FillLayer::operator!=): (WebCore::FillLayer::hasImage): (WebCore::FillLayer::hasFixedImage):
- rendering/style/RenderStyle.cpp:
- rendering/style/RenderStyle.h:
- rendering/style/StyleBackgroundData.cpp: Copied from rendering/style/RenderStyle.cpp. (WebCore::StyleBackgroundData::StyleBackgroundData):
- rendering/style/StyleBackgroundData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleBackgroundData::~StyleBackgroundData): (WebCore::StyleBackgroundData::operator!=):
- rendering/style/StyleBoxData.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/StyleBoxData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleBoxData::operator!=):
- rendering/style/StyleDashboardRegion.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleDashboardRegion::operator!=):
- rendering/style/StyleMarqueeData.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/StyleMarqueeData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleMarqueeData::operator!=):
- rendering/style/StyleMultiColData.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/StyleMultiColData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleMultiColData::operator!=): (WebCore::StyleMultiColData::ruleWidth):
- rendering/style/StyleVisualData.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/StyleVisualData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleVisualData::operator==):
- 6:32 PM Changeset in webkit [36586] by
-
- 1 edit in trunk/WebCore/platform/ScrollbarThemeComposite.cpp
Fix Win build bustage.
- 6:17 PM Changeset in webkit [36585] by
-
- 5 edits in trunk/WebCore
Fix Win and Qt build bustage.
- 5:56 PM Changeset in webkit [36584] by
-
- 9 edits1 delete in trunk/WebCore
2008-09-17 David Hyatt <hyatt@apple.com>
Remove WidgetClient from Widget.
Reviewed by Sam Weinig
- WebCore.xcodeproj/project.pbxproj:
- platform/Widget.h: (WebCore::Widget::setClient): (WebCore::Widget::client):
- platform/WidgetClient.h: Removed.
- platform/gtk/WidgetGtk.cpp:
- platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::show): (WebCore::Widget::hide):
- platform/qt/WidgetQt.cpp: (WebCore::WidgetPrivate::WidgetPrivate):
- platform/win/WidgetWin.cpp: (WebCore::Widget::Widget):
- platform/wx/WidgetWx.cpp: (WebCore::Widget::Widget):
- 5:40 PM Changeset in webkit [36583] by
-
- 4 edits in branches/Safari-3-2-branch
Versioning.
- 5:39 PM Changeset in webkit [36582] by
-
- 14 edits in trunk/WebCore
2008-09-17 David Hyatt <hyatt@apple.com>
Remove isEnabled/setEnabled from Widget. The concept of being enabled now
only applies to Scrollbars so the method has been moved there and made
cross-platform. Scrollbar subclasses that have a corresponding native
widget can subclass setEnabled to change the enabled state of the native
widget.
Reviewed by Sam Weinig & Darin Adler
- WebCore.base.exp:
- platform/Scrollbar.cpp: (WebCore::Scrollbar::Scrollbar):
- platform/Scrollbar.h: (WebCore::Scrollbar::enabled): (WebCore::Scrollbar::setEnabled):
- platform/Widget.h:
- platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::setEnabled):
- platform/gtk/ScrollbarGtk.h:
- platform/gtk/WidgetGtk.cpp:
- platform/mac/ScrollbarMac.h:
- platform/mac/ScrollbarMac.mm: (WebCore::ScrollbarMac::scrollbarHit): (WebCore::ScrollbarMac::setEnabled):
- platform/mac/WidgetMac.mm:
- platform/qt/WidgetQt.cpp: (WebCore::WidgetPrivate::WidgetPrivate):
- platform/win/WidgetWin.cpp: (WebCore::Widget::Widget):
- platform/wx/WidgetWx.cpp:
- 5:36 PM Changeset in webkit [36581] by
-
- 4 edits in trunk/JavaScriptCore
2008-09-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
JIT generation cti_op_construct_verify.
Quarter to half percent progression on v8-tests.
Roughly not change on SunSpider (possible minor progression).
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
- VM/Machine.cpp:
- VM/Machine.h:
- 5:05 PM Changeset in webkit [36580] by
-
- 1 edit in trunk/WebCore/platform/Widget.h
Land a comment in Widget.h to help describe the class.
- 4:56 PM Changeset in webkit [36579] by
-
- 10 edits1 copy in trunk/WebCore
2008-09-17 Sam Weinig <sam@webkit.org>
Rubber-stamped by David Hyatt.
Split all RenderStyle enums into their own file.
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/style/BorderValue.h:
- rendering/style/CollapsedBorderValue.h:
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h: Copied from rendering/style/RenderStyle.h. (WebCore::):
- rendering/style/StyleCachedImage.h:
- rendering/style/StyleGeneratedImage.h:
- rendering/style/StyleImage.h:
- 4:54 PM Changeset in webkit [36578] by
-
- 2 edits in trunk/JavaScriptCore
Improve timer accuracy for JavaScript Date object on Windows.
Use a combination of ftime and QueryPerformanceCounter.
ftime returns the information we want, but doesn't have sufficient resolution.
QueryPerformanceCounter has high resolution, but is only usable to measure time intervals.
To combine them, we call ftime and QueryPerformanceCounter initially. Later calls will use
QueryPerformanceCounter by itself, adding the delta to the saved ftime. We re-sync to
correct for drift if the low-res and high-res elapsed time between calls differs by more
than twice the low-resolution timer resolution.
QueryPerformanceCounter may be inaccurate due to a problems with:
- some PCI bridge chipsets (http://support.microsoft.com/kb/274323)
- BIOS bugs (http://support.microsoft.com/kb/895980/)
- BIOS/HAL bugs on multiprocessor/multicore systems (http://msdn.microsoft.com/en-us/library/ms644904.aspx)
Reviewed by Darin Adler.
- kjs/DateMath.cpp: (JSC::highResUpTime): (JSC::lowResUTCTime): (JSC::qpcAvailable): (JSC::getCurrentUTCTimeWithMicroseconds):
- 4:53 PM Changeset in webkit [36577] by
-
- 2 edits in trunk/WebCore
Add back isFrameView check to fix failed assertion during scroll bar teardown.
Reviewed by Dave Hyatt.
- platform/Scrollbar.cpp: (WebCore::Scrollbar::setParent):
- 4:41 PM Changeset in webkit [36576] by
-
- 1 edit6 adds in trunk/LayoutTests
2008-09-17 Simon Fraser <Simon Fraser>
Add pixel test expecteds for transform tests.
- platform/mac/transforms/2d/compound-transforms-vs-containers-expected.checksum: Added.
- platform/mac/transforms/2d/compound-transforms-vs-containers-expected.png: Added.
- platform/mac/transforms/2d/transform-borderbox-expected.checksum: Added.
- platform/mac/transforms/2d/transform-borderbox-expected.png: Added.
- platform/mac/transforms/2d/transform-origin-borderbox-expected.checksum: Added.
- platform/mac/transforms/2d/transform-origin-borderbox-expected.png: Added.
- 4:39 PM Changeset in webkit [36575] by
-
- 1 edit in trunk/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp
Fix win bustage.
- 4:30 PM Changeset in webkit [36574] by
-
- 2 edits in trunk/WebCore
2008-09-17 Brady Eidson <beidson@apple.com>
Reviewed by Mac build fix
- WebCore.xcodeproj/project.pbxproj: Send appropriate headers to WebKit
- 4:28 PM Changeset in webkit [36573] by
-
- 3 edits in trunk/WebCore
Fix build.
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::setParentVisible):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::init):
- 4:25 PM Changeset in webkit [36572] by
-
- 2 edits in trunk/WebCore
[QtWebKit] Implement error handling in TextCodecQt::decode
Use the QTextCodec parsing state to set the sawError out variable. This
is needed to pass Test 70 of acid3. The test case for this bug is
fast/encoding/invalid-xml.html that is now partially passed. To pass
it completely the Qt text codecs need to be adjusted to have proper
error handling.
- 4:12 PM Changeset in webkit [36571] by
-
- 1 edit in trunk/WebCore/plugins/win/PluginViewWin.cpp
Fix Windows bustage.
- 4:11 PM Changeset in webkit [36570] by
-
- 1 edit in trunk/WebCore/plugins/win/PluginViewWin.cpp
Fix Windows bustage.
- 4:07 PM Changeset in webkit [36569] by
-
- 1 edit in trunk/WebCore/platform/win/ScrollViewWin.cpp
Fix Windows bustage.
- 4:03 PM Changeset in webkit [36568] by
-
- 8 edits6 copies in trunk/WebCore
2008-09-17 Sam Weinig <sam@webkit.org>
Rubber-stamped by Dave Hyatt.
Split BorderData, BorderValue, CollapsedBorderValue, OutlineValue and StyleSurroundData
out of RenderStyle.h/cpp
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- rendering/style/BorderData.h: Copied from rendering/style/RenderStyle.h. (WebCore::BorderData::hasBorderRadius): (WebCore::BorderData::borderLeftWidth): (WebCore::BorderData::borderRightWidth): (WebCore::BorderData::borderTopWidth): (WebCore::BorderData::borderBottomWidth): (WebCore::BorderData::operator!=):
- rendering/style/BorderValue.h: Copied from rendering/style/RenderStyle.h. (WebCore::): (WebCore::BorderValue::BorderValue): (WebCore::BorderValue::nonZero): (WebCore::BorderValue::isTransparent): (WebCore::BorderValue::isVisible):
- rendering/style/CollapsedBorderValue.h: Copied from rendering/style/RenderStyle.h. (WebCore::): (WebCore::CollapsedBorderValue::CollapsedBorderValue): (WebCore::CollapsedBorderValue::operator==):
- rendering/style/OutlineValue.h: Copied from rendering/style/RenderStyle.h. (WebCore::OutlineValue::OutlineValue):
- rendering/style/RenderStyle.cpp:
- rendering/style/RenderStyle.h:
- rendering/style/StyleSurroundData.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/StyleSurroundData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleSurroundData::operator!=):
- 4:00 PM Changeset in webkit [36567] by
-
- 2 edits in trunk/WebCore
2008-09-17 Beth Dakin <Beth Dakin>
Reviewed by Darin Adler.
This is a better fix for: Invalid CSS code crashes Safari
https://bugs.webkit.org/show_bug.cgi?id=20512
The spec indicates that the only valid input for a counter is a
number or an identifier. So that is exactly what we allow.
- css/CSSParser.cpp: (WebCore::CSSParser::parseCounterContent):
- 3:40 PM Changeset in webkit [36566] by
-
- 3 edits in trunk/JavaScriptCore
2008-09-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Implement JIT generation of CallFrame initialization, for op_call.
1% sunspider 2.5% v8-tests.
- VM/CTI.cpp: (JSC::CTI::compileOpCall):
- VM/Machine.cpp: (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_call_NotJSFunction):
- 3:22 PM Changeset in webkit [36565] by
-
- 1 edit in trunk/WebCore/plugins/qt/PluginViewQt.cpp
Fix Qt bustage.
- 3:21 PM Changeset in webkit [36564] by
-
- 1 edit in trunk/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
Fix Qt bustage.
- 3:16 PM Changeset in webkit [36563] by
-
- 3 edits in trunk/WebCore
2008-09-17 Alp Toker <alp@nuanti.com>
GTK+ build fix. Adapt to use PlatformWidget functions.
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollViewScrollbar::geometryChanged): (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild):
- platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::ScrollbarGtk): (ScrollbarGtk::~ScrollbarGtk): (ScrollbarGtk::geometryChanged):
- 3:07 PM Changeset in webkit [36562] by
-
- 1 edit in trunk/WebCore/platform/Widget.h
Fix wx bustage.
- 3:07 PM Changeset in webkit [36561] by
-
- 1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp
Fix Qt bustage.
- 3:00 PM Changeset in webkit [36560] by
-
- 3 edits3 adds in trunk
WebCore:
2008-09-17 Sam Weinig <sam@webkit.org>
Reviewed by Adele Peterson.
Patch for <rdar://problem/6133884>
Calling window.resizeTo() on a subframe shouldn't change the window size
Test: fast/dom/Window/window-resize-and-move-sub-frame.html
- page/DOMWindow.cpp: (WebCore::DOMWindow::moveBy): (WebCore::DOMWindow::moveTo): (WebCore::DOMWindow::resizeBy): (WebCore::DOMWindow::resizeTo):
LayoutTests:
2008-09-17 Sam Weinig <sam@webkit.org>
Reviewed by Adele Peterson.
Test for <rdar://problem/6133884>
Calling window.resizeTo() on a subframe shouldn't change the window size
- fast/dom/Window/resources/blank.html: Added.
- fast/dom/Window/window-resize-and-move-sub-frame-expected.txt: Added.
- fast/dom/Window/window-resize-and-move-sub-frame.html: Added.
- 2:49 PM ProposedWebInspectorRearchitecting edited by
- (diff)
- 2:45 PM ProposedWebInspectorRearchitecting edited by
- (diff)
- 2:43 PM ProposedWebInspectorRearchitecting edited by
- added random notes (diff)
- 2:35 PM Changeset in webkit [36559] by
-
- 3 edits4 adds in trunk
WebCore:
2008-09-17 Beth Dakin <Beth Dakin>
Reviewed by Adam Roben.
Fix for https://bugs.webkit.org/show_bug.cgi?id=20512 Invalid CSS
code crashes Safari
and corresponding: <rdar://problem/6173832>
Reading through the spec, it seems like a function is not valid
input for a counter. So this patch checks for that and bails in the
case of invalid input.
- css/CSSParser.cpp: (WebCore::CSSParser::parseCounterContent):
LayoutTests:
2008-09-17 Beth Dakin <Beth Dakin>
Reviewed by Adam Roben.
Test for https://bugs.webkit.org/show_bug.cgi?id=20512 Invalid CSS
code crashes Safari
and corresponding: <rdar://problem/6173832>
- fast/css/counters/counter-function-input-2-expected.txt: Added.
- fast/css/counters/counter-function-input-2.html: Added.
- fast/css/counters/counter-function-input-expected.txt: Added.
- fast/css/counters/counter-function-input.html: Added.
- 2:30 PM Changeset in webkit [36558] by
-
- 1 edit in trunk/WebCore/plugins/gtk/PluginViewGtk.cpp
Fix Gtk bustage.
- 2:28 PM Changeset in webkit [36557] by
-
- 1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp
Fix Qt bustage.
- 2:17 PM Changeset in webkit [36556] by
-
- 1 edit in trunk/WebCore/WebCore.base.exp
Fix Mac bustage.
- 2:16 PM Changeset in webkit [36555] by
-
- 1 edit in trunk/WebCore/bindings/js/ScriptControllerQt.cpp
Fix Qt bustage
- 2:14 PM Changeset in webkit [36554] by
-
- 2 edits in trunk/WebCore
2008-09-17 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Antti Koivisto.
Fix <rdar://problem/6227089>
Crash in WebCore::Frame::setNeedsReapplyStyles()
View is null checked elsewhere too.
- page/Frame.cpp: (WebCore::Frame::setNeedsReapplyStyles):
- 1:59 PM Changeset in webkit [36553] by
-
- 25 edits in trunk
WebCore:
2008-09-17 David Hyatt <hyatt@apple.com>
Make the notion of having a native widget backing a Widget cross-platform.
The PlatformWidget abstraction (which already existed) is used for this.
Windows = HWND
Qt = QWidget
Mac = NSView
wx = wxWindow
Gtk = GtkWidget
There are new cross-platform methods that replace all of the unique
platform-specific methods.
platformWidget()
setPlatformWidget()
For plugins, on every platform except Qt on Windows, the plugin's native
widget is now stored in the Widget base class. Since Qt on Windows uses
HWNDs for plugins instead of QWidget, it is the only platform to keep the
m_window variable in PluginView.
Reviewed by Sam Weinig
- WebCore.base.exp:
- bindings/js/ScriptControllerMac.mm: (WebCore::ScriptController::createScriptInstanceForWidget):
- page/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper attachmentView]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::mouseDownViewIfStillGood): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
- platform/Widget.cpp: (WebCore::Widget::init): (WebCore::Widget::setParent): (WebCore::Widget::releasePlatformWidget): (WebCore::Widget::retainPlatformWidget):
- platform/Widget.h: (WebCore::Widget::platformWidget): (WebCore::Widget::setPlatformWidget):
- platform/gtk/WidgetGtk.cpp: (WebCore::Widget::Widget): (WebCore::Widget::setFocus): (WebCore::gdkDrawable): (WebCore::Widget::setCursor): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::paint):
- platform/mac/PlatformScreenMac.mm: (WebCore::screenRect): (WebCore::screenAvailableRect):
- platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::scrollView): (WebCore::ScrollView::update): (WebCore::ScrollView::inWindow):
- platform/mac/ScrollbarMac.mm: (WebCore::ScrollbarMac::ScrollbarMac): (WebCore::ScrollbarMac::~ScrollbarMac): (WebCore::ScrollbarMac::updateThumbPosition): (WebCore::ScrollbarMac::updateThumbProportion): (WebCore::ScrollbarMac::scrollbarHit):
- platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::setFocus): (WebCore::Widget::getOuterView): (WebCore::Widget::paint): (WebCore::Widget::invalidate): (WebCore::Widget::invalidateRect): (WebCore::Widget::setIsSelected): (WebCore::Widget::releasePlatformWidget): (WebCore::Widget::retainPlatformWidget):
- platform/qt/WidgetQt.cpp: (WebCore::WidgetPrivate::WidgetPrivate): (WebCore::Widget::Widget): (WebCore::Widget::setFrameGeometry): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::isEnabled): (WebCore::Widget::setEnabled): (WebCore::Widget::invalidateRect): (WebCore::Widget::containingWindow):
- platform/win/WidgetWin.cpp: (WebCore::Widget::Widget):
- platform/wx/WidgetWx.cpp: (WebCore::Widget::Widget): (WebCore::Widget::frameGeometry): (WebCore::Widget::setFocus): (WebCore::Widget::setCursor): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::setFrameGeometry): (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::invalidate): (WebCore::Widget::invalidateRect): (WebCore::Widget::paint):
- plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
- plugins/PluginView.h: (WebCore::PluginView::platformPluginWidget):
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updateWindow): (WebCore::PluginView::setFocus): (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::setParent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::setParentVisible): (WebCore::PluginView::getValue): (WebCore::PluginView::forceRedraw): (WebCore::PluginView::init):
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updateWindow): (WebCore::PluginView::setFocus): (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::setParent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::setParentVisible): (WebCore::PluginView::getValue): (WebCore::PluginView::~PluginView): (WebCore::PluginView::init):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::updateWindow): (WebCore::PluginView::setFocus): (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::paint): (WebCore::PluginView::setParent): (WebCore::PluginView::setParentVisible): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::stop): (WebCore::PluginView::invalidateRect): (WebCore::PluginView::forceRedraw): (WebCore::PluginView::~PluginView): (WebCore::PluginView::init):
WebKit/mac:
2008-09-17 David Hyatt <hyatt@apple.com>
Make the notion of Widget having an underlying native widget cross-platform.
Reviewed by Sam Weinig
- WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent):
- WebView/WebFrame.mm: (-[WebFrame _dragSourceMovedTo:]): (-[WebFrame _dragSourceEndedAt:operation:]):
- WebView/WebFrameView.mm: (-[WebFrameView _install]):
- WebView/WebRenderNode.mm: (copyRenderNode):
- 1:27 PM Changeset in webkit [36552] by
-
- 3 edits in branches/Safari-3-2-branch/WebKit/mac
Merge r36126.
- 1:27 PM Changeset in webkit [36551] by
-
- 13 edits in branches/Safari-3-2-branch
Merge r35950.
- 1:27 PM Changeset in webkit [36550] by
-
- 18 edits in branches/Safari-3-2-branch
Merge r32881.
- 1:27 PM Changeset in webkit [36549] by
-
- 4 edits in branches/Safari-3-2-branch
Versioning.
- 1:27 PM Changeset in webkit [36548] by
-
- 1 edit in branches/Safari-3-2-branch/JavaScriptCore/wtf/Vector.h
Merge new Vector::remove variant from r30593.
- 1:27 PM Changeset in webkit [36547] by
-
- 4 edits in branches/Safari-3-2-branch
Versioning.
- 1:17 PM Changeset in webkit [36546] by
-
- 1 edit in trunk/JavaScriptCore/VM/Machine.cpp
build fix
- 1:16 PM Changeset in webkit [36545] by
-
- 2 edits in trunk/WebCore
2008-09-17 Sam Weinig <sam@webkit.org>
Fix assert.
- platform/Widget.cpp: (WebCore::Widget::setParent):
- 12:29 PM Changeset in webkit [36544] by
-
- 4 edits in trunk/JavaScriptCore
2008-09-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Optimizations for op_call in CTI. Move check for (ctiCode == 0) into JIT code,
move copying of scopeChain for CodeBlocks that needFullScopeChain into head of
functions, instead of checking prior to making the call.
3% on v8-tests (4% on richards, 6% in delta-blue)
- VM/CTI.cpp: (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile):
- VM/Machine.cpp: (JSC::Machine::execute): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_vm_compile): (JSC::Machine::cti_vm_updateScopeChain): (JSC::Machine::cti_op_construct_JSConstruct):
- VM/Machine.h:
- 11:46 AM Changeset in webkit [36543] by
-
- 18 edits in trunk/WebCore
2008-09-17 David Hyatt <hyatt@apple.com>
Beginnings of Widget refactoring (in order to make the mixing of
widgets with and without corresponding native widgets more cross-platform).
This first patch makes the concept of a parent ScrollView cross-platform.
Note the similarity of the show/hide methods on the three PluginViews. This
will be refactored better in a later patch so that they can all share
a base class Widget show/hide method. For now the changes were made
simply to be able to bring WidgetWin's setParent method up into Widget.
Reviewed by Sam Weinig
- WebCore.base.exp:
- platform/ScrollView.h:
- platform/Widget.cpp: (WebCore::Widget::init): (WebCore::Widget::setParent):
- platform/Widget.h: (WebCore::Widget::isSelfVisible): (WebCore::Widget::isParentVisible): (WebCore::Widget::isVisible): (WebCore::Widget::setParentVisible): (WebCore::Widget::isPluginView): (WebCore::Widget::parent): (WebCore::Widget::handleEvent): (WebCore::Widget::geometryChanged):
- platform/gtk/WidgetGtk.cpp: (WebCore::Widget::Widget):
- platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild):
- platform/mac/ScrollbarMac.mm: (WebCore::ScrollbarMac::~ScrollbarMac):
- platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::~Widget):
- platform/qt/WidgetQt.cpp: (WebCore::WidgetPrivate::WidgetPrivate): (WebCore::Widget::Widget): (WebCore::Widget::topLevel):
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::setAncestorVisible): (WebCore::ScrollView::show): (WebCore::ScrollView::hide):
- platform/win/WidgetWin.cpp: (WebCore::Widget::Widget): (WebCore::Widget::setParent):
- platform/wx/WidgetWx.cpp: (WebCore::Widget::Widget):
- plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
- plugins/PluginView.h:
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::setParentVisible):
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::setParentVisible):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::setParentVisible):
- 11:16 AM ProposedWebInspectorRearchitecting edited by
- added a note on fetchMessages (diff)
- 11:08 AM ProposedWebInspectorRearchitecting edited by
- minor tweaking of the description. (diff)
- 11:02 AM ProposedWebInspectorRearchitecting edited by
- added a bit of background description on current InspectorController … (diff)
- 9:50 AM Changeset in webkit [36542] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
<rdar://problem/6219577> Spew in console at launch about encoding mappings when running with ICU 4.0
- platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Updated for new encoding names.
- 6:29 AM Changeset in webkit [36541] by
-
- 4 edits in trunk
2008-09-17 Tor Arne Vestbø <tavestbo@trolltech.com>
Fix the QtWebKit/Mac build
- 1:34 AM Changeset in webkit [36540] by
-
- 1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp
Fix Gtk bustage.
- 1:17 AM Changeset in webkit [36539] by
-
- 7 edits in trunk/WebCore
\2008-09-17 David Hyatt <hyatt@apple.com>
Add a #define to control whether or not to use an NSScroller on Mac.
This ifdef will allow the new NSView-less NSScroller on Mac to be
developed side by side with the current one.
The new scroller paints a debug red if turned on (although due to
Widget issues you won't see anything paint yet).
Reviewed by olliej
- platform/Scrollbar.cpp:
- platform/Scrollbar.h:
- platform/mac/ScrollbarMac.h:
- platform/mac/ScrollbarMac.mm:
- platform/mac/ScrollbarThemeMac.cpp: (WebCore::ScrollbarThemeMac::paint):
- platform/mac/ScrollbarThemeMac.h:
Sep 16, 2008:
- 11:48 PM Changeset in webkit [36538] by
-
- 1 edit in trunk/WebKit/qt/Api/qwebpage.cpp
Fix Qt bustage.
- 11:32 PM Changeset in webkit [36537] by
-
- 1 edit in trunk/WebKit/qt/Api/qwebpage.cpp
Fix Qt bustage.
- 10:50 PM Changeset in webkit [36536] by
-
- 1 edit in trunk/WebCore/platform/gtk/ScrollbarGtk.h
Fix gtk bustage.
- 10:06 PM Changeset in webkit [36535] by
-
- 3 edits in trunk/WebKit/qt
2008-09-16 Alp Toker <alp@nuanti.com>
Prospective Qt build fix. ScrollBar.h -> Scrollbar.h
- Api/qwebframe.cpp:
- Api/qwebpage.cpp:
- 9:35 PM Changeset in webkit [36534] by
-
- 3 edits in trunk/WebKit/qt
Fix Qt build bustage.
- 9:30 PM Changeset in webkit [36533] by
-
- 2 edits in trunk/WebCore
2008-09-16 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=20854
[GTK] Windows can be not realized in ScrollView::update
Do not call gdk_window_invalidate_rect on a non-realized GtkWidget.
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::update):
- 9:22 PM Changeset in webkit [36532] by
-
- 34 edits2 moves in trunk
2008-09-16 Alp Toker <alp@nuanti.com>
Suggested by Dave Hyatt.
Build fix and cleanup. Rename ScrollBar to Scrollbar.
- 9:22 PM Changeset in webkit [36531] by
-
- 1 edit in trunk/WebCore/platform/qt/WidgetQt.cpp
Fix Qt build bustage.
- 8:54 PM Changeset in webkit [36530] by
-
- 1 edit in trunk/WebCore/rendering/RenderLayer.cpp
Fix Gtk/Qt build bustage.
- 8:49 PM Changeset in webkit [36529] by
-
- 5 edits in trunk/WebCore
2008-09-16 David Hyatt <hyatt@apple.com>
Fix Qt build bustage by making moveThumb a member of Scrollbar so that
it can be called from ScrollbarQt.
- platform/ScrollBar.cpp: (WebCore::Scrollbar::moveThumb): (WebCore::Scrollbar::handleMouseMoveEvent): (WebCore::Scrollbar::handleMousePressEvent):
- platform/ScrollBar.h:
- platform/qt/ScrollViewQt.cpp:
- platform/qt/ScrollbarQt.cpp: (WebCore::Scrollbar::handleContextMenuEvent):
- 8:17 PM Changeset in webkit [36528] by
-
- 6 edits in trunk
2008-09-16 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20857: REGRESSION (r36427): ASSERTION FAILED: m_refCount >= 0 in RegisterID::deref()
<https://bugs.webkit.org/show_bug.cgi?id=20857>
Fix a problem stemming from the slightly unsafe behaviour of the
CodeGenerator::finalDestination() method by putting the "func" argument
of the emitConstruct() method in a RefPtr in its caller. Also, add an
assertion guaranteeing that this is always the case.
CodeGenerator::finalDestination() is still incorrect and can cause
problems with a different allocator; see bug 20340 for more details.
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitConstruct):
- kjs/nodes.cpp: (JSC::NewExprNode::emitCode):
LayoutTests:
- fast/js/codegen-temporaries-expected.txt:
- fast/js/resources/codegen-temporaries.js:
- 8:17 PM Changeset in webkit [36527] by
-
- 23 edits5 moves2 deletes in trunk
WebCore:
2008-09-16 David Hyatt <hyatt@apple.com>
Eliminate PlatformScrollbar. Mac and Gtk now have subclasses for their
native-widget scrollbars (ScrollbarMac and ScrollbarGtk). Other platforms
now just use Scrollbar.
Reviewed by Sam Weinig
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- page/mac/FrameMac.mm:
- platform/PopupMenu.h: (WebCore::PopupMenu::scrollbar):
- platform/ScrollBar.cpp: (WebCore::createNativeScrollbar):
- platform/ScrollBar.h:
- platform/gtk/PlatformScrollBar.h: Removed.
- platform/gtk/PlatformScrollBarGtk.cpp: Removed.
- platform/gtk/ScrollbarGtk.cpp: Copied from platform/gtk/PlatformScrollBarGtk.cpp. (gtkScrollEventCallback): (ScrollbarGtk::ScrollbarGtk): (ScrollbarGtk::~ScrollbarGtk): (ScrollbarGtk::updateThumbPosition): (ScrollbarGtk::updateThumbProportion): (ScrollbarGtk::setFrameGeometry): (ScrollbarGtk::geometryChanged): (ScrollbarGtk::gtkValueChanged):
- platform/gtk/ScrollbarGtk.h: Copied from platform/gtk/PlatformScrollBar.h.
- platform/mac/PlatformScrollBar.h: Removed.
- platform/mac/PlatformScrollBarMac.mm: Removed.
- platform/mac/ScrollbarMac.h: Copied from platform/mac/PlatformScrollBar.h.
- platform/mac/ScrollbarMac.mm: Copied from platform/mac/PlatformScrollBarMac.mm. (-[WebCoreScrollBar initWithScrollbarMac:]): (-[WebCoreScrollBar detachScrollbarMac]): (WebCore::Scrollbar::createNativeScrollbar): (WebCore::ScrollbarMac::ScrollbarMac): (WebCore::ScrollbarMac::~ScrollbarMac): (WebCore::ScrollbarMac::updateThumbPosition): (WebCore::ScrollbarMac::updateThumbProportion): (WebCore::ScrollbarMac::scrollbarHit):
- platform/qt/PlatformScrollBar.h: Removed.
- platform/qt/PlatformScrollBarQt.cpp: Removed.
- platform/qt/ScrollbarQt.cpp: Copied from platform/qt/PlatformScrollBarQt.cpp. (WebCore::Scrollbar::handleContextMenuEvent):
- rendering/HitTestResult.cpp:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::destroyScrollbar):
- rendering/RenderLayer.h:
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::isPointInOverflowControl):
- rendering/RenderObject.h:
- rendering/RenderTextControl.cpp:
WebKit/win:
2008-09-16 David Hyatt <hyatt@apple.com>
Eliminate PlatformScrollbar.
Reviewed by Sam Weinig
- WebScrollBar.cpp: (WebScrollBar::init):
- WebScrollBar.h:
- 7:15 PM Changeset in webkit [36526] by
-
- 8 edits in trunk/WebCore
2008-09-16 David Hyatt <hyatt@apple.com>
Make the scrollbar resizer-dodging logic cross-platform in the
Scrollbar class.
Reviewed by Sam Weinig
- platform/ScrollBar.cpp: (WebCore::Scrollbar::setFrameGeometry): (WebCore::Scrollbar::setParent): (WebCore::Scrollbar::windowClipRect):
- platform/ScrollBar.h:
- platform/ScrollView.h: (WebCore::ScrollView::windowResizerRect): (WebCore::ScrollView::resizerOverlapsContent): (WebCore::ScrollView::adjustOverlappingScrollbarCount):
- platform/Widget.h: (WebCore::Widget::setParent):
- platform/mac/WidgetMac.mm: (WebCore::Widget::convertToContainingWindow):
- platform/win/PlatformScrollBar.h:
- platform/win/PlatformScrollBarWin.cpp:
- 5:18 PM Changeset in webkit [36525] by
-
- 1 edit2 moves in trunk/LayoutTests
Disable fast/js/garbage-collect-after-string-appends.html.
- 4:04 PM Changeset in webkit [36524] by
-
- 2 edits in trunk/LayoutTests
Tweak garbage-collect-after-string-appends.js to not fail when run twice or more in a row.
This will hopefully address the intermittent failures seen on the build bot.
Rubber-stamped by Sam Weinig.
- fast/js/resources/garbage-collect-after-string-appends.js:
- 3:28 PM Changeset in webkit [36523] by
-
- 2 edits in trunk/WebKitTools
2008-09-16 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Add flag to disable running sample on tests that timeout.
- Scripts/run-webkit-tests:
- 2:46 PM Changeset in webkit [36522] by
-
- 1 edit4 adds in trunk/LayoutTests
2008-09-16 Chris Marrin <cmarrin@apple.com>
Reviewed by Dan Bernstein.
New tests for keyframe animations
https://bugs.webkit.org/show_bug.cgi?id=20891
- animations/keyframes-expected.txt: Added.
- animations/keyframes-out-of-order-expected.txt: Added.
- animations/keyframes-out-of-order.html: Added.
- animations/keyframes.html: Added.
- 1:43 PM Changeset in webkit [36521] by
-
- 4 edits in trunk/LayoutTests
2008-09-16 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
Update layout test results for tests changed by http://trac.webkit.org/changeset/35799
- platform/mac-leopard/security/block-test-expected.txt:
- platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
- security/block-test-expected.txt:
- 1:15 PM Changeset in webkit [36520] by
-
- 3 edits in trunk/LayoutTests
2008-09-16 Simon Fraser <Simon Fraser>
Reviewed by Mark Rowe
Fix test cases that call notifyDone() twice
https://bugs.webkit.org/show_bug.cgi?id=20884
- animations/change-one-anim.html:
Only respond to one of the two running animations, to avoid
doing things twice.
https://bugs.webkit.org/show_bug.cgi?id=20881
- svg/custom/gradient-attr-update.svg:
Fix the test to not run code both on an onload handler,
and on the synthetic click handler.
https://bugs.webkit.org/show_bug.cgi?id=20884
- 12:40 PM Changeset in webkit [36519] by
-
- 5 edits in trunk/WebKitTools
Windows build fix after r36511
Update for rename of layoutTestController to gLayoutTestController.
- DumpRenderTree/LayoutTestController.cpp:
- DumpRenderTree/win/EditingDelegate.cpp:
- DumpRenderTree/win/FrameLoadDelegate.cpp:
- DumpRenderTree/win/ResourceLoadDelegate.cpp:
- DumpRenderTree/win/UIDelegate.cpp:
- 12:32 PM Changeset in webkit [36518] by
-
- 2 edits in trunk/JavaScriptCore
2008-09-16 Alice Liu <alice.liu@apple.com>
build fix.
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
- 11:47 AM Changeset in webkit [36517] by
-
- 1 edit1 add in trunk/WebKitTools
Add a script to print out the dependency tree of a Visual Studio solution file
- Scripts/print-msvc-project-dependencies: Added.
- 11:01 AM Changeset in webkit [36516] by
-
- 2 edits in trunk/WebKitTools
Fix the build.
- DumpRenderTree/LayoutTestController.cpp: (notifyDoneCallback): Call fprintf in a safer manner.
- 10:40 AM Changeset in webkit [36515] by
-
- 6 edits in trunk
WebCore:
Reviewed by Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=15129 <rdar://problem/4644824> adding a new line with DOM does unnecessary additional repaint
Covered by fast/repaint/4776765.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Avoid repainting this object if it did not have layout in the beginning. (WebCore::RenderBlock::layoutBlockChildren): If a child did not have layout in the beginning, repaint it in its new position, to compensate for the above (regardless of whether it "moved").
- rendering/RenderObject.cpp: (WebCore::RenderObject::checkForRepaintDuringLayout): Added a comment about generalizing this fix in the future.
LayoutTests:
Reviewed by Darin Adler.
- updated results for https://bugs.webkit.org/show_bug.cgi?id=15129 <rdar://problem/4644824> adding a new line with DOM does unnecessary additional repaint
- platform/mac/fast/repaint/4776765-expected.checksum:
- platform/mac/fast/repaint/4776765-expected.png:
- 10:40 AM Changeset in webkit [36514] by
-
- 5 edits in trunk/JavaScriptCore
2008-09-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
CTI code generation for op_ret. The majority of the work
(updating variables on the stack & on exec) can be performed
directly in generated code.
We still need to check, & to call out to C-code to handle
activation records, profiling, and full scope chains.
+1.5% Sunspider, +5/6% v8 tests.
- VM/CTI.cpp: (JSC::CTI::emitPutCTIParam): (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileMainPass):
- VM/CTI.h:
- VM/Machine.cpp: (JSC::Machine::cti_op_ret_activation): (JSC::Machine::cti_op_ret_profiler): (JSC::Machine::cti_op_ret_scopeChain):
- VM/Machine.h:
- 10:34 AM Changeset in webkit [36513] by
-
- 5 edits8 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix https://bugs.webkit.org/show_bug.cgi?id=15384 Div does not notice when grandparent changes height
Test: fast/block/basic/quirk-percent-height-grandchild.html
- fix https://bugs.webkit.org/show_bug.cgi?id=20714 Resizing Gmail inbox vertically results in whitespace at the bottom of the window
Test: fast/replaced/percent-height-in-anonymous-block.html
Added a two-way mapping between boxes with percentage heights and
their non-parent ancestors up to the one the height is computed relative
to. In quirks mode (the first bug), this can be any number of containing
block with auto height. In strict mode (the second bug) this can be
the containing block of an anonymous block containing a replaced
element.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::~RenderBlock): Added code to remove the all the mapping to/from this block to percentage-height descendants. (WebCore::RenderBlock::layoutBlockChildren): Added code to mark percentage-height descendants (and their containing block ancestry chain up to this block) for layout. This ensures that those descendants whose height depends on the height of this block (or an ancestor) are updated. (WebCore::RenderBlock::addPercentHeightDescendant): Added. Establishes a two-way mapping between this block and the given box. (WebCore::RenderBlock::removePercentHeightDescendant): Added. Removes all the mapping to/from this box.
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): Added calls to removePercentHeightDescendant() when style changes and the box previously had a percentage height. An exception is when the style change does not require layout, in which case the box still has a percentage height and the mappings are valid. In all other cases, any required mappings will be (re-)established during layout. (WebCore::RenderBox::destroy): Added a call to removePercentHeightDescendant. (WebCore::RenderBox::calcPercentageHeight): Added code that, in quirks mode, if a higher-than-parent containing block is affecting the box's height, creates a mapping between the box and that block. (WebCore::RenderBox::calcReplacedHeightUsing): Changed to skip over anonymous containing blocks, if any, and when that happens, use addPercentHeightDescendant() to ensure that the non-anonymous block is aware of the dependent percent-height box.
LayoutTests:
Reviewed by Dave Hyatt.
- test for https://bugs.webkit.org/show_bug.cgi?id=15384 Div does not notice when grandparent changes height
- test for https://bugs.webkit.org/show_bug.cgi?id=20714 Resizing Gmail inbox vertically results in whitespace at the bottom of the window
- fast/block/basic/quirk-percent-height-grandchild.html: Added.
- fast/replaced/percent-height-in-anonymous-block.html: Added.
- platform/mac/fast/block/basic/quirk-percent-height-grandchild-expected.checksum: Added.
- platform/mac/fast/block/basic/quirk-percent-height-grandchild-expected.png: Added.
- platform/mac/fast/block/basic/quirk-percent-height-grandchild-expected.txt: Added.
- platform/mac/fast/replaced/percent-height-in-anonymous-block-expected.checksum: Added.
- platform/mac/fast/replaced/percent-height-in-anonymous-block-expected.png: Added.
- platform/mac/fast/replaced/percent-height-in-anonymous-block-expected.txt: Added.
- 10:27 AM Changeset in webkit [36512] by
-
- 4 edits in trunk/WebKitTools
2008-09-16 Simon Fraser <Simon Fraser>
Reviewed by Eric Seidel
Protect against tests that call layoutTestController.notifyDone()
more than once, which would lead to memory corruption, by nulling
out the LayoutTestController on the JSObjectRef on destruction. Also
add a finalize callback on the class so that if the LTC outlives
the JSObjectRef, the JSObjectRef backpointer on the LTC can be
nulled out.
- 10:22 AM Changeset in webkit [36511] by
-
- 12 edits in trunk/WebKitTools
2008-09-16 Simon Fraser <Simon Fraser>
Reviewed by Eric Seidel
Step 1 patch: rename global variable for clarity.
https://bugs.webkit.org/show_bug.cgi?id=20875
- 10:02 AM Changeset in webkit [36510] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Fix typo in Dimitri's email address.
- 9:59 AM Changeset in webkit [36509] by
-
- 3 edits in trunk/JavaScriptCore
2008-09-16 Dimitri Glazkov <dlglazkov@chromium.org>
Fix the Windows build.
Add some extra parentheses to stop MSVC from complaining so much.
- VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_stricteq): (JSC::Machine::cti_op_nstricteq):
- kjs/operations.cpp: (JSC::strictEqual):
- 9:59 AM Changeset in webkit [36508] by
-
- 3 edits in trunk/WebCore
2008-09-16 Dirk Schulze <vbs85@gmx.de>
Reviewed by Oliver Hunt and Alp Toker.
Implemented toDataURL in Cairo. Only PNG support
at the moment.
Qt, Cairo and wx require toDataURL implementations
https://bugs.webkit.org/show_bug.cgi?id=17719
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypesForEncoding):
- platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::ImageBuffer): (WebCore::writeFunction): (WebCore::ImageBuffer::toDataURL):
- 9:47 AM Changeset in webkit [36507] by
-
- 1 edit in trunk/WebCore/rendering/RenderMedia.cpp
Revert r36505 ("Only forward events to media element controls if they are visible")
Sorry, it snuck in while trying to commit something else.
- 9:45 AM Changeset in webkit [36506] by
-
- 2 edits in trunk/WebCore
2008-09-16 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Hide unused media element controls in the QtWebKit port
- 9:40 AM Changeset in webkit [36505] by
-
- 1 edit in trunk/WebCore/rendering/RenderMedia.cpp
Only forward events to media element controls if they are visible
- 9:12 AM Changeset in webkit [36504] by
-
- 1 copy in branches/Safari-3-2-branch
New branch.
- 7:19 AM Changeset in webkit [36503] by
-
- 2 edits in trunk/WebCore
2008-09-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Fix compilation of the Qt scrollbar code.
- 7:15 AM Changeset in webkit [36502] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders Carlsson.
Prevent accesses off of the end of the buffer introduced in r36450
and when checking for descriptions of mime. Also, coding style fix.
- 5:34 AM WikiStart edited by
- (diff)
- 5:29 AM ApplicationsGtk edited by
- (diff)
- 4:12 AM Changeset in webkit [36501] by
-
- 5 edits4 adds in trunk
Reviewed by Eric.
https://bugs.webkit.org/show_bug.cgi?id=20634
SVG transform attribute is ignored by <use> in <clipPath>
Transform the paths with the local transform when part
of a clip path.
Test: svg/custom/use-clipped-transform.svg
- 4:07 AM Changeset in webkit [36500] by
-
- 3 edits in trunk/WebKit/mac
2008-09-16 Anders Carlsson <andersca@apple.com>
Reviewed by Cameron Zwarich.
Move more instance variables down to the C++ class.
- Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::WebNetscapePluginStream):
- Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]): (-[WebBaseNetscapePluginStream transferMode]): (-[WebBaseNetscapePluginStream plugin]): (-[WebBaseNetscapePluginStream setPlugin:]): (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): (-[WebBaseNetscapePluginStream wantsAllStreams]): (-[WebBaseNetscapePluginStream _destroyStream]): (-[WebBaseNetscapePluginStream _destroyStreamWithReason:]): (-[WebBaseNetscapePluginStream _deliverData]): (-[WebBaseNetscapePluginStream _deliverDataToFile:]): (-[WebBaseNetscapePluginStream finishedLoading]): (-[WebBaseNetscapePluginStream receivedData:]):
- 2:48 AM Changeset in webkit [36499] by
-
- 3 edits in trunk/WebKit/mac
2008-09-16 Anders Carlsson <andersca@apple.com>
Reviewed by Dave Hyatt.
Move a bunch of instance variables into the C++ class.
- Plugins/WebBaseNetscapePluginStream.h:
- Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream _pluginCancelledConnectionError]): (-[WebBaseNetscapePluginStream errorForReason:]): (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream setRequestURL:]): (-[WebBaseNetscapePluginStream setResponseURL:]): (-[WebBaseNetscapePluginStream setMIMEType:]): (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): (-[WebBaseNetscapePluginStream _destroyStream]): (-[WebBaseNetscapePluginStream _destroyStreamWithReason:]): (-[WebBaseNetscapePluginStream _deliverData]): (-[WebBaseNetscapePluginStream receivedData:]):
- 2:47 AM Changeset in webkit [36498] by
-
- 1 edit in trunk/WebCore/platform/qt/PlatformScrollBar.h
Fix Qt build bustage in PlatformScrollbarQt.cpp
- 2:33 AM Changeset in webkit [36497] by
-
- 3 edits in trunk/WebKit/mac
2008-09-16 Anders Carlsson <andersca@apple.com>
Reviewed by Dave Hyatt.
Add a new WebNetscapePluginStream C++ class. The idea is that it is supposed to replace the Obj-C
WebBaseNetscapePluginStream class. The plan is to gradually move/rewrite code from the Obj-C class to the C++ class
until the C++ class can replace the Obj-C class.
- Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::create): (WebNetscapePluginStream::WebNetscapePluginStream):
- Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream initWithFrameLoader:]): (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]):
- 2:27 AM Changeset in webkit [36496] by
-
- 1 edit in trunk/WebCore/platform/qt/ScrollbarThemeQt.cpp
Fix Qt build bustage in ScrollbarThemeQt.cpp
- 2:21 AM Changeset in webkit [36495] by
-
- 1 edit in trunk/WebCore/platform/gtk/PlatformScrollBar.h
Speculative fix for scrollbar issues on GTK.
- 2:17 AM Changeset in webkit [36494] by
-
- 1 edit in trunk/WebCore/platform/qt/ScrollbarThemeQt.cpp
Fix Qt build bustage in ScrollbarThemeQt.cpp
- 2:16 AM Changeset in webkit [36493] by
-
- 1 edit in trunk/WebCore/platform/qt/ScrollbarThemeQt.cpp
Fix Qt build bustage in ScrollbarThemeQt.cpp
- 2:15 AM Changeset in webkit [36492] by
-
- 5 edits in trunk/WebKit/mac
2008-09-16 Anders Carlsson <andersca@apple.com>
Reviewed by Dave Hyatt.
Instead of storing a pointer to NPP method individually, just store a pointer to the NPNetscapeFuncs vtable.
- Plugins/WebBaseNetscapePluginStream.h:
- Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream setPlugin:]): (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): (-[WebBaseNetscapePluginStream wantsAllStreams]): (-[WebBaseNetscapePluginStream _destroyStream]): (-[WebBaseNetscapePluginStream _deliverData]):
- Plugins/WebNetscapePluginPackage.h:
- Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage pluginFuncs]):
- 2:11 AM Changeset in webkit [36491] by
-
- 1 edit in trunk/WebCore/platform/qt/PlatformScrollBarQt.cpp
Fix Qt build bustage in PlatformScrollbarQt.cpp
- 2:06 AM Changeset in webkit [36490] by
-
- 3 edits in trunk/WebKit/mac
2008-09-16 Anders Carlsson <andersca@apple.com>
Reviewed by Dave Hyatt.
Remove references to WebNetscapePluginStream.
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebNetscapePluginEmbeddedView.h:
- 2:00 AM Changeset in webkit [36489] by
-
- 1 edit in trunk/WebCore/platform/gtk/LocalizedStringsGtk.cpp
Fix GTK bustage. Maybe. Cleaning up after Chris Fleizach's checkin...
Sep 15, 2008:
- 11:53 PM Changeset in webkit [36488] by
-
- 13 edits in trunk/WebCore
Convert Qt to ScrollbarTheme. Add cross-platform support for jumping a scrollbar thumb directly to a position on the track (Shift+Click on Windows, Middle Click on Qt)
- 11:48 PM Changeset in webkit [36487] by
-
- 1 edit in trunk/WebCore/platform/qt/Localizations.cpp
Fix Qt build bustage in Localizations.
- 11:39 PM Changeset in webkit [36486] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Dave Hyatt.
- fix https://bugs.webkit.org/show_bug.cgi?id=20860 REGRESSION: Crash in RenderLayer::hasVisibleContent() loading wavy.com
- WebView/WebFrame.mm: (-[WebFrame _getVisibleRect:]): Changed to check if the RenderPart has layout before accessing it, instead of checking if the frame inside it has layout.
- 11:14 PM Changeset in webkit [36485] by
-
- 10 edits2 adds in trunk/WebCore
2008-09-15 David Smith <catfish.man@gmail.com>
Reviewed by Sam Weinig.
Cache the result of parsing the an+b expression in :nth-child(an+b). Roughly a 2x speedup for :nth-child on SlickSpeed.
- GNUmakefile.am: Add CSSNthSelector
- WebCore.pro: Add CSSNthSelector
- WebCore.vcproj/WebCore.vcproj: Add CSSNthSelector
- WebCore.xcodeproj/project.pbxproj: Add CSSNthSelector
- css/CSSGrammar.y: Create CSSNthSelectors instead of CSSSelectors for :nth-*
- css/CSSNthSelector.cpp: Added. (WebCore::CSSNthSelector::parseNth): Moved from CSSStyleSelector and modified to cache (WebCore::CSSNthSelector::matchNth): Moved from CSSStyleSelector and modified to use the cache
- css/CSSNthSelector.h: Added. (WebCore::CSSNthSelector::CSSNthSelector): (WebCore::CSSNthSelector::~CSSNthSelector):
- css/CSSParser.cpp: (WebCore::CSSParser::createFloatingNthSelector):
- css/CSSParser.h:
- css/CSSSelector.h: Use the free bit here to store a flag for CSSNthSelector (WebCore::CSSSelector::CSSSelector):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Take advantage of knowing that all :nth-* selectors are CSSNthSelectors
- 11:12 PM Changeset in webkit [36484] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Complete my previous changelog entry
- 11:08 PM Changeset in webkit [36483] by
-
- 5 edits in trunk/JavaScriptCore
2008-09-15 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- speed up the === and !== operators by choosing the fast cases better
No effect on SunSpider but speeds up the V8 EarlyBoyer benchmark about 4%.
- VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_stricteq): (JSC::Machine::cti_op_nstricteq):
- kjs/JSImmediate.h: (JSC::JSImmediate::areBothImmediate):
- kjs/operations.cpp: (JSC::strictEqual): (JSC::strictEqualSlowCase):
- kjs/operations.h:
- 11:06 PM Changeset in webkit [36482] by
-
- 2 edits in trunk/JavaScriptCore
Coding style cleanup.
RS=Sam
- 10:54 PM Changeset in webkit [36481] by
-
- 2 edits in trunk/WebKitTools
2008-09-15 Alice Liu <alice.liu@apple.com>
A change needed to make PPC bots pass accessibility/table-cell-spans.html layout test
Reviewed by Stephanie Lewis.
- DumpRenderTree/mac/AccessibilityUIElementMac.mm: Calling -[NSValue rangeValue] on nil object was returning bogus results on PPC, but not Intel. Add a check for nil before calling. (AccessibilityUIElement::rowIndexRange): (AccessibilityUIElement::columnIndexRange):
- 10:53 PM Changeset in webkit [36480] by
-
- 8 edits in trunk/JavaScriptCore
Bug 20874: op_resolve does not do any form of caching
<https://bugs.webkit.org/show_bug.cgi?id=20874>
Reviewed by Cameron Zwarich
This patch adds an op_resolve_global opcode to handle (and cache)
property lookup we can statically determine must occur on the global
object (if at all).
3% progression on sunspider, 3.2x improvement to bitops-bitwise-and, and
10% in math-partial-sums
- 10:39 PM Changeset in webkit [36479] by
-
- 2 edits in trunk/LayoutTests
2008-09-15 Sam Weinig <sam@webkit.org>
Roll out r36478. It did little to help the issue either.
- fast/js/resources/garbage-collect-after-string-appends.js:
- 10:14 PM Changeset in webkit [36478] by
-
- 2 edits in trunk/LayoutTests
2008-09-15 Sam Weinig <sam@webkit.org>
Avoid the single character optimization.
- fast/js/resources/garbage-collect-after-string-appends.js:
- 9:34 PM Changeset in webkit [36477] by
-
- 2 edits in trunk/LayoutTests
2008-09-15 Sam Weinig <sam@webkit.org>
Roll out r36476. It did little to help the issue.
- fast/js/resources/garbage-collect-after-string-appends.js:
- 8:59 PM Changeset in webkit [36476] by
-
- 2 edits in trunk/LayoutTests
2008-09-15 Sam Weinig <sam@webkit.org>
Make this test a little more forgiving.
- fast/js/resources/garbage-collect-after-string-appends.js:
- 8:46 PM Changeset in webkit [36475] by
-
- 9 edits in trunk/JavaScriptCore
2008-09-15 Sam Weinig <sam@webkit.org>
Roll out r36462. It broke document.all.
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
- VM/CTI.h:
- VM/Machine.cpp: (JSC::Machine::Machine): (JSC::Machine::cti_op_eq_null): (JSC::Machine::cti_op_neq_null):
- VM/Machine.h: (JSC::Machine::isJSString):
- kjs/JSCell.h:
- kjs/JSWrapperObject.h:
- kjs/StringObject.h:
- kjs/StringObjectThatMasqueradesAsUndefined.h:
- 8:27 PM Changeset in webkit [36474] by
-
- 1 edit1 delete in trunk/LayoutTests
2008-09-15 Sam Weinig <sam@webkit.org>
http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase.html
now passes on Leopard in 10.5.5.
- platform/mac-leopard/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Removed.
- 7:46 PM Changeset in webkit [36473] by
-
- 2 edits in trunk/WebCore
2008-09-15 Matt Lilek <webkit@mattlilek.com>
Reviewed by Tim Hatcher.
Clean up some inspector JS callbacks to remove an extra return.
- page/InspectorController.cpp: (WebCore::hideDOMNodeHighlight): (WebCore::loaded): (WebCore::unloading): (WebCore::attach): (WebCore::detach): (WebCore::startDebuggingAndReloadInspectedPage): (WebCore::stopDebugging): (WebCore::debuggerAttached): (WebCore::pauseOnExceptions): (WebCore::pauseInDebugger): (WebCore::resumeDebugger): (WebCore::stepOverStatementInDebugger): (WebCore::stepIntoStatementInDebugger): (WebCore::stepOutOfFunctionInDebugger): (WebCore::isWindowVisible): (WebCore::closeWindow):
- 7:44 PM Changeset in webkit [36472] by
-
- 2 edits in trunk/JavaScriptCore
2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20863: ASSERTION FAILED: addressOffset < instructions.size() in CodeBlock::getHandlerForVPC
<https://bugs.webkit.org/show_bug.cgi?id=20863>
r36427 changed the number of arguments to op_construct without changing
the argument index for the vPC in the call to initializeCallFrame() in
the CTI case. This caused a JSC test failure. Correcting the argument
index fixes the test failure.
- VM/Machine.cpp: (JSC::Machine::cti_op_construct_JSConstruct):
- 7:30 PM Changeset in webkit [36471] by
-
- 1 edit in trunk/WebKit/win/WebCoreSupport/WebChromeClient.cpp
Scrollbars on Windows are now completely under the control of their theme classes. It is now possible to switch between Aqua scrollbars and native scrollbars via a preferences setting (the same one used for controls.
- 7:29 PM Changeset in webkit [36470] by
-
- 12 edits1 delete in trunk/WebCore
Scrollbars on Windows are now completely under the control of their theme classes. It is now possible to switch between Aqua scrollbars and native scrollbars via a preferences setting (the same one used for controls.
- 6:34 PM Changeset in webkit [36469] by
-
- 2 edits in trunk/JavaScriptCore
Fix GCC 4.2 build.
- 5:46 PM Changeset in webkit [36468] by
-
- 1 edit4 adds in trunk/LayoutTests
2008-09-15 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt.
Make transform animation behavior match spec
https://bugs.webkit.org/show_bug.cgi?id=20770
- transitions/transform-op-list-match-expected.txt: Added.
- transitions/transform-op-list-match.html: Added.
- transitions/transform-op-list-no-match-expected.txt: Added.
- transitions/transform-op-list-no-match.html: Added.
- 5:17 PM Changeset in webkit [36467] by
-
- 22 edits5 adds in trunk
<rdar://problem/4003789> Expose lists as AXList
<rdar://problem/5707399> VO: Definition lists not announced in Safari
https://bugs.webkit.org/show_bug.cgi?id=20808
Lists are now exposed through AX. On the mac (in SnowLeopard) they use two new subroles
AXContentList for <ul>, <ol> and AXDefinitionList for <dl>
Inside the definition list, each <dt> "term" has an accessibility description ("term"),
as does each <dd> tag ("definition")
- 5:01 PM Changeset in webkit [36466] by
-
- 47 edits2 deletes in trunk/WebCore
Reviewed by Eric.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=20865
Prepare HTMLScriptElement & SVGScriptElement unification, and unification of event handling.
Several renames:
dispatchHTMLEvent -> dispatchEventForType
setHTMLEventListener -> setEventListenerForType
getHTMLEventListener -> eventListenerForType
removeHTMLEventListener -> removeEventListenerForType
isHTMLEventListener -> isAttachedToEventTargetNode
...
Similar renames for the dispatch/get/set/*Window*Event functions.
Kill JSSVGLazyEventListener and merge with JSLazyEventListener.
Most important change: Rename setHTMLEventListener to setEventListenerForTypeAndAttribute,
as there exists a generic createEventListener() method now, taking care of JSLazyEventListener creation.
setHTMLEventListener() used createHTMLEventListener() before and was HTML specific.
SVG is able to use the code as well now. This affects most files in html/.
No functional changes.
- 4:44 PM Changeset in webkit [36465] by
-
- 8 edits in trunk/WebCore
Switch PlatformScrollbarWin's hit testing to use ScrollbarTheme. The file is now nearly completely empty. PlatformScrollbarSafari and PlatformScrollbarQt still need to be converted.
- 4:38 PM Changeset in webkit [36464] by
-
- 2 edits in trunk/JavaScriptCore
2008-09-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Fixed a typo in op_get_by_id_chain that caused it to miss every time
in the interpreter.
Also, a little cleanup.
- VM/Machine.cpp: (JSC::Machine::privateExecute): Set up baseObject before entering the loop, so we compare against the right values.
- 4:37 PM Changeset in webkit [36463] by
-
- 8 edits in trunk/JavaScriptCore
2008-09-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed the CalledAsConstructor flag from the call frame header. Now,
we use an explicit opcode at the call site to fix up constructor results.
SunSpider says 0.4% faster.
cti_op_construct_verify is an out-of-line function call for now, but we
can fix that once StructureID holds type information like isObject.
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Codegen for the new opcode.
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
- VM/CodeGenerator.cpp: Codegen for the new opcode. Also... (JSC::CodeGenerator::emitCall): ... don't test for known non-zero value. (JSC::CodeGenerator::emitConstruct): ... ditto.
- VM/Machine.cpp: No more CalledAsConstructor (JSC::Machine::privateExecute): Implementation for the new opcode. (JSC::Machine::cti_op_ret): The speedup: no need to check whether we were called as a constructor. (JSC::Machine::cti_op_construct_verify): Implementation for the new opcode.
- VM/Machine.h:
- VM/Opcode.h: Declare new opcode.
- VM/RegisterFile.h: (JSC::RegisterFile::): No more CalledAsConstructor
- 4:33 PM Changeset in webkit [36462] by
-
- 9 edits in trunk/JavaScriptCore
2008-09-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Inline code generation of eq_null/neq_null for CTI. Uses vptr checking for
StringObjectsThatAreMasqueradingAsBeingUndefined. In the long run, the
masquerading may be handled differently (through the StructureIDs - see bug
#20823).
1% on v8-tests.
- VM/CTI.cpp: (JSC::CTI::emitJumpSlowCaseIfIsJSCell): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
- VM/CTI.h:
- VM/Machine.cpp: (JSC::Machine::Machine): (JSC::Machine::cti_op_eq_null): (JSC::Machine::cti_op_neq_null):
- VM/Machine.h: (JSC::Machine::doesMasqueradesAsUndefined):
- kjs/JSWrapperObject.h: (JSC::JSWrapperObject::): (JSC::JSWrapperObject::JSWrapperObject):
- kjs/StringObject.h: (JSC::StringObject::StringObject):
- kjs/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
- 4:08 PM Changeset in webkit [36461] by
-
- 2 edits in trunk/WebCore
2008-09-15 David Smith <catfish.man@gmail.com>
"Just do it"'d by Mark Rowe
https://bugs.webkit.org/show_bug.cgi?id=20856
Add missing license header
- dom/NodeRenderStyle.h:
- 3:17 PM Changeset in webkit [36460] by
-
- 2 edits in trunk/JavaScriptCore
2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Rubber-stamped by Oliver Hunt.
r36427 broke CodeBlock::dump() by changing the number of arguments to
op_construct without changing the code that prints it. This patch fixes
it by printing the additional argument.
- JavaScriptCore.xcodeproj/project.pbxproj:
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
- 2:52 PM Changeset in webkit [36459] by
-
- 3 edits2 adds in trunk
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher.
Add default constructor for ShadowData
https://bugs.webkit.org/show_bug.cgi?id=20757
Test: transitions/shadow.html
- rendering/style/RenderStyle.h:
- 2:40 PM Changeset in webkit [36458] by
-
- 2 edits in trunk/WebCore
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher.
RenderStyle should update keyframes.
http://bugs.webkit.org/show_bug.cgi?id=20756
- rendering/style/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::updateKeyframes):
- 2:31 PM Changeset in webkit [36457] by
-
- 2 edits in trunk/WebCore
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher.
Unnecessary ASSERT in ImplicitAnimation destructor.
https://bugs.webkit.org/show_bug.cgi?id=20817
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::~ImplicitAnimation):
- 2:27 PM Changeset in webkit [36456] by
-
- 7 edits2 deletes in trunk/WebKit
WebKit:
2008-09-15 Anders Carlsson <andersca@apple.com>
Reviewed by Mitz.
Merge WebNetscapePluginStream into WebBaseNetscapePluginStream.
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2008-09-15 Anders Carlsson <andersca@apple.com>
Reviewed by Mitz.
Merge WebNetscapePluginStream into WebBaseNetscapePluginStream.
- Plugins/WebBaseNetscapePluginStream.h:
- Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream initWithFrameLoader:]): (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]): (-[WebBaseNetscapePluginStream start]): (-[WebBaseNetscapePluginStream stop]): (-[WebBaseNetscapePluginStream cancelLoadWithError:]):
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedResponse:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
- Plugins/WebNetscapePluginEmbeddedView.mm:
- Plugins/WebNetscapePluginStream.h: Removed.
- Plugins/WebNetscapePluginStream.mm: Removed.
- 2:22 PM Changeset in webkit [36455] by
-
- 2 adds in trunk/LayoutTests/transforms/2d/resources
Oops. Forgot this file in previous commit.
- 2:21 PM Changeset in webkit [36454] by
-
- 1 edit16 adds in trunk/LayoutTests
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher.
Tests for -webkit-transform
https://bugs.webkit.org/show_bug.cgi?id=20771
- transforms/2d/compound-2d-transforms-expected.txt: Added.
- transforms/2d/compound-2d-transforms.html: Added.
- transforms/2d/compound-transforms-vs-containers.html: Added.
- transforms/2d/transform-2d-expected.txt: Added.
- transforms/2d/transform-2d.html: Added.
- transforms/2d/transform-accuracy-expected.txt: Added.
- transforms/2d/transform-accuracy.html: Added.
- transforms/2d/transform-borderbox.html: Added.
- transforms/2d/transform-origin-borderbox.html: Added.
- transforms/2d/resources/transform-test-utils.js: Added.
- platform/mac/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.
- platform/mac/transforms/2d/transform-borderbox-expected.txt: Added.
- platform/mac/transforms/2d/transform-origin-borderbox-expected.txt: Added.
- 2:06 PM Changeset in webkit [36453] by
-
- 1 edit in trunk/WebCore/platform/win/ScrollbarThemeWin.cpp
Fix Win build bustage.
- 2:02 PM Changeset in webkit [36452] by
-
- 2 edits in trunk/WebKit/qt
Reviewed by Simon.
Yahoo assumes non-RFC compliant HTTP redirect behaviour. QtWebKit is (more)
compliant, so broken. I think the Yahoo-assumed behaviour is real-world standard.
Basically, Yahoo's login procedure for flickr looks like this:
- load flickr.com, click "sign in"
- this is a Yahoo page with a form
(https://login.yahoo.com/config/login?.src=flickr...)
when you click the "Sign In" button, the form submits to a yahoo.com POST URL
- The POST returns with a 302 (redirect) to another yahoo.com URL
- If you POST the redirected Location:, it all breaks. Yahoo assumes you will
convert the method to GET, which works fine but is definitely not
RFC-compliant. It would be compliant for 303, and the RFC says that many
implementations treat 302 and 303 the same way (for HTTP/1.0 compliance), but
converting to GET is explicitly wrong for 302.
- 1:59 PM Changeset in webkit [36451] by
-
- 1 edit7 adds in trunk/LayoutTests
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher
Tests for animations.
https://bugs.webkit.org/show_bug.cgi?id=20789
- animations/animation-test-helpers.js: Added.
- animations/generic-from-to-expected.txt: Added.
- animations/generic-from-to.html: Added.
- animations/multiple-animations-expected.txt: Added.
- animations/multiple-animations.html: Added.
- animations/multiple-keyframes-expected.txt: Added.
- animations/multiple-keyframes.html: Added.
- 1:53 PM Changeset in webkit [36450] by
-
- 2 edits in trunk/WebCore
Reviewed by Simon.
Fix plugin extension info. It was returning the mimetype where the
extension was given.
- 1:40 PM Changeset in webkit [36449] by
-
- 2 edits in trunk/WebCore
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher
Coding style violation!!!! Cleanup AnimationBase.cpp
- page/animation/AnimationBase.cpp: (WebCore::blendFunc):
- 1:03 PM Changeset in webkit [36448] by
-
- 9 edits in trunk/WebCore
2008-09-15 David Hyatt <hyatt@apple.com>
Move all hit testing code for scrollbars into the base class. Refactor
it to accommodate all platform-specific behaviors using virtual ScrollbarTheme
functions.
No platform is using this code yet. Although it has been moved and compiles
(even on Mac), it is not being used on any platform.
Reviewed by Sam Weinig
- platform/ScrollBar.cpp: (WebCore::Scrollbar::autoscrollPressedPart): (WebCore::Scrollbar::startTimerIfNeeded): (WebCore::Scrollbar::handleMouseMoveEvent): (WebCore::Scrollbar::handleMouseOutEvent): (WebCore::Scrollbar::handleMouseReleaseEvent): (WebCore::Scrollbar::handleMousePressEvent):
- platform/ScrollBar.h: (WebCore::Scrollbar::handleContextMenuEvent):
- platform/ScrollbarTheme.h: (WebCore::ScrollbarTheme::hitTest): (WebCore::ScrollbarTheme::invalidateOnMouseEnterExit): (WebCore::ScrollbarTheme::invalidatePart): (WebCore::ScrollbarTheme::shouldCenterOnThumb): (WebCore::ScrollbarTheme::centerOnThumb): (WebCore::ScrollbarTheme::thumbPosition): (WebCore::ScrollbarTheme::thumbLength): (WebCore::ScrollbarTheme::trackLength): (WebCore::ScrollbarTheme::initialAutoscrollTimerDelay): (WebCore::ScrollbarTheme::autoscrollTimerDelay):
- platform/Widget.h: (WebCore::Widget::parent):
- platform/mac/PlatformScrollBar.h: (WebCore::PlatformScrollbar::handleMouseMoveEvent): (WebCore::PlatformScrollbar::handleMouseOutEvent): (WebCore::PlatformScrollbar::handleMousePressEvent): (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
- platform/mac/WidgetMac.mm: (WebCore::Widget::convertFromContainingWindow):
- platform/win/ScrollbarThemeWin.cpp: (WebCore::ScrollbarThemeWin::invalidateOnMouseEnterExit):
- platform/win/ScrollbarThemeWin.h:
- 11:48 AM Changeset in webkit [36447] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
- fix <rdar://problem/5842247> Single long breakable word takes O(n2) to lay out
Cache the next breakable position for text nodes in InlineIterator.
- rendering/bidi.cpp: (WebCore::InlineIterator::InlineIterator): (WebCore::InlineIterator::increment): (WebCore::RenderBlock::findNextLineBreak):
- 10:10 AM Changeset in webkit [36446] by
-
- 2 edits in trunk/WebCore
2008-09-15 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
Fix assertion and integral pixel issue when creating subimages.
https://bugs.webkit.org/show_bug.cgi?id=20786
- platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):
- 8:16 AM Changeset in webkit [36445] by
-
- 2 edits in trunk/JavaScriptCore
Build fix
- kjs/StructureID.cpp: Removed a stray semicolon.
- 5:43 AM Changeset in webkit [36444] by
-
- 2 edits in trunk/WebCore
2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Implment seek() and clean up and improve debugging output
- 4:40 AM Changeset in webkit [36443] by
-
- 2 edits in trunk/WebCore
2008-09-15 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon.
Remove bogus Q_ASSERTs from the MediaPlayer Phonon implementation
m_mediaObject, m_audioOutput, m_videoWidget get created in the
c'tor and will only be deleted in the c'tor. The Q_ASSERTs would
only check if we use the MediaPlayerPrivate after it has been deleted.
Acked-by: Tor Arne Vestbø <tavestbo@trolltech.com>
- 4:35 AM Changeset in webkit [36442] by
-
- 5 edits in trunk
WebCore:
2008-09-15 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej.
<rdar://problem/6163988>
https://bugs.webkit.org/show_bug.cgi?id=20457
Canvas: createPattern crashes WebKit in WTF::RefPtr<WebCore::Image>::operator!() const + 9 with a 1D pattern
Check the width and height and throw an exception if any of them are 0.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
LayoutTests:
2008-09-15 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej.
<rdar://problem/6163988>
https://bugs.webkit.org/show_bug.cgi?id=20457
Canvas: createPattern crashes WebKit in WTF::RefPtr<WebCore::Image>::operator!() const + 9 with a 1D pattern
Add test for createPattern where the canvas passed in has a zero height/width.
- fast/canvas/canvas-with-incorrect-args-expected.txt:
- fast/canvas/canvas-with-incorrect-args.html:
- 4:28 AM Changeset in webkit [36441] by
-
- 2 edits in trunk/WebCore
2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Render media element controls with antialiasing enabled
- 4:27 AM Changeset in webkit [36440] by
-
- 2 edits in trunk/WebCore
2008-09-15 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Upon non fatal error, switch to the pause state (so that playback can continue)
- 4:22 AM Changeset in webkit [36439] by
-
- 2 edits in trunk/WebCore
2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Don't set WTF_USE_JSC in WebCore.pro now that it's set in config.h
- 4:16 AM Changeset in webkit [36438] by
-
- 7 edits in trunk
2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Make QtInstance::create() private and fix caching
- 3:43 AM Changeset in webkit [36437] by
-
- 2 edits in trunk/JavaScriptCore
2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Fix a crash in fast/js/exception-expression-offset.html caused by not
updating all mentions of the length of op_construct in r36427.
- VM/Machine.cpp: (JSC::Machine::cti_op_construct_NotJSConstruct):
- 3:20 AM Changeset in webkit [36436] by
-
- 4 edits in trunk/JavaScriptCore
2008-09-15 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- fix layout test failure introduced by fix for 20849
(The failing test was fast/js/delete-then-put.html)
- kjs/JSObject.cpp: (JSC::JSObject::removeDirect): Clear enumeration cache in the dictionary case.
- kjs/JSObject.h: (JSC::JSObject::putDirect): Ditto.
- kjs/StructureID.h: (JSC::StructureID::clearEnumerationCache): Inline to handle the clear.
- 3:02 AM Changeset in webkit [36435] by
-
- 2 edits in trunk/JavaScriptCore
2008-09-15 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- fix JSC test failures introduced by fix for 20849
- kjs/PropertyMap.cpp: (JSC::PropertyMap::getEnumerablePropertyNames): Use the correct count.
- 2:39 AM Changeset in webkit [36434] by
-
- 5 edits in trunk
2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20851: REGRESSION (r36410): fast/js/kde/GlobalObject.html fails
<https://bugs.webkit.org/show_bug.cgi?id=20851>
r36410 introduced an optimization for parseInt() that is incorrect when
its argument is larger than the range of a 32-bit integer. If the
argument is a number that is not an immediate integer, then the correct
behaviour is to return the floor of its value, unless it is an infinite
value, in which case the correct behaviour is to return 0.
- kjs/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt):
LayoutTests:
- fast/js/numeric-conversion-expected.txt:
- fast/js/resources/numeric-conversion.js:
- 2:13 AM Changeset in webkit [36433] by
-
- 1 edit in trunk/WebCore/platform/qt/ScrollbarThemeQt.cpp
Fix Qt build bustage.
- 1:45 AM Changeset in webkit [36432] by
-
- 3 edits in trunk/WebCore
2008-09-15 David Smith <catfish.man@gmail.com>
Reviewed by Dave Hyatt.
2x speedup on querySelector[All] with :nth-child by removing the collectRulesOnly argument on SelectorChecker.
With collectRulesOnly set to true (the default) an optimization is turned off, and no callers were intentionally leaving it true.
querySelector[All] assumed that the default was probably the right way to go, and so ended up being slow.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
- css/CSSStyleSelector.h:
- 1:34 AM Changeset in webkit [36431] by
-
- 1 edit in trunk/WebCore/platform/qt/ScrollbarThemeQt.cpp
Make sure ScrollbarThemeQt.cpp accurately reflects copyright information, since it contains code from PlatformScrollbarQt.cpp
- 1:31 AM Changeset in webkit [36430] by
-
- 2 edits in trunk/WebCore/platform/qt
Fix Qt build bustage.
- 12:27 AM Changeset in webkit [36429] by
-
- 6 edits in trunk/JavaScriptCore
2008-09-15 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Patch for https://bugs.webkit.org/show_bug.cgi?id=20849
Cache property names for getEnumerablePropertyNames in the StructureID.
~0.5% speedup on Sunspider overall (9.7% speedup on string-fasta). ~1% speedup
on the v8 test suite.
- kjs/JSObject.cpp: (JSC::JSObject::getPropertyNames):
- kjs/PropertyMap.cpp: (JSC::PropertyMap::getEnumerablePropertyNames):
- kjs/PropertyMap.h:
- kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::getEnumerablePropertyNames):
- kjs/StructureID.h:
Sep 14, 2008:
- 11:33 PM Changeset in webkit [36428] by
-
- 11 edits in trunk/WebCore
Refactor painting of the native windows scrollbar and prepare for code sharing with the Aqua windows scrollbar.
- 11:26 PM Changeset in webkit [36427] by
-
- 4 edits in trunk/JavaScriptCore
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- speed up JS construction by extracting "prototype" lookup so PIC applies.
~0.5% speedup on SunSpider
Speeds up some of the V8 tests as well, most notably earley-boyer.
- VM/CTI.cpp: (JSC::CTI::compileOpCall): Account for extra arg for prototype. (JSC::CTI::privateCompileMainPass): Account for increased size of op_construct.
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitConstruct): Emit separate lookup to get prototype property.
- VM/Machine.cpp: (JSC::Machine::privateExecute): Expect prototype arg in op_construct. (JSC::Machine::cti_op_construct_JSConstruct): ditto (JSC::Machine::cti_op_construct_NotJSConstruct): ditto
- 10:38 PM Changeset in webkit [36426] by
-
- 3 edits in trunk/WebCore
Moving all resource graphs under the same container for future scalable feature.
This is a speedup on resize but maybe a loss on changing the sorting function.
Reviewed by Timothy Hatcher.
- page/inspector/ResourcesPanel.js: Added a container for all resource graphs. Added WebInspector.ResourceGraph. No more _updateGraphBars on resize.
- page/inspector/inspector.css: Edited corresponding rules and removed unnecessaries.
- 10:05 PM Changeset in webkit [36425] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Eric Seidel.
Add a protected destructor for RefCounted.
It is wrong to call its destructor directly, because (1) this should be taken care of by
deref(), and (2) many classes that use RefCounted have non-virtual destructors.
No change in behavior.
- wtf/RefCounted.h: (WTF::RefCounted::~RefCounted):
- 10:00 PM Changeset in webkit [36424] by
-
- 1 edit in trunk/WebCore/platform/qt/ScrollbarThemeQt.cpp
Fix Qt bustage.
- 9:52 PM Changeset in webkit [36423] by
-
- 4 edits2 adds in trunk
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=20738
compareBoundaryPoints gives incorrect results
Test: fast/dom/Range/compareBoundaryPoints-2.html
- dom/Range.cpp: (WebCore::Range::compareBoundaryPoints): Correct meanings of START_TO_END and END_TO_START.
- page/DOMSelection.cpp: (WebCore::DOMSelection::addRange): Updated for this change.
- 8:10 PM Changeset in webkit [36422] by
-
- 2 edits in trunk/WebCore
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Unreviewed build fix.
Trying again.
- bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::hasInstance):
- 7:55 PM Changeset in webkit [36421] by
-
- 3 edits in trunk/WebCore
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Unreviewed build fix.
Blind attempt to fix build. Correct parameters for hasInstance.
- bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::hasInstance):
- bindings/js/JSQuarantinedObjectWrapper.h:
- 7:23 PM Changeset in webkit [36420] by
-
- 3 edits4 deletes in trunk
WebCore:
Rubber-stamped by Sam Weinig.
- revert <http://trac.webkit.org/changeset/36382> because it exposed <https://bugs.webkit.org/show_bug.cgi?id=20846> and resulted in crashes on Tiger.
- platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getLastResortFallbackFont):
LayoutTests:
Rubber-stamped by Sam Weinig.
- revert <http://trac.webkit.org/changeset/36382> because it exposed <https://bugs.webkit.org/show_bug.cgi?id=20846> and resulted in crashes on Tiger.
- platform/mac/fast/text/last-resort-font-expected.checksum: Removed.
- platform/mac/fast/text/last-resort-font-expected.png: Removed.
- platform/mac/fast/text/last-resort-font-expected.txt: Removed.
- platform/mac/fast/text/last-resort-font.html: Removed.
- 7:21 PM Changeset in webkit [36419] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Now with all new and improved Changelog in the correct order.
- 7:18 PM Changeset in webkit [36418] by
-
- 8 edits in trunk/JavaScriptCore
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- split the "prototype" lookup for hasInstance into opcode stream so it can be cached
~5% speedup on v8 earley-boyer test
- API/JSCallbackObject.h: Add a parameter for the pre-looked-up prototype.
- API/JSCallbackObjectFunctions.h: (JSC::::hasInstance): Ditto.
- API/JSValueRef.cpp: (JSValueIsInstanceOfConstructor): Look up and pass in prototype.
- JavaScriptCore.exp:
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Pass along prototype.
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump): Print third arg.
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitInstanceOf): Implement this, now that there is a third argument.
- VM/CodeGenerator.h:
- VM/Machine.cpp: (JSC::Machine::privateExecute): Pass along the prototype. (JSC::Machine::cti_op_instanceof): ditto
- kjs/JSObject.cpp: (JSC::JSObject::hasInstance): Expect to get a pre-looked-up prototype.
- kjs/JSObject.h:
- kjs/nodes.cpp: (JSC::InstanceOfNode::emitCode): Emit a get_by_id of the prototype property and pass that register to instanceof.
- kjs/nodes.h:
- 7:13 PM Changeset in webkit [36417] by
-
- 14 edits in trunk/JavaScriptCore
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- split the "prototype" lookup for hasInstance into opcode stream so it can be cached
~5% speedup on v8 earley-boyer test
- API/JSCallbackObject.h: Add a parameter for the pre-looked-up prototype.
- API/JSCallbackObjectFunctions.h: (JSC::::hasInstance): Ditto.
- API/JSValueRef.cpp: (JSValueIsInstanceOfConstructor): Look up and pass in prototype.
- JavaScriptCore.exp:
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Pass along prototype.
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump): Print third arg.
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitInstanceOf): Implement this, now that there is a third argument.
- VM/CodeGenerator.h:
- VM/Machine.cpp: (JSC::Machine::privateExecute): Pass along the prototype. (JSC::Machine::cti_op_instanceof): ditto
- kjs/JSObject.cpp: (JSC::JSObject::hasInstance): Expect to get a pre-looked-up prototype.
- kjs/JSObject.h:
- kjs/nodes.cpp: (JSC::InstanceOfNode::emitCode): Emit a get_by_id of the prototype property and pass that register to instanceof.
- kjs/nodes.h:
- 5:56 PM Changeset in webkit [36416] by
-
- 4 edits2 adds in trunk/WebCore
Add ScrollbarThemeComposite for use by ScrollbarThemeSafari and ScrollbarThemeWin
- 5:53 PM Changeset in webkit [36415] by
-
- 1 edit in trunk/WebCore/platform/qt/ScrollbarThemeQt.cpp
Fix Qt build bustage.
- 5:36 PM Changeset in webkit [36414] by
-
- 1 edit in trunk/WebCore/platform/win/ScrollbarThemeSafari.h
Fix Win build bustage.
- 5:35 PM Changeset in webkit [36413] by
-
- 2 edits in trunk/JavaScriptCore
2008-09-14 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Remove unnecessary virtual function call from cti_op_call_JSFunction -
~5% on richards, ~2.5% on v8-tests, ~0.5% on sunspider.
- VM/Machine.cpp: (JSC::Machine::cti_op_call_JSFunction):
- 5:26 PM Changeset in webkit [36412] by
-
- 11 edits3 adds in trunk
2008-09-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20827: the 'typeof' operator is slow
<https://bugs.webkit.org/show_bug.cgi?id=20827>
Optimize the 'typeof' operator when its result is compared to a constant
string.
This is a 5.5% speedup on the V8 Earley-Boyer test.
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (JSC::jsIsObjectType): (JSC::jsIsFunctionType): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_is_undefined): (JSC::Machine::cti_op_is_boolean): (JSC::Machine::cti_op_is_number): (JSC::Machine::cti_op_is_string): (JSC::Machine::cti_op_is_object): (JSC::Machine::cti_op_is_function):
- VM/Machine.h:
- VM/Opcode.h:
- kjs/nodes.cpp: (JSC::BinaryOpNode::emitCode): (JSC::EqualNode::emitCode): (JSC::StrictEqualNode::emitCode):
- kjs/nodes.h:
LayoutTests:
- fast/js/resources/typeof-codegen-crash.js: Added.
- fast/js/typeof-codegen-crash-expected.txt: Added.
- fast/js/typeof-codegen-crash.html: Added.
- 5:20 PM Changeset in webkit [36411] by
-
- 4 edits in trunk/WebCore
2008-09-14 Alp Toker <alp@nuanti.com>
https://bugs.webkit.org/show_bug.cgi?id=20320
[GTK] A white rectangle is visible behind widgets with rounded corners
Sync bundled gtk2drawing.c to the latest version from Mozilla (coding
style exempt).
Requested by Michael Monreal.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk):
- platform/gtk/gtk2drawing.c: (moz_gtk_set_widget_name): (ensure_window_widget): (setup_widget_prototype): (ensure_button_arrow_widget): (moz_gtk_get_combo_box_inner_button): (moz_gtk_get_combo_box_button_inner_widgets): (ensure_combo_box_widgets): (moz_gtk_get_combo_box_entry_inner_widgets): (moz_gtk_get_combo_box_entry_arrow): (ensure_combo_box_entry_widgets): (ensure_toolbar_widget): (ensure_tooltip_widget): (ensure_menu_bar_widget): (ensure_menu_bar_item_widget): (ensure_menu_popup_widget): (ensure_menu_item_widget): (ensure_image_menu_item_widget): (ensure_menu_separator_widget): (ensure_check_menu_item_widget): (ensure_tree_header_cell_widget): (ensure_scrolled_window_widget): (moz_gtk_button_paint): (moz_gtk_init): (moz_gtk_button_get_inner_border): (moz_gtk_toggle_paint): (calculate_button_inner_rect): (calculate_arrow_rect): (moz_gtk_scrollbar_button_paint): (moz_gtk_scrollbar_thumb_paint): (moz_gtk_caret_paint): (moz_gtk_entry_paint): (moz_gtk_treeview_paint): (moz_gtk_tree_header_cell_paint): (moz_gtk_combo_box_paint): (moz_gtk_downarrow_paint): (moz_gtk_combo_box_entry_button_paint): (moz_gtk_toolbar_paint): (moz_gtk_tab_scroll_arrow_paint): (moz_gtk_menu_bar_paint): (moz_gtk_menu_item_paint): (moz_gtk_get_widget_border): (moz_gtk_get_combo_box_entry_button_size): (moz_gtk_get_tab_scroll_arrow_size): (moz_gtk_get_downarrow_size): (moz_gtk_images_in_menus): (moz_gtk_widget_paint): (moz_gtk_shutdown):
- platform/gtk/gtkdrawing.h:
- 5:12 PM Changeset in webkit [36410] by
-
- 2 edits in trunk/JavaScriptCore
2008-09-14 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Patch for https://bugs.webkit.org/show_bug.cgi?id=20844
Speed up parseInt for numbers
Sunspider reports this as 1.029x as fast overall and 1.37x as fast on string-unpack-code.
No change on the v8 suite.
- kjs/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt): Don't convert numbers to strings just to convert them back to numbers.
- 4:55 PM Changeset in webkit [36409] by
-
- 17 edits in trunk/WebCore
2008-09-14 David Hyatt <hyatt@apple.com>
Convert Mac, Gtk, wx and Qt over to the new ScrollbarTheme for
painting. Mac and Gtk themes don't do anything and just let the
underlying widget paint. Qt now uses the theme to paint. wx doesn't
do anything yet.
Reviewed by Sam Weinig
- platform/ScrollBar.cpp: (WebCore::Scrollbar::paint):
- platform/ScrollBar.h: (WebCore::Scrollbar::value): (WebCore::Scrollbar::visibleSize): (WebCore::Scrollbar::maximum): (WebCore::Scrollbar::lineStep): (WebCore::Scrollbar::pageStep): (WebCore::Scrollbar::pixelStep): (WebCore::Scrollbar::pressedPart): (WebCore::Scrollbar::hoveredPart): (WebCore::Scrollbar::theme):
- platform/ScrollbarTheme.h: (WebCore::ScrollbarTheme::paint): (WebCore::ScrollbarTheme::scrollbarThickness): (WebCore::ScrollbarTheme::supportsControlTints): (WebCore::ScrollbarTheme::themeChanged):
- platform/gtk/PlatformScrollBar.h:
- platform/gtk/PlatformScrollBarGtk.cpp:
- platform/mac/PlatformScrollBar.h:
- platform/mac/PlatformScrollBarMac.mm:
- platform/qt/PlatformScrollBar.h:
- platform/qt/PlatformScrollBarQt.cpp:
- platform/qt/ScrollbarThemeQt.cpp: (WebCore::styleOptionSlider):
- platform/qt/ScrollbarThemeQt.h: (WebCore::ScrollbarThemeQt::paint):
- platform/win/PlatformScrollBarSafari.cpp: (WebCore::PlatformScrollbar::paint):
- platform/win/ScrollbarThemeSafari.h: (WebCore::ScrollbarThemeSafari::supportsControlTints):
- platform/wx/PlatformScrollBar.h:
- platform/wx/TemporaryLinkStubs.cpp: (PlatformScrollbar::~PlatformScrollbar):
- 4:01 PM Changeset in webkit [36408] by
-
- 7 edits in trunk/JavaScriptCore
2008-09-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver Hunt.
Bug 20816: op_lesseq should be optimized
<https://bugs.webkit.org/show_bug.cgi?id=20816>
Add a loop_if_lesseq opcode that is similar to the loop_if_less opcode.
This is a 9.4% speedup on the V8 Crypto benchmark.
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitJumpIfTrue):
- VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_loop_if_lesseq):
- VM/Machine.h:
- VM/Opcode.h:
- 3:15 PM Changeset in webkit [36407] by
-
- 2 edits in trunk/WebCore
2008-09-14 Sam Weinig <sam@webkit.org>
Qt build fix.
- platform/qt/PlatformScrollBarQt.cpp:
- 3:12 PM Changeset in webkit [36406] by
-
- 12 edits in trunk
2008-09-14 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Remove extraneous semicolons.
- kjs/nodes.cpp: (JSC::PrefixResolveNode::emitCode):
- wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::GrowHeap):
WebCore:
2008-09-14 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Remove extraneous semicolons.
- bindings/scripts/CodeGeneratorObjC.pm:
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::tokenizeRelAttribute):
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::charsetAttributeValue): (WebCore::HTMLScriptElement::typeAttributeValue):
- platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
- platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollbars):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintEllipsisBoxes):
- svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::toPathData):
- 3:00 PM Changeset in webkit [36405] by
-
- 2 edits in trunk/WebCore
2008-09-14 Sam Weinig <sam@webkit.org>
Qt build fix.
- platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::updateScrollbars):
- 2:36 PM Changeset in webkit [36404] by
-
- 2 edits in trunk/WebCore
2008-09-14 Sam Weinig <sam@webkit.org>
Qt build fix.
- platform/qt/PlatformScrollBarQt.cpp: (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::paint):
- 2:33 AM Changeset in webkit [36403] by
-
- 3 edits in trunk/WebKitTools
Build fix.
- 1:33 AM Changeset in webkit [36402] by
-
- 5 edits in trunk/JavaScriptCore
2008-09-14 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Cleanup Sampling code.
- VM/CTI.cpp: (JSC::CTI::emitCall): (JSC::CTI::privateCompileMainPass):
- VM/CTI.h: (JSC::CTI::execute):
- VM/SamplingTool.cpp: (JSC::): (JSC::SamplingTool::run): (JSC::SamplingTool::dump):
- VM/SamplingTool.h: (JSC::SamplingTool::callingHostFunction):
- 1:18 AM Changeset in webkit [36401] by
-
- 13 edits in trunk/JavaScriptCore
Bug 20821: Cache property transitions to speed up object initialization
https://bugs.webkit.org/show_bug.cgi?id=20821
Reviewed by Cameron Zwarich.
Implement a transition cache to improve the performance of new properties
being added to objects. This is extremely beneficial in constructors and
shows up as a 34% improvement on access-binary-trees in SunSpider (0.8%
overall)
