Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Oct 15, 2008:

11:41 PM Changeset in webkit [37630] by ap@webkit.org

• 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=21610
run-webkit-threads --threaded crashes in StructureID destructor

• kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::~StructureID): Protect access to a static (debug-only) HashSet with a lock.

10:31 PM Changeset in webkit [37629] by weinig@apple.com

• 3 edits in trunk/JavaScriptCore

2008-10-15 Sam Weinig <​sam@webkit.org>

Reviewed by Goeffrey Garen.

Add function to dump statistics for StructureIDs.

• kjs/StructureID.cpp: (JSC::StructureID::dumpStatistics): (JSC::StructureID::StructureID): (JSC::StructureID::~StructureID):
• kjs/StructureID.h:

9:56 PM Changeset in webkit [37628] by jhoneycutt@apple.com

• 2 edits in trunk/WebCore

2008-10-15 Jon Honeycutt <​jhoneycutt@apple.com>

Remove unneeded check of whether a Page defers loading before running it
in a modal dialog.

No test possible.

Reviewed by Tim Hatcher.

• page/Chrome.cpp:

9:36 PM Changeset in webkit [37627] by cwzwarich@webkit.org

• 3 edits in trunk/JavaScriptCore

2008-10-15 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 21633: Avoid using a HashMap when there is only a single transition
<​https://bugs.webkit.org/show_bug.cgi?id=21633>

This is a 0.8% speedup on SunSpider and between a 0.5% and 1.0% speedup
on the V8 benchmark suite, depending on which harness we use. It will
also slightly reduce the memory footprint of a StructureID.

• kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::~StructureID): (JSC::StructureID::addPropertyTransition):
• kjs/StructureID.h: (JSC::StructureID::):

8:09 PM Changeset in webkit [37626] by mrowe@apple.com

• 2 edits in trunk/WebKit/mac

Fix a leak of a CFStringRef reported by the build bot.

Reviewed by Jon Honeycutt.

• Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): Use a autoreleased
NSString rather than manually releasing a CFStringRef when we're done with it.

7:36 PM Changeset in webkit [37625] by ggaren@apple.com

• 2 edits in trunk/JavaScriptCore

2008-10-15 Csaba Osztrogonac <​oszi@inf.u-szeged.hu>

Reviewed by Geoffrey Garen.

1.40% speedup on SunSpider, 1.44% speedup on V8. (Linux)

No change on Mac.

• VM/Machine.cpp: (JSC::fastIsNumber): ALWAYS_INLINE modifier added.

6:14 PM Changeset in webkit [37624] by andersca@apple.com

• 2 edits in trunk/WebKit/mac

2008-10-15 Kenneth Russell <​kenneth.russell@sun.com>

Reviewed and landed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=21572

Initialize pluginFunc.size to the correct size before calling NP_GetEntryPoints.

• Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):

6:05 PM Changeset in webkit [37623] by mrowe@apple.com

• 2 edits in trunk/WebKit/mac

<rdar://problem/6272508> Crash occurs after loading flash content at ​http://www.macrumors.com/

Restore some code related to the CoreGraphics drawing model that was misplaced in r37131.

Reviewed by Dan Bernstein.

• Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView invalidateRegion:]):
(-[WebBaseNetscapePluginView setVariable:value:]):

4:33 PM Changeset in webkit [37622] by ggaren@apple.com

• 32 edits
  2 copies
  1 add in trunk

JavaScriptCore:

2008-10-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=21345
Start the debugger without reloading the inspected page

• JavaScriptCore.exp: New symbols.
• JavaScriptCore.xcodeproj/project.pbxproj: New files.

• VM/CodeBlock.h: (JSC::EvalCodeCache::get): Updated for tweak to parsing API.

• kjs/CollectorHeapIterator.h: Added. An iterator for the object heap, which we use to find all the live functions and recompile them.

• kjs/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate): Updated for tweak to parsing API.

• kjs/FunctionConstructor.cpp: (JSC::constructFunction): Updated for tweak to parsing API.

• kjs/JSFunction.cpp: (JSC::JSFunction::JSFunction): Try to validate our SourceCode in debug builds by ASSERTing that it's syntactically valid. This doesn't catch all SourceCode bugs, but it catches a lot of them.

• kjs/JSGlobalObjectFunctions.cpp: (JSC::globalFuncEval): Updated for tweak to parsing API.

• kjs/Parser.cpp: (JSC::Parser::parse):
• kjs/Parser.h: (JSC::Parser::parse): Tweaked the parser to make it possible to parse without an ExecState, and to allow the client to specify a debugger to notify (or not) about the source we parse. This allows the inspector to recompile even though no JavaScript is executing, then notify the debugger about all source code when it's done.

• kjs/Shell.cpp: (prettyPrintScript): Updated for tweak to parsing API.

• kjs/SourceRange.h: (JSC::SourceCode::isNull): Added to help with ASSERTs.

• kjs/collector.cpp: (JSC::Heap::heapAllocate): (JSC::Heap::sweep): (JSC::Heap::primaryHeapBegin): (JSC::Heap::primaryHeapEnd):
• kjs/collector.h: (JSC::): Moved a bunch of declarations around to enable compilation of CollectorHeapIterator.

• kjs/interpreter.cpp: (JSC::Interpreter::checkSyntax): (JSC::Interpreter::evaluate): Updated for tweak to parsing API.

• kjs/lexer.h: (JSC::Lexer::sourceCode): BUG FIX: Calculate SourceCode ranges relative to the SourceCode range in which we're lexing, otherwise nested functions that are compiled individually get SourceCode ranges that don't reflect their nesting.

• kjs/nodes.cpp: (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::finishParsing): (JSC::FunctionBodyNode::create): (JSC::FunctionBodyNode::copyParameters):
• kjs/nodes.h: (JSC::ScopeNode::setSource): (JSC::FunctionBodyNode::parameterCount): Added some helper functions for copying one FunctionBodyNode's parameters to another. The recompiler uses these when calling "finishParsing".

WebCore:

2008-10-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=21345
Start the debugger without reloading the inspected page

• WebCore.base.exp: New symbols.

• ForwardingHeaders/kjs/CollectorHeapIterator.h: Copied from ForwardingHeaders/kjs/ustring.h.
• ForwardingHeaders/kjs/Parser.h: Copied from ForwardingHeaders/kjs/ustring.h.
• WebCore.xcodeproj/project.pbxproj: New forwarding headers.

• inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::startDebugging):
• inspector/InspectorController.h: Renamed startDebuggingAndReloadInspectedPage to startDebugging, and changed its behavior to match.

• inspector/JavaScriptDebugListener.h:
• inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::JavaScriptDebugServer): (WebCore::JavaScriptDebugServer::addListener): (WebCore::JavaScriptDebugServer::removeListener): (WebCore::JavaScriptDebugServer::recompileAllJSFunctions): (WebCore::JavaScriptDebugServer::willAddFirstListener): (WebCore::JavaScriptDebugServer::didRemoveLastListener):
• inspector/JavaScriptDebugServer.h: Refactored the JavaScriptDebugServer to centralize handling of adding the first listener and removing the last. Then, added a feature to recompile all JS functions in these cases. This allows us to dynamically add and remove hooks like the debugger hooks without reloading the page.

• inspector/front-end/ScriptsPanel.js:
• English.lproj/localizedStrings.js: Updated for startDebuggingAndReloadInspectedPage => startDebugging rename. Removed all UI that claimed that starting the debugger would reload the page.

WebKit/mac:

2008-10-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=21345
Start the debugger without reloading the inspected page

• WebInspector/WebInspector.mm: (-startDebuggingJavaScript:): Updated for rename.

WebKit/win:

2008-10-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=21345
Start the debugger without reloading the inspected page

• WebInspector.cpp: (WebInspector::toggleDebuggingJavaScript): Updated for rename.

3:22 PM Changeset in webkit [37621] by zecke@webkit.org

• 2 edits in trunk/WebCore

2008-10-15 Holger Hans Peter Freyther <​zecke@selfish.org>

Build fix attempt.

Try to fix static/non-static declaration of g_string_append_uri_escape
by renaming that string. Another look needs to be taken.

• platform/gtk/guriescape.c: (_webcore_g_string_append_uri_escaped): (_webcore_g_uri_escape_string):

3:10 PM Changeset in webkit [37620] by adele@apple.com

• 2 edits in trunk/WebCore

2008-10-15 Adele Peterson <​adele@apple.com>

Attempt to fix the Tiger build.

• platform/network/mac/ResourceHandleMac.mm:

3:08 PM Changeset in webkit [37619] by zecke@webkit.org

• 2 edits in trunk/WebCore

Build fix for Cairo after changes to BitmapeImage.h

3:01 PM Changeset in webkit [37618] by zecke@webkit.org

• 2 edits in trunk/WebCore

2008-10-15 Jeff Cook <​cookiecaper@gmail.com>

Reviewed by Holger Freyther.

Stop SIGSEGV when leaving a page with a Flash object by reordering
window destruction and plugin stop.

See ​https://bugs.webkit.org/show_bug.cgi?id=20779

• plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::stop):

3:01 PM Changeset in webkit [37617] by mrowe@apple.com

• 2 edits in trunk/WebKit

<rdar://problem/5803460> A file named StringsNotToBeLocalized.txt file is installed Webkit.framework/Resources.

Rubber-stamped by Brady Eidson.

• WebKit.xcodeproj/project.pbxproj: Don't install StringsNotToBeLocalized.txt.

2:53 PM Changeset in webkit [37616] by adele@apple.com

• 4 edits in trunk/WebCore

2008-10-15 Adele Peterson <​adele@apple.com>

Reviewed by Sam Weinig.

Implement didSendBodyData delegate method, and use older code path when that delegate doesn't exist.

• platform/network/ResourceHandle.h:
• platform/network/mac/FormDataStreamMac.mm: (WebCore::formRead):
• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didSendBodyDataDelegateExists): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):

2:11 PM Changeset in webkit [37615] by pkasting@chromium.org

• 2 edits in trunk/WebCore

2008-10-15 Peter Kasting <​pkasting@google.com>

Reviewed by David Hyatt.

Qt build bustage fix.

• platform/graphics/qt/StillImageQt.h: (WebCore::StillImage::destroyDecodedData):

2:06 PM Changeset in webkit [37614] by hyatt@apple.com

• 2 edits in trunk/WebCore

2008-10-15 David Hyatt <​hyatt@apple.com>

Make sure scrollbar styles get deleted if they aren't assigned to a renderer.

Reviewed by Mark Rowe

• rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::getScrollbarPseudoStyle): (WebCore::RenderScrollbar::updateScrollbarPart):

1:53 PM Changeset in webkit [37613] by zecke@webkit.org

• 4 edits in trunk/WebCore

2008-10-15 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Holger Freyther.

​http://bugs.webkit.org/show_bug.cgi?id=21211
[CURL] Upload doesn't work because cancel is called

FormDataStream::read returns 0 when retrieving data from the form
fails, but also when there is no more data to send. This means that
ResourceHandleManager::cancel is always called even when the data was
successfully sent.

Check if there are more elements in the form before calling
FormDataStream::read.

• platform/network/curl/FormDataStreamCurl.cpp: (WebCore::FormDataStream::hasMoreElements):
• platform/network/curl/FormDataStreamCurl.h:
• platform/network/curl/ResourceHandleManager.cpp: (WebCore::readCallback):

1:38 PM Changeset in webkit [37612] by pkasting@chromium.org

• 11 edits in trunk/WebCore

2008-10-15 Peter Kasting <​pkasting@google.com>

Reviewed by David Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=19663 (Second attempt)
Account for paint and timer lag when animating images. Also pretend
that images whose animations were paused (by becoming invisible)
continued to animate, by "catching up" to the correct frame when they're
shown again.

• platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::destroyDecodedData): (WebCore::BitmapImage::cacheFrame): (WebCore::BitmapImage::frameIsCompleteAtIndex): (WebCore::BitmapImage::frameDurationAtIndex): (WebCore::BitmapImage::frameHasAlphaAtIndex): (WebCore::BitmapImage::repetitionCount): (WebCore::BitmapImage::shouldAnimate): (WebCore::BitmapImage::startAnimation): (WebCore::BitmapImage::resetAnimation): (WebCore::BitmapImage::advanceAnimation): (WebCore::BitmapImage::internalAdvanceAnimation): (WebCore::BitmapImage::notifyObserverAndTrimDecodedData):
• platform/graphics/BitmapImage.h: (WebCore::FrameData::FrameData): (WebCore::BitmapImage::):
• platform/graphics/GeneratedImage.h: (WebCore::GeneratedImage::destroyDecodedData):
• platform/graphics/Image.h:
• platform/graphics/cairo/ImageCairo.cpp: (WebCore::FrameData::clear): (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::draw):
• platform/graphics/cg/ImageCG.cpp: (WebCore::FrameData::clear): (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::draw):
• platform/graphics/cg/PDFDocumentImage.h: (WebCore::PDFDocumentImage::destroyDecodedData):
• platform/graphics/qt/ImageQt.cpp: (WebCore::FrameData::clear): (WebCore::BitmapImage::draw):
• platform/graphics/wx/ImageWx.cpp: (WebCore::FrameData::clear): (WebCore::BitmapImage::draw):
• svg/graphics/SVGImage.h: (WebCore::SVGImage::destroyDecodedData):

1:32 PM Changeset in webkit [37611] by Beth Dakin

• 9 edits
  2 adds in trunk

WebCore:

2008-10-14 Maxime Britto <​britto@apple.com>

Reviewed by Darin Adler, tweaked and landed by Beth.

• WebCore.base.exp: Exposes two functions to be able to create a selection from a point on the screen. Also exposes the new TextIterator::currentNode function.
• WebCore/editing/TextIterator.cpp: (TextIterator::currentNode) : New function that returns the current text node or NULL if there is no text node.

WebKit:

2008-10-14 Maxime Britto <​britto@apple.com>

Reviewed by Darin Adler.

• WebKit.xcodeproj/project.pbxproj: Added two files for the WebTextIterator, and made the WebTextIterator.h private

WebKit/mac:

2008-10-14 Maxime Britto <​britto@apple.com>

Reviewed by Darin Adler.

Added SPI to use WebCore's TextIterator with WebKit.

• WebView/WebTextIterator.h: Added.
• WebView/WebTextIterator.mm: Added. (-[WebTextIteratorPrivate dealloc]): (-[WebTextIterator dealloc]): (-[WebTextIterator initWithRange:]): Creates a TextIterator instance (-[WebTextIterator advance]): Asks the iterator to advance() . (-[WebTextIterator currentNode]): Returns the current DOMNode from the iterator (-[WebTextIterator currentText]): Returns the current text from the iterator (-[WebTextIterator atEnd]): Indicated whether the iterator has reached the end of the range.
• WebView/WebView.h:
• WebView/WebView.mm: (-[WebView textIteratorForRect:]): Returns a WebTextIterator with the DOMRange contained in the rectangle given as a parameter.

1:18 PM Changeset in webkit [37610] by zecke@webkit.org

• 7 edits
  2 adds in trunk/WebCore

2008-10-15 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Holger Freyther.

​http://bugs.webkit.org/show_bug.cgi?id=20664
[GTK] File names are not always encodable in UTF-8

On Linux file names are just raw data and cannot always be directly
encoded in UTF-8 or in any other encodings, so we escape them before
storing the file name in a String and unescape them before passing
them to native functions handling files.

• GNUmakefile.am:
• platform/FileSystem.h:
• platform/gtk/FileChooserGtk.cpp: (WebCore::stringByAdoptingFileSystemRepresentation): (WebCore::FileChooser::basenameForWidth):
• platform/gtk/FileSystemGtk.cpp: (WebCore::filenameToString): (WebCore::filenameFromString): (WebCore::filenameForDisplay): (WebCore::fileExists): (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::makeAllDirectories): (WebCore::homeDirectoryPath): (WebCore::pathGetFileName): (WebCore::listDirectory):
• platform/gtk/KURLGtk.cpp: (WebCore::KURL::fileSystemPath):
• platform/gtk/SharedBufferGtk.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
• platform/gtk/guriescape.c: Added. (is_valid): (gunichar_ok): (g_string_append_uri_escaped): (_webcore_g_uri_escape_string):
• platform/gtk/guriescape.h: Added.

11:23 AM Changeset in webkit [37609] by Adam Roben

• 3 edits in trunk/WebKit/win

Export WTF::Mutex::tryLock

• WebKit.vcproj/WebKit.def:
• WebKit.vcproj/WebKit_debug.def:

11:19 AM Changeset in webkit [37608] by sfalken@apple.com

• 1 edit in tags/Safari-6528.4.2/WebCore/WebCore.vcproj/WebCore.submit.sln

Merge r37596.

11:12 AM Changeset in webkit [37607] by sfalken@apple.com

• 1 copy in tags/Safari-6528.4.2

New tag.

10:21 AM Changeset in webkit [37606] by timothy@apple.com

• 3 edits in trunk/WebKit/mac

Clean up user agent generation to simplify the _standardUserAgentWithApplicationName:
class method to not require a WebKit version.

Reviewed by Darin Adler.

• WebView/WebView.mm: (+[WebView _standardUserAgentWithApplicationName:]): Create the WebKit version. (-[WebView WebCore::_userAgentForURL:]): Use the simplified _standardUserAgentWithApplicationName:. Remove code that created the WebKit version.
• WebView/WebViewPrivate.h: Change the method name of _standardUserAgentWithApplicationName:.

10:02 AM Changeset in webkit [37605] by Darin Adler

• 15 edits in trunk/WebCore

2008-10-15 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Eric Seidel.

• part of ​https://bugs.webkit.org/show_bug.cgi?id=20543 Moved gradient spread method out of SVG into the GraphicsContext.

• platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::spreadMethod): (WebCore::GraphicsContext::setSpreadMethod):
• platform/graphics/GraphicsContext.h: (WebCore::):
• platform/graphics/GraphicsContextPrivate.h:
• platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::applySpreadMethod): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
• platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::applySpreadMethod): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
• svg/GradientAttributes.h: (WebCore::GradientAttributes::GradientAttributes): (WebCore::GradientAttributes::spreadMethod): (WebCore::GradientAttributes::setSpreadMethod):
• svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::parseMappedAttribute):
• svg/SVGGradientElement.h:
• svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::collectGradientProperties):
• svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::collectGradientProperties):
• svg/graphics/SVGPaintServerGradient.cpp: (WebCore::operator<<): (WebCore::SVGPaintServerGradient::SVGPaintServerGradient): (WebCore::SVGPaintServerGradient::spreadMethod): (WebCore::SVGPaintServerGradient::setGradientSpreadMethod): (WebCore::SVGPaintServerGradient::externalRepresentation):
• svg/graphics/SVGPaintServerGradient.h:
• svg/graphics/cairo/SVGPaintServerGradientCairo.cpp: (WebCore::SVGPaintServerGradient::setup):
• svg/graphics/qt/SVGPaintServerGradientQt.cpp: (WebCore::SVGPaintServerGradient::setup):

9:42 AM Changeset in webkit [37604] by Darin Adler

• 2 edits in trunk/JavaScriptCore

2008-10-15 Joerg Bornemann <​joerg.bornemann@trolltech.com>

Reviewed by Darin Adler.

• part of ​https://bugs.webkit.org/show_bug.cgi?id=20746 Fix compilation on Windows CE.

str(n)icmp, strdup and vsnprintf are not available on Windows CE,
they are called _str(n)icmp, etc. instead

• wtf/StringExtras.h: Added inline function implementations.

9:34 AM Changeset in webkit [37603] by jchaffraix@webkit.org

• 7 edits
  4 copies in branches/XBL2/WebCore

2008-10-15 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by David Hyatt.

Bug 20490: [XBL] XBLBinding should be split into several classes

• Distribute XBLBinding's methods and attributes between 2 new classes:

• XBLBindingPrototype: holds and manages the binding element.

• XBLDocumentPrototype: loads and stores the binding document.

• Make the 2 new classes RefCounted as they should be shared between multiple bindings.

No functional changes, thus no test cases.

• GNUmakefile.am: Add the 2 new files to compile.
• WebCore.pro: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• xbl/XBLBinding.cpp: (WebCore::XBLBinding::XBLBinding): Take an XBLBindingPrototype. (WebCore::XBLBinding::~XBLBinding): Zero the XBLBindingPrototype. (WebCore::XBLBinding::uri):
• xbl/XBLBinding.h:
• xbl/XBLBindingManager.cpp: (WebCore::XBLBindingManager::addBinding):
• xbl/XBLBindingPrototype.cpp: Copied from WebCore/xbl/XBLBinding.cpp. (WebCore::XBLBindingPrototype::XBLBindingPrototype): (WebCore::XBLBindingPrototype::~XBLBindingPrototype): (WebCore::XBLBindingPrototype::updateBindingElement): Renamed getBindingElement to updateBindingElement.

• xbl/XBLBindingPrototype.h: Copied from WebCore/xbl/XBLBinding.h. (WebCore::XBLBindingPrototype::create):
• xbl/XBLDocumentPrototype.cpp: Copied from WebCore/xbl/XBLBinding.cpp. (WebCore::XBLDocumentPrototype::XBLDocumentPrototype): (WebCore::XBLDocumentPrototype::~XBLDocumentPrototype): (WebCore::XBLDocumentPrototype::setXBLDocument):
• xbl/XBLDocumentPrototype.h: Copied from WebCore/xbl/XBLBinding.h. (WebCore::XBLDocumentPrototype::create): (WebCore::XBLDocumentPrototype::bindingDocument):

2:35 AM Changeset in webkit [37602] by cwzwarich@webkit.org

• 2 edits in trunk/JavaScriptCore

2008-10-15 Gabor Loki <​loki@inf.u-szeged.hu>

Reviewed by Cameron Zwarich.

<​https://bugs.webkit.org/show_bug.cgi?id=20912>
Use simple uint32_t multiplication on op_mul if both operands are
immediate number and they are between zero and 0x7FFF.

• VM/Machine.cpp: (JSC::Machine::privateExecute):

Oct 14, 2008:

10:22 PM Changeset in webkit [37601] by darin@chromium.org

• 2 edits in trunk/WebCore

2008-10-09 Darin Fisher <​darin@chromium.org>

Reviewed by Sam Weinig.

Make pan scrolling a platform configurable option
​https://bugs.webkit.org/show_bug.cgi?id=21515

• page/EventHandler.cpp: (WebCore::EventHandler::handleAutoscroll): (WebCore::EventHandler::autoscrollTimerFired): (WebCore::EventHandler::stopAutoscrollTimer): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::keyEvent):

10:21 PM Changeset in webkit [37600] by darin@chromium.org

• 2 edits in trunk/JavaScriptCore

2008-10-09 Darin Fisher <​darin@chromium.org>

Reviewed by Sam Weinig.

Make pan scrolling a platform configurable option.
​https://bugs.webkit.org/show_bug.cgi?id=21515

• wtf/Platform.h: Add ENABLE_PAN_SCROLLING

10:15 PM Changeset in webkit [37599] by darin@chromium.org

• 17 edits in trunk/WebCore

2008-10-10 Darin Fisher <​darin@chromium.org>

Reviewed by Darin Adler.

Add some PLATFORM(CHROMIUM) ifdefs to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=21511

• loader/FTPDirectoryDocument.cpp:
• loader/FTPDirectoryParser.cpp:
• loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument):
• platform/ContextMenuItem.h:
• platform/Cursor.h:
• platform/DragData.h:
• platform/DragImage.h:
• platform/Pasteboard.h:
• platform/PlatformKeyboardEvent.h: (WebCore::PlatformKeyboardEvent::isSystemKey):
• platform/PlatformMenuDescription.h:
• platform/PlatformMouseEvent.h:
• platform/PlatformWheelEvent.h:
• platform/PopupMenu.h:
• platform/ScrollView.h:
• platform/Widget.h:
• platform/network/NetworkStateNotifier.h:

8:41 PM Changeset in webkit [37598] by timothy@apple.com

• 3 edits in trunk/WebKit/mac

Make the user agent generation method a class method and cache the WebKit
version in a static to prevent generating it every time. This is needed
clean up to fix <rdar://problem/6292331>. Moved all code to WebPrivate so
the class method can be in the WebViewPrivate.h header.

Reviewed by John Sullivan.

• WebView/WebView.mm: (callGestalt): Moved. Same code. (createMacOSXVersionString): Moved. Same code. (createUserVisibleWebKitVersionString): Moved from _userVisibleBundleVersionFromFullVersion: and returns a copied string. (+[WebView _standardUserAgentWithApplicationName:andWebKitVersion:]): Made into a class method. (-[WebView WebCore::_userAgentForURL:]): Changed to cache the WebKit version.
• WebView/WebViewPrivate.h: Added +_standardUserAgentWithApplicationName:andWebKitVersion:.

7:39 PM Changeset in webkit [37597] by mjs@apple.com

• 9 edits in trunk/JavaScriptCore

2008-10-14 Maciej Stachowiak <​mjs@apple.com>

Rubber stamped by Sam Weinig.

• revert r37572 and r37581 for now

Turns out GCC 4.2 is still a (small) regression, we'll have to do
more work to turn it on.

• Configurations/DebugRelease.xcconfig:
• JavaScriptCore.xcodeproj/project.pbxproj:
• VM/CTI.cpp:
• VM/CTI.h:
• VM/Machine.cpp: (JSC::Machine::cti_op_convert_this): (JSC::Machine::cti_op_end): (JSC::Machine::cti_op_add): (JSC::Machine::cti_op_pre_inc): (JSC::Machine::cti_timeout_check): (JSC::Machine::cti_register_file_check): (JSC::Machine::cti_op_loop_if_less): (JSC::Machine::cti_op_loop_if_lesseq): (JSC::Machine::cti_op_new_object): (JSC::Machine::cti_op_put_by_id): (JSC::Machine::cti_op_put_by_id_second): (JSC::Machine::cti_op_put_by_id_generic): (JSC::Machine::cti_op_put_by_id_fail): (JSC::Machine::cti_op_get_by_id): (JSC::Machine::cti_op_get_by_id_second): (JSC::Machine::cti_op_get_by_id_generic): (JSC::Machine::cti_op_get_by_id_fail): (JSC::Machine::cti_op_instanceof): (JSC::Machine::cti_op_del_by_id): (JSC::Machine::cti_op_mul): (JSC::Machine::cti_op_new_func): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_vm_compile): (JSC::Machine::cti_op_push_activation): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_create_arguments): (JSC::Machine::cti_op_tear_off_activation): (JSC::Machine::cti_op_tear_off_arguments): (JSC::Machine::cti_op_ret_profiler): (JSC::Machine::cti_op_ret_scopeChain): (JSC::Machine::cti_op_new_array): (JSC::Machine::cti_op_resolve): (JSC::Machine::cti_op_construct_JSConstruct): (JSC::Machine::cti_op_construct_NotJSConstruct): (JSC::Machine::cti_op_get_by_val): (JSC::Machine::cti_op_resolve_func): (JSC::Machine::cti_op_sub): (JSC::Machine::cti_op_put_by_val): (JSC::Machine::cti_op_put_by_val_array): (JSC::Machine::cti_op_lesseq): (JSC::Machine::cti_op_loop_if_true): (JSC::Machine::cti_op_negate): (JSC::Machine::cti_op_resolve_base): (JSC::Machine::cti_op_resolve_skip): (JSC::Machine::cti_op_resolve_global): (JSC::Machine::cti_op_div): (JSC::Machine::cti_op_pre_dec): (JSC::Machine::cti_op_jless): (JSC::Machine::cti_op_not): (JSC::Machine::cti_op_jtrue): (JSC::Machine::cti_op_post_inc): (JSC::Machine::cti_op_eq): (JSC::Machine::cti_op_lshift): (JSC::Machine::cti_op_bitand): (JSC::Machine::cti_op_rshift): (JSC::Machine::cti_op_bitnot): (JSC::Machine::cti_op_resolve_with_base): (JSC::Machine::cti_op_new_func_exp): (JSC::Machine::cti_op_mod): (JSC::Machine::cti_op_less): (JSC::Machine::cti_op_neq): (JSC::Machine::cti_op_post_dec): (JSC::Machine::cti_op_urshift): (JSC::Machine::cti_op_bitxor): (JSC::Machine::cti_op_new_regexp): (JSC::Machine::cti_op_bitor): (JSC::Machine::cti_op_call_eval): (JSC::Machine::cti_op_throw): (JSC::Machine::cti_op_get_pnames): (JSC::Machine::cti_op_next_pname): (JSC::Machine::cti_op_push_scope): (JSC::Machine::cti_op_pop_scope): (JSC::Machine::cti_op_typeof): (JSC::Machine::cti_op_is_undefined): (JSC::Machine::cti_op_is_boolean): (JSC::Machine::cti_op_is_number): (JSC::Machine::cti_op_is_string): (JSC::Machine::cti_op_is_object): (JSC::Machine::cti_op_is_function): (JSC::Machine::cti_op_stricteq): (JSC::Machine::cti_op_nstricteq): (JSC::Machine::cti_op_to_jsnumber): (JSC::Machine::cti_op_in): (JSC::Machine::cti_op_push_new_scope): (JSC::Machine::cti_op_jmp_scopes): (JSC::Machine::cti_op_put_by_index): (JSC::Machine::cti_op_switch_imm): (JSC::Machine::cti_op_switch_char): (JSC::Machine::cti_op_switch_string): (JSC::Machine::cti_op_del_by_val): (JSC::Machine::cti_op_put_getter): (JSC::Machine::cti_op_put_setter): (JSC::Machine::cti_op_new_error): (JSC::Machine::cti_op_debug): (JSC::Machine::cti_vm_throw):
• VM/Machine.h:
• masm/X86Assembler.h: (JSC::X86Assembler::emitRestoreArgumentReference): (JSC::X86Assembler::emitRestoreArgumentReferenceForTrampoline):
• wtf/Platform.h:

5:23 PM Changeset in webkit [37596] by sfalken@apple.com

• 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.submit.sln

Build fix. Fix dependency chain in sln file.

3:43 PM Changeset in webkit [37595] by pam@chromium.org

• 1 edit
  2 adds in trunk/LayoutTests

2008-10-14 Pamela Greene <​pam@chromium.org>

Add test to verify popup properties while they're opening.
The expected result is currently not the desired result.
See ​https://bugs.webkit.org/show_bug.cgi?id=21419 and
​https://bugs.webkit.org/show_bug.cgi?id=21597 .

Reviewed by Eric Seidel.

• fast/dom/Window/window-open-pending-url-expected.txt: Added.
• fast/dom/Window/window-open-pending-url.html: Added.

3:16 PM Changeset in webkit [37594] by adachan@apple.com

• 6 edits in trunk/WebKitTools

Fix windows build.

Reviewed by Sam Weinig.

• DumpRenderTree/cg/PixelDumpSupportCG.cpp:
• DumpRenderTree/config.h:
• DumpRenderTree/win/DumpRenderTreeWin.h:
• DumpRenderTree/win/LayoutTestControllerWin.cpp:
• DumpRenderTree/win/UIDelegate.cpp:

3:11 PM Changeset in webkit [37593] by Adam Roben

• 2 edits in trunk/BugsSite

Fix Bug 21602: Bugzilla times out trying to display formatted diff for attachment 24345

​https://bugs.webkit.org/show_bug.cgi?id=21602

Reviewed by Dave Kilzer.

• PrettyPatch/PrettyPatch.rb: (PrettyPatch.BINARY_FILE_MARKER_FORMAT): Added. (PrettyPatch.FileDiff.initialize): If any of the lines in the diff are a binary file marker, mark this FileDiff as binary and stop trying to process the lines. (PrettyDiff.FileDiff.to_html): If we're binary, just print a string saying so.

2:31 PM Changeset in webkit [37592] by cmarrin@apple.com

• 3 edits
  2 adds in trunk

2008-10-14 Chris Marrin <​cmarrin@apple.com>

Reviewed by Darin Adler.

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=21490
Optimize keyframe style sheet changes by avoiding styleSheetChanged()

Test: css3/change-keyframes.html

• css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::append): (WebCore::WebKitCSSKeyframesRule::deleteRule):

1:35 PM Changeset in webkit [37591] by hyatt@apple.com

• 5 edits
  273 adds in trunk

WebCore:

2008-10-14 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21595

Clean up background and overflow propagation from the body to the viewport. Make it match the
latest CSS2.1 spec thinking.

Reviewed by Adam Roben

Added many tests at fast/body-propagation/. These are Simon Pieters' tests of propagation handling
(available at ​http://simon.html5.org/test/css/magic-body/).

• dom/Document.cpp: (WebCore::Document::body):
• page/FrameView.cpp: (WebCore::FrameView::layout):
• rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange): (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::repaintLayerRectsForImage):

LayoutTests:

2008-10-14 David Hyatt <​hyatt@apple.com>

Add layout tests for body propagation of overflow and background to the viewport.

Reviewed by Adam Roben

• fast/body-propagation: Added.
• fast/body-propagation/background-color: Added.
• fast/body-propagation/background-color/001-xhtml.xhtml: Added.
• fast/body-propagation/background-color/001.html: Added.
• fast/body-propagation/background-color/002-xhtml.xhtml: Added.
• fast/body-propagation/background-color/002.html: Added.
• fast/body-propagation/background-color/003-declarative.xhtml: Added.
• fast/body-propagation/background-color/003-xhtml.xhtml: Added.
• fast/body-propagation/background-color/003.html: Added.
• fast/body-propagation/background-color/004-declarative.xhtml: Added.
• fast/body-propagation/background-color/004-xhtml.xhtml: Added.
• fast/body-propagation/background-color/004.html: Added.
• fast/body-propagation/background-color/005-declarative.xhtml: Added.
• fast/body-propagation/background-color/005-xhtml.xhtml: Added.
• fast/body-propagation/background-color/005.html: Added.
• fast/body-propagation/background-color/006-declarative.xhtml: Added.
• fast/body-propagation/background-color/006-xhtml.xhtml: Added.
• fast/body-propagation/background-color/006.html: Added.
• fast/body-propagation/background-color/007-declarative.xhtml: Added.
• fast/body-propagation/background-color/007-xhtml.xhtml: Added.
• fast/body-propagation/background-color/007.html: Added.
• fast/body-propagation/background-color/008-xhtml.xhtml: Added.
• fast/body-propagation/background-color/008.html: Added.
• fast/body-propagation/background-image: Added.
• fast/body-propagation/background-image/001-xhtml.xhtml: Added.
• fast/body-propagation/background-image/001.html: Added.
• fast/body-propagation/background-image/002-xhtml.xhtml: Added.
• fast/body-propagation/background-image/002.html: Added.
• fast/body-propagation/background-image/003-declarative.xhtml: Added.
• fast/body-propagation/background-image/003-xhtml.xhtml: Added.
• fast/body-propagation/background-image/003.html: Added.
• fast/body-propagation/background-image/004-declarative.xhtml: Added.
• fast/body-propagation/background-image/004-xhtml.xhtml: Added.
• fast/body-propagation/background-image/004.html: Added.
• fast/body-propagation/background-image/005-declarative.xhtml: Added.
• fast/body-propagation/background-image/005-xhtml.xhtml: Added.
• fast/body-propagation/background-image/005.html: Added.
• fast/body-propagation/background-image/006-declarative.xhtml: Added.
• fast/body-propagation/background-image/006-xhtml.xhtml: Added.
• fast/body-propagation/background-image/006.html: Added.
• fast/body-propagation/background-image/007-declarative.xhtml: Added.
• fast/body-propagation/background-image/007-xhtml.xhtml: Added.
• fast/body-propagation/background-image/007.html: Added.
• fast/body-propagation/background-image/008-xhtml.xhtml: Added.
• fast/body-propagation/background-image/008.html: Added.
• fast/body-propagation/background-image/009-xhtml.xhtml: Added.
• fast/body-propagation/background-image/009.html: Added.
• fast/body-propagation/background-image/010-xhtml.xhtml: Added.
• fast/body-propagation/background-image/010.html: Added.
• fast/body-propagation/background-image/resources: Added.
• fast/body-propagation/background-image/resources/lime.png: Added.
• fast/body-propagation/background-image/resources/red.png: Added.
• fast/body-propagation/background-image/resources/white.png: Added.
• fast/body-propagation/background-image/resources/yellow.png: Added.
• fast/body-propagation/overflow: Added.
• fast/body-propagation/overflow/001-xhtml.xhtml: Added.
• fast/body-propagation/overflow/001.html: Added.
• fast/body-propagation/overflow/002-xhtml.xhtml: Added.
• fast/body-propagation/overflow/002.html: Added.
• fast/body-propagation/overflow/003-declarative.xhtml: Added.
• fast/body-propagation/overflow/003-xhtml.xhtml: Added.
• fast/body-propagation/overflow/003.html: Added.
• fast/body-propagation/overflow/004-declarative.xhtml: Added.
• fast/body-propagation/overflow/004-xhtml.xhtml: Added.
• fast/body-propagation/overflow/004.html: Added.
• fast/body-propagation/overflow/005-declarative.xhtml: Added.
• fast/body-propagation/overflow/005-xhtml.xhtml: Added.
• fast/body-propagation/overflow/005.html: Added.
• fast/body-propagation/overflow/006-declarative.xhtml: Added.
• fast/body-propagation/overflow/006-xhtml.xhtml: Added.
• fast/body-propagation/overflow/006.html: Added.
• fast/body-propagation/overflow/007-declarative.xhtml: Added.
• fast/body-propagation/overflow/007-xhtml.xhtml: Added.
• fast/body-propagation/overflow/007.html: Added.
• platform/mac/fast/body-propagation: Added.
• platform/mac/fast/body-propagation/background-color: Added.
• platform/mac/fast/body-propagation/background-color/001-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-color/001-expected.png: Added.
• platform/mac/fast/body-propagation/background-color/001-expected.txt: Added.
• platform/mac/fast/body-propagation/background-color/001-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-color/001-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/background-color/001-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/background-color/002-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-color/002-expected.png: Added.
• platform/mac/fast/body-propagation/background-color/002-expected.txt: Added.
• platform/mac/fast/body-propagation/background-color/002-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-color/002-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/background-color/002-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/background-color/003-declarative-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-color/003-declarative-expected.png: Added.
• platform/mac/fast/body-propagation/background-color/003-declarative-expected.txt: Added.
• platform/mac/fast/body-propagation/background-color/003-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-color/003-expected.png: Added.
• platform/mac/fast/body-propagation/background-color/003-expected.txt: Added.
• platform/mac/fast/body-propagation/background-color/003-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-color/003-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/background-color/003-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/background-color/004-declarative-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-color/004-declarative-expected.png: Added.
• platform/mac/fast/body-propagation/background-color/004-declarative-expected.txt: Added.
• platform/mac/fast/body-propagation/background-color/004-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-color/004-expected.png: Added.
• platform/mac/fast/body-propagation/background-color/004-expected.txt: Added.
• platform/mac/fast/body-propagation/background-color/004-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-color/004-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/background-color/004-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/background-color/005-declarative-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-color/005-declarative-expected.png: Added.
• platform/mac/fast/body-propagation/background-color/005-declarative-expected.txt: Added.
• platform/mac/fast/body-propagation/background-color/005-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-color/005-expected.png: Added.
• platform/mac/fast/body-propagation/background-color/005-expected.txt: Added.
• platform/mac/fast/body-propagation/background-color/005-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-color/005-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/background-color/005-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/background-color/006-declarative-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-color/006-declarative-expected.png: Added.
• platform/mac/fast/body-propagation/background-color/006-declarative-expected.txt: Added.
• platform/mac/fast/body-propagation/background-color/006-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-color/006-expected.png: Added.
• platform/mac/fast/body-propagation/background-color/006-expected.txt: Added.
• platform/mac/fast/body-propagation/background-color/006-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-color/006-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/background-color/006-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/background-color/007-declarative-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-color/007-declarative-expected.png: Added.
• platform/mac/fast/body-propagation/background-color/007-declarative-expected.txt: Added.
• platform/mac/fast/body-propagation/background-color/007-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-color/007-expected.png: Added.
• platform/mac/fast/body-propagation/background-color/007-expected.txt: Added.
• platform/mac/fast/body-propagation/background-color/007-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-color/007-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/background-color/007-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/background-color/008-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-color/008-expected.png: Added.
• platform/mac/fast/body-propagation/background-color/008-expected.txt: Added.
• platform/mac/fast/body-propagation/background-color/008-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-color/008-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/background-color/008-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image: Added.
• platform/mac/fast/body-propagation/background-image/001-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/001-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/001-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/001-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/001-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/001-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/002-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/002-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/002-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/002-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/002-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/002-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/003-declarative-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/003-declarative-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/003-declarative-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/003-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/003-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/003-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/003-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/003-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/003-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/004-declarative-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/004-declarative-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/004-declarative-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/004-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/004-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/004-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/004-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/004-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/004-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/005-declarative-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/005-declarative-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/005-declarative-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/005-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/005-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/005-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/005-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/005-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/005-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/006-declarative-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/006-declarative-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/006-declarative-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/006-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/006-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/006-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/006-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/006-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/006-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/007-declarative-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/007-declarative-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/007-declarative-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/007-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/007-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/007-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/007-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/007-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/007-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/008-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/008-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/008-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/008-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/008-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/008-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/009-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/009-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/009-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/009-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/009-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/009-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/010-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/010-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/010-expected.txt: Added.
• platform/mac/fast/body-propagation/background-image/010-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/background-image/010-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/background-image/010-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/overflow: Added.
• platform/mac/fast/body-propagation/overflow/001-expected.checksum: Added.
• platform/mac/fast/body-propagation/overflow/001-expected.png: Added.
• platform/mac/fast/body-propagation/overflow/001-expected.txt: Added.
• platform/mac/fast/body-propagation/overflow/001-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/overflow/001-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/overflow/001-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/overflow/002-expected.checksum: Added.
• platform/mac/fast/body-propagation/overflow/002-expected.png: Added.
• platform/mac/fast/body-propagation/overflow/002-expected.txt: Added.
• platform/mac/fast/body-propagation/overflow/002-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/overflow/002-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/overflow/002-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/overflow/003-declarative-expected.checksum: Added.
• platform/mac/fast/body-propagation/overflow/003-declarative-expected.png: Added.
• platform/mac/fast/body-propagation/overflow/003-declarative-expected.txt: Added.
• platform/mac/fast/body-propagation/overflow/003-expected.checksum: Added.
• platform/mac/fast/body-propagation/overflow/003-expected.png: Added.
• platform/mac/fast/body-propagation/overflow/003-expected.txt: Added.
• platform/mac/fast/body-propagation/overflow/003-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/overflow/003-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/overflow/003-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/overflow/004-declarative-expected.checksum: Added.
• platform/mac/fast/body-propagation/overflow/004-declarative-expected.png: Added.
• platform/mac/fast/body-propagation/overflow/004-declarative-expected.txt: Added.
• platform/mac/fast/body-propagation/overflow/004-expected.checksum: Added.
• platform/mac/fast/body-propagation/overflow/004-expected.png: Added.
• platform/mac/fast/body-propagation/overflow/004-expected.txt: Added.
• platform/mac/fast/body-propagation/overflow/004-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/overflow/004-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/overflow/004-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/overflow/005-declarative-expected.checksum: Added.
• platform/mac/fast/body-propagation/overflow/005-declarative-expected.png: Added.
• platform/mac/fast/body-propagation/overflow/005-declarative-expected.txt: Added.
• platform/mac/fast/body-propagation/overflow/005-expected.checksum: Added.
• platform/mac/fast/body-propagation/overflow/005-expected.png: Added.
• platform/mac/fast/body-propagation/overflow/005-expected.txt: Added.
• platform/mac/fast/body-propagation/overflow/005-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/overflow/005-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/overflow/005-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/overflow/006-declarative-expected.checksum: Added.
• platform/mac/fast/body-propagation/overflow/006-declarative-expected.png: Added.
• platform/mac/fast/body-propagation/overflow/006-declarative-expected.txt: Added.
• platform/mac/fast/body-propagation/overflow/006-expected.checksum: Added.
• platform/mac/fast/body-propagation/overflow/006-expected.png: Added.
• platform/mac/fast/body-propagation/overflow/006-expected.txt: Added.
• platform/mac/fast/body-propagation/overflow/006-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/overflow/006-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/overflow/006-xhtml-expected.txt: Added.
• platform/mac/fast/body-propagation/overflow/007-declarative-expected.checksum: Added.
• platform/mac/fast/body-propagation/overflow/007-declarative-expected.png: Added.
• platform/mac/fast/body-propagation/overflow/007-declarative-expected.txt: Added.
• platform/mac/fast/body-propagation/overflow/007-expected.checksum: Added.
• platform/mac/fast/body-propagation/overflow/007-expected.png: Added.
• platform/mac/fast/body-propagation/overflow/007-expected.txt: Added.
• platform/mac/fast/body-propagation/overflow/007-xhtml-expected.checksum: Added.
• platform/mac/fast/body-propagation/overflow/007-xhtml-expected.png: Added.
• platform/mac/fast/body-propagation/overflow/007-xhtml-expected.txt: Added.

12:55 PM Changeset in webkit [37590] by weinig@apple.com

• 16 edits
  9 deletes in trunk

WebCore:

2008-10-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed and landed by Sam Weinig.

Due to change in spec (​http://dev.w3.org/2006/webapi/selectors-api/#namespace),
remove NSResolver code, leaving only checking for selectors that need
NS resolution and throwing a coresponding error.

• WebCore.pro:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• WebCoreSources.bkl:
• bindings/js/JSDocumentCustom.cpp:
• bindings/js/JSDocumentFragmentCustom.cpp:
• bindings/js/JSElementCustom.cpp:
• bindings/js/JSNSResolver.cpp: Removed.
• bindings/js/JSNSResolver.h: Removed.
• dom/Document.idl:
• dom/DocumentFragment.idl:
• dom/Element.idl:
• dom/NSResolver.h: Removed.
• dom/NSResolver.idl: Removed.
• dom/Node.h:
• dom/Node.cpp: (WebCore::forEachTagSelector): (WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()): (WebCore::selectorNeedsNamespaceResolution): (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll):

LayoutTests:

2008-10-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed and landed by Sam Weinig.

Due to change in spec (​http://dev.w3.org/2006/webapi/selectors-api/#namespace),
remove no longer relevant NSResolver tests.

• fast/dom/SelectorAPI/NSResolver-basic-expected.txt: Removed.
• fast/dom/SelectorAPI/NSResolver-basic.xhtml: Removed.
• fast/dom/SelectorAPI/NSResolver-exceptions-expected.txt: Removed.
• fast/dom/SelectorAPI/NSResolver-exceptions.xhtml: Removed.
• fast/dom/SelectorAPI/resources/NSResolver-exceptions.js: Removed.

12:19 PM Changeset in webkit [37589] by Darin Adler

• 5 edits in trunk/WebCore

2008-10-14 Darin Adler <Darin Adler>

Reviewed by Sam Weinig (all but the FormDataListItem rename).

• ​https://bugs.webkit.org/show_bug.cgi?id=21593 Bug 21593: add multiple-file support to HTMLFormElement

• html/FormDataList.cpp: Removed appendFile since it's now inline. Also took incorrect old copyrights off of this file that are left over from when it was split.
• html/FormDataList.h: Ditto. Renamed FormDataListItem to Item and made it a member of FormDataList. Changed it to hold a File object instead of a path. And made its data members private. Changed FormDataList::appendFile accordingly.

• html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): Updated for above changes. Removed the code that special-cases HTMLInputElement, because now the FormDataListItem has everything we need. And if there are multiple files, we'll get multiple list items for them.

• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData): Changed the code for <input type=file> to use File objects instead of path strings and also to append multiple files if the file list has them.

12:17 PM Changeset in webkit [37588] by timothy@apple.com

• 2 edits in trunk/WebKitTools

Make prepare-ChangeLog populate the changed functions for JavaScript files.

​https://bugs.webkit.org/show_bug.cgi?id=21567

Reviewed by David Kilzer.

• Scripts/prepare-ChangeLog: (get_function_line_ranges): Call get_function_line_ranges_for_javascript for files that end with ".js". (get_function_line_ranges_for_javascript): Find functions, anonymous functions and getters/setters.

11:43 AM Changeset in webkit [37587] by Darin Adler

• 26 edits
  1 add in trunk/WebKitTools

2008-10-14 Alp Toker <​alp@nuanti.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=16299
Add a config.h file to DRT

Add a config.h to DumpRenderTree and reduce use of DumpRenderTree.h as
an ad-hoc config header.

• DumpRenderTree/AccessibilityController.cpp:
• DumpRenderTree/AccessibilityUIElement.cpp:
• DumpRenderTree/AccessibilityUIElement.h:
• DumpRenderTree/DumpRenderTree.h:
• DumpRenderTree/GCController.cpp:
• DumpRenderTree/LayoutTestController.cpp:
• DumpRenderTree/WorkQueue.cpp:
• DumpRenderTree/config.h: Added.
• DumpRenderTree/gtk/DumpRenderTree.cpp:
• DumpRenderTree/gtk/GCControllerGtk.cpp:
• DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
• DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
• DumpRenderTree/win/AccessibilityControllerWin.cpp:
• DumpRenderTree/win/AccessibilityUIElementWin.cpp:
• DumpRenderTree/win/DumpRenderTree.cpp:
• DumpRenderTree/win/DumpRenderTreeWin.h:
• DumpRenderTree/win/EditingDelegate.cpp:
• DumpRenderTree/win/EventSender.cpp:
• DumpRenderTree/win/FrameLoadDelegate.cpp:
• DumpRenderTree/win/GCControllerWin.cpp:
• DumpRenderTree/win/MD5.cpp:
• DumpRenderTree/win/PixelDumpSupportWin.cpp:
• DumpRenderTree/win/PolicyDelegate.cpp:
• DumpRenderTree/win/ResourceLoadDelegate.cpp:
• DumpRenderTree/win/WorkQueueItemWin.cpp:
• GNUmakefile.am:

9:22 AM Changeset in webkit [37586] by ap@webkit.org

• 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=20256
Array.push and other standard methods disappear

• kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::~JSGlobalData): Don't use static hash tables even on platforms that don't enable JSC_MULTIPLE_THREADS - these tables reference IdentifierTable, which is always per-GlobalData.

5:50 AM Changeset in webkit [37585] by vestbo@webkit.org

• 2 edits in trunk/WebCore

2008-10-14 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Fix QtWebKit scrollbar painting errors

1:46 AM Changeset in webkit [37584] by vestbo@webkit.org

• 2 edits in trunk/WebKit/qt

2008-10-14 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Clip painter to dirty rect before passing on to WebKit

This was previously done in ScrollViewQt, but after the
refactoring of ScrollView we need to do it in QWebFrame
instead, similar to Safari/Win.

1:43 AM Changeset in webkit [37583] by vestbo@webkit.org

• 2 edits in trunk/WebCore

2008-10-14 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Fix scrollbar arrows for horizontal scrollbars

1:38 AM Changeset in webkit [37582] by vestbo@webkit.org

• 4 edits in trunk/WebCore

2008-10-14 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Use style-painter to draw scrollbars in ScrollbarThemeQt

This has the benefit of setting up the painter properly without
antialiasing and saving and restoring the brush. It also ensures
that we use the style of the QWebView over the QApplication style
if possible.

1:21 AM Changeset in webkit [37581] by mjs@apple.com

• 7 edits in trunk/JavaScriptCore

2008-10-14 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Cameron Zwarich.

• always use CTI_ARGUMENTS and CTI_ARGUMENTS_FASTCALL

This is a small regression for GCC 4.0, but simplifies the code
for future improvements and lets us focus on GCC 4.2+ and MSVC.

• VM/CTI.cpp:
• VM/CTI.h:
• VM/Machine.cpp: (JSC::Machine::cti_op_convert_this): (JSC::Machine::cti_op_end): (JSC::Machine::cti_op_add): (JSC::Machine::cti_op_pre_inc): (JSC::Machine::cti_timeout_check): (JSC::Machine::cti_register_file_check): (JSC::Machine::cti_op_loop_if_less): (JSC::Machine::cti_op_loop_if_lesseq): (JSC::Machine::cti_op_new_object): (JSC::Machine::cti_op_put_by_id): (JSC::Machine::cti_op_put_by_id_second): (JSC::Machine::cti_op_put_by_id_generic): (JSC::Machine::cti_op_put_by_id_fail): (JSC::Machine::cti_op_get_by_id): (JSC::Machine::cti_op_get_by_id_second): (JSC::Machine::cti_op_get_by_id_generic): (JSC::Machine::cti_op_get_by_id_fail): (JSC::Machine::cti_op_instanceof): (JSC::Machine::cti_op_del_by_id): (JSC::Machine::cti_op_mul): (JSC::Machine::cti_op_new_func): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_vm_compile): (JSC::Machine::cti_op_push_activation): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_create_arguments): (JSC::Machine::cti_op_tear_off_activation): (JSC::Machine::cti_op_tear_off_arguments): (JSC::Machine::cti_op_ret_profiler): (JSC::Machine::cti_op_ret_scopeChain): (JSC::Machine::cti_op_new_array): (JSC::Machine::cti_op_resolve): (JSC::Machine::cti_op_construct_JSConstruct): (JSC::Machine::cti_op_construct_NotJSConstruct): (JSC::Machine::cti_op_get_by_val): (JSC::Machine::cti_op_resolve_func): (JSC::Machine::cti_op_sub): (JSC::Machine::cti_op_put_by_val): (JSC::Machine::cti_op_put_by_val_array): (JSC::Machine::cti_op_lesseq): (JSC::Machine::cti_op_loop_if_true): (JSC::Machine::cti_op_negate): (JSC::Machine::cti_op_resolve_base): (JSC::Machine::cti_op_resolve_skip): (JSC::Machine::cti_op_resolve_global): (JSC::Machine::cti_op_div): (JSC::Machine::cti_op_pre_dec): (JSC::Machine::cti_op_jless): (JSC::Machine::cti_op_not): (JSC::Machine::cti_op_jtrue): (JSC::Machine::cti_op_post_inc): (JSC::Machine::cti_op_eq): (JSC::Machine::cti_op_lshift): (JSC::Machine::cti_op_bitand): (JSC::Machine::cti_op_rshift): (JSC::Machine::cti_op_bitnot): (JSC::Machine::cti_op_resolve_with_base): (JSC::Machine::cti_op_new_func_exp): (JSC::Machine::cti_op_mod): (JSC::Machine::cti_op_less): (JSC::Machine::cti_op_neq): (JSC::Machine::cti_op_post_dec): (JSC::Machine::cti_op_urshift): (JSC::Machine::cti_op_bitxor): (JSC::Machine::cti_op_new_regexp): (JSC::Machine::cti_op_bitor): (JSC::Machine::cti_op_call_eval): (JSC::Machine::cti_op_throw): (JSC::Machine::cti_op_get_pnames): (JSC::Machine::cti_op_next_pname): (JSC::Machine::cti_op_push_scope): (JSC::Machine::cti_op_pop_scope): (JSC::Machine::cti_op_typeof): (JSC::Machine::cti_op_is_undefined): (JSC::Machine::cti_op_is_boolean): (JSC::Machine::cti_op_is_number): (JSC::Machine::cti_op_is_string): (JSC::Machine::cti_op_is_object): (JSC::Machine::cti_op_is_function): (JSC::Machine::cti_op_stricteq): (JSC::Machine::cti_op_nstricteq): (JSC::Machine::cti_op_to_jsnumber): (JSC::Machine::cti_op_in): (JSC::Machine::cti_op_push_new_scope): (JSC::Machine::cti_op_jmp_scopes): (JSC::Machine::cti_op_put_by_index): (JSC::Machine::cti_op_switch_imm): (JSC::Machine::cti_op_switch_char): (JSC::Machine::cti_op_switch_string): (JSC::Machine::cti_op_del_by_val): (JSC::Machine::cti_op_put_getter): (JSC::Machine::cti_op_put_setter): (JSC::Machine::cti_op_new_error): (JSC::Machine::cti_op_debug): (JSC::Machine::cti_vm_throw):
• VM/Machine.h:
• masm/X86Assembler.h: (JSC::X86Assembler::emitRestoreArgumentReference): (JSC::X86Assembler::emitRestoreArgumentReferenceForTrampoline):
• wtf/Platform.h:

12:49 AM Changeset in webkit [37580] by jhoneycutt@apple.com

• 3 edits in trunk/WebKit/win

2008-10-14 Jon Honeycutt <​jhoneycutt@apple.com>

Export currentThread.

Rubber-stamped by Dan Bernstein.

• WebKit.vcproj/WebKit.def:
• WebKit.vcproj/WebKit_debug.def:

Oct 13, 2008:

11:45 PM Changeset in webkit [37579] by hyatt@apple.com

• 3 edits in trunk/WebCore

2008-10-13 David Hyatt <​hyatt@apple.com>

Add support for CSS transitions on some SVG properties. This patch is intended to be a guideline
for how to add support for the rest.

Reviewed by Oliver Hunt

• page/animation/AnimationBase.cpp: (WebCore::ensurePropertyMap):
• rendering/style/RenderStyle.h: (WebCore::RenderStyle::fillOpacity): (WebCore::RenderStyle::setFillOpacity): (WebCore::RenderStyle::strokeOpacity): (WebCore::RenderStyle::setStrokeOpacity): (WebCore::RenderStyle::floodOpacity): (WebCore::RenderStyle::setFloodOpacity):

11:29 PM Changeset in webkit [37578] by hyatt@apple.com

• 4 edits in trunk/WebCore

2008-10-13 David Hyatt <​hyatt@apple.com>

<rdar://problem/6289712> REGRESSION(r37432-37490): Scroll bar is not drawn in Bookmark View, Preferences sheets.

Fix for disabled scrollbars not painting in Windows Safari. Make sure that the Windows theme
implements paintTrackBackground so that when the thumb is not present the track still paints.

Reviewed by Oliver Hunt

• platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint):
• platform/win/ScrollbarThemeWin.cpp: (WebCore::ScrollbarThemeWin::paintTrackBackground):
• platform/win/ScrollbarThemeWin.h:

11:12 PM Changeset in webkit [37577] by hyatt@apple.com

• 4 edits in trunk/WebCore

2008-10-13 David Hyatt <​hyatt@apple.com>

Fix over-invalidation of native scrollbars.

Reviewed by Oliver Hunt

• platform/Scrollbar.h: (WebCore::Scrollbar::styleChanged):
• platform/mac/ScrollbarThemeMac.mm: (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
• rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::styleChanged):

10:29 PM Changeset in webkit [37576] by mjs@apple.com

• 3 edits in trunk/JavaScriptCore

2008-10-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Cameron Zwarich.

• make Machine::getArgumentsData an Arguments method and inline it

~2% on v8 raytrace

• VM/Machine.cpp:
• kjs/Arguments.h: (JSC::Machine::getArgumentsData):

9:14 PM Changeset in webkit [37575] by alp@webkit.org

• 4 edits in trunk

2008-10-13 Alp Toker <​alp@nuanti.com>

Fix autotools dist build target by listing recently added header
files only. Not reviewed.

7:28 PM Changeset in webkit [37574] by mrowe@apple.com

• 2 edits in trunk/WebCore

Don't run a SQLite query on every iteration of the sync thread when the query
will touch a large portion of the icon database while performing no useful work.

Reviewed by Brady Eidson.

• loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::writeToDatabase): Don't call checkForDanglingPageURLs unless
we modified the database.
(WebCore::IconDatabase::checkForDanglingPageURLs): Don't do any work in a release build
unless we've been asked to prune any dangling pageURLs that we find.

7:16 PM Changeset in webkit [37573] by alp@webkit.org

• 2 edits in trunk

2008-10-13 Alp Toker <​alp@nuanti.com>

GTK+ build fix: Ensure correct builds when debugging is
enabled/disabled by defining NDEBUG in autotoolsconfig.h as needed.
It's still passed as a compiler flag since some sources (DRT) don't
use config.h yet.

• configure.ac:

6:21 PM Changeset in webkit [37572] by mjs@apple.com

• 9 edits in trunk

JavaScriptCore:

2008-10-13 Maciej Stachowiak <​mjs@apple.com>

Rubber stamped by Mark Rowe.

• fixed <rdar://problem/5806316> JavaScriptCore should not force building with gcc 4.0
• use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default

• Configurations/DebugRelease.xcconfig:
• JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

2008-10-13 Maciej Stachowiak <​mjs@apple.com>

Rubber stamped by Mark Rowe.

• use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default

• Configurations/DebugRelease.xcconfig:

WebCore:

2008-10-13 Maciej Stachowiak <​mjs@apple.com>

Rubber stamped by Mark Rowe.

• use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default

• Configurations/DebugRelease.xcconfig:

WebKit/mac:

2008-10-13 Maciej Stachowiak <​mjs@apple.com>

Rubber stamped by Mark Rowe.

• use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default

• Configurations/DebugRelease.xcconfig:

5:59 PM Changeset in webkit [37571] by hyatt@apple.com

• 7 edits in trunk/WebCore

2008-10-13 David Hyatt <​hyatt@apple.com>

Make dropdown lists on Windows work with CSS custom scrollbars.

Reviewed by Adele

• platform/PopupMenu.h: (WebCore::PopupMenu::scrollbarCornerPresent):
• platform/PopupMenuClient.h:
• platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show):
• rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::createScrollbar):
• rendering/RenderMenuList.h:
• rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createScrollbar):
• rendering/RenderTextControl.h:

5:20 PM Changeset in webkit [37570] by cwzwarich@webkit.org

• 6 edits in trunk/JavaScriptCore

2008-10-13 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 21541: Move RegisterFile growth check to callee
<​https://bugs.webkit.org/show_bug.cgi?id=21541>

Move the RegisterFile growth check to the callee in the common case,
where some of the information is known statically at JIT time. There is
still a check in the caller in the case where the caller provides too
few arguments.

This is a 2.1% speedup on the V8 benchmark, including a 5.1% speedup on
the Richards benchmark, a 4.1% speedup on the DeltaBlue benchmark, and a
1.4% speedup on the Earley-Boyer benchmark. It is also a 0.5% speedup on
SunSpider.

• VM/CTI.cpp: (JSC::CTI::privateCompile):
• VM/Machine.cpp: (JSC::Machine::cti_register_file_check): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_construct_JSConstruct):
• VM/Machine.h:
• VM/RegisterFile.h:
• masm/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::cmpl_mr): (JSC::X86Assembler::emitUnlinkedJg):

4:39 PM Changeset in webkit [37569] by hyatt@apple.com

• 1 edit in trunk/WebKit/win/WebScrollBar.h

Fix Windows build bustage.

4:39 PM Changeset in webkit [37568] by hyatt@apple.com

• 1 edit in trunk/WebCore/platform/PopupMenu.h

Fix Windows build bustage.

3:48 PM Changeset in webkit [37567] by Chris Fleizach

• 14 edits
  2 adds in trunk

<rdar://problem/6271864> Links from image maps not being included in AXLinkUIElements

This also fixes the positions of image map links

3:42 PM Changeset in webkit [37566] by hyatt@apple.com

• 4 edits
  4 adds in trunk

WebCore:

2008-10-13 David Hyatt <​hyatt@apple.com>

Make RenderListBox work with CSS scrollbars. Refactoring this code to support creation/destruction in
the same way RenderLayer does also fixes a bug where the PLT would assert on the next-to-last page (no
idea how to make a test case for that, though, since I couldn't repro without running the whole PLT).

Reviewed by Tim Hatcher

Added scrollbars/listbox-scrollbar-combinations.html

• rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::createScrollbar): (WebCore::RenderListBox::destroyScrollbar): (WebCore::RenderListBox::setHasVerticalScrollbar):
• rendering/RenderListBox.h:

LayoutTests:

2008-10-13 David Hyatt <​hyatt@apple.com>

Add test case for custom CSS listbox scrollbars.

Reviewed by Tim Hatcher

• platform/mac/scrollbars/listbox-scrollbar-combinations-expected.checksum: Added.
• platform/mac/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
• platform/mac/scrollbars/listbox-scrollbar-combinations-expected.txt: Added.
• scrollbars/listbox-scrollbar-combinations.html: Added.

3:25 PM Changeset in webkit [37565] by timothy@apple.com

• 1 edit
  45 adds in trunk/LayoutTests

Adds an complex styled scrollbar test that exercises all pseudo-elements and pseudo-classes.
Also uses positive and negative margins on the scrollbar track and track pieces.
Tests all the combinations of scrollbars for overflow elements, with and without resizers.

Rubber-stamped by Dave Hyatt.

• platform/mac/scrollbars/overflow-scrollbar-combinations-expected.checksum: Added.
• platform/mac/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
• platform/mac/scrollbars/overflow-scrollbar-combinations-expected.txt: Added.
• scrollbars/overflow-scrollbar-combinations.html: Added.
• scrollbars/resources: Added.
• scrollbars/resources/corner-inactive.png: Added.
• scrollbars/resources/corner.png: Added.
• scrollbars/resources/horizontal-button-active.png: Added.
• scrollbars/resources/horizontal-button-background-active.png: Added.
• scrollbars/resources/horizontal-button-background-hover.png: Added.
• scrollbars/resources/horizontal-button-background-inactive.png: Added.
• scrollbars/resources/horizontal-button-background.png: Added.
• scrollbars/resources/horizontal-button-hover.png: Added.
• scrollbars/resources/horizontal-button-inactive.png: Added.
• scrollbars/resources/horizontal-button.png: Added.
• scrollbars/resources/horizontal-decrement-arrow.png: Added.
• scrollbars/resources/horizontal-increment-arrow.png: Added.
• scrollbars/resources/horizontal-thumb-active.png: Added.
• scrollbars/resources/horizontal-thumb-hover.png: Added.
• scrollbars/resources/horizontal-thumb-inactive.png: Added.
• scrollbars/resources/horizontal-thumb.png: Added.
• scrollbars/resources/horizontal-track-active.png: Added.
• scrollbars/resources/horizontal-track-disabled.png: Added.
• scrollbars/resources/horizontal-track-hover.png: Added.
• scrollbars/resources/horizontal-track.png: Added.
• scrollbars/resources/resizer-inactive.png: Added.
• scrollbars/resources/resizer.png: Added.
• scrollbars/resources/vertical-button-active.png: Added.
• scrollbars/resources/vertical-button-background-active.png: Added.
• scrollbars/resources/vertical-button-background-hover.png: Added.
• scrollbars/resources/vertical-button-background-inactive.png: Added.
• scrollbars/resources/vertical-button-background.png: Added.
• scrollbars/resources/vertical-button-hover.png: Added.
• scrollbars/resources/vertical-button-inactive.png: Added.
• scrollbars/resources/vertical-button.png: Added.
• scrollbars/resources/vertical-decrement-arrow.png: Added.
• scrollbars/resources/vertical-increment-arrow.png: Added.
• scrollbars/resources/vertical-thumb-active.png: Added.
• scrollbars/resources/vertical-thumb-hover.png: Added.
• scrollbars/resources/vertical-thumb-inactive.png: Added.
• scrollbars/resources/vertical-thumb.png: Added.
• scrollbars/resources/vertical-track-active.png: Added.
• scrollbars/resources/vertical-track-disabled.png: Added.
• scrollbars/resources/vertical-track-hover.png: Added.
• scrollbars/resources/vertical-track.png: Added.

2:53 PM Changeset in webkit [37564] by hyatt@apple.com

• 3 edits in trunk/WebCore

2008-10-13 David Hyatt <​hyatt@apple.com>

In order to always match the :corner-present pseudo-class properly, delay initial updating of
scrollbar styles until the layer has the scrollbars in its member variables.

Reviewed by Tim Hatcher

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar):
• rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::RenderScrollbar):

2:41 PM Changeset in webkit [37563] by weinig@apple.com

• 8 edits in trunk

JavaScriptCore:

2008-10-13 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=21577
5 false positive StructureID leaks

• Add leak ignore set to StructureID to selectively ignore leaking some StructureIDs.
• Add create method to JSGlolalData to be used when the data will be intentionally leaked and ignore all leaks caused the StructureIDs stored in it.

• JavaScriptCore.exp:
• kjs/JSGlobalData.cpp: (JSC::JSGlobalData::createLeaked):
• kjs/JSGlobalData.h:
• kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::~StructureID): (JSC::StructureID::startIgnoringLeaks): (JSC::StructureID::stopIgnoringLeaks):
• kjs/StructureID.h:

WebCore:

2008-10-13 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=21577
5 false positive StructureID leaks

In WebCore, we intentionally leak the common JSGlobalData which in turn
leaks 5 StructureIDs. Use the new JSGlobalData::createLeaked in order to
ignore the StructureIDs leaked within.

• bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::commonJSGlobalData):

2:23 PM Changeset in webkit [37562] by hyatt@apple.com

• 10 edits in trunk/WebCore

2008-10-13 David Hyatt <​hyatt@apple.com>

Add support for the :corner-present pseudoclass, which enables scrollbar pieces to change their
artwork based on whether there is a scrollbar corner present.

Reviewed by Tim Hatcher

• css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
• css/CSSSelector.h: (WebCore::CSSSelector::):
• css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
• platform/ScrollView.cpp: (WebCore::ScrollView::scrollbarCornerPresent):
• platform/ScrollView.h:
• platform/ScrollbarClient.h:
• rendering/RenderLayer.cpp: (WebCore::cornerRect): (WebCore::scrollCornerRect): (WebCore::resizerCornerRect): (WebCore::RenderLayer::scrollbarCornerPresent): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar):
• rendering/RenderLayer.h: (WebCore::RenderLayer::horizontalScrollbar): (WebCore::RenderLayer::verticalScrollbar):
• rendering/RenderListBox.h: (WebCore::RenderListBox::scrollbarCornerPresent):

1:56 PM Changeset in webkit [37561] by hyatt@apple.com

• 6 edits in trunk/WebCore

2008-10-13 David Hyatt <​hyatt@apple.com>

Make resizers and scrollbar corners respect :window-inactive (one more bug fix and then Tim's master
test case for all this can land).

Reviewed by Tim Hatcher

• css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
• rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::styleChanged): (WebCore::RenderLayer::updateScrollCornerStyle): (WebCore::RenderLayer::updateResizerStyle):
• rendering/RenderLayer.h:
• rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::paint):
• rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::paintIntoRect):

1:21 PM Changeset in webkit [37560] by hyatt@apple.com

• 5 edits in trunk/WebCore

2008-10-13 David Hyatt <​hyatt@apple.com>

Rework resizer and scroll corner painting so that custom resizers and scroll corners will paint
and invalidate properly as images load, etc.

Reviewed by Tim Hatcher

• rendering/RenderLayer.cpp: (WebCore::cornerRect): (WebCore::scrollCornerRect): (WebCore::resizerCornerRect): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::isPointInResizeControl): (WebCore::RenderLayer::hitTestOverflowControls): (WebCore::RenderLayer::styleChanged):
• rendering/RenderLayer.h:
• rendering/RenderObject.h: (WebCore::RenderObject::setRect):
• rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::styleDidChange): (WebCore::RenderScrollbarPart::imageChanged):

11:55 AM Changeset in webkit [37559] by ddkilzer@apple.com

• 2 edits in trunk/WebKitTools

Bug 21457: resolve-ChangeLogs should be able to operate on a git revision range

<​https://bugs.webkit.org/show_bug.cgi?id=21457>

Reviewed by Adam.

• Scripts/resolve-ChangeLogs: Added optional parameter to

-ffix-merged switch to run the script on a revision range.

Updated command-line validation checks.
(findChangeLog): Fixed long-standing bug that should have used
$_[0] instead of $_.
(fixMergedChangeLog): Renamed to fixOneMergedChangeLog($). Updated
to work when called from git filter-branch. It always restores a
copy of the previous revision before reapplying the patch.
(fixMergedChangeLogs): Added. Calls itself through git filter-branch
to re-merge ChangeLog files across a revision range. Removes
.git/refs/original directory on success.

(parseFixMerged): Added. Custom method to parse the -ffix-merged

switch.
(removeChangeLogArguments): Added. Removes items from @ARGV when
they are ChangeLog paths, and return a list of paths. This makes it
easier to validate the command-line.
(resolveChangeLog): Added. Extracted from main code block. Runs
the traditional single-file merge algorithm.
(usageAndExit): Added. Extracted from main code block. Prints
usage statement and exits with error status.

11:31 AM Changeset in webkit [37558] by sfalken@apple.com

• 9 edits in branches/Safari-3-2-branch

WebCore:

2008-10-13 Steve Falkenburg <​sfalken@apple.com>

Roll out r36884.

• platform/graphics/GraphicsContext.h:
• platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::CGContextWithHDC): (WebCore::GraphicsContext::GraphicsContext):

WebKit/win:

2008-10-13 Steve Falkenburg <​sfalken@apple.com>

Roll out r36883, r36884.

Added unimplemented method to IWebViewPrivate (paintDocumentRectToContext) for nightly compatibility
(we need to preserve vtable order).

• Interfaces/IWebViewPrivate.idl:
• WebFrame.cpp: (WebFrame::transitionToCommittedForNewPage): (WebFrame::unmarkAllBadGrammar):
• WebFrame.h:
• WebView.cpp: (WebView::WebView): (WebView::paintIntoBackingStore): (WebView::paintDocumentRectToContext):
• WebView.h:

11:23 AM Changeset in webkit [37557] by sfalken@apple.com

• 2 edits in trunk/WebKit/win

2008-10-13 Steve Falkenburg <​sfalken@apple.com>

Reorder methods to preserve compatibility.

Rubber stamped by Oliver Hunt.

• Interfaces/IWebViewPrivate.idl:

4:44 AM Changeset in webkit [37556] by jmalonzo@webkit.org

• 6 edits
  2 adds in trunk

2008-10-13 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Darin Adler. Landed by Jan Alonzo.

WebKit GTK Port needs a smartpointer to handle g_free (GFreePtr?)
​http://bugs.webkit.org/show_bug.cgi?id=20483

Start the conversion to use GOwnPtr and fix a memory leak.

• platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateErrorCallback):

2008-10-13 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Darin Adler. Landed by Jan Alonzo.

WebKit GTK Port needs a smartpointer to handle g_free (GFreePtr?)
​http://bugs.webkit.org/show_bug.cgi?id=20483

Add a GOwnPtr smart pointer (similar to OwnPtr) to handle memory
allocated by GLib and start the conversion to use it.

• GNUmakefile.am:
• wtf/GOwnPtr.cpp: Added. (WTF::GError): (WTF::GList): (WTF::GCond): (WTF::GMutex): (WTF::GPatternSpec): (WTF::GDir):
• wtf/GOwnPtr.h: Added. (WTF::freeOwnedPtr): (WTF::GOwnPtr::GOwnPtr): (WTF::GOwnPtr::~GOwnPtr): (WTF::GOwnPtr::get): (WTF::GOwnPtr::release): (WTF::GOwnPtr::rawPtr): (WTF::GOwnPtr::set): (WTF::GOwnPtr::clear): (WTF::GOwnPtr::operator*): (WTF::GOwnPtr::operator->): (WTF::GOwnPtr::operator!): (WTF::GOwnPtr::operator UnspecifiedBoolType): (WTF::GOwnPtr::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::getPtr):
• wtf/Threading.h:
• wtf/ThreadingGtk.cpp: (WTF::Mutex::~Mutex): (WTF::Mutex::lock): (WTF::Mutex::tryLock): (WTF::Mutex::unlock): (WTF::ThreadCondition::~ThreadCondition): (WTF::ThreadCondition::wait): (WTF::ThreadCondition::timedWait): (WTF::ThreadCondition::signal): (WTF::ThreadCondition::broadcast):

Oct 12, 2008:

7:43 PM Changeset in webkit [37555] by jhoneycutt@apple.com

• 2 edits in trunk/WebCore

2008-10-12 Jon Honeycutt <​jhoneycutt@apple.com>

Windows build fix.

• loader/TextResourceDecoder.cpp:

7:20 PM Changeset in webkit [37554] by Darin Adler

• 5 edits in trunk/LayoutTests

2008-10-12 Pamela Greene <​pam@chromium.org>

Reviewed by Darin Adler.

• ​https://bugs.webkit.org/show_bug.cgi?id=21523

Add tests to cover more gradient edge cases: missing endpoints, only
endpoints, only one stop.

• fast/canvas/fillrect_gradient.html:
• platform/mac/fast/canvas/fillrect_gradient-expected.checksum:
• platform/mac/fast/canvas/fillrect_gradient-expected.png:
• platform/mac/fast/canvas/fillrect_gradient-expected.txt:

7:16 PM Changeset in webkit [37553] by Darin Adler

• 2 edits in trunk/JavaScriptCore

2008-10-12 Gabriella Toth <​gtoth@inf.u-szeged.hu>

Reviewed by Darin Adler.

• part of ​https://bugs.webkit.org/show_bug.cgi?id=21055 Bug 21055: not invoked functions

• kjs/nodes.cpp: Deleted a function that is not invoked: statementListInitializeVariableAccessStack.

7:13 PM Changeset in webkit [37552] by Darin Adler

• 2 edits in trunk/WebCore

2008-10-12 Darin Fisher <​darin@chromium.org>

Reviewed by Darin Adler.

• fix ​https://bugs.webkit.org/show_bug.cgi?id=21229 Bug 21229: NetworkStateNotifier.h lacks a #include <windows.h> for PLATFORM(WIN)

• platform/network/NetworkStateNotifier.h: Add the #include.

6:41 PM Changeset in webkit [37551] by abarth@webkit.org

• 1 edit in trunk/LayoutTests/ChangeLog

Fix typo in LayoutTests/ChangeLog

6:37 PM Changeset in webkit [37550] by Darin Adler

• 6 edits
  2 adds in trunk/WebCore

2008-10-12 Darin Adler <Darin Adler>

Based on work by Holger Freyther.

• part of ​https://bugs.webkit.org/show_bug.cgi?id=20953 Split WidthIterator into its own source file.

• GNUmakefile.am: Added new source files.
• WebCore.vcproj/WebCore.vcproj: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• WebCoreSources.bkl: Ditto.

• platform/graphics/Font.cpp: Use WidthIterator from its new place.
• platform/graphics/WidthIterator.cpp: Added.
• platform/graphics/WidthIterator.h: Added.

6:29 PM Changeset in webkit [37549] by abarth@webkit.org

• 3 edits in trunk/LayoutTests

2008-10-12 Pamela Greene <​pam@chromium.org>

Fixed 'completed' variable name to match 'running' one.
See ​https://bugs.webkit.org/show_bug.cgi?21506

Reviewed by Darin Adler.
Landed by Adam Barth.

• dom/html/level2/html/HTMLFrameElement09.js:
• dom/html/level2/html/HTMLIFrameElement11.js:

6:26 PM Changeset in webkit [37548] by mrowe@apple.com

• 2 edits in branches/Safari-3-2-branch/JavaScriptCore

Merge r37526.

6:15 PM Changeset in webkit [37547] by abarth@webkit.org

• 2 edits in trunk/LayoutTests

2008-10-12 Pamela Greene <​pam@chromium.org>

Remove a race condition in a test by promoting layoutTestController
calls outside document.write(). Add document.close().
See ​https://bugs.webkit.org/show_bug.cgi?id=21524

Reviewed by Darin Adler.
Landed by Adam Barth.

• fast/encoding/script-in-head.html:

6:15 PM Changeset in webkit [37546] by abarth@webkit.org

• 4 edits
  1 add in trunk/LayoutTests

2008-10-12 Pamela Greene <​pam@chromium.org>

Remove data: URLs to avoid cross-domain security restrictions.
See ​https://bugs.webkit.org/show_bug.cgi?id=21528

Reviewed by Darin Adler.
Landed by Adam Barth.

• fast/events/resources/tabindex-focus-blur-all-frame1.html:
• fast/events/resources/tabindex-focus-blur-all-frame2.html:
• fast/events/resources/tabindex-focus-blur-all-frame3.html: Added.
• fast/events/tabindex-focus-blur-all.html:

6:15 PM Changeset in webkit [37545] by abarth@webkit.org

• 2 edits in trunk/LayoutTests

2008-10-12 Pamela Greene <​pam@chromium.org>

Fix test when removesExtraParentheses == false.
See ​https://bugs.webkit.org/show_bug.cgi?id=21529

Reviewed by Darin Adler.
Landed by Adam Barth.

• fast/js/resources/function-toString-parentheses.js:

6:15 PM Changeset in webkit [37544] by abarth@webkit.org

• 4 edits in trunk/LayoutTests

2008-10-12 Pamela Greene <​pam@chromium.org>

Fix a race condition by waiting for all create functions to be called
before terminating.
See ​https://bugs.webkit.org/show_bug.cgi?id=21531

Reviewed by Darin Adler.
Landed by Adam Barth.

• platform/mac/svg/carto.net/window-expected.checksum:
• platform/mac/svg/carto.net/window-expected.png:
• platform/mac/svg/carto.net/window-expected.txt:
• svg/carto.net/window.svg:

6:14 PM Changeset in webkit [37543] by abarth@webkit.org

• 3 edits in trunk/LayoutTests

2008-10-12 Pamela Greene <​pam@chromium.org>

Remove inadvertent const redefinition, and add specific test for it.
See ​https://bugs.webkit.org/show_bug.cgi?id=21532

Reviewed by Darin Adler.
Landed by Adam Barth.

• fast/js/const-expected.txt:
• fast/js/resources/const.js:

6:14 PM Changeset in webkit [37542] by abarth@webkit.org

• 1 edit
  2 adds in trunk/LayoutTests

2008-10-12 Pamela Greene <​pam@chromium.org>

Add a test for null character data.
See ​https://bugs.webkit.org/show_bug.cgi?id=21535

Reviewed by Darin Adler.
Landed by Adam Barth.

• fast/dom/null-chardata-crash-expected.txt: Added.
• fast/dom/null-chardata-crash.html: Added.

6:13 PM Changeset in webkit [37541] by Darin Adler

• 3 edits in trunk/WebCore

2008-10-12 Tony Chang <​tony@chromium.org>

Reviewed by Sam Weinig.

• ​https://bugs.webkit.org/show_bug.cgi?id=21480 Remove duplicate definitions of MimeClassInfo and PluginInfo.

• plugins/PluginInfoStore.cpp: Added an include.
• plugins/PluginInfoStore.h: Removed struct declarations.

6:07 PM Changeset in webkit [37540] by Darin Adler

• 3 edits in trunk/WebCore

2008-10-12 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

• ​https://bugs.webkit.org/show_bug.cgi?id=21563 Bug 21563: platform Gradient class should not use the CSS parser

• platform/graphics/Gradient.cpp: Removed the overload of addColorStop that accepts a CSS color string. That's handled in the DOM now, not here. (WebCore::Gradient::addColorStop): Use getRGBA instead of having our own copy of it here.
• platform/graphics/Gradient.h: More of the same. Tweak formatting a bit.

5:58 PM Changeset in webkit [37539] by Darin Adler

• 4 edits
  3 adds
  6 deletes in trunk

WebCore:

2008-10-12 Glenn Wilson <​gwilson@google.com>

Reviewed by Darin Adler.

• ​https://bugs.webkit.org/show_bug.cgi?id=20461

Added feature to allow multi-line inputs into text fields.
HTMLInputElement would cut the set text at the first 'system' character,
so it would truncate at the first carriage return or newline.
This fix modifies that behavior to truncate at any non-space system character
but changes \r, \n, and \r\n to a single space.

Tests: editing/pasteboard/paste-multiline-text-input.html

• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::constrainValue):

LayoutTests:

2008-10-12 Glenn Wilson <​gwilson@google.com>

Reviewed by Darin Adler.

• ​https://bugs.webkit.org/show_bug.cgi?id=20461

Added new test to verify that the user can cut and paste multiple lines of text
into a single line text field.

• fast/forms/paste-multiline-text-input-expected.txt: Added.
• fast/forms/paste-multiline-text-input.html: Added.
• fast/forms/input-truncate-newline-expected.txt: Removed.
• fast/forms/input-truncate-newline.html: Removed.

• fast/forms/8250-expected.txt: Added.
• fast/forms/8250.html: Updated test to be text-only and expect new results.
• platform/mac/fast/forms/8250-expected.checksum: Removed.
• platform/mac/fast/forms/8250-expected.png: Removed.
• platform/mac/fast/forms/8250-expected.txt: Removed.
• platform/qt/fast/forms/8250-expected.txt: Removed.

5:25 PM Changeset in webkit [37538] by Darin Adler

• 8 edits
  9 adds in trunk

WebCore:

2008-10-12 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Eric Seidel.

• ​https://bugs.webkit.org/show_bug.cgi?id=20435

Added exception codes to canvas gradients to match current specification.

Tests: fast/canvas/gradient-addColorStop-with-invalid-color.html

fast/canvas/linearGradient-infinite-values.html
fast/canvas/radialGradient-infinite-values.html

• html/CanvasGradient.cpp: (WebCore::CanvasGradient::addColorStop):
• html/CanvasGradient.h:
• html/CanvasGradient.idl:
• html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createLinearGradient): (WebCore::CanvasRenderingContext2D::createRadialGradient):
• html/CanvasRenderingContext2D.h:
• html/CanvasRenderingContext2D.idl:

LayoutTests:

2008-10-12 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Eric Seidel.

• test for ​https://bugs.webkit.org/show_bug.cgi?id=20435

Added new tests to check behavior of canvas gradients to infinite values
or invalid colors.

• fast/canvas/gradient-addColorStop-with-invalid-color-expected.txt: Added.
• fast/canvas/gradient-addColorStop-with-invalid-color.html: Added.
• fast/canvas/linearGradient-infinite-values-expected.txt: Added.
• fast/canvas/linearGradient-infinite-values.html: Added.
• fast/canvas/radialGradient-infinite-values-expected.txt: Added.
• fast/canvas/radialGradient-infinite-values.html: Added.
• fast/canvas/resources/gradient-addColorStop-with-invalid-color.js: Added.
• fast/canvas/resources/linearGradient-infinite-values.js: Added.
• fast/canvas/resources/radialGradient-infinite-values.js: Added.

4:59 PM Changeset in webkit [37537] by Darin Adler

• 3 edits in trunk/WebCore

2008-10-12 Eric Roman <​eroman@chromium.org>

• ​https://bugs.webkit.org/show_bug.cgi?id=20246 Implement RenderThemeWin::systemColor() to match Windows colors.

Reviewed by David Hyatt.

• rendering/RenderThemeWin.cpp: (WebCore::cssValueIdToSysColorIndex): (WebCore::RenderThemeWin::systemColor):
• rendering/RenderThemeWin.h:

4:51 PM Changeset in webkit [37536] by mrowe@apple.com

• 4 edits in branches/Safari-3-2-branch/WebKit/win

Merge r36005.

4:50 PM Changeset in webkit [37535] by Darin Adler

• 2 edits in trunk/WebCore

2008-10-12 Aaron Bockover <​abockover@novell.com>

Reviewed by Alp Toker.

Add version parsing for Flash, and the PluginQuirkDontSetNullWindowHandleOnDestroy
plugin quirk if Flash 10 or newer since at least in b218, setting a NULL window
handler on destroy crashes WebKit <​https://bugs.webkit.org/show_bug.cgi?id=19859>

• plugins/gtk/PluginPackageGtk.cpp:

4:01 PM Changeset in webkit [37534] by Darin Adler

• 2 edits in trunk/WebCore

2008-10-12 Jonathon Jongsma <​jonathon.jongsma@collabora.co.uk>

Reviewed by Oliver Hunt.

• ​https://bugs.webkit.org/show_bug.cgi?id=19331 <rdar://problem/5984433>: Drag and drop of links in edit mode violates assert in MoveSelectionCommand::doApply()

• page/DragController.cpp: (WebCore::DragController::startDrag): When a link is dragged without any text selected (note: for this to work, the EditableLinkBehavior setting must be set to 'live' or 'default') and then dropped into an editable html document it will eventually violate an ASSERT in MoveSelectionCommand that requires that there is a selection. To prevent this, expand the selection to the enclosing anchor tag when the drag begins.

3:53 PM Changeset in webkit [37533] by Darin Adler

• 2 edits in trunk/WebCore

2008-10-12 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

• fix ​https://bugs.webkit.org/show_bug.cgi?id=21557 Bug 21557: REGRESSION: generated-layer-scrollbar-crash.html is crashing

• rendering/RenderObject.cpp: (WebCore::RenderObject::getPseudoStyle): Keep walking up the parent chain until we hit an Element. Nowadays, Node::isElementNode() is just as efficient as RenderObject::isText(), and this guarantees that the node can be cast to Element*, which is done just below. The reason this is hit is that RenderLayer can call getPseudoStyle on a RenderView, which has the document as its element() -- and a document is neither a Text node nor an Element. A loose end is that this seems to mean you can't style the scrollbar corner or the resizer on a RenderView. Hyatt may want to look into that later.

3:51 PM Changeset in webkit [37532] by Darin Adler

• 3 edits in trunk/JavaScriptCore

2008-10-12 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

• wtf/unicode/icu/UnicodeIcu.h: Fixed indentation to match WebKit coding style.
• wtf/unicode/qt4/UnicodeQt4.h: Ditto.

3:49 PM Changeset in webkit [37531] by Darin Adler

• 8 edits
  12 adds in trunk

JavaScriptCore:

2008-10-12 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

• ​https://bugs.webkit.org/show_bug.cgi?id=21556 Bug 21556: non-ASCII digits are allowed in places where only ASCII should be

• wtf/unicode/icu/UnicodeIcu.h: Removed isDigit, digitValue, and isFormatChar.
• wtf/unicode/qt4/UnicodeQt4.h: Ditto.

WebCore:

2008-10-12 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

• ​https://bugs.webkit.org/show_bug.cgi?id=21556 Bug 21556: non-ASCII digits are allowed in places where only ASCII should be

Tests: fast/dom/HTMLFontElement/size-attribute.html

fast/dom/HTMLInputElement/size-attribute.html
fast/dom/HTMLTableElement/cellpadding-attribute.html

• html/HTMLFontElement.cpp: (WebCore::parseFontSizeNumber): Use isASCIIDigit instead of Unicode::isDigit, since non-ASCII digits are not valid here.
• html/HTMLFontElement.h: Tweaked formatting a bit and removed the unneeded destructor declaration.
• platform/text/String.cpp: (WebCore::lengthOfCharactersAsInteger): Use isASCIIDigit instead of Unicode::isDigit, since non-ASCII digits are not valid.

LayoutTests:

2008-10-12 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

• tests for ​https://bugs.webkit.org/show_bug.cgi?id=21556 Bug 21556: non-ASCII digits are allowed in places where only ASCII should be

The fix was in a function used all over the place. I set a breakpoint in the
function and made some regression tests for the first few places it was used.

• fast/dom/HTMLFontElement: Added.
• fast/dom/HTMLFontElement/resources: Added.
• fast/dom/HTMLFontElement/resources/TEMPLATE.html: Added.
• fast/dom/HTMLFontElement/resources/size-attribute.js: Added.
• fast/dom/HTMLFontElement/size-attribute-expected.txt: Added.
• fast/dom/HTMLFontElement/size-attribute.html: Added.
• fast/dom/HTMLInputElement/resources/size-attribute.js: Added.
• fast/dom/HTMLInputElement/size-attribute-expected.txt: Added.
• fast/dom/HTMLInputElement/size-attribute.html: Added.
• fast/dom/HTMLTableElement/cellpadding-attribute-expected.txt: Added.
• fast/dom/HTMLTableElement/cellpadding-attribute.html: Added.
• fast/dom/HTMLTableElement/resources/cellpadding-attribute.js: Added.

3:38 PM Changeset in webkit [37530] by Darin Adler

• 3 edits
  2 adds in trunk

WebCore:

2008-10-12 Jungshik Shin <​jshin@chromium.org>

Reviewed by Darin Adler.

Treat x-user-defined as windows-1252 for html files with meta charset
declaration to be compatible with Indian web sites.
( ​https://bugs.webkit.org/show_bug.cgi?id=18270 )

Test: fast/encoding/charset-xuser-defined.html

• loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::setEncoding):

LayoutTests:

2008-10-12 Jungshik Shin <​jshin@chromium.org>

Reviewed by Darin Adler.

Treat x-user-defined as windows-1252 for html files with meta charset
declaration to be compatible with Indian web sites.
( ​https://bugs.webkit.org/show_bug.cgi?id=18270 )

• fast/encoding/charset-xuser-defined-expected.txt: Added.
• fast/encoding/charset-xuser-defined.html: Added.

3:24 PM Changeset in webkit [37529] by Darin Adler

• 130 edits in trunk/LayoutTests

2008-10-12 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

• ​https://bugs.webkit.org/show_bug.cgi?id=21559 Bug 21559: many SVG tests are slightly different from what make-js-test-wrappers would make

• svg/custom/immutable-properties.html: Updated path to test resources so it does not go up out of and back into LayoutTests.
• svg/custom/svg-modify-currentTranslate.html: Ditto.
• svg/custom/svg-xml-dom-sync.html: Ditto.
• svg/custom/tearoffs-with-tearoffs.html: Ditto.

• svg/dynamic-updates/resources/*.js: Allow the make-js-test-wrappers script to add var successfullyParsed = true; to these files. It's not helpful for the tests, but it's not harmful either.

2:32 PM Changeset in webkit [37528] by weinig@apple.com

• 2 edits in trunk/WebCore

2008-10-12 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Remove unneeded forward declaration.

• platform/graphics/ImageBuffer.h:

1:43 PM Changeset in webkit [37527] by weinig@apple.com

• 14 edits
  1 add in trunk/WebCore

2008-10-12 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=21560
Layering violation: String should not be responsible for creating Lengths

It was a layering violation for String to know haw to parse
into Lengths, LengthArrays, and CoordsArrays.

• GNUmakefile.am:
• WebCore.pro:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• WebCoreSources.bkl:
• html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::parseMappedAttribute):
• html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute):
• platform/text/AtomicString.h: (WebCore::AtomicString::percentage):
• platform/text/PlatformString.h:
• platform/text/String.cpp:
• platform/text/StringImpl.cpp:
• platform/text/StringImpl.h:
• rendering/Length.cpp: Added. (WebCore::parseLength): (WebCore::countCharacter): (WebCore::newCoordsArray): (WebCore::newLengthArray):
• rendering/Length.h: (WebCore::LengthSize::LengthSize):

12:51 PM Changeset in webkit [37526] by andersca@apple.com

• 2 edits in trunk/JavaScriptCore

2008-10-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Make the append method that takes a Vector more strict - it now requires the elements
of the vector to be appended same type as the elements of the Vector they're being appended to.

This would cause problems when dealing with Vectors containing other Vectors.

• wtf/Vector.h: (WTF::::append):

12:34 PM Changeset in webkit [37525] by Darin Adler

• 2 edits in trunk/WebKitTools

2008-10-12 Darin Adler <Darin Adler>

• Scripts/make-js-test-wrappers: Update exceptions list so the script won't overwrite files and mangle tests.

11:23 AM Changeset in webkit [37524] by Darin Adler

• 3 edits
  2 adds in trunk

WebCore:

2008-10-12 Brad Garcia <​bgarcia@google.com>

Reviewed by Darin Adler.

Interpret fractional percentage values for %MultiLength values.
Fix for ​https://bugs.webkit.org/show_bug.cgi?id=3591
Test: fast/frames/frame-length-fractional-percentage.html

• platform/text/StringImpl.cpp: (WebCore::parseLength):

LayoutTests:

2008-10-12 Brad Garcia <​bgarcia@google.com>

Reviewed by Darin Adler.

Testcases for fractional frame lengths.
​https://bugs.webkit.org/show_bug.cgi?id=3591

• fast/frames/frame-length-fractional.html: Added.
• fast/frames/frame-length-fractional-expected.txt: Added.

10:04 AM Changeset in webkit [37523] by timothy@apple.com

• 4 edits in trunk/WebCore

Remember the expanded state of the rules in the Styles pane. So
collapsing a rule will persist across all the elements that have
that same rule. The same applies to Computed Style, so the Computed
Style rule is now collapsed by default. This should help lessen the
confusion on why Computed Style can't be edited (a common confusion.)

​https://bugs.webkit.org/show_bug.cgi?id=21553

Reviewed by Darin Adler.

• inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection): Set the _expanded property directly, instead of using the setter. Expanded is the default, so no work is needed. This prevents calling StylesSidebarPane.collapse before object initialization is complete.
• inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): Check the Preferences object for the expanded state of the StylePropertiesSection. Collapse computed style by default and expand everything else. (WebInspector.StylePropertiesSection): Make a semi unique identifier to be used when remembering expanded state. (WebInspector.StylePropertiesSection.prototype.expand): Set the expanded state to true for this identifier in Preferences.styleRulesExpandedState. Don't remember the state if the dontRememberState property is true. (WebInspector.StylePropertiesSection.prototype.collapse): Set the expanded state to false for this identifier in Preferences.styleRulesExpandedState.
• inspector/front-end/inspector.js: (Preferences.styleRulesExpandedState): Initialize to an empty object.

4:47 AM Changeset in webkit [37522] by jmalonzo@webkit.org

• 2 edits in trunk/WebCore

2008-10-12 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Alp Toker.

[Gtk] Remove libWebCoreJS.la when doing make clean
​https://bugs.webkit.org/show_bug.cgi?id=21544

Remove libWebCoreJS.la when doing a clean target

• GNUmakefile.am: add libWebCoreJS.la to CLEANFILES

Oct 11, 2008:

11:50 PM Changeset in webkit [37521] by alp@webkit.org

• 3 edits in trunk/WebCore

2008-10-11 Alp Toker <​alp@nuanti.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=20592
The focus ring is not shown while navigating on some pages

Fix drawFocusRing() so it doesn't depend on the current graphics
state, thus matching other platforms which already work this way.

This patch provides two code paths: one using straight Cairo and
one specialised for the GTK+ port with a more conventional appearance.

Also change focusRingColor() to return a null color, allowing the
focus ring to pick up the style's current color if it isn't overridden
with CSS.

• platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawFocusRing):
• platform/gtk/TemporaryLinkStubs.cpp: (WebCore::focusRingColor):

10:00 PM Changeset in webkit [37520] by cwzwarich@webkit.org

• 2 edits in trunk/JavaScriptCore

2008-10-11 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Sam Weinig.

Clean up RegExpMatchesArray.h to match our coding style.

• kjs/RegExpMatchesArray.h: (JSC::RegExpMatchesArray::getOwnPropertySlot): (JSC::RegExpMatchesArray::put): (JSC::RegExpMatchesArray::deleteProperty): (JSC::RegExpMatchesArray::getPropertyNames):

9:56 PM Changeset in webkit [37519] by mitz@apple.com

• 2 edits in trunk/WebCore

Rubber-stamped by Sam Weinig.

• change all internal callers to use Cache::evict() instead of remove()

• loader/Cache.cpp: (WebCore::Cache::revalidateResource): (WebCore::Cache::revalidationSucceeded): (WebCore::Cache::pruneDeadResources): (WebCore::Cache::setDisabled):

9:26 PM Changeset in webkit [37518] by hyatt@apple.com

• 2 edits in trunk/WebCore

2008-10-11 David Hyatt <​hyatt@apple.com>

Make sure invalidatePart knows how to invalidate the track and scrollbar backgrounds.

Reviewed by Tim Hatcher

• platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::invalidatePart):

9:20 PM Changeset in webkit [37517] by hyatt@apple.com

• 6 edits in trunk/WebCore

2008-10-11 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21549 (regression in before/after track pieces).

Also fixed resizer positioning problems.

Reviewed by Tim Hatcher

• platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::splitTrack): (WebCore::ScrollbarThemeComposite::trackPosition): (WebCore::ScrollbarThemeComposite::trackLength):
• platform/ScrollbarThemeComposite.h: (WebCore::ScrollbarThemeComposite::constrainTrackRectToTrackPieces):
• rendering/RenderLayer.cpp: (WebCore::scrollCornerRect): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::isPointInResizeControl): (WebCore::RenderLayer::hitTestOverflowControls):
• rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):
• rendering/RenderScrollbarTheme.h:

8:48 PM Changeset in webkit [37516] by mrowe@apple.com

• 1 edit in branches/Safari-3-2-branch/JavaScriptCore/wtf/ASCIICType.h

Merge ASCIICType.h portion of r36244.

8:33 PM Changeset in webkit [37515] by alp@webkit.org

• 3 edits in trunk/WebCore

2008-10-11 Alp Toker <​alp@nuanti.com>

Reviewed by David Hyatt.

Implement release/retain for Widget GTK+.

• platform/Widget.cpp:
• platform/gtk/WidgetGtk.cpp: (WebCore::Widget::~Widget): (WebCore::Widget::releasePlatformWidget): (WebCore::Widget::retainPlatformWidget):

6:38 PM Changeset in webkit [37514] by mrowe@apple.com

• 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog header that was mangled in r37484.

6:31 PM Changeset in webkit [37513] by mrowe@apple.com

• 1 move in trunk/LayoutTests/animations/font-size-using-ems.html-disabled

Disable animations/font-size-using-ems.html as it has been causing the following test, animatinos/generic-from-to.html, to hang since it was added.

4:10 PM Changeset in webkit [37512] by mitz@apple.com

• 4 edits in trunk/WebKitTools

Reviewed by Sam Weinig and Anders Carlsson.

• update Mac DumpRenderTree to use the new WebView SPI for forcing the complex text code path
• add --complex-text support to Windows DumpRenderTree

• DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree):
• DumpRenderTree/win/DumpRenderTree.cpp: (createWebViewAndOffscreenWindow): (main):
• Scripts/run-webkit-tests:

3:53 PM Changeset in webkit [37511] by mitz@apple.com

• 15 edits in trunk

WebCore:

Reviewed by Sam Weinig.

• rename WebCoreSetAlwaysUseATSU to WebCoreSetAlwaysUsesComplexTextCodePath and add a corresponding getter; add the same functions on Windows

• WebCore.base.exp:
• platform/graphics/Font.cpp: (WebCore::Font::setCodePath): (WebCore::codePath): (WebCore::Font::canUseGlyphCache):
• platform/graphics/Font.h:
• platform/mac/WebCoreTextRenderer.h:
• platform/mac/WebCoreTextRenderer.mm: (WebCoreSetAlwaysUsesComplexTextCodePath): (WebCoreAlwaysUsesComplexTextCodePath):
• platform/win/WebCoreTextRenderer.cpp: (WebCore::WebCoreSetAlwaysUsesComplexTextCodePath): (WebCore::WebCoreAlwaysUsesComplexTextCodePath):
• platform/win/WebCoreTextRenderer.h:

WebKit/mac:

Reviewed by Sam Weinig.

• rename _setAlwaysUseATSU to _setAlwaysUsesComplexTextCodePath and update it for the renamed WebCoreTextRenderer method; keep the old method around for clients that use it

• WebView/WebView.mm: (+[WebView _setAlwaysUseATSU:]): (+[WebView _setAlwaysUsesComplexTextCodePath:]):
• WebView/WebViewPrivate.h:

WebKit/win:

Reviewed by Sam Weinig.

• add SPI for forcing the complex text code path to be used for all text

• Interfaces/IWebViewPrivate.idl:
• WebView.cpp: (WebView::setAlwaysUsesComplexTextCodePath): (WebView::alwaysUsesComplexTextCodePath):
• WebView.h:

3:20 PM Changeset in webkit [37510] by weinig@apple.com

• 2 edits in trunk/WebCore

2008-10-11 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Stop leaking the event parameter names. The protected strings were showing up
in the caches window after one use. No measurable performance loss.

• bindings/js/JSEventListener.cpp: (WebCore::eventParameterName):

3:10 PM Changeset in webkit [37509] by weinig@apple.com

• 3 edits in trunk/WebCore

2008-10-11 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Remove unused function getNodeEventListener.

• bindings/js/JSEventListener.cpp:
• bindings/js/JSEventListener.h:

1:58 PM Changeset in webkit [37508] by cwzwarich@webkit.org

• 3 edits in trunk/JavaScriptCore

2008-10-11 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Sam Weinig.

Bug 21525: 55 StructureID leaks on Wikitravel's main page
<​https://bugs.webkit.org/show_bug.cgi?id=21525>

Bug 21533: Simple JavaScript code leaks StructureIDs
<​https://bugs.webkit.org/show_bug.cgi?id=21533>

StructureID::getEnumerablePropertyNames() ends up calling back to itself
via JSObject::getPropertyNames(), which causes the PropertyNameArray to
be cached twice. This leads to a memory leak in almost every use of
JSObject::getPropertyNames() on an object. The fix here is based on a
suggestion of Sam Weinig.

This patch also fixes every StructureID leaks that occurs while running
the Mozilla MemBuster test.

• kjs/PropertyNameArray.h: (JSC::PropertyNameArray::PropertyNameArray): (JSC::PropertyNameArray::setCacheable): (JSC::PropertyNameArray::cacheable):
• kjs/StructureID.cpp: (JSC::StructureID::getEnumerablePropertyNames):

12:50 AM Changeset in webkit [37507] by hyatt@apple.com

• 8 edits in trunk/WebCore

2008-10-11 David Hyatt <​hyatt@apple.com>

Add support for both positive and negative margins to tracks and track pieces.

Reviewed by Tim Hatcher

• platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint): (WebCore::ScrollbarThemeComposite::hitTest): (WebCore::ScrollbarThemeComposite::splitTrack): (WebCore::ScrollbarThemeComposite::trackPieceRects): (WebCore::ScrollbarThemeComposite::trackPosition): (WebCore::ScrollbarThemeComposite::trackLength):
• platform/ScrollbarThemeComposite.h: (WebCore::ScrollbarThemeComposite::adjustTrackPieceRect):
• rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::trackRect): (WebCore::RenderScrollbar::trackPieceRectWithMargins):
• rendering/RenderScrollbar.h:
• rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::computeScrollbarWidth): (WebCore::RenderScrollbarPart::computeScrollbarHeight):
• rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::adjustTrackPieceRect):
• rendering/RenderScrollbarTheme.h: